13 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Fri, 25 Apr 2008 12:37:32 +0000 (12:37 +0000)]
Tor Arne Vestbø <tavestbo@trolltech.com>

Respect antialiasing hint when drawing focus rects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoKavindra Devi Palaraja <kdpalara@trolltech.com>
hausmann@webkit.org [Fri, 25 Apr 2008 12:37:15 +0000 (12:37 +0000)]
Kavindra Devi Palaraja <kdpalara@trolltech.com>

completed documentation for the Detailed Description section for QWebView

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDenis Dzyubenko <denis.dzyubenko@trolltech.com>
hausmann@webkit.org [Fri, 25 Apr 2008 12:37:01 +0000 (12:37 +0000)]
Denis Dzyubenko <denis.dzyubenko@trolltech.com>

Fixed the way QWebHistory works - when you call back(), forward() or goToItem() functions it changes the current item in history *and* loads the corresponding page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Fri, 25 Apr 2008 12:36:47 +0000 (12:36 +0000)]
Tor Arne Vestbø <tavestbo@trolltech.com>

Fix resubmit of HTML forms when initially denied by QWebPage::acceptNavigationRequest().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSimon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Fri, 25 Apr 2008 10:49:50 +0000 (10:49 +0000)]
Simon Hausmann <hausmann@webkit.org>

When pressing backspace in a line edit in a webpage we should not go back to the previous page.

The shortcut for back on Windows is backspace. Implemented shortcut override
handling in QWebView/QWebPage to prevent this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAriya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Fri, 25 Apr 2008 10:49:34 +0000 (10:49 +0000)]
Ariya Hidayat <ariya.hidayat@trolltech.com>

Fix triple-clicking does not work in a web page

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Fri, 25 Apr 2008 10:49:20 +0000 (10:49 +0000)]
Holger Hans Peter Freyther <zecke@selfish.org>

networking: Use Qt::QueuedConnection in QNetworkReplyHandler

    Make sure we leave the networking backend before calling
    into WebCore. Otheriwse we might return to the networking
    backend when it is already deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Fri, 25 Apr 2008 10:49:03 +0000 (10:49 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

When pressing Ctrl-Up the keyboard modifiers could include other modifiers

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Fri, 25 Apr 2008 10:48:49 +0000 (10:48 +0000)]
Tor Arne Vestbø <tavestbo@trolltech.com>

Fix handling of Javascript's confirm() function in QtWebKit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoKavindra Devi Palaraja <kdpalara@trolltech.com>
hausmann@webkit.org [Fri, 25 Apr 2008 10:41:30 +0000 (10:41 +0000)]
Kavindra Devi Palaraja <kdpalara@trolltech.com>

Doc - added a screenshot, flowchart, and a snippet to the QWebView documentation to improve clarity

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Fri, 25 Apr 2008 10:32:44 +0000 (10:32 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

QWebPage: missing signal when window.print() is requested from javascript

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Fri, 25 Apr 2008 10:32:27 +0000 (10:32 +0000)]
Tor Arne Vestbø <tavestbo@trolltech.com>

Fix propagation of mouse double click events.

Treat a mouse double click as a regular mouse press with just a different click count.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Fri, 25 Apr 2008 10:32:12 +0000 (10:32 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Fixes: "Save Image" action wasn't doing anything.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Fri, 25 Apr 2008 10:31:58 +0000 (10:31 +0000)]
Tor Arne Vestbø <tavestbo@trolltech.com>

Fixes: Fix strange button sizes (push, radio, and check) in QtWebKit.

We now use pixel metrics instead of fixed sizes for the
button margins, or if the style supports layout rects we
use the delta between the content rect and the layout rect.

In adition we compensate for the difference between the size
for content and the actual layout rect (if supported) by
reporting back the layout rect to WebKit for page layout,
and then inflating the rect we actually paint to.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Fri, 25 Apr 2008 10:31:40 +0000 (10:31 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Apply key event changes to the current frame, not the main frame.

Example: hitting space bar should scroll current frame, not the main frame
which doesn't even have a scrollbar.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Fri, 25 Apr 2008 10:00:08 +0000 (10:00 +0000)]
Benjamin Meyer  <bmeyer@trolltech.com>

Fixes: QWebFrame crash when fetching the icon

Just call QWebSettings::iconForUrl to not duplicate code and obey the mutex lock.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Fri, 25 Apr 2008 09:59:56 +0000 (09:59 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Fixes: Valgrind warnings about uninitilized variables used in jumps

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWarwick Allison <warwick@trolltech.com>
hausmann@webkit.org [Fri, 25 Apr 2008 09:59:40 +0000 (09:59 +0000)]
Warwick Allison <warwick@trolltech.com>

Fixes: Scrollbars did not report correct maximum.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Fri, 25 Apr 2008 09:59:10 +0000 (09:59 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Implement NoDrop, ZoomIn, and ZoomOut cursors

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Fri, 25 Apr 2008 09:01:33 +0000 (09:01 +0000)]
Holger Hans Peter Freyther <zecke@selfish.org>

Handle the ListboxAppearance as 'TextField' as well. We are mainly interested in the background.

RenderBox will call us to paint the outline/background, it is handled the same as a
TextAreaAppearance in RenderTheme, handle it the same in the RenderThemeQt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Fri, 25 Apr 2008 09:01:16 +0000 (09:01 +0000)]
Holger Hans Peter Freyther <zecke@selfish.org>

No reason to exit the application when we can not paint something. Replace the Q_ASSERT
with a runtime check. Return true to indicate that we did not handle the painting
of this element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Fri, 25 Apr 2008 09:01:00 +0000 (09:01 +0000)]
Holger Hans Peter Freyther <zecke@selfish.org>

Correct the comment. We are in painTextField and don't paint a button.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Fri, 25 Apr 2008 09:00:43 +0000 (09:00 +0000)]
Holger Hans Peter Freyther <zecke@selfish.org>

Allow ListboxAppearance to take focus as well. Stolen from Tor Arne

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Fri, 25 Apr 2008 09:00:26 +0000 (09:00 +0000)]
Holger Hans Peter Freyther  <zecke@selfish.org>

Do not execute most of the http tests as they hang or crash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSimon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Fri, 25 Apr 2008 09:00:09 +0000 (09:00 +0000)]
Simon Hausmann <hausmann@webkit.org>

Remove debug output.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDavid Boddie <dboddie@trolltech.com>
hausmann@webkit.org [Fri, 25 Apr 2008 08:10:26 +0000 (08:10 +0000)]
David Boddie <dboddie@trolltech.com>

Documentation updates for some of the QWeb classes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Fri, 25 Apr 2008 07:53:18 +0000 (07:53 +0000)]
Holger Hans Peter Freyther <zecke@selfish.org>

Implement dumping of resource load callbacks to pass http/tests/xmlhttprequest/abort-should-cancel-load.html

Similar to Editing and Frameloading we do the dumping within WebCore

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Fri, 25 Apr 2008 07:52:56 +0000 (07:52 +0000)]
Holger Hans Peter Freyther <zecke@selfish.org>

Change the string to match the mac and pass http/tests/misc/isindex-formdata.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSimon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Fri, 25 Apr 2008 07:52:37 +0000 (07:52 +0000)]
Simon Hausmann <hausmann@webkit.org>

When we encounter a new/unknown HTTP request type report it back to WebCore as loading error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Fri, 25 Apr 2008 07:44:10 +0000 (07:44 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Fix crash in the networking layer.

Set the m_reply to null right after calling deleteLater().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-24 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 25 Apr 2008 06:42:23 +0000 (06:42 +0000)]
2008-04-24  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Oliver Hunt.

        * WebCore.base.exp: Remove two symbols from the export list that don't need to be exported.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Fri, 25 Apr 2008 04:04:46 +0000 (04:04 +0000)]

        Reviewed by Dave Hyatt.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18722
          <rdar://problem/5888360> REGRESSION (3.1 -> TOT): Webkit Nightly Build crashes when visiting i has a hotdog

        Test: fast/dynamic/float-remove-above-line.html

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren): Avoid adding floats that
        do not intrude into the line to its floats vector. When such floats go
        away, they do not dirty the line (because they do not intersect with it)
        and having it keep them in its floats vector is what caused the crash.


        Reviewed by Dave Hyatt.

        - test for https://bugs.webkit.org/show_bug.cgi?id=18722
          <rdar://problem/5888360> REGRESSION (3.1 -> TOT): Webkit Nightly Build crashes when visiting i has a hotdog

        * fast/dynamic/float-remove-above-line-expected.txt: Added.
        * fast/dynamic/float-remove-above-line.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-24 Justin Garcia <justin.garcia@apple.com>
justin.garcia@apple.com [Fri, 25 Apr 2008 02:04:15 +0000 (02:04 +0000)]
2008-04-24  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John Sullivan.

        It is possible, despite our safeguards, for createMarkup to iterate past the end of the Range
        that is passed to it.  Added a null check to prevent crashes in this situation (we won't crash but
        we will create too much markup), and added an ASSERT to hopefully catch the scenario in a debugger
        and help us understand what's going on.

        * editing/markup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove code for calculating the glyph cache size.
mrowe@apple.com [Fri, 25 Apr 2008 01:29:28 +0000 (01:29 +0000)]
Remove code for calculating the glyph cache size.

Reviewed by Sam Weinig.

* WebCore.base.exp: Remove unused symbol.
* platform/graphics/mac/FontCacheMac.mm: Remove code that is unused now that we do not compute the glyph cache size.
* platform/mac/WebCoreSystemInterface.h: Remove unused symbol.
* platform/mac/WebCoreSystemInterface.mm: Ditto.

* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface): Remove unused symbol.

* WebKitSystemInterface.h: Remove unused symbol.
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd a definition of BUILDING_ON_LEOPARD to complement BUILDING_ON_TIGER.
mrowe@apple.com [Fri, 25 Apr 2008 01:29:21 +0000 (01:29 +0000)]
Add a definition of BUILDING_ON_LEOPARD to complement BUILDING_ON_TIGER.

Reviewed by Sam Weinig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-24 Cameron McCormack <cam@mcc.id.au>
mrowe@apple.com [Fri, 25 Apr 2008 00:58:11 +0000 (00:58 +0000)]
2008-04-24  Cameron McCormack  <cam@mcc.id.au>

        Reviewed by Maciej Stachowiak.

        Ensure that changes to rx="" and ry="" attributes on an SVG <rect>
        element cause a relayout.

        Test: svg/dom/SVGRectElement/rect-modify-rx.svg

        * svg/SVGRectElement.cpp:
        (WebCore::SVGRectElement::svgAttributeChanged): Call needsLayout()
        when the attribute is rx or ry.
        (WebCore::SVGRectElement::hasRelativeValues): Return true when the
        attribute is rx or ry, since they also can have relative values.

2008-04-24  Cameron McCormack  <cam@mcc.id.au>

        Reviewed by Maciej Stachowiak.

        Test for:
        Modifying rx="" or ry="" on a <rect> doesn't relayout

        * svg/dom/SVGRectElement: Added.
        * svg/dom/SVGRectElement/rect-modify-rx-expected.txt: Added.
        * svg/dom/SVGRectElement/rect-modify-rx.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-24 Jan Michael Alonzo <jmalonzo@unpluggable.com>
mrowe@apple.com [Fri, 25 Apr 2008 00:50:40 +0000 (00:50 +0000)]
2008-04-24  Jan Michael Alonzo  <jmalonzo@unpluggable.com>

        Reviewed by Maciej Stachowiak.

        Typo and documentation fix for build-webkit

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-24 Adam Barth <hk9565@gmail.com>
mrowe@apple.com [Fri, 25 Apr 2008 00:47:23 +0000 (00:47 +0000)]
2008-04-24  Adam Barth  <hk9565@gmail.com>

        Reviewed by Sam Weinig.

        Update the XMLHttpRequest header black list to match the spec.

        * xml/XMLHttpRequest.cpp:

2008-04-24  Adam Barth  <hk9565@gmail.com>

        Reviewed by Sam Weinig.

        Test that we block headers beginning with "Sec-" as per spec.

        * http/tests/xmlhttprequest/set-dangerous-headers-expected.txt:
        * http/tests/xmlhttprequest/set-dangerous-headers.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-22 Feng Qian <ian.eng.webkit@gmail.com>
mrowe@apple.com [Fri, 25 Apr 2008 00:47:15 +0000 (00:47 +0000)]
2008-04-22  Feng Qian  <ian.eng.webkit@gmail.com>

        Reviewed by Geoff Garen.

        Fix https://bugs.webkit.org/show_bug.cgi?id=18677
        Bug 18677: Synchronous event dispatch confuses the popup blocker into incorrectly blocking chat popups in gmail.com.

        Test: fast/events/nested-window-event.html

        * bindings/js/kjs_events.cpp:
        (WebCore::JSAbstractEventListener::handleEvent): Save and restore the current event around the event dispatch.

2008-04-22  Feng Qian  <ian.eng.webkit@gmail.com>

        Reviewed by Geoff Garen.

        Test for nested event handlers.

        * fast/events/nested-window-event-expected.txt: Added.
        * fast/events/nested-window-event.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-24 Brady Eidson <beidson@apple.com>
beidson@apple.com [Fri, 25 Apr 2008 00:26:00 +0000 (00:26 +0000)]
2008-04-24  Brady Eidson  <beidson@apple.com>

        Reviewed by Teh Mitzpettel

        Make it so PageGroups know what their own name is.

        * WebCore.base.exp:

        * page/Page.cpp:
        * page/Page.h:

        * page/PageGroup.cpp: Move the PageGroupMap into the PageGroup class.
        (WebCore::PageGroup::PageGroup): Added a c'tor that takes the group name as an argument instead of
          the initial Page.
        (WebCore::PageGroup::pageGroup): Handles creating and mapping names to groups
        * page/PageGroup.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebKit/gtk:
mitz@apple.com [Thu, 24 Apr 2008 23:20:16 +0000 (23:20 +0000)]

        - build fix

        * webkit/webkitwebview.cpp:


        - build fix

        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-24 Adele Peterson <adele@apple.com>
adele@apple.com [Thu, 24 Apr 2008 22:56:51 +0000 (22:56 +0000)]
2008-04-24  Adele Peterson  <adele@apple.com>

        Reviewed by Darin.

        Consolidate two versions of pathGetFileName.

        * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): Call FileSystem.h version of pathGetFileName and removed the static helper function.
        * platform/posix/FileSystemPOSIX.cpp: (WebCore::pathGetFileName): Moved general case from HTMLFormElement version here.
          If other platforms relied on that default they should implement this function for their platform specific version of FileSystem.cpp
        * platform/win/FileSystemWin.cpp: (WebCore::pathGetFileName): Moved win implementation from HTMLFormElement here.
        * platform/wx/FileSystemWx.cpp: (WebCore::pathGetFileName): Moved wx implementation from HTMLFormElement here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-24 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 24 Apr 2008 21:49:19 +0000 (21:49 +0000)]
2008-04-24  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        Fix layout test regressions from my earlier preferences/settings tweak.

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:]): Even if we're not posting
          the notification to update the settings, each WebView still needs to register for the
          notification - restore that behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-24 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 24 Apr 2008 21:45:31 +0000 (21:45 +0000)]
2008-04-24  Anders Carlsson  <andersca@apple.com>

        Windows build fix.

        * html/HTMLFormElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd svg mask example.
hyatt@apple.com [Thu, 24 Apr 2008 19:43:09 +0000 (19:43 +0000)]
Add svg mask example.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd svg file of a circle.
hyatt@apple.com [Thu, 24 Apr 2008 19:42:19 +0000 (19:42 +0000)]
Add svg file of a circle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd more files.
hyatt@apple.com [Thu, 24 Apr 2008 19:26:17 +0000 (19:26 +0000)]
Add more files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd kate gradient pic.
hyatt@apple.com [Thu, 24 Apr 2008 19:21:36 +0000 (19:21 +0000)]
Add kate gradient pic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-24 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 24 Apr 2008 19:16:07 +0000 (19:16 +0000)]
2008-04-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Don't call fprintf from the signal handler.

        * DumpRenderTree/mac/DumpRenderTree.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdjust files.
hyatt@apple.com [Thu, 24 Apr 2008 19:16:05 +0000 (19:16 +0000)]
Adjust files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-24 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 24 Apr 2008 19:15:40 +0000 (19:15 +0000)]
2008-04-24  Anders Carlsson  <andersca@apple.com>

        Don't crash when the string is empty.

        * html/HTMLMediaElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd more files.
hyatt@apple.com [Thu, 24 Apr 2008 19:12:57 +0000 (19:12 +0000)]
Add more files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Thu, 24 Apr 2008 19:09:48 +0000 (19:09 +0000)]

        Reviewed by Darin Adler.

        - preparation for https://bugs.webkit.org/show_bug.cgi?id=3729
          <rdar://problem/4036353> REGRESSION: arrow keys move insertion bar backwards in RTL text

        The three main changes in this patch are:

        1) Making all inline boxes know their bidi level, instead of just text
           boxes knowing whether their bidi level is odd or even. This is
           required for the next change.

        2) Replacing RenderObject::inlineBox() with
           Position::getInlineBoxAndOffset() in recognition of the fact that the
           inline box containing the primary caret for a position in a given
           node may belong to a different node's renderer.

        3) Changing RenderObject::caretRect() to take an InlineBox parameter,
           and changing callers to call VisiblePosition::caretRect(), which
           locates the inline box, then calls caretRect() on the renderer for
           that box. This, combined with the previous change, ensures that the
           primary caret is rendered at the right place for positions that
           lie on a directionality boundary.

        Test: platform/mac/editing/input/caret-primary-bidi.html

        * WebCore.base.exp: Added the VisiblePosition(Node*, int, EAffinity)
        constructor and VisiblePosition::caretRect(), and sorted.

        * dom/Position.cpp:
        (WebCore::nextRenderedEditable): Adjusted for the removal of
        (WebCore::previousRenderedEditable): Ditto.
        (WebCore::Position::rendersInDifferentPosition): Ditto.
        (WebCore::Position::getInlineBoxAndOffset): Added. Gets the inline box
        and the offset within that box at which the primary caret for this
        position should render.

        * dom/Position.h:

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::mergeParagraphs): Changed to call
        VisiblePosition::caretRect() instead of calling the RenderObject method.

        * editing/SelectionController.cpp:
        (WebCore::caretY): Ditto.
        (WebCore::SelectionController::xPosForVerticalArrowNavigation): Ditto.
        (WebCore::SelectionController::layout): Ditto.

        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::caretRect): Changed to call
        getInlineBoxAndOffset() to get the correct inline box and call the
        renderer for that box.

        * editing/VisiblePosition.h:
        (WebCore::VisiblePosition::getInlineBoxAndOffset): Added convenience
        methods for getting the inline box and caret offset for a visible
        position, accounting for its affinity.

        * editing/visible_units.cpp:
        (WebCore::rootBoxForLine): Changed to use getInlineBoxAndOffset()
        instead of RenderObject::inlineBox().
        (WebCore::previousLinePosition): Ditto.
        (WebCore::nextLinePosition): Ditto.

        * page/AccessibilityObject.cpp:
        (WebCore::updateAXLineStartForVisiblePosition): Ditto.

        * page/Frame.cpp:
        (WebCore::Frame::firstRectForRange): Ditto.

        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::caretMinOffset): Changed to forward to the
        (WebCore::InlineBox::caretMaxOffset): Ditto.
        * rendering/InlineBox.h: Replaced the m_reversed bit, intended for use
        in InlineTextBox only, with six bits of the bidi level of the box,
        intended for use in all leaf inline boxes.
        (WebCore::InlineBox::InlineBox): Added missing initializer for
        m_dirOverride and initialized the bidi level.
        (WebCore::InlineBox::bidiLevel): Added this accessor.
        (WebCore::InlineBox::setBidiLevel): Ditto.
        (WebCore::InlineBox::direction): Ditto.
        (WebCore::InlineBox::caretLeftmostOffset): Added this convenience
        (WebCore::InlineBox::caretRightmostOffset): Ditto.

        * rendering/InlineTextBox.cpp: Replaced all references to m_reversed
        with checking of direction().

        * rendering/RenderBR.cpp: Removed inlineBox().
        * rendering/RenderBR.h: Ditto.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::caretRect): Changed to take an inline box and
        account for the direction of the box (or the renderer) in positioning
        the caret: in right-to-left boxes, the "before" position is to the right
        while "after" is to the left.
        * rendering/RenderBox.h:

        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::caretRect): Updated the signature.
        * rendering/RenderFlow.h:

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::caretRect): Updated the signature.
        (WebCore::RenderObject::caretMaxOffset): Changed to return the child
        node count (or 1 if there are no children) for replaced elements, such
        as <select>s.
        * rendering/RenderObject.h:

        * rendering/RenderReplaced.cpp: Removed caretMinOffset() and
        caretMaxOffset() because the base class implementation does the right
        thing for replaced objects now.
        * rendering/RenderReplaced.h:

        * rendering/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::caretRect): Updated the signature.
        (WebCore::RenderSVGInlineText::positionForCoordinates): Updated for
        the change from m_reversed to direction().
        * rendering/RenderSVGInlineText.h:

        * rendering/RenderText.cpp:
        (WebCore::RenderText::caretRect): Changed to take an inline box and
        removed the code that used to find the inline for the given position.
        Changed use of m_reversed to use direction().
        (WebCore::RenderText::position): Changed use of m_reversed to use
        * rendering/RenderText.h:

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::textWithHardLineBreaks): Adjusted for the
        removal of RenderObject::inlineBox().

        * rendering/RenderTreeAsText.cpp:
        (WebCore::writeTextRun): Changed to use direction() instead of

        * rendering/SVGInlineTextBox.cpp: Ditto.

        * rendering/SVGRenderTreeAsText.cpp: Ditto.

        * rendering/SVGRootInlineBox.cpp: Ditto.

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::constructLine): Made this function set the
        bidi level on all leaf boxes.

        * svg/SVGTextContentElement.cpp: Changed to use direction() instead of


        Reviewed by Darin Adler.

        - preparation for https://bugs.webkit.org/show_bug.cgi?id=3729
          <rdar://problem/4036353> REGRESSION: arrow keys move insertion bar backwards in RTL text

        * WebView/WebFrame.mm:
        (-[WebFrame _caretRectAtNode:offset:affinity:]): Changed to use
        VisiblePosition::caretRect() instead of the RenderObject method which
        was removed.


        Reviewed by Darin Adler.

        - test the visual position of the primary caret in bidirectional text

        * platform/mac/editing/input/caret-primary-bidi-expected.txt: Added.
        * platform/mac/editing/input/caret-primary-bidi.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoCheck in kate image for blog post.
hyatt@apple.com [Thu, 24 Apr 2008 19:09:07 +0000 (19:09 +0000)]
Check in kate image for blog post.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd blog files for mask post.
hyatt@apple.com [Thu, 24 Apr 2008 19:00:51 +0000 (19:00 +0000)]
Add blog files for mask post.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago../mac:
beidson@apple.com [Thu, 24 Apr 2008 18:57:58 +0000 (18:57 +0000)]

2008-04-24  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        Rework the Settings population again.

        * WebView/WebView.mm:
        (-[WebView _updateSettingsFromPreferences:]): This method is called both from _preferencesChangedNotification
          and directly from WebView's common init function.
        (-[WebView _preferencesChangedNotification:]):
        (-[WebView _commonInitializationWithFrameName:groupName:]): Call _updateSettingsFromPreferences immediately
          after creating the new Page


2008-04-24  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        Revert my previous change to WebKit/Win until I can make it act more like the new Mac code

        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-24 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 24 Apr 2008 18:53:34 +0000 (18:53 +0000)]
2008-04-24  Sam Weinig  <sam@webkit.org>

        Fix the world.

        * bindings/js/kjs_proxy.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd blog images.
hyatt@apple.com [Thu, 24 Apr 2008 18:51:14 +0000 (18:51 +0000)]
Add blog images.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-24 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 24 Apr 2008 18:45:53 +0000 (18:45 +0000)]
2008-04-24  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Add a #define to easily enable collecting on every allocation to aid
        debugging GC bugs.

        * kjs/collector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Thu, 24 Apr 2008 17:54:27 +0000 (17:54 +0000)]

2008-04-24  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        - fix crash in regression test where we'd ask a frame for a user agent string
          after the WebView was already closed

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::scheduleHTTPRedirection): Quietly do nothing if this is
        called on a frame that's already detached from its page.
        (WebCore::FrameLoader::scheduleLocationChange): Ditto.
        (WebCore::FrameLoader::scheduleRefresh): Ditto.
        (WebCore::FrameLoader::scheduleHistoryNavigation): Ditto.
        (WebCore::FrameLoader::redirectionTimerFired): Assert that this is never called
        for a frame that's already detached from its page.
        (WebCore::FrameLoader::scheduleRedirection): Ditto.
        (WebCore::FrameLoader::startRedirectionTimer): Ditto.


2008-04-24  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        - fix crash in regression test where we'd ask a frame for a user agent string
          after the WebView was already closed

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::userAgent): Assert that the WebView is not nil. Also
        added some code to prevent the crash in release builds if this problem happens

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd a new callFunction helper function to remove duplicate code
timothy@apple.com [Thu, 24 Apr 2008 17:50:12 +0000 (17:50 +0000)]
Add a new callFunction helper function to remove duplicate code
for calling JavaScript functions with arguments.

Reviewed by Darin Adler.

* page/InspectorController.cpp:
(WebCore::InspectorController::callSimpleFunction): Call callFunction.
(WebCore::InspectorController::callFunction): Extended version of the original
callSimpleFunction, with script function arguments and an exception argument.
(WebCore::InspectorController::focusNode): Use callFunction.
(WebCore::InspectorController::addScriptResource): Ditto.
(WebCore::InspectorController::removeScriptResource): Ditto.
(WebCore::InspectorController::addDatabaseScriptResource): Ditto.
(WebCore::InspectorController::removeDatabaseScriptResource): Ditto.
(WebCore::InspectorController::addScriptConsoleMessage): Ditto.
* page/InspectorController.h: Add callFunction.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
andersca@apple.com [Thu, 24 Apr 2008 17:45:17 +0000 (17:45 +0000)]

2008-04-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Change some String arguments to be const references instead.

        * css/CSSRule.cpp:
        * css/CSSRule.h:
        * html/HTMLFormElement.cpp:
        * html/HTMLMediaElement.cpp:
        * page/EditorClient.h:
        * platform/SecurityOrigin.cpp:
        * platform/graphics/MediaPlayer.cpp:
        * platform/graphics/MediaPlayer.h:
        * rendering/MediaControlElements.cpp:
        * rendering/MediaControlElements.h:
        * svg/animation/SVGSMILElement.cpp:
        * svg/animation/SVGSMILElement.h:
        * svg/graphics/SVGImageEmptyClients.h:
        * xml/XSLTProcessor.cpp:


2008-04-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Change some String arguments to be const references instead.

        * WebCoreSupport/EditorClientGtk.cpp:
        * WebCoreSupport/EditorClientGtk.h:


2008-04-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Change some String arguments to be const references instead.

        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:


2008-04-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Change some String arguments to be const references instead.

        * WebCoreSupport/EditorClientQt.cpp:
        * WebCoreSupport/EditorClientQt.h:


2008-04-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Change some String arguments to be const references instead.

        * WebCoreSupport/WebEditorClient.cpp:
        * WebCoreSupport/WebEditorClient.h:


2008-04-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Change some String arguments to be const references instead.

        * WebKitSupport/EditorClientWx.cpp:
        * WebKitSupport/EditorClientWx.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
justin.garcia@apple.com [Thu, 24 Apr 2008 17:41:11 +0000 (17:41 +0000)]

2008-04-24  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/5604313> FormatBlock to apply an h1 also inserts a style span around the first letter (16004)

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::advance): We emit an extra newline when leaving a
        block element that has atypical margin/padding. When we emit the extra newline,
        it needs to be positioned after that block's contents, not after the block.
        This is how we position the first newline, too, since the range for emitted newlines
        should start where the line break begins visually.


2008-04-24  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/5604313> FormatBlock leaves first letter incorrectly styled (16004)

        * editing/execCommand/5604313-expected.txt: Added.
        * editing/execCommand/5604313.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-24 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 24 Apr 2008 17:25:01 +0000 (17:25 +0000)]
2008-04-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Only avoid implicit entries when doing the initial caching.

        * loader/appcache/ApplicationCacheGroup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
kmccullough@apple.com [Thu, 24 Apr 2008 17:20:01 +0000 (17:20 +0000)]

2008-04-24  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adam and Sam.

        -<rdar://problem/5770054> JavaScript profiler (10928)
        -Only profile the page group that starts profiling to avoid profiling
        tools that shouldn't be profiled unless explicitly requested to.

        * JavaScriptCore.exp: Export new signature.
        * kjs/JSGlobalObject.cpp: Add unique identifiers to the JSGlobalObject.
        * kjs/JSGlobalObject.h: Ditto.
        * profiler/Profiler.cpp: Check the identifier of the page group of the
        lexical global exec state and only profile if it matches the given page
        group identifier.
        * profiler/Profiler.h: Ditto.


2008-04-24  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adam and Sam.

        -<rdar://problem/5770054> JavaScript profiler (10928)
        -Only profile the page group that starts profiling to avoid profiling
        tools that shouldn't be profiled unless explicitly requested to.

        * bindings/js/kjs_proxy.cpp: When a new global object is created set its
        page group identifier.
        * page/Console.cpp: When calling console.profile set the identifier of
        the page group being profiled.
        * page/PageGroup.cpp: Implement unique identifiers.
        * page/PageGroup.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
sullivan@apple.com [Thu, 24 Apr 2008 16:55:37 +0000 (16:55 +0000)]

2008-04-24  John Sullivan  <sullivan@apple.com>

        Mac buid fix

        * page/mac/WebCoreViewFactory.h:
        add declarations of six new AX methods that were added to LocalizedStrings.h

        * platform/mac/LocalizedStringsMac.mm:
        implement by calling through to WebCoreViewFactory as we do with the other functions here


2008-04-24  John Sullivan  <sullivan@apple.com>

        Mac build fix

        * WebCoreSupport/WebViewFactory.mm:
        (-[WebViewFactory AXButtonActionVerb]):
        implement this method using the text in WebCoreLocalizedStrings.cpp
        (-[WebViewFactory AXRadioButtonActionVerb]):
        (-[WebViewFactory AXTextFieldActionVerb]):
        (-[WebViewFactory AXCheckedCheckBoxActionVerb]):
        (-[WebViewFactory AXUncheckedCheckBoxActionVerb]):
        (-[WebViewFactory AXLinkActionVerb]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago../mac:
beidson@apple.com [Thu, 24 Apr 2008 16:33:20 +0000 (16:33 +0000)]

2008-04-23  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        In some current work I noticed that when a new Page is created, it is possible that it requires info from its Settings
        object before the Settings object is initialized.  It seems quite prudent to post the preferences changed notification,
        thereby populating the Settings object, immediately after the Page is created.

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:]): Post the notification right after the Page is created


2008-04-23  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        In some current work I noticed that when a new Page is created, it is possible that it requires info from its Settings
        object before the Settings object is initialized.  It seems quite prudent to post the preferences changed notification,
        thereby populating the Settings object, immediately after the Page is created.

        * WebView.cpp:
        (WebView::initWithFrame): Post the notification right after the Page is created

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-24 John Sullivan <sullivan@apple.com>
sullivan@apple.com [Thu, 24 Apr 2008 15:23:51 +0000 (15:23 +0000)]
2008-04-24  John Sullivan  <sullivan@apple.com>

        Reviewed by Jess

        - fixed <rdar://problem/5886655> JavaScript input panel automatic resizing doesn't work right with HiDPI

        * Misc/WebNSControlExtras.m:
        (-[NSControl sizeToFitAndAdjustWindowHeight]):
        deploy userSpaceScaleFactor when using view distances on the window

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Thu, 24 Apr 2008 14:07:29 +0000 (14:07 +0000)]
Holger Hans Peter Freyther <zecke@selfish.org>

Cosmetic changes to make the code more readable.
    -Early exit if we don't have a webview
    -handle the empty tooltip and non-empty tooltip case separately

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix text rendering in -reverse mode on Qt/Mac.
hausmann@webkit.org [Thu, 24 Apr 2008 14:07:16 +0000 (14:07 +0000)]
Fix text rendering in -reverse mode on Qt/Mac.

For Font::width() don't use a plain QFontMetrics object but also the properly
setup QTextLayout that has the RTL/LTR force flags set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 14:06:57 +0000 (14:06 +0000)]
Tor Arne Vestbø <tavestbo@trolltech.com>

Don't do anti-aliasing for arcs, lines and rects, but continue to anti-alias
all drawing primitives in the HTML Canvas element.

This speeds up drawing of dashed outlines significantly.

Also preserve the anti-aliasing renderhint for transparency layers and
get rid of the mostly unused device pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoPaul Olav Tvete <paul@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 13:45:27 +0000 (13:45 +0000)]
Paul Olav Tvete <paul@trolltech.com>

Fix various compiler warnings related to QString(const char *)
construction by using QLatin1String.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoPaul Olav Tvete <paul@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 13:44:53 +0000 (13:44 +0000)]
Paul Olav Tvete <paul@trolltech.com>

Automatically wrap tooltip text and hide a shown tooltip when it is empty.

QWidget::setTooltip("") will still show the old tooltip for up to 10 seconds.
Workaround as discussed with Matthias.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMorten Johan Sørvig <msorvig@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 13:30:03 +0000 (13:30 +0000)]
Morten Johan Sørvig <msorvig@trolltech.com>

Work around QMacStyle bug in repainting the vertical scrollbar.

We draw the scrollbar using HITheme but somehow the translation and the
clipping we previously set using ClipCGContextToRegion is ignored. Drawing
without the translation fixes the clip.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Thu, 24 Apr 2008 11:20:39 +0000 (11:20 +0000)]
Holger Hans Peter Freyther <zecke@selfish.org>

Allow to disable caching completeley by calling setObjectCacheCapacities(0, 0, 0)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Thu, 24 Apr 2008 11:20:22 +0000 (11:20 +0000)]
Holger Hans Peter Freyther <zecke@selfish.org>

* Set an expiration date for local files as we do not know what will happen
  to these files (in contrast to a http server with max-age and other headers)
* Remember the time when we started the job and use that for the expiration date
* QNetworkManager does not handle expiration at all, we might want to set the
  expiration for all downloads but this will be a performance nightmare.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix the Gtk and Qt builds.
hausmann@webkit.org [Thu, 24 Apr 2008 11:16:54 +0000 (11:16 +0000)]
Fix the Gtk and Qt builds.

Added missing localization stubs for accessibility.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 10:35:27 +0000 (10:35 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Improve keyboard scrolling

Match Down/Up keys scroll distance with Safari (i.e. faster) and add Home and End shortcuts to scroll to the top/botom.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoOlivier Goffart <ogoffart@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 10:20:51 +0000 (10:20 +0000)]
Olivier Goffart  <ogoffart@trolltech.com>

Fix various compiler warnings in the Qt port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAndre Poenitz <andre.poenitz@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 10:20:14 +0000 (10:20 +0000)]
Andre Poenitz <andre.poenitz@trolltech.com>

Removed spurious QHideEvent forward declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-24 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Thu, 24 Apr 2008 09:01:14 +0000 (09:01 +0000)]
2008-04-24  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Simon.

        Bug 15940: Implement threading API for Qt

        Original patch by Justin Haygood, tweaked by me.

        * JavaScriptCore.pri:
        * wtf/ThreadingQt.cpp: Added.
        (WTF::waitForThreadCompletion): return !res to return
        0 on success (to match the pthreads implementation).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 08:53:44 +0000 (08:53 +0000)]
Tor Arne Vestbø <tavestbo@trolltech.com>

Render text areas using Qt (ensures proper style).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 08:53:27 +0000 (08:53 +0000)]
Tor Arne Vestbø <tavestbo@trolltech.com>

Make mouse wheel events over scrollbars behave the same as in Qt, i.e. both
horizontal and vertical wheel events will scroll the view in the orientation
of the scrollbar underneath the cursor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-23 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 24 Apr 2008 08:25:26 +0000 (08:25 +0000)]
2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Brady.

        Implement accDoDefaultAction().

        * AccessibleBase.cpp:
        (AccessibleBase::accDoDefaultAction): Call the object's
        performDefaultAction() method. Return S_FALSE if the call returns false,
        indicating that the object has no default action associated with it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-23 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 24 Apr 2008 08:24:58 +0000 (08:24 +0000)]
2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Adam.

        Don't allow a hit test to return an AccessibilityObject that should be

        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::doAccessibilityHitTest): If this result
        object's accessibility is ignored, return the parent unignored object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-23 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 24 Apr 2008 08:24:26 +0000 (08:24 +0000)]
2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Adam.

        Fix a crash when performing a hit test on an AccessibilityObject with
        no layer (e.g., an AccessibilityObject for a RenderText object).

        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::doAccessibilityHitTest): Added a null
        check for layer. Removed a null check for m_renderer, which shouldn't

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-23 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 24 Apr 2008 08:23:51 +0000 (08:23 +0000)]
2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Adam.

        Implement accHitTest().

        * AccessibleBase.cpp:
        (AccessibleBase::accHitTest): Perform a hit test for a child object. If
        none is found, report whether the point was within our own bounding box.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-23 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 24 Apr 2008 08:23:12 +0000 (08:23 +0000)]
2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Adam and Darin.

        Implement accNavigate().

        * AccessibleBase.cpp:
        (AccessibleBase::accNavigate): This method navigates between elements,
        given a start point and a direction. The directions UP, DOWN, LEFT,
        RIGHT are not are not implemented, matching Mozilla and IE. The
        directions FIRSTCHILD and LASTCHILD are only allowed from self. NEXT and
        PREVIOUS are allowed from self or any of our children.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-23 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 24 Apr 2008 08:22:28 +0000 (08:22 +0000)]
2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Adam.

        Implement accLocation().

        * AccessibleBase.cpp:
        (AccessibleBase::accLocation): Report the screen coordinates for the
        object's bounding box.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-23 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 24 Apr 2008 08:21:40 +0000 (08:21 +0000)]
2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Adam.

        Implement contentsToScreen() and screenToContents() on Windows.

        * platform/ScrollView.h: Make these declarations conditional on
        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::contentsToScreen): Translate from coordinates
        relative to the ScrollView to coordinates relative to the screen. Do
        this by getting the offset of the ScrollView in screen coordinates and
        moving the rect by this amount.
        (WebCore::ScrollView::screenToContents): Translate from coordinates
        relative to the screen to coordinates relative to the ScrollView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-23 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 24 Apr 2008 08:20:44 +0000 (08:20 +0000)]
2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Adam, Darin, Oliver.

        Implement get_accDefaultAction().

        * AccessibleBase.cpp:
        (AccessibleBase::get_accDefaultAction): Report the result of calling the
        object's actionVerb method.
        * English.lproj/Localizable.strings: Updated with new strings.
        * WebCoreLocalizedStrings.cpp:
        (WebCore::AXButtonActionVerb): Return a localized string representing
        the object's default action.
        (WebCore::AXRadioButtonActionVerb): Same.
        (WebCore::AXTextFieldActionVerb): Same.
        (WebCore::AXCheckedCheckBoxActionVerb): Same
        (WebCore::AXUncheckedCheckBoxActionVerb): Same.
        (WebCore::AXLinkActionVerb): Same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-22 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 24 Apr 2008 08:19:43 +0000 (08:19 +0000)]
2008-04-22  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Adam.

        Implement get_accFocus().

        * AccessibleBase.cpp:
        (AccessibleBase::get_accRole): Remove redundant initialize; VariantInit
        does this.
        (AccessibleBase::get_accState): Same.
        (AccessibleBase::get_accSelection): Relocated next to accSelect().
        (AccessibleBase::get_accFocus): If the focused object is this object or
        a child of this object, report it. Otherwise, report VT_EMPTY.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Alp Toker.
christian@webkit.org [Thu, 24 Apr 2008 08:15:37 +0000 (08:15 +0000)]
Reviewed by Alp Toker.

        Emit a warning about an unknown setting only if it is
        not a valid property. Otherwise applications can't
        subclass WebKitWebSettings to add new properties.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 07:55:22 +0000 (07:55 +0000)]
Tor Arne Vestbø  <tavestbo@trolltech.com>

Cleaned up copyright headers in the Qt port (removed misplaced class
descriptions and fixed inconsistent whitespace and indentation).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 07:44:52 +0000 (07:44 +0000)]
Tor Arne Vestbø <tavestbo@trolltech.com>

Added basic URL guessing to QtLauncher (same as in the demo browser).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 07:44:39 +0000 (07:44 +0000)]
Tor Arne Vestbø <tavestbo@trolltech.com>

Disable vanlilla focus rings since Qt provides this as part of the style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoGeorge Staikos <george@staikos.net>
hausmann@webkit.org [Thu, 24 Apr 2008 07:38:30 +0000 (07:38 +0000)]
George Staikos <george@staikos.net>

This optimization in BitmapImage::drawPattern for the identity
transform is bogus and causes incorrect results on sites like youtube.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 07:31:31 +0000 (07:31 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Prevent double deletions of the default web interface.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by Dave Hyatt.
mitz@apple.com [Thu, 24 Apr 2008 04:29:49 +0000 (04:29 +0000)]
    Rubber-stamped by Dave Hyatt.

        - update computed style results for border-image and mask-image

        * fast/css/computed-style-expected.txt:
        * fast/css/computed-style-without-renderer-expected.txt:
        * svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Alp Toker.
kevino@webkit.org [Thu, 24 Apr 2008 03:55:16 +0000 (03:55 +0000)]
Reviewed by Alp Toker.

Typo fix to restore text entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32455 268f45cc-cd09-0410-ab3c-d52691b4dbfc