WebKit-https.git
9 years agoAdd partial load tests for PNG images
noel.gordon@gmail.com [Wed, 19 Sep 2012 03:08:37 +0000 (03:08 +0000)]
Add partial load tests for PNG images
https://bugs.webkit.org/show_bug.cgi?id=95707

Reviewed by Adam Barth.

Partial load test: receive a partial number of image bytes and stall forever. The
partial image should be decoded and drawn and the blue <img> background should be
visible.

Progressive load test: receive a partial number of image bytes, stall for 1 second
and then continue to receive all the image bytes. The entire test image should be
decoded and drawn and the blue <img> background should be visible.

* fast/images/resources/dice.png: Added: test image has alpha transparency.
* http/tests/images/png-partial-load-expected.png: Added.
* http/tests/images/png-partial-load-expected.txt: Added.
* http/tests/images/png-partial-load.html: Added.
* http/tests/images/png-progressive-load-expected.png: Added.
* http/tests/images/png-progressive-load-expected.txt: Added.
* http/tests/images/png-progressive-load.html: Added.
* platform/chromium/http/tests/images/png-partial-load-expected.png: Added.
* platform/mac/http/tests/images/png-partial-load-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WebKit2] [GTK] Add API for controlling the user agent
mrobinson@webkit.org [Wed, 19 Sep 2012 02:37:21 +0000 (02:37 +0000)]
[WebKit2] [GTK] Add API for controlling the user agent
https://bugs.webkit.org/show_bug.cgi?id=95697

Reviewed by Carlos Garcia Campos.

Add API for changing the user agent in WebKit2. This adds two styles of
setting the user agent: complete override and a method that just inserts
the application name and version, but preserves the carefully crafted user agent
in the library.

* UIProcess/API/gtk/WebKitSettings.cpp:
(_WebKitSettingsPrivate): Added a new field to store the user agent.
This is stored in the private data structure, because we can only
set the user agent when attaching the settings to the page.
(webKitSettingsSetProperty): Add hooks for the new user agent property.
(webKitSettingsGetProperty): Ditto.
(webkit_settings_class_init): Ditto.
(webkitSettingsAttachSettingsToPage): Ditto.
(webkit_settings_get_user_agent): Added.
(webkit_settings_set_user_agent): Added.
(webkit_settings_set_user_agent_with_application_name): Added.
* UIProcess/API/gtk/WebKitSettings.h: Added new methods.
* UIProcess/API/gtk/WebKitWebView.cpp: Update the glue for the settings
when attaching and detaching from WebViews.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Added new methods to
the documentation.
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp: Test the new user agent
property.
(testWebKitSettingsUserAgent): Ditto.
(beforeAll): Ditto.
* UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::standardUserAgent): Now use the shared WebCore
code when setting the user agent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] Notification.requestPermission(function() {alert();}) crashes
haraken@chromium.org [Wed, 19 Sep 2012 01:36:24 +0000 (01:36 +0000)]
[V8] Notification.requestPermission(function() {alert();}) crashes
https://bugs.webkit.org/show_bug.cgi?id=94462

Reviewed by Adam Barth.

Source/WebCore:

Since Notification.requestPermission() is a static method,
we need to use getExecutionContext() instead of retrieving a context
from a DOM object.

Test: http/tests/notifications/notification-request-permission.html

* bindings/v8/custom/V8NotificationCustom.cpp:
(WebCore::V8Notification::requestPermissionCallback):

LayoutTests:

The added test checks if Notification.requestPermission() does not crash.

* http/tests/notifications/notification-request-permission-expected.txt: Added.
* http/tests/notifications/notification-request-permission.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Implement PageClientImpl::isViewFocused.
ryuan.choi@samsung.com [Wed, 19 Sep 2012 01:33:05 +0000 (01:33 +0000)]
[EFL][WK2] Implement PageClientImpl::isViewFocused.
https://bugs.webkit.org/show_bug.cgi?id=97015

Reviewed by Gyuyoung Kim.

WebKit2/Efl always returns true for PageClientImpl::isViewFocused.
So window.onblur events will not be generated when webview lost focus.

This patch implements isViewFocused to return the current focus of webview.

* UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::isViewFocused):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG should not call out to C++ every time that it tries to put to an object that...
fpizlo@apple.com [Wed, 19 Sep 2012 01:20:52 +0000 (01:20 +0000)]
DFG should not call out to C++ every time that it tries to put to an object that doesn't yet have array storage
https://bugs.webkit.org/show_bug.cgi?id=96983

Reviewed by Oliver Hunt.

Introduce more polymorphism into the DFG's array mode support. Use that to
introduce the notion of effectul array modes, where the check for the mode
will perform actions necessary to ensure that we have the mode we want, if
the object is not already in that mode. Also added profiling support for
checking if an object is of a type that would not allow us to create array
storage (like a typed array or a string for example).

This is a ~2x speed-up on loops that transform an object that did not have
indexed storage into one that does.

* JSCTypedArrayStubs.h:
(JSC):
* bytecode/ArrayProfile.cpp:
(JSC::ArrayProfile::computeUpdatedPrediction):
* bytecode/ArrayProfile.h:
(JSC::ArrayProfile::ArrayProfile):
(JSC::ArrayProfile::mayInterceptIndexedAccesses):
(ArrayProfile):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGArrayMode.cpp:
(JSC::DFG::fromObserved):
(DFG):
(JSC::DFG::modeAlreadyChecked):
(JSC::DFG::modeToString):
* dfg/DFGArrayMode.h:
(DFG):
(JSC::DFG::modeUsesButterfly):
(JSC::DFG::isSlowPutAccess):
(JSC::DFG::benefitsFromStructureCheck):
(JSC::DFG::isEffectful):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getArrayMode):
(JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::byValIsPure):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasArrayMode):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::arrayify):
(DFG):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/Arguments.h:
(Arguments):
* runtime/JSNotAnObject.h:
(JSNotAnObject):
* runtime/JSObject.h:
(JSObject):
(JSC::JSObject::ensureArrayStorage):
* runtime/JSString.h:
(JSC::JSString::createStructure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Refactoring] ContentDistributor::distributeSelectionsTo should not change ContentDis...
shinyak@chromium.org [Wed, 19 Sep 2012 01:04:59 +0000 (01:04 +0000)]
[Refactoring] ContentDistributor::distributeSelectionsTo should not change ContentDistribution pool.
https://bugs.webkit.org/show_bug.cgi?id=96993

Reviewed by Dimitri Glazkov.

Since we would like to reuse ContentDistribution pool, it should not be updated in
ContentDistributor::distributeSelectionsTo. Instead, we should have Vector<bool> to indicate an element is
distributed or not.

No new tests, simple refactoring.

* html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::distributeSelectionsTo):
* html/shadow/ContentDistributor.h:
(ContentDistributor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdjust expectation for fast/workers/storage/interrupt-database.html
dpranke@chromium.org [Wed, 19 Sep 2012 01:03:45 +0000 (01:03 +0000)]
Adjust expectation for fast/workers/storage/interrupt-database.html
https://bugs.webkit.org/show_bug.cgi?id=84696

Unreviewed, expectations change.

It looks like this test is just kinda slow and probably won't timeout if we mark it SLOW.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] word-spacing-characters{,-complex} no longer fail on Mac.
dpranke@chromium.org [Wed, 19 Sep 2012 00:44:46 +0000 (00:44 +0000)]
[chromium] word-spacing-characters{,-complex} no longer fail on Mac.
https://bugs.webkit.org/show_bug.cgi?id=94008
https://bugs.webkit.org/show_bug.cgi?id=94003

Unreviewed, expectations change.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] gradient-with-scaled-ancestor passes on mac lion gpu
dpranke@chromium.org [Wed, 19 Sep 2012 00:41:20 +0000 (00:41 +0000)]
[chromium] gradient-with-scaled-ancestor passes on mac lion gpu
http://bugs.webkit.org/show_bug.cgi?id=96441

Unreviewed, expectations change.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Adjust expectation for fast/css/sticky/sticky-left-percentage.html
dpranke@chromium.org [Wed, 19 Sep 2012 00:38:06 +0000 (00:38 +0000)]
[chromium] Adjust expectation for fast/css/sticky/sticky-left-percentage.html
http://webkit.org/b/95136

Unreviewed, expectations change.

The test is only failing on win and linux now.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] overflow-auto-with-touch-toggle is no longer failing.
dpranke@chromium.org [Wed, 19 Sep 2012 00:35:54 +0000 (00:35 +0000)]
[chromium] overflow-auto-with-touch-toggle is no longer failing.
https://bugs.webkit.org/show_bug.cgi?id=94353

Unreviewed, expectations change.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] fast/css/nested-rounded-corners.html is no longer failing.
dpranke@chromium.org [Wed, 19 Sep 2012 00:32:02 +0000 (00:32 +0000)]
[chromium] fast/css/nested-rounded-corners.html is no longer failing.
https://bugs.webkit.org/show_bug.cgi?id=94063

Unreviewed, expectations change.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] font-scale-factor.html and simple-paragraph.html are no longer failing.
dpranke@chromium.org [Wed, 19 Sep 2012 00:26:32 +0000 (00:26 +0000)]
[chromium] font-scale-factor.html and simple-paragraph.html are no longer failing.
https://bugs.webkit.org/show_bug.cgi?id=90741

Unreviewed, expectations change.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] fast/table/border-collapsing/cached-69296.html is no longer failing.
dpranke@chromium.org [Wed, 19 Sep 2012 00:23:19 +0000 (00:23 +0000)]
[chromium] fast/table/border-collapsing/cached-69296.html is no longer failing.
https://bugs.webkit.org/show_bug.cgi?id=70298

Unreviewed, expectations change.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] fast/js/kde/GlobalObject.html is no longer failing.
dpranke@chromium.org [Wed, 19 Sep 2012 00:20:11 +0000 (00:20 +0000)]
[chromium] fast/js/kde/GlobalObject.html is no longer failing.
https://bugs.webkit.org/show_bug.cgi?id=75468

Unreviewed, expectations change.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Mark LayoutTests/fullscreen/exit-full-screen-iframe.html as flaky.
dpranke@chromium.org [Wed, 19 Sep 2012 00:15:23 +0000 (00:15 +0000)]
[chromium] Mark LayoutTests/fullscreen/exit-full-screen-iframe.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=90704

Unreviewed, expectations change.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] 2d.imageData.object.round and canvas-ImageData-behavior are no longer...
dpranke@chromium.org [Wed, 19 Sep 2012 00:11:10 +0000 (00:11 +0000)]
[chromium] 2d.imageData.object.round and canvas-ImageData-behavior are no longer failing
https://bugs.webkit.org/show_bug.cgi?id=94246

Unreviewed, expectations change.

[chromium] The following suppressions appear to be no longer needed
(the tests are passing), so I'm removing them:

BUGWK94246 : canvas/philip/tests/2d.imageData.object.round.html = TEXT
BUGWK94246 : platform/chromium/virtual/gpu/canvas/philip/tests/2d.imageData.object.round.html = TEXT
BUGWK94246 : fast/canvas/canvas-ImageData-behaviour.html = TEXT
BUGWK94246 : platform/chromium/virtual/gpu/fast/canvas/canvas-ImageData-behaviour.html = TEXT

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofast/dom/Window/anonymous-slot-with-changes.html is no longer failing.
dpranke@chromium.org [Wed, 19 Sep 2012 00:06:12 +0000 (00:06 +0000)]
fast/dom/Window/anonymous-slot-with-changes.html is no longer failing.
http://code.google.com/p/chromium/issues/detail?id=33538

Unreviewed, expectations change.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTitle string should be changed when document.title is set to ''.
commit-queue@webkit.org [Tue, 18 Sep 2012 23:49:31 +0000 (23:49 +0000)]
Title string should be changed when document.title is set to ''.
https://bugs.webkit.org/show_bug.cgi?id=96793

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-09-18
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

DocumentLoader::setTitle() function returns without anything (changing
m_pageTitle and calling FrameLoaderClient::setTitle()) when new title
string is empty.
So, when document.title is set to '', title string of a browser cannot
be changed.
For applying the change of document.title properly, empty string check
should be removed.

Test: fast/dom/title-text-property-assigning-empty-string.html

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::setTitle):

Source/WebKit2:

Added unit test for setting document.title and checking the title
string with title,changed signal and ewk_view_title_get() function.

* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):

Tools:

Change dump format of dumpTitleChanges more understandable.
Uses single quotation marks for the title string.

* DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::didReceiveTitleForFrame):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didReceiveTitle):
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onFrameTitleChanged):
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(webViewTitleChanged):
* DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::titleChanged):
* DumpRenderTree/win/FrameLoadDelegate.cpp:
(FrameLoadDelegate::didReceiveTitle):
* DumpRenderTree/wx/DumpRenderTreeWx.cpp:
(LayoutWebViewEventHandler::OnReceivedTitleEvent):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didReceiveTitleForFrame):

LayoutTests:

Added layout tests for assigning empty string to title text.
And modified expected results according to the change of
dumpTitleChanges.

* fast/dom/title-text-property-2-expected.txt: Modified expected result.
* fast/dom/title-text-property-assigning-empty-string-expected.txt: Added.
* fast/dom/title-text-property-assigning-empty-string.html: Added.
* fast/dom/title-text-property-expected.txt: Modified expected result.
* fast/dom/title-text-property.html: Apply modified dumpTitleChanges.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r128939.
hclam@chromium.org [Tue, 18 Sep 2012 23:19:42 +0000 (23:19 +0000)]
Unreviewed, rolling out r128939.
http://trac.webkit.org/changeset/128939
https://bugs.webkit.org/show_bug.cgi?id=96135

Failing test_shell_tests.

* WebKit.gypi:
* src/WebImageSkia.cpp:
(WebKit::WebImage::fromData):
(WebKit::WebImage::framesFromData):
* tests/WebImageTest.cpp: Removed.
* tests/data/black-and-white.ico: Removed.
* tests/data/white-1x1.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofast/forms/search-event-delay.html is asserting in markAllMisspellingsAndBadGrammarIn...
simon.fraser@apple.com [Tue, 18 Sep 2012 22:43:35 +0000 (22:43 +0000)]
fast/forms/search-event-delay.html is asserting in markAllMisspellingsAndBadGrammarInRanges()
https://bugs.webkit.org/show_bug.cgi?id=82761

Reviewed by Ryosuke Niwa.

Speculative fix for this assertion: have InternalSettings save
and restore the value of the "unifiedTextCheckerEnabled" setting
between tests, so that tests change the value of this setting don't
affect later tests.

* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
* testing/InternalSettings.h:
(Backup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] WebImage should use ImageDecoder directly
hclam@chromium.org [Tue, 18 Sep 2012 22:29:54 +0000 (22:29 +0000)]
[chromium] WebImage should use ImageDecoder directly
https://bugs.webkit.org/show_bug.cgi?id=96135

Reviewed by Adam Barth.

This patch is for preparation of deferred image decoding.
ImageSource will be used as a portal to access deferred image decoder
by BitmapImage, it should not be accessible through WebKit APIs.

WebImage now calls ImageDecoder directly which is the actual
implementation of an image decoder.

Tests: WebImageTest.PNGImage
       WebImageTest.ICOImage

* WebKit.gypi:
* src/WebImageSkia.cpp:
(WebKit::WebImage::fromData):
(WebKit::WebImage::framesFromData):
* tests/WebImageTest.cpp: Added.
(WebKit):
(WebKit::readFile):
(WebKit::TEST):
* tests/data/black-and-white.ico: Added.
* tests/data/white-1x1.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInclude PhantomArguments in DFGDisassembly
fpizlo@apple.com [Tue, 18 Sep 2012 22:26:41 +0000 (22:26 +0000)]
Include PhantomArguments in DFGDisassembly
https://bugs.webkit.org/show_bug.cgi?id=97043

Reviewed by Geoffrey Garen.

* dfg/DFGNode.h:
(JSC::DFG::Node::willHaveCodeGenOrOSR):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDivision by zero crash in BackingStore::scroll
andersca@apple.com [Tue, 18 Sep 2012 22:00:19 +0000 (22:00 +0000)]
Division by zero crash in BackingStore::scroll
https://bugs.webkit.org/show_bug.cgi?id=97046
<rdar://problem/11722564>

Reviewed by Dan Bernstein.

It appears that DrawingAreaImpl::scroll can be called with an empty scroll rect. Do nothing
if that's the case. Also, assert that the scrolling rect in BackingStoreMac is never empty.

* UIProcess/mac/BackingStoreMac.mm:
(WebKit::BackingStore::scroll):
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::scroll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Use didCancel and didSucceed instead of didCheckCancel and didCheckSucceed
commit-queue@webkit.org [Tue, 18 Sep 2012 21:38:57 +0000 (21:38 +0000)]
[BlackBerry] Use didCancel and didSucceed instead of didCheckCancel and didCheckSucceed
https://bugs.webkit.org/show_bug.cgi?id=97033

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-09-18
Reviewed by Rob Buis.

Using these preferred public methods (the latter has a note to be made private) ensures that
the right SpellChecker object is being called during the callback in spellCheckingRequestProcessed
and spellCheckingRequestCancelled.

Internally reviewed by Mike Fenton.

By referencing the TextCheckingRequest object's methods, we don't need to keep track of the associated
SpellChecker for each request. Removing much of the code that was put in place incorrectly to achieve this.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::getSpellChecker):
* WebKitSupport/InputHandler.h:
(InputHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore unreviewed rebaseline after r128906.
jchaffraix@webkit.org [Tue, 18 Sep 2012 21:37:03 +0000 (21:37 +0000)]
More unreviewed rebaseline after r128906.

* platform/chromium-mac/fast/invalid/residual-style-expected.txt:
* platform/chromium-win-xp/fast/invalid/residual-style-expected.txt: Added.
* platform/chromium-win-xp/tables/mozilla/bugs/bug56563-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttp://trac.webkit.org/changeset/128912 caused these tests to start failing.
ojan@chromium.org [Tue, 18 Sep 2012 21:31:30 +0000 (21:31 +0000)]
trac.webkit.org/changeset/128912 caused these tests to start failing.
Looks like a garden-o-matic/webkit-patch bug.

* platform/chromium-linux/css3/filters/filter-change-repaint-composited-expected.png: Added.
* platform/chromium-linux/css3/filters/filter-change-repaint-expected.png: Added.
* platform/chromium-linux/css3/filters/filter-repaint-child-layers-expected.png: Added.
* platform/chromium-linux/css3/filters/filter-repaint-composited-fallback-crash-expected.png: Added.
* platform/chromium-linux/css3/filters/filter-repaint-composited-fallback-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening after http://trac.webkit.org/changeset/128928
fpizlo@apple.com [Tue, 18 Sep 2012 21:27:26 +0000 (21:27 +0000)]
Unreviewed gardening after trac.webkit.org/changeset/128928

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r128802): It made some JS tests crash
fpizlo@apple.com [Tue, 18 Sep 2012 21:17:43 +0000 (21:17 +0000)]
REGRESSION(r128802): It made some JS tests crash
https://bugs.webkit.org/show_bug.cgi?id=97001

Reviewed by Mark Hahnenberg.

IndexingHeaderInlineMethods was incorrectly assuming that if the HasArrayStorage bit is clear, then that means that indexing payload capacity is zero.

* runtime/IndexingHeaderInlineMethods.h:
(JSC::IndexingHeader::preCapacity):
(JSC::IndexingHeader::indexingPayloadSizeInBytes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoText Autosizing: Ignore constrained heights in certain circumstances.
commit-queue@webkit.org [Tue, 18 Sep 2012 20:40:56 +0000 (20:40 +0000)]
Text Autosizing: Ignore constrained heights in certain circumstances.
https://bugs.webkit.org/show_bug.cgi?id=96848

Patch by John Mellor <johnme@chromium.org> on 2012-09-18
Reviewed by Julien Chaffraix.

Source/WebCore:

Ignore constrained heights on html and body elements, as some sites
(e.g. wikipedia) set height:100% on these, without intending to
constrain the height of descendants.

Also ignore constrained heights on ancestors of floats and out-of-flow
positioned elements with no height set, since the height of these is
determined independently from their ancestors.

Test: fast/text-autosizing/constrained-height-body.html
      fast/text-autosizing/constrained-out-of-flow.html
      fast/text-autosizing/constrained-then-float-ancestors.html
      fast/text-autosizing/constrained-then-position-absolute-ancestors.html
      fast/text-autosizing/constrained-then-position-fixed-ancestors.html

* rendering/TextAutosizer.cpp:
(WebCore::contentHeightIsConstrained):

    Adjusted constrainedness algorithm.

LayoutTests:

Added 3 tests, updated 2, and removed 1. See below.

* fast/text-autosizing/constrained-height-body-expected.html: Added.
* fast/text-autosizing/constrained-height-body.html: Added.

    Checks that constrained height html & body are ignored.

* fast/text-autosizing/constrained-then-overflow-then-positioned-ancestors-expected.html: Removed.
* fast/text-autosizing/constrained-then-overflow-then-positioned-ancestors.html: Removed.

    Removed because this situation is no longer possible now that
    heightless position:absolute elements are always unconstrained.

* fast/text-autosizing/constrained-out-of-flow-expected.html: Added.
* fast/text-autosizing/constrained-out-of-flow.html: Added.

    Checks that floats and out-of-flow positioned elements do not ignore
    constraints on themselves.

* fast/text-autosizing/constrained-then-float-ancestors-expected.html: Added.
* fast/text-autosizing/constrained-then-float-ancestors.html: Added.

    Checks that floats ignore constraints on ancestors.

* fast/text-autosizing/constrained-then-position-absolute-ancestors-expected.html:
* fast/text-autosizing/constrained-then-position-absolute-ancestors.html:

    Added position:relative to emphasize that the ancestor's constrained
    height is actually being ignored, not just skipped over; and updated
    explanation.

* fast/text-autosizing/constrained-then-position-fixed-ancestors-expected.html:
* fast/text-autosizing/constrained-then-position-fixed-ancestors.html:

    Updated explanation (since the test still passes, but for a
    different reason).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMediaStream API: Create a flag to enable PeerConnection00
tommyw@google.com [Tue, 18 Sep 2012 20:07:18 +0000 (20:07 +0000)]
MediaStream API: Create a flag to enable PeerConnection00
https://bugs.webkit.org/show_bug.cgi?id=96989

Reviewed by Adam Barth.

Adding the functionality to separately enable/disable PeerConnection00.
For now it is enabled by default.

Source/WebCore:

Not testable, nor likely to cause issues.

* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::deprecatedPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::setDeprecatedPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitPeerConnection00Enabled):
(RuntimeEnabledFeatures):

Source/WebKit/chromium:

* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableDeprecatedPeerConnection):
(WebKit):
(WebKit::WebRuntimeFeatures::isDeprecatedPeerConnectionEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Date picker isn't inputting after 'OK'
commit-queue@webkit.org [Tue, 18 Sep 2012 19:55:55 +0000 (19:55 +0000)]
[BlackBerry] Date picker isn't inputting after 'OK'
https://bugs.webkit.org/show_bug.cgi?id=97031

PR208052

Patch by Jessica Cao <jecao@rim.com> on 2012-09-18
Reviewed by Rob Buis

Checking for !values.contains("-1") will match valid strings like "2012-09-18". Use value != "-1" instead.

* WebCoreSupport/DatePickerClient.cpp:
(WebCore::DatePickerClient::setValueAndClosePopup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Layout Test svg/dom/SVGScriptElement/script-change-externalResourcesRequired...
ap@apple.com [Tue, 18 Sep 2012 19:37:02 +0000 (19:37 +0000)]
    Layout Test svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg is failing
        https://bugs.webkit.org/show_bug.cgi?id=93589

        * platform/mac/Skipped: Skipping the test on Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Popup page should reference the client with a weak pointer
yoli@rim.com [Tue, 18 Sep 2012 19:26:13 +0000 (19:26 +0000)]
[BlackBerry] Popup page should reference the client with a weak pointer
https://bugs.webkit.org/show_bug.cgi?id=97028

Reviewed by Rob Buis.

RIM PR# 209847.
Internally reviewed by Mike Fenton.

Store the pointer in a ref-coutned shared object, and clear the pointer
when the client is going to be destroyed, so it won't be accessed by
the JS function afterwards.

* WebCoreSupport/PagePopupBlackBerry.cpp:
(WebCore::PagePopupBlackBerry::PagePopupBlackBerry):
(WebCore::PagePopupBlackBerry::~PagePopupBlackBerry):
(WebCore::PagePopupBlackBerry::init):
(WebCore::setValueAndClosePopupCallback):
(WebCore::popUpExtensionFinalize):
(WebCore::PagePopupBlackBerry::installDOMFunction):
(WebCore::PagePopupBlackBerry::closePopup):
* WebCoreSupport/PagePopupBlackBerry.h:
(PagePopupBlackBerry):
(SharedClientPointer):
(WebCore::PagePopupBlackBerry::SharedClientPointer::SharedClientPointer):
(WebCore::PagePopupBlackBerry::SharedClientPointer::clear):
(WebCore::PagePopupBlackBerry::SharedClientPointer::get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed, add missing newline to expectation for test only run
jsbell@chromium.org [Tue, 18 Sep 2012 19:09:05 +0000 (19:09 +0000)]
[Chromium] Unreviewed, add missing newline to expectation for test only run
as part of chromium's content_browsertests.

* storage/indexeddb/basics-shared-workers-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove lines for tests that haven't failed on any Chromium bot for the last 500 runs.
ojan@chromium.org [Tue, 18 Sep 2012 18:58:28 +0000 (18:58 +0000)]
Remove lines for tests that haven't failed on any Chromium bot for the last 500 runs.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline after r128906. All the differences were expected.
jchaffraix@webkit.org [Tue, 18 Sep 2012 18:52:56 +0000 (18:52 +0000)]
Rebaseline after r128906. All the differences were expected.

* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug56563-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.png:
* platform/gtk/fast/invalid/residual-style-expected.txt:
* platform/mac/fast/invalid/residual-style-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoComplete some forgotten rebaselines. The new results match other ports/platforms.
ojan@chromium.org [Tue, 18 Sep 2012 18:26:19 +0000 (18:26 +0000)]
Complete some forgotten rebaselines. The new results match other ports/platforms.

* fast/block/float/024-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/024-expected.txt.
* fast/block/margin-collapse/025-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/margin-collapse/025-expected.txt.
* fast/block/margin-collapse/block-inside-inline/025-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/margin-collapse/block-inside-inline/025-expected.txt.
* fast/block/margin-collapse/empty-clear-blocks-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/margin-collapse/empty-clear-blocks-expected.txt.
* platform/chromium-mac-snowleopard/fast/block/float/024-expected.png:
* platform/chromium-mac-snowleopard/fast/block/margin-collapse/empty-clear-blocks-expected.png:
* platform/chromium-mac/fast/block/float/024-expected.png:
* platform/chromium-mac/fast/block/float/024-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/float/024-expected.txt.
* platform/chromium-mac/fast/block/margin-collapse/025-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/margin-collapse/025-expected.txt.
* platform/chromium-mac/fast/block/margin-collapse/block-inside-inline/025-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt.
* platform/chromium-mac/fast/block/margin-collapse/empty-clear-blocks-expected.png:
* platform/chromium-mac/fast/block/margin-collapse/empty-clear-blocks-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert 128780, 128676, 128645
commit-queue@webkit.org [Tue, 18 Sep 2012 18:18:08 +0000 (18:18 +0000)]
Revert 128780, 128676, 128645
https://bugs.webkit.org/show_bug.cgi?id=97022

Patch by Bo Liu <boliu@chromium.org> on 2012-09-18
Reviewed by Adam Barth.

I made these revisions to add in-place reload behavior to ImagesEnabled setting.
Reverting this for now due to them causing performance regression in
chromium, possibly caused by increased calls to
PermissionClient::imageAllowed.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

* WebCore.exp.in:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::didBeginDocument):
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::load):
* loader/cache/CachedImage.h:
(WebCore::CachedImage::stillNeedsLoad):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::didAddClient):
* loader/cache/CachedResource.h:
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::setAutoLoadImages):
* loader/cache/CachedResourceLoader.h:
(CachedResourceLoader):
* page/Settings.cpp:
(WebCore::setLoadsImagesAutomaticallyInAllFrames):
(WebCore::Settings::Settings):
(WebCore::Settings::setLoadsImagesAutomatically):
(WebCore::Settings::loadsImagesAutomaticallyTimerFired):
(WebCore::Settings::setImagesEnabled):
* page/Settings.h:
(Settings):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setLangAttributeAwareFormControlUIEnabled):
* testing/InternalSettings.h:
(Backup):
(InternalSettings):
* testing/InternalSettings.idl:

Source/WebKit2:

* win/WebKit2.def:

LayoutTests:

* fast/loader/display-image-unset-allows-cached-image-load-expected.txt: Removed.
* fast/loader/display-image-unset-allows-cached-image-load.html: Removed.
* fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt: Removed.
* fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html: Removed.
* fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place-expected.txt: Removed.
* fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html: Removed.
* fast/loader/resources/image1.html: Removed.
* fast/loader/resources/image2.html: Removed.
* platform/chromium/http/tests/permissionclient/image-permissions-expected.txt:
* platform/chromium/permissionclient/image-permissions-expected.txt:
* platform/chromium/permissionclient/image-permissions.html:
* platform/chromium/permissionclient/resources/image.html:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] [WK2] Replace Skipped with TestExpectations
sergio@webkit.org [Tue, 18 Sep 2012 18:15:11 +0000 (18:15 +0000)]
[GTK] [WK2] Replace Skipped with TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=97029

Reviewed by Martin Robinson.

Replace the Skipped file with a TestExpectations file which adds
lots of semantics.

* platform/gtk-wk2/Skipped: Removed.
* platform/gtk-wk2/TestExpectations: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline tests. Mostly failing due to slight pixel differences.
ojan@chromium.org [Tue, 18 Sep 2012 18:12:07 +0000 (18:12 +0000)]
Rebaseline tests. Mostly failing due to slight pixel differences.
* platform/chromium-win/css3/filters/crash-hw-sw-switch-expected.png:
* platform/chromium-win/css3/filters/effect-brightness-clamping-expected.png:
* platform/chromium-win/css3/filters/effect-brightness-expected.png:
These two results are darker now, but this matches the mac/linux results.

* platform/chromium-win/css3/filters/filter-change-repaint-composited-expected.png: Added.
* platform/chromium-win/css3/filters/filter-change-repaint-expected.png: Added.
* platform/chromium-win/css3/filters/filter-repaint-child-layers-expected.png: Added.
* platform/chromium-win/css3/filters/filter-repaint-composited-fallback-crash-expected.png: Added.
* platform/chromium-win/css3/filters/filter-repaint-composited-fallback-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Skipping large number of tests that have been failing on Windows.
roger_fong@apple.com [Tue, 18 Sep 2012 18:09:35 +0000 (18:09 +0000)]
Unreviewed. Skipping large number of tests that have been failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=97026

Due to the state of the windows bots a large number of tests have been failing for quite some time and it is difficult to tell when the failure started.
For now I'm adding these tests to the skip list to get the bots greener and will come back to them later.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Set focus on the ExtensionPanel's iframe when it is selected
commit-queue@webkit.org [Tue, 18 Sep 2012 18:02:36 +0000 (18:02 +0000)]
Web Inspector: Set focus on the ExtensionPanel's iframe when it is selected
https://bugs.webkit.org/show_bug.cgi?id=96148

Patch by John J. Barton <johnjbarton@chromium.org> on 2012-09-18
Reviewed by Vsevolod Vlasov.

Source/WebCore:

ExtensionView ctor calls setDefaultFocusedElement with its iframe,
ExtensionPanel ctor calls setDefaultFocusedElement with the extensionView
and ExtensionPanel's setDefaultFocusedElement calls its grandparent impl

Tests: Added hasFocus test to extensions/extension-panel.html

* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel):
(WebInspector.ExtensionPanel.prototype.defaultFocusedElement):
* inspector/front-end/ExtensionView.js:
(WebInspector.ExtensionView):

LayoutTests:

Add one line to verify that the panel's document has focus after show

* inspector/extensions/extensions-panel-expected.txt:
* inspector/extensions/extensions-panel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline tests failing due to expected slight pixel differences.
ojan@chromium.org [Tue, 18 Sep 2012 18:00:04 +0000 (18:00 +0000)]
Rebaseline tests failing due to expected slight pixel differences.

* platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
* platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.png:
* platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.png:
* platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.png:
* platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Discrete-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Gamma-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Linear-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Table-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
* platform/chromium-mac/css3/filters/effect-combined-expected.png:
* platform/chromium-mac/css3/filters/effect-opacity-expected.png:
* platform/chromium-mac/css3/filters/effect-reference-ordering-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
* platform/chromium-mac/svg/custom/feComponentTransfer-Discrete-expected.png:
* platform/chromium-mac/svg/custom/feComponentTransfer-Gamma-expected.png:
* platform/chromium-mac/svg/custom/feComponentTransfer-Linear-expected.png:
* platform/chromium-mac/svg/custom/feComponentTransfer-Table-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
* platform/chromium-win/css3/filters/effect-combined-expected.png:
* platform/chromium-win/css3/filters/effect-opacity-expected.png:
* platform/chromium-win/css3/filters/effect-reference-ordering-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
* platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.png:
* platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.png:
* platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.png:
* platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWTFString::show doesn't dump non-ASCII characters in a readable manner
commit-queue@webkit.org [Tue, 18 Sep 2012 17:57:33 +0000 (17:57 +0000)]
WTFString::show doesn't dump non-ASCII characters in a readable manner
https://bugs.webkit.org/show_bug.cgi?id=96749

Patch by Glenn Adams <glenn@skynav.com> on 2012-09-18
Reviewed by Benjamin Poulain.

Dump non-ASCII characters in a useful form for debugging.

* wtf/text/WTFString.cpp:
(asciiDebug):
Dump non-ASCII characters (i.e., UTF-16 code elements) as well as non-printable ASCII characters
using \uXXXX format. Also escape \ as \\ in order to remove ambiguity.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] [WebKit2] Use XComposite window for accelerated compositing
mrobinson@webkit.org [Tue, 18 Sep 2012 17:54:14 +0000 (17:54 +0000)]
[GTK] [WebKit2] Use XComposite window for accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=94417

Reviewed by Carlos Garcia Campos.

Instead of rendering directly to the widget's native window, render to an
offscreen window redirected to a Pixmap with XComposite.

Source/WebCore:

No new tests. This will be covered by the existing accelerated compositing tests,
which should now give correct pixel results.

* platform/gtk/RedirectedXCompositeWindow.cpp:
(WebCore::RedirectedXCompositeWindow::resize): Add a call to XFlush which ensures
that pending X11 operations complete.
* platform/gtk/RedirectedXCompositeWindow.h:
(WebCore::RedirectedXCompositeWindow::windowId): Added this accessor.

Source/WebKit2:

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(_WebKitWebViewBasePrivate): Added a few members necessary to track the
offscreen window.
(webkit_web_view_base_init):
(renderAcceleratedCompositingResults): Added this helper functions which renders
the results of the accelerated compositing operations during the GTK+ draw loop.
(webkitWebViewBaseDraw): Call renderAcceleratedCompositingResults when appropriate.
(resizeWebKitWebViewBaseFromAllocation): Resize the offscreen window when appropriate.
(webkitWebViewBaseSizeAllocate): Do not call resizeWebKitWebViewBaseFromAllocation when
the actual size of the widget does not change. This prevents destroying and recreating
the offscreen window pixmap when it isn't necessary.
(webkitWebViewBaseMap): We no longer send the window id during map, instead it's sent
as soon as there is WebPageProxy.
(webkitWebViewBaseCreateWebPage): Send the window id of the redirected window to
the WebProcess.
(queueAnotherDrawOfAcceleratedCompositingResults): Added this helper which works
around the issue of slow updates of the pixmap backing the redirected XComposite window.
(webkitWebViewBaseQueueDrawOfAcceleratedCompositingResults): Added this method which
is what the WebProcess uses to force a redraw on the UIProcess side.
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Added new method to the list of private methods.
* UIProcess/DrawingAreaProxyImpl.h:
(DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::isInAcceleratedCompositingMode): Exposed this method publically
so that it can be used from WebKitWebViewBase.
* UIProcess/WebPageProxy.h:
(WebPageProxy): Renamed widgetMapped to setAcceleratedCompositingWindowId.
* UIProcess/WebPageProxy.messages.in: Ditto.
* UIProcess/gtk/WebPageProxyGtk.cpp: Ditto.
(WebKit::WebPageProxy::setAcceleratedCompositingWindowId):
* WebProcess/WebPage/WebPage.h:
(WebPage): Ditto.
* WebProcess/WebPage/WebPage.messages.in: Ditto.
* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::sizeDidChange): Force a composite to the resized window right
away so that the new window pixmap is updated before the first draw.
(WebKit::LayerTreeHostGtk::compositeLayersToContext): If the composition is for a resize,
first clear the entire GL context so that we don't see black artifacts during resize.
* WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
(LayerTreeHostGtk): Update the signature of  compositeLayersToContext.
* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::setAcceleratedCompositingWindowId): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTables without any descendant and auto logical width should have a 0px logical width
jchaffraix@webkit.org [Tue, 18 Sep 2012 17:51:22 +0000 (17:51 +0000)]
Tables without any descendant and auto logical width should have a 0px logical width
https://bugs.webkit.org/show_bug.cgi?id=95521

Reviewed by Abhishek Arya.

Source/WebCore:

The code would wrongly add the border-spacing in the row direction to the table's logical
width even if we didn't have a column. The new behavior matches FireFox and Opera. IE
matches our old behavior for inline tables but our new behavior for normal tables which
is a bug on their side.

Tests: fast/table/empty-table-should-take-no-space.html
       fast/table/fixed-table-layout/empty-table-should-take-no-space-fixed-layout.html

* rendering/RenderTable.h:
(WebCore::RenderTable::borderSpacingInRowDirection):
Added this new helper function to return the right border-spacing. Added a FIXME as the code always
return the horizontal dimension which is wrong in vertical-writing mode.

(WebCore::RenderTable::bordersPaddingAndSpacingInRowDirection):
Changed to call borderSpacingInRowDirection. Added a comment as to why we don't add border-spacing on
border-collapse: separate tables.

LayoutTests:

* fast/table/empty-table-should-take-no-space-expected.html: Added.
* fast/table/empty-table-should-take-no-space.html: Added.
* fast/table/fixed-table-layout/empty-table-should-take-no-space-fixed-layout-expected.html: Added.
* fast/table/fixed-table-layout/empty-table-should-take-no-space-fixed-layout.html: Added.
2 new tests to check that empty tables have 0px logical width.

* platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug56563-expected.txt:
* platform/mac/tables/mozilla/bugs/bug56563-expected.txt:
* platform/qt/tables/mozilla/bugs/bug56563-expected.txt:
* tables/mozilla/bugs/bug56563-expected.txt:
Progression. The table now is 2px wide as it has a 1px right & left border.

* platform/chromium-linux/fast/invalid/residual-style-expected.txt:
Progression. The changes are due to the tables shrinking which is expected.

* platform/chromium-linux/fast/forms/file/file-input-disabled-expected.txt:
* platform/chromium-mac/fast/forms/file/file-input-disabled-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug113235-2-expected.txt:
* platform/chromium-win-xp/fast/forms/file-input-disabled-expected.txt:
* platform/chromium-win/fast/forms/file/file-input-disabled-expected.txt:
* platform/chromium-win/fast/invalid/017-expected.txt:
* platform/chromium-win/fast/invalid/018-expected.txt:
* platform/chromium-win/fast/invalid/020-expected.txt:
* platform/chromium-win/fast/invalid/table-inside-stray-table-content-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug113235-2-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug23994-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug56405-expected.txt:
* platform/efl/fast/forms/file/file-input-disabled-expected.txt:
* platform/efl/fast/invalid/017-expected.txt:
* platform/efl/fast/invalid/018-expected.txt:
* platform/efl/fast/invalid/020-expected.txt:
* platform/efl/fast/invalid/table-inside-stray-table-content-expected.txt:
* platform/efl/fast/invalid/table-residual-style-crash-expected.txt:
* platform/efl/tables/mozilla/bugs/bug23994-expected.txt:
* platform/efl/tables/mozilla/bugs/bug56405-expected.txt:
* platform/gtk/fast/forms/file/file-input-disabled-expected.txt:
* platform/gtk/fast/invalid/017-expected.txt:
* platform/gtk/fast/invalid/018-expected.txt:
* platform/gtk/fast/invalid/020-expected.txt:
* platform/gtk/fast/invalid/table-inside-stray-table-content-expected.txt:
* platform/gtk/fast/invalid/table-residual-style-crash-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug23994-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug56405-expected.txt:
* platform/mac/fast/forms/file/file-input-disabled-expected.txt:
* platform/mac/fast/invalid/017-expected.txt:
* platform/mac/fast/invalid/018-expected.txt:
* platform/mac/fast/invalid/020-expected.txt:
* platform/mac/fast/invalid/table-inside-stray-table-content-expected.txt:
* platform/mac/fast/invalid/table-residual-style-crash-expected.txt:
* platform/mac/tables/mozilla/bugs/bug113235-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug23994-expected.txt:
* platform/mac/tables/mozilla/bugs/bug56405-expected.txt:
* platform/qt/fast/forms/file/file-input-disabled-expected.txt:
* platform/qt/fast/invalid/017-expected.txt:
* platform/qt/fast/invalid/018-expected.txt:
* platform/qt/fast/invalid/020-expected.txt:
* platform/qt/fast/invalid/table-inside-stray-table-content-expected.txt:
* platform/qt/fast/invalid/table-residual-style-crash-expected.txt:
* platform/qt/tables/mozilla/bugs/bug113235-2-expected.txt:
* platform/qt/tables/mozilla/bugs/bug23994-expected.txt:
* platform/qt/tables/mozilla/bugs/bug56405-expected.txt:
* platform/win/fast/forms/file-input-disabled-expected.txt:
* platform/win/fast/forms/file/file-input-disabled-expected.txt:
* tables/mozilla/bugs/bug113235-2-expected.txt:
Progression. The tables now have a 0px logical width. In some cases, we add the border-spacing in the
block-flow direction if we have a row. This is not consistently handled by browsers and not very well
defined in CSS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Build is broken without option --enable-unstable-features
zandobersek@gmail.com [Tue, 18 Sep 2012 17:43:06 +0000 (17:43 +0000)]
[GTK] Build is broken without option --enable-unstable-features
https://bugs.webkit.org/show_bug.cgi?id=96996

Reviewed by Martin Robinson.

When searching for the bare feature define in feature_defines_unstable or
feature_defines_overrides, search for the bare define followed by = character.
This avoids incorrectly matching the ENABLE_VIDEO define to the ENABLE_VIDEO_TRACK
overriding define (and works as well for other similarly named feature defines).

No new tests - no new functionality.

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 18 Sep 2012 17:42:07 +0000 (17:42 +0000)]
Unreviewed GTK gardening.

Adding expectations for flakily-crashing tests, these failures
are a regression from r128802.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Merge moveSelectionStart, moveSelectionEnd, and moveCaret into selectRange
commit-queue@webkit.org [Tue, 18 Sep 2012 17:23:37 +0000 (17:23 +0000)]
[Chromium] Merge moveSelectionStart, moveSelectionEnd, and moveCaret into selectRange
https://bugs.webkit.org/show_bug.cgi?id=96508

Patch by Iain Merrick <husky@google.com> on 2012-09-18
Reviewed by Ryosuke Niwa.

These methods had "start" and "end" parameters, but this is incorrect.
selectRange() actually takes base and extent (where the user actually
touched), and selectionBounds() returns anchor and focus (base and extent
expanded to account for the selection granularity).

This patch fixes the parameter names, and updates selectRange, its test
and its documentation to reflect the correct usage. It also removes
moveSelectionStart/moveSelectionEnd/moveCaret (which aren't being used
yet), and updates WebFrameTest to show how these can be implemented via
selectRange.

* public/WebFrame.h:
(WebFrame):
* public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::selectionBounds):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::selectRange):
* src/WebFrameImpl.h:
(WebFrameImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::selectionBounds):
* src/WebViewImpl.h:
(WebViewImpl):
* tests/WebFrameTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRoll chromium DEPS to r157342
peter@chromium.org [Tue, 18 Sep 2012 16:21:10 +0000 (16:21 +0000)]
Roll chromium DEPS to r157342
https://bugs.webkit.org/show_bug.cgi?id=96963

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-09-18
Reviewed by Stephen White.

Roll chromium DEPS to r157342. Also include the top-level directory
google_apis as a dependency, which was required for r157130.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse WTF::HasTrivialDestructor instead of compiler-specific versions in JSC::NeedsDest...
mhahnenberg@apple.com [Tue, 18 Sep 2012 16:13:11 +0000 (16:13 +0000)]
Use WTF::HasTrivialDestructor instead of compiler-specific versions in JSC::NeedsDestructor
https://bugs.webkit.org/show_bug.cgi?id=96980

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

* runtime/JSCell.h:
(JSC):
(NeedsDestructor):

Source/WTF:

* wtf/TypeTraits.h:
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEWS shouldn't sleep if there are new patches in its queue
commit-queue@webkit.org [Tue, 18 Sep 2012 15:30:27 +0000 (15:30 +0000)]
EWS shouldn't sleep if there are new patches in its queue
https://bugs.webkit.org/show_bug.cgi?id=83038

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-09-18
Reviewed by Eric Seidel.

EWS tries to process a security patch. Of course it can't, because the EWS isn't
the member of the security group. But the problem is that after it can't process
the attachment, it says that queue is empty (but it isn't!) and it sleeps 2 minutes
and push the security patch to the end of the queue.
Now it stays in the loop until it finds a patch or the queue gets empty.

* Scripts/webkitpy/tool/commands/queues.py:
(AbstractPatchQueue._next_patch):
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(AbstractPatchQueueTest.test_next_patch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFGOperations doesn't use NativeCallFrameTracer in enough places
fpizlo@apple.com [Tue, 18 Sep 2012 15:22:29 +0000 (15:22 +0000)]
DFGOperations doesn't use NativeCallFrameTracer in enough places
https://bugs.webkit.org/show_bug.cgi?id=96987

Reviewed by Mark Hahnenberg.

Anything that can GC should use it.

* dfg/DFGOperations.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Gardening.
rakuco@webkit.org [Tue, 18 Sep 2012 15:14:57 +0000 (15:14 +0000)]
[EFL] Gardening.

Move fast/events/dont-loose-last-event.html from Skipped to
TestExpectations now that it has a proper bug tracking the
failure.

* platform/efl/Skipped:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Avoid using a deprecated extension API parameter in test to avoid console...
caseq@chromium.org [Tue, 18 Sep 2012 15:02:34 +0000 (15:02 +0000)]
Unreviewed. Avoid using a deprecated extension API parameter in test to avoid console warning,
that break expectations on EFL due to EFL's DRT logging inspector console output to test
expectations.

* inspector/extensions/extensions-audits-api.html:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2][WTR] InjectedBundle::booleanForKey() should handle literals effectively
commit-queue@webkit.org [Tue, 18 Sep 2012 15:00:45 +0000 (15:00 +0000)]
[WK2][WTR] InjectedBundle::booleanForKey() should handle literals effectively
https://bugs.webkit.org/show_bug.cgi?id=97014

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-18
Reviewed by Kenneth Rohde Christiansen.

According to http://trac.webkit.org/wiki/EfficientStrings WTF::StringBuilder::appendLiteral() shall
be used for literals rather than WTF::StringBuilder::append().

* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::booleanForKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Gardening.
rakuco@webkit.org [Tue, 18 Sep 2012 14:57:14 +0000 (14:57 +0000)]
[EFL] Gardening.

* platform/efl/TestExpectations: Skip
inspector/extensions/extensions-audits-api.html while we do not
solve the associated bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Unreviewed daily gardening.
rakuco@webkit.org [Tue, 18 Sep 2012 14:44:45 +0000 (14:44 +0000)]
[EFL] Unreviewed daily gardening.

Re-skip a few tests which were unskipped in r128880 and r128882
and still fail both on my machine and on the bots.

* platform/efl/Skipped:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Extensions API] postpone requests to add extensions until extension...
caseq@chromium.org [Tue, 18 Sep 2012 14:14:10 +0000 (14:14 +0000)]
Web Inspector: [Extensions API] postpone requests to add extensions until extension server is initialized
https://bugs.webkit.org/show_bug.cgi?id=97012

Reviewed by Vsevolod Vlasov.

- queue extensions being added unless initialization is complete;
- add queued extensions upon completion of initialization;

* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype.initExtensions):
(WebInspector.ExtensionServer.prototype._addExtensions):
(WebInspector.ExtensionServer.prototype._addExtension):
(WebInspector.ExtensionServer.prototype._innerAddExtension):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Unskip the right ietestcenter tests after r128802.
rakuco@webkit.org [Tue, 18 Sep 2012 14:11:00 +0000 (14:11 +0000)]
[EFL] Unskip the right ietestcenter tests after r128802.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate my e-mail address.
hausmann@webkit.org [Tue, 18 Sep 2012 14:08:01 +0000 (14:08 +0000)]
Update my e-mail address.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Use UndoStep::editingAction() to set the text of undo/redo actions
caio.oliveira@openbossa.org [Tue, 18 Sep 2012 14:05:07 +0000 (14:05 +0000)]
[Qt] Use UndoStep::editingAction() to set the text of undo/redo actions
https://bugs.webkit.org/show_bug.cgi?id=96921

Reviewed by Ryosuke Niwa.

Set the text of QUndoCommands we create for undo/redo actions based on the
editing action from UndoStep.

This change is visible using QtTestBrowser, and looking at the Edit menu after
doing HTML editing changes. I've used http://simple-rte.rniwa.com for testing.

* WebCoreSupport/UndoStepQt.cpp:
(undoNameForEditAction): This function returns a localized name of the action.
(UndoStepQt::UndoStepQt): Set the text based on UndoStep::editingAction.
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage):
(tst_QWebPage::undoActionHaveCustomText): Create a new test to verify that the text
describing the undo action after inserting a text and indenting the text is different.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate my e-mail address.
abecsi@webkit.org [Tue, 18 Sep 2012 14:03:48 +0000 (14:03 +0000)]
Update my e-mail address.

Unreviewed.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] qt_webkit.pri should not be listed in Tools.pro
abecsi@webkit.org [Tue, 18 Sep 2012 13:58:20 +0000 (13:58 +0000)]
[Qt] qt_webkit.pri should not be listed in Tools.pro

Reviewed and rubber-stamped by Simon Hausmann and Tor Arne Vestbø.

Since r128751 the module pri file is auto-generated
but it was still listed in OTHER_FILES.

Patch by Andras Becsi <andras.becsi@digia.com> on 2012-09-18

* Tools.pro: Remove unneeded line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix build with some versions of the gold linker
hausmann@webkit.org [Tue, 18 Sep 2012 13:51:18 +0000 (13:51 +0000)]
[Qt] Fix build with some versions of the gold linker

Reviewed by Tor Arne Vestbø.

Don't unconditionally pass --no-keep-memory to the linker, some versions might not support it.
Instead run a compile/link test first to see if it works.

* qmake/config.tests/gnuld/gnuld.pro: Added.
* qmake/config.tests/gnuld/main.cpp: Added.
(main):
* qmake/mkspecs/features/unix/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Remove forced use of gold.
hausmann@webkit.org [Tue, 18 Sep 2012 13:37:47 +0000 (13:37 +0000)]
[Qt] Remove forced use of gold.

Reviewed by Tor Arne Vestbø.

The choice of what linker to use with WebKit should be taken by Qt's build system and ideally the same for all
modules of Qt. Then in turn it is usually up to the administrator of the machine. Recent Debian based systems
often offer the automatic use of gold through a symlink and a dpkg-diversion when installing the gold package.

* qmake/mkspecs/features/unix/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Prospective Qt/Windows cross-compiling fix
hausmann@webkit.org [Tue, 18 Sep 2012 13:29:43 +0000 (13:29 +0000)]
[Qt] Prospective Qt/Windows cross-compiling fix

Reviewed by Tor Arne Vestbø.

The win32 scope is not set when cross-compiling from Linux to Windows.

* qmake/mkspecs/features/functions.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r128849.
commit-queue@webkit.org [Tue, 18 Sep 2012 13:23:07 +0000 (13:23 +0000)]
Unreviewed, rolling out r128849.
http://trac.webkit.org/changeset/128849
https://bugs.webkit.org/show_bug.cgi?id=97007

Causes test_ewk2_view to time out. (Requested by rakuco on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-18

* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_webprocess_crashed):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/ewk_view_private.h:
* UIProcess/API/efl/ewk_view_ui_client.cpp:
(ewk_view_ui_client_attach):
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Rebaseline several test cases in Skipped list
commit-queue@webkit.org [Tue, 18 Sep 2012 13:02:17 +0000 (13:02 +0000)]
[EFL] Rebaseline several test cases in Skipped list
https://bugs.webkit.org/show_bug.cgi?id=97000

Unreviewed EFL gardening.

Rebaseline several test cases an unskip them.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-18

* platform/efl/Skipped:
* platform/efl/TestExpectations:
* platform/efl/animations/additive-transform-animations-expected.txt: Added.
* platform/efl/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
* platform/efl/animations/cross-fade-webkit-mask-box-image-expected.txt: Added.
* platform/efl/fast/events/offsetX-offsetY-expected.txt: Removed.
* platform/efl/fast/events/pointer-events-2-expected.png:
* platform/efl/fast/events/pointer-events-2-expected.txt:
* platform/efl/fast/forms/001-expected.png:
* platform/efl/fast/forms/001-expected.txt:
* platform/efl/fast/forms/float-before-fieldset-expected.png:
* platform/efl/fast/forms/float-before-fieldset-expected.txt:
* platform/efl/fast/forms/form-element-geometry-expected.png:
* platform/efl/fast/forms/form-element-geometry-expected.txt:
* platform/efl/fast/forms/input-baseline-expected.png:
* platform/efl/fast/forms/input-baseline-expected.txt:
* platform/efl/fast/forms/input-placeholder-visibility-1-expected.png:
* platform/efl/fast/forms/input-placeholder-visibility-1-expected.txt:
* platform/efl/fast/forms/input-text-scroll-left-on-blur-expected.png:
* platform/efl/fast/forms/input-text-scroll-left-on-blur-expected.txt:
* platform/efl/fast/forms/mailto/advanced-get-expected.txt: Added.
* platform/efl/fast/forms/mailto/advanced-put-expected.txt: Added.
* platform/efl/fast/forms/placeholder-position-expected.png:
* platform/efl/fast/forms/placeholder-position-expected.txt:
* platform/efl/fast/forms/placeholder-pseudo-style-expected.png:
* platform/efl/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/efl/fast/forms/textarea-placeholder-pseudo-style-expected.png:
* platform/efl/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
* platform/efl/fast/gradients/generated-gradients-expected.png:
* platform/efl/fast/gradients/generated-gradients-expected.txt:
* platform/efl/fast/gradients/radial-centered-expected.png:
* platform/efl/fast/gradients/radial-centered-expected.txt:
* platform/efl/fast/inline-block/contenteditable-baseline-expected.png:
* platform/efl/fast/inline-block/contenteditable-baseline-expected.txt:
* platform/efl/fast/inline/continuation-outlines-with-layers-2-expected.png:
* platform/efl/fast/inline/continuation-outlines-with-layers-2-expected.txt:
* platform/efl/fast/inline/inline-box-background-expected.png:
* platform/efl/fast/inline/inline-box-background-expected.txt:
* platform/efl/fast/inline/inline-box-background-long-image-expected.png:
* platform/efl/fast/inline/inline-box-background-long-image-expected.txt:
* platform/efl/fast/inline/inline-box-background-repeat-x-expected.png:
* platform/efl/fast/inline/inline-box-background-repeat-x-expected.txt:
* platform/efl/fast/inline/inline-box-background-repeat-y-expected.png:
* platform/efl/fast/inline/inline-box-background-repeat-y-expected.txt:
* platform/efl/fast/invalid/nestedh3s-expected.png:
* platform/efl/fast/invalid/nestedh3s-expected.txt:
* platform/efl/fast/overflow/overflow-float-stacking-expected.png:
* platform/efl/fast/overflow/overflow-float-stacking-expected.txt:
* platform/efl/fast/overflow/overflow-stacking-expected.png:
* platform/efl/fast/overflow/overflow-stacking-expected.txt:
* platform/efl/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/efl/fast/repaint/block-layout-inline-children-replaced-expected.txt:
* platform/efl/fast/repaint/japanese-rl-selection-clear-expected.png:
* platform/efl/fast/repaint/japanese-rl-selection-clear-expected.txt:
* platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.png:
* platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.txt:
* platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.png:
* platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
* platform/efl/fast/repaint/moving-shadow-on-path-expected.png:
* platform/efl/fast/repaint/moving-shadow-on-path-expected.txt:
* platform/efl/fast/repaint/repaint-svg-after-style-change-expected.png: Added.
* platform/efl/fast/repaint/repaint-svg-after-style-change-expected.txt: Added.
* platform/efl/fast/repaint/table-section-repaint-expected.txt:
* platform/efl/fast/repaint/transform-absolute-in-positioned-container-expected.png:
* platform/efl/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
* platform/efl/fast/replaced/width100percent-searchfield-expected.png:
* platform/efl/fast/replaced/width100percent-searchfield-expected.txt:
* platform/efl/fast/table/027-expected.png:
* platform/efl/fast/table/027-expected.txt:
* platform/efl/fast/table/027-vertical-expected.png:
* platform/efl/fast/table/027-vertical-expected.txt:
* platform/efl/fast/table/032-expected.png:
* platform/efl/fast/table/032-expected.txt:
* platform/efl/fast/table/040-expected.png:
* platform/efl/fast/table/040-expected.txt:
* platform/efl/fast/table/040-vertical-expected.png:
* platform/efl/fast/table/040-vertical-expected.txt:
* platform/efl/fast/table/absolute-table-at-bottom-expected.png:
* platform/efl/fast/table/absolute-table-at-bottom-expected.txt:
* platform/efl/fast/table/border-collapsing/004-expected.png:
* platform/efl/fast/table/border-collapsing/004-expected.txt:
* platform/efl/fast/table/border-collapsing/004-vertical-expected.png:
* platform/efl/fast/table/border-collapsing/004-vertical-expected.txt:
* platform/efl/fast/table/dynamic-caption-add-before-child-expected.png:
* platform/efl/fast/table/dynamic-caption-add-before-child-expected.txt:
* platform/efl/fast/table/frame-and-rules-expected.png:
* platform/efl/fast/table/frame-and-rules-expected.txt:
* platform/efl/fast/table/multiple-captions-display-expected.png: Added.
* platform/efl/fast/table/multiple-captions-display-expected.txt:
* platform/efl/media/video-colorspace-yuv420-expected.png: Added.
* platform/efl/media/video-colorspace-yuv420-expected.txt: Added.
* platform/efl/media/video-colorspace-yuv422-expected.png: Added.
* platform/efl/media/video-colorspace-yuv422-expected.txt: Added.
* platform/efl/perf/nested-combined-selectors-expected.txt: Added.
* platform/efl/userscripts/script-run-at-end-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Gardening after r128802.
rakuco@webkit.org [Tue, 18 Sep 2012 12:56:41 +0000 (12:56 +0000)]
[EFL] Gardening after r128802.

* platform/efl/TestExpectations: Temporarily skip a few JS tests
which are crashing after r128802.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] min-device-width failures in media tests
commit-queue@webkit.org [Tue, 18 Sep 2012 12:55:04 +0000 (12:55 +0000)]
[EFL] min-device-width failures in media tests
https://bugs.webkit.org/show_bug.cgi?id=96920

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-18
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Return a realistic value (800x600) for screen resolution if
it cannot be detected, instead of returning (0x0).

This allows for some tests to pass on the build bots
where X is not running.

No new tests, already covered by existing tests.

* platform/efl/PlatformScreenEfl.cpp:
(WebCore::screenRect):

LayoutTests:

Unskip several test cases which should pass on the
build bots now that we return a realistic screen
resolution whenever it cannot be detected.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Clarify TestExpectations file
commit-queue@webkit.org [Tue, 18 Sep 2012 12:51:30 +0000 (12:51 +0000)]
[EFL][WK2] Clarify TestExpectations file
https://bugs.webkit.org/show_bug.cgi?id=97003

Unreviewed EFL gardening.

Slight reorganization and bug numbers updating
in EFL WK2 TestExpectations for clarity.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-18

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r128802): It made some JS tests crash
ossy@webkit.org [Tue, 18 Sep 2012 12:39:51 +0000 (12:39 +0000)]
REGRESSION(r128802): It made some JS tests crash
https://bugs.webkit.org/show_bug.cgi?id=97001

Unreviewed gardening, skip the new _crashing_ tests to paint the bots green.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix compilation with Qt 5 on MeeGo 1.2 Harmattan
commit-queue@webkit.org [Tue, 18 Sep 2012 12:21:44 +0000 (12:21 +0000)]
Fix compilation with Qt 5 on MeeGo 1.2 Harmattan
https://bugs.webkit.org/show_bug.cgi?id=96937

Patch by Simon Hausmann <simon.hausmann@digia.com> on 2012-09-18
Reviewed by Jocelyn Turcotte.

The gl2ext.h header file on the platform is outdated. Instead use the newer copy from Qt
through implicit inclusion of qopengl.h. Since Qt's declarations are based on newer Khronos
headers, the multi sampling extensions do have the PROC suffix, we need the same workaround
as QNX.

* platform/graphics/opengl/Extensions3DOpenGLES.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Remove background view on EWebLauncher and MiniBrowser
commit-queue@webkit.org [Tue, 18 Sep 2012 12:05:31 +0000 (12:05 +0000)]
[EFL] Remove background view on EWebLauncher and MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=96905

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-09-18
Reviewed by Gyuyoung Kim.

The size of webview was changed after adding url bar.
And the background view is not necessary anymore, since it was used for debugging back in the day.

* EWebLauncher/main.c:
(_ELauncher):
(on_ecore_evas_resize):
(browserCreate):
* MiniBrowser/efl/main.c:
(_MiniBrowser):
(on_ecore_evas_resize):
(browserCreate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Extensions API] explicitly manage extension audit progress
caseq@chromium.org [Tue, 18 Sep 2012 11:41:16 +0000 (11:41 +0000)]
Web Inspector: [Extensions API] explicitly manage extension audit progress
https://bugs.webkit.org/show_bug.cgi?id=96803

Reviewed by Alexander Pavlov.

Source/WebCore:

- create a sub-progress per audit category;
- manage audit category progress within the category, not in the panel logic;
- consider audit is done when all categories are done;
- expose AuditResults.updateProgress(worked, totalWork) in the extensions API;
- retain old magic for computing audit progress if extension specifies extension results count.

* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel.prototype._executeAudit.ruleResultReadyCallback):
(WebInspector.AuditsPanel.prototype._executeAudit):
(WebInspector.AuditCategory.prototype.run.callbackWrapper):
(WebInspector.AuditCategory.prototype.run):
* inspector/front-end/ExtensionAPI.js:
(defineCommonExtensionSymbols):
(injectedExtensionAPI.Audits.prototype.addCategory):
(injectedExtensionAPI.AuditResultImpl.prototype.updateProgress):
* inspector/front-end/ExtensionAuditCategory.js:
(WebInspector.ExtensionAuditCategory.prototype.run):
(WebInspector.ExtensionAuditCategoryResults):
(WebInspector.ExtensionAuditCategoryResults.prototype.done):
(WebInspector.ExtensionAuditCategoryResults.prototype._addResult):
(WebInspector.ExtensionAuditCategoryResults.prototype.updateProgress):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._onUpdateAuditProgress):
(WebInspector.ExtensionServer.prototype._onStopAuditCategoryRun):
* inspector/front-end/ProgressBar.js:
(WebInspector.ProgressIndicator.prototype.done): Assure only first call to done() has effect.

LayoutTests:

* inspector/extensions/extensions-audits-api-expected.txt: Added AuditResults.updateProgress()
* inspector/extensions/extensions-audits.html: Added a call to updateProgress()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] run-webkit-tests unable to find TestExpectations for WK2
sergio@webkit.org [Tue, 18 Sep 2012 11:33:03 +0000 (11:33 +0000)]
[GTK] run-webkit-tests unable to find TestExpectations for WK2
https://bugs.webkit.org/show_bug.cgi?id=96998

Reviewed by Philippe Normand.

We should look for TestExpectations files in all the locations where
we currently look for Skipped files. This will allow
run-webkit-tests to look for TestExpectations files in
platform/gtk-wk2 and platform/wk2 if the "-2" flag is used.

* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.expectations_files):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Unreviewed gardening.
rakuco@webkit.org [Tue, 18 Sep 2012 11:14:03 +0000 (11:14 +0000)]
[EFL] Unreviewed gardening.

Update some pixel expectations after a long time.
japanese-lr-selection-expected.png now actually shows a selection
background, some shadows are displayed properly and some fonts
have had rendering adjustments.

* platform/efl/fast/writing-mode/basic-vertical-line-expected.png:
* platform/efl/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png:
* platform/efl/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
* platform/efl/fast/writing-mode/box-shadow-vertical-lr-expected.png:
* platform/efl/fast/writing-mode/box-shadow-vertical-rl-expected.png:
* platform/efl/fast/writing-mode/english-bt-text-expected.png:
* platform/efl/fast/writing-mode/english-rl-text-expected.png:
* platform/efl/fast/writing-mode/fieldsets-expected.png:
* platform/efl/fast/writing-mode/japanese-lr-selection-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Gardening after r128802.
rakuco@webkit.org [Tue, 18 Sep 2012 10:57:28 +0000 (10:57 +0000)]
[EFL] Gardening after r128802.

* platform/efl/TestExpectations: Unskip test that is now passing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Set the area of tooltips in WebKit2
carlosgc@webkit.org [Tue, 18 Sep 2012 10:34:40 +0000 (10:34 +0000)]
[GTK] Set the area of tooltips in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=96618

Reviewed by Martin Robinson.

In GTK+ tooltips are associated to a widget, if the mouse is moved
inside the widget area, the tooltip position doesn't change even
if the tooltip text changes. To support multiple tooltips for the
same widget, we need to set the area of the widget for every
tooltip.

* Shared/WebHitTestResult.cpp:
(WebKit::WebHitTestResult::Data::encode): Encode elementBoundingBox.
(WebKit::WebHitTestResult::Data::decode): Decode elementBoundingBox.
* Shared/WebHitTestResult.h:
(Data): Add elementBoundingBox to WebHitTestResult::Data.
(WebKit::WebHitTestResult::Data::elementBoundingBoxInWindowCoordinates):
Get the bounding box of the inner non shared node of the hit test
result in window coordinates.
(WebKit::WebHitTestResult::Data::Data):
(WebKit::WebHitTestResult::elementBoundingBox):
(WebHitTestResult):
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewMouseTargetChanged): Call webkitWebViewBaseSetTooltipArea.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseQueryTooltip): Use the tooltipArea if it's not empty.
(webkitWebViewBaseSetTooltipArea): Set the tooltipArea.
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Unreviewed gardening.
rakuco@webkit.org [Tue, 18 Sep 2012 10:29:02 +0000 (10:29 +0000)]
[EFL] Unreviewed gardening.

Update MathML expectations after r128837.

* platform/efl/mathml/presentation/attributes-expected.txt:
* platform/efl/mathml/presentation/fenced-expected.txt:
* platform/efl/mathml/presentation/fenced-mi-expected.png:
* platform/efl/mathml/presentation/fenced-mi-expected.txt:
* platform/efl/mathml/presentation/fractions-expected.txt:
* platform/efl/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/efl/mathml/presentation/mo-stretch-expected.png:
* platform/efl/mathml/presentation/mo-stretch-expected.txt:
* platform/efl/mathml/presentation/mroot-pref-width-expected.txt:
* platform/efl/mathml/presentation/roots-expected.txt:
* platform/efl/mathml/presentation/row-alignment-expected.png:
* platform/efl/mathml/presentation/row-alignment-expected.txt:
* platform/efl/mathml/presentation/style-expected.txt:
* platform/efl/mathml/presentation/sub-expected.txt:
* platform/efl/mathml/presentation/subsup-expected.png:
* platform/efl/mathml/presentation/subsup-expected.txt:
* platform/efl/mathml/presentation/sup-expected.txt:
* platform/efl/mathml/presentation/tables-expected.png:
* platform/efl/mathml/presentation/tables-expected.txt:
* platform/efl/mathml/presentation/tokenElements-expected.txt:
* platform/efl/mathml/presentation/under-expected.txt:
* platform/efl/mathml/presentation/underover-expected.txt:
* platform/efl/mathml/xHeight-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert r127457 and following fixes due to several hit-testing regressions
allan.jensen@nokia.com [Tue, 18 Sep 2012 10:28:02 +0000 (10:28 +0000)]
Revert r127457 and following fixes due to several hit-testing regressions
https://bugs.webkit.org/show_bug.cgi?id=96830

Reviewed by Antonio Gomes.

The revert misssed one related follow-up.

* dom/Document.cpp:
(WebCore::Document::updateHoverActiveState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix build without the QtQuick module
vestbo@webkit.org [Tue, 18 Sep 2012 10:23:13 +0000 (10:23 +0000)]
[Qt] Fix build without the QtQuick module

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed. Attempt at greening the WinCairo bot. Touching
mark.lam@apple.com [Tue, 18 Sep 2012 09:42:38 +0000 (09:42 +0000)]
Not reviewed. Attempt at greening the WinCairo bot. Touching
LowLevelInterpreter.asm to trigger a rebuild of LLIntDesiredOffsets.
https://bugs.webkit.org/show_bug.cgi?id=96992.

* llint/LowLevelInterpreter.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Unskip fast/js/global-constructors.html
commit-queue@webkit.org [Tue, 18 Sep 2012 09:32:15 +0000 (09:32 +0000)]
[EFL] Unskip fast/js/global-constructors.html
https://bugs.webkit.org/show_bug.cgi?id=96984

Unreviewed EFL gardening.

Generate baseline for fast/js/global-constructors.html
and unskip test. The only differences in the expected
output are due to webkit prefix.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-18

* fast/js/global-constructors-expected.txt: Added.
* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] REGRESSION(r128790): It broke the ARM build
kadam@inf.u-szeged.hu [Tue, 18 Sep 2012 09:11:05 +0000 (09:11 +0000)]
[Qt] REGRESSION(r128790): It broke the ARM build
https://bugs.webkit.org/show_bug.cgi?id=96968

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2012-09-18
Reviewed by Filip Pizlo.

Implement the missing or32 method in the MacroAssemblerARM.h.

* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::or32):
(MacroAssemblerARM):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix after http://trac.webkit.org/projects/webkit/changeset/128852.
slewis@apple.com [Tue, 18 Sep 2012 09:11:01 +0000 (09:11 +0000)]
Build fix after trac.webkit.org/projects/webkit/changeset/128852.

Unreviewed.

* DumpRenderTree/mac/DumpRenderTree.mm:
(poseAsClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Skipped failing tests because eventSender.gestureTap
kkristof@inf.u-szeged.hu [Tue, 18 Sep 2012 08:58:53 +0000 (08:58 +0000)]
[Qt] Skipped failing tests because eventSender.gestureTap
is not implemented on Qt, ENABLE(SHADOW_DOM) is disabled and
WebKitDisplayImagesKey is not supported.

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-09-18
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 18 Sep 2012 08:46:04 +0000 (08:46 +0000)]
Unreviewed GTK gardening.

Rebaselining MathML tests' baselines after r128837.

* platform/gtk/mathml/presentation/attributes-expected.png:
* platform/gtk/mathml/presentation/attributes-expected.txt:
* platform/gtk/mathml/presentation/fenced-expected.txt:
* platform/gtk/mathml/presentation/fenced-mi-expected.png:
* platform/gtk/mathml/presentation/fenced-mi-expected.txt:
* platform/gtk/mathml/presentation/fractions-expected.png:
* platform/gtk/mathml/presentation/fractions-expected.txt:
* platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png:
* platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/gtk/mathml/presentation/mo-expected.png:
* platform/gtk/mathml/presentation/mo-expected.txt:
* platform/gtk/mathml/presentation/mo-stretch-expected.png:
* platform/gtk/mathml/presentation/mo-stretch-expected.txt:
* platform/gtk/mathml/presentation/mroot-pref-width-expected.txt:
* platform/gtk/mathml/presentation/over-expected.png:
* platform/gtk/mathml/presentation/over-expected.txt:
* platform/gtk/mathml/presentation/roots-expected.png:
* platform/gtk/mathml/presentation/roots-expected.txt:
* platform/gtk/mathml/presentation/row-alignment-expected.png:
* platform/gtk/mathml/presentation/row-alignment-expected.txt:
* platform/gtk/mathml/presentation/row-expected.png:
* platform/gtk/mathml/presentation/row-expected.txt:
* platform/gtk/mathml/presentation/style-expected.png:
* platform/gtk/mathml/presentation/style-expected.txt:
* platform/gtk/mathml/presentation/sub-expected.png:
* platform/gtk/mathml/presentation/sub-expected.txt:
* platform/gtk/mathml/presentation/subsup-expected.png:
* platform/gtk/mathml/presentation/subsup-expected.txt:
* platform/gtk/mathml/presentation/sup-expected.png:
* platform/gtk/mathml/presentation/sup-expected.txt:
* platform/gtk/mathml/presentation/tables-expected.png:
* platform/gtk/mathml/presentation/tables-expected.txt:
* platform/gtk/mathml/presentation/tokenElements-expected.txt:
* platform/gtk/mathml/presentation/under-expected.png:
* platform/gtk/mathml/presentation/under-expected.txt:
* platform/gtk/mathml/presentation/underover-expected.png:
* platform/gtk/mathml/presentation/underover-expected.txt:
* platform/gtk/mathml/xHeight-expected.png: Added.
* platform/gtk/mathml/xHeight-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSSRegions]Flag auto-height regions
mihnea@adobe.com [Tue, 18 Sep 2012 08:39:59 +0000 (08:39 +0000)]
[CSSRegions]Flag auto-height regions
https://bugs.webkit.org/show_bug.cgi?id=96267

Reviewed by Julien Chaffraix.

Source/WebCore:

The regions having auto logical height should be flagged so that their height will computed as part of a 2 pass-layout mechanism.
A valid region is flagged as having auto logical height if:
- has auto logical height and is part of the normal flow
- has auto logical height, is not part of normal flow and does not have logical top/bottom specified

An invalid region (part of circular dependency) will not be marked even if its style matches the above situations.

Test: fast/regions/autoheight-regions-mark.html

* rendering/FlowThreadController.cpp: Keep a counter of auto logical height valid regions.
(WebCore::FlowThreadController::FlowThreadController):
(WebCore::FlowThreadController::layoutRenderNamedFlowThreads): Verify that the current number of auto logical height regions is correct by iterating over all the regions attached to the flow threads
and compute the number of auto logical height regions on the spot.
(WebCore):
(WebCore::FlowThreadController::isAutoLogicalHeightRegionsFlagConsistent): Helper function that is used to verify the number of auto logical height regions.
* rendering/FlowThreadController.h:
(WebCore::FlowThreadController::hasAutoLogicalHeightRegions):
(WebCore::FlowThreadController::incrementAutoLogicalHeightRegions):
(WebCore::FlowThreadController::decrementAutoLogicalHeightRegions):
(FlowThreadController):
* rendering/RenderFlowThread.cpp:
(WebCore):
(WebCore::RenderFlowThread::autoLogicalHeightRegionsCount): Helper function that is used to count the number of regions marked as having auto logical height.
* rendering/RenderFlowThread.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::updateRegionHasAutoLogicalHeightFlag):
(WebCore):
(WebCore::RenderRegion::styleDidChange): For a region that is attached to a flow thread, verify whether the style change modified its auto logical height appearance.
(WebCore::RenderRegion::attachRegion): Handle the case of attaching region to a flow thread and the detach/attach sequence when the region is moved in the render tree.
(WebCore::RenderRegion::detachRegion):
* rendering/RenderRegion.h:
(WebCore::RenderRegion::shouldHaveAutoLogicalHeight):
(WebCore::RenderRegion::hasAutoLogicalHeight):
(RenderRegion):
* rendering/RenderTreeAsText.cpp: For the regions that use auto logical height, modify the output to reflect that.
(WebCore::writeRenderNamedFlowThreads):

LayoutTests:

The regions having auto logical height should be flagged so that their height will computed as part of a 2 pass-layout mechanism.
Added a test that checks whether a region in several situations is marked properly.

* fast/regions/autoheight-regions-mark.html: Added.
* platform/mac/fast/regions/autoheight-regions-mark-expected.png: Added.
* platform/mac/fast/regions/autoheight-regions-mark-expected.txt: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for WinCairo builds.
mark.lam@apple.com [Tue, 18 Sep 2012 08:35:12 +0000 (08:35 +0000)]
Fix for WinCairo builds.
https://bugs.webkit.org/show_bug.cgi?id=96992.

Reviewed by Filip Pizlo.

Adding additional vcproj build targets in LLIntDesiredOffsets.vcproj,
LLIntOffsetsExtractor.vcproj, and LLIntAssembly.vcproj to match those
in jsc.vcproj.

* JavaScriptCore.vcproj/LLIntAssembly/LLIntAssembly.vcproj:
* JavaScriptCore.vcproj/LLIntDesiredOffsets/LLIntDesiredOffsets.vcproj:
* JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcproj:
* JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorCommon.vsprops: Added property svn:eol-style.
* JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorDebug.vsprops: Added property svn:eol-style.
* JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorDebugAll.vsprops: Added.
* JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorDebugCairoCFLite.vsprops: Added.
* JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorProduction.vsprops: Added.
* JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorRelease.vsprops: Added property svn:eol-style.
* JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorReleaseCairoCFLite.vsprops: Added.
* JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorReleasePGO.vsprops: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed update of email addresses for Berlin QtWebKit office.
allan.jensen@nokia.com [Tue, 18 Sep 2012 08:21:51 +0000 (08:21 +0000)]
Unreviewed update of email addresses for Berlin QtWebKit office.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Prevent scroll adjustment of input fields when region of interest mechan...
anilsson@rim.com [Tue, 18 Sep 2012 08:17:21 +0000 (08:17 +0000)]
[BlackBerry] Prevent scroll adjustment of input fields when region of interest mechanism active
https://bugs.webkit.org/show_bug.cgi?id=96750

Reviewed by Antonio Gomes.

The region of interest mechanism replaces the scrolling/zooming
functionality in InputHandler::ensureFocusTextElementVisible().

We introduce a new fine-grained setting for the various adjustment
modes. The WebKit embedder can disable all scroll types in favor of the
region of interest mechanism by using the new setting.

PR #208387

Reviewed internally by Mike Fenton.

* WebKitSupport/AboutData.cpp:
(BlackBerry::WebKit::configPage):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
* WebKitSupport/InputHandler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, fix sloppy English in comment.
fpizlo@apple.com [Tue, 18 Sep 2012 07:29:03 +0000 (07:29 +0000)]
Unreviewed, fix sloppy English in comment.

* runtime/JSGlobalObject.cpp:
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDisable adding an AuthorShadowRoot to replaced elements.
shinyak@chromium.org [Tue, 18 Sep 2012 07:28:23 +0000 (07:28 +0000)]
Disable adding an AuthorShadowRoot to replaced elements.
https://bugs.webkit.org/show_bug.cgi?id=96978

Reviewed by Hajime Morita.

Source/WebCore:

We (people who implement Shadow DOM) have concluded that we don't support adding AuthorShadowRoot to
replaced elements in the current spec, since it turned out that a lot of difficulties exist and it brings
a lot of mess to our codebase.

For now, we just disable adding AuthorShadowRoot to these replaced elements.

Test: fast/dom/shadow/shadow-disable.html

* html/HTMLImageElement.h:
* html/HTMLKeygenElement.h:
* html/HTMLMeterElement.h:
* html/HTMLProgressElement.h:
* html/HTMLTextAreaElement.h:

LayoutTests:

Since we don't support AuthorShadowRoot for replaced elements for now, we enable a flat to
support AuthorShadowRoot in these tests.

Also, we have a test to check to reject adding ShadowRoot to repalced elements.

* fast/dom/shadow/select-image-with-shadow.html:
* fast/dom/shadow/shadow-disable-expected.txt:
* fast/dom/shadow/shadow-disable.html: Checks WebKit rejects adding ShadowRoot to repalced elements.
* fast/dom/shadow/shadowdom-for-fieldset-only-shadow.html:
* fast/dom/shadow/shadowdom-for-image-alt-update.html:
* fast/dom/shadow/shadowdom-for-image-alt.html:
* fast/dom/shadow/shadowdom-for-image-content.html:
* fast/dom/shadow/shadowdom-for-image-dynamic.html:
* fast/dom/shadow/shadowdom-for-image-event-click.html:
* fast/dom/shadow/shadowdom-for-image-event.html:
* fast/dom/shadow/shadowdom-for-image-in-shadowdom.html:
* fast/dom/shadow/shadowdom-for-image-map.html:
* fast/dom/shadow/shadowdom-for-image-style.html:
* fast/dom/shadow/shadowdom-for-image-with-multiple-shadow.html:
* fast/dom/shadow/shadowdom-for-image-with-pseudo-id.html:
* fast/dom/shadow/shadowdom-for-image-with-width-and-height.html:
* fast/dom/shadow/shadowdom-for-image.html:
* fast/dom/shadow/shadowdom-for-keygen-complex-shadow.html:
* fast/dom/shadow/shadowdom-for-keygen-without-shadow.html:
* fast/dom/shadow/shadowdom-for-meter-dynamic.html:
* fast/dom/shadow/shadowdom-for-meter-multiple.html:
* fast/dom/shadow/shadowdom-for-meter-with-style.html:
* fast/dom/shadow/shadowdom-for-meter-without-appearance.html:
* fast/dom/shadow/shadowdom-for-meter-without-shadow-element.html:
* fast/dom/shadow/shadowdom-for-meter.html:
* fast/dom/shadow/shadowdom-for-object-only-shadow.html:
* fast/dom/shadow/shadowdom-for-progress-dynamic.html:
* fast/dom/shadow/shadowdom-for-progress-multiple.html:
* fast/dom/shadow/shadowdom-for-progress-with-style.html:
* fast/dom/shadow/shadowdom-for-progress-without-appearance.html:
* fast/dom/shadow/shadowdom-for-progress-without-shadow-element.html:
* fast/dom/shadow/shadowdom-for-progress.html:
* fast/dom/shadow/shadowdom-for-textarea-complex-shadow.html:
* fast/dom/shadow/shadowdom-for-textarea-with-placeholder.html:
* fast/dom/shadow/shadowdom-for-textarea-without-shadow.html:
* fast/dom/shadow/shadowdom-for-textarea.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CMAKE] Fix build break because of memory exhausted.
ryuan.choi@samsung.com [Tue, 18 Sep 2012 07:20:05 +0000 (07:20 +0000)]
[CMAKE] Fix build break because of memory exhausted.
https://bugs.webkit.org/show_bug.cgi?id=77327

Reviewed by Gyuyoung Kim.

Added to avoid memory exhaustion on 32bit linux debug build.

* Source/cmake/OptionsCommon.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html...
zandobersek@gmail.com [Tue, 18 Sep 2012 06:56:36 +0000 (06:56 +0000)]
[GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
https://bugs.webkit.org/show_bug.cgi?id=96899

Reviewed by Martin Robinson.

Tools:

When overriding the 'WebKitDisplayImageKey' preference, use the
'auto-load-images' property of WebKitWebSettings as the property which
should be updated with the corresponding preference value.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
* DumpRenderTree/gtk/TestRunnerGtk.cpp:
(TestRunner::overridePreference):

LayoutTests:

Remove failure expectation for the test in title.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Add NativeWebTouchEvent and handle the Touch event.
commit-queue@webkit.org [Tue, 18 Sep 2012 06:45:09 +0000 (06:45 +0000)]
[EFL][WK2] Add NativeWebTouchEvent and handle the Touch event.
https://bugs.webkit.org/show_bug.cgi?id=90662

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-09-17
Reviewed by Gyuyoung Kim.

Implement codes to handle touch event for WebKit2 EFL port.
Additionally, types and structure for touch event are defined because
they are not in the Evas.

* PlatformEfl.cmake:
* Shared/NativeWebTouchEvent.h:
(NativeWebTouchEvent):
* Shared/efl/NativeWebTouchEventEfl.cpp: Added.
(WebKit):
(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):
* Shared/efl/WebEventFactory.cpp:
(WebKit):
(WebKit::typeForTouchEvent):
(WebKit::WebEventFactory::createWebTouchEvent):
* Shared/efl/WebEventFactory.h:
(WebEventFactory):
* UIProcess/API/efl/ewk_touch.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
psolanki@apple.com [Tue, 18 Sep 2012 06:34:55 +0000 (06:34 +0000)]
DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
https://bugs.webkit.org/show_bug.cgi?id=96973

Reviewed by Dan Bernstein.

* DumpRenderTree/mac/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/Base.xcconfig:
* WebKitTestRunner/PlatformWebView.h: Use #ifdef __OBJC__ and not #if.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128852 268f45cc-cd09-0410-ab3c-d52691b4dbfc