WebKit-https.git
15 years agoLayoutTests:
justing [Mon, 25 Sep 2006 21:59:43 +0000 (21:59 +0000)]
LayoutTests:

        Reviewed by john

        * editing/execCommand/indent-empty-root-expected.checksum: Added.
        * editing/execCommand/indent-empty-root-expected.png: Added.
        * editing/execCommand/indent-empty-root-expected.txt: Added.
        * editing/execCommand/indent-empty-root.html: Added.

WebCore:

        Reviewed by john

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=11002>
        Gmail Editor: Crash at WebCore::SplitElementCommand::doApply() when attempting to indent in a new message

        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::indentRegion): Special case
        an empty root editable element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMath error in SystemTimeWin
beidson [Mon, 25 Sep 2006 21:40:08 +0000 (21:40 +0000)]
Math error in SystemTimeWin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBuild fix to avoid property name conflict warning.
thatcher [Mon, 25 Sep 2006 21:31:27 +0000 (21:31 +0000)]
Build fix to avoid property name conflict warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
ap [Mon, 25 Sep 2006 20:41:33 +0000 (20:41 +0000)]
    Reviewed by Eric.

        Whitespace cleanup; rename *job variables to *loader.

        * bindings/js/JSXMLHttpRequest.cpp:
        (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
        (KJS::JSXMLHttpRequestConstructorImp::implementsConstruct):
        (KJS::JSXMLHttpRequestConstructorImp::construct):
        (KJS::JSXMLHttpRequest::getOwnPropertySlot):
        (KJS::JSXMLHttpRequest::getValueProperty):
        (KJS::JSXMLHttpRequest::put):
        (KJS::JSXMLHttpRequest::putValueProperty):
        (KJS::JSXMLHttpRequest::mark):
        (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
        (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
        (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
        * bindings/js/JSXMLHttpRequest.h:
        (KJS::JSXMLHttpRequest::toBoolean):
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::XMLHttpRequest):
        (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
        (WebCore::XMLHttpRequest::send):
        (WebCore::XMLHttpRequest::abort):
        (WebCore::XMLHttpRequest::receivedAllData):
        (WebCore::XMLHttpRequest::receivedData):
        * xml/xmlhttprequest.h:
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
thatcher [Mon, 25 Sep 2006 19:04:09 +0000 (19:04 +0000)]
WebCore:

        Reviewed by Brady.

        - Deprecate the rest of the old-style methods that are not generated.
        - Add @property syntax to DOMRange.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOM.mm:
        (-[DOMRange setStart:offset:]):
        (-[DOMRange setEnd:offset:]):
        (-[DOMRange compareBoundaryPoints:sourceRange:]):
        (-[DOMRange setStart::]):
        (-[DOMRange setEnd::]):
        (-[DOMRange compareBoundaryPoints::]):
        (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
        (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
        (-[DOMDocument createNodeIterator::::]):
        (-[DOMDocument createTreeWalker::::]):
        * bindings/objc/DOMCSS.h:
        * bindings/objc/DOMCSS.mm:
        (-[DOMDocument getComputedStyle:pseudoElement:]):
        (-[DOMDocument getComputedStyle::]):
        (-[DOMDocument getMatchedCSSRules:pseudoElement:]):
        * bindings/objc/DOMExtensions.h:
        * bindings/objc/DOMHTML.h:
        * bindings/objc/DOMRange.h:
        * bindings/objc/DOMTraversal.h:

WebKit:

        Reviewed by Brady.

        Use the non-deprecated method names for getComputedStyle, setEnd and setStart.

        * WebInspector/WebInspector.m:
        (-[WebInspector _highlightNode:]):
        * WebView/WebHTMLView.m:
        (unionDOMRanges):
        (-[WebHTMLView _selectRangeInMarkedText:]):
        (-[WebTextCompleteController doCompletion]):
        * WebView/WebView.m:
        (-[WebView computedStyleForElement:pseudoElement:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBuild fix.
thatcher [Mon, 25 Sep 2006 17:37:39 +0000 (17:37 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-25 Eric Seidel <eric@eseidel.com>
eseidel [Mon, 25 Sep 2006 09:52:04 +0000 (09:52 +0000)]
2006-09-25  Eric Seidel  <eric@eseidel.com>

        Reviewed by mjs.

        Outermost <svg> element should clip to viewport
        http://bugzilla.opendarwin.org/show_bug.cgi?id=11007

        Test: svg/custom/viewport-clip.svg

        * css/svg.css: change svg:root overflow: from 'visible' to 'hidden'

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-25 Anders Carlsson <acarlsson@apple.com>
andersca [Mon, 25 Sep 2006 08:08:39 +0000 (08:08 +0000)]
2006-09-25  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Maciej.

        * css/MediaList.cpp:
        Remove unused header.

        * dom/Document.cpp:
        (WebCore::Document::clear):
        Use clear instead of iterating through the list of event listeners, removing each one.
        (Doing that causes a crash when running the layout tests with GuardMalloc turned on)

        * html/HTMLKeygenElement.cpp:
        (WebCore::HTMLKeygenElement::HTMLKeygenElement):
        (WebCore::HTMLKeygenElement::appendFormData):
        Update due to changes in the SSL key generator.

        * ksvg2/svg/SVGAngle.cpp:
        Remove unused header.

        * ksvg2/svg/SVGAnimationElement.cpp:
        (SVGAnimationElement::parseMappedAttribute):
        Rename methods and pass Strings instead of DeprecatedStrings to
        parseSeparatedList.

        * ksvg2/svg/SVGFEColorMatrixElement.cpp:
        * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
        * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
        * ksvg2/svg/SVGFEMergeElement.cpp:
        * ksvg2/svg/SVGFEOffsetElement.cpp:
        Remove unused headers.

        * ksvg2/svg/SVGHelper.cpp:
        (WebCore::SVGHelper::parseSeparatedList):
        * ksvg2/svg/SVGHelper.h:
        Rename ParseSeperatedList to parseSeparatedList, make it take a String instead of a
        DeprecatedString and have it use Vector<String> instead of DeprecatedStringList.

        * ksvg2/svg/SVGLengthList.cpp:
        (WebCore::SVGLengthList::parse):
        * ksvg2/svg/SVGLengthList.h:
        Use Vector<String> instead of DeprecatedStringList.

        * loader/Cache.cpp:
        (WebCore::Cache::requestImage):
        (WebCore::Cache::requestStyleSheet):
        (WebCore::Cache::requestScript):
        (WebCore::Cache::requestXSLStyleSheet):
        (WebCore::Cache::requestXBLDocument):
        (WebCore::Cache::remove):
        (WebCore::Cache::get):
        Use a String as the key in the cache set instead of a RefPtr<StringImpl>.

        * loader/DocLoader.cpp:
        (WebCore::DocLoader::needReload):
        * loader/DocLoader.h:
        Use a HashSet instead of DeprecatedStringList.

        * page/FrameView.h:
        Remove declarations that have no functions.

        * platform/SSLKeyGenerator.h:
        * platform/mac/SSLKeyGeneratorMac.mm:
        (WebCore::supportedKeySizes):
        (WebCore::signedPublicKeyAndChallengeString):
        Convert to use Vector<String> instead of DeprecatedStringList, and String instead of
        DeprecatedString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix win32 cursor build bustage.
hyatt [Mon, 25 Sep 2006 08:06:17 +0000 (08:06 +0000)]
Fix win32 cursor build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoCleanup in RenderThemeWin and GraphicsContextCairo/Win
hyatt [Mon, 25 Sep 2006 07:39:01 +0000 (07:39 +0000)]
Cleanup in RenderThemeWin and GraphicsContextCairo/Win

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-24 Eric Seidel <eric@eseidel.com>
eseidel [Mon, 25 Sep 2006 02:35:09 +0000 (02:35 +0000)]
2006-09-24  Eric Seidel  <eric@eseidel.com>

        Reviewed by beth.

        Browsers disagree on behavior for an invalid fill
        http://bugzilla.opendarwin.org/show_bug.cgi?id=11017

        * svg/custom/invalid-fill-expected.checksum: Added.
        * svg/custom/invalid-fill-expected.png: Added.
        * svg/custom/invalid-fill-expected.txt: Added.
        * svg/custom/invalid-fill.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-24 Eric Seidel <eric@eseidel.com>
eseidel [Mon, 25 Sep 2006 01:30:36 +0000 (01:30 +0000)]
2006-09-24  Eric Seidel  <eric@eseidel.com>

        Reviewed by hyatt.

        <svg:a> cannot be styled with a:hover
        http://bugzilla.opendarwin.org/show_bug.cgi?id=11005

        Test: svg/hixie/cascade/002.xml

        * css/cssstyleselector.cpp:
        (WebCore::checkPseudoState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim H.
weinig [Sun, 24 Sep 2006 22:36:23 +0000 (22:36 +0000)]
    Reviewed by Tim H.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10882
        SVG needs Obj-C DOM bindings

        - Auto-generate the first 8 Objective-C SVG DOM bindings.  The
          auto-generated classes are DOMSVGAngle, DOMSVGLength, DOMSVGLengthList,
          DOMSVGMatrix, DOMSVGPathSeg, DOMSVGPathSegList, DOMSVGTransform, and
          DOMSVGTransformList.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOMInternal.h:
        * bindings/objc/DOMSVG.h: Added.
        * ksvg2/svg/SVGAngle.idl:
        * ksvg2/svg/SVGLength.idl:
        * ksvg2/svg/SVGLengthList.idl:
        * ksvg2/svg/SVGMatrix.idl:
        * ksvg2/svg/SVGPathSeg.idl:
        * ksvg2/svg/SVGPathSegList.idl:
        * ksvg2/svg/SVGTransform.idl:
        * ksvg2/svg/SVGTransformList.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoHopefully this unbreaks the build, should fix linux build too.
rwlbuis [Sun, 24 Sep 2006 20:30:54 +0000 (20:30 +0000)]
Hopefully this unbreaks the build, should fix linux build too.
Thanks to WildFox and buildbot for the notification.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by eseidel.
rwlbuis [Sun, 24 Sep 2006 19:43:13 +0000 (19:43 +0000)]
    Reviewed by eseidel.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6001
        WebKit does not handle fallback custom cursors
        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6002
        WebKit does not properly handle SVG <cursor> element

        Add support for svg cursor images. Also make sure hotspot
        settings are handled correctly. Add tests for handling of css3
        cursor syntax with hotspots in strict and quirks mode. Finally
        implement fallback.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim H.
weinig [Sun, 24 Sep 2006 19:34:43 +0000 (19:34 +0000)]
    Reviewed by Tim H.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11009
        Auto-generate the internal methods interfaces for the Objective-C bindings

        - Auto-generate the internal method declarations into their own files
          named in the form DOMFooBarInternal.h for class DOMFooBar.

        - Remove all use of DOM_cast from code.

        - Assorted cleanups.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOM.mm:
        (-[DOMNode _initWithNode:WebCore::]):
        (-[DOMNode WebCore::]):
        (-[DOMRange dealloc]):
        (-[DOMRange finalize]):
        (-[DOMRange _initWithRange:WebCore::]):
        (-[DOMRange WebCore::]):
        (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
        (-[DOMNodeFilter WebCore::]):
        (-[DOMNodeFilter dealloc]):
        (-[DOMNodeFilter finalize]):
        (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
        (-[DOMNodeIterator WebCore::]):
        (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
        (-[DOMTreeWalker WebCore::]):
        * bindings/objc/DOMAbstractView.mm:
        (-[DOMAbstractView _initWithAbstractView:WebCore::]):
        * bindings/objc/DOMCSS.mm:
        (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
        (-[DOMCSSRule _initWithRule:WebCore::]):
        (-[DOMCSSValue _initWithValue:WebCore::]):
        * bindings/objc/DOMEvents.mm:
        (-[DOMEvent _initWithEvent:WebCore::]):
        * bindings/objc/DOMHTMLAppletElement.mm:
        (-[DOMHTMLAppletElement align]):
        (-[DOMHTMLAppletElement setAlign:]):
        (-[DOMHTMLAppletElement alt]):
        (-[DOMHTMLAppletElement setAlt:]):
        (-[DOMHTMLAppletElement archive]):
        (-[DOMHTMLAppletElement setArchive:]):
        (-[DOMHTMLAppletElement code]):
        (-[DOMHTMLAppletElement setCode:]):
        (-[DOMHTMLAppletElement codeBase]):
        (-[DOMHTMLAppletElement setCodeBase:]):
        (-[DOMHTMLAppletElement height]):
        (-[DOMHTMLAppletElement setHeight:]):
        (-[DOMHTMLAppletElement hspace]):
        (-[DOMHTMLAppletElement setHspace:]):
        (-[DOMHTMLAppletElement name]):
        (-[DOMHTMLAppletElement setName:]):
        (-[DOMHTMLAppletElement object]):
        (-[DOMHTMLAppletElement setObject:]):
        (-[DOMHTMLAppletElement vspace]):
        (-[DOMHTMLAppletElement setVspace:]):
        (-[DOMHTMLAppletElement width]):
        (-[DOMHTMLAppletElement setWidth:]):
        * bindings/objc/DOMInternal.h:
        (getDOMWrapper):
        (addDOMWrapper):
        (raiseOnDOMError):
        * bindings/objc/DOMXPath.mm:
        (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
        * bindings/scripts/CodeGeneratorObjC.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by eseidel.
rwlbuis [Sun, 24 Sep 2006 14:32:34 +0000 (14:32 +0000)]
    Reviewed by eseidel.

        Fix Qt/Linux build after Dave's Scrollbar changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by eseidel.
rwlbuis [Sun, 24 Sep 2006 14:19:27 +0000 (14:19 +0000)]
    Reviewed by eseidel.

        Qt/Linux build system changes: enable xpath/xslt by default.
        Offer possibility to change all of these using 'ccmake'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoClean up scrollbar API.
hyatt [Sun, 24 Sep 2006 07:23:03 +0000 (07:23 +0000)]
Clean up scrollbar API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
weinig [Sat, 23 Sep 2006 19:03:18 +0000 (19:03 +0000)]
    Reviewed by Eric.

        Build Fix.

        * DumpRenderTree/EventSendingController.m:
        (-[EventSendingController enableDOMUIEventLogging:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
ap [Sat, 23 Sep 2006 18:44:00 +0000 (18:44 +0000)]
    Reviewed by Eric.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=4872
        XMLHttpRequest fails to throw an exception when there is a security violation
        (mismatching domains)

        Raise an exception if there is a security violation, and also in cases required by
        the current draft of XHR specification.

WebCore:
        * bindings/js/JSXMLHttpRequest.cpp:
        (KJS::JSXMLHttpRequest::getValueProperty): Raise an exception if a DOM method reports one.
        (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Raise an exception if a DOM method
        reports one, and also if there were too few arguments passed.

        * bindings/js/kjs_binding.cpp:
        (KJS::setDOMException): Added support for custom XHR exceptions.

        * xml/xmlhttprequest.h: Changed state names to match the current spec. Defined an
        exception code range for XHR exceptions.

        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::open): Removed a check for m_aborted that could never succeed.
        (WebCore::XMLHttpRequest::send):
        (WebCore::XMLHttpRequest::setRequestHeader):
        (WebCore::XMLHttpRequest::getStatus):
        (WebCore::XMLHttpRequest::getStatusText):
        (WebCore::XMLHttpRequest::processSyncLoadResults):
        (WebCore::XMLHttpRequest::receivedAllData):
        (WebCore::XMLHttpRequest::receivedData):

LayoutTests:
        * http/tests/xmlhttprequest/exceptions-expected.txt: Added.
        * http/tests/xmlhttprequest/exceptions.html: Added.

        * http/tests/xmlhttprequest/extra-parameters-expected.txt: Added.
        * http/tests/xmlhttprequest/extra-parameters.html: Added.
        * http/tests/xmlhttprequest/resources/post-echo.cgi: Added.
        Test that passing too many parameters is OK (Firefox behavior; WinIE raises an exception).

        * fast/dom/xmlhttprequest-get-expected.txt: Updated results.

        * http/tests/xmlhttprequest/zero-length-response-expected.txt:
        * http/tests/xmlhttprequest/zero-length-response-sync-expected.txt:
        * http/tests/xmlhttprequest/zero-length-response-sync.html:
        * http/tests/xmlhttprequest/zero-length-response.html:
        Updated results and changed state names to match the current spec.

        * http/tests/xmlhttprequest/resources/zero-length.xml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
ap [Sat, 23 Sep 2006 18:08:18 +0000 (18:08 +0000)]
    Reviewed by Maciej.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10183
        REGRESSION: obfuscated JS decoding breaks because of soft hyphen removal
        (Fanfiction.net author pages not listing stories)

        Rolled out the fix for bug 4139.

        * kjs/lexer.cpp:
        (Lexer::setCode):
        (Lexer::shift):
        * tests/mozilla/ecma/Array/15.4.5.1-1.js:
        * tests/mozilla/expected.html:

2006-09-22  Steve Falkenburg  <sfalken@apple.com>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-22 Steve Falkenburg <sfalken@apple.com>
sfalken [Sat, 23 Sep 2006 01:58:07 +0000 (01:58 +0000)]
2006-09-22  Steve Falkenburg  <sfalken@apple.com>

        Build fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoChanged the tests to be if(window.layoutTestController)
thatcher [Sat, 23 Sep 2006 00:56:25 +0000 (00:56 +0000)]
Changed the tests to be if(window.layoutTestController)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-22 Steve Falkenburg <sfalken@apple.com>
sfalken [Sat, 23 Sep 2006 00:44:58 +0000 (00:44 +0000)]
2006-09-22  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Jeff Jenkins.

        Tweak CF types.

        * platform/cf/ResourceLoaderCFNet.cpp:
        (WebCore::willCacheResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
justing [Sat, 23 Sep 2006 00:14:55 +0000 (00:14 +0000)]
WebCore:

        Reviewed by darin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=8029>
        Rename Node::isAncestor and RenderObject::hasAncestor to isDescendantOf

        * dom/Document.cpp:
        (WebCore::Document::clearSelectionIfNeeded):
        * dom/Element.cpp:
        (WebCore::Element::contains):
        * dom/Node.cpp:
        (WebCore::Node::traverseNextNode):
        (WebCore::Node::traverseNextSibling):
        (WebCore::Node::traversePreviousNodePostOrder):
        (WebCore::Node::checkAddChild):
        (WebCore::Node::isDescendantOf):
        * dom/Node.h:
        * dom/NodeIterator.cpp:
        (WebCore::NodeIterator::notifyBeforeNodeRemoval):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyBlockStyle):
        (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
        (WebCore::ApplyStyleCommand::applyInlineStyle):
        (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode):
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::mergeIdenticalElements):
        (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::updatePositionForNodeRemoval):
        (WebCore::DeleteSelectionCommand::handleGeneralDelete):
        (WebCore::DeleteSelectionCommand::mergeParagraphs):
        * editing/FormatBlockCommand.cpp:
        (WebCore::FormatBlockCommand::doApply):
        * editing/IndentOutdentCommand.cpp:
        (WebCore::enclosingListOrBlockquote):
        * editing/Selection.cpp:
        (WebCore::Selection::validate):
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::nodeWillBeRemoved):
        * editing/TextIterator.cpp:
        (WebCore::SimplifiedBackwardsTextIterator::advance):
        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::next):
        (WebCore::VisiblePosition::previous):
        (WebCore::VisiblePosition::canonicalPosition):
        (WebCore::isFirstVisiblePositionInNode):
        (WebCore::isLastVisiblePositionInNode):
        * editing/htmlediting.cpp:
        (WebCore::firstEditablePositionAfterPositionInRoot):
        (WebCore::lastEditablePositionBeforePositionInRoot):
        (WebCore::enclosingNodeWithTag):
        (WebCore::enclosingList):
        (WebCore::enclosingListChild):
        * editing/markup.cpp:
        (WebCore::createMarkup):

WebKitTools:

        Reviewed by darin

        * Scripts/do-webcore-rename:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoVersioning
thatcher [Sat, 23 Sep 2006 00:02:44 +0000 (00:02 +0000)]
Versioning

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
thatcher [Fri, 22 Sep 2006 23:34:07 +0000 (23:34 +0000)]
WebCore:

        Reviewed by Darin.

        - Added @property syntax to non-generated headers
          inside #ifndef BUILDING_ON_TIGER.
        - Changed the DOMEventTarget protocol to have have new versions
          of addEventListener and removeEventListener with named parameters.
          These old style methods can be removed once Mail changes to use
          the new methods <rdar://problem/4746649>.

        * WebCorePrefix.h: define BUILDING_ON_TIGER when Tiger is the target
        * bindings/objc/DOM.mm:
        (-[DOMNode addEventListener:listener:useCapture:]):
        (-[DOMNode addEventListener:::]): call the new method
        (-[DOMNode removeEventListener:listener:useCapture:]):
        (-[DOMNode removeEventListener:::]): call the new method
        * bindings/objc/DOMAbstractView.h:
        * bindings/objc/DOMEventTarget.h:
        * bindings/objc/DOMHTMLAppletElement.h:
        * bindings/objc/DOMHTMLEmbedElement.h:
        * bindings/objc/DOMHTMLOptionElement.h:
        * bindings/objc/DOMObject.h:
        * bindings/objc/DOMRGBColor.h:

WebKit:

        Reviewed by Darin.

        Pass all headers through unifdef to filter out BUILDING_ON_TIGER blocks
        if MACOSX_DEPLOYMENT_TARGET is 10.4.

        * MigrateHeaders.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
weinig [Fri, 22 Sep 2006 23:09:56 +0000 (23:09 +0000)]
    Reviewed by Eric.

        Fix Qt/Linux build and a really stupid mixup in GraphicsContextQt.

        * platform/qt/FrameQt.cpp:
        * platform/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::translate): Make it actually translate, not scale! :-)
        (WebCore::GraphicsContext::origin):
        * platform/qt/PlatformScrollBar.h: Added.
        (WebCore::PlatformScrollBar::isWidget):
        * platform/qt/WidgetQt.cpp:
        (WebCore::Widget::invalidate):
        (WebCore::Widget::invalidateRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Alice.
darin [Fri, 22 Sep 2006 22:02:56 +0000 (22:02 +0000)]
    Reviewed by Alice.

        * wtf/Vector.h: Add an append that takes a pointer and length.
        Generalize the existing Vector append to work on vectors with
        any value for inlineCapacity. Change the append algorithm so
        it doesn't check capacity each time through the loop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMinor tweaks to RenderThemeMac's systemFont function.
hyatt [Fri, 22 Sep 2006 21:56:44 +0000 (21:56 +0000)]
Minor tweaks to RenderThemeMac's systemFont function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-22 Steve Falkenburg <sfalken@apple.com>
sfalken [Fri, 22 Sep 2006 21:50:53 +0000 (21:50 +0000)]
2006-09-22  Steve Falkenburg  <sfalken@apple.com>

        Fix release build.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoI did not pay enough attention at the time of landing WildFox' crash fix.
rwlbuis [Fri, 22 Sep 2006 20:33:19 +0000 (20:33 +0000)]
I did not pay enough attention at the time of landing WildFox' crash fix.
beidson already fixed the problem in r16499. Reverting the test now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMerged my previous checkin with what I was *supposed* to checkin that had been review...
beidson [Fri, 22 Sep 2006 19:27:11 +0000 (19:27 +0000)]
Merged my previous checkin with what I was *supposed* to checkin that had been reviewed by Maciej
Added bug numbers to the ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady.
thatcher [Fri, 22 Sep 2006 18:41:43 +0000 (18:41 +0000)]
    Reviewed by Brady.

        Build fix for Xcode 2.3. Convert GraphicsContext::translate() to
        take floats. There was already an implicit conversion to float/double
        when calling CGContextTranslateCTM or cairo_translate.

        * platform/GraphicsContext.h:
        * platform/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::translate):
        * platform/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::translate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Sfalken
beidson [Fri, 22 Sep 2006 18:22:20 +0000 (18:22 +0000)]
    Reviewed by Sfalken

        Add redirect and other cleanup to ResourceLoaderWin.cpp

        * WebCore.xcodeproj/project.pbxproj:
        * platform/ResourceLoader.h:
        * platform/win/ResourceLoaderWin.cpp:
        (WebCore::ResourceLoaderWndProc):
        (WebCore::initializeOffScreenResourceLoaderWindow):
        (WebCore::ResourceLoader::onHandleCreated):
        (WebCore::ResourceLoader::onRequestRedirected):
        (WebCore::ResourceLoader::onRequestComplete):
        (WebCore::transferJobStatusCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
ap [Fri, 22 Sep 2006 18:18:03 +0000 (18:18 +0000)]
    Reviewed by Geoff.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10803
        REGRESSION (r15536-r15544): manual-tests/bugzilla-6821.html failing

        * page/FrameView.cpp:
        (WebCore::FrameView::hoverTimerFired): Use the current event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders.
rwlbuis [Fri, 22 Sep 2006 14:13:12 +0000 (14:13 +0000)]
    Reviewed by Anders.

        Fix (last) svg memory leak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-22 Eric Seidel <eric@eseidel.com>
eseidel [Fri, 22 Sep 2006 13:01:51 +0000 (13:01 +0000)]
2006-09-22  Eric Seidel  <eric@eseidel.com>

        No review necessary, just removing a dead file.

        Remove unused file (added previously by mistake) to make room for real implementation.

        * platform/mac/BitmapImageMac.mm: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMac side of scrollbar move
hyatt [Fri, 22 Sep 2006 08:51:27 +0000 (08:51 +0000)]
Mac side of scrollbar move

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMove PlatformScrollBar.h down into platform-specific subdirs.
hyatt [Fri, 22 Sep 2006 08:46:49 +0000 (08:46 +0000)]
Move PlatformScrollBar.h down into platform-specific subdirs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd invalidation methods to widget.
hyatt [Fri, 22 Sep 2006 08:24:33 +0000 (08:24 +0000)]
Add invalidation methods to widget.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by eseidel.
rwlbuis [Fri, 22 Sep 2006 08:23:26 +0000 (08:23 +0000)]
    Reviewed by eseidel.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10901
        Merge build fixes from unity

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by eseidel.
rwlbuis [Fri, 22 Sep 2006 08:07:55 +0000 (08:07 +0000)]
    Reviewed by eseidel.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10977
        SVGDocument does not expose 'rootElement' property

        Enable 'rootElement' property.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-21 Steve Falkenburg <sfalken@apple.com>
sfalken [Fri, 22 Sep 2006 04:31:33 +0000 (04:31 +0000)]
2006-09-21  Steve Falkenburg  <sfalken@apple.com>

        Tweak includes.

        * platform/ResourceLoaderInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago build fixed. band happy.
ggaren [Fri, 22 Sep 2006 01:29:30 +0000 (01:29 +0000)]
    build fixed. band happy.

        * platform/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::translate):
        * platform/mac/WidgetMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
ggaren [Fri, 22 Sep 2006 00:50:41 +0000 (00:50 +0000)]
JavaScriptCore:

        Reviewed by Maciej.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        Updated to include the right path.
        * wtf/FastMalloc.h: #include Platform.h, since we use Platform macros.

WebCore:

        Reviewed by Maciej.

        Some Widget refactoring.

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * bridge/mac/FrameMac.mm:
        * bridge/win/FrameWin.cpp:
        (WebCore::FrameWin::runJavaScriptAlert):
        (WebCore::FrameWin::runJavaScriptConfirm):
        * bridge/win/PageWin.cpp:
        (WebCore::Page::Page):
        (WebCore::rootWindowForFrame):
        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::translate):
        * page/FrameView.cpp:
        (WebCore::FrameView::isFrameView):
        * page/Page.h:
        (WebCore::Page::setInstanceHandle):
        (WebCore::Page::instanceHandle):
        * platform/GraphicsContext.h:
        * platform/ScrollView.h:
        * platform/Widget.h:
        * platform/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::translate):
        (WebCore::GraphicsContext::origin):
        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::clearFocus):
        * platform/win/ResourceLoaderWin.cpp:
        (WebCore::initializeOffScreenResourceLoaderWindow):
        * platform/win/ScreenWin.cpp:
        (WebCore::monitorInfo):
        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::updateContents):
        (WebCore::ScrollView::visibleWidth):
        (WebCore::ScrollView::visibleHeight):
        (WebCore::ScrollView::visibleContentRect):
        (WebCore::ScrollView::viewportToContents):
        (WebCore::ScrollView::contentsToViewport):
        (WebCore::ScrollView::scrollBy):
        (WebCore::ScrollView::updateScrollInfo):
        (WebCore::ScrollView::updateScrollBars):
        * platform/win/SharedTimerWin.cpp:
        (WebCore::initializeOffScreenTimerWindow):
        * platform/win/TemporaryLinkStubs.cpp:
        (FrameView::updateBorder):
        (ScrollView::paint):
        (GraphicsContext::clip):
        * platform/win/WidgetWin.cpp:
        (WebCore::Widget::Widget):
        (WebCore::Widget::parentWindow):
        (WebCore::Widget::setParentWindow):
        (WebCore::Widget::frameGeometry):
        (WebCore::Widget::hasFocus):
        (WebCore::Widget::setFocus):
        (WebCore::Widget::show):
        (WebCore::Widget::hide):
        (WebCore::Widget::setFrameGeometry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-21 Anders Carlsson <acarlsson@apple.com>
andersca [Thu, 21 Sep 2006 23:55:28 +0000 (23:55 +0000)]
2006-09-21  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Tim H.

        * platform/TextEncoding.cpp:
        (WebCore::TextEncoding::backslashAsCurrencySymbol):
        Add comment clarifying why backslashAsCurrencySymbol is needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-21 Matt Lilek <pewtermoose@gmail.com>
bdash [Thu, 21 Sep 2006 22:36:08 +0000 (22:36 +0000)]
2006-09-21  Matt Lilek  <pewtermoose@gmail.com>

        Reviewed by Eric.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10975
        Update the blog template to valid HTML 4.01 Strict.

        * blog/wp-content/themes/webkit/comments-popup.php:
        * blog/wp-content/themes/webkit/comments.php:
        * blog/wp-content/themes/webkit/footer.php:
        * blog/wp-content/themes/webkit/header.php:
        * blog/wp-content/themes/webkit/style.css: Add missing semi-colon that the validator complained about.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Adding more calls to layoutTestController.dumpChildFrameScrollPositions()
thatcher [Thu, 21 Sep 2006 22:05:43 +0000 (22:05 +0000)]
    Adding more calls to layoutTestController.dumpChildFrameScrollPositions()
        for tests that need to report child frame scroll positions.

        * http/tests/navigation/anchor-frames.html:
        * http/tests/navigation/anchor-subframeload.html:
        * http/tests/navigation/relativeanchor-frames.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFactored out get/release of HDC from cairo GraphicsContext.
seangies [Thu, 21 Sep 2006 21:58:40 +0000 (21:58 +0000)]
Factored out get/release of HDC from cairo GraphicsContext.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by anders
justing [Thu, 21 Sep 2006 21:42:58 +0000 (21:42 +0000)]
    Reviewed by anders

        <rdar://problem/4426622>
        Plain text paste slow.  Time spent mostly in WebCore::rebalanceWhitespaceInTextNode(...)

        * editing/htmlediting.cpp:
        (WebCore::rebalanceWhitespaceInTextNode): We no longer need to use a RegExp replace because we
        aren't producing complicated sequences here.  Use multiple UChar -> UChar replaces instead for speed.
        Got rid of uses of DepricatedString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoHmm, forgot to commit kcanvas/ changes as part of linux build fixes.
rwlbuis [Thu, 21 Sep 2006 21:22:14 +0000 (21:22 +0000)]
Hmm, forgot to commit kcanvas/ changes as part of linux build fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoToo tired too do it right :}
rwlbuis [Thu, 21 Sep 2006 21:18:32 +0000 (21:18 +0000)]
Too tired too do it right :}

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by eseidel.
rwlbuis [Thu, 21 Sep 2006 21:14:28 +0000 (21:14 +0000)]
    Reviewed by eseidel.

        Don't crash if no IconDatabase is available (ie. on Qt/Gdk)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by eseidel.
rwlbuis [Thu, 21 Sep 2006 21:11:21 +0000 (21:11 +0000)]
    Reviewed by eseidel.

        Fix Qt/Linux build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoSet dumpChildFrameScrollPositions to NO before each test run.
thatcher [Thu, 21 Sep 2006 21:02:30 +0000 (21:02 +0000)]
Set dumpChildFrameScrollPositions to NO before each test run.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
thatcher [Thu, 21 Sep 2006 20:43:37 +0000 (20:43 +0000)]
LayoutTests:

        Reviewed by Adam.

        Bug 10923: Frame scroll layout test failures on the buildbot
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10923

        Made this test call layoutTestController.dumpChildFrameScrollPositions().

        * fast/overflow/scrollRevealButton-expected.txt:
        * fast/overflow/scrollRevealButton.html:

WebKitTools:

        Reviewed by Adam.

        Bug 10923: Frame scroll layout test failures on the buildbot
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10923

        Added a new method that will toggle on the recursive dump of
        child frame scroll positions.

        * DumpRenderTree/DumpRenderTree.m:
        (dumpFrameScrollPosition):
        (+[LayoutTestController isSelectorExcludedFromWebScript:]):
        (-[LayoutTestController dumpChildFrameScrollPositions]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBuild fix.
thatcher [Thu, 21 Sep 2006 19:56:56 +0000 (19:56 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Thu, 21 Sep 2006 19:31:56 +0000 (19:31 +0000)]
LayoutTests:

        Reviewed by john

        * editing/pasteboard/subframe-dragndrop-1-expected.checksum: Added.
        * editing/pasteboard/subframe-dragndrop-1-expected.png: Added.
        * editing/pasteboard/subframe-dragndrop-1-expected.txt: Added.
        * editing/pasteboard/subframe-dragndrop-1.html: Added.

WebCore:

        Reviewed by john

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7165>
        TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe

        * editing/MoveSelectionCommand.cpp:
        (WebCore::MoveSelectionCommand::MoveSelectionCommand): Set the document
        to the position-to-move-to's document, not the fragment's document.  The
        fragment's document is the document used to create the fragment and is irrelavant.

WebKit:

        Reviewed by john

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7165>
        TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe

        The top level WebHTMLView is responsible for performing dragging operations, but
        the inner view, the view that holds the drag caret, should be consulted to determine
        if the drag is a move drag.

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebHTMLView.m:
        (-[NSArray dragImage:at:offset:event:pasteboard:source:slideBack:]): Don't set initatedDrag here, because
        it's only the top level WebHTMLView that performs this operation.
        (-[WebHTMLView _setInitiatedDrag:]): Added.
        (-[WebHTMLView _initiatedDrag]): Ditto.
        (-[WebHTMLView _canProcessDragWithDraggingInfo:]): Ask the innerView if it initiated the drag,
        not the top level view.
        (-[WebHTMLView _isMoveDrag]): The top level view asks the innerView if it should perform
        a move drag, so don't ASSERT _isTopHTMLView.
        (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]): Ask the innerView if _isMoveDrag.
        (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): Ditto.
        * WebView/WebHTMLViewInternal.h: Added two private SPI so that
        the top level WebHTMLView can set and get the initiatedDrag BOOL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoEliminate a crash for all platforms without IconDatabase hooked up
beidson [Thu, 21 Sep 2006 19:01:36 +0000 (19:01 +0000)]
Eliminate a crash for all platforms without IconDatabase hooked up

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoYABF
beidson [Thu, 21 Sep 2006 17:18:46 +0000 (17:18 +0000)]
YABF

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-21 Mark Rowe <opendarwin.org@bdash.net.nz>
bdash [Thu, 21 Sep 2006 09:39:35 +0000 (09:39 +0000)]
2006-09-21  Mark Rowe  <opendarwin.org@bdash.net.nz>

        Reviewed by Eric.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10966
        Bug 10966: Updates to website

        Resolves a few remaining validation issues, makes Bugzilla links consistent, and removes unneeded references to OpenDarwin.

        * coding/coding-style.html:
        * coding/lgpl-license.html:
        * contact.html:
        * index.html:
        * projects/css/index.html:
        * projects/editing/index.html:
        * projects/forms/index.html:
        * projects/html/index.html:
        * projects/index.html:
        * projects/javascript/index.html:
        * projects/svg/index.html:
        * projects/xslt/index.html:
        * webdevelopers/webkit_version.html:
        * webdevelopers/webkit_version_xl.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by eseidel.
rwlbuis [Thu, 21 Sep 2006 07:29:08 +0000 (07:29 +0000)]
    Reviewed by eseidel.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10946
        new marker code draws end-marker in wrong place

        Keep track of the start of the subpath so we can handle
        closeTo/moveTo correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWheel scrolling prep for win32.
hyatt [Thu, 21 Sep 2006 07:18:47 +0000 (07:18 +0000)]
Wheel scrolling prep for win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-21 Mark Rowe <opendarwin.org@bdash.net.nz>
bdash [Thu, 21 Sep 2006 06:27:36 +0000 (06:27 +0000)]
2006-09-21  Mark Rowe  <opendarwin.org@bdash.net.nz>

        Reviewed by TimH.

        Updates to make static pages validate as HTML 4.01 Strict.

        * building/build.html:
        * coding/coding-style.html:
        * header.inc:
        * index.html: Move <style> tag into the document head.
        * projects/cleanup/index.html:
        * projects/compat/index.html:
        * projects/css/index.html:
        * projects/documentation/index.html:
        * projects/editing/index.html:
        * projects/forms/index.html: Remove note about <label> not being implemented correctly.
        * projects/html/index.html:
        * projects/javascript/index.html:
        * projects/performance/index.html:
        * projects/portability/index.html: Change mention of Windows port to note that it is in progress rather than non-existant.
        * projects/printing/index.html:
        * projects/svg/index.html:
        * projects/xslt/index.html:
        * quality/bugwriting.html: Update WebKit version numbers to be accurate.  Move JS away from using innerHTML as W3C validator doesn't like it.
        * quality/reduction.html:
        * quality/reporting.html: Rename element IDs that start with numbers.  Update WebKit and Mac OS X version numbers to be accurate.
        * quality/testing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
thatcher [Thu, 21 Sep 2006 03:45:02 +0000 (03:45 +0000)]
    Reviewed by Hyatt.

        Bug 10917: REGRESSION (r16027): iFrame transparency broken
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10917

        Don't paint the base background color if we transparent.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintBackgroundExtended):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by andersca.
aroben [Thu, 21 Sep 2006 00:54:02 +0000 (00:54 +0000)]
    Reviewed by andersca.

        * platform/FileChooser.h: Remove no-longer-necessary namespace std

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix up conditional.
seangies [Wed, 20 Sep 2006 23:52:06 +0000 (23:52 +0000)]
Fix up conditional.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-20 Eric Seidel <eric@eseidel.com>
eseidel [Wed, 20 Sep 2006 23:37:33 +0000 (23:37 +0000)]
2006-09-20  Eric Seidel  <eric@eseidel.com>

        Reviewed by beth.

        Cleanup style in KCanvas.
        Remove extra white-space, unneeded arguments, etc.

        * WebCore.xcodeproj/project.pbxproj:
        * kcanvas/KCanvasClipper.cpp:
        (WebCore::operator<<):
        (WebCore::KCanvasClipper::externalRepresentation):
        * kcanvas/KCanvasClipper.h:
        * kcanvas/KCanvasFilters.cpp:
        (WebCore::KCanvasFilter::externalRepresentation):
        (WebCore::operator<<):
        (WebCore::KCanvasFilterEffect::externalRepresentation):
        (WebCore::KCPointLightSource::externalRepresentation):
        (WebCore::KCSpotLightSource::externalRepresentation):
        (WebCore::KCDistantLightSource::externalRepresentation):
        (WebCore::KCanvasFEBlend::externalRepresentation):
        (WebCore::KCanvasFEColorMatrix::externalRepresentation):
        (WebCore::KCanvasFEComponentTransfer::externalRepresentation):
        (WebCore::KCanvasFEComposite::externalRepresentation):
        (WebCore::KCanvasFEConvolveMatrix::externalRepresentation):
        (WebCore::KCanvasFEDiffuseLighting::externalRepresentation):
        (WebCore::KCanvasFEDisplacementMap::externalRepresentation):
        (WebCore::KCanvasFEFlood::externalRepresentation):
        (WebCore::KCanvasFEGaussianBlur::externalRepresentation):
        (WebCore::KCanvasFEImage::externalRepresentation):
        (WebCore::KCanvasFEMerge::externalRepresentation):
        (WebCore::KCanvasFEMorphology::externalRepresentation):
        (WebCore::KCanvasFEOffset::externalRepresentation):
        (WebCore::KCanvasFESpecularLighting::externalRepresentation):
        (WebCore::KCanvasFETile::externalRepresentation):
        (WebCore::KCanvasFETurbulence::externalRepresentation):
        * kcanvas/KCanvasFilters.h:
        (WebCore::KCanvasFEDiffuseLighting::lightSource):
        (WebCore::KCanvasFESpecularLighting::lightSource):
        * kcanvas/KCanvasImage.h:
        * kcanvas/KCanvasMarker.cpp:
        (WebCore::KCanvasMarker::externalRepresentation):
        * kcanvas/KCanvasMarker.h:
        * kcanvas/KCanvasResource.cpp:
        (WebCore::operator<<):
        * kcanvas/KCanvasResource.h:
        * kcanvas/KCanvasTreeDebug.cpp:
        (WebCore::operator<<):
        (WebCore::writeIndent):
        (WebCore::writeStyle):
        (WebCore::write):
        (WebCore::writeRenderResources):
        * kcanvas/KCanvasTreeDebug.h:
        (WebCore::operator<<):
        * kcanvas/RenderForeignObject.cpp:
        (WebCore::RenderForeignObject::paint):
        * kcanvas/RenderPath.cpp:
        (WebCore::RenderPath::paint):
        (WebCore::drawStartAndMidMarkers):
        * kcanvas/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::paint):
        * kcanvas/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::translateForAttributes):
        * kcanvas/RenderSVGImage.h:
        * kcanvas/device/KRenderingDevice.cpp:
        (WebCore::KRenderingDevice::currentContext):
        (WebCore::KRenderingDevice::popContext):
        (WebCore::KRenderingDevice::pushContext):
        * kcanvas/device/KRenderingDevice.h:
        * kcanvas/device/KRenderingFillPainter.h:
        * kcanvas/device/KRenderingPaintServer.h:
        (WebCore::KRenderingPaintServer::KRenderingPaintServer):
        (WebCore::KRenderingPaintServer::activeClient):
        (WebCore::KRenderingPaintServer::setActiveClient):
        * kcanvas/device/KRenderingPaintServerGradient.cpp:
        (WebCore::operator<<):
        (WebCore::KRenderingPaintServerGradient::externalRepresentation):
        (WebCore::KRenderingPaintServerLinearGradient::externalRepresentation):
        (WebCore::KRenderingPaintServerGradient::listener):
        (WebCore::KRenderingPaintServerGradient::setListener):
        (WebCore::KRenderingPaintServerRadialGradient::externalRepresentation):
        * kcanvas/device/KRenderingPaintServerGradient.h:
        * kcanvas/device/KRenderingPaintServerPattern.cpp:
        (WebCore::KRenderingPaintServerPattern::tile):
        (WebCore::KRenderingPaintServerPattern::setTile):
        (WebCore::KRenderingPaintServerPattern::listener):
        (WebCore::KRenderingPaintServerPattern::setListener):
        (WebCore::KRenderingPaintServerPattern::externalRepresentation):
        * kcanvas/device/KRenderingPaintServerPattern.h:
        * kcanvas/device/KRenderingPaintServerSolid.cpp:
        (WebCore::KRenderingPaintServerSolid::externalRepresentation):
        * kcanvas/device/KRenderingPaintServerSolid.h:
        * kcanvas/device/KRenderingStrokePainter.cpp:
        (WebCore::KRenderingStrokePainter::strokeMiterLimit):
        (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
        * kcanvas/device/KRenderingStrokePainter.h:
        * kcanvas/device/quartz/KCanvasFilterQuartz.h:
        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        (WebCore::KCanvasFilterQuartz::prepareFilter):
        * kcanvas/device/quartz/KCanvasItemQuartz.h: Removed.
        * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
        (WebCore::KCanvasMaskerQuartz::applyMask):
        * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
        (WebCore::KCanvasImageQuartz::init):
        * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
        (WebCore::KCanvasClipperQuartz::applyClip):
        * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
        * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
        (WebCore::KRenderingDeviceQuartz::quartzContext):
        (WebCore::KRenderingDeviceQuartz::contextForImage):
        (WebCore::KRenderingDeviceQuartz::createPaintServer):
        (WebCore::KRenderingDeviceQuartz::createResource):
        (WebCore::KRenderingDeviceQuartz::createFilterEffect):
        * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
        (WebCore::CGShadingRefForLinearGradient):
        (WebCore::CGShadingRefForRadialGradient):
        (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
        (WebCore::KRenderingPaintServerGradientQuartz::teardown):
        * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
        * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
        (WebCore::KRenderingPaintServerQuartzHelper::strokePath):
        (WebCore::KRenderingPaintServerQuartzHelper::clipToStrokePath):
        (WebCore::KRenderingPaintServerQuartzHelper::fillPath):
        (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
        (WebCore::KRenderingPaintServerSolidQuartz::draw):
        (WebCore::KRenderingPaintServerSolidQuartz::setup):
        (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
        (WebCore::KRenderingPaintServerPatternQuartz::setup):
        (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
        (WebCore::KRenderingPaintServerPatternQuartz::teardown):
        * kcanvas/device/quartz/QuartzSupport.h:
        * kcanvas/device/quartz/QuartzSupport.mm:
        (WebCore::applyStrokeStyleToContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
andersca [Wed, 20 Sep 2006 22:45:13 +0000 (22:45 +0000)]
JavaScriptCore:

2006-09-20  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Dave Hyatt.

        * wtf/MathExtras.h:
        Get rid of lrint.

WebCore:

2006-09-20  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Dave Hyatt.

        * dom/WheelEvent.cpp:
        (WebCore::WheelEvent::WheelEvent):
        Use lroundf instead of lround since deltas are floats.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-20 Julien Palmas <julien.palmas@gmail.com>
eseidel [Wed, 20 Sep 2006 22:38:59 +0000 (22:38 +0000)]
2006-09-20  Julien Palmas  <julien.palmas@gmail.com>

        Reviewed by eseidel.  Landed by eseidel.

        Test: svg/custom/pattern-y-offset.svg

        * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
        (WebCore::KRenderingPaintServerPatternQuartz::setup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add a new wheelEvent method to ScrollView. Platforms that wish
hyatt [Wed, 20 Sep 2006 22:37:28 +0000 (22:37 +0000)]
    Add a new wheelEvent method to ScrollView.  Platforms that wish
        to handle the wheel event for the scroll view themselves can then
        do so there.  (Mac lets the underlying NSScrollView do it for now.)

        * page/FrameView.cpp:
        (WebCore::FrameView::handleWheelEvent):
        * platform/ScrollView.h:
        (WebCore::ScrollView::wheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoSend debug messages to debugger console.
seangies [Wed, 20 Sep 2006 21:59:15 +0000 (21:59 +0000)]
Send debug messages to debugger console.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix copyright year.
thatcher [Wed, 20 Sep 2006 21:44:11 +0000 (21:44 +0000)]
Fix copyright year.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
beidson [Wed, 20 Sep 2006 21:32:59 +0000 (21:32 +0000)]
WebCore:

        Reviewed by Tim Omernick

        Part of fixing a crash Tim O showed me that I missed in a release build.
        WebKit should be able to call through the bridge to WebCore no matter what -
        Replace the _iconDB member with calls to IconDatabase::sharedIconDatabase()

        * bridge/mac/WebCoreIconDatabaseBridge.h:
        * bridge/mac/WebCoreIconDatabaseBridge.mm:
        (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
        (-[WebCoreIconDatabaseBridge isOpen]):
        (-[WebCoreIconDatabaseBridge removeAllIcons]):
        (-[WebCoreIconDatabaseBridge _isEmpty]):
        (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]):
        (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
        (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
        (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
        (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
        (-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
        (-[WebCoreIconDatabaseBridge retainIconForURL:]):
        (-[WebCoreIconDatabaseBridge releaseIconForURL:]):
        (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
        (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
        (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
        (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]):
        (-[WebCoreIconDatabaseBridge _setEnabled:]):
        (-[WebCoreIconDatabaseBridge _isEnabled]):

WebKit:

        Reviewed by Tim Omernick

        Fixing part of a crash Tim O showed me.  [WebIconDatabase init] should finish
        gracefully even if we can't open the database

        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase init]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add an implementation of lrint for Win32.
hyatt [Wed, 20 Sep 2006 21:12:01 +0000 (21:12 +0000)]
    Add an implementation of lrint for Win32.

        Reviewed by anders

        * wtf/MathExtras.h:
        (lrint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-20 Anders Carlsson <acarlsson@apple.com>
andersca [Wed, 20 Sep 2006 21:04:01 +0000 (21:04 +0000)]
2006-09-20  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Darin.

        Add String::split which returns a Vector of Strings and use it instead of
        DeprecatedStringList.

        * bindings/js/kjs_events.cpp:
        (KJS::Clipboard::getValueProperty):
        * bindings/js/kjs_window.cpp:
        (KJS::parseModalDialogFeatures):
        * css/MediaList.cpp:
        (WebCore::MediaList::setMediaText):
        * dom/Clipboard.h:
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::formData):
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::tokenizeRelAttribute):
        * platform/PlatformString.h:
        * platform/String.cpp:
        (WebCore::String::split):
        * platform/StringImpl.cpp:
        * platform/StringImpl.h:
        * platform/mac/ClipboardMac.h:
        * platform/mac/ClipboardMac.mm:
        (WebCore::ClipboardMac::types):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim O.
thatcher [Wed, 20 Sep 2006 20:43:56 +0000 (20:43 +0000)]
    Reviewed by Tim O.

        <rdar://problem/4741392> Develop a system to find what version of WebKit an app was linked with

        * Misc/WebKitVersionChecks.h: Added.
        * Misc/WebKitVersionChecks.m: Added.
        (WebKitLinkedOnOrAfter): Added.
        (WebKitLinkTimeVersion): Added.
        (WebKitRunTimeVersion): Added.
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
tomernic [Wed, 20 Sep 2006 20:31:30 +0000 (20:31 +0000)]
    Reviewed by Darin.

        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase init]):
        Fixed a typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Wed, 20 Sep 2006 19:20:33 +0000 (19:20 +0000)]
LayoutTests:

        Reviewed by harrison

        * editing/selection/editable-links.html: Added.
        * editing/selection/editable-links.html-disabled: Removed.

WebCore:

        Reviewed by harrison

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::adjustRenderStyle): Don't call
        HTMLElement::isContentEditable just to check the Frame's editability, since
        it calls updateRenderering, which can get us into infinite recursion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
beidson [Wed, 20 Sep 2006 19:12:08 +0000 (19:12 +0000)]
WebCore:

        Reviewed by Darin

        Cleaned up my last patch alot, and made the WebCore icon database disabled by default

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::IconDatabase): Disabled by default
        (WebCore::IconDatabase::removeAllIcons): Respect just isOpen() (disabled database will always be closed)
        (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto
        (WebCore::IconDatabase::iconForPageURL): Ditto
        (WebCore::IconDatabase::isIconExpiredForIconURL): Ditto
        (WebCore::IconDatabase::iconURLForPageURL): Ditto
        (WebCore::IconDatabase::retainIconForPageURL): Ditto
        (WebCore::IconDatabase::releaseIconForPageURL): Ditto
        (WebCore::IconDatabase::setIconDataForIconURL): Ditto
        (WebCore::IconDatabase::setIconURLForPageURL): Ditto
        (WebCore::IconDatabase::hasEntryForIconURL): Ditto
        (WebCore::IconDatabase::setEnabled): Fixed a big bug here!

WebKit:

        Reviewed by Darin

        Preparing to make the WebIconDatabase disabled by default - this patch tells the bridge whether its enabled or not

        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase init]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by timothy.
aroben [Wed, 20 Sep 2006 18:33:10 +0000 (18:33 +0000)]
    Reviewed by timothy.

        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10953
        Test results for fast/js/window-properties.html should include
        children of window.document.body.firstChild

        * fast/js/window-properties-expected.txt: Regenerate results which now
        include window.document.body.firstChild.*
        * fast/js/window-properties.html: Print out 'null' for null objects
        instead of 'object' for more clarity

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
aroben [Wed, 20 Sep 2006 17:42:48 +0000 (17:42 +0000)]
WebCore:
        Reviewed by Adele.

        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10935
        REGRESSION: file upload control with direction:rtl or text-align:right
        draws button on top of filename/icon

        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::setStyle): Force text-align to
        match direction
        (WebCore::RenderFileUploadControl::paintObject): Fix positioning of
        the filename and icon in RTL

LayoutTests:
        Reviewed by Adele.

        Adding test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10935
        REGRESSION: file upload control with direction:rtl or text-align:right
        draws button on top of filename/icon

        * fast/forms/file-input-direction-expected.checksum: Added.
        * fast/forms/file-input-direction-expected.png: Added.
        * fast/forms/file-input-direction-expected.txt: Added.
        * fast/forms/file-input-direction.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
aliceli1 [Wed, 20 Sep 2006 17:30:32 +0000 (17:30 +0000)]
    Reviewed by Adam Roben.

        fixed windows build

        * dom/WheelEvent.cpp:
        (WebCore::WheelEvent::WheelEvent):
        changed lrint to lround

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build Fix. Adds isHorizontal attribute back to WheelEvent
weinig [Wed, 20 Sep 2006 14:23:03 +0000 (14:23 +0000)]
    Build Fix.  Adds isHorizontal attribute back to WheelEvent
        for the Objective-C bindings.  If it is found that isHorizontal
        is not used, we should remove it again but also remove it's
        declaration from PublicDOMInterfaces.h

        * dom/WheelEvent.h:
        (WebCore::WheelEvent::isHorizontal):
        * dom/WheelEvent.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for 10945, WheelEvent should support two dimensions at once, since
hyatt [Wed, 20 Sep 2006 09:52:25 +0000 (09:52 +0000)]
    Fix for 10945, WheelEvent should support two dimensions at once, since
        MacBooks allow for diagonal scrolling.  Also enhance the PlatformWheelEvent
        to allow for diagonal scrolling.

        Reviewed by Eric

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchWheelEvent):
        * dom/WheelEvent.cpp:
        (WebCore::WheelEvent::WheelEvent):
        (WebCore::WheelEvent::initWheelEvent):
        * dom/WheelEvent.h:
        (WebCore::WheelEvent::wheelDelta):
        (WebCore::WheelEvent::wheelDeltaX):
        (WebCore::WheelEvent::wheelDeltaY):
        * dom/WheelEvent.idl:
        * page/FrameView.cpp:
        (WebCore::FrameView::handleWheelEvent):
        * platform/PlatformWheelEvent.h:
        (WebCore::PlatformWheelEvent::deltaX):
        (WebCore::PlatformWheelEvent::deltaY):
        (WebCore::PlatformWheelEvent::normalize):
        * platform/mac/WheelEventMac.mm:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-20 Eric Seidel <eric@eseidel.com>
eseidel [Wed, 20 Sep 2006 09:38:23 +0000 (09:38 +0000)]
2006-09-20  Eric Seidel  <eric@eseidel.com>

        Reviewed by hyatt.

        Commit two test updates I forgot to commit with:
        Markers should clip to their viewport.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5967

        * svg/W3C-SVG-1.1/painting-marker-01-f-expected.checksum:
        * svg/W3C-SVG-1.1/painting-marker-01-f-expected.png:
        * svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
        * svg/W3C-SVG-1.1/painting-marker-02-f-expected.checksum:
        * svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
        * svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-19 Eric Seidel <eric@eseidel.com>
eseidel [Wed, 20 Sep 2006 09:20:39 +0000 (09:20 +0000)]
2006-09-19  Eric Seidel  <eric@eseidel.com>

        Reviewed by hyatt.

        Split KCanvasResources.* into multiple files (and some other minor spacing changes).

        No tests were harmed in the making of this patch.

        * WebCore.xcodeproj/project.pbxproj:
        * kcanvas/KCanvasClipper.cpp: Added.
        (WebCore::operator<<):
        * kcanvas/KCanvasClipper.h: Added.
        * kcanvas/KCanvasFilters.h:
        * kcanvas/KCanvasImage.h:
        * kcanvas/KCanvasMarker.cpp: Added.
        * kcanvas/KCanvasMarker.h: Added.
        * kcanvas/KCanvasMasker.cpp: Added.
        (WebCore::KCanvasMasker::KCanvasMasker):
        (WebCore::KCanvasMasker::setMask):
        (WebCore::KCanvasMasker::externalRepresentation):
        (WebCore::getMaskerById):
        * kcanvas/KCanvasMasker.h: Added.
        * kcanvas/KCanvasResource.cpp: Added.
        (WebCore::KCanvasResource::invalidate):
        (WebCore::KCanvasResource::externalRepresentation):
        (WebCore::getResourceById):
        (WebCore::getPaintServerById):
        * kcanvas/KCanvasResource.h: Added.
        * kcanvas/KCanvasResources.cpp: Removed.
        * kcanvas/KCanvasResources.h: Removed.
        * kcanvas/RenderPath.cpp:
        * kcanvas/RenderSVGContainer.cpp:
        * kcanvas/RenderSVGImage.cpp:
        * kcanvas/RenderSVGText.cpp:
        * kcanvas/device/KRenderingPaintServer.h:
        * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
        * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
        * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
        * ksvg2/svg/SVGClipPathElement.h:
        * ksvg2/svg/SVGFEColorMatrixElement.cpp:
        * ksvg2/svg/SVGFEComponentTransferElement.cpp:
        * ksvg2/svg/SVGFECompositeElement.cpp:
        * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
        * ksvg2/svg/SVGFELightElement.cpp:
        * ksvg2/svg/SVGFEOffsetElement.cpp:
        * ksvg2/svg/SVGFETurbulenceElement.cpp:
        * ksvg2/svg/SVGFilterElement.cpp:
        * ksvg2/svg/SVGLinearGradientElement.cpp:
        * ksvg2/svg/SVGMarkerElement.h:
        * ksvg2/svg/SVGMaskElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
beidson [Wed, 20 Sep 2006 07:16:10 +0000 (07:16 +0000)]
WebCore:

        Reviewed by Sarge Decker

        <rdar://problem/4739892> and <rdar://problem/4729797>
        - WebCore::IconDatabase needs to have and respect an enabled() flag
        - Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari

        * bridge/mac/WebCoreIconDatabaseBridge.h:
        * bridge/mac/WebCoreIconDatabaseBridge.mm:
        (-[WebCoreIconDatabaseBridge _setEnabled:]): Added
        (-[WebCoreIconDatabaseBridge _isEnabled]): Added
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::IconDatabase):
        (WebCore::IconDatabase::open): Don't open if disabled
        (WebCore::IconDatabase::removeAllIcons): Ignore if disabled/closed
        (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ignore if disabled/closed
        (WebCore::IconDatabase::iconForPageURL): Default Icon if disabled/closed
        (WebCore::IconDatabase::isIconExpiredForIconURL): Default return if disabled/closed
        (WebCore::IconDatabase::iconURLForPageURL): Default return if disabled/closed
        (WebCore::IconDatabase::retainIconForPageURL): Ignore if disabled/closed
        (WebCore::IconDatabase::releaseIconForPageURL): Ignore if disabled/closed
        (WebCore::IconDatabase::releaseIconURL):
        (WebCore::IconDatabase::setIconDataForIconURL): Ignore if disabled/closed
        (WebCore::IconDatabase::setIconURLForPageURL): Ignore if disabled/closed
        (WebCore::IconDatabase::hasEntryForIconURL): Default return if disabled/closed
        (WebCore::IconDatabase::setEnabled): Added
        * loader/icon/IconDatabase.h:
        (WebCore::IconDatabase::enabled): Added
        * page/Frame.cpp:
        (WebCore::Frame::endIfNotLoading): do an IconDatabase::enabled() check before bothering to load the icon
        * platform/mac/ResourceLoaderMac.mm: Removed extraneous #include

WebKit:

        Reviewed by Sarge Decker

        <rdar://problem/4739892> and <rdar://problem/4729797>
        - WebCore::IconDatabase needs to have and respect an enabled() flag
        - Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari

        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase init]): If preference says icons are disabled, tell the bridge
        (-[WebIconDatabase _isEnabled]): Ask the bridge if the database is enabled

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Massage mouse wheel handling so that it is more cross-platform. Make
hyatt [Wed, 20 Sep 2006 07:06:57 +0000 (07:06 +0000)]
    Massage mouse wheel handling so that it is more cross-platform.  Make
        all the work happen in handleWheelEvent on the FrameView.

        Reviewed by bradee-oh

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::wheelEvent):
        * page/FrameView.cpp:
        (WebCore::FrameView::handleWheelEvent):
        * platform/PlatformWheelEvent.h:
        (WebCore::PlatformWheelEvent::platformDelta):
        (WebCore::PlatformWheelEvent::delta):
        * platform/mac/WheelEventMac.mm:
        (WebCore::platformDeltaForEvent):
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scroll):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::scroll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-19 Eric Seidel <eric@eseidel.com>
eseidel [Wed, 20 Sep 2006 05:37:18 +0000 (05:37 +0000)]
2006-09-19  Eric Seidel  <eric@eseidel.com>

        Reviewed by adele.

        Improve test output for filters with bounding-box relative sizes.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8585

        Many test results updated.

        * kcanvas/KCanvasFilters.cpp:
        (WebCore::KCanvasFilter::externalRepresentation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-19 Eric Seidel <eric@eseidel.com>
eseidel [Wed, 20 Sep 2006 05:26:46 +0000 (05:26 +0000)]
2006-09-19  Eric Seidel  <eric@eseidel.com>

        Reviewed by adele.

        Markers should clip to their viewport.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5967

        Test: svg/custom/marker-overflow-clip.svg

        * kcanvas/KCanvasResources.cpp:
        (WebCore::KCanvasMarker::KCanvasMarker):
        (WebCore::KCanvasMarker::setMarker):
        (WebCore::KCanvasMarker::draw):
        * kcanvas/KCanvasResources.h:
        (WebCore::KCanvasMasker::mask):
        * ksvg2/svg/SVGMarkerElement.cpp:
        (WebCore::SVGMarkerElement::SVGMarkerElement):
        (WebCore::SVGMarkerElement::parseMappedAttribute):
        (WebCore::SVGMarkerElement::canvasResource):
        (WebCore::SVGMarkerElement::createRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoChecking the mail post-commit hook on the new server
beidson [Wed, 20 Sep 2006 03:57:18 +0000 (03:57 +0000)]
Checking the mail post-commit hook on the new server

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoCheckin test on the new hardware!
beidson [Wed, 20 Sep 2006 03:46:03 +0000 (03:46 +0000)]
Checkin test on the new hardware!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Wed, 20 Sep 2006 01:57:03 +0000 (01:57 +0000)]
LayoutTests:

        Reviewed by eseidel

        Disabling this test temporarily.

        * editing/selection/editable-links.html: Removed.
        * editing/selection/editable-links.html-disabled: Added.

WebCore:

        Reviewed by eseidel

        Backing out my recent change.

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::adjustRenderStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Kevin McCullough
beidson [Wed, 20 Sep 2006 00:53:48 +0000 (00:53 +0000)]
    Reviewed by Kevin McCullough

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10940
        Opening a PDF in a new tab/window creates a documentless-frame
        and we deref the document without checking its validity

        * page/Frame.cpp:
        (WebCore::Frame::iconURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Tue, 19 Sep 2006 23:36:03 +0000 (23:36 +0000)]
LayoutTests:

        Reviewed by harrison

        * editing/selection/editable-links-expected.checksum: Added.
        * editing/selection/editable-links-expected.png: Added.
        * editing/selection/editable-links-expected.txt: Added.
        * editing/selection/editable-links.html: Added.

WebCore:

        Reviewed by harrison

        <rdar://problem/4735272>
        Can not click into link in programmatically editable content

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::adjustRenderStyle): We stopped using
        userModify to implement document wide editability.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoI totally LIED in the Changelog
beidson [Tue, 19 Sep 2006 23:25:56 +0000 (23:25 +0000)]
I totally LIED in the Changelog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed and landed by Brady
beidson [Tue, 19 Sep 2006 23:24:37 +0000 (23:24 +0000)]
    Reviewed and landed by Brady

        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10939
        Build broken when SVG is not enabled.

        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::startElementNs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16454 268f45cc-cd09-0410-ab3c-d52691b4dbfc