WebKit-https.git
9 years agoPerf-o-matic build fix. Also toggle the switch to start using ping images on the...
rniwa@webkit.org [Thu, 1 Mar 2012 07:50:59 +0000 (07:50 +0000)]
Perf-o-matic build fix. Also toggle the switch to start using ping images on the dashboard after r109190.

* Websites/webkit-perf.appspot.com/controller.py:
(schedule_runs_update):
(schedule_report_process):
* Websites/webkit-perf.appspot.com/js/admin.js:
(bind):
* Websites/webkit-perf.appspot.com/js/config.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoScriptExecutionContext has too many ifdef ENABLE(SQL_DATABASE)
abarth@webkit.org [Thu, 1 Mar 2012 07:46:27 +0000 (07:46 +0000)]
ScriptExecutionContext has too many ifdef ENABLE(SQL_DATABASE)
https://bugs.webkit.org/show_bug.cgi?id=79633

Reviewed by Eric Seidel.

Source/WebCore:

This class creates a DatabaseContext object to supplement the
ScriptExecutionContext with database-specific information.  This new
object lets us remove a bunch of database-specific (and ifdefed) logic
from ScriptExecutionContext.(cpp|h).

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore):
* dom/ScriptExecutionContext.h:
(WebCore):
(ScriptExecutionContext):
* history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
* platform/Supplementable.h:
(WebCore::Supplementable::provideSupplement):
(WebCore::Supplementable::requireSupplement):
(Supplementable):
* storage/AbstractDatabase.cpp:
(WebCore::AbstractDatabase::AbstractDatabase):
* storage/AbstractDatabase.h:
(WebCore):
(WebCore::AbstractDatabase::databaseContext):
(AbstractDatabase):
* storage/Database.cpp:
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::markAsDeletedAndClose):
(WebCore::Database::close):
(WebCore::Database::closeImmediately):
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::scheduleTransaction):
(WebCore::Database::scheduleTransactionStep):
(WebCore::Database::transactionClient):
(WebCore::Database::transactionCoordinator):
(WebCore::Database::tableNames):
(WebCore::Database::securityOrigin):
* storage/DatabaseContext.cpp: Added.
(WebCore):
(WebCore::existingDatabaseContextFrom):
(WebCore::DatabaseContext::DatabaseContext):
(WebCore::DatabaseContext::~DatabaseContext):
(WebCore::DatabaseContext::from):
(WebCore::DatabaseContext::databaseThread):
(WebCore::DatabaseContext::hasOpenDatabases):
(WebCore::DatabaseContext::stopDatabases):
* storage/DatabaseContext.h: Added.
(WebCore):
(DatabaseContext):
(WebCore::DatabaseContext::setHasOpenDatabases):
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::checkAndHandleClosedOrInterruptedDatabase):
(WebCore::SQLTransaction::notifyDatabaseThreadIsShuttingDown):
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadShutdownStartTask::performTask):

Source/WebKit/mac:

* WebView/WebFrame.mm:
(-[WebFrame _cacheabilityDictionary]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG BasicBlocks should not require that their nodes have continuous indices in the...
yuqiang.xian@intel.com [Thu, 1 Mar 2012 07:39:31 +0000 (07:39 +0000)]
DFG BasicBlocks should not require that their nodes have continuous indices in the graph
https://bugs.webkit.org/show_bug.cgi?id=79899

Reviewed by Filip Pizlo.

This will make it more convenient to insert nodes into the DFG.
With this capability we now place the Phi nodes in the corresponding
blocks.
Local CSE is modified to not to rely on the assumption of continuous
node indices in a block.
This is performance neutral on SunSpider, V8 and Kraken.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::AbstractState):
(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::clobberStructures):
(JSC::DFG::AbstractState::mergeToSuccessors):
(JSC::DFG::AbstractState::dump):
* dfg/DFGAbstractState.h:
(JSC::DFG::AbstractState::forNode):
(AbstractState):
* dfg/DFGArithNodeFlagsInferencePhase.cpp:
(ArithNodeFlagsInferencePhase):
* dfg/DFGBasicBlock.h:
(JSC::DFG::BasicBlock::BasicBlock):
(BasicBlock):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addToGraph):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::insertPhiNode):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::determineReachability):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
* dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::performBlockCFA):
(CFAPhase):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::CSEPhase):
(JSC::DFG::CSEPhase::endIndexForPureCSE):
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::impureCSE):
(JSC::DFG::CSEPhase::globalVarLoadElimination):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkFunctionElimination):
(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getScopeChainLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::performBlockCSE):
(CSEPhase):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGPhase.cpp:
(JSC::DFG::Phase::beginPhase):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
* dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDisable watchlist. It's been spamming CCs.
abarth@webkit.org [Thu, 1 Mar 2012 07:34:35 +0000 (07:34 +0000)]
Disable watchlist.  It's been spamming CCs.

* Scripts/webkitpy/tool/bot/stylequeuetask.py:
(StyleQueueTask.run):
* Scripts/webkitpy/tool/commands/queues_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, gardening.
haraken@chromium.org [Thu, 1 Mar 2012 07:23:26 +0000 (07:23 +0000)]
Unreviewed, gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r109309.
shinyak@chromium.org [Thu, 1 Mar 2012 07:10:42 +0000 (07:10 +0000)]
Unreviewed, rolling out r109309.
http://trac.webkit.org/changeset/109309
https://bugs.webkit.org/show_bug.cgi?id=80002

broke

* fast/dom/resources/shadow-test-driver.js:
(createContentWithSelect):
* fast/dom/shadow/content-element-move.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rolled DEPS.
kinuko@chromium.org [Thu, 1 Mar 2012 06:54:16 +0000 (06:54 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefactoring: HTMLContentSelector should be InsertionPoint-aware.
shinyak@chromium.org [Thu, 1 Mar 2012 06:39:22 +0000 (06:39 +0000)]
Refactoring: HTMLContentSelector should be InsertionPoint-aware.
https://bugs.webkit.org/show_bug.cgi?id=79901

Reviewed by Hajime Morita.

ContentSelectorQuery took HTMLContentElement as argument, but patch changes it to take InsertionPoint instead.
If InsertionPoint is not HTMLContentElement, ContentSelectorQuery will selects the rest of light children.

Now InsertionPoint has pure virtual method 'select'. <shadow> will implement this as a method returning empty string.

* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::hasInsertionPoint):
* dom/ShadowRoot.h:
(ShadowRoot):
* dom/ShadowTree.cpp:
(WebCore::ShadowTree::needsReattachHostChildrenAndShadow):
(WebCore::ShadowTree::hostChildrenChanged):
* html/shadow/ContentSelectorQuery.cpp:
(WebCore::ContentSelectorQuery::ContentSelectorQuery):
(WebCore::ContentSelectorQuery::matches):
* html/shadow/ContentSelectorQuery.h:
(WebCore):
(ContentSelectorQuery):
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::detach):
* html/shadow/HTMLContentElement.h:
(WebCore::toHTMLContentElement):
(WebCore):
* html/shadow/HTMLContentSelector.cpp:
(WebCore::HTMLContentSelector::select):
* html/shadow/HTMLContentSelector.h:
(HTMLContentSelector):
* html/shadow/InsertionPoint.h:
(InsertionPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, gardening.
haraken@chromium.org [Thu, 1 Mar 2012 06:36:06 +0000 (06:36 +0000)]
Unreviewed, gardening.

* platform/chromium-mac-snowleopard/media/sources-fallback-codecs-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHandle CSSPropertySpeak in CSSStyleApplyProperty.
macpherson@chromium.org [Thu, 1 Mar 2012 06:22:39 +0000 (06:22 +0000)]
Handle CSSPropertySpeak in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=79879

Reviewed by Eric Seidel.

No new tests / refactoring only.

* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHandle CSSPropertyWebkitColumnAxis in CSSStyleApplyProperty.
macpherson@chromium.org [Thu, 1 Mar 2012 06:12:22 +0000 (06:12 +0000)]
Handle CSSPropertyWebkitColumnAxis in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=79869

Reviewed by Eric Seidel.

No new tests / refactoring only.

* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocreateContentWithSelect in shadow-test-driver.js is not intuitive.
shinyak@chromium.org [Thu, 1 Mar 2012 05:57:05 +0000 (05:57 +0000)]
createContentWithSelect in shadow-test-driver.js is not intuitive.
https://bugs.webkit.org/show_bug.cgi?id=80002

Reviewed by Hajime Morita.

createContentWithSelect takes an agument 'fallback', but it used to create a text node
if the argument is missing. This is not intuitive at all.

This patch changes the createContentWithSelect behavior to make it intuitive.

* fast/dom/resources/shadow-test-driver.js:
(createContentWithSelect):
* fast/dom/shadow/content-element-move.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThe JIT should not crash the entire process just because there is not
fpizlo@apple.com [Thu, 1 Mar 2012 05:47:19 +0000 (05:47 +0000)]
The JIT should not crash the entire process just because there is not
enough executable memory, if the LLInt is enabled
https://bugs.webkit.org/show_bug.cgi?id=79962
<rdar://problem/10922215>

Unreviewed, adding forgotten file.

* jit/JITCompilationEffort.h: Added.
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThe JIT should not crash the entire process just because there is not
fpizlo@apple.com [Thu, 1 Mar 2012 05:46:20 +0000 (05:46 +0000)]
The JIT should not crash the entire process just because there is not
enough executable memory, if the LLInt is enabled
https://bugs.webkit.org/show_bug.cgi?id=79962
<rdar://problem/10922215>

Reviewed by Gavin Barraclough.

Added the notion of JITCompilationEffort. If we're JIT'ing as a result of
a tier-up, then we set it to JITCompilationCanFail. Otherwise it's
JITCompilationMustSucceed. This preserves the old behavior of LLInt is
disabled or if we're compiling something that can't be interpreted (like
an OSR exit stub).

* JavaScriptCore.xcodeproj/project.pbxproj:
* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
* assembler/ARMAssembler.h:
(ARMAssembler):
* assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::executableCopy):
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::~LinkBuffer):
(LinkBuffer):
(JSC::LinkBuffer::didFailToAllocate):
(JSC::LinkBuffer::isValid):
(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::performFinalization):
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::executableCopy):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::executableCopy):
* assembler/X86Assembler.h:
(JSC::X86Assembler::executableCopy):
(JSC::X86Assembler::X86InstructionFormatter::executableCopy):
* bytecode/CodeBlock.cpp:
(JSC::ProgramCodeBlock::jitCompileImpl):
(JSC::EvalCodeBlock::jitCompileImpl):
(JSC::FunctionCodeBlock::jitCompileImpl):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::jitCompile):
(CodeBlock):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGJITCompiler.h:
(JITCompiler):
* jit/ExecutableAllocator.cpp:
(JSC::DemandExecutableAllocator::allocateNewSpace):
(JSC::ExecutableAllocator::allocate):
* jit/ExecutableAllocator.h:
(ExecutableAllocator):
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::ExecutableAllocator::allocate):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JIT.h:
(JSC::JIT::compile):
(JIT):
* jit/JITCompilationEffort.h: Added.
(JSC):
* jit/JITDriver.h:
(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):
* llint/LLIntSlowPaths.cpp:
(LLInt):
(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::entryOSR):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* runtime/Executable.cpp:
(JSC::EvalExecutable::jitCompile):
(JSC::ProgramExecutable::jitCompile):
(JSC::FunctionExecutable::jitCompileForCall):
(JSC::FunctionExecutable::jitCompileForConstruct):
* runtime/Executable.h:
(EvalExecutable):
(ProgramExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::jitCompileFor):
* runtime/ExecutionHarness.h:
(JSC::prepareForExecution):
(JSC::prepareFunctionForExecution):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename DOMSelection to Selection
arv@chromium.org [Thu, 1 Mar 2012 05:34:33 +0000 (05:34 +0000)]
Rename DOMSelection to Selection
https://bugs.webkit.org/show_bug.cgi?id=79688

Reviewed by Adam Barth.

Source/WebCore:

No new tests. Existing tests have been updated to cover this.

* page/DOMSelection.idl:
* page/DOMWindow.idl:

LayoutTests:

* fast/dom/Window/window-properties-expected.txt:
* fast/dom/dom-constructors-expected.txt:
* fast/dom/dom-constructors.html:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/win/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: IDBDatabase.objectStoreNames and IDObjectStore.indexNames results should...
jsbell@chromium.org [Thu, 1 Mar 2012 05:22:57 +0000 (05:22 +0000)]
IndexedDB: IDBDatabase.objectStoreNames and IDObjectStore.indexNames results should be sorted
https://bugs.webkit.org/show_bug.cgi?id=79950

Reviewed by Tony Chang.

Source/WebCore:

Test: storage/indexeddb/list-ordering.html

* dom/DOMStringList.cpp: Added sort method, not exposed via IDL.
(WebCore::DOMStringList::sort):
(WebCore):
* dom/DOMStringList.h:
(DOMStringList):
* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::objectStoreNames):
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::indexNames):

LayoutTests:

* storage/indexeddb/list-ordering-expected.txt: Added.
* storage/indexeddb/list-ordering.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Estimate pixel count for frame rate control
wjmaclean@chromium.org [Thu, 1 Mar 2012 04:33:03 +0000 (04:33 +0000)]
[chromium] Estimate pixel count for frame rate control
https://bugs.webkit.org/show_bug.cgi?id=74982

Reviewed by James Robinson.

Source/WebCore:

Value checks added to unit tests.

Adds mechanism to compute and collect statistics on pixel overdraw for selected frames.

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::optimizeRenderPasses):
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::wedgeProduct):
(WebCore):
(WebCore::quadArea):
(WebCore::CCQuadCuller::cullOccludedQuads):
* platform/graphics/chromium/cc/CCQuadCuller.h:
(CCQuadCuller):
* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::optimizeQuads):
* platform/graphics/chromium/cc/CCRenderPass.h:
(CCOverdrawCounts):
(WebCore):
(CCRenderPass):

Source/WebKit/chromium:

Adds mechanism to compute and collect statistics on pixel overdraw for selected frames.

* tests/CCQuadCullerTest.cpp:
(WebCore):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, gardening.
haraken@chromium.org [Thu, 1 Mar 2012 04:26:39 +0000 (04:26 +0000)]
Unreviewed, gardening.

* platform/chromium-linux/fast/workers/storage/use-same-database-in-page-and-workers-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Get rid of the #ifdef mess in LayerTreeHost[Proxy]
noam.rosenthal@nokia.com [Thu, 1 Mar 2012 04:22:28 +0000 (04:22 +0000)]
[Qt][WK2] Get rid of the #ifdef mess in LayerTreeHost[Proxy]
https://bugs.webkit.org/show_bug.cgi?id=79501

Source/JavaScriptCore:

Enable WTF_USE_UI_SIDE_COMPOSITING for Qt.

Reviewed by Kenneth Rohde Christiansen.

* wtf/Platform.h:

Source/WebKit2:

Use a new UI_SIDE_COMPOSITING flag instead of the several #ifdef flags we currently use.

Reviewed by Kenneth Rohde Christiansen.

* Shared/WebLayerTreeInfo.cpp:
* Shared/WebLayerTreeInfo.h:
* UIProcess/DrawingAreaProxy.cpp:
(WebKit):
* UIProcess/DrawingAreaProxy.h:
(DrawingAreaProxy):
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit):
* UIProcess/DrawingAreaProxyImpl.h:
(DrawingAreaProxyImpl):
* UIProcess/LayerTreeHostProxy.h:
(LayerTreeHostProxy):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
* UIProcess/qt/LayerBackingStore.cpp:
* UIProcess/qt/LayerBackingStore.h:
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
* WebProcess/WebCoreSupport/WebGraphicsLayer.h:
* WebProcess/WebPage/DrawingArea.h:
(DrawingArea):
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit):
* WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):
* WebProcess/WebPage/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::create):
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::purgeBackingStores):
* WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry]Make about:cache feature available in release version.
commit-queue@webkit.org [Thu, 1 Mar 2012 04:20:18 +0000 (04:20 +0000)]
[BlackBerry]Make about:cache feature available in release version.
https://bugs.webkit.org/show_bug.cgi?id=79866

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-02-29
Reviewed by Antonio Gomes.

No tests.
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleAbout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fix navigation start time on cross-renderer navigation
simonjam@chromium.org [Thu, 1 Mar 2012 04:08:54 +0000 (04:08 +0000)]
[chromium] Fix navigation start time on cross-renderer navigation
https://bugs.webkit.org/show_bug.cgi?id=75922

Reviewed by Darin Fisher.

Source/WebCore:

* loader/DocumentLoadTiming.cpp:
(WebCore::DocumentLoadTiming::setNavigationStart): Added.
* loader/DocumentLoadTiming.h:

Source/WebKit/chromium:

* public/WebDataSource.h:
* src/WebDataSource.cpp:
(WebKit::WebDataSource::setNavigationStartTime): Added.
* src/WebDataSource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSVG <use> element allows invalid contents
commit-queue@webkit.org [Thu, 1 Mar 2012 03:54:24 +0000 (03:54 +0000)]
SVG <use> element allows invalid contents
https://bugs.webkit.org/show_bug.cgi?id=77764

Patch by Stephen Chenney <schenney@chromium.org> on 2012-02-29
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Modify the isDisallowedElement method to disallow all of the
disallowed elements, instead of just a few. It is now a whitelist
implementation.

This also fixes bugs 78807, 78838 and 79798 related to memory
corruption issues.

Tests: svg/custom/bug78807.svg
       svg/custom/bug78838.html
       svg/custom/bug79798.html

* svg/SVGUseElement.cpp:
(WebCore::isDisallowedElement):

LayoutTests:

These test all use invalid elements in the <use> and crash in the absence
of this patch. Existing tests cover the valid elements in <use>, so no
additional tests for those.

* svg/custom/bug78807-expected.txt: Added.
* svg/custom/bug78807.svg: Added.
* svg/custom/bug78838-expected.txt: Added.
* svg/custom/bug78838.html: Added.
* svg/custom/bug79798-expected.txt: Added.
* svg/custom/bug79798.html: Added.
* svg/custom/resources/bug78838.svg: Added.
* svg/custom/resources/bug79798.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoContinue the search for playable mime types among <source> children of <video> even...
fischman@chromium.org [Thu, 1 Mar 2012 03:38:02 +0000 (03:38 +0000)]
Continue the search for playable mime types among <source> children of <video> even when using data: URLs
https://bugs.webkit.org/show_bug.cgi?id=79934

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/sources-fallback-codecs.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::selectNextSourceChild):

LayoutTests:

* media/sources-fallback-codecs-expected.txt: Added.
* media/sources-fallback-codecs.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add impl-thread support for animation-timing-function
commit-queue@webkit.org [Thu, 1 Mar 2012 03:34:31 +0000 (03:34 +0000)]
[chromium] Add impl-thread support for animation-timing-function
https://bugs.webkit.org/show_bug.cgi?id=79819

Patch by Ian Vollick <vollick@chromium.org> on 2012-02-29
Reviewed by James Robinson.

Source/WebCore:

* WebCore.gypi:
* platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp:
(WebCore::CCKeyframe::CCKeyframe):
(WebCore):
(WebCore::CCKeyframe::~CCKeyframe):
(WebCore::CCKeyframe::time):
(WebCore::CCKeyframe::timingFunction):
(WebCore::CCFloatKeyframe::create):
(WebCore::CCFloatKeyframe::CCFloatKeyframe):
(WebCore::CCFloatKeyframe::~CCFloatKeyframe):
(WebCore::CCFloatKeyframe::value):
(WebCore::CCFloatKeyframe::clone):
(WebCore::CCTransformKeyframe::create):
(WebCore::CCTransformKeyframe::CCTransformKeyframe):
(WebCore::CCTransformKeyframe::~CCTransformKeyframe):
(WebCore::CCTransformKeyframe::value):
(WebCore::CCTransformKeyframe::clone):
(WebCore::CCKeyframedFloatAnimationCurve::create):
(WebCore::CCKeyframedFloatAnimationCurve::CCKeyframedFloatAnimationCurve):
(WebCore::CCKeyframedFloatAnimationCurve::addKeyframe):
(WebCore::CCKeyframedFloatAnimationCurve::duration):
(WebCore::CCKeyframedFloatAnimationCurve::clone):
(WebCore::CCKeyframedFloatAnimationCurve::getValue):
(WebCore::CCKeyframedTransformAnimationCurve::create):
(WebCore::CCKeyframedTransformAnimationCurve::CCKeyframedTransformAnimationCurve):
(WebCore::CCKeyframedTransformAnimationCurve::~CCKeyframedTransformAnimationCurve):
(WebCore::CCKeyframedTransformAnimationCurve::addKeyframe):
(WebCore::CCKeyframedTransformAnimationCurve::duration):
(WebCore::CCKeyframedTransformAnimationCurve::clone):
(WebCore::CCKeyframedTransformAnimationCurve::getValue):
* platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:
(CCKeyframe):
(CCFloatKeyframe):
(WebCore):
(CCTransformKeyframe):
(CCKeyframedFloatAnimationCurve):
(CCKeyframedTransformAnimationCurve):
* platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
* platform/graphics/chromium/cc/CCTimingFunction.cpp: Added.
(WebCore):
(WebCore::CCTimingFunction::CCTimingFunction):
(WebCore::CCTimingFunction::~CCTimingFunction):
(WebCore::CCTimingFunction::duration):
(WebCore::CCCubicBezierTimingFunction::create):
(WebCore::CCCubicBezierTimingFunction::CCCubicBezierTimingFunction):
(WebCore::CCCubicBezierTimingFunction::~CCCubicBezierTimingFunction):
(WebCore::CCCubicBezierTimingFunction::getValue):
(WebCore::CCCubicBezierTimingFunction::clone):
(WebCore::CCEaseTimingFunction::create):
(WebCore::CCEaseInTimingFunction::create):
(WebCore::CCEaseOutTimingFunction::create):
(WebCore::CCEaseInOutTimingFunction::create):
* platform/graphics/chromium/cc/CCTimingFunction.h: Added.
(WebCore):
(CCTimingFunction):
(CCCubicBezierTimingFunction):
(CCEaseTimingFunction):
(CCEaseInTimingFunction):
(CCEaseOutTimingFunction):
(CCEaseInOutTimingFunction):

Source/WebKit/chromium:

* tests/CCKeyframedAnimationCurveTest.cpp:
(WebCore::TEST):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoneed to clone the gpu baselines and expectations into the new "virtual" dir
dpranke@chromium.org [Thu, 1 Mar 2012 02:51:45 +0000 (02:51 +0000)]
need to clone the gpu baselines and expectations into the new "virtual" dir
https://bugs.webkit.org/show_bug.cgi?id=79956

Tools:

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.virtual_test_suites):

LayoutTests:

Unreviewed, expectations change and new baselines.

* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/arc360-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-before-css-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-expected.txt: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-resize-reset-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-text-baseline-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-transforms-during-path-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvasDrawingIntoSelf-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/drawImage-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/fillrect-gradient-zero-stops-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/patternfill-repeat-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-1-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-2-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-3-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-4-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-5-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-6-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-7-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/toDataURL-alpha-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/zero-size-fill-rect-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.gradient.radial.cone.cylinder-expected.txt: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.line.width.basic-expected.txt: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.line.width.transformed-expected.txt: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.path.arcTo.shape.curve1-expected.txt: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.path.arcTo.shape.curve2-expected.txt: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.shadow.enable.blur-expected.txt: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.text.draw.fontface.notinpage-expected.txt: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.transformation.setTransform.skewed-expected.txt: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.transformation.transform.skewed-expected.txt: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-as-image-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-zoom-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-currentColor-expected.txt: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-fillPath-shadow-expected.txt: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-shadow-expected.txt: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-text-baseline-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-transform-skewed-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-transforms-during-path-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/fillrect-gradient-zero-stops-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/patternfill-repeat-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/arc360-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-as-image-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-as-image-expected.txt: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-as-image-incremental-repaint-expected.txt: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-before-css-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-expected.txt: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-zoom-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-zoom-expected.txt: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-empty-image-pattern-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-resize-reset-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-text-baseline-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-transform-identity-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-transform-infinity-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-transform-multiply-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-transform-nan-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-transform-non-invertible-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-transform-skewed-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-transforms-during-path-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvasDrawingIntoSelf-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/drawImage-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/fillrect-gradient-zero-stops-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/patternfill-repeat-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-1-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-2-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-3-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-4-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-5-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-6-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-7-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/toDataURL-alpha-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/zero-size-fill-rect-expected.png: Added.
* platform/chromium/test_expectations.txt:
* platform/chromium/virtual/gpu/README.txt: Added.
* platform/chromium/virtual/gpu/canvas/philip/README.txt: Added.
* platform/chromium/virtual/gpu/fast/canvas/README.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CMake] Unreviewed, fix build on 64-bit platforms with SHARED_CORE=ON after r109197.
kubo@profusion.mobi [Thu, 1 Mar 2012 02:39:26 +0000 (02:39 +0000)]
[CMake] Unreviewed, fix build on 64-bit platforms with SHARED_CORE=ON after r109197.
https://bugs.webkit.org/show_bug.cgi?id=79965

This partially reverts r66714, in that whether -fPIC is passed to
the compiler does not depend on the value of SHARED_CORE anymore:
since we always build WTF as a static library, it will always need
-fPIC because our shared libraries are built with it.

* Source/cmake/WebKitHelpers.cmake: Always pass -fPIC to
STATIC_LIBRARY targets.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSwitch to using json rather than simplejson now that the master is using Python 2.7.
mrowe@apple.com [Thu, 1 Mar 2012 02:38:03 +0000 (02:38 +0000)]
Switch to using json rather than simplejson now that the master is using Python 2.7.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(loadBuilderConfig):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
haraken@chromium.org [Thu, 1 Mar 2012 02:28:22 +0000 (02:28 +0000)]
Unreviewed gardening.

* platform/chromium/fast/regions/select-in-region-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CMake] Unreviewed, fix build on 64-bit platforms with SHARED_CORE=ON after r109197.
kubo@profusion.mobi [Thu, 1 Mar 2012 02:09:25 +0000 (02:09 +0000)]
[CMake] Unreviewed, fix build on 64-bit platforms with SHARED_CORE=ON after r109197.

This partially reverts r66714, in that whether -fPIC is passed to
the compiler does not depend on the value of SHARED_CORE anymore:
since we always build WTF as a static library, it will always need
-fPIC because our shared libraries are built with it.

* Source/cmake/WebKitHelpers.cmake: Always pass -fPIC to
STATIC_LIBRARY targets.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, marking RegExp.html as FAIL in Chromium/V8
haraken@chromium.org [Thu, 1 Mar 2012 01:56:39 +0000 (01:56 +0000)]
Unreviewed, marking RegExp.html as FAIL in Chromium/V8
since it requires a fix in V8.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMethods in ShadowTree and TreeScopeAdopter should be multiple shadow roots aware.
shinyak@chromium.org [Thu, 1 Mar 2012 01:55:08 +0000 (01:55 +0000)]
Methods in ShadowTree and TreeScopeAdopter should be multiple shadow roots aware.
https://bugs.webkit.org/show_bug.cgi?id=79768

Reviewed by Hajime Morita.

Source/WebCore:

Some methods in ShadowTree and TreeScopeAdopter were not multiple shadow roots aware.
They should consider multiple shadow roots.

Test: fast/dom/shadow/multiple-shadowroot-adopt.html

* dom/ShadowTree.cpp:
(WebCore::ShadowTree::setParentTreeScope):
(WebCore):
(WebCore::ShadowTree::childNeedsStyleRecalc):
(WebCore::ShadowTree::needsStyleRecalc):
* dom/ShadowTree.h:
(WebCore):
(ShadowTree):
* dom/TreeScopeAdopter.cpp:
(WebCore::shadowTreeFor):
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):
(WebCore::TreeScopeAdopter::moveShadowTreeToNewDocument):
(WebCore):
* dom/TreeScopeAdopter.h:
(TreeScopeAdopter):

LayoutTests:

* fast/dom/shadow/multiple-shadowroot-adopt-expected.txt: Added.
* fast/dom/shadow/multiple-shadowroot-adopt.html: Added.
* platform/efl/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRubber stamped by Oliver Hunt.
barraclough@apple.com [Thu, 1 Mar 2012 01:34:07 +0000 (01:34 +0000)]
Rubber stamped by Oliver Hunt.

* tests/mozilla/ecma_2/RegExp/constructor-001.js:
* tests/mozilla/ecma_2/RegExp/function-001.js:
* tests/mozilla/ecma_2/RegExp/properties-001.js:
    - Check in new test cases results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add the ability to turn off autoresize.
levin@chromium.org [Thu, 1 Mar 2012 01:29:56 +0000 (01:29 +0000)]
[chromium] Add the ability to turn off autoresize.
https://bugs.webkit.org/show_bug.cgi?id=77452

Reviewed by Darin Fisher.

Source/WebCore:

Test: fast/autoresize/turn-off-autoresize.html

* page/FrameView.cpp:
(WebCore::FrameView::enableAutoSizeMode): Fix the code
path for turning off autoresize to set the scrollbars to auto.

Source/WebKit/chromium:

* public/WebView.h:
(WebKit::WebViewImpl::enableAutoResizeMode): Cleaned up the api.
(WebKit::WebViewImpl::disableAutoResizeMode): Added the ability to disable auto-resize.
(WebKit::WebViewImpl::enableAutoResizeMode): Deprecated it.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::enableAutoResizeMode): Adjust for new api.
(WebKit::WebViewImpl::disableAutoResizeMode): Allow turning off autoresize.
(WebKit::WebViewImpl::enableAutoResizeMode): Call the other two apis, but
this api will be deleted shortly.
(WebKit::WebViewImpl::configureAutoResizeMode): Common code.
* src/WebViewImpl.h:
(WebViewImpl): Adjust to new public api.

Tools:

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController): Expose a way to turn off auto-resize.
(LayoutTestController::enableAutoResizeMode): Ditto and adjust to new WebKit api.
(LayoutTestController::disableAutoResizeMode):  Ditto.
* DumpRenderTree/chromium/LayoutTestController.h: Ditto.

LayoutTests:

* fast/autoresize/turn-off-autoresize-expected.txt: Added.
* fast/autoresize/turn-off-autoresize.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStop installing JSCLLIntOffsetsExtractor.
mrowe@apple.com [Thu, 1 Mar 2012 01:26:15 +0000 (01:26 +0000)]
Stop installing JSCLLIntOffsetsExtractor.

Replace the separate TestRegExp and TestAPI xcconfig files with a single ToolExecutable xcconfig file
that derives the product name from the target name. We can then use that xcconfig file for JSCLLIntOffsetsExtractor.
This has the results of setting SKIP_INSTALL = YES for JSCLLIntOffsetsExtractor.

While I was doing this fiddling I noticed that the JSCLLIntOffsetsExtractor target had a custom value
for USER_HEADER_SEARCH_PATHS to allow it to find LLIntDesiredOffsets.h. A better way of doing that is
to add LLIntDesiredOffsets.h to the Xcode project so that it'll be included in the header map. That
allows us to remove the override of USER_HEADER_SEARCH_PATHS entirely. So I did that too!

Reviewed by Filip Pizlo.

* Configurations/TestRegExp.xcconfig: Removed.
* Configurations/ToolExecutable.xcconfig: Renamed from Source/JavaScriptCore/Configurations/TestAPI.xcconfig.
* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<msubsup> setNeedsLayout() correction
commit-queue@webkit.org [Thu, 1 Mar 2012 01:17:33 +0000 (01:17 +0000)]
<msubsup> setNeedsLayout() correction
https://bugs.webkit.org/show_bug.cgi?id=79856

Patch by David Barton <dbarton@mathscribe.com> on 2012-02-29
Reviewed by Julien Chaffraix.

m_scripts->setNeedsLayout(true, false); needs to be added to the fix for bug 79274.

No new tests. It's actually difficult to test the need for this with the current code,
because there are a lot of extra setNeedsLayout() calls right now. I caught this after
removing some of those calls that should be redundant, for a future patch. Actually
removing those calls now changes other behavior, due to other bugs, so I'll save all
that for future patches. We should land this fix now though I think, as it could
possibly matter in some cases.

* rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIsSynchronizingStyleAttributeFlag could be purged.
kling@webkit.org [Thu, 1 Mar 2012 01:03:41 +0000 (01:03 +0000)]
IsSynchronizingStyleAttributeFlag could be purged.
<http://webkit.org/b/79313>

Reviewed by Anders Carlsson.

We were using IsSynchronizingStyleAttributeFlag to prevent various things from
happening below setAttribute() when serializing the "style" attribute based on
an element's inline style.

Simplify the whole thing by adding a way to set an attribute without triggering
any callbacks (a 'notifyChanged' argument to Element::setAttribute().)
This removes the need for IsSynchronizingStyleAttributeFlag in the first place
and makes StyledElement::updateStyleAttribute() a bit cheaper to boot.

* dom/Element.cpp:
(WebCore::Element::setAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::willModifyAttribute):
(WebCore::Element::didModifyAttribute):
(WebCore::Element::didRemoveAttribute):
* dom/Element.h:
* dom/Node.h:
* dom/StyledElement.cpp:
(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::attributeChanged):
* html/HTMLElement.cpp:
(WebCore::StyledElement::copyNonAttributeProperties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAutocomplete attribute should apply to textarea's.
commit-queue@webkit.org [Thu, 1 Mar 2012 00:33:56 +0000 (00:33 +0000)]
Autocomplete attribute should apply to textarea's.
https://bugs.webkit.org/show_bug.cgi?id=79929

Patch by Mike Fenton <mifenton@rim.com> on 2012-02-29
Reviewed by Antonio Gomes.

Allow the autocomplete attribute to bubble back to the form setting.

Expand support to include checking autocorrect, autocomplete and
name/id matching to text areas.

Reviewed internally by Nima Ghanavatian and Gen Mak.

* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::elementSupportsAutocorrect):
(BlackBerry::WebKit::DOMSupport::elementSupportsAutocomplete):
(BlackBerry::WebKit::DOMSupport::elementAttributeState):
* WebKitSupport/DOMSupport.h:
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::inputStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline line-grid tests for Chromium after r109267.
adamk@chromium.org [Thu, 1 Mar 2012 00:33:46 +0000 (00:33 +0000)]
Rebaseline line-grid tests for Chromium after r109267.

Unreviewed gardening.

* platform/chromium-linux/fast/line-grid/line-align-left-edges-expected.png: Added.
* platform/chromium-linux/fast/line-grid/line-align-right-edges-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/line-grid/line-align-left-edges-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/line-grid/line-align-right-edges-expected.png: Added.
* platform/chromium-win/fast/line-grid/line-align-left-edges-expected.png: Added.
* platform/chromium-win/fast/line-grid/line-align-right-edges-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonrwt: make --print trace work with virtual tests
dpranke@chromium.org [Thu, 1 Mar 2012 00:33:13 +0000 (00:33 +0000)]
nrwt: make --print trace work with virtual tests
https://bugs.webkit.org/show_bug.cgi?id=79952

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer._print_test_trace):
(Printer._print_baseline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMark fast/js/kde/RegExp.html test as failing on Chromium due to
adamk@chromium.org [Thu, 1 Mar 2012 00:27:52 +0000 (00:27 +0000)]
Mark fast/js/kde/RegExp.html test as failing on Chromium due to
differing V8 behavior. Opened http://code.google.com/p/v8/issues/detail?id=1982
to track this issue in V8.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] REGRESSION: Cannot drag a file out
dcheng@chromium.org [Thu, 1 Mar 2012 00:14:42 +0000 (00:14 +0000)]
[chromium] REGRESSION: Cannot drag a file out
https://bugs.webkit.org/show_bug.cgi?id=79817

Reviewed by Ryosuke Niwa.

Source/WebCore:

Temporary fix for file drag out. This change won't be needed once DataTransferItemList
support is better implemented.

Test: platform/chromium/fast/events/drag-downloadURL.html

* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):

LayoutTests:

* platform/chromium/fast/events/drag-downloadURL-expected.txt: Added.
* platform/chromium/fast/events/drag-downloadURL.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoClean up CSSPrimitiveValue::computeLengthDouble().
macpherson@chromium.org [Thu, 1 Mar 2012 00:11:45 +0000 (00:11 +0000)]
Clean up CSSPrimitiveValue::computeLengthDouble().
https://bugs.webkit.org/show_bug.cgi?id=77065

Reviewed by Eric Seidel.

Refactoring only / no behavioral change.

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLengthDouble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSpeculative build-fix.
bdakin@apple.com [Wed, 29 Feb 2012 23:59:59 +0000 (23:59 +0000)]
Speculative build-fix.

* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebKit2: WebKit2: didNewFirstVisuallyNonEmptyLayout should be sent to injected...
bweinstein@apple.com [Wed, 29 Feb 2012 23:32:33 +0000 (23:32 +0000)]
Source/WebKit2: WebKit2: didNewFirstVisuallyNonEmptyLayout should be sent to injected bundle
https://bugs.webkit.org/show_bug.cgi?id=79849

Tell the injected bundle about didNewFirstVisuallyNonEmptyLayout (we currently
just tell the UI process).

Reviewed by Beth Dakin.

* WebProcess/InjectedBundle/API/c/WKBundlePage.h: Add didNewFirstVisuallyNonEmptyLayout to version 1.
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didNewFirstVisuallyNonEmptyLayout): Call through to the
    client.
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
(InjectedBundlePageLoaderClient):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidNewFirstVisuallyNonEmptyLayout): Tell the injected
    bundle.

Tools: WebKit2: didNewFirstVisuallyNonEmptyLayout should be sent to injected bundle
https://bugs.webkit.org/show_bug.cgi?id=79849

Reviewed by Beth Dakin.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage): Add an entry to the struct.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemoved unused Apple buildslaves from the master configuration
lforschler@apple.com [Wed, 29 Feb 2012 23:28:00 +0000 (23:28 +0000)]
Removed unused Apple buildslaves from the master configuration
https://bugs.webkit.org/show_bug.cgi?id=79925

Reviewed by Stephanie Lewis.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/JavaScriptCore: RefCounted::deprecatedTurnOffVerifier() should not be deprecated
barraclough@apple.com [Wed, 29 Feb 2012 23:23:58 +0000 (23:23 +0000)]
Source/JavaScriptCore: RefCounted::deprecatedTurnOffVerifier() should not be deprecated
https://bugs.webkit.org/show_bug.cgi?id=79864

Patch by Filip Pizlo <fpizlo@apple.com> on 2012-02-28
Reviewed by Oliver Hunt.

Removed the word "deprecated" from the name of this method, since this method
should not be deprecated. It works just fine as it is, and there is simply no
alternative to calling this method for many interesting JSC classes.

* parser/SourceProvider.h:
(JSC::SourceProvider::SourceProvider):
* runtime/SymbolTable.h:
(JSC::SharedSymbolTable::SharedSymbolTable):
* wtf/MetaAllocator.cpp:
(WTF::MetaAllocatorHandle::MetaAllocatorHandle):
(WTF::MetaAllocator::allocate):
* wtf/RefCounted.h:
(RefCountedBase):
(WTF::RefCountedBase::turnOffVerifier):

LayoutTests: 'source' property of RegExp instance cannot be ""
https://bugs.webkit.org/show_bug.cgi?id=79938

Reviewed by Oliver Hunt.

15.10.6.4 specifies that RegExp.prototype.toString must return '/' + source + '/',
and also states that the result must be a valid RegularExpressionLiteral. '//' is
not a valid RegularExpressionLiteral (since it is a single line comment), and hence
source cannot ever validly be "". If the source is empty, return a different Pattern
that would match the same thing.

* fast/js/kde/RegExp-expected.txt:
* fast/js/kde/script-tests/RegExp.js:
* fast/regex/script-tests/toString.js:
* fast/regex/toString-expected.txt:
    - Update these tests to check for the correct result.
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A3_T1-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A3_T2-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A3_T3-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A3_T4-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A3_T5-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A4_T2-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A4_T3-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A4_T5-expected.txt:
    - Check in failing results, these tests are all incorrect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Wed, 29 Feb 2012 23:10:26 +0000 (23:10 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-29

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=79705
bdakin@apple.com [Wed, 29 Feb 2012 23:10:06 +0000 (23:10 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=79705
didNewFirstVisuallyNonEmptyLayout should be enhanced to look at size instead
of a raw tally
-and corresponding-
<rdar://problem/10821314>

Reviewed by Dave Hyatt.

Instead of firing didNewFirstVisuallyNonEmptyLayout() when a raw tally of
relevant painted objects has reached a port-defined threshold, this patch
looks at the size of those objects with respect to the view area. The patch
also looks at relevant objects that cannot yet be fully painted, such as
incrementally loading images.

We no longer need a HashSet for the relevant painted objects since Region can
do all of the heavy lifting. We now have a Region for the painted and
unpainted regions. We do need a HashSet for the unpainted objects though,
because we need to know if a painted object needs to be subtracted from the
unpainted region before being added to the painted region.
* page/Page.cpp:
(WebCore):
(WebCore::Page::isCountingRelevantRepaintedObjects):
(WebCore::Page::startCountingRelevantRepaintedObjects):
(WebCore::Page::resetRelevantPaintedObjectCounter):
(WebCore::Page::addRelevantRepaintedObject):
(WebCore::Page::addRelevantUnpaintedObject):
* page/Page.h:
(Page):

New function on Region iterates through the rects and calculates the total
area.
* platform/graphics/Region.cpp:
(WebCore::Region::totalArea):
(WebCore):
* platform/graphics/Region.h:
(Region):

Remove code from these classes since they are not actually relevant objects.
* rendering/InlineBox.cpp:
(WebCore::InlineBox::paint):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::paintReplaced):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):

All of these other callers send a rect that actually represents their size
(usually the visualOverflowRect) instead of the paintInfo's paintRect, and
they call addRelevantUnpaintedObject when appropriate.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paint):
(WebCore::RenderEmbeddedObject::paintReplaced):
* rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::paintReplaced):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::paintReplaced):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paintReplaced):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: Resource leak with IDBObjectStore.openCursor
jsbell@chromium.org [Wed, 29 Feb 2012 23:03:19 +0000 (23:03 +0000)]
IndexedDB: Resource leak with IDBObjectStore.openCursor
https://bugs.webkit.org/show_bug.cgi?id=79835

Source/WebCore:

IDBCursor object that were never continue()'d to the end would leak due to a
reference cycle with IDBRequest. In addition, the IDBRequest would never be
marked "finished" which would prevent GC from reclaiming it. IDBTransactions
now track and notify IDBCursors to break these references when the transaction
can no longer not process requests.

Reviewed by Tony Chang.

Tests: storage/indexeddb/cursor-continue.html

* storage/IDBCursor.cpp:
(WebCore::IDBCursor::IDBCursor): Register with IDBTransaction bookkeeping.
(WebCore::IDBCursor::continueFunction): Early error if transaction has finished.
(WebCore::IDBCursor::close): Break the reference cycle with IDBRequest, and notify it
that the cursor is finished.
(WebCore):
* storage/IDBCursor.h:
(WebCore):
(IDBCursor):
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::finishCursor): If there is no request in flight, mark itself as
finished to allow GC.
(WebCore):
(WebCore::IDBRequest::dispatchEvent): Once an in-flight request has been processed,
mark the request as finished if the cursor is finished, to allow GC.
* storage/IDBRequest.h:
(IDBRequest):
* storage/IDBTransaction.cpp: Track open cursors, close them when finished.
(WebCore::IDBTransaction::OpenCursorNotifier::OpenCursorNotifier):
(WebCore):
(WebCore::IDBTransaction::OpenCursorNotifier::~OpenCursorNotifier):
(WebCore::IDBTransaction::registerOpenCursor):
(WebCore::IDBTransaction::unregisterOpenCursor):
(WebCore::IDBTransaction::closeOpenCursors):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
* storage/IDBTransaction.h:
(WebCore):
(OpenCursorNotifier):
(IDBTransaction):

LayoutTests:

Ensure that IDBCursor.continue() throws the right exception when transaction is finished.

Reviewed by Tony Chang.

* storage/indexeddb/cursor-continue-expected.txt:
* storage/indexeddb/cursor-continue.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening. Remove suppressions for rubberbanding tests.
adamk@chromium.org [Wed, 29 Feb 2012 22:51:25 +0000 (22:51 +0000)]
Unreviewed gardening.  Remove suppressions for rubberbanding tests.

These tests were broken by r109183 and should be fixed by r109265.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening, add MAC GPU expectations for 2d.transformation.*
adamk@chromium.org [Wed, 29 Feb 2012 22:47:57 +0000 (22:47 +0000)]
Unreviewed gardening, add MAC GPU expectations for 2d.transformation.*
(removed due to MAC CPU config passing in r109257).

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefCounted::deprecatedTurnOffVerifier() should not be deprecated
fpizlo@apple.com [Wed, 29 Feb 2012 22:47:31 +0000 (22:47 +0000)]
RefCounted::deprecatedTurnOffVerifier() should not be deprecated
https://bugs.webkit.org/show_bug.cgi?id=79864

Reviewed by Oliver Hunt.

Removed the word "deprecated" from the name of this method, since this method
should not be deprecated. It works just fine as it is, and there is simply no
alternative to calling this method for many interesting JSC classes.

* parser/SourceProvider.h:
(JSC::SourceProvider::SourceProvider):
* runtime/SymbolTable.h:
(JSC::SharedSymbolTable::SharedSymbolTable):
* wtf/MetaAllocator.cpp:
(WTF::MetaAllocatorHandle::MetaAllocatorHandle):
(WTF::MetaAllocator::allocate):
* wtf/RefCounted.h:
(RefCountedBase):
(WTF::RefCountedBase::turnOffVerifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=79940
hyatt@apple.com [Wed, 29 Feb 2012 22:44:33 +0000 (22:44 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=79940
<rdar://problem/10080189>

Add support in WebKit for an intra-line character grid for Japanese text layout.

Patch logicalLeftOffsetForLine and logicalRightOffsetForLine in order to get the
basic edge snapping grid functionality up and running. See all the FIXMEs in the function for
some of the issues that still have to be dealt with for it to really work well.

Reviewed by Dan Bernstein.

Added new tests in fast/line-grid.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=79940
<rdar://problem/10080189>

Add support in WebKit for an intra-line character grid for Japanese text layout.

New tests for basic left and right alignment of lines in the presence of
floating and positioned objects as well as objects with margins and borders.

Reviewed by Dan Bernstein.

* fast/line-grid/line-align-left-edges.html: Added.
* fast/line-grid/line-align-right-edges.html: Added.
* platform/mac/fast/line-grid/line-align-left-edges-expected.png: Added.
* platform/mac/fast/line-grid/line-align-left-edges-expected.txt: Added.
* platform/mac/fast/line-grid/line-align-right-edges-expected.png: Added.
* platform/mac/fast/line-grid/line-align-right-edges-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonrwt: implement simple 'virtual test suite' support
dpranke@chromium.org [Wed, 29 Feb 2012 22:43:27 +0000 (22:43 +0000)]
nrwt: implement simple 'virtual test suite' support
https://bugs.webkit.org/show_bug.cgi?id=79737

Reviewed by Adam Barth.

Add very basic support for 'virtual test suites' to NRWT:
a virtual suite is a directory that may contain new baselines,
contains a pointer to a "base" directory of tests, and an
optional list of command line arguments to pass to DRT;
it gives us a way to run all of the tests in a given directory
multiple times with multiple (potentially differing) sets of
results and baselines.

This patch implements the support needed for this feature, and
some basic tests, but no actual port will use the feature yet.

This is probably the simplest implementation possible - the
list of virtual suites will be hard-coded into the port's
implementation. One can imagine a more data-driven approach
where the suite instructions are stored in a manifest file
either in LayoutTests (all suites in one file), or per-port,
or per-directory. If this feature ends up being useful we
should probably add something like that so people don't have
to hunt around in the code to add suites.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.__init__):
(Port.expected_filename):
(Port.tests):
(Port):
(Port._real_tests):
(Port._driver_class):
(Port.virtual_test_suites):
(Port.virtual_suite):
(Port.virtual_suite.VirtualTestSuite):
(Port.virtual_suite.VirtualTestSuite.__init__):
(Port.virtual_suite.VirtualTestSuite.__repr__):
(Port.populated_virtual_test_suites):
(Port._virtual_tests):
(Port.lookup_virtual_test_base):
(Port.lookup_virtual_test_args):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_find_with_skipped_directories):
* Scripts/webkitpy/layout_tests/port/driver.py:
(DriverInput.__init__):
(DriverProxy.run_test):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.virtual_test_suites):
(TestDriver.run_test):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_all):
(MainTest.test_virtual):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Some Layout Tests in platform/chromium/rubberbanding and platform/chromium...
andersca@apple.com [Wed, 29 Feb 2012 22:43:05 +0000 (22:43 +0000)]
[Chromium] Some Layout Tests in platform/chromium/rubberbanding and platform/chromium/compositing/rubberbanding are failing
https://bugs.webkit.org/show_bug.cgi?id=79878

Reviewed by James Robinson.

Make sure that ScrollableArea::setScrollOffsetFromAnimation doesn't end up
setting the ScrollAnimator's current scroll position by making a new function, scrollPositionChanged,
that both notifyScrollPositionChanged and setScrollOffsetFromAnimation call and move the call to update
the position to notifyScrollPositionChanged.

* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::notifyScrollPositionChanged):
(WebCore):
(WebCore::ScrollableArea::scrollPositionChanged):
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
* platform/ScrollableArea.h:
(ScrollableArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonrwt: support more than two drivers in DriverProxy
dpranke@chromium.org [Wed, 29 Feb 2012 22:40:32 +0000 (22:40 +0000)]
nrwt: support more than two drivers in DriverProxy
https://bugs.webkit.org/show_bug.cgi?id=79736

Reviewed by Adam Barth.

Now that we can support per-test command lines for
Drivers, modify DriverProxy to keep a map of running
drivers for each needed command-line; this will allow
us to transparently maintain a pool of appropriately
configured DRTs without having to constantly start and stop
them.

Note that this potentially raises a garbage collection
problem - the number of running DRTs will grow with the
number of different sets of command line args. For now
this is no worse than the current code - if you're running
with pixel tests, you will only need one DRT per worker,
and if you aren't, you'll need two (one for text-only tests,
and one for reftests).

An alternative would be to only ever have one running driver,
and restart the driver as the command line changes, but this
might (?) slow down execution in the text-only case - we
should benchmark this because it would be simpler and possibly
allow us to eliminate DriverProxy altogether.

* Scripts/webkitpy/layout_tests/port/driver.py:
(DriverProxy.__init__):
(DriverProxy):
(DriverProxy._make_driver):
(DriverProxy.run_test):
(DriverProxy.has_crashed):
(DriverProxy.stop):
(DriverProxy.cmd_line):
(DriverProxy._cmd_line_as_key):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Don't let invalidation for next frame prevent tile upload
commit-queue@webkit.org [Wed, 29 Feb 2012 22:35:01 +0000 (22:35 +0000)]
[chromium] Don't let invalidation for next frame prevent tile upload
https://bugs.webkit.org/show_bug.cgi?id=79841

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-29
Reviewed by James Robinson.

Source/WebCore:

We currently don't push dirty tiles to the impl thread so there are no
tiles with garbage data on the impl thread. However, this judgement is
overzealous and blocks tiles that get invalidated by WebKit for the
next frame during the paint of the current frame.

Instead, check if a tile is dirty and was not painted for the current
frame when deciding to push the tile to the impl thread. This requires
that we know if a tile was painted during the current frame, which we
can do if we always reset m_updateRect to be empty each frame.

New unit tests: TiledLayerChromiumTest.pushTilesMarkedDirtyDuringPaint
                TiledLayerChromiumTest.pushTilesLayerMarkedDirtyDuringPaintOnNextLayer
                TiledLayerChromiumTest.pushTilesLayerMarkedDirtyDuringPaintOnPreviousLayer

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::UpdatableTile::isDirtyForCurrentFrame):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore):
(WebCore::TiledLayerChromium::prepareToUpdate):
* platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):

Source/WebKit/chromium:

* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening, remove some more stale expectations (mostly mac repaint tests).
adamk@chromium.org [Wed, 29 Feb 2012 22:30:33 +0000 (22:30 +0000)]
Unreviewed gardening, remove some more stale expectations (mostly mac repaint tests).

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMediaStream API: MediaStreamTrackList out-of-bounds access fix
tommyw@google.com [Wed, 29 Feb 2012 22:13:54 +0000 (22:13 +0000)]
MediaStream API: MediaStreamTrackList out-of-bounds access fix
https://bugs.webkit.org/show_bug.cgi?id=79889

Reviewed by Adam Barth.

Out-of-bounds access to MediaStreamTrackList ASSERTS instead of returning 0,
this is not according to ecmascript standard. Also fixed a similar issue in MediaStreamList.

Source/WebCore:

Test: fast/mediastream/peerconnection-mediastreamlist.html

* Modules/mediastream/MediaStreamList.cpp:
(WebCore::MediaStreamList::item):
* Modules/mediastream/MediaStreamTrackList.cpp:
(WebCore::MediaStreamTrackList::item):

LayoutTests:

* fast/mediastream/peerconnection-mediastreamlist-expected.txt: Added.
* fast/mediastream/peerconnection-mediastreamlist.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening, mark a few more tests as passing.
adamk@chromium.org [Wed, 29 Feb 2012 22:12:12 +0000 (22:12 +0000)]
Unreviewed gardening, mark a few more tests as passing.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Upstream the BlackBerry change to platform/graphics/FloatSize.h
leo.yang@torchmobile.com.cn [Wed, 29 Feb 2012 22:11:06 +0000 (22:11 +0000)]
[BlackBerry] Upstream the BlackBerry change to platform/graphics/FloatSize.h
https://bugs.webkit.org/show_bug.cgi?id=79893

Reviewed by Antonio Gomes.

Add conversion convenience between WebCore::FloatSize and BlackBerry::Platform::FloatSize.

The porting can't be built yet, no new tests.

* platform/graphics/FloatSize.h:
(Platform):
(FloatSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, add myself as a reviewer
enne@google.com [Wed, 29 Feb 2012 22:05:18 +0000 (22:05 +0000)]
Unreviewed, add myself as a reviewer

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening, remove a bunch of expectations for now-passing tests.
adamk@chromium.org [Wed, 29 Feb 2012 21:49:12 +0000 (21:49 +0000)]
Unreviewed gardening, remove a bunch of expectations for now-passing tests.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Upstream the BlackBerry change to platform/graphics/FloatRect.h
leo.yang@torchmobile.com.cn [Wed, 29 Feb 2012 21:41:33 +0000 (21:41 +0000)]
[BlackBerry] Upstream the BlackBerry change to platform/graphics/FloatRect.h
https://bugs.webkit.org/show_bug.cgi?id=79891

Reviewed by Antonio Gomes.

Add conversion convenience between WebCore::FloatRect and BlackBerry::Platform::FloatRect.

The porting can't be built yet, no new tests.

* platform/graphics/FloatRect.h:
(Platform):
(FloatRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake use of CG rounded-rect primitives
timothy_horton@apple.com [Wed, 29 Feb 2012 21:36:12 +0000 (21:36 +0000)]
Make use of CG rounded-rect primitives
https://bugs.webkit.org/show_bug.cgi?id=79932
<rdar://problem/9274953>

Reviewed by Simon Fraser.

Dispatch to potentially platform-specific rounded rectangle path
construction from addPathForRoundedRect. Make use of this to call
wkCGPathAddRoundedRect on Lion and above, as long as the rounded
corners are all equivalent.

No new tests, as this is covered by many that use rounded corners,
and is only a performance improvement.

* WebCore.exp.in:
* platform/graphics/Path.cpp:
(WebCore::Path::addRoundedRect):
(WebCore):
(WebCore::Path::addPathForRoundedRect):
* platform/graphics/Path.h:
(Path):
* platform/graphics/cg/PathCG.cpp:
(WebCore::Path::addPathForRoundedRect):
(WebCore):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

Add wkCGPathAddRoundedRect.

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceLion.a:
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash at -[WebFrame(WebInternal) _setTypingStyle:withUndoAction:]
enrica@apple.com [Wed, 29 Feb 2012 21:28:00 +0000 (21:28 +0000)]
Crash at -[WebFrame(WebInternal) _setTypingStyle:withUndoAction:]
https://bugs.webkit.org/show_bug.cgi?id=79937
<rdar://problem/10942936>

Reviewed by Dan Bernstein.

* WebView/WebFrame.mm:
(-[WebFrame _setTypingStyle:withUndoAction:]): Adding a null check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening, mark some tests as passing on GPU tests.
adamk@chromium.org [Wed, 29 Feb 2012 21:27:19 +0000 (21:27 +0000)]
Unreviewed gardening, mark some tests as passing on GPU tests.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Upstream the BlackBerry change to platform/graphics/FloatPoint.h
leo.yang@torchmobile.com.cn [Wed, 29 Feb 2012 21:25:24 +0000 (21:25 +0000)]
[BlackBerry] Upstream the BlackBerry change to platform/graphics/FloatPoint.h
https://bugs.webkit.org/show_bug.cgi?id=79887

Reviewed by Antonio Gomes.

Add conversion convenience between WebCore::FloatPoint and BlackBerry::Platform::FloatPoint.

The porting can't be built yet, no new tests.

* platform/graphics/FloatPoint.h:
(Platform):
(FloatPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoShadowRoot need innerHTML
commit-queue@webkit.org [Wed, 29 Feb 2012 21:17:28 +0000 (21:17 +0000)]
ShadowRoot need innerHTML
https://bugs.webkit.org/show_bug.cgi?id=78473

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2012-02-29
Reviewed by Hajime Morita.

Source/WebCore:

Refactor code for sharing common code between HTMLElement & ShadowRoot.
Implement innerHTML attribute for ShadowRoot.

Test: fast/dom/shadow/shadow-root-innerHTML.html

* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::cloneNode):
(WebCore):
(WebCore::ShadowRoot::innerHTML):
(WebCore::ShadowRoot::setInnerHTML):
* dom/ShadowRoot.h:
(ShadowRoot):
* dom/ShadowRoot.idl:
* editing/markup.cpp:
(WebCore::urlToMarkup):
(WebCore):
(WebCore::createFragmentFromSource):
(WebCore::hasOneChild):
(WebCore::hasOneTextChild):
(WebCore::replaceChildrenWithFragment):
(WebCore::replaceChildrenWithText):
* editing/markup.h:
* html/HTMLElement.cpp:
(WebCore):

LayoutTests:

Implement innerHTML attribute for ShadowRoot.

* fast/dom/shadow/shadow-root-innerHTML-expected.txt: Added.
* fast/dom/shadow/shadow-root-innerHTML.html: Added.
* platform/qt/Skipped: Added test case in Skipped as ShadowRoot is supported by Chromium only.
* platform/mac/Skipped: ditto.
* platform/win/Skipped: ditto.
* platform/wincairo/Skipped: ditto.
* platform/wk2/Skipped: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening, mark a test as waiting for rebaselining after a skia update.
adamk@chromium.org [Wed, 29 Feb 2012 21:15:27 +0000 (21:15 +0000)]
Unreviewed gardening, mark a test as waiting for rebaselining after a skia update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCFURLDownloadScheduleWithCurrentMessageQueue only exists on Windows
aestes@apple.com [Wed, 29 Feb 2012 21:13:16 +0000 (21:13 +0000)]
CFURLDownloadScheduleWithCurrentMessageQueue only exists on Windows
https://bugs.webkit.org/show_bug.cgi?id=79936

Reviewed by Brady Eidson.

CFURLDownloadScheduleWithCurrentMessageQueue only exists on Windows
platforms. Non-Windows platforms that use CFNetwork-based downloads
should omit this call.

* WebProcess/Downloads/cfnet/DownloadCFNet.cpp:
(WebKit::Download::start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening, remove incorrect platform-specific expectation.
adamk@chromium.org [Wed, 29 Feb 2012 21:10:11 +0000 (21:10 +0000)]
Unreviewed gardening, remove incorrect platform-specific expectation.

* platform/chromium-win/fast/events/message-port-multi-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStop doubling maximalOutlineSize during painting
jchaffraix@webkit.org [Wed, 29 Feb 2012 20:49:49 +0000 (20:49 +0000)]
Stop doubling maximalOutlineSize during painting
https://bugs.webkit.org/show_bug.cgi?id=79724

Reviewed by Tony Chang.

Refactoring only, covered by existing tests (mostly repaint ones).

* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::shouldPaint):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintCollapsedBorders):
Introduce a local repaint rectangle that we inflate by the maximalOutlineSize
to simplify the comparison logic. Also tried to make it clearer what's going on
by tweaking the existing code.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintObject):
Remove the doubling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash when changing list marker locations
commit-queue@webkit.org [Wed, 29 Feb 2012 20:40:10 +0000 (20:40 +0000)]
Crash when changing list marker locations
https://bugs.webkit.org/show_bug.cgi?id=79681

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-02-29
Reviewed by David Hyatt.

Source/WebCore:

This fixes a regression crash from r108548.

There are some conditions where removing the anonymous block
parent at that point can cause problems. One is when there is
a continuation from it, and another when it is a sibling of
lineBoxParent and it causes lineBoxParent to be deleted
incidentally. This patch delays the destruction until after
lineBoxParent has been used and makes an exception for
continuations.

* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::updateMarkerLocation)

LayoutTests:

This test exercises the crashing condition for bug 79681 where an
anonymous block was being removed from the render tree inappropriately.

* fast/lists/remove-listmarker-from-anonblock-with-continuation-crash-expected.txt: Added
* fast/lists/remove-listmarker-from-anonblock-with-continuation-crash.html: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening, further mark stop-animation-on-suspend.html as crashy on Windows.
adamk@chromium.org [Wed, 29 Feb 2012 20:33:32 +0000 (20:33 +0000)]
Unreviewed gardening, further mark stop-animation-on-suspend.html as crashy on Windows.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd more tests for web intents
dpranke@chromium.org [Wed, 29 Feb 2012 20:04:07 +0000 (20:04 +0000)]
Add more tests for web intents
https://bugs.webkit.org/show_bug.cgi?id=79527

Patch by Greg Billock <gbillock@google.com> on 2012-02-29
Reviewed by Adam Barth.

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::sendWebIntentResponse):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
(WebViewHost::currentIntentRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] We should not add NetscapeBrowserFuncs.cpp as header
commit-queue@webkit.org [Wed, 29 Feb 2012 20:02:13 +0000 (20:02 +0000)]
[Qt][WK2] We should not add NetscapeBrowserFuncs.cpp as header
https://bugs.webkit.org/show_bug.cgi?id=79847

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-02-29
Reviewed by Alexey Proskuryakov.

* Target.pri: Fix typo, so we can add ".h" file instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWritable attribute not set correctly when redefining an accessor to a data descriptor
barraclough@apple.com [Wed, 29 Feb 2012 19:59:43 +0000 (19:59 +0000)]
Writable attribute not set correctly when redefining an accessor to a data descriptor
https://bugs.webkit.org/show_bug.cgi?id=79931

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

* runtime/JSObject.cpp:
(JSC::JSObject::defineOwnProperty):
    - use attributesOverridingCurrent instead of attributesWithOverride.
* runtime/PropertyDescriptor.cpp:
* runtime/PropertyDescriptor.h:
    - remove attributesWithOverride - attributesOverridingCurrent does the same thing.

LayoutTests:

* fast/js/Object-defineProperty-expected.txt:
* fast/js/script-tests/Object-defineProperty.js:
    - Added tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Add support for FLAC audio and OGG/Vorbis audio
commit-queue@webkit.org [Wed, 29 Feb 2012 19:53:49 +0000 (19:53 +0000)]
[BlackBerry] Add support for FLAC audio and OGG/Vorbis audio
https://bugs.webkit.org/show_bug.cgi?id=79519

Patch by Max Feil <mfeil@rim.com> on 2012-02-29
Reviewed by Antonio Gomes.

Source/WebCore:

A layout test already exists for OGG. We do not support OGG
video at this time, only audio.

Test: media/media-can-play-flac-audio.html

* platform/blackberry/MIMETypeRegistryBlackBerry.cpp:
(WebCore):

Source/WebKit/blackberry:

* Api/WebSettings.cpp:
(BlackBerry::WebKit::mimeTypeAssociationMap):

LayoutTests:

A layout test already exists for OGG. We do not support OGG
video at this time, only audio.

* media/media-can-play-flac-audio-expected.txt: Added.
* media/media-can-play-flac-audio.html: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=79868
bdakin@apple.com [Wed, 29 Feb 2012 19:51:54 +0000 (19:51 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=79868
Overlay scrollbars should respond to AppKit's NSEventPhaseMayBegin
-and corresponding-
<rdar://problem/10688637>

Reviewed by Anders Carlsson.

Scrollbars are currently drawn on the main thread even when scrolling happens
on the scrolling thread, so we have to call back to the main thread for the
time being to make the right drawing calls for NSEventPhaseMayBegin.
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::handleWheelEventPhase):
(WebCore):
* page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::handleWheelEventPhase):
(WebCore):
* page/scrolling/ScrollingTree.h:
* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::handleWheelEvent):
* platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::handleWheelEventPhase):
(ScrollAnimator):

Call into AppKit on NSEventPhaseMayBegin.
* platform/mac/ScrollAnimatorMac.h:
(ScrollAnimatorMac):
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::mayBeginScrollGesture):
(WebCore):
(WebCore::ScrollAnimatorMac::handleWheelEventPhase):
(WebCore::ScrollAnimatorMac::handleWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd more tests for web intents
commit-queue@webkit.org [Wed, 29 Feb 2012 19:51:11 +0000 (19:51 +0000)]
Add more tests for web intents
https://bugs.webkit.org/show_bug.cgi?id=79527

Patch by Greg Billock <gbillock@google.com> on 2012-02-29
Reviewed by Adam Barth.

Tools:

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::sendWebIntentResponse):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
(WebViewHost::currentIntentRequest):

LayoutTests:

* webintents/resources/web-intents-testing.js: Added.
(onSuccess):
(onFailure):
(startIntentWithCallbacks):
(simulateButtonPress):
* webintents/web-intents-failure-expected.txt: Added.
* webintents/web-intents-failure.html: Added.
* webintents/web-intents-invoke-expected.txt: Added.
* webintents/web-intents-invoke.html: Added.
* webintents/web-intents-reload.html:
* webintents/web-intents-reply-expected.txt: Added.
* webintents/web-intents-reply.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoperftestsrunner can call printer.write() after printer.cleanup()
dpranke@chromium.org [Wed, 29 Feb 2012 19:48:43 +0000 (19:48 +0000)]
perftestsrunner can call printer.write() after printer.cleanup()
https://bugs.webkit.org/show_bug.cgi?id=79872

Reviewed by Ryosuke Niwa.

This patch fixes a unittest that was incorrectly calling
PerfTestsRunner.run() twice (which led to a weird state in the
printer object).

* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.test_run_with_upload_json):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWhen invoking Lookup while zoomed in, the highlighted word renders out of line
weinig@apple.com [Wed, 29 Feb 2012 19:40:24 +0000 (19:40 +0000)]
When invoking Lookup while zoomed in, the highlighted word renders out of line
<rdar://problem/10812527>

Reviewed by Simon Fraser.

* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupForRange):
Make sure to scale the ascent when determining the origin for the overlay.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed: updating expectations for chromium (error messages)
dslomov@google.com [Wed, 29 Feb 2012 19:08:24 +0000 (19:08 +0000)]
Unreviewed: updating expectations for chromium (error messages)

* platform/chromium/fast/events/message-port-multi-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
kbalazs@webkit.org [Wed, 29 Feb 2012 18:56:11 +0000 (18:56 +0000)]
[Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
https://bugs.webkit.org/show_bug.cgi?id=76546

Reviewed by Simon Hausmann.

Revert the workaround introduced in r107868 and reintroduce
the qml binding so we can test the code path that we are more
interested in. The reason that it did not work before is that
we don't have an active platform window which we now workaround
by propagating the resize through QWindowSystemInterface.

* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::handleStatusChanged):
(WTR::PlatformWebView::resizeTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFull screen video volume slider has "progress bar"
jer.noble@apple.com [Wed, 29 Feb 2012 18:55:12 +0000 (18:55 +0000)]
Full screen video volume slider has "progress bar"
https://bugs.webkit.org/show_bug.cgi?id=79812

Reviewed by Eric Carlson.

Source/WebCore:

No new tests; strictly a platform-specific look-and-feel change.

The full-screen volume slider has a "media-slider"" appearance, which is rendering as if
the volume slider has a "progress".  Make a concrete "media-fullscreen-volume-slider" appearance
which has the correct look-and-feel.

Add two new appearance keywords, media-fullscreen-volume-slider and thumb, and their associated
types and CSS keywords:
* css/CSSValueKeywords.in:
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* html/shadow/MediaControlElements.h:
* platform/ThemeTypes.h:

Handle the new slider and thumb types when rendering:
* rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::adjustMediaSliderThumbSize):
(WebCore::RenderMediaControls::paintMediaControlsPart):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
* rendering/RenderTheme.h:
(WebCore::RenderTheme::paintMediaFullScreenVolumeSliderTrack):
(WebCore::RenderTheme::paintMediaFullScreenVolumeSliderThumb):
* rendering/RenderThemeMac.h:
(RenderThemeMac):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustMediaSliderThumbSize):
(WebCore::RenderThemeMac::paintMediaFullScreenVolumeSliderTrack):
(WebCore::RenderThemeMac::paintMediaFullScreenVolumeSliderThumb):
* rendering/RenderMediaControlsChromium.cpp:
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):

* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::orientation): Mark the fullscreen volume slider as horizontal.
* html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderThumb::updateAppearance): Give MediaFullScreenVolumeSliderParts
    MediaFullScreenVolumeSliderThumbParts.
* css/fullscreenQuickTime.css: Change the styles for the fullscreen slider, min, and max buttons.
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-volume-min-button):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-volume-slider):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-volume-max-button):
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::reset): Set the value of the fullscreen volume slider
    when resetting.

WebKitLibraries:

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceLion.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Use text or page zoom factor in WebKitWebView depending on zoom-text-only
carlosgc@webkit.org [Wed, 29 Feb 2012 18:51:15 +0000 (18:51 +0000)]
[GTK] Use text or page zoom factor in WebKitWebView depending on zoom-text-only
https://bugs.webkit.org/show_bug.cgi?id=75252

Reviewed by Gustavo Noronha Silva.

* UIProcess/API/gtk/WebKitWebView.cpp:
(zoomTextOnlyChanged): Update text/page zoom factor when
zoom-text-only setting changes.
(webkitWebViewSetSettings): Helper function to set the settings
object for the web view, initializing the settings for the page
and connecting to notify::zoom-text-only signal.
(webkitWebViewConstructed): Use webkitWebViewSetSettings().
(webkit_web_view_set_settings): Use webkitWebViewSetSettings() and
disconnect from the notify::zoom-text-only signal of the previous
settings object.
(webkit_web_view_set_zoom_level): Set text/page zoom factor
depending on WebKitSettings:zoom-text-only property.
(webkit_web_view_get_zoom_level): Get text/page zoom factor
depending on WebKitSettings:zoom-text-only property.
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewZoomLevel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Add zoom-text-only setting to WebKit2 GTK+ API
carlosgc@webkit.org [Wed, 29 Feb 2012 18:45:14 +0000 (18:45 +0000)]
[GTK] Add zoom-text-only setting to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=75249

Reviewed by Gustavo Noronha Silva.

To set whether zoom level of web view should affect only the text
or all page contents. It's disabled by default.

* UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init): Add WebKitSettings:zoom-text-only
property.
(webkit_settings_set_zoom_text_only): Set
WebKitSettings:zoom-text-only.
(webkit_settings_get_zoom_text_only): Get
WebKitSettings:zoom-text-only.
* UIProcess/API/gtk/WebKitSettings.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new
symbols.
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDidFindString should be emitted even if FindOptionsShowOverlay is not enabled
sergio@webkit.org [Wed, 29 Feb 2012 18:15:32 +0000 (18:15 +0000)]
DidFindString should be emitted even if FindOptionsShowOverlay is not enabled
https://bugs.webkit.org/show_bug.cgi?id=76522

Reviewed by Darin Adler.

DidFindString message should be issued always even if neither
FindOptionsShowOverlay or FindOptionsShowHighlight are
provided. The difference is that if any of those flags are present
the find operation will look for all the appearances of the text
in the web view, otherwise it will just look and report the next
occurrence.

This patch removes the temporary workaround added in r109222 to
the WebKitFindController unit tests.

* UIProcess/API/gtk/tests/TestWebKitFindController.cpp:
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoApplying region style should not need to access parent rules
antti@apple.com [Wed, 29 Feb 2012 18:08:27 +0000 (18:08 +0000)]
Applying region style should not need to access parent rules
https://bugs.webkit.org/show_bug.cgi?id=79910

Reviewed by Andreas Kling.

Currently CSSStyleSelector::applyProperties looks into parent rules to see if a rule is
part of region style. The plan is to eliminate the rule parent pointer so this needs to be refactored.

Add a bit to RuleData to indicate if the StyleRule is part of a region style.

* css/CSSStyleSelector.cpp:
(RuleData):
(WebCore::RuleData::isInRegionRule):
(RuleSet):
(WebCore::CSSStyleSelector::addMatchedProperties):
(WebCore::CSSStyleSelector::sortAndTransferMatchedRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSStyleSelector.h:
(CSSStyleSelector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Bump WebKitGTK+ version number.
carlosgc@webkit.org [Wed, 29 Feb 2012 17:55:03 +0000 (17:55 +0000)]
Unreviewed. Bump WebKitGTK+ version number.

* configure.ac: Bump version number to 1.9.0 now that we branched
for 1.8.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fix GTK+ build.
carlosgc@webkit.org [Wed, 29 Feb 2012 17:51:29 +0000 (17:51 +0000)]
Unreviewed. Fix GTK+ build.

* Source/autotools/symbols.filter: Add symbol.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd JSCore symbol exports needed by wx port
kevino@webkit.org [Wed, 29 Feb 2012 17:44:34 +0000 (17:44 +0000)]
Add JSCore symbol exports needed by wx port
https://bugs.webkit.org/show_bug.cgi?id=77280

Reviewed by Hajime Morita.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [InspectorIndexedDB] Add refresh to IndexedDB support.
vsevik@chromium.org [Wed, 29 Feb 2012 17:40:55 +0000 (17:40 +0000)]
Web Inspector: [InspectorIndexedDB] Add refresh to IndexedDB support.
https://bugs.webkit.org/show_bug.cgi?id=79695

Reviewed by Pavel Feldman.

* inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView):
(WebInspector.IDBDataView.prototype._refreshButtonClicked):
(WebInspector.IDBDataView.prototype.get statusBarItems):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.IndexedDBTreeElement):
(WebInspector.IndexedDBTreeElement.prototype.onattach):
(WebInspector.IndexedDBTreeElement.prototype._handleContextMenuEvent):
(WebInspector.IDBDatabaseTreeElement.prototype.onattach):
(WebInspector.IDBDatabaseTreeElement.prototype._handleContextMenuEvent):
(WebInspector.IDBDatabaseTreeElement.prototype._refreshIndexedDB):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] [WK2] Add Find API
sergio@webkit.org [Wed, 29 Feb 2012 17:37:04 +0000 (17:37 +0000)]
[GTK] [WK2] Add Find API
https://bugs.webkit.org/show_bug.cgi?id=76070

Reviewed by Martin Robinson.

This patch adds a new public find API for the Gtk+ WK2 port. It
defines a new object called WebKitFindController owned by each
WebKitWebView. Clients will use this new object to search strings
in the WebKitWebView.

Changes include also documentation and unit tests for the new
public API.

* GNUmakefile.am:
* UIProcess/API/gtk/WebKitDefines.h:
* UIProcess/API/gtk/WebKitFindController.cpp: Added.
(didFindString): implementation of the WKPage Find interface.
(didFailToFindString): Ditto.
(didCountStringMatches): Ditto.
(webkit_find_controller_init):
(getWKPageFromWebKitWebView):
(webkitFindControllerConstructed):
(webkitFindControllerGetProperty):
(webkitFindControllerSetProperty):
(webkitFindControllerFinalize):
(webkit_find_controller_class_init):
(webkit_find_controller_get_search_text):
(webkit_find_controller_get_options):
(webkit_find_controller_get_max_match_count):
(webkit_find_controller_get_web_view):
(webKitFindControllerPerform):
(webKitFindControllerSetSearchData):
(webkit_find_controller_search): asynchronously looks for the
search string in the WebKitWebView.
(webkit_find_controller_search_finish): unhighlights text matches.
(webkit_find_controller_search_next):
(webkit_find_controller_search_previous):
(webkit_find_controller_count_matches): asynchronously counts the
number of matches of the search string in the WebKitWebView.
* UIProcess/API/gtk/WebKitFindController.h: Added.
* UIProcess/API/gtk/WebKitPrivate.h:
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_get_find_controller): returns the
WebKitFindController instance owned by the WebKitWebView.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
* UIProcess/API/gtk/docs/webkit2gtk.types:
* UIProcess/API/gtk/tests/GNUmakefile.am:
* UIProcess/API/gtk/tests/TestWebKitFindController.cpp: Added.
(testFindControllerTextFound):
(testFindControllerTextNotFound):
(testFindControllerMatchCount):
(testFindControllerMaxMatchCount):
(testFindControllerNext):
(testFindControllerPrevious):
(testFindControllerCountedMatches):
(testFindControllerOptions):
(testFindControllerInstance):
(testFindControllerGetters):
(testFindControllerHide):
(beforeAll):
(afterAll):
* UIProcess/API/gtk/webkit2.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: timeline markers are not shown on the timeline panel
caseq@chromium.org [Wed, 29 Feb 2012 17:35:22 +0000 (17:35 +0000)]
Web Inspector: timeline markers are not shown on the timeline panel
https://bugs.webkit.org/show_bug.cgi?id=79921

Reviewed by Pavel Feldman.

* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline.addTimestampRecords):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAlign InlineBox::m_expansion to a byte boundary
bashi@chromium.org [Wed, 29 Feb 2012 17:07:00 +0000 (17:07 +0000)]
Align InlineBox::m_expansion to a byte boundary
https://bugs.webkit.org/show_bug.cgi?id=79761

Add a bit to m_expansion to align a byte boundary.
This will make valgrind memcheck happy.
I confirmed sizeof(InlineBox) is unchanged.

Reviewed by Hajime Morita.

No new tests. No behavior changes.

* rendering/InlineBox.h:
(InlineBox): Aligned m_expansion to a byte boundary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDo not iterate all tiles for resizing when the content didn't change
kenneth@webkit.org [Wed, 29 Feb 2012 16:51:41 +0000 (16:51 +0000)]
Do not iterate all tiles for resizing when the content didn't change
https://bugs.webkit.org/show_bug.cgi?id=79787

Reviewed by Simon Hausmann.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::createTiles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in WebCore::CompositeEditCommand::insertNodeAt
commit-queue@webkit.org [Wed, 29 Feb 2012 16:43:31 +0000 (16:43 +0000)]
Crash in WebCore::CompositeEditCommand::insertNodeAt
https://bugs.webkit.org/show_bug.cgi?id=67764

Patch by Parag Radke <parag@motorola.com> on 2012-02-29
Reviewed by Ryosuke Niwa.

Source/WebCore:

If caret position after deletion and destination position coincides then
removing the node will result in removing the destination node also. Hence crash.

Test: editing/deleting/delete-block-merge-contents-025.html

* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::cleanupAfterDeletion):
If the caret position after delete and the destination position
renderes at the same place, pruning the node and making an early exit.

LayoutTests:

Added a test case to test deletion when caret position after deletion and
destination postion renders at the same place.

* editing/deleting/delete-block-merge-contents-025-expected.txt: Added.
* editing/deleting/delete-block-merge-contents-025.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-29 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 29 Feb 2012 16:08:57 +0000 (16:08 +0000)]
2012-02-29  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Final set of pixel tests for Snow Leopard, svg/ passes with tolerance 0 again,
        despite one known flaky test and 2 known failures that affect Lion as well.

        * platform/mac-snowleopard/svg/W3C-SVG-1.1/linking-a-05-t-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: Added.
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png: Added.
        * platform/mac-snowleopard/svg/css/group-with-shadow-expected.png:
        * platform/mac-snowleopard/svg/custom/gradient-rotated-bbox-expected.png: Added.
        * platform/mac-snowleopard/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png: Added.
        * platform/mac-snowleopard/svg/custom/marker-opacity-expected.png: Added.
        * platform/mac-snowleopard/svg/custom/shapes-supporting-markers-expected.png:
        * platform/mac-snowleopard/svg/custom/zero-path-square-cap-rendering2-expected.png: Added.
        * platform/mac-snowleopard/svg/filters/filter-placement-issue-expected.png: Added.
        * platform/mac-snowleopard/svg/filters/filter-refresh-expected.png: Added.
        * platform/mac-snowleopard/svg/filters/filter-rounding-issues-expected.png: Added.
        * platform/mac-snowleopard/svg/filters/filter-source-position-expected.png: Added.
        * platform/mac-snowleopard/svg/filters/filter-width-update-expected.png:
        * platform/mac-snowleopard/svg/filters/filterRes-expected.png: Added.
        * platform/mac-snowleopard/svg/filters/filterRes1-expected.png: Added.
        * platform/mac-snowleopard/svg/filters/filterRes2-expected.png: Added.
        * platform/mac-snowleopard/svg/filters/filterRes3-expected.png: Added.
        * platform/mac-snowleopard/svg/filters/filteredImage-expected.png: Added.
        * platform/mac-snowleopard/svg/filters/parent-children-with-same-filter-expected.png: Added.
        * platform/mac-snowleopard/svg/filters/shadow-on-filter-expected.png: Added.
        * platform/mac-snowleopard/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
        * platform/mac-snowleopard/svg/filters/subRegion-in-userSpace-expected.png: Added.
        * platform/mac-snowleopard/svg/filters/subRegion-one-effect-expected.png:
        * platform/mac-snowleopard/svg/filters/subRegion-two-effects-expected.png:
        * platform/mac-snowleopard/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
        * platform/mac-snowleopard/svg/foreignObject/filter-expected.png: Added.
        * platform/mac-snowleopard/svg/foreignObject/text-tref-02-b-expected.png:
        * platform/mac-snowleopard/svg/hixie/perf/001-expected.png:
        * platform/mac-snowleopard/svg/hixie/perf/002-expected.png:
        * platform/mac-snowleopard/svg/hixie/perf/005-expected.png: Added.
        * platform/mac-snowleopard/svg/hixie/perf/006-expected.png: Added.
        * platform/mac-snowleopard/svg/hixie/perf/007-expected.png:
        * platform/mac-snowleopard/svg/repaint/filter-child-repaint-expected.png: Added.
        * platform/mac-snowleopard/svg/repaint/filter-repaint-expected.png:
        * platform/mac-snowleopard/svg/repaint/image-href-change-expected.png: Added.
        * platform/mac-snowleopard/svg/repaint/image-with-clip-path-expected.png: Added.
        * platform/mac-snowleopard/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
        * platform/mac-snowleopard/svg/text/select-textLength-spacing-squeeze-2-expected.png:
        * platform/mac-snowleopard/svg/text/select-textLength-spacing-stretch-4-expected.png:
        * platform/mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png:
        * platform/mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png:
        * platform/mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png:
        * platform/mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png:
        * platform/mac-snowleopard/svg/text/selection-background-color-expected.png: Added.
        * platform/mac-snowleopard/svg/text/text-align-01-b-expected.png:
        * platform/mac-snowleopard/svg/text/text-align-05-b-expected.png:
        * platform/mac-snowleopard/svg/text/text-align-06-b-expected.png:
        * platform/mac-snowleopard/svg/text/text-fill-opacity-expected.png: Added.
        * platform/mac-snowleopard/svg/text/text-path-01-b-expected.png:
        * platform/mac-snowleopard/svg/text/text-spacing-01-b-expected.png:
        * platform/mac-snowleopard/svg/text/text-text-01-b-expected.png:
        * platform/mac-snowleopard/svg/text/text-text-04-t-expected.png:
        * platform/mac-snowleopard/svg/text/text-text-05-t-expected.png:
        * platform/mac-snowleopard/svg/text/text-text-07-t-expected.png:
        * platform/mac-snowleopard/svg/text/text-tselect-02-f-expected.png: Added.
        * platform/mac-snowleopard/svg/text/tspan-dynamic-positioning-expected.png: Added.
        * platform/mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
        * platform/mac-snowleopard/svg/transforms/text-with-mask-with-svg-transform-expected.png:
        * platform/mac-snowleopard/svg/webarchive/svg-feimage-subresources-expected.png: Added.
        * platform/mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png:
        * platform/mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png: Added.
        * platform/mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
        * platform/mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
        * platform/mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
        * platform/mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109217 268f45cc-cd09-0410-ab3c-d52691b4dbfc