WebKit-https.git
9 years agoWeb Inspector: Redesign summary view / retaining tree contents
loislo@chromium.org [Mon, 6 Feb 2012 16:20:23 +0000 (16:20 +0000)]
Web Inspector: Redesign summary view / retaining tree contents
https://bugs.webkit.org/show_bug.cgi?id=77870

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-06
Reviewed by Pavel Feldman.

1. Make object IDs less contrast.
2. Put array indices in [].
3. Do not write type if it's just "Object".

Source/WebCore:

* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotObjectNode.prototype._emptyData):
(WebInspector.HeapSnapshotObjectNode.prototype._enhanceData):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
(WebInspector.HeapSnapshotConstructorNode.prototype.get data):
* inspector/front-end/heapProfiler.css:
(.detailed-heapshot-view .console-formatted-id):
(.detailed-heapshot-view td.object-column span.grayed):

LayoutTests:

* inspector/profiler/detailed-heapshots-test.js:
(initialize_DetailedHeapshotTest.):
(initialize_DetailedHeapshotTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Texmap][Qt] Avoid an image copy when uploading textures in WebKit1
noam.rosenthal@nokia.com [Mon, 6 Feb 2012 16:10:13 +0000 (16:10 +0000)]
[Texmap][Qt] Avoid an image copy when uploading textures in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=77748

Reviewed by Kenneth Rohde Christiansen.

Use QPixmap::buffer() API to get access to the QPixmap's pixels without implicit copies.

Instrumentation shows that the deep image copies created from TextureMapperGL are
eliminated.

* platform/graphics/opengl/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLayoutTest failures on r106797
tonyg@chromium.org [Mon, 6 Feb 2012 16:05:53 +0000 (16:05 +0000)]
LayoutTest failures on r106797
https://bugs.webkit.org/show_bug.cgi?id=77868

Call suspendIfNeeded from subclass of IDBRequest, IDBVersionChangeRequest.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Simon Hausmann.

* storage/IDBVersionChangeRequest.cpp:
(WebCore::IDBVersionChangeRequest::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Make sure html_dir exists before calling gtkdoc-rebase
carlosgc@webkit.org [Mon, 6 Feb 2012 14:54:38 +0000 (14:54 +0000)]
[GTK] Make sure html_dir exists before calling gtkdoc-rebase
https://bugs.webkit.org/show_bug.cgi?id=77869

Reviewed by Philippe Normand.

* gtk/gtkdoc.py:
(GTKDoc.rebase_installed_docs): Check html_dir exists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Implement ImageBuffer::copyImage(ImageBuffer::DontCopyBackingStore)
noam.rosenthal@nokia.com [Mon, 6 Feb 2012 14:18:14 +0000 (14:18 +0000)]
[Qt] Implement ImageBuffer::copyImage(ImageBuffer::DontCopyBackingStore)
https://bugs.webkit.org/show_bug.cgi?id=77689

Reviewed by Kenneth Rohde Christiansen.

Use StillImageQt::createForRendering when using DontCopyBackingStore.
Enable DontCopyBackingStore in TextureMapperNode.
This removes deep copies resulting from the use of ImageBuffer.

Instrumentation shows that deep image copies resulted from ImageBuffer are eliminated.

* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::copyImage):
* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::renderContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebGestureEvent can not encode delta and area.
commit-queue@webkit.org [Mon, 6 Feb 2012 14:07:27 +0000 (14:07 +0000)]
WebGestureEvent can not encode delta and area.
https://bugs.webkit.org/show_bug.cgi?id=77728

Source/WebCore:

Add area field to PlatformGestureEvent.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Kenneth Rohde Christiansen.

* platform/PlatformGestureEvent.h:
(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(WebCore::PlatformGestureEvent::area):

Source/WebKit2:

Support delta and area fields in WebGestureEvent, and send area with Qt tap gesture.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Kenneth Rohde Christiansen.

* Shared/WebEvent.h:
(WebKit::WebGestureEvent::area):
(WebKit::WebGestureEvent::delta):
* Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent):
* Shared/WebGestureEvent.cpp:
(WebKit::WebGestureEvent::WebGestureEvent):
(WebKit::WebGestureEvent::encode):
(WebKit::WebGestureEvent::decode):
* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::handleSingleTapEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry]Use extension for a mimetype as the suggested extension
commit-queue@webkit.org [Mon, 6 Feb 2012 13:55:14 +0000 (13:55 +0000)]
[BlackBerry]Use extension for a mimetype as the suggested extension
if the url file doesn't have an extension.
https://bugs.webkit.org/show_bug.cgi?id=76779

Patch by Charles Wei <charles.wei@torchmobile.com.cn> on 2012-02-06
Reviewed by Antonio Gomes.

No new tests.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendResponseIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSpeech input: fix fast/speech/bubble-position.html
hans@chromium.org [Mon, 6 Feb 2012 13:24:20 +0000 (13:24 +0000)]
Speech input: fix fast/speech/bubble-position.html
https://bugs.webkit.org/show_bug.cgi?id=77732

Reviewed by Tony Gentilcore.

There is no need for the test to check the pixel-exact position of the
rect, since that seems to vary a little between platforms.
The point of the test is to check that the rect is within the iframe,
so let's do that.

* fast/speech/bubble-position-expected.txt:
* fast/speech/bubble-position.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Remove TiledDrawingArea and dependencies.
jocelyn.turcotte@nokia.com [Mon, 6 Feb 2012 13:11:50 +0000 (13:11 +0000)]
[Qt][WK2] Remove TiledDrawingArea and dependencies.
https://bugs.webkit.org/show_bug.cgi?id=71681

Reviewed by Kenneth Rohde Christiansen.

Tiled drawing surface functionality got converted to LayerTree.
TiledDrawingArea and its dependencies are not used by any port anymore.

* CMakeLists.txt:
* GNUmakefile.am:
* Shared/DrawingAreaInfo.h:
* Target.pri:
* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::QQuickWebPagePrivate):
* UIProcess/API/qt/qquickwebpage_p.h:
* UIProcess/API/qt/qquickwebpage_p_p.h:
(QQuickWebPagePrivate):
* UIProcess/DrawingAreaProxy.h:
* UIProcess/DrawingAreaProxy.messages.in:
* UIProcess/TiledDrawingAreaProxy.cpp: Removed.
* UIProcess/TiledDrawingAreaProxy.h: Removed.
* UIProcess/qt/QtSGTileNode.cpp: Removed.
* UIProcess/qt/QtSGTileNode.h: Removed.
* UIProcess/qt/QtSGUpdateQueue.cpp: Removed.
* UIProcess/qt/QtSGUpdateQueue.h: Removed.
* UIProcess/qt/TiledDrawingAreaProxyQt.cpp: Removed.
* WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/DrawingArea.messages.in:
* WebProcess/WebPage/TiledDrawingArea.cpp: Removed.
* WebProcess/WebPage/TiledDrawingArea.h: Removed.
* WebProcess/WebPage/WebPage.h:
(WebPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Don't version QtWebKit.experimental.
jocelyn.turcotte@nokia.com [Mon, 6 Feb 2012 13:09:27 +0000 (13:09 +0000)]
[Qt] Don't version QtWebKit.experimental.
https://bugs.webkit.org/show_bug.cgi?id=77739

Reviewed by Tor Arne Vestbø.

Source/WebKit/qt:

We won't support previous versions of the experimental API.

* declarative/experimental/plugin.cpp:

Source/WebKit2:

* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_itemSelector.qml:
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml:
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_navigationHistory.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:

Tools:

* MiniBrowser/qt/qml/BrowserWindow.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename [HasIndexGetter], [HasNameGetter] and [HasCustomIndexSetter] IDLs
haraken@chromium.org [Mon, 6 Feb 2012 12:56:07 +0000 (12:56 +0000)]
Rename [HasIndexGetter], [HasNameGetter] and [HasCustomIndexSetter] IDLs
https://bugs.webkit.org/show_bug.cgi?id=77848

Reviewed by Adam Barth.

For naming consistency with [CustomGetter] and [CustomSetter],
this patch renames the following IDLs:

[HasIndexGetter] => [IndexedGetter]  (Remove "Has". This IDL is for "indexed" properties
in the Web IDL: http://dev.w3.org/2006/webapi/WebIDL/#idl-indexed-properties)
[HasCustomIndexSetter] => [CustomIndexedSetter]  (Ditto.)
[HasNameGetter] => [NamedGetter] (Remove "Has". This IDL is for "named" properties
in the Web IDL: http://dev.w3.org/2006/webapi/WebIDL/#idl-named-properties)

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationIndexer):
(GenerateImplementationNamedPropertyGetter):

* bindings/scripts/test/TestEventTarget.idl: No change in run-bindings-tests results.
* bindings/scripts/test/TestTypedArray.idl: Ditto.

* Modules/gamepad/GamepadList.idl:
* css/CSSRuleList.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSValueList.idl:
* css/MediaList.idl:
* css/StyleSheetList.idl:
* css/WebKitCSSFilterValue.idl:
* css/WebKitCSSKeyframesRule.idl:
* css/WebKitCSSTransformValue.idl:
* dom/ClientRectList.idl:
* dom/DOMStringList.idl:
* dom/DOMStringMap.idl:
* dom/DataTransferItemList.idl:
* dom/NamedNodeMap.idl:
* dom/NodeList.idl:
* dom/TouchList.idl:
* fileapi/EntryArray.idl:
* fileapi/EntryArraySync.idl:
* fileapi/FileList.idl:
* html/DOMSettableTokenList.idl:
* html/DOMTokenList.idl:
* html/HTMLAllCollection.idl:
* html/HTMLCollection.idl:
* html/HTMLFormElement.idl:
* html/HTMLOptionsCollection.idl:
* html/HTMLPropertiesCollection.idl:
* html/HTMLSelectElement.idl:
* html/TextTrackCueList.idl:
* html/canvas/CanvasPixelArray.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:
* html/track/TextTrackList.idl:
* mediastream/MediaStreamList.idl:
* mediastream/MediaStreamTrackList.idl:
* page/SpeechInputResultList.idl:
* page/WebKitAnimationList.idl:
* plugins/DOMMimeTypeArray.idl:
* plugins/DOMPlugin.idl:
* plugins/DOMPluginArray.idl:
* storage/Storage.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Ensure timers and other active DOM objects do not fire in suspended...
commit-queue@webkit.org [Mon, 6 Feb 2012 12:36:41 +0000 (12:36 +0000)]
Source/WebCore: Ensure timers and other active DOM objects do not fire in suspended documents.
https://bugs.webkit.org/show_bug.cgi?id=53733

ScriptExecutionContext now remembers it has suspended active DOM objects
and suspends all newly installed active DOM objects as well.

All create-calls active DOM objects now calls the post constructor method
suspendIfNeeded that updates the suspend state. It is post constructor
because the suspend/resume functions are virtual and thus can not be called
from constructors.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Mihai Parparita.

Test: fast/events/suspend-timers.html

* Modules/intents/IntentRequest.cpp:
(WebCore::IntentRequest::create):
* bindings/generic/ActiveDOMCallback.cpp:
(WebCore::ActiveDOMCallback::ActiveDOMCallback):
* dom/ActiveDOMObject.cpp:
(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
(WebCore::ActiveDOMObject::suspendIfNeeded):
* dom/ActiveDOMObject.h:
(WebCore::ActiveDOMObject::suspendIfNeededCalled):
* dom/DocumentEventQueue.cpp:
(WebCore::DocumentEventQueue::DocumentEventQueue):
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjectIfNeeded):
* dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::activeDOMObjectsAreSuspended):
* fileapi/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::create):
* fileapi/FileReader.cpp:
(WebCore::FileReader::create):
* fileapi/FileReader.h:
* fileapi/FileWriter.cpp:
(WebCore::FileWriter::create):
* fileapi/FileWriter.h:
* history/CachedFrame.cpp:
(WebCore::CachedFrame::CachedFrame):
* html/HTMLAudioElement.cpp:
(WebCore::HTMLAudioElement::create):
* html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::create):
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::create):
* mediastream/PeerConnection.cpp:
(WebCore::PeerConnection::create):
* notifications/Notification.cpp:
(WebCore::Notification::create):
* notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::create):
* notifications/NotificationCenter.h:
* page/DOMTimer.cpp:
(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):
* page/EventSource.cpp:
(WebCore::EventSource::create):
* page/SuspendableTimer.cpp:
(WebCore::SuspendableTimer::SuspendableTimer):
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::create):
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::create):
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::create):
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::create):
* websockets/WebSocket.cpp:
(WebCore::WebSocket::create):
* websockets/WebSocket.h:
* workers/SharedWorker.cpp:
(WebCore::SharedWorker::create):
* workers/Worker.cpp:
(WebCore::Worker::create):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::create):

LayoutTests: Test that timers do not fire from subframes of suspended documents.
https://bugs.webkit.org/show_bug.cgi?id=53733

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Mihai Parparita.

* fast/events/resources/suspend-subframe-1.html: Added.
* fast/events/resources/suspend-subframe-2.html: Added.
* fast/events/suspend-timers-expected.txt: Added.
* fast/events/suspend-timers.html: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed WinCE build fix after r106197.
paroga@webkit.org [Mon, 6 Feb 2012 12:33:47 +0000 (12:33 +0000)]
Unreviewed WinCE build fix after r106197.

* tools/CodeProfiling.cpp:
(JSC::CodeProfiling::notifyAllocator): getenv() isn't supported by WinCE. Don't call it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdding FFTFrameGStreamer.cpp that I forgot to commit
philn@webkit.org [Mon, 6 Feb 2012 11:18:00 +0000 (11:18 +0000)]
Adding FFTFrameGStreamer.cpp that I forgot to commit
in r106537. That new file was reviewed in https://bugs.webkit.org/show_bug.cgi?id=73545.

* platform/audio/gstreamer/FFTFrameGStreamer.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd <shadow> element, which is guarded by SHADOW_DOM flag.
hayato@chromium.org [Mon, 6 Feb 2012 10:39:29 +0000 (10:39 +0000)]
Add <shadow> element, which is guarded by SHADOW_DOM flag.
https://bugs.webkit.org/show_bug.cgi?id=76435

Reviewed by Dimitri Glazkov.

Test: fast/dom/shadow/shadow-element.html

Source/WebCore:

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLElementsAllInOne.cpp:
* html/HTMLTagNames.in:
* html/shadow/HTMLShadowElement.cpp: Added.
(WebCore):
(WebCore::HTMLShadowElement::HTMLShadowElement):
(WebCore::HTMLShadowElement::create):
(WebCore::HTMLShadowElement::~HTMLShadowElement):
* html/shadow/HTMLShadowElement.h: Added.
(WebCore):
(HTMLShadowElement):
* html/shadow/HTMLShadowElement.idl: Added.

LayoutTests:

* fast/dom/shadow/shadow-element-expected.txt: Added.
* fast/dom/shadow/shadow-element.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Update NEWS and configure.ac for 1.7.5 release
carlosgc@webkit.org [Mon, 6 Feb 2012 10:26:05 +0000 (10:26 +0000)]
[GTK] Update NEWS and configure.ac for 1.7.5 release
https://bugs.webkit.org/show_bug.cgi?id=77859

Reviewed by Philippe Normand.

.:

* configure.ac: Bumped version number.

Source/WebKit/gtk:

* NEWS: Added release notes for 1.7.5.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=76995.
commit-queue@webkit.org [Mon, 6 Feb 2012 10:18:57 +0000 (10:18 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=76995.
WebKit fails IETC :indeterminate and input type=radio test.

All input types should respect indeterminate property(getter and setter). This is true with other browsers.
Indeterminate appearance for radio input type is supported by IOS platform. Webkit need not support indeterminate appearance
for radio input type on other platforms.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-02-06
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/indeterminate-input-types.html

* html/CheckboxInputType.cpp:
(WebCore::CheckboxInputType::supportsIndeterminateAppearance): Checks indeterminate appearance is supported.
(WebCore):
* html/CheckboxInputType.h:
(CheckboxInputType):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setIndeterminate): Removed the check isCheckable().
(WebCore::HTMLInputElement::isIndeterminate): Checks indeterminate appearance is supported.
(WebCore):
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/InputType.cpp:
(WebCore::InputType::supportsIndeterminateAppearance): Checks indeterminate appearance is supported.
(WebCore):
* html/InputType.h:
(InputType):
* html/RadioInputType.cpp:
(WebCore::RadioInputType::willDispatchClick): Indeterminate related code is moved to IOS specific.
(WebCore::RadioInputType::didDispatchClick): Ditto.
(WebCore::RadioInputType::supportsIndeterminateAppearance): Checks indeterminate appearance is supported.
(WebCore):
* html/RadioInputType.h:
(RadioInputType):

LayoutTests:

* fast/forms/indeterminate-input-types-expected.txt: Added.
* fast/forms/indeterminate-input-types.html: Added.
* fast/forms/indeterminate-radio.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Remove unused variable in PluginViewBlackBerry
commit-queue@webkit.org [Mon, 6 Feb 2012 10:02:03 +0000 (10:02 +0000)]
[BlackBerry] Remove unused variable in PluginViewBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=77847

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-02-06
Reviewed by Kentaro Hara.

No changes in behavior, so no new tests.

* plugins/blackberry/PluginViewBlackBerry.cpp:
(WebCore::PluginView::updatePluginWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Remove unused variable in BackingStore
commit-queue@webkit.org [Mon, 6 Feb 2012 09:58:05 +0000 (09:58 +0000)]
[BlackBerry] Remove unused variable in BackingStore
https://bugs.webkit.org/show_bug.cgi?id=77851

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-02-06
Reviewed by Kentaro Hara.

* blackberry/Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::blitContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-06 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 6 Feb 2012 09:40:14 +0000 (09:40 +0000)]
2012-02-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Switch to unix file endings and at a trailing newline - hopefully the bots will accept my follow up patch then.

        * svg/filters/invalidate-on-child-layout.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Fix several gtkdoc-fixxref warnings
carlosgc@webkit.org [Mon, 6 Feb 2012 09:29:34 +0000 (09:29 +0000)]
[GTK] Fix several gtkdoc-fixxref warnings
https://bugs.webkit.org/show_bug.cgi?id=77613

Reviewed by Martin Robinson.

Source/WebKit/gtk:

* docs/webkitgtk-docs.sgml: Remove webkitspellcheckerenchant
section.
* docs/webkitgtk-sections.txt: Remove webkitspellcheckerenchant
symbols and move WebKitWebNavigationReason from the private
section to the global section.
* webkit/webkitwebnavigationaction.h: Document
WebKitWebNavigationReason enum.

Source/WebKit2:

* UIProcess/API/gtk/WebKitWindowProperties.cpp: Fix a typo, a
colon was missing in WebKitWebView::ready-to-show.

Tools:

* gtk/generate-gtkdoc:
(get_webkit1_options): Add webkitspellcheckerenchant.* to the list
of ignored files, since it's private.
* gtk/gtkdoc.py:
(GTKDoc._ignored_files_basenames): Helper function that returns a
string with the list of ignored files basenames separated by a
spaces, as expected by several gtkdoc commands.
(GTKDoc._run_gtkdoc_scan): Use _ignored_files_basenames for
--ignore-headers option.
(GTKDoc._run_gtkdoc_mkdb): Use _ignored_files_basenames for
--ignore-files option.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Fix CallArgument type in Inspector.json
commit-queue@webkit.org [Mon, 6 Feb 2012 09:27:50 +0000 (09:27 +0000)]
Web Inspector: Fix CallArgument type in Inspector.json
https://bugs.webkit.org/show_bug.cgi?id=77839

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-06
Reviewed by Yury Semikhatsky.

Protocol description is fixed: field type is changed. No changes to
program code are necessary.

* inspector/Inspector-0.1.json:
* inspector/Inspector-1.0.json:
* inspector/Inspector.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Fix xrefs after installing API documentation
carlosgc@webkit.org [Mon, 6 Feb 2012 09:23:08 +0000 (09:23 +0000)]
[GTK] Fix xrefs after installing API documentation
https://bugs.webkit.org/show_bug.cgi?id=77551

Reviewed by Martin Robinson.

* GNUmakefile.am: Call generate-gtkdoc --rebase after installing
api docs.
* gtk/common.py:
(prefix_of_pkg_config_file): Get the prefix variable of the given
pkg-config file.
(gtk_version_of_pkg_config_file): Get the gtk version required by
the given pkg-config file.
* gtk/generate-gtkdoc: Add --rebase command line option to rebase
installed documentation.
(get_gtkdoc_module_paths): Get paths where API doc is installed
for the dependencies of the given pkg-config file.
(get_common_xref_deps): Get API doc directories of dependencies
common to WebKit1 and WebKit2.
(get_webkit2_options): Add cross_reference_deps option.
(get_webkit1_options): Ditto
(rebase_installed_docs): Helper function to create a generator for
the given pkg-config file and options and call rebase_installed_docs.
* gtk/gtkdoc.py:
(GTKDoc.__init__): Initialize cross_reference_deps.
(GTKDoc._run_gtkdoc_fixxref): Add API doc directories of
dependencies.
(GTKDoc.rebase_installed_docs): Call gtkdoc-rebase to fix xref
links of installed documentation.
(PkgConfigGTKDoc.__init__): Get the prefix from the pkg-config
file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLayout Test http/tests/security/xssAuditor/dom-write-innerHTML.html is flaky
abarth@webkit.org [Mon, 6 Feb 2012 09:22:26 +0000 (09:22 +0000)]
Layout Test http/tests/security/xssAuditor/dom-write-innerHTML.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=67538

Reviewed by Kentaro Hara.

Try to fix the flakiness in this test by kicking off the <img> load
before the load event has fired for the inner frame.  That way, the
load event for the main frame will be delayed until the image finishes
loading (and its error handler has fired), removing the need for the
setTimeout.

* http/tests/security/xssAuditor/dom-write-innerHTML.html:
* http/tests/security/xssAuditor/resources/echo-dom-write-innerHTML.html:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIncorrect statistics shown when running run-webkit-tests with --repeat-each or -...
sergio@webkit.org [Mon, 6 Feb 2012 09:07:20 +0000 (09:07 +0000)]
Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations
https://bugs.webkit.org/show_bug.cgi?id=77672

Reviewed by Dirk Pranke.

Test repetitions must be taken into account when working out
the statistics shown by run-webkit-tests.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.prepare_lists_and_print_output):
(Manager._print_result_summary):
* Scripts/webkitpy/layout_tests/models/result_summary.py:
(ResultSummary.__init__):
(ResultSummary.add):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_repeat_each_iterations_num_tests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove JSObject defineGetter/defineSetter lookupGetter/lookupSetter
barraclough@apple.com [Mon, 6 Feb 2012 08:56:02 +0000 (08:56 +0000)]
Remove JSObject defineGetter/defineSetter lookupGetter/lookupSetter
https://bugs.webkit.org/show_bug.cgi?id=77451

Reviewed by Sam Weinig.

These can now all be implemented in terms of defineOwnProperty & getPropertyDescriptor.
Also remove initializeGetterSetterProperty, since this is equivalent to putDirectAccessor.

Source/JavaScriptCore:

* JavaScriptCore.exp:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::defineOwnProperty):
* debugger/DebuggerActivation.h:
(DebuggerActivation):
* runtime/ClassInfo.h:
(MethodTable):
(JSC):
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::finishCreation):
* runtime/JSCell.cpp:
(JSC):
* runtime/JSCell.h:
(JSCell):
* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::defineOwnProperty):
(JSC):
* runtime/JSGlobalObject.h:
(JSGlobalObject):
* runtime/JSObject.cpp:
(JSC):
* runtime/JSObject.h:
(JSObject):
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):

Source/WebCore:

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore):
(WebCore::JSDOMWindow::defineOwnProperty):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore):
* bindings/js/JSDOMWindowShell.h:
(JSDOMWindowShell):
* bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::defineOwnProperty):
(WebCore::JSLocationPrototype::defineOwnProperty):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
* page/DOMWindow.idl:
* page/Location.idl:

Source/WebKit/qt:

* Api/qwebframe.cpp:
(QWebFramePrivate::addQtSenderToGlobalObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/JavaScriptCore: Unreviewed. Fix make distcheck.
carlosgc@webkit.org [Mon, 6 Feb 2012 08:51:19 +0000 (08:51 +0000)]
Source/JavaScriptCore: Unreviewed. Fix make distcheck.

* GNUmakefile.list.am: Add missing files.

Source/WebCore: Unreviewed. Fix make distrcheck.

* GNUmakefile.am: Fix typo in inspector json file.
* GNUmakefile.list.am: Remove non existent file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-06 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 6 Feb 2012 08:04:25 +0000 (08:04 +0000)]
2012-02-06  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Qt minimal compilation fix after r106777.

        * inspector/InspectorDatabaseAgent.h: added missing #if ENABLED guards.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: REGRESSION detached dom nodes aren't highlighted
loislo@chromium.org [Mon, 6 Feb 2012 07:54:53 +0000 (07:54 +0000)]
Web Inspector: REGRESSION detached dom nodes aren't highlighted
https://bugs.webkit.org/show_bug.cgi?id=77829

This functionality was lost when I replaced (Native roots) with (Detached DOM trees) on v8 side.

Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get isDetachedDOMTreesRoot):
(WebInspector.HeapSnapshot.prototype._markDetachedDOMTreeNodes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: get rid of artificial heap snapshot nodes from the retaining tree.
loislo@chromium.org [Mon, 6 Feb 2012 07:52:59 +0000 (07:52 +0000)]
Web Inspector: get rid of artificial heap snapshot nodes from the retaining tree.
https://bugs.webkit.org/show_bug.cgi?id=77850

Reviewed by Yury Semikhatsky.

* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype.updateHasChildren):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get isArtificial):
(WebInspector.HeapSnapshot.prototype._init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: CodeGeneratorInspector.py: switch domain agents to formal interfaces...
yurys@chromium.org [Mon, 6 Feb 2012 07:39:40 +0000 (07:39 +0000)]
Web Inspector: CodeGeneratorInspector.py: switch domain agents to formal interfaces in BackendDispatcher
https://bugs.webkit.org/show_bug.cgi?id=77444

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-05
Reviewed by Yury Semikhatsky.

All agent code is switched to formal interfaces. Actual agent class
names and includes are dropped from InspectorBackendDispatcher.h.

* inspector/CodeGeneratorInspector.py:
(DomainNameFixes.get_fixed_data):
(Generator.go):
* inspector/InspectorAgent.h:
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::highlightNode):
* inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
* inspector/InspectorDOMDebuggerAgent.h:
* inspector/InspectorDOMStorageAgent.h:
* inspector/InspectorDatabaseAgent.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/InspectorFileSystemAgent.h:
* inspector/InspectorIndexedDBAgent.h:
* inspector/InspectorMemoryAgent.h:
* inspector/InspectorPageAgent.h:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::getProfile):
(WebCore::InspectorProfilerAgent::removeProfile):
* inspector/InspectorProfilerAgent.h:
(InspectorProfilerAgent):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::setExtraHTTPHeaders):
* inspector/InspectorResourceAgent.h:
(InspectorResourceAgent):
* inspector/InspectorRuntimeAgent.h:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::start):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
* inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::sendMessageToWorker):
* inspector/InspectorWorkerAgent.h:
(InspectorWorkerAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename [TreatNullAs=EmptyString] to [TreatNullAs=NullString],
haraken@chromium.org [Mon, 6 Feb 2012 07:06:00 +0000 (07:06 +0000)]
Rename [TreatNullAs=EmptyString] to [TreatNullAs=NullString],
[TreatUndefinedAs=EmptyString] to [TreatUndefinedAs=NullString]
https://bugs.webkit.org/show_bug.cgi?id=77611

Reviewed by Adam Barth.

While the Web IDL spec requires [TreatNullAs=EmptyString] and [TreatUndefinedAs=EmptyString],
the current WebKit treats them as (not an empty string but) a null string.
To avoid confusion, this patch renames [TreatNullAs=EmptyString] to [TreatNullAs=NullString],
and [TreatUndefinedAs=EmptyString] to [TreatUndefinedAs=NullString].
(Eventually we should fix WebKit so that it uses an empty string and then
rename them to [TreatNullAs=EmptyString] and [TreatUndefinedAs=EmptyString].)

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm: Added FIXME.
(JSValueToNative):
* bindings/scripts/CodeGeneratorV8.pm: Ditto.
(GetNativeTypeFromSignature):

* bindings/scripts/test/TestObj.idl:
* css/CSSCharsetRule.idl:
* css/CSSPageRule.idl:
* css/CSSRule.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSStyleRule.idl:
* css/CSSValue.idl:
* css/MediaList.idl:
* css/WebKitCSSKeyframesRule.idl:
* dom/Attr.idl:
* dom/CharacterData.idl:
* dom/DOMImplementation.idl:
* dom/Document.idl:
* dom/Element.idl:
* dom/NamedNodeMap.idl:
* dom/Node.idl:
* dom/ProcessingInstruction.idl:
* dom/ShadowRoot.idl:
* fileapi/Blob.idl:
* fileapi/DirectoryEntry.idl:
* fileapi/DirectoryEntrySync.idl:
* fileapi/Entry.idl:
* fileapi/EntrySync.idl:
* fileapi/WebKitBlobBuilder.idl:
* html/HTMLAnchorElement.idl:
* html/HTMLButtonElement.idl:
* html/HTMLCanvasElement.idl:
* html/HTMLDocument.idl:
* html/HTMLElement.idl:
* html/HTMLFieldSetElement.idl:
* html/HTMLFormElement.idl:
* html/HTMLFrameElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLKeygenElement.idl:
* html/HTMLMediaElement.idl:
* html/HTMLObjectElement.idl:
* html/HTMLOutputElement.idl:
* html/HTMLScriptElement.idl:
* html/HTMLSelectElement.idl:
* html/HTMLTextAreaElement.idl:
* html/HTMLTitleElement.idl:
* html/canvas/CanvasRenderingContext2D.idl:
* page/Console.idl:
* page/DOMWindow.idl:
* storage/StorageEvent.idl:
* svg/SVGAngle.idl:
* svg/SVGElement.idl:
* svg/SVGLength.idl:
* svg/SVGScriptElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG's child references from one node to another should have room for type information
fpizlo@apple.com [Mon, 6 Feb 2012 06:44:24 +0000 (06:44 +0000)]
DFG's child references from one node to another should have room for type information
https://bugs.webkit.org/show_bug.cgi?id=77797

Reviewed by Oliver Hunt.

The DFG::Node::child fields now contain both a DFG::NodeIndex (which is just an unsigned)
and a DFG::UseKind (which is currently an effectively empty enum). They are encapsulated
together as a DFG::NodeUse, which can in most cases still be used as an index (for
example DFG::Graph, AbstractState, and SpeculativeJIT all accept NodeUse in most places
where they really want a NodeIndex).

The NodeUse stores both the index and the UseKind without bloating the memory usage of
DFG::Node, since we really don't need full 32 bits for the NodeIndex (a DFG::Node is
roughly 11 words, so if we assume that we never want to use more than 1GB to DFG compile
something - likely a sensible assumption! - then we will only be able to have room for
about 24 million nodes, which means we only need about 24.5 bits for the node index).
Currently the DFG::NodeUse allocates 4 bits for the UseKind and 28 bits for the index,
but stores the index as a signed number to make NoNode work naturally. Hence we really
just have 27 bits for the index.

This is performance-neutral on all benchmarks we track.

* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGAbstractState.h:
(JSC::DFG::AbstractState::forNode):
(AbstractState):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::addVarArgChild):
(JSC::DFG::ByteCodeParser::processPhiStack):
* dfg/DFGCommon.h:
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(DFG):
* dfg/DFGGraph.h:
(Graph):
(JSC::DFG::Graph::operator[]):
(JSC::DFG::Graph::at):
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
(JSC::DFG::Graph::clearAndDerefChild1):
(JSC::DFG::Graph::clearAndDerefChild2):
(JSC::DFG::Graph::clearAndDerefChild3):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::getPrediction):
* dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child1Unchecked):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(JSC::DFG::Node::firstChild):
(JSC::DFG::Node::numChildren):
(JSC::DFG::Node::dumpChildren):
(Node):
* dfg/DFGNodeReferenceBlob.h: Added.
(DFG):
(NodeReferenceBlob):
(JSC::DFG::NodeReferenceBlob::NodeReferenceBlob):
(JSC::DFG::NodeReferenceBlob::child):
(JSC::DFG::NodeReferenceBlob::child1):
(JSC::DFG::NodeReferenceBlob::child2):
(JSC::DFG::NodeReferenceBlob::child3):
(JSC::DFG::NodeReferenceBlob::child1Unchecked):
(JSC::DFG::NodeReferenceBlob::initialize):
(JSC::DFG::NodeReferenceBlob::firstChild):
(JSC::DFG::NodeReferenceBlob::setFirstChild):
(JSC::DFG::NodeReferenceBlob::numChildren):
(JSC::DFG::NodeReferenceBlob::setNumChildren):
* dfg/DFGNodeUse.h: Added.
(DFG):
(NodeUse):
(JSC::DFG::NodeUse::NodeUse):
(JSC::DFG::NodeUse::indexUnchecked):
(JSC::DFG::NodeUse::index):
(JSC::DFG::NodeUse::setIndex):
(JSC::DFG::NodeUse::useKind):
(JSC::DFG::NodeUse::setUseKind):
(JSC::DFG::NodeUse::isSet):
(JSC::DFG::NodeUse::operator!):
(JSC::DFG::NodeUse::operator==):
(JSC::DFG::NodeUse::operator!=):
(JSC::DFG::NodeUse::shift):
(JSC::DFG::NodeUse::makeWord):
(JSC::DFG::operator==):
(JSC::DFG::operator!=):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::vote):
(JSC::DFG::Propagator::toDouble):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::canonicalize):
(JSC::DFG::Propagator::startIndex):
(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::performSubstitution):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::use):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::at):
(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::use):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::DoubleOperand::DoubleOperand):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::SpeculateIntegerOperand::SpeculateIntegerOperand):
(JSC::DFG::SpeculateStrictInt32Operand::SpeculateStrictInt32Operand):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoxss-DENIED-from-data-url-in-foreign-domain-subframe.html is flaky
abarth@webkit.org [Mon, 6 Feb 2012 05:55:10 +0000 (05:55 +0000)]
xss-DENIED-from-data-url-in-foreign-domain-subframe.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77849

Reviewed by Kentaro Hara.

This test doesn't seem to be sequenced correctly w.r.t. the load events
of the various frames involved.  This patch re-orders some of the
triggers in the hopes of making the test no longer flaky.

* http/tests/security/dataURL/resources/foreign-domain-data-url-accessor-iframe.html:
* http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html:
* platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename [JSCCustom*] IDL to [JSCustom*] IDL
haraken@chromium.org [Mon, 6 Feb 2012 04:47:11 +0000 (04:47 +0000)]
Rename [JSCCustom*] IDL to [JSCustom*] IDL
https://bugs.webkit.org/show_bug.cgi?id=77844

Reviewed by Adam Barth.

Most existing JSC-specific IDLs have "JS" prefix. We can rename [JSCCustom] to
[JSCustom], [JSCCustomGetter] to [JSCustomGetter], and [JSCCustomSetter] to
[JSCustomSetter].

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* css/CSSStyleDeclaration.idl:
* html/HTMLDocument.idl:
* html/canvas/DataView.idl:
* page/DOMWindow.idl:
* page/MemoryInfo.idl:
* webaudio/ConvolverNode.idl:
* webaudio/DOMWindowWebAudio.idl:
* webaudio/WaveShaperNode.idl:
* websockets/DOMWindowWebSocket.idl:
* workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Enable WebGL with glx backend
commit-queue@webkit.org [Mon, 6 Feb 2012 04:01:42 +0000 (04:01 +0000)]
[EFL] Enable WebGL with glx backend
https://bugs.webkit.org/show_bug.cgi?id=77308

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-02-05
Reviewed by Martin Robinson.

.:

Enabled WebGL feature for EFL port. The way is very similar to the one of GTK port.

* Source/cmake/OptionsEfl.cmake: Added feature option for WebGL.

Source/WebCore:

Implemented WebGL feature for EFL port. The way is very similar to the one of GTK port.

No new tests required. We can verify this feature with the existing test cases.

* CMakeLists.txt: Revised common files required for WebGL.
* PlatformEfl.cmake: Added EFL specific files.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
* platform/graphics/ANGLEWebKitBridge.h:
* platform/graphics/GraphicsContext3D.h:
(WebCore):
(WebCore::GraphicsContext3D::platformTexture):
(GraphicsContext3D):
(WebCore::GraphicsContext3D::paintsIntoCanvasBuffer):
* platform/graphics/efl/DrawingBufferEfl.cpp: Copied from GTK port.
(WebCore):
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer):
(WebCore::DrawingBuffer::platformColorBuffer):
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
* platform/graphics/efl/GraphicsContext3DEfl.cpp: Almost same with GraphicsContext3DGtk.cpp.
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::isGLES2Compliant):
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES):
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

Source/WebKit/efl:

Activated WebGL feature.

* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in FormSubmission::create.
inferno@chromium.org [Mon, 6 Feb 2012 03:53:42 +0000 (03:53 +0000)]
Crash in FormSubmission::create.
https://bugs.webkit.org/show_bug.cgi?id=77813

Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/form-submission-create-crash.xhtml

* loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):

LayoutTests:

* fast/forms/form-submission-create-crash-expected.txt: Added.
* fast/forms/form-submission-create-crash.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unused file MappedAttributeEntry.h.
kling@webkit.org [Mon, 6 Feb 2012 02:25:23 +0000 (02:25 +0000)]
Remove unused file MappedAttributeEntry.h.
<http://webkit.org/b/77841>

Reviewed by Anders Carlsson.

* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/MappedAttributeEntry.h: Removed.
* dom/StyledElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStyledElement: Rename parseMappedAttribute() to parseAttribute().
kling@webkit.org [Mon, 6 Feb 2012 02:21:57 +0000 (02:21 +0000)]
StyledElement: Rename parseMappedAttribute() to parseAttribute().
<http://webkit.org/b/77830>

Reviewed by Anders Carlsson.

Rename across the board and decorate subclasses with OVERRIDE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed syntax fix.
kov@webkit.org [Mon, 6 Feb 2012 02:06:35 +0000 (02:06 +0000)]
Unreviewed syntax fix.

* English.lproj/localizedStrings.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSwedish buildfix.
kling@webkit.org [Mon, 6 Feb 2012 01:33:30 +0000 (01:33 +0000)]
Swedish buildfix.

* dom/Document.cpp:
(WebCore::wheelEventHandlerCountChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThe scrolling tree should be aware of any wheel event handlers on the page
andersca@apple.com [Mon, 6 Feb 2012 00:43:19 +0000 (00:43 +0000)]
The scrolling tree should be aware of any wheel event handlers on the page
https://bugs.webkit.org/show_bug.cgi?id=77840

Reviewed by Andreas Kling.

If there are wheel event handlers on the page, any wheel events must be redispatched
to the main thread so they can go through the DOM event handling.

* dom/Document.cpp:
(WebCore::wheelEventHandlerCountChanged):
Inform the scrolling coordinator that the wheel event count changed.

(WebCore::Document::didAddWheelEventHandler):
(WebCore::Document::didRemoveWheelEventHandler):
Call wheelEventHandlerCountChanged.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewWheelEventHandlerCountChanged):
Call recomputeWheelEventHandlerCount.

(WebCore::ScrollingCoordinator::recomputeWheelEventHandlerCount):
Update the scrolling tree state.

* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree):
Initialize m_hasWheelEventHandlers to false.

(WebCore::ScrollingTree::tryToHandleWheelEvent):
If m_hasWheelEventHandlers is true, bail.

(WebCore::ScrollingTree::commitNewTreeState):
Update m_hasWheelEventHandlers.

* page/scrolling/ScrollingTreeState.cpp:
(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::setWheelEventHandlerCount):
Add getter and setter for the wheel event handler count.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline xss-inactive-closure.html. This test "fails" because of a
abarth@webkit.org [Sun, 5 Feb 2012 22:27:19 +0000 (22:27 +0000)]
Rebaseline xss-inactive-closure.html.  This test "fails" because of a
subtle difference in how V8 and JSC do security checks.  Essentially,
V8 does security checks based on the current ScriptExecutionContext
whereas JSC does security checks based on the current DOMWindow.  I'm
working on fixing these differences in bugs like
https://bugs.webkit.org/show_bug.cgi?id=75793, but it's a long road.

In any case, the behavior indicated by this test is fine from a
security point of view, so it's better to rebaseline this test because
that will let us detect future regressions.

* platform/chromium/http/tests/security/listener/xss-inactive-closure-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline xss-DENIED-defineProperty. These V8-specific results appear
abarth@webkit.org [Sun, 5 Feb 2012 22:16:21 +0000 (22:16 +0000)]
Rebaseline xss-DENIED-defineProperty.  These V8-specific results appear
to also be passing, just with slightly fewer console messages.

* platform/chromium/http/tests/security/xss-DENIED-defineProperty-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFurther cleanup of failing and flaky security LayoutTests. This patch
abarth@webkit.org [Sun, 5 Feb 2012 22:02:02 +0000 (22:02 +0000)]
Further cleanup of failing and flaky security LayoutTests.  This patch
updates the expectations to match the behavior as described by the
flakiness dashboard.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThis test is no longer flaky. It appears to pass all the time.
abarth@webkit.org [Sun, 5 Feb 2012 21:54:21 +0000 (21:54 +0000)]
This test is no longer flaky.  It appears to pass all the time.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage...
mitz@apple.com [Sun, 5 Feb 2012 18:51:03 +0000 (18:51 +0000)]
<rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true
https://bugs.webkit.org/show_bug.cgi?id=77823

Reviewed by Anders Carlsson.

Source/WebKit2:

* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:
(WebKit::InjectedBundlePageResourceLoadClient::shouldUseCredentialStorage): Added. Calls
through to the client if it implements shouldUseCredentialStorage. Returns true otherwise.
* WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::shouldUseCredentialStorage): Changed to call the injected
bundle resource load client.

Tools:

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Remove g_thread_init() calls
gyuyoung.kim@samsung.com [Sun, 5 Feb 2012 14:02:03 +0000 (14:02 +0000)]
[EFL] Remove g_thread_init() calls
https://bugs.webkit.org/show_bug.cgi?id=77828

Reviewed by Andreas Kling.

g_thread_init has been deprecated since glib 2.32. This function is no longer necessary.
The GLib threading system is automatically initialized at the start of your program.

* ewk/ewk_main.cpp:
(_ewk_init_body):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CMAKE] Support javascriptcore test for EFL port.
gyuyoung.kim@samsung.com [Sun, 5 Feb 2012 09:36:24 +0000 (09:36 +0000)]
[CMAKE] Support javascriptcore test for EFL port.
https://bugs.webkit.org/show_bug.cgi?id=77425

Reviewed by Daniel Bates.

Efl and WinCE as well as Blackberry port are now using Cmake as its build system
and they are share the make file to create jsc excutable. In order to run
"run-javascriptcore-tests", EFL port needs to change jsc installation configuration
with executable output directory(e.g. Programs). So, this patch change jsc installation
configuration only for EFL port.

.:

* Source/cmake/OptionsEfl.cmake: Change *jsc_efl* name with *jsc*.

Source/JavaScriptCore:

* shell/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CMAKE] Do not build Tools when building jsc only.
gyuyoung.kim@samsung.com [Sun, 5 Feb 2012 09:27:59 +0000 (09:27 +0000)]
[CMAKE] Do not build Tools when building jsc only.
https://bugs.webkit.org/show_bug.cgi?id=77826

Reviewed by Daniel Bates.

Do not build Tools when jsc is only built. Build breaks occur because
Tools is built together when building jsc.

* CMakeLists.txt: Build Tools directory when ENABLE_TOOLS is on.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove mapped vs non-mapped attribute distinction.
kling@webkit.org [Sun, 5 Feb 2012 09:26:05 +0000 (09:26 +0000)]
Remove mapped vs non-mapped attribute distinction.
<http://webkit.org/b/77827>

Reviewed by Antti Koivisto.

Removed the isMappedAttribute flag from Attribute as it no longer serves
a practical purpose. Previously, StyledElement would generate mapped
attributes and plain Element would generate non-mapped ones.

The distinction is now made much more clearly by dividing the work between
Element's and StyledElement's attributeChanged() methods. The only thing
that StyledElement wants to do in addition to what Element does is
calling parseMappedAttribute() (which we'll rename in a later patch.)

* dom/Attribute.cpp:
(WebCore::Attribute::clone):
* dom/Attribute.h:
(WebCore::Attribute::create):
(WebCore::Attribute::Attribute):
(Attribute):
* dom/Document.cpp:
(WebCore::Document::createAttributeNS):
* dom/Element.cpp:
(WebCore::Element::attributeChanged):
* dom/Element.h:
(Element):
* dom/Node.cpp:
(WebCore::Node::dumpStatistics):
* dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::parseMappedAttribute):
* dom/StyledElement.h:
(StyledElement):
* html/parser/HTMLConstructionSite.cpp:
(WebCore):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
* html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::insertFakePreElement):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::getPresentationAttribute):
* xml/parser/MarkupTokenBase.h:
(WebCore::::initializeAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoKill CSSMappedAttributeDeclaration.
kling@webkit.org [Sun, 5 Feb 2012 08:29:38 +0000 (08:29 +0000)]
Kill CSSMappedAttributeDeclaration.
<http://webkit.org/b/77820>

Reviewed by Antti Koivisto.

Replace all use of CSSMappedAttributeDeclaration by StylePropertySet.
Moved the setNeedsStyleRecalc() calls from CSSMappedAttributeDeclaration
to the add/remove-CSS-property helpers in StyledElement.

This removes one step of indirection for attribute styles and reduces
the size of elements that have presentational attributes by one pointer.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.order:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/CSSMappedAttributeDeclaration.cpp: Removed.
* dom/CSSMappedAttributeDeclaration.h: Removed.
* dom/DOMAllInOne.cpp:

    Remove CSSMappedAttributeDeclaration.{cpp,h}

* css/CSSParser.h:
* css/CSSParser.cpp:
(WebCore::parseSimpleLengthValue):

    Remove CSSParser::parseMappedAttributeValue(), we now use parseValue()
    directly instead. We lose the benefit of caching new CSSValues in the
    document's CSSValuePool but this optimization can be added back later.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchAllRules):
* dom/ElementAttributeData.h:
(ElementAttributeData):
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::ensureAttributeStyle):
* dom/NamedNodeMap.h:
(WebCore::NamedNodeMap::attributeStyle):
(NamedNodeMap):
* dom/StyledElement.cpp:
(WebCore::StyledElement::removeCSSProperties):
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):
(WebCore::StyledElement::addCSSLength):
(WebCore::StyledElement::addCSSColor):
* dom/StyledElement.h:
(WebCore):
(WebCore::StyledElement::attributeStyle):
(WebCore::StyledElement::ensureAttributeStyle):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: beautify retaining tree items view.
loislo@chromium.org [Sun, 5 Feb 2012 08:27:07 +0000 (08:27 +0000)]
Web Inspector: beautify retaining tree items view.
https://bugs.webkit.org/show_bug.cgi?id=77810

Reviewed by Yury Semikhatsky.

* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
* inspector/front-end/heapProfiler.css:
(.cycled-ancessor-node):
* inspector/front-end/profilesPanel.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add support to force full damage in CCDamageTracker
shawnsingh@chromium.org [Sun, 5 Feb 2012 06:13:47 +0000 (06:13 +0000)]
[chromium] Add support to force full damage in CCDamageTracker
https://bugs.webkit.org/show_bug.cgi?id=76805

Reviewed by James Robinson.

Source/WebCore:

Unit test added to CCDamageTrackerTest.cpp.

This feature is needed for events that should cause the entire
surface to be damaged, even if layers themselves had only partial
damage or no damage at all. For example, tab-switching is one such
event.

* platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::CCDamageTracker):
(WebCore::CCDamageTracker::updateDamageRectForNextFrame):
* platform/graphics/chromium/cc/CCDamageTracker.h:
(WebCore::CCDamageTracker::forceFullDamageNextUpdate):
(CCDamageTracker):

Source/WebKit/chromium:

* tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
(WebKitTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/10660698> Clients cannot prevent caching of individual responses
mitz@apple.com [Sun, 5 Feb 2012 02:53:18 +0000 (02:53 +0000)]
<rdar://problem/10660698> Clients cannot prevent caching of individual responses
https://bugs.webkit.org/show_bug.cgi?id=77822

Reviewed by Sam Weinig.

Source/WebKit2:

* Shared/APIClientTraits.cpp: Added definition of interfaceSizesByVersion for
WKBundlePageResourceLoadClient.
* Shared/APIClientTraits.h: Added APIClientTraits specialization for WKBundlePageResourceLoadClient.
* WebProcess/InjectedBundle/API/c/WKBundlePage.h: Added WKBundlePageShouldCacheResponseCallback
typedef, added shouldCacheResponse member to WKBundlePageResourceLoadClient, and bumped
kWKBundlePageResourceLoadClientCurrentVersion to 1.
* WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:
(WebKit::InjectedBundlePageResourceLoadClient::shouldCacheResponse): Added. Calls through
to the client if it implements shouldCacheResponse. Returns true otherwise.
* WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::willCacheResponse): Changed to call
InjectedBundlePageResourceLoadClient::shouldCacheResponse() and return nil if the former
returns false.
(WebKit::WebFrameLoaderClient::shouldCacheResponse): Changed to call
InjectedBundlePageResourceLoadClient::shouldCacheResponse().

Tools:

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove dead code from ScrollingCoordinator
andersca@apple.com [Sun, 5 Feb 2012 01:03:24 +0000 (01:03 +0000)]
Remove dead code from ScrollingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=77821

Reviewed by Sam Weinig.

* WebCore.exp.in:
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::ScrollingCoordinator):
* page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
* page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinator::frameViewScrollLayerDidChange):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
(WebCore::RenderLayerCompositor::updateRootLayerPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd ability to send WKURLRequests in WebKit2 API user messages
weinig@apple.com [Sun, 5 Feb 2012 00:55:32 +0000 (00:55 +0000)]
Add ability to send WKURLRequests in WebKit2 API user messages
https://bugs.webkit.org/show_bug.cgi?id=77819

Reviewed by Anders Carlsson.

Source/WebKit2:

Test: WebKit2UserMessageRoundTripTest API test.

* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
Add encode/decode for WebURLRequest.

Tools:

Add testing for round-tripping WKTypes from the UIProcess,
to the WebProcess, and back.

- This commit adds a test fixture and tests for WKURLRequestRef, WKURLRef, and WKStringRef.
  More can easily be added.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Added.
(TestWebKitAPI):
(WebKit2UserMessageRoundTripTest):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::WebKit2UserMessageRoundTripTest):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::didReceiveMessageFromInjectedBundle):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::roundTrip):
(TestWebKitAPI::TEST_F):
* TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Added.
(TestWebKitAPI):
(UserMessageTest):
(TestWebKitAPI::UserMessageTest::UserMessageTest):
(TestWebKitAPI::UserMessageTest::didReceiveMessage):
* TestWebKitAPI/mac/PlatformWebViewMac.mm:
(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI):
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
* TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThe scrolling tree should inform the main scrolling coordinator when the scroll posit...
andersca@apple.com [Sun, 5 Feb 2012 00:43:39 +0000 (00:43 +0000)]
The scrolling tree should inform the main scrolling coordinator when the scroll position changes
https://bugs.webkit.org/show_bug.cgi?id=77818

Reviewed by Sam Weinig.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):
Set the main frame scroll position.

* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::updateMainFrameScrollPosition):
Call ScrollingCoordinator::updateMainFrameScrollPosition on the main thread.

* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::scrollBy):
Call ScrollingTree::updateMainFrameScrollPosition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/10772406> WKPreferences instances cannot be copied
mitz@apple.com [Sun, 5 Feb 2012 00:18:17 +0000 (00:18 +0000)]
<rdar://problem/10772406> WKPreferences instances cannot be copied
https://bugs.webkit.org/show_bug.cgi?id=77816

Reviewed by Sam Weinig.

Source/WebKit2:

Test added in TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp.

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesCreateCopy): Added.
* UIProcess/API/C/WKPreferencesPrivate.h:
* UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::WebPreferences): Added this constructor that copies the
WebPreferencesStore of the given WebPreferences.
* UIProcess/WebPreferences.h:
(WebKit::WebPreferences::create): Added this create function that takes a WebPreferences
instance and creates a new instance with a copy of the given instance’s store.

Tools:

* TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRubber stamped by Sam Weinig.
barraclough@apple.com [Sat, 4 Feb 2012 23:49:37 +0000 (23:49 +0000)]
Rubber stamped by Sam Weinig.

* yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPatternConstructor::quantifyAtom):
    - Fix comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix bug in svg-link-hover-use.svg
commit-queue@webkit.org [Sat, 4 Feb 2012 22:56:55 +0000 (22:56 +0000)]
Fix bug in svg-link-hover-use.svg
https://bugs.webkit.org/show_bug.cgi?id=77768

Patch by Philip Rogers <pdr@google.com> on 2012-02-04
Reviewed by Eric Seidel.

* ManualTests/svg-link-hover-use.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoElement: Remove unnecessary attributeChanged() argument.
kling@webkit.org [Sat, 4 Feb 2012 22:56:28 +0000 (22:56 +0000)]
Element: Remove unnecessary attributeChanged() argument.
<http://webkit.org/b/77814>

Reviewed by Ryosuke Niwa.

Remove the 'preserveDecls' argument to Element::attributeChanged() as that is no
longer needed after the removal of per-attribute style declarations.
Decorated subclass overrides with OVERRIDE since we're touching the lines.

Also removed an old inaccurate comment in NamedNodeMap::setAttributes() - calling
attributeChanged() is absolutely necessary to initialize element-specific state.

* dom/Element.cpp:
(WebCore::Element::attributeChanged):
* dom/Element.h:
(Element):
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::setAttributes):
* dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged):
* dom/StyledElement.h:
(StyledElement):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::attributeChanged):
* html/HTMLMediaElement.h:
(HTMLMediaElement):
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::attributeChanged):
* html/HTMLScriptElement.h:
(HTMLScriptElement):
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::attributeChanged):
* html/HTMLTrackElement.h:
(HTMLTrackElement):
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::attributeChanged):
* svg/SVGAnimationElement.h:
* svg/SVGElement.cpp:
(WebCore::SVGElement::attributeChanged):
* svg/SVGElement.h:
(SVGElement):
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::attributeChanged):
* svg/animation/SVGSMILElement.h:
(SVGSMILElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] CurrentTime: Reorder headers for win32
commit-queue@webkit.org [Sat, 4 Feb 2012 22:44:40 +0000 (22:44 +0000)]
[GTK] CurrentTime: Reorder headers for win32
https://bugs.webkit.org/show_bug.cgi?id=77808

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-04
Reviewed by Martin Robinson.

In GTK+ win32 port, monotonicallyIncreasingTime() implementation is
based on g_get_monotonic_time(). Reorder headers to make sure glib.h
gets included even when the platform is win32.

CurrentTime.cpp: In function 'double WTF::monotonicallyIncreasingTime()':
CurrentTime.cpp:321:53: error: 'g_get_monotonic_time' was not declared in this scope
CurrentTime.cpp:322:1: warning: control reaches end of non-void function [-Wreturn-type]

* wtf/CurrentTime.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash when reparenting children of flexible boxes
commit-queue@webkit.org [Sat, 4 Feb 2012 22:40:52 +0000 (22:40 +0000)]
Crash when reparenting children of flexible boxes
https://bugs.webkit.org/show_bug.cgi?id=77458

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-02-04
Reviewed by Ojan Vafai.

Source/WebCore:

This fixes some regressions I introduced in r106150. RenderBlock::
removeChild needs to be careful about not collapsing anonymous
blocks underneath flexible boxes, and also about node ordering
when there is an after block.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::collapseAnonymousBoxChild):

LayoutTests:

This test case reparents a block node from under a flexible box so
that only anonymous blocks and floating generated blocks remain.
A recent patch caused these anonymous blocks to be collapsed, which
is incorrect.

* fast/css-generated-content/remove-div-from-flexible-box-with-floating-after-content-crash-expected.txt: Added
* fast/css-generated-content/remove-div-from-flexible-box-with-floating-after-content-crash.html: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDebug build fix after r106715.
rniwa@webkit.org [Sat, 4 Feb 2012 22:26:52 +0000 (22:26 +0000)]
Debug build fix after r106715.

* html/HTMLDetailsElement.cpp:
(WebCore::DetailsSummaryElement::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Use the wide character version of win32 API by default
commit-queue@webkit.org [Sat, 4 Feb 2012 22:24:01 +0000 (22:24 +0000)]
[GTK] Use the wide character version of win32 API by default
https://bugs.webkit.org/show_bug.cgi?id=77809

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-04
Reviewed by Martin Robinson.

Certain win32-specific files (like PluginDatabaseWin.cpp) make the
assumption that the wide character version of win32 API is the default.
Define _UNICODE and UNICODE to do this, similar to what other win32
ports are doing.

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed test fix after r106740.
kling@webkit.org [Sat, 4 Feb 2012 21:31:51 +0000 (21:31 +0000)]
Unreviewed test fix after r106740.
<http://webkit.org/b/77204>

Disable matched declaration caching for elements with attribute style until we can
figure out how it's supposed to work.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchAllRules):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoKill per-Attribute style declarations.
kling@webkit.org [Sat, 4 Feb 2012 12:24:19 +0000 (12:24 +0000)]
Kill per-Attribute style declarations.
<http://webkit.org/b/77204>

Reviewed by Antti Koivisto.

Source/WebCore:

TL;DR summary: Remove the per-Attribute style declarations and replace them by a single
style declaration on StyledElement that acts as a secondary inline style.

The previous design was conceived in the Age of the Old Web(tm) where the majority of
element styling was accomplished via attributes. Nowadays, CSS is a much better tool for
this and we should optimize around that instead.

StyledElements now have an attributeStyle() which contains all the styling from attributes.
parseMappedAttribute() is responsible for adding/removing properties to the attributeStyle
as the corresponding attributes come in/out of the element.

Each Attribute instance shrinks by one pointer, each element that has attributes grows by
one pointer. The styles from individual attributes are no longer shared, so content that
uses a lot of repeating styling attributes will see a slight memory regression from this.
Future improvements to this could enable sharing the attributeStyle between elements that
have the same exact attributes to mitigate some of the damage.

There should be no web-facing behavior change from this, but it does break two things:

- The Inspector feature for displaying per-attribute styles. To keep things manageable,
  this patch simply files all the attribute styles together under an anonymous attribute
  in the Inspector.

- The Obj-C DOM binding for Attr::style() has to be kept for compatibility reasons,
  though it's already deprecated. It will now always return nil, since there's no way to
  retrieve a live style declaration that's specific to a certain Attr.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
* dom/Attr.h:
(WebCore):
(Attr):
(WebCore::Attr::style):
* dom/Attribute.cpp:
(WebCore::Attribute::clone):
* dom/Attribute.h:
(WebCore):
(WebCore::Attribute::create):
(WebCore::Attribute::createMapped):
(Attribute):
(WebCore::Attribute::Attribute):
* dom/CSSMappedAttributeDeclaration.cpp:
(WebCore::CSSMappedAttributeDeclaration::~CSSMappedAttributeDeclaration):
(WebCore::CSSMappedAttributeDeclaration::setMappedProperty):
* dom/CSSMappedAttributeDeclaration.h:
(CSSMappedAttributeDeclaration):
(WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):
* dom/Element.h:
(Element):
* dom/ElementAttributeData.h:
(ElementAttributeData):
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::ensureAttributeStyle):
(WebCore):
* dom/NamedNodeMap.h:
(WebCore::NamedNodeMap::attributeStyle):
(NamedNodeMap):
* dom/StyledElement.cpp:
(WebCore):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::removeCSSProperties):
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):
(WebCore::StyledElement::addCSSLength):
(WebCore::StyledElement::addCSSColor):
* dom/StyledElement.h:
(StyledElement):
(WebCore::StyledElement::removeCSSProperty):
(WebCore::StyledElement::attributeStyle):
(WebCore::StyledElement::ensureAttributeStyle):
* html/HTMLBRElement.cpp:
(WebCore::HTMLBRElement::parseMappedAttribute):
* html/HTMLBRElement.h:
(HTMLBRElement):
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::parseMappedAttribute):
* html/HTMLBodyElement.h:
(HTMLBodyElement):
* html/HTMLDivElement.cpp:
(WebCore::HTMLDivElement::parseMappedAttribute):
* html/HTMLDivElement.h:
(HTMLDivElement):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::applyBorderAttribute):
(WebCore::HTMLElement::mapLanguageAttributeToLocale):
(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::removeHTMLAlignment):
(WebCore):
(WebCore::HTMLElement::addHTMLAlignmentToStyledElement):
(WebCore::HTMLElement::setContentEditable):
* html/HTMLElement.h:
(HTMLElement):
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::parseMappedAttribute):
* html/HTMLEmbedElement.h:
(HTMLEmbedElement):
* html/HTMLFontElement.cpp:
(WebCore::HTMLFontElement::parseMappedAttribute):
* html/HTMLFontElement.h:
(HTMLFontElement):
* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::parseMappedAttribute):
* html/HTMLFrameSetElement.h:
(HTMLFrameSetElement):
* html/HTMLHRElement.cpp:
(WebCore::HTMLHRElement::parseMappedAttribute):
* html/HTMLHRElement.h:
(HTMLHRElement):
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseMappedAttribute):
* html/HTMLIFrameElement.h:
(HTMLIFrameElement):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseMappedAttribute):
* html/HTMLImageElement.h:
(HTMLImageElement):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseMappedAttribute):
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::parseMappedAttribute):
* html/HTMLLIElement.h:
(HTMLLIElement):
* html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::parseMappedAttribute):
* html/HTMLMarqueeElement.h:
(HTMLMarqueeElement):
* html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::parseMappedAttribute):
* html/HTMLOListElement.h:
(HTMLOListElement):
* html/HTMLOutputElement.cpp:
* html/HTMLOutputElement.h:
(HTMLOutputElement):
* html/HTMLParagraphElement.cpp:
(WebCore::HTMLParagraphElement::parseMappedAttribute):
* html/HTMLParagraphElement.h:
(HTMLParagraphElement):
* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::parseMappedAttribute):
* html/HTMLPlugInElement.h:
(HTMLPlugInElement):
* html/HTMLPreElement.cpp:
(WebCore::HTMLPreElement::parseMappedAttribute):
* html/HTMLPreElement.h:
(HTMLPreElement):
* html/HTMLTableCaptionElement.cpp:
(WebCore::HTMLTableCaptionElement::parseMappedAttribute):
* html/HTMLTableCaptionElement.h:
(HTMLTableCaptionElement):
* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::parseMappedAttribute):
* html/HTMLTableCellElement.h:
(HTMLTableCellElement):
* html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::parseMappedAttribute):
* html/HTMLTableColElement.h:
(HTMLTableColElement):
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::parseMappedAttribute):
* html/HTMLTableElement.h:
(HTMLTableElement):
* html/HTMLTablePartElement.cpp:
(WebCore):
(WebCore::HTMLTablePartElement::parseMappedAttribute):
* html/HTMLTablePartElement.h:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::parseMappedAttribute):
* html/HTMLUListElement.cpp:
(WebCore::HTMLUListElement::parseMappedAttribute):
* html/HTMLUListElement.h:
(HTMLUListElement):
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::parseMappedAttribute):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):
* mathml/MathMLElement.cpp:
(WebCore::MathMLElement::parseMappedAttribute):
* mathml/MathMLElement.h:
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::parseMappedAttribute):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::parseMappedAttribute):
(WebCore::SVGStyledElement::getPresentationAttribute):
* svg/SVGStyledElement.h:
(SVGStyledElement):
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::parseMappedAttribute):

LayoutTests:

Rebaselined 3 inspector tests since attribute styles are no longer shown per-attribute.

* inspector/elements/elements-panel-styles-expected.txt:
* inspector/styles/styles-computed-trace-expected.txt:
* inspector/styles/styles-new-API-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic's All Failure tab should let you examine and rebaseline expected failures
abarth@webkit.org [Sat, 4 Feb 2012 10:22:12 +0000 (10:22 +0000)]
garden-o-matic's All Failure tab should let you examine and rebaseline expected failures
https://bugs.webkit.org/show_bug.cgi?id=77802

Reviewed by Eric Seidel.

This patch refactors our directory grouping code into base.js where it
can be shared between failures.js and notifications.js.  It then adds
an Examine action to each group of failures that triggers the "results"
view.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: get rid of cycles in retaining tree
loislo@chromium.org [Sat, 4 Feb 2012 10:20:07 +0000 (10:20 +0000)]
Web Inspector: get rid of cycles in retaining tree
https://bugs.webkit.org/show_bug.cgi?id=77801

Drive by fix: 'retained by' prefix was removed.

Reviewed by Yury Semikhatsky.

* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype._updateHasChildren):
(WebInspector.HeapSnapshotObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
* inspector/front-end/profilesPanel.css:
(.cycled-ancessor-node):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd the "JS" prefix to JSC specific IDL attributes
haraken@chromium.org [Sat, 4 Feb 2012 10:12:47 +0000 (10:12 +0000)]
Add the "JS" prefix to JSC specific IDL attributes
https://bugs.webkit.org/show_bug.cgi?id=77693

Reviewed by Darin Adler.

Some JSC specific IDLs do not have "JS" prefix, e.g. [CustomIsReachable].
It might be OK since JSC is the main JavaScript engine in WebKit, but
distinguishing IDLs widely used in WebKit and IDLs used in JSC only would help
people understand the role of IDLs.

This patch renames the following JSC specific IDLs:

    CustomFinalize => JSCustomFinalize
    CustomIsReachable => JSCustomIsReachable
    CustomMarkFunction => JSCustomMarkFunction
    CustomToJS => JSCustomToJS
    CustomNativeConverter => JSCustomToNativeObject (Note: For naming consistency with [JSCustomToJS])
    GenerateIsReachable => JSGenerateIsReachable
    GenerateToJS => JSGenerateToJS
    NoStaticTables => JSNoStaticTables
    WindowEventListener => JSWindowEventListener
    InlineGetOwnPropertySlot => JSInlineGetOwnPropertySlot
    DelegatingPrototypePutFunction => JSCustomPrototypePutDelegate

No tests. No changes in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(HasCustomToV8Implementation):

* bindings/scripts/test/TestTypedArray.idl: No change in run-bindings-tests results.

* css/CSSRule.idl:
* css/CSSRuleList.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSValue.idl:
* css/MediaList.idl:
* css/MediaQueryListListener.idl:
* css/StyleMedia.idl:
* css/StyleSheet.idl:
* css/StyleSheetList.idl:
* dom/Attr.idl:
* dom/DOMCoreException.idl:
* dom/DOMImplementation.idl:
* dom/DOMStringMap.idl:
* dom/Document.idl:
* dom/Element.idl:
* dom/ErrorEvent.idl:
* dom/Event.idl:
* dom/EventException.idl:
* dom/EventListener.idl:
* dom/MessageChannel.idl:
* dom/MessageEvent.idl:
* dom/MessagePort.idl:
* dom/NamedNodeMap.idl:
* dom/Node.idl:
* dom/NodeFilter.idl:
* dom/NodeIterator.idl:
* dom/NodeList.idl:
* dom/TreeWalker.idl:
* dom/WebKitNamedFlow.idl:
* fileapi/Blob.idl:
* fileapi/DOMFileSystem.idl:
* fileapi/DOMFileSystemSync.idl:
* fileapi/DirectoryEntry.idl:
* fileapi/DirectoryEntrySync.idl:
* fileapi/DirectoryReader.idl:
* fileapi/DirectoryReaderSync.idl:
* fileapi/Entry.idl:
* fileapi/EntryArray.idl:
* fileapi/EntryArraySync.idl:
* fileapi/EntrySync.idl:
* fileapi/File.idl:
* fileapi/FileEntry.idl:
* fileapi/FileEntrySync.idl:
* fileapi/FileError.idl:
* fileapi/FileException.idl:
* fileapi/FileList.idl:
* fileapi/FileReader.idl:
* fileapi/FileReaderSync.idl:
* fileapi/FileWriter.idl:
* fileapi/Metadata.idl:
* fileapi/OperationNotAllowedException.idl:
* fileapi/WebKitBlobBuilder.idl:
* html/DOMFormData.idl:
* html/DOMSettableTokenList.idl:
* html/DOMTokenList.idl:
* html/DOMURL.idl:
* html/HTMLAllCollection.idl:
* html/HTMLBodyElement.idl:
* html/HTMLCollection.idl:
* html/HTMLFrameSetElement.idl:
* html/ImageData.idl:
* html/MediaController.idl:
* html/TextTrack.idl:
* html/TextTrackCue.idl:
* html/VoidCallback.idl:
* html/canvas/ArrayBuffer.idl:
* html/canvas/ArrayBufferView.idl:
* html/canvas/CanvasRenderingContext.idl:
* html/canvas/DataView.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/OESStandardDerivatives.idl:
* html/canvas/OESTextureFloat.idl:
* html/canvas/OESVertexArrayObject.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:
* html/canvas/WebGLCompressedTextures.idl:
* html/canvas/WebGLDebugRendererInfo.idl:
* html/canvas/WebGLDebugShaders.idl:
* html/canvas/WebGLLoseContext.idl:
* html/canvas/WebGLRenderingContext.idl:
* html/track/TextTrackList.idl:
* loader/appcache/DOMApplicationCache.idl:
* mediastream/LocalMediaStream.idl:
* page/BarInfo.idl:
* page/Console.idl:
* page/DOMSelection.idl:
* page/DOMWindow.idl:
* page/EventSource.idl:
* page/Geolocation.idl:
* page/History.idl:
* page/Location.idl:
* page/Navigator.idl:
* page/Screen.idl:
* page/WorkerNavigator.idl:
* plugins/DOMMimeTypeArray.idl:
* plugins/DOMPluginArray.idl:
* storage/Database.idl:
* storage/DatabaseSync.idl:
* storage/IDBAny.idl:
* storage/IDBKey.idl:
* storage/SQLError.idl:
* storage/SQLException.idl:
* storage/SQLResultSet.idl:
* storage/SQLResultSetRowList.idl:
* storage/SQLTransaction.idl:
* storage/SQLTransactionSync.idl:
* storage/Storage.idl:
* svg/SVGElementInstance.idl:
* svg/SVGPathSeg.idl:
* webaudio/AudioBufferCallback.idl:
* webaudio/AudioBufferSourceNode.idl:
* webaudio/AudioContext.idl:
* webaudio/AudioDestinationNode.idl:
* webaudio/AudioGain.idl:
* webaudio/AudioGainNode.idl:
* webaudio/AudioPannerNode.idl:
* webaudio/AudioProcessingEvent.idl:
* webaudio/BiquadFilterNode.idl:
* webaudio/ConvolverNode.idl:
* webaudio/DelayNode.idl:
* webaudio/DynamicsCompressorNode.idl:
* webaudio/HighPass2FilterNode.idl:
* webaudio/JavaScriptAudioNode.idl:
* webaudio/LowPass2FilterNode.idl:
* webaudio/MediaElementAudioSourceNode.idl:
* webaudio/OfflineAudioCompletionEvent.idl:
* webaudio/RealtimeAnalyserNode.idl:
* webaudio/WaveShaperNode.idl:
* websockets/CloseEvent.idl:
* websockets/WebSocket.idl:
* workers/AbstractWorker.idl:
* workers/DedicatedWorkerContext.idl:
* workers/SharedWorker.idl:
* workers/SharedWorkerContext.idl:
* workers/Worker.idl:
* workers/WorkerContext.idl:
* workers/WorkerLocation.idl:
* xml/XMLHttpRequest.idl:
* xml/XMLHttpRequestException.idl:
* xml/XMLHttpRequestProgressEvent.idl:
* xml/XMLHttpRequestUpload.idl:
* xml/XPathResult.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttp/tests/security/xss-eval fails due to difference in JSC and V8 eval
abarth@webkit.org [Sat, 4 Feb 2012 10:09:16 +0000 (10:09 +0000)]
http/tests/security/xss-eval fails due to difference in JSC and V8 eval
https://bugs.webkit.org/show_bug.cgi?id=77806

Reviewed by Eric Seidel.

Both the JSC and V8 behaviors are reasonable in this case.  This patch
modifies the test to show that either behavior isn't a security
vulnerability.

* http/tests/security/xss-eval.html:
* platform/chromium/http/tests/security/xss-eval-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocheck-webkit-style is throwing an exception
ojan@chromium.org [Sat, 4 Feb 2012 09:50:47 +0000 (09:50 +0000)]
check-webkit-style is throwing an exception
https://bugs.webkit.org/show_bug.cgi?id=77744

Reviewed by David Levin.

If the test_list is None, then we don't need to check for unsupported
feature tests to skip.

* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._has_test_in_directories):
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(test_skipped_tests_for_unsupported_features_empty_test_list):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConvert RenderTheme over to new layout abstraction
eae@chromium.org [Sat, 4 Feb 2012 09:42:39 +0000 (09:42 +0000)]
Convert RenderTheme over to new layout abstraction
https://bugs.webkit.org/show_bug.cgi?id=77783

Reviewed by Eric Seidel.

Change the RenderTheme classes to use the new layout abstraction as a
part of the ongoing conversion work.

No new tests.

* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
(WebCore::RenderTheme::baselinePosition):
(WebCore::RenderTheme::adjustRepaintRect):
(WebCore::RenderTheme::meterSizeForBounds):
* rendering/RenderTheme.h:
(RenderTheme):
(WebCore::RenderTheme::paintCapsLockIndicator):
* rendering/RenderThemeChromiumMac.h:
(RenderThemeChromiumMac):
* rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton):
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::convertToPaintingRect):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
* rendering/RenderThemeChromiumSkia.h:
* rendering/RenderThemeMac.h:
(RenderThemeMac):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustRepaintRect):
(WebCore::RenderThemeMac::inflateRect):
(WebCore::RenderThemeMac::setControlSize):
(WebCore::RenderThemeMac::paintCapsLockIndicator):
(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::meterSizeForBounds):
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::setPopupButtonCellState):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::baselinePosition):
* rendering/RenderThemeSafari.h:
(RenderThemeSafari):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):
(WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton):
* rendering/RenderThemeWin.h:
(RenderThemeWin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: mark quota layout test WONTFIX
dgrogan@chromium.org [Sat, 4 Feb 2012 09:40:39 +0000 (09:40 +0000)]
IndexedDB: mark quota layout test WONTFIX
https://bugs.webkit.org/show_bug.cgi?id=77459

Reviewed by Tony Chang.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fix multi-second hangs in compositor invalidating large layers
senorblanco@chromium.org [Sat, 4 Feb 2012 09:26:17 +0000 (09:26 +0000)]
[chromium] Fix multi-second hangs in compositor invalidating large layers
https://bugs.webkit.org/show_bug.cgi?id=77774

Reviewed by James Robinson.

Correctness covered by existing tests.

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::pushPropertiesTo):
Remove tiles from the tiler when they are invalid (ie., no longer have
texture backing).
(WebCore::TiledLayerChromium::invalidateRect):
Instead of iterating over the tile indices (which may be very large),
iterate over the tile hash map instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Upstream BlackBerry WebCoreSupport ClientExtension and GeolocationContro...
commit-queue@webkit.org [Sat, 4 Feb 2012 09:24:10 +0000 (09:24 +0000)]
[BlackBerry] Upstream BlackBerry WebCoreSupport ClientExtension and GeolocationControllerClientBlackBerry classes
https://bugs.webkit.org/show_bug.cgi?id=77751

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-02-04
Reviewed by Rob Buis.

Initial upstream, no new tests.

* blackberry/WebCoreSupport/ClientExtension.cpp: Added.
* blackberry/WebCoreSupport/ClientExtension.h: Added.
* blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.cpp: Added.
* blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Patch by Swapna P <spottabathini@innominds.com> on 2012-02-04
commit-queue@webkit.org [Sat, 4 Feb 2012 09:19:57 +0000 (09:19 +0000)]
Source/WebCore: Patch by Swapna P <spottabathini@innominds.com> on 2012-02-04
Reviewed by Antonio Gomes.

Bug: iframe with scrolling=no incorrectly autoscrollable
https://bugs.webkit.org/show_bug.cgi?id=61558

Added check for frame scrolling mode just before applying scroll on frame content in function RenderLayer::scrollRect

Testcase: LayoutTests/fast/events/autoscroll-with-non-scrollable-parent.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):

LayoutTests: Patch by Swapna P <spottabathini@innominds.com> on 2012-02-04
Reviewed by Antonio Gomes.

Bug: iframe with scrolling=no incorrectly autoscrollable
https://bugs.webkit.org/show_bug.cgi?id=61558

Did change inorder to print correct log as per the description provided in test case.

* fast/events/autoscroll-with-non-scrollable-parent.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCanvas-into-canvas drawing should respect backing store scale ratio
timothy_horton@apple.com [Sat, 4 Feb 2012 06:43:50 +0000 (06:43 +0000)]
Canvas-into-canvas drawing should respect backing store scale ratio
https://bugs.webkit.org/show_bug.cgi?id=77784
<rdar://problem/10549729>

Reviewed by Dan Bernstein.

Respect the backing store scale ratio when drawing a canvas into another
canvas via ctx.drawImage(canvas, x, y). Previous behavior caused canvas
drawing to differ based on the size of the backing store, which is ideally
an implementation detail to authors.

Also, rename the source canvas arguments to CanvasRenderingContext2D::drawImage
to be more clear.

No new tests.

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a Chromium-specific baseline for this test. These results appear to be passing.
abarth@webkit.org [Sat, 4 Feb 2012 04:45:42 +0000 (04:45 +0000)]
Add a Chromium-specific baseline for this test.  These results appear to be passing.

* platform/chromium-win/http/tests/security/cross-frame-access-put-expected.txt: Removed.
* platform/chromium/http/tests/security/cross-frame-access-put-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoList of all failures in garden-o-matic should actually list all the failures
abarth@webkit.org [Sat, 4 Feb 2012 03:59:10 +0000 (03:59 +0000)]
List of all failures in garden-o-matic should actually list all the failures
https://bugs.webkit.org/show_bug.cgi?id=77796

Reviewed by Eric Seidel.

This patch wires a bit more data into the new "All Failures" tab.  I've
also iterated on how we enable this experimental feature.  The tab is
still just a dumb list, but we'll make it smarter.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix after r106692.
rniwa@webkit.org [Sat, 4 Feb 2012 03:50:50 +0000 (03:50 +0000)]
Windows build fix after r106692.

* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_reference_files):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=77782
bdakin@apple.com [Sat, 4 Feb 2012 02:01:27 +0000 (02:01 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=77782
WebPageProxy::didNewFirstVisuallyNonEmptyLayout should is called more than
once on some pages with frames
-and corresponding-
<rdar://problem/10798474>

Reviewed by Sam Weinig.

Source/WebCore:

startCountingRelevantRepaintedObjects() should only be called for the main
frame. Otherwise, the counter will be re-set inappropriately, and
didNewFirstVisuallyNonEmptyLayout may even end up firing more than once.
* page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):

Tools:

One new test.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::didForceRepaint):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Added.
(TestWebKitAPI):
(NewFirstVisuallyNonEmptyLayoutFramesTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::NewFirstVisuallyNonEmptyLayoutFramesTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
* TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReduce the memory allocations of WebCore's cssPropertyName()
benjamin@webkit.org [Sat, 4 Feb 2012 01:59:41 +0000 (01:59 +0000)]
Reduce the memory allocations of WebCore's cssPropertyName()
https://bugs.webkit.org/show_bug.cgi?id=74782

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-02-03
Reviewed by Geoffrey Garen.

Add a fast path to avoid the use of the StringBuilder.

The string builder is needed for two cases:
-CSS prefix (the character after the prefix must be uppercase)
-JavaScript CamelCase name for CSS properties

We can skip all memory allocations if the property is not in those
two cases. We start by testing the string for uppercase characters,
and just return the an identical string.

This patch create a "fast case" 2.7 times faster than previously.
The "slow case" is 2-3% slower due to the additional check at the beginning.

* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore):
(WebCore::containsASCIIUpperChar):
(WebCore::cssPropertyName):
(WebCore::isCSSPropertyName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2 should dispatch wheel events to the new ScrollingTree class
andersca@apple.com [Sat, 4 Feb 2012 01:56:42 +0000 (01:56 +0000)]
WebKit2 should dispatch wheel events to the new ScrollingTree class
https://bugs.webkit.org/show_bug.cgi?id=77795

Reviewed by Andreas Kling.

Source/WebCore:

* WebCore.exp.in:
Add new symbols needed by WebKit2.

* WebCore.xcodeproj/project.pbxproj:
Make ScrollingTree.h private so it can be included by WebKit2.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::scrollingTree):
* page/scrolling/ScrollingCoordinator.h:
Add a scrolling tree getter.

Source/WebKit2:

Replace all uses of ScrollingCoordinator with ScrollingTree instead.
Also, don't try to handle gesture events on the scrolling thread anymore;
we don't need to to that right now.

* WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::addScrollingTreeForPage):
(WebKit::EventDispatcher::removeScrollingTreeForPage):
(WebKit::EventDispatcher::wheelEvent):
(WebKit::EventDispatcher::gestureEvent):
* WebProcess/WebPage/EventDispatcher.h:
(WebCore):
(EventDispatcher):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::~TiledCoreAnimationDrawingArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] WebCore::toV8Context crashes if DomWindow::frame() returns null.
dslomov@google.com [Sat, 4 Feb 2012 01:45:14 +0000 (01:45 +0000)]
[Chromium] WebCore::toV8Context crashes if DomWindow::frame() returns null.
https://bugs.webkit.org/show_bug.cgi?id=77686.

Reviewed by Adam Barth.

* bindings/v8/V8Helpers.cpp:
(WebCore::toV8Context):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: change exit() calls to sys.exit(), fix a leak in outputcapture
dpranke@chromium.org [Sat, 4 Feb 2012 01:41:14 +0000 (01:41 +0000)]
webkitpy: change exit() calls to sys.exit(), fix a leak in outputcapture
https://bugs.webkit.org/show_bug.cgi?id=77781

Reviewed by Eric Seidel.

This change fixes a couple of issues discovered while debugging
test-webkitpy; both calling exit() instead of sys.exit() --
which is discouraged in program code instead of the interpreter
-- and a particular usage of outputcapture were stdin to get whacked
and preventing debugging.

This change introduces a couple of common _exit() methods that
will standardize how webkit-patch exit's, in case we need to do
something different in the future.

* Scripts/webkitpy/common/system/deprecated_logging.py:
(error):
* Scripts/webkitpy/common/system/outputcapture.py:
(OutputCapture.assert_outputs):
* Scripts/webkitpy/tool/bot/queueengine.py:
(QueueEngine.exit_after_handled_error):
* Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
(AbstractSequencedCommand.execute):
* Scripts/webkitpy/tool/commands/queues.py:
(StyleQueue.handle_script_error):
* Scripts/webkitpy/tool/commands/upload.py:
(MarkBugFixed.execute):
* Scripts/webkitpy/tool/multicommandtool.py:
(Command._exit):
* Scripts/webkitpy/tool/steps/abstractstep.py:
(AbstractStep._exit):
* Scripts/webkitpy/tool/steps/checkstyle.py:
(CheckStyle.run):
* Scripts/webkitpy/tool/steps/commit.py:
(Commit._check_test_expectations):
* Scripts/webkitpy/tool/steps/confirmdiff.py:
(ConfirmDiff.run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThe scrolling tree should be able to handle wheel events
andersca@apple.com [Sat, 4 Feb 2012 01:33:46 +0000 (01:33 +0000)]
The scrolling tree should be able to handle wheel events
https://bugs.webkit.org/show_bug.cgi?id=77794

Reviewed by Andreas Kling.

* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::tryToHandleWheelEvent):
New function. Currently this always returns that it was able to handle the wheel event,
but this will change in the future.

(WebCore::ScrollingTree::handleWheelEvent):
Ask the root node to handle the wheel event.

* page/scrolling/ScrollingTreeNode.h:
Add a handleWheelEvent pure virtual member function.

* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::handleWheelEvent):
Call scrollBy for now. Eventually this should use a scroll elasticity controller to handle
things like rubber-banding.

(WebCore::ScrollingTreeNodeMac::scrollPosition):
(WebCore::ScrollingTreeNodeMac::setScrollPosition):
Add getters and setters for the scroll position.

(WebCore::ScrollingTreeNodeMac::scrollBy):
Update the scroll position given the offset.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agobuildbot fix for curl.
lforschler@apple.com [Sat, 4 Feb 2012 01:32:31 +0000 (01:32 +0000)]
buildbot fix for curl.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2 Mac] No need to allow access to input methods or keyboard layouts
ap@apple.com [Sat, 4 Feb 2012 01:29:14 +0000 (01:29 +0000)]
[WK2 Mac] No need to allow access to input methods or keyboard layouts
https://bugs.webkit.org/show_bug.cgi?id=77775
<rdar://problem/9276253>
<rdar://problem/9276268>

Reviewed by Dan Bernstein.

* WebProcess/com.apple.WebProcess.sb: These rules were likely only necessary in early days
of WebKit2. If there are cases when this happens, that's likely wrong, and we need to know
about that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnother http -> https fix for curl
lforschler@apple.com [Sat, 4 Feb 2012 01:26:01 +0000 (01:26 +0000)]
Another http -> https fix for curl

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in Node::dispatchSubtreeModifiedEvent
rniwa@webkit.org [Sat, 4 Feb 2012 01:22:38 +0000 (01:22 +0000)]
Crash in Node::dispatchSubtreeModifiedEvent
https://bugs.webkit.org/show_bug.cgi?id=77449

Reviewed by Alexey Proskuryakov.

Source/WebCore:

The bug was caused by appendChild not retaining this pointer.
This is normally okay because there's another owner within JSC/V8 binding code that
holds onto the node but this isn't the case when nodes are created as a part
of setting document.title. Fixed the crash by retaining the pointer as needed.

Test: fast/dom/remove-body-during-title-creation.html

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::appendChild):

LayoutTests:

Add a regression test for the crash.

* fast/dom/remove-body-during-title-creation-expected.txt: Added.
* fast/dom/remove-body-during-title-creation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPerf bot build fix.
rniwa@webkit.org [Sat, 4 Feb 2012 01:19:05 +0000 (01:19 +0000)]
Perf bot build fix.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._generate_json):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a blank "Expected Failures" tab to garden-o-matic
abarth@webkit.org [Sat, 4 Feb 2012 01:18:23 +0000 (01:18 +0000)]
Add a blank "Expected Failures" tab to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=77793

Reviewed by Eric Seidel.

This tab will help us explore and manage our expected failures.  The
tab is hidden by default via a new "experimental features" flag.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
(#unexpected):
(#onebar.partytime #unexpected):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix other instances of http://developer links which should be https://developer
lforschler@apple.com [Sat, 4 Feb 2012 01:09:05 +0000 (01:09 +0000)]
Fix other instances of developer links which should be https://developer

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoApply changed properties from the updated scrolling tree state
andersca@apple.com [Sat, 4 Feb 2012 01:05:24 +0000 (01:05 +0000)]
Apply changed properties from the updated scrolling tree state
https://bugs.webkit.org/show_bug.cgi?id=77792

Reviewed by Andreas Kling.

* page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::update):
Update the tree node properties from the scrolling tree state.

* page/scrolling/ScrollingTreeNode.h:
(WebCore::ScrollingTreeNode::scrollingTree):
(WebCore::ScrollingTreeNode::viewportRect):
(WebCore::ScrollingTreeNode::contentsSize):
Add getters.

* page/scrolling/ScrollingTreeState.h:
(WebCore::ScrollingTreeState::changedProperties):
New function for accessing the changed properties of the scrolling tree state.

* page/scrolling/mac/ScrollingTreeNodeMac.h:
* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::update):
Update the scroll layer from the scrolling tree if necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix URL string
lforschler@apple.com [Sat, 4 Feb 2012 00:57:33 +0000 (00:57 +0000)]
Fix URL string

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] Use properly quoted string literals
ap@apple.com [Sat, 4 Feb 2012 00:31:26 +0000 (00:31 +0000)]
[WK2] Use properly quoted string literals
https://bugs.webkit.org/show_bug.cgi?id=77583

Reviewed by Darin Adler.

Also added some FIXMEs.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoupdate-webkit-support-libraries is broken with the change from http to https on devel...
lforschler@apple.com [Sat, 4 Feb 2012 00:29:47 +0000 (00:29 +0000)]
update-webkit-support-libraries is broken with the change from http to https on developer.apple.com
https://bugs.webkit.org/show_bug.cgi?id=77785

Fix the build bots.

Pass the -k and --sslv3 keys to make curl work with https on https://developer.apple.com

* Scripts/update-webkit-support-libs:
(downloadExpectedVersionNumber):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPrefix the typedef in WTF_MAKE_FAST_ALLOCATED with underscores
andersca@apple.com [Sat, 4 Feb 2012 00:24:02 +0000 (00:24 +0000)]
Prefix the typedef in WTF_MAKE_FAST_ALLOCATED with underscores
https://bugs.webkit.org/show_bug.cgi?id=77788

Reviewed by Andreas Kling.

The current typedef name, 'ThisIsHereToForceASemicolonAfterThisMacro', shows up when trying to
code-complete 'this' in Xcode. Prefix the typedef with two underscores to stop this from happening.

* wtf/FastAllocBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106707 268f45cc-cd09-0410-ab3c-d52691b4dbfc