fsamuel@chromium.org [Fri, 12 Aug 2011 18:43:36 +0000 (18:43 +0000)]
Chromium's WebKit API should use floats instead of doubles for zoom to match WebCore
https://bugs.webkit.org/show_bug.cgi?id=66089
Reviewed by Darin Fisher.
* public/WebView.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::zoomLevel):
(WebKit::WebViewImpl::setZoomLevel):
(WebKit::WebViewImpl::zoomLimitsChanged):
(WebKit::WebViewImpl::fullFramePluginZoomLevelChanged):
(WebKit::WebView::zoomLevelToZoomFactor):
(WebKit::WebView::zoomFactorToZoomLevel):
* src/WebViewImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92978
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Fri, 12 Aug 2011 18:42:25 +0000 (18:42 +0000)]
Need to handle kCACFContextNeedsFlushNotification notifications that arrive after the AVFWrapper has been disposed
https://bugs.webkit.org/show_bug.cgi?id=65724
Instead of using a pointer to the AVFWrapper object as the context for various callbacks, assign each object an
ID and use that instead. Keep track of the mapping between object IDs and AVFWrapper objects in a HashMap, and manage
access to this map using a Mutex since it can be accessed from multiple threads. This allows us to actually delete
AVFWrapper objects instead of leaking them (which we were doing before to prevent crashes).
Reviewed by Eric Carlson.
No new tests, uses existing media tests.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::AVFWrapper::callbackContext): Added.
(WebCore::AVFWrapper::AVFWrapper): Initialize m_objectID and add it to the HashMap.
(WebCore::AVFWrapper::~AVFWrapper): Log object ID and remove obsolete assert.
(WebCore::AVFWrapper::mapLock): Added.
(WebCore::AVFWrapper::map): Added.
(WebCore::AVFWrapper::addToMap): Added.
(WebCore::AVFWrapper::removeFromMap): Added.
(WebCore::AVFWrapper::avfWrapperForCallbackContext): Added.
(WebCore::AVFWrapper::scheduleDisconnectAndDelete): Remove AVFWrapper from HashMap instead of zeroing m_owner.
(WebCore::AVFWrapper::disconnectAndDeleteAVFWrapper): Use callbackContext(), delete the AVFWrapper here.
(WebCore::AVFWrapper::createPlayer): Use callbackContext().
(WebCore::AVFWrapper::createPlayerItem): Use callbackContext().
(WebCore::AVFWrapper::periodicTimeObserverCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::notificationCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::loadPlayableCompletionCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::checkPlayability): Use callbackContext().
(WebCore::AVFWrapper::loadMetadataCompletionCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::beginLoadingMetadata): Use callbackContext().
(WebCore::AVFWrapper::seekCompletedCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::seekToTime): Use callbackContext().
(WebCore::AVFWrapper::platformLayer): Remove overly noisy LOG().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92977
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fsamuel@chromium.org [Fri, 12 Aug 2011 18:36:37 +0000 (18:36 +0000)]
Refactoring of PopupMenuChromium
https://bugs.webkit.org/show_bug.cgi?id=66009
Reviewed by Darin Fisher.
Source/WebCore:
Split PopupMenuChromium into three sets of files: PopupMenuChromium.{h|cpp}, PopupContainer.{h|cpp}, and PopupLisBox.{h|cpp}
for readability and maintainability.
No new tests as no functionality has changed.
* WebCore.gypi:
* platform/chromium/PopupContainer.cpp: Added.
(WebCore::constructRelativeMouseEvent):
(WebCore::constructRelativeWheelEvent):
(WebCore::PopupContainer::create):
(WebCore::PopupContainer::PopupContainer):
(WebCore::PopupContainer::~PopupContainer):
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
(WebCore::PopupContainer::showPopup):
(WebCore::PopupContainer::hidePopup):
(WebCore::PopupContainer::notifyPopupHidden):
(WebCore::PopupContainer::layoutAndGetRTLOffset):
(WebCore::PopupContainer::handleMouseDownEvent):
(WebCore::PopupContainer::handleMouseMoveEvent):
(WebCore::PopupContainer::handleMouseReleaseEvent):
(WebCore::PopupContainer::handleWheelEvent):
(WebCore::PopupContainer::handleTouchEvent):
(WebCore::PopupContainer::handleGestureEvent):
(WebCore::PopupContainer::handleKeyEvent):
(WebCore::PopupContainer::hide):
(WebCore::PopupContainer::paint):
(WebCore::PopupContainer::paintBorder):
(WebCore::PopupContainer::isInterestedInEventForKey):
(WebCore::PopupContainer::chromeClientChromium):
(WebCore::PopupContainer::showInRect):
(WebCore::PopupContainer::refresh):
(WebCore::PopupContainer::isRTL):
(WebCore::PopupContainer::selectedIndex):
(WebCore::PopupContainer::menuItemHeight):
(WebCore::PopupContainer::menuItemFontSize):
(WebCore::PopupContainer::menuStyle):
(WebCore::popupData):
(WebCore::PopupContainer::getSelectedItemToolTip):
* platform/chromium/PopupContainer.h: Added.
(WebCore::PopupContainer::listBox):
(WebCore::PopupContainer::popupType):
* platform/chromium/PopupListBox.cpp: Added.
(WebCore::PopupListBox::PopupListBox):
(WebCore::PopupListBox::handleMouseDownEvent):
(WebCore::PopupListBox::handleMouseMoveEvent):
(WebCore::PopupListBox::handleMouseReleaseEvent):
(WebCore::PopupListBox::handleWheelEvent):
(WebCore::PopupListBox::isInterestedInEventForKey):
(WebCore::PopupListBox::handleTouchEvent):
(WebCore::PopupListBox::handleGestureEvent):
(WebCore::isCharacterTypeEvent):
(WebCore::PopupListBox::handleKeyEvent):
(WebCore::PopupListBox::hostWindow):
(WebCore::stripLeadingWhiteSpace):
(WebCore::PopupListBox::typeAheadFind):
(WebCore::PopupListBox::paint):
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowFont):
(WebCore::PopupListBox::abandon):
(WebCore::PopupListBox::pointToRowIndex):
(WebCore::PopupListBox::acceptIndex):
(WebCore::PopupListBox::selectIndex):
(WebCore::PopupListBox::setOriginalIndex):
(WebCore::PopupListBox::getRowHeight):
(WebCore::PopupListBox::getRowBounds):
(WebCore::PopupListBox::invalidateRow):
(WebCore::PopupListBox::scrollToRevealRow):
(WebCore::PopupListBox::isSelectableItem):
(WebCore::PopupListBox::clearSelection):
(WebCore::PopupListBox::selectNextRow):
(WebCore::PopupListBox::selectPreviousRow):
(WebCore::PopupListBox::adjustSelectedIndex):
(WebCore::PopupListBox::hidePopup):
(WebCore::PopupListBox::updateFromElement):
(WebCore::PopupListBox::setMaxWidthAndLayout):
(WebCore::PopupListBox::layout):
(WebCore::PopupListBox::clear):
(WebCore::PopupListBox::isPointInBounds):
* platform/chromium/PopupListBox.h: Added.
(WebCore::PopupItem::PopupItem):
(WebCore::PopupListBox::create):
(WebCore::PopupListBox::selectedIndex):
(WebCore::PopupListBox::numItems):
(WebCore::PopupListBox::setBaseWidth):
(WebCore::PopupListBox::setMaxHeight):
(WebCore::PopupListBox::setMaxWidth):
(WebCore::PopupListBox::disconnectClient):
(WebCore::PopupListBox::items):
(WebCore::PopupListBox::~PopupListBox):
(WebCore::PopupListBox::scrollToRevealSelection):
* platform/chromium/PopupMenuChromium.cpp:
* platform/chromium/PopupMenuChromium.h:
Source/WebKit/chromium:
* src/ChromeClientImpl.cpp:
* src/WebPopupMenuImpl.cpp:
* src/WebViewImpl.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92976
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 12 Aug 2011 17:51:08 +0000 (17:51 +0000)]
Move compiler specific macros to their own header
https://bugs.webkit.org/show_bug.cgi?id=66119
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
Add Compiler.h
* wtf/AlwaysInline.h:
Move the contents of this file (which no longer was just about ALWAYS_INLINE) to
Compiler.h. We can remove this file in a later commit.
* wtf/Compiler.h: Added.
Put all compiler specific checks and features in this file.
* wtf/Platform.h:
Move COMPILER macro and definitions (and the odd WARN_UNUSED_RETURN compiler feature)
to Compiler.h. Include Compiler.h since it is necessary.
Source/JavaScriptGlue:
* ForwardingHeaders/wtf/Compiler.h: Added.
Source/WebCore:
* ForwardingHeaders/wtf/Compiler.h: Added.
Tools:
* DumpRenderTree/ForwardingHeaders/wtf/Compiler.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92974
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Fri, 12 Aug 2011 17:36:18 +0000 (17:36 +0000)]
[Qt][REGRESSION] composited content doesn't render since r92651
https://bugs.webkit.org/show_bug.cgi?id=66108
Reviewed by Benjamin Poulain.
Changed the signature for GraphicsLayerTextureMapper::syncCompositingState to match
the new signature in GraphicsLayer.h.
No new tests. This is a regression that's covered by existing pixel tests.
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::syncCompositingState):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92973
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 12 Aug 2011 17:34:12 +0000 (17:34 +0000)]
Add a way to extend DOM objects in garden-o-matic.
https://bugs.webkit.org/show_bug.cgi?id=66096
Reviewed by Adam Barth.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.extends.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92972
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fsamuel@chromium.org [Fri, 12 Aug 2011 17:28:12 +0000 (17:28 +0000)]
Expose pageScaleFactor in Chromium's WebHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=66139
Reviewed by Darin Fisher.
* public/WebHistoryItem.h:
* src/WebHistoryItem.cpp:
(WebKit::WebHistoryItem::pageScaleFactor):
(WebKit::WebHistoryItem::setPageScaleFactor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92970
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 12 Aug 2011 17:22:25 +0000 (17:22 +0000)]
Original patch by Mihnea Ovidenie <mihnea@adobe.com>.
Also contains some improvements done by Dave Hyatt <hyatt@apple.com>.
[CSSRegions]RenderFlowThread should display its content using RenderRegion
https://bugs.webkit.org/show_bug.cgi?id=65627
Source/WebCore:
RenderFlowThread collects RenderObjects from a flow. These objects are displayed by means
of RenderRegion objects that get the content from the same flow.
Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-12
Reviewed by David Hyatt.
Tests: fast/regions/content-flowed-into-regions-dynamically-added.html
fast/regions/content-flowed-into-regions-dynamically-removed.html
fast/regions/content-flowed-into-regions-with-dyn-index.html
fast/regions/content-flowed-into-regions-with-index-dom.html
fast/regions/content-flowed-into-regions-with-index.html
fast/regions/content-flowed-into-regions.html
fast/regions/flow-content-basic-vertical-rl.html
fast/regions/flow-content-basic-vertical.html
* dom/Node.cpp:
(WebCore::Node::diff):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::createFlowThreadStyle):
(WebCore::RenderFlowThread::styleDidChange):
(WebCore::compareRenderRegions):
(WebCore::RenderFlowThread::addRegionToThread):
(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeLogicalWidth):
(WebCore::RenderFlowThread::computeLogicalHeight):
(WebCore::RenderFlowThread::paintIntoRegion):
* rendering/RenderFlowThread.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::~RenderRegion):
(WebCore::RenderRegion::paint):
(WebCore::RenderRegion::styleDidChange):
* rendering/RenderRegion.h:
(WebCore::RenderRegion::setRegionRect):
(WebCore::RenderRegion::regionRect):
* rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
* rendering/RenderView.cpp:
(WebCore::RenderView::styleDidChange):
(WebCore::RenderView::renderFlowThreadWithName):
* rendering/RenderView.h:
LayoutTests:
Also updated the old tests that expected an 100% by 100% RenderFlowThread. Those tests
require at least a region attached, otherwise the RenderFlowThread would have been 0/0 in size,
and no output would be generated for them in the render tree.
The attached regions are now printed in the render tree, so some tests required updated results.
Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-12
Reviewed by David Hyatt.
* fast/regions/content-flowed-into-regions-dynamically-added-expected.png: Added.
* fast/regions/content-flowed-into-regions-dynamically-added-expected.txt: Added.
* fast/regions/content-flowed-into-regions-dynamically-added.html: Added.
* fast/regions/content-flowed-into-regions-dynamically-removed-expected.png: Added.
* fast/regions/content-flowed-into-regions-dynamically-removed-expected.txt: Added.
* fast/regions/content-flowed-into-regions-dynamically-removed.html: Added.
* fast/regions/content-flowed-into-regions-expected.png: Added.
* fast/regions/content-flowed-into-regions-expected.txt: Added.
* fast/regions/content-flowed-into-regions-with-dyn-index-expected.png: Added.
* fast/regions/content-flowed-into-regions-with-dyn-index-expected.txt: Added.
* fast/regions/content-flowed-into-regions-with-dyn-index.html: Added.
* fast/regions/content-flowed-into-regions-with-index-dom-expected.png: Added.
* fast/regions/content-flowed-into-regions-with-index-dom-expected.txt: Added.
* fast/regions/content-flowed-into-regions-with-index-dom.html: Added.
* fast/regions/content-flowed-into-regions-with-index-expected.png: Added.
* fast/regions/content-flowed-into-regions-with-index-expected.txt: Added.
* fast/regions/content-flowed-into-regions-with-index.html: Added.
* fast/regions/content-flowed-into-regions.html: Added.
* fast/regions/flow-content-basic-vertical-rl.html: Copied from LayoutTests/fast/regions/flow-content-basic.html.
* fast/regions/flow-content-basic-vertical.html: Copied from LayoutTests/fast/regions/flow-content-basic.html.
* fast/regions/flow-content-basic.html:
* fast/regions/render-region-renderer-expected.txt:
* fast/regions/resources/region-style.css: Added.
(.greenBox):
(.blueBox):
(.orangeBox):
(.flowArticle):
(.regionArticle):
(.borderBox):
* fast/regions/webkit-flow-renderer-expected.txt:
* fast/regions/webkit-flow-renderer-layer-expected.txt:
* fast/regions/webkit-flow-renderer-layer.html:
* fast/regions/webkit-flow-renderer-nested-expected.txt:
* fast/regions/webkit-flow-renderer-nested.html:
* fast/regions/webkit-flow-renderer.html:
* platform/mac/fast/regions/flow-content-basic-expected.png: Added.
* platform/mac/fast/regions/flow-content-basic-expected.txt: Added.
* platform/mac/fast/regions/flow-content-basic-vertical-expected.png: Added.
* platform/mac/fast/regions/flow-content-basic-vertical-expected.txt: Added.
* platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.png: Added.
* platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92969
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Fri, 12 Aug 2011 16:27:57 +0000 (16:27 +0000)]
Crash in WebCore::editingIgnoresContent
https://bugs.webkit.org/show_bug.cgi?id=66125
Reviewed by Ryosuke Niwa.
Source/WebCore:
RefPtr a few nodes in case they get blown away in
dispatchEvent calls.
Test: editing/selection/select-start-remove-root-crash.html
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::selectAll):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
LayoutTests:
Tests that we do not crash when we blow away the root
during the firing of selectstart event in selection.
* editing/selection/select-start-remove-root-crash-expected.txt: Added.
* editing/selection/select-start-remove-root-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92966
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
nduca@chromium.org [Fri, 12 Aug 2011 16:26:39 +0000 (16:26 +0000)]
[chromium] Add WebThread to WebKitClient
https://bugs.webkit.org/show_bug.cgi?id=66013
Reviewed by Darin Fisher.
* public/WebKitClient.h:
(WebKit::WebKitClient::createThread):
* public/WebThread.h: Added.
(WebKit::WebThread::~WebThread):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92965
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Fri, 12 Aug 2011 15:34:08 +0000 (15:34 +0000)]
Web Inspector: properly update console message count in source frames and resources panel.
https://bugs.webkit.org/show_bug.cgi?id=57009
Reviewed by Yury Semikhatsky.
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageRepeatCountUpdated):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.show):
(WebInspector.SourceFrame.prototype.addMessageToSource):
(WebInspector.SourceFrame.prototype._updateMessageRepeatCount):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92964
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Fri, 12 Aug 2011 15:15:16 +0000 (15:15 +0000)]
[Qt] Add test for correct order of load signals in QWebPage
https://bugs.webkit.org/show_bug.cgi?id=66016
Reviewed by Benjamin Poulain.
Add API test to ensure the order of load signals: loadStarted() needs to be emitted
first, then loadProgress(100), followed by loadFinished().
The test is skipped since this right now is broken, the bug
https://bugs.webkit.org/show_bug.cgi?id=28851 tracks one possible way to fix.
* tests/qwebpage/tst_qwebpage.cpp:
(SpyForLoadSignalsOrder::SpyForLoadSignalsOrder):
(SpyForLoadSignalsOrder::isFinished):
(SpyForLoadSignalsOrder::onLoadProgress):
(tst_QWebPage::loadSignalsOrder_data):
(tst_QWebPage::loadSignalsOrder):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92963
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 12 Aug 2011 14:56:04 +0000 (14:56 +0000)]
2011-08-12 Pavel Feldman <pfeldman@google.com>
Not reviewed: follow up to inspector test breakage.
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._showScriptFoldersSettingChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92962
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 12 Aug 2011 14:50:47 +0000 (14:50 +0000)]
Web Inspector: expand exception properties when wrapping it as object.
https://bugs.webkit.org/show_bug.cgi?id=66035
Source/WebCore:
Use toString() value as a description for value thrown during eval.
Reviewed by Pavel Feldman.
* inspector/InjectedScriptSource.js:
(.):
LayoutTests:
Reviewed by Pavel Feldman.
* inspector/console/console-eval-global-expected.txt:
* inspector/console/console-eval-syntax-error-expected.txt:
* inspector/console/console-eval-undefined-override-expected.txt:
* inspector/extensions/extensions-eval-expected.txt:
* inspector/runtime/runtime-setPropertyValue-expected.txt:
* platform/chromium/inspector/console/console-eval-global-expected.txt:
* platform/chromium/inspector/console/console-eval-syntax-error-expected.txt:
* platform/chromium/inspector/console/console-eval-undefined-override-expected.txt:
* platform/chromium/inspector/debugger/debugger-activation-crash2-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92961
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Fri, 12 Aug 2011 14:33:34 +0000 (14:33 +0000)]
[Qt] Make sure QtWebKit correctly compiles when building WebKit2 with Qt5.
In order to build correctly the QtQuick1 plugin we need to explicitly
link to the new library added in Qt5 "qtquick1".
Reviewed by Simon Hausmann.
* declarative/declarative.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92960
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreip@google.com [Fri, 12 Aug 2011 14:05:53 +0000 (14:05 +0000)]
2011-08-12 Andrei Popescu <andreip@google.com>
[Chromium] Rebaseline these tests on Leopard.
Unreviewed gardening.
* LayoutTests/platform/chromium-linux/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
* LayoutTests/platform/chromium-mac-leopard/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
* LayoutTests/platform/chromium-mac-leopard/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
* LayoutTests/platform/chromium-mac/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
* LayoutTests/platform/chromium-mac/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
* LayoutTests/platform/chromium-win-xp/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
* LayoutTests/platform/chromium-win/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
* LayoutTests/platform/chromium-win/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92959
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 12 Aug 2011 13:54:10 +0000 (13:54 +0000)]
Web Inspector: make folders optional in the Scripts' panel file selector.
https://bugs.webkit.org/show_bug.cgi?id=66100
Reviewed by Yury Semikhatsky.
Source/WebCore:
* English.lproj/localizedStrings.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._showScriptFoldersSettingChanged):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered.optionCompare):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.prototype.reset):
(WebInspector.ScriptsPanel.prototype._resetFilesSelect):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):
LayoutTests:
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/scripts-sorting-expected.txt:
* inspector/debugger/scripts-sorting.html:
* platform/chromium/inspector/debugger/scripts-sorting-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92958
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Fri, 12 Aug 2011 13:03:09 +0000 (13:03 +0000)]
Web Inspector: add space between error info and error message in source frame message bubble.
https://bugs.webkit.org/show_bug.cgi?id=65069
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleMessage.prototype._formatMessage):
LayoutTests:
* http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
* inspector/debugger/source-frame-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92957
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 12 Aug 2011 12:56:28 +0000 (12:56 +0000)]
Web Inspector: console loses focus upon reloading the page from the inspector.
https://bugs.webkit.org/show_bug.cgi?id=66068
Reviewed by Yury Semikhatsky.
Source/WebCore:
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel.prototype._auditFinishedCallback):
(WebInspector.AuditsPanel.prototype._clearButtonClicked):
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype.revealAndSelect):
(WebInspector.DataGridNode.prototype.revealAndSelect):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._jumpToSearchResult):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.this.treeOutline.selectedNodeChanged):
(WebInspector.ElementsPanel.get this):
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._reset):
(WebInspector.ElementsPanel.prototype._setDocument.selectNode):
(WebInspector.ElementsPanel.prototype._setDocument.selectLastSelectedNode):
(WebInspector.ElementsPanel.prototype._setDocument):
(WebInspector.ElementsPanel.prototype._domWordWrapSettingChanged):
(WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
(WebInspector.ElementsPanel.prototype.switchToAndFocus):
(WebInspector.ElementsPanel.prototype.selectedDOMNode):
(WebInspector.ElementsPanel.prototype.selectDOMNode):
(WebInspector.ElementsPanel.prototype.updateModifiedNodes):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb.selectCrumbFunction):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
(WebInspector.ElementsPanel.prototype.updateStyles):
(WebInspector.ElementsPanel.prototype.updateMetrics):
(WebInspector.ElementsPanel.prototype.updateProperties):
(WebInspector.ElementsPanel.prototype.updateEventListeners):
(WebInspector.ElementsPanel.prototype.handleCopyEvent):
(WebInspector.ElementsPanel.prototype.updateFocusedNode):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline):
(WebInspector.ElementsTreeOutline.prototype.selectedDOMNode):
(WebInspector.ElementsTreeOutline.prototype.selectDOMNode):
(WebInspector.ElementsTreeOutline.prototype.update):
(WebInspector.ElementsTreeOutline.prototype._revealAndSelectNode):
(WebInspector.ElementsTreeOutline.prototype._ondrop.callback):
(WebInspector.ElementsTreeOutline.prototype._ondrop):
(WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
(WebInspector.ElementsTreeElement.prototype._updateChildren):
(WebInspector.ElementsTreeElement.prototype.onselect):
(WebInspector.ElementsTreeElement.prototype.selectOnMouseDown):
(WebInspector.ElementsTreeElement.prototype._startEditingTarget):
(WebInspector.ElementsTreeElement.prototype._startEditing):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.reset):
* inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileView.prototype._jumpToSearchResult):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._addProfileHeader):
(WebInspector.ProfilesPanel.prototype.showProfile):
(WebInspector.ProfileSidebarTreeElement.prototype.onselect):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._initDefaultSelection.get if):
(WebInspector.ResourcesPanel.prototype._initDefaultSelection):
(WebInspector.ResourcesPanel.prototype.reset):
(WebInspector.ResourcesPanel.prototype.showResource):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._createTopPane):
* inspector/front-end/inspector.js:
* inspector/front-end/inspectorCommon.css:
(body):
* inspector/front-end/treeoutline.js:
(TreeOutline.prototype.revealAndSelect):
(TreeElement.prototype.selectOnMouseDown):
(TreeElement.prototype.revealAndSelect):
(TreeElement.prototype.select):
LayoutTests:
* inspector/console/command-line-api-inspect.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92956
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 12 Aug 2011 12:17:09 +0000 (12:17 +0000)]
Source/WebCore: Add HTMLUnknownElement interface as defined in
http://www.w3.org/TR/html5/elements.html#elements-in-the-dom.
https://bugs.webkit.org/show_bug.cgi?id=41841
Unreviewed gardening after r92890.
* platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: Updated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92955
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 12 Aug 2011 12:06:50 +0000 (12:06 +0000)]
2011-08-12 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Inspector clean-up: remove unused method declaration from InspectorAgent.h
* inspector/InspectorAgent.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92954
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Fri, 12 Aug 2011 11:44:55 +0000 (11:44 +0000)]
Web Inspector: Network resource identifier should have RequestId type and requestId name in protocol.
https://bugs.webkit.org/show_bug.cgi?id=66061
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::ConsoleMessage):
(WebCore::ConsoleMessage::addToFrontend):
* inspector/ConsoleMessage.h:
* inspector/IdentifiersFactory.cpp:
(WebCore::IdentifiersFactory::requestId):
* inspector/IdentifiersFactory.h:
* inspector/Inspector.json:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::markResourceAsCached):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::didFinishLoading):
(WebCore::InspectorResourceAgent::didFailLoading):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::setInitialScriptContent):
(WebCore::InspectorResourceAgent::didReceiveScriptResponse):
(WebCore::InspectorResourceAgent::setInitialXHRContent):
(WebCore::InspectorResourceAgent::didReceiveXHRResponse):
(WebCore::InspectorResourceAgent::didCreateWebSocket):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorResourceAgent::didCloseWebSocket):
(WebCore::InspectorResourceAgent::getResourceContent):
* inspector/InspectorResourceAgent.h:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::willReceiveResourceData):
(WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
(WebCore::InspectorTimelineAgent::didFinishLoadingResource):
* inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::resourceCreated):
(WebCore::NetworkResourcesData::responseReceived):
(WebCore::NetworkResourcesData::setResourceType):
(WebCore::NetworkResourcesData::resourceType):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::maybeAddResourceData):
(WebCore::NetworkResourcesData::maybeDecodeDataToContent):
(WebCore::NetworkResourcesData::addCachedResource):
(WebCore::NetworkResourcesData::addResourceSharedBuffer):
(WebCore::NetworkResourcesData::data):
(WebCore::NetworkResourcesData::clear):
(WebCore::NetworkResourcesData::ensureNoDataForRequestId):
(WebCore::NetworkResourcesData::ensureFreeSpace):
* inspector/NetworkResourcesData.h:
(WebCore::NetworkResourcesData::ResourceData::requestId):
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createResourceSendRequestData):
(WebCore::TimelineRecordFactory::createResourceReceiveResponseData):
(WebCore::TimelineRecordFactory::createResourceFinishData):
(WebCore::TimelineRecordFactory::createReceiveResourceData):
* inspector/TimelineRecordFactory.h:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded):
* inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI.Resources.prototype.getHAR):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._notifyResourceFinished):
(WebInspector.ExtensionServer.prototype._onGetHAR):
(WebInspector.ExtensionServer.prototype._requestId):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype.requestContent):
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.resourceMarkedAsCached):
(WebInspector.NetworkDispatcher.prototype.responseReceived):
(WebInspector.NetworkDispatcher.prototype.dataReceived):
(WebInspector.NetworkDispatcher.prototype.loadingFinished):
(WebInspector.NetworkDispatcher.prototype.loadingFailed):
(WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
(WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):
(WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):
(WebInspector.NetworkDispatcher.prototype.webSocketClosed):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
(WebInspector.NetworkDispatcher.prototype._startResource):
(WebInspector.NetworkDispatcher.prototype._finishResource):
(WebInspector.NetworkDispatcher.prototype._createResource):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._appendResource):
(WebInspector.NetworkLogView.prototype._matchResource):
(WebInspector.NetworkLogView.prototype._updateSearchMatchedListAfterRequestIdChanged):
(WebInspector.NetworkLogView.prototype.performSearch):
* inspector/front-end/Resource.js:
(WebInspector.Resource):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._addRecordToTimeline):
(WebInspector.TimelinePanel.prototype._findParentRecord):
(WebInspector.TimelinePanel.FormattedRecord):
LayoutTests:
* http/tests/inspector/network/download.html:
* http/tests/inspector/network/x-frame-options-deny.html:
* inspector/timeline/timeline-load.html:
* inspector/timeline/timeline-network-resource-expected.txt:
* inspector/timeline/timeline-network-resource.html:
* inspector/timeline/timeline-test.js:
* platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92953
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 12 Aug 2011 10:57:12 +0000 (10:57 +0000)]
Source/WebCore: Add HTMLUnknownElement interface as defined in
http://www.w3.org/TR/html5/elements.html#elements-in-the-dom.
https://bugs.webkit.org/show_bug.cgi?id=41841
Unreviewed gardening after r92890.
* fast/html/unknown-tag-expected.txt: Added.
* platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Updated.
* platform/qt/fast/dom/prototype-inheritance-2-expected.png: Updated.
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt: Updated.
* platform/qt/fast/js/global-constructors-expected.txt: Updated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92952
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Fri, 12 Aug 2011 09:32:32 +0000 (09:32 +0000)]
IndexedDB: Object store records don't need to have keys in all indexes
https://bugs.webkit.org/show_bug.cgi?id=66049
Reviewed by Tony Chang.
Source/WebCore:
Allow inserting records in an object store even though they don't
yield keys in some index. The spec has changed in this regard.
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::putInternal):
LayoutTests:
Update test to make sure it's possible to add an object store record
even though it doesn't yield keys in every index.
* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/index-basics.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92951
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Fri, 12 Aug 2011 08:51:14 +0000 (08:51 +0000)]
IndexedDB: Overwriting key in unique index should be possible
https://bugs.webkit.org/show_bug.cgi?id=65993
Reviewed by Tony Chang.
Source/WebCore:
It should be possible to overwrite an object store record even if
there is a derived key for that record in an index with the unique flag set.
* storage/IDBBackingStore.h:
* storage/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::addingKeyAllowed):
* storage/IDBIndexBackendImpl.h:
* storage/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
* storage/IDBLevelDBBackingStore.h:
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::putInternal):
* storage/IDBSQLiteBackingStore.cpp:
(WebCore::IDBSQLiteBackingStore::keyExistsInIndex):
* storage/IDBSQLiteBackingStore.h:
LayoutTests:
Test that it's possible to overwrite an object store record even if there
is a derived key for that record in an index with the unique flag set.
* storage/indexeddb/index-unique-expected.txt:
* storage/indexeddb/index-unique.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92950
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 12 Aug 2011 07:52:24 +0000 (07:52 +0000)]
[EFL] Fix after r91815 - restore changes from r91659.
https://bugs.webkit.org/show_bug.cgi?id=64682
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-12
Reviewed by Kenneth Rohde Christiansen.
Restore patch for fix ewk_view_context_menu_forward_event which
has been overwrititen by mistake.
* ewk/ewk_view.cpp:
(ewk_view_context_menu_forward_event):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92949
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 12 Aug 2011 07:46:13 +0000 (07:46 +0000)]
[EFL] HTML Saving feature.
https://bugs.webkit.org/show_bug.cgi?id=55455
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-12
Reviewed by Antonio Gomes.
Gets the source and location of resources for document.
TODO:
1. Support others resources (css, plugins, media files).
2. Currently only HTML documents are supported.
* ewk/ewk_frame.cpp:
(ewk_frame_source_get):
(ewk_frame_resources_location_get):
* ewk/ewk_frame.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92948
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Fri, 12 Aug 2011 06:44:53 +0000 (06:44 +0000)]
WebSocket: Implement "protocol" attribute
https://bugs.webkit.org/show_bug.cgi?id=65248
Reviewed by Kent Tamura.
Source/WebCore:
Tests: http/tests/websocket/tests/hybi/no-subprotocol.html (added)
http/tests/websocket/tests/hybi/set-protocol.html (added)
http/tests/websocket/tests/hybi/workers/no-subprotocol.html (added)
http/tests/websocket/tests/hixie76/undefined-attributes.html (updated)
http/tests/websocket/tests/hybi/multiple-subprotocols.html (updated)
http/tests/websocket/tests/hybi/workers/multiple-subprotocols.html (updated)
* websockets/ThreadableWebSocketChannel.h:
Added subprotocol() function. This function is named differently from the counterpart of
WebSocket class, because the name "protocol" can be confused with the WebSocket protocol.
Added m_useHixie76Protocol and m_subprotocol, because these value may be used after
m_channel has been released. Using bool should be fine, because boolean literals do not
appear in ambiguous context.
* websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::subprotocol):
(WebCore::ThreadableWebSocketChannelClientWrapper::setSubprotocol):
* websockets/ThreadableWebSocketChannelClientWrapper.h:
* websockets/WebSocket.cpp:
(WebCore::WebSocket::WebSocket):
(WebCore::WebSocket::connect):
(WebCore::WebSocket::protocol):
The "protocol" attribute is available only when the hybi-10 protocol is chosen.
(WebCore::WebSocket::binaryType):
(WebCore::WebSocket::setBinaryType):
(WebCore::WebSocket::didConnect):
* websockets/WebSocket.h:
* websockets/WebSocket.idl:
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::subprotocol):
* websockets/WebSocketChannel.h:
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::subprotocol):
(WebCore::workerContextDidConnect):
Subprotocol value is saved in the client wrapper object after the WebSocket connection is
established.
(WebCore::WorkerThreadableWebSocketChannel::Peer::didConnect):
* websockets/WorkerThreadableWebSocketChannel.h:
LayoutTests:
* http/tests/websocket/tests/hixie76/undefined-attributes-expected.txt:
* http/tests/websocket/tests/hixie76/undefined-attributes.html:
Added a test to check "protocol" attribute.
* http/tests/websocket/tests/hybi/multiple-subprotocols-expected.txt:
* http/tests/websocket/tests/hybi/multiple-subprotocols.html:
The attribute should return an empty string at first. After the connection is established,
it should return the value of Sec-WebSocket-Protocol header in the server's handshake response.
* http/tests/websocket/tests/hybi/no-subprotocol-expected.txt: Added.
* http/tests/websocket/tests/hybi/no-subprotocol.html: Added.
* http/tests/websocket/tests/hybi/set-protocol-expected.txt: Added.
* http/tests/websocket/tests/hybi/set-protocol.html: Added.
* http/tests/websocket/tests/hybi/workers/multiple-subprotocols-expected.txt:
* http/tests/websocket/tests/hybi/workers/no-subprotocol-expected.txt: Added.
* http/tests/websocket/tests/hybi/workers/no-subprotocol.html: Added.
* http/tests/websocket/tests/hybi/workers/resources/multiple-subprotocols.js:
(ws.onopen):
(ws.onclose):
(checkAfterOnClose):
* http/tests/websocket/tests/hybi/workers/resources/no-subprotocol.js: Added.
(ws.onopen):
(ws.onclose):
(checkAfterOnClose):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92946
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 12 Aug 2011 05:38:41 +0000 (05:38 +0000)]
[Chromium][DRT] editing/spelling/spelling-backspace-between-lines.html fails
https://bugs.webkit.org/show_bug.cgi?id=45438
Reviewed by Kent Tamura.
Tools:
MockSpellCheck was assuming the input of spellCheckWord() is a word.
But it can be a series of word. This change made spellCheckWord()
understand simple word boundary which appears in tests.
* DumpRenderTree/chromium/MockSpellCheck.cpp:
(MockSpellCheck::spellCheckWord):
LayoutTests:
Added a chromium specific expectation because chromium will use window's (wrong) expectation
unless chromium has its own.
* platform/chromium/editing/spelling/spelling-backspace-between-lines-expected.txt: Added
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92928
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Fri, 12 Aug 2011 05:18:28 +0000 (05:18 +0000)]
Implement proper handling of events with a related target in regard to shadow DOM boundaries.
https://bugs.webkit.org/show_bug.cgi?id=65899
Reviewed by Dimitri Glazkov.
Fixes issues in the following corner cases:
1. When both a target node and a relatedTarget node are immediate children of
the same shadow root, an event is not dispatched.
2. If a target node is an ancestor of a relatedTarget node, crossing
shadow boundaries, or vice verse, an event is not dispatched or wrongly
dispatched.
Source/WebCore:
Test: fast/dom/shadow/shadow-boundary-events.html
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::adjustToShadowBoundaries):
LayoutTests:
* fast/dom/shadow/shadow-boundary-crossing-expected.txt: Renamed from LayoutTests/fast/events/shadow-boundary-crossing-expected.txt.
* fast/dom/shadow/shadow-boundary-crossing.html: Renamed from LayoutTests/fast/events/shadow-boundary-crossing.html.
* fast/dom/shadow/shadow-boundary-events-expected.txt: Added.
* fast/dom/shadow/shadow-boundary-events.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92922
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 12 Aug 2011 04:16:55 +0000 (04:16 +0000)]
VectorArgumentCoder doesn't encode/decode enough data for more than one byte vector elements
https://bugs.webkit.org/show_bug.cgi?id=66109
Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-08-11
Reviewed by Anders Carlsson.
Multiply vector size by element size in encode/decode to get correct byte size of vector data.
* Platform/CoreIPC/ArgumentCoders.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92914
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Fri, 12 Aug 2011 04:09:42 +0000 (04:09 +0000)]
DFG JIT-specific structure stub info code offset fields are signed
8-bit, but it is possible for the offsets to be greater than 127
https://bugs.webkit.org/show_bug.cgi?id=66122
Reviewed by Gavin Barraclough.
* bytecode/StructureStubInfo.h:
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92911
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Fri, 12 Aug 2011 03:41:48 +0000 (03:41 +0000)]
DFG JIT speculation failure code sometimes picks the wrong register
as a scratch register.
https://bugs.webkit.org/show_bug.cgi?id=66104
Reviewed by Gavin Barraclough.
Hardened the code with more assertions and fixed the bug. Now a
spilled register is only used for scratch if it also isn't being
used for shuffling.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::ShuffledRegister::handleNonCyclingPermutation):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92909
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 12 Aug 2011 03:32:16 +0000 (03:32 +0000)]
Readback composited webgl results for printing
https://bugs.webkit.org/show_bug.cgi?id=65658
Patch by John Bauman <jbauman@chromium.org> on 2011-08-11
Reviewed by James Robinson.
Source/WebCore:
The real composited results may be locked inside the compositor
context's version of a texture because the drawing buffer was
automatically cleared, so read from there to get the actual presented
version to draw.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/chromium/Extensions3DChromium.h:
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas):
* platform/graphics/chromium/WebGLLayerChromium.h:
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):
Source/WebKit/chromium:
Add support for reading from the composited version of a canvas.
* public/WebGraphicsContext3D.h:
* src/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::paintFramebufferToCanvas):
* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::paintFramebufferToCanvas):
(WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DInternal::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3DInternal::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3DInternal::reshape):
* src/GraphicsContext3DInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92908
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 12 Aug 2011 03:14:32 +0000 (03:14 +0000)]
REGRESSION: Qt JavaScript bridge signal connection fails
https://bugs.webkit.org/show_bug.cgi?id=66097
Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-08-11
Reviewed by Gavin Barraclough.
Source/WebCore:
Tests in WebKit/qt/tests/qwebframe
Call toThisObject() on exec->lexicalGlobalObject() so the correct
object is passed to the JS signal handler.
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeConnectionMethod::call):
Source/WebKit/qt:
Unmark tests as expected failures, they pass now.
* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::connectAndDisconnect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92907
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Fri, 12 Aug 2011 03:00:05 +0000 (03:00 +0000)]
Remove incorrect comment about m_wheelEventHandlerCount
https://bugs.webkit.org/show_bug.cgi?id=66117
Reviewed by Simon Fraser.
From what I can tell, this number is changed only in
Frame::notifyChromeClientWheelEventHandlerCountChanged(),
and there it just reads the number modified in
Document::didAdd/RemoveWheelEventHandler(). So this is just the number
of event handlers (and not related to horizontal scrollbars), and the
variable name expresses that already.
Source/WebCore:
* dom/Document.h:
Source/WebKit2:
* UIProcess/WebPageProxy.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 12 Aug 2011 02:54:18 +0000 (02:54 +0000)]
Versioning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92905
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 12 Aug 2011 02:48:06 +0000 (02:48 +0000)]
Unreviewed, rolling out r92880.
http://trac.webkit.org/changeset/92880
https://bugs.webkit.org/show_bug.cgi?id=66123
Breaks compile in VS2010 (Requested by jamesr_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-11
* wtf/PassRefPtr.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92903
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 12 Aug 2011 02:11:26 +0000 (02:11 +0000)]
Fix sunspider-compare-results to default to the same suite version as the sunspider script.
Rubber-stamped by Maciej Stachowiak.
* sunspider-compare-results:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92902
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 12 Aug 2011 02:11:22 +0000 (02:11 +0000)]
Don't conditionalize the use of -fomit-frame-pointer on compiler version as
all of our supported compilers are now new enough to have the same, sane behavior.
Rubber-stamped by Sam Weinig.
* Configurations/JavaScriptCore.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92901
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 12 Aug 2011 02:07:24 +0000 (02:07 +0000)]
[chromium] Defer managed texture creation and destruction until updateCompositorResources
https://bugs.webkit.org/show_bug.cgi?id=64772
Patch by James Robinson <jamesr@chromium.org> on 2011-08-11
Reviewed by Kenneth Russell.
This adds support for deferring GraphicsContext3D calls for texture creation and destruction for managed
textures and defers these calls until updateCompositorResources() for contents textures. The primary benefit of
this change is that it decouples managing the texture budget for the next frame (which has to happen before
painting layer contents) from the actual GL calls that create/destroy textures. That way, in the threaded
compositing world we can continue to use textures from the previous frame while software painting contents for
the next frame into software buffers or SkPictures.
Also renames LayerTexture to ManagedTexture to better reflect what it is. Not all ManagedTextures we create are
necessarily associated with layers, but they are all managed by a TextureManager.
Covered by compositing/ layout tests.
* WebCore.gypi:
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::updateTextureRect):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::releaseTextures):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::getOffscreenLayerTexture):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::initializeSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/LayerTextureUpdater.h:
* platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
(WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
* platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::getSingleTexture):
(WebCore::LayerTilerChromium::createTile):
(WebCore::LayerTilerChromium::updateRect):
(WebCore::LayerTilerChromium::drawTiles):
* platform/graphics/chromium/LayerTilerChromium.h:
(WebCore::LayerTilerChromium::Tile::Tile):
(WebCore::LayerTilerChromium::Tile::texture):
* platform/graphics/chromium/ManagedTexture.cpp: Renamed from Source/WebCore/platform/graphics/chromium/LayerTexture.cpp.
(WebCore::ManagedTexture::ManagedTexture):
(WebCore::ManagedTexture::~ManagedTexture):
(WebCore::ManagedTexture::isValid):
(WebCore::ManagedTexture::reserve):
(WebCore::ManagedTexture::unreserve):
(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):
* platform/graphics/chromium/ManagedTexture.h: Renamed from Source/WebCore/platform/graphics/chromium/LayerTexture.h.
(WebCore::ManagedTexture::create):
(WebCore::ManagedTexture::format):
(WebCore::ManagedTexture::isReserved):
* platform/graphics/chromium/RenderSurfaceChromium.h:
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::TextureManager):
(WebCore::TextureManager::deleteEvictedTextures):
(WebCore::TextureManager::removeTexture):
(WebCore::TextureManager::allocateTexture):
(WebCore::TextureManager::requestTexture):
* platform/graphics/chromium/TextureManager.h:
(WebCore::TextureManager::create):
(WebCore::TextureManager::setAssociatedContextDebugOnly):
(WebCore::TextureManager::associatedContextDebugOnly):
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::prepareContentsTexture):
(WebCore::CCRenderSurface::drawSurface):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore::CCRenderSurface::contentsTexture):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::bindContentsTexture):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92900
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Fri, 12 Aug 2011 00:52:28 +0000 (00:52 +0000)]
<webkit.org/b/66113> [CFNetwork] willCacheResponse() leaks CFCachedURLResponseRef if delegate changes CacheStoragePolicy
Reviewed by Joseph Pecoraro.
This first appeared in ToT WebKit r23462 (Windows merge).
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willCacheResponse): Only retain cachedResponse if we
are returning the same object passed into the method, otherwise
we end up double-retaining the new object created.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92897
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 12 Aug 2011 00:45:08 +0000 (00:45 +0000)]
Rework some Makefile logic to remove a double-negative.
Reviewed by Jon Honeycutt.
* DumpRenderTree/mac/PerlSupport/Makefile:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92896
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
nduca@chromium.org [Fri, 12 Aug 2011 00:22:52 +0000 (00:22 +0000)]
[chromium] Make WebViewImpl point at CCLayerTreeHost and related separation
https://bugs.webkit.org/show_bug.cgi?id=65791
With this patch, LayerRendererChromium becomes increasingly responsible
for rendering, while render scheduling and tree hosting moves into the
CCLayerTreeHost.
Reviewed by James Robinson.
Source/WebCore:
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::releaseTextures):
(WebCore::LayerRendererChromium::updateRootLayerContents):
(WebCore::LayerRendererChromium::drawRootLayer):
(WebCore::LayerRendererChromium::invalidateRootLayerRect):
(WebCore::LayerRendererChromium::rootLayerChanged):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::getFramebufferPixels):
(WebCore::LayerRendererChromium::getOffscreenLayerTexture):
(WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::setScissorToRect):
(WebCore::LayerRendererChromium::layerTreeAsText):
(WebCore::LayerRendererChromium::dumpRenderSurfaces):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::settings):
(WebCore::LayerRendererChromium::owner):
(WebCore::LayerRendererChromium::rootLayer):
(WebCore::LayerRendererChromium::skiaContext):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::setTextureUpdated):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
(WebCore::CCHeadsUpDisplay::enabled):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::create):
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::animateAndLayout):
(WebCore::CCLayerTreeHost::createLayerTreeHostCommitter):
(WebCore::CCLayerTreeHost::createLayerTreeHostImpl):
(WebCore::CCLayerTreeHost::context):
(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::createRootLayerPainter):
(WebCore::CCLayerTreeHost::finishAllRendering):
(WebCore::CCLayerTreeHost::invalidateRootLayerRect):
(WebCore::CCLayerTreeHost::setNeedsCommitAndRedraw):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
(WebCore::CCLayerTreeHost::setRootLayer):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::doComposite):
(WebCore::CCLayerTreeHost::composite):
(WebCore::CCLayerTreeHost::reallocateRenderer):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::animating):
(WebCore::CCLayerTreeHost::setAnimating):
(WebCore::CCLayerTreeHost::rootLayer):
(WebCore::CCLayerTreeHost::settings):
(WebCore::CCLayerTreeHost::viewportContentRect):
(WebCore::CCLayerTreeHost::viewportScrollPosition):
(WebCore::CCLayerTreeHost::viewportVisibleRect):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::create):
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::drawLayersOnMainThread):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:
(WebCore::CCLayerTreeHostImplProxy::initImplOnCCThread):
Source/WebKit/chromium:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::doPixelReadbackToCanvas):
(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::setRootPlatformLayer):
(WebKit::WebViewImpl::setRootLayerNeedsDisplay):
(WebKit::WebViewImpl::scrollRootLayerRect):
(WebKit::WebViewImpl::invalidateRootLayerRect):
(WebKit::getCompositorSettings):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::createRootLayerPainter):
(WebKit::WebViewImpl::animateAndLayout):
(WebKit::WebViewImpl::didRecreateGraphicsContext):
(WebKit::WebViewImpl::scheduleComposite):
(WebKit::WebViewImpl::updateLayerTreeViewport):
(WebKit::WebViewImpl::graphicsContext3D):
(WebKit::WebViewImpl::setVisibilityState):
* src/WebViewImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92895
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Fri, 12 Aug 2011 00:20:09 +0000 (00:20 +0000)]
WebCore::AVFWrapper fails to remove observer for kCACFContextNeedsFlushNotification
https://bugs.webkit.org/show_bug.cgi?id=66116
We need to pass 0 as the object parameter to CFNotificationCenterRemoveObserver() when removing
kCACFContextNeedsFlushNotification to match what we do when we registered for the same
notification with CFNotificationCenterAddObserver().
Reviewed by John Sullivan.
No new tests, uses existing media tests.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::AVFWrapper::disconnectAndDeleteAVFWrapper): Pass 0 as the object parameter to CFNotificationCenterRemoveObserver().
(WebCore::AVFWrapper::notificationCallback): Remove obsolete FIXME comment.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92894
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Fri, 12 Aug 2011 00:18:59 +0000 (00:18 +0000)]
[chromium] Expose "min/max scroll size", "has horizontal/vertical scrollbar", "number of wheel handlers" to clients
https://bugs.webkit.org/show_bug.cgi?id=66094
Reviewed by James Robinson.
We want to implement two-finger-swipe for history like safari does on
os x lion. The way this works is:
* If a page has no horizontal scrollbars, or the page is all the way
to the left, scrolling to the left will go back in history instead.
* Same for right/forward.
This is modelled after the WebKit2 functions
WKPageIsPinnedToLeftSide(), WKPageIsPinnedToRightSide(),
WKPageHasHorizontalScrollbar(), and
webPageProxy::willHandleHorizontalScrollEvents().
* public/WebFrame.h:
* public/WebViewClient.h:
(WebKit::WebViewClient::numWheelEventHandlersChanged):
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::numWheelEventHandlersChanged):
* src/ChromeClientImpl.h:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::hasHorizontalScrollbar):
(WebKit::WebFrameImpl::hasVerticalScrollbar):
(WebKit::WebFrameImpl::isPinnedToLeft):
(WebKit::WebFrameImpl::isPinnedToRight):
* src/WebFrameImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92893
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Fri, 12 Aug 2011 00:11:08 +0000 (00:11 +0000)]
DFG JIT verbose mode does not report the generated types of nodes
https://bugs.webkit.org/show_bug.cgi?id=65830
Reviewed by Sam Weinig.
Added code that prints the type selected for each node's result.
* dfg/DFGGenerationInfo.h:
(JSC::DFG::dataFormatToString):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92892
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 11 Aug 2011 23:43:11 +0000 (23:43 +0000)]
Share code between isStyleSpanOrSpanWithOnlyStyleAttribute, isUnstyledStyleSpan,
isSpanWithoutAttributesOrUnstyleStyleSpan and replaceWithSpanOrRemoveIfWithoutAttributes
https://bugs.webkit.org/show_bug.cgi?id=66091
Reviewed by Tony Chang.
Source/WebCore:
Extracted common code as hasNoAttributeOrOnlyStyleAttribute. The only behavioral difference is that
replaceWithSpanOrRemoveIfWithoutAttributes will now remove elements with class="Apple-style-span",
for which I'm adding a test.
Test: editing/style/remove-styled-element-with-style-span.html
* editing/ApplyStyleCommand.cpp:
(WebCore::hasNoAttributeOrOnlyStyleAttribute):
(WebCore::isStyleSpanOrSpanWithOnlyStyleAttribute):
(WebCore::isUnstyledStyleSpan):
(WebCore::isSpanWithoutAttributesOrUnstyleStyleSpan):
(WebCore::ApplyStyleCommand::replaceWithSpanOrRemoveIfWithoutAttributes):
LayoutTests:
Added a test to ensure WebKit removes implicitly styled elements such as em, b, etc...
with class="Apple-style-span" when they're not necessary.
* editing/style/remove-styled-element-with-style-span-expected.txt: Added.
* editing/style/remove-styled-element-with-style-span.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92891
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 11 Aug 2011 23:35:29 +0000 (23:35 +0000)]
Source/WebCore: Add HTMLUnknownElement interface as defined in
http://www.w3.org/TR/html5/elements.html#elements-in-the-dom.
https://bugs.webkit.org/show_bug.cgi?id=41841
Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-11
Reviewed by Adam Barth.
Test: fast/html/unknown-tag.html
* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/scripts/CodeGeneratorV8.pm:
(IsDOMNodeType):
* dom/make_names.pl:
(defaultParametersHash):
(buildConstructorMap):
(printJSElementIncludes):
(printElementIncludes):
(printWrapperFunctions):
(printWrapperFactoryCppFile):
* html/HTMLTagNames.in:
* html/HTMLUnknownElement.h: Added.
(WebCore::HTMLUnknownElement::create):
(WebCore::HTMLUnknownElement::HTMLUnknownElement):
* html/HTMLUnknownElement.idl: Added.
* mathml/mathtags.in:
* page/DOMWindow.idl:
* svg/svgtags.in:
LayoutTests: Created tests for HTMLUnknownElement interface.
https://bugs.webkit.org/show_bug.cgi?id=41841.
Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-11
Reviewed by Adam Barth.
* fast/dom/prototype-inheritance-expected.txt:
* fast/html/unknown-tag.html: Added.
* platform/chromium/fast/dom/prototype-inheritance-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-expected.txt:
* platform/win/fast/dom/prototype-inheritance-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92890
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 11 Aug 2011 23:20:57 +0000 (23:20 +0000)]
Add a FIXME.
* TestWebKitAPI/TestsController.cpp:
(TestWebKitAPI::TestsController::TestsController):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92889
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Thu, 11 Aug 2011 23:19:43 +0000 (23:19 +0000)]
Remove dead code: borderInnerRect
https://bugs.webkit.org/show_bug.cgi?id=66087
Reviewed by Adam Barth.
Removing an old and currently unused function: RenderObject::borderInnerRect.
No new tests since I'm just pruning dead code.
* rendering/RenderObject.cpp:
* rendering/RenderObject.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92888
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 11 Aug 2011 23:18:23 +0000 (23:18 +0000)]
Initialize threading before running any tests
https://bugs.webkit.org/show_bug.cgi?id=66112
Reviewed by Adam Barth.
* TestWebKitAPI/TestsController.cpp:
(TestWebKitAPI::TestsController::TestsController):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92887
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 11 Aug 2011 22:56:22 +0000 (22:56 +0000)]
Add unexpected-passes.html to TestFailures for marking tests as passing
https://bugs.webkit.org/show_bug.cgi?id=66102
Reviewed by Dimitri Glazkov.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
- Move some code into the library so it can be shared.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
- Add round-trip unit tests.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Added.
- I'm not entirely sure this feature should remain a separate HTML
file, but it seemed better than cluttering up the main HTML file
with too much extra stuff.
* Scripts/webkitpy/tool/servers/gardeningserver.py:
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
- The gardening server couldn't handle adding PASS expectations. Now it can.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92886
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 11 Aug 2011 22:48:34 +0000 (22:48 +0000)]
pfeldman says we need to rebaseline this test. The massively complex
baseline fallback graph confused him when he created a platform/mac
fallback.
* platform/chromium-win/inspector/debugger: Added.
* platform/chromium-win/inspector/debugger/scripts-panel-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92885
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Thu, 11 Aug 2011 22:29:02 +0000 (22:29 +0000)]
Avoid adding the visible wash layer twice
https://bugs.webkit.org/show_bug.cgi?id=66098
Reviewed by Chris Marrin.
Fix two issues; only create a m_visibleTileWashLayer if we don't have one
already, and avoid adding multiple m_visibleTileWashLayers to the sublayers
array when flipping between tiled and non-tiled.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92884
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 11 Aug 2011 22:02:33 +0000 (22:02 +0000)]
The PageSerializer should always use absolute URL
https://bugs.webkit.org/show_bug.cgi?id=66006
Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-08-11
Reviewed by Adam Barth.
Page serializer resolves every URL for storing the resources.
The MarkupAccumulator used there should use the same rules in order to
create a valid file.
No new tests because the test infrastructure for this
does not exist with layout tests and the Chromium unit test for
the serializer are disabled.
* page/PageSerializer.cpp:
(WebCore::SerializerMarkupAccumulator::SerializerMarkupAccumulator):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92883
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 11 Aug 2011 21:59:11 +0000 (21:59 +0000)]
NRWT has wrong fallback order for Mac now that Lion exists
https://bugs.webkit.org/show_bug.cgi?id=66093
Reviewed by Adam Barth.
ORWT used a different system for fallback orders than NRWT did.
I moved win.py to match ORWT fallback orders in bug 64486.
This bug moves mac.py to match ORWT fallback order
and adds 'lion' as a supported OS version.
Because ChromiumMac shares OS version detection code with AppleMac
this also added support for 'lion' to chromium mac. Hopefully that's a good thing.
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/mac.py:
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/win.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92882
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 11 Aug 2011 21:56:04 +0000 (21:56 +0000)]
Move some Snow Leopard test results to the right place.
* platform/mac-snowleopard/fast/loader/file-url-mimetypes-2-expected.txt: Removed.
* platform/mac-snowleopard/fast/loader/file-url-mimetypes-expected.txt: Removed.
* platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Removed.
* platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html: Removed.
* platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Copied from platform/mac-snowleopard/fast/loader/file-url-mimetypes-expected.txt.
* platform/mac-snowleopard/platform/mac/fast/text/international: Added.
* platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Copied from platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt.
* platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html: Copied from platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92881
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 11 Aug 2011 21:39:51 +0000 (21:39 +0000)]
nullptr can't be used for PassRefPtr
https://bugs.webkit.org/show_bug.cgi?id=66024
Patch by James Robinson <jamesr@chromium.org> on 2011-08-11
Reviewed by Anders Carlsson.
* wtf/PassRefPtr.h:
(WTF::PassRefPtr::PassRefPtr):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92880
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 11 Aug 2011 21:29:22 +0000 (21:29 +0000)]
Record that these tests are now passing in these configurations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92879
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 11 Aug 2011 21:20:33 +0000 (21:20 +0000)]
2011-08-11 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: inspector's scripts-panel test baseline for mac added.
* platform/mac/inspector/debugger/scripts-panel-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92878
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 11 Aug 2011 21:08:05 +0000 (21:08 +0000)]
Update test results now that we use absolute URLs.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92876
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 11 Aug 2011 20:59:51 +0000 (20:59 +0000)]
garden-o-matic should be able to determine when tests unexpectedly pass
https://bugs.webkit.org/show_bug.cgi?id=66092
Reviewed by Dimitri Glazkov.
This patch just contains the library methods for extracting this
information. I'll add some UI in a subsequent patch.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92875
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Thu, 11 Aug 2011 20:43:18 +0000 (20:43 +0000)]
Enable fast path scrolling for composited iframes
https://bugs.webkit.org/show_bug.cgi?id=65056
Reviewed by James Robinson.
Source/WebCore:
iframes with composited layers for content should be able to do fast
path scrolling because they draw into their own backing. To enable
this, useSlowRepaints is modified to return true only for the cases
that apply to composited layers. The fast path scrolling function is
modified to send the invalidation to the backing itself rather than to
the window.
Renamed a number of "slow repaint" functions to be the more accurate
"cannot blit to window" as it will not always force slow path
scrolling.
* page/FrameView.cpp:
(WebCore::FrameView::reset):
(WebCore::FrameView::useSlowRepaints):
(WebCore::FrameView::useSlowRepaintsIfNotOverlapped):
(WebCore::FrameView::contentsInCompositedLayer):
(WebCore::FrameView::setCannotBlitToWindow):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::scrollContentsSlowPath):
* page/FrameView.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::cannotBlitToWindow):
* rendering/RenderLayer.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations):
LayoutTests:
Added test of iframe overlapping another iframe. Mac gets its own
incorrect expectations due to bug 63282.
* compositing/iframes/overlapped-iframe-iframe-expected.txt: Added.
* compositing/iframes/overlapped-iframe-iframe.html: Added.
* platform/chromium-gpu/compositing/iframes/overlapped-iframe-iframe-expected.txt: Added.
* platform/mac/compositing/iframes/overlapped-iframe-iframe-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92874
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Thu, 11 Aug 2011 19:44:45 +0000 (19:44 +0000)]
Support creating compositing layers for scrollable frames and iframes
https://bugs.webkit.org/show_bug.cgi?id=55257
Reviewed by James Robinson.
Source/WebCore:
When force compositing mode is turned on, iframes with overflow will
become composited (in order to enable faster scrolling).
This patch was originally by Daniel Sievers <sievers@chromium.org>.
Tests: platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html
platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html
platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html
platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html
platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
(WebCore::RenderLayerCompositor::requiresCompositingForScrollableFrame):
* rendering/RenderLayerCompositor.h:
LayoutTests:
* platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer-expected.txt: Added.
* platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html: Added.
* platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer-expected.txt: Added.
* platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html: Added.
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing-expected.txt: Added.
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html: Added.
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer-expected.txt: Added.
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html: Added.
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing-expected.txt: Added.
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html: Added.
* platform/chromium/compositing/force-compositing-mode/resources/subframe-big.html: Added.
* platform/chromium/compositing/force-compositing-mode/resources/subframe-small.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92873
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 11 Aug 2011 19:24:50 +0000 (19:24 +0000)]
Remove the temporary workaround added by trac.webkit.org/changeset/51338
https://bugs.webkit.org/show_bug.cgi?id=65908
Patch by Marja Hölttä <marja@chromium.org> on 2011-08-11
Reviewed by Adam Barth.
SecurityOrigin for a file URL returns "file://", and
SecurityOrigin::createFromString("file://") creates a unique (null)
security origin (because "file://" is first canonicalized to "file:///"
and that is a directory). This means the conversion SecurityOrigin ->
string -> SecurityOrigin doens't give back the same SecurityOrigin in
case of file URLs.
WebStorageNamespaceImpl::createStorageArea contains a workaround which
changes the string "file://" into "file:///a" before giving it to
SecurityOrigin::createFromString.
If SecurityOrigin::m_enforceFilePathSeparation is true, then
SecurityOrigin::toString() returns "null" for file URLs, and this
problem does not exist, and the workaround code is not ran.
This patch removes the workaround.
* src/WebStorageNamespaceImpl.cpp:
(WebKit::WebStorageNamespaceImpl::createStorageArea):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92872
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 11 Aug 2011 19:22:57 +0000 (19:22 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=65944
Replace QuotesData::operator==() with QuotesData::equal(const QuotesData*
, const QuotesData*) because QuotesData::operator==() were using non-standard
C++ code that is not supported by all compilers.
Patch by Yong Li <yoli@rim.com> on 2011-08-11
Reviewed by Alexey Proskuryakov.
No new tests because some existing test cases can show the issue,
for example, fast/css/content/content-quotes-01.html.
* rendering/RenderQuote.cpp:
(WebCore::RenderQuote::styleDidChange):
* rendering/style/QuotesData.cpp:
(WebCore::QuotesData::equal):
* rendering/style/QuotesData.h:
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setQuotes):
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::operator==):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92871
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 11 Aug 2011 18:08:08 +0000 (18:08 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=66075
Source/WebCore:
Turn on regions and exclusions by default. Fix one stray ifdef that I missed.
Reviewed by James Robinson.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::contentToCSSValue):
LayoutTests:
Fix the broken test result for layer dumping, since at the moment flow threads don't collect
layers (this will be fixed eventually).
Unskip the regions and exclusions tests now that they are turned on by default.
Reviewed by James Robinson.
* fast/regions/webkit-flow-renderer-layer-expected.txt:
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92870
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Thu, 11 Aug 2011 17:57:05 +0000 (17:57 +0000)]
[Qt] fast/dom/HTMLDocument/hasFocus.html fails
https://bugs.webkit.org/show_bug.cgi?id=66076
Unreviewed gardening.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92869
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 11 Aug 2011 17:29:09 +0000 (17:29 +0000)]
Removed unused variable in StackBounds::initialize() to resolve
compiler warning when building on QNX.
https://bugs.webkit.org/show_bug.cgi?id=66072
Patch by Daniel Bates <dbates@rim.com> on 2011-08-11
Reviewed by Antonio Gomes.
* wtf/StackBounds.cpp:
(WTF::StackBounds::initialize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92868
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 11 Aug 2011 17:23:49 +0000 (17:23 +0000)]
[Chromium] Temporarily disable layer anti-aliasing on ChromeOS.
https://bugs.webkit.org/show_bug.cgi?id=65922
Patch by David Reveman <reveman@chromium.org> on 2011-08-11
Reviewed by James Robinson.
No new tests.
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::draw):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92867
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 11 Aug 2011 17:19:55 +0000 (17:19 +0000)]
Merge expectations to mute flakiness.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92866
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 11 Aug 2011 16:56:28 +0000 (16:56 +0000)]
New expectation entries should be placed next to existing ones.
https://bugs.webkit.org/show_bug.cgi?id=66066
Reviewed by Adam Barth.
* Scripts/webkitpy/layout_tests/models/test_expectations.py: Added the notion of insertion point,
which is computed as the last found reference to the same test.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added and adjusted unit tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92861
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 11 Aug 2011 16:48:59 +0000 (16:48 +0000)]
Implementation of monotonically increasing clock on GTK
https://bugs.webkit.org/show_bug.cgi?id=62175
Patch by Devdatta Deshpande <pwjd73@motorola.com> on 2011-08-11
Reviewed by Martin Robinson.
* wtf/CurrentTime.cpp:
(WTF::monotonicallyIncreasingTime):
The default implementation of monotonicallyIncreasingTime only
guarantees the result to be non-decreasing.
If the system time is changed to past then default implementation will
still fail and WebCore timers will not fire.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92859
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
qi.2.zhang@nokia.com [Thu, 11 Aug 2011 16:47:30 +0000 (16:47 +0000)]
[Qt] fast/dom/HTMLDocument/hasFocus.html failed
https://bugs.webkit.org/show_bug.cgi?id=62126
This test case passed under the latest revision, remove it from skip list.
Reviewed by Chang Shu.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92858
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 11 Aug 2011 16:44:55 +0000 (16:44 +0000)]
Unreviewed, rolling out r92847.
http://trac.webkit.org/changeset/92847
https://bugs.webkit.org/show_bug.cgi?id=65986
Broke check-webkit-style
* Scripts/webkitpy/style/checker.py:
* Scripts/webkitpy/style/checker_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 11 Aug 2011 16:37:55 +0000 (16:37 +0000)]
[Qt] PageSerializer is specific to MHTML, we should not compile it
https://bugs.webkit.org/show_bug.cgi?id=66054
Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-08-11
Reviewed by Noam Rosenthal.
PageSerializer is specific to MHTML. Do not build PageSerializer unless MHTML is enabled.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 11 Aug 2011 16:36:00 +0000 (16:36 +0000)]
Web Inspector: [refactoring] make tabbed pane a view
https://bugs.webkit.org/show_bug.cgi?id=66060
Reviewed by Pavel Feldman.
* inspector/front-end/NetworkItemView.js:
(WebInspector.NetworkItemView):
(WebInspector.NetworkItemView.prototype.show):
(WebInspector.NetworkItemView.prototype._selectTab.get if):
(WebInspector.NetworkItemView.prototype._selectTab):
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane):
* inspector/front-end/inspector.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Thu, 11 Aug 2011 15:57:00 +0000 (15:57 +0000)]
[GTK] create pot files in builddir, not (read only) srcdir
https://bugs.webkit.org/show_bug.cgi?id=66059
Reviewed by Gustavo Noronha Silva.
* GNUmakefile.am: write and read pot files from the build dir.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Thu, 11 Aug 2011 15:53:27 +0000 (15:53 +0000)]
Add the javascript core dynamic library for gtk-doc's introspection helper.
Patch by Gustavo Noronha Silva <gns@gnome.org> on 2011-08-11
Reviewed by Xan Lopez.
* docs/GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Thu, 11 Aug 2011 15:46:45 +0000 (15:46 +0000)]
2011-08-11 Xan Lopez <xlopez@igalia.com>
[GTK] Update NEWS and configure.ac for 1.5.2 release
Reviewed by Gustavo Noronha.
* configure.ac: update for release.
Source/WebKit/gtk:
2011-08-11 Xan Lopez <xlopez@igalia.com>
[GTK] Update NEWS and configure.ac for 1.5.2 release
Reviewed by Gustavo Noronha.
* NEWS: update for release.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Thu, 11 Aug 2011 15:33:25 +0000 (15:33 +0000)]
[Qt/WK2] Add initial support for viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=65975
Reviewed by Benjamin Poulain.
Redirect the viewport arguments through to the view.
* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::didReceiveViewportArguments):
* UIProcess/API/qt/qdesktopwebview_p.h:
* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebView::geometryChanged):
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::setViewportArguments):
* UIProcess/qt/QtWebPageProxy.h:
* UIProcess/qt/TouchViewInterface.cpp:
(WebKit::TouchViewInterface::updateViewportState):
(WebKit::TouchViewInterface::didReceiveViewportArguments):
* UIProcess/qt/TouchViewInterface.h:
(WebKit::TouchViewInterface::ViewportState::ViewportState):
* UIProcess/qt/ViewInterface.h:
* UIProcess/qt/qtouchwebpageproxy.cpp:
(QTouchWebPageProxy::QTouchWebPageProxy):
* UIProcess/qt/qtouchwebpageproxy.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 11 Aug 2011 15:24:30 +0000 (15:24 +0000)]
Web Inspector: source frame popover simetimes pops up after user switches from Scripts panel
https://bugs.webkit.org/show_bug.cgi?id=66057
Reviewed by Pavel Feldman.
* inspector/front-end/SourceFrame.js: remove popover timer when removing popover.
(WebInspector.SourceFrame.prototype._mouseDown):
(WebInspector.SourceFrame.prototype._hidePopup):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Thu, 11 Aug 2011 14:59:15 +0000 (14:59 +0000)]
Web Inspector: Scripts panel: display the current search match index in the toolbar.
https://bugs.webkit.org/show_bug.cgi?id=66048
Reviewed by Pavel Feldman.
* English.lproj/localizedStrings.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
(WebInspector.ScriptsPanel.prototype.performSearch):
(WebInspector.ScriptsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype.updateSearchMatchesCount):
(WebInspector.SearchController.prototype.updateCurrentMatchIndex):
(WebInspector.SearchController.prototype.activePanelChanged.performPanelSearch):
(WebInspector.SearchController.prototype.activePanelChanged):
(WebInspector.SearchController.prototype._updateSearchMatchesCountAndCurrentMatchIndex):
(WebInspector.SearchController.prototype._performSearch):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.get currentSearchResultIndex):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Thu, 11 Aug 2011 14:43:59 +0000 (14:43 +0000)]
2011-08-11 Xan Lopez <xlopez@igalia.com>
[GTK] Add another missing file to GNUmakefile
Reviewed by Gustavo Noronha.
* GNUmakefile.list.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 11 Aug 2011 14:40:29 +0000 (14:40 +0000)]
[Qt] autotests shouldn't require config.h in the style check
https://bugs.webkit.org/show_bug.cgi?id=65986
Remove the include rules from the style-check for Qt tests.
Since for the most part it's just a matter of using the
API provided by QtWebKit, enforcing the WebCore set of rules
only seems to make sense in the case of MIMESniffing.
Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-08-11
Reviewed by Benjamin Poulain.
* Scripts/webkitpy/style/checker.py:
* Scripts/webkitpy/style/checker_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Thu, 11 Aug 2011 14:34:34 +0000 (14:34 +0000)]
2011-08-11 Xan Lopez <xlopez@igalia.com>
[GTK] Add missing files to GNUMakefile
Reviewed by Gustavo Noronha.
* GNUmakefile.am:
* GNUmakefile.list.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreip@google.com [Thu, 11 Aug 2011 14:15:04 +0000 (14:15 +0000)]
2011-08-11 Andrei Popescu <andreip@google.com>
[Chromium] Rebaseline these tests on Leopard.
Unreviewed gardening.
* platform/chromium-mac-leopard/editing/pasteboard/paste-text-016-expected.png: Added
* platform/chromium-mac-leopard/editing/spelling/inline_spelling_markers-expected.png: Added
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Thu, 11 Aug 2011 14:02:38 +0000 (14:02 +0000)]
WebKitTestRunner needs a more-complete implementation of eventSender
https://bugs.webkit.org/show_bug.cgi?id=42194
fast/encoding/mailto-always-utf-8.html needs eventSender
Move it to the common wk2 Skipped list from the qt-wk2.
Unreviewed gardening.
Patch by Zsolt Fehér <h490267@stud.u-szeged.hu> on 2011-08-11
* platform/qt-wk2/Skipped:
* platform/wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Thu, 11 Aug 2011 14:00:57 +0000 (14:00 +0000)]
WebSocket: Use PassRefPtr<> in function arguments in WorkerThreadableWebSocketChannel.cpp
https://bugs.webkit.org/show_bug.cgi?id=66047
Reviewed by Kent Tamura.
It's safe to use PassRefPtr<> in these functions because:
- CrossThreadTask knows how to pass a RefPtr<> across threads, and
- Call sites do not pass the pointers to anywhere else.
No change in functionality, thus no new tests.
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::workerContextDidSend):
(WebCore::workerContextDidGetBufferedAmount):
(WebCore::workerContextDidConnect):
(WebCore::workerContextDidReceiveMessage):
(WebCore::workerContextDidStartClosingHandshake):
(WebCore::workerContextDidClose):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 11 Aug 2011 13:59:08 +0000 (13:59 +0000)]
Web Inspector: [Mac] search as you type does not work with the new indent in the script selector.
https://bugs.webkit.org/show_bug.cgi?id=66039
Reviewed by Yury Semikhatsky.
Source/WebCore:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
* inspector/front-end/inspector.css:
(select.status-bar-item):
LayoutTests:
* inspector/debugger/scripts-panel-expected.txt:
* platform/chromium/inspector/debugger/scripts-sorting-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Thu, 11 Aug 2011 12:45:44 +0000 (12:45 +0000)]
Unreviewed build fix for Qt.
Make sure we build when Qt is namespaced.
* platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 11 Aug 2011 12:40:57 +0000 (12:40 +0000)]
[WK2] Implement waitForPolicyDelegate
https://bugs.webkit.org/show_bug.cgi?id=42330
Patch by Zsolt Fehér <h490267@stud.u-szeged.hu> on 2011-08-11
Reviewed by Csaba Osztrogonác.
Tools:
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::navigationTypeToString):
(WTR::InjectedBundlePage::decidePolicyForNavigationAction):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController):
(WTR::LayoutTestController::setCustomPolicyDelegate):
(WTR::LayoutTestController::waitForPolicyDelegate):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::isPolicyDelegateEnabled):
(WTR::LayoutTestController::isPolicyDelegatePermissive):
LayoutTests:
Unskip passing tests.
* platform/qt-wk2/Skipped:
* platform/wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Thu, 11 Aug 2011 12:20:59 +0000 (12:20 +0000)]
Web Inspector: use source-file-replaced instead of source-file-changed event.
https://bugs.webkit.org/show_bug.cgi?id=65551
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/debugger/source-frame-count.html
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeReplaced):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._removeSourceFrame):
(WebInspector.ScriptsPanel.prototype._sourceFileReplaced):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.get uiSourceCode):
(WebInspector.RawSourceCode.prototype.reload):
* inspector/front-end/inspector.js:
(WebInspector._createPanels):
LayoutTests:
* inspector/debugger/scripts-panel-expected.txt:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/source-file-expected.txt:
* inspector/debugger/source-file.html:
* inspector/debugger/source-frame-count-expected.txt: Added.
* inspector/debugger/source-frame-count.html: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreip@google.com [Thu, 11 Aug 2011 11:30:31 +0000 (11:30 +0000)]
2011-08-11 Andrei Popescu <andreip@google.com>
Master: Support CSS3 font feature properties
https://bugs.webkit.org/show_bug.cgi?id=63796
Unreviewed gardening.
css3/font-feature-settings-rendering.html is missing expectations. Looking at the
actual test output, it appears clearly wrong so we cannot rebaseline it either.
We'll therefore update the expectations file to mark this test as missing expected
results and update the bug to say it needs investigation and fixing.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reni@webkit.org [Thu, 11 Aug 2011 10:04:05 +0000 (10:04 +0000)]
[Qt]Fix warnings after r92805.
Reviewed by Csaba Osztrogonác.
Control reached the end non-void functions.
* src/compiler/ossource_posix.cpp:
(OS_AllocTLSIndex):
(OS_SetTLSValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Thu, 11 Aug 2011 09:34:16 +0000 (09:34 +0000)]
Web Inspector: [REGRESSION] Resources panel search fails when search result is found in a resource used in several frames.
https://bugs.webkit.org/show_bug.cgi?id=66007
Reviewed by Pavel Feldman.
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.performSearch.callback):
(WebInspector.ResourcesPanel.prototype.performSearch):
(WebInspector.FrameTreeElement.prototype.resourceByURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Thu, 11 Aug 2011 09:24:06 +0000 (09:24 +0000)]
[GTK] Fix the build after r92792.
Rubber-stamped by Csaba Osztrogonác.
No new tests needed.
* GNUmakefile.list.am: add missing
RenderFlowThread.{cpp|h}
RenderRegion.{cpp|h}
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 11 Aug 2011 08:59:16 +0000 (08:59 +0000)]
Rebaseline these tests, as requested by morrita.
* platform/chromium-mac/editing/pasteboard/paste-text-016-expected.png: Added.
* platform/chromium-mac/editing/selection/move-by-character-005-expected.png: Added.
* platform/chromium-mac/editing/spelling/inline_spelling_markers-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 11 Aug 2011 08:54:12 +0000 (08:54 +0000)]
rebaseline-expectations should use the release bots, not the debug
bots. The debug bots don't all run all the tests. Also, delay
updating test_expectations a long as possible to avoid clearing out
lines that we'll need for other ports.
* Scripts/webkitpy/layout_tests/port/builders.py:
* Scripts/webkitpy/tool/commands/rebaseline.py:
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc