WebKit-https.git
11 years ago(Not reviewed.)
mjs@apple.com [Thu, 8 Apr 2010 06:13:50 +0000 (06:13 +0000)]
(Not reviewed.)

Random demo to look cool on twitter.

* misc/gradient-input.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 8 Apr 2010 06:03:29 +0000 (06:03 +0000)]
2010-04-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Alexey Proskuryakov.

        WebKit Apache configs only listen on IPv4 addresses, causing random timeouts
        https://bugs.webkit.org/show_bug.cgi?id=37104

        Apache 1.3 does not support IPv6, so remove the Listen [::1] directive
        and add a warning about how that may cause flakiness on systems which
        use Apache 1.3, but support IPv6.

        * http/conf/httpd.conf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Eric Seidel <eric@webkit.org>
abarth@webkit.org [Thu, 8 Apr 2010 05:00:16 +0000 (05:00 +0000)]
2010-04-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        WebKit Apache configs only listen on IPv4 addresses, causing random timeouts
        https://bugs.webkit.org/show_bug.cgi?id=37104

        WebKit Apache configs were only listening on IPv4 loopback (127.0.0.1), however
        the system will resolve "localhost." to both IPv4 and IPv6 (::1) loopback
        addreses when IPv6 is enabled.  Since DNS lookup returns addresses in random
        order, we would occasionally fail to make connections to "localhost" addresses
        if the various network re-tries all happen to resolve to the IPv6 loopback.

        To make matters worse, the kernel has a connection reset throttle which we
        could trigger if we would repeatedly attempt to connect to ::1 and fail.
        The trottle would cause a 1 or 2 second delay on the connection, sometimes
        causing slow tests to time out.

        I also discovered during this investigation that we have some partial support
        for specifying our apache port numbers at runtime.  The support is already incomplete
        by not accounting for WebSockets or SSL ports.  This fix will make our partial
        support for dynamic apache port numbers even more broken.

        I've added Listen [::1]:PORT directives for 8000, 8080, and 8443 to all
        platforms (except cygwin which does not have the 8443 directive to begin with).

        * http/conf/apache2-debian-httpd.conf:
        * http/conf/apache2-httpd.conf:
        * http/conf/cygwin-httpd.conf:
        * http/conf/fedora-httpd.conf:
        * http/conf/httpd.conf:
2010-04-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        WebKit Apache configs only listen on IPv4 addresses, causing random timeouts
        https://bugs.webkit.org/show_bug.cgi?id=37104

        Add warnings that the partial support for specifying what port numbers
        apache should bind to is even more broken after this fix.

        * Scripts/run-webkit-httpd:
        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoVector<UString> makes many needless calls to UString::UString and UString::~UString
oliver@apple.com [Thu, 8 Apr 2010 04:35:06 +0000 (04:35 +0000)]
Vector<UString> makes many needless calls to UString::UString and UString::~UString

Reviewed by Anders Carlsson.

Add a VectorTrait<UString> specialisation to allow vector to simply memset/memcpy
data around.  Only difference from the VectorTrait<RefPtr<T> > traits is the inability
to use memset to initialize data.

* runtime/UString.h:
(WTF::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Thu, 8 Apr 2010 04:12:17 +0000 (04:12 +0000)]
2010-04-07  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        LayoutTestController::m_handlesAuthenticationChallenges isn't initialized
        https://bugs.webkit.org/show_bug.cgi?id=37190

        * DumpRenderTree/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRefactor WebHTMLView printing code and add private methods to enter and exit printing...
mitz@apple.com [Thu, 8 Apr 2010 04:11:48 +0000 (04:11 +0000)]
Refactor WebHTMLView printing code and add private methods to enter and exit printing mode.
https://bugs.webkit.org/show_bug.cgi?id=37246

Reviewed by Adele Peterson.

* Misc/WebNSPrintOperationExtras.h: Declared -_web_availablePaperWidth and -_web_availablePaperHeight.
* Misc/WebNSPrintOperationExtras.m:
(-[NSPrintOperation _web_availablePaperWidth]): Turned -[WebHTMLView _availablePaperWidthForPrintOperation:]
into this method.
(-[NSPrintOperation _web_availablePaperHeight]): Turned -[WebHTMLView _calculatePrintHeight] into this
method.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _isInPrintMode]): Added this accessor.
(-[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:]): Added. Moved the code from -knowsPageRange: that
computes the layout widths and enters printing mode into this private method.
(-[WebHTMLView _endPrintMode]): New private method (the old -_endPrintMode has been renamed).
(-[WebHTMLView _scaleFactorForPrintOperation:]): Use -[NSPrintOperation _web_availablePaperWidth].
(-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Renamed -_endPrintMode to this, changed it to call
_endPrintMode.
(-[WebHTMLView _delayedEndPrintMode:]): Updated for rename.
(-[WebHTMLView knowsPageRange:]): Use -_beginPrintModeWithPageWidth:shrintToFit:,
-[NSPrintOperation _web_availablePaperWidth], and -[NSPrintOperation _web_availablePaperHeight]. Updated for
rename.
(-[WebHTMLView beginDocument]): Updated for rename.
(-[WebHTMLView endDocument]): Ditto.
* WebView/WebHTMLViewPrivate.h: Declared new private methods -_isInPrintMode,
-_beginPrintModeWithPageWidth:shrinkToFit: and -_endPrintMode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Chromium's HTML5 DB support in --single-process mode.
dumi@chromium.org [Thu, 8 Apr 2010 01:18:36 +0000 (01:18 +0000)]
Fix Chromium's HTML5 DB support in --single-process mode.
https://bugs.webkit.org/show_bug.cgi?id=37186.

Reviewed by Jeremy Orlow.

Always register and use Chromium's SQLite VFS for
WebSQLDatabases. Keep using the default VFS in all other
cases. This change should allow Chromium to support
WebSQLDatabases in --single-process mode.

Also, cleaning up a bit SQLiteFileSystemChromium and getting rid
of the SQLITE_OPEN_FULLMUTEX flag: we use sqlite DB handles only
on the DB thread, so we don't need multi-threaded support.

* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::open):
* platform/sql/SQLiteDatabase.h:
* platform/sql/SQLiteFileSystem.cpp:
(WebCore::SQLiteFileSystem::openDatabase):
* platform/sql/SQLiteFileSystem.h:
* platform/sql/chromium/SQLiteFileSystemChromium.cpp:
(WebCore::SQLiteFileSystem::openDatabase):
* platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
(WebCore::SQLiteFileSystem::registerSQLiteVFS):
* platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
(WebCore::SQLiteFileSystem::registerSQLiteVFS):
* storage/Database.cpp:
(WebCore::Database::performOpenAndVerify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Remove QuartzCoreInterface from the build
cmarrin@apple.com [Thu, 8 Apr 2010 00:38:40 +0000 (00:38 +0000)]
    Remove QuartzCoreInterface from the build

        No longer needed since QuartzCore.dll is now included in  the latest Safari release (4.0.5).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Sheriff Bot <webkit.review.bot@gmail.com>
ojan@chromium.org [Thu, 8 Apr 2010 00:32:01 +0000 (00:32 +0000)]
2010-04-07  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r57178.
        http://trac.webkit.org/changeset/57178
        https://bugs.webkit.org/show_bug.cgi?id=37240

        Caused chromium browser_test and ui_test regressions
        (Requested by ojan on #webkit).

        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::processingUserGesture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 7 Apr 2010 23:52:01 +0000 (23:52 +0000)]
2010-04-07  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        New chromium expected results after r57215
        https://bugs.webkit.org/show_bug.cgi?id=37239

        * platform/chromium-linux/fast/repaint/stacked-diacritics-expected.checksum: Added.
        * platform/chromium-linux/fast/text/line-breaks-expected.checksum:
        * platform/chromium-linux/fast/text/line-breaks-expected.png:
        * platform/chromium-linux/fast/text/line-breaks-expected.txt:
        Our new behavior is no more broken than the old behavior. Evan says
        he'll fix the underlying problem some day.

        * platform/chromium-win/fast/repaint/stacked-diacritics-expected.checksum: Added.
        * platform/chromium-win/fast/repaint/stacked-diacritics-expected.png: Added.
        * platform/chromium-win/fast/repaint/stacked-diacritics-expected.txt: Added.
        This is a new test. These are just the usual windows vs. mac font rendering differences.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Eric Seidel <eric@webkit.org>
abarth@webkit.org [Wed, 7 Apr 2010 23:49:11 +0000 (23:49 +0000)]
2010-04-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Fix two cookie tests to clean up after themselves (so they can be run repeatedly)
        https://bugs.webkit.org/show_bug.cgi?id=37235

        Tiger's CFNetwork doesn't seem to understand "max-age=-1" so we'll
        use "expires=some date in the past" to clear cookies instead.
        I've verified that these tests still work on Snow Leopard.

        * http/tests/xmlhttprequest/resources/cross-origin-set-cookies.php:
        * http/tests/xmlhttprequest/resources/get-set-cookie.cgi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBeat gcc with a clue bat -- force inlining of refIfNotNull and derefIfNotNull
oliver@apple.com [Wed, 7 Apr 2010 23:06:11 +0000 (23:06 +0000)]
Beat gcc with a clue bat -- force inlining of refIfNotNull and derefIfNotNull

Reviewed by Geoff Garen.

* wtf/PassRefPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd the comment and assert that we're generating version 4 random number
jianli@chromium.org [Wed, 7 Apr 2010 23:04:53 +0000 (23:04 +0000)]
Add the comment and assert that we're generating version 4 random number
based UUIDs.
https://bugs.webkit.org/show_bug.cgi?id=36472

Reviewed by Adam Barth and Dmitry Titov.

* platform/UUID.cpp:
(WebCore::createCanonicalUUIDString):
* platform/UUID.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Erik Arvidsson <arv@chromium.org>
eric@webkit.org [Wed, 7 Apr 2010 22:59:29 +0000 (22:59 +0000)]
2010-04-07  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Adam Barth.

        Allow white listing access from origin to local origin.
        https://bugs.webkit.org/show_bug.cgi?id=37228

        This makes it possible to load a local resource from a non local
        origin if the access has previously been white listed by calling
        SecurityOrigin::whiteListAccessFromOrigin.

        * http/tests/security/local-image-from-remote-whitelisted-expected.txt: Added.
        * http/tests/security/local-image-from-remote-whitelisted.html: Added.
2010-04-07  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Adam Barth.

        Allow white listing access from origin to local origin.
        https://bugs.webkit.org/show_bug.cgi?id=37228

        This makes it possible to load a local resource from a non local
        origin if the access has previously been white listed by calling
        SecurityOrigin::whiteListAccessFromOrigin.

        Test: http/tests/security/local-image-from-remote-whitelisted.html

        * page/OriginAccessEntry.cpp:
        (WebCore::OriginAccessEntry::OriginAccessEntry): Removed assert that only the http and https protocol are valid.
        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::canRequest): Use isAccessWhiteListed
        (WebCore::SecurityOrigin::isAccessWhiteListed): Extracted code that goes through the originAccessMap to do the origin matching.
        (WebCore::SecurityOrigin::canLoad): Check if access has been white listed.
        * page/SecurityOrigin.h: Add private function isAccessWhiteListed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 7 Apr 2010 22:43:29 +0000 (22:43 +0000)]
2010-04-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Fix two cookie tests to clean up after themselves (so they can be run repeatedly)
        https://bugs.webkit.org/show_bug.cgi?id=37235

        Added a ?clear=1 query parameter to the two "set cookies" cgi scripts
        that these tests use, and call it to clear the cookies before leaving the test.

        I could not resist the temptation of cleaning up the ridiculously awful copy/paste
        in these tests, so the changes are larger than strictly necessary.

        * http/tests/xmlhttprequest/cookies.html:
        * http/tests/xmlhttprequest/cross-origin-cookie-storage.html:
        * http/tests/xmlhttprequest/resources/cross-origin-set-cookies.php:
        * http/tests/xmlhttprequest/resources/get-set-cookie.cgi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Luiz Agostini <luiz.agostini@openbossa.org>
eric@webkit.org [Wed, 7 Apr 2010 21:53:26 +0000 (21:53 +0000)]
2010-04-07  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Darin Adler.

        Adding static method zero() to classes IntPoint and FloatPoint.
        https://bugs.webkit.org/show_bug.cgi?id=37220

        Adding static method zero() to classes IntPoint and FloatPoint as suggested by Darin Adler.

        * platform/graphics/FloatPoint.h:
        (WebCore::FloatPoint::zero):
        * platform/graphics/IntPoint.h:
        (WebCore::IntPoint::zero):
        (WebCore::IntPoint::clampNegativeToZero):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago * platform/network/mac/AuthenticationMac.mm: Fix a typo in comment.
ap@apple.com [Wed, 7 Apr 2010 21:32:49 +0000 (21:32 +0000)]
    * platform/network/mac/AuthenticationMac.mm: Fix a typo in comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Wed, 7 Apr 2010 21:30:08 +0000 (21:30 +0000)]
2010-04-07  Zhenyao Mo  <zmo@google.com>

        Reviewed by Eric Seidel.

        A few tests in fast/canvas/webgl failed randomly on Leopard Commit Bot
        https://bugs.webkit.org/show_bug.cgi?id=37098

        * fast/canvas/webgl/resources/webgl-test.js: Turn off stencil/antialias by default.
        (create3DContext):
        * fast/canvas/webgl/script-tests/index-validation.js: By default antialias is off.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix a typo.
ap@apple.com [Wed, 7 Apr 2010 21:25:45 +0000 (21:25 +0000)]
Fix a typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darinn Adler.
ap@apple.com [Wed, 7 Apr 2010 21:25:29 +0000 (21:25 +0000)]
    Reviewed by Darinn Adler.

        https://bugs.webkit.org/show_bug.cgi?id=37230
        <rdar://problem/7813115> REGRESSION (4.0.5): Safari asks for credentials all the time when
        authenticating to Windows IIS Server

        * platform/network/ProtectionSpace.h: (WebCore::ProtectionSpaceAuthenticationScheme): Added
        a constant for ProtectionSpaceAuthenticationSchemeUnknown.

        * platform/network/cf/AuthenticationCF.cpp: (WebCore::core):
        * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::authenticationSchemeFromAuthenticationMethod):
        Return ProtectionSpaceAuthenticationSchemeUnknown for unknown scheme.

        * platform/network/mac/AuthenticationMac.mm:
        (WebCore::mac): Support NTLM on systems older than 10.6. We actually get this string from
        NSURLConnection, even though there was no public constant.
        (WebCore::core): Return ProtectionSpaceAuthenticationSchemeUnknown for unknown scheme.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Jaime Yap <jaimeyap@google.com>
eric@webkit.org [Wed, 7 Apr 2010 21:20:50 +0000 (21:20 +0000)]
2010-04-07  Jaime Yap  <jaimeyap@google.com>

        Reviewed by Pavel Feldman.
        Tests expectations changed due to the addition of the function symbol name for
        the call location for records sent by the InspectorTimelineAgent.
        https://bugs.webkit.org/show_bug.cgi?id=36839

        No new tests.

        * inspector/timeline-test.js:
        * platform/chromium-win/inspector/timeline-event-dispatch-expected.txt:
        * platform/chromium-win/inspector/timeline-mark-timeline-expected.txt:
        * platform/chromium-win/inspector/timeline-network-resource-expected.txt:
        * platform/chromium-win/inspector/timeline-paint-expected.txt:
        * platform/chromium-win/inspector/timeline-parse-html-expected.txt:
2010-04-07  Jaime Yap  <jaimeyap@google.com>

        Reviewed by Pavel Feldman.

        Adds the ability to get the function symbol name when looking up the call location
        for records sent by the InspectorTimelineAgent.
        https://bugs.webkit.org/show_bug.cgi?id=36839

        No new tests.

        * bindings/js/ScriptCallStack.cpp:
        (WebCore::ScriptCallStack::callLocation):
        * bindings/js/ScriptCallStack.h:
        * bindings/v8/ScriptCallStack.cpp:
        (WebCore::ScriptCallStack::create):
        (WebCore::ScriptCallStack::callLocation):
        (WebCore::ScriptCallStack::ScriptCallStack):
        * bindings/v8/ScriptCallStack.h:
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::createUtilityContext):
        (WebCore::ScriptDebugServer::topStackFrame):
        * bindings/v8/ScriptDebugServer.h:
        (WebCore::ScriptDebugServer::utilityContext):
        * bindings/v8/V8Proxy.cpp:
        * bindings/v8/V8Proxy.h:
        * inspector/TimelineRecordFactory.cpp:
        (WebCore::TimelineRecordFactory::createGenericRecord):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Jay Civelli <jcivelli@chromium.org>
eric@webkit.org [Wed, 7 Apr 2010 21:10:58 +0000 (21:10 +0000)]
2010-04-07  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Jian Li.

        [chromium] Add test for a popup related crasher.
        https://bugs.webkit.org/show_bug.cgi?id=37141

        * platform/chromium/fast/forms: Added.
        * platform/chromium/fast/forms/search-popup-crasher-expected.txt: Added.
        * platform/chromium/fast/forms/search-popup-crasher.html: Added.
2010-04-07  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Jian Li.

        [chromium] Fixing a NULL pointer being dereferenced in some cases.
        https://bugs.webkit.org/show_bug.cgi?id=37141

        Test: platform/chromium/fast/forms/search-popup-crasher.html

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupMenu::~PopupMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd skeleton FileStream module for providing sync file operations for FileAPI
jianli@chromium.org [Wed, 7 Apr 2010 20:47:04 +0000 (20:47 +0000)]
Add skeleton FileStream module for providing sync file operations for FileAPI
https://bugs.webkit.org/show_bug.cgi?id=37217

Patch by Kinuko Yasuda <kinuko@chromium.org> on 2010-04-07
Reviewed by Jian Li.

For now the module just defines an interface and is almost empty.
Implementation will be added.

No new tests; will be added when we have complete implementation.

* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/FileStream.cpp: Added.
* html/FileStream.h: Added.
* html/FileStreamClient.h: Added.
* html/FileThread.cpp:
(WebCore::SameFilePredicate::SameFilePredicate):
(WebCore::SameFilePredicate::operator()):
(WebCore::FileThread::unscheduleTasks):
* html/FileThread.h:
(WebCore::FileThread::Task::stream):
(WebCore::FileThread::Task::Task):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Kenneth Rohde Christiansen.
ossy@webkit.org [Wed, 7 Apr 2010 20:44:51 +0000 (20:44 +0000)]
Rubber-stamped by Kenneth Rohde Christiansen.

Poor rendering on lala.com with frame flattening
https://bugs.webkit.org/show_bug.cgi?id=37164

Platform specific expected files added for test introduced in r57225.

* platform/mac/fast/frames/flattening/iframe-flattening-offscreen-expected.txt: Added.
* platform/qt/fast/frames/flattening/iframe-flattening-offscreen-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 7 Apr 2010 20:37:59 +0000 (20:37 +0000)]
2010-04-07  Oliver Hunt  <oliver@apple.com>

        Reviewed by Darin Adler.

        Remove some unnecessary uses of commonJSGlobalData
        https://bugs.webkit.org/show_bug.cgi?id=37229

        Pass the ExecState down to identifierFromNPIdentifier and update call sites

        * bridge/NP_jsobject.cpp:
        (_NPN_Invoke):
        (_NPN_GetProperty):
        (_NPN_SetProperty):
        (_NPN_RemoveProperty):
        (_NPN_HasProperty):
        (_NPN_HasMethod):
        * bridge/c/c_instance.cpp:
        (JSC::Bindings::CInstance::getPropertyNames):
        * bridge/c/c_utility.cpp:
        (JSC::Bindings::identifierFromNPIdentifier):
        * bridge/c/c_utility.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Wed, 7 Apr 2010 20:32:13 +0000 (20:32 +0000)]
2010-04-07  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Darin Adler.

        Replace isprint with isASCIIPrintable
        https://bugs.webkit.org/show_bug.cgi?id=37223

        WebKit does not use functions in <ctype.h> as they are dependent on the current
        locale. Use the equivalent functions in <wtf/ASCIICType.h>. isASCIIPrintable
        replaces isprint.

        * pcre/pcre_exec.cpp:
        (pchars):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Kenneth Rohde Christiansen <kenneth@webkit.org>
eric@webkit.org [Wed, 7 Apr 2010 20:22:43 +0000 (20:22 +0000)]
2010-04-07  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Darin Adler.

        Poor rendering on lala.com with frame flattening
        https://bugs.webkit.org/show_bug.cgi?id=37164

        Do not flatten offscreen iframes.

        Test: fast/frames/flattening/iframe-flattening-offscreen.html

        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::flattenFrame):
        * rendering/RenderPartObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Abhishek Arya <inferno@chromium.org>
abarth@webkit.org [Wed, 7 Apr 2010 19:49:20 +0000 (19:49 +0000)]
2010-04-07  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Adam Barth.

        Make sure that calling bindings constructors as function does not result in crash.

        * fast/constructors: Added.
        * fast/constructors/constructor-as-function-crash-expected.txt: Added.
        * fast/constructors/constructor-as-function-crash.html: Added.
2010-04-07  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Adam Barth.

        [V8] Add a missing check for constructor call in WebKitPointConstructor.
        https://bugs.webkit.org/show_bug.cgi?id=37210

        Test: fast/constructors/constructor-as-function-crash.html

        * bindings/v8/custom/V8WebKitPointConstructor.cpp:
        (WebCore::V8WebKitPoint::constructorCallback): Added a check for constructor call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 7 Apr 2010 19:17:07 +0000 (19:17 +0000)]
2010-04-07  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Simon Fraser.

        Make tests pass with tolerance=0 after r57215
        https://bugs.webkit.org/show_bug.cgi?id=37225

        * platform/mac-leopard/fast/text/complex-text-opacity-expected.checksum:
        * platform/mac-leopard/fast/text/complex-text-opacity-expected.png:
        * platform/mac/fast/repaint/stacked-diacritics-expected.checksum:
        * platform/mac/fast/repaint/stacked-diacritics-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Wed, 7 Apr 2010 18:54:31 +0000 (18:54 +0000)]
2010-04-07  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed, skipping fast/media/media-feature-wgt-view-mode.html for Chromium.

        Chromium doesn't implement layoutTestController.setViewModeMediaFeature(), which is needed
        to pass this layout test.

        * platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.checksum: Removed.
        * platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.png: Removed.
        * platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.txt: Removed.
        * platform/chromium/test_expectations.txt: Skip fast/media/media-feature-wgt-view-mode.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFixing TIGER build (take 2)
enrica@apple.com [Wed, 7 Apr 2010 18:44:54 +0000 (18:44 +0000)]
Fixing TIGER build (take 2)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 7 Apr 2010 18:16:56 +0000 (18:16 +0000)]
2010-04-07  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Chromium: support themes in devtools window.

        https://bugs.webkit.org/attachment.cgi?bugid=37216

        * WebKit.gypi:
        * src/js/DevTools.js:
        (WebInspector.setToolbarColors):
        (WebInspector.resetToolbarColors):
        * src/js/Images/segmentChromium2.png: Added.
        * src/js/Images/segmentHoverChromium2.png: Added.
        * src/js/Images/segmentSelectedChromium2.png: Added.
        * src/js/Images/statusbarBackgroundChromium2.png: Added.
        * src/js/Images/statusbarMenuButtonChromium2.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Wed, 7 Apr 2010 18:12:38 +0000 (18:12 +0000)]
2010-04-07  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed, checking in missing image baselines for fast/layers/video-layer.html

        * platform/chromium-linux/fast/layers/video-layer-expected.checksum: Added.
        * platform/chromium-linux/fast/layers/video-layer-expected.png: Added.
        * platform/chromium-mac/fast/layers/video-layer-expected.checksum: Added.
        * platform/chromium-mac/fast/layers/video-layer-expected.png: Added.
        * platform/chromium-win/fast/layers/video-layer-expected.checksum: Updated.
        * platform/chromium-win/fast/layers/video-layer-expected.png: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=37219
enrica@apple.com [Wed, 7 Apr 2010 17:59:49 +0000 (17:59 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=37219

Reviewed by Darin Adler.

JavaScriptCore:

This change disables text caret for the iPhone platflorm.

* wtf/Platform.h: Disabled text caret for iPhone.

WebCore:

This change disables text caret for the iPhone platflorm.
Added UNUSED_PARAM to build when ENABLE_TEXT_CARET is 0.

* editing/SelectionController.cpp:
(WebCore::SelectionController::recomputeCaretRect):
(WebCore::SelectionController::paintCaret):
* page/Frame.cpp:
(WebCore::Frame::paintDragCaret):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFixing TIGER build
enrica@apple.com [Wed, 7 Apr 2010 17:57:10 +0000 (17:57 +0000)]
Fixing TIGER build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoText repainting does not account for glyphs which draw outside the typographic bounds...
enrica@apple.com [Wed, 7 Apr 2010 17:06:16 +0000 (17:06 +0000)]
Text repainting does not account for glyphs which draw outside the typographic bounds of the font (6274).
<rdar://problem/6649734>
<https://bugs.webkit.org/show_bug.cgi?id=6274>

Reviewed by Dave Hyatt.

* fast/repaint/stacked-diacritics.html: Added.
* platform/mac/fast/repaint/stacked-diacritics-expected.checksum: Added.
* platform/mac/fast/repaint/stacked-diacritics-expected.png: Added.
* platform/mac/fast/repaint/stacked-diacritics-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Text repainting does not account for glyphs which draw outside the typograph...
enrica@apple.com [Wed, 7 Apr 2010 17:01:52 +0000 (17:01 +0000)]
WebCore: Text repainting does not account for glyphs which draw outside the typographic bounds of the font (6274).
<rdar://problem/6649734>
<https://bugs.webkit.org/show_bug.cgi?id=6274>

Reviewed by Dave Hyatt.

In order to be able to handle successfully this case, it is necessary to change the glyph width cache to store
the bounding box for the glyph instead of the simply caching the glyph width.
Retrieving the bounding box for the glyph is expensive, therefore we do it only
when we are rendering text using the complex text path to minimize the performance impact.
To support characters with stacked diacritics, the method canUseGlyphCache has been modified to
return false for the range of characters with stacked diacritics.
The glyph cache has been also updated to allow storing the glyph bounding box together with the
horizontal width. The bounding box is populated only for complex text.

The original version of this patch has been written by Dan Bernstein.

Test: fast/repaint/stacked-diacritics.html

* Android.mk: File name change.
* GNUmakefile.am: File name change.
* WebCore.base.exp: Added parameter in exported function.
* WebCore.gypi: File name change.
* WebCore.vcproj/WebCore.vcproj: File name change.
* WebCore.xcodeproj/project.pbxproj: File name change.
* platform/graphics/Font.cpp:
(WebCore::Font::floatWidth): Added glyphOverflow parameter.
* platform/graphics/Font.h:
(WebCore::GlyphOverflow::GlyphOverflow): Added.
(WebCore::Font::width): Added glyphOverflow parameter.
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::canUseGlyphCache): Modified to render characters with stacked diacritics with complex text path.
* platform/graphics/GlyphMetricsMap.cpp: Copied from WebCore/platform/graphics/GlyphWidthMap.cpp.
(WebCore::GlyphMetricsMap::locatePageSlowCase): Class name changed to reflect new semantics.
* platform/graphics/GlyphMetricsMap.h: Copied from WebCore/platform/graphics/GlyphWidthMap.h.
(WebCore::GlyphMetricsMap::GlyphMetricsMap):
(WebCore::GlyphMetricsMap::~GlyphMetricsMap):
(WebCore::GlyphMetricsMap::metricsForGlyph):
(WebCore::GlyphMetricsMap::widthForGlyph):
(WebCore::GlyphMetricsMap::setMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::metricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForIndex):
(WebCore::GlyphMetricsMap::locatePage):
* platform/graphics/GlyphWidthMap.cpp: Removed.
* platform/graphics/GlyphWidthMap.h: Removed.
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::platformGlyphInit):
* platform/graphics/SimpleFontData.h:
(WebCore::):
(WebCore::SimpleFontData::widthForGlyph):
(WebCore::SimpleFontData::metricsForGlyph):
* platform/graphics/cairo/SimpleFontDataCairo.cpp:
(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.
* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::Font::floatWidthForComplexText): Added parameter.
* platform/graphics/chromium/FontLinux.cpp:
(WebCore::Font::floatWidthForComplexText): Added parameter.
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.
* platform/graphics/chromium/SimpleFontDataLinux.cpp:
(WebCore::SimpleFontData::platformWidthForGlyph): Name and signature vachange
* platform/graphics/efl/FontEfl.cpp:
(WebCore::Font::floatWidthForComplexText): Name and signature change.
* platform/graphics/gtk/SimpleFontDataPango.cpp:
(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.
* platform/graphics/haiku/FontHaiku.cpp:
(WebCore::Font::floatWidthForComplexText): Added parameter.
* platform/graphics/haiku/SimpleFontDataHaiku.cpp:
(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
* platform/graphics/mac/ComplexTextController.h:
(WebCore::ComplexTextController::minGlyphBoundingBoxX):
(WebCore::ComplexTextController::maxGlyphBoundingBoxX):
(WebCore::ComplexTextController::minGlyphBoundingBoxY):
(WebCore::ComplexTextController::maxGlyphBoundingBoxY):
* platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::floatWidthForComplexText): Added paramter.
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.
* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::floatWidthForComplexText): Added paramter.
* platform/graphics/win/FontWin.cpp:
(WebCore::Font::floatWidthForComplexText): Added parameter.
* platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.
* platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::metricsForGDIGlyph):
* platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::UniscribeController):
(WebCore::UniscribeController::shapeAndPlaceItem):
* platform/graphics/win/UniscribeController.h:
(WebCore::UniscribeController::minGlyphBoundingBoxX):
(WebCore::UniscribeController::maxGlyphBoundingBoxX):
(WebCore::UniscribeController::minGlyphBoundingBoxY):
(WebCore::UniscribeController::maxGlyphBoundingBoxY):
* platform/graphics/wince/FontWince.cpp:
(WebCore::Font::floatWidthForComplexText): Added parameter.
* platform/graphics/wx/FontWx.cpp:
(WebCore::Font::floatWidthForComplexText): Added parameter.
* platform/graphics/wx/SimpleFontDataWx.cpp:
(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesHorizontally):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::computeVerticalOverflow):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::setFallbackFonts):
(WebCore::InlineTextBox::fallbackFonts):
(WebCore::InlineTextBox::setGlyphOverflow):
(WebCore::InlineTextBox::glyphOverflow):
* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::clearGlyphOverflowAndFallbackFontMap): Added.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeHorizontalPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
* rendering/RenderText.cpp:
(WebCore::RenderText::RenderText):
(WebCore::RenderText::styleDidChange):
(WebCore::RenderText::widthFromCache):
(WebCore::RenderText::trimmedPrefWidths):
(WebCore::RenderText::calcPrefWidths):
(WebCore::RenderText::setText):
(WebCore::RenderText::width):
* rendering/RenderText.h:

LayoutTests: Text repainting does not account for glyphs which draw outside the typographic bounds of the font (6274).
<rdar://problem/6649734>
<https://bugs.webkit.org/show_bug.cgi?id=6274>

Reviewed by Dave Hyatt.

* fast/repaint/stacked-diacritics.html: Added.
* platform/mac/fast/repaint/stacked-diacritics-expected.checksum: Added.
* platform/mac/fast/repaint/stacked-diacritics-expected.png: Added.
* platform/mac/fast/repaint/stacked-diacritics-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Joseph Pecoraro <joepeck@webkit.org>
eric@webkit.org [Wed, 7 Apr 2010 16:53:38 +0000 (16:53 +0000)]
2010-04-07  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Darin Adler.

        Fix incorrect white-space in WebGLRenderingContext.idl
        https://bugs.webkit.org/show_bug.cgi?id=31339

        * html/canvas/WebGLRenderingContext.idl: Remove offending extra whitespace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Rodrigo Belem <rodrigo.belem@openbossa.org>
eric@webkit.org [Wed, 7 Apr 2010 16:43:53 +0000 (16:43 +0000)]
2010-04-07  Rodrigo Belem  <rodrigo.belem@openbossa.org>

        Reviewed by Simon Hausmann.

        [Qt] The build system is not installing the generated headers (QGraphicsWebView, QWebDatabase, etc)
        https://bugs.webkit.org/show_bug.cgi?id=37173

        This patch sets the correct path to the classheaders.pri and then
        fixes the installation of the generated headers.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Wed, 7 Apr 2010 16:33:34 +0000 (16:33 +0000)]
2010-04-07  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        Add ewk_view (the high level object to acces the WebKit-EFL browser
        component) to efl/ewk.
        http://webkit.org/b/35932

        * efl/ewk/ewk_view.cpp: Added.
        * efl/ewk/ewk_view.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSpatial Navigation: bail out as soon as algorithm finds a focus candidate is not...
tonikitoo@webkit.org [Wed, 7 Apr 2010 16:32:10 +0000 (16:32 +0000)]
Spatial Navigation: bail out as soon as algorithm finds a focus candidate is not applicable https://bugs.webkit.org/show_bug.cgi?id=37135

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

It happens, for example, when distanceDataForNode assigns numeric_limits<long long> to
current focus candidate's. It means that current candidate is not in direction, or not
a valid target node.

* page/FocusController.cpp:
(WebCore::FocusController::findFocusableNodeInDirection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Andrey Kosyakov <caseq@chromium.org>
eric@webkit.org [Wed, 7 Apr 2010 16:18:38 +0000 (16:18 +0000)]
2010-04-07  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Removed inspector methods from ScriptExecutionContext and derived classes.
        Removed MessageDestination parameter from console-related calls (we now always
        log to the same destination(s)).
        Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
        https://bugs.webkit.org/show_bug.cgi?id=36949

        * dom/Document.cpp:
        (WebCore::Document::reportException):
        (WebCore::Document::addMessage):
        * dom/Document.h:
        * dom/ScriptExecutionContext.h:
        * loader/EmptyClients.h:
        (WebCore::EmptyFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
        * loader/FrameLoaderClient.h:
        * loader/ResourceLoadNotifier.cpp:
        * loader/ResourceLoadNotifier.h:
        * websockets/WebSocket.cpp:
        (WebCore::WebSocket::connect):
        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::didOpen):
        (WebCore::WebSocketChannel::appendToBuffer):
        * websockets/WebSocketHandshake.cpp:
        (WebCore::WebSocketHandshake::readServerHandshake):
        (WebCore::WebSocketHandshake::readHTTPHeaders):
        (WebCore::WebSocketHandshake::checkResponseHeaders):
        * workers/DefaultSharedWorkerRepository.cpp:
        (WebCore::postConsoleMessageTask):
        (WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::importScripts):
        (WebCore::WorkerContext::addMessage):
        * workers/WorkerContext.h:
        * workers/WorkerMessagingProxy.cpp:
        (WebCore::postConsoleMessageTask):
        (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
        * workers/WorkerMessagingProxy.h:
        * workers/WorkerReportingProxy.h:
        * xml/XMLHttpRequest.cpp:
        (WebCore::reportUnsafeUsage):
        (WebCore::XMLHttpRequest::didFinishLoading):
2010-04-07  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Removed inspector methods from ScriptExecutionContext and derived classes.
        Removed MessageDestination parameter from console-related calls (we now always
        log to the same destination(s)).
        Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
        https://bugs.webkit.org/show_bug.cgi?id=36949

        * public/WebCommonWorkerClient.h:
        (WebKit::WebCommonWorkerClient::postConsoleMessageToWorkerObject):
        * src/FrameLoaderClientImpl.cpp:
        * src/FrameLoaderClientImpl.h:
        * src/WebWorkerBase.cpp:
        (WebKit::WebWorkerBase::postConsoleMessageToWorkerObject):
        (WebKit::WebWorkerBase::postConsoleMessageTask):
        * src/WebWorkerBase.h:
        * src/WebWorkerClientImpl.cpp:
        (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject):
        (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObjectTask):
        * src/WebWorkerClientImpl.h:
2010-04-07  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
        https://bugs.webkit.org/show_bug.cgi?id=36949

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        * WebCoreSupport/FrameLoaderClientGtk.h:
2010-04-07  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
        https://bugs.webkit.org/show_bug.cgi?id=36949

        * WebCoreSupport/FrameLoaderClientHaiku.cpp:
        * WebCoreSupport/FrameLoaderClientHaiku.h:
2010-04-07  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
        https://bugs.webkit.org/show_bug.cgi?id=36949

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
2010-04-07  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
        https://bugs.webkit.org/show_bug.cgi?id=36949

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        * WebCoreSupport/FrameLoaderClientQt.h:
2010-04-07  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
        https://bugs.webkit.org/show_bug.cgi?id=36949

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        * WebCoreSupport/WebFrameLoaderClient.h:
2010-04-07  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
        https://bugs.webkit.org/show_bug.cgi?id=36949

        * WebKitSupport/FrameLoaderClientWx.cpp:
        * WebKitSupport/FrameLoaderClientWx.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Wed, 7 Apr 2010 15:52:54 +0000 (15:52 +0000)]
2010-04-07  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] WebIDBDatabaseError::assign doesn't work correctly
        https://bugs.webkit.org/show_bug.cgi?id=37209

        * src/WebIDBDatabaseError.cpp:
        (WebKit::WebIDBDatabaseError::assign):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=36827
hausmann@webkit.org [Wed, 7 Apr 2010 14:14:27 +0000 (14:14 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=36827

Patch by Dawit Alemayehu <adawit@kde.org> on 2010-04-07
Reviewed by Simon Hausmann.

WebCore:

Replaced the 'shouldTreatAsAttachment' function with a more generic
function that returns the content disposition type.

See comments 39-42 in https://bugs.webkit.org/show_bug.cgi?id=36395

* platform/network/HTTPParsers.cpp:
(WebCore::contentDispositionType):
* platform/network/HTTPParsers.h:
(WebCore::):

WebKit/chromium:

Updated the WebCore::shouldTreatAsAttachement function call with the
new more generic replacement WebCore::contentDispositionType.

See comments 39-42 in https://bugs.webkit.org/show_bug.cgi?id=36395

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForMIMEType):

WebKit/qt:

Updated the WebCore::shouldTreatAsAttachement function call with the
new more generic replacement WebCore::contentDispositionType.

See comments 39-42 in https://bugs.webkit.org/show_bug.cgi?id=36395

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Wed, 7 Apr 2010 14:04:56 +0000 (14:04 +0000)]
2010-04-07  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Yury Semikhatsky.

        [V8] Throw exception in SerializedScriptValue on input errors
        https://bugs.webkit.org/show_bug.cgi?id=37160

        When cycles are detected SerializedScriptValue should throw
        NOT_SUPPORTED_ERR. See
        http://www.whatwg.org/specs/web-apps/2009-10-27/multipage/urls.html#structured-clone

        * bindings/scripts/CodeGeneratorV8.pm: Custom processing for
        function arguments of type SerializedScriptValue.

        * bindings/v8/SerializedScriptValue.cpp:
        (WebCore::SerializedScriptValue::SerializedScriptValue):
        * bindings/v8/SerializedScriptValue.h:
        (WebCore::SerializedScriptValue::create): Added a constructor
        function with an extra paratemer to check whether an exception was
        thrown.

        SerializedScriptValue::create callers updated to check for
        exceptions:
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::V8DOMWindow::postMessageCallback):
        * bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
        (WebCore::V8DedicatedWorkerContext::postMessageCallback):
        * bindings/v8/custom/V8HistoryCustom.cpp:
        (WebCore::V8History::pushStateCallback):
        (WebCore::V8History::replaceStateCallback):
        * bindings/v8/custom/V8MessagePortCustom.cpp:
        (WebCore::V8MessagePort::postMessageCallback):
        * bindings/v8/custom/V8PopStateEventCustom.cpp:
        (WebCore::V8PopStateEvent::initPopStateEventCallback):
        * bindings/v8/custom/V8WorkerCustom.cpp:
        (WebCore::V8Worker::postMessageCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 7 Apr 2010 13:10:59 +0000 (13:10 +0000)]
2010-04-07  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Provide a placeholder for resources with no content available
        https://bugs.webkit.org/show_bug.cgi?id=37142

        * English.lproj/localizedStrings.js:
        * inspector/front-end/ImageView.js:
        (WebInspector.ImageView):
        (WebInspector.ImageView.prototype.contentTabSelected):
        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView.prototype._innerSelectContentTab):
        (WebInspector.ResourceView.prototype.contentTabSelected):
        * inspector/front-end/inspector.css:
        (.resource-content-unavailable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=36750
hausmann@webkit.org [Wed, 7 Apr 2010 12:48:59 +0000 (12:48 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=36750

Reviewed by Laszlo Gombos.

[Qt] Package build without touch support is broken

Use the conditional attribute instead of #ifdefs in the idl file for the
touch specific properties, to make the generated files compile with and
without the touch events enabled.

* dom/Document.idl: Use conditional instead of #ifdef.
* dom/Element.idl: Ditto.
* page/DOMWindow.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd the touch event related IDL files to the idl generation, so that
hausmann@webkit.org [Wed, 7 Apr 2010 12:03:51 +0000 (12:03 +0000)]
Add the touch event related IDL files to the idl generation, so that
they can be safely included from generated JS bindings files. The
generated files have #ifdef feature guards.

Reviewed by Holger Freyther.

* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Wed, 7 Apr 2010 11:39:31 +0000 (11:39 +0000)]
2010-04-06  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Adam Barth.

        V8CustomIDBCallbacks<> should not hold a reference to the frame
        https://bugs.webkit.org/show_bug.cgi?id=37154

        Don't hold on to a Frame reference.
        Instead, be an ActiveDOMObject and use scriptExecutionContext()
        to get the v8 context.
        Factor the guts of onSuccess and onError out.

        Doesn't work enough to test yet.

        * bindings/v8/custom/V8CustomIDBCallbacks.h:
        (WebCore::V8CustomIDBCallbacks::create):
        (WebCore::V8CustomIDBCallbacks::onSuccess):
        (WebCore::V8CustomIDBCallbacks::onError):
        (WebCore::V8CustomIDBCallbacks::V8CustomIDBCallbacks):
        (WebCore::V8CustomIDBCallbacks::onEvent):
        * bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp:
        (WebCore::V8IndexedDatabaseRequest::openCallback):
        * storage/IDBCallbacks.h:
        (WebCore::IDBCallbacks::IDBCallbacks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Andreas Kling <andreas.kling@nokia.com>
eric@webkit.org [Wed, 7 Apr 2010 11:14:59 +0000 (11:14 +0000)]
2010-04-07  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] When providing a widget for the PDF mime type it will cause a crash

        m_pluginView may actually be a Widget (for embedded Qt widgets),
        so always check isPluginView() before calling PluginView specific methods.

        https://bugs.webkit.org/show_bug.cgi?id=29450

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::finishedLoading):
        (WebCore::FrameLoaderClientQt::setMainDocumentError):
        (WebCore::FrameLoaderClientQt::committedLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Wed, 7 Apr 2010 10:19:30 +0000 (10:19 +0000)]
2010-04-07  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r57196.
        http://trac.webkit.org/changeset/57196
        https://bugs.webkit.org/show_bug.cgi?id=37196

        Multiple layout test failures on Chromium (Requested by yurys
        on #webkit).

        * inspector/timeline-test.js:
2010-04-07  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r57196.
        http://trac.webkit.org/changeset/57196
        https://bugs.webkit.org/show_bug.cgi?id=37196

        Multiple layout test failures on Chromium (Requested by yurys
        on #webkit).

        * bindings/js/ScriptCallStack.cpp:
        (WebCore::ScriptCallStack::callLocation):
        * bindings/js/ScriptCallStack.h:
        * bindings/v8/ScriptCallStack.cpp:
        (WebCore::ScriptCallStack::create):
        (WebCore::ScriptCallStack::callLocation):
        (WebCore::ScriptCallStack::ScriptCallStack):
        * bindings/v8/ScriptCallStack.h:
        * bindings/v8/ScriptDebugServer.cpp:
        * bindings/v8/ScriptDebugServer.h:
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::createUtilityContext):
        (WebCore::V8Proxy::sourceLineNumber):
        (WebCore::V8Proxy::sourceName):
        * bindings/v8/V8Proxy.h:
        (WebCore::V8Proxy::utilityContext):
        * inspector/TimelineRecordFactory.cpp:
        (WebCore::TimelineRecordFactory::createGenericRecord):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, rolling out r57199.
hausmann@webkit.org [Wed, 7 Apr 2010 09:19:24 +0000 (09:19 +0000)]
Unreviewed, rolling out r57199.
http://trac.webkit.org/changeset/57199
https://bugs.webkit.org/show_bug.cgi?id=36750

Breaks non-touch enabled build

* dom/Document.idl:
* dom/Element.idl:
* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=36750
hausmann@webkit.org [Wed, 7 Apr 2010 09:08:25 +0000 (09:08 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=36750

Reviewed by Laszlo Gombos.

[Qt] Package build without touch support is broken

Use the conditional attribute instead of #ifdefs in the idl file for the
touch specific properties, to make the generated files compile with and
without the touch events enabled.

* dom/Document.idl: Use conditional instead of #ifdef.
* dom/Element.idl: Ditto.
* page/DOMWindow.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Wed, 7 Apr 2010 08:15:43 +0000 (08:15 +0000)]
2010-04-07  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix trunk (non-standalone) builds for Symbian
        https://bugs.webkit.org/show_bug.cgi?id=37136

        Test for source files before building instead of relying on
        standalone_package config.

        * WebKit.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Jochen Eisinger <jochen@chromium.org>
eric@webkit.org [Wed, 7 Apr 2010 07:39:29 +0000 (07:39 +0000)]
2010-04-07  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Darin Fisher.

        Add createApplicationCacheHost to WebFrameClient so
        the ApplicationCacheHost has access to its frame.

        https://bugs.webkit.org/show_bug.cgi?id=36882

        * public/WebFrameClient.h:
        (WebKit::WebFrameClient::createApplicationCacheHost):
        * src/ApplicationCacheHostInternal.h:
        (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-07 Jaime Yap <jaimeyap@google.com>
eric@webkit.org [Wed, 7 Apr 2010 07:20:09 +0000 (07:20 +0000)]
2010-04-07  Jaime Yap  <jaimeyap@google.com>

        Reviewed by Yury Semikhatsky.

        Adds callerFuncName to the list of nondeterministic fields in the timeline
        layout tests.
        https://bugs.webkit.org/show_bug.cgi?id=36839

        * inspector/timeline-test.js:
2010-04-07  Jaime Yap  <jaimeyap@google.com>

        Reviewed by Yury Semikhatsky.

        Adds the ability to get the function symbol name when looking up the call location
        for records sent by the InspectorTimelineAgent.
        https://bugs.webkit.org/show_bug.cgi?id=36839

        No new tests.

        * bindings/js/ScriptCallStack.cpp:
        (WebCore::ScriptCallStack::callLocation):
        * bindings/js/ScriptCallStack.h:
        * bindings/v8/ScriptCallStack.cpp:
        (WebCore::ScriptCallStack::create):
        (WebCore::ScriptCallStack::callLocation):
        (WebCore::ScriptCallStack::ScriptCallStack):
        * bindings/v8/ScriptCallStack.h:
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::createUtilityContext):
        (WebCore::ScriptDebugServer::lastCallFrame):
        * bindings/v8/ScriptDebugServer.h:
        (WebCore::ScriptDebugServer::utilityContext):
        * bindings/v8/V8Proxy.cpp:
        * bindings/v8/V8Proxy.h:
        * inspector/TimelineRecordFactory.cpp:
        (WebCore::TimelineRecordFactory::createGenericRecord):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-31 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 7 Apr 2010 06:40:53 +0000 (06:40 +0000)]
2010-03-31  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add webkit-patch command to crawl buildbot history and find when tests
        started to fail.
        https://bugs.webkit.org/show_bug.cgi?id=36911

        This is a very bare-bones implementation, which works, but isn't pretty.
        We will need further re-factoring and improvement to this code, but
        after long discussions with Adam, I think it's best that we land this
        and iterate from there.

        * Scripts/webkitpy/common/net/buildbot.py:
         - Add revision_build_pairs_with_results for cleaner code and possible
           optimization of this command.
         - Return None if a build number can't be found for a revision in
           build_for_revision
         - Separate out suspect_revisions_for_transition for re-use by
           FailureReason
         - Add LayoutTestResults.failing_tests() and make our parsing code
           explict about what tables it accepts.
        * Scripts/webkitpy/tool/commands/queries.py:
         - Move _print_blame_information_for_commit out of WhatBroke for re-use
           by FailureReason.
         - Add FailureReason command which can crawl a given builder and explain
           why it is currently red on a per-test basis.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=37188
bolsinga@apple.com [Wed, 7 Apr 2010 05:14:46 +0000 (05:14 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=37188
WebCore::page::Geolocation::m_shouldClearCache is not used.

Reviewed by Darin Adler.

* page/Geolocation.cpp:
(WebCore::Geolocation::Geolocation): Remove m_shouldClearCache.
* page/Geolocation.h:
(WebCore::Geolocation::): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Wed, 7 Apr 2010 04:58:29 +0000 (04:58 +0000)]
2010-04-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        Remove obsolete MOBILE flag
        https://bugs.webkit.org/show_bug.cgi?id=37125

        The MOBILE flag is no longer used by any of the ports.
        The flag use to control some tokenizer defaults that
        can be changed runtime.

        No new tests as there is no new functionality.

        * config.h:
        * html/HTMLTokenizer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Adam Barth <abarth@webkit.org>
eric@webkit.org [Wed, 7 Apr 2010 04:38:23 +0000 (04:38 +0000)]
2010-04-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        REGRESSION: Worker termination via JS timeout may cause worker tests like fast/workers/worker-terminate.html fail.
        https://bugs.webkit.org/show_bug.cgi?id=36646

        Add a new exception type for forcibly terminating a JavaScript stack.
        The new exception functions similarly to the
        InterruptedExecutionException but is conceptually different because
        execution is terminated instead of just interrupted.

        * GNUmakefile.am:
            - Added new Terminator.h file.
        * JavaScriptCore.gypi:
            - Added new Terminator.h file.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
            - Added new Terminator.h file.
        * JavaScriptCore.xcodeproj/project.pbxproj:
            - Added new Terminator.h file.
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::throwException):
            - Fully unwind the stack for TerminatedExecutionException.
        (JSC::Interpreter::privateExecute):
            - Check if we've been terminated at the same time we check if we've
              timed out.
        * jit/JITStubs.cpp:
        (JSC::DEFINE_STUB_FUNCTION):
            - Check if we've been terminated at the same time we check if we've
              timed out.
        * runtime/Completion.cpp:
            - Some exceptions define special completion types so that calls can
              see why we terminated evaluation.
        (JSC::evaluate):
        * runtime/Completion.h:
            - Define a new completion type for termination.
        (JSC::):
        * runtime/ExceptionHelpers.cpp:
            - Define TerminatedExecutionException and refactor pseudo-RTTI
              virtual function to be more semantic.
        (JSC::InterruptedExecutionError::exceptionType):
        (JSC::TerminatedExecutionError::TerminatedExecutionError):
        (JSC::TerminatedExecutionError::exceptionType):
        (JSC::TerminatedExecutionError::toString):
        (JSC::createTerminatedExecutionException):
        * runtime/ExceptionHelpers.h:
            - Entry point for generating a TerminatedExecutionException.
        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData):
            - Add a Terminator object that can be used to asynchronously
              terminate a JavaScript execution stack.
        * runtime/JSGlobalData.h:
        * runtime/JSObject.h:
        (JSC::JSObject::exceptionType):
            - Define that, by default, thrown objects have a normal exception
              type.
        * runtime/Terminator.h: Added.
            - Added a new controller object that can be used to terminate
              execution asynchronously.  This object is more or less a
              glorified bool.
        (JSC::Terminator::Terminator):
        (JSC::Terminator::termianteSoon):
        (JSC::Terminator::shouldTerminate):
2010-04-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        REGRESSION: Worker termination via JS timeout may cause worker tests like fast/workers/worker-terminate.html fail.
        https://bugs.webkit.org/show_bug.cgi?id=36646

        * fast/workers/resources/worker-run-forever.js: Added.
        * fast/workers/worker-terminate-forever-expected.txt: Added.
        * fast/workers/worker-terminate-forever.html: Added.
            - Test what happens when we terminate an infinitely running worker.
              The essential point is that we don't spam the console with
              nonsense about a timeout.
        * platform/mac/Skipped:
            - Rescue worker-terminate.html from the Skipped list now that we've
              fixed the underlying bug that was causing the flakiness.
2010-04-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        REGRESSION: Worker termination via JS timeout may cause worker tests like fast/workers/worker-terminate.html fail.
        https://bugs.webkit.org/show_bug.cgi?id=36646

        Cause the worker code to swallow termination exceptions because these
        need not be reported to the user because they are an implementation
        detail of how we terminate worker execution.

        Test: fast/workers/worker-terminate-forever.html

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::reportException):
            - Refuse to report termination exceptions to the user because they
              are an implementation detail.
        * bindings/js/WorkerScriptController.cpp:
        (WebCore::WorkerScriptController::forbidExecution):
            - Instead of using timeouts to stop run away workers, use our fancy
              new Terminator object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Andrew Scherkus <scherkus@chromium.org>
eric@webkit.org [Wed, 7 Apr 2010 04:17:57 +0000 (04:17 +0000)]
2010-04-06  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Eric Seidel.

        Checking in new baselines for media/video-controls-rendering.html and fast/layers/video-layer.html.
        https://bugs.webkit.org/show_bug.cgi?id=37180

        * platform/chromium-linux/media/video-controls-rendering-expected.checksum: Wasn't rebaselined when Linux scrollbars changed.
        * platform/chromium-linux/media/video-controls-rendering-expected.png: Ditto.
        * platform/chromium-mac/fast/layers/video-layer-expected.txt: Wasn't rebaselined when audio/video UI was refreshed.
        * platform/chromium-win/fast/layers/video-layer-expected.txt: Ditto.
        * platform/chromium/test_expectations.txt: Removed expectations for the above two tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTiger build fix after r57184.
mitz@apple.com [Wed, 7 Apr 2010 03:10:39 +0000 (03:10 +0000)]
Tiger build fix after r57184.

* WebView/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTiger build fix after r57184.
mitz@apple.com [Wed, 7 Apr 2010 02:54:21 +0000 (02:54 +0000)]
Tiger build fix after r57184.

* WebView/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 7 Apr 2010 02:39:43 +0000 (02:39 +0000)]
2010-04-06  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [DRT/Chromium] Add DumpRenderTree.gyp, and some small fixes
        https://bugs.webkit.org/show_bug.cgi?id=37137

        - Add DumpRenderTree.gyp
        - Remove some dependencies to base/string_util.h,
          base/compiler_specific.h, base/file_path.h, base/file_util.h,
          base/message_loop.h, base/sys_string_conversions.h,

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Added.
        * DumpRenderTree/chromium/CppVariant.cpp:
        (CppVariant::toStringVector):
        * DumpRenderTree/chromium/EventSender.cpp:
        (EventSender::EventSender):
        (EventSender::keyDown):
        (EventSender::scheduleAsynchronousClick):
        (EventSender::beginDragWithFiles):
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::setUserStyleSheetLocation):
        (LayoutTestController::pathToLocalResource):
        * DumpRenderTree/chromium/TextInputController.cpp:
        (TextInputController::markedRange):
        (TextInputController::selectedRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 7 Apr 2010 02:33:47 +0000 (02:33 +0000)]
2010-04-06  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        Write stack traces into the results directory for new-run-webkit-tests,
        instead of writing them alongside the test file.

        https://bugs.webkit.org/show_bug.cgi?id=36504

        * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 7 Apr 2010 02:29:32 +0000 (02:29 +0000)]
2010-04-06  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Speculative build fix for Tiger.

        * WebView/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 7 Apr 2010 02:27:04 +0000 (02:27 +0000)]
2010-04-06  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed build fix.

        Enable pixel tests by default in new-run-webkit-tests unless
        explicitly set by the port or by the command line. This was broken in
        the fix for bug 36801 (rev. 57173).

        https://bugs.webkit.org/show_bug.cgi?id=37184

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoExpose WebHTMLView’s page breaking logic as SPI.
mitz@apple.com [Wed, 7 Apr 2010 01:53:25 +0000 (01:53 +0000)]
Expose WebHTMLView’s page breaking logic as SPI.

Reviewed by Sam Weinig and Anders Carlsson.

* WebView/WebHTMLView.mm:
(-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]): Factored out of -adjustPageHeightNew:top:bottom:limit:
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Call -_adjustedBottomOfPageWithTop:bottom:limit:
* WebView/WebHTMLViewPrivate.h: Declared -_adjustedBottomOfPageWithTop:bottom:limit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd an #if in order to make Tiger happy.
mrowe@apple.com [Wed, 7 Apr 2010 01:40:35 +0000 (01:40 +0000)]
Add an #if in order to make Tiger happy.

* WebView/WebViewData.mm:
(-[WebViewPrivate init]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Kinuko Yasuda <kinuko@chromium.org>
eric@webkit.org [Wed, 7 Apr 2010 01:29:04 +0000 (01:29 +0000)]
2010-04-06  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Jian Li.

        Add basic FileSystem operations for FileReader/FileWriter support for POSIX (incl. Mac)
        https://bugs.webkit.org/show_bug.cgi?id=36938

        No new tests; will be added when we implement upper layers.

        * platform/FileSystem.h:
        (WebCore::):
        * platform/posix/FileSystemPOSIX.cpp:
        (WebCore::openFile):
        (WebCore::closeFile):
        (WebCore::seekFile):
        (WebCore::truncateFile):
        (WebCore::writeToFile):
        (WebCore::readFromFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix.
mrowe@apple.com [Wed, 7 Apr 2010 01:15:30 +0000 (01:15 +0000)]
Build fix.

* WebView/WebViewData.mm:
(-[WebViewPrivate init]): Use objc_collectingEnabled like we do elsewhere in WebKit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Nicolas Weber <thakis@chromium.org>
eric@webkit.org [Wed, 7 Apr 2010 01:02:11 +0000 (01:02 +0000)]
2010-04-06  Nicolas Weber  <thakis@chromium.org>

        Reviewed by Dimitri Glazkov.

        Implement DragImage functionality for chromium/mac.
        https://bugs.webkit.org/show_bug.cgi?id=37069

        * page/chromium/DragControllerChromium.cpp:
        (WebCore::DragController::maxDragImageSize):
        Use a max size of 400x400 on OS X.
        * platform/chromium/DragImageChromiumMac.cpp:
        (WebCore::dragImageSize): Implement.
        (WebCore::deleteDragImage): Implement.
        (WebCore::scaleDragImage): Implement.
        (WebCore::dissolveDragImageToFraction): Implement.
        (WebCore::createDragImageFromImage): Implement.
        * platform/chromium/DragImageRef.h:
        Use CGImageRefs as DragImageRef on OS X.
2010-04-06  Nicolas Weber  <thakis@chromium.org>

        Reviewed by Dimitri Glazkov.

        Use drag images on OS X as well.
        https://bugs.webkit.org/show_bug.cgi?id=37069

        * src/DragClientImpl.cpp:
        (WebKit::DragClientImpl::startDrag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoREGRESSION (r57113): editing/inserting/break-blockquote-after-delete.html fails on...
mrowe@apple.com [Tue, 6 Apr 2010 23:37:21 +0000 (23:37 +0000)]
REGRESSION (r57113): editing/inserting/break-blockquote-after-delete.html fails on Windows
<http://webkit.org/b/37156> / <rdar://problem/7832408>

Rubber-stamped by Oliver Hunt.

Land Windows-specific results for editing/inserting/break-blockquote-after-delete.html.  <rdar://problem/7834280>
tracks understanding the root cause of this difference between Mac and Windows.

* platform/win/editing/inserting/break-blockquote-after-delete-expected.checksum: Copied from LayoutTests/platform/mac/editing/inserting/break-blockquote-after-delete-expected.checksum.
* platform/win/editing/inserting/break-blockquote-after-delete-expected.png: Copied from LayoutTests/platform/mac/editing/inserting/break-blockquote-after-delete-expected.png.
* platform/win/editing/inserting/break-blockquote-after-delete-expected.txt: Copied from LayoutTests/platform/chromium-mac/editing/inserting/break-blockquote-after-delete-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Chris Evans <cevans@chromium.org>
eric@webkit.org [Tue, 6 Apr 2010 23:36:41 +0000 (23:36 +0000)]
2010-04-06  Chris Evans  <cevans@chromium.org>

        Reviewed by Adam Barth.

        Add test for javascript:window.open() popup blocker bypass.
        https://bugs.webkit.org/show_bug.cgi?id=37138

        * fast/events/popup-blocked-from-window-open.html: added
        * fast/events/popup-blocked-from-window-open-expected.txt: added
2010-04-06  Chris Evans  <cevans@chromium.org>

        Reviewed by Adam Barth.

        Use the new UserGestureIndictor to process javascript:window.open()

        https://bugs.webkit.org/show_bug.cgi?id=37138

        * bindings/v8/ScriptController.cpp
        (WebCore::ScriptController::processingUserGesture):
          Use the new UserGestureIndicator when processing a
          javascript:window.open()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Adam Barth <abarth@webkit.org>
eric@webkit.org [Tue, 6 Apr 2010 23:27:01 +0000 (23:27 +0000)]
2010-04-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        transitions/transition-end-event-transform.html fails intermittently on Tiger Intel Release bot
        https://bugs.webkit.org/show_bug.cgi?id=37145

        The timeout on this test is wrong because the helper library assumes
        that we're only going to do one transition, but the test actually does
        two in sequence.  This patch doubles the timeout to account for that.

        The design of these tests are quite unfortunate because these timeout
        behaviors don't seem like they'd be reliable on slow machines like
        Tiger.  I'm not 100% convinced that this will fix the flakiness, but it
        seems like an improvement.

        I'll file a separate bug about DRT leaking state from one test to
        another.

        * transitions/transition-end-event-helpers.js:
        * transitions/transition-end-event-set-none.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Vangelis Kokkevis <vangelis@chromium.org>
eric@webkit.org [Tue, 6 Apr 2010 23:17:00 +0000 (23:17 +0000)]
2010-04-06  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Dimitri Glazkov.

        Renaming Graphics Layer related classes used by Chromium from *Skia to *Chromium and replacing wherever possible Skia-specific
        data types with WebCore equivalents. The source files will be renamed accordingly and moved out of platform/graphics/skia
        in a subsequent CL.
        https://bugs.webkit.org/show_bug.cgi?id=37116

        No new functionality so no new tests.

        * platform/graphics/GraphicsLayer.h:
        * platform/graphics/skia/GraphicsLayerSkia.cpp:
        (WebCore::setLayerBorderColor):
        (WebCore::clearBorderColor):
        (WebCore::setLayerBackgroundColor):
        (WebCore::clearLayerBackgroundColor):
        (WebCore::GraphicsLayer::create):
        (WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
        (WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
        (WebCore::GraphicsLayerChromium::setName):
        (WebCore::GraphicsLayerChromium::nativeLayer):
        (WebCore::GraphicsLayerChromium::setChildren):
        (WebCore::GraphicsLayerChromium::addChild):
        (WebCore::GraphicsLayerChromium::addChildAtIndex):
        (WebCore::GraphicsLayerChromium::addChildBelow):
        (WebCore::GraphicsLayerChromium::addChildAbove):
        (WebCore::GraphicsLayerChromium::replaceChild):
        (WebCore::GraphicsLayerChromium::removeFromParent):
        (WebCore::GraphicsLayerChromium::setPosition):
        (WebCore::GraphicsLayerChromium::setAnchorPoint):
        (WebCore::GraphicsLayerChromium::setSize):
        (WebCore::GraphicsLayerChromium::setTransform):
        (WebCore::GraphicsLayerChromium::setChildrenTransform):
        (WebCore::GraphicsLayerChromium::setPreserves3D):
        (WebCore::GraphicsLayerChromium::setMasksToBounds):
        (WebCore::GraphicsLayerChromium::setDrawsContent):
        (WebCore::GraphicsLayerChromium::setBackgroundColor):
        (WebCore::GraphicsLayerChromium::clearBackgroundColor):
        (WebCore::GraphicsLayerChromium::setContentsOpaque):
        (WebCore::GraphicsLayerChromium::setBackfaceVisibility):
        (WebCore::GraphicsLayerChromium::setOpacity):
        (WebCore::GraphicsLayerChromium::setNeedsDisplay):
        (WebCore::GraphicsLayerChromium::setNeedsDisplayInRect):
        (WebCore::GraphicsLayerChromium::setContentsRect):
        (WebCore::GraphicsLayerChromium::setContentsToImage):
        (WebCore::GraphicsLayerChromium::setContentsToVideo):
        (WebCore::GraphicsLayerChromium::setGeometryOrientation):
        (WebCore::GraphicsLayerChromium::hostLayerForSublayers):
        (WebCore::GraphicsLayerChromium::layerForSuperlayer):
        (WebCore::GraphicsLayerChromium::platformLayer):
        (WebCore::GraphicsLayerChromium::setDebugBackgroundColor):
        (WebCore::GraphicsLayerChromium::setDebugBorder):
        (WebCore::GraphicsLayerChromium::updateSublayerList):
        (WebCore::GraphicsLayerChromium::updateLayerPosition):
        (WebCore::GraphicsLayerChromium::updateLayerSize):
        (WebCore::GraphicsLayerChromium::updateAnchorPoint):
        (WebCore::GraphicsLayerChromium::updateTransform):
        (WebCore::GraphicsLayerChromium::updateChildrenTransform):
        (WebCore::GraphicsLayerChromium::updateMasksToBounds):
        (WebCore::GraphicsLayerChromium::updateContentsOpaque):
        (WebCore::GraphicsLayerChromium::updateBackfaceVisibility):
        (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
        (WebCore::GraphicsLayerChromium::updateLayerDrawsContent):
        (WebCore::GraphicsLayerChromium::updateLayerBackgroundColor):
        (WebCore::GraphicsLayerChromium::updateContentsImage):
        (WebCore::GraphicsLayerChromium::updateContentsVideo):
        (WebCore::GraphicsLayerChromium::updateContentsRect):
        (WebCore::GraphicsLayerChromium::updateGeometryOrientation):
        (WebCore::GraphicsLayerChromium::setupContentsLayer):
        (WebCore::GraphicsLayerChromium::updateOpacityOnLayer):
        * platform/graphics/skia/GraphicsLayerSkia.h:
        (WebCore::GraphicsLayerChromium::primaryLayer):
        (WebCore::GraphicsLayerChromium::contentsLayer):
        * platform/graphics/skia/LayerRendererSkia.cpp:
        (WebCore::LayerRendererChromium::create):
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::~LayerRendererChromium):
        (WebCore::LayerRendererChromium::updateLayerContents):
        (WebCore::LayerRendererChromium::drawLayersInCanvas):
        (WebCore::LayerRendererChromium::drawLayerInCanvasRecursive):
        (WebCore::LayerRendererChromium::updateLayerContentsRecursive):
        * platform/graphics/skia/LayerRendererSkia.h:
        (WebCore::LayerRendererChromium::setRootLayer):
        (WebCore::LayerRendererChromium::rootLayer):
        * platform/graphics/skia/LayerSkia.cpp:
        (WebCore::LayerChromium::create):
        (WebCore::LayerChromium::LayerChromium):
        (WebCore::LayerChromium::~LayerChromium):
        (WebCore::LayerChromium::updateGraphicsContext):
        (WebCore::LayerChromium::updateContents):
        (WebCore::LayerChromium::drawDebugBorder):
        (WebCore::LayerChromium::setNeedsCommit):
        (WebCore::LayerChromium::addSublayer):
        (WebCore::LayerChromium::insertSublayer):
        (WebCore::LayerChromium::removeFromSuperlayer):
        (WebCore::LayerChromium::removeSublayer):
        (WebCore::LayerChromium::indexOfSublayer):
        (WebCore::LayerChromium::setBackingStoreRect):
        (WebCore::LayerChromium::setBounds):
        (WebCore::LayerChromium::setFrame):
        (WebCore::LayerChromium::rootLayer):
        (WebCore::LayerChromium::removeAllSublayers):
        (WebCore::LayerChromium::setSublayers):
        (WebCore::LayerChromium::setSuperlayer):
        (WebCore::LayerChromium::superlayer):
        (WebCore::LayerChromium::setNeedsDisplay):
        * platform/graphics/skia/LayerSkia.h:
        (WebCore::LayerChromium::setAnchorPoint):
        (WebCore::LayerChromium::anchorPoint):
        (WebCore::LayerChromium::borderWidth):
        (WebCore::LayerChromium::bounds):
        (WebCore::LayerChromium::frame):
        (WebCore::LayerChromium::setPosition):
        (WebCore::LayerChromium::position):
        (WebCore::LayerChromium::zPosition):
        (WebCore::LayerChromium::getSublayers):
        (WebCore::LayerChromium::setSublayerTransform):
        (WebCore::LayerChromium::sublayerTransform):
        (WebCore::LayerChromium::setTransform):
        (WebCore::LayerChromium::transform):
2010-04-06  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Dimitri Glazkov.

        Changing references to Graphics Layer related classes from *Skia to *Chromium.
        https://bugs.webkit.org/show_bug.cgi?id=37116

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::paint):
        (WebKit::WebViewImpl::setAcceleratedCompositing):
        (WebKit::WebViewImpl::updateRootLayerContents):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>
eric@webkit.org [Tue, 6 Apr 2010 23:04:44 +0000 (23:04 +0000)]
2010-04-06  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] These tests can be removed from the skipped list since these
        work after the redirection loop detection implemented in qt network.
        https://bugs.webkit.org/show_bug.cgii?id=36690

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
eric@webkit.org [Tue, 6 Apr 2010 22:55:10 +0000 (22:55 +0000)]
2010-04-06  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>

        Reviewed by Laszlo Gombos.

        [Qt] WebKit does not build on Windows with --3d-canvas
        https://bugs.webkit.org/show_bug.cgi?id=37026

        * platform/graphics/GraphicsContext3D.h:
        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3D::getActiveAttrib):
        (WebCore::GraphicsContext3D::getActiveUniform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 6 Apr 2010 22:47:49 +0000 (22:47 +0000)]
2010-04-06  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        Disable pixel tests on the mac port by default.

        Also, revamp the way we check for pixel tests being enabled or
        disabled. We now look for options.pixel_tests instead of
        options.no_pixel_tests, and we have the "--pixel-tests" (force enable)
        and "--no-pixel-tests" (force disable) flags.

        https://bugs.webkit.org/show_bug.cgi?id=36801

        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Diego Gonzalez <diego.gonzalez@openbossa.org>
eric@webkit.org [Tue, 6 Apr 2010 22:42:58 +0000 (22:42 +0000)]
2010-04-06  Diego Gonzalez  <diego.gonzalez@openbossa.org>

        Reviewed by Laszlo Gombos.

        [Qt] Added the iPhone and iPad latest user agent in QtLauncher UA switcher
        https://bugs.webkit.org/show_bug.cgi?id=37159

        * QtLauncher/useragentlist.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 James Hawkins <jhawkins@chromium.org>
jhawkins@chromium.org [Tue, 6 Apr 2010 22:39:02 +0000 (22:39 +0000)]
2010-04-06  James Hawkins  <jhawkins@chromium.org>

        Reviewed by Adam Barth.

        [Chromium] Implement WebInputElement::maxLength.
        https://bugs.webkit.org/show_bug.cgi?id=37172

        * public/WebInputElement.h:
        * src/WebInputElement.cpp:
        (WebKit::WebInputElement::maxLength):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Abhinav Mithal <abhinav.mithal@nokia.com>
eric@webkit.org [Tue, 6 Apr 2010 22:32:41 +0000 (22:32 +0000)]
2010-04-06  Abhinav Mithal <abhinav.mithal@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] npapi header leaves XP_WIN flag defined even when __SYMBIAN32__ flag is found
        https://bugs.webkit.org/show_bug.cgi?id=34614

        Do not define XP_WIN if WebKit is compiled for Symbian.

        No new tests as there is no new functionality.

        * bridge/npapi.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdded myself to the committers list.
aestes@apple.com [Tue, 6 Apr 2010 22:02:28 +0000 (22:02 +0000)]
Added myself to the committers list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Tue, 6 Apr 2010 21:58:31 +0000 (21:58 +0000)]
2010-04-06  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed, media test expectations tweak.

        We now regularly run http/tests/media and have to mark a few tests as TIMEOUT.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoaria-label doesn't work on image map area
cfleizach@apple.com [Tue, 6 Apr 2010 21:28:10 +0000 (21:28 +0000)]
aria-label doesn't work on image map area
https://bugs.webkit.org/show_bug.cgi?id=36977

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/area-with-aria-label.html

* accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::accessibilityDescription):

LayoutTests:

* platform/mac/accessibility/area-with-aria-label-expected.txt: Added.
* platform/mac/accessibility/area-with-aria-label.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Tue, 6 Apr 2010 21:21:28 +0000 (21:21 +0000)]
2010-04-06  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed, cleaning up media layout test expectations.

        Mostly correcting bug numbers, updating comments, and fixing expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 6 Apr 2010 20:44:42 +0000 (20:44 +0000)]
2010-04-06  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        Reverts the incorrect fixed position fastpath scrolling logic
        https://bugs.webkit.org/show_bug.cgi?id=33150

        This code does not properly handle overflow or transforms on fixed
        position elements, causing repaint bugs on scroll.

        No new tests.

        * page/FrameView.cpp:
        (WebCore::FrameView::addFixedObject):
        (WebCore::FrameView::removeFixedObject):
        * page/FrameView.h:
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::scrollContents):
        * platform/ScrollView.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::styleWillChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[wx] Build fix for wxMac / Cocoa on wx trunk.
kevino@webkit.org [Tue, 6 Apr 2010 19:58:03 +0000 (19:58 +0000)]
[wx] Build fix for wxMac / Cocoa on wx trunk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Simon Hausmann <simon.hausmann@nokia.com>
eric@webkit.org [Tue, 6 Apr 2010 19:50:58 +0000 (19:50 +0000)]
2010-04-06  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Darin Adler.

        JS code generator does not support feature conditional attributes that are writable
        https://bugs.webkit.org/show_bug.cgi?id=37149

        Write out the feature #ifdef not only for the getter, but also for the setter
        function.

        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Evan Stade <estade@chromium.org>
eric@webkit.org [Tue, 6 Apr 2010 19:17:08 +0000 (19:17 +0000)]
2010-04-06  Evan Stade  <estade@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] need DragImage implementation
        https://bugs.webkit.org/show_bug.cgi?id=35811

        Use the DragImageRef that the DragController passes to us.

        This was previously committed but rolled back for breaking layout
        tests. The fix is on the WebKit/chromium side.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * platform/chromium/DragImageChromium.cpp: Removed.
        * platform/chromium/DragImageChromiumMac.cpp: Added.
        (WebCore::dragImageSize):
        (WebCore::deleteDragImage):
        (WebCore::scaleDragImage):
        (WebCore::dissolveDragImageToFraction):
        (WebCore::createDragImageFromImage):
        (WebCore::createDragImageIconForCachedImage):
        * platform/chromium/DragImageChromiumSkia.cpp: Added.
        (WebCore::dragImageSize):
        (WebCore::deleteDragImage):
        (WebCore::scaleDragImage):
        (WebCore::dissolveDragImageToFraction):
        (WebCore::createDragImageFromImage):
        (WebCore::createDragImageIconForCachedImage):
        * platform/chromium/DragImageRef.h:
2010-04-06  Evan Stade  <estade@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] need DragImage implementation
        https://bugs.webkit.org/show_bug.cgi?id=35811

        Basic implementation using SkBitmap. Transformations are not supported
        yet. No implementation for mac.

        This was previously committed but rolled back for breaking layout
        tests.

        * public/WebViewClient.h:
        (WebKit::WebViewClient::startDragging):
        * src/DragClientImpl.cpp:
        (WebKit::DragClientImpl::startDrag): new: check for null dragImage.
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::startDragging):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-01 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Tue, 6 Apr 2010 18:56:30 +0000 (18:56 +0000)]
2010-04-01  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Darin Adler.

        Fix bug: CSS3 :not selector with ID simple selector sequence test fails
        https://bugs.webkit.org/show_bug.cgi?id=36276

        * fast/css/invalid-not-with-simple-selector-sequence-expected.txt: Added.
        * fast/css/invalid-not-with-simple-selector-sequence.html: Added.
2010-04-01  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Darin Adler.

        Fix bug: CSS3 :not selector with ID simple selector sequence test fails
        As per http://www.w3.org/TR/css3-selectors/#negation, :not(X) takes a simple selector as an argument.
        WebKit was accepting a simple selector *sequence*.
        This patch adds WebCore::CSSSelector::isSimple which judges if the selector is simple.
        The method is used in CSSGrammar.y to decide whether to accept the selector as the argument of :not().
        https://bugs.webkit.org/show_bug.cgi?id=36276

        Test: fast/css/invalid-not-with-simple-selector-sequence.html

        * css/CSSGrammar.y:
        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::isSimple):
        * css/CSSSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoREGRESSION (r57109): editing/pasteboard/drag-image-to-contenteditable-in-iframe.html...
darin@apple.com [Tue, 6 Apr 2010 18:18:56 +0000 (18:18 +0000)]
REGRESSION (r57109): editing/pasteboard/drag-image-to-contenteditable-in-iframe.html fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=37157

* platform/win/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
Copied from platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt.
Windows gets a different result than Mac because the dragging code ends up making the src attribute
of the dragged element have a full path on Windows, but not on Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Dan Bernstein.
mitz@apple.com [Tue, 6 Apr 2010 18:17:58 +0000 (18:17 +0000)]
Rubber-stamped by Dan Bernstein.

Patch by Andy Estes <aestes@apple.com> on 2010-04-06
Remove non-ASCII characters from license headers to fix build errors on
Japanese Windows.

https://bugs.webkit.org/show_bug.cgi?id=37008

* dom/UserGestureIndicator.cpp:
* dom/UserGestureIndicator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 James Hawkins <jhawkins@chromium.org>
jhawkins@chromium.org [Tue, 6 Apr 2010 17:59:37 +0000 (17:59 +0000)]
2010-04-06  James Hawkins  <jhawkins@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Move the getElementsByTagName from WebDocument to WebNode.
        https://bugs.webkit.org/show_bug.cgi?id=37161

        * public/WebDocument.h:
        * public/WebNode.h:
        * src/WebDocument.cpp:
        * src/WebNode.cpp:
        (WebKit::WebNode::getElementsByTagName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Andrei Popescu <andreip@google.com>
eric@webkit.org [Tue, 6 Apr 2010 17:49:34 +0000 (17:49 +0000)]
2010-04-06  Andrei Popescu  <andreip@google.com>

        Reviewed by Dimitri Glazkov.

        [V8][Android] PageCache crashes when JavaScript is disabled
        https://bugs.webkit.org/show_bug.cgi?id=37150

        This patch ensures that saving and restoration of the script
        state only happens when JS is enabled and each frame has a
        non-null context.

        No new tests: existing tests show the feature is working
        when JS is enabled. When JS is disabled, manual testing
        is required.

        * bindings/v8/ScriptCachedFrameData.cpp:
        (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
        (WebCore::ScriptCachedFrameData::restore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Bryan Yeung <bryeung@chromium.org>
eric@webkit.org [Tue, 6 Apr 2010 17:39:24 +0000 (17:39 +0000)]
2010-04-06  Bryan Yeung  <bryeung@chromium.org>

        Reviewed by Dimitri Glazkov.

        Update chromium expectations for passing Linux tests.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Diego Gonzalez <diego.gonzalez@openbossa.org>
eric@webkit.org [Tue, 6 Apr 2010 17:29:36 +0000 (17:29 +0000)]
2010-04-06  Diego Gonzalez  <diego.gonzalez@openbossa.org>

        Reviewed by Simon Hausmann.

        [Qt] Add mechanism to detect QtWebKit 2.0 via the preprocessor
        https://bugs.webkit.org/show_bug.cgi?id=36538

        * Api/qwebkitglobal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 6 Apr 2010 17:11:31 +0000 (17:11 +0000)]
2010-04-06  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Update Chromium test expectations for fast/dom/error-to-string-stack-overflow.html.

        * platform/chromium-mac/fast/dom/error-to-string-stack-overflow-expected.txt:
        * platform/chromium-win/fast/dom/error-to-string-stack-overflow-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 6 Apr 2010 16:15:36 +0000 (16:15 +0000)]
2010-04-06  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed build fix for Chromium DEPS.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-06 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 6 Apr 2010 15:56:35 +0000 (15:56 +0000)]
2010-04-06  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed: build fixi for WebKit Chromium bots.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57152 268f45cc-cd09-0410-ab3c-d52691b4dbfc