WebKit-https.git
14 years ago2007-11-07 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 8 Nov 2007 07:58:15 +0000 (07:58 +0000)]
2007-11-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Darin and Oliver.

        Add evaluateToNumber parallel evaluation tree to speed up number operations.
        Make ImmediateNumberNode a subclass of NumberNode.
        Share evaluate logic between evaluate and evaluateToNumber using inline functions
        There is still a lot of improvement to be made here.

        SunSpider claims this is a 1.0% speedup overall (nbody 7.9%), base64 slowing 2.0%
        Given the huge win that this prepares us for with simple type inferencing I see the small
        regression in base64 being worth the substantial overall improvement.

        * kjs/grammar.y:
        * kjs/nodes.cpp:
        (KJS::Node::evaluateToNumber):
        (KJS::NumberNode::evaluate):
        (KJS::NumberNode::evaluateToNumber):
        (KJS::StringNode::evaluateToNumber):
        (KJS::LocalVarAccessNode::inlineEvaluate):
        (KJS::LocalVarAccessNode::evaluate):
        (KJS::LocalVarAccessNode::evaluateToNumber):
        (KJS::BracketAccessorNode::inlineEvaluate):
        (KJS::BracketAccessorNode::evaluate):
        (KJS::BracketAccessorNode::evaluateToNumber):
        (KJS::NegateNode::evaluate):
        (KJS::NegateNode::evaluateToNumber):
        (KJS::MultNode::inlineEvaluateToNumber):
        (KJS::MultNode::evaluate):
        (KJS::MultNode::evaluateToNumber):
        (KJS::DivNode::inlineEvaluateToNumber):
        (KJS::DivNode::evaluate):
        (KJS::DivNode::evaluateToNumber):
        (KJS::ModNode::inlineEvaluateToNumber):
        (KJS::ModNode::evaluate):
        (KJS::ModNode::evaluateToNumber):
        (KJS::throwOutOfMemoryErrorToNumber):
        (KJS::addSlowCaseToNumber):
        (KJS::add):
        (KJS::addToNumber):
        (KJS::AddNode::evaluateToNumber):
        (KJS::SubNode::inlineEvaluateToNumber):
        (KJS::SubNode::evaluate):
        (KJS::SubNode::evaluateToNumber):
        (KJS::valueForReadModifyAssignment):
        (KJS::ReadModifyLocalVarNode::evaluate):
        (KJS::ReadModifyResolveNode::evaluate):
        (KJS::ReadModifyDotNode::evaluate):
        (KJS::ReadModifyBracketNode::evaluate):
        * kjs/nodes.h:
        (KJS::Node::):
        (KJS::NumberNode::):
        (KJS::ImmediateNumberNode::):
        (KJS::AddNode::precedence):
        * kjs/nodes2string.cpp:
        (KJS::NumberNode::streamTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Added IWebDocumentText available via QI from WebFrame.
sfalken [Thu, 8 Nov 2007 07:40:08 +0000 (07:40 +0000)]
    Added IWebDocumentText available via QI from WebFrame.

        Reviewed by Sam.

        * WebFrame.cpp:
        (WebFrame::QueryInterface): Added IID_IWebDocumentText.
        (WebFrame::supportsTextEncoding): Stubbed out.
        (WebFrame::selectedString): Implemented.
        (WebFrame::selectAll): Stubbed out.
        (WebFrame::deselectAll): Stubbed out.
        * WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Ollie.
antti [Thu, 8 Nov 2007 06:13:20 +0000 (06:13 +0000)]
    Reviewed by Ollie.

        Ensure video renderer has correct size if video has already been loaded
        when it is constructed.

        * rendering/RenderVideo.cpp:
        (WebCore::RenderVideo::RenderVideo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Ollie.
antti [Thu, 8 Nov 2007 04:24:50 +0000 (04:24 +0000)]
    Reviewed by Ollie.

        Ensure video is visible when it should be.

        * rendering/RenderVideo.cpp:
        (WebCore::RenderVideo::updateMovie):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
mitz@apple.com [Thu, 8 Nov 2007 01:54:14 +0000 (01:54 +0000)]
    Reviewed by Darin Adler.

        - fix <rdar://problem/5523503> Safari crashes clicking scroll bar in FaceBook 'Trips'

        Layers and listboxes are two kinds of ScrollBarClient that can be
        removed while the scrollbar is tracking the mouse. The scrollbar is not
        destroyed until later, and meanwhile it can try to call the client,
        which results in a crash.

        * manual-tests/stale-scrollbar-client-crash.html: Added.
        * platform/ScrollBar.h:
        (WebCore::Scrollbar::setClient): Added.
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::destroyScrollbar): Call Scrollbar::setClient().
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::~RenderListBox): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
mitz@apple.com [Thu, 8 Nov 2007 01:45:11 +0000 (01:45 +0000)]
    Reviewed by Darin Adler.

        - add an option to run-webkit-tests to ignore pixel test failures where
          all pixels differ by no more than a specified threshold

        * DumpRenderTree/mac/ImageDiff.m:
        (main):
        (compareImages):
        (computePercentageDifferent):
        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix <rdar://5569268> Crash when opening any FTP site in second tab/window
aroben [Wed, 7 Nov 2007 23:45:58 +0000 (23:45 +0000)]
Fix <rdar://5569268> Crash when opening any FTP site in second tab/window

WebCore:

        Fix <rdar://5569268> Crash when opening any FTP site in second tab/window

        Reviewed by Sam.

        No test possible.

        * platform/win/SharedBufferWin.cpp:
        (WebCore::SharedBuffer::createWithContentsOfFile): Bail if we get an
        empty path, because _wfopen_s will crash if we pass it a null pointer.

WebKit/win:

        Fix <rdar://5569268> Crash when opening any FTP site in second tab/window

        Reviewed by Sam.

        * WebView.cpp:
        (WebView::initWithFrame): Set the ftpDirectoryTemplatePath for every
        Page, not just the first one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-07 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Wed, 7 Nov 2007 23:09:12 +0000 (23:09 +0000)]
2007-11-07  Mark Rowe  <mrowe@apple.com>

        Reviewed by Kevin Decker.

        Fix 64-bit Mac build.

        * WebKit.xcodeproj/project.pbxproj: Change paths specified relative to SRCROOT
        to be relative to PROJECT_DIR.  PROJECT_DIR takes into account the projectDirPath
        setting of the project, which in this instance includes the necessary "mac"
        subdirectory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ddkilzer [Wed, 7 Nov 2007 21:54:57 +0000 (21:54 +0000)]
WebCore:

        WebKit confuses width/height for Media Queries device-aspect-ratio evaluation
        <http://bugs.webkit.org/show_bug.cgi?id=14893>
        <rdar://problem/5380295>

        Reviewed by Darin.

        Tests: fast/css/device-aspect-ratio.html
               fast/css/max-device-aspect-ratio.html
               fast/css/min-device-aspect-ratio.html

        * css/MediaQueryEvaluator.cpp:
        (WebCore::parseAspectRatio): Renamed method parameters from a/b to h/v.
        (WebCore::device_aspect_ratioMediaFeatureEval): Renamed local variables from
        a/b to h/v.  Switched first two arguments of the call to cmpvalue() to fix
        the bug.

LayoutTests:

        WebKit confuses width/height for Media Queries device-aspect-ratio evaluation
        <http://bugs.webkit.org/show_bug.cgi?id=14893>
        <rdar://problem/5380295>

        Reviewed by Darin.

        Each of the following tests creates a <link> element and dynamically sets its
        media query based on the aspect ratio (width/height) of the current screen.
        When the <link> element is attached to the <head> node, the test expects the
        stylesheet to be loaded for the test to pass.

        * fast/css/device-aspect-ratio-expected.txt: Added.
        * fast/css/device-aspect-ratio.html: Added.

        This test sets the device-aspect-ratio to the current size of the screen.
        NOTE: This test passed before the fix.

        * fast/css/max-device-aspect-ratio-expected.txt: Added.
        * fast/css/max-device-aspect-ratio.html: Added.

        This test sets the max-device-aspect ratio to 100/1 for landscape monitors or
        1/1 for portrait (or square) monitors.
        NOTE: This test failed before the fix.

        * fast/css/min-device-aspect-ratio-expected.txt: Added.
        * fast/css/min-device-aspect-ratio.html: Added.

        This test sets the min-device-aspect ratio to 1/1 for landscape monitors or
        1/100 for portrait (or square) monitors.
        NOTE: This test failed before the fix.

        * fast/css/resources/device-aspect-ratio.css: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRoll out r27578 as it is not necessary.
mrowe@apple.com [Wed, 7 Nov 2007 21:44:04 +0000 (21:44 +0000)]
Roll out r27578 as it is not necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Wed, 7 Nov 2007 20:59:00 +0000 (20:59 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15887
          REGRESSION (r27576): Crash in RenderStyle::affectedByHoverRules clicking link on Digg

        Test: fast/css/display-none-inline-style-change-crash.html

        * dom/Element.cpp:
        (WebCore::Element::recalcStyle): Fixed the crash by null-checking
        the current style and removed other checks that are not strictly
        necessary.

LayoutTests:

        Reviewed by Dave Hyatt.

        - test for http://bugs.webkit.org/show_bug.cgi?id=15887
          REGRESSION (r27576): Crash in RenderStyle::affectedByHoverRules clicking link on Digg

        * fast/css/display-none-inline-style-change-crash-expected.txt: Added.
        * fast/css/display-none-inline-style-change-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Kevin Decker.
tristan [Wed, 7 Nov 2007 20:11:12 +0000 (20:11 +0000)]
    Reviewed by Kevin Decker.

        Build fix for Leopard.  Cast a size() as int to unsigned for proper
        comparison.

        * bindings/js/JSHTMLDocumentCustom.cpp:
        (WebCore::writeHelper):
        Casted an int to unsigned for an unsigned to unsigned comparison.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubberstamped by Sam
beidson@apple.com [Wed, 7 Nov 2007 19:31:27 +0000 (19:31 +0000)]
    Rubberstamped by Sam

        Remove FrameLoaderClient methods from SVG that were pruned awhile ago

        * platform/graphics/svg/SVGImageEmptyClients.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Wed, 7 Nov 2007 18:52:09 +0000 (18:52 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix a bug where CSS rules with :hover in the ancestor chain stopped
          working after changing the inline style declaration of the ancestor

        Test: fast/css/affected-by-hover-after-style-change.html

        * dom/Element.cpp:
        (WebCore::Element::recalcStyle): If we are not forcing style
        recalculation for all descendants, preserve any "affected by
        {hover|active|drag} bits that we may have acquired from them.
        Also renamed _style to currentStyle.

WebKitSite:

        Reviewed by Darin Adler.

        - removed a workaround for the bug fixed in the WebCore part of this
          patch

        * misc/DatabaseExample.html:

LayoutTests:

        Reviewed by Darin Adler.

        - test that CSS rules with :hover in the ancestor chain continue to work
          after changing the inline style declaration of the ancestor

        * fast/css/affected-by-hover-after-style-change.html: Added.
        * platform/mac/fast/css/affected-by-hover-after-style-change-expected.checksum: Added.
        * platform/mac/fast/css/affected-by-hover-after-style-change-expected.png: Added.
        * platform/mac/fast/css/affected-by-hover-after-style-change-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
timothy@apple.com [Wed, 7 Nov 2007 17:56:16 +0000 (17:56 +0000)]
    Reviewed by Adam.

        Bug 11920: Web Inspector should have Firebug-like CSS editing
        http://bugs.webkit.org/show_bug.cgi?id=11920

        * css/CSSComputedStyleDeclaration.h:
          (WebCore::CSSComputedStyleDeclaration::isPropertyImplicit): Return false. I'm not sure why
          this was true, but computed style has no concept of implicit. So false makes more sense
          and makes the code simpler in the inspector. This function was added for the inspector,
          so this isn't a compatibility change.
        * page/inspector/PropertiesSection.js: Add a getter/setter to reset populated status.
        * page/inspector/StylesSidebarPane.js: Some refactoring along with the main support for
          style editing.
        * page/inspector/inspector.css: Style changes for propery editing and focus correctness.
        * page/inspector/inspector.js: Look for a handleKeyEvent function of the focus element before
          trying to call a function based on the element's id. Call focused and blurred on the focused
          element when currentFocusElement is changed. Use the new listItemElement getter instead of
          the private property.
        * page/inspector/treeoutline.js: No longer expand on double click if ondblclick is implemented.
          Shrink the toggle zone to 10px to better match the size of the arrow. Add an onattach call
          to allow generation of the title using the DOM element. Add listItemElement and
          childrenListElement getters.
        * page/inspector/utilities.js: Add new helper prototype methods on CSSStyleDeclaration.
        * page/inspector/DocumentPanel.js: Use the new listItemElement getter instead of the private
          property. Also expand the DOM node on double click now that the TreeOutline dosen't do it.
        * page/inspector/Resource.js: Use the new listItemElement and childrenListElement getters
          instead of the private properties.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-07 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Wed, 7 Nov 2007 17:54:36 +0000 (17:54 +0000)]
2007-11-07  Mark Rowe  <mrowe@apple.com>

        Reviewed by Eric.

        Fix up initialization after being mangled in r27572, and remove the
        ternary expression as extraCost will always be zero for the numeric
        heap.

        * kjs/collector.cpp:
        (KJS::Collector::heapAllocate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-07 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Wed, 7 Nov 2007 17:54:12 +0000 (17:54 +0000)]
2007-11-07  Mark Rowe  <mrowe@apple.com>

        Gtk build fix.

        * kjs/regexp_object.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Beth Dakin.
ggaren@apple.com [Wed, 7 Nov 2007 17:32:11 +0000 (17:32 +0000)]
    Reviewed by Beth Dakin.

        Eliminated a bogus (though compiled-out) branch in the collector.

        * kjs/collector.cpp:
        (KJS::Collector::heapAllocate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
ggaren@apple.com [Wed, 7 Nov 2007 17:18:39 +0000 (17:18 +0000)]
JavaScriptCore:

        Reviewed by Darin Adler.

        Fixed part of http://bugs.webkit.org/show_bug.cgi?id=15861
        15% of string-validate-input.js is spent compiling the same regular expression.

        Put RegExpImp properties into a static hashtable to avoid a slew of
        PropertyMap churn when creating a RegExpImp.

        Factored important bits of regular expression implementation out of
        RegExpImp (the JS object) and into RegExp (the PCRE wrapper class),
        making RegExp a ref-counted class. (This will help later.)

        Removed PCRE_POSIX support because I didn't quite know how to test it
        and keep it working with these changes.

        1.1% SunSpider speedup. 5.8% speedup on string-validate-input.js.

        * kjs/regexp.h: A few interface changes:
        1. Renamed "subpatterns()" => "numSubpatterns()"
        2. Made flag enumeration private and replaced it with public getters for
        specific flags.
        3. Made RegExp ref-counted so RegExps can be shared by RegExpImps.
        4. Made RegExp take a string of flags instead of an int, eliminating
        duplicated flag parsing code elsewhere.

        * kjs/regexp_object.cpp:
        (KJS::RegExpProtoFunc::callAsFunction): For RegExp.compile:
        - Fixed a bug where compile(undefined) would throw an exception.
        - Removed some now-redundant code.
        - Used RegExp sharing to eliminate an allocation and a bunch of
        PropertyMap thrash. (Not a big win since compile is a deprecated
        function. I mainly did this to test the plubming.)

LayoutTests:

        Reviewed by Darin Adler.

        Beefed up the RegExp.compile testcase to cover a mistake in the
        original check-in and a mistake I made while developing my new patch.

        * fast/js/resources/regexp-compile.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore.pri expects OBJECTS_DIR to be set, so set it in
hausmann [Wed, 7 Nov 2007 16:36:04 +0000 (16:36 +0000)]
JavaScriptCore.pri expects OBJECTS_DIR to be set, so set it in
testkjs.pro, too, where it's included from.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoCoding style fix.
hausmann [Wed, 7 Nov 2007 16:14:59 +0000 (16:14 +0000)]
Coding style fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFor safety provide a default constructor for WindowFeatures().
hausmann [Wed, 7 Nov 2007 15:52:09 +0000 (15:52 +0000)]
For safety provide a default constructor for WindowFeatures().
ContextMenuController.cpp: createNewWindow as well as QWebPage need to
create a default initialized WindowFeatures object on the fly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the Qt build.
hausmann [Wed, 7 Nov 2007 15:35:44 +0000 (15:35 +0000)]
Fix the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix "nmake clean" for the Qt/Windows build by replacing tmp/ with a variable that...
hausmann [Wed, 7 Nov 2007 14:45:32 +0000 (14:45 +0000)]
Fix "nmake clean" for the Qt/Windows build by replacing tmp/ with a variable that ends with the correct type of slash/backslash depending on the choice of compiler/make tool.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMake the setting of letting Javascript access the clipboard configurable through...
hausmann [Wed, 7 Nov 2007 14:32:23 +0000 (14:32 +0000)]
Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoChanged QWebPageHistory::goToItem to take a value instead of a pointer.
hausmann [Wed, 7 Nov 2007 14:32:16 +0000 (14:32 +0000)]
Changed QWebPageHistory::goToItem to take a value instead of a pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemoved unimplemented QWebHistoryItem::children() function
hausmann [Wed, 7 Nov 2007 14:32:09 +0000 (14:32 +0000)]
Removed unimplemented QWebHistoryItem::children() function

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoChanged the getter functions in QWebSettings to transparently resolve against the...
hausmann [Wed, 7 Nov 2007 14:32:05 +0000 (14:32 +0000)]
Changed the getter functions in QWebSettings to transparently resolve against the default settings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdded explicit functions for resetting the font sizes and font families.
hausmann [Wed, 7 Nov 2007 14:31:59 +0000 (14:31 +0000)]
Added explicit functions for resetting the font sizes and font families.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoCombined the font sizes accessors/setters under one setter/getter with an enum.
hausmann [Wed, 7 Nov 2007 14:31:54 +0000 (14:31 +0000)]
Combined the font sizes accessors/setters under one setter/getter with an enum.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRenamed QWebPage::userAgentStringForUrl(url) to QWebPage::userAgentFor(url);
hausmann [Wed, 7 Nov 2007 14:31:49 +0000 (14:31 +0000)]
Renamed QWebPage::userAgentStringForUrl(url) to QWebPage::userAgentFor(url);

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRenamed QWebPage::webActionTriggered to QWebPage::triggerAction
hausmann [Wed, 7 Nov 2007 14:31:44 +0000 (14:31 +0000)]
Renamed QWebPage::webActionTriggered to QWebPage::triggerAction

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoChanged the virtual QWebPage::setWindowGeometry to be a geometryChangeRequest signal...
hausmann [Wed, 7 Nov 2007 14:31:38 +0000 (14:31 +0000)]
Changed the virtual QWebPage::setWindowGeometry to be a geometryChangeRequest signal instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRenamed QWebPage::webAction() to QWebPage::action()
hausmann [Wed, 7 Nov 2007 14:31:32 +0000 (14:31 +0000)]
Renamed QWebPage::webAction() to QWebPage::action()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemoved a bunch of slots/functions that are now available through the new actions...
hausmann [Wed, 7 Nov 2007 14:31:26 +0000 (14:31 +0000)]
Removed a bunch of slots/functions that are now available through the new actions API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdded some more comments to the API after another round of API review with Lars.
hausmann [Wed, 7 Nov 2007 14:31:22 +0000 (14:31 +0000)]
Added some more comments to the API after another round of API review with Lars.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMoved QWebFrame::selectedText() to QWebPage::selectedText().
hausmann [Wed, 7 Nov 2007 14:31:16 +0000 (14:31 +0000)]
Moved QWebFrame::selectedText() to QWebPage::selectedText().

The currently selected text is a property of the page as a whole.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoImplemented support for settings propagation.
hausmann [Wed, 7 Nov 2007 14:31:11 +0000 (14:31 +0000)]
Implemented support for settings propagation.

If an individual setting is not set in a page's QWebSettings then it is inherited from the default settings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReworked the QWebSettings API.
hausmann [Wed, 7 Nov 2007 14:31:04 +0000 (14:31 +0000)]
Reworked the QWebSettings API.
QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMade the QWebSettings::webGraphic functions static. The implementation was using...
hausmann [Wed, 7 Nov 2007 14:30:57 +0000 (14:30 +0000)]
Made the QWebSettings::webGraphic functions static. The implementation was using QWebSettings::global() anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMoved the WebCore::Image specific function loadResourcePixmap from qwebsettings.cpp...
hausmann [Wed, 7 Nov 2007 14:30:50 +0000 (14:30 +0000)]
Moved the WebCore::Image specific function loadResourcePixmap from qwebsettings.cpp to ImageQt.cpp and made it static.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoChanged the icondatabase accessor to be a static function because it doesn't change...
hausmann [Wed, 7 Nov 2007 14:30:43 +0000 (14:30 +0000)]
Changed the icondatabase accessor to be a static function because it doesn't change the QWebSettings object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoChanged the webAction() accessor to not be a slot but just a public function.
hausmann [Wed, 7 Nov 2007 14:30:38 +0000 (14:30 +0000)]
Changed the webAction() accessor to not be a slot but just a public function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoImplemented createWindow() in QtLauncher.
hausmann [Wed, 7 Nov 2007 14:30:34 +0000 (14:30 +0000)]
Implemented createWindow() in QtLauncher.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoImplemented opening links in new windows
hausmann [Wed, 7 Nov 2007 14:30:28 +0000 (14:30 +0000)]
Implemented opening links in new windows

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdded and implemented the "OpenLink" action.
hausmann [Wed, 7 Nov 2007 14:30:22 +0000 (14:30 +0000)]
Added and implemented the "OpenLink" action.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdjust the state of the reload action correctly.
hausmann [Wed, 7 Nov 2007 14:30:17 +0000 (14:30 +0000)]
Adjust the state of the reload action correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoInitialize the undo/redo actions from QUndoStack. That automatically takes care of...
hausmann [Wed, 7 Nov 2007 14:30:11 +0000 (14:30 +0000)]
Initialize the undo/redo actions from QUndoStack. That automatically takes care of enabling/disabling them as well as the activation/trigger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdded undo/redo toolbar buttons, moved the location line edit into a separate toolbar.
hausmann [Wed, 7 Nov 2007 14:30:05 +0000 (14:30 +0000)]
Added undo/redo toolbar buttons, moved the location line edit into a separate toolbar.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUpdate the editor actions when the selection changes.
hausmann [Wed, 7 Nov 2007 14:30:00 +0000 (14:30 +0000)]
Update the editor actions when the selection changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdded cut/copy/paste actions to the toolbar of QtLauncher
hausmann [Wed, 7 Nov 2007 14:29:54 +0000 (14:29 +0000)]
Added cut/copy/paste actions to the toolbar of QtLauncher

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoStarted working on keeping the state of the navigation actions up-to-date.
hausmann [Wed, 7 Nov 2007 14:29:48 +0000 (14:29 +0000)]
Started working on keeping the state of the navigation actions up-to-date.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUse the navigational web actions in the toolbar
hausmann [Wed, 7 Nov 2007 14:29:42 +0000 (14:29 +0000)]
Use the navigational web actions in the toolbar

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoStore a bunch of QActions in QWebPagePrivate, corresponding to QWebPage::WebAction.
hausmann [Wed, 7 Nov 2007 14:29:37 +0000 (14:29 +0000)]
Store a bunch of QActions in QWebPagePrivate, corresponding to QWebPage::WebAction.
Added QWebPageContext to hold context sensitive information (for example used by the context menu).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMoved the editing actions implemented in keyPressEvent into webActionTriggered.
hausmann [Wed, 7 Nov 2007 14:29:31 +0000 (14:29 +0000)]
Moved the editing actions implemented in keyPressEvent into webActionTriggered.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoIntroduced a central virtual void webActionTriggered(WebAction action) method that...
hausmann [Wed, 7 Nov 2007 14:29:25 +0000 (14:29 +0000)]
Introduced a central virtual void webActionTriggered(WebAction action) method that is called from various
convenience methods such as cut()/copy()/paste().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRestructure the context menu classes for the Qt port. ContextMenu and ContextMenuItem...
hausmann [Wed, 7 Nov 2007 14:29:19 +0000 (14:29 +0000)]
Restructure the context menu classes for the Qt port. ContextMenu and ContextMenuItem don't store
QActions/QMenus anymore but just store the action type, tag, title and optionally submenu as created
in ContextMenu::populate().
For the actual Qt context menu we traverse this structure after sendContextMenuEvent and create a QMenu
out of it. That menu is currently not functional anymore though.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoChanged ContextMenu::setPlatformDescription for the Qt port to not show the qmenu...
hausmann [Wed, 7 Nov 2007 14:29:11 +0000 (14:29 +0000)]
Changed ContextMenu::setPlatformDescription for the Qt port to not show the qmenu right away
but instead just behave as a normal setter that takes ownership of the platform menu description (the qmenu).
Instead now QWebPage::contextMenuEvent() retrieves the QMenu after calling sendContextMenuEvent and calls exec()
on it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoChanged to PlatformMouseEvent constructor to allow construction from a QContextMenuEvent.
hausmann [Wed, 7 Nov 2007 14:29:03 +0000 (14:29 +0000)]
Changed to PlatformMouseEvent constructor to allow construction from a QContextMenuEvent.
Call sendContextMenuEvent on the event handler from a QWidget::contextMenuEvent re-implementation instead of in mousePressEvent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoTurned onLoadProgressChanged into a real private slot.
hausmann [Wed, 7 Nov 2007 14:28:56 +0000 (14:28 +0000)]
Turned onLoadProgressChanged into a real private slot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMake QWebHistory an explicitly shared object, returned as a pointer by QWebPage:...
hausmann [Wed, 7 Nov 2007 14:28:33 +0000 (14:28 +0000)]
Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agocomments on API changes that we'd like to do.
hausmann [Wed, 7 Nov 2007 14:23:14 +0000 (14:23 +0000)]
comments on API changes that we'd like to do.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd a QWebPage::frameCreated() signal and fix DRT
hausmann [Wed, 7 Nov 2007 14:21:48 +0000 (14:21 +0000)]
Add a QWebPage::frameCreated() signal and fix DRT

The removal of createFrame in QWebPage broke the re-implementation
in DumpRenderTree. Instead emit a frameCreated() signal and
connect to it in DumpRenderTree.

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemove QWebPage::createFrame()
hausmann [Wed, 7 Nov 2007 14:19:53 +0000 (14:19 +0000)]
Remove QWebPage::createFrame()

now that QWebFrame doesn't have virtual methods anymore, there
is no need for a createFrame() factory method in QWebpage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMoved all the event handlers from QWebFrame into QWebPage.
hausmann [Wed, 7 Nov 2007 14:17:54 +0000 (14:17 +0000)]
Moved all the event handlers from QWebFrame into QWebPage.

This cleans up the public API and allows us to remove the
HackWebFrame hack in DumpRenderTree.

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agodon't put nbsp's into the plan text paste
hausmann [Wed, 7 Nov 2007 14:01:41 +0000 (14:01 +0000)]
don't put nbsp's into the plan text paste

Fix both ClipboardQt and PasteboardQt to replace
nbsp's with spaces before putting the text onto the
native clipboard. This is consistent with Mac and Win
and fixes at least editing/pasteboard/4076267-3.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd now passing tests
hausmann [Wed, 7 Nov 2007 14:01:31 +0000 (14:01 +0000)]
Add now passing tests

The fix of umemcasecmp in UnicodeQt4.h fixed quite a lot
of test falures. Add these to our regression tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoupdate test results after the last commit.
hausmann [Wed, 7 Nov 2007 14:01:15 +0000 (14:01 +0000)]
update test results after the last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agofix umemcasecmp
hausmann [Wed, 7 Nov 2007 14:01:03 +0000 (14:01 +0000)]
fix umemcasecmp

Pretty embarrassing bug. Has the potential to fix quite a few test failures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUpdate the list of skipped tests.
hausmann [Wed, 7 Nov 2007 14:00:51 +0000 (14:00 +0000)]
Update the list of skipped tests.

Three more tests are passing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoImplement Pasteboard::writeImage()
hausmann [Wed, 7 Nov 2007 13:45:55 +0000 (13:45 +0000)]
Implement Pasteboard::writeImage()

* Pasteboard is now fully implemented. Copying of Images into the Clipboard
  is now supported.
* As with URLs we only copy into the Clipboard (and not additionally to the
  Selection)

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoApple CodingStyle fixes
hausmann [Wed, 7 Nov 2007 13:45:49 +0000 (13:45 +0000)]
Apple CodingStyle fixes

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoImplement Pasteboard::writeURL()
hausmann [Wed, 7 Nov 2007 13:45:44 +0000 (13:45 +0000)]
Implement Pasteboard::writeURL()
* The URL currently gets written as text/plain and text/uri-list.
  The win and mac port have some more types which we currently do
  not support. When supporting them we can use the 'titleString'
  as well.
* As with writeSelection we only copy into the Clipboard. We could
  consider copying into the Selection as well.

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoKill whitespace
hausmann [Wed, 7 Nov 2007 13:45:37 +0000 (13:45 +0000)]
Kill whitespace

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUse correct UserAgent string.
hausmann [Wed, 7 Nov 2007 13:45:19 +0000 (13:45 +0000)]
Use correct UserAgent string.

* Only have one User Agent String and this place is QWebPage
* QWebPage::open -> QWebNetworkRequest -> QWebPage::open ->
  ResourceRequest -> FrameLoader::load -> QWebNetworkRequest
* ResourceRequest is != 0 when getting called from WebCore, we
  will only do requests when coming from WebCore and then we can
  use the User-Agent set with the help of the FrameLoaderClient
* We might want to change QWebNetworkRequest a bit

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoImplemented the two Javascript prompt callbacks in qt/DumpRenderTree
hausmann [Wed, 7 Nov 2007 13:18:13 +0000 (13:18 +0000)]
Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
to prevent the default implementation from popping up messageboxes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoadd more passing test cases.
hausmann [Wed, 7 Nov 2007 12:47:58 +0000 (12:47 +0000)]
add more passing test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUse the correct function calls to convert a selection to
hausmann [Wed, 7 Nov 2007 12:47:47 +0000 (12:47 +0000)]
Use the correct function calls to convert a selection to
HTML or plain text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoremove two notImplemented() warnings, as I believe we don't
hausmann [Wed, 7 Nov 2007 12:47:39 +0000 (12:47 +0000)]
remove two notImplemented() warnings, as I believe we don't
have to implement these methods. Add some (commented out)
debug code in one place.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd WebKit/qt/Api to the dependency path when building QtLauncher and DumpRenderTree.
hausmann [Wed, 7 Nov 2007 12:44:20 +0000 (12:44 +0000)]
Add WebKit/qt/Api to the dependency path when building QtLauncher and DumpRenderTree.
That means that changes to the public API of the Qt port also trigger a rebuild of the tools.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoSome more clipboard fixes.
hausmann [Wed, 7 Nov 2007 12:33:08 +0000 (12:33 +0000)]
Some more clipboard fixes.

We have to set things immediately on the QClipBoard if the
Clipboard object is not for dragging.

This is due to the fact that the Clipboard object might be
rather long lived if accessed through javascript (it'll only
get deleted by JS garbage collection). We have to transfer
the data over to the QClipboard before that to make things work.

Fixes editing/execCommand/copy-without-selection.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix compilation on Windows with non-cygwin perl.
hausmann [Wed, 7 Nov 2007 10:32:07 +0000 (10:32 +0000)]
Fix compilation on Windows with non-cygwin perl.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemove conflict marker.
mrowe@apple.com [Wed, 7 Nov 2007 10:14:50 +0000 (10:14 +0000)]
Remove conflict marker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoCorrected ChangeLog grammar.
ap@webkit.org [Wed, 7 Nov 2007 09:53:29 +0000 (09:53 +0000)]
Corrected ChangeLog grammar.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Finished moving editing/pasteboard/5583362.html to platform/mac (this test...
ap@webkit.org [Wed, 7 Nov 2007 09:52:20 +0000 (09:52 +0000)]
    Finished moving editing/pasteboard/5583362.html to platform/mac (this test was crashing in ObjC test plugin,
        because it couldn't find its resources.

        * editing/resources/plaintext-pasteboard-data.dat: Removed.
        * platform/mac/editing/resources: Added.
        * platform/mac/editing/resources/plaintext-pasteboard-data.dat: Copied from editing/resources/plaintext-pasteboard-data.dat.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Wed, 7 Nov 2007 08:11:58 +0000 (08:11 +0000)]
WebCore:

        Reviewed by Brady Eidson.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15877
          REGRESSION: r27486 caused a layout regression at my bank's website

        Test: fast/block/float/overhanging-after-height-decrease-offsets.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock):

LayoutTests:

        Reviewed by Brady Eidson.

        - test for http://bugs.webkit.org/show_bug.cgi?id=15877
          REGRESSION: r27486 caused a layout regression at my bank's website

        * fast/block/float/overhanging-after-height-decrease-offsets.html: Added.
        * platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-offsets-expected.checksum: Added.
        * platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-offsets-expected.png: Added.
        * platform/mac/fast/block/float/overhanging-after-height-decrease-offsets-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
mjs [Wed, 7 Nov 2007 07:23:25 +0000 (07:23 +0000)]
    Reviewed by Eric.

        - only collect when the heap is full, unless we have lots of extra cost garbage

        1.1% SunSpider speedup.

        This shouldn't hit memory use much since the extra space in those
        blocks hangs around either way.

        * kjs/collector.cpp:
        (KJS::Collector::heapAllocate):
        (KJS::Collector::collect): Fix logic error that reversed the sense of collect's
        return value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Move a Mac-specific test to platform/mac
aroben [Wed, 7 Nov 2007 07:00:14 +0000 (07:00 +0000)]
    Move a Mac-specific test to platform/mac

        * editing/pasteboard/5583362.html: Removed.
        * platform/mac/editing/pasteboard/5583362.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAvoid unnecessarily boxing the result from post inc/decrement for 0.3% gain in sunspider
oliver [Wed, 7 Nov 2007 06:03:20 +0000 (06:03 +0000)]
Avoid unnecessarily boxing the result from post inc/decrement for 0.3% gain in sunspider

Reviewed by Maciej

We now convert the common 'for (...; ...; <var>++) ...' to the semantically identical
'for (...; ...; ++<var>) ...'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 7 Nov 2007 05:41:21 +0000 (05:41 +0000)]
2007-11-06  Eric Seidel  <eric@webkit.org>

        * Scripts/build-testkjs: build fix... too many $$

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
bdakin [Wed, 7 Nov 2007 05:31:10 +0000 (05:31 +0000)]
WebCore:

        Reviewed by Sam.

        <rdar://problem/5575812> REGRESSION:When using absolute positioning
        with overflow:auto div, WebKit seems to add an additional 15px

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::containingBlockWidthForPositioned): We need to
        subtract off the vertical scrollbar width too.

LayoutTests:

        Reviewed by Sam.

        New test for <rdar://problem/5575812> REGRESSION:When using
        absolute positioning with overflow:auto div, WebKit seems to add an
        additional 15px
        * fast/overflow/overflow-auto-position-absolute.html: Added.
        * platform/mac/fast/overflow/overflow-auto-position-absolute-expected.checksum: Added.
        * platform/mac/fast/overflow/overflow-auto-position-absolute-expected.png: Added.
        * platform/mac/fast/overflow/overflow-auto-position-absolute-expected.txt: Added.

        Test with changed results. The measurements in the rtl example now
        more closely mirror the ltr example.
        * platform/mac/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Change WebLocalizableStrings to take UTF-8 C strings
aroben [Wed, 7 Nov 2007 05:29:02 +0000 (05:29 +0000)]
     Change WebLocalizableStrings to take UTF-8 C strings

         This matches the way things work on the Mac, and will allow source
         files containing localizable strings to be shared between Mac and
         Windows. The old functions have not been removed for compatibility
         reasons, but are now just wrappers around the new UTF-8 functions.

         Reviewed by Ada.

         * WebKit.vcproj/WebKit.def: Added new functions.
         * WebKit.vcproj/WebKit_debug.def: Ditto.
         * WebLocalizableStrings.cpp:
         (copyLocalizedStringFromBundle): Changed to take a WebCore::String
         representing the key.
         (localizedString): Refactored from WebLocalizedString. Takes a
         WebCore::String representing the key.
         (localizedLPCTSTR): Ditto for WebLocalizedLPCTSTR.
         (WebLocalizedStringUTF8): Added. Takes a UTF-8 C string as the key.
         (WebLocalizedLPCTSTRUTF8): Ditto.
         (WebLocalizedString): Changed to call localizedString.
         (WebLocalizedLPCTSTR): Changed to call localizedLPCTSTR.
         * WebLocalizableStrings.h: Changed macros to use the new UTF-8
         functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 7 Nov 2007 05:24:17 +0000 (05:24 +0000)]
2007-11-06  Eric Seidel  <eric@webkit.org>

        Reviewed by Mark Rowe.

        * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMove Mac files from WebKit into WebKit/mac.
mrowe@apple.com [Wed, 7 Nov 2007 03:01:16 +0000 (03:01 +0000)]
Move Mac files from WebKit into WebKit/mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
justing [Wed, 7 Nov 2007 01:13:47 +0000 (01:13 +0000)]
WebCore:

        Reviewed by Dan Bernstein.

        <rdar://problem/5583387> ASSERTION FAILED: !refChild->hasTagName(bodyTag) when pasting newline in plain text into rich text Mail
        <rdar://problem/5583362> REGRESSION (5523.10.3-TOT): Newlines stripped when pasting plain text in Mail

        * editing/markup.cpp:
        (WebCore::createFragmentFromText): Put paragraphs of text into clones of the block
        that encloses the input context, unless that block is the body, which shouldn't
        be cloned.  In that case, use regular divs, as we did before r27369.

LayoutTests:

        Reviewed by Dan Bernstein.

        <rdar://problem/5583387> ASSERTION FAILED: !refChild->hasTagName(bodyTag) when pasting newline in plain text into rich text Mail
        <rdar://problem/5583362> REGRESSION (5523.10.3-TOT): Newlines stripped when pasting plain text in Mail

        * editing/pasteboard/5583362.html: Added.
        * editing/resources/plaintext-pasteboard-data.dat: Added.
        * platform/mac/editing/pasteboard/5583362-expected.checksum: Added.
        * platform/mac/editing/pasteboard/5583362-expected.png: Added.
        * platform/mac/editing/pasteboard/5583362-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-06 Eric Seidel <eric@webkit.org>
eseidel [Wed, 7 Nov 2007 01:03:26 +0000 (01:03 +0000)]
2007-11-06  Eric Seidel  <eric@webkit.org>

        Reviewed by darin.

        This fixes a regressed layout test for string + object

        SunSpider claims this was an overall 0.3% speedup, although some individual tests were slower.

        * kjs/nodes.cpp:
        (KJS::add): remove erroneous "fast path" for string + *

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric Seidel.
ggaren@apple.com [Wed, 7 Nov 2007 00:06:43 +0000 (00:06 +0000)]
    Reviewed by Eric Seidel.

        Added toJSNumber, a fast path for converting a JSValue to a JS number,
        and deployed it in postfix expressions. In the fast case this
        eliminates a call to jsNumber.

        0.4% speedup on SunSpider.

        * ChangeLog:
        * kjs/nodes.cpp:
        (KJS::PostIncResolveNode::evaluate):
        (KJS::PostIncLocalVarNode::evaluate):
        (KJS::PostDecResolveNode::evaluate):
        (KJS::PostDecLocalVarNode::evaluate):
        (KJS::PostIncBracketNode::evaluate):
        (KJS::PostDecBracketNode::evaluate):
        (KJS::PostIncDotNode::evaluate):
        (KJS::PostDecDotNode::evaluate):
        (KJS::UnaryPlusNode::evaluate):
        * kjs/value.h:
        (KJS::JSValue::toJSNumber):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-06 Christian Dywan <christian@twotoasts.de>
mrowe@apple.com [Wed, 7 Nov 2007 00:04:38 +0000 (00:04 +0000)]
2007-11-06  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Darin.

        Fix http://bugs.webkit.org/show_bug.cgi?id=15828
        Bug 15828: WebKit GTK include and lib directory is installed in qt4-named directory

        * WebCore.pro: Use sane default install paths for the gtk port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-06 Rodney Dawes <dobey@wayofthemonkey.com>
mrowe@apple.com [Wed, 7 Nov 2007 00:02:04 +0000 (00:02 +0000)]
2007-11-06  Rodney Dawes  <dobey@wayofthemonkey.com>

        Fix http://bugs.webkit.org/attachment.cgi?id=17043&action=view
        Bug 15766: [GTK] WebKit sometimes spews binary data as text/plain into iframes

        FrameLoaderClient::objectContentType needs to check with the MIMETypeRegistry
        to determine whether the given MIME type is displayable as an image or non-image.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (FrameLoaderClient::objectContentType): Change logic to match that in
        the Windows and Mac ports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Correct test results.
antti [Tue, 6 Nov 2007 23:19:02 +0000 (23:19 +0000)]
    Correct test results.

        * platform/mac/fast/layers/layer-visibility-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27490 268f45cc-cd09-0410-ab3c-d52691b4dbfc