WebKit-https.git
10 years agoWeb Inspector: backend js api: an ability to skip optional arguments in the middle...
loislo@chromium.org [Fri, 19 Aug 2011 08:42:03 +0000 (08:42 +0000)]
Web Inspector: backend js api: an ability to skip optional arguments in the middle of the argument list is required.
https://bugs.webkit.org/show_bug.cgi?id=66482

There are functions in the API with multiple optional arguments.
When we call it we have to specify an optional argument as 'undefined' if we want to pass non default value for the next one.
This can be solved with passing the arguments as an object.

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/CodeGeneratorInspector.pm:
* inspector/front-end/RemoteObject.js:

LayoutTests:

* inspector/debugger/debugger-set-breakpoint-regex.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Build fix after r93384.
zoltan@webkit.org [Fri, 19 Aug 2011 07:54:35 +0000 (07:54 +0000)]
[Qt] Build fix after r93384.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoComputing screen-space transform for LayerChromium and CCLayerImpl
commit-queue@webkit.org [Fri, 19 Aug 2011 05:44:52 +0000 (05:44 +0000)]
Computing screen-space transform for LayerChromium and CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=66114

Source/WebCore:

Added a data member to LayerChromium and CCLayerImpl that holds
the screen-space transform.   The transform is computed in
calculateDrawTransformsAndVisibility(), which is used during
updating (LayerChromium) and drawing (CCLayerImpl).

Also fixed a FIXME in LayerRendererChromium::drawLayer, which
was not computing the entire hierarchy of transforms to determine
back-face visibility.  Now it simply uses the world space transform.

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-18
Reviewed by James Robinson.

Test: compositing/backface-visibility-hierarchical-transform.html

* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::screenSpaceTransform):
(WebCore::LayerChromium::setScreenSpaceTransform):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::screenSpaceTransform):
(WebCore::CCLayerImpl::setScreenSpaceTransform):

LayoutTests:

This case tests if backface visibility properly accounts for a hierarchy
of transforms.  In particular, this test forces Chromium to create a
hierarchy of RenderSurfaces.

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-18
Reviewed by James Robinson.

* compositing/backface-visibility-hierarchical-transform-expected.png: Added.
* compositing/backface-visibility-hierarchical-transform-expected.txt: Added.
* compositing/backface-visibility-hierarchical-transform.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[skia] -webkit-transform breaks -webkit-mask
commit-queue@webkit.org [Fri, 19 Aug 2011 04:51:38 +0000 (04:51 +0000)]
[skia] -webkit-transform breaks -webkit-mask
https://bugs.webkit.org/show_bug.cgi?id=66442

Source/WebCore:

The problem here is that in RenderBox::paintMaskImages, if we are in
a transform with a rotation, scale or skew we set the composite mode to
be DestinationIn and then create a transparency layer, then paint the
mask with SourceOver and end the transparency layer. (The normal case
is just to use DestinationIn to paint the mask.)

In skia when we create transparency layers we don't pass on the composite
mode, so when we end the transparency layer it is composited back using
SourceOver. The fix is to pass on the composite mode when creating
transparency layers in skia.

Patch by Ben Wells <benwells@chromium.org> on 2011-08-18
Reviewed by Stephen White.

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::getXfermodeMode):
* platform/graphics/skia/PlatformContextSkia.h:

LayoutTests:

Patch by Ben Wells <benwells@chromium.org> on 2011-08-18
Reviewed by Stephen White.

* platform/chromium-linux/fast/css/transformed-mask-expected.png: Added.
* platform/chromium-linux/fast/css/transformed-mask-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIsolate EventDispatchMediator into a separate file.
hayato@chromium.org [Fri, 19 Aug 2011 04:46:33 +0000 (04:46 +0000)]
Isolate EventDispatchMediator into a separate file.
https://bugs.webkit.org/show_bug.cgi?id=66458

Reviewed by Ryosuke Niwa.

Extracted EventDispatchMediator.h and EventDispatchMediator.cpp
out of Event.h and Event.cpp Also moved FocusEventDispatchMediator
and BlurEventDispatchMediator from Event.{h|cpp} to
EventDispatchMediator.{h|cpp}.

No new tests since this is just refactoring.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Event.cpp:
* dom/Event.h:
* dom/EventDispatchMediator.cpp: Added.
(WebCore::EventDispatchMediator::create):
(WebCore::EventDispatchMediator::EventDispatchMediator):
(WebCore::EventDispatchMediator::dispatchEvent):
(WebCore::FocusEventDispatchMediator::create):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
* dom/EventDispatchMediator.h: Added.
(WebCore::EventDispatchMediator::~EventDispatchMediator):
(WebCore::EventDispatchMediator::event):
(WebCore::EventDispatchMediator::EventDispatchMediator):
(WebCore::EventDispatchMediator::setEvent):
* dom/EventDispatcher.cpp:
* dom/KeyboardEvent.h:
* dom/MouseEvent.h:
* dom/Node.cpp:
* dom/ScopedEventQueue.cpp:
* dom/UIEvent.h:
* dom/WheelEvent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMid-word break can occur between a character and a combining mark
mitz@apple.com [Fri, 19 Aug 2011 03:34:36 +0000 (03:34 +0000)]
Mid-word break can occur between a character and a combining mark
https://bugs.webkit.org/show_bug.cgi?id=66529

Reviewed by Simon Fraser.

No test added because I could not find a combining mark with a non-zero advance in
any of the system fonts and tests fonts.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Disallow a mid-word break before a
combining mark.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agonew-run-webkit-tests hung while acquiring http lock on snow leopard bots
dpranke@chromium.org [Fri, 19 Aug 2011 01:58:57 +0000 (01:58 +0000)]
new-run-webkit-tests hung while acquiring http lock on snow leopard bots
https://bugs.webkit.org/show_bug.cgi?id=64886

Temporarily disable the http locking to work around the issue.
I'm not actually sure if this is going to work or improve things
much.

Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/layout_tests/port/mac.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r90971): Null pointer dereference with placeholder and webkit-scrollbar...
tkent@chromium.org [Fri, 19 Aug 2011 01:33:07 +0000 (01:33 +0000)]
REGRESSION(r90971): Null pointer dereference with placeholder and webkit-scrollbar-corner
https://bugs.webkit.org/show_bug.cgi?id=66453

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/forms/placeholder-crash-with-scrollbar-corner.html

* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode): Add a NULL check for owner's layer.

LayoutTests:

* fast/forms/placeholder-crash-with-scrollbar-corner-expected.txt: Added.
* fast/forms/placeholder-crash-with-scrollbar-corner.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium plumbing for webkitRequestFullScreen
koz@chromium.org [Fri, 19 Aug 2011 01:17:22 +0000 (01:17 +0000)]
Chromium plumbing for webkitRequestFullScreen
https://bugs.webkit.org/show_bug.cgi?id=66031

Reviewed by Darin Fisher.

* public/WebView.h:
* public/WebViewClient.h:
(WebKit::WebViewClient::enterFullscreenForElement):
(WebKit::WebViewClient::exitFullscreenForElement):
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::enterFullScreenForElement):
(WebKit::ChromeClientImpl::exitFullScreenForElement):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::exitFullscreen):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNew XML parser: scripting support
jpfau@apple.com [Fri, 19 Aug 2011 01:09:34 +0000 (01:09 +0000)]
New XML parser: scripting support
https://bugs.webkit.org/show_bug.cgi?id=66406

Reviewed by Adam Barth.

* xml/parser/NewXMLDocumentParser.cpp:
(WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::resumeParsing):
(WebCore::NewXMLDocumentParser::processScript):
(WebCore::NewXMLDocumentParser::append): Add support for pausing the parsing
(WebCore::NewXMLDocumentParser::finish): Add support for pausing the parsing
(WebCore::NewXMLDocumentParser::notifyFinished):
* xml/parser/NewXMLDocumentParser.h:
(WebCore::NewXMLDocumentParser::pauseParsing):
* xml/parser/XMLTreeBuilder.cpp: Add a shared function between self-closing and end tags
(WebCore::XMLTreeBuilder::closeElement): Registers scripts and pops the stack
(WebCore::XMLTreeBuilder::processStartTag):
(WebCore::XMLTreeBuilder::processEndTag):
* xml/parser/XMLTreeBuilder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Broken rendering occured when resized in ewk_view_single.
ryuan.choi@samsung.com [Fri, 19 Aug 2011 01:04:12 +0000 (01:04 +0000)]
[EFL] Broken rendering occured when resized in ewk_view_single.
https://bugs.webkit.org/show_bug.cgi?id=66271

Force rendering when ewk_view resized.
It's because Evas_Object doesn't generate any rendering request although
it was changed.

Reviewed by Tony Chang.

* ewk/ewk_view.cpp:
(_ewk_view_smart_calculate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove allocation in constructors into separate constructorBody() methods
commit-queue@webkit.org [Fri, 19 Aug 2011 00:58:34 +0000 (00:58 +0000)]
Move allocation in constructors into separate constructorBody() methods
https://bugs.webkit.org/show_bug.cgi?id=66265

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-18
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Refactoring to put all allocations that need to be done after the object's
initialization list has executed but before the object is ready for use
into a separate constructorBody() method.  This method is still called by the constructor,
so the patch doesn't resolve any potential issues, it's just to set up the code for further refactoring.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* jsc.cpp:
(GlobalObject::constructorBody):
(GlobalObject::GlobalObject):
* runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::ErrorInstance):
* runtime/ErrorInstance.h:
(JSC::ErrorInstance::constructorBody):
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
(JSC::ErrorPrototype::constructorBody):
* runtime/ErrorPrototype.h:
* runtime/Executable.cpp:
(JSC::FunctionExecutable::FunctionExecutable):
* runtime/Executable.h:
(JSC::FunctionExecutable::constructorBody):
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
* runtime/InternalFunction.h:
(JSC::InternalFunction::constructorBody):
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::JSByteArray):
* runtime/JSByteArray.h:
(JSC::JSByteArray::constructorBody):
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::constructorBody):
* runtime/JSFunction.h:
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::constructorBody):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::constructorBody):
* runtime/JSString.h:
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::constructorBody):
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
* runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::constructorBody):
* runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::constructorBody):
* runtime/NativeErrorPrototype.h:
* runtime/StringObject.cpp:
* runtime/StringObject.h:
(JSC::StringObject::create):
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::create):
(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::StringPrototype):
* runtime/StringPrototype.h:
(JSC::StringPrototype::create):

Source/WebCore:

No new tests.

Refactoring to put all allocations that need to be done after the object's
initialization list has executed but before the object is ready for use
into a separate constructorBody() method.  This method is still called by the constructor,
so the patch doesn't resolve any potential issues, it's just to set up the code for further refactoring.

* bridge/objc/ObjCRuntimeObject.h:
(JSC::Bindings::ObjCRuntimeObject::create):
* bridge/objc/ObjCRuntimeObject.mm:
* bridge/objc/objc_instance.mm:
(ObjCRuntimeMethod::create):
(ObjCRuntimeMethod::ObjCRuntimeMethod):
* bridge/runtime_array.cpp:
* bridge/runtime_array.h:
(JSC::RuntimeArray::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=66495
bdakin@apple.com [Fri, 19 Aug 2011 00:44:35 +0000 (00:44 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=66495
Lion-specific scroller SPIs can use forward declaration instead of
WebKitSystemInterface

Reviewed by Sam Weinig.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* platform/mac/NSScrollerImpDetails.h: Added.
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPartAnimation setCurrentProgress:]):
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
(WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):
* platform/mac/ScrollbarThemeMac.h:
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::updateEnabledState):
(WebCore::scrollbarPainterPaint):
(WebCore::ScrollbarThemeMac::paint):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac: Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=66495
Lion-specific scroller SPIs can use forward declaration instead of
WebKitSystemInterface

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Source/WebKit2: Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=66495
Lion-specific scroller SPIs can use forward declaration instead of
WebKitSystemInterface

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

WebKitLibraries: Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=66495
Lion-specific scroller SPIs can use forward declaration instead of
WebKitSystemInterface

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceLion.a:
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9973194> Fonts that specify a positive descender value are treated...
mitz@apple.com [Fri, 19 Aug 2011 00:23:52 +0000 (00:23 +0000)]
<rdar://problem/9973194> Fonts that specify a positive descender value are treated as having descenders ending above the baseline
https://bugs.webkit.org/show_bug.cgi?id=66515

Reviewed by Darin Adler.

No test because none of the system fonts and test fonts have an incorrectly-specified descender value.

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit): If the font specifies a positive descender, assume that it meant
the same amount, but negative. This is consistent with what Core Text does.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG non-speculative JIT does not inline the double case of ValueAdd
fpizlo@apple.com [Fri, 19 Aug 2011 00:18:49 +0000 (00:18 +0000)]
DFG non-speculative JIT does not inline the double case of ValueAdd
https://bugs.webkit.org/show_bug.cgi?id=66025

Reviewed by Gavin Barraclough.

This is a 1.3% win on Kraken overall, with >=8% speed-ups on a few
benchmarks (imaging-darkroom, stanford-crypto-pbkdf2,
stanford-crypto-sha256-iterative).  It looks like it might have
a speed-up in SunSpider (though not statistically significant or
particularly reproducible) and a slight slow-down in V8 (0.14%,
not statistically significant).  It does slow down v8-crypto by
1.5%.

* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::isKnownInteger):
(JSC::DFG::JITCodeGenerator::isKnownNumeric):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::basicArithOp):
* dfg/DFGOperations.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Fix results. Just copy over the platform independent results.
tony@chromium.org [Fri, 19 Aug 2011 00:00:10 +0000 (00:00 +0000)]
[chromium] Fix results.  Just copy over the platform independent results.

* platform/chromium/fast/frames/frame-set-scaling-rotate-expected.png:
* platform/chromium/fast/frames/frame-set-scaling-skew-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdded Frame Set Scaling Test Results for WebKit1 Mac and WebKit2 Mac
fsamuel@chromium.org [Thu, 18 Aug 2011 23:29:47 +0000 (23:29 +0000)]
Added Frame Set Scaling Test Results for WebKit1 Mac and WebKit2 Mac
https://bugs.webkit.org/show_bug.cgi?id=66493

The expected results of the layout tests written for
https://bugs.webkit.org/show_bug.cgi?id=57785
differ between WebKitt Mac and WebKit2 Mac.

WebKit2 Mac matches the cross-platform results.
WebKit1 Mac has a special set of test results.

Reviewed by Tony Chang.

* platform/chromium/fast/frames/frame-set-scaling-3d-expected.png: Added.
* platform/chromium/fast/frames/frame-set-scaling-3d-expected.txt: Added.
* platform/chromium/fast/frames/frame-set-scaling-centered-expected.png: Added.
* platform/chromium/fast/frames/frame-set-scaling-centered-expected.txt: Added.
* platform/chromium/fast/frames/frame-set-scaling-expected.png: Added.
* platform/chromium/fast/frames/frame-set-scaling-expected.txt: Added.
* platform/chromium/fast/frames/frame-set-scaling-rotate-expected.png: Added.
* platform/chromium/fast/frames/frame-set-scaling-rotate-expected.txt: Added.
* platform/chromium/fast/frames/frame-set-scaling-skew-expected.png: Added.
* platform/chromium/fast/frames/frame-set-scaling-skew-expected.txt: Added.
* platform/mac-wk2/fast/frames/frame-set-scaling-3d-expected.png: Added.
* platform/mac-wk2/fast/frames/frame-set-scaling-centered-expected.png: Added.
* platform/mac-wk2/fast/frames/frame-set-scaling-expected.png: Added.
* platform/mac-wk2/fast/frames/frame-set-scaling-rotate-expected.png: Added.
* platform/mac-wk2/fast/frames/frame-set-scaling-skew-expected.png: Added.
* platform/mac/fast/frames/frame-set-scaling-3d-expected.png: Added.
* platform/mac/fast/frames/frame-set-scaling-centered-expected.png: Added.
* platform/mac/fast/frames/frame-set-scaling-expected.png: Added.
* platform/mac/fast/frames/frame-set-scaling-rotate-expected.png: Added.
* platform/mac/fast/frames/frame-set-scaling-skew-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Mark editing/selection/regional-indicators.html as timing
tony@chromium.org [Thu, 18 Aug 2011 23:28:11 +0000 (23:28 +0000)]
[chromium] Mark editing/selection/regional-indicators.html as timing
out on Linux debug and rebaseline 2 tests.

* platform/chromium-win/fast/frames/frame-set-scaling-rotate-expected.png: Added.
* platform/chromium-win/fast/frames/frame-set-scaling-skew-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agopositionForPoint returns wrong VisiblePosition at bidi boundaries
rniwa@webkit.org [Thu, 18 Aug 2011 23:07:15 +0000 (23:07 +0000)]
positionForPoint returns wrong VisiblePosition at bidi boundaries
https://bugs.webkit.org/show_bug.cgi?id=65356

Reviewed by David Hyatt.

Source/WebCore:

The bug was caused by RenderText::positionForPoint's assuming that the position will always reside
inside the inline box that contains the point, which is not true at the boundaries of bidi-runs.

For example, in aDC12BAb where AB12CD is a RTL text, the offset on the right of A is 7 even though
the inline box for "BA" only contains offsets 1, 2, and 3. We must traverse the bidi-run "DC12BA"
until the end to obtain the offset 7 from the inline box for "DC".

Fixed the bug by introducing createVisiblePositionAfterAdjustingOffsetForBiDi which traverses runs
on the left or the right of the position to compute the appropriate offset following the NSTextView convention.

This patch also fixes a regression from r74971 that caret is placed incorrectly between inline boxes of
LTR or RTL text in a RTL or LTR block respectively.

Test: editing/selection/caret-at-bidi-boundary.html

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::offsetForPosition):
* rendering/RenderText.cpp:
(WebCore::lineDirectionPointFitsInBox): Takes ShouldAffinityBeDownstream instead of EAfinity.
(WebCore::createVisiblePositionForBox):
(WebCore::createVisiblePositionAfterAdjustingOffsetForBiDi):
(WebCore::RenderText::positionForPoint):

LayoutTests:

* editing/selection/caret-at-bidi-boundary-expected.txt: Added.
* editing/selection/caret-at-bidi-boundary.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago--webkit-visual-word renaming right/leftWordPositionAcrossBoundary
xji@chromium.org [Thu, 18 Aug 2011 23:05:42 +0000 (23:05 +0000)]
--webkit-visual-word renaming right/leftWordPositionAcrossBoundary
https://bugs.webkit.org/show_bug.cgi?id=66436

Reviewed by Ryosuke Niwa.

Rename them to right/leftWordPositionIgnoringEditingBoundary.

* editing/visible_units.cpp:
(WebCore::leftWordPositionIgnoringEditingBoundary):
(WebCore::rightWordPositionIgnoringEditingBoundary):
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement WebMediaPlayerClientImpl::audioSourceProvider() and interface into chromium
crogers@google.com [Thu, 18 Aug 2011 23:05:19 +0000 (23:05 +0000)]
Implement WebMediaPlayerClientImpl::audioSourceProvider() and interface into chromium
https://bugs.webkit.org/show_bug.cgi?id=66441

Reviewed by Darin Fisher.

* public/WebAudioSourceProvider.h: Added.
(WebKit::WebAudioSourceProvider::~WebAudioSourceProvider):
* public/WebMediaPlayer.h:
(WebKit::WebMediaPlayer::audioSourceProvider):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::audioSourceProvider):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::provideInput):
* src/WebMediaPlayerClientImpl.h:
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::AudioSourceProviderImpl):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::~AudioSourceProviderImpl):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSoft link against AVFoundationCF and CoreMedia
jeffm@apple.com [Thu, 18 Aug 2011 22:57:04 +0000 (22:57 +0000)]
Soft link against AVFoundationCF and CoreMedia
https://bugs.webkit.org/show_bug.cgi?id=65725

Add new macros to SoftLinking.h to support soft-linking to functions and variables decorated with __declspec(dllimport),
and use them to soft-link to AVFoundationCF and CoreMedia. I verified that the WebProcess doesn't load these DLLs
until a media element is used.

Reviewed by Eric Carlson.

No new tests as no change in functionality.

* WebCore.vcproj/WebCore.vcproj: Added AVFoundationCFSoftLinking.h and CoreMediaSoftLinking.h.
* WebCore.vcproj/WebCoreMediaQT.vsprops: Removed DelayLoadDLLs linker option which is no longer needed.
* platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Added.
* platform/graphics/avfoundation/cf/CoreMediaSoftLinking.h: Added.
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Stop linking against AVFoundationCF.lib and CoreMedia.lib and include AVFoundationCFSoftLinking.h and CoreMediaSoftLinking.h.
* platform/win/SoftLinking.h: Added SOFT_LINK_DLL_IMPORT() and SOFT_LINK_VARIABLE_DLL_IMPORT() macros.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium Mac: Show scrollbar when doing search
commit-queue@webkit.org [Thu, 18 Aug 2011 22:46:42 +0000 (22:46 +0000)]
Chromium Mac: Show scrollbar when doing search
https://bugs.webkit.org/show_bug.cgi?id=66209

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-18
Reviewed by James Robinson.

Source/WebCore:

Updated the Lion scrollbar drawing code to force the scrollbar to be visible when we have tickmarks for search results.

No tests because there are no Mac 10.7 chromium bots yet.

* platform/chromium/ScrollbarThemeChromiumMac.h:
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::paint):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):

Source/WebKit/chromium:

Fixed a bug in invalidateArea where it wouldn't properly invalidate overlay scrollbars. The problem was that it was assuming that the scrollbar was always to the right of the visible scrollbar. This isn't true for overlay scrollbars.

No tests because there are no Mac 10.7 chromium bots yet.

* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::invalidateArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Draw the root/"non-composited content" in compositor side
commit-queue@webkit.org [Thu, 18 Aug 2011 22:42:25 +0000 (22:42 +0000)]
[chromium] Draw the root/"non-composited content" in compositor side
https://bugs.webkit.org/show_bug.cgi?id=58834

Patch by James Robinson <jamesr@chromium.org> on 2011-08-18
Reviewed by Kenneth Russell.

Source/WebCore:

Handle the root or non-composited content with a GraphicsLayer rather than special case logic in
LayerRendererChromium. This layer's client is the NonCompositedContentHost, which routes the paint callbacks
through the LayerPainterChromium interface out to the WebView.  The root layer is special in two ways:
*) The root layer has a scroll offset, which changes how the visibleLayerRect maps to content space and applies a
    draw-time transform.
*) The root layer masks the alpha channel and disable blending when drawing because of concerns about subpixel
    AA trashing the alpha channel.  The root layer is always opaque so this is fine.
*) The root layer does not have border texels and does have subpixel AA for text.

Covered by compositing/

* WebCore.gypi:
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::scrollPosition):
(WebCore::LayerChromium::setScrollPosition):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::releaseTextures):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::getFramebufferPixels):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
(WebCore::LayerRendererChromium::layerTreeAsText):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::rootLayer):
(WebCore::LayerRendererChromium::viewportSize):
(WebCore::LayerRendererChromium::viewportWidth):
(WebCore::LayerRendererChromium::viewportHeight):
* platform/graphics/chromium/NonCompositedContentHost.cpp: Added.
(WebCore::NonCompositedContentHost::NonCompositedContentHost):
(WebCore::NonCompositedContentHost::~NonCompositedContentHost):
(WebCore::NonCompositedContentHost::invalidateRect):
(WebCore::NonCompositedContentHost::invalidateEntireLayer):
(WebCore::NonCompositedContentHost::setScrollPosition):
(WebCore::NonCompositedContentHost::notifyAnimationStarted):
(WebCore::NonCompositedContentHost::notifySyncRequired):
(WebCore::NonCompositedContentHost::paintContents):
(WebCore::NonCompositedContentHost::showDebugBorders):
(WebCore::NonCompositedContentHost::showRepaintCounter):
* platform/graphics/chromium/NonCompositedContentHost.h: Added.
(WebCore::NonCompositedContentHost::create):
(WebCore::NonCompositedContentHost::graphicsLayer):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::scrollPosition):
(WebCore::CCLayerImpl::setScrollPosition):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::invalidateRootLayerRect):
(WebCore::CCLayerTreeHost::setRootLayer):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::reallocateRenderer):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::rootLayer):
(WebCore::CCLayerTreeHost::viewportSize):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::didRecreateGraphicsContext):
(WebKit::WebViewImpl::updateLayerTreeViewport):
* src/WebViewImpl.h:

LayoutTests:

Update pixel baselines that changes due to subtle blending
differences, primarily on scrollbars. I don't know why these keep
changing.

* compositing/checkerboard-expected.png:
* platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
* platform/chromium-gpu-linux/compositing/images/direct-image-background-color-expected.png:
* platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
* platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
* platform/chromium-gpu-linux/compositing/overflow/overflow-scroll-expected.png:
* platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
* platform/chromium-gpu-linux/compositing/webgl/webgl-background-color-expected.png:
* platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-gpu-linux/media/video-zoom-expected.png:
* platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r93354.
commit-queue@webkit.org [Thu, 18 Aug 2011 22:23:08 +0000 (22:23 +0000)]
Unreviewed, rolling out r93354.
http://trac.webkit.org/changeset/93354
https://bugs.webkit.org/show_bug.cgi?id=66503

"consensus was not reached" (Requested by senorblanco on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-18

Source/WebCore:

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawNativeImage):

LayoutTests:

* fast/canvas/drawImage-clipped-source-expected.txt: Removed.
* fast/canvas/drawImage-clipped-source.html: Removed.
* fast/canvas/drawImage-clipped-source.js: Removed.
* fast/canvas/drawImage-with-invalid-args-expected.txt:
* fast/canvas/drawImage-with-invalid-args.html:
* platform/chromium/test_expectations.txt:
* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGestureRecognizer: Update how gesture-scroll works.
commit-queue@webkit.org [Thu, 18 Aug 2011 22:19:23 +0000 (22:19 +0000)]
GestureRecognizer: Update how gesture-scroll works.

Source/WebCore:

Instead of just sending a series of 'GestureUpdate' events, send a
single 'GestureBegin' event, followed by a series of 'GestureUpdate' events,
and end with a 'GestureEnd' event.
https://bugs.webkit.org/show_bug.cgi?id=66267

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-08-18
Reviewed by Adam Barth.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
* platform/chromium/GestureRecognizerChromium.cpp:
(WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
(WebCore::InnerGestureRecognizer::appendScrollGestureBegin):
(WebCore::InnerGestureRecognizer::appendScrollGestureEnd):
(WebCore::InnerGestureRecognizer::appendScrollGestureUpdate):
(WebCore::scrollEnd):
(WebCore::isClickOrScroll):
(WebCore::inScroll):
* platform/chromium/GestureRecognizerChromium.h:
(WebCore::InnerGestureRecognizer::firstTouchPosition):

Source/WebKit/chromium:

Add a unit-test to make sure the correct gesture events are being
generated.
https://bugs.webkit.org/show_bug.cgi?id=66267

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-08-18
Reviewed by Adam Barth.

* tests/InnerGestureRecognizerTest.cpp:
(WebCore::BuildablePlatformTouchPoint::BuildablePlatformTouchPoint):
(WebCore::BuildablePlatformTouchEvent::BuildablePlatformTouchEvent):
(WebCore::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix r93349.
rniwa@webkit.org [Thu, 18 Aug 2011 22:16:21 +0000 (22:16 +0000)]
Fix r93349.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium: Update forked ScrollbarThemeChromiumMac.mm
commit-queue@webkit.org [Thu, 18 Aug 2011 22:14:23 +0000 (22:14 +0000)]
Chromium: Update forked ScrollbarThemeChromiumMac.mm
https://bugs.webkit.org/show_bug.cgi?id=65555

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-18
Reviewed by James Robinson.

Source/WebCore:

Merge recent changes to ScrollbarThemeMac.mm to ScrollbarThemeChromiumMac.mm.

* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
(wkScrollbarPainterSetEnabled):
* platform/chromium/ScrollbarThemeChromiumMac.h:
(WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages):
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::registerScrollbar):
(WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar):
(WebCore::toScrollbarPainterKnobStyle):
(WebCore::ScrollbarThemeChromiumMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeChromiumMac::updateEnabledState):
(WebCore::ScrollbarThemeChromiumMac::paint):

LayoutTests:

Removing the chromium-cg-mac version of the expectation file since it now matches the mac one.

* platform/chromium-cg-mac/fast/events/scrollbar-double-click-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoadd embedded png checksums to WebKitTestRunner
tony@chromium.org [Thu, 18 Aug 2011 22:08:28 +0000 (22:08 +0000)]
add embedded png checksums to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=66494

Looks like WebKitTestRunner has never supported embedded checksums.  This copies
some code from DRT and adds it to the WebKitTestRunner.

Reviewed by Darin Adler.

* WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
* WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
* WebKitTestRunner/GNUmakefile.am: Add new files
* WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
* WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
* WebKitTestRunner/cairo/TestInvocationCairo.cpp:
(WTR::dumpBitmap): Refactor to use PixelDumpSupport.
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
* WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::dumpBitmap): Refactor to use PixelDumpSupport.
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
* WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Unwarranted DOM Exception when when canvas2D drawImage is called...
commit-queue@webkit.org [Thu, 18 Aug 2011 22:03:11 +0000 (22:03 +0000)]
Source/WebCore: Unwarranted DOM Exception when when canvas2D drawImage is called with src
rect out of bounds
https://bugs.webkit.org/show_bug.cgi?id=65709

Patch by Justin Novosad <junov@chromium.org> on 2011-08-18
Reviewed by Stephen White.

Test: fast/canvas/drawImage-clipped-source.html

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
Removed the unnecessary dom exceptions for out of bounds source rectangles
The overloads that receive video and image elements as source images
now use the normalized versions of the source rectangle, which
GraphicsContext (and its various platform flavors) can handle correctly.
The normalized rectangle is the equivalent rectangle with width and height
greater than 0.  The canvas version of this method, which had better layout
test coverage, was already correctly using the normalized rectangle. The
newly added layout test verifies correct behavior with negative
source rectangle dimensions.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawNativeImage):
Fixed algorithm that adjusts the destination rectangle to match the clipping
applied to the source rect. The case of scaled filtered images with source
rectangles that overlap the edge of the image was not being handled
correctly. This use case was previously unsupported and used to trigger
a DOM exception.

LayoutTests: Unwarranted DOM Exception when when canvas2D drawImage is called with src
rect out of bounds
https://bugs.webkit.org/show_bug.cgi?id=65709

Patch by Justin Novosad <junov@chromium.org> on 2011-08-18
Reviewed by Stephen White.

* fast/canvas/drawImage-clipped-source-expected.txt: Added.
* fast/canvas/drawImage-clipped-source.html: Added.
New test that verifies the clipping behavior when source rectangles
are partially out of the bounds of the source image
* fast/canvas/drawImage-clipped-source.js: Added.
(patternTest.this.testPixel):
(patternTest.this.testRedSquare):
(patternTest.this.testPattern):
(patternTest.this.testAggregatePattern):
(patternTest):
(drawTestPattern):
(executeTest):
* fast/canvas/drawImage-with-invalid-args-expected.txt:
* fast/canvas/drawImage-with-invalid-args.html:
This test covers (among other things) cases where the source rectangle is
_completely_ outside the bounds of the source image.  It was modified to no
longer expect DOM exceptions
* platform/chromium/test_expectations.txt:
Out-dated test canvas/philip/tests/2d.drawImage.outsidesource.html
is now expected to fail
* platform/mac/Skipped:
Skipping canvas/philip/tests/2d.drawImage.outsidesource.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago [Gtk] editing/selection/regional-indicators.html fails
ap@apple.com [Thu, 18 Aug 2011 21:55:54 +0000 (21:55 +0000)]
    [Gtk] editing/selection/regional-indicators.html fails
        https://bugs.webkit.org/show_bug.cgi?id=66501

        * platform/gtk/editing/selection/regional-indicators-expected.txt: Land failing results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Use a correct name for expected results.
ap@apple.com [Thu, 18 Aug 2011 21:53:57 +0000 (21:53 +0000)]
    Use a correct name for expected results.

        * platform/qt/editing/selection/regional-indicators-actual.txt: Removed.
        * platform/qt/editing/selection/regional-indicators-expected.txt: Copied from LayoutTests/platform/qt/editing/selection/regional-indicators-actual.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago [Qt] editing/selection/regional-indicators.html fails
ap@apple.com [Thu, 18 Aug 2011 21:50:56 +0000 (21:50 +0000)]
    [Qt] editing/selection/regional-indicators.html fails
        https://bugs.webkit.org/show_bug.cgi?id=66500

        * platform/qt/editing/selection/regional-indicators-actual.txt: Land failing results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r93329.
commit-queue@webkit.org [Thu, 18 Aug 2011 21:00:56 +0000 (21:00 +0000)]
Unreviewed, rolling out r93329.
http://trac.webkit.org/changeset/93329
https://bugs.webkit.org/show_bug.cgi?id=66497

Turned text on chromium win blue (Requested by jamesr_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-18

Source/WebCore:

* WebCore.gypi:
* platform/graphics/chromium/ContentLayerChromium.cpp:
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::prepareToUpdate):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::dumpLayerProperties):
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::releaseTextures):
(WebCore::LayerRendererChromium::updateRootLayerContents):
(WebCore::LayerRendererChromium::drawRootLayer):
(WebCore::LayerRendererChromium::invalidateRootLayerRect):
(WebCore::LayerRendererChromium::rootLayerChanged):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::paintLayerContents):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::getFramebufferPixels):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
(WebCore::LayerRendererChromium::layerTreeAsText):
(WebCore::LayerRendererChromium::dumpRenderSurfaces):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::rootLayer):
* platform/graphics/chromium/NonCompositedContentHost.cpp: Removed.
* platform/graphics/chromium/NonCompositedContentHost.h: Removed.
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::dumpSurface):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::createTilerIfNeeded):
(WebCore::TiledLayerChromium::tilingTransform):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::createRootLayerPainter):
(WebCore::CCLayerTreeHost::invalidateRootLayerRect):
(WebCore::CCLayerTreeHost::setRootLayer):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::reallocateRenderer):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::rootLayer):
(WebCore::CCLayerTreeHost::viewportContentRect):
(WebCore::CCLayerTreeHost::viewportScrollPosition):
(WebCore::CCLayerTreeHost::viewportVisibleRect):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::draw):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setRootPlatformLayer):
(WebKit::WebViewImpl::didRecreateGraphicsContext):
(WebKit::WebViewImpl::updateLayerTreeViewport):
* src/WebViewImpl.h:

LayoutTests:

* platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/ancestor-overflow-change-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
* platform/chromium-gpu-linux/compositing/images/direct-image-background-color-expected.png:
* platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
* platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
* platform/chromium-gpu-linux/compositing/overflow/overflow-scroll-expected.png:
* platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
* platform/chromium-gpu-linux/compositing/webgl/webgl-background-color-expected.png:
* platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-gpu-linux/media/video-zoom-expected.png:
* platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip tests added by r93291 on GTK because GTK's DRT doesn't support textInputControll...
rniwa@webkit.org [Thu, 18 Aug 2011 20:52:00 +0000 (20:52 +0000)]
Skip tests added by r93291 on GTK because GTK's DRT doesn't support textInputController.doCommand yet,
which is tracked by the bug 66496.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGTK rebaseline after r93221.
rniwa@webkit.org [Thu, 18 Aug 2011 20:43:59 +0000 (20:43 +0000)]
GTK rebaseline after r93221.

* platform/gtk/editing/selection/collapse-selection-in-bidi-expected.txt:
Copied from LayoutTests/platform/win/editing/selection/collapse-selection-in-bidi-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSimplifiedBackwardsTextIterator returns incorrect offset with first-letter rule
rniwa@webkit.org [Thu, 18 Aug 2011 20:41:51 +0000 (20:41 +0000)]
SimplifiedBackwardsTextIterator returns incorrect offset with first-letter rule
https://bugs.webkit.org/show_bug.cgi?id=66086

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by SimplifiedBackwardsTextIterator's not taking care of first-letter at all.
Fixing the bug by detecting RenderTextFragment in handleTextNode.

Also added m_shouldHandleFirstLetter to SimplifiedBackwardsTextIterator to keep track of whether or not
the next call to handleTextNode needs to process the first-letter part of the text fragment.

Test: editing/text-iterator/backward-textiterator-first-letter-crash.html

* editing/TextIterator.cpp:
(WebCore::firstRenderTextInFirstLetter): Extracted from handleTextNodeFirstLetter.
(WebCore::TextIterator::handleTextNodeFirstLetter): Calls firstRenderTextInFirstLetter.
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
(WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
(WebCore::SimplifiedBackwardsTextIterator::handleFirstLetter): Added.
* editing/TextIterator.h:

LayoutTests:

Added a test to ensure WebKit does not hit assertions in SimplifiedBackwardsTextIterator.
Also fixed a bug in first-letter-word-boundary.html and updated expected offsets for move backward by word
from 0 to 1 because there is unrendered space before "hello".

* editing/text-iterator/backward-textiterator-first-letter-crash-expected.txt: Added.
* editing/text-iterator/backward-textiterator-first-letter-crash.html: Added.
* editing/text-iterator/first-letter-word-boundary-expected.txt:
* editing/text-iterator/first-letter-word-boundary.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Assert that main thread and compositor thread are used safely
commit-queue@webkit.org [Thu, 18 Aug 2011 20:37:25 +0000 (20:37 +0000)]
[chromium] Assert that main thread and compositor thread are used safely
https://bugs.webkit.org/show_bug.cgi?id=66145

CCLayerTreeHostImplProxy now has public static methods isMainThread()
and isImplThread(), and we ASSERT these in various places. If threaded
compositing is disabled, we fake isImplThread() by setting a flag for
the duration of compositing, so the assert is still valid.

Patch by Iain Merrick <husky@google.com> on 2011-08-18
Reviewed by James Robinson.

Covered by existing tests.

* platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::draw):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::doComposite):
* platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:
(WebCore::CCLayerTreeHostImplProxy::postDrawLayersTaskOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommitOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::isMainThread):
(WebCore::CCLayerTreeHostImplProxy::isImplThread):
(WebCore::CCLayerTreeHostImplProxy::setImplThread):
(WebCore::CCLayerTreeHostImplProxy::commitOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::drawLayersOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::setNeedsRedrawOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::initImplOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::layerTreeHostClosedOnCCThread):
* platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h:
* platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::draw):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::draw):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=47240
commit-queue@webkit.org [Thu, 18 Aug 2011 20:36:17 +0000 (20:36 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=47240

Fixed a cygwin path problem in the chromium port of diff_image;
Also made the return values of the diff_image function more consistent.

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-18
Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRegional indicator symbols that are combined should behave as a single character...
ap@apple.com [Thu, 18 Aug 2011 20:32:55 +0000 (20:32 +0000)]
Regional indicator symbols that are combined should behave as a single character when editing
https://bugs.webkit.org/show_bug.cgi?id=65395

Reviewed by Dan Bernstein.

Source/WebCore:

Part two: make cursor movement iterator work. This fixes the problem for strings that don't
contain more than two flags in a row, as fixing it completely doesn't seem possible with ICU.

Test: editing/selection/regional-indicators.html

* platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator): Added custom
rules for regional indicator symbols.

LayoutTests:

* editing/selection/regional-indicators-expected.txt: Added.
* editing/selection/regional-indicators.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix rubber band gutter drawing for Skia on Chromium Mac
caryclark@google.com [Thu, 18 Aug 2011 20:22:52 +0000 (20:22 +0000)]
Fix rubber band gutter drawing for Skia on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=66478

Reviewed by James Robinson.

No new tests. The Skia on Chromium Mac platform has
not been enabled.

This break was detected at compile time; there is no
behavior change.

* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
Convert the CGImage into an SkBitmap if Skia is present.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a bunch of accessors to WebAccessibilityObject to expose more of
commit-queue@webkit.org [Thu, 18 Aug 2011 20:22:47 +0000 (20:22 +0000)]
Add a bunch of accessors to WebAccessibilityObject to expose more of
AccessibilityObject to Chromium, including range control values,
document load state, live region attributes, and a few other
ARIA attributes.

https://bugs.webkit.org/show_bug.cgi?id=66411

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-08-18
Reviewed by Dimitri Glazkov.

* public/WebAccessibilityObject.h:
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::isAriaReadOnly):
(WebKit::WebAccessibilityObject::isButtonStateMixed):
(WebKit::WebAccessibilityObject::isControl):
(WebKit::WebAccessibilityObject::isFocused):
(WebKit::WebAccessibilityObject::isLoaded):
(WebKit::WebAccessibilityObject::isRequired):
(WebKit::WebAccessibilityObject::isVertical):
(WebKit::WebAccessibilityObject::accessKey):
(WebKit::WebAccessibilityObject::ariaHasPopup):
(WebKit::WebAccessibilityObject::ariaLiveRegionAtomic):
(WebKit::WebAccessibilityObject::ariaLiveRegionBusy):
(WebKit::WebAccessibilityObject::ariaLiveRegionRelevant):
(WebKit::WebAccessibilityObject::ariaLiveRegionStatus):
(WebKit::WebAccessibilityObject::estimatedLoadingProgress):
(WebKit::WebAccessibilityObject::hierarchicalLevel):
(WebKit::WebAccessibilityObject::valueDescription):
(WebKit::WebAccessibilityObject::valueForRange):
(WebKit::WebAccessibilityObject::maxValueForRange):
(WebKit::WebAccessibilityObject::minValueForRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement a faster path for painting tables with overflowing cells
jchaffraix@webkit.org [Thu, 18 Aug 2011 20:20:57 +0000 (20:20 +0000)]
Implement a faster path for painting tables with overflowing cells
https://bugs.webkit.org/show_bug.cgi?id=65491

This change introduces a smarter way of painting if the table is big enough and we have a small amount
of overflowing cells in the table. The new path does a binary search of the cells to repaint but adds
the overflowing cells to the repainting cells.

This saves ~50% when doing programmatic scrolling throught JS on a 500x100 table with some overflowing
cells. Also we cap the memory usage to a ratio of the total size of the table to avoid blowing up the
memory.

Reviewed by David Hyatt.

No new tests as the behavior should be the same.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::RenderTableSection):
(WebCore::RenderTableSection::layoutRows): Added some code to accumulate the overflowing cells
in an internal HashSet (we don't need to keep them sorted and it makes it easier to use them during
painting). If we hit the cap, flip the boolean value and clear the HashSet as the slow path does not
care about the cell's information. Make sure that the "has overflowing cells" information is still
properly encoded on our 2 values.

(WebCore::compareCellPositionsWithOverflowingCells): Added this method as we are doing a more
complicated sort:
    * the old path would sort one (mostly sorted) array by rows only as the stable sort would
      take care of keeping the column ordering inside a row.
    * the new path basically has to sort an unsorted array (taken partly from the HashSet).

(WebCore::RenderTableSection::paintObject): Tweaked the logic to account for difference between
m_forceSlowPaintPathWithOverflowingCell and has some overflowing cells. Also we make sure we don't
repaint the same cell twice.

(WebCore::RenderTableSection::nodeAtPoint): Changed to hasOverflowingCell(). We don't apply our
fast path optimization here.

* rendering/RenderTableSection.h: Transformed our original boolean into
a HashSet and a boolean. The HashSet holds up the CellStruct that are overflowing
until we reach the memory threshold. After this is hit, we just set the boolean
to avoid using too much memory.

(WebCore::RenderTableSection::hasOverflowingCell): This is the new way to determine
if we have any overflowing cell, used only for hit testing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAn EventSource constructor should throw TypeError, when the number of arguments is...
commit-queue@webkit.org [Thu, 18 Aug 2011 20:11:24 +0000 (20:11 +0000)]
An EventSource constructor should throw TypeError, when the number of arguments is not enough.
https://bugs.webkit.org/show_bug.cgi?id=66454

Patch by Kentaro Hara <haraken@google.com> on 2011-08-18
Reviewed by Adam Barth.

The spec is here: http://www.w3.org/TR/WebIDL/#es-operations.

Source/WebCore:

Test: fast/eventsource/eventsource-constructor.html

* bindings/js/JSEventSourceCustom.cpp:
(WebCore::JSEventSourceConstructor::constructJSEventSource): Changed SyntaxError to TypeError.
* bindings/v8/custom/V8EventSourceConstructor.cpp:
(WebCore::V8EventSource::constructorCallback): Changed SyntaxError to TypeError.

LayoutTests:

* fast/eventsource/eventsource-constructor-expected.txt: Changed SyntaxError to TypeError.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoA SharedWorker constructor should throw TypeError, when the number of arguments is...
commit-queue@webkit.org [Thu, 18 Aug 2011 20:09:13 +0000 (20:09 +0000)]
A SharedWorker constructor should throw TypeError, when the number of arguments is not enough.
https://bugs.webkit.org/show_bug.cgi?id=66455

Patch by Kentaro Hara <haraken@google.com> on 2011-08-18
Reviewed by Adam Barth.

The spec is here: http://www.w3.org/TR/WebIDL/#es-operations.

Source/WebCore:

Test: fast/workers/shared-worker-constructor.html

* bindings/js/JSSharedWorkerCustom.cpp:
(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker): Changed SyntaxError to TypeError.
* bindings/v8/custom/V8SharedWorkerCustom.cpp:
(WebCore::V8SharedWorker::constructorCallback): Changed SyntaxError to TypeError.

LayoutTests:

* fast/workers/shared-worker-constructor-expected.txt: Changed SyntaxError to TypeError.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-08-17 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Thu, 18 Aug 2011 20:08:04 +0000 (20:08 +0000)]
2011-08-17  Alejandro G. Castro  <alex@igalia.com>

        [GTK] Fix compilation problems with deprecations in gtk+
        https://bugs.webkit.org/show_bug.cgi?id=66073

        Reviewed by Martin Robinson.

        * platform/gtk/GtkAuthenticationDialog.cpp:
        (WebCore::GtkAuthenticationDialog::GtkAuthenticationDialog): Added
        gtk_box_new conditional compilation for gtk+-3.
        * platform/gtk/RenderThemeGtk3.cpp:
        (WebCore::RenderThemeGtk::adjustRepaintRect):
        (WebCore::RenderThemeGtk::paintSliderTrack):
        (WebCore::RenderThemeGtk::paintSliderThumb):
        (WebCore::RenderThemeGtk::adjustSliderThumbSize): Now we have have
        GTK_TYPE_SCALE in gtk+3.

2011-08-17  Alejandro G. Castro  <alex@igalia.com>

        [GTK] Fix compilation problems with deprecations in gtk+
        https://bugs.webkit.org/show_bug.cgi?id=66073

        Reviewed by Martin Robinson.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (main): G_CONST_RETURN was deprecated
        * GtkLauncher/main.c:
        (createWindow): Added gtk_box_new conditional compilation for
        gtk+-3.
        * MiniBrowser/gtk/BrowserWindow.c:
        (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we
        are just supporting gtk+-3 for WebKit2.

2011-08-17  Alejandro G. Castro  <alex@igalia.com>

        [GTK] Fix compilation problems with deprecations in gtk+
        https://bugs.webkit.org/show_bug.cgi?id=66073

        Reviewed by Martin Robinson.

        * WebCoreSupport/FullscreenVideoController.cpp:
        (FullscreenVideoController::createHud): Added gtk_box_new
        conditional compilation for gtk+-3.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMade some code even more private to a particular file and class
darin@apple.com [Thu, 18 Aug 2011 20:01:08 +0000 (20:01 +0000)]
Made some code even more private to a particular file and class
https://bugs.webkit.org/show_bug.cgi?id=66428

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKView.mm:
(-[WKView _setDrawingAreaSize:]): Made this file internal.
* UIProcess/API/mac/WKViewInternal.h: Removed _setDrawingAreaSize.
* UIProcess/DrawingAreaProxy.h: Made sizeDidChange private.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoA Worker constructor should throw TypeError, when the number of arguments is not...
commit-queue@webkit.org [Thu, 18 Aug 2011 19:43:13 +0000 (19:43 +0000)]
A Worker constructor should throw TypeError, when the number of arguments is not enough
https://bugs.webkit.org/show_bug.cgi?id=66456

Patch by Kentaro Hara <haraken@google.com> on 2011-08-18
Reviewed by Adam Barth.

Spec is here: http://www.w3.org/TR/WebIDL/#es-operations.

Source/WebCore:

Test: fast/workers/worker-constructor.html

* bindings/js/JSWorkerCustom.cpp:
(WebCore::JSWorkerConstructor::constructJSWorker): Changed SyntaxError to TypeError.
* bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::V8Worker::constructorCallback): Changed SyntaxError to TypeError.

LayoutTests:

* fast/workers/worker-constructor-expected.txt: Changed SyntaxError to TypeError.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix logic error causing reverse of desired WebGL rate limiting behavior
commit-queue@webkit.org [Thu, 18 Aug 2011 19:32:13 +0000 (19:32 +0000)]
Fix logic error causing reverse of desired WebGL rate limiting behavior
https://bugs.webkit.org/show_bug.cgi?id=66445

Patch by John Bates <jbates@google.com> on 2011-08-18
Reviewed by Kenneth Russell.

* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::setTextureUpdated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwitch RenderTextControl* to new layout types
leviw@chromium.org [Thu, 18 Aug 2011 19:28:33 +0000 (19:28 +0000)]
Switch RenderTextControl* to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66250

Reviewed by Eric Seidel.

Convertikng the RenderTextControl* classes to use the LayoutUnit abstraction.

No new tests as no change in behavior.

* rendering/LayoutTypes.h:
(WebCore::layoutMod): Added a function to perform the modulo operation on LayoutUnits.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::hitInnerTextElement):
* rendering/RenderTextControl.h:
* rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::preferredContentWidth):
(WebCore::RenderTextControlMultiLine::baselinePosition):
* rendering/RenderTextControlMultiLine.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::controlClipRect):
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
(WebCore::RenderTextControlSingleLine::scrollWidth):
(WebCore::RenderTextControlSingleLine::scrollHeight):
(WebCore::RenderTextControlSingleLine::scrollLeft):
(WebCore::RenderTextControlSingleLine::scrollTop):
(WebCore::RenderTextControlSingleLine::setScrollLeft):
(WebCore::RenderTextControlSingleLine::setScrollTop):
* rendering/RenderTextControlSingleLine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwitch Inline rendering classes to new layout types
leviw@chromium.org [Thu, 18 Aug 2011 19:23:22 +0000 (19:23 +0000)]
Switch Inline rendering classes to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66239

Reviewed by Eric Seidel.

Converting inline rendering classes to use the LayoutUnit abstraction from ints.

No new tests as no change in functionality.

* rendering/InlineBox.h:
(WebCore::InlineBox::logicalFrameRect):
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):
* rendering/InlineFlowBox.h:
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::logicalOverflowRect):
(WebCore::InlineTextBox::setLogicalOverflowRect):
(WebCore::InlineTextBox::baselinePosition):
(WebCore::InlineTextBox::lineHeight):
* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::logicalTopVisualOverflow):
(WebCore::InlineTextBox::logicalBottomVisualOverflow):
(WebCore::InlineTextBox::logicalLeftVisualOverflow):
(WebCore::InlineTextBox::logicalRightVisualOverflow):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::culledInlineAbsoluteRects):
(WebCore::computeMargin):
(WebCore::RenderInline::culledInlineBoundingBox):
(WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::rectWithOutlineForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::mapLocalToContainer):
(WebCore::RenderInline::lineHeight):
(WebCore::RenderInline::baselinePosition):
(WebCore::RenderInline::addDashboardRegions):
* rendering/RenderInline.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNew XML parser: add doctype to DOM tree
jpfau@apple.com [Thu, 18 Aug 2011 19:19:40 +0000 (19:19 +0000)]
New XML parser: add doctype to DOM tree
https://bugs.webkit.org/show_bug.cgi?id=66408

Reviewed by Adam Barth.

* xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::processDOCTYPE):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a test to ensure WebKit does not paste contents before
rniwa@webkit.org [Thu, 18 Aug 2011 19:17:41 +0000 (19:17 +0000)]
Add a test to ensure WebKit does not paste contents before
https://bugs.webkit.org/show_bug.cgi?id=66481

Reviewed by Alexey Proskuryakov.

Add a regression test since this bug has been fixed by r92695.

* editing/pasteboard/paste-delete-insertion-position-skip-paragraph-expected.txt: Added.
* editing/pasteboard/paste-delete-insertion-position-skip-paragraph.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=61016
dslomov@google.com [Thu, 18 Aug 2011 19:10:23 +0000 (19:10 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=61016
[WebWorkers][Chromium] Use v8 Isolates for in-process implementation of WebWorkers.
This adds an implementation of in-process dedicated workers to chromium port.
The crux of the matter is the reimplementation of WebWorkerClientImpl. WebWorkerClientImpl now
implements all three of Worker{Loader,Context,Object}Proxies and delegates the implementation to
WebKit's standard WorkerMessagingProxy.
For now, we have 3 implementations of workers in chromium WebKit:
  - In-process dedicated workers (this checkin)
  - Inter-process shared workers
  - Inter-process dedicated workers (defunct after this checkin)
This patch extracts some new common interfaces (NewWebWorkerBase and NewWebWorkerClient) for these
three implementations.
Removing the remainings of inter-process dedicated workers -related classes is left for a separate patch
(it will require coordinated changes on chromuium side).

Reviewed by David Levin.

* public/WebCommonWorkerClient.h:
* src/DatabaseObserver.cpp:
(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):
* src/LocalFileSystemChromium.cpp:
(WebCore::openFileSystemHelper):
* src/WebSharedWorkerImpl.h:
(WebKit::WebSharedWorkerImpl::newCommonClient):
* src/WebWorkerBase.h:
(WebKit::WebWorkerBase::view):
* src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::createWorkerContextProxy):
(WebKit::WebWorkerClientImpl::startWorkerContext):
(WebKit::WebWorkerClientImpl::terminateWorkerContext):
(WebKit::WebWorkerClientImpl::postMessageToWorkerContext):
(WebKit::WebWorkerClientImpl::hasPendingActivity):
(WebKit::WebWorkerClientImpl::workerObjectDestroyed):
(WebKit::WebWorkerClientImpl::connectToInspector):
(WebKit::WebWorkerClientImpl::disconnectFromInspector):
(WebKit::WebWorkerClientImpl::sendMessageToInspector):
(WebKit::WebWorkerClientImpl::postMessageToPageInspector):
(WebKit::WebWorkerClientImpl::postTaskToLoader):
(WebKit::WebWorkerClientImpl::postTaskForModeToWorkerContext):
(WebKit::WebWorkerClientImpl::postMessageToWorkerObject):
(WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObject):
(WebKit::WebWorkerClientImpl::reportPendingActivity):
(WebKit::WebWorkerClientImpl::workerContextClosed):
(WebKit::WebWorkerClientImpl::postExceptionToWorkerObject):
(WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject):
(WebKit::WebWorkerClientImpl::workerContextDestroyed):
(WebKit::WebWorkerClientImpl::allowFileSystem):
(WebKit::WebWorkerClientImpl::openFileSystem):
(WebKit::WebWorkerClientImpl::allowDatabase):
(WebKit::WebWorkerClientImpl::dispatchDevToolsMessage):
(WebKit::WebWorkerClientImpl::view):
(WebKit::WebWorkerClientImpl::WebWorkerClientImpl):
(WebKit::WebWorkerClientImpl::~WebWorkerClientImpl):
* src/WebWorkerClientImpl.h:
(WebKit::WebWorkerClientImpl::newCommonClient):
* src/WebWorkerImpl.cpp:
(WebKit::WebWorkerImpl::newCommonClient):
* src/WebWorkerImpl.h:
* src/WorkerFileSystemCallbacksBridge.cpp:
(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):
* src/WorkerFileSystemCallbacksBridge.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Draw the root/"non-composited content" in compositor side
commit-queue@webkit.org [Thu, 18 Aug 2011 19:06:59 +0000 (19:06 +0000)]
[chromium] Draw the root/"non-composited content" in compositor side
https://bugs.webkit.org/show_bug.cgi?id=58834

Patch by James Robinson <jamesr@chromium.org> on 2011-08-18
Reviewed by Darin Fisher.

Source/WebCore:

Handle the root or non-composited content with a GraphicsLayer rather than special case logic in
LayerRendererChromium. This layer's client is the NonCompositedContentHost, which routes the paint callbacks
through the LayerPainterChromium interface out to the WebView.  The root layer is special in two ways:
*) The root layer has a scroll offset, which changes how the visibleLayerRect maps to content space and applies a
    draw-time transform.
*) The root layer masks the alpha channel when drawing because of concerns about subpixel AA trashing the alpha
    channel.  The root layer is always opaque so this is fine.
*) The root layer does not have border texels and does have subpixel AA for text.

Covered by compositing/

* WebCore.gypi:
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::scrollPosition):
(WebCore::LayerChromium::setScrollPosition):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::releaseTextures):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::getFramebufferPixels):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
(WebCore::LayerRendererChromium::layerTreeAsText):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::rootLayer):
(WebCore::LayerRendererChromium::viewportSize):
(WebCore::LayerRendererChromium::viewportWidth):
(WebCore::LayerRendererChromium::viewportHeight):
* platform/graphics/chromium/NonCompositedContentHost.cpp: Added.
(WebCore::NonCompositedContentHost::NonCompositedContentHost):
(WebCore::NonCompositedContentHost::~NonCompositedContentHost):
(WebCore::NonCompositedContentHost::invalidateRect):
(WebCore::NonCompositedContentHost::invalidateEntireLayer):
(WebCore::NonCompositedContentHost::setScrollPosition):
(WebCore::NonCompositedContentHost::notifyAnimationStarted):
(WebCore::NonCompositedContentHost::notifySyncRequired):
(WebCore::NonCompositedContentHost::paintContents):
(WebCore::NonCompositedContentHost::showDebugBorders):
(WebCore::NonCompositedContentHost::showRepaintCounter):
* platform/graphics/chromium/NonCompositedContentHost.h: Added.
(WebCore::NonCompositedContentHost::create):
(WebCore::NonCompositedContentHost::graphicsLayer):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::scrollPosition):
(WebCore::CCLayerImpl::setScrollPosition):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::invalidateRootLayerRect):
(WebCore::CCLayerTreeHost::setRootLayer):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::reallocateRenderer):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::rootLayer):
(WebCore::CCLayerTreeHost::viewportSize):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::didRecreateGraphicsContext):
(WebKit::WebViewImpl::updateLayerTreeViewport):
* src/WebViewImpl.h:

LayoutTests:

Update pixel baselines that changes due to subtle blending
differences, primarily on scrollbars. I don't know why these keep
changing.

* compositing/checkerboard-expected.png:
* platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
* platform/chromium-gpu-linux/compositing/images/direct-image-background-color-expected.png:
* platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
* platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
* platform/chromium-gpu-linux/compositing/overflow/overflow-scroll-expected.png:
* platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
* platform/chromium-gpu-linux/compositing/webgl/webgl-background-color-expected.png:
* platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-gpu-linux/media/video-zoom-expected.png:
* platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix "missing return" gcc warning in ScrollAnimatorNone
thakis@chromium.org [Thu, 18 Aug 2011 18:51:41 +0000 (18:51 +0000)]
Fix "missing return" gcc warning in ScrollAnimatorNone
https://bugs.webkit.org/show_bug.cgi?id=66480

Reviewed by Tony Chang.

* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::PerAxisData::curveAt):
(WebCore::ScrollAnimatorNone::PerAxisData::curveDerivativeAt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] [WK2] Activating sub menus cause the WebProcess to crash
commit-queue@webkit.org [Thu, 18 Aug 2011 18:49:21 +0000 (18:49 +0000)]
[GTK] [WK2] Activating sub menus cause the WebProcess to crash
https://bugs.webkit.org/show_bug.cgi?id=66471

Patch by Amruth Raj <amruthraj@motorola.com> on 2011-08-18
Reviewed by Anders Carlsson.

* UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::WebContextMenuProxyGtk::createGtkMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevalidate expired resources if they're requested after the initial document load
simonjam@chromium.org [Thu, 18 Aug 2011 18:41:28 +0000 (18:41 +0000)]
Revalidate expired resources if they're requested after the initial document load
https://bugs.webkit.org/show_bug.cgi?id=52153

Reviewed by Antti Koivisto.

Source/WebCore:

Test: http/tests/cache/subresource-multiple-instances.html

* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::determineRevalidationPolicy):

LayoutTests:

* http/tests/cache/subresource-multiple-instances-expected.txt: Added.
* http/tests/cache/subresource-multiple-instances.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Marking tests needing win/linux baselines as such in
tony@chromium.org [Thu, 18 Aug 2011 18:29:25 +0000 (18:29 +0000)]
[chromium] Marking tests needing win/linux baselines as such in
test_expectations.txt.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDump-as-markup conversion: editing/pasteboard/block-wrappers-necessary.html
rniwa@webkit.org [Thu, 18 Aug 2011 18:26:30 +0000 (18:26 +0000)]
Dump-as-markup conversion: editing/pasteboard/block-wrappers-necessary.html
https://bugs.webkit.org/show_bug.cgi?id=66420

Reviewed by Kent Tamura.

Converted the test.

* editing/pasteboard/block-wrappers-necessary-expected.txt: Added.
* editing/pasteboard/block-wrappers-necessary.html:
* platform/chromium-cg-mac-leopard/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
* platform/chromium-win-vista/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
* platform/gtk/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
* platform/gtk/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
* platform/mac/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
* platform/mac/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
* platform/qt/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
* platform/qt/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDump-as-markup conversion: editing/pasteboard/5368833.html
rniwa@webkit.org [Thu, 18 Aug 2011 18:21:32 +0000 (18:21 +0000)]
Dump-as-markup conversion: editing/pasteboard/5368833.html
https://bugs.webkit.org/show_bug.cgi?id=66416

Reviewed by Kent Tamura.

Converted the test and also renamed the test to a more descriptive name.

* editing/pasteboard/5368833.html: Removed.
* editing/pasteboard/paste-blockquote-and-paragraph-break-expected.txt: Added.
* editing/pasteboard/paste-blockquote-and-paragraph-break.html: Copied from LayoutTests/editing/pasteboard/5368833.html.
* platform/chromium-linux/editing/pasteboard/5368833-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/5368833-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/5368833-expected.txt: Removed.
* platform/gtk/editing/pasteboard/5368833-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/5368833-expected.png: Removed.
* platform/mac/editing/pasteboard/5368833-expected.png: Removed.
* platform/mac/editing/pasteboard/5368833-expected.txt: Removed.
* platform/qt/editing/pasteboard/5368833-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate chromium gpu expected results after r93275.
tony@chromium.org [Thu, 18 Aug 2011 18:09:51 +0000 (18:09 +0000)]
Update chromium gpu expected results after r93275.

* platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate baselines for mac and win after test changes/fixes in r93275.
tony@chromium.org [Thu, 18 Aug 2011 17:59:05 +0000 (17:59 +0000)]
Update baselines for mac and win after test changes/fixes in r93275.

* platform/chromium-cg-mac/fast/canvas/canvas-composite-expected.png:
* platform/chromium-win/fast/canvas/canvas-composite-expected.png:
* platform/chromium-win/fast/canvas/canvas-composite-transformclip-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd checksums to png results. Still trying to find out why they
tony@chromium.org [Thu, 18 Aug 2011 17:48:13 +0000 (17:48 +0000)]
Add checksums to png results.  Still trying to find out why they
went missing in the first place.

* fast/frames/frame-set-scaling-3d-expected.png:
* fast/frames/frame-set-scaling-centered-expected.png:
* fast/frames/frame-set-scaling-expected.png:
* fast/frames/frame-set-scaling-rotate-expected.png:
* fast/frames/frame-set-scaling-skew-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix libc++ C++0x build
andersca@apple.com [Thu, 18 Aug 2011 17:21:21 +0000 (17:21 +0000)]
Fix libc++ C++0x build
https://bugs.webkit.org/show_bug.cgi?id=66479

Reviewed by Adam Roben.

Add missing includes.

* DumpRenderTree/LayoutTestController.cpp:
* DumpRenderTree/mac/CheckedMalloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agodump-as-markup conversion: editing/pasteboard/testcase-9507.html
rniwa@webkit.org [Thu, 18 Aug 2011 17:20:29 +0000 (17:20 +0000)]
dump-as-markup conversion: editing/pasteboard/testcase-9507.html
https://bugs.webkit.org/show_bug.cgi?id=66448

Reviewed by Kent Tamura.

Converted the test.

* editing/pasteboard/testcase-9507-expected.txt: Added.
* editing/pasteboard/testcase-9507.html:
* platform/chromium-linux/editing/pasteboard/testcase-9507-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/testcase-9507-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/testcase-9507-expected.txt: Removed.
* platform/gtk/editing/pasteboard/testcase-9507-expected.png: Removed.
* platform/gtk/editing/pasteboard/testcase-9507-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/testcase-9507-expected.png: Removed.
* platform/mac/editing/pasteboard/testcase-9507-expected.png: Removed.
* platform/mac/editing/pasteboard/testcase-9507-expected.txt: Removed.
* platform/qt/editing/pasteboard/testcase-9507-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMore C++0x libc++ build fixes
andersca@apple.com [Thu, 18 Aug 2011 17:16:17 +0000 (17:16 +0000)]
More C++0x libc++ build fixes
https://bugs.webkit.org/show_bug.cgi?id=66476

Reviewed by Adam Roben.

* Plugins/Hosted/NetscapePluginHostProxy.mm:
(WKPCSetException):
Use a WTF String here instead of an STL string.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
std::make_pair now takes rvalue references, so get rid of the template arguments and let
the compiler deduce them instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix clang libc++ C++0x build
andersca@apple.com [Thu, 18 Aug 2011 16:56:19 +0000 (16:56 +0000)]
Fix clang libc++ C++0x build
https://bugs.webkit.org/show_bug.cgi?id=66475

Reviewed by Adam Roben.

Remove calls to isnan and isfinite with integer arguments.

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::viewport):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate the device scale factor when the WebView's window changes
aroben@apple.com [Thu, 18 Aug 2011 16:43:53 +0000 (16:43 +0000)]
Update the device scale factor when the WebView's window changes

Fixes <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
WebView is moved between windows with different backing scale factors

Reviewed by Anders Carlsson.

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView viewDidMoveToWindow]): Call setDeviceScaleFactor because our new window (or no
window at all) might have a different backing scale factor than the previous one.
(-[WebView _deviceScaleFactor]): Moved to the WebFileInternal category.

Source/WebKit2:

* UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]): Call setDeviceScaleFactor because our new window (or no
window at all) might have a different backing scale factor than the previous one.
(-[WKView _deviceScaleFactor]): Moved to the new FileInternal category.

Tools:

Test that WebKit updates style when a WebView is moved between differently-scaled windows

* TestWebKitAPI/JavaScriptTest.cpp:
(TestWebKitAPI::runJSTest): Moved a little bit of code from here...
(TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
gtest's built-in error messages.

* TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and
WKView * for convenience on Mac. Added compareJSResult helper function for implementing
those overloads.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.

* TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.
(-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
(-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
(TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
(TestWebKitAPI::setPageLoaderClient): Set up the client.
(TestWebKitAPI::DynamicDeviceScaleFactor::DynamicDeviceScaleFactor): Simple constructor.
(TestWebKitAPI::DynamicDeviceScaleFactor::createWindow): Creates a
SyntheticBackingScaleFactorWindow and returns it.
(TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Loads devicePixelRatio.html and checks
that WebKit uses the correct scale factor when the WebView is not in a window, is put in a
window, is moved to a differently-scaled window, and is taken out of the window.
(TestWebKitAPI::DynamicDeviceScaleFactor::loadURL): Helper function with overloads for
WebKit1 and WebKit2.
(TestWebKitAPI::TEST_F): Runs the test, with overloads for WebKit1 and WebKit2.

* TestWebKitAPI/Tests/mac/devicePixelRatio.html: Added.

* TestWebKitAPI/mac/JavaScriptTestMac.mm: Added.
(TestWebKitAPI::runJSTest): Fairly simple overloads for WebView * and WKView *.

* TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.h: Added.
* TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: Added.
(-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): Simple
initializer.
(-[SyntheticBackingScaleFactorWindow setBackingScaleFactor:]): Simple setter.

(-[SyntheticBackingScaleFactorWindow backingScaleFactor]):
(-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]):
Overrides of NSWindow methods that WebKit uses to determine the device scale factor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake WebPageProxy keep track of the current device scale factor
aroben@apple.com [Thu, 18 Aug 2011 16:43:14 +0000 (16:43 +0000)]
Make WebPageProxy keep track of the current device scale factor

The device scale factor is no longer considered part of WebPageProxy's "view state". It now
has its own setter/getter. This made the code a little simpler and more similar to the page
scale factor. Each port-specific WebKit2 view is now responsible for calling
WebPageProxy::setDeviceScaleFactor whenever it thinks the device scale factor might have
changed.

Fixes <http://webkit.org/b/66466> WebKit2 requires every port-specific view to keep track of
the current device scale factor

Reviewed by Anders Carlsson.

* UIProcess/API/efl/PageClientImpl.cpp:
* UIProcess/API/efl/PageClientImpl.h:
* UIProcess/API/gtk/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
* UIProcess/PageClient.h:
* UIProcess/qt/QtWebPageProxy.h:
* UIProcess/win/WebView.h:
Removed deviceScaleFactor.

* UIProcess/API/mac/WKView.mm:
(-[WKView _deviceScaleFactor]): Added. Code came from PageClientImpl::deviceScaleFactor.
(-[WKView _windowDidChangeResolution:]): Changed to call WebPageProxy::setDeviceScaleFactor.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy): Initialize m_deviceScaleFactor.
(WebKit::WebPageProxy::viewStateDidChange): Removed device-scale-factor-related code.
(WebKit::WebPageProxy::setDeviceScaleFactor): Added. Records the new device scale factor and
tells the DrawingAreaProxy about it if it's actually changed.
(WebKit::WebPageProxy::creationParameters): Use m_deviceScaleFactor instead of calling out
to the PageClient.

* UIProcess/WebPageProxy.h: Added m_deviceScaleFactor and setDeviceScaleFactor, which
replaces the DeviceScaleFactor ViewStateFlag.
(WebKit::WebPageProxy::deviceScaleFactor): Inlined this now-simple getter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert r93294, doesn't compile on Chromium Mac.
tony@chromium.org [Thu, 18 Aug 2011 16:39:12 +0000 (16:39 +0000)]
Revert r93294, doesn't compile on Chromium Mac.

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-08-18 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Thu, 18 Aug 2011 16:36:45 +0000 (16:36 +0000)]
2011-08-18  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: [Extensions API] rename webInspector.resources to webInspector.network
        https://bugs.webkit.org/show_bug.cgi?id=66460

        Reviewed by Pavel Feldman.

        Tests: http/tests/inspector/extensions-network-redirect.html
               inspector/extensions/extensions-network.html

        * inspector/front-end/ExtensionAPI.js:
        (WebInspector.injectedExtensionAPI.InspectorExtensionAPI):
        (WebInspector.injectedExtensionAPI.Network.requestDispatch):
        (WebInspector.injectedExtensionAPI):
        (WebInspector.injectedExtensionAPI.Network.prototype.getHAR):
        (WebInspector.injectedExtensionAPI.defineDeprecatedProperty.getter):
        (WebInspector.injectedExtensionAPI.defineDeprecatedProperty):
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer):
        (WebInspector.ExtensionServer.prototype._inspectedURLChanged):
        (WebInspector.ExtensionServer.prototype._notifyRequestFinished):
        (WebInspector.ExtensionServer.prototype._onGetHAR):
        (WebInspector.ExtensionServer.prototype._onGetResourceContent):
        (WebInspector.ExtensionServer.prototype._requestId):
        (WebInspector.ExtensionServer.prototype._requestById):
        (WebInspector.ExtensionServer.prototype._onAddAuditCategory):
        (WebInspector.ExtensionServer.prototype._onAddAuditResult):
        (WebInspector.ExtensionServer.prototype._onStopAuditCategoryRun):
        (WebInspector.ExtensionServer.prototype.initExtensions):
        (WebInspector.ExtensionServer.prototype._onmessage):

2011-08-18  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: [Extensions API] rename webInspector.resources to webInspector.network
        https://bugs.webkit.org/show_bug.cgi?id=66460

        Reviewed by Pavel Feldman.

        * http/tests/inspector/extensions-network-redirect-expected.txt: Added.
        * http/tests/inspector/extensions-network-redirect.html: Renamed from LayoutTests/http/tests/inspector/extensions-resources-redirect.html.
        * http/tests/inspector/extensions-network-test.js: Renamed from LayoutTests/http/tests/inspector/extensions-resources-test.js.
        (extension_getRequestByUrl.onHAR):
        (extension_getRequestByUrl):
        * http/tests/inspector/extensions-resources-redirect-expected.txt: Removed.
        * http/tests/inspector/extensions-useragent-expected.txt:
        * http/tests/inspector/extensions-useragent.html:
        * inspector/extensions/extensions-api-expected.txt:
        * inspector/extensions/extensions-events-expected.txt:
        * inspector/extensions/extensions-events.html:
        * inspector/extensions/extensions-network-expected.txt: Renamed from LayoutTests/inspector/extensions/extensions-resources-expected.txt.
        * inspector/extensions/extensions-network.html: Renamed from LayoutTests/inspector/extensions/extensions-resources.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Change webview API tests to use "load-status" signal instead of "load-progress"
caio.oliveira@openbossa.org [Thu, 18 Aug 2011 15:51:27 +0000 (15:51 +0000)]
[GTK] Change webview API tests to use "load-status" signal instead of "load-progress"
https://bugs.webkit.org/show_bug.cgi?id=66243

Reviewed by Martin Robinson.

The idle_quit_loop_cb() already checks the "load-status" flag, so it is enough to
call it only when the "load-status" change.

This change is important in the context of bug 28851, which aims to change the
order in which "progress finished" and "load finished" callbacks are called. In
this new scenario, at the progress callback the load will never be finished.

* tests/testwebview.c:
(test_webkit_web_view_grab_focus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-08-18 Chang Shu <cshu@webkit.org>
chang.shu@nokia.com [Thu, 18 Aug 2011 15:39:59 +0000 (15:39 +0000)]
2011-08-18  Chang Shu  <cshu@webkit.org>

        [Windows] editing/input/password-echo-passnode2.html, editing/input/password-echo-passnode3.html,
        editing/input/password-echo-passnode.html, editing/input/password-echo-textnode.html
        failing on Windows since they were added
        https://bugs.webkit.org/show_bug.cgi?id=66461

        Reviewed by Adam Roben.

        Skip the above tests as window.textInputController is not supported on windows.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoiframe and frameset scaling is broken
abecsi@webkit.org [Thu, 18 Aug 2011 14:59:46 +0000 (14:59 +0000)]
iframe and frameset scaling is broken
https://bugs.webkit.org/show_bug.cgi?id=57785

Add missing Qt results for tests added in r93287.

Unreviewed gardening.

* platform/qt/fast/frames/iframe-scaling-with-scroll-expected.txt: Added.
* platform/qt/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: extract content loading functions from RawSourceCode to ContentProvide...
podivilov@chromium.org [Thu, 18 Aug 2011 14:56:13 +0000 (14:56 +0000)]
Web Inspector: extract content loading functions from RawSourceCode to ContentProvider implementations.
https://bugs.webkit.org/show_bug.cgi?id=66237

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/content-providers.html

* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode.prototype._loadResourceContent):
(WebInspector.RawSourceCode.prototype._loadScriptContent):
(WebInspector.RawSourceCode.prototype._loadAndConcatenateScriptsContent):
(WebInspector.ScriptContentProvider):
(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
(WebInspector.ResourceContentProvider):
(WebInspector.ResourceContentProvider.prototype.requestContent):

LayoutTests:

* inspector/debugger/content-providers-expected.txt: Added.
* inspector/debugger/content-providers.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[CSSRegions] RenderRegion should not reference a parent RenderFlowThread
commit-queue@webkit.org [Thu, 18 Aug 2011 14:36:46 +0000 (14:36 +0000)]
[CSSRegions] RenderRegion should not reference a parent RenderFlowThread
https://bugs.webkit.org/show_bug.cgi?id=66142

Source/WebCore:

Added code that checks the parent RenderFlowThread of a RenderRegion and creates
a dependency for its referenced RenderFlowThread (from CSS style).

There are two cases:
1. A RenderRegion tries to display the flow thread that laid it out. In this case
the region will be ignored and will not participate in the flow threads regions list.
2. A RenderRegion tries to display a flow thread that contains another region that
tries to display the first region's flow thread. This one can be generalized with any
number of intermediate flow threads. In this case the recursion is detected and only the
first added region will actually be selected. The other region will be ignored. However,
when the recursion is removed the invalid regions will be recovered.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-18
Reviewed by David Hyatt.

Tests: fast/regions/flows-dependency-dynamic-remove.html
       fast/regions/flows-dependency-same-flow.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::insertPositionedObject):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::dependsOn):
(WebCore::RenderFlowThread::addRegionToThread):
(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::checkInvalidRegions):
(WebCore::RenderFlowThread::addDependencyOnFlowThread):
(WebCore::RenderFlowThread::removeDependencyOnFlowThread):
(WebCore::RenderFlowThread::pushDependencies):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeLogicalWidth):
(WebCore::RenderFlowThread::computeLogicalHeight):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
* rendering/RenderFlowThread.h:
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::appendChildNode):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::~RenderRegion):
(WebCore::RenderRegion::paintReplaced):
(WebCore::RenderRegion::nodeAtPoint):
(WebCore::RenderRegion::attachRegion):
(WebCore::RenderRegion::detachRegion):
* rendering/RenderRegion.h:
(WebCore::RenderRegion::parentFlowThread):
(WebCore::RenderRegion::isValid):
(WebCore::RenderRegion::setIsValid):
* rendering/RenderTreeAsText.cpp:
(WebCore::writeRenderFlowThreads):
(WebCore::writeLayers):
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):
(WebCore::RenderView::renderFlowThreadWithName):
(WebCore::RenderView::layoutRenderFlowThreads):
* rendering/RenderView.h:
(WebCore::RenderView::hasRenderFlowThreads):
(WebCore::RenderView::isRenderFlowThreadOrderDirty):
(WebCore::RenderView::setIsRenderFlowThreadOrderDirty):
(WebCore::RenderView::renderFlowThreadList):

LayoutTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-18
Reviewed by David Hyatt.

* fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
* fast/regions/flows-dependency-dynamic-remove.html: Added.
* fast/regions/flows-dependency-same-flow-expected.txt: Added.
* fast/regions/flows-dependency-same-flow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-08-18 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Thu, 18 Aug 2011 14:32:20 +0000 (14:32 +0000)]
2011-08-18  Vitaly Repeshko  <vitalyr@chromium.org>

        [chromium] Updating test expectations.

        Unreviewed.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-08-18 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Thu, 18 Aug 2011 14:12:42 +0000 (14:12 +0000)]
2011-08-18  Vitaly Repeshko  <vitalyr@chromium.org>

        [chromium] Updating test expectations.

        Unreviewed.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: add UISourceCode class.
podivilov@chromium.org [Thu, 18 Aug 2011 13:49:04 +0000 (13:49 +0000)]
Web Inspector: add UISourceCode class.
https://bugs.webkit.org/show_bug.cgi?id=66233

Source/WebCore:

This is a next step towards splitting SourceFile into RawSourceCode and UISourceCode.
UISourceCode is a part of SourceFile's interface that is visible to ScriptsPanel.
UISourceCode represents a single entry in scripts panel's files select.

Reviewed by Pavel Feldman.

Test: inspector/debugger/ui-source-code.html

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/UISourceCode.js: Added.
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.get id):
(WebInspector.UISourceCode.prototype.get url):
(WebInspector.UISourceCode.prototype.get isContentScript):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype._didRequestContent):
(WebInspector.ContentProvider):
(WebInspector.ContentProvider.prototype.requestContent):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

LayoutTests:

Reviewed by Pavel Feldman.

* inspector/debugger/ui-source-code-expected.txt: Added.
* inspector/debugger/ui-source-code.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake WebCore keep track of the current device scale factor
aroben@apple.com [Thu, 18 Aug 2011 13:26:12 +0000 (13:26 +0000)]
Make WebCore keep track of the current device scale factor

Fixes <http://webkit.org/b/66413> WebCore requires every WebKit port to keep track of the
device scale factor

Reviewed by Darin Adler.

Source/WebCore:

* WebCore.exp.in: Removed Frame::deviceScaleFactorChanged, added Page::setDeviceScaleFactor.

* css/MediaQueryEvaluator.cpp:
(WebCore::device_pixel_ratioMediaFeatureEval):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::HTMLCanvasElement):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::devicePixelRatio):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::addDashboardRegions):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::deviceScaleFactor):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::addDashboardRegions):
Changed to get the device scale factor from Page.

* loader/EmptyClients.h:
* page/Chrome.cpp:
* page/Chrome.h:
* page/ChromeClient.h:
Removed Chrome[Client]::deviceScaleFactor.

* page/Frame.cpp:
* page/Frame.h:
Removed deviceScaleFactorChanged. Made deviceOrPageScaleFactorChanged public.

* page/Page.cpp:
(WebCore::Page::Page): Initialize m_deviceScaleFactor.
(WebCore::Page::setDeviceScaleFactor): Added. Code came from
Frame::deviceScaleFactorChanged.

* page/Page.h: Added m_deviceScaleFactor.
(WebCore::Page::deviceScaleFactor): Added simple getter.

Source/WebKit/chromium:

* src/ChromeClientImpl.cpp:
* src/ChromeClientImpl.h:
Removed deviceScaleFactor.

Source/WebKit/efl:

* WebCoreSupport/ChromeClientEfl.cpp:
* WebCoreSupport/ChromeClientEfl.h:
Removed deviceScaleFactor.

Source/WebKit/gtk:

* WebCoreSupport/ChromeClientGtk.cpp:
* WebCoreSupport/ChromeClientGtk.h:
Removed deviceScaleFactor.

Source/WebKit/haiku:

* WebCoreSupport/ChromeClientHaiku.cpp:
* WebCoreSupport/ChromeClientHaiku.h:
Removed deviceScaleFactor.

Source/WebKit/mac:

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
Moved code to calculate the device scale factor from here...

* WebView/WebView.mm:
(-[WebView _deviceScaleFactor]):
...to here.

(-[WebView _windowDidChangeResolution:]): Now calls Page::setDeviceScaleFactor.

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate): Removed pixelRatio.
(QWebPage::viewportAttributesForSize): Now calls Page::setDeviceScaleFactor.

* Api/qwebpage_p.h: Removed pixelRatio.

* WebCoreSupport/ChromeClientQt.cpp:
* WebCoreSupport/ChromeClientQt.h:
Removed deviceScaleFactor.

Source/WebKit/win:

* WebCoreSupport/WebChromeClient.cpp:
* WebCoreSupport/WebChromeClient.h:
Removed deviceScaleFactor.

Source/WebKit/wince:

* WebCoreSupport/ChromeClientWinCE.cpp:
* WebCoreSupport/ChromeClientWinCE.h:
Removed deviceScaleFactor.

Source/WebKit/wx:

* WebKitSupport/ChromeClientWx.cpp:
* WebKitSupport/ChromeClientWx.h:
Removed deviceScaleFactor.

Source/WebKit2:

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.h:
Removed deviceScaleFactor.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::display):
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::hideFindIndicator):
* WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
(WebKit::LayerTreeHostCA::deviceScaleFactor):
Changed to get the device scale factor from WebCore.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::setDeviceScaleFactor):
* WebProcess/WebPage/WebPage.h:
Removed m_deviceScaleFactor. We always get the scale factor from WebCore now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDump-as-markup conversion: editing/pasteboard/paste-text-010.html and editing/pastebo...
rniwa@webkit.org [Thu, 18 Aug 2011 13:06:59 +0000 (13:06 +0000)]
Dump-as-markup conversion: editing/pasteboard/paste-text-010.html and editing/pasteboard/paste-text-015.html
https://bugs.webkit.org/show_bug.cgi?id=66440

Reviewed by Kent Tamura.

Converted the tests.

* editing/pasteboard/paste-text-010-expected.txt: Added.
* editing/pasteboard/paste-text-010.html:
* editing/pasteboard/paste-text-015-expected.txt: Added.
* editing/pasteboard/paste-text-015.html:
* platform/chromium-linux/editing/pasteboard/paste-text-010-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/paste-text-015-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-010-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-010-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-015-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-015-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-text-010-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-text-015-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-text-010-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-text-010-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-text-015-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-text-015-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-text-010-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-text-015-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDump-as-markup conversion: editing/pasteboard/paste-text-017.html and editing/pastebo...
rniwa@webkit.org [Thu, 18 Aug 2011 12:36:01 +0000 (12:36 +0000)]
Dump-as-markup conversion: editing/pasteboard/paste-text-017.html and editing/pasteboard/paste-text-018.html
https://bugs.webkit.org/show_bug.cgi?id=66443

Reviewed by Kent Tamura.

Converted the tests.

* editing/pasteboard/paste-text-017-expected.txt: Added.
* editing/pasteboard/paste-text-017.html:
* editing/pasteboard/paste-text-018-expected.txt: Added.
* editing/pasteboard/paste-text-018.html:
* platform/chromium-linux/editing/pasteboard/paste-text-017-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/paste-text-018-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-017-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-017-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-018-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-018-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-text-017-expected.png: Removed.
* platform/gtk/editing/pasteboard/paste-text-017-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-text-018-expected.png: Removed.
* platform/gtk/editing/pasteboard/paste-text-018-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-text-017-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-text-017-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-text-018-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-text-018-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-text-017-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-text-018-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSVG and HTML editing have conflicting inline isWhitespace functions
darin@apple.com [Thu, 18 Aug 2011 12:25:04 +0000 (12:25 +0000)]
SVG and HTML editing have conflicting inline isWhitespace functions
https://bugs.webkit.org/show_bug.cgi?id=65145

Reviewed by Nikolas Zimmermann.

Renamed the SVG-specific whitespace functions to call it "SVG space"
rather than just "whitespace". An alternative would have been to put
the functions into an SVG namespace instead of the top level WebCore
namespace.

* svg/SVGAnimateMotionElement.cpp:
(WebCore::parsePoint): Call skipOptionalSVGSpaces.
* svg/SVGAnimationElement.cpp:
(WebCore::parseKeySplines): Ditto.
* svg/SVGFitToViewBox.cpp:
(WebCore::SVGFitToViewBox::parseViewBox): Ditto.
* svg/SVGLengthList.cpp:
(WebCore::SVGLengthList::parse): Call isSVGSpace and
skipOptionalSVGSpacesOrDelimiter.
* svg/SVGParserUtilities.cpp:
(WebCore::genericParseNumber): Call skipOptionalSVGSpacesOrDelimiter.
(WebCore::parseArcFlag): Ditto.
(WebCore::parseRect): Call skipOptionalSVGSpaces.
(WebCore::pointsListFromSVGData): Ditto.
(WebCore::parseGlyphName): Call skipOptionalSVGSpaces, isSVGSpace,
and skipOptionalSVGSpacesOrDelimiter.
(WebCore::parseDelimitedString): Call skipOptionalSVGSpaces.

* svg/SVGParserUtilities.h:
(WebCore::isSVGSpace): Renamed from isWhitespace. This better matches
the comment which specifically talks about SVG.
(WebCore::skipOptionalSVGSpaces): Renamed from skipOptionalSpaces.
(WebCore::skipOptionalSVGSpacesOrDelimiter): Renamed from
skipOptionalSVGSpacesOrDelimiter.

* svg/SVGPathStringSource.cpp:
(WebCore::SVGPathStringSource::moveToNextToken): Call skipOptionalSVGSpaces.
* svg/SVGPreserveAspectRatio.cpp:
(WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio): Ditto.
* svg/SVGStringList.cpp:
(WebCore::SVGStringList::parse): Call isSVGSpace and
skipOptionalSVGSpacesOrDelimiter.
* svg/SVGTransformable.cpp:
(WebCore::parseTransformParamList): Call skipOptionalSVGSpaces and
skipOptionalSVGSpacesOrDelimiter.
(WebCore::SVGTransformable::parseTransformAttribute): Call skipOptionalSVGSpaces.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove a superfluous 'using' from WebBindings.cpp
steveblock@google.com [Thu, 18 Aug 2011 11:52:45 +0000 (11:52 +0000)]
Remove a superfluous 'using' from WebBindings.cpp
https://bugs.webkit.org/show_bug.cgi?id=66046

Reviewed by Alexey Proskuryakov.

* src/WebBindings.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[jsfunfuzz] DFG speculative JIT does divide-by-zero checks incorrectly
fpizlo@apple.com [Thu, 18 Aug 2011 11:47:26 +0000 (11:47 +0000)]
[jsfunfuzz] DFG speculative JIT does divide-by-zero checks incorrectly
https://bugs.webkit.org/show_bug.cgi?id=66426

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Changed the branchTestPtr to branchTest32.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

Reviewed by Oliver Hunt.

Added a trivial test of mod-by-zero, which fails with the previous version
of the DFG speculative JIT.

* fast/js/mod-by-zero-expected.txt: Added.
* fast/js/mod-by-zero.html: Added.
* fast/js/script-tests/mod-by-zero.js: Added.
(mod):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=66425
dslomov@google.com [Thu, 18 Aug 2011 11:43:51 +0000 (11:43 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=66425
check-webkit-style should detect incorrectly formatted file change descriptions.
Description, if present, should be separated from colon with a space.

Reviewed by David Levin.

* Scripts/webkitpy/style/checkers/changelog.py: Fix.
* Scripts/webkitpy/style/checkers/changelog_unittest.py: Unit tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPrepare frames for history navigation.
gavinp@chromium.org [Thu, 18 Aug 2011 11:10:44 +0000 (11:10 +0000)]
Prepare frames for history navigation.

Before beginning an explicit history navigation in a newly initialized
frame, it's important to give a "previous" item to avoid crashes, and
give a state to the state machine to avoid extra validating loads.

https://bugs.webkit.org/show_bug.cgi?id=66322

Reviewed by Darin Fisher.

Source/WebCore:

No new tests, as history navigation is very difficult to test in
DumpRenderTree.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::prepareForHistoryNavigation):
* loader/FrameLoader.h:

Source/WebKit/chromium:

* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::loadHistoryItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWhen changing the size of a menulist from x (x>1) to 1, the first item should be...
commit-queue@webkit.org [Thu, 18 Aug 2011 11:05:53 +0000 (11:05 +0000)]
When changing the size of a menulist from x (x>1) to 1, the first item should be selected.
https://bugs.webkit.org/show_bug.cgi?id=66282

Patch by Jing Zhao <jingzhao@chromium.org> on 2011-08-18
Reviewed by Kent Tamura.

No new tests since it only changes the behavior in Android Browser.

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseMappedAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium/mac] Enable smooth scrolling
thakis@chromium.org [Thu, 18 Aug 2011 11:02:46 +0000 (11:02 +0000)]
[chromium/mac] Enable smooth scrolling
https://bugs.webkit.org/show_bug.cgi?id=66418

Reviewed by Dimitri Glazkov.

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove TIMEOUT expectation for fast/canvas/webgl/uninitialized-test.html
steveblock@google.com [Thu, 18 Aug 2011 10:33:35 +0000 (10:33 +0000)]
Remove TIMEOUT expectation for fast/canvas/webgl/uninitialized-test.html
http://code.google.com/p/chromium/issues/detail?id=93044

This test should now pass after Chromium rolled V8 to 3.5.6 in r97287.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoHandle "form" attribute updates in parseMappedAttribute() instead of attributeChanged...
adamk@chromium.org [Thu, 18 Aug 2011 10:22:01 +0000 (10:22 +0000)]
Handle "form" attribute updates in parseMappedAttribute() instead of attributeChanged() to better match HTMLElement practices
https://bugs.webkit.org/show_bug.cgi?id=66321

Reviewed by Darin Adler.

Source/WebCore:

This is simply a cleanup change: there's no need that I can see for
HTMLFormControlElement and HTMLObjectElement to override
Element::attributeChanged since they can properly handle form
attribute changes in parseMappedAttribute, which they also override.

Though no change in behavior, I've added test coverage of the moved
code to an existing test (fast/forms/form-attribute.html) and added
a new test.

Test: fast/forms/radio-remove-form-attr.html

* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::parseMappedAttribute):
* html/HTMLFormControlElement.h:
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):
* html/HTMLObjectElement.h:

LayoutTests:

Added new coverage to ensure that adding a radio button to a radio
group in the document by removing a form attribute leaves the group in
a valid state (no more than one button checked).

Beefed up coverage of form associated elements to better cover
HTMLObjectElement.

* fast/forms/form-attribute-expected.txt:
* fast/forms/radio-remove-form-attr-expected.txt: Added.
* fast/forms/radio-remove-form-attr.html: Added.
* fast/forms/script-tests/form-attribute.js:
Added coverage of <object form=""> behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd support of setPasswordEchoEnabled and setPasswordEchoDuration for password echo...
commit-queue@webkit.org [Thu, 18 Aug 2011 10:19:50 +0000 (10:19 +0000)]
Add support of setPasswordEchoEnabled and setPasswordEchoDuration for password echo feature
https://bugs.webkit.org/show_bug.cgi?id=66052

Patch by Chang Shu <cshu@webkit.org> on 2011-08-18
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Added runtime settings in WebCore.
Added support in window.internals for testing.

Tests: editing/input/password-echo-passnode.html
       editing/input/password-echo-passnode2.html
       editing/input/password-echo-passnode3.html
       editing/input/password-echo-textnode.html

* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setPasswordEchoEnabled):
(WebCore::Settings::passwordEchoEnabled):
(WebCore::Settings::setPasswordEchoDurationInSeconds):
(WebCore::Settings::passwordEchoDurationInSeconds):
* testing/Internals.cpp:
(WebCore::Internals::Internals):
(WebCore::Internals::setPasswordEchoEnabled):
(WebCore::Internals::setPasswordEchoDurationInSeconds):
(WebCore::Internals::reset):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit/qt:

Enable password echo under the build flag.

* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):

LayoutTests:

Added tests.

* editing/input/password-echo-passnode-expected.txt: Added.
* editing/input/password-echo-passnode.html: Added.
* editing/input/password-echo-passnode2-expected.txt: Added.
* editing/input/password-echo-passnode2.html: Added.
* editing/input/password-echo-passnode3-expected.txt: Added.
* editing/input/password-echo-passnode3.html: Added.
* editing/input/password-echo-textnode-expected.txt: Added.
* editing/input/password-echo-textnode.html: Added.
* editing/input/resources: Added.
* editing/input/resources/password-echo.js: Added.
(secureChar):
(secureText):
(log):
(assert):
(run.else):
(run):
(init):
* platform/wk2/Skipped: No support yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSelecting all and inserting text into a page with a frameset leads to a NULL ptr
commit-queue@webkit.org [Thu, 18 Aug 2011 08:44:02 +0000 (08:44 +0000)]
Selecting all and inserting text into a page with a frameset leads to a NULL ptr
https://bugs.webkit.org/show_bug.cgi?id=66288

Source/WebCore:

Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-18
Reviewed by Tony Chang.

VisibleSelection returns a NoSelection to InsertTextCommand::doApply as
a new endingSelection, which isn't a sane state to be in. The code
tries to get a position on a higher node for a better selection, but
cannot go above the frameset (which exists in place of the body tag),
which lacks a renderer, and therefore cannot have a non-NoSelection
VisibleSelection.

Because this is a rare corner case, it seemed more reasonable to bail
out in this circumstance than to change the way VisibleSelection
canonicalization works. The new behavior is to delete the content, but
insert nothing. I investigated the possibility of trying to move above
or below the frameset in this particular case, but there still isn't a
renderer, so it didn't prevent the crash.

Test: editing/inserting/insert-text-into-empty-frameset-crash.html

* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::doApply):

LayoutTests:

This test selects all and inserts text in a page which contains a frameset.
It tests for a crash caused by a NULL ptr which can occur in InsertText::doApply.

Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-18
Reviewed by Tony Chang.

* editing/inserting/insert-text-into-empty-frameset-crash-expected.txt: Added.
* editing/inserting/insert-text-into-empty-frameset-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Correct the path in the Skipped list after 93283.
reni@webkit.org [Thu, 18 Aug 2011 08:09:34 +0000 (08:09 +0000)]
[Qt] Correct the path in the Skipped list after 93283.

Unreviewed gardening.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove arguments from CloseEvent::create().
commit-queue@webkit.org [Thu, 18 Aug 2011 08:02:43 +0000 (08:02 +0000)]
Remove arguments from CloseEvent::create().
https://bugs.webkit.org/show_bug.cgi?id=66294

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-18
Reviewed by Kent Tamura.

CloseEvent objects are initialized by initCloseEvent() in all cases.
Initialization in create() is redundant.

No new tests for no functional difference.

* websockets/CloseEvent.h:
(WebCore::CloseEvent::create):
(WebCore::CloseEvent::CloseEvent):
* websockets/WebSocket.cpp:
(WebCore::WebSocket::didClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoiframe and frameset scaling is broken
fsamuel@chromium.org [Thu, 18 Aug 2011 07:23:11 +0000 (07:23 +0000)]
iframe and frameset scaling is broken
https://bugs.webkit.org/show_bug.cgi?id=57785

Source/WebCore:

Reviewed by Simon Fraser.

Fixed two iframe and frameset scaling bugs:
  #1 iframes and frameset backgrounds and scroll areas are doubly scaled when they are styled with -webkit-transform.
  #2 frameset does not respect -webkit-transform-origin when scaled

Tests: fast/frames/frame-set-scaling-3d.html
       fast/frames/frame-set-scaling-centered.html
       fast/frames/frame-set-scaling-rotate.html
       fast/frames/frame-set-scaling-skew.html
       fast/frames/frame-set-scaling.html
       fast/frames/iframe-scaling-with-scroll.html

* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layout):
Update the FrameSet's layer transform after we've computed size to correctly account for the transform origin.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::childrenClipRect):
The dirty rect should be the document's unscaled size.
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidget):
(WebCore::RenderWidget::updateWidgetPosition):
Don't scale the FrameView rect here. Scaling is done within the FrameView.

LayoutTests:

Added tests to verify that framesets and iframes are scaled and positioned correctly.

Reviewed by Simon Fraser.

* fast/frames/frame-set-scaling-3d-expected.png: Added.
* fast/frames/frame-set-scaling-3d-expected.txt: Added.
* fast/frames/frame-set-scaling-3d.html: Added.
* fast/frames/frame-set-scaling-centered-expected.png: Added.
* fast/frames/frame-set-scaling-centered-expected.txt: Added.
* fast/frames/frame-set-scaling-centered.html: Added.
* fast/frames/frame-set-scaling-expected.png: Added.
* fast/frames/frame-set-scaling-expected.txt: Added.
* fast/frames/frame-set-scaling-rotate-expected.png: Added.
* fast/frames/frame-set-scaling-rotate-expected.txt: Added.
* fast/frames/frame-set-scaling-rotate.html: Added.
* fast/frames/frame-set-scaling-skew-expected.png: Added.
* fast/frames/frame-set-scaling-skew-expected.txt: Added.
* fast/frames/frame-set-scaling-skew.html: Added.
* fast/frames/frame-set-scaling.html: Added.
* fast/frames/iframe-scaling-with-scroll.html: Added.
* platform/chromium-linux/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
* platform/chromium-linux/fast/frames/iframe-scaling-with-scroll-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
* platform/mac/fast/frames/iframe-scaling-with-scroll-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowebkit-patch pretty-diff should be shown in main help
abarth@webkit.org [Thu, 18 Aug 2011 07:21:37 +0000 (07:21 +0000)]
webkit-patch pretty-diff should be shown in main help
https://bugs.webkit.org/show_bug.cgi?id=66404

Reviewed by Dimitri Glazkov.

As requested by dglazkov.

* Scripts/webkitpy/tool/commands/prettydiff.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed buildfix after r93268.
ossy@webkit.org [Thu, 18 Aug 2011 06:58:40 +0000 (06:58 +0000)]
Unreviewed buildfix after r93268.

* dom/Document.cpp:
(WebCore::disableRangeMutation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwitch RenderBox to to new layout types
eae@chromium.org [Thu, 18 Aug 2011 06:37:30 +0000 (06:37 +0000)]
Switch RenderBox to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66156

Reviewed by Eric Seidel.

Convert RenderBox to new layout abstraction as a part of the ongoing
conversion work.

No new tests as no new functionality.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
(WebCore::RenderBox::scrollLeft):
(WebCore::RenderBox::scrollTop):
(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
(WebCore::RenderBox::absoluteRects):
(WebCore::RenderBox::absoluteContentBox):
(WebCore::RenderBox::absoluteContentQuad):
(WebCore::RenderBox::outlineBoundsForRepaint):
(WebCore::RenderBox::reflectionBox):
(WebCore::RenderBox::reflectedRect):
(WebCore::RenderBox::verticalScrollbarWidth):
(WebCore::RenderBox::horizontalScrollbarHeight):
(WebCore::RenderBox::computeContentBoxLogicalWidth):
(WebCore::RenderBox::computeContentBoxLogicalHeight):
(WebCore::RenderBox::maskClipRect):
(WebCore::RenderBox::repaintLayerRectsForImage):
(WebCore::RenderBox::pushContentsClip):
(WebCore::RenderBox::overflowClipRect):
(WebCore::RenderBox::clipRect):
(WebCore::RenderBox::containingBlockLogicalWidthForContent):
(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):
(WebCore::RenderBox::positionLineBox):
(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeBlockDirectionMargins):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::computeInlineStaticDistance):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::computeLogicalLeftPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::computeBlockStaticDistance):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::computeLogicalTopPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
(WebCore::RenderBox::localCaretRect):
(WebCore::RenderBox::lineHeight):
(WebCore::RenderBox::baselinePosition):
(WebCore::RenderBox::logicalVisualOverflowRectForPropagation):
(WebCore::RenderBox::visualOverflowRectForPropagation):
(WebCore::RenderBox::logicalLayoutOverflowRectForPropagation):
(WebCore::RenderBox::layoutOverflowRectForPropagation):
(WebCore::RenderBox::locationOffsetIncludingFlipping):
* rendering/RenderBox.h:
(WebCore::RenderBox::borderFitAdjust):
(WebCore::RenderBox::intrinsicSize):
(WebCore::RenderBox::intrinsicLogicalWidth):
(WebCore::RenderBox::intrinsicLogicalHeight):
(WebCore::RenderBox::scrollbarLogicalHeight):
(WebCore::RenderBox::controlClipRect):
(WebCore::RenderBox::firstLineBoxBaseline):
(WebCore::RenderBox::lastLineBoxBaseline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93284 268f45cc-cd09-0410-ab3c-d52691b4dbfc