WebKit-https.git
9 years agoTeach git about localizable *.strings files
ddkilzer@apple.com [Wed, 6 Jun 2012 21:19:38 +0000 (21:19 +0000)]
Teach git about localizable *.strings files
<http://webkit.org/b/88447>

Reviewed by Adam Roben.

* .gitattributes: Set diff attribute for *.strings files so
git-diff doesn't complain about them being binary files once the
git-config command is run.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove some magic from the -webkit-flex shorthand parsing to match the changes in...
ojan@chromium.org [Wed, 6 Jun 2012 21:16:14 +0000 (21:16 +0000)]
Remove some magic from the -webkit-flex shorthand parsing to match the changes in the spec
https://bugs.webkit.org/show_bug.cgi?id=88444

Reviewed by Tony Chang.

Source/WebCore:

-Unset positive flex defaults to 0.
-Unset negative flex defaults to 1. No magic of doing something different if positive flex was set.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseFlex):

LayoutTests:

* css3/flexbox/flex-property-parsing-expected.txt:
* css3/flexbox/flex-property-parsing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert r119440 now that I have a time to rebaseline them all!
rniwa@webkit.org [Wed, 6 Jun 2012 21:11:45 +0000 (21:11 +0000)]
Revert r119440 now that I have a time to rebaseline them all!

* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::thumbLength):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: two manager_worker_broker_unittest tests are broken
dpranke@chromium.org [Wed, 6 Jun 2012 21:03:45 +0000 (21:03 +0000)]
webkitpy: two manager_worker_broker_unittest tests are broken
https://bugs.webkit.org/show_bug.cgi?id=88445

Reviewed by Ojan Vafai.

These tests were never updated when we removed the
--worker-model argument, and we were passing 'inline' instead of
1 (for the number of workers) :(. As a result we were creating
multiprocessing queues unnecessarily and that was failing on cygwin.

* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
(InterfaceTest.test_managerconnection_is_abstract):
(InterfaceTest.test_workerconnection_is_abstract):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: Infinite recursion in IDBObjectStore.openCursor(key, legacy_constant)
jsbell@chromium.org [Wed, 6 Jun 2012 21:01:13 +0000 (21:01 +0000)]
IndexedDB: Infinite recursion in IDBObjectStore.openCursor(key, legacy_constant)
https://bugs.webkit.org/show_bug.cgi?id=88431

Reviewed by Tony Chang.

Source/WebCore:

Function was calling itself, rather than delegating to the correct (IDBKeyRange) overload.

Test: storage/indexeddb/legacy-constants.html

* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::openCursor):

LayoutTests:

* storage/indexeddb/legacy-constants-expected.txt:
* storage/indexeddb/resources/legacy-constants.js: Refactored and added test cases.
(populateStore):
(doChecks.doNext.request.onsuccess):
(doChecks.doNext.testWithKey.request.onsuccess):
(doChecks.doNext.testWithKey):
(doChecks.doNext):
(doChecks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Avoid limiting page-scale-factor when device-scale-factor is applied in...
commit-queue@webkit.org [Wed, 6 Jun 2012 20:41:03 +0000 (20:41 +0000)]
[chromium] Avoid limiting page-scale-factor when device-scale-factor is applied in the compositor.
https://bugs.webkit.org/show_bug.cgi?id=88417

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-06-06
Reviewed by James Robinson.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rolled DEPS.
fischman@chromium.org [Wed, 6 Jun 2012 20:24:19 +0000 (20:24 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_t...
rniwa@webkit.org [Wed, 6 Jun 2012 20:12:04 +0000 (20:12 +0000)]
REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=87406

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations.__init__):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._update_expectations_file):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline_does_not_include_overrides):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: perf tests unit tests fail on chromium win
dpranke@chromium.org [Wed, 6 Jun 2012 19:57:26 +0000 (19:57 +0000)]
webkitpy: perf tests unit tests fail on chromium win
https://bugs.webkit.org/show_bug.cgi?id=88279

Reviewed by Ryosuke Niwa.

I'm seeing weird failures running the unit tests in my win32
checkout, and we don't really expect webpagereplay to work on
win32 anyway, so I'm skipping the import of that module for now
and adding a warning.

* Scripts/run-perf-tests:
* Scripts/webkitpy/performance_tests/perftest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: Rename IDBFactory.getDatabaseNames() to webkitGetDatabaseNames()
jsbell@chromium.org [Wed, 6 Jun 2012 19:00:04 +0000 (19:00 +0000)]
IndexedDB: Rename IDBFactory.getDatabaseNames() to webkitGetDatabaseNames()
https://bugs.webkit.org/show_bug.cgi?id=86874

Reviewed by Ojan Vafai.

Source/WebCore:

The function is non-standard, and should be prefixed.

Test: storage/indexeddb/factory-basics.html

* Modules/indexeddb/IDBFactory.idl:

LayoutTests:

* storage/indexeddb/factory-basics-expected.txt:
* storage/indexeddb/resources/factory-basics.js:
(test):
(openSuccess):
(deleteDatabaseSuccess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnsure consistent order of evaluation in LLInt slow paths
wingo@igalia.com [Wed, 6 Jun 2012 18:59:35 +0000 (18:59 +0000)]
Ensure consistent order of evaluation in LLInt slow paths
https://bugs.webkit.org/show_bug.cgi?id=88409

Reviewed by Geoffrey Garen.

* llint/LLIntSlowPaths.cpp:
(slow_path_mul)
(slow_path_sub)
(slow_path_div)
(slow_path_mod)
(slow_path_lshift)
(slow_path_rshift)
(slow_path_urshift)
(slow_path_bitand)
(slow_path_bitor)
(slow_path_bitxor): Avoid calling toNumber, toInt32, or toUInt32
multiple times without intervening sequence points.  Fixes
fast/js/exception-sequencing-binops.html with GCC 4.7 on x86-64
Linux, which reordered evaluation of the arguments to fmod.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Update my email address in committers.py.
commit-queue@webkit.org [Wed, 6 Jun 2012 18:47:42 +0000 (18:47 +0000)]
Unreviewed. Update my email address in committers.py.

Patch by Yong Li <yoli@rim.com> on 2012-06-06

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Expose setPictographFontFamily through the chromium webkit api.
thakis@chromium.org [Wed, 6 Jun 2012 18:00:47 +0000 (18:00 +0000)]
[chromium] Expose setPictographFontFamily through the chromium webkit api.
https://bugs.webkit.org/show_bug.cgi?id=88393

Reviewed by Adam Barth.

This was added to WebCore in
https://bugs.webkit.org/show_bug.cgi?id=65197

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setPictographFontFamily):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rolled DEPS.
rniwa@webkit.org [Wed, 6 Jun 2012 17:58:13 +0000 (17:58 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium rebaseline after r119591 because it was failing with missing results.
rniwa@webkit.org [Wed, 6 Jun 2012 17:51:17 +0000 (17:51 +0000)]
Chromium rebaseline after r119591 because it was failing with missing results.

* platform/chromium-linux/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png:
* platform/chromium-linux/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Removed.
* platform/chromium-mac-leopard/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
* platform/chromium-mac/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
* platform/chromium-win-vista/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
* platform/chromium-win-xp/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
* platform/chromium-win/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
* platform/chromium/TestExpectations:
* platform/chromium/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Robert Kroeger to commiters.py
rjkroege@chromium.org [Wed, 6 Jun 2012 17:34:03 +0000 (17:34 +0000)]
Add Robert Kroeger  to commiters.py
https://bugs.webkit.org/show_bug.cgi?id=88415

Unreviewed.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] fast/hidpi/device-scale-factor-paint.html crashes
commit-queue@webkit.org [Wed, 6 Jun 2012 17:33:32 +0000 (17:33 +0000)]
[WK2] fast/hidpi/device-scale-factor-paint.html crashes
https://bugs.webkit.org/show_bug.cgi?id=88350

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-06-06
Reviewed by Alexey Proskuryakov.

* fast/hidpi/device-scale-factor-paint-expected.html: Renamed from LayoutTests/platform/chromium/fast/hidpi/device-scale-factor-paint-expected.html.
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed rebaseline for r119591.
loislo@chromium.org [Wed, 6 Jun 2012 16:47:07 +0000 (16:47 +0000)]
Unreviewed rebaseline for r119591.

* platform/chromium-mac/svg/custom/js-late-pattern-creation-expected.png:
* platform/chromium-win/svg/custom/js-late-pattern-creation-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd support for direction on table row group with collapsing borders
jchaffraix@webkit.org [Wed, 6 Jun 2012 16:07:16 +0000 (16:07 +0000)]
Add support for direction on table row group with collapsing borders
https://bugs.webkit.org/show_bug.cgi?id=87900

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: fast/table/border-collapsing/first-cell-left-border-hidden-table-ltr-section-rtl.html
       fast/table/border-collapsing/last-cell-left-border-hidden-table-ltr-section-rtl.html
       fast/table/border-collapsing/left-border-table-ltr-section-rtl.html
       fast/table/border-collapsing/left-border-table-rtl-section-ltr.html
       fast/table/border-collapsing/left-border-table-rtl-section-rtl.html
       fast/table/border-collapsing/left-border-vertical-lr-table-ltr-section-rtl.html
       fast/table/border-collapsing/left-border-vertical-lr-table-rtl-section-ltr.html
       fast/table/border-collapsing/left-border-vertical-lr-table-rtl-section-rtl.html
       fast/table/border-collapsing/rtl-table-left-border-hidden.html
       fast/table/border-collapsing/top-border-vertical-rl-table-ltr-section-rtl.html
       fast/table/border-collapsing/top-border-vertical-rl-table-rtl-section-ltr.html
       fast/table/border-collapsing/top-border-vertical-rl-table-rtl-section-rtl.html
       fast/table/table-ltr-section-rtl.html
       fast/table/table-rtl-section-ltr.html
       fast/table/table-rtl-section-rtl.html

This change enables proper support for direction on table row group.
The current code would allow people to set direction on the row group but would still
use the table's code for directionality checks (with surprising consequences).

The main change involve swapping end / start borders in case of mixed directionality
as those 2 are not in sync.

Example: <table dir="ltr"><tbody dir="rtl"><td id="cell0"></td><td id="cell1"></td></tbody></table>

Visually:
Table: Start ---------------------> End
Tbody: End <---------------------- Start
Cell:  | #cell0        |           #cell1 |

In this example, the end table border should be compared with the tbody's start border
and the last cell's (in DOM order) start border.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::tableStartBorderAdjoiningCell):
(WebCore::RenderTable::tableEndBorderAdjoiningCell):
Same as the other adjoining functions.

* rendering/RenderTable.h:
(WebCore::RenderTable::lastColumnIndex):
Helper function to get the last column index.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::computeCollapsedEndBorder):
Updated to call the table's adjoining border helpers.

* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::styleForCellFlow):
Updated to use the table row group's style now that we properly support it.

(WebCore::RenderTableCell::isFirstOrLastCellInRow):
Debug only helper to make sure we don't call the border adjoining function
on non-terminal cells.

(WebCore::RenderTableCell::borderAdjoiningTableStart):
(WebCore::RenderTableCell::borderAdjoiningTableEnd):
* rendering/RenderTableRow.h:
(WebCore::RenderTableRow::borderAdjoiningTableStart):
(WebCore::RenderTableRow::borderAdjoiningTableEnd):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::firstRowCellAdjoiningTableStart):
(WebCore::RenderTableSection::firstRowCellAdjoiningTableEnd):
Updated the previous function to account for mixed directionality.

(WebCore::RenderTableSection::layoutRows):
Move some of the code to setLogicalPositionForCell to match RenderBlock.

(WebCore::RenderTableSection::setLogicalPositionForCell):
Switched direction checks to styleForCellFlow (this doesn't change anything as we
were already properly flipping already but ensure better).

* rendering/RenderTableSection.h:
(WebCore::RenderTableSection::hasSameDirectionAsTable):
Added this helper to know if we have a mixed direction.

(WebCore::RenderTableSection::borderAdjoiningTableStart):
(WebCore::RenderTableSection::borderAdjoiningTableEnd):
Updated to account for mixed directionality.

LayoutTests:

* fast/table/border-collapsing/first-cell-left-border-hidden-table-ltr-section-rtl-expected.html: Added.
* fast/table/border-collapsing/first-cell-left-border-hidden-table-ltr-section-rtl.html: Added.
* fast/table/border-collapsing/last-cell-left-border-hidden-table-ltr-section-rtl-expected.html: Added.
* fast/table/border-collapsing/last-cell-left-border-hidden-table-ltr-section-rtl.html: Added.
* fast/table/border-collapsing/left-border-table-ltr-section-rtl-expected.html: Added.
* fast/table/border-collapsing/left-border-table-ltr-section-rtl.html: Added.
* fast/table/border-collapsing/left-border-table-rtl-section-ltr-expected.html: Added.
* fast/table/border-collapsing/left-border-table-rtl-section-ltr.html: Added.
* fast/table/border-collapsing/left-border-table-rtl-section-rtl-expected.html: Added.
* fast/table/border-collapsing/left-border-table-rtl-section-rtl.html: Added.
* fast/table/border-collapsing/left-border-vertical-lr-table-ltr-section-rtl-expected.html: Added.
* fast/table/border-collapsing/left-border-vertical-lr-table-ltr-section-rtl.html: Added.
* fast/table/border-collapsing/left-border-vertical-lr-table-rtl-section-ltr-expected.html: Added.
* fast/table/border-collapsing/left-border-vertical-lr-table-rtl-section-ltr.html: Added.
* fast/table/border-collapsing/left-border-vertical-lr-table-rtl-section-rtl-expected.html: Added.
* fast/table/border-collapsing/left-border-vertical-lr-table-rtl-section-rtl.html: Added.
* fast/table/border-collapsing/rtl-table-left-border-hidden-expected.html: Added.
* fast/table/border-collapsing/rtl-table-left-border-hidden.html: Added.
* fast/table/border-collapsing/top-border-vertical-rl-table-ltr-section-rtl-expected.html: Added.
* fast/table/border-collapsing/top-border-vertical-rl-table-ltr-section-rtl.html: Added.
* fast/table/border-collapsing/top-border-vertical-rl-table-rtl-section-ltr-expected.html: Added.
* fast/table/border-collapsing/top-border-vertical-rl-table-rtl-section-ltr.html: Added.
* fast/table/border-collapsing/top-border-vertical-rl-table-rtl-section-rtl-expected.html: Added.
* fast/table/border-collapsing/top-border-vertical-rl-table-rtl-section-rtl.html: Added.
Most of those are test are a variation of direction on table and row group along with disabling some
borders (either using 'hidden' or just disabling it by setting it to 0px).

* fast/table/table-ltr-section-rtl-expected.html: Added.
* fast/table/table-ltr-section-rtl.html: Added.
* fast/table/table-rtl-section-ltr-expected.html: Added.
* fast/table/table-rtl-section-ltr.html: Added.
* fast/table/table-rtl-section-rtl-expected.html: Added.
* fast/table/table-rtl-section-rtl.html: Added.
Bonus as there was little testing for mixed direction + separate borders.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Enable the LLInt
wingo@igalia.com [Wed, 6 Jun 2012 16:00:38 +0000 (16:00 +0000)]
[GTK] Enable the LLInt
https://bugs.webkit.org/show_bug.cgi?id=88315

Reviewed by Filip Pizlo.

.:

* configure.ac: Require Ruby, to build the low-level interpreter.

Source/JavaScriptCore:

* GNUmakefile.am: Add rules to generate LLIntDesiredOffsets.h and
LLIntAssembly.h.
* GNUmakefile.list.am: Add offlineasm and llint files to the
dist.  Add LLInt source files to the build.
* llint/LowLevelInterpreter.asm (crash): Generate a store of
0xbbadbeef to a register, not to a constant.  Otherwise, gas was
failing to assemble result.
* offlineasm/asm.rb (labelReference): Generate a
SYMBOL_STRING_RELOCATION instead of a SYMBOL_STRING, so that we go
through the PLT on ELF systems.

Source/WTF:

* wtf/InlineASM.h: Add an implementation of LOCAL_LABEL_STRING for
OS(LINUX).
* wtf/Platform.h: Add OS(LINUX) to the set of operating systems
for ENABLE_LLINT.  Add a specific check for PLATFORM(MAC) or
PLATFORM(IOS), and add to that a check for PLATFORM(GTK).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2-Gtk]Compilation errors with flag CONTEXT_MENUS=0
commit-queue@webkit.org [Wed, 6 Jun 2012 15:57:16 +0000 (15:57 +0000)]
[WK2-Gtk]Compilation errors with flag CONTEXT_MENUS=0
https://bugs.webkit.org/show_bug.cgi?id=87842

Patch by chandra Shekar Vallala <chandra.vallala@motorola.com> on 2012-06-06
Reviewed by Martin Robinson.

Fix for compilation errors while building webkit2-gtk with CONTEXT_MENUS=0

* UIProcess/gtk/WebContextMenuProxyGtk.cpp: Added code under CONTEXT_MENUS CC
* UIProcess/gtk/WebContextMenuProxyGtk.h: Ditto
* WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp: Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] imageSmoothingEnabled should apply to patterns
commit-queue@webkit.org [Wed, 6 Jun 2012 15:17:20 +0000 (15:17 +0000)]
[Chromium] imageSmoothingEnabled should apply to patterns
https://bugs.webkit.org/show_bug.cgi?id=88103

Patch by Keyar Hood <keyar@chromium.org> on 2012-06-06
Reviewed by Stephen White.

Source/WebCore:

Test: fast/canvas/canvas-imageSmoothingEnabled-patterns.html

When drawing patterns on a Canvas, the imageSmoothingEnabled flag is
respected.
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::setupShader):

LayoutTests:

Added tests for imageSmoothingEnabled flag applying to patterns.

Modified the TestExpectations file as tests are failing due to the new
change. It makes the pictures prettier (and it agrees with other
browsers) so we have decided that the new results are to be considered
correct.
* fast/canvas/canvas-imageSmoothingEnabled-patterns.html: Added.
* platform/chromium-linux/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
* platform/chromium-linux/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][DRT] http/tests/globalhistory testcases do not pass
commit-queue@webkit.org [Wed, 6 Jun 2012 14:57:42 +0000 (14:57 +0000)]
[EFL][DRT] http/tests/globalhistory testcases do not pass
https://bugs.webkit.org/show_bug.cgi?id=82579

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-06-06
Reviewed by Csaba Osztrogonác.

Tools:

DRT has provided callbacks for ewk_view "global history delegate" signals.

* DumpRenderTree/efl/DumpRenderTree.cpp:
(isGlobalHistoryTest): Aux function to ident global history testcase.
(createLayoutTestController):
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
(DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
(DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
(DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
(DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):

LayoutTests:

* platform/efl/Skipped: Unskip http/tests/globalhistory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [JSC] Add WebGL instrumentation support
caseq@chromium.org [Wed, 6 Jun 2012 14:12:36 +0000 (14:12 +0000)]
Web Inspector: [JSC] Add WebGL instrumentation support
https://bugs.webkit.org/show_bug.cgi?id=87975

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-06-06
Reviewed by Vsevolod Vlasov.

* bindings/js/JSInjectedScriptManager.cpp:
(WebCore::injectAndExecuteFunction):
(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore):
(WebCore::InjectedScriptManager::injectWebGLScript):
* bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::injectWebGLScript):
* inspector/InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::wrapWebGLRenderingContextForInstrumentation):
* inspector/InjectedScriptManager.h:
(InjectedScriptManager):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
* inspector/InspectorWebGLAgent.cpp:
(WebCore::InspectorWebGLAgent::wrapWebGLRenderingContextForInstrumentation):
* inspector/InspectorWebGLAgent.h:
(InspectorWebGLAgent):
* inspector/InspectorWebGLInstrumentation.h:
(WebCore::InspectorInstrumentation::wrapWebGLRenderingContextForInstrumentation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] run-qtwebkit-tests hangs with -j1
commit-queue@webkit.org [Wed, 6 Jun 2012 13:09:04 +0000 (13:09 +0000)]
[Qt] run-qtwebkit-tests hangs with -j1
run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
This could happen due to an uncancelled timer after results were returned. This timer was
started only if --timeout was set.
https://bugs.webkit.org/show_bug.cgi?id=85475

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-06-06
Reviewed by Csaba Osztrogonác.

* Scripts/run-qtwebkit-tests:
(run_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed update chromium test expectations.
loislo@chromium.org [Wed, 6 Jun 2012 12:24:32 +0000 (12:24 +0000)]
Unreviewed update chromium test expectations.

* platform/chromium/TestExpectations:
css3/filters/huge-region-composited.html = CRASH : was removed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix a few spelling mistakes in IconDatabase logging
vestbo@webkit.org [Wed, 6 Jun 2012 11:41:19 +0000 (11:41 +0000)]
Fix a few spelling mistakes in IconDatabase logging

Makes debugging harder if the logging is confusing.

Reviewed by Jocelyn Turcotte.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Compiler] Remove compile-front-end.sh and fix InjectedScriptSource...
vsevik@chromium.org [Wed, 6 Jun 2012 11:37:02 +0000 (11:37 +0000)]
Web Inspector: [Compiler] Remove compile-front-end.sh and fix InjectedScriptSource errors.
https://bugs.webkit.org/show_bug.cgi?id=87512

Reviewed by Yury Semikhatsky.

Removed compile-front-end.sh, compile-front-end.py should be used instead now.
Made generate_protocol_externs a python module to call it from compile-front-end.py.
Temporary copy of InjectedScriptSource.js is created and modified to
avoid "This code lacks side effects" warning.

* inspector/compile-front-end.py:
* inspector/compile-front-end.sh: Removed.
* inspector/generate-protocol-externs: Removed.
* inspector/generate_protocol_externs.py: Added.
(full_qualified_type_id):
(param_type):
(generate_protocol_externs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] REGRESSION(r118616): It made all tests crash in debug mode
zherczeg@webkit.org [Wed, 6 Jun 2012 11:34:45 +0000 (11:34 +0000)]
[Qt] REGRESSION(r118616): It made all tests crash in debug mode
https://bugs.webkit.org/show_bug.cgi?id=87701

Reviewed by Csaba Osztrogonác.

Replace WriteBarrier<JSObject> to Weak<JSObject> by introducing a new
QtWeakObjectReference sub class. Rewrite all affected type definitions.

All existing test in debug mode cover this issue.

* bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fallbackObject):
* bridge/qt/qt_instance.cpp:
(QtRuntimeObject):
(JSC::Bindings::QtInstance::removeUnusedMethods):
* bridge/qt/qt_instance.h:
(QtInstance):
(QtWeakObjectReference):
(JSC::Bindings::QtInstance::QtWeakObjectReference::QtWeakObjectReference):
(JSC::Bindings::QtInstance::QtWeakObjectReference::operator=):
(JSC::Bindings::QtInstance::QtWeakObjectReference::get):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMethodData::finalize):
* bridge/qt/qt_runtime_qt4.cpp:
(JSC::Bindings::QtRuntimeMethodData::finalize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Option for selecting/deselecting all breakpoints in breakpoint pane
loislo@chromium.org [Wed, 6 Jun 2012 11:27:56 +0000 (11:27 +0000)]
Web Inspector: Option for selecting/deselecting all breakpoints in breakpoint pane
https://bugs.webkit.org/show_bug.cgi?id=87644

Patch by Sam D <dsam2912@gmail.com> on 2012-06-06
Reviewed by Pavel Feldman.

Added an option to enable/disable all breakpoints in Breakpoint pane.

* Source/WebCore/English.lproj/localizedStrings.js:
* Source/WebCore/inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.enableAllBreakpoints):
(WebInspector.BreakpointManager.prototype.disableAllBreakpoints):
* Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointContextMenu.enabledBreakpointCount):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointContextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Qt DRT / WTR should be able to load external resources
zoltan@webkit.org [Wed, 6 Jun 2012 11:21:43 +0000 (11:21 +0000)]
[Qt] Qt DRT / WTR should be able to load external resources
https://bugs.webkit.org/show_bug.cgi?id=87326

Reviewed by Hajime Morita.

Allow external resources to be loaded when the main frame's URL is also an external resource.
This change is analogous to r118231 for Mac port and to r119153 Chromium port.

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::blockRequest):
(WebCore):
(WebCore::isLocalhost):
(WebCore::hostIsUsedBySomeTestsToGenerateError):
(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: help/settings screen does not overlay console in split screen mode
caseq@chromium.org [Wed, 6 Jun 2012 10:41:54 +0000 (10:41 +0000)]
Web Inspector: help/settings screen does not overlay console in split screen mode
https://bugs.webkit.org/show_bug.cgi?id=88352

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-06-06
Reviewed by Pavel Feldman.

* inspector/front-end/HelpScreen.js:
(WebInspector.HelpScreen): Mark view as root.
(WebInspector.HelpScreen.prototype.showModal): Change view parent.
* inspector/front-end/helpScreen.css:
(.help-window-outer): Add panel and status bar indent.
(body.compact .help-window-outer): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Form] Changes for InputNumber type
yosin@chromium.org [Wed, 6 Jun 2012 10:26:18 +0000 (10:26 +0000)]
[Form] Changes for InputNumber type
https://bugs.webkit.org/show_bug.cgi?id=88394

Reviewed by Kent Tamura.

This patch changes codes for consitency of InputNumber usage for
reducing size of patch when we change InputNumber type alias from
double to Decimal.

No new tests. This patch doesn't change behavior.

* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::serializeWithComponents): Fixed parameter type for getAllowedValueStep.
* html/InputType.cpp:
(WebCore::InputType::minimum): Fixed return value type to InputNumber.
(WebCore::InputType::maximum): ditto.
* html/MonthInputType.cpp:
(WebCore::MonthInputType::defaultValueForStepUp): Fix return value type to InputNumber.
(WebCore::MonthInputType::parseToNumber): ditto.
* html/NumberInputType.cpp:
(WebCore::NumberInputType::setValueAsDouble): Removed extra convertDoubleToInputNumber.
* html/StepRange.cpp:
(WebCore::StepRange::alignValueForStep): Use roundByStep for code sharing.
(WebCore::StepRange::clampValue): ditto.
(WebCore::StepRange::roundByStep): Added.
* html/StepRange.h:
(StepRange): Added a declaration of roundByStep.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix harmattan builds broken by r119247.
commit-queue@webkit.org [Wed, 6 Jun 2012 10:24:47 +0000 (10:24 +0000)]
[Qt] Fix harmattan builds broken by r119247.
https://bugs.webkit.org/show_bug.cgi?id=88330

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-06-06
Reviewed by Jocelyn Turcotte.

Fix Harmattan build break caused by undefined constant
GL_TEXTURE_RECTANGLE_ARB by adding defined(GL_ARB_texture_rectangle)
guards around TextureMapperGL::drawTextureRectangleARB.

* platform/graphics/texmap/TextureMapperGL.cpp: Added defined(GL_ARB_texture_rectangle) guards around drawTextureRectangleARB.
(WebCore):
* platform/graphics/texmap/TextureMapperGL.h: Added definded(GL_ARB_texture_rectangle) guards around drawTextureRectangleARB.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
commit-queue@webkit.org [Wed, 6 Jun 2012 10:12:40 +0000 (10:12 +0000)]
[Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=88327

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-06-06
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewExperimental::setPreferredMinimumContentsWidth):
* UIProcess/API/qt/qquickwebview_p.h:

Tools:

* MiniBrowser/qt/MiniBrowser.qrc: Added contents_width.png.
* MiniBrowser/qt/icons/contents_width.png: Added.
* MiniBrowser/qt/qml/BrowserWindow.qml: Added button for toggling preferredMinimumContentsWidth.
* MiniBrowser/qt/qml/ViewportInfoItem.qml: Added display of preferredMinimumContentsWidth.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, updated TestExpectations after several tests have been
sergio@webkit.org [Wed, 6 Jun 2012 10:04:20 +0000 (10:04 +0000)]
Unreviewed, updated TestExpectations after several tests have been
regularly passing in the 3 GTK bots for some time.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Turning the bot into a springtime green
commit-queue@webkit.org [Wed, 6 Jun 2012 09:57:52 +0000 (09:57 +0000)]
[EFL] Turning the bot into a springtime green
https://bugs.webkit.org/show_bug.cgi?id=88400

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-06-06

* platform/efl/Skipped:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r106478): None of the Paper.js JavaScript examples work
wingo@igalia.com [Wed, 6 Jun 2012 09:39:04 +0000 (09:39 +0000)]
REGRESSION (r106478): None of the Paper.js JavaScript examples work
https://bugs.webkit.org/show_bug.cgi?id=87158

Source/JavaScriptCore:

Reviewed by Michael Saboff.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::resolve): If we have to bail out to
dynamicResolve(), only skip static scopes from the head of the
scope chain.  Before, we were also skipping activations with
direct eval as well, which was incorrect.

LayoutTests:

Added regression tests for functions inside eval inside a with.

Reviewed by Michael Saboff.

* fast/js/eval-and-with-expected.txt: Added.
* fast/js/eval-and-with.html: Added.
* fast/js/script-tests/eval-and-with.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Unreviewed gardening. Skip modified falining test. Rebase a test.
kkristof@inf.u-szeged.hu [Wed, 6 Jun 2012 09:34:37 +0000 (09:34 +0000)]
[Qt][WK2] Unreviewed gardening. Skip modified falining test. Rebase a test.
[Qt] Fix wrong skipping.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-06-06

* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/compositing/backing/no-backing-for-perspective-expected.txt:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPositionIterator:;setOffsetInLeafNode() is not used anywhere.
shinyak@chromium.org [Wed, 6 Jun 2012 09:03:35 +0000 (09:03 +0000)]
PositionIterator:;setOffsetInLeafNode() is not used anywhere.
https://bugs.webkit.org/show_bug.cgi?id=88397

Reviewed by Ryosuke Niwa.

It's not used anywhere. We can remove it safely.

No new tests, no change in behavior.

* WebCore.order:
* dom/PositionIterator.cpp:
* dom/PositionIterator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [WebGL] Add WebGL instrumentation support on the backend
caseq@chromium.org [Wed, 6 Jun 2012 08:35:15 +0000 (08:35 +0000)]
Web Inspector: [WebGL] Add WebGL instrumentation support on the backend
https://bugs.webkit.org/show_bug.cgi?id=87960

Adds a WebGLAgent, injects a WebGL script upon calling the getContext
method of a HTMLCanvasElement that will wrap the WebGL rendering context
for instrumentation purposes.

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-06-06
Reviewed by Yury Semikhatsky.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
(WebCore::JSHTMLCanvasElement::toDataURL):
* bindings/js/JSInjectedScriptManager.cpp:
(WebCore):
(WebCore::InjectedScriptManager::injectWebGLScript):
* bindings/v8/ScriptState.cpp:
(WebCore::ScriptState::forContext):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
* bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore):
(WebCore::InjectedScriptManager::injectWebGLScript):
(WebCore::InjectedScriptManager::discardInjectedScript):
(WebCore::InjectedScriptManager::injectedScriptFor):
* inspector/CodeGeneratorInspector.py:
* inspector/InjectedScriptManager.cpp:
(WebCore):
(WebCore::InjectedScriptManager::wrapWebGLRenderingContextForInstrumentation):
(WebCore::InjectedScriptManager::injectedWebGLScriptSource):
* inspector/InjectedScriptManager.h:
(InjectedScriptManager):
* inspector/InjectedWebGLScriptSource.js: Added.
* inspector/Inspector.json:
* inspector/InspectorAllInOne.cpp:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorInstrumentation.h:
(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::markResourceAsCached):
* inspector/InspectorWebGLAgent.cpp: Added.
(WebCore):
(WebGLAgentState):
(WebCore::InspectorWebGLAgent::InspectorWebGLAgent):
(WebCore::InspectorWebGLAgent::~InspectorWebGLAgent):
(WebCore::InspectorWebGLAgent::setFrontend):
(WebCore::InspectorWebGLAgent::clearFrontend):
(WebCore::InspectorWebGLAgent::restore):
(WebCore::InspectorWebGLAgent::enable):
(WebCore::InspectorWebGLAgent::disable):
(WebCore::InspectorWebGLAgent::wrapWebGLRenderingContextForInstrumentation):
* inspector/InspectorWebGLAgent.h: Added.
(WebCore):
(InspectorWebGLAgent):
(WebCore::InspectorWebGLAgent::create):
(WebCore::InspectorWebGLAgent::enabled):
* inspector/InspectorWebGLInstrumentation.h: Added.
(WebCore):
(WebCore::InspectorInstrumentation::wrapWebGLRenderingContextForInstrumentation):
* inspector/InstrumentingAgents.h:
(WebCore):
(WebCore::InstrumentingAgents::InstrumentingAgents):
(InstrumentingAgents):
(WebCore::InstrumentingAgents::inspectorWebGLAgent):
(WebCore::InstrumentingAgents::setInspectorWebGLAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRoll Chromium DEPS from r140700 to r140711.
kinuko@chromium.org [Wed, 6 Jun 2012 07:55:37 +0000 (07:55 +0000)]
Roll Chromium DEPS from r140700 to r140711.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebPage::windowIsVisible is incorrect during resumePainting
timothy_horton@apple.com [Wed, 6 Jun 2012 07:54:47 +0000 (07:54 +0000)]
WebPage::windowIsVisible is incorrect during resumePainting
https://bugs.webkit.org/show_bug.cgi?id=88374
<rdar://problem/11587039>

Reviewed by Simon Fraser.

Currently, when changing window visibility, WKView calls viewStateDidChange(ViewIsVisible)
and then _updateWindowVisibility. This means that during viewStateDidChange, the WebPage's
windowIsVisible state is incorrect.

viewStateDidChange(ViewIsVisible) can end up in (one of the DrawingArea implementations)::resumePainting(),
which uses windowIsVisible to determine whether or not to unpause requestAnimationFrame.

This results in a state where, with some configurations, doing the following:

    1. requestAnimationFrame()
    2. requestFullScreen()
    3. requestAnimationFrame()
    4. cancelFullScreen()
    5. requestAnimationFrame()

Will cause the second and third rAF calls to have no effect. Even after cancelFullScreen() is called,
the fact that we have had unpaired suspend/resumeScriptedAnimations will cause the suspend count
on the ScriptedAnimationController to never return to zero, which will cause us to never
recover rAF functionality.

The fix is very simple: we should _updateWindowVisibility *before* viewStateDidChange, so that it is
always correct for any code called underneath that method.

* UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidOrderOffScreen:]):
(-[WKView _windowDidOrderOnScreen:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add a WebKit::WebMediaPlayer::CORSMode enum in preparation for 88349
fischman@chromium.org [Wed, 6 Jun 2012 07:51:29 +0000 (07:51 +0000)]
[chromium] Add a WebKit::WebMediaPlayer::CORSMode enum in preparation for 88349
https://bugs.webkit.org/show_bug.cgi?id=88388

Reviewed by Darin Fisher.

* public/WebMediaPlayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReverted r119567, the fix for <http://webkit.org/b/88378>, because it broke the 32...
mitz@apple.com [Wed, 6 Jun 2012 07:37:05 +0000 (07:37 +0000)]
Reverted r119567, the fix for <webkit.org/b/88378>, because it broke the 32-bit build.

* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):
* llint/LowLevelInterpreter.asm:
* runtime/JSGlobalData.h:
(JSGlobalData):
* runtime/JSGlobalThis.cpp:
(JSC::JSGlobalThis::setUnwrappedObject):
* runtime/JSObject.cpp:
(JSC::JSObject::visitChildren):
(JSC::JSObject::createInheritorID):
* runtime/JSObject.h:
(JSObject):
(JSC::JSObject::resetInheritorID):
(JSC):
(JSC::JSObject::offsetOfInheritorID):
(JSC::JSObject::inheritorID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Build fix for Accelerated Compositing with OpenGL
commit-queue@webkit.org [Wed, 6 Jun 2012 07:29:35 +0000 (07:29 +0000)]
[GTK] Build fix for Accelerated Compositing with OpenGL
https://bugs.webkit.org/show_bug.cgi?id=88292

Patch by Joone Hur <joone.hur@intel.com> on 2012-06-06
Reviewed by Martin Robinson.

Build fix after r119247.
Do not include GraphicsSurface.h when not building
with GRAPHICS_SURFACE.

No new tests. This is only a build fix.

* platform/graphics/texmap/TextureMapperBackingStore.cpp:
* platform/graphics/texmap/TextureMapperBackingStore.h:
* platform/graphics/texmap/TextureMapperGL.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] IndexedDB file should be sand-boxed to the application data directory.
charles.wei@torchmobile.com.cn [Wed, 6 Jun 2012 07:01:11 +0000 (07:01 +0000)]
[BlackBerry] IndexedDB file should be sand-boxed to the application data directory.
https://bugs.webkit.org/show_bug.cgi?id=88065

Reviewed by George Staikos.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
* Api/WebSettings.cpp:
(WebKit):
(BlackBerry::WebKit::WebSettings::indexedDataBasePath):
(BlackBerry::WebKit::WebSettings::setIndexedDataBasePath):
* Api/WebSettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoASSERTION FAILED: ASSERT(!isPercentageIntrinsicSize) in RenderReplaced::computeIntrin...
commit-queue@webkit.org [Wed, 6 Jun 2012 06:53:11 +0000 (06:53 +0000)]
ASSERTION FAILED: ASSERT(!isPercentageIntrinsicSize) in RenderReplaced::computeIntrinsicRatioInformationForRenderBox
https://bugs.webkit.org/show_bug.cgi?id=88197

Patch by Joe Thomas <joethomas@motorola.com> on 2012-06-05
Reviewed by Daniel Bates.

RenderSVGRoot extends RenderReplaced and it overrides the computeIntrinsicRatioInformation()
method of RenderReplaced. RenderSVGRoot::computeIntrinsicRatioInformation
sets isPercentageIntrinsicSize to true while it handles width and height of percentage types.
So this assertion should be fired only if intrinsicRatio is non-zero.

Source/WebCore:

Test: svg/in-html/svg-assert-failure-percentage.html

* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeIntrinsicRatioInformationForRenderBox):

LayoutTests:

* svg/in-html/svg-assert-failure-percentage-expected.txt: Added.
* svg/in-html/svg-assert-failure-percentage.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChanging flexbox justify/alignment doesn't update their positioning
tony@chromium.org [Wed, 6 Jun 2012 06:45:22 +0000 (06:45 +0000)]
Changing flexbox justify/alignment doesn't update their positioning
https://bugs.webkit.org/show_bug.cgi?id=88366

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/flexbox/style-change.html

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff): Since these member variables were moved
out of StyleFlexibleBoxData, we have to compare them in RenderStyle::diff.

LayoutTests:

* css3/flexbox/style-change-expected.txt: Added.
* css3/flexbox/style-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSC implementation of SerializedScriptValue for IndexedDB
charles.wei@torchmobile.com.cn [Wed, 6 Jun 2012 05:51:34 +0000 (05:51 +0000)]
JSC implementation of SerializedScriptValue for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=88048

Reviewed by George Staikos.

No new tests. All the current indexeddb test cases apply when indexeddb works for JSC.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serializeNumber):
(CloneSerializer):
(WebCore::CloneDeserializer::toWireString):
(CloneDeserializer):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::toWireString):
(WebCore):
(WebCore::SerializedScriptValue::createFromWire):
(WebCore::SerializedScriptValue::numberValue):
(WebCore::SerializedScriptValue::deserialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNested CSS flexbox renders incorrectly
ojan@chromium.org [Wed, 6 Jun 2012 05:41:51 +0000 (05:41 +0000)]
Nested CSS flexbox renders incorrectly
https://bugs.webkit.org/show_bug.cgi?id=87679

Reviewed by Julien Chaffraix.

Source/WebCore:

If the containing block with a perpendicular writing mode has an overrideHeight,
then its logical height should be based off that instead of its RenderStyle.

Test: css3/flexbox/perpendicular-writing-modes-inside-flex-item.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):

LayoutTests:

* css3/flexbox/perpendicular-writing-modes-inside-flex-item-expected.txt: Added.
* css3/flexbox/perpendicular-writing-modes-inside-flex-item.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeed special-case toJS(IDBAny) for IDBCursorWithValue
charles.wei@torchmobile.com.cn [Wed, 6 Jun 2012 05:37:24 +0000 (05:37 +0000)]
Need special-case toJS(IDBAny) for IDBCursorWithValue
https://bugs.webkit.org/show_bug.cgi?id=87963

Reviewed by George Staikos.

No new tests, this is for indexedDB, which is not working for JSC binding.
When indexedDB working for JSC, all the indexdb test cases should apply.

* bindings/js/JSIDBAnyCustom.cpp:
(WebCore::toJS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRoll Chromium DEPS from r140653 to r140700.
rniwa@webkit.org [Wed, 6 Jun 2012 05:35:04 +0000 (05:35 +0000)]
Roll Chromium DEPS from r140653 to r140700.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Use Component.onCompleted in API tests for single and multi file upload...
commit-queue@webkit.org [Wed, 6 Jun 2012 05:32:27 +0000 (05:32 +0000)]
[Qt][WK2] Use Component.onCompleted in API tests for single and multi file upload tests.
https://bugs.webkit.org/show_bug.cgi?id=88247

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-06-05
Reviewed by Kenneth Rohde Christiansen.

With r116936, Component.onCompleted can be used for callback instead of the
1s timer in single and multi file upload tests.

* UIProcess/API/qt/tests/qmltests/WebView/tst_multiFileUpload.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_singleFileUpload.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImprove Math.round and Math.floor intrinsic
yuqiang.xian@intel.com [Wed, 6 Jun 2012 05:25:54 +0000 (05:25 +0000)]
Improve Math.round and Math.floor intrinsic
https://bugs.webkit.org/show_bug.cgi?id=88314

Reviewed by Filip Pizlo.

Currently we call a native function from the JIT code to complete the
"round" and "floor" operations. We could inline some fast paths
especially for those positive values on the platforms where floating
point truncation is supported.
This brings 3% gain on Kraken, especially 32% on audio-oscillator,
and slight win on SunSpider, measured on IA32.

* jit/ThunkGenerators.cpp:
(JSC::floorThunkGenerator):
(JSC):
(JSC::roundThunkGenerator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] show the feature list in alphabetical order
commit-queue@webkit.org [Wed, 6 Jun 2012 05:19:18 +0000 (05:19 +0000)]
[GTK] show the feature list in alphabetical order
https://bugs.webkit.org/show_bug.cgi?id=88343

Patch by Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk> on 2012-06-05
Reviewed by Gustavo Noronha Silva.

* configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove JSObject::m_inheritorID
barraclough@apple.com [Wed, 6 Jun 2012 05:08:45 +0000 (05:08 +0000)]
Remove JSObject::m_inheritorID
https://bugs.webkit.org/show_bug.cgi?id=88378

Reviewed by Geoff Garen.

This is rarely used, and not performance critical (the commonly accessed copy is cached on JSFunction),
and most objects don't need an inheritorID (this value is only used if the object is used as a prototype).
Instead use a private named value in the object's property storage.

* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):
    - No need m_inheritorID to initialize!
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):
    - No need m_inheritorID to initialize!
* llint/LowLevelInterpreter.asm:
    - No need m_inheritorID to initialize!
* runtime/JSGlobalData.h:
(JSGlobalData):
    - Added private name 'm_inheritorIDKey'.
* runtime/JSGlobalThis.cpp:
(JSC::JSGlobalThis::setUnwrappedObject):
    - resetInheritorID is now passed a JSGlobalData&.
* runtime/JSObject.cpp:
(JSC::JSObject::visitChildren):
    - No m_inheritorID to be marked.
(JSC::JSObject::createInheritorID):
    - Store the newly created inheritorID in the property map.
* runtime/JSObject.h:
(JSC::JSObject::resetInheritorID):
    - Remove the inheritorID from property storage.
(JSC::JSObject::inheritorID):
    - Read the inheritorID from property storage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove erroneous expected image added in r119544.
rniwa@webkit.org [Wed, 6 Jun 2012 04:58:10 +0000 (04:58 +0000)]
Remove erroneous expected image added in r119544.

* platform/chromium-mac/fast/forms/select/optgroup-rendering-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Set default memory allocation limit bytes when GL_CHROMIUM_gpu_memory_mana...
commit-queue@webkit.org [Wed, 6 Jun 2012 04:44:56 +0000 (04:44 +0000)]
[chromium] Set default memory allocation limit bytes when GL_CHROMIUM_gpu_memory_manager is not supported by graphics context.
https://bugs.webkit.org/show_bug.cgi?id=87996

Patch by Michal Mocny <mmocny@google.com> on 2012-06-05
Reviewed by James Robinson.

Soon we hope to have renderers not manage there own memory allocation limits, and rely exclusively on the
allocation given by GpuMemoryManager.  However, when the graphics context does not support the
GL_CHROMIUM_gpu_memory_manager extension, such as the one used by DumpRenderTree, we must default the
memory allocation limit to some non-0 value.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::postSetContentsMemoryAllocationLimitBytesToMainThreadOnImplThread):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore):
(DebugScopedSetMainThreadFromEither):
(WebCore::DebugScopedSetMainThreadFromEither::DebugScopedSetMainThreadFromEither):
(WebCore::DebugScopedSetMainThreadFromEither::~DebugScopedSetMainThreadFromEither):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r119494.
haraken@chromium.org [Wed, 6 Jun 2012 03:44:03 +0000 (03:44 +0000)]
Unreviewed, rolling out r119494.
http://trac.webkit.org/changeset/119494
https://bugs.webkit.org/show_bug.cgi?id=87911

We found similar APIs are already implemented

* public/WebWidget.h:
* src/WebViewImpl.cpp:
* src/WebViewImpl.h:
(WebViewImpl):
* tests/WebViewTest.cpp:
* tests/data/textarea.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Use GraphicsContext3DOpenGLES.cpp when using OpenGL ES
commit-queue@webkit.org [Wed, 6 Jun 2012 03:04:29 +0000 (03:04 +0000)]
[Qt] Use GraphicsContext3DOpenGLES.cpp when using OpenGL ES
https://bugs.webkit.org/show_bug.cgi?id=78720

Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-06-05
Reviewed by Noam Rosenthal.

Source/WebCore:

Functions are removed from GraphicsContext3DQt that already implemented
in GraphicsContext3DCommon. Macros that not supported at GLES have been
changed to their appropriate pair that found in GraphicsContext3D
(e.g. GL_FRAMEBUFFER_EXT to GraphicsContext3D::FRAMEBUFFER).
It was needed because OpenGLES does not support these macros.
Extensions3DQt is removed beceause it has never been used.
Some functions have been moved fron GraphicsContext3DCommon to *OpenGL
and *OpenGLES to provide specialization.
The "m_depthStencilBuffer" member is added to Qt port because it uses
"m_depthStencilBuffer" like the other platforms.

* Target.pri:
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::depthRange):
(WebCore):
(WebCore::GraphicsContext3D::clearDepth):
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::readRenderingResults):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::readPixels):
* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore::GraphicsContext3D::depthRange):
(WebCore):
(WebCore::GraphicsContext3D::clearDepth):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::isGLES2Compliant):
(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebuffer):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore):

Source/WTF:

Defined a global Opengl ES macro to check OpenGL ES on every platforms.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium rebaselines after r115091.
rniwa@webkit.org [Wed, 6 Jun 2012 02:41:45 +0000 (02:41 +0000)]
Chromium rebaselines after r115091.

* platform/chromium-mac-leopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Added.
* platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Added.
* platform/chromium-win/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore Chromium rebaselines after r119528 and r119512.
rniwa@webkit.org [Wed, 6 Jun 2012 02:13:34 +0000 (02:13 +0000)]
More Chromium rebaselines after r119528 and r119512.

* platform/chromium-linux/editing/selection/3690703-2-expected.png:
* platform/chromium-linux/editing/selection/3690703-expected.png:
* platform/chromium-linux/editing/selection/3690719-expected.png:
* platform/chromium-linux/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry]Differentiate options and group options by TypeOption and TypeOptionInGroup
commit-queue@webkit.org [Wed, 6 Jun 2012 01:57:53 +0000 (01:57 +0000)]
[BlackBerry]Differentiate options and group options by TypeOption and TypeOptionInGroup
https://bugs.webkit.org/show_bug.cgi?id=88342

Patch by Crystal Zhang <haizhang@rim.com> on 2012-06-05
Reviewed by Rob Buis.

RIM PR: 163141

Reviewed internally by Mike Fenton.

We set all options' type to TypeOption, which can't tell if an option belongs to a group,
introduce TypeOptionInGroup to fix it.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openSelectPopup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSpecial layout handler should be done on top frame being printed.
darin@apple.com [Wed, 6 Jun 2012 01:51:08 +0000 (01:51 +0000)]
Special layout handler should be done on top frame being printed.
https://bugs.webkit.org/show_bug.cgi?id=88201

Patch by Vitaly Buka <vitalybuka@chromium.org> on 2012-06-05
Reviewed by Brady Eidson.

No new tests. Root case is already covered by tests.
Case described in the issue can be reproduced only by direct call
to Frame::setPrinting of subframe. Probably it's not possible with
layout tests.

* page/Frame.cpp:
(WebCore::Frame::setPrinting):
Use shouldUsePrintingLayout to choose proper version of forceLayout().
(WebCore::Frame::shouldUsePrintingLayout):
Checks if current frame is the top frame being printed.
* rendering/RenderView.cpp:
(WebCore::RenderView::shouldUsePrintingLayout): Forward to Frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Conditionally enlarge HTML5 video controls in fullscreen mode
commit-queue@webkit.org [Wed, 6 Jun 2012 01:40:38 +0000 (01:40 +0000)]
[BlackBerry] Conditionally enlarge HTML5 video controls in fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=87551

Patch by Max Feil <mfeil@rim.com> on 2012-06-05
Reviewed by Antonio Gomes.

Source/WebCore:

Changes to make media controls larger in fullscreen mode. The
BlackBerry media controls used to be sized by a combination
of CSS styles specified in mediaControlsBlackBerry.css and
hard coded constants in RenderThemeBlackBerry.cpp. This patch
moves all the dimensional sizes to a common location, i.e.
RenderThemeBlackBerry.cpp. Having all the logic in C++ code allows
more complex decision making for when and how much to enlarge the
media controls. Currently the controls are enlarged by a factor
of 2 if the document is in fullscreen mode, the video element
is the current fullscreen element, and the deviceScaleFactor of
the page is less than 2.0. This avoids overly large controls
on pages which are already at least doubling the size of the
controls via viewport meta tag device-width settings. In other
words, if the CSS pixels are already enlarged compared to device
pixels by a factor of at least 2 in length and width.

In order to accomplish this, I had to add a new Element* parameter
to RenderTheme::adjustSliderThumbSize(). This is needed so
that fullscreen mode can be checked and the deviceScaleFactor
retrieved. I feel that this does not have a big impact on the
code and the other ports, for which I will simply be adding the
additional parameter in their platform code.

Tests:
video-controls-enlarged-fullscreen-meta.html
video-controls-enlarged-fullscreen-nometa.html

* css/mediaControlsBlackBerry.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
* html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderThumb::updateAppearance):
* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore):
(WebCore::determineRenderSlider):
(WebCore::determineFullScreenMultiplier):
(WebCore::RenderThemeBlackBerry::adjustSliderThumbSize):
(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
(WebCore::RenderThemeBlackBerry::adjustSliderTrackStyle):
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaSliderThumb):
* platform/blackberry/RenderThemeBlackBerry.h:
(RenderThemeBlackBerry):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::adjustSliderThumbSize):
* platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):
* platform/gtk/RenderThemeGtk.h:
* platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::adjustSliderThumbSize):
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::adjustSliderThumbSize):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::adjustSliderThumbSize):
* platform/qt/RenderThemeQt.h:
(RenderThemeQt):
* platform/qt/RenderThemeQtMobile.cpp:
(WebCore::RenderThemeQtMobile::adjustSliderThumbSize):
* platform/qt/RenderThemeQtMobile.h:
(RenderThemeQtMobile):
* rendering/RenderThemeChromiumLinux.cpp:
(WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
* rendering/RenderThemeChromiumLinux.h:
(RenderThemeChromiumLinux):
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize):
* rendering/RenderThemeChromiumSkia.h:
(RenderThemeChromiumSkia):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore):
(WebCore::RenderThemeChromiumWin::adjustSliderThumbSize):
* rendering/RenderThemeChromiumWin.h:
(RenderThemeChromiumWin):
* rendering/RenderThemeMac.h:
(RenderThemeMac):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::adjustSliderThumbSize):
* rendering/RenderThemeSafari.h:
(RenderThemeSafari):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::adjustSliderThumbSize):
* rendering/RenderThemeWin.h:
(RenderThemeWin):
* rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::adjustSliderThumbSize):
* rendering/RenderThemeWinCE.h:
(RenderThemeWinCE):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::adjustMediaControlStyle):
(WebCore):
(WebCore::RenderTheme::adjustSliderThumbStyle):
(WebCore::RenderTheme::adjustSliderThumbSize):
* rendering/RenderTheme.h:
(RenderTheme):

Source/WebKit/qt:

Add a new parameter to adjustSliderThumbSize() for BlackBerry
port. Fixing compiles of other ports.

* WebCoreSupport/RenderThemeQStyle.cpp:
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):
* WebCoreSupport/RenderThemeQStyle.h:
(RenderThemeQStyle):

LayoutTests:

* media/media-controls.js:
(mediaControlsButtonDimensions):
* platform/blackberry/media/video-controls-enlarged-fullscreen-meta-expected.txt: Added.
* platform/blackberry/media/video-controls-enlarged-fullscreen-meta.html: Added.
* platform/blackberry/media/video-controls-enlarged-fullscreen-nometa-expected.txt: Added.
* platform/blackberry/media/video-controls-enlarged-fullscreen-nometa.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=88370
slewis@apple.com [Wed, 6 Jun 2012 01:37:09 +0000 (01:37 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=88370
Memory sampler should trigger low memory signal

Reviewed by Geoff Garen.

Source/WebCore:

No new tests. Verify by running stress test which crashes
in a few minutes without the fix.

Fix assumption in block code.  We could get in a state where timer_event_source
had already been released before the block ran.

* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::holdOff):

Source/WebKit2:

Send low memory signal when running the memory sampler.  We'd
like to test memory that cannot be freed.

* Shared/WebMemorySampler.cpp:
(WebKit::WebMemorySampler::sampleTimerFired):
* Shared/WebMemorySampler.h:
(WebMemorySampler):
* Shared/mac/WebMemorySampler.mac.mm:
(WebKit):
(WebKit::WebMemorySampler::sendMemoryPressureEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStop generating image results in the tests added by r114172.
rniwa@webkit.org [Wed, 6 Jun 2012 01:10:49 +0000 (01:10 +0000)]
Stop generating image results in the tests added by r114172.

Rubber-stamped by Simon Fraser.

* css3/filters/huge-region-composited.html:
* css3/filters/huge-region.html:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium rebaselines after r118772.
rniwa@webkit.org [Wed, 6 Jun 2012 01:01:32 +0000 (01:01 +0000)]
Chromium rebaselines after r118772.

* platform/chromium-mac-leopard/fast/forms/select/optgroup-rendering-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/select/optgroup-rendering-expected.png: Added.
* platform/chromium-mac/fast/forms/select/optgroup-rendering-expected.png: Added.
* platform/chromium-mac/fast/forms/select/optgroup-rendering-expected.txt: Added.
* platform/chromium-win/fast/forms/select/optgroup-rendering-expected.png: Added.
* platform/chromium-win/fast/forms/select/optgroup-rendering-expected.txt: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
andersca@apple.com [Wed, 6 Jun 2012 00:57:10 +0000 (00:57 +0000)]
Build fix.

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin):
The error constant has been renamed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename a plug-in loading error constant
andersca@apple.com [Wed, 6 Jun 2012 00:48:14 +0000 (00:48 +0000)]
Rename a plug-in loading error constant
https://bugs.webkit.org/show_bug.cgi?id=88381
<rdar://problem/11602601>

Reviewed by Sam Weinig.

* Misc/WebKitErrors.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fixing an incorrect path in lion Skipped file.
leviw@chromium.org [Wed, 6 Jun 2012 00:47:22 +0000 (00:47 +0000)]
Unreviewed. Fixing an incorrect path in lion Skipped file.

* platform/mac-lion/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Forms] Introduce InputNumber type as an alias of double for replacing it to Decimal
yosin@chromium.org [Wed, 6 Jun 2012 00:39:52 +0000 (00:39 +0000)]
[Forms] Introduce InputNumber type as an alias of double for replacing it to Decimal
https://bugs.webkit.org/show_bug.cgi?id=88275

Reviewed by Kent Tamura.

This patch introduced InputNumber type as alias of double to be
replaced to Decimal and convertDoubleToInputNumber and
convertToInputNumberToDouble for reducing size of patch when we
introduce Decimal type.

This patch added new vairables to use const variable to reduce
copy operation when introducing Decimal type.

In the implementation, we use InputNumber, will be Decimal, however some methods in IDL
use double. To clarify internal usage of value and external usage, thit patch renamed
following functions:

- parseToDouble => parseNumber
- setValueAsNumber => setValueAsDouble and setValueAsInputNumber
- valueAsNumber => valueAsDouble

This patch is a part of introducing Decimal, https://bugs.webkit.org/show_bug.cgi?id=80009

No new tests. This patch doesn't change behavior.

* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::valueAsDate): Replaced parseToNumber() to valueAsDouble()
(WebCore::BaseDateAndTimeInputType::setValueAsDate): Inserted convertDoubleToInputNumber.
(WebCore::BaseDateAndTimeInputType::valueAsDouble): Use new function parseToDouble().
(WebCore::BaseDateAndTimeInputType::setValueAsInputNumber): Added.
(WebCore::BaseDateAndTimeInputType::defaultValueForStepUp): Changed return type to InputNumber.
(WebCore::BaseDateAndTimeInputType::parseToNumber): This is replacement of parseToDouble().
(WebCore::BaseDateAndTimeInputType::parseToDouble): Added for valueAsDate and valueAsDouble.
(WebCore::BaseDateAndTimeInputType::serialize): Changed parameter type to InputNumber.
(WebCore::BaseDateAndTimeInputType::serializeWithComponents): Replace double to InputNumber for getAllowdStep.
* html/BaseDateAndTimeInputType.h:
(BaseDateAndTimeInputType):
* html/DateInputType.cpp:
(WebCore::DateInputType::createStepRange): Replaced double to InputNumber.
* html/DateInputType.h:
(DateInputType):
* html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::defaultValueForStepUp): Changed return type to InputNumber.
(WebCore::DateTimeInputType::createStepRange): Replaced double to InputNumber.
* html/DateTimeInputType.h:
(DateTimeInputType):
* html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::createStepRange): Replaced double to InputNumber.
* html/DateTimeLocalInputType.h:
(DateTimeLocalInputType):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::getAllowedValueStep): Changed parameter type to InputNumber.
(WebCore::HTMLInputElement::valueAsNumber): Use InputType::valueAsDouble.
(WebCore::HTMLInputElement::setValueAsNumber): Use InputType::valueAsDouble.
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/InputType.cpp:
(WebCore::InputType::valueAsDouble): Replacement of valueAsNumber.
(WebCore::InputType::setValueAsDouble): Replacement of valueAsNumber.
(WebCore::InputType::setValueAsInputNumber): Replacement of valueAsNumber.
(WebCore::InputType::rangeUnderflow): Replaced double to InputNumber.
(WebCore::InputType::rangeOverflow): Replaced double to InputNumber.
(WebCore::InputType::defaultValueForStepUp): Changed return type to InputNumber.
(WebCore::InputType::isInRange): Replaced double to InputNumber.
(WebCore::InputType::isOutOfRange): Replaced double to InputNumber.
(WebCore::InputType::stepMismatch): Replaced double to InputNumber.
(WebCore::InputType::validationMessage): Replaced double to InputNumber.
(WebCore::InputType::parseToNumber): Replacement of parseToDouble.
(WebCore::InputType::parseToNumberOrNaN): Added for reducing number of std::numeric_limits<double>::quiet_NaN().
(WebCore::InputType::parseToNumberWithDecimalPlaces): Replaced double to InputNumber.
(WebCore::InputType::serialize): Changed parameter type to InputNumber.
(WebCore::InputType::applyStep): Replaced double to InputNumber.
(WebCore::InputType::getAllowedValueStep): Changed parameter type to InputNumber.
(WebCore::InputType::stepUpFromRenderer): Replaced double to InputNumber.
* html/InputType.h:
(InputType):
* html/MonthInputType.cpp:
(WebCore::MonthInputType::defaultValueForStepUp): Changed return type to InputNumber.
(WebCore::MonthInputType::createStepRange): Replaced double to InputNumber.
(WebCore::MonthInputType::parseToNumber): Replacement of parseToDouble.
* html/MonthInputType.h:
(MonthInputType):
* html/NumberInputType.cpp:
(WebCore::NumberInputType::valueAsDouble): Replacement of valueAsNumber. Changed to use parseToDoubleForNumberType.
(WebCore::NumberInputType::setValueAsDouble):  Replacement of setValueAsNumber.  Changed to use serializeForNumberType.
(WebCore::NumberInputType::setValueAsInputNumber): Replacement of setValueAsNumber.
(WebCore::NumberInputType::createStepRange): Replaced double to InputNumber.
(WebCore::NumberInputType::parseToNumber): Replacement of parseToDouble.
(WebCore::NumberInputType::parseToNumberWithDecimalPlaces): Replaced double to InputNumber.
(WebCore::NumberInputType::serialize):
* html/NumberInputType.h:
(NumberInputType):
* html/RangeInputType.cpp:
(WebCore::ensureMaximum): Replaced double to InputNumber.
(WebCore::RangeInputType::valueAsDouble): Replacement of valueAsNumber.
(WebCore::RangeInputType::setValueAsInputNumber):  Replacement of setValueAsNumber.
(WebCore::RangeInputType::createStepRange): Replaced double to InputNumber.
(WebCore::RangeInputType::handleKeydownEvent): Replaced double to InputNumber.
(WebCore::RangeInputType::parseToNumber): Replacement of parseToDouble.
(WebCore::RangeInputType::serialize): Changed parameter type to InputNumber.
(WebCore::RangeInputType::sanitizeValue): Replaced double to InputNumber.
* html/RangeInputType.h:
(RangeInputType):
* html/StepRange.cpp:
(WebCore::StepRange::StepRange): Replaced double to InputNumber.
(WebCore::StepRange::acceptableError): Replaced double to InputNumber.
(WebCore::StepRange::alignValueForStep): Replaced double to InputNumber.
(WebCore):
(WebCore::StepRange::clampValue): Replaced double to InputNumber.
(WebCore::StepRange::stepMismatch): Replaced double to InputNumber.
* html/StepRange.h:
(WebCore::convertDoubleToInputNumber): Added.
(WebCore::convertInputNumberToDouble): Added.
(WebCore::StepRange::NumberWithDecimalPlaces::NumberWithDecimalPlaces): Replaced double to InputNumber.
(WebCore::StepRange::StepDescription::defaultValue): Replaced double to InputNumber.
(StepRange):
(WebCore::StepRange::maximum): Replaced double to InputNumber.
(WebCore::StepRange::minimum): Replaced double to InputNumber.
(WebCore::StepRange::step): Replaced double to InputNumber.
(WebCore::StepRange::stepBase): Replaced double to InputNumber.
(WebCore::StepRange::defaultValue): Replaced double to InputNumber.
(WebCore::StepRange::proportionFromValue): Replaced double to InputNumber.
(WebCore::StepRange::valueFromProportion): Replaced double to InputNumber.
* html/TimeInputType.cpp:
(WebCore::TimeInputType::defaultValueForStepUp): Replaced double to InputNumber.
(WebCore::TimeInputType::createStepRange): Replaced double to InputNumber.
* html/TimeInputType.h:
(TimeInputType):
* html/WeekInputType.cpp:
(WebCore::WeekInputType::createStepRange): Replaced double to InputNumber.
* html/WeekInputType.h:
(WeekInputType):
* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::writeDocument): Replaced double to InputNumber.
* html/shadow/SliderThumbElement.cpp:
(WebCore::sliderPosition): Replaced double to InputNumber.
(WebCore::RenderSliderThumb::layout): Replaced double to InputNumber.
(WebCore::SliderThumbElement::setPositionFromPoint): Replaced double to InputNumber.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening. Chromium windows test expectation updates.
eae@chromium.org [Wed, 6 Jun 2012 00:38:21 +0000 (00:38 +0000)]
Unreviewed gardening. Chromium windows test expectation updates.

* platform/chromium-win/fast/sub-pixel: Added.
* platform/chromium-win/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRoll Chromium DEPS from r140528 to r140653.
rniwa@webkit.org [Wed, 6 Jun 2012 00:32:24 +0000 (00:32 +0000)]
Roll Chromium DEPS from r140528 to r140653.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening. More updated Chromium test expectations following 119528.
leviw@chromium.org [Wed, 6 Jun 2012 00:31:22 +0000 (00:31 +0000)]
Unreviewed gardening. More updated Chromium test expectations following 119528.

* platform/chromium-linux-x86/editing/selection: Added.
* platform/chromium-linux-x86/editing/selection/3690703-2-expected.png: Added.
* platform/chromium-linux-x86/editing/selection/3690703-expected.png: Added.
* platform/chromium-linux-x86/editing/selection/3690719-expected.png: Added.
* platform/chromium-linux-x86/fast/sub-pixel: Added.
* platform/chromium-linux-x86/fast/sub-pixel/selection: Added.
* platform/chromium-linux-x86/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
* platform/chromium-linux/fast/sub-pixel: Added.
* platform/chromium-linux/fast/sub-pixel/selection: Added.
* platform/chromium-linux/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
* platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
* platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
* platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
* platform/chromium-mac-leopard/editing/selection/selection-button-text-expected.png:
* platform/chromium-mac-leopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
* platform/chromium-mac-leopard/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
* platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
* platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
* platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
* platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
* platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
* platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
* platform/chromium-mac-leopard/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
* platform/chromium-mac-leopard/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
* platform/chromium-mac-leopard/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
* platform/chromium-mac-leopard/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
* platform/chromium-mac/editing/selection/3690703-2-expected.png:
* platform/chromium-mac/editing/selection/3690703-expected.png:
* platform/chromium-mac/editing/selection/3690719-expected.png:
* platform/chromium-mac/editing/selection/selection-button-text-expected.png:
* platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
* platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
* platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
* platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
* platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
* platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
* platform/chromium-mac/fast/sub-pixel/selection: Added.
* platform/chromium-mac/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
* platform/chromium-win-vista/fast/sub-pixel: Added.
* platform/chromium-win-vista/fast/sub-pixel/selection: Added.
* platform/chromium-win-vista/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
* platform/chromium-win/editing/selection/3690703-2-expected.png:
* platform/chromium-win/editing/selection/3690703-expected.png:
* platform/chromium-win/editing/selection/3690719-expected.png:
* platform/chromium-win/fast/sub-pixel: Added.
* platform/chromium-win/fast/sub-pixel/selection: Added.
* platform/chromium-win/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium rebaselines for r119523 and r119529.
rniwa@webkit.org [Wed, 6 Jun 2012 00:25:11 +0000 (00:25 +0000)]
Chromium rebaselines for r119523 and r119529.

* platform/chromium-linux/compositing/layer-creation: Removed.
* platform/chromium-mac-snowleopard/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
* platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png:
* platform/chromium-mac/compositing/iframes/scroll-fixed-transformed-element-expected.png: Added.
* platform/chromium-mac/fullscreen/full-screen-stacking-context-expected.png:
* platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt:
* platform/chromium-win/compositing/iframes/scroll-fixed-transformed-element-expected.png: Added.
* platform/chromium-win/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/11575898> and https://bugs.webkit.org/show_bug.cgi?id=88372
beidson@apple.com [Wed, 6 Jun 2012 00:15:42 +0000 (00:15 +0000)]
<rdar://problem/11575898> and https://bugs.webkit.org/show_bug.cgi?id=88372
REGRESSION(110494): Can no longer drag-and-drop links into FileMaker Pro 12

- Before r110494 we used to write the NSStringPboardType to the pasteboard.
  After r110494 we write NSURLPboardType instead.
  That's basically a no-op, but the NSStringPboardType needs to be restored.
- Before r110494 we wrote the link destination URL to the pasteboard.
  After r110494 we write the image src URL if the link is an image.
  We need to revert to writing the link URL.

Fortunately these changes can be accomplished with a 2-line fix.

Reviewed by Enrica Casucci.

* UIProcess/API/mac/WKView.mm:
(-[WKView _setPromisedData:WebCore::withFileName:withExtension:withTitle:withURL:withVisibleURL:withArchive:WebCore::forPasteboard:]):
n

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix after r119527.
rniwa@webkit.org [Wed, 6 Jun 2012 00:05:46 +0000 (00:05 +0000)]
Build fix after r119527.

* dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Cairo] [OpenGL] Enable GL_OES_standard_derivatives
commit-queue@webkit.org [Tue, 5 Jun 2012 23:12:19 +0000 (23:12 +0000)]
[Cairo] [OpenGL] Enable GL_OES_standard_derivatives
https://bugs.webkit.org/show_bug.cgi?id=87583

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-06-05
Reviewed by Alejandro G. Castro.

No new tests. This is covered by oes-standard-derivatives.html
in the Khronos WebGL conformance tests, which may one day be part
of the WebKit test suite.

Activate the GL_OES_standard_derivatives on Cairo along with
Qt and Mac.

* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::ensureEnabled):
(WebCore::Extensions3DOpenGL::isEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuildbot fix.
jonlee@apple.com [Tue, 5 Jun 2012 22:45:01 +0000 (22:45 +0000)]
Buildbot fix.

* BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier
in the function. Store in a local variable.
(loadBuilderConfig):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixing two leopard-specific baselines following r119528.
leviw@chromium.org [Tue, 5 Jun 2012 22:28:02 +0000 (22:28 +0000)]
Fixing two leopard-specific baselines following r119528.

* platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png:
* platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Chromium test expectations.
rniwa@webkit.org [Tue, 5 Jun 2012 22:19:47 +0000 (22:19 +0000)]
Fix Chromium test expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAvoid creating compositing layers for preserve-3d without transformed descendants
simon.fraser@apple.com [Tue, 5 Jun 2012 22:18:31 +0000 (22:18 +0000)]
Avoid creating compositing layers for preserve-3d without transformed descendants
https://bugs.webkit.org/show_bug.cgi?id=88115

Source/WebCore:

Reviewed by Antti Koivisto.

Avoid creating compositing layers, and therefore using excess backing store,
for elements that have -webkit-transform-style: preserve-3d, but no 3D-transformed
descendants that would be affected by that preserve-3d.

Test: compositing/layer-creation/no-compositing-for-preserve-3d.html

* rendering/RenderLayer.h: Replace the "mustOverlap" flag with a enum
that describes the different reasons for indirect compositing, so that
we can use that information to decide whether to allocate backing store.
(WebCore::RenderLayer::setIndirectCompositingReason):
(WebCore::RenderLayer::indirectCompositingReason):
(WebCore::RenderLayer::mustCompositeForIndirectReasons):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer): Initialize m_indirectCompositingReason

* rendering/RenderLayerCompositor.h: New out param for computeCompositingRequirements()
that is uses to indicate that a 3d-transformed descendant has been encountered.
Rename requiresCompositingWhenDescendantsAreCompositing() to requiresCompositingForIndirectReason(),
and return the reason as an out param.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayers): Pass in the saw3DTransform
param to computeCompositingRequirements().
(WebCore::RenderLayerCompositor::computeCompositingRequirements): Return a flag
from computeCompositingRequirements() that is set to true if we've seen descendants
that have 3d transforms. This is later used to decide whether to composite for
perspective or preserve-3d.
Change the "mustOverlapCompositedLayers" code to use the new "indirect compositing"
enum flags.
After enumerating children, call requiresCompositingForIndirectReason() and
record the reason in the layer.
(WebCore::RenderLayerCompositor::needsToBeComposited): Use mustCompositeForIndirectReasons() now.
(WebCore::RenderLayerCompositor::requiresOwnBackingStore): Consult the indirect compositing
reason rather than just looking for the overlap flag.
(WebCore::RenderLayerCompositor::reasonForCompositing): Now that we have more information
about indirect compositing reasons, the logging can be more detailed.
(WebCore::RenderLayerCompositor::requiresCompositingForTransform): This now only looks
for 3d transforms. We now treat perspective and perserve-3d as "indirect" reasons, because
whether they composite depends on descendants having non-affine transforms.
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason): Includes the logic
previously in requiresCompositingWhenDescendantsAreCompositing(), and now determines
whether to composite for preserve-3d and perspective, based on whether we have transformed descendants.

LayoutTests:

Reviewed by Antti Koivisto.

* compositing/backing/no-backing-for-perspective-expected.txt:
* compositing/backing/no-backing-for-perspective.html: Change the transform to be non-affine so that
we keep making layers for perspective.
* compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.
* compositing/layer-creation/no-compositing-for-preserve-3d.html: Copied from LayoutTests/compositing/backing/no-backing-for-perspective.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBlock selection gaps painted not properly pixel snapped
leviw@chromium.org [Tue, 5 Jun 2012 21:56:24 +0000 (21:56 +0000)]
Block selection gaps painted not properly pixel snapped
https://bugs.webkit.org/show_bug.cgi?id=88000

Reviewed by Ryosuke Niwa.

Source/WebCore:

Fixes for selection painting in both inline line heights and block gaps. We were unintentionally
flooring inline and block offsets in RenderBlock, but actually need to intentionally floor the
logical left and right values in logical(Left|Right)SelectionGap to properly align our block
selection gaps. This is to properly mirror the behavior in pixelSnappedLogicalRightOffsetForLine.

We were also unintentionally upcasting LayoutUnits to floats in InlineTextBox's selection painting
routine. Now we're properly rounding.

Test: fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintSelection): Move paint values to integers and do proper rounding.
* rendering/RenderBlock.cpp:
(WebCore::blockDirectionOffset): Fix incorrect flooring in return value.
(WebCore::inlineDirectionOffset): Ditto.
(WebCore): Removing previous attempt to properly mirror inline box selection pixel alignment. This
implementation rounded the final x value instead of properly rounding our block offset then flooring
the offset that corresponds to the behavior in InlineTextBox. It also didn't properly pixel snap
the y offset and height.
(WebCore::RenderBlock::blockSelectionGap): Properly pixel snapping the gap rect before painting.
(WebCore::RenderBlock::logicalLeftSelectionGap): Correctly match InlineTextBox's selection pixel
alignment by flooring the logicalLeft and pixel snapping the subsequent rect. We do this in order
to maintain proper render tree pixel snapping while simultaneously mirroring the flooring in the
inline direction that occurs in InlineTextBox.cpp's alignSelectionRectToDevicePixels method.
(WebCore::RenderBlock::logicalRightSelectionGap): Ditto with the right.

LayoutTests:

One new selection test and updated snowleopard expectations for a handful that improved.

Note: a couple of the RTL results appear worse, but sadly are only returning to our old pre-sub-pixel results.

* fast/sub-pixel/selection: Added.
* fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.txt: Added.
* fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html: Added.
* platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/selection-button-text-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
* platform/chromium-mac-snowleopard/fast/sub-pixel: Added.
* platform/chromium-mac-snowleopard/fast/sub-pixel/selection: Added.
* platform/chromium-mac-snowleopard/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
* platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.png:
* platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/chromium/TestExpectations:
* platform/efl/Skipped:
* platform/gtk-wk2/Skipped:
* platform/mac-lion/Skipped:
* platform/mac-snowleopard/Skipped:
* platform/mac-wk2/Skipped:
* platform/mac/Skipped:
* platform/qt-4.8/Skipped:
* platform/qt/Skipped:
* platform/win-wk2/Skipped:
* platform/win-xp/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove support for target-densitydpi in the viewport meta tag
abarth@webkit.org [Tue, 5 Jun 2012 21:36:55 +0000 (21:36 +0000)]
Remove support for target-densitydpi in the viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=88047

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

The target-densitydpi parameter was originally implemented on Android,
but it does not appear to be widely used and introduces significant
implementation complexity because it forces us to track three scale
factors (defaultDeviceScaleFactor, deviceScaleFactor, and
pageScaleFactor) rather than just two (deviceScaleFactor and
pageScaleFactor).

There don't appear to be many web sites that use target-densitydpi
because it is not supported on iOS.  There are also concerns from the
standards community about the design of the feature.  It seems our best
course of action is to remove target-densitydpi and address these use
cases via other mechanisms, such as responsive images and device units
in CSS because those approaches are likely to be implemented broadly.

* dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes):
(WebCore):
(WebCore::setViewportFeature):
(WebCore::viewportErrorMessageTemplate):
(WebCore::viewportErrorMessageLevel):
* dom/ViewportArguments.h:
(WebCore::ViewportArguments::ViewportArguments):
(ViewportArguments):
(WebCore::ViewportArguments::operator==):

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
* Api/WebViewportArguments.cpp:
(BlackBerry::WebKit::WebViewportArguments::targetDensityDpi):
(BlackBerry::WebKit::WebViewportArguments::setTargetDensityDpi):
* Api/WebViewportArguments.h:

Source/WebKit/efl:

* ewk/ewk_view.cpp:
(_ewk_view_priv_new):

LayoutTests:

These tests are no longer needed because they're testing a feature we
no longer support.

* fast/viewport/viewport-133-expected.txt: Removed.
* fast/viewport/viewport-133.html: Removed.
* fast/viewport/viewport-92-expected.txt: Removed.
* fast/viewport/viewport-92.html: Removed.
* fast/viewport/viewport-93-expected.txt: Removed.
* fast/viewport/viewport-93.html: Removed.
* fast/viewport/viewport-94-expected.txt: Removed.
* fast/viewport/viewport-94.html: Removed.
* fast/viewport/viewport-95-expected.txt: Removed.
* fast/viewport/viewport-95.html: Removed.
* fast/viewport/viewport-96-expected.txt: Removed.
* fast/viewport/viewport-96.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG CFG simplification should not attempt to deref nodes inside of an unreachable...
fpizlo@apple.com [Tue, 5 Jun 2012 21:32:18 +0000 (21:32 +0000)]
DFG CFG simplification should not attempt to deref nodes inside of an unreachable subgraph
https://bugs.webkit.org/show_bug.cgi?id=88362

Reviewed by Gavin Barraclough.

* dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::fixPhis):
(JSC::DFG::CFGSimplificationPhase::removePotentiallyDeadPhiReference):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Chromium test expectations.
rniwa@webkit.org [Tue, 5 Jun 2012 21:24:21 +0000 (21:24 +0000)]
Fix Chromium test expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium mac rebaseline for float-containing-block-with-margin.
eae@chromium.org [Tue, 5 Jun 2012 21:16:24 +0000 (21:16 +0000)]
Unreviewed chromium mac rebaseline for float-containing-block-with-margin.

* platform/chromium-mac-leopard/fast/sub-pixel: Added.
* platform/chromium-mac-leopard/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
* platform/chromium-mac/fast/sub-pixel/float-containing-block-with-margin-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Chromium test failure expectations per Skia roll:
rniwa@webkit.org [Tue, 5 Jun 2012 20:54:46 +0000 (20:54 +0000)]
Add Chromium test failure expectations per Skia roll:
http://src.chromium.org/viewvc/chrome?view=rev&revision=140580

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuildbot fix.
jonlee@apple.com [Tue, 5 Jun 2012 20:53:51 +0000 (20:53 +0000)]
Buildbot fix.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(loadBuilderConfig):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: clean up win-specific path handling and tests
dpranke@chromium.org [Tue, 5 Jun 2012 20:47:42 +0000 (20:47 +0000)]
webkitpy: clean up win-specific path handling and tests
https://bugs.webkit.org/show_bug.cgi?id=88281

Reviewed by Adam Barth.

There was a bunch of inconsistent logic for handling path
conversions for win32 and cygwin paths due to us sometimes
looking at sys.platform and sometimes using mock hosts. This
patch cleans everything up so that we are required to pass
PlatformInfo objects to the path module and stop trying to do
different things when running on cygwin or win32 hosts (except
in the path_unittest module itself).

This may slightly reduce test coverage for the win32 code paths
but will be a lot easier to follow and maintain.

* Scripts/webkitpy/common/system/path.py:
(abspath_to_uri):
(_convert_path):
* Scripts/webkitpy/common/system/path_unittest.py:
(AbspathTest.platforminfo):
(AbspathTest.test_abspath_to_uri_cygwin):
(AbspathTest.test_abspath_to_uri_unixy):
(AbspathTest.test_abspath_to_uri_win):
(AbspathTest.test_abspath_to_uri_escaping_unixy):
(AbspathTest.test_abspath_to_uri_escaping_cygwin):
(AbspathTest.test_stop_cygpath_subprocess):
* Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo.__init__):
(PlatformInfo.is_cygwin):
* Scripts/webkitpy/common/system/platforminfo_mock.py:
(MockPlatformInfo.is_cygwin):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.to.show_results_html_file):
* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.test_to_uri):
(Driver.uri_to_test):
* Scripts/webkitpy/layout_tests/port/driver_unittest.py:
(DriverTest.test_test_to_uri):
(DriverTest.test_uri_to_test):
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockDRTPortTest.make_port):
(MockDRTTest.input_line):
(MockChromiumDRTTest.test_pixeltest__fails):
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/port/win.py:
(WinPort.show_results_html_file):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_unexpected_failures):
(MainTest.test_results_directory_absolute):
(MainTest.test_results_directory_default):
(MainTest.test_results_directory_relative):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWorkaround buildbot bug when merging build requests.
jonlee@apple.com [Tue, 5 Jun 2012 20:41:41 +0000 (20:41 +0000)]
Workaround buildbot bug when merging build requests.
https://bugs.webkit.org/show_bug.cgi?id=88158

Reviewed by Mark Rowe.

For expediency, we still want testers to pick the latest build to test, but to ensure
that the builders are reporting the correct revision number, we should let the building bots
run as they normally would. That is, the builder picks the oldest revision, and merges
subsequent requests. Because merged requests get appended to the list of changes for a given
build, the last change in that list is also the latest change. When we used pickLatestBuild
for the builders, this was not the case (it would always report the penultimate change).

http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.

* BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override
for all Apple builders.
* BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick
the latest build to run.
(loadBuilderConfig):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEntry into JSC should CRASH() if the Heap is busy
mhahnenberg@apple.com [Tue, 5 Jun 2012 20:38:21 +0000 (20:38 +0000)]
Entry into JSC should CRASH() if the Heap is busy
https://bugs.webkit.org/show_bug.cgi?id=88355

Reviewed by Geoffrey Garen.

Interpreter::execute() returns jsNull() right now if we try to enter it while
the Heap is busy (e.g. with a collection), which is okay, but some code paths
that call Interpreter::execute() allocate objects before checking if the Heap
is busy. Attempting to execute JS code while the Heap is busy should not be
allowed and should be enforced by a release-mode CRASH() to prevent vague,
unhelpful backtraces later on if somebody makes a mistake. Normally, recursively
executing JS code is okay, e.g. for evals, but it should not occur during a
Heap allocation or collection because the Heap is not guaranteed to be in a
consistent state (especially during collections). We are protected from
executing JS on the same Heap concurrently on two separate threads because
they must each take a JSLock first. However, we are not protected from reentrant
execution of JS on the same thread because JSLock allows reentrancy. Therefore,
we should fail early if we detect an entrance into JS code while the Heap is busy.

* heap/Heap.cpp: Changed Heap::collect so that it sets the m_operationInProgress field
at the beginning of collection and then unsets it at the end so that it is set at all
times throughout the duration of a collection rather than sporadically during various
phases. There is no reason to unset during a collection because our collector does
not currently support running additional JS between the phases of a collection.
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
(JSC::Heap::collect):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute): Crash if the Heap is busy.
* runtime/Completion.cpp: Crash if the Heap is busy. We do it here before we call
Interpreter::execute() because we do some allocation prior to calling execute() which
could cause Heap corruption if, for example, that allocation caused a collection.
(JSC::evaluate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Implement log channel initialization for WebKit2
vestbo@webkit.org [Tue, 5 Jun 2012 20:06:26 +0000 (20:06 +0000)]
[Qt] Implement log channel initialization for WebKit2

Reviewed by Alexis Menard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebLayerTreeRenderer behaves wrongly when no contentsScale is set.
alexis.menard@openbossa.org [Tue, 5 Jun 2012 19:59:17 +0000 (19:59 +0000)]
WebLayerTreeRenderer behaves wrongly when no contentsScale is set.
https://bugs.webkit.org/show_bug.cgi?id=88357

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2012-06-05
Reviewed by Alexis Menard.

The contentsScale needs to get a default value in case no
value is explicitely set yet.
This fixes the blank-until-resize problem when running MiniBrowser
in --desktop mode.

* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAssertion failure on mac-lion-wk2 in fast/hidpi/device-scale-factor-paint.html
timothy_horton@apple.com [Tue, 5 Jun 2012 19:52:48 +0000 (19:52 +0000)]
Assertion failure on mac-lion-wk2 in fast/hidpi/device-scale-factor-paint.html
https://bugs.webkit.org/show_bug.cgi?id=88356

Unreviewed, remove incorrect baselines and skip test on Mac.

* platform/mac/Skipped:
* platform/mac/fast/hidpi/device-scale-factor-paint-expected.png: Removed.
* platform/mac/fast/hidpi/device-scale-factor-paint-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] Improve variable resolution order on window
arv@chromium.org [Tue, 5 Jun 2012 19:22:46 +0000 (19:22 +0000)]
[V8] Improve variable resolution order on window
https://bugs.webkit.org/show_bug.cgi?id=84247

Reviewed by Ojan Vafai.

This changes the V8 flag to turn on es52_globals and updates the layout tests to reflect the fixed behavior.

Source/WebCore:

Test: fast/dom/Window/window-property-shadowing-onclick.html

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initContextIfNeeded): Set the flag as we initialize V8.
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initIsolate): Ditto.

LayoutTests:

* fast/dom/Window/window-property-shadowing-name-expected.txt: The expectation is now reversed.
* fast/dom/Window/window-property-shadowing-name.html: JSC fails so this test says fail. Bug 75575 tracks JSC.
* fast/dom/Window/window-property-shadowing-onclick-expected.txt: Added.
* fast/dom/Window/window-property-shadowing-onclick.html: Added.
* platform/chromium/fast/dom/Window/window-property-shadowing-name-expected.txt: Copied from LayoutTests/fast/dom/Window/window-property-shadowing-name-expected.txt.
* platform/chromium/fast/dom/Window/window-property-shadowing-onclick-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDelete dead code from RenderBox::computeLogicalWidthInRegion
ojan@chromium.org [Tue, 5 Jun 2012 19:16:55 +0000 (19:16 +0000)]
Delete dead code from RenderBox::computeLogicalWidthInRegion
https://bugs.webkit.org/show_bug.cgi?id=88353

Reviewed by Tony Chang.

No new tests obviously since this is dead code.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInRegion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChange fast/sub-pixel/float-containing-block-with-margin.html to pixel test
eae@chromium.org [Tue, 5 Jun 2012 19:16:11 +0000 (19:16 +0000)]
Change fast/sub-pixel/float-containing-block-with-margin.html to pixel test
https://bugs.webkit.org/show_bug.cgi?id=88351

Reviewed by Levi Weintraub.

Change fast/sub-pixel/float-containing-block-with-margin.html to pixel
test to allow for platform differences as the default styling makes it
very hard to use a reftests for this.

* fast/sub-pixel/float-containing-block-with-margin-expected.html: Removed.
* fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
* fast/sub-pixel/float-containing-block-with-margin-expected.txt: Added.
* fast/sub-pixel/float-containing-block-with-margin.html:
* platform/chromium-mac/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119512 268f45cc-cd09-0410-ab3c-d52691b4dbfc