WebKit-https.git
9 years agoClear up scale factor terminology
aroben@apple.com [Mon, 15 Aug 2011 13:43:29 +0000 (13:43 +0000)]
Clear up scale factor terminology

WebKit by and large deals with two scale factors: one intrinsic to the device on which the
software is running, and one that is per-Page and can be controlled via API calls. This
patch names the former "deviceScaleFactor" and the latter "pageScaleFactor", and makes the
code use those names. It should introduce no behavior changes.

Fixes <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to the
device scale factor

Reviewed by Simon Fraser.

Source/WebCore:

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
Removed an unused member. This is unrelated to this patch.

* css/MediaQueryEvaluator.cpp:
* html/HTMLCanvasElement.cpp:
* html/HTMLCanvasElement.h:
* loader/EmptyClients.h:
* page/Chrome.cpp:
* page/Chrome.h:
* page/ChromeClient.h:
* page/DOMWindow.cpp:
* page/Frame.cpp:
* page/Frame.h:
* platform/graphics/GraphicsLayer.cpp:
* platform/graphics/GraphicsLayer.h:
* platform/graphics/GraphicsLayerClient.h:
* platform/graphics/ca/GraphicsLayerCA.cpp:
* rendering/RenderInline.cpp:
* rendering/RenderLayerBacking.cpp:
* rendering/RenderLayerBacking.h:
* rendering/RenderLayerCompositor.cpp:
* rendering/RenderLayerCompositor.h:
* rendering/RenderObject.cpp:

Source/WebKit/chromium:

* src/ChromeClientImpl.cpp:
* src/ChromeClientImpl.h:

Source/WebKit/efl:

* WebCoreSupport/ChromeClientEfl.cpp:
* WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

* WebCoreSupport/ChromeClientGtk.cpp:
* WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/haiku:

* WebCoreSupport/ChromeClientHaiku.cpp:
* WebCoreSupport/ChromeClientHaiku.h:

Source/WebKit/mac:

* Misc/WebNSControlExtras.m:
(-[NSControl sizeToFitAndAdjustWindowHeight]): Updated this function to use more modern
AppKit scale factor terminology. (This is unrelated to the rest of the patch.)

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:

Source/WebKit/qt:

* WebCoreSupport/ChromeClientQt.cpp:
* WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win:

* WebCoreSupport/WebChromeClient.cpp:
* WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

* WebCoreSupport/ChromeClientWinCE.cpp:
* WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

* WebKitSupport/ChromeClientWx.cpp:
* WebKitSupport/ChromeClientWx.h:

Source/WebKit2:

* Shared/UpdateInfo.cpp:
* Shared/UpdateInfo.h:
* Shared/WebPageCreationParameters.cpp:
* Shared/WebPageCreationParameters.h:
* UIProcess/API/C/WKPage.cpp:
* UIProcess/API/efl/PageClientImpl.cpp:
* UIProcess/API/efl/PageClientImpl.h:
* UIProcess/API/gtk/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
* UIProcess/BackingStore.cpp:
* UIProcess/BackingStore.h:
* UIProcess/DrawingAreaProxyImpl.cpp:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/WebPopupMenuProxy.h:
* UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
* UIProcess/gtk/WebPopupMenuProxyGtk.h:
* UIProcess/mac/BackingStoreMac.mm:
* UIProcess/mac/WebPageProxyMac.mm:
* UIProcess/mac/WebPopupMenuProxyMac.h:
* UIProcess/mac/WebPopupMenuProxyMac.mm:
* UIProcess/qt/WebPopupMenuProxyQt.h:
* UIProcess/win/WebPopupMenuProxyWin.h:
* UIProcess/win/WebView.h:
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
* WebProcess/WebPage/FindController.cpp:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
* WebProcess/WebPage/ca/LayerTreeHostCA.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPatch by Oliver Varga <Varga.Oliver@stud.u-szeged.hu> on 2011-08-15
reni@webkit.org [Mon, 15 Aug 2011 11:59:22 +0000 (11:59 +0000)]
Patch by Oliver Varga <Varga.Oliver@stud.u-szeged.hu> on 2011-08-15
Reviewed by Nikolas Zimmermann.

Speed up SVGSMILElement::findInstanceTime.
https://bugs.webkit.org/show_bug.cgi?id=61025

Source/JavaScriptCore:

Add a new parameter to StdlibExtras.h::binarySerarch function
to also handle cases when the array does not contain the key value.
This is needed for an svg function.

* wtf/StdLibExtras.h:
(WTF::binarySearch):

Source/WebCore:

Replace the linear search to binary search on ordered list because
the previous searches from the beginning was not efficient.
Out of index error fixed by Renata Hodovan.

No new tests this is only a performance tweak.

* svg/animation/SVGSMILElement.cpp:
(WebCore::extractTimeFromVector):
(WebCore::SVGSMILElement::findInstanceTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement proper handling of focusin/focusout events in regard to shadow DOM boundaries.
hayato@chromium.org [Mon, 15 Aug 2011 11:02:10 +0000 (11:02 +0000)]
Implement proper handling of focusin/focusout events in regard to shadow DOM boundaries.
https://bugs.webkit.org/show_bug.cgi?id=64249

Reviewed by Dimitri Glazkov.

Introduces FocusInEventDispatchMediator/FocusOutEventDispatchMediator so
that we can shrink ancestors of event target node considering shadow
DOM boundaries before dispatching focusin/focusout events.

Source/WebCore:

Test: fast/dom/shadow/shadow-boundary-events.html

* dom/Document.cpp:
(WebCore::Document::setFocusedNode):
* dom/Node.cpp:
(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
(WebCore::Node::dispatchDOMActivateEvent):
(WebCore::Node::defaultEventHandler):
* dom/Node.h:
* dom/UIEvent.cpp:
(WebCore::FocusInEventDispatchMediator::create):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):
* dom/UIEvent.h:

LayoutTests:

* fast/dom/shadow/shadow-boundary-events-expected.txt:
* fast/dom/shadow/shadow-boundary-events.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: not all of the properties have valid descriptors on all platforms.
pfeldman@chromium.org [Mon, 15 Aug 2011 10:26:49 +0000 (10:26 +0000)]
Web Inspector: not all of the properties have valid descriptors on all platforms.
Includes PropertyDescriptor protocol documentation fixes.
https://bugs.webkit.org/show_bug.cgi?id=66215

Source/WebCore:

Activations, LocalStorage and some other properties potentially don't have
valid property descriptors. InjectedScript should use conservative getter in order to
mitigate this.

Patch by Pavel Feldman <pfeldman@google.com> on 2011-08-15
Reviewed by Yury Semikhatsky.

* inspector/InjectedScriptSource.js:
* inspector/Inspector.json:

LayoutTests:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-08-15
Reviewed by Yury Semikhatsky.

* inspector/protocol/runtime-agent-expected.txt:
* inspector/protocol/runtime-agent.html:
* inspector/runtime/runtime-localStorage-getProperties-expected.txt: Added.
* inspector/runtime/runtime-localStorage-getProperties.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: context menu on the link in the console does not have standard link...
pfeldman@chromium.org [Mon, 15 Aug 2011 09:26:41 +0000 (09:26 +0000)]
Web Inspector: context menu on the link in the console does not have standard link options.
https://bugs.webkit.org/show_bug.cgi?id=66214

Patch by Pavel Feldman <pfeldman@google.com> on 2011-08-15
Reviewed by Yury Semikhatsky.

* English.lproj/localizedStrings.js:
* inspector/front-end/ConsoleView.js:
* inspector/front-end/ElementsPanel.js:
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.populateContextMenu):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._contextMenu):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._contextMenuEventFired):
* inspector/front-end/inspector.js:
(WebInspector.openLinkExternallyLabel):
(WebInspector.copyLinkAddressLabel):
(WebInspector.populateHrefContextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: showContextMenu missing in Remote DevTools
pfeldman@chromium.org [Mon, 15 Aug 2011 08:13:33 +0000 (08:13 +0000)]
Web Inspector: showContextMenu missing in Remote DevTools
https://bugs.webkit.org/show_bug.cgi?id=63725

Reviewed by Yury Semikhatsky.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/ConsoleView.js:
* inspector/front-end/SoftContextMenu.js: Added.
(.WebInspector.SoftContextMenu):
(.WebInspector.SoftContextMenu.prototype.show):
(.WebInspector.SoftContextMenu.prototype._createMenuItem):
(.WebInspector.SoftContextMenu.prototype._createSeparator):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseDown):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseUp):
(.WebInspector.SoftContextMenu.prototype._triggerAction):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseOver):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseOut):
(.WebInspector.SoftContextMenu.prototype._highlightMenuItem):
(.WebInspector.SoftContextMenu.prototype._highlightPrevious):
(.WebInspector.SoftContextMenu.prototype._highlightNext):
(.WebInspector.SoftContextMenu.prototype._menuKeyDown):
(.WebInspector.SoftContextMenu.prototype._glassPaneMouseUp):
(.WebInspector.SoftContextMenu.prototype._discardMenu):
(.InspectorFrontendHost.showContextMenu):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
(.soft-context-menu-glass-pane):
(.soft-context-menu):
(.soft-context-menu-item):
(.soft-context-menu-separator):
(.soft-context-menu-item-mouse-over):
* inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago [QT]REGRESSION after r93011
reni@webkit.org [Mon, 15 Aug 2011 06:57:27 +0000 (06:57 +0000)]
   [QT]REGRESSION after r93011
       https://bugs.webkit.org/show_bug.cgi?id=66212

Unreviewed gardening.

* platform/qt-4.8/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Crash in HTMLTreeBuilder::processAnyOtherEndTagForInBody
inferno@chromium.org [Sun, 14 Aug 2011 23:08:11 +0000 (23:08 +0000)]
Source/WebCore: Crash in HTMLTreeBuilder::processAnyOtherEndTagForInBody
https://bugs.webkit.org/show_bug.cgi?id=66187

Reviewed by Adam Barth.

RefPtr a few ContainerNodes to prevent premature deletion.

Test: fast/html/process-end-tag-for-inbody-crash.html

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

LayoutTests: Crash in HTMLTreeBuilder::processAnyOtherEndTagForInBody.
https://bugs.webkit.org/show_bug.cgi?id=66187

Reviewed by Adam Barth.

* fast/html/process-end-tag-for-inbody-crash-expected.txt: Added.
* fast/html/process-end-tag-for-inbody-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix GTK Windows build after r92308.
commit-queue@webkit.org [Sun, 14 Aug 2011 12:21:57 +0000 (12:21 +0000)]
Fix GTK Windows build after r92308.
https://bugs.webkit.org/show_bug.cgi?id=66140

Patch by Kalev Lember <kalevlember@gmail.com> on 2011-08-14
Reviewed by Xan Lopez.

* config.h: Don't try to include WebCoreHeaderDetection.h for GTK.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSwitch results detail view over to new-style object-oriented UI widgets
abarth@webkit.org [Sun, 14 Aug 2011 07:02:36 +0000 (07:02 +0000)]
Switch results detail view over to new-style object-oriented UI widgets
https://bugs.webkit.org/show_bug.cgi?id=66200

Reviewed by Dimitri Glazkov.

This patch replaces my goofy template-based UI for the results
comparison screen with new object-oriented UI widgets.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSet the svn:mime-type property of some PNG files to image/png
mitz@apple.com [Sun, 14 Aug 2011 06:55:55 +0000 (06:55 +0000)]
Set the svn:mime-type property of some PNG files to image/png

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChanged the value of WebKitShowsToolTipOverTruncatedTextPreferenceKey to match the...
mitz@apple.com [Sat, 13 Aug 2011 20:38:58 +0000 (20:38 +0000)]
Changed the value of WebKitShowsToolTipOverTruncatedTextPreferenceKey to match the naming everywhere else.

Reviewed by Joseph Pecoraro.

../WebKit/mac:

* WebView/WebPreferenceKeysPrivate.h:

../WebKit/win:

* WebPreferenceKeysPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove forward declaration of -[WebUndefined dealloc] to appease the bot gods.
weinig@apple.com [Sat, 13 Aug 2011 19:27:16 +0000 (19:27 +0000)]
Remove forward declaration of -[WebUndefined dealloc] to appease the bot gods.

* bindings/objc/WebScriptObject.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove assertion from -[WebUndefined dealloc] to try to mollify the bots.
weinig@apple.com [Sat, 13 Aug 2011 19:25:51 +0000 (19:25 +0000)]
Remove assertion from -[WebUndefined dealloc] to try to mollify the bots.

* bindings/objc/WebScriptObject.mm:
(-[WebUndefined dealloc]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unused variables from WebView/WebFullScreenController.h
weinig@apple.com [Sat, 13 Aug 2011 19:12:22 +0000 (19:12 +0000)]
Remove unused variables from WebView/WebFullScreenController.h
https://bugs.webkit.org/show_bug.cgi?id=66194

Reviewed by Dan Bernstein.

* WebView/WebFullScreenController.h:
Remove a few variables which were not used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unused variables from WKFullScreenWindowController.h
weinig@apple.com [Sat, 13 Aug 2011 19:03:55 +0000 (19:03 +0000)]
Remove unused variables from WKFullScreenWindowController.h
https://bugs.webkit.org/show_bug.cgi?id=66193

Reviewed by Dan Bernstein.

* UIProcess/mac/WKFullScreenWindowController.h:
Remove _layerViewPlaceholder, _isWindowLoaded and _initialFrame which were not used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unused variables from WebVideoFullscreenController.h
weinig@apple.com [Sat, 13 Aug 2011 18:57:53 +0000 (18:57 +0000)]
Remove unused variables from WebVideoFullscreenController.h
https://bugs.webkit.org/show_bug.cgi?id=66192

Reviewed by Dan Bernstein.

* platform/mac/WebVideoFullscreenController.h:
Remove _isWindowLoaded, _savedUIMode and _savedUIOptions which were not used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix incorrect objective-c initialize in WebCore
weinig@apple.com [Sat, 13 Aug 2011 18:51:05 +0000 (18:51 +0000)]
Fix incorrect objective-c initialize in WebCore
https://bugs.webkit.org/show_bug.cgi?id=66191

Reviewed by David Kilzer.

* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper initWithAccessibilityObject:]):
* rendering/RenderThemeMac.mm:
(-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):
Correctly initialize by assigning to self and nil checking the result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix clang build.
abarth@webkit.org [Sat, 13 Aug 2011 18:31:43 +0000 (18:31 +0000)]
Fix clang build.

* platform/chromium/PopupMenuChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/66188> WebCore.xcodeproj has duplicate entries again
ddkilzer@apple.com [Sat, 13 Aug 2011 18:06:08 +0000 (18:06 +0000)]
<webkit.org/b/66188> WebCore.xcodeproj has duplicate entries again

Reviewed by Dan Bernstein.

* WebCore.xcodeproj/project.pbxproj: Remove duplicate entries
by using uniq.  Originally noticed by Xcode 4.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd back 0xbbadbeef to CRASH to allow for old habits
weinig@apple.com [Sat, 13 Aug 2011 17:54:43 +0000 (17:54 +0000)]
Add back 0xbbadbeef to CRASH to allow for old habits
https://bugs.webkit.org/show_bug.cgi?id=66190

Reviewed by David Kilzer.

* wtf/Assertions.h:
Add back the assignment to the memory address 0xbbadbeef in the CRASH
macro, as it does not cause issue in the clang static analyzer and many
people use its presence in crash reports to easily identify ASSERTs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix a bunch of minor bugs caught by the clang static analyzer in JavaScriptCore
weinig@apple.com [Sat, 13 Aug 2011 17:48:53 +0000 (17:48 +0000)]
Fix a bunch of minor bugs caught by the clang static analyzer in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=66182

Reviewed by Dan Bernstein.

Fixes 10 warnings in JavaScriptCore and 2 in testapi.

* API/tests/testapi.c:
(main):
Remove dead variables.

* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
Initialize hasPrinted and silence an unused warning by casting to void (Ok here
since it is debug code and I want to keep it clear that if other cases are added,
the hasPrinted flag would be needed).

* wtf/dtoa.cpp:
(WTF::d2b):
The variable "de" in the else block is always zero, so there is no reason to
use it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic's analyzeUnexpectedFailures needs a completion callback.
dglazkov@chromium.org [Sat, 13 Aug 2011 15:39:03 +0000 (15:39 +0000)]
garden-o-matic's analyzeUnexpectedFailures needs a completion callback.
https://bugs.webkit.org/show_bug.cgi?id=66166

Also changed base.RequestTracker to:
a) fire callback immediately if requestsInFlight is 0;
b) not barf if callback is not supplied.

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Started using completion callback.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added completion callback.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Changed RequestTracker.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittest.js: Added unit tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
mitz@apple.com [Sat, 13 Aug 2011 07:00:48 +0000 (07:00 +0000)]
Build fix.

* WebView.cpp:
(WebView::notifyPreferencesChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: <rdar://problem/7337717> Add an option to automatically show tooltips...
mitz@apple.com [Sat, 13 Aug 2011 06:25:30 +0000 (06:25 +0000)]
Source/WebCore: <rdar://problem/7337717> Add an option to automatically show tooltips (with the full text) over truncated text
https://bugs.webkit.org/show_bug.cgi?id=66178

Reviewed by Simon Fraser.

* WebCore.exp.in: Export setShowsToolTipOverTruncatedText().
* page/Chrome.cpp:
(WebCore::Chrome::setToolTip): If no title is found, and the page is set to show tooltips over
truncated text, try to set the tooltip to the full text of the truncated text, if any.
* page/Settings.cpp:
(WebCore::Settings::Settings): Initialize new member variable.
(WebCore::Settings::setShowsToolTipOverTruncatedText): Added this setter.
* page/Settings.h:
(WebCore::Settings::showsToolTipOverTruncatedText): Added this getter.
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::innerTextIfTruncated): Added. If the inner node or its nearest enclosing
block has text-overflow: ellipsis and has truncated lines, return the node’s (full) inner text.
* rendering/HitTestResult.h:
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::hasEllipsisBox): Made this public.

Source/WebKit/mac: Add an option to automatically show tooltips (with the full text) over truncated text
https://bugs.webkit.org/show_bug.cgi?id=66178

Reviewed by Simon Fraser.

* WebView/WebPreferenceKeysPrivate.h: Defined a preference key.
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Added a default value of NO for the
ShowsToolTipOverTruncatedText preference.
(-[WebPreferences showsToolTipOverTruncatedText]): Added this getter.
(-[WebPreferences setShowsToolTipOverTruncatedText:]): Added this setter.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Added call to Settings::setShowsToolTipOverTruncatedText().

Source/WebKit/win: Add an option to automatically show tooltips (with the full text) over truncated text
https://bugs.webkit.org/show_bug.cgi?id=66178

Reviewed by Simon Fraser.

* Interfaces/IWebPreferencesPrivate.idl: Added accessors.
* WebPreferenceKeysPrivate.h: Defined a preference key.
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Added a default value of
false for the ShowsToolTipOverTruncatedText preference.
(WebPreferences::showsToolTipOverTruncatedText): Added this getter.
(WebPreferences::setShowsToolTipOverTruncatedText): Added this setter.
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged): Added call to Settings::setShowsToolTipOverTruncatedText().

Source/WebKit2: <rdar://problem/7337717> Add an option to automatically show tooltips (with the full text) over truncated text
https://bugs.webkit.org/show_bug.cgi?id=66178

Reviewed by Simon Fraser.

* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetShowsToolTipOverTruncatedText): Added this setter.
(WKPreferencesGetShowsToolTipOverTruncatedText): Added this getter.
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Handle the showsToolTipOverTruncatedText preference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOwnership of canvas's GraphicsContext3D should be moved to PlatformContextSkia
senorblanco@chromium.org [Sat, 13 Aug 2011 03:26:43 +0000 (03:26 +0000)]
Ownership of canvas's GraphicsContext3D should be moved to PlatformContextSkia
https://bugs.webkit.org/show_bug.cgi?id=66154

Reviewed by Kenneth Russell.

Covered by existing tests in fast/canvas and canvas/philip.

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::isAccelerated):
Plumb this call through GraphicsContext::isAcceleratedContext().
(WebCore::CanvasRenderingContext2D::paintsIntoCanvasBuffer):
For the ACCELERATED_2D_CANVAS path, plumb this call through
(the new) GraphicsContext::paintsIntoCanvasBuffer().
(WebCore::CanvasRenderingContext2D::clearAcceleration):
(WebCore::CanvasRenderingContext2D::resetAcceleration):
Remove the use of the m_context3D member; use a temporary instead.
* html/canvas/CanvasRenderingContext2D.h:
Remove the m_context3D member.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::isAcceleratedContext):
(WebCore::GraphicsContext::paintsIntoImageBuffer):
Implement stub versions of these functions for other platforms.
* platform/graphics/GraphicsContext.h:
Expose isAcceleratedContext() to all platforms.  Add
paintsIntoImageBuffer() member function.
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::create):
* platform/graphics/gpu/SharedGraphicsContext3D.h:
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setGraphicsContext3D):
(WebCore::GraphicsContext::isAcceleratedContext):
(WebCore::GraphicsContext::paintsIntoImageBuffer):
Basically gut this class leaving only a static creation function.
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):
Use isAccelerated() in place of useSkiaGpu().
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
(WebCore::PlatformContextSkia::paintsIntoImageBuffer):
* platform/graphics/skia/PlatformContextSkia.h:
(WebCore::PlatformContextSkia::isAccelerated):
Rename useSkiaGpu() to isAccelerated().  Plumb through
paintsIntoImageBuffer() to GraphicsContext3D.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse __builtin_trap() for CRASH when building with clang
weinig@apple.com [Sat, 13 Aug 2011 02:40:51 +0000 (02:40 +0000)]
Use __builtin_trap() for CRASH when building with clang
https://bugs.webkit.org/show_bug.cgi?id=66152

Reviewed by Anders Carlsson.

../JavaScriptCore:

* wtf/Assertions.h:
Add Clang specific CRASH macro that calls __builtin_trap() instead
of silly techniques to crash. This allows the static analyzer to understand
that we are intentionally crashing. As a result, we need to mark some functions
as not returning.

Also adds a macros that annotates a function as never returning due to ASSERT or CRASH.

* wtf/Compiler.h:
Add COMPILIER(CLANG) and fix some formatting and spelling mistakes.

* wtf/FastMalloc.cpp:
(WTF::Internal::fastMallocMatchFailed):
Add NO_RETURN_DUE_TO_CRASH.

* yarr/YarrParser.h:
(JSC::Yarr::Parser::CharacterClassParserDelegate::assertionWordBoundary):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomBackReference):
Add NO_RETURN_DUE_TO_ASSERT.

../WebCore:

* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneBase::fail):
* bindings/objc/WebScriptObject.mm:
* platform/mac/BlockExceptions.h:
* platform/text/cf/StringImplCF.cpp:
Add NO_RETURN_DUE_TO_ASSERT.

* bridge/IdentifierRep.h:
Don't define the destructor since it is never called,

../WebKit/mac:

* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView setAttributeKeys:andValues:]):
(-[WebBaseNetscapePluginView handleMouseMoved:]):
(-[WebBaseNetscapePluginView handleMouseEntered:]):
(-[WebBaseNetscapePluginView handleMouseExited:]):
(-[WebBaseNetscapePluginView focusChanged]):
(-[WebBaseNetscapePluginView windowFocusChanged:]):
(-[WebBaseNetscapePluginView createPlugin]):
(-[WebBaseNetscapePluginView loadStream]):
(-[WebBaseNetscapePluginView shouldStop]):
(-[WebBaseNetscapePluginView destroyPlugin]):
(-[WebBaseNetscapePluginView updateAndSetWindow]):
(-[WebBaseNetscapePluginView sendModifierEventWithKeyCode:character:]):
(-[WebBaseNetscapePluginView pluginLayer]):
(-[WebBaseNetscapePluginView getFormValue:]):
Remove the ASSERT_NOT_REACHED from the base class methods. They were not
adding much value and were getting in the way of making the static analyzer
work. A better way to do this would be to use a formal protocol.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAbandoned Memory: Temporary CSS Fonts May Never Be Purged
joepeck@webkit.org [Sat, 13 Aug 2011 01:44:01 +0000 (01:44 +0000)]
Abandoned Memory: Temporary CSS Fonts May Never Be Purged
https://bugs.webkit.org/show_bug.cgi?id=66153

Reviewed by Dan Bernstein.

No new tests, this is not a functional change.

* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
If the CSS font-face is loading from a URL then immediately
fallback to a system font matching the description, since we
cannot determine a reasonable family name from the m_string
URL. The URL could be a dataURI.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG JIT has inconsistent use of boxDouble and unboxDouble,
fpizlo@apple.com [Fri, 12 Aug 2011 23:27:45 +0000 (23:27 +0000)]
DFG JIT has inconsistent use of boxDouble and unboxDouble,
inconsistent use of assertions regarding doubles, and those
assertions are not turned on in debug builds
https://bugs.webkit.org/show_bug.cgi?id=66160

Reviewed by Gavin Barraclough.

JIT assertions are now turned on in debug builds.  JIT
assertions are now used for boxing and unboxing doubles, and boxing
and unboxing no longer involves code duplication.

* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::boxDouble):
(JSC::DFG::JITCodeGenerator::unboxDouble):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::GeneralizedRegister::moveTo):
(JSC::DFG::GeneralizedRegister::swapWith):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::boxDouble):
(JSC::DFG::JITCompiler::unboxDouble):
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::convertToDouble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefactoring of PopupMenuChromium For Readability and Maintainability
fsamuel@chromium.org [Fri, 12 Aug 2011 23:18:48 +0000 (23:18 +0000)]
Refactoring of PopupMenuChromium For Readability and Maintainability
https://bugs.webkit.org/show_bug.cgi?id=66009

Reviewed by Darin Fisher.

Source/WebCore:

Split PopupMenuChromium into three sets of files: PopupMenuChromium.{h|cpp}, PopupContainer.{h|cpp},
and PopupLisBox.{h|cpp}  for readability and maintainability.

No new tests as there's no change in functionality.

* WebCore.gypi:
* platform/chromium/PopupContainer.cpp: Added.
(WebCore::constructRelativeMouseEvent):
(WebCore::constructRelativeWheelEvent):
(WebCore::PopupContainer::create):
(WebCore::PopupContainer::PopupContainer):
(WebCore::PopupContainer::~PopupContainer):
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
(WebCore::PopupContainer::showPopup):
(WebCore::PopupContainer::hidePopup):
(WebCore::PopupContainer::notifyPopupHidden):
(WebCore::PopupContainer::layoutAndGetRTLOffset):
(WebCore::PopupContainer::handleMouseDownEvent):
(WebCore::PopupContainer::handleMouseMoveEvent):
(WebCore::PopupContainer::handleMouseReleaseEvent):
(WebCore::PopupContainer::handleWheelEvent):
(WebCore::PopupContainer::handleTouchEvent):
(WebCore::PopupContainer::handleGestureEvent):
(WebCore::PopupContainer::handleKeyEvent):
(WebCore::PopupContainer::hide):
(WebCore::PopupContainer::paint):
(WebCore::PopupContainer::paintBorder):
(WebCore::PopupContainer::isInterestedInEventForKey):
(WebCore::PopupContainer::chromeClientChromium):
(WebCore::PopupContainer::showInRect):
(WebCore::PopupContainer::refresh):
(WebCore::PopupContainer::isRTL):
(WebCore::PopupContainer::selectedIndex):
(WebCore::PopupContainer::menuItemHeight):
(WebCore::PopupContainer::menuItemFontSize):
(WebCore::PopupContainer::menuStyle):
(WebCore::popupData):
(WebCore::PopupContainer::getSelectedItemToolTip):
* platform/chromium/PopupContainer.h: Added.
(WebCore::PopupContainer::listBox):
(WebCore::PopupContainer::popupType):
* platform/chromium/PopupListBox.cpp: Added.
(WebCore::PopupListBox::PopupListBox):
(WebCore::PopupListBox::handleMouseDownEvent):
(WebCore::PopupListBox::handleMouseMoveEvent):
(WebCore::PopupListBox::handleMouseReleaseEvent):
(WebCore::PopupListBox::handleWheelEvent):
(WebCore::PopupListBox::isInterestedInEventForKey):
(WebCore::PopupListBox::handleTouchEvent):
(WebCore::PopupListBox::handleGestureEvent):
(WebCore::isCharacterTypeEvent):
(WebCore::PopupListBox::handleKeyEvent):
(WebCore::PopupListBox::hostWindow):
(WebCore::stripLeadingWhiteSpace):
(WebCore::PopupListBox::typeAheadFind):
(WebCore::PopupListBox::paint):
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowFont):
(WebCore::PopupListBox::abandon):
(WebCore::PopupListBox::pointToRowIndex):
(WebCore::PopupListBox::acceptIndex):
(WebCore::PopupListBox::selectIndex):
(WebCore::PopupListBox::setOriginalIndex):
(WebCore::PopupListBox::getRowHeight):
(WebCore::PopupListBox::getRowBounds):
(WebCore::PopupListBox::invalidateRow):
(WebCore::PopupListBox::scrollToRevealRow):
(WebCore::PopupListBox::isSelectableItem):
(WebCore::PopupListBox::clearSelection):
(WebCore::PopupListBox::selectNextRow):
(WebCore::PopupListBox::selectPreviousRow):
(WebCore::PopupListBox::adjustSelectedIndex):
(WebCore::PopupListBox::hidePopup):
(WebCore::PopupListBox::updateFromElement):
(WebCore::PopupListBox::setMaxWidthAndLayout):
(WebCore::PopupListBox::layout):
(WebCore::PopupListBox::clear):
(WebCore::PopupListBox::isPointInBounds):
* platform/chromium/PopupListBox.h: Added.
(WebCore::PopupItem::PopupItem):
(WebCore::PopupListBox::create):
(WebCore::PopupListBox::selectedIndex):
(WebCore::PopupListBox::numItems):
(WebCore::PopupListBox::setBaseWidth):
(WebCore::PopupListBox::setMaxHeight):
(WebCore::PopupListBox::setMaxWidth):
(WebCore::PopupListBox::disconnectClient):
(WebCore::PopupListBox::items):
(WebCore::PopupListBox::~PopupListBox):
(WebCore::PopupListBox::scrollToRevealSelection):
* platform/chromium/PopupMenuChromium.cpp:
* platform/chromium/PopupMenuChromium.h:

Source/WebKit/chromium:

* src/ChromeClientImpl.cpp:
* src/WebPopupMenuImpl.cpp:
* src/WebViewImpl.cpp:
* tests/PopupMenuTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExpose pageScaleFactor() to Chromium's WebViewImpl
fsamuel@chromium.org [Fri, 12 Aug 2011 22:56:35 +0000 (22:56 +0000)]
Expose pageScaleFactor() to Chromium's WebViewImpl
https://bugs.webkit.org/show_bug.cgi?id=66067

Reviewed by Darin Fisher.

* public/WebView.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::pageScaleFactor):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip the test added by r92997 on Qt port because it uses a method on EventSender...
rniwa@webkit.org [Fri, 12 Aug 2011 22:48:27 +0000 (22:48 +0000)]
Skip the test added by r92997 on Qt port because it uses a method on EventSender that hasn't been
implemented by Qt port's DRT. The failure is tracked by the bug 66173.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBe more forward-looking in the choice of compiler.
mrowe@apple.com [Fri, 12 Aug 2011 22:35:34 +0000 (22:35 +0000)]
Be more forward-looking in the choice of compiler.

Rubber-stamped by Jon Honeycutt.

Source/JavaScriptCore:

* Configurations/CompilerVersion.xcconfig:

Source/JavaScriptGlue:

* Configurations/CompilerVersion.xcconfig:

Source/ThirdParty/ANGLE:

* Configurations/CompilerVersion.xcconfig:

Source/WebCore:

* Configurations/CompilerVersion.xcconfig:

Source/WebKit/mac:

* Configurations/CompilerVersion.xcconfig:

Source/WebKit2:

* Configurations/CompilerVersion.xcconfig:

Tools:

* DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
* MiniBrowser/Configurations/CompilerVersion.xcconfig:
* TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
* WebKitTestRunner/Configurations/CompilerVersion.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Fix non-pthreads build after r91906.
commit-queue@webkit.org [Fri, 12 Aug 2011 22:32:43 +0000 (22:32 +0000)]
[GTK] Fix non-pthreads build after r91906.
https://bugs.webkit.org/show_bug.cgi?id=66151

Patch by Kalev Lember <kalevlember@gmail.com> on 2011-08-12
Reviewed by David Levin.

r91906 broke the non-pthreads GTK+ build by including a header which
doesn't exist. Fix it by including DateMath.h instead of DateMap.h.

* wtf/gtk/ThreadingGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fix comile warning on CCLayerTreeHost
nduca@chromium.org [Fri, 12 Aug 2011 22:00:23 +0000 (22:00 +0000)]
[chromium] Fix comile warning on CCLayerTreeHost

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate expectations to note flakiness.
abarth@webkit.org [Fri, 12 Aug 2011 21:44:14 +0000 (21:44 +0000)]
Update expectations to note flakiness.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoApple-style-span class seems unnecessary
rniwa@webkit.org [Fri, 12 Aug 2011 21:42:58 +0000 (21:42 +0000)]
Apple-style-span class seems unnecessary
https://bugs.webkit.org/show_bug.cgi?id=12248

Reviewed by Justin Garcia.

Source/WebCore:

Stop generating span or font elements with class="Apple-style-span" given WebKit's editing component
no longer depends on Apple-style-span since r92823 removed the dependency of copy and paste code on
style spans. WebKit continues to recognize Apple style spans to remove them.

Also renamed isSpanWithoutAttributesOrUnstyleStyleSpan to isSpanWithoutAttributesOrUnstyle*d*StyleSpan.

* editing/ApplyStyleCommand.cpp:
(WebCore::isLegacyAppleStyleSpan): Renamed from isStyleSpan.
(WebCore::isSpanWithoutAttributesOrUnstyledStyleSpan): Renamed from isSpanWithoutAttributesOr*Unstyle*StyleSpan.
(WebCore::createFontElement): No longer adds class="Apple-style-span".
(WebCore::createStyleSpanElement): Ditto.
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Calls isSpanWithoutAttributesOrUnstyleStyleSpan
instead of isUnstyledStyleSpan since there won't be any Apple style spans.
(WebCore::dummySpanAncestorForNode):
(WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans): Ditto.
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Ditto.
(WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
(WebCore::ApplyStyleCommand::removeCSSStyle):
* editing/ApplyStyleCommand.h:
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::removeStyleFromRulesAndContext): Ditto.
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): Calls isLegacyAppleStyleSpan instead
of isStyleSpan.
(WebCore::handleStyleSpansBeforeInsertion): Ditto.
(WebCore::ReplaceSelectionCommand::handleStyleSpans): Ditto.
(WebCore::ReplaceSelectionCommand::doApply): Ditto.
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag): No longer adds class="Apple-style-span".

LayoutTests:

Rebaselined the tests because spans in these tests lost no longer have class="Apple-style-span".

* editing/deleting/delete-br-012-expected.txt:
* editing/deleting/delete-line-break-between-paragraphs-with-same-style-expected.txt:
* editing/deleting/delete-select-all-001-expected.txt:
* editing/execCommand/16049-expected.txt:
* editing/execCommand/5685604-1.html:
* editing/execCommand/delete-image-in-anchor-expected.txt:
* editing/execCommand/hilitecolor-expected.txt:
* editing/execCommand/modifyForeColorByCharacter-expected.txt:
* editing/execCommand/query-font-size-expected.txt:
* editing/execCommand/remove-format-multiple-elements-expected.txt:
* editing/execCommand/script-tests/remove-format-multiple-elements.js:
* editing/execCommand/script-tests/toggle-text-decorations.js:
* editing/execCommand/script-tests/toggle-unlink.js:
* editing/execCommand/toggle-style-2-expected.txt:
* editing/execCommand/toggle-text-decorations-expected.txt:
* editing/execCommand/toggle-unlink-expected.txt:
* editing/inserting/5994480-2-expected.txt:
* editing/pasteboard/5065605-expected.txt:
* editing/pasteboard/copy-null-characters-expected.txt:
* editing/pasteboard/copy-text-with-backgroundcolor-expected.txt:
* editing/pasteboard/data-transfer-items-expected.txt:
* editing/pasteboard/do-not-copy-unnecessary-styles-2-expected.txt:
* editing/pasteboard/do-not-copy-unnecessary-styles-expected.txt:
* editing/pasteboard/onpaste-text-html-expected.txt:
* editing/pasteboard/paste-text-with-style-2-expected.txt:
* editing/style/apply-font-size-to-multiple-nodes-expected.txt:
* editing/style/block-style-004-expected.txt:
* editing/style/block-style-005-expected.txt:
* editing/style/block-style-006-expected.txt:
* editing/style/fontsize-1-expected.txt:
* editing/style/fore-color-by-name-expected.txt:
* editing/style/highlight-insert-paragraph-expected.txt:
* editing/style/inline-style-container-expected.txt:
* editing/style/inline-style-extend-run-expected.txt:
* editing/style/invalid-font-size-expected.txt:
* editing/style/push-down-font-styles-expected.txt:
* editing/style/script-tests/inline-style-container.js:
* editing/style/script-tests/inline-style-extend-run.js:
* editing/style/script-tests/push-down-font-styles.js:
* editing/style/style-text-node-without-editable-parent-expected.txt:
* fast/events/ondrop-text-html-expected.txt:
* platform/chromium-win/editing/inserting/5994480-2-expected.txt:
* platform/gtk/editing/inserting/5994480-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate some configuration settings that were missed back in r92432.
mrowe@apple.com [Fri, 12 Aug 2011 21:42:44 +0000 (21:42 +0000)]
Update some configuration settings that were missed back in r92432.

* Configurations/CompilerVersion.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fix compositor breakage due to duplicate context creation AND by context...
nduca@chromium.org [Fri, 12 Aug 2011 21:41:14 +0000 (21:41 +0000)]
[chromium] Fix compositor breakage due to duplicate context creation AND by context-lost
https://bugs.webkit.org/show_bug.cgi?id=66168

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSwitch RenderMenuList, RenderListBox, and RenderFieldSet to new layout units
leviw@chromium.org [Fri, 12 Aug 2011 21:35:02 +0000 (21:35 +0000)]
Switch RenderMenuList, RenderListBox, and RenderFieldSet to new layout units
https://bugs.webkit.org/show_bug.cgi?id=66149

Reviewed by Eric Seidel.

Changing RenderMenuList, RenderListBox, and RenderFieldSet to the LayoutUnit
abstraction from ints.

No tests as no change in functionality.

* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::layoutSpecialExcludedChild):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::numVisibleItems):
(WebCore::RenderListBox::listHeight):
(WebCore::RenderListBox::baselinePosition):
(WebCore::RenderListBox::itemBoundingBoxRect):
(WebCore::itemOffsetForAlignment):
(WebCore::RenderListBox::panScroll):
(WebCore::RenderListBox::scrollToward):
(WebCore::RenderListBox::autoscroll):
(WebCore::RenderListBox::scrollSize):
(WebCore::RenderListBox::scrollPosition):
(WebCore::RenderListBox::setScrollOffset):
(WebCore::RenderListBox::itemHeight):
(WebCore::RenderListBox::verticalScrollbarWidth):
(WebCore::RenderListBox::scrollWidth):
(WebCore::RenderListBox::scrollHeight):
(WebCore::RenderListBox::scrollLeft):
(WebCore::RenderListBox::setScrollLeft):
(WebCore::RenderListBox::scrollTop):
(WebCore::RenderListBox::setScrollTop):
(WebCore::RenderListBox::controlClipRect):
(WebCore::RenderListBox::invalidateScrollbarRect):
(WebCore::RenderListBox::convertFromScrollbarToContainingView):
(WebCore::RenderListBox::convertFromContainingViewToScrollbar):
(WebCore::RenderListBox::contentsSize):
(WebCore::RenderListBox::currentMousePosition):
* rendering/RenderListBox.h:
(WebCore::RenderListBox::scrollCornerRect):
(WebCore::RenderListBox::invalidateScrollCornerRect):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::controlClipRect):
(WebCore::RenderMenuList::showPopup):
* rendering/RenderMenuList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebKit/chromium: Wire gesture tap events, add support for gesture events in...
commit-queue@webkit.org [Fri, 12 Aug 2011 21:28:37 +0000 (21:28 +0000)]
Source/WebKit/chromium: Wire gesture tap events, add support for gesture events in the DRT and add a layout test for it.
https://bugs.webkit.org/show_bug.cgi?id=66105

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-08-12
Reviewed by Darin Fisher.

* public/WebInputEvent.h:
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::handleInputEvent):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):

Tools: DRT: Add support for gesture events.
https://bugs.webkit.org/show_bug.cgi?id=66105

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-08-12
Reviewed by Darin Fisher.

* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender):
(EventSender::gestureScrollBegin):
(EventSender::gestureScrollEnd):
(EventSender::gestureTap):
(EventSender::gestureEvent):
* DumpRenderTree/chromium/EventSender.h:

LayoutTests: DRT: Add support for gesture events.
https://bugs.webkit.org/show_bug.cgi?id=66105

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-08-12
Reviewed by Darin Fisher.

* fast/events/touch/gesture/gesture-click-expected.txt: Added.
* fast/events/touch/gesture/gesture-click.html: Added.
* platform/chromium/fast/events/touch/gesture/gesture-click-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=66133
hyatt@apple.com [Fri, 12 Aug 2011 21:02:19 +0000 (21:02 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=66133

Make hit testing work on RenderRegions. Pass off the hit testing to the RenderFlowThread
layer tree (just as we did with painting).

Reviewed by Sam Weinig.

Added hit-test-float.html to demonstrate basic hit testing of content flowed into regions.

Source/WebCore:

* rendering/HitTestRequest.h:
(WebCore::HitTestRequest::type):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::hitTestRegion):
* rendering/RenderFlowThread.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::paintReplaced):
(WebCore::RenderRegion::nodeAtPoint):
* rendering/RenderRegion.h:

LayoutTests:

* fast/regions/hit-test-float-expected.txt: Added.
* fast/regions/hit-test-float.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSwitch RenderTable* to new layout types
leviw@chromium.org [Fri, 12 Aug 2011 21:01:45 +0000 (21:01 +0000)]
Switch RenderTable* to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66146

Reviewed by Eric Seidel.

Converting RenderTable* classes to new LayoutUnits from ints.

No new tests as no new functionality.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::firstLineBoxBaseline):
(WebCore::RenderTable::overflowClipRect):
* rendering/RenderTable.h:
(WebCore::RenderTable::columnPositions):
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::clippedOverflowRectForRepaint):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::clippedOverflowRectForRepaint):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderBefore):
(WebCore::RenderTableSection::calcOuterBorderAfter):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::firstLineBoxBaseline):
(WebCore::RenderTableSection::paintObject):
(WebCore::RenderTableSection::nodeAtPoint):
* rendering/RenderTableSection.h:
(WebCore::RenderTableSection::outerBorderBefore):
(WebCore::RenderTableSection::outerBorderAfter):
(WebCore::RenderTableSection::outerBorderStart):
(WebCore::RenderTableSection::outerBorderEnd):
(WebCore::RenderTableSection::getBaseline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPatch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2011-08-12
commit-queue@webkit.org [Fri, 12 Aug 2011 20:58:53 +0000 (20:58 +0000)]
Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2011-08-12
Reviewed by Alexey Proskuryakov.

EventSource loader should not buffer data
https://bugs.webkit.org/show_bug.cgi?id=61863

Disabled buffering in the EventSource loader.

Added a manual test.

* manual-tests/eventsource/eventsource-loader-buffering.html: Added.
* manual-tests/eventsource/eventsource-loader-buffering.php: Added.
* page/EventSource.cpp:
(WebCore::EventSource::connect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip the test added by r92982 on Qt since it uses a new layoutTestController method
rniwa@webkit.org [Fri, 12 Aug 2011 20:56:14 +0000 (20:56 +0000)]
Skip the test added by r92982 on Qt since it uses a new layoutTestController method
that hasn't been implemented by Qt DRT. The failure is tracked by the bug 66162.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Implement the embedders for the HTML5 Track List objects
commit-queue@webkit.org [Fri, 12 Aug 2011 20:46:17 +0000 (20:46 +0000)]
[Chromium] Implement the embedders for the HTML5 Track List objects
https://bugs.webkit.org/show_bug.cgi?id=60260

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-08-12
Reviewed by Darin Fisher.

* WebKit.gyp:
* public/WebMediaStreamTrack.h: Added.
(WebKit::WebMediaStreamTrack::WebMediaStreamTrack):
(WebKit::WebMediaStreamTrack::~WebMediaStreamTrack):
(WebKit::WebMediaStreamTrack::isNull):
* public/WebMediaStreamTrackList.h: Added.
(WebKit::WebMediaStreamTrackList::WebMediaStreamTrackList):
(WebKit::WebMediaStreamTrackList::~WebMediaStreamTrackList):
(WebKit::WebMediaStreamTrackList::isNull):
* src/WebMediaStreamTrack.cpp: Added.
(WebKit::WebMediaStreamTrack::initialize):
(WebKit::WebMediaStreamTrack::reset):
(WebKit::WebMediaStreamTrack::WebMediaStreamTrack):
(WebKit::WebMediaStreamTrack::operator WTF::PassRefPtr<WebCore::MediaStreamTrack>):
* src/WebMediaStreamTrackList.cpp: Added.
(WebKit::WebMediaStreamTrackList::initialize):
(WebKit::WebMediaStreamTrackList::reset):
(WebKit::WebMediaStreamTrackList::WebMediaStreamTrackList):
(WebKit::WebMediaStreamTrackList::operator WTF::PassRefPtr<MediaStreamTrackList>):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGTK rebaselines after r92890.
rniwa@webkit.org [Fri, 12 Aug 2011 20:41:04 +0000 (20:41 +0000)]
GTK rebaselines after r92890.

* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMac rebaselines after r92890.
rniwa@webkit.org [Fri, 12 Aug 2011 20:34:54 +0000 (20:34 +0000)]
Mac rebaselines after r92890.

* fast/dom/Window/window-properties-expected.txt:
* fast/dom/Window/window-property-descriptors-expected.txt:
* fast/dom/prototype-inheritance-2-expected.txt:
* platform/mac/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r91610?): Bing Maps fail to initialize (InvalidOperation:
barraclough@apple.com [Fri, 12 Aug 2011 20:33:25 +0000 (20:33 +0000)]
REGRESSION (r91610?): Bing Maps fail to initialize (InvalidOperation:
Matrix3D.invert)
https://bugs.webkit.org/show_bug.cgi?id=66038

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-08-12
Reviewed by Gavin Barraclough.

Simplest and lowest-impact fix for the case where the spilled format
of a DFG node differs from the register format: if the format is
converted then indicate that the spilled value is no longer valid
("kill the spill").

* dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::killSpilled):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoResourceLoader::didReceiveDataArray() does not handle m_shouldBufferData correctly
psolanki@apple.com [Fri, 12 Aug 2011 20:33:04 +0000 (20:33 +0000)]
ResourceLoader::didReceiveDataArray() does not handle m_shouldBufferData correctly
https://bugs.webkit.org/show_bug.cgi?id=65926

Reviewed by Alexey Proskuryakov.

* loader/mac/ResourceLoaderMac.mm:
(WebCore::ResourceLoader::didReceiveDataArray): Make sure we call the client callbacks when
m_shouldBufferData is set to false.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoallowRoundingHacksCallback uses the wrong argument for 'thisObject'.
aestes@apple.com [Fri, 12 Aug 2011 20:18:51 +0000 (20:18 +0000)]
allowRoundingHacksCallback uses the wrong argument for 'thisObject'.
https://bugs.webkit.org/show_bug.cgi?id=66158

Reviewed by Dan Bernstein.

* DumpRenderTree/LayoutTestController.cpp:
(allowRoundingHacksCallback): The third argument is the 'this'
JSObjectRef, not the second.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r92976.
abarth@webkit.org [Fri, 12 Aug 2011 20:16:10 +0000 (20:16 +0000)]
Unreviewed, rolling out r92976.
http://trac.webkit.org/changeset/92976
https://bugs.webkit.org/show_bug.cgi?id=66159

Does not compile on chromium-win (Requested by abarth|gardener
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-12

Source/WebCore:

* WebCore.gypi:
* platform/chromium/PopupContainer.cpp: Removed.
* platform/chromium/PopupContainer.h: Removed.
* platform/chromium/PopupListBox.cpp: Removed.
* platform/chromium/PopupListBox.h: Removed.
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupListBox::create):
(WebCore::PopupListBox::selectedIndex):
(WebCore::PopupListBox::numItems):
(WebCore::PopupListBox::setBaseWidth):
(WebCore::PopupListBox::setMaxHeight):
(WebCore::PopupListBox::setMaxWidth):
(WebCore::PopupListBox::disconnectClient):
(WebCore::PopupListBox::items):
(WebCore::PopupListBox::PopupListBox):
(WebCore::PopupListBox::~PopupListBox):
(WebCore::PopupListBox::scrollToRevealSelection):
(WebCore::constructRelativeMouseEvent):
(WebCore::constructRelativeWheelEvent):
(WebCore::PopupContainer::create):
(WebCore::PopupContainer::PopupContainer):
(WebCore::PopupContainer::~PopupContainer):
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
(WebCore::PopupContainer::showPopup):
(WebCore::PopupContainer::hidePopup):
(WebCore::PopupContainer::notifyPopupHidden):
(WebCore::PopupContainer::layoutAndGetRTLOffset):
(WebCore::PopupContainer::handleMouseDownEvent):
(WebCore::PopupContainer::handleMouseMoveEvent):
(WebCore::PopupContainer::handleMouseReleaseEvent):
(WebCore::PopupContainer::handleWheelEvent):
(WebCore::PopupContainer::handleTouchEvent):
(WebCore::PopupContainer::handleGestureEvent):
(WebCore::PopupContainer::handleKeyEvent):
(WebCore::PopupContainer::hide):
(WebCore::PopupContainer::paint):
(WebCore::PopupContainer::paintBorder):
(WebCore::PopupContainer::isInterestedInEventForKey):
(WebCore::PopupContainer::chromeClientChromium):
(WebCore::PopupContainer::showInRect):
(WebCore::PopupContainer::refresh):
(WebCore::PopupContainer::isRTL):
(WebCore::PopupContainer::selectedIndex):
(WebCore::PopupContainer::menuItemHeight):
(WebCore::PopupContainer::menuItemFontSize):
(WebCore::PopupContainer::menuStyle):
(WebCore::popupData):
(WebCore::PopupContainer::getSelectedItemToolTip):
(WebCore::PopupListBox::handleMouseDownEvent):
(WebCore::PopupListBox::handleMouseMoveEvent):
(WebCore::PopupListBox::handleMouseReleaseEvent):
(WebCore::PopupListBox::handleWheelEvent):
(WebCore::PopupListBox::isInterestedInEventForKey):
(WebCore::PopupListBox::handleTouchEvent):
(WebCore::PopupListBox::handleGestureEvent):
(WebCore::isCharacterTypeEvent):
(WebCore::PopupListBox::handleKeyEvent):
(WebCore::PopupListBox::hostWindow):
(WebCore::stripLeadingWhiteSpace):
(WebCore::PopupListBox::typeAheadFind):
(WebCore::PopupListBox::paint):
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowFont):
(WebCore::PopupListBox::abandon):
(WebCore::PopupListBox::pointToRowIndex):
(WebCore::PopupListBox::acceptIndex):
(WebCore::PopupListBox::selectIndex):
(WebCore::PopupListBox::setOriginalIndex):
(WebCore::PopupListBox::getRowHeight):
(WebCore::PopupListBox::getRowBounds):
(WebCore::PopupListBox::invalidateRow):
(WebCore::PopupListBox::scrollToRevealRow):
(WebCore::PopupListBox::isSelectableItem):
(WebCore::PopupListBox::clearSelection):
(WebCore::PopupListBox::selectNextRow):
(WebCore::PopupListBox::selectPreviousRow):
(WebCore::PopupListBox::adjustSelectedIndex):
(WebCore::PopupListBox::hidePopup):
(WebCore::PopupListBox::updateFromElement):
(WebCore::PopupListBox::setMaxWidthAndLayout):
(WebCore::PopupListBox::layout):
(WebCore::PopupListBox::clear):
(WebCore::PopupListBox::isPointInBounds):
* platform/chromium/PopupMenuChromium.h:
(WebCore::PopupItem::PopupItem):
(WebCore::PopupContainer::listBox):
(WebCore::PopupContainer::popupType):

Source/WebKit/chromium:

* src/ChromeClientImpl.cpp:
* src/WebPopupMenuImpl.cpp:
* src/WebViewImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCancel in onbeforeunload dialog sometime causes a button to stop working.
aestes@apple.com [Fri, 12 Aug 2011 19:56:56 +0000 (19:56 +0000)]
Cancel in onbeforeunload dialog sometime causes a button to stop working.
https://bugs.webkit.org/show_bug.cgi?id=26211

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: fast/loader/form-submission-after-beforeunload-cancel.html

If an onbeforeunload handler cancels a navigation that was triggered by
a form submission, WebCore's multiple form submission protection
prevents the form from being submitted a second time even though no
first submission actually took place. Fix this by clearing
m_submittedFormURL if the onbeforeunload handler cancels the load. This
allows the submission to be retried.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::shouldClose): Set m_submittedFormURL to KURL()
if shouldClose() will return false.

Tools:

Implement a new LayoutTestController method that a test can call to set
the return value of DumpRenderTree's beforeunload UI delegate.

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController): Initialize
m_shouldStayOnPageAfterHandlingBeforeUnload.
(setShouldStayOnPageAfterHandlingBeforeUnloadCallback): Call
LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload().
(LayoutTestController::staticFunctions): Register
'setShouldStayOnPageAfterHandlingBeforeUnload' as a static function.
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
(LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController): Initialize
m_shouldStayOnPageAfterHandlingBeforeUnload and bind
'setShouldStayOnPageAfterHandlingBeforeUnload' to its c++ setter.
(LayoutTestController::reset): Reset
m_shouldStayOnPageAfterHandlingBeforeUnload to false.
(LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
Set m_shouldStayOnPageAfterHandlingBeforeUnload to the value passed in
from JavaScript.
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::runModalBeforeUnloadDialog): Add the correct logging and
return the inverse of
LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload().
* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]): Ditto.
* DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
Define setShouldStayOnPageAfterHandlingBeforeUnload().
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::postNewBeforeUnloadReturnValue): Post a message
to the Test Controller telling it what value it should return in its
onbeforeunload UI delegate.
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
Call InjectedBundle::postNewBeforeUnloadReturnValue().
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController): Initialize
m_beforeUnloadReturnValue to true.
(WTR::runBeforeUnloadConfirmPanel): Add the correct logging and return
the value of TestController::beforeUnloadReturnValue().
(WTR::TestController::resetStateToConsistentValues): Reset
m_beforeUnloadReturnValue to true.
* WebKitTestRunner/TestController.h:
(WTR::TestController::beforeUnloadReturnValue):
(WTR::TestController::setBeforeUnloadReturnValue):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the
message posted from the injected bundle by retrieving the message body
as a WKBoolean and calling TestController::setBeforeUnloadReturnValue().

LayoutTests:

* fast/loader/form-submission-after-beforeunload-cancel-expected.txt: Added.
* fast/loader/form-submission-after-beforeunload-cancel.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=66130
hyatt@apple.com [Fri, 12 Aug 2011 19:53:24 +0000 (19:53 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=66130

RenderRegions need to paint the entire RenderFlowThread layer tree. Instead of just calling
paintBlock, make sure RenderRegions paint the flow thread's layer tree instead with the appropriate
offset.

Fix RenderRegions to derive from RenderReplaced instead of RenderBox, since it simplifies the code.
They no longer have to subclass their own layout method or worry about all of the painting logic
for anything other than the content area.

Reviewed by Anders Carlsson.

Existing tests have a layer tree example, and so those results are updated to show the tree now.

Source/WebCore:

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::createFlowThreadStyle):
(WebCore::RenderFlowThread::paintIntoRegion):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::collectLayers):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::paintReplaced):
(WebCore::RenderRegion::styleDidChange):
* rendering/RenderRegion.h:

LayoutTests:

* fast/regions/content-flowed-into-regions-dynamically-added-expected.png:
* fast/regions/content-flowed-into-regions-dynamically-removed-expected.png:
* fast/regions/content-flowed-into-regions-expected.png:
* fast/regions/content-flowed-into-regions-with-dyn-index-expected.png:
* fast/regions/content-flowed-into-regions-with-index-dom-expected.png:
* fast/regions/content-flowed-into-regions-with-index-expected.png:
* fast/regions/flow-content-basic-vertical.html:
* fast/regions/webkit-flow-renderer-layer-expected.txt:
* platform/mac/fast/regions/flow-content-basic-expected.png:
* platform/mac/fast/regions/flow-content-basic-vertical-expected.png:
* platform/mac/fast/regions/flow-content-basic-vertical-expected.txt:
* platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r92978.
abarth@webkit.org [Fri, 12 Aug 2011 19:38:44 +0000 (19:38 +0000)]
Unreviewed, rolling out r92978.
http://trac.webkit.org/changeset/92978
https://bugs.webkit.org/show_bug.cgi?id=66155

This patch does not compile (Requested by abarth|gardener on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-12

* public/WebView.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::zoomLevel):
(WebKit::WebViewImpl::setZoomLevel):
(WebKit::WebViewImpl::zoomLimitsChanged):
(WebKit::WebViewImpl::fullFramePluginZoomLevelChanged):
(WebKit::WebView::zoomLevelToZoomFactor):
(WebKit::WebView::zoomFactorToZoomLevel):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix mac build when web audio is enabled
crogers@google.com [Fri, 12 Aug 2011 18:56:44 +0000 (18:56 +0000)]
Fix mac build when web audio is enabled
https://bugs.webkit.org/show_bug.cgi?id=66150

Unreviewed build fix.

* platform/audio/mac/AudioFileReaderMac.cpp:
(WebCore::AudioFileReader::createBus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium's WebKit API should use floats instead of doubles for zoom to match WebCore
fsamuel@chromium.org [Fri, 12 Aug 2011 18:43:36 +0000 (18:43 +0000)]
Chromium's WebKit API should use floats instead of doubles for zoom to match WebCore
https://bugs.webkit.org/show_bug.cgi?id=66089

Reviewed by Darin Fisher.

* public/WebView.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::zoomLevel):
(WebKit::WebViewImpl::setZoomLevel):
(WebKit::WebViewImpl::zoomLimitsChanged):
(WebKit::WebViewImpl::fullFramePluginZoomLevelChanged):
(WebKit::WebView::zoomLevelToZoomFactor):
(WebKit::WebView::zoomFactorToZoomLevel):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeed to handle kCACFContextNeedsFlushNotification notifications that arrive after...
jeffm@apple.com [Fri, 12 Aug 2011 18:42:25 +0000 (18:42 +0000)]
Need to handle kCACFContextNeedsFlushNotification notifications that arrive after the AVFWrapper has been disposed
https://bugs.webkit.org/show_bug.cgi?id=65724

Instead of using a pointer to the AVFWrapper object as the context for various callbacks, assign each object an
ID and use that instead. Keep track of the mapping between object IDs and AVFWrapper objects in a HashMap, and manage
access to this map using a Mutex since it can be accessed from multiple threads. This allows us to actually delete
AVFWrapper objects instead of leaking them (which we were doing before to prevent crashes).

Reviewed by Eric Carlson.

No new tests, uses existing media tests.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::AVFWrapper::callbackContext): Added.
(WebCore::AVFWrapper::AVFWrapper): Initialize m_objectID and add it to the HashMap.
(WebCore::AVFWrapper::~AVFWrapper): Log object ID and remove obsolete assert.
(WebCore::AVFWrapper::mapLock): Added.
(WebCore::AVFWrapper::map): Added.
(WebCore::AVFWrapper::addToMap): Added.
(WebCore::AVFWrapper::removeFromMap): Added.
(WebCore::AVFWrapper::avfWrapperForCallbackContext): Added.
(WebCore::AVFWrapper::scheduleDisconnectAndDelete): Remove AVFWrapper from HashMap instead of zeroing m_owner.
(WebCore::AVFWrapper::disconnectAndDeleteAVFWrapper): Use callbackContext(), delete the AVFWrapper here.
(WebCore::AVFWrapper::createPlayer): Use callbackContext().
(WebCore::AVFWrapper::createPlayerItem): Use callbackContext().
(WebCore::AVFWrapper::periodicTimeObserverCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::notificationCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::loadPlayableCompletionCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::checkPlayability): Use callbackContext().
(WebCore::AVFWrapper::loadMetadataCompletionCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::beginLoadingMetadata): Use callbackContext().
(WebCore::AVFWrapper::seekCompletedCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::seekToTime): Use callbackContext().
(WebCore::AVFWrapper::platformLayer): Remove overly noisy LOG().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefactoring of PopupMenuChromium
fsamuel@chromium.org [Fri, 12 Aug 2011 18:36:37 +0000 (18:36 +0000)]
Refactoring of PopupMenuChromium
https://bugs.webkit.org/show_bug.cgi?id=66009

Reviewed by Darin Fisher.

Source/WebCore:

Split PopupMenuChromium into three sets of files: PopupMenuChromium.{h|cpp}, PopupContainer.{h|cpp}, and PopupLisBox.{h|cpp}
for readability and maintainability.

No new tests as no functionality has changed.

* WebCore.gypi:
* platform/chromium/PopupContainer.cpp: Added.
(WebCore::constructRelativeMouseEvent):
(WebCore::constructRelativeWheelEvent):
(WebCore::PopupContainer::create):
(WebCore::PopupContainer::PopupContainer):
(WebCore::PopupContainer::~PopupContainer):
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
(WebCore::PopupContainer::showPopup):
(WebCore::PopupContainer::hidePopup):
(WebCore::PopupContainer::notifyPopupHidden):
(WebCore::PopupContainer::layoutAndGetRTLOffset):
(WebCore::PopupContainer::handleMouseDownEvent):
(WebCore::PopupContainer::handleMouseMoveEvent):
(WebCore::PopupContainer::handleMouseReleaseEvent):
(WebCore::PopupContainer::handleWheelEvent):
(WebCore::PopupContainer::handleTouchEvent):
(WebCore::PopupContainer::handleGestureEvent):
(WebCore::PopupContainer::handleKeyEvent):
(WebCore::PopupContainer::hide):
(WebCore::PopupContainer::paint):
(WebCore::PopupContainer::paintBorder):
(WebCore::PopupContainer::isInterestedInEventForKey):
(WebCore::PopupContainer::chromeClientChromium):
(WebCore::PopupContainer::showInRect):
(WebCore::PopupContainer::refresh):
(WebCore::PopupContainer::isRTL):
(WebCore::PopupContainer::selectedIndex):
(WebCore::PopupContainer::menuItemHeight):
(WebCore::PopupContainer::menuItemFontSize):
(WebCore::PopupContainer::menuStyle):
(WebCore::popupData):
(WebCore::PopupContainer::getSelectedItemToolTip):
* platform/chromium/PopupContainer.h: Added.
(WebCore::PopupContainer::listBox):
(WebCore::PopupContainer::popupType):
* platform/chromium/PopupListBox.cpp: Added.
(WebCore::PopupListBox::PopupListBox):
(WebCore::PopupListBox::handleMouseDownEvent):
(WebCore::PopupListBox::handleMouseMoveEvent):
(WebCore::PopupListBox::handleMouseReleaseEvent):
(WebCore::PopupListBox::handleWheelEvent):
(WebCore::PopupListBox::isInterestedInEventForKey):
(WebCore::PopupListBox::handleTouchEvent):
(WebCore::PopupListBox::handleGestureEvent):
(WebCore::isCharacterTypeEvent):
(WebCore::PopupListBox::handleKeyEvent):
(WebCore::PopupListBox::hostWindow):
(WebCore::stripLeadingWhiteSpace):
(WebCore::PopupListBox::typeAheadFind):
(WebCore::PopupListBox::paint):
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowFont):
(WebCore::PopupListBox::abandon):
(WebCore::PopupListBox::pointToRowIndex):
(WebCore::PopupListBox::acceptIndex):
(WebCore::PopupListBox::selectIndex):
(WebCore::PopupListBox::setOriginalIndex):
(WebCore::PopupListBox::getRowHeight):
(WebCore::PopupListBox::getRowBounds):
(WebCore::PopupListBox::invalidateRow):
(WebCore::PopupListBox::scrollToRevealRow):
(WebCore::PopupListBox::isSelectableItem):
(WebCore::PopupListBox::clearSelection):
(WebCore::PopupListBox::selectNextRow):
(WebCore::PopupListBox::selectPreviousRow):
(WebCore::PopupListBox::adjustSelectedIndex):
(WebCore::PopupListBox::hidePopup):
(WebCore::PopupListBox::updateFromElement):
(WebCore::PopupListBox::setMaxWidthAndLayout):
(WebCore::PopupListBox::layout):
(WebCore::PopupListBox::clear):
(WebCore::PopupListBox::isPointInBounds):
* platform/chromium/PopupListBox.h: Added.
(WebCore::PopupItem::PopupItem):
(WebCore::PopupListBox::create):
(WebCore::PopupListBox::selectedIndex):
(WebCore::PopupListBox::numItems):
(WebCore::PopupListBox::setBaseWidth):
(WebCore::PopupListBox::setMaxHeight):
(WebCore::PopupListBox::setMaxWidth):
(WebCore::PopupListBox::disconnectClient):
(WebCore::PopupListBox::items):
(WebCore::PopupListBox::~PopupListBox):
(WebCore::PopupListBox::scrollToRevealSelection):
* platform/chromium/PopupMenuChromium.cpp:
* platform/chromium/PopupMenuChromium.h:

Source/WebKit/chromium:

* src/ChromeClientImpl.cpp:
* src/WebPopupMenuImpl.cpp:
* src/WebViewImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove compiler specific macros to their own header
weinig@apple.com [Fri, 12 Aug 2011 17:51:08 +0000 (17:51 +0000)]
Move compiler specific macros to their own header
https://bugs.webkit.org/show_bug.cgi?id=66119

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
Add Compiler.h

* wtf/AlwaysInline.h:
Move the contents of this file (which no longer was just about ALWAYS_INLINE) to
Compiler.h.  We can remove this file in a later commit.

* wtf/Compiler.h: Added.
Put all compiler specific checks and features in this file.

* wtf/Platform.h:
Move COMPILER macro and definitions (and the odd WARN_UNUSED_RETURN compiler feature)
to Compiler.h.  Include Compiler.h since it is necessary.

Source/JavaScriptGlue:

* ForwardingHeaders/wtf/Compiler.h: Added.

Source/WebCore:

* ForwardingHeaders/wtf/Compiler.h: Added.

Tools:

* DumpRenderTree/ForwardingHeaders/wtf/Compiler.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][REGRESSION] composited content doesn't render since r92651
noam.rosenthal@nokia.com [Fri, 12 Aug 2011 17:36:18 +0000 (17:36 +0000)]
[Qt][REGRESSION] composited content doesn't render since r92651
https://bugs.webkit.org/show_bug.cgi?id=66108

Reviewed by Benjamin Poulain.

Changed the signature for GraphicsLayerTextureMapper::syncCompositingState to match
the new signature in GraphicsLayer.h.

No new tests. This is a regression that's covered by existing pixel tests.

* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::syncCompositingState):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a way to extend DOM objects in garden-o-matic.
dglazkov@chromium.org [Fri, 12 Aug 2011 17:34:12 +0000 (17:34 +0000)]
Add a way to extend DOM objects in garden-o-matic.
https://bugs.webkit.org/show_bug.cgi?id=66096

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.extends.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExpose pageScaleFactor in Chromium's WebHistoryItem
fsamuel@chromium.org [Fri, 12 Aug 2011 17:28:12 +0000 (17:28 +0000)]
Expose pageScaleFactor in Chromium's WebHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=66139

Reviewed by Darin Fisher.

* public/WebHistoryItem.h:
* src/WebHistoryItem.cpp:
(WebKit::WebHistoryItem::pageScaleFactor):
(WebKit::WebHistoryItem::setPageScaleFactor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOriginal patch by Mihnea Ovidenie <mihnea@adobe.com>.
commit-queue@webkit.org [Fri, 12 Aug 2011 17:22:25 +0000 (17:22 +0000)]
Original patch by Mihnea Ovidenie <mihnea@adobe.com>.
Also contains some improvements done by Dave Hyatt <hyatt@apple.com>.

[CSSRegions]RenderFlowThread should display its content using RenderRegion
https://bugs.webkit.org/show_bug.cgi?id=65627

Source/WebCore:

RenderFlowThread collects RenderObjects from a flow. These objects are displayed by means
of RenderRegion objects that get the content from the same flow.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-12
Reviewed by David Hyatt.

Tests: fast/regions/content-flowed-into-regions-dynamically-added.html
       fast/regions/content-flowed-into-regions-dynamically-removed.html
       fast/regions/content-flowed-into-regions-with-dyn-index.html
       fast/regions/content-flowed-into-regions-with-index-dom.html
       fast/regions/content-flowed-into-regions-with-index.html
       fast/regions/content-flowed-into-regions.html
       fast/regions/flow-content-basic-vertical-rl.html
       fast/regions/flow-content-basic-vertical.html

* dom/Node.cpp:
(WebCore::Node::diff):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::createFlowThreadStyle):
(WebCore::RenderFlowThread::styleDidChange):
(WebCore::compareRenderRegions):
(WebCore::RenderFlowThread::addRegionToThread):
(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeLogicalWidth):
(WebCore::RenderFlowThread::computeLogicalHeight):
(WebCore::RenderFlowThread::paintIntoRegion):
* rendering/RenderFlowThread.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::~RenderRegion):
(WebCore::RenderRegion::paint):
(WebCore::RenderRegion::styleDidChange):
* rendering/RenderRegion.h:
(WebCore::RenderRegion::setRegionRect):
(WebCore::RenderRegion::regionRect):
* rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
* rendering/RenderView.cpp:
(WebCore::RenderView::styleDidChange):
(WebCore::RenderView::renderFlowThreadWithName):
* rendering/RenderView.h:

LayoutTests:

Also updated the old tests that expected an 100% by 100% RenderFlowThread. Those tests
require at least a region attached, otherwise the RenderFlowThread would have been 0/0 in size,
and no output would be generated for them in the render tree.

The attached regions are now printed in the render tree, so some tests required updated results.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-12
Reviewed by David Hyatt.

* fast/regions/content-flowed-into-regions-dynamically-added-expected.png: Added.
* fast/regions/content-flowed-into-regions-dynamically-added-expected.txt: Added.
* fast/regions/content-flowed-into-regions-dynamically-added.html: Added.
* fast/regions/content-flowed-into-regions-dynamically-removed-expected.png: Added.
* fast/regions/content-flowed-into-regions-dynamically-removed-expected.txt: Added.
* fast/regions/content-flowed-into-regions-dynamically-removed.html: Added.
* fast/regions/content-flowed-into-regions-expected.png: Added.
* fast/regions/content-flowed-into-regions-expected.txt: Added.
* fast/regions/content-flowed-into-regions-with-dyn-index-expected.png: Added.
* fast/regions/content-flowed-into-regions-with-dyn-index-expected.txt: Added.
* fast/regions/content-flowed-into-regions-with-dyn-index.html: Added.
* fast/regions/content-flowed-into-regions-with-index-dom-expected.png: Added.
* fast/regions/content-flowed-into-regions-with-index-dom-expected.txt: Added.
* fast/regions/content-flowed-into-regions-with-index-dom.html: Added.
* fast/regions/content-flowed-into-regions-with-index-expected.png: Added.
* fast/regions/content-flowed-into-regions-with-index-expected.txt: Added.
* fast/regions/content-flowed-into-regions-with-index.html: Added.
* fast/regions/content-flowed-into-regions.html: Added.
* fast/regions/flow-content-basic-vertical-rl.html: Copied from LayoutTests/fast/regions/flow-content-basic.html.
* fast/regions/flow-content-basic-vertical.html: Copied from LayoutTests/fast/regions/flow-content-basic.html.
* fast/regions/flow-content-basic.html:
* fast/regions/render-region-renderer-expected.txt:
* fast/regions/resources/region-style.css: Added.
(.greenBox):
(.blueBox):
(.orangeBox):
(.flowArticle):
(.regionArticle):
(.borderBox):
* fast/regions/webkit-flow-renderer-expected.txt:
* fast/regions/webkit-flow-renderer-layer-expected.txt:
* fast/regions/webkit-flow-renderer-layer.html:
* fast/regions/webkit-flow-renderer-nested-expected.txt:
* fast/regions/webkit-flow-renderer-nested.html:
* fast/regions/webkit-flow-renderer.html:
* platform/mac/fast/regions/flow-content-basic-expected.png: Added.
* platform/mac/fast/regions/flow-content-basic-expected.txt: Added.
* platform/mac/fast/regions/flow-content-basic-vertical-expected.png: Added.
* platform/mac/fast/regions/flow-content-basic-vertical-expected.txt: Added.
* platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.png: Added.
* platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in WebCore::editingIgnoresContent
inferno@chromium.org [Fri, 12 Aug 2011 16:27:57 +0000 (16:27 +0000)]
Crash in WebCore::editingIgnoresContent
https://bugs.webkit.org/show_bug.cgi?id=66125

Reviewed by Ryosuke Niwa.

Source/WebCore:

RefPtr a few nodes in case they get blown away in
dispatchEvent calls.

Test: editing/selection/select-start-remove-root-crash.html

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::selectAll):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):

LayoutTests:

Tests that we do not crash when we blow away the root
during the firing of selectstart event in selection.

* editing/selection/select-start-remove-root-crash-expected.txt: Added.
* editing/selection/select-start-remove-root-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add WebThread to WebKitClient
nduca@chromium.org [Fri, 12 Aug 2011 16:26:39 +0000 (16:26 +0000)]
[chromium] Add WebThread to WebKitClient
https://bugs.webkit.org/show_bug.cgi?id=66013

Reviewed by Darin Fisher.

* public/WebKitClient.h:
(WebKit::WebKitClient::createThread):
* public/WebThread.h: Added.
(WebKit::WebThread::~WebThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: properly update console message count in source frames and resources...
podivilov@chromium.org [Fri, 12 Aug 2011 15:34:08 +0000 (15:34 +0000)]
Web Inspector: properly update console message count in source frames and resources panel.
https://bugs.webkit.org/show_bug.cgi?id=57009

Reviewed by Yury Semikhatsky.

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageRepeatCountUpdated):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.show):
(WebInspector.SourceFrame.prototype.addMessageToSource):
(WebInspector.SourceFrame.prototype._updateMessageRepeatCount):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add test for correct order of load signals in QWebPage
caio.oliveira@openbossa.org [Fri, 12 Aug 2011 15:15:16 +0000 (15:15 +0000)]
[Qt] Add test for correct order of load signals in QWebPage
https://bugs.webkit.org/show_bug.cgi?id=66016

Reviewed by Benjamin Poulain.

Add API test to ensure the order of load signals: loadStarted() needs to be emitted
first, then loadProgress(100), followed by loadFinished().

The test is skipped since this right now is broken, the bug
https://bugs.webkit.org/show_bug.cgi?id=28851 tracks one possible way to fix.

* tests/qwebpage/tst_qwebpage.cpp:
(SpyForLoadSignalsOrder::SpyForLoadSignalsOrder):
(SpyForLoadSignalsOrder::isFinished):
(SpyForLoadSignalsOrder::onLoadProgress):
(tst_QWebPage::loadSignalsOrder_data):
(tst_QWebPage::loadSignalsOrder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-12 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Fri, 12 Aug 2011 14:56:04 +0000 (14:56 +0000)]
2011-08-12  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: follow up to inspector test breakage.

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._showScriptFoldersSettingChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: expand exception properties when wrapping it as object.
yurys@chromium.org [Fri, 12 Aug 2011 14:50:47 +0000 (14:50 +0000)]
Web Inspector: expand exception properties when wrapping it as object.
https://bugs.webkit.org/show_bug.cgi?id=66035

Source/WebCore:

Use toString() value as a description for value thrown during eval.

Reviewed by Pavel Feldman.

* inspector/InjectedScriptSource.js:
(.):

LayoutTests:

Reviewed by Pavel Feldman.

* inspector/console/console-eval-global-expected.txt:
* inspector/console/console-eval-syntax-error-expected.txt:
* inspector/console/console-eval-undefined-override-expected.txt:
* inspector/extensions/extensions-eval-expected.txt:
* inspector/runtime/runtime-setPropertyValue-expected.txt:
* platform/chromium/inspector/console/console-eval-global-expected.txt:
* platform/chromium/inspector/console/console-eval-syntax-error-expected.txt:
* platform/chromium/inspector/console/console-eval-undefined-override-expected.txt:
* platform/chromium/inspector/debugger/debugger-activation-crash2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Make sure QtWebKit correctly compiles when building WebKit2 with Qt5.
alexis.menard@openbossa.org [Fri, 12 Aug 2011 14:33:34 +0000 (14:33 +0000)]
[Qt] Make sure QtWebKit correctly compiles when building WebKit2 with Qt5.

In order to build correctly the QtQuick1 plugin we need to explicitly
link to the new library added in Qt5 "qtquick1".

Reviewed by Simon Hausmann.

* declarative/declarative.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-12 Andrei Popescu <andreip@google.com>
andreip@google.com [Fri, 12 Aug 2011 14:05:53 +0000 (14:05 +0000)]
2011-08-12  Andrei Popescu  <andreip@google.com>

[Chromium] Rebaseline these tests on Leopard.

Unreviewed gardening.

* LayoutTests/platform/chromium-linux/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
* LayoutTests/platform/chromium-mac-leopard/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
* LayoutTests/platform/chromium-mac-leopard/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
* LayoutTests/platform/chromium-mac/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
* LayoutTests/platform/chromium-mac/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
* LayoutTests/platform/chromium-win-xp/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
* LayoutTests/platform/chromium-win/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
* LayoutTests/platform/chromium-win/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: make folders optional in the Scripts' panel file selector.
pfeldman@chromium.org [Fri, 12 Aug 2011 13:54:10 +0000 (13:54 +0000)]
Web Inspector: make folders optional in the Scripts' panel file selector.
https://bugs.webkit.org/show_bug.cgi?id=66100

Reviewed by Yury Semikhatsky.

Source/WebCore:

* English.lproj/localizedStrings.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._showScriptFoldersSettingChanged):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered.optionCompare):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.prototype.reset):
(WebInspector.ScriptsPanel.prototype._resetFilesSelect):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):

LayoutTests:

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/scripts-sorting-expected.txt:
* inspector/debugger/scripts-sorting.html:
* platform/chromium/inspector/debugger/scripts-sorting-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: add space between error info and error message in source frame message...
podivilov@chromium.org [Fri, 12 Aug 2011 13:03:09 +0000 (13:03 +0000)]
Web Inspector: add space between error info and error message in source frame message bubble.
https://bugs.webkit.org/show_bug.cgi?id=65069

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleMessage.prototype._formatMessage):

LayoutTests:

* http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
* inspector/debugger/source-frame-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: console loses focus upon reloading the page from the inspector.
pfeldman@chromium.org [Fri, 12 Aug 2011 12:56:28 +0000 (12:56 +0000)]
Web Inspector: console loses focus upon reloading the page from the inspector.
https://bugs.webkit.org/show_bug.cgi?id=66068

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel.prototype._auditFinishedCallback):
(WebInspector.AuditsPanel.prototype._clearButtonClicked):
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype.revealAndSelect):
(WebInspector.DataGridNode.prototype.revealAndSelect):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._jumpToSearchResult):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.this.treeOutline.selectedNodeChanged):
(WebInspector.ElementsPanel.get this):
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._reset):
(WebInspector.ElementsPanel.prototype._setDocument.selectNode):
(WebInspector.ElementsPanel.prototype._setDocument.selectLastSelectedNode):
(WebInspector.ElementsPanel.prototype._setDocument):
(WebInspector.ElementsPanel.prototype._domWordWrapSettingChanged):
(WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
(WebInspector.ElementsPanel.prototype.switchToAndFocus):
(WebInspector.ElementsPanel.prototype.selectedDOMNode):
(WebInspector.ElementsPanel.prototype.selectDOMNode):
(WebInspector.ElementsPanel.prototype.updateModifiedNodes):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb.selectCrumbFunction):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
(WebInspector.ElementsPanel.prototype.updateStyles):
(WebInspector.ElementsPanel.prototype.updateMetrics):
(WebInspector.ElementsPanel.prototype.updateProperties):
(WebInspector.ElementsPanel.prototype.updateEventListeners):
(WebInspector.ElementsPanel.prototype.handleCopyEvent):
(WebInspector.ElementsPanel.prototype.updateFocusedNode):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline):
(WebInspector.ElementsTreeOutline.prototype.selectedDOMNode):
(WebInspector.ElementsTreeOutline.prototype.selectDOMNode):
(WebInspector.ElementsTreeOutline.prototype.update):
(WebInspector.ElementsTreeOutline.prototype._revealAndSelectNode):
(WebInspector.ElementsTreeOutline.prototype._ondrop.callback):
(WebInspector.ElementsTreeOutline.prototype._ondrop):
(WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
(WebInspector.ElementsTreeElement.prototype._updateChildren):
(WebInspector.ElementsTreeElement.prototype.onselect):
(WebInspector.ElementsTreeElement.prototype.selectOnMouseDown):
(WebInspector.ElementsTreeElement.prototype._startEditingTarget):
(WebInspector.ElementsTreeElement.prototype._startEditing):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.reset):
* inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileView.prototype._jumpToSearchResult):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._addProfileHeader):
(WebInspector.ProfilesPanel.prototype.showProfile):
(WebInspector.ProfileSidebarTreeElement.prototype.onselect):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._initDefaultSelection.get if):
(WebInspector.ResourcesPanel.prototype._initDefaultSelection):
(WebInspector.ResourcesPanel.prototype.reset):
(WebInspector.ResourcesPanel.prototype.showResource):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._createTopPane):
* inspector/front-end/inspector.js:
* inspector/front-end/inspectorCommon.css:
(body):
* inspector/front-end/treeoutline.js:
(TreeOutline.prototype.revealAndSelect):
(TreeElement.prototype.selectOnMouseDown):
(TreeElement.prototype.revealAndSelect):
(TreeElement.prototype.select):

LayoutTests:

* inspector/console/command-line-api-inspect.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Add HTMLUnknownElement interface as defined in
ossy@webkit.org [Fri, 12 Aug 2011 12:17:09 +0000 (12:17 +0000)]
Source/WebCore: Add HTMLUnknownElement interface as defined in
http://www.w3.org/TR/html5/elements.html#elements-in-the-dom.

https://bugs.webkit.org/show_bug.cgi?id=41841

Unreviewed gardening after r92890.

* platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-12 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 12 Aug 2011 12:06:50 +0000 (12:06 +0000)]
2011-08-12  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Inspector clean-up: remove unused method declaration from InspectorAgent.h

        * inspector/InspectorAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Network resource identifier should have RequestId type and requestId...
vsevik@chromium.org [Fri, 12 Aug 2011 11:44:55 +0000 (11:44 +0000)]
Web Inspector: Network resource identifier should have RequestId type and requestId name in protocol.
https://bugs.webkit.org/show_bug.cgi?id=66061

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::ConsoleMessage):
(WebCore::ConsoleMessage::addToFrontend):
* inspector/ConsoleMessage.h:
* inspector/IdentifiersFactory.cpp:
(WebCore::IdentifiersFactory::requestId):
* inspector/IdentifiersFactory.h:
* inspector/Inspector.json:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::markResourceAsCached):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::didFinishLoading):
(WebCore::InspectorResourceAgent::didFailLoading):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::setInitialScriptContent):
(WebCore::InspectorResourceAgent::didReceiveScriptResponse):
(WebCore::InspectorResourceAgent::setInitialXHRContent):
(WebCore::InspectorResourceAgent::didReceiveXHRResponse):
(WebCore::InspectorResourceAgent::didCreateWebSocket):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorResourceAgent::didCloseWebSocket):
(WebCore::InspectorResourceAgent::getResourceContent):
* inspector/InspectorResourceAgent.h:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::willReceiveResourceData):
(WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
(WebCore::InspectorTimelineAgent::didFinishLoadingResource):
* inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::resourceCreated):
(WebCore::NetworkResourcesData::responseReceived):
(WebCore::NetworkResourcesData::setResourceType):
(WebCore::NetworkResourcesData::resourceType):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::maybeAddResourceData):
(WebCore::NetworkResourcesData::maybeDecodeDataToContent):
(WebCore::NetworkResourcesData::addCachedResource):
(WebCore::NetworkResourcesData::addResourceSharedBuffer):
(WebCore::NetworkResourcesData::data):
(WebCore::NetworkResourcesData::clear):
(WebCore::NetworkResourcesData::ensureNoDataForRequestId):
(WebCore::NetworkResourcesData::ensureFreeSpace):
* inspector/NetworkResourcesData.h:
(WebCore::NetworkResourcesData::ResourceData::requestId):
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createResourceSendRequestData):
(WebCore::TimelineRecordFactory::createResourceReceiveResponseData):
(WebCore::TimelineRecordFactory::createResourceFinishData):
(WebCore::TimelineRecordFactory::createReceiveResourceData):
* inspector/TimelineRecordFactory.h:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded):
* inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI.Resources.prototype.getHAR):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._notifyResourceFinished):
(WebInspector.ExtensionServer.prototype._onGetHAR):
(WebInspector.ExtensionServer.prototype._requestId):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype.requestContent):
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.resourceMarkedAsCached):
(WebInspector.NetworkDispatcher.prototype.responseReceived):
(WebInspector.NetworkDispatcher.prototype.dataReceived):
(WebInspector.NetworkDispatcher.prototype.loadingFinished):
(WebInspector.NetworkDispatcher.prototype.loadingFailed):
(WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
(WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):
(WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):
(WebInspector.NetworkDispatcher.prototype.webSocketClosed):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
(WebInspector.NetworkDispatcher.prototype._startResource):
(WebInspector.NetworkDispatcher.prototype._finishResource):
(WebInspector.NetworkDispatcher.prototype._createResource):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._appendResource):
(WebInspector.NetworkLogView.prototype._matchResource):
(WebInspector.NetworkLogView.prototype._updateSearchMatchedListAfterRequestIdChanged):
(WebInspector.NetworkLogView.prototype.performSearch):
* inspector/front-end/Resource.js:
(WebInspector.Resource):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._addRecordToTimeline):
(WebInspector.TimelinePanel.prototype._findParentRecord):
(WebInspector.TimelinePanel.FormattedRecord):

LayoutTests:

* http/tests/inspector/network/download.html:
* http/tests/inspector/network/x-frame-options-deny.html:
* inspector/timeline/timeline-load.html:
* inspector/timeline/timeline-network-resource-expected.txt:
* inspector/timeline/timeline-network-resource.html:
* inspector/timeline/timeline-test.js:
* platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Add HTMLUnknownElement interface as defined in
ossy@webkit.org [Fri, 12 Aug 2011 10:57:12 +0000 (10:57 +0000)]
Source/WebCore: Add HTMLUnknownElement interface as defined in
http://www.w3.org/TR/html5/elements.html#elements-in-the-dom.

https://bugs.webkit.org/show_bug.cgi?id=41841

Unreviewed gardening after r92890.

* fast/html/unknown-tag-expected.txt: Added.
* platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Updated.
* platform/qt/fast/dom/prototype-inheritance-2-expected.png: Updated.
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt: Updated.
* platform/qt/fast/js/global-constructors-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: Object store records don't need to have keys in all indexes
hans@chromium.org [Fri, 12 Aug 2011 09:32:32 +0000 (09:32 +0000)]
IndexedDB: Object store records don't need to have keys in all indexes
https://bugs.webkit.org/show_bug.cgi?id=66049

Reviewed by Tony Chang.

Source/WebCore:

Allow inserting records in an object store even though they don't
yield keys in some index. The spec has changed in this regard.

* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::putInternal):

LayoutTests:

Update test to make sure it's possible to add an object store record
even though it doesn't yield keys in every index.

* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/index-basics.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: Overwriting key in unique index should be possible
hans@chromium.org [Fri, 12 Aug 2011 08:51:14 +0000 (08:51 +0000)]
IndexedDB: Overwriting key in unique index should be possible
https://bugs.webkit.org/show_bug.cgi?id=65993

Reviewed by Tony Chang.

Source/WebCore:

It should be possible to overwrite an object store record even if
there is a derived key for that record in an index with the unique flag set.

* storage/IDBBackingStore.h:
* storage/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::addingKeyAllowed):
* storage/IDBIndexBackendImpl.h:
* storage/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
* storage/IDBLevelDBBackingStore.h:
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::putInternal):
* storage/IDBSQLiteBackingStore.cpp:
(WebCore::IDBSQLiteBackingStore::keyExistsInIndex):
* storage/IDBSQLiteBackingStore.h:

LayoutTests:

Test that it's possible to overwrite an object store record even if there
is a derived key for that record in an index with the unique flag set.

* storage/indexeddb/index-unique-expected.txt:
* storage/indexeddb/index-unique.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Fix after r91815 - restore changes from r91659.
commit-queue@webkit.org [Fri, 12 Aug 2011 07:52:24 +0000 (07:52 +0000)]
[EFL] Fix after r91815 - restore changes from r91659.
https://bugs.webkit.org/show_bug.cgi?id=64682

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-12
Reviewed by Kenneth Rohde Christiansen.

Restore patch for fix ewk_view_context_menu_forward_event which
has been overwrititen by mistake.

* ewk/ewk_view.cpp:
(ewk_view_context_menu_forward_event):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] HTML Saving feature.
commit-queue@webkit.org [Fri, 12 Aug 2011 07:46:13 +0000 (07:46 +0000)]
[EFL] HTML Saving feature.
https://bugs.webkit.org/show_bug.cgi?id=55455

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-12
Reviewed by Antonio Gomes.

Gets the source and location of resources for document.
TODO:
1. Support others resources (css, plugins, media files).
2. Currently only HTML documents are supported.

* ewk/ewk_frame.cpp:
(ewk_frame_source_get):
(ewk_frame_resources_location_get):
* ewk/ewk_frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebSocket: Implement "protocol" attribute
yutak@chromium.org [Fri, 12 Aug 2011 06:44:53 +0000 (06:44 +0000)]
WebSocket: Implement "protocol" attribute
https://bugs.webkit.org/show_bug.cgi?id=65248

Reviewed by Kent Tamura.

Source/WebCore:

Tests: http/tests/websocket/tests/hybi/no-subprotocol.html (added)
       http/tests/websocket/tests/hybi/set-protocol.html (added)
       http/tests/websocket/tests/hybi/workers/no-subprotocol.html (added)
       http/tests/websocket/tests/hixie76/undefined-attributes.html (updated)
       http/tests/websocket/tests/hybi/multiple-subprotocols.html (updated)
       http/tests/websocket/tests/hybi/workers/multiple-subprotocols.html (updated)

* websockets/ThreadableWebSocketChannel.h:
Added subprotocol() function. This function is named differently from the counterpart of
WebSocket class, because the name "protocol" can be confused with the WebSocket protocol.
Added m_useHixie76Protocol and m_subprotocol, because these value may be used after
m_channel has been released. Using bool should be fine, because boolean literals do not
appear in ambiguous context.
* websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::subprotocol):
(WebCore::ThreadableWebSocketChannelClientWrapper::setSubprotocol):
* websockets/ThreadableWebSocketChannelClientWrapper.h:
* websockets/WebSocket.cpp:
(WebCore::WebSocket::WebSocket):
(WebCore::WebSocket::connect):
(WebCore::WebSocket::protocol):
The "protocol" attribute is available only when the hybi-10 protocol is chosen.
(WebCore::WebSocket::binaryType):
(WebCore::WebSocket::setBinaryType):
(WebCore::WebSocket::didConnect):
* websockets/WebSocket.h:
* websockets/WebSocket.idl:
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::subprotocol):
* websockets/WebSocketChannel.h:
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::subprotocol):
(WebCore::workerContextDidConnect):
Subprotocol value is saved in the client wrapper object after the WebSocket connection is
established.
(WebCore::WorkerThreadableWebSocketChannel::Peer::didConnect):
* websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

* http/tests/websocket/tests/hixie76/undefined-attributes-expected.txt:
* http/tests/websocket/tests/hixie76/undefined-attributes.html:
Added a test to check "protocol" attribute.
* http/tests/websocket/tests/hybi/multiple-subprotocols-expected.txt:
* http/tests/websocket/tests/hybi/multiple-subprotocols.html:
The attribute should return an empty string at first. After the connection is established,
it should return the value of Sec-WebSocket-Protocol header in the server's handshake response.
* http/tests/websocket/tests/hybi/no-subprotocol-expected.txt: Added.
* http/tests/websocket/tests/hybi/no-subprotocol.html: Added.
* http/tests/websocket/tests/hybi/set-protocol-expected.txt: Added.
* http/tests/websocket/tests/hybi/set-protocol.html: Added.
* http/tests/websocket/tests/hybi/workers/multiple-subprotocols-expected.txt:
* http/tests/websocket/tests/hybi/workers/no-subprotocol-expected.txt: Added.
* http/tests/websocket/tests/hybi/workers/no-subprotocol.html: Added.
* http/tests/websocket/tests/hybi/workers/resources/multiple-subprotocols.js:
(ws.onopen):
(ws.onclose):
(checkAfterOnClose):
* http/tests/websocket/tests/hybi/workers/resources/no-subprotocol.js: Added.
(ws.onopen):
(ws.onclose):
(checkAfterOnClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium][DRT] editing/spelling/spelling-backspace-between-lines.html fails
morrita@google.com [Fri, 12 Aug 2011 05:38:41 +0000 (05:38 +0000)]
[Chromium][DRT] editing/spelling/spelling-backspace-between-lines.html fails
https://bugs.webkit.org/show_bug.cgi?id=45438

Reviewed by Kent Tamura.

Tools:

MockSpellCheck was assuming the input of spellCheckWord() is a word.
But it can be a series of word. This change made spellCheckWord()
understand simple word boundary which appears in tests.

* DumpRenderTree/chromium/MockSpellCheck.cpp:
(MockSpellCheck::spellCheckWord):

LayoutTests:

Added a chromium specific expectation because chromium will use window's (wrong) expectation
unless chromium has its own.

* platform/chromium/editing/spelling/spelling-backspace-between-lines-expected.txt: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement proper handling of events with a related target in regard to shadow DOM...
hayato@chromium.org [Fri, 12 Aug 2011 05:18:28 +0000 (05:18 +0000)]
Implement proper handling of events with a related target in regard to shadow DOM boundaries.
https://bugs.webkit.org/show_bug.cgi?id=65899

Reviewed by Dimitri Glazkov.

Fixes issues in the following corner cases:
1. When both a target node and a relatedTarget node are immediate children of
the same shadow root, an event is not dispatched.
2. If a target node is an ancestor of a relatedTarget node, crossing
shadow boundaries, or vice verse, an event is not dispatched or wrongly
dispatched.

Source/WebCore:

Test: fast/dom/shadow/shadow-boundary-events.html

* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::adjustToShadowBoundaries):

LayoutTests:

* fast/dom/shadow/shadow-boundary-crossing-expected.txt: Renamed from LayoutTests/fast/events/shadow-boundary-crossing-expected.txt.
* fast/dom/shadow/shadow-boundary-crossing.html: Renamed from LayoutTests/fast/events/shadow-boundary-crossing.html.
* fast/dom/shadow/shadow-boundary-events-expected.txt: Added.
* fast/dom/shadow/shadow-boundary-events.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVectorArgumentCoder doesn't encode/decode enough data for more than one byte vector...
commit-queue@webkit.org [Fri, 12 Aug 2011 04:16:55 +0000 (04:16 +0000)]
VectorArgumentCoder doesn't encode/decode enough data for more than one byte vector elements
https://bugs.webkit.org/show_bug.cgi?id=66109

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-08-11
Reviewed by Anders Carlsson.

Multiply vector size by element size in encode/decode to get correct byte size of vector data.

* Platform/CoreIPC/ArgumentCoders.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG JIT-specific structure stub info code offset fields are signed
fpizlo@apple.com [Fri, 12 Aug 2011 04:09:42 +0000 (04:09 +0000)]
DFG JIT-specific structure stub info code offset fields are signed
8-bit, but it is possible for the offsets to be greater than 127
https://bugs.webkit.org/show_bug.cgi?id=66122

Reviewed by Gavin Barraclough.

* bytecode/StructureStubInfo.h:
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG JIT speculation failure code sometimes picks the wrong register
fpizlo@apple.com [Fri, 12 Aug 2011 03:41:48 +0000 (03:41 +0000)]
DFG JIT speculation failure code sometimes picks the wrong register
as a scratch register.
https://bugs.webkit.org/show_bug.cgi?id=66104

Reviewed by Gavin Barraclough.

Hardened the code with more assertions and fixed the bug.  Now a
spilled register is only used for scratch if it also isn't being
used for shuffling.

* dfg/DFGJITCompiler.cpp:
(JSC::DFG::ShuffledRegister::handleNonCyclingPermutation):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReadback composited webgl results for printing
commit-queue@webkit.org [Fri, 12 Aug 2011 03:32:16 +0000 (03:32 +0000)]
Readback composited webgl results for printing
https://bugs.webkit.org/show_bug.cgi?id=65658

Patch by John Bauman <jbauman@chromium.org> on 2011-08-11
Reviewed by James Robinson.

Source/WebCore:

The real composited results may be locked inside the compositor
context's version of a texture because the drawing buffer was
automatically cleared, so read from there to get the actual presented
version to draw.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/chromium/Extensions3DChromium.h:
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas):
* platform/graphics/chromium/WebGLLayerChromium.h:
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):

Source/WebKit/chromium:

Add support for reading from the composited version of a canvas.

* public/WebGraphicsContext3D.h:
* src/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::paintFramebufferToCanvas):
* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::paintFramebufferToCanvas):
(WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DInternal::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3DInternal::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3DInternal::reshape):
* src/GraphicsContext3DInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION: Qt JavaScript bridge signal connection fails
commit-queue@webkit.org [Fri, 12 Aug 2011 03:14:32 +0000 (03:14 +0000)]
REGRESSION: Qt JavaScript bridge signal connection fails
https://bugs.webkit.org/show_bug.cgi?id=66097

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-08-11
Reviewed by Gavin Barraclough.

Source/WebCore:

Tests in WebKit/qt/tests/qwebframe

Call toThisObject() on exec->lexicalGlobalObject() so the correct
object is passed to the JS signal handler.

* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeConnectionMethod::call):

Source/WebKit/qt:

Unmark tests as expected failures, they pass now.

* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::connectAndDisconnect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove incorrect comment about m_wheelEventHandlerCount
thakis@chromium.org [Fri, 12 Aug 2011 03:00:05 +0000 (03:00 +0000)]
Remove incorrect comment about m_wheelEventHandlerCount
https://bugs.webkit.org/show_bug.cgi?id=66117

Reviewed by Simon Fraser.

From what I can tell, this number is changed only in
Frame::notifyChromeClientWheelEventHandlerCountChanged(),
and there it just reads the number modified in
Document::didAdd/RemoveWheelEventHandler(). So this is just the number
of event handlers (and not related to horizontal scrollbars), and the
variable name expresses that already.

Source/WebCore:

* dom/Document.h:

Source/WebKit2:

* UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVersioning.
mrowe@apple.com [Fri, 12 Aug 2011 02:54:18 +0000 (02:54 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r92880.
commit-queue@webkit.org [Fri, 12 Aug 2011 02:48:06 +0000 (02:48 +0000)]
Unreviewed, rolling out r92880.
http://trac.webkit.org/changeset/92880
https://bugs.webkit.org/show_bug.cgi?id=66123

Breaks compile in VS2010 (Requested by jamesr_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-11

* wtf/PassRefPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix sunspider-compare-results to default to the same suite version as the sunspider...
mrowe@apple.com [Fri, 12 Aug 2011 02:11:26 +0000 (02:11 +0000)]
Fix sunspider-compare-results to default to the same suite version as the sunspider script.

Rubber-stamped by Maciej Stachowiak.

* sunspider-compare-results:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't conditionalize the use of -fomit-frame-pointer on compiler version as
mrowe@apple.com [Fri, 12 Aug 2011 02:11:22 +0000 (02:11 +0000)]
Don't conditionalize the use of -fomit-frame-pointer on compiler version as
all of our supported compilers are now new enough to have the same, sane behavior.

Rubber-stamped by Sam Weinig.

* Configurations/JavaScriptCore.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Defer managed texture creation and destruction until updateCompositorResources
commit-queue@webkit.org [Fri, 12 Aug 2011 02:07:24 +0000 (02:07 +0000)]
[chromium] Defer managed texture creation and destruction until updateCompositorResources
https://bugs.webkit.org/show_bug.cgi?id=64772

Patch by James Robinson <jamesr@chromium.org> on 2011-08-11
Reviewed by Kenneth Russell.

This adds support for deferring GraphicsContext3D calls for texture creation and destruction for managed
textures and defers these calls until updateCompositorResources() for contents textures.  The primary benefit of
this change is that it decouples managing the texture budget for the next frame (which has to happen before
painting layer contents) from the actual GL calls that create/destroy textures.  That way, in the threaded
compositing world we can continue to use textures from the previous frame while software painting contents for
the next frame into software buffers or SkPictures.

Also renames LayerTexture to ManagedTexture to better reflect what it is.  Not all ManagedTextures we create are
necessarily associated with layers, but they are all managed by a TextureManager.

Covered by compositing/ layout tests.

* WebCore.gypi:
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::updateTextureRect):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::releaseTextures):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::getOffscreenLayerTexture):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::initializeSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/LayerTextureUpdater.h:
* platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
(WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
* platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::getSingleTexture):
(WebCore::LayerTilerChromium::createTile):
(WebCore::LayerTilerChromium::updateRect):
(WebCore::LayerTilerChromium::drawTiles):
* platform/graphics/chromium/LayerTilerChromium.h:
(WebCore::LayerTilerChromium::Tile::Tile):
(WebCore::LayerTilerChromium::Tile::texture):
* platform/graphics/chromium/ManagedTexture.cpp: Renamed from Source/WebCore/platform/graphics/chromium/LayerTexture.cpp.
(WebCore::ManagedTexture::ManagedTexture):
(WebCore::ManagedTexture::~ManagedTexture):
(WebCore::ManagedTexture::isValid):
(WebCore::ManagedTexture::reserve):
(WebCore::ManagedTexture::unreserve):
(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):
* platform/graphics/chromium/ManagedTexture.h: Renamed from Source/WebCore/platform/graphics/chromium/LayerTexture.h.
(WebCore::ManagedTexture::create):
(WebCore::ManagedTexture::format):
(WebCore::ManagedTexture::isReserved):
* platform/graphics/chromium/RenderSurfaceChromium.h:
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::TextureManager):
(WebCore::TextureManager::deleteEvictedTextures):
(WebCore::TextureManager::removeTexture):
(WebCore::TextureManager::allocateTexture):
(WebCore::TextureManager::requestTexture):
* platform/graphics/chromium/TextureManager.h:
(WebCore::TextureManager::create):
(WebCore::TextureManager::setAssociatedContextDebugOnly):
(WebCore::TextureManager::associatedContextDebugOnly):
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::prepareContentsTexture):
(WebCore::CCRenderSurface::drawSurface):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore::CCRenderSurface::contentsTexture):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::bindContentsTexture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/66113> [CFNetwork] willCacheResponse() leaks CFCachedURLResponse...
ddkilzer@apple.com [Fri, 12 Aug 2011 00:52:28 +0000 (00:52 +0000)]
<webkit.org/b/66113> [CFNetwork] willCacheResponse() leaks CFCachedURLResponseRef if delegate changes CacheStoragePolicy

Reviewed by Joseph Pecoraro.

This first appeared in ToT WebKit r23462 (Windows merge).

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willCacheResponse): Only retain cachedResponse if we
are returning the same object passed into the method, otherwise
we end up double-retaining the new object created.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRework some Makefile logic to remove a double-negative.
mrowe@apple.com [Fri, 12 Aug 2011 00:45:08 +0000 (00:45 +0000)]
Rework some Makefile logic to remove a double-negative.

Reviewed by Jon Honeycutt.

* DumpRenderTree/mac/PerlSupport/Makefile:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Make WebViewImpl point at CCLayerTreeHost and related separation
nduca@chromium.org [Fri, 12 Aug 2011 00:22:52 +0000 (00:22 +0000)]
[chromium] Make WebViewImpl point at CCLayerTreeHost and related separation
https://bugs.webkit.org/show_bug.cgi?id=65791

With this patch, LayerRendererChromium becomes increasingly responsible
for rendering, while render scheduling and tree hosting moves into the
CCLayerTreeHost.

Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::releaseTextures):
(WebCore::LayerRendererChromium::updateRootLayerContents):
(WebCore::LayerRendererChromium::drawRootLayer):
(WebCore::LayerRendererChromium::invalidateRootLayerRect):
(WebCore::LayerRendererChromium::rootLayerChanged):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::getFramebufferPixels):
(WebCore::LayerRendererChromium::getOffscreenLayerTexture):
(WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::setScissorToRect):
(WebCore::LayerRendererChromium::layerTreeAsText):
(WebCore::LayerRendererChromium::dumpRenderSurfaces):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::settings):
(WebCore::LayerRendererChromium::owner):
(WebCore::LayerRendererChromium::rootLayer):
(WebCore::LayerRendererChromium::skiaContext):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::setTextureUpdated):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
(WebCore::CCHeadsUpDisplay::enabled):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::create):
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::animateAndLayout):
(WebCore::CCLayerTreeHost::createLayerTreeHostCommitter):
(WebCore::CCLayerTreeHost::createLayerTreeHostImpl):
(WebCore::CCLayerTreeHost::context):
(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::createRootLayerPainter):
(WebCore::CCLayerTreeHost::finishAllRendering):
(WebCore::CCLayerTreeHost::invalidateRootLayerRect):
(WebCore::CCLayerTreeHost::setNeedsCommitAndRedraw):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
(WebCore::CCLayerTreeHost::setRootLayer):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::doComposite):
(WebCore::CCLayerTreeHost::composite):
(WebCore::CCLayerTreeHost::reallocateRenderer):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::animating):
(WebCore::CCLayerTreeHost::setAnimating):
(WebCore::CCLayerTreeHost::rootLayer):
(WebCore::CCLayerTreeHost::settings):
(WebCore::CCLayerTreeHost::viewportContentRect):
(WebCore::CCLayerTreeHost::viewportScrollPosition):
(WebCore::CCLayerTreeHost::viewportVisibleRect):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::create):
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::drawLayersOnMainThread):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:
(WebCore::CCLayerTreeHostImplProxy::initImplOnCCThread):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::doPixelReadbackToCanvas):
(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::setRootPlatformLayer):
(WebKit::WebViewImpl::setRootLayerNeedsDisplay):
(WebKit::WebViewImpl::scrollRootLayerRect):
(WebKit::WebViewImpl::invalidateRootLayerRect):
(WebKit::getCompositorSettings):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::createRootLayerPainter):
(WebKit::WebViewImpl::animateAndLayout):
(WebKit::WebViewImpl::didRecreateGraphicsContext):
(WebKit::WebViewImpl::scheduleComposite):
(WebKit::WebViewImpl::updateLayerTreeViewport):
(WebKit::WebViewImpl::graphicsContext3D):
(WebKit::WebViewImpl::setVisibilityState):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92895 268f45cc-cd09-0410-ab3c-d52691b4dbfc