WebKit-https.git
9 years agoVersioning.
lforschler@apple.com [Wed, 21 Dec 2011 22:50:14 +0000 (22:50 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Mark color-prop-05-t.svg as failing after r103427
enne@google.com [Wed, 21 Dec 2011 22:47:17 +0000 (22:47 +0000)]
[chromium] Mark color-prop-05-t.svg as failing after r103427
https://bugs.webkit.org/show_bug.cgi?id=75042

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAlways reposition the scrollbar layers when the frame view size changes
andersca@apple.com [Wed, 21 Dec 2011 22:46:56 +0000 (22:46 +0000)]
Always reposition the scrollbar layers when the frame view size changes
https://bugs.webkit.org/show_bug.cgi?id=75035

Reviewed by Darin Adler.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
Remove the layersChanged check and unconditionally call positionScrollbarLayers(). This only
worked by accident before because we were recreating horizontal and vertical scrollbars on every call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Add 'Select All' option to context menus in WebKit-EFL.
commit-queue@webkit.org [Wed, 21 Dec 2011 22:43:58 +0000 (22:43 +0000)]
[EFL] Add 'Select All' option to context menus in WebKit-EFL.
https://bugs.webkit.org/show_bug.cgi?id=74920

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2011-12-21
Reviewed by Eric Seidel.

Enable 'Select All' option to context menus called on input fields in WebKit-EFL
as it is enabled in GTK and QT ports.

Source/WebCore:

* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected): Add 'Select All' option.
(WebCore::ContextMenuController::populate): Append 'Select All' item.
(WebCore::ContextMenuController::checkOrEnableIfNeeded): Enable 'Select All' option.
* platform/ContextMenuItem.h: Add 'Select All' option.
* platform/LocalizationStrategy.h: Add constructor for 'Select All' option.
* platform/LocalizedStrings.h: Add constructor for 'Select All' option.

Source/WebKit/efl:

* ewk/ewk_contextmenu.h: Add new context menu option 'Select All'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake calls to willModifyAttribute and attributeChanged symmetrical
adamk@chromium.org [Wed, 21 Dec 2011 22:34:29 +0000 (22:34 +0000)]
Make calls to willModifyAttribute and attributeChanged symmetrical
https://bugs.webkit.org/show_bug.cgi?id=74987

Reviewed by Ryosuke Niwa.

Previously, calls to Element::willModifyAttribute sometimes happened
in one method while calls to Element::attributeChanged happened in
another. This change makes them symmetrical for all the cases I know
about: setAttribute, removeAttribute, setNamedItem, removeNamedItem.

To accomplish this, NamedNodeMap::addAttribute, removeAttribute, and
replaceAttribute have been reduced to their pure functionality of
manipulating m_attributes, and their callers are left responsible for
properly notifying the Element of the underlying changes.

One other bit of refactoring was done: to simplify
Element::setAttribute, it now dispatches to
Element::removeAttributeInternal if the incoming value is null.

No new tests, no change in behavior.

* dom/Attribute.h:
* dom/Element.cpp:
(WebCore::Element::removeAttribute):
(WebCore::Element::removeAttributeInternal): Added, sharing code
between the two removeAttribute overloads.
(WebCore::Element::setAttributeInternal):
* dom/Element.h:
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::setNamedItem):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::addAttribute):
(WebCore::NamedNodeMap::removeAttribute):
(WebCore::NamedNodeMap::replaceAttribute):
* svg/properties/SVGAnimatedPropertySynchronizer.h:
Call Element::setAttribute unless the attribute is already present,
and add a comment explaining why the code looks the way it does.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Mark more Mac compositing tests as flaky
enne@google.com [Wed, 21 Dec 2011 22:29:39 +0000 (22:29 +0000)]
[chromium] Mark more Mac compositing tests as flaky
https://bugs.webkit.org/show_bug.cgi?id=47949

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r103408.
enne@google.com [Wed, 21 Dec 2011 22:08:44 +0000 (22:08 +0000)]
Unreviewed, rolling out r103408.
http://trac.webkit.org/changeset/103408
https://bugs.webkit.org/show_bug.cgi?id=75017

WorkerDevToolsSanityTest.InspectSharedWorker is failing
(Requested by loislo_ on #webkit).

Source/WebCore:

* inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype.sources):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMap):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.setCompilerSourceMapping):
* inspector/front-end/utilities.js:
(String.prototype.asParsedURL):

LayoutTests:

* http/tests/inspector/compiler-source-mapping-expected.txt:
* http/tests/inspector/compiler-source-mapping.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Fix CSS filters crash on zero-sized elements.
senorblanco@chromium.org [Wed, 21 Dec 2011 21:40:37 +0000 (21:40 +0000)]
Source/WebCore: Fix CSS filters crash on zero-sized elements.
https://bugs.webkit.org/show_bug.cgi?id=75020

Reviewed by Dean Jackson.

Test: css3/filters/filter-empty-element-crash.html

* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::inputContext):
Protect against null ImageBuffer.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayer):
Protect against null GraphicsContext.

LayoutTests: Test for CSS filters crash on zero-sized element
https://bugs.webkit.org/show_bug.cgi?id=75020

Reviewed by Dean Jackson.

* css3/filters/filter-empty-element-crash-expected.txt: Added.
* css3/filters/filter-empty-element-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: suppress incremental rendering and use application chrome mode
timothy@apple.com [Wed, 21 Dec 2011 21:21:41 +0000 (21:21 +0000)]
Web Inspector: suppress incremental rendering and use application chrome mode

https://webkit.org/b/75026

Reviewed by Joseph Pecoraro.

Source/WebKit/mac:

* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController init]): Sort the preferences, remove the Leopard font family setting,
set suppress incremental rendering and use application chrome mode.

Source/WebKit2:

* UIProcess/WebInspectorProxy.cpp:
(WebKit::createInspectorPageGroup): Set suppress incremental rendering and use application chrome mode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInform the scrolling coordinator when scrollbar layers come and go
andersca@apple.com [Wed, 21 Dec 2011 21:01:43 +0000 (21:01 +0000)]
Inform the scrolling coordinator when scrollbar layers come and go
https://bugs.webkit.org/show_bug.cgi?id=75028

Reviewed by Andreas Kling and Simon Fraser.

* page/ScrollingCoordinator.h:
* page/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinator::setFrameViewHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinator::setFrameViewVerticalScrollbarLayer):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: [Chromium] DatabaseTrackerChromium: iterating DatabaseSet races with...
dslomov@google.com [Wed, 21 Dec 2011 20:27:37 +0000 (20:27 +0000)]
Source/WebCore: [Chromium] DatabaseTrackerChromium: iterating DatabaseSet races with Database disposal on worker thread
https://bugs.webkit.org/show_bug.cgi?id=74554

Reviewed by David Levin.

Covered by existing tests in fast/workers/storage.

* storage/chromium/DatabaseTrackerChromium.cpp:
(WebCore::NotifyDatabaseObserverOnCloseTask::create):
(WebCore::NotifyDatabaseObserverOnCloseTask::performTask):
(WebCore::NotifyDatabaseObserverOnCloseTask::isCleanupTask):
(WebCore::NotifyDatabaseObserverOnCloseTask::NotifyDatabaseObserverOnCloseTask):
(WebCore::DatabaseTracker::removeOpenDatabase):

LayoutTests: [Chromium] DatabaseTrackerChromium: iterating DatabaseSet races with Database disposal on worker thread.
https://bugs.webkit.org/show_bug.cgi?id=74554

Reviewed by David Levin.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHTMLMediaElement::configureTextTrackDisplay is unnecessary
eric.carlson@apple.com [Wed, 21 Dec 2011 20:09:54 +0000 (20:09 +0000)]
HTMLMediaElement::configureTextTrackDisplay is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=74945

Reviewed by Darin Adler.

Nothing to test, just removing redundant code. Correct behavior tested by
media/track/track-cue-rendering.html and media/track/track-cue-nothing-to-render.html.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::configureTextTrackDisplay): Don't show and hide track, just call
    updateTextTrackDisplay and it will do the right thing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-12-21 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 21 Dec 2011 20:09:18 +0000 (20:09 +0000)]
2011-12-21  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Rebaseline pixel test results, which have < 0.011 diffs on my 64bit SL machine.
        This is a preparation, to build a new baseline with Lion.

        * platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-26-t-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-44-t-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/interact-order-01-b-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/interact-order-02-b-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-15-t-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
        * platform/mac-snowleopard/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
        * platform/mac-snowleopard/svg/carto.net/selectionlist-expected.png:
        * platform/mac-snowleopard/svg/css/composite-shadow-example-expected.png:
        * platform/mac-snowleopard/svg/css/composite-shadow-with-opacity-expected.png:
        * platform/mac-snowleopard/svg/dom/SVGStringList-basics-expected.png:
        * platform/mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png:
        * platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
        * platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
        * platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
        * platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
        * platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
        * platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
        * platform/mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
        * platform/mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
        * platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
        * platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
        * platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
        * platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
        * platform/mac-snowleopard/svg/filters/feLighting-crash-expected.png:
        * platform/mac-snowleopard/svg/filters/feOffset-expected.png:
        * platform/mac-snowleopard/svg/filters/filter-on-tspan-expected.png:
        * platform/mac-snowleopard/svg/wicd/rightsizing-grid-expected.png:
        * platform/mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
        * platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
        * platform/mac/svg/as-background-image/svg-as-background-1-expected.png:
        * platform/mac/svg/as-background-image/svg-as-background-3-expected.png:
        * platform/mac/svg/as-background-image/svg-as-background-5-expected.png:
        * platform/mac/svg/as-background-image/svg-as-background-6-expected.png:
        * platform/mac/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
        * platform/mac/svg/as-image/animated-svg-as-image-expected.png:
        * platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
        * platform/mac/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
        * platform/mac/svg/as-image/same-image-two-instances-expected.png:
        * platform/mac/svg/as-image/svg-image-change-content-size-expected.png:
        * platform/mac/svg/as-object/object-box-sizing-no-width-height-expected.png:
        * platform/mac/svg/batik/filters/filterRegions-expected.png:
        * platform/mac/svg/batik/masking/maskRegions-expected.png:
        * platform/mac/svg/batik/text/textOnPath2-expected.png:
        * platform/mac/svg/batik/text/textOnPath3-expected.png:
        * platform/mac/svg/batik/text/verticalTextOnPath-expected.png:
        * platform/mac/svg/carto.net/button-expected.png:
        * platform/mac/svg/carto.net/colourpicker-expected.png:
        * platform/mac/svg/carto.net/scrollbar-expected.png:
        * platform/mac/svg/carto.net/slider-expected.png:
        * platform/mac/svg/clip-path/clip-path-child-clipped-expected.png:
        * platform/mac/svg/clip-path/clip-path-childs-clipped-expected.png:
        * platform/mac/svg/clip-path/clip-path-clipped-expected.png:
        * platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.png:
        * platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.png:
        * platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.png:
        * platform/mac/svg/clip-path/clip-path-on-g-expected.png:
        * platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.png:
        * platform/mac/svg/clip-path/clip-path-on-svg-expected.png:
        * platform/mac/svg/clip-path/clip-path-use-as-child-expected.png:
        * platform/mac/svg/clip-path/clip-path-use-as-child2-expected.png:
        * platform/mac/svg/clip-path/clip-path-use-as-child3-expected.png:
        * platform/mac/svg/clip-path/clip-path-use-as-child4-expected.png:
        * platform/mac/svg/css/circle-in-mask-with-shadow-expected.png:
        * platform/mac/svg/css/composite-shadow-text-expected.png:
        * platform/mac/svg/css/mask-with-shadow-expected.png:
        * platform/mac/svg/custom/absolute-sized-content-with-resources-expected.png:
        * platform/mac/svg/custom/dasharrayOrigin-expected.png:
        * platform/mac/svg/custom/embedding-external-svgs-expected.png:
        * platform/mac/svg/custom/feComponentTransfer-Discrete-expected.png:
        * platform/mac/svg/custom/feComponentTransfer-Gamma-expected.png:
        * platform/mac/svg/custom/feComponentTransfer-Linear-expected.png:
        * platform/mac/svg/custom/feComponentTransfer-Table-expected.png:
        * platform/mac/svg/custom/fill-opacity-update-expected.png:
        * platform/mac/svg/custom/fractional-rects-expected.png:
        * platform/mac/svg/custom/gradient-rotated-bbox-expected.png:
        * platform/mac/svg/custom/grayscale-gradient-mask-2-expected.png:
        * platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
        * platform/mac/svg/custom/invalid-css-expected.png:
        * platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.png:
        * platform/mac/svg/custom/js-late-clipPath-creation-expected.png:
        * platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
        * platform/mac/svg/custom/js-late-pattern-creation-expected.png:
        * platform/mac/svg/custom/linking-uri-01-b-expected.png:
        * platform/mac/svg/custom/mouse-move-on-svg-container-expected.png:
        * platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
        * platform/mac/svg/custom/nested-pattern-boundingBoxModeContent-expected.png:
        * platform/mac/svg/custom/non-scaling-stroke-expected.png:
        * platform/mac/svg/custom/pattern-in-defs-expected.png:
        * platform/mac/svg/custom/pattern-rotate-expected.png:
        * platform/mac/svg/custom/pattern-rotate-gaps-expected.png:
        * platform/mac/svg/custom/pattern-skew-transformed-expected.png:
        * platform/mac/svg/custom/pattern-with-transformation-expected.png:
        * platform/mac/svg/custom/rounded-rects-expected.png:
        * platform/mac/svg/custom/simple-text-double-shadow-expected.png:
        * platform/mac/svg/custom/svg-fonts-in-html-expected.png:
        * platform/mac/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Copied from svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png.
        * platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png:
        * platform/mac/svg/filters/filter-rounding-issues-expected.png:
        * platform/mac/svg/hixie/cascade/002-expected.png:
        * platform/mac/svg/hixie/perf/001-expected.png:
        * platform/mac/svg/hixie/perf/002-expected.png:
        * platform/mac/svg/hixie/perf/007-expected.png:
        * platform/mac/svg/hixie/transform/001-expected.png:
        * platform/mac/svg/text/select-textLength-spacing-squeeze-1-expected.png:
        * platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.png:
        * platform/mac/svg/text/select-textLength-spacing-squeeze-3-expected.png:
        * platform/mac/svg/text/select-textLength-spacing-squeeze-4-expected.png:
        * platform/mac/svg/text/select-textLength-spacing-stretch-1-expected.png:
        * platform/mac/svg/text/select-textLength-spacing-stretch-2-expected.png:
        * platform/mac/svg/text/select-textLength-spacing-stretch-3-expected.png:
        * platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png:
        * platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png:
        * platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png:
        * platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
        * platform/mac/svg/text/selection-styles-expected.png:
        * platform/mac/svg/text/small-fonts-3-expected.png:
        * platform/mac/svg/text/text-align-03-b-expected.png:
        * platform/mac/svg/text/text-path-01-b-expected.png:
        * platform/mac/svg/text/text-text-05-t-expected.png:
        * platform/mac/svg/text/textPathBoundsBug-expected.png:
        * platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
        * platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.png:
        * platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
        * platform/mac/svg/webarchive/svg-feimage-subresources-expected.png:
        * platform/mac/svg/wicd/test-scalable-background-image2-expected.png:
        * platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
        * platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
        * platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
        * platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
        * platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
        * platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
        * platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
        * svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoScrollingCoordinator functions should take FrameView objects
andersca@apple.com [Wed, 21 Dec 2011 19:52:57 +0000 (19:52 +0000)]
ScrollingCoordinator functions should take FrameView objects
https://bugs.webkit.org/show_bug.cgi?id=75023

Reviewed by Sam Weinig.

* page/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::syncFrameViewGeometry):
* page/ScrollingCoordinator.h:
* page/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinator::setFrameViewScrollLayer):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
(WebCore::RenderLayerCompositor::ensureRootLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGet rid of ScrollableAreaClient
andersca@apple.com [Wed, 21 Dec 2011 19:41:12 +0000 (19:41 +0000)]
Get rid of ScrollableAreaClient
https://bugs.webkit.org/show_bug.cgi?id=75021

Reviewed by Sam Weinig.

The ScrollableAreaClient interface will just add an extra level of indirection between ScrollableArea and
ScrollAnimator, which is unnecessary. Eventually I'd like to rename ScrollAnimator to something that better reflects
all the different responsibilities it currently has.

* WebCore.exp.in:
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
* page/ScrollingCoordinator.cpp:
* page/ScrollingCoordinator.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::ScrollView):
* platform/ScrollView.h:
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::ScrollableArea):
* platform/ScrollableArea.h:
* platform/ScrollableAreaClient.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't recreate scrollbar layers whenever the frame view size changes
andersca@apple.com [Wed, 21 Dec 2011 19:28:55 +0000 (19:28 +0000)]
Don't recreate scrollbar layers whenever the frame view size changes
https://bugs.webkit.org/show_bug.cgi?id=75018

Reviewed by Darin Adler and Simon Fraser.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExtract WinCE CMake arguments from build-webkit into separate function
dbates@webkit.org [Wed, 21 Dec 2011 19:09:43 +0000 (19:09 +0000)]
Extract WinCE CMake arguments from build-webkit into separate function
https://bugs.webkit.org/show_bug.cgi?id=74983

Reviewed by Rob Buis.

Towards adding support for using Tools/Scripts/build-jsc for the WinCE port, extract the
WinCE-specific CMake argument from Tools/Scripts/build-webkit into webkitdirs::cmakeBasedPortArguments().
This will allow us to get the WinCE-specific CMake argument in Tools/Scripts/build-jsc so
that we can pass it to the CMake build system when building JavaScriptCore.

* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
(cmakeBasedPortArguments): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd CMake option to only build JavaScriptCore
dbates@webkit.org [Wed, 21 Dec 2011 19:05:26 +0000 (19:05 +0000)]
Add CMake option to only build JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=74979

Reviewed by Rob Buis.

Towards adding CMake support to script Tools/Scripts/build-jsc, add a CMake
option to only build JavaScriptCore.

* CMakeLists.txt: Defined ENABLE_WEBCORE to build WebCore. If the option
ONLY_BUILD_JAVASCRIPTCORE is specified then don't build WebCore, WebKit, or WebKit2.
* Source/CMakeLists.txt:
* Source/cmake/WebKitFS.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCleanup up clients when deallocating WebKit2 API objects
weinig@apple.com [Wed, 21 Dec 2011 18:43:48 +0000 (18:43 +0000)]
Cleanup up clients when deallocating WebKit2 API objects
https://bugs.webkit.org/show_bug.cgi?id=75014

Reviewed by Adam Roben.

* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController dealloc]):
* UIProcess/API/mac/WKConnection.mm:
(-[WKConnection dealloc]):
Clear clients on dealloc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Add tests for favicon and fix icon url decoding issue
commit-queue@webkit.org [Wed, 21 Dec 2011 18:21:58 +0000 (18:21 +0000)]
[Qt][WK2] Add tests for favicon and fix icon url decoding issue
https://bugs.webkit.org/show_bug.cgi?id=74967

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2011-12-21
Reviewed by Simon Hausmann.

* UIProcess/API/qt/qwebiconimageprovider.cpp: We already receive the url
without the percent encoding and we should access WebIconDatabase with
an encoded url. Added a test to cover this behavior.
(QWebIconImageProvider::requestImage):
* UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml: Added.
* UIProcess/API/qt/tests/qmltests/common/favicon.html: Added.
* UIProcess/API/qt/tests/qmltests/common/favicon.png: Added.
* UIProcess/API/qt/tests/qmltests/common/favicon2.html: Added.
* UIProcess/API/qt/tests/qmltests/common/small-favicon.png: Added.
* UIProcess/API/qt/tests/qmltests/qmltests.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoException thrown when running WKBrowsingContextLoadDelegateTest.SimpleLoad test
weinig@apple.com [Wed, 21 Dec 2011 18:19:08 +0000 (18:19 +0000)]
Exception thrown when running WKBrowsingContextLoadDelegateTest.SimpleLoad test
https://bugs.webkit.org/show_bug.cgi?id=75012

Reviewed by Adam Roben.

* UIProcess/API/mac/WKProcessGroup.mm:
(-[WKProcessGroup dealloc]):
Clear the WKContext's connection client.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Extension API] refactor extension API build code, expose experimental...
caseq@chromium.org [Wed, 21 Dec 2011 17:20:43 +0000 (17:20 +0000)]
Web Inspector: [Extension API] refactor extension API build code, expose experimental APIs conditionally in chromium
https://bugs.webkit.org/show_bug.cgi?id=74941

Reviewed by Pavel Feldman.

Source/WebCore:

* WebCore.gypi:
* inspector/front-end/ExtensionAPI.js:
(buildPlatformExtensionAPI.platformExtensionAPI):
(buildPlatformExtensionAPI):
(buildExtensionAPIInjectedScript):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._addExtensions):
(WebInspector.ExtensionServer.prototype._addExtension):
(window.addExtension):

Source/WebKit/chromium:

* WebKit.gyp:
* WebKit.gypi:
* scripts/concatenate_js_files.py:
(main):
* scripts/generate_devtools_extension_api.py:
(write_devtools_extension_api):
* src/js/DevTools.js:
():

LayoutTests:

* http/tests/inspector/extensions-test.js:
(initialize_ExtensionsTest.InspectorTest.runExtensionTests):
(initialize_ExtensionsTest):
* platform/chromium/inspector/extensions/extensions-api-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Fix tst_QQuickWebView::scrollRequest() API test
commit-queue@webkit.org [Wed, 21 Dec 2011 17:03:15 +0000 (17:03 +0000)]
[Qt][WK2] Fix tst_QQuickWebView::scrollRequest() API test
https://bugs.webkit.org/show_bug.cgi?id=73994

Patch by Michael Brüning <michael.bruning@nokia.com> on 2011-12-21
Reviewed by Kenneth Rohde Christiansen.

Added a viewport meta tag so that the view is actually scrollable and
does not get scaled to not be scrollable. Corrected the style
definition for the <div> tag. Removed unneeded text in div

Rolled back changes some of the changes from the previous patch
(r102453) because they weren't necessary.

* UIProcess/API/qt/tests/html/scroll.html:
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::scrollRequest): Partially rolled back changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix.
jberlin@webkit.org [Wed, 21 Dec 2011 16:24:52 +0000 (16:24 +0000)]
Windows build fix.

Replace all instances of "WebPropupMenuProxy" with "WebPopupMenuProxy".

* UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::showPopupMenu):
(WebKit::WebPopupMenuProxyWin::setFocusedIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: fix source map url resolving.
podivilov@chromium.org [Wed, 21 Dec 2011 15:48:44 +0000 (15:48 +0000)]
Web Inspector: fix source map url resolving.
https://bugs.webkit.org/show_bug.cgi?id=74305

Reviewed by Pavel Feldman.

Source/WebCore:

Also fix the bug with repeated source urls in mapping sections.

* inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype.sources):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMap):
(WebInspector.ClosureCompilerSourceMapping.prototype._resolveSourceMapURL):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.installCompilerSourceMapping):
* inspector/front-end/utilities.js:
(String.prototype.asParsedURL):

LayoutTests:

* http/tests/inspector/compiler-source-mapping-expected.txt:
* http/tests/inspector/compiler-source-mapping.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNew renderer for SVGRectElement
reni@webkit.org [Wed, 21 Dec 2011 15:28:58 +0000 (15:28 +0000)]
New renderer for SVGRectElement
https://bugs.webkit.org/show_bug.cgi?id=65769

Source/WebCore:

Rubber-stamped by Zoltan Herczeg.

Change the return value of RenderSVGRect::renderName() from RenderSVGPath to RenderSVGRect.
This is a follow-up patch of r101517 to correct the DRT output.

* rendering/svg/RenderSVGRect.h:
(WebCore::RenderSVGRect::renderName):

LayoutTests:

Rubber stamped by Zoltan Herczeg.

Rename the renderer of SVGRects from RenderSVGPath to RenderSVGRect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: TabbedPane should use tabElement width measuring to layout tab element...
vsevik@chromium.org [Wed, 21 Dec 2011 14:38:43 +0000 (14:38 +0000)]
Web Inspector: TabbedPane should use tabElement width measuring to layout tab elements when width is too small to fit them.
https://bugs.webkit.org/show_bug.cgi?id=75005

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/tabbed-pane-max-tab-width-calculation.html

* inspector/front-end/NetworkItemView.js:
(WebInspector.NetworkItemView.prototype.wasShown):
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane):
(WebInspector.TabbedPane.prototype.appendTab):
(WebInspector.TabbedPane.prototype._createTabElement):
(WebInspector.TabbedPane.prototype.onResize):
(WebInspector.TabbedPane.prototype._maybeMeasureAndUpdate):
(WebInspector.TabbedPane.prototype._measureTab):
(WebInspector.TabbedPane.prototype._updateWidths):
(WebInspector.TabbedPane.prototype._calculateMaxWidth):
(WebInspector.TabbedPaneTab):
* inspector/front-end/inspector.css:
(.tabbed-pane-header):
(.tabbed-pane-header-tabs):
(.tabbed-pane-header-tab):
(.tabbed-pane-header-tab.measuring):
(.tabbed-pane-header-tab.selected):
* inspector/front-end/scriptsPanel.css:
(#scripts-navigator-tabbed-pane .tabbed-pane-header-tabs):

LayoutTests:

* inspector/tabbed-pane-max-tab-width-calculation-expected.txt: Added.
* inspector/tabbed-pane-max-tab-width-calculation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: auto detect source map url.
podivilov@chromium.org [Wed, 21 Dec 2011 13:52:11 +0000 (13:52 +0000)]
Web Inspector: auto detect source map url.
https://bugs.webkit.org/show_bug.cgi?id=74088

Reviewed by Pavel Feldman.

Source/WebCore:

Check to see if "X-SourceMap" HTTP response header was sent with script resource.
Header value will be used as auto suggestion for source map url in UI.

* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::sourceMapURLForScript):
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerDispatcher.prototype.scriptParsed):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode):
* inspector/front-end/Script.js:
(WebInspector.Script):

LayoutTests:

* inspector/debugger/raw-source-code.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Mobile theme refinements
pierre.rossi@gmail.com [Wed, 21 Dec 2011 13:48:36 +0000 (13:48 +0000)]
[Qt] Mobile theme refinements
https://bugs.webkit.org/show_bug.cgi?id=74727

Mostly to replace most of the rounded-rect-shaped
controls with squircle-shaped ones.

Reviewed by Kenneth Rohde Christiansen.

No new tests needed.

* platform/qt/RenderThemeQtMobile.cpp:
(WebCore::drawControlBackground):
(WebCore::painterScale):
(WebCore::borderPen):
(WebCore::StylePainterMobile::drawCheckableBackground): Toned down the gradient a bit.
(WebCore::StylePainterMobile::findCheckBox):
(WebCore::StylePainterMobile::drawRadio):
(WebCore::StylePainterMobile::findRadio):
(WebCore::StylePainterMobile::drawMultipleComboButton): increase spacing between the dots.
(WebCore::StylePainterMobile::drawSimpleComboButton): attempt to improve readability.
(WebCore::StylePainterMobile::getButtonImageSize):
(WebCore::StylePainterMobile::findComboButton):
(WebCore::StylePainterMobile::drawLineEdit):
(WebCore::StylePainterMobile::findLineEdit):
(WebCore::StylePainterMobile::drawPushButton):
(WebCore::StylePainterMobile::findPushButton):
(WebCore::StylePainterMobile::drawComboBox):
(WebCore::StylePainterMobile::drawProgress):
(WebCore::StylePainterMobile::drawSliderThumb):
(WebCore::RenderThemeQtMobile::computeSizeBasedOnStyle):
(WebCore::RenderThemeQtMobile::paintTextField):
* platform/qt/RenderThemeQtMobile.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: CSSStyleSheet::cssRules can return 0 and InspectorStyleSheet dosen...
apavlov@chromium.org [Wed, 21 Dec 2011 13:45:10 +0000 (13:45 +0000)]
Web Inspector: CSSStyleSheet::cssRules can return 0 and InspectorStyleSheet dosen't check
https://bugs.webkit.org/show_bug.cgi?id=74938

Prevent security checks when retrieving a just-added CSS rule from the "inspector stylesheet".

Reviewed by Pavel Feldman.

* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::addRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Update Qt specific expected results.
ossy@webkit.org [Wed, 21 Dec 2011 10:38:08 +0000 (10:38 +0000)]
[Qt] Unreviewed gardening. Update Qt specific expected results.

* platform/qt/Skipped: Skip fast/text/international/bdi-neutral-wrapped.html because of missing test font.
* platform/qt/css2.1/20110323/border-conflict-style-079-expected.png: Added.
* platform/qt/css2.1/20110323/floating-replaced-height-008-expected.png: Added.
* platform/qt/css2.1/t170602-bdr-conflct-w-05-d-expected.png: Added.
* platform/qt/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Added.
* platform/qt/css2.1/t170602-bdr-conflct-w-07-d-expected.png: Added.
* platform/qt/css2.1/t170602-bdr-conflct-w-08-d-expected.png: Added.
* platform/qt/css2.1/t170602-bdr-conflct-w-15-d-expected.png: Added.
* platform/qt/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Added.
* platform/qt/css2.1/t170602-bdr-conflct-w-17-d-expected.png: Added.
* platform/qt/css2.1/t170602-bdr-conflct-w-18-d-expected.png: Added.
* platform/qt/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
* platform/qt/test_expectations.txt: Unskip passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFulfill FIXME in HTMLLinkElement.h.
reni@webkit.org [Wed, 21 Dec 2011 10:20:36 +0000 (10:20 +0000)]
Fulfill FIXME in  HTMLLinkElement.h.
https://bugs.webkit.org/show_bug.cgi?id=74278

Rename isStyleSheetLoading() method to styleSheetIsLoading().
This new one has the correct grammar.

Reviewed by Darin Adler.

No new tests because the functionality remains the same.

* dom/Document.cpp:
(WebCore::Document::recalcStyleSelector):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setDisabledState):
(WebCore::HTMLLinkElement::styleSheetIsLoading):
(WebCore::HTMLLinkElement::sheetLoaded):
* html/HTMLLinkElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Forms] Add OVERRIDE to WebCore/html/*InputType.h
commit-queue@webkit.org [Wed, 21 Dec 2011 09:47:45 +0000 (09:47 +0000)]
[Forms] Add OVERRIDE to WebCore/html/*InputType.h
https://bugs.webkit.org/show_bug.cgi?id=74996

Patch by Yosifumi Inoue <yosin@chromium.org> on 2011-12-21
Reviewed by Kent Tamura.

No new tests. Changes are just for compilation.

* html/BaseButtonInputType.h: Add OVERRIDE.
* html/BaseCheckableInputType.h: Add OVERRIDE.
* html/BaseDateAndTimeInputType.h: Add OVERRIDE.
* html/BaseTextInputType.h: Add OVERRIDE.
* html/ButtonInputType.h: Add OVERRIDE.
* html/CheckboxInputType.h: Add OVERRIDE.
* html/ColorInputType.h: Add OVERRIDE.
* html/DateInputType.h: Add OVERRIDE.
* html/DateTimeInputType.h: Add OVERRIDE.
* html/DateTimeLocalInputType.h: Add OVERRIDE.
* html/EmailInputType.h: Add OVERRIDE.
* html/FileInputType.h: Add OVERRIDE.
* html/HiddenInputType.h: Add OVERRIDE.
* html/ImageInputType.h: Add OVERRIDE.
* html/IsIndexInputType.h: Add OVERRIDE.
* html/MonthInputType.h: Add OVERRIDE.
* html/NumberInputType.h: Add OVERRIDE.
* html/PasswordInputType.h: Add OVERRIDE.
* html/RadioInputType.h: Add OVERRIDE.
* html/RangeInputType.h: Add OVERRIDE.
* html/ResetInputType.h: Add OVERRIDE.
* html/SearchInputType.h: Add OVERRIDE.
* html/SubmitInputType.h: Add OVERRIDE.
* html/TelephoneInputType.h: Add OVERRIDE.
* html/TextFieldInputType.h: Add OVERRIDE.
* html/TextInputType.h: Add OVERRIDE.
* html/TimeInputType.h: Add OVERRIDE.
* html/URLInputType.h: Add OVERRIDE.
* html/WeekInputType.h: Add OVERRIDE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIn prepare-ChangeLog, replace constant global variables with "use constant"
haraken@chromium.org [Wed, 21 Dec 2011 08:54:22 +0000 (08:54 +0000)]
In prepare-ChangeLog, replace constant global variables with "use constant"
https://bugs.webkit.org/show_bug.cgi?id=74992

Reviewed by Ryosuke Niwa.

This patch replaces the following constant global variables with "use constant"s.
    - $changeLogTimeZone
    - $SVN
    - $GIT
    - %supportedTestExtensions

* Scripts/prepare-ChangeLog:
(changeLogNameFromArgs):
(changeLogEmailAddressFromArgs):
(resolveConflictedChangeLogs):
(generateNewChangeLogs):
(diffCommand):
(statusCommand):
(createPatchCommand):
(findOriginalFileFromSvn):
(determinePropertyChanges):
(generateFileList):
(reviewerAndDescriptionForGitCommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed update test expectation for svg/custom/linking-uri-01-b.svg
loislo@chromium.org [Wed, 21 Dec 2011 08:33:43 +0000 (08:33 +0000)]
Unreviewed update test expectation for svg/custom/linking-uri-01-b.svg

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd all ICU languages to LocaleToScriptMappingDefault.cpp
commit-queue@webkit.org [Wed, 21 Dec 2011 08:19:32 +0000 (08:19 +0000)]
Add all ICU languages to LocaleToScriptMappingDefault.cpp
https://bugs.webkit.org/show_bug.cgi?id=67274

Patch by Matt Falkenhagen <falken@chromium.org> on 2011-12-21
Reviewed by Kent Tamura.

This better mimics the behavior of LocaleToScriptMappingICU.cpp. ICU
languages from ICU 3.6 are added. Also, script suffix in locale is
handled, so for example "fa_Latn" is mapped to Latin while "fa" is mapped to
Arabic.

No new tests, there is no visible effect until default per-script fonts
are added to non-ICU ports (alternatively, we could extend DumpRenderTree
to support overridePreference for per-script fonts as in bug 71110).

* platform/text/LocaleToScriptMappingDefault.cpp:
(WebCore::getScriptCode): add script name to script code mapping
(WebCore::localeToScriptCodeForFontSelection): add ICU languages to map

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed update test expectations for inspector's tests.
loislo@chromium.org [Wed, 21 Dec 2011 08:11:54 +0000 (08:11 +0000)]
Unreviewed update test expectations for inspector's tests.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] [Gardening] Move tests to the right skip list.
commit-queue@webkit.org [Wed, 21 Dec 2011 08:09:55 +0000 (08:09 +0000)]
[Qt] [Gardening] Move tests to the right skip list.
https://bugs.webkit.org/show_bug.cgi?id=74958

These tests pass on Qt-5.0 both with WK1 and WK2 but fail on Qt-4.8.
Also removes comment refering to Qt-4.7 since the test fails on all
versions at the moment.

Patch by João Paulo Rechi Vita <jprvita@openbossa.org> on 2011-12-21
Reviewed by Csaba Osztrogonác.

* platform/qt-4.8/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDisable a test without a result while I figure out
levin@chromium.org [Wed, 21 Dec 2011 08:03:04 +0000 (08:03 +0000)]
Disable a test without a result while I figure out
how to make the results consistent for each run.
Bug 74666 basically tracks re-enabling this test
since it contains an enhanced version of it.

* http/tests/workers/interrupt-database-sync-open-crash.html-skipped: Renamed from LayoutTests/http/tests/workers/interrupt-database-sync-open-crash.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpstream PageClientBlackBerry.h into WebCore/platform/blackberry
commit-queue@webkit.org [Wed, 21 Dec 2011 07:44:43 +0000 (07:44 +0000)]
Upstream PageClientBlackBerry.h into WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=74169

Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-20
Reviewed by Daniel Bates.

Initial upstream, no new tests.

* platform/blackberry/PageClientBlackBerry.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago32_64 baseline JIT should attempt to convert division results to integers, and record...
fpizlo@apple.com [Wed, 21 Dec 2011 07:40:44 +0000 (07:40 +0000)]
32_64 baseline JIT should attempt to convert division results to integers, and record when that fails
https://bugs.webkit.org/show_bug.cgi?id=74997
<rdar://problem/10612389>

Reviewed by Gavin Barraclough.

* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_div):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpstream PlatformMouseEvent and LocalizedStrings into WebCore/platform/blackberry
commit-queue@webkit.org [Wed, 21 Dec 2011 07:36:28 +0000 (07:36 +0000)]
Upstream PlatformMouseEvent and LocalizedStrings into WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=74383

Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-20
Reviewed by Daniel Bates.

Other Main Contributors:
Rob Buis <rbuis@rim.com>
Mike Fenton <mifenton@rim.com>

Initial upstream, no new tests.

* PlatformBlackBerry.cmake: Modified to rename Localizations.cpp to LocalizedStringsBlackBerry.cpp
* platform/blackberry/LocalizedStringsBlackBerry.cpp: Added.
* platform/blackberry/PlatformMouseEventBlackBerry.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJavaScriptCore should be consistent about how it reads and writes ArgumentCount
fpizlo@apple.com [Wed, 21 Dec 2011 06:01:20 +0000 (06:01 +0000)]
JavaScriptCore should be consistent about how it reads and writes ArgumentCount
https://bugs.webkit.org/show_bug.cgi?id=74989
<rdar://problem/10612006>

Reviewed by Gavin Barraclough.

* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileLoadVarargs):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_get_arguments_length):
(JSC::JIT::emit_op_get_argument_by_val):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::SpecializedThunkJIT):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: CodeGenerator should not use pointers for out params of RefPtr type.
loislo@chromium.org [Wed, 21 Dec 2011 05:51:31 +0000 (05:51 +0000)]
Web Inspector: CodeGenerator should not use pointers for out params of RefPtr type.
https://bugs.webkit.org/show_bug.cgi?id=69366

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-12-20
Reviewed by Pavel Feldman.

Generator fixed and all usages are changed manually.

* inspector/CodeGeneratorInspector.py:
(RawTypes.BaseType):
(RawTypes.BaseType.get_output_argument_prefix):
(RawTypes.Object.get_output_argument_prefix):
(RawTypes.Array.get_output_argument_prefix):
(RawTypes):
(Generator.process_command):
* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::getApplicationCacheForFrame):
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::getStyleSheet):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):
(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
(WebCore::InspectorCSSAgent::stopSelectorProfiler):
(WebCore::InspectorCSSAgent::stopSelectorProfilerImpl):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::resolveNode):
(WebCore::InspectorDOMAgent::getAttributes):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
* inspector/InspectorDOMStorageAgent.h:
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
* inspector/InspectorDatabaseAgent.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionLocation):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getDOMNodeCount):
* inspector/InspectorMemoryAgent.h:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
* inspector/InspectorPageAgent.h:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore::InspectorProfilerAgent::getProfile):
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):
* inspector/InspectorProfilerAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):
* inspector/InspectorRuntimeAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] m_triggerIdlePaints not reset after a compositeAndReadback
commit-queue@webkit.org [Wed, 21 Dec 2011 04:36:13 +0000 (04:36 +0000)]
[chromium] m_triggerIdlePaints not reset after a compositeAndReadback
https://bugs.webkit.org/show_bug.cgi?id=74974

Patch by Eric Penner <epenner@google.com> on 2011-12-20
Reviewed by James Robinson.

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::compositeAndReadback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove misplaced assert in SQLiteStatement.cpp
levin@chromium.org [Wed, 21 Dec 2011 03:26:26 +0000 (03:26 +0000)]
Move misplaced assert in SQLiteStatement.cpp
https://bugs.webkit.org/show_bug.cgi?id=74975

Reviewed by Dmitry Titov.

The test is coming with bug 74666.

* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::step): If a database was interrupted
before the prepare method was called, then m_isPrepared will be
false, so I moved the assert to be after the check for interrupted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebVTT cues sometimes render when they should not
eric.carlson@apple.com [Wed, 21 Dec 2011 02:37:02 +0000 (02:37 +0000)]
WebVTT cues sometimes render when they should not
https://bugs.webkit.org/show_bug.cgi?id=74873

Not reviewed: update Chromium to pass new test added in r103371.

* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::updateTextTrackDisplay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoValue Profiles for arguments should be more easily accessible to the interpreter
fpizlo@apple.com [Wed, 21 Dec 2011 02:29:15 +0000 (02:29 +0000)]
Value Profiles for arguments should be more easily accessible to the interpreter
https://bugs.webkit.org/show_bug.cgi?id=74984
<rdar://problem/10611364>

Reviewed by Gavin Barraclough.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::dumpValueProfiles):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::setArgumentValueProfileSize):
(JSC::CodeBlock::numberOfArgumentValueProfiles):
(JSC::CodeBlock::valueProfileForArgument):
(JSC::CodeBlock::addValueProfile):
(JSC::CodeBlock::valueProfile):
(JSC::CodeBlock::valueProfileForBytecodeOffset):
(JSC::CodeBlock::totalNumberOfValueProfiles):
(JSC::CodeBlock::getFromAllValueProfiles):
* bytecode/ValueProfile.h:
(JSC::ValueProfile::ValueProfile):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHTMLOptionsCollection: Remove incorrect FIXME about having a base class.
kling@webkit.org [Wed, 21 Dec 2011 02:02:19 +0000 (02:02 +0000)]
HTMLOptionsCollection: Remove incorrect FIXME about having a base class.
<http://webkit.org/b/74973>

Reviewed by Alexey Proskuryakov.

HTMLOptionsCollection should indeed inherit from HTMLCollection according to
current HTML5, so remove the comment saying we should change that.

Spec: http://www.whatwg.org/specs/web-apps/current-work/#htmloptionscollection

* html/HTMLOptionsCollection.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSC shell should accept utf8 input.
barraclough@apple.com [Wed, 21 Dec 2011 01:50:23 +0000 (01:50 +0000)]
JSC shell should accept utf8 input.

Reviewed by Filip Pizlo.

* jsc.cpp:
(jscSource):
(functionRun):
(functionLoad):
(functionCheckSyntax):
(runWithScripts):
(runInteractive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agotd element ignores zero width/height input element
commit-queue@webkit.org [Wed, 21 Dec 2011 01:41:13 +0000 (01:41 +0000)]
td element ignores zero width/height input element
https://bugs.webkit.org/show_bug.cgi?id=74636

Patch by Florin Malita <fmalita@google.com> on 2011-12-20
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/input-zero-width.html

* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computePreferredLogicalWidths):
Relax the attribute test to allow setting widths == 0.

LayoutTests:

* fast/forms/input-zero-width-expected.html: Added.
* fast/forms/input-zero-width.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAvoid unnecessary work when removing attributes from an element
adamk@chromium.org [Wed, 21 Dec 2011 01:32:54 +0000 (01:32 +0000)]
Avoid unnecessary work when removing attributes from an element
https://bugs.webkit.org/show_bug.cgi?id=74953

Reviewed by Ryosuke Niwa.

Source/WebCore:

Various codepaths in Element and NamedNodeMap repeatedly search
through the list of attributes during a single operation. To avoid
this, I've added new getters to NamedNodeMap that return indices
rather than Attribute*s (they return WTF::notFound if no match is
found). These new methods are now used during removeAttribute
operations, as well as setAttribute and NamedNodeMap::setNamedItem
(along with a new replaceAttribute helper method).

The other optimization here involves the creation/destruction
of never-references Attr nodes. This is now avoided by calling
NamedNodeMap::removeAttribute directly instead of going through
NamedNodeMap::removeNamedItem.

As a cleanup after the above changes, the ExceptionCode argument is
gone from Element::removeAttribute and friends (it was never set
previously). The bulk of the files mentioned below are simply updating
callers to these methods.

No new tests, no change in behavior expected.

* dom/DatasetDOMStringMap.cpp:
(WebCore::DatasetDOMStringMap::deleteItem):
* dom/Element.cpp:
(WebCore::Element::removeAttribute):
(WebCore::Element::setBooleanAttribute):
(WebCore::Element::removeAttributeNS):
(WebCore::Element::setAttribute):
(WebCore::Element::setAttributeInternal):
* dom/Element.h:
* dom/Element.idl:
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::setNamedItem):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::getAttributeItemIndexSlowCase):
(WebCore::NamedNodeMap::replaceAttribute):
(WebCore::NamedNodeMap::removeAttribute):
* dom/NamedNodeMap.h:
(WebCore::NamedNodeMap::getAttributeItem):
(WebCore::NamedNodeMap::getAttributeItemIndex):
(WebCore::NamedNodeMap::removeAttribute):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::cloneHierarchyUnderNewBlock):
* editing/SplitElementCommand.cpp:
(WebCore::SplitElementCommand::executeApply):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::setContentEditable):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setType):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::transferUseAttributesToReplacedElement):

Source/WebKit/qt:

* Api/qwebelement.cpp:
(QWebElement::removeAttribute): Updated a caller of
WebCore::Element::removeAttribute to remove ExceptionCode argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebVTT cues sometimes render when they should not
eric.carlson@apple.com [Wed, 21 Dec 2011 01:14:23 +0000 (01:14 +0000)]
WebVTT cues sometimes render when they should not
https://bugs.webkit.org/show_bug.cgi?id=74873

Reviewed by Darin Adler.

Source/WebCore:

Test: media/track/track-cue-nothing-to-render.html

* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::updateTextTrackDisplay): Don't return early if the current
    cue is empty so the previous cue is removed.

LayoutTests:

* media/track/captions-webvtt/captions-gaps.vtt: Added.
* media/track/track-cue-nothing-to-render-expected.txt: Added.
* media/track/track-cue-nothing-to-render.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't crash on the second time VideoLayerChromium::createCCVideoLayer() is called
commit-queue@webkit.org [Wed, 21 Dec 2011 01:09:12 +0000 (01:09 +0000)]
Don't crash on the second time VideoLayerChromium::createCCVideoLayer() is called
https://bugs.webkit.org/show_bug.cgi?id=74963

Patch by Ami Fischman <fischman@chromium.org> on 2011-12-20
Reviewed by James Robinson.

Manually tested by force-dropping the layer tree in CCLayerTreeHost::didBecomeInvisibleOnImplThread().
Crashed before the fix, doesn't crash after.

* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::~VideoLayerChromium):
(WebCore::VideoLayerChromium::createCCLayerImpl):
* platform/graphics/chromium/VideoLayerChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowouldTaintOrigin m_cleanURLs cache grows very large when data urls used
commit-queue@webkit.org [Wed, 21 Dec 2011 00:39:28 +0000 (00:39 +0000)]
wouldTaintOrigin m_cleanURLs cache grows very large when data urls used
https://bugs.webkit.org/show_bug.cgi?id=74957

Patch by Scott Graham <scottmg@chromium.org> on 2011-12-20
Reviewed by Kenneth Russell.

No new tests, but memory usage of CanvasRenderingContext::m_cleanURLs
is reduced.

* html/canvas/CanvasRenderingContext.cpp:
(WebCore::CanvasRenderingContext::wouldTaintOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChange adoptPtr(new ...) to ...::create in Page.cpp
commit-queue@webkit.org [Wed, 21 Dec 2011 00:23:50 +0000 (00:23 +0000)]
Change adoptPtr(new ...) to ...::create in Page.cpp
https://bugs.webkit.org/show_bug.cgi?id=74457

Patch by Greg Billock <gbillock@google.com> on 2011-12-20
Reviewed by Darin Adler.

* dom/DeviceMotionController.cpp:
(WebCore::DeviceMotionController::create):
* dom/DeviceMotionController.h:
* dom/DeviceOrientationController.cpp:
(WebCore::DeviceOrientationController::create):
* dom/DeviceOrientationController.h:
* editing/FrameSelection.cpp:
(WebCore::DragCaretController::create):
* editing/FrameSelection.h:
* history/BackForwardController.cpp:
(WebCore::BackForwardController::create):
* history/BackForwardController.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::create):
* inspector/InspectorController.h:
* loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::create):
* loader/ProgressTracker.h:
* notifications/NotificationController.cpp:
(WebCore::NotificationController::create):
* notifications/NotificationController.h:
* page/Chrome.cpp:
(WebCore::Chrome::create):
* page/Chrome.h:
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::create):
* page/ContextMenuController.h:
* page/DragController.cpp:
(WebCore::DragController::create):
* page/DragController.h:
* page/FocusController.cpp:
(WebCore::FocusController::create):
* page/FocusController.h:
* page/GeolocationController.cpp:
(WebCore::GeolocationController::create):
* page/GeolocationController.h:
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::initGroup):
(WebCore::Page::speechInput):
* page/PageGroup.cpp:
(WebCore::PageGroup::create):
* page/PageGroup.h:
* page/Settings.cpp:
(WebCore::Settings::create):
* page/Settings.h:
* page/SpeechInput.cpp:
(WebCore::SpeechInput::create):
* page/SpeechInput.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRubber Stamped by Sam Weinig
barraclough@apple.com [Wed, 21 Dec 2011 00:10:07 +0000 (00:10 +0000)]
Rubber Stamped by Sam Weinig

* runtime/JSGlobalData.cpp:
    - removed some dead code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMac build fix after r103354.
rniwa@webkit.org [Wed, 21 Dec 2011 00:04:22 +0000 (00:04 +0000)]
Mac build fix after r103354.

* platform/mac/ScrollAnimatorMac.mm:
(systemUptime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd ScrollableArea::contentsResized and have it call the scroll animator
andersca@apple.com [Tue, 20 Dec 2011 23:58:30 +0000 (23:58 +0000)]
Add ScrollableArea::contentsResized and have it call the scroll animator
https://bugs.webkit.org/show_bug.cgi?id=74966

Reviewed by Sam Weinig.

Source/WebCore:

* WebCore.exp.in:
* page/FrameView.cpp:
(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::contentsResized):
* page/FrameView.h:
* platform/ScrollView.h:
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::contentsResized):
* platform/ScrollableArea.h:

Source/WebKit2:

* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::scrollbarStyleChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agorequestAnimationFrame on Mac fires at 60fps even when drawing is much slower
simon.fraser@apple.com [Tue, 20 Dec 2011 23:55:11 +0000 (23:55 +0000)]
requestAnimationFrame on Mac fires at 60fps even when drawing is much slower
https://bugs.webkit.org/show_bug.cgi?id=74964

Reviewed by Chris Marrin.

On Mac requestAnimationFrame uses a CVDisplayLink, sending notifications
from the display link thread to the main thread that the display link fired.
However, there was no throttling on these notifications; if processing an event
took a long time, notifications would pile up, and then get handled after
the slow event completed.

This would cause JS animations which animate by changing style to report
60fps when their display framerate was much lower.

Fix by throttling notifications from the display link thread to the web
thread; if the previous event hasn't completed yet, don't send any new ones.

No new tests, since testing this runtime behavior is hard.

* platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::refreshDisplayOnMainThread):
(WebCore::DisplayRefreshMonitor::notifyClients): Factored out of the
static refreshDisplayOnMainThread method so we can use 'this'.
* platform/graphics/DisplayRefreshMonitor.h:
* platform/graphics/mac/DisplayRefreshMonitorMac.cpp:
(WebCore::DisplayRefreshMonitor::displayLinkFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Coverity] Fix leak in V8HTMLDocument
commit-queue@webkit.org [Tue, 20 Dec 2011 23:46:03 +0000 (23:46 +0000)]
[Coverity] Fix leak in V8HTMLDocument
https://bugs.webkit.org/show_bug.cgi?id=74943

Patch by Greg Billock <gbillock@google.com> on 2011-12-20
Reviewed by Adam Barth.

* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::openCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonrwt: rename field references from _fs to _filesystem
dpranke@chromium.org [Tue, 20 Dec 2011 23:39:54 +0000 (23:39 +0000)]
nrwt: rename field references from _fs to _filesystem
https://bugs.webkit.org/show_bug.cgi?id=74898

Reviewed by Adam Barth.

This is a simple cleanup; most of the code uses
self._filesystem, but some used self._fs; this change renames
the latter to the former to be more consistent.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.__init__):
(Manager.collect_tests):
(Manager._strip_test_dir_prefix):
(Manager._split_into_chunks_if_necessary):
(Manager.results_directory):
(Manager._clobber_old_results):
(Manager._upload_json_files):
(Manager.print_config):
(Manager._copy_results_html_file):
(Manager._show_results_html_file):
(Manager._log_worker_stack):
* Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
(JSONLayoutResultsGenerator._normalize_results_json):
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(JSONResultsGeneratorBase.__init__):
(JSONResultsGeneratorBase.generate_json_output):
(JSONResultsGeneratorBase.generate_times_ms_file):
(JSONResultsGeneratorBase.upload_json_files):
(JSONResultsGeneratorBase._get_svn_revision):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(Base.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTightened up Vector<T>::append
ggaren@apple.com [Tue, 20 Dec 2011 23:30:50 +0000 (23:30 +0000)]
Tightened up Vector<T>::append
https://bugs.webkit.org/show_bug.cgi?id=74906

Reviewed by Sam Weinig.

Not a measurable speedup, but code inspection shows better code generated,
and I believe this is a step toward turning off -fomit-frame-pointer.

* wtf/Vector.h:
(WTF::::append):
(WTF::::appendSlowCase): Split out the slow case into a separate function
to keep unnecessary instructions off the hot path. This means the hot
path can now be inlined more often.

Removed some old MSVC7 cruft. Hopefully, we don't need to hang on to a
compiler work-around from 2007.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix the Windows build.
andersca@apple.com [Tue, 20 Dec 2011 23:28:37 +0000 (23:28 +0000)]
Try to fix the Windows build.

* UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::showPopupMenu):
(WebKit::WebPopupMenuProxyWin::setFocusedIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMerge ScrollAnimatorChromiumMac.mm back to ScrollAnimatorMac
commit-queue@webkit.org [Tue, 20 Dec 2011 23:13:59 +0000 (23:13 +0000)]
Merge ScrollAnimatorChromiumMac.mm back to ScrollAnimatorMac
https://bugs.webkit.org/show_bug.cgi?id=61144

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-12-20
Reviewed by Beth Dakin.

At a high level the main changes are:
    - replace #ifdefs in ScrollAnimatorMac and ScrollbarThemeMac with run time checks
    - delete duplicate code in ScrollbarThemeChromiumMac. Keep the paint code since it does tickmarks and SKIA stuff.
    - delete ScrollAnimatorChromiumMac since ScrollAnimatorMac does the exact same thing
    - delete ScrollbarOverlayUtilitiesChromiumMac since NSScrollerImpDetails does the same thing

No new tests. Just refactoring.

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* platform/chromium/ScrollAnimatorChromiumMac.h: Removed.
* platform/chromium/ScrollAnimatorChromiumMac.mm: Removed.
* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h: Removed.
* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm: Removed.
* platform/chromium/ScrollbarThemeChromiumMac.h:
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::scrollbarPainterPaintTrack):
(WebCore::ScrollbarThemeChromiumMac::paint):
* platform/mac/EmptyProtocolDefinitions.h:
* platform/mac/NSScrollerImpDetails.h:
(WebCore::isScrollbarOverlayAPIAvailable):
* platform/mac/NSScrollerImpDetails.mm: Added.
(WebCore::isScrollbarOverlayAPIAvailable):
(WebCore::recommendedScrollerStyle):
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(scrollbarPainterForScrollbar):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::cancelAnimations):
(WebCore::ScrollAnimatorMac::setIsActive):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
(WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):
* platform/mac/ScrollElasticityController.h:
* platform/mac/ScrollbarThemeMac.h:
* platform/mac/ScrollbarThemeMac.mm:
(+[WebScrollbarPrefsObserver appearancePrefsChanged:]):
(+[WebScrollbarPrefsObserver behaviorPrefsChanged:]):
(WebCore::updateArrowPlacement):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::setIsCurrentlyDrawingIntoLayer):
(WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeMac::hasButtons):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::scrollbarPartToHIPressedState):
(WebCore::ScrollbarThemeMac::updateEnabledState):
(WebCore::scrollbarPainterPaint):
(WebCore::ScrollbarThemeMac::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agosizeof(RenderStyle) is 64 instead of 56 on Windows (x86)
tony@chromium.org [Tue, 20 Dec 2011 22:37:04 +0000 (22:37 +0000)]
sizeof(RenderStyle) is 64 instead of 56 on Windows (x86)
https://bugs.webkit.org/show_bug.cgi?id=74876

Reviewed by Ryosuke Niwa.

Move bit fields into a new class and use unsigned for all types so we
align at 4 byte bounds. Also move the initializers into the header
file (has the side benefit of not needing to duplicate the initializers
in 3 places).

Enable the compile assert on Windows.

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyleBitfields::affectedByUncommonAttributeSelectors):
(WebCore::RenderStyleBitfields::setAffectedByUncommonAttributeSelectors):
(WebCore::RenderStyleBitfields::unique):
(WebCore::RenderStyleBitfields::setUnique):
(WebCore::RenderStyleBitfields::affectedByEmpty):
(WebCore::RenderStyleBitfields::emptyState):
(WebCore::RenderStyleBitfields::setEmptyState):
(WebCore::RenderStyleBitfields::childrenAffectedByFirstChildRules):
(WebCore::RenderStyleBitfields::setChildrenAffectedByFirstChildRules):
(WebCore::RenderStyleBitfields::childrenAffectedByLastChildRules):
(WebCore::RenderStyleBitfields::setChildrenAffectedByLastChildRules):
(WebCore::RenderStyleBitfields::childrenAffectedByDirectAdjacentRules):
(WebCore::RenderStyleBitfields::setChildrenAffectedByDirectAdjacentRules):
(WebCore::RenderStyleBitfields::childrenAffectedByForwardPositionalRules):
(WebCore::RenderStyleBitfields::setChildrenAffectedByForwardPositionalRules):
(WebCore::RenderStyleBitfields::childrenAffectedByBackwardPositionalRules):
(WebCore::RenderStyleBitfields::setChildrenAffectedByBackwardPositionalRules):
(WebCore::RenderStyleBitfields::firstChildState):
(WebCore::RenderStyleBitfields::setFirstChildState):
(WebCore::RenderStyleBitfields::lastChildState):
(WebCore::RenderStyleBitfields::setLastChildState):
(WebCore::RenderStyleBitfields::childIndex):
(WebCore::RenderStyleBitfields::setChildIndex):
(WebCore::RenderStyleBitfields::setHasExplicitlyInheritedProperties):
(WebCore::RenderStyleBitfields::hasExplicitlyInheritedProperties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed, according to the flakiness dashboard,
tony@chromium.org [Tue, 20 Dec 2011 22:33:22 +0000 (22:33 +0000)]
[chromium] Unreviewed, according to the flakiness dashboard,
http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html
is consistently passing.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert code for r96912 and r101905, since they cause
japhet@chromium.org [Tue, 20 Dec 2011 22:17:40 +0000 (22:17 +0000)]
Revert code for r96912 and r101905, since they cause
regressions in mac scrollbars, caret display in
form fields, etc.
https://bugs.webkit.org/show_bug.cgi?id=74939

Reviewed by Eric Seidel.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setFocus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed, according to the flakiness dashboard,
tony@chromium.org [Tue, 20 Dec 2011 22:13:56 +0000 (22:13 +0000)]
[chromium] Unreviewed, according to the flakiness dashboard,
svg/css/glyph-orientation-rounding-test.xhtml is consistently passing
on all platforms.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoenable USE_SKIA_TEXT by default, replacing GDI for all text drawing
reed@google.com [Tue, 20 Dec 2011 22:05:28 +0000 (22:05 +0000)]
enable USE_SKIA_TEXT by default, replacing GDI for all text drawing
https://bugs.webkit.org/show_bug.cgi?id=74928

Reviewed by Stephen White.

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] enable WPO for WebCore libs in official builds
tony@chromium.org [Tue, 20 Dec 2011 21:45:25 +0000 (21:45 +0000)]
[chromium] enable WPO for WebCore libs in official builds
https://bugs.webkit.org/show_bug.cgi?id=74947

Reviewed by James Robinson.

Also move enable_wexit_time_destructors to the top level variables
so we don't have to add it to all targets.

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Remove statusBarMessageChanged
commit-queue@webkit.org [Tue, 20 Dec 2011 21:40:42 +0000 (21:40 +0000)]
[Qt][WK2] Remove statusBarMessageChanged
https://bugs.webkit.org/show_bug.cgi?id=74405

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2011-12-20
Reviewed by Tor Arne Vestbø.

Removing support for window.status updates from the public
QML API. See bug for details.

* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/qt/QtWebPageUIClient.cpp:
(QtWebPageUIClient::QtWebPageUIClient):
* UIProcess/qt/QtWebPageUIClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd ScrollableArea wrappers for a bunch of ScrollAnimator member functions
andersca@apple.com [Tue, 20 Dec 2011 21:21:33 +0000 (21:21 +0000)]
Add ScrollableArea wrappers for a bunch of ScrollAnimator member functions
https://bugs.webkit.org/show_bug.cgi?id=74951

Reviewed by Sam Weinig.

Source/WebCore:

* WebCore.exp.in:
* page/EventHandler.cpp:
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::updateMouseEventTargetNode):
* page/FocusController.cpp:
(WebCore::FocusController::setActive):
* page/FrameView.cpp:
(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
(WebCore::FrameView::notifyPageThatContentAreaWillPaint):
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::contentAreaWillPaint):
(WebCore::ScrollableArea::mouseEnteredContentArea):
(WebCore::ScrollableArea::mouseExitedContentArea):
(WebCore::ScrollableArea::mouseMovedInContentArea):
(WebCore::ScrollableArea::mouseEnteredScrollbar):
(WebCore::ScrollableArea::mouseExitedScrollbar):
(WebCore::ScrollableArea::contentAreaDidShow):
(WebCore::ScrollableArea::contentAreaDidHide):
* platform/ScrollableArea.h:
* platform/ScrollableAreaClient.h:
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::mouseEntered):
(WebCore::Scrollbar::mouseExited):
(WebCore::Scrollbar::mouseUp):

Source/WebKit2:

* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::paint):
(WebKit::BuiltInPDFView::handleMouseEvent):
(WebKit::BuiltInPDFView::handleMouseEnterEvent):
(WebKit::BuiltInPDFView::handleMouseLeaveEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWhen <bdi> content is wrapped, all hell breaks loose
commit-queue@webkit.org [Tue, 20 Dec 2011 21:11:35 +0000 (21:11 +0000)]
When <bdi> content is wrapped, all hell breaks loose
https://bugs.webkit.org/show_bug.cgi?id=74396

New test case by Aharon Lanin for multi-line bidi.

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-12-20
Reviewed by Ryosuke Niwa.

* fast/text/international/bidi-neutral-wrapped.html: Added.
* fast/text/international/bidi-neutral-wrapped-expected.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPerform case insensitive matching on MIME types in XHR
jarred@sencha.com [Tue, 20 Dec 2011 21:06:48 +0000 (21:06 +0000)]
Perform case insensitive matching on MIME types in XHR
https://bugs.webkit.org/show_bug.cgi?id=74800

Source/WebCore:

Perform case insensitive matching on responseMIMEType() in didReceiveData().
Workaround case sensitive matching by DOMImplementation::isXMLMIMEType() in responseIsXML().

Reviewed by Darin Adler.

Tests: http/tests/xmlhttprequest/xmlhttprequest-mimetype-mixed-case.html
       http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-mixed-case.html

* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::didReceiveData):
(WebCore::XMLHttpRequest::responseIsXML):

LayoutTests:

New tests that verify mixed case MIME types are properly handled in XHR for
- user provided types via overrideMimeType()
- server-sent Content-Type headers

Reviewed by Darin Adler.

* http/tests/xmlhttprequest/resources/xmlhttprequest-mimetype-mixed-case.php: Added.
* http/tests/xmlhttprequest/xmlhttprequest-mimetype-mixed-case.html: Added.
* http/tests/xmlhttprequest/xmlhttprequest-mimetype-mixed-case-expected.txt: Added.
* http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-mixed-case.html: Added.
* http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-mixed-case-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove no-op DOMAttr* event dispatch methods from Element
adamk@chromium.org [Tue, 20 Dec 2011 21:02:48 +0000 (21:02 +0000)]
Remove no-op DOMAttr* event dispatch methods from Element
https://bugs.webkit.org/show_bug.cgi?id=74946

Reviewed by Darin Adler.

The removed methods had their bodies #if 0'd out, so this should have
no effect on anything.

* dom/Element.cpp:
* dom/Element.h:
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::addAttribute):
(WebCore::NamedNodeMap::removeAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoScrollableArea should have an optional ScrollableAreaClient
andersca@apple.com [Tue, 20 Dec 2011 20:33:38 +0000 (20:33 +0000)]
ScrollableArea should have an optional ScrollableAreaClient
https://bugs.webkit.org/show_bug.cgi?id=74949

Reviewed by Sam Weinig.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* page/FrameView.cpp:
(WebCore::scrollableAreaClient):
(WebCore::FrameView::FrameView):
* page/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::scrollableAreaClientForFrame):
* page/ScrollingCoordinator.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::ScrollView):
* platform/ScrollView.h:
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::ScrollableArea):
* platform/ScrollableArea.h:
* platform/ScrollableAreaClient.h: Added.
(WebCore::ScrollableAreaClient::~ScrollableAreaClient):
(WebCore::ScrollableAreaClient::ScrollableAreaClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WinCairo] Unreviewed build fix.
bfulgham@webkit.org [Tue, 20 Dec 2011 20:29:47 +0000 (20:29 +0000)]
[WinCairo] Unreviewed build fix.

* win/WebKit2CFLite.def: Add missing export declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename Element::setAttributeMap to parserSetAttributeMap and limit its use to the...
adamk@chromium.org [Tue, 20 Dec 2011 19:40:58 +0000 (19:40 +0000)]
Rename Element::setAttributeMap to parserSetAttributeMap and limit its use to the parser
https://bugs.webkit.org/show_bug.cgi?id=74885

Reviewed by Ryosuke Niwa.

Element::setAttributeMap is currently used by the parser in cases
where a NamedNodeMap of attributes has already been allocated and
transfers ownership to the Element. Other uses in WebCore don't have
this ownership-transfer requirement, and so are more clearly expressed
with normal setAttribute calls.

Eliminating non-parser callers allows the code to make safe
assumptions about the state of the Element it's called on: no need to
worry about, e.g., updating the id in the document's cache or
enqueueing mutation records.

No new tests, no change in behavior expected.

* dom/Element.cpp:
(WebCore::Element::parserSetAttributeMap): Renamed, added assertions
to make sure it's not called unexpectedly, update comments.
* dom/Element.h:
* html/HTMLViewSourceDocument.cpp: Use setAttribute instead of setAttributeMap.
(WebCore::HTMLViewSourceDocument::createContainingTable):
(WebCore::HTMLViewSourceDocument::addSpanWithClassName):
(WebCore::HTMLViewSourceDocument::addLine):
(WebCore::HTMLViewSourceDocument::addBase):
(WebCore::HTMLViewSourceDocument::addLink):
* html/parser/HTMLConstructionSite.cpp: Reference new name.
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):
* html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::constructTreeFromToken): Use setAttribute instead of setAttributeMap.
Also get rid of an unnecessary String -> AtomicString conversion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unused parameter from RenderLayerCompositor::rebuildCompositingLayerTree
commit-queue@webkit.org [Tue, 20 Dec 2011 18:12:34 +0000 (18:12 +0000)]
Remove unused parameter from RenderLayerCompositor::rebuildCompositingLayerTree
https://bugs.webkit.org/show_bug.cgi?id=74936

Patch by Iain Merrick <husky@google.com> on 2011-12-20
Reviewed by Simon Fraser.

Pure refactoring, no change in functionality.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
* rendering/RenderLayerCompositor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReplace webkitperl/run-leaks_unittest/RunLeaks.pm with webkitperl/LoadAsModule.pm
haraken@chromium.org [Tue, 20 Dec 2011 17:40:33 +0000 (17:40 +0000)]
Replace webkitperl/run-leaks_unittest/RunLeaks.pm with webkitperl/LoadAsModule.pm
https://bugs.webkit.org/show_bug.cgi?id=74836

Reviewed by David Kilzer.

webkitperl/run-leaks_unittest/RunLeaks.pm can be used for unit-testing of run-leaks only.
This patch creates more generalized webkitperl/LoadAsModule.pm, which can be also used
for unit-testing of other Perl scripts. We are planning to use it for unit-testing
of prepare-ChangeLog.

Using LoadAsModule.pm, you can load a Perl script as follows.
The first argument is the arbitrary package name you want to use, and the second argument
is the name of the Perl script you want to load.

    use LoadAsModule qw(RunLeaks run-leaks);
    RunLeaks::someFunctionDefinedInRunLeaks(...);

Tests: Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl
       Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl
       Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl

* Scripts/webkitperl/LoadAsModule.pm: Added.
* Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Removed.
(import):
(readFile):
* Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Used LoadAsModule instead of RunLeaks.
* Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
* Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRenderStyle::InheritedFlags and RenderStyle::NonInheritedFlags members should be...
tony@chromium.org [Tue, 20 Dec 2011 17:31:39 +0000 (17:31 +0000)]
RenderStyle::InheritedFlags and RenderStyle::NonInheritedFlags members should be 4 byte aligned
https://bugs.webkit.org/show_bug.cgi?id=74880

Reviewed by Ryosuke Niwa.

Use unsigned for all types so we get 4 byte boundaries (unsigned char
means we try to align to 1 byte boundaries) and add setters and
getters for bool members.

Move some members around to make sure we're aligned to 4 byte boundaries.

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::copyNonInheritedFrom):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::NonInheritedFlags::affectedByHover):
(WebCore::InheritedFlags::NonInheritedFlags::setAffectedByHover):
(WebCore::InheritedFlags::NonInheritedFlags::affectedByActive):
(WebCore::InheritedFlags::NonInheritedFlags::setAffectedByActive):
(WebCore::InheritedFlags::NonInheritedFlags::affectedByDrag):
(WebCore::InheritedFlags::NonInheritedFlags::setAffectedByDrag):
(WebCore::InheritedFlags::NonInheritedFlags::isLink):
(WebCore::InheritedFlags::NonInheritedFlags::setIsLink):
(WebCore::InheritedFlags::setBitDefaults):
(WebCore::InheritedFlags::affectedByHoverRules):
(WebCore::InheritedFlags::affectedByActiveRules):
(WebCore::InheritedFlags::affectedByDragRules):
(WebCore::InheritedFlags::setAffectedByHoverRules):
(WebCore::InheritedFlags::setAffectedByActiveRules):
(WebCore::InheritedFlags::setAffectedByDragRules):
(WebCore::InheritedFlags::isLink):
(WebCore::InheritedFlags::setIsLink):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] 2 editing tests introduced in r103073 fails
ossy@webkit.org [Tue, 20 Dec 2011 17:26:43 +0000 (17:26 +0000)]
[Qt][WK2] 2 editing tests introduced in r103073 fails
https://bugs.webkit.org/show_bug.cgi?id=74937

Unreviewed gardening, skip failing tests.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Assertion hit and crash with fast/multicol/pagination-* tests
ossy@webkit.org [Tue, 20 Dec 2011 17:23:05 +0000 (17:23 +0000)]
[Qt][WK2] Assertion hit and crash with fast/multicol/pagination-* tests
https://bugs.webkit.org/show_bug.cgi?id=74511

Unreviewed gardening, skip failing tests.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoemacs: unreviewed. add settings for editing js files.
loislo@chromium.org [Tue, 20 Dec 2011 17:09:20 +0000 (17:09 +0000)]
emacs: unreviewed. add settings for editing js files.

* .dir-locals.el:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r103325) - injected-script-for-origin.html crashing in Chromium Linux...
caseq@chromium.org [Tue, 20 Dec 2011 16:32:25 +0000 (16:32 +0000)]
REGRESSION(r103325) - injected-script-for-origin.html crashing in Chromium Linux debug
https://bugs.webkit.org/show_bug.cgi?id=74934

Unreviewed test fix.

* http/tests/inspector/injected-script-for-origin.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agochromium: unreviewed. Clean out passing tests from test_expectations.txt.
loislo@chromium.org [Tue, 20 Dec 2011 16:27:31 +0000 (16:27 +0000)]
chromium: unreviewed. Clean out passing tests from test_expectations.txt.

* platform/chromium/test_expectations.txt:
  plugins/form-value.html: was fixed at r103147.
  fast/images/move-image-to-new-document.html: was fixed somewhere between r102959 and r102965.
  media/media-controller-playback.html: rebaselined at r103285.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Build fix for gcc used on WK2 build bot.
hausmann@webkit.org [Tue, 20 Dec 2011 15:42:38 +0000 (15:42 +0000)]
[Qt] Build fix for gcc used on WK2 build bot.

* UIProcess/qt/QtWebPagePolicyClient.cpp:
(QtWebPagePolicyClient::decidePolicyForNavigationAction): Don't do case:
with values outside the range of the type. Instead switch() on the int instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Extend QQuickWebview::navigationRequested API
hausmann@webkit.org [Tue, 20 Dec 2011 15:35:52 +0000 (15:35 +0000)]
[Qt] Extend QQuickWebview::navigationRequested API
https://bugs.webkit.org/show_bug.cgi?id=73818

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2011-12-20
Reviewed by Simon Hausmann.

Source/WebKit/qt:

* declarative/experimental/plugin.cpp:

Source/WebKit2:

Added url of the originating frame on QWebNavigationRequest,
accessible via 'request.originatingUrl' on QML. Download action
was moved to experimental, so in order to use it you should set
'request.action = WebViewExperimental.DownloadRequest' on QML.

* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qwebnavigationrequest.cpp:
(QWebNavigationRequestPrivate::QWebNavigationRequestPrivate):
(QWebNavigationRequest::QWebNavigationRequest):
(QWebNavigationRequest::originatingUrl):
* UIProcess/API/qt/qwebnavigationrequest_p.h:
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
Tests were modified a bit to reuse urls and also added a test case to check
originating url once a request is done.
* UIProcess/qt/QtWebPagePolicyClient.cpp:
(QtWebPagePolicyClient::decidePolicyForNavigationAction):
* UIProcess/qt/QtWebPagePolicyClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] WK2 Debugging quirks need some improvement
kbalazs@webkit.org [Tue, 20 Dec 2011 15:21:49 +0000 (15:21 +0000)]
[Qt] WK2 Debugging quirks need some improvement
https://bugs.webkit.org/show_bug.cgi?id=74859

Reviewed by Simon Hausmann.

Improvements added to make debugging WebKit2 more
confortable and efficient:
1. Unify debugging quirks. From now all of them are controlled
by the QT_WEBKIT2_DEBUG environment variable.
2. Disable crash handlers for WebKitTestRunner if debugging quirks
are used to make it possible to use postmortem debugging via core dumps
which is extremely useful for debugging bugs triggered by layout tests.
3. Disable test timeout for WebKitTestRunner if debugging quirks
are used because that makes debugging impossible.

Source/WebKit2:

* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::QtWebProcess::setupChildProcess):
* WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):

Tools:

* WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
(WTR::InjectedBundle::platformInitialize):
* WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
(WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
* WebKitTestRunner/qt/TestControllerQt.cpp:
(WTR::TestController::platformRunUntil):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Rebaseline fast/js/mozilla/strict/15.4.5.1.html
loislo@chromium.org [Tue, 20 Dec 2011 15:07:09 +0000 (15:07 +0000)]
[Chromium] Rebaseline fast/js/mozilla/strict/15.4.5.1.html
https://bugs.webkit.org/show_bug.cgi?id=74918

Unreviewed expectation fix.

Patch by Michael Starzinger <mstarzinger@chromium.org> on 2011-12-20

* platform/chromium/fast/js/mozilla/strict/15.4.5.1-expected.txt: Added.
* platform/chromium/test_

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRegression(99212): table rows get incorrect height after changing some cells' height
jchaffraix@webkit.org [Tue, 20 Dec 2011 14:08:52 +0000 (14:08 +0000)]
Regression(99212): table rows get incorrect height after changing some cells' height
https://bugs.webkit.org/show_bug.cgi?id=74303

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/table/resize-table-binding-cell.html
       fast/table/resize-table-cell.html
       fast/table/resize-table-row.html

r99212 wrongly implemented the row's logicalHeight recalculation.
The original code would use recalcCells which would properly recalculate a
row logicalHeight by iterating over the table's cells but throwing out the
existing result.

Our approach is just to recompute our row's logicalHeight and leave the
rest of the section untouched.

* rendering/RenderTableSection.cpp:
(WebCore::updateLogicalHeightForCell):
Added this new helper function to update the RowStruct logicalHeight during
|addCell| and |rowLogicalHeightChanged|.

(WebCore::RenderTableSection::addCell):
Replaced the old code with a call to updateLogicalHeightForCell.
(WebCore::RenderTableSection::rowLogicalHeightChanged):
Added a call to updateLogicalHeightForCell for each cells.

LayoutTests:

Added some tests that resize a cell or a row and check that we properly recompute the height.

* fast/table/resize-table-binding-cell-expected.txt: Added.
* fast/table/resize-table-binding-cell.html: Added.
* fast/table/resize-table-cell-expected.txt: Added.
* fast/table/resize-table-cell.html: Added.
* fast/table/resize-table-row-expected.txt: Added.
* fast/table/resize-table-row.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r103322.
loislo@chromium.org [Tue, 20 Dec 2011 14:04:25 +0000 (14:04 +0000)]
Unreviewed, rolling out r103322.
http://trac.webkit.org/changeset/103322
https://bugs.webkit.org/show_bug.cgi?id=74927

seven inspector's tests are crashing on qt (Requested by
loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-20

* inspector/CodeGeneratorInspector.py:
(RawTypes.BaseType.is_event_param_check_optional):
(RawTypes.Object.is_event_param_check_optional):
(RawTypes.Array.is_event_param_check_optional):
(RawTypes):
(Generator.process_command):
* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::getApplicationCacheForFrame):
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::getStyleSheet):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):
(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
(WebCore::InspectorCSSAgent::stopSelectorProfiler):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::resolveNode):
(WebCore::InspectorDOMAgent::getAttributes):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
* inspector/InspectorDOMStorageAgent.h:
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
* inspector/InspectorDatabaseAgent.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionLocation):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getDOMNodeCount):
* inspector/InspectorMemoryAgent.h:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
* inspector/InspectorPageAgent.h:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore::InspectorProfilerAgent::getProfile):
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):
* inspector/InspectorProfilerAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):
* inspector/InspectorRuntimeAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Extensions API] allow setting extension API per extension security...
caseq@chromium.org [Tue, 20 Dec 2011 13:42:35 +0000 (13:42 +0000)]
Web Inspector: [Extensions API] allow setting extension API per extension security origin
https://bugs.webkit.org/show_bug.cgi?id=74868

Reviewed by Pavel Feldman.

This replaces InspectorExtensionAPI string within InspectorFrontendHost with a map by extension
security origin, so that we can have APIs customized by extension (in particular, this is needed
to expose experimental APIs only to certain extensions).

* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::didClearWindowObjectInWorld):
(WebCore::InspectorAgent::setInjectedScriptForOrigin):
* inspector/InspectorAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::setInjectedScriptForOrigin):
* inspector/InspectorController.h:
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::setInjectedScriptForOrigin):
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.idl:
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._addExtensions):
(WebInspector.ExtensionServer.prototype._addExtension):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2]REGRESSION(r103310): It broke tst_QQuickWebView::loadNonexistentFileUrl...
jesus@webkit.org [Tue, 20 Dec 2011 13:36:14 +0000 (13:36 +0000)]
[Qt][WK2]REGRESSION(r103310): It broke tst_QQuickWebView::loadNonexistentFileUrl() API test
https://bugs.webkit.org/show_bug.cgi?id=74923

Rubber-stamped by Csaba Osztrogonác.

Fixing API usage after http://trac.webkit.org/changeset/103310.

* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::loadNonexistentFileUrl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Favicon support should work with multiple web contexts
hausmann@webkit.org [Tue, 20 Dec 2011 13:31:53 +0000 (13:31 +0000)]
[Qt] Favicon support should work with multiple web contexts
https://bugs.webkit.org/show_bug.cgi?id=74922

Reviewed by Tor Arne Vestbø.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize): Remove unnecessary use of QtWebContext::defaultContext(). There is
already a member variable "context" which is the correct one.
(QQuickWebViewPrivate::setIcon): Ditto.
* UIProcess/API/qt/qwebiconimageprovider.cpp:
(QWebIconImageProvider::requestImage): Extract the context id from the image id and use it to
query the correct icon database.
* UIProcess/qt/QtWebContext.cpp: Provide a mapping from id to qtwebcontext.
(WebKit::generateContextID):
(WebKit::QtWebContext::QtWebContext):
(WebKit::QtWebContext::~QtWebContext):
(WebKit::QtWebContext::contextByID):
(WebKit::QtWebContext::initialize):
* UIProcess/qt/QtWebContext.h:
(WebKit::QtWebContext::context):
(WebKit::QtWebContext::contextID):
* UIProcess/qt/QtWebIconDatabaseClient.cpp:
(QtWebIconDatabaseClient::QtWebIconDatabaseClient):
(QtWebIconDatabaseClient::requestIconForPageURL): Store the context id in the icon url.
* UIProcess/qt/QtWebIconDatabaseClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: CodeGenerator should not use pointers for out params of RefPtr type.
loislo@chromium.org [Tue, 20 Dec 2011 13:20:28 +0000 (13:20 +0000)]
Web Inspector: CodeGenerator should not use pointers for out params of RefPtr type.
https://bugs.webkit.org/show_bug.cgi?id=69366

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-12-20
Reviewed by Pavel Feldman.

Generator fixed and all usages are changed manually.

* inspector/CodeGeneratorInspector.py:
(RawTypes.BaseType.is_event_param_check_optional):
(RawTypes.BaseType):
(RawTypes.BaseType.get_output_argument_prefix):
(RawTypes.Object.get_output_argument_prefix):
(RawTypes.Array.get_output_argument_prefix):
(RawTypes):
(Generator.process_command):
* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::getApplicationCacheForFrame):
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::getStyleSheet):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):
(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
(WebCore::InspectorCSSAgent::stopSelectorProfiler):
(WebCore::InspectorCSSAgent::stopSelectorProfilerImpl):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::resolveNode):
(WebCore::InspectorDOMAgent::getAttributes):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
* inspector/InspectorDOMStorageAgent.h:
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
* inspector/InspectorDatabaseAgent.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionLocation):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getDOMNodeCount):
* inspector/InspectorMemoryAgent.h:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
* inspector/InspectorPageAgent.h:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore::InspectorProfilerAgent::getProfile):
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):
* inspector/InspectorProfilerAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):
* inspector/InspectorRuntimeAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Change default WebSocket protocol to the latest one
yutak@chromium.org [Tue, 20 Dec 2011 13:17:17 +0000 (13:17 +0000)]
[GTK] Change default WebSocket protocol to the latest one
https://bugs.webkit.org/show_bug.cgi?id=74064

Reviewed by Martin Robinson.

* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
Use hybi WebSocket protocol by default.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] HTTP header injection via QWebPage::userAgentForUrl()
jarred@sencha.com [Tue, 20 Dec 2011 12:56:06 +0000 (12:56 +0000)]
[Qt] HTTP header injection via QWebPage::userAgentForUrl()
https://bugs.webkit.org/show_bug.cgi?id=68560

Strip out newline characters from the result of userAgentForUrl() to prevent additional
HTTP headers in HTTP requests.

New QtTest case that validates the user agent, as returned by navigator.userAgent, does not
contain any newline characters.

Reviewed by Simon Hausmann.

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::userAgent):
* tests/qwebpage/tst_qwebpage.cpp:
(CustomUserAgentWebPage::userAgentForUrl):
(tst_QWebPage::userAgentNewlineStripping):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Tue, 20 Dec 2011 12:49:30 +0000 (12:49 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-mac/Skipped: Skip failing and crashing tests to try to paint the bot green.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103319 268f45cc-cd09-0410-ab3c-d52691b4dbfc