WebKit-https.git
10 years ago2011-04-08 Jamie Cooley <james.cooley@nokia.com>
commit-queue@webkit.org [Fri, 8 Apr 2011 15:38:04 +0000 (15:38 +0000)]
2011-04-08  Jamie Cooley  <james.cooley@nokia.com>

        Reviewed by Benjamin Poulain.

        [Qt][WK2] Make sure qwkhistory.h is copied into includes/WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=57945

        * UIProcess/API/qt/WKView.h:
        * UIProcess/API/qt/qwkhistory.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build warning fix.
jberlin@webkit.org [Fri, 8 Apr 2011 15:30:14 +0000 (15:30 +0000)]
Windows build warning fix.

* WebCore.vcproj/WebCore.vcproj:
Since ShadowRoot.cpp is included in the DOMAllInOne.cpp file, it should be excluded from
the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Yi Shen <yi.4.shen@nokia.com>
yi.4.shen@nokia.com [Fri, 8 Apr 2011 15:24:07 +0000 (15:24 +0000)]
2011-04-08  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt]REGRESSION(r82243): fast/events/onsearch-enter.html fails
        https://bugs.webkit.org/show_bug.cgi?id=57472

        Unskips the fast/events/onsearch-enter.html test.

        * platform/qt/Skipped:
2011-04-08  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt]REGRESSION(r82243): fast/events/onsearch-enter.html fails
        https://bugs.webkit.org/show_bug.cgi?id=57472

        Avoid to insert new line for both keydown event & keypress event.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleInputMethodKeydown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 8 Apr 2011 15:10:18 +0000 (15:10 +0000)]
2011-04-07  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: update breakpoints according to source frame decorations after live edit.
        https://bugs.webkit.org/show_bug.cgi?id=58029

        * inspector/debugger/live-edit-expected.txt:
        * inspector/debugger/live-edit.html:
2011-04-07  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: update breakpoints according to source frame decorations after live edit.
        https://bugs.webkit.org/show_bug.cgi?id=58029

        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype._updateResourceContent.didEditScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype._updateResourceContent):
        * inspector/front-end/SourceFile.js:
        (WebInspector.SourceFile.prototype.set content):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._handleSave.didEditScriptSource):
        (WebInspector.SourceFrame.prototype._handleSave):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 8 Apr 2011 15:03:20 +0000 (15:03 +0000)]
2011-04-08  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: fix scripts concatenation in scripts panel.
        https://bugs.webkit.org/show_bug.cgi?id=58138

        When there is just one script starting at 0:0 it should not be surrounded by <script> framing.

        * inspector/front-end/SourceFile.js:
        (WebInspector.SourceFile.prototype._loadResourceContent):
        (WebInspector.SourceFile.prototype._loadAndConcatenateScriptsContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Steve Block <steveblock@google.com>
steveblock@google.com [Fri, 8 Apr 2011 14:22:53 +0000 (14:22 +0000)]
2011-04-08  Steve Block  <steveblock@google.com>

        Unreviewed build fix.

        Media Stream API: add the getUserMedia method and the Javascript bindings
        https://bugs.webkit.org/show_bug.cgi?id=56586

        Add new tests to skipped lists for platforms where the feature is not
        enabled.

        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 8 Apr 2011 14:07:32 +0000 (14:07 +0000)]
2011-04-08  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Update Chromium test expectations to match results after rolling
        v8 revision that reports stack overflow exception to the console.

        * platform/chromium-win/fast/dom/error-to-string-stack-overflow-expected.txt: Removed.
        * platform/chromium-win/fast/js/recursion-limit-equal-expected.txt: Removed.
        * platform/chromium/fast/dom/error-to-string-stack-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/error-to-string-stack-overflow-expected.txt.
        * platform/chromium/fast/js/recursion-limit-equal-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/js/recursion-limit-equal-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 8 Apr 2011 12:36:57 +0000 (12:36 +0000)]
2011-04-08  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: use "locations" for debugger scripts, "lineNumbers" for the UI elements.
        https://bugs.webkit.org/show_bug.cgi?id=58118

        This change reuses location for call frames in the protocol + structures script
        location <-> source lines interaction better. When we need UI columns, we will add
        them, but we should distinguish between script and UI terms on the type level, not naming.

        * English.lproj/localizedStrings.js:
        * bindings/v8/DebuggerScript.js:
        * inspector/InjectedScriptSource.js:
        * inspector/Inspector.json:
        * inspector/front-end/CallStackSidebarPane.js:
        (WebInspector.CallStackSidebarPane.prototype.update.didGetSourceLine):
        (WebInspector.CallStackSidebarPane.prototype.update):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage.didRequestSourceMapping):
        (WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage):
        (WebInspector.DebuggerPresentationModel.prototype.continueToLine):
        (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping):
        (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
        (WebInspector.PresenationCallFrame):
        (WebInspector.PresenationCallFrame.prototype.sourceLine.didRequestSourceMapping):
        (WebInspector.PresenationCallFrame.prototype.sourceLine):
        * inspector/front-end/ScriptFormatter.js:
        (WebInspector.ScriptFormatter.locationToPosition):
        (WebInspector.ScriptFormatter.lineToPosition):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
        (WebInspector.ScriptsPanel.prototype._debuggerPaused):
        (WebInspector.ScriptsPanel.prototype.showAnchorLocation):
        (WebInspector.ScriptsPanel.prototype._callFrameSelected.didGetSourceLocation):
        (WebInspector.ScriptsPanel.prototype._callFrameSelected):
        * inspector/front-end/SourceFile.js:
        (WebInspector.SourceMapping.prototype.scriptLocationToSourceLine):
        (WebInspector.SourceMapping.prototype.sourceLineToScriptLocation):
        (WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLine):
        (WebInspector.FormattedSourceMapping.prototype.sourceLineToScriptLocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 8 Apr 2011 12:34:30 +0000 (12:34 +0000)]
2011-04-08  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: distinguish breakpoints set on de-obfuscated sources from breakponts set on original sources.
        https://bugs.webkit.org/show_bug.cgi?id=58133

        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
        (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
        (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
        (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId):
        (WebInspector.DebuggerPresentationModel.prototype._createSourceFileId):
        (WebInspector.DebuggerPresentationModel.prototype._reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 8 Apr 2011 12:31:41 +0000 (12:31 +0000)]
2011-04-07  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: make SourceFrame TextViewer's delegate for editing operations.
        https://bugs.webkit.org/show_bug.cgi?id=58026

        This is the first step of decoupling TextViewer from SourceFrame.

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame):
        (WebInspector.SourceFrame.prototype.show):
        (WebInspector.SourceFrame.prototype.hide):
        (WebInspector.SourceFrame.prototype._ensureContentLoaded):
        (WebInspector.SourceFrame.prototype.contentEditable):
        (WebInspector.SourceFrame.prototype.startEditing):
        (WebInspector.SourceFrame.prototype.endEditing):
        (WebInspector.SourceFrame.prototype._createTextViewer):
        (WebInspector.SourceFrame.prototype._handleSave):
        (WebInspector.SourceFrame.prototype._handleRevertEditing):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype._enterInternalTextChangeMode):
        (WebInspector.TextViewer.prototype._exitInternalTextChangeMode):
        (WebInspector.TextViewer.prototype._syncDecorationsForLine):
        (WebInspector.TextViewer.prototype._doubleClick):
        (WebInspector.TextViewerDelegate):
        (WebInspector.TextViewerDelegate.prototype.contentEditable):
        (WebInspector.TextViewerDelegate.prototype.startEditing):
        (WebInspector.TextViewerDelegate.prototype.endEditing):
        (WebInspector.TextEditorMainPanel.prototype._paintScheduledLines):
        (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
        * inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Leandro Gracia Gil <leandrogracia@chromium.org>
steveblock@google.com [Fri, 8 Apr 2011 12:09:05 +0000 (12:09 +0000)]
2011-04-08  Leandro Gracia Gil  <leandrogracia@chromium.org>

        Reviewed by Steve Block.

        Media Stream API: add the getUserMedia method and the Javascript bindings.
        https://bugs.webkit.org/show_bug.cgi?id=56586

        Test the Javascript behaviour of the getUserMedia method with different types of arguments.
        Current specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#video-conferencing-and-peer-to-peer-communication

        * fast/dom/MediaStream/argument-types-expected.txt: Added.
        * fast/dom/MediaStream/argument-types.html: Added.
        * fast/dom/MediaStream/enabled-expected.txt: Added.
        * fast/dom/MediaStream/enabled.html: Added.
        * fast/dom/MediaStream/no-interface-object-expected.txt: Added.
        * fast/dom/MediaStream/no-interface-object.html: Added.
        * fast/dom/MediaStream/script-tests/argument-types.js: Added.
        (shouldNotThrow):
        (test):
        (emptyFunction):
        ():
        (ObjectThrowingException.prototype.valueOf):
        (ObjectThrowingException.prototype.toString):
        * fast/dom/MediaStream/script-tests/enabled.js: Added.
        (hasGetUserMediaProperty):
        * fast/dom/MediaStream/script-tests/no-interface-object.js: Added.
        (test):
2011-04-08  Leandro Gracia Gil  <leandrogracia@chromium.org>

        Reviewed by Steve Block.

        Media Stream API: add the getUserMedia method and the Javascript bindings.
        https://bugs.webkit.org/show_bug.cgi?id=56586

        Add the getUserMedia method to the navigator and its new Javascript types.
        Current specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#video-conferencing-and-peer-to-peer-communication

        Tests: fast/dom/MediaStream/argument-types.html
               fast/dom/MediaStream/enabled.html
               fast/dom/MediaStream/no-interface-object.html

        * Android.derived.jscbindings.mk:
        * Android.derived.v8bindings.mk:
        * Android.v8bindings.mk:
        * CMakeLists.txt:
        * CodeGenerators.pri:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSNavigatorCustom.cpp:
        (WebCore::JSNavigator::webkitGetUserMedia):
        * bindings/v8/custom/V8NavigatorCustom.cpp: Added.
        (WebCore::V8Navigator::webkitGetUserMediaCallback):
        * page/Navigator.cpp:
        (WebCore::Navigator::webkitGetUserMedia):
        * page/Navigator.h:
        * page/Navigator.idl:
        * page/NavigatorUserMediaError.h: Added.
        (WebCore::NavigatorUserMediaError::NavigatorUserMediaError):
        (WebCore::NavigatorUserMediaError::~NavigatorUserMediaError):
        (WebCore::NavigatorUserMediaError::code):
        * page/NavigatorUserMediaError.idl: Added.
        * page/NavigatorUserMediaErrorCallback.h: Added.
        (WebCore::NavigatorUserMediaErrorCallback::~NavigatorUserMediaErrorCallback):
        * page/NavigatorUserMediaErrorCallback.idl: Added.
        * page/NavigatorUserMediaSuccessCallback.h: Added.
        (WebCore::NavigatorUserMediaSuccessCallback::~NavigatorUserMediaSuccessCallback):
        * page/NavigatorUserMediaSuccessCallback.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Fri, 8 Apr 2011 11:40:01 +0000 (11:40 +0000)]
2011-04-08  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Add more tests for detailed heap snapshots UI.
        https://bugs.webkit.org/show_bug.cgi?id=58010
        https://bugs.webkit.org/show_bug.cgi?id=58011

        Added tests for "Containment" view. Minor refactorings, bugs fixed.
        Split one large tests into smaller ones to avoid timing out in debug mode.

        Tests: inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting.html
               inspector/profiler/detailed-heapshots-containment-show-all.html
               inspector/profiler/detailed-heapshots-containment-show-next.html
               inspector/profiler/detailed-heapshots-containment-sorting.html
               inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html
               inspector/profiler/detailed-heapshots-summary-show-all.html
               inspector/profiler/detailed-heapshots-summary-show-next.html
               inspector/profiler/detailed-heapshots-summary-sorting.html

        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotGridNode):
        (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
        (WebInspector.HeapSnapshotGridNode.prototype.sort.doSort):
        (WebInspector.HeapSnapshotGridNode.prototype.sort):
        (WebInspector.HeapSnapshotGenericObjectNode):
        (WebInspector.HeapSnapshotObjectNode):
        (WebInspector.HeapSnapshotInstanceNode):
        (WebInspector.HeapSnapshotConstructorNode):
        (WebInspector.HeapSnapshotDiffNode):
        (WebInspector.HeapSnapshotDominatorObjectNode):
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.HeapSnapshotContainmentDataGrid):
        (WebInspector.HeapSnapshotDominatorsDataGrid):

2011-04-08  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Add more tests for detailed heap snapshots UI.
        https://bugs.webkit.org/show_bug.cgi?id=58010
        https://bugs.webkit.org/show_bug.cgi?id=58011

        Added tests for "Containment" view. Minor refactorings, bugs fixed.
        Split one large tests into smaller ones to avoid timing out in debug mode.

        * inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting.html: Added.
        * inspector/profiler/detailed-heapshots-containment-show-all-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-containment-show-all.html: Added.
        * inspector/profiler/detailed-heapshots-containment-show-next-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-containment-show-next.html: Added.
        * inspector/profiler/detailed-heapshots-containment-sorting-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-containment-sorting.html: Added.
        * inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html: Added.
        * inspector/profiler/detailed-heapshots-summary-expected.txt: Removed.
        * inspector/profiler/detailed-heapshots-summary-show-all-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-summary-show-all.html: Added.
        * inspector/profiler/detailed-heapshots-summary-show-next-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-summary-show-next.html: Added.
        * inspector/profiler/detailed-heapshots-summary-sorting-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-summary-sorting.html: Added.
        * inspector/profiler/detailed-heapshots-summary.html: Removed.
        * inspector/profiler/detailed-heapshots-test.js:
        (initialize_DetailedHeapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled):
        (initialize_DetailedHeapshotTest.InspectorTest.startProfilerTest):
        (initialize_DetailedHeapshotTest.):
        (initialize_DetailedHeapshotTest):
        * platform/chromium/inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting-expected.txt: Copied from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-expected.txt.
        * platform/chromium/inspector/profiler/detailed-heapshots-containment-show-all-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-containment-show-next-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-containment-sorting-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-expected.txt.
        * platform/chromium/inspector/profiler/detailed-heapshots-summary-show-all-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-summary-show-next-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-summary-sorting-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Andrey Adaikin <aandrey@google.com>
podivilov@chromium.org [Fri, 8 Apr 2011 11:22:00 +0000 (11:22 +0000)]
2011-04-08  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Bugs in some corner cases in the text editor
        https://bugs.webkit.org/show_bug.cgi?id=58025

        This solves the following bugs:
        1) The very last _empty_ line would not be deleted if you hit a Backspace on it, or the selection text to be deleted is extended to the very bottom of the editor.
        2) An odd corner case: delete all source code from the editor, hit backspace on the only empty line, then add a character. In this case the browser will insert a TEXT node instead of a DIV node for a lineRow.

        * inspector/front-end/TextViewer.js:
        (WebInspector.TextEditorMainPanel.prototype._selectionToPosition):
        (WebInspector.TextEditorMainPanel.prototype._enclosingLineRowOrSelf):
        (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
        (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
        (WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 8 Apr 2011 11:20:29 +0000 (11:20 +0000)]
2011-04-07  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: add test for script formatter worker.
        https://bugs.webkit.org/show_bug.cgi?id=57447

        * inspector/debugger/script-formatter-expected.txt: Added.
        * inspector/debugger/script-formatter.html: Added.
        * platform/chromium/test_expectations.txt:
2011-04-07  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: add test for script formatter worker.
        https://bugs.webkit.org/show_bug.cgi?id=57447

        Test: inspector/debugger/script-formatter.html

        * GNUmakefile.am:
        * WebCore.xcodeproj/project.pbxproj:
        * gyp/streamline-inspector-source.sh:
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype._addScript):
        (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
        (WebInspector.DebuggerPresentationModel.prototype._formatter):
        * inspector/front-end/ScriptFormatterWorker.js:
2011-04-07  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: add test for script formatter worker.
        https://bugs.webkit.org/show_bug.cgi?id=57447

        * WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 8 Apr 2011 11:13:21 +0000 (11:13 +0000)]
2011-04-08  Kent Tamura  <tkent@chromium.org>

        [Chromium] Note some flaky tests.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 8 Apr 2011 10:52:32 +0000 (10:52 +0000)]
2011-04-08  Kent Tamura  <tkent@chromium.org>

        [Chromium] The second attempt of fixing for Windows (dbg)(shared) build.

        * WebKit.gyp: webkit should not depend on webkit_support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Fri, 8 Apr 2011 10:35:28 +0000 (10:35 +0000)]
2011-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Do not destroy WorkQueue event sources unless they have been cancelled
        https://bugs.webkit.org/show_bug.cgi?id=57611

        * Platform/WorkQueue.h:
        * Platform/gtk/WorkQueueGtk.cpp:
        (WorkQueue::EventSource::EventSource): Remove unused member
        m_dispatchSource.
        (WorkQueue::EventSource::executeEventSource): Make it return void
        instead of boolean since we are always ignoring the return value.
        (WorkQueue::EventSource::performWork): Return FALSE from the
        callback only when the source has been cancelled (condition = 0)
        to make sure it's destroyed when the even source handler is
        unregistered.
        (WorkQueue::registerEventSourceHandler): Use GRefPtr for the
        source, to avoid leaking it.
        (WorkQueue::scheduleWorkOnSource): Receive the source callback as
        parameter so that it can be used by scheduleWorkOnTermination() too.
        (WorkQueue::scheduleWork):
        (WorkQueue::scheduleWorkAfterDelay):
        (WorkQueue::scheduleWorkOnTermination): Use
        scheduleWorkOnSource().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Fri, 8 Apr 2011 10:28:29 +0000 (10:28 +0000)]
2011-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Close connection when web process finishes
        https://bugs.webkit.org/show_bug.cgi?id=57540

        * Platform/CoreIPC/Connection.h:
        * Platform/CoreIPC/unix/ConnectionUnix.cpp:
        * Platform/PlatformProcessIdentifier.h: Use GPid as process
        identifier.
        * Platform/WorkQueue.h:
        * Platform/gtk/WorkQueueGtk.cpp:
        (WorkQueue::EventSource::EventSource): Add cancellable parameter.
        (WorkQueue::EventSource::cancel): New method to cancel the source.
        (WorkQueue::EventSource::performWorkOnTermination): New method to
        execute a work item called when child process has finished.
        (WorkQueue::registerEventSourceHandler): Create a GCancellable for
        the socket source.
        (WorkQueue::unregisterEventSourceHandler): Cancel the source
        instead of destroying it, this will cause the source to trigger
        with condition = 0, which makes the callback return FALSE and the
        source is destroyed.
        (WorkQueue::scheduleWorkOnSource): Pass NULL as cancellable for
        idle and timeout sources.
        (WorkQueue::scheduleWorkOnTermination): Create a child watch
        source to monitor the child process.
        * UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
        (WebKit::ProcessLauncher::launchProcess): Use GPid instead of int
        as process identifier.
        * UIProcess/WebProcessProxy.cpp:
        (WebKit::WebProcessProxy::didFinishLaunching): Call
        WorkQueue::scheduleWorkOnTermination() for GTK platform too when
        web process has been launched.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 8 Apr 2011 10:28:28 +0000 (10:28 +0000)]
2011-04-08  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Adjusted test expectations following r83275.

        * http/tests/inspector/resource-har-conversion-expected.txt:
        * http/tests/inspector/resource-parameters-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Fri, 8 Apr 2011 10:17:00 +0000 (10:17 +0000)]
2011-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Implement scheduleWorkAfterDelay() in WorkQueueGtk
        https://bugs.webkit.org/show_bug.cgi?id=57434

        * Platform/WorkQueue.h:
        * Platform/gtk/WorkQueueGtk.cpp:
        (WorkQueue::EventSource::executeEventSource): This new method
        contains the common code to execute a work item.
        (WorkQueue::EventSource::performWorkOnce): Use
        executeEventSource() to execute the work item.
        (WorkQueue::EventSource::performWork): Use executeEventSource() to
        execute the work item.
        (WorkQueue::registerEventSourceHandler): Use a GSocket instead of
        a GIOChannel since the API is newer and allows us to pass a
        cancellable object to be able to cancel the source.
        (WorkQueue::scheduleWorkOnSource): This new method contains the
        common code to attach a source to a context. It doesn't use a lock
        anymore, since g_source_attach() uses its own mutex internally.
        (WorkQueue::scheduleWork): Use an idle source instead of a timeout
        one, changing the priority to G_PRIORITY_DEFAULT.
        (WorkQueue::scheduleWorkAfterDelay): Implement it using a timeout
        source with the given delay.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Fri, 8 Apr 2011 10:06:24 +0000 (10:06 +0000)]
2011-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Use glib API instead of fork + execl in ProcessLauncherGtk
        https://bugs.webkit.org/show_bug.cgi?id=57234

        * UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
        (WebKit::childSetupFunction): close the socket and use prctl()
        when platform is Linux to kill the child process when the parent
        finishes.
        (WebKit::ProcessLauncher::launchProcess): Use g_spawn_async() to
        launch the web process.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Andrey Adaikin <aandrey@google.com>
podivilov@chromium.org [Fri, 8 Apr 2011 09:55:03 +0000 (09:55 +0000)]
2011-04-08  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Tweak dynamically constants for the async highlighting in text editor
        https://bugs.webkit.org/show_bug.cgi?id=58035

        * inspector/front-end/TextViewer.js:
        (WebInspector.TextEditorMainPanel.prototype._expandChunks):
        (WebInspector.TextEditorMainPanel.prototype._schedulePaintLines):
        (WebInspector.TextEditorMainPanel.prototype._paintScheduledLines):
        (WebInspector.TextEditorMainPanel.prototype._restorePaintLinesOperationsCredit):
        (WebInspector.TextEditorMainPanel.prototype._adjustPaintLinesOperationsRefreshValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 8 Apr 2011 09:48:46 +0000 (09:48 +0000)]
2011-04-08  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: HAR compliance fixes
        https://bugs.webkit.org/show_bug.cgi?id=58124

        - Always provide some values for queryString and cookies, even though arrays may be empty
        - Always provide an empty cache object
        - Added entire HARLog to test
        - Workaround in test to avoid custom expectations (favicon.ico appears in log on certain platforms)

        * inspector/front-end/HAREntry.js:
        (WebInspector.HAREntry.prototype.build):
        (WebInspector.HAREntry.prototype._buildRequest):
        (WebInspector.HAREntry.prototype._buildResponse):

2011-04-08  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: HAR compliance fixes
        https://bugs.webkit.org/show_bug.cgi?id=58124

        - Added entire HARLog to test
        - Workaround in test to avoid custom expectations (favicon.ico appears in log on certain platforms

        * http/tests/inspector/resource-har-conversion-expected.txt:
        * http/tests/inspector/resource-har-conversion.html:
        * http/tests/inspector/resources-test.js:
        * platform/mac-wk2/http/tests/inspector/resource-har-conversion-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 8 Apr 2011 09:28:25 +0000 (09:28 +0000)]
2011-04-08  Kent Tamura  <tkent@chromium.org>

        [Chromium] Build fix for Windows (dbg)(shared).

        * WebKit.gyp: Add webkit_support dependency, which is required for webkit_unittest_files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 8 Apr 2011 09:26:16 +0000 (09:26 +0000)]
2011-04-08  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed, added new GTK+ test expectations.

        * platform/gtk/fast/block/positioning/complex-positioned-movement-expected.checksum: Added.
        * platform/gtk/fast/block/positioning/complex-positioned-movement-expected.png: Added.
        * platform/gtk/fast/block/positioning/complex-positioned-movement-expected.txt: Added.
        * platform/gtk/fast/text/decorations-transformed-expected.checksum: Added.
        * platform/gtk/fast/text/decorations-transformed-expected.png: Added.
        * platform/gtk/fast/text/decorations-transformed-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Dominic Cooney <dominicc@google.com>
commit-queue@webkit.org [Fri, 8 Apr 2011 09:26:02 +0000 (09:26 +0000)]
2011-04-08  Dominic Cooney  <dominicc@google.com>

        Reviewed by Kent Tamura.

        layoutTestController.shadowRoot should return undefined if its
        argument is not an element.
        https://bugs.webkit.org/show_bug.cgi?id=58119

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::shadowRoot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Fri, 8 Apr 2011 09:15:17 +0000 (09:15 +0000)]
2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
        https://bugs.webkit.org/show_bug.cgi?id=58039

        Implemented missing functions in GTK's DRT.

        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (modifyAccessibilityValue): Helper function to increment or decrement
        the current value for an object through the AccessibilityObject's API.
        (DumpRenderTreeSupportGtk::incrementAccessibilityValue): New function,
        to be used from GTK's DRT.
        (DumpRenderTreeSupportGtk::decrementAccessibilityValue): Ditto.
2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
        https://bugs.webkit.org/show_bug.cgi?id=58039

        Implement missing functions in GTK's DRT.

        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
        (AccessibilityUIElement::increment): Implemented.
        (AccessibilityUIElement::decrement): Implemented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Dominic Cooney <dominicc@google.com>
commit-queue@webkit.org [Fri, 8 Apr 2011 09:04:42 +0000 (09:04 +0000)]
2011-04-08  Dominic Cooney  <dominicc@google.com>

        Reviewed by Kent Tamura.

        Make WK2 layoutTestController.shadowRoot return undefined, not
        null, when its argument is not an element.
        https://bugs.webkit.org/show_bug.cgi?id=58121

        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::shadowRoot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Fri, 8 Apr 2011 08:47:01 +0000 (08:47 +0000)]
2011-04-08  Anton Muhin  <antonm@chromium.org>

        Reviewed by Adam Barth.

        [v8] Change expectations for plugins/netscape-plugin-poperty-access-exception test
        https://bugs.webkit.org/show_bug.cgi?id=54681

        This a patch which should be landed when fix for exception handling in v8 is landed
        (see http://codereview.chromium.org/6397011/)

        * platform/chromium-mac/plugins/netscape-plugin-property-access-exception-expected.txt:
        * platform/chromium-win/plugins/netscape-plugin-property-access-exception-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 8 Apr 2011 07:53:11 +0000 (07:53 +0000)]
2011-04-08  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        dump-as-markup conversion: editing/pasteboard/5065605.html and display-block-on-spans.html
        https://bugs.webkit.org/show_bug.cgi?id=58074

        Converted 5065605.html and display-block-on-spans.html to dump-as-markup tests.

        * editing/pasteboard/5065605-expected.txt: Added.
        * editing/pasteboard/5065605.html:
        * editing/pasteboard/display-block-on-spans-expected.txt: Added.
        * editing/pasteboard/display-block-on-spans.html:
        * platform/chromium-linux/editing/pasteboard/5065605-expected.checksum: Removed.
        * platform/chromium-linux/editing/pasteboard/5065605-expected.png: Removed.
        * platform/chromium-linux/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
        * platform/chromium-linux/editing/pasteboard/display-block-on-spans-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/5065605-expected.checksum: Removed.
        * platform/chromium-win/editing/pasteboard/5065605-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/5065605-expected.txt: Removed.
        * platform/chromium-win/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
        * platform/chromium-win/editing/pasteboard/display-block-on-spans-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/display-block-on-spans-expected.txt: Removed.
        * platform/gtk/editing/pasteboard/5065605-expected.checksum: Removed.
        * platform/gtk/editing/pasteboard/5065605-expected.png: Removed.
        * platform/gtk/editing/pasteboard/5065605-expected.txt: Removed.
        * platform/gtk/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
        * platform/gtk/editing/pasteboard/display-block-on-spans-expected.png: Removed.
        * platform/gtk/editing/pasteboard/display-block-on-spans-expected.txt: Removed.
        * platform/mac-leopard/editing/pasteboard/5065605-expected.checksum: Removed.
        * platform/mac-leopard/editing/pasteboard/5065605-expected.png: Removed.
        * platform/mac-leopard/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
        * platform/mac-leopard/editing/pasteboard/display-block-on-spans-expected.png: Removed.
        * platform/mac/editing/pasteboard/5065605-expected.checksum: Removed.
        * platform/mac/editing/pasteboard/5065605-expected.png: Removed.
        * platform/mac/editing/pasteboard/5065605-expected.txt: Removed.
        * platform/mac/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
        * platform/mac/editing/pasteboard/display-block-on-spans-expected.png: Removed.
        * platform/mac/editing/pasteboard/display-block-on-spans-expected.txt: Removed.
        * platform/qt/editing/pasteboard/5065605-expected.txt: Removed.
        * platform/qt/editing/pasteboard/display-block-on-spans-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Add platform specific expected file after r83235.
ossy@webkit.org [Fri, 8 Apr 2011 07:46:36 +0000 (07:46 +0000)]
[Qt] Add platform specific expected file after r83235.

* platform/qt/http/tests/security/contentSecurityPolicy: Added.
* platform/qt/http/tests/security/contentSecurityPolicy/xsl-allowed-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/xsl-allowed-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 8 Apr 2011 07:38:14 +0000 (07:38 +0000)]
2011-04-08  Kent Tamura  <tkent@chromium.org>

        [Chromium] Update expectations for r82899 and r83253.

        * platform/chromium-mac-leopard/fast/borders/border-radius-huge-assert-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/borders/border-radius-huge-assert-expected.png:
        * platform/chromium-mac-leopard/fast/box-shadow/border-radius-big-expected.png: Added.
        * platform/chromium-mac-leopard/fast/box-shadow/spread-multiple-inset-expected.png:
        * platform/chromium-mac/fast/borders/border-radius-circle-expected.png: Added.
        * platform/chromium-mac/fast/borders/border-radius-huge-assert-expected.png: Added.
        * platform/chromium-mac/fast/box-shadow/border-radius-big-expected.png: Added.
        * platform/chromium-mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
        * platform/chromium-mac/fast/box-shadow/spread-expected.png: Added.
        * platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.png: Added.
        * platform/chromium-mac/fast/box-shadow/spread-multiple-normal-expected.png: Added.
        * platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
        * platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
        * platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
        * platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
        * platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFlaky Test: fast/events/tabindex-focus-blur-all.html
ossy@webkit.org [Fri, 8 Apr 2011 07:21:32 +0000 (07:21 +0000)]
Flaky Test: fast/events/tabindex-focus-blur-all.html
https://bugs.webkit.org/show_bug.cgi?id=52115

* platform/qt/Skipped: Add fast/events/tabindex-focus-blur-all.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-08 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 8 Apr 2011 07:05:32 +0000 (07:05 +0000)]
2011-04-08  Adam Barth  <abarth@webkit.org>

        Attempt to fix the Qt build.

        * css/CSSStyleApplyProperty.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 8 Apr 2011 07:00:13 +0000 (07:00 +0000)]
2011-04-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Refactor WebCore/GNUMakefile.am to separate list of files
        https://bugs.webkit.org/show_bug.cgi?id=58116

        This change is similar to the cooresponding to change to
        JavaScriptCore.  We hope to generate GNUmakefile.list.am automatically
        using GYP.

        * GNUmakefile.am:
        * GNUmakefile.list.am: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 8 Apr 2011 06:49:58 +0000 (06:49 +0000)]
2011-04-07  Ryosuke Niwa  <rniwa@webkit.org>

        Chromium rebaseline after r83246.

        * platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed.
ggaren@apple.com [Fri, 8 Apr 2011 06:46:52 +0000 (06:46 +0000)]
Not reviewed.

Rolled out some accidentally-committed changes in my last commit.

* dom/EventTarget.cpp:
(WebCore::EventTarget::addEventListener):
(WebCore::EventTarget::removeEventListener):
* dom/EventTarget.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Julien Chaffraix <jchaffraix@codeaurora.org>
commit-queue@webkit.org [Fri, 8 Apr 2011 06:45:30 +0000 (06:45 +0000)]
2011-04-07  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Alexey Proskuryakov.

        EventSource should only accept UTF-8 charset
        https://bugs.webkit.org/show_bug.cgi?id=56942

        * ChangeLog-2011-02-16: Corrected previous commit message. Pointed out by Alexey.

        * http/tests/eventsource/eventsource-bad-mime-type-expected.txt: Updated with the new console message.

        * http/tests/eventsource/eventsource-content-type-charset-expected.txt:
        * http/tests/eventsource/eventsource-content-type-charset.html: Beefed up this test and merged
        the following test into it. The new tests check that we dispatch a console error if the charset is
        wrong.

        * http/tests/eventsource/eventsource-content-type-text-event-stream-foobar-expected.txt: Removed.
        * http/tests/eventsource/eventsource-content-type-text-event-stream-foobar.html: Removed.

        * http/tests/eventsource/resources/response-content-type-charset.php: Return the charset passed
        in the URL. Also added PHP's magic quotes handling as this would make the test fail on Mac.

        * http/tests/eventsource/resources/response-content-type-event-stream-foobar.php: Removed.
2011-04-07  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Alexey Proskuryakov.

        EventSource should only accept UTF-8 charset
        https://bugs.webkit.org/show_bug.cgi?id=56942

        Following the discussion on bug 45372, this change implements the recommended
        way of handling "charset". We only accept UTF-8 but no other encoding. This matches
        the encoding of the EventSource and also may fix TomCat that automatically send this
        charset.

        * page/EventSource.cpp:
        (WebCore::EventSource::didReceiveResponse): We now check the charset attribute and if it is
        not UTF-8, abort the connection and log the error to the console. Also we log if the MIME type
        is wrong to the console to help debugging (only in the case of an HTTP 200 response though).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 8 Apr 2011 06:34:47 +0000 (06:34 +0000)]
2011-04-07  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Maciej Stachowiak.

        Some Handle<T> cleanup
        https://bugs.webkit.org/show_bug.cgi?id=58109

        * bytecode/SamplingTool.h: Sorted alphabetically because that's the
        WebKit style. Added a Global.h #include that was previously missing
        but harmless.

        * collector/handles/Global.h:
        (JSC::Global::Global): Added a null constructor. No need for a special
        tag, and the tag is incompatible with some data structures.

        (JSC::Global::isHashTableDeletedValue):
        (JSC::Global::~Global):
        (JSC::Global::set):
        (JSC::Global::operator=):
        (JSC::Global::clear):
        (JSC::Global::hashTableDeletedValue): Reordered constructors to be near
        each other.

        (JSC::Global::setWithWriteBarrier): Renamed internalSet to
        setWithWriteBarrier for clarity, and funneled more code into using set
        and setWithWriteBarrier to reduce duplication.

        * collector/handles/Handle.h:
        (JSC::HandleBase::operator!):
        (JSC::HandleBase::HandleBase): Removed isEmpty(), since we already have
        boolean and ! operators.

        (JSC::HandleBase::slot):
        (JSC::HandleBase::setSlot):
        (JSC::Handle::Handle): Added general support for null Handles. This was
        previously outlawed by ASSERTs, but our code has grown to support and
        rely on null Handles.

        * collector/handles/HandleHeap.cpp:
        (JSC::HandleHeap::markWeakHandles):
        (JSC::HandleHeap::finalizeWeakHandles):
        (JSC::HandleHeap::isValidWeakNode): Migrated from isValidWeakHandle,
        and beefed this up a bit.

        * collector/handles/HandleHeap.h:
        (JSC::HandleHeap::globalData): Added accessor, used by some new set functions.

        * collector/handles/Local.h: Moved hash traits to the bottom of the file,
        since this file is about the Local class, not the traits.

        (JSC::::Local): Updated for removal of invalidate().

        (JSC::::operator): Deployed "using" to avoid a lot of this->
        template funny business.

        (JSC::::setWithSlotCheck): Renamed from internalSet, more specific now.

        * interpreter/RegisterFile.h:
        (JSC::RegisterFile::RegisterFile): Updated to use null constructor.

        * jit/JITStubs.cpp:
        (JSC::JITThunks::hostFunctionStub):

        * runtime/JSPropertyNameIterator.h:
        (JSC::Structure::setEnumerationCache):
        * runtime/Structure.h: Removed clearEnumerationCache
        because it was an unused holdover from when the enumeration cache was
        not a handle.

        * runtime/WeakGCMap.h:
        (JSC::WeakGCMap::set): Finish initializing our handle before putting it
        in the table. This seemed more logical, and at one point was required
        to avoid triggering an ASSERT.

        * runtime/WeakGCPtr.h: Inherit from Handle instead of rolling our own
        handle-like behavior, to avoid duplication.

        (JSC::WeakGCPtr::WeakGCPtr):
        (JSC::WeakGCPtr::~WeakGCPtr):
        (JSC::WeakGCPtr::get):
        (JSC::WeakGCPtr::clear):
        (JSC::WeakGCPtr::set):
        (JSC::WeakGCPtr::setWithWriteBarrier): Removed duplicate code and
        standardized on Handle idioms.
2011-04-07  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Maciej Stachowiak.

        Some Handle<T> cleanup
        https://bugs.webkit.org/show_bug.cgi?id=58109

        * JSRun.h:
        * JSValueWrapper.h: #include a file that was missing before, but was
        harmlessly so until now.
2011-04-07  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Maciej Stachowiak.

        Some Handle<T> cleanup
        https://bugs.webkit.org/show_bug.cgi?id=58109

        * bindings/js/ScriptValue.h:
        (WebCore::ScriptValue::ScriptValue): Updated for new null constructor.
        (WebCore::ScriptValue::hasNoValue): Updated for removal of isEmpty().
2011-04-07  Geoffrey Garen  <ggaren@apple.com>

        Some Handle<T> cleanup
        https://bugs.webkit.org/show_bug.cgi?id=58109

        * WebProcess/Plugins/Netscape/NPJSObject.cpp:
        (WebKit::NPJSObject::NPJSObject): Updated for new null constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Fri, 8 Apr 2011 06:34:46 +0000 (06:34 +0000)]
2011-04-07  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Add WebKit API to query and request unified offline-storage quota
        https://bugs.webkit.org/show_bug.cgi?id=57849
        Just adding the API, this does not do anything yet.

        The API is based on the public discussion for unified quota API:
        http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html
        (The detail is not yet fully specified and might be subject to change.)

        * public/WebFrameClient.h:
        (WebKit::WebFrameClient::queryStorageUsageAndQuota): Added.
        (WebKit::WebFrameClient::requestStorageQuota): Added.
        * public/WebStorageQuotaCallbacks.h: Added.
        (WebKit::WebStorageQuotaCallbacks::~WebStorageQuotaCallbacks):
        * public/WebStorageQuotaType.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 8 Apr 2011 06:28:14 +0000 (06:28 +0000)]
2011-04-07  Kent Tamura  <tkent@chromium.org>

        [Chromium] Update expectations for xsl-blocked.php and pate-text-011.html.

        * platform/chromium/http/tests/security/contentSecurityPolicy/xsl-blocked-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Dominic Cooney <dominicc@google.com>
tkent@chromium.org [Fri, 8 Apr 2011 06:03:31 +0000 (06:03 +0000)]
2011-04-07  Dominic Cooney  <dominicc@google.com>

        Reviewed by Dimitri Glazkov.

        Let shadow DOM have a list of nodes at the top level of a shadow.
        https://bugs.webkit.org/show_bug.cgi?id=57813

        * fast/dom/HTMLKeygenElement/keygen-expected.txt: shadow DOM changed
        * fast/dom/HTMLKeygenElement/keygen.html: added assertion on shadow
2011-04-07  Dominic Cooney  <dominicc@google.com>

        Reviewed by Dimitri Glazkov.

        Let shadow DOM have a list of nodes at the top level of a shadow.
        https://bugs.webkit.org/show_bug.cgi?id=57813

        Adds ShadowRoot, a list of nodes, to be a parent for top-level
        shadow children. Forwards rendering through the root and into the
        host's renderer.

        Covered by existing tests of elements that use this style of shadow.

        * Android.mk: add ShadowRoot.h/cpp
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.exp.in:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::initForStyleResolve): proxy style to host
        * dom/ContainerNode.cpp: parent nodes that are shadow roots are alive
        (WebCore::ContainerNode::insertBefore):
        (WebCore::ContainerNode::replaceChild):
        (WebCore::ContainerNode::removeChild):
        (WebCore::ContainerNode::appendChild):
        * dom/DocumentFragment.cpp:
        (WebCore::DocumentFragment::DocumentFragment):
        * dom/DocumentFragment.h:
        * dom/Element.cpp:
        (WebCore::Element::recalcStyle): look through ShadowRoots for host's style
        (WebCore::Element::shadowRoot): should be const
        (WebCore::Element::ensureShadowRoot): simpler than setShadowRoot
        * dom/Element.h:
        * dom/ElementRareData.h:
        * dom/Node.cpp:
        (WebCore::Node::parentNodeForRenderingAndStyle): indirection so
          ShadowRoot can forward to the host's renderer
        (WebCore::Node::createRendererAndStyle):
        (WebCore::Node::createRendererIfNeeded):
        * dom/Node.h:
        (WebCore::Node::isShadowBoundary): temporary, to differentiate
          old- and new-style, until all roots are ShadowRoot instances
        * dom/ShadowRoot.cpp: Added.
        (WebCore::ShadowRoot::ShadowRoot):
        (WebCore::ShadowRoot::recalcStyle): forward recalc to children
        * dom/ShadowRoot.h: Added.
        (WebCore::ShadowRoot::isShadowBoundary):
        (WebCore::ShadowRoot::create):
        * html/HTMLKeygenElement.cpp: use ensureShadowRoot
        (WebCore::HTMLKeygenElement::HTMLKeygenElement):
        (WebCore::HTMLKeygenElement::parseMappedAttribute):
        (WebCore::HTMLKeygenElement::appendFormData):
        (WebCore::HTMLKeygenElement::reset):
        (WebCore::HTMLKeygenElement::shadowSelect):
        * html/HTMLKeygenElement.h:
        * html/HTMLMeterElement.cpp: use ensureShadowRoot
        (WebCore::HTMLMeterElement::createShadowSubtree):
        * html/HTMLProgressElement.cpp: use ensureShadowRoot
        (WebCore::HTMLProgressElement::createShadowSubtree):
        * html/InputType.cpp: use ensureShadowRoot
        (WebCore::InputType::destroyShadowSubtree):
        * html/RangeInputType.cpp: use ensureShadowRoot
        (WebCore::RangeInputType::handleMouseDownEvent):
        (WebCore::RangeInputType::createShadowSubtree):
        (WebCore::RangeInputType::valueChanged):
        (WebCore::RangeInputType::shadowSliderThumb):
        * html/RangeInputType.h:
        * html/ValidationMessage.cpp: use ensureShadowRoot
        (WebCore::ValidationMessage::buildBubbleTree):
        (WebCore::ValidationMessage::deleteBubbleTree):
        * html/shadow/SliderThumbElement.cpp:
        (WebCore::SliderThumbElement::setPositionFromPoint):
        (WebCore::SliderThumbElement::hostInput):
        * html/shadow/SliderThumbElement.h:
        * rendering/MediaControlElements.cpp: use ensureShadowRoot
        (WebCore::MediaControlInputElement::attach):
        (WebCore::MediaControlInputElement::updateStyle):
        * rendering/RenderSlider.cpp: use ensureShadowRoot
        (WebCore::RenderSlider::thumbRect):
        (WebCore::RenderSlider::layout):
        (WebCore::RenderSlider::shadowSliderThumb):
        (WebCore::RenderSlider::inDragMode):
        * rendering/RenderSlider.h:
2011-04-07  Dominic Cooney  <dominicc@google.com>

        Reviewed by Dimitri Glazkov.

        Let shadow DOM have a list of nodes at the top level of a shadow.
        https://bugs.webkit.org/show_bug.cgi?id=57813

        * src/WebElement.cpp:
        (WebKit::WebElement::shadowRoot): shadow roots are ContainerNodes now

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 8 Apr 2011 06:01:59 +0000 (06:01 +0000)]
2011-04-07  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Simon Fraser.

        REGRESSION (r80871): Crash when visiting http://broadband.biglobe.ne.jp/
        https://bugs.webkit.org/show_bug.cgi?id=56297
        <rdar://problem/9131597>

        Test: fast/css-generated-content/table-row-after-no-crash.html

        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::styleDidChange): Factor out generation of before/after
        content, and only do it if the row already has a parent. For construction of
        anonymous cells to work correctly, the row needs to already have a parent, so
        in that case wait a bit.
        (WebCore::RenderTableRow::updateBeforeAndAfterContent): Factored out to here.
        * rendering/RenderTableRow.h:
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::addChild): When adding a row, update its
        before/after content, in case it had any.
2011-04-07  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Simon Fraser.

        REGRESSION (r80871): Crash when visiting http://broadband.biglobe.ne.jp/
        https://bugs.webkit.org/show_bug.cgi?id=56297
        <rdar://problem/9131597>

        * fast/css-generated-content/table-row-after-no-crash-expected.txt: Added.
        * fast/css-generated-content/table-row-after-no-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoProbable fix for <rdar://problem/9251443> Crashing on exception: -
bdakin@apple.com [Fri, 8 Apr 2011 05:52:24 +0000 (05:52 +0000)]
Probable fix for <rdar://problem/9251443>  Crashing on exception: -
[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]: unrecognized
selector sent to instance ADDRESS.

Reviewed by Simon Fraser.

       Need to implement new delegate method.
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Ian Henderson <ianh@apple.com>
commit-queue@webkit.org [Fri, 8 Apr 2011 05:38:55 +0000 (05:38 +0000)]
2011-04-07  Ian Henderson  <ianh@apple.com>

        Reviewed by Simon Fraser.

        Optimize filling rounded rects that are actually ellipses
        https://bugs.webkit.org/show_bug.cgi?id=58098

        In CG, drawing an ellipse directly is faster than constructing and
        filling a rounded rect path.  Detect when the given rounded rect is
        actually an ellipse and draw it directly in this case.

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::fillRoundedRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Magnus Danielsson <public@fuzzac.com>
commit-queue@webkit.org [Fri, 8 Apr 2011 04:59:33 +0000 (04:59 +0000)]
2011-04-07  Magnus Danielsson  <public@fuzzac.com>

        Reviewed by Darin Fisher.

        [chromium] WebPageSerializerImpl doesn't serialize sub-frames correctly
        https://bugs.webkit.org/show_bug.cgi?id=53897

        When serializing a web page using 'save page as', sub-frames and resources gets
        saved in a sub-directory. However, frame elements didn't get updated to reference
        these saved sub-frames, but were still referencing the original url. So when opening
        a saved web page, any sub-frames would get pulled in from the original url rather than
        what was saved.

        In addition to this, sub-frames in the sub-directory erroneously had the name of the
        sub-directory prepended to the path of resources located in the same sub-directory.

        * src/WebPageSerializerImpl.cpp:
        (WebKit::WebPageSerializerImpl::openTagToStrne: Fixed resource paths in sub-frames.
        Also made sure sub-frames are referenced correctly from parent frame.
        (WebKit::WebPageSerializerImpl::endTagToString): Removed constness from argument.
        (WebKit::WebPageSerializerImpl::buildContentForNode): Ditto.
        * src/WebPageSerializerImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Ned Holbrook <nholbrook@apple.com>
commit-queue@webkit.org [Fri, 8 Apr 2011 04:38:37 +0000 (04:38 +0000)]
2011-04-07  Ned Holbrook  <nholbrook@apple.com>

        Reviewed by Dan Bernstein.

        CTLine objects should outlive their CTRuns
        https://bugs.webkit.org/show_bug.cgi?id=58063

        * platform/graphics/mac/ComplexTextController.h: Add m_coreTextLines, to be destroyed after m_complexTextRuns.
        * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
        (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Moot m_coreTextRun.
        (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Append line to m_coreTextLines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 8 Apr 2011 04:32:14 +0000 (04:32 +0000)]
2011-04-07  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        Change reference port for Mac GPU baselines from
        Leopard to SnowLeopard, XP to Win7, and Linux-x86
        to Linux x86-64.

        https://bugs.webkit.org/show_bug.cgi?id=58099

        * Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Nat Duca <nduca@chromium.org>
commit-queue@webkit.org [Fri, 8 Apr 2011 04:32:04 +0000 (04:32 +0000)]
2011-04-07  Nat Duca  <nduca@chromium.org>

        Reviewed by David Levin.

        [chromium] Compositor thread infrastructure
        https://bugs.webkit.org/show_bug.cgi?id=56131

        Introduce chrome compositor thread and related
        infrastructure.

        * WebCore.gypi:
        * platform/graphics/chromium/cc/CCMainThread.cpp: Added.
        (WebCore::CCMainThread::performTask):
        (WebCore::CCMainThread::postTask):
        * platform/graphics/chromium/cc/CCMainThread.h: Added.
        (WebCore::CCMainThread::Task::~Task):
        (WebCore::CCMainThread::Task::instance):
        (WebCore::CCMainThread::Task::Task):
        * platform/graphics/chromium/cc/CCMainThreadTask.h: Added.
        (WebCore::MainThreadTask0::create):
        (WebCore::MainThreadTask0::MainThreadTask0):
        (WebCore::MainThreadTask0::performTask):
        (WebCore::MainThreadTask1::create):
        (WebCore::MainThreadTask1::MainThreadTask1):
        (WebCore::MainThreadTask1::performTask):
        (WebCore::MainThreadTask2::create):
        (WebCore::MainThreadTask2::MainThreadTask2):
        (WebCore::MainThreadTask2::performTask):
        (WebCore::MainThreadTask3::create):
        (WebCore::MainThreadTask3::MainThreadTask3):
        (WebCore::MainThreadTask3::performTask):
        (WebCore::createMainThreadTask):
        * platform/graphics/chromium/cc/CCThread.cpp: Added.
        (WebCore::CCThread::create):
        (WebCore::CCThread::CCThread):
        (WebCore::CCThread::~CCThread):
        (WebCore::CCThread::postTask):
        (WebCore::CCThread::compositorThreadStart):
        (WebCore::CCThread::runLoop):
        * platform/graphics/chromium/cc/CCThread.h: Added.
        (WebCore::CCThread::Task::~Task):
        (WebCore::CCThread::Task::instance):
        (WebCore::CCThread::Task::Task):
        (WebCore::CCThread::threadID):
        (WebCore::CCCompletionEvent::CCCompletionEvent):
        (WebCore::CCCompletionEvent::~CCCompletionEvent):
        (WebCore::CCCompletionEvent::wait):
        (WebCore::CCCompletionEvent::signal):
        * platform/graphics/chromium/cc/CCThreadTask.h: Added.
        (WebCore::CCThreadTask0::create):
        (WebCore::CCThreadTask0::CCThreadTask0):
        (WebCore::CCThreadTask0::performTask):
        (WebCore::CCThreadTask1::create):
        (WebCore::CCThreadTask1::CCThreadTask1):
        (WebCore::CCThreadTask1::performTask):
        (WebCore::CCThreadTask2::create):
        (WebCore::CCThreadTask2::CCThreadTask2):
        (WebCore::CCThreadTask2::performTask):
        (WebCore::CCThreadTask3::create):
        (WebCore::CCThreadTask3::CCThreadTask3):
        (WebCore::CCThreadTask3::performTask):
        (WebCore::createCCThreadTask):
2011-04-07  Nat Duca  <nduca@chromium.org>

        Reviewed by David Levin.

        [chromium] Compositor thread infrastructure
        https://bugs.webkit.org/show_bug.cgi?id=56131

        Tests for chrome compositor thread and related infrastructure.

        * WebKit.gyp:
        * WebKit.gypi:
        * tests/CCThreadTaskTest.cpp: Added.
        (WebCore::TEST):
        * tests/CCThreadTest.cpp: Added.
        (WebCore::TEST):
        (WebCore::PingPongUsingCondition::ping):
        (WebCore::PingPongTestUsingTasks::ping):
        (WebCore::PingPongTestUsingTasks::pong):
        * tests/RunAllTests.cpp:
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 8 Apr 2011 04:30:24 +0000 (04:30 +0000)]
2011-04-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Martin Robinson.

        Refactor Gtk build system to separate list of files
        https://bugs.webkit.org/show_bug.cgi?id=58090

        This is the first step towards generating part of the GTK build system
        using GYP.  In the first iteration, our plan is to just generate the
        list of files.  This patch is the first step, which is to separate out
        the part of JavaScriptCore build system that we intend to generate from
        the rest of the build system.

        * GNUmakefile.am:
        * GNUmakefile.list.am: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 8 Apr 2011 04:11:13 +0000 (04:11 +0000)]
2011-04-07  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
        https://bugs.webkit.org/show_bug.cgi?id=57872

        Added tests to ensure WebKit inserts a paragraph separator properly around tab span.

        * editing/inserting/insert-div-021-expected.txt: No longer duplicates span[id="test"] incorrectly.
        * editing/inserting/insert-paragraph-after-tab-span-and-text-expected.txt: Added.
        * editing/inserting/insert-paragraph-after-tab-span-and-text.html: Added.
        * editing/inserting/insert-paragraph-separator-tab-span-expected.txt: Added.
        * editing/inserting/insert-paragraph-separator-tab-span.html: Added.
        * editing/inserting/insert-paragraph-at-end-of-line-expected.txt: No longer duplicates a[id="anchor"] incorrectly.
2011-04-07  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
        https://bugs.webkit.org/show_bug.cgi?id=57872

        r46914 initially introduced a regression by replacing calls to styleAtPosition by editingStyleAtPosition
        because editingStyleAtPosition did not avoid tab span to obtain the computed style unlike styleAtPosition.

        r46914 also introduced a regression by cloning hierarchy under new block at the insertion position without
        avoiding the tab span.

        Fixed the both regressions by avoiding tab spans when computing the editing style and when cloning hierarchy.
        Also reverted r46914 for the general code path because re-creating node hierarchy duplicates nodes when
        we're moving nodes after the paragraph separator. Instead, we now split the tree up until the start block
        before moving the nodes.

        Tests: editing/inserting/insert-paragraph-after-tab-span-and-text.html
               editing/inserting/insert-paragraph-separator-tab-span.html

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::saveTypingStyleState): Since EditingStyle's constructor avoids a tab span,
        no longer calls positionBeforeTabSpan on the position passed to EditingStyle's constructor.
        * editing/EditingStyle.cpp:
        (WebCore::EditingStyle::init): Always avoid a tab span when computing the editing style.
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply): Avoid cloning tab spans and inserting a paragraph
        separator into a paragraph separator.
        * editing/htmlediting.cpp:
        (WebCore::positionOutsideTabSpan): Renamed from positionBeforeTabSpan. Also returns the position in the parent
        node after the tab span if the position was at the end of the tab span.
        * editing/htmlediting.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 8 Apr 2011 04:02:11 +0000 (04:02 +0000)]
2011-04-07  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        dump-as-markup conversion: editing/pasteboard/paste-text-001.html and paste-text-011.html
        https://bugs.webkit.org/show_bug.cgi?id=58078

        Converted the tests.

        * editing/pasteboard/paste-text-001-expected.txt: Added.
        * editing/pasteboard/paste-text-001.html:
        * editing/pasteboard/paste-text-011-expected.txt: Added.
        * editing/pasteboard/paste-text-011.html:
        * platform/chromium-linux/editing/pasteboard/paste-text-001-expected.checksum: Removed.
        * platform/chromium-linux/editing/pasteboard/paste-text-001-expected.png: Removed.
        * platform/chromium-linux/editing/pasteboard/paste-text-011-expected.checksum: Removed.
        * platform/chromium-linux/editing/pasteboard/paste-text-011-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/paste-text-001-expected.checksum: Removed.
        * platform/chromium-win/editing/pasteboard/paste-text-001-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/paste-text-001-expected.txt: Removed.
        * platform/chromium-win/editing/pasteboard/paste-text-011-expected.checksum: Removed.
        * platform/chromium-win/editing/pasteboard/paste-text-011-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Removed.
        * platform/gtk/editing/pasteboard/paste-text-001-expected.txt: Removed.
        * platform/gtk/editing/pasteboard/paste-text-011-expected.checksum: Removed.
        * platform/gtk/editing/pasteboard/paste-text-011-expected.png: Removed.
        * platform/gtk/editing/pasteboard/paste-text-011-expected.txt: Removed.
        * platform/mac-leopard/editing/pasteboard/paste-text-011-expected.checksum: Removed.
        * platform/mac-leopard/editing/pasteboard/paste-text-011-expected.png: Removed.
        * platform/mac/editing/pasteboard/paste-text-001-expected.checksum: Removed.
        * platform/mac/editing/pasteboard/paste-text-001-expected.png: Removed.
        * platform/mac/editing/pasteboard/paste-text-001-expected.txt: Removed.
        * platform/mac/editing/pasteboard/paste-text-011-expected.checksum: Removed.
        * platform/mac/editing/pasteboard/paste-text-011-expected.png: Removed.
        * platform/mac/editing/pasteboard/paste-text-011-expected.txt: Removed.
        * platform/qt/editing/pasteboard/paste-text-011-expected.checksum: Removed.
        * platform/qt/editing/pasteboard/paste-text-011-expected.png: Removed.
        * platform/qt/editing/pasteboard/paste-text-011-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Fri, 8 Apr 2011 03:59:34 +0000 (03:59 +0000)]
2011-04-07  Jia Pu  <jpu@apple.com>

        Reviewed by Darin Adler.

        [Mac] Editor::setComposition() should not trigger correction panel timer.
        https://bugs.webkit.org/show_bug.cgi?id=58049
         <rdar://problem/9226305>

        On Mac OS X that supports autocorrection panel, typing unconfirmed composition (i.e. unconfirmed Japanese or Chinese input)
        should not start autocorrection timer. We added a member variable, m_shouldPreventSpellChecking, to TypingCommand.
        When this value is true, markMisspellingsAfterTyping() will not be called in TypingCommand::typingAddedToOpenCommand().
        m_shouldPreventSpellChecking is set to true in the TypingCommand objects created by Editor::setComposition().

        No new tests. No deterministically reproducible test case. Patch is based on static code analysis. Testing this also requires firing
        autocorrection panel timer, which can not be easily done in automated fashion.

        * editing/Editor.cpp:
        (WebCore::Editor::deleteWithDirection):
        (WebCore::Editor::insertTextWithoutSendingTextEvent):
        (WebCore::Editor::confirmComposition):
        (WebCore::Editor::setComposition):
        * editing/EditorCommand.cpp:
        (WebCore::executeDelete):
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::TypingCommand):
        (WebCore::TypingCommand::deleteSelection):
        (WebCore::TypingCommand::deleteKeyPressed):
        (WebCore::TypingCommand::forwardDeleteKeyPressed):
        (WebCore::TypingCommand::insertText):
        (WebCore::TypingCommand::insertLineBreak):
        (WebCore::TypingCommand::insertParagraphSeparator):
        (WebCore::TypingCommand::typingAddedToOpenCommand):
        * editing/TypingCommand.h:
        (WebCore::TypingCommand::create):
        (WebCore::TypingCommand::setShouldPreventSpellChecking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 8 Apr 2011 03:51:54 +0000 (03:51 +0000)]
2011-04-07  Kent Tamura  <tkent@chromium.org>

        [Chromium] Update expectations for r83216 and r83235.

        * platform/chromium-linux/svg/custom/foreign-object-skew-expected.png: Added.
        * platform/chromium-linux/svg/custom/foreign-object-skew-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/custom/foreign-object-skew-expected.txt.
        * platform/chromium-mac-leopard/svg/custom/foreign-object-skew-expected.checksum: Removed.
        * platform/chromium-mac-leopard/svg/custom/foreign-object-skew-expected.png:
        * platform/chromium-mac/svg/custom/foreign-object-skew-expected.checksum: Removed.
        * platform/chromium-mac/svg/custom/foreign-object-skew-expected.png:
        * platform/chromium-mac/svg/zoom/text/zoom-foreignObject-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/custom/foreign-object-skew-expected.png.
        * platform/chromium-win-vista/svg/custom/foreign-object-skew-expected.checksum: Removed.
        * platform/chromium-win-vista/svg/custom/foreign-object-skew-expected.png:
        * platform/chromium-win/svg/custom/foreign-object-skew-expected.checksum: Removed.
        * platform/chromium-win/svg/custom/foreign-object-skew-expected.png:
        * platform/chromium-win/svg/custom/foreign-object-skew-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Fri, 8 Apr 2011 03:21:15 +0000 (03:21 +0000)]
2011-04-07  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric Seidel.

        Test for Bug 51465 - chrome.dll!WebCore::RenderLayer::currentTransform
        ReadAV@NULL (8968fc97874fa23b6799ff8f09c142e4)

        Forgot to add them to the original patch.

        * fast/css/webkit-empty-transform-preserve3d-crash-expected.txt: Added.
        * fast/css/webkit-empty-transform-preserve3d-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 John Bauman <jbauman@chromium.org>
commit-queue@webkit.org [Fri, 8 Apr 2011 03:09:15 +0000 (03:09 +0000)]
2011-04-07  John Bauman  <jbauman@chromium.org>

        Reviewed by Kenneth Russell.

        clearIfComposited call is really slow
        https://bugs.webkit.org/show_bug.cgi?id=57999

        Move getContextAttributes call after the if, so it isn't called nearly as often.

        No new tests.

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::clearIfComposited):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Luke Macpherson <macpherson@chromium.org>
commit-queue@webkit.org [Fri, 8 Apr 2011 02:33:22 +0000 (02:33 +0000)]
2011-04-07  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Dimitri Glazkov.

        Implement Backgroun and Mask properties in CSSStyleApplyProperty
        https://bugs.webkit.org/show_bug.cgi?id=57922

        No tests added as no behavioral changes.

        * css/CSSStyleApplyProperty.cpp:
        Added ApplyPropertyFillLayer test to handle Background and Mask CSS Properties.
        (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
        Added constructor calls to set up:
          CSSPropertyBackgroundAttachment
          CSSPropertyBackgroundClip
          CSSPropertyWebkitBackgroundClip
          CSSPropertyWebkitBackgroundComposite
          CSSPropertyBackgroundOrigin
          CSSPropertyWebkitBackgroundOrigin
          CSSPropertyBackgroundSize
          CSSPropertyWebkitBackgroundSize
          CSSPropertyWebkitMaskAttachment
          CSSPropertyWebkitMaskClip
          CSSPropertyWebkitMaskComposite
          CSSPropertyWebkitMaskOrigin
          CSSPropertyWebkitMaskSize
        * css/CSSStyleApplyProperty.h:
        (WebCore::CSSStyleApplyProperty::setPropertyValue):
        Add function to specify an equivalent property value in the lookup table.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        Remove sections now implemented by CSSStyleApplyProperty.
        * css/CSSStyleSelector.h:
        Make CSSStyleApplyProperty a friend class so that the mapFill* functions are accessible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 8 Apr 2011 02:12:31 +0000 (02:12 +0000)]
2011-04-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Split run storage out from BidiResolver into a new BidiRunList class
        https://bugs.webkit.org/show_bug.cgi?id=57764

        Part of what makes BidiResolver and InlineIterator so difficult to understand
        (and bug 50912 so difficult to fix) is that BidiResolver is both a state machine
        for the Unicode Bidi Algorithm (UBA) as well as storage for the resulting
        BidiRuns from the algorithm.  This patch breaks the storage aspect off
        into its own class BidiRunList.

        This patch is only a start.  It does not actually fix the problematic ownership
        relationship, but it does make it possible to fix such in a second patch.

        The run pointers and addRun/prependRun, etc. were already a tightly coupled
        logical subset of the BidiResolver class, so moving them into their own class
        was both obvious and easy.  The only piece of logic I had to move was that
        deleteRuns() had a side-effect of setting the m_emptyRun bit on the resolver.

        I believe this deleteRuns side-effect was only ever used for one place
        (right after findNextLineBreak) and that it's only needed because
        findNextLineBreak can sometimes create bidi runs.  Run creation appears to be
        an unintentional side-effect of how InlineIterator calls through to BidiResolver
        as part of bidiNext and not a desired effect of the code.  I have added the call
        to markCurrentRunEmpty to both places deleteRuns was called (where the resolver
        could get re-used) as a safety precaution.  We could replace both with ASSERTs
        in a later patch.

        I suspect there may be a small performance win from further refactoring so that
        findNextLineBreak does not need to create BidiRuns.

        As I commented in the code, callers should own their own BidiRunList which they
        pass to BidiResolver::createBidiRunsForLine.  I attempted to implement that in
        an earlier version of this patch, but it was too complicated with the current
        twisted dependencies between InlineIterator/bidiNext and InlineBidiResolver.
        raise/lowerExplicitEmbeddingLevel are called unconditionally
        from commitExplicitEmbedding (which is called by bidiNext) and expect to have
        access to a runs list even in cases where we don't want any runs (findNextLineBreak).

        I also cleaned up some of the callers to pass around BidiRunList objects instead
        of InlineBidiResolvers now that they're separate objects.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::drawBidiText):
        * platform/text/BidiResolver.h:
        (WebCore::BidiResolver::BidiResolver):
        (WebCore::BidiResolver::runs):
        (WebCore::BidiResolver::markCurrentRunEmpty):
        (WebCore::::appendRun):
        (WebCore::::lowerExplicitEmbeddingLevel):
        (WebCore::::raiseExplicitEmbeddingLevel):
        (WebCore::::reorderRunsFromLevels):
        (WebCore::::createBidiRunsForLine):
        * rendering/InlineIterator.h:
        (WebCore::InlineBidiResolver::appendRun):
        * rendering/RenderBlock.h:
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::createRun):
        (WebCore::RenderBlock::appendRunsForObject):
        (WebCore::reachedEndOfTextRenderer):
        (WebCore::RenderBlock::handleTrailingSpaces):
        (WebCore::RenderBlock::layoutInlineChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Adrienne Walker <enne@google.com>
enne@google.com [Fri, 8 Apr 2011 02:05:55 +0000 (02:05 +0000)]
2011-04-07  Adrienne Walker  <enne@google.com>

        [chromium] Unreviewed, add baseline pixel images for decorations-transformed.

        * platform/chromium-mac/fast/text/decorations-transformed-expected.png: Added.
        * platform/chromium-win/fast/text/decorations-transformed-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMax build fix.
jberlin@webkit.org [Fri, 8 Apr 2011 01:50:35 +0000 (01:50 +0000)]
Max build fix.

* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::checkSpellingOfString):
Do not risk an overflow.
(WebKit::WebEditorClient::checkGrammarOfString):
Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Naoki Takano <takano.naoki@gmail.com>
commit-queue@webkit.org [Fri, 8 Apr 2011 01:18:59 +0000 (01:18 +0000)]
2011-04-07  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Adam Barth.

        [Chromium] Fix relocation problem of popup window which introduces autofill popup sometimes moves to screen's top left corner.
        https://bugs.webkit.org/show_bug.cgi?id=57911
        http://code.google.com/p/chromium/issues/detail?id=78073

        Manual test added: manual-tests/autofill-popup-location.html

        Originally only height is checked so that it introduces the bug.
        So I changed it to check both width and height as size.

        * manual-tests/autofill-popup-location.html: Added.
        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::refresh): Check window size between original and new before calling setFrameRect().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoVersioning.
lforschler@apple.com [Fri, 8 Apr 2011 01:09:38 +0000 (01:09 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 8 Apr 2011 01:08:59 +0000 (01:08 +0000)]
2011-04-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement img-src style-src and font-src
        https://bugs.webkit.org/show_bug.cgi?id=58018

        Test a bunch of allow/block tests for these new directives.

        * http/tests/security/contentSecurityPolicy/image-allowed-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/image-allowed.html: Added.
        * http/tests/security/contentSecurityPolicy/image-blocked-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/image-blocked.html: Added.
        * http/tests/security/contentSecurityPolicy/resources/blue.css: Added.
        * http/tests/security/contentSecurityPolicy/resources/style.xsl: Added.
        * http/tests/security/contentSecurityPolicy/style-allowed-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/style-allowed.html: Added.
        * http/tests/security/contentSecurityPolicy/style-blocked-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/style-blocked.html: Added.
        * http/tests/security/contentSecurityPolicy/xsl-allowed.php: Added.
        * http/tests/security/contentSecurityPolicy/xsl-blocked-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/xsl-blocked.php: Added.
2011-04-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement img-src style-src and font-src
        https://bugs.webkit.org/show_bug.cgi?id=58018

        These are pretty straight forward given the rest of the infrastructure
        we've built so far.

        Tests: http/tests/security/contentSecurityPolicy/image-allowed.html
               http/tests/security/contentSecurityPolicy/image-blocked.html
               http/tests/security/contentSecurityPolicy/style-allowed.html
               http/tests/security/contentSecurityPolicy/style-blocked.html
               http/tests/security/contentSecurityPolicy/xsl-allowed.php
               http/tests/security/contentSecurityPolicy/xsl-blocked.php

        * loader/cache/CachedResourceLoader.cpp:
        (WebCore::CachedResourceLoader::canRequest):
        * page/ContentSecurityPolicy.cpp:
        (WebCore::ContentSecurityPolicy::allowImageFromSource):
        (WebCore::ContentSecurityPolicy::allowStyleFromSource):
        (WebCore::ContentSecurityPolicy::allowFontFromSource):
        (WebCore::ContentSecurityPolicy::addDirective):
        * page/ContentSecurityPolicy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake IconSnapshot and PageURLRecord member variables private.
levin@chromium.org [Fri, 8 Apr 2011 00:55:59 +0000 (00:55 +0000)]
Make IconSnapshot and PageURLRecord member variables private.
https://bugs.webkit.org/show_bug.cgi?id=58080

Reviewed by Darin Adler.

No change in functionality so no new tests.

* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::writeToDatabase): Changed to used the accessor functions.
(WebCore::IconDatabase::writeIconSnapshotToSQLDatabase): Ditto.
* loader/icon/IconRecord.h:
(WebCore::IconSnapshot::IconSnapshot): Changed to use the new member variable names.
(WebCore::IconSnapshot::iconURL): Expose the property.
(WebCore::IconSnapshot::timestamp): Ditto.
(WebCore::IconSnapshot::data): Ditto.
* loader/icon/PageURLRecord.h:
(WebCore::PageURLSnapshot::PageURLSnapshot): Changed to use the new member variable names.
(WebCore::PageURLSnapshot::pageURL): Expose the property.
(WebCore::PageURLSnapshot::iconURL): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Updated comment in skipped list to
enrica@apple.com [Fri, 8 Apr 2011 00:48:50 +0000 (00:48 +0000)]
Unreviewed. Updated comment in skipped list to
include the bug that tracks the changes required
in WebKitTestRunner.

* platform/win-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2: Implement TextChecker on Windows
jberlin@webkit.org [Fri, 8 Apr 2011 00:38:20 +0000 (00:38 +0000)]
WebKit2: Implement TextChecker on Windows
https://bugs.webkit.org/show_bug.cgi?id=57862

Reviewed by Brian Weinstein.

Part 4: Implement checkGrammarOfString.

* Scripts/webkit2/messages.py:
The generated files should include TextCheckerClient.h for WebCore::GrammarDetail.

* Shared/API/c/win/WKBaseWin.h:
* Shared/APIObject.h:
* UIProcess/API/C/win/WKAPICastWin.h:

* UIProcess/API/C/win/WKGrammarDetail.cpp: Added.
(WKGrammarDetailGetTypeID):
(WKGrammarDetailCreate):
* UIProcess/API/C/win/WKGrammarDetail.h: Added.

* UIProcess/API/C/win/WKTextChecker.h:
Add the checkGrammarOfString WKTextCheckerClient function.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::checkGrammarOfString):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:

* UIProcess/TextChecker.h:
* UIProcess/win/TextCheckerWin.cpp:
(WebKit::TextChecker::checkGrammarOfString):
Call the TextCheckerClient.
* UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::checkSpellingOfString):
Add a comment about this not being used on Mac.
(WebKit::TextChecker::checkGrammarOfString):
Ditto, and call notImplemented.
* UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::TextChecker::checkGrammarOfString):
Call notImplemented.
* UIProcess/qt/TextCheckerQt.cpp:
(WebKit::TextChecker::checkGrammarOfString):
Ditto.

* UIProcess/win/WebGrammarDetail.cpp: Added.
(WebKit::WebGrammarDetail::create):
(WebKit::WebGrammarDetail::WebGrammarDetail):
Initialize the underlying WebCore::GrammarDetail.
* UIProcess/win/WebGrammarDetail.h: Added.
(WebKit::WebGrammarDetail::grammarDetail):
(WebKit::WebGrammarDetail::type):

* UIProcess/win/WebTextCheckerClient.cpp:
(WebKit::WebTextCheckerClient::checkGrammarOfString):
Populate the Vector of WebCore::GrammarDetails with the WebGrammarDetails.
* UIProcess/win/WebTextCheckerClient.h:

* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::checkSpellingOfString):
Use WTF::notFound as the initial value for resultLocation.
(WebKit::WebEditorClient::checkGrammarOfString):
Send a sync message to the UI Process (similar to checkSpellingOfString and checkTextOfParagraph).

* win/WebKit2.vcproj:
Add WKGrammarDetail.h/.cpp and WebGrammarDetail.h/.cpp.
* win/WebKit2Generated.make:
Copy over WKGrammarDetail.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMapping booleans the same way as integers
barraclough@apple.com [Thu, 7 Apr 2011 23:47:06 +0000 (23:47 +0000)]
Mapping booleans the same way as integers
https://bugs.webkit.org/show_bug.cgi?id=56913

Patch by Zoltan Herczeg <zherczeg@webkit.org> on 2011-04-07
Reviewed by Gavin Barraclough.

Instead of having a seperate tag field for booleans,
the logical values are stored in the payload field
(for JSValue32_64 representation).

1.007x speedup on SunSpider.

* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitStoreBool):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_not):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_eq):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
* jit/JSInterfaceJIT.h:
* runtime/JSValue.h:
(JSC::JSValue::JSValue):
(JSC::JSValue::isTrue):
(JSC::JSValue::isFalse):
(JSC::JSValue::getBoolean):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(WebKit2): execCommand('undo') doesn't work (Windows).
enrica@apple.com [Thu, 7 Apr 2011 23:46:43 +0000 (23:46 +0000)]
REGRESSION(WebKit2): execCommand('undo') doesn't work (Windows).
https://bugs.webkit.org/show_bug.cgi?id=58056
<rdar://problem/8862023>

Reviewed by Oliver Hunt.

Adding support for execCommand('undo') and execCommand('redo')
in WebKit2 for Windows.

* UIProcess/API/C/win/WKView.h:
* UIProcess/win/WebUndoClient.cpp:
(WebKit::WebUndoClient::canUndoRedo):
(WebKit::WebUndoClient::executeUndoRedo):
* UIProcess/win/WebUndoClient.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::canUndoRedo):
(WebKit::WebView::executeUndoRedo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Thu, 7 Apr 2011 23:38:50 +0000 (23:38 +0000)]
2011-04-07  Daniel Bates  <dbates@rim.com>

        Reviewed by Darin Adler.

        Add a layout test to ensure that mousemove is fired from a subframe
        https://bugs.webkit.org/show_bug.cgi?id=58094

        * fast/events/iframe-onmousemove-expected.txt: Added.
        * fast/events/iframe-onmousemove.html: Added.
        * fast/events/resources/iframe-onmousemove.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Decrease flakiness of test results.
ossy@webkit.org [Thu, 7 Apr 2011 23:30:50 +0000 (23:30 +0000)]
[Qt][WK2] Decrease flakiness of test results.

* platform/qt-wk2/Skipped:
 - Add canvas tests not to break css2.1 tests.
 - Remove passing css2.1 tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix.
mitz@apple.com [Thu, 7 Apr 2011 23:07:04 +0000 (23:07 +0000)]
Build fix.

* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::roundToDevicePixels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 7 Apr 2011 23:03:43 +0000 (23:03 +0000)]
2011-04-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add stub support for generating Gtk build system from gyp
        https://bugs.webkit.org/show_bug.cgi?id=58086

        This adds support for a new --port argument and plumbs through
        the necessary paths to allow generating for a port other than Mac.

        * Source/gyp/configure:
2011-04-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add stub support for generating Gtk build system from gyp
        https://bugs.webkit.org/show_bug.cgi?id=58086

        This does not produce a buildable JavaScriptCore, but it
        does allow running gyp/configure --port=gtk and having
        it generate a gtk.Makefile which we can use for testing
        the rest of the plumbing.

        * gyp/gtk.gyp: Added.
2011-04-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add stub support for generating Gtk build system from gyp
        https://bugs.webkit.org/show_bug.cgi?id=58086

        This does not produce a buildable WebCore, but it
        does allow running gyp/configure --port=gtk and having
        it generate a gtk.Makefile which we can use for testing
        the rest of the plumbing.

        * gyp/gtk.gyp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Thu, 7 Apr 2011 22:51:14 +0000 (22:51 +0000)]
2011-04-07  Andrew Scherkus  <scherkus@chromium.org>

        Revert ENABLE_TRACK patch due to compile failures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed; Add failing legacy full screen tests to the gtk/Skipped list.
jer.noble@apple.com [Thu, 7 Apr 2011 22:38:42 +0000 (22:38 +0000)]
Unreviewed; Add failing legacy full screen tests to the gtk/Skipped list.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=57736
hyatt@apple.com [Thu, 7 Apr 2011 22:33:32 +0000 (22:33 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=57736

Reviewed by Dan Bernstein.

Crash on openstreetmap.org while using the map. Fix a bad interaction between the positioned movement layout
optimization and the simplified layout optimization that could lead to blocks remaining marked as dirty when
layout finished. This would eventually lead to an inability to properly determine the correct layout root and
would cause a deleted root to be used later on.

Added fast/block/positioning/complex-positioned-movement.html.

Source/WebCore:

* page/FrameView.cpp:
(WebCore::FrameView::scheduleRelayoutOfSubtree):
Add asserts to catch cases in the future where a layout root is set that has a dirty containing block.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::simplifiedLayout):
Change simplified layout so that the positioned movement optimization no longer clears the other layout
flags. This will ensure that we still lay out our descendants if they need it.

(WebCore::RenderBlock::layoutPositionedObjects):
Changed to clear our layout flags now if the positioned movement is successful, since tryLayoutDoingPositionedMovementOnly
no longer does the clear.

* rendering/RenderBox.h:
(WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):
tryLayoutDoingPositionedMovementOnly now returns a boolean indicating success or failure.  On success it no longer
does setNeedsLayout(false), but instead will let the caller take care of it. This way the caller can still look at
the other flags in case other kinds of layout are still needed.

* rendering/RenderObject.h:
(WebCore::RenderObject::setNeedsPositionedMovementLayout):
(WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayout):
Changed these methods to only set their respective flags and not to try to be clever about avoiding propagation.

LayoutTests:

* fast/block/positioning/complex-positioned-movement.html: Added.
* platform/mac/fast/block/positioning/complex-positioned-movement-expected.checksum: Added.
* platform/mac/fast/block/positioning/complex-positioned-movement-expected.png: Added.
* platform/mac/fast/block/positioning/complex-positioned-movement-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Anna Cavender <annacc@chromium.org>
scherkus@chromium.org [Thu, 7 Apr 2011 22:23:42 +0000 (22:23 +0000)]
2011-04-07  Anna Cavender  <annacc@chromium.org>

        Reviewed by Eric Carlson.

        Setup ENABLE(TRACK) feature define
        https://bugs.webkit.org/show_bug.cgi?id=53556

        * configure.ac:

2011-04-07  Anna Cavender  <annacc@chromium.org>

        Reviewed by Eric Carlson.

        Setup ENABLE(TRACK) feature define
        https://bugs.webkit.org/show_bug.cgi?id=53556

        * Configurations/FeatureDefines.xcconfig:

2011-04-07  Anna Cavender  <annacc@chromium.org>

        Reviewed by Eric Carlson.

        Setup ENABLE(TRACK) feature define + initial HTMLTrackElement
        https://bugs.webkit.org/show_bug.cgi?id=53556

        No new tests. No real functionality added just yet.

        * CMakeLists.txt:
        * Configurations/FeatureDefines.xcconfig:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.xcodeproj/project.pbxproj:
        * features.pri:
        * html/HTMLAttributeNames.in:
        * html/HTMLTagNames.in:
        * html/HTMLTrackElement.cpp: Added.
        (WebCore::HTMLTrackElement::HTMLTrackElement):
        (WebCore::HTMLTrackElement::create):
        (WebCore::HTMLTrackElement::insertedIntoTree):
        (WebCore::HTMLTrackElement::willRemove):
        (WebCore::HTMLTrackElement::src):
        (WebCore::HTMLTrackElement::setSrc):
        (WebCore::HTMLTrackElement::kind):
        (WebCore::HTMLTrackElement::setKind):
        (WebCore::HTMLTrackElement::srclang):
        (WebCore::HTMLTrackElement::setSrclang):
        (WebCore::HTMLTrackElement::label):
        (WebCore::HTMLTrackElement::setLabel):
        (WebCore::HTMLTrackElement::isDefault):
        (WebCore::HTMLTrackElement::setIsDefault):
        (WebCore::HTMLTrackElement::isURLAttribute):
        * html/HTMLTrackElement.h: Added.
        * html/HTMLTrackElement.idl: Added.

2011-04-07  Anna Cavender  <annacc@chromium.org>

        Reviewed by Eric Carlson.

        Setup ENABLE(TRACK) feature define + initial HTMLTrackElement
        https://bugs.webkit.org/show_bug.cgi?id=53556

        * WebKit.xcodeproj/project.pbxproj:

2011-04-07  Anna Cavender  <annacc@chromium.org>

        Reviewed by Eric Carlson.

        Setup ENABLE(TRACK) feature define
        https://bugs.webkit.org/show_bug.cgi?id=53556

        * features.gypi:

2011-04-07  Anna Cavender  <annacc@chromium.org>

        Reviewed by Eric Carlson.

        Setup ENABLE(TRACK) feature define
        https://bugs.webkit.org/show_bug.cgi?id=53556

        * Configurations/FeatureDefines.xcconfig:

2011-04-07  Anna Cavender  <annacc@chromium.org>

        Reviewed by Eric Carlson.

        Setup ENABLE(TRACK) feature define
        https://bugs.webkit.org/show_bug.cgi?id=53556

        * Configurations/FeatureDefines.xcconfig:

2011-04-07  Anna Cavender  <annacc@chromium.org>

        Reviewed by Eric Carlson.

        Setup ENABLE(TRACK) feature define
        https://bugs.webkit.org/show_bug.cgi?id=53556

        * Scripts/build-webkit:

2011-04-07  Anna Cavender  <annacc@chromium.org>

        Reviewed by Eric Carlson.

        Setup ENABLE(TRACK) feature define
        https://bugs.webkit.org/show_bug.cgi?id=53556

        * win/tools/vsprops/FeatureDefines.vsprops:
        * win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 7 Apr 2011 22:21:53 +0000 (22:21 +0000)]
2011-04-07  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        update DRT to embed checksums in png files
        https://bugs.webkit.org/show_bug.cgi?id=57871

        We insert the bytes for the comment in printPNG rather than at encode
        time because each platform does its own PNG encoding (either using CG
        or cairo).  Putting this in pringPNG avoids having to duplicate this
        code, although it's not as clean as doing it at encoding time.

        We insert the comment right after the IHDR chunk of the PNG.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/CyclicRedundancyCheck.cpp: Added.
        (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
        (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
        * DumpRenderTree/CyclicRedundancyCheck.h: Added.
        * DumpRenderTree/PixelDumpSupport.cpp:
        (dumpWebViewAsPixelsAndCompareWithExpected):
        (convertChecksumToPNGComment): Generate the bytes to insert.
        (printPNG): Insert the png comment before the first IDAT section.
        * DumpRenderTree/PixelDumpSupport.h:
        * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
        (printPNG):
        (dumpBitmap):
        * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
        (printPNG):
        (dumpBitmap):
        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 7 Apr 2011 22:17:56 +0000 (22:17 +0000)]
2011-04-07  Martin Robinson  <mrobinson@igalia.com>

        Fix the WebKit2 GTK+ build for older versions of GTK+.

        * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Include the GtkVersioning.h header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 7 Apr 2011 22:16:52 +0000 (22:16 +0000)]
2011-04-07  Adam Barth  <abarth@webkit.org>

        Fix whitespace in GNUmakefile.am.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9018212> Underline thickness is not uniform under non-integral scale...
mitz@apple.com [Thu, 7 Apr 2011 22:15:32 +0000 (22:15 +0000)]
<rdar://problem/9018212> Underline thickness is not uniform under non-integral scale factor
https://bugs.webkit.org/show_bug.cgi?id=58083

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/text/decorations-transformed.html

* platform/graphics/GraphicsContext.h: Added a RoundingMode enum with two values. RoundAllSides
is the existing rounding mode, where each side of the rectangle snaps to the nearest pixel
gridline. RoundOriginAndDimensions snaps the origin to the nearest pixel gridpoint and rounds
the width and the height. In this new mode, translating a rectangle in user space never changes
its dimensions in device pixels.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::roundToDevicePixels): Implemented RoundOriginAndDimensions.
(WebCore::GraphicsContext::drawLineForText): Use RoundOriginAndDimensions, thus ensuring that
all underlines have the same thickness in device pixels.
* platform/graphics/openvg/GraphicsContextOpenVG.cpp:
(WebCore::GraphicsContext::roundToDevicePixels): Added RoundingMode parameter, but did not implement it.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::roundToDevicePixels): Ditto.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::roundToDevicePixels): Ditto.
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::roundToDevicePixels): Ditto.
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::roundToDevicePixels): Ditto.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintDecoration):

LayoutTests:

* fast/text/decorations-transformed.html: Added.
* platform/mac/fast/text/decorations-transformed-expected.checksum: Added.
* platform/mac/fast/text/decorations-transformed-expected.png: Added.
* platform/mac/fast/text/decorations-transformed-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Amruth Raj <amruthraj@motorola.com> and Martin Robinson <mrobinson...
mrobinson@webkit.org [Thu, 7 Apr 2011 22:11:08 +0000 (22:11 +0000)]
2011-04-07   Amruth Raj  <amruthraj@motorola.com> and Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [GTK] Implement SharedMemory for WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=49791

        Share the SharedMemory, Attachment and Connection implementations with the Qt port.
        Both implementation are, in fact, general Unix implementations using standard Unix
        domain sockets and sendmsg / recvmsg. This should reduce the amount of duplicated code
        greatly and lay the groundwork for GTK+/Qt implementations for other operating systems.

        * GNUmakefile.am: Replaced GTK+ versions of files with the Unix ones.
        * Platform/CoreIPC/ArgumentDecoder.cpp: Extended Qt #ifdefs to include GTK.
        (CoreIPC::ArgumentDecoder::~ArgumentDecoder):
        * Platform/CoreIPC/ArgumentEncoder.cpp: Ditto.
        (CoreIPC::ArgumentEncoder::~ArgumentEncoder):
        * Platform/CoreIPC/Attachment.h: Ditto.
        * Platform/CoreIPC/Connection.h: Combined the GTK+ and Qt sections.
        * Platform/CoreIPC/unix/AttachmentUnix.cpp: Renamed from Source/WebKit2/Platform/CoreIPC/qt/AttachmentQt.cpp.
        * Platform/CoreIPC/unix/ConnectionUnix.cpp: Renamed from Source/WebKit2/Platform/CoreIPC/qt/ConnectionQt.cpp.
        * Platform/unix/SharedMemoryUnix.cpp: Renamed from Source/WebKit2/Platform/qt/SharedMemoryQt.cpp.
        * UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
        (WebKit::ProcessLauncher::launchProcess): Use SOCK_DGRAM instead of SOCK_STREAM to match Qt.
        * WebKit2.pro: Updated source list to reflect file renaming.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed; Add the media/media-fullscreen-inline.html test to the mac-snowleopard...
jer.noble@apple.com [Thu, 7 Apr 2011 21:52:12 +0000 (21:52 +0000)]
Unreviewed; Add the media/media-fullscreen-inline.html test to the mac-snowleopard Skipped list.

The legacy full screen API now redirects to the new full screen API, breaking the media-fullscreen-inline.html
test.

* platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Thu, 7 Apr 2011 21:51:23 +0000 (21:51 +0000)]
2011-04-06  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Nate Chapin.

        [V8] Remove custom DOMImplementation getter on Document.
        https://bugs.webkit.org/show_bug.cgi?id=57991

        The custom getter is no longer required because DOMImplementation
        objects are now created per document.

        Test: fast/dom/DOMImplementation/implementation-identity.html

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/custom/V8DocumentCustom.cpp:
        * dom/Document.idl:

2011-04-06  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Nate Chapin.

        [V8] Remove custom DOMImplementation getter on Document.
        https://bugs.webkit.org/show_bug.cgi?id=57991

        * fast/dom/DOMImplementation/implementation-identity-expected.txt: Added.
        * fast/dom/DOMImplementation/implementation-identity.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a couple of typos in comments that Darin spotted.
barraclough@apple.com [Thu, 7 Apr 2011 21:44:40 +0000 (21:44 +0000)]
Fix a couple of typos in comments that Darin spotted.

* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_not):
* runtime/JSImmediate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Brian Weinstein.
ap@apple.com [Thu, 7 Apr 2011 21:43:03 +0000 (21:43 +0000)]
    Reviewed by Brian Weinstein.

        REGRESSION (r83081): Use of deallocated memory in WebEditorClient::respondToChangedSelection()
        https://bugs.webkit.org/show_bug.cgi?id=58082

        * WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::respondToChangedSelection):
        Now that the Range is used outside the full expression where it's created, it needs to be
        protected with RefPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Steve Lacey <sjl@chromium.org>
commit-queue@webkit.org [Thu, 7 Apr 2011 21:19:19 +0000 (21:19 +0000)]
2011-04-07  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        Make various video layout tests platform independent by selecting an appropriate media file.

        Various layout tests depend on mp4 files.
        https://bugs.webkit.org/show_bug.cgi?id=57804

        * http/tests/media/remove-while-loading.html:
        * http/tests/media/video-load-and-stall.cgi:
        * http/tests/media/video-play-stall-before-meta-data.html:
        * http/tests/media/video-play-stall-seek.html:
        * http/tests/media/video-play-stall.html:
        * http/tests/media/video-seekable-stall.html:
        * media/media-file.js:
        (mimeTypeForFile):
        (stripExtension):
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Sergey Glazunov <serg.glazunov@gmail.com>
inferno@chromium.org [Thu, 7 Apr 2011 21:17:44 +0000 (21:17 +0000)]
2011-04-07  Sergey Glazunov  <serg.glazunov@gmail.com>

        Reviewed by Dimitri Glazkov.

        setHasID() is only called for styled elements
        https://bugs.webkit.org/show_bug.cgi?id=57267

        Test: fast/dom/non-styled-element-id-crash.html

        * dom/Element.cpp:
        (WebCore::Element::attributeChanged):
        (WebCore::Element::idAttributeChanged):
        * dom/Element.h:
        * dom/StyledElement.cpp:
        (WebCore::StyledElement::parseMappedAttribute):
2011-04-07  Sergey Glazunov  <serg.glazunov@gmail.com>

        Reviewed by Dimitri Glazkov.

        setHasID() is only called for styled elements
        https://bugs.webkit.org/show_bug.cgi?id=57267

        * fast/dom/non-styled-element-id-crash-expected.txt: Added.
        * fast/dom/non-styled-element-id-crash.html: Added.
        * svg/custom/embedded-svg-disallowed-in-dashboard.xml: Fix the failing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Thu, 7 Apr 2011 21:11:42 +0000 (21:11 +0000)]
2011-04-07  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        HTMLVideoElement::webkitEnterFullscreen does not use new Full Screen API when available.
        https://bugs.webkit.org/show_bug.cgi?id=58070

        Make the HTMLMediaElement full screen functions call into the new Full Screen API when
        FULLSCREEN_API is enabled.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::enterFullscreen):
        (WebCore::HTMLMediaElement::exitFullscreen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a typo in the Skipped list from r83203.
bweinstein@apple.com [Thu, 7 Apr 2011 21:10:59 +0000 (21:10 +0000)]
Fix a typo in the Skipped list from r83203.

* platform/win-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9251566> WebBackForwardList::createCFDictionaryRepresentation's curre...
mrowe@apple.com [Thu, 7 Apr 2011 20:58:58 +0000 (20:58 +0000)]
<rdar://problem/9251566> WebBackForwardList::createCFDictionaryRepresentation's current item index
doesn't account for items removed by filter callback.

Reviewed by Dan Bernstein.

* UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::createCFDictionaryRepresentation): Update the current item index
when we omit an item due to the filter callback.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 7 Apr 2011 20:51:22 +0000 (20:51 +0000)]
2011-04-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement CSP's options directive
        https://bugs.webkit.org/show_bug.cgi?id=58014

        * http/tests/security/contentSecurityPolicy/inline-script-allowed-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/inline-script-allowed.html: Added.
        * http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html: Added.
2011-04-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement CSP's options directive
        https://bugs.webkit.org/show_bug.cgi?id=58014

        This patch contains the full options parser, but we only have enough of
        CSP implemented to see the effects of disable-xss-protection.  Will
        need to do some more work before we can see eval-script in action.

        Tests: http/tests/security/contentSecurityPolicy/inline-script-allowed.html
               http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html

        * page/ContentSecurityPolicy.cpp:
        (WebCore::CSPOptions::CSPOptions):
        (WebCore::CSPOptions::disableXSSProtection):
        (WebCore::CSPOptions::evalScript):
        (WebCore::CSPOptions::parse):
        (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
        (WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
        (WebCore::ContentSecurityPolicy::allowInlineScript):
        (WebCore::ContentSecurityPolicy::addDirective):
        * page/ContentSecurityPolicy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Anders Carlsson.
ap@apple.com [Thu, 7 Apr 2011 20:48:10 +0000 (20:48 +0000)]
    Reviewed by Anders Carlsson.

        REGRESSION (WebKit2): Reverse conversion doesn't work in Kotoeri
        https://bugs.webkit.org/show_bug.cgi?id=58066
        <rdar://problem/8965302>

        * Scripts/webkit2/messages.py:
        * Shared/mac/AttributedString.h: Added.
        * Shared/mac/AttributedString.mm: Added.
        (WebKit::AttributedString::encode):
        (WebKit::AttributedString::decode):
        Added an class that wraps NSAttributedString. As far as I can tell, one can't pass a CF
        or NS object to another process without wrapping it in a C++ one.

        * Shared/mac/ArgumentCodersMac.h: Added.
        * Shared/mac/ArgumentCodersMac.mm: Added.
        Added coders for Foundation objects, similar to ArgumentCodersCF. There are two reasons why
        these are needed:
        1) Even though most Foundation objects are toll free bridged with CF, CFGetTypeID() doesn't
        work properly for them (I've been just getting 1).
        2) NSColor isn't toll free bridged to CF.
        This adds just the types necessary for editing NSAttributedString (and I don't yet know what
        happens with attachments).

        * UIProcess/API/mac/WKView.mm: (-[WKView attributedSubstringFromRange:]):
        * UIProcess/WebPageProxy.h:
        * UIProcess/mac/WebPageProxyMac.mm:
        (WebKit::WebPageProxy::getAttributedSubstringFromRange):
        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/WebPage/WebPage.h:
        * WebProcess/WebPage/WebPage.messages.in:
        Boilerplate code for making a sync call to web process.

        * WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::getAttributedSubstringFromRange):
        Ported from WebHTMLView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
enrica@apple.com [Thu, 7 Apr 2011 20:40:30 +0000 (20:40 +0000)]
Unreviewed.
Adding to skipped list for Windows (WK2) the
tests relative to undo removed from the skipped list
for Mac where execCommand('undo') is now supported.

* platform/win-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Adrienne Walker <enne@google.com>
enne@google.com [Thu, 7 Apr 2011 20:36:37 +0000 (20:36 +0000)]
2011-04-07  Adrienne Walker  <enne@google.com>

        [chromium] Unreviewed, rebaseline progress element tests.

        * platform/chromium-linux/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Removed.
        * platform/chromium-linux/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
        * platform/chromium-mac-leopard/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: Added.
        * platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Removed.
        * platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
        * platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
        * platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Andy Estes <aestes@apple.com>
aestes@apple.com [Thu, 7 Apr 2011 20:23:48 +0000 (20:23 +0000)]
2011-04-07  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r64712): Microsoft Outlook 2011: original message contents
        not included when replying to an email.
        https://bugs.webkit.org/show_bug.cgi?id=57794

        * WebKit.xcodeproj/project.pbxproj:
2011-04-07  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r64712): Microsoft Outlook 2011: original message contents
        not included when replying to an email.
        https://bugs.webkit.org/show_bug.cgi?id=57794

        Outlook populates a reply message by creating an empty WebView and
        using DOM API to populate the WebView's empty document with content
        from the original message. It expects the initial empty document to
        simply be "<html></html>", and it proceeds to dynamically create and
        append a BODY node and add the original message content as a child of
        that node. Outlook then takes the innerHTML of the frame's first body
        element and copies it into a *new* document that is displayed and
        edited in the reply message window.

        Due to implementing the HTML5 tree building algorithm in r64712,
        initial empty documents went from being "<html></html>" to being
        "<html><head></head><body></body></html>". Outlook still dynamically
        creates a BODY node to parent the original message content, but this
        BODY node duplicates the one created by the tree builder. When Outlook
        then takes the innerHTML of the first body element to populate the
        reply message window it gets the empty body element created by the
        parser, not the one it created with the original message content.

        Fix this by injecting a user script into the initial empty document
        that removes the HEAD and BODY nodes created by the parser. This
        ensures that the BODY created by Outlook is the only BODY in the
        document.

        * Misc/OutlookQuirksUserScript.js: Added.
        * WebView/WebView.mm:
        (leakMailQuirksUserScriptContents):
        (-[WebView _injectMailQuirksScript]):
        (needsOutlookQuirksScript):
        (leakOutlookQuirksUserScriptContents):
        (-[WebView _injectOutlookQuirksScript]):
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2011-04-07  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r64712): Microsoft Outlook 2011: original message contents
        not included when replying to an email.
        https://bugs.webkit.org/show_bug.cgi?id=57794

        * WebCore.exp.in:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::finishedParsing): Call Frame::injectUserScripts()
        before checking if the FrameLoader is parsing the initial empty document.
        This allows user scripts to be injected at the end of document parsing
        (if the setting is enabled).
        * page/Frame.cpp:
        (WebCore::Frame::injectUserScripts): Do not inject scripts if this
        feature is disabled on the initial empty document.
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        * page/Settings.h: Add a setting for injecting user scripts into the
        initial empty document (defaults to false).
        (WebCore::Settings::setInjectUserScriptsInInitialEmptyDocument):
        (WebCore::Settings::injectUserScriptsInInitialEmptyDocument):
        * platform/mac/RuntimeApplicationChecks.h:
        * platform/mac/RuntimeApplicationChecks.mm:
        (WebCore::applicationIsMicrosoftOutlook): Check if the embedding
        application is Microsoft Outlook.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMac build fix.
jeffm@apple.com [Thu, 7 Apr 2011 20:18:44 +0000 (20:18 +0000)]
Mac build fix.

* Shared/WebString.h:
(WebKit::WebString::getCharacters): Add explict cast when using std::min().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed; rebaseline expected results in platform/mac-wk2.
jer.noble@apple.com [Thu, 7 Apr 2011 20:09:33 +0000 (20:09 +0000)]
Unreviewed; rebaseline expected results in platform/mac-wk2.

* platform/mac-wk2/media/controls-without-preload-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Thu, 7 Apr 2011 19:49:22 +0000 (19:49 +0000)]
2011-04-07  Jeff Miller  <jeffm@apple.com>

        Reviewed by Adam Roben.

        Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
        https://bugs.webkit.org/show_bug.cgi?id=58058

        * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
        (TestWebKitAPI::TEST): Add tests for  WKStringGetLength() and WKStringGetCharactersPtr().
2011-04-07  Jeff Miller  <jeffm@apple.com>

        Reviewed by Adam Roben.

        Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
        https://bugs.webkit.org/show_bug.cgi?id=58058

        WKStringGetCharactersPtr() exposes the internal implementation of WKString, so change this to WKStringGetCharacters(), which makes a UTF-16 copy.

        * Shared/API/c/WKString.cpp:
        (WKStringGetCharacters): Added, replaces WKStringGetCharactersPtr().
        * Shared/API/c/WKString.h: Replaced WKStringGetCharactersPtr() with WKStringGetCharacters().
        * Shared/WebString.h:
        (WebKit::WebString::getCharacters): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2: Support window bounce when panning.
bweinstein@apple.com [Thu, 7 Apr 2011 19:42:26 +0000 (19:42 +0000)]
WebKit2: Support window bounce when panning.
https://bugs.webkit.org/show_bug.cgi?id=58065
<rdar://problem/9244367>

Reviewed by Adam Roben.

Make gestureDidScroll synchronous, as once we scroll, we need to know
whether or not we are at the beginning or end of the scrollable document.

If we are at either end of the scrollable document, we call the Windows 7
API to bounce the window to give an indication that you are past an end
of the document.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::gestureDidScroll): Pass a boolean for the reply, and return it.
* UIProcess/WebPageProxy.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView): Inititalize a new variable.
(WebKit::WebView::onGesture): Once we send the message to scroll, check if have gone to
    an end of the document, and if we have, bounce the window.
* UIProcess/win/WebView.h:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: GestureDidScroll is now sync.
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::gestureDidScroll): When we are done scrolling, check if we have a vertical
    scrollbar and if we are at the beginning or the end of the scrollable document.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Thu, 7 Apr 2011 19:30:37 +0000 (19:30 +0000)]
2011-04-06  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        AVF: MediaPlayerPrivateAVFoundation never reaches playable state.
        https://bugs.webkit.org/show_bug.cgi?id=57962

        Add support for a new AVPlayerItem API which will notify clients when their
        seek completes.  This requires a new Notification type to be passed to the main
        thread in MediaPlayerPrivateAVFoundation.

        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
        (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Added.
        (WebCore::MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification): Added two new
            overloaded functions which take a Notification; and a Notification::Type and boolean.
        (WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Support new SeekCompleted
            Notification type.
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
        (WebCore::MediaPlayerPrivateAVFoundation::Notification::Notification): Added one new constructor.
        (WebCore::MediaPlayerPrivateAVFoundation::Notification::finished): Added ivar and accessor.
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
        (WebCore::MediaPlayerPrivateAVFoundationObjC::seekToTime): Call new AVPlayerItem API.
        (-[WebCoreAVFMovieObserver seekCompleted:]): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83196 268f45cc-cd09-0410-ab3c-d52691b4dbfc