WebKit-https.git
10 years ago<rdar://problem/10405215> REGRESSION (r98178): World of Warcraft Launcher crashes...
mitz@apple.com [Tue, 8 Nov 2011 01:16:35 +0000 (01:16 +0000)]
<rdar://problem/10405215> REGRESSION (r98178): World of Warcraft Launcher crashes in FrameView::isOnActivePage()
https://bugs.webkit.org/show_bug.cgi?id=71743

Reviewed by Beth Dakin.

* page/FrameView.cpp:
(WebCore::FrameView::isOnActivePage): Added a check for a null m_frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=71534
dslomov@google.com [Tue, 8 Nov 2011 00:59:33 +0000 (00:59 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=71534
[V8] On neutering TypedArrayViews, V8 should be notified to drain code generation cache.

Reviewed by David Levin.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
* html/canvas/DataView.cpp:
* html/canvas/DataView.h:
* html/canvas/Float32Array.h:
* html/canvas/Float64Array.h:
* html/canvas/Int16Array.h:
* html/canvas/Int32Array.h:
* html/canvas/Int8Array.h:
* html/canvas/TypedArrayBase.h:
* html/canvas/Uint16Array.h:
* html/canvas/Uint32Array.h:
* html/canvas/Uint8Array.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoaddMessage's last few arguments should be optional
abarth@webkit.org [Tue, 8 Nov 2011 00:57:10 +0000 (00:57 +0000)]
addMessage's last few arguments should be optional
https://bugs.webkit.org/show_bug.cgi?id=70946

Reviewed by Darin Adler.

As requested by Darin Adler.  I wanted to call this method addMessage,
but the compiler was unhappy locating the overload on
ScriptExecutionContext when Document had an override too.  Changing the
name to addConsoleMessage made all the code happier.

* dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::addMessage):
* dom/ScriptExecutionContext.h:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::getImageData):
* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::filterToken):
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::notifyFinished):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation):
(WebCore::ContentSecurityPolicy::logUnrecognizedDirective):
* page/EventSource.cpp:
(WebCore::EventSource::didReceiveResponse):
* webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::looping):
(WebCore::AudioBufferSourceNode::setLooping):
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::createLowPass2Filter):
(WebCore::AudioContext::createHighPass2Filter):
* xml/XMLHttpRequest.cpp:
(WebCore::reportUnsafeUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebWorkers fail with document.domain set when accessing from subdomain
abarth@webkit.org [Tue, 8 Nov 2011 00:51:28 +0000 (00:51 +0000)]
WebWorkers fail with document.domain set when accessing from subdomain
https://bugs.webkit.org/show_bug.cgi?id=67978

Reviewed by Sam Weinig.

Source/WebCore:

Workers should ignore document.domain when deciding which URLs a
document can request, just like XMLHttpRequest and every other API.

Test: http/tests/workers/worker-document-domain-security.html

* workers/AbstractWorker.cpp:
(WebCore::AbstractWorker::resolveURL):

LayoutTests:

Test that a document can still create same-origin workers after setting
document.domain.

* http/tests/workers/worker-document-domain-security-expected.txt: Added.
* http/tests/workers/worker-document-domain-security.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG operationCreateThis slow path may get the wrong callee in case of inlining
fpizlo@apple.com [Tue, 8 Nov 2011 00:37:33 +0000 (00:37 +0000)]
DFG operationCreateThis slow path may get the wrong callee in case of inlining
https://bugs.webkit.org/show_bug.cgi?id=71647

Reviewed by Oliver Hunt.

No new tests because I only saw this manifest itself when I had other bugs
leading to spurious slow path executions.

* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix chromium cg results for css2.1/20110323/block-non-replaced-width-008.html
tony@chromium.org [Tue, 8 Nov 2011 00:33:20 +0000 (00:33 +0000)]
Fix chromium cg results for css2.1/20110323/block-non-replaced-width-008.html

* platform/chromium-cg-mac-leopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAllow gamepad API to be enabled at runtime
commit-queue@webkit.org [Tue, 8 Nov 2011 00:27:44 +0000 (00:27 +0000)]
Allow gamepad API to be enabled at runtime
https://bugs.webkit.org/show_bug.cgi?id=71736

Part of full patch, found at
https://bugs.webkit.org/show_bug.cgi?id=69451

Patch by Scott Graham <scottmg@chromium.org> on 2011-11-07
Reviewed by Adam Barth.

No new tests. No new functionality.

* bindings/generic/RuntimeEnabledFeatures.cpp:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setGamepadsEnabled):
(WebCore::RuntimeEnabledFeatures::gamepadsEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove [CustomGetter] IDL for window.Option of V8
haraken@chromium.org [Tue, 8 Nov 2011 00:10:42 +0000 (00:10 +0000)]
Remove [CustomGetter] IDL for window.Option of V8
https://bugs.webkit.org/show_bug.cgi?id=71735

Reviewed by Nate Chapin.

Currently, window.Option uses a custom getter to get the template
of 'HTMLOptionElementConstructor'. However, this getter does not need to
be custom and can use a default getter
'DOMWindowInternal::DOMWindowConstructorGetter'.

Tests: fast/js/custom-constructors.html
       fast/forms/option-index.html
       fast/forms/add-and-remove-option.html
       fast/dom/dom-add-optionelement.html

* bindings/v8/custom/V8DOMWindowCustom.cpp: Removed a custom getter.
* page/DOMWindow.idl: Removed [CustomGetter] IDL from window.Option of V8. Renamed 'HTMLOptionElementConstructor' to 'HTMLOptionElementConstructorConstructor' in order to make window.Option use the template of (not 'HTMLOptionElement' but) 'HTMLOptionElementConstructor'. Note that CodeGenerator*.pm strips /Constructor$/ from the IDL type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDe-virtualize JSObject::putWithAttributes
mhahnenberg@apple.com [Mon, 7 Nov 2011 23:57:37 +0000 (23:57 +0000)]
De-virtualize JSObject::putWithAttributes
https://bugs.webkit.org/show_bug.cgi?id=71716

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added putWithAttributes to the MethodTable, changed all the virtual
implementations of putWithAttributes to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* API/JSObjectRef.cpp:
(JSObjectSetProperty):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::putWithAttributes):
* debugger/DebuggerActivation.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
* runtime/ClassInfo.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::putWithAttributes):
* runtime/JSActivation.h:
* runtime/JSCell.cpp:
(JSC::JSCell::putWithAttributes):
* runtime/JSCell.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::putWithAttributes):
* runtime/JSGlobalObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::putWithAttributes):
(JSC::putDescriptor):
* runtime/JSObject.h:
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::putWithAttributes):
* runtime/JSStaticScopeObject.h:
* runtime/JSVariableObject.cpp:
(JSC::JSVariableObject::putWithAttributes):
* runtime/JSVariableObject.h:

Source/WebCore:

No new tests.

Added putWithAttributes to the MethodTable, changed all the virtual
implementations of putWithAttributes to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::putWithAttributes):
* bindings/js/JSDOMWindowShell.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] restore original expectation for fast/frames/sandboxed-iframe-navigation...
tony@chromium.org [Mon, 7 Nov 2011 23:53:04 +0000 (23:53 +0000)]
[chromium] restore original expectation for fast/frames/sandboxed-iframe-navigation-targetlink.html

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Release build fix.
dslomov@google.com [Mon, 7 Nov 2011 23:49:17 +0000 (23:49 +0000)]
Unreviewed. Release build fix.

* parser/Lexer.cpp:
(JSC::assertCharIsIn8BitRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r99470.
commit-queue@webkit.org [Mon, 7 Nov 2011 23:46:08 +0000 (23:46 +0000)]
Unreviewed, rolling out r99470.
http://trac.webkit.org/changeset/99470
https://bugs.webkit.org/show_bug.cgi?id=71740

"Broke test-webkitpy" (Requested by eseidel2 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-07

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=71490
bdakin@apple.com [Mon, 7 Nov 2011 23:45:23 +0000 (23:45 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=71490
Support uiStateTransitionProgress for scrollbars
-and corresponding-
<rdar://problem/9849612>

Reviewed by Sam Weinig.

Source/WebCore:

Step 1 of supporting uiStateTransitionProgress is knowing when the mouse has
entered or exited a scrollbar. These changes to Scrollbar pass that information
on to the ScrollAnimator. Also, Scrollbar::mouseUp() now takes a
PlatformMouseEvent as a parameter. This is necessary because m_hoveredNode is not
always up to date on a mouseUp, so mouseUp must hitTest the scrollbar to see if
the mouse has exited the scrollbar.
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::mouseMoved):
(WebCore::Scrollbar::mouseExited):
(WebCore::Scrollbar::mouseUp):
* platform/Scrollbar.h:

These changes are required now that Scrollbar::mouseUp() takes a parameter.
* WebCore.exp.in:
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
* platform/chromium/PopupListBox.cpp:
(WebCore::PopupListBox::handleMouseReleaseEvent):
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::wndProc):

ScrollAnimator passes the information on to AppKit.
* platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::mouseEnteredScrollbar):
(WebCore::ScrollAnimator::mouseExitedScrollbar):
* platform/mac/ScrollAnimatorMac.h:
(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):

There are several new pieces of AppKit api we must call into.
* platform/mac/NSScrollerImpDetails.h:

This is a temporary function that is needed for the time being since there is new
AppKit api required for this to work.
* platform/mac/ScrollAnimatorMac.mm:
(supportsUIStateTransitionProgress):

I refactored WebScrollbarPartAnimation so that it can handle the
uiStateTransitionProgress animation as well as the alpha animations it already
handled. This mostly involved re-naming things and making use of a new enum called
FeatureToAnimate which keeps track of what the instance of
WebScrollbarPartAnimation is animating.
(-[WebScrollbarPartAnimation initWithScrollbarPainter:animate:scrollAnimator:animateFrom:animateTo:duration:]):
(-[WebScrollbarPartAnimation setScrollbarPainter:]):
(-[WebScrollbarPartAnimation setStartValue:]):
(-[WebScrollbarPartAnimation setEndValue:]):
(-[WebScrollbarPartAnimation setCurrentProgress:]):

WebScrollbarPainterDelegate has two new animations,
_verticalUIStateTransitionAnimation, and _horizontalUIStateTransitionAnimation. It
also responds to a few new delegate calls.
(-[WebScrollbarPainterDelegate cancelAnimations]):

This is a new delegate call needed for uiStateTransitionProgress.
(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):

I re-named setUpAnimation to setUpAlphaAnimation since it does a lot of things
that are specific to the alpha animation and I chose not to re-use it for
uiStateTransition.
(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):

New delegate call for the uiStateTransition animation that sets up that animation
and kicks it off.
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]):

Source/WebKit/chromium:

Scrollbar::mouseUp() now takes a PlatformMouseEvent as a parameter.
* src/WebScrollbarImpl.cpp:
(WebKit::WebScrollbarImpl::onMouseUp):

Source/WebKit/win:

Scrollbar::mouseUp() now takes a PlatformMouseEvent as a parameter.
* WebScrollBar.cpp:
(WebScrollBar::handleMouseEvent):

Source/WebKit2:

Scrollbar::mouseUp() now takes a PlatformMouseEvent as a parameter.
* UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::onLButtonUp):
* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::handleMouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove unnecessary use of function pointer in FrameSelection::modify()
aboxhall@chromium.org [Mon, 7 Nov 2011 23:43:21 +0000 (23:43 +0000)]
Remove unnecessary use of function pointer in FrameSelection::modify()
https://bugs.webkit.org/show_bug.cgi?id=71646

Reviewed by Ryosuke Niwa.

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::modify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed Windows build fix after r99468.
andreas.kling@nokia.com [Mon, 7 Nov 2011 23:39:29 +0000 (23:39 +0000)]
Unreviewed Windows build fix after r99468.

* css/CSSPrimitiveValue.h: Unmark single-argument constructors
as explicit, since this conflicts with the template constructors
in CSSPrimitiveValueMappings.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix due to a erroneous search-and-replace.
jer.noble@apple.com [Mon, 7 Nov 2011 23:25:52 +0000 (23:25 +0000)]
Build fix due to a erroneous search-and-replace.

Unreviewed build fix.

Replace all instances of GenericClock with ClockGeneric.

* WebCore.xcodeproj/project.pbxproj:
* platform/ClockGeneric.cpp:
(ClockGeneric::ClockGeneric):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove parseSandboxPolicy to SecurityContext
abarth@webkit.org [Mon, 7 Nov 2011 23:20:18 +0000 (23:20 +0000)]
Move parseSandboxPolicy to SecurityContext
https://bugs.webkit.org/show_bug.cgi?id=71732

Reviewed by Eric Seidel.

As requested by Eric, this patch resolves a layering inversion.  Now
that we have SecurityContext to hold the sandbox bits and the origin,
it's a logical place to put the parser for sandbox policies.

* dom/SecurityContext.cpp:
(WebCore::SecurityContext::parseSandboxPolicy):
* dom/SecurityContext.h:
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseMappedAttribute):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::applySandboxPolicy):
* page/SecurityOrigin.cpp:
* page/SecurityOrigin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename PlatformClockPOSIX -> ClockGeneric, and use WTF::currentTime() for its timing...
jer.noble@apple.com [Mon, 7 Nov 2011 23:17:42 +0000 (23:17 +0000)]
Rename PlatformClockPOSIX -> ClockGeneric, and use WTF::currentTime() for its timing source.
https://bugs.webkit.org/show_bug.cgi?id=71702

Reviewed by Sam Weinig.

No new tests; covered by existing tests.

* platform/Clock.cpp:
(Clock::create):
* platform/ClockGeneric.cpp: Renamed from Source/WebCore/platform/posix/PlatformClockPOSIX.cpp.
(ClockGeneric::GenericClock):
(ClockGeneric::setCurrentTime):
(ClockGeneric::currentTime):
(ClockGeneric::setPlayRate):
(ClockGeneric::start):
(ClockGeneric::stop):
* platform/ClockGeneric.h: Renamed from Source/WebCore/platform/posix/PlatformClockPOSIX.h.
(WebCore::ClockGeneric::playRate):
(WebCore::ClockGeneric::isRunning):

Boilerplate project file changes:
* CMakeLists.txt:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] disable 2 tests that are slow in debug
tony@chromium.org [Mon, 7 Nov 2011 23:16:47 +0000 (23:16 +0000)]
[chromium] disable 2 tests that are slow in debug

* platform/chromium/test_expectations.txt: only run
    fast/frames/lots-of-iframes.html and fast/frames/lots-of-objects.html
    in release builds

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwitch the value profiler back to 8 buckets, because we suspect that while this
fpizlo@apple.com [Mon, 7 Nov 2011 23:08:54 +0000 (23:08 +0000)]
Switch the value profiler back to 8 buckets, because we suspect that while this
is more expensive it's also more stable.

Rubber stamped by Geoff Garen.

* bytecode/ValueProfile.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Create a separate setting for compositing of for scrollable [i]frames
vangelis@chromium.org [Mon, 7 Nov 2011 23:03:05 +0000 (23:03 +0000)]
Source/WebCore: Create a separate setting for compositing of for scrollable [i]frames
that forceCompositingMode can be used without turning frames into composited layers.
https://bugs.webkit.org/show_bug.cgi?id=71714

Reviewed by James Robinson.

* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setAcceleratedCompositingForScrollableFramesEnabled):
(WebCore::Settings::acceleratedCompositingForScrollableFramesEnabled):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
* testing/Internals.cpp:
(WebCore::Internals::setEnableCompositingForScrollableFrames):
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests: [chromium] Make compositing for scrollable [i]frames a setting separate from
forceCompositingMode.
https://bugs.webkit.org/show_bug.cgi?id=71714

Adjust the force-compositing-mode layout tests to explicitly set the new flag.

Reviewed by James Robinson.

* platform/chromium/compositing/force-compositing-mode/force-composite-empty.html:
* platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html:
* platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html:
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html:
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html:
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[MutationObservers] Fix mac build (with mutation_observers enabled)
commit-queue@webkit.org [Mon, 7 Nov 2011 22:55:30 +0000 (22:55 +0000)]
[MutationObservers] Fix mac build (with mutation_observers enabled)
https://bugs.webkit.org/show_bug.cgi?id=71728

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-07
Reviewed by Tony Chang.

Errant forward declaration of MutationObserverRegistration removed from
Node.h this would have broken a port that tried to build with mutation_observers=1.

* dom/Node.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago The Full Keyboard Access preference should be read in the UI process
ap@apple.com [Mon, 7 Nov 2011 22:51:59 +0000 (22:51 +0000)]
    The Full Keyboard Access preference should be read in the UI process
        https://bugs.webkit.org/show_bug.cgi?id=71734
        <rdar://problem/9237619>

        Reviewed by Darin Adler.

        This is consistent with how other global preferences (like language) are handled, and lets
        us tighten up the sandbox a little.

        * Shared/WebProcessCreationParameters.cpp:
        (WebKit::WebProcessCreationParameters::encode):
        (WebKit::WebProcessCreationParameters::decode):
        * Shared/WebProcessCreationParameters.h:
        Added fullKeyboardAccessEnabled, so that newly started processes have the right preference value.

        * UIProcess/WebContext.h:
        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::fullKeyboardAccessModeChanged): If preference changes while a web process
        is already running, tell it.
        (WebKit::WebContext::ensureWebProcess): Set parameters.fullKeyboardAccessEnabled from current
        preference.

        * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::fullKeyboardAccessEnabled):
        * UIProcess/mac/WebProcessProxyMac.mm: (WebKit::WebProcessProxy::fullKeyboardAccessEnabled):
        * UIProcess/WebProcessProxy.h:
        Proxy it to Objective-C code. WebProcessProxy is as good place to have the static function
        as any. One day, we will make code more consistent with language and other global preferences.

        * UIProcess/mac/WKFullKeyboardAccessWatcher.h: Copied from Source/WebKit2/WebProcess/mac/WKFullKeyboardAccessWatcher.h.
        * UIProcess/mac/WKFullKeyboardAccessWatcher.mm: Copied from Source/WebKit2/WebProcess/mac/WKFullKeyboardAccessWatcher.mm.
        * WebProcess/mac/WKFullKeyboardAccessWatcher.h: Removed.
        * WebProcess/mac/WKFullKeyboardAccessWatcher.mm: Removed.
        (-[WKFullKeyboardAccessWatcher retrieveKeyboardUIModeFromPreferences:]): Once retrieved,
        push the preference value.

        * WebKit2.xcodeproj/project.pbxproj: WKFullKeyboardAccessWatcher is now in UI process.

        * WebProcess/WebProcess.h:
        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::WebProcess):
        (WebKit::WebProcess::fullKeyboardAccessModeChanged):
        (WebKit::WebProcess::fullKeyboardAccessEnabled):
        * WebProcess/mac/WebProcessMac.mm:
        WebCprocess now holds the preference value in a mamber value, which UI process pushes
        updates to.

        * WebProcess/WebProcess.messages.in: Added a message for changes preference value.

        * WebProcess/com.apple.WebProcess.sb: We no longer need read access to com.apple.universalaccess.plist.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate chromium test_expectations.txt.
tony@chromium.org [Mon, 7 Nov 2011 22:46:35 +0000 (22:46 +0000)]
Update chromium test_expectations.txt.

* platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png:
    Fix result that was attempted to be fixed in r99457.
* platform/chromium/test_expectations.txt: Tests that need a baseline
    after 99454.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove [CustomGetter] IDL from 'HTMLAudioElementConstructor' of V8
haraken@chromium.org [Mon, 7 Nov 2011 22:39:41 +0000 (22:39 +0000)]
Remove [CustomGetter] IDL from 'HTMLAudioElementConstructor' of V8
https://bugs.webkit.org/show_bug.cgi?id=71660

Reviewed by Adam Barth.

Currently, "new Audio()" uses a custom getter to get the template
of 'HTMLAudioElementConstructor'. However, this getter does not need to
be custom and can use a default getter 'DOMWindowInternal::DOMWindowConstructorGetter'.

Tests: fast/js/custom-constructors.html
       media/audio-constructor.html
       media/audio-constructor-src.html
       media/audio-constructor-preload.html
       media/audio-controls-do-not-fade-out.html
       media/audio-controls-rendering.html

* bindings/v8/custom/V8DOMWindowCustom.cpp: Removed a custom getter.
* page/DOMWindow.idl: Removed [CustomGetter] IDL from 'HTMLAudioElementConstructor' of V8. Renamed 'HTMLAudioElementConstructor' to 'HTMLAudioElementConstructorConstructor' in order to make 'new Audio()' use the template of (not 'HTMLAudioElement' but) 'HTMLAudioElementConstructor'. Note that CodeGenerator*.pm strips /Constructor$/ from an IDL type.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation): If an IDL type is 'XXXXConstructorConstructor', then we do not add a header file 'XXXXConstructor.h' to JSDOMWindow.cpp, because the NamedConstructor declaration is written in the header file of class XXXX 'XXXX.h'. Incidentally, the reason why CodeGeneratorV8.pm does not need a corresponding change is that V8 is still generating the NamedConstructor declaration in its dedicated header file 'XXXXConstructor.h'. This V8 issue will be fixed in the upcoming patch that implements [NamedConstructor] IDL in V8.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Emit the "frame,created" signal earlier.
commit-queue@webkit.org [Mon, 7 Nov 2011 22:38:32 +0000 (22:38 +0000)]
[EFL] Emit the "frame,created" signal earlier.
https://bugs.webkit.org/show_bug.cgi?id=71696

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-07
Reviewed by Kenneth Rohde Christiansen.

FrameLoader::loadURLIntoChildFrame will trigger the machinery that will call
FrameLoaderClientEfl::dispatchDidStartProvisionalLoad. However, since we were
emitting the "frame,created" signal after that, applications would connect to
it after some other frame signals had already been emitted. Should help tests
such as http/tests/loading/empty-subframe.html pass.

* ewk/ewk_frame.cpp:
(ewk_frame_child_add):
* ewk/ewk_view.cpp:
(ewk_view_frame_create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLayout Test fast/events/platform-wheelevent-paging-x-in-scrolling-page.html is failing
tony@chromium.org [Mon, 7 Nov 2011 22:35:13 +0000 (22:35 +0000)]
Layout Test fast/events/platform-wheelevent-paging-x-in-scrolling-page.html is failing
https://bugs.webkit.org/show_bug.cgi?id=71606

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-07
Reviewed by Tony Chang.

* platform/chromium/test_expectations.txt: Remove the expected failure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] update flakiness dashboard to reflect current bots
tony@chromium.org [Mon, 7 Nov 2011 22:31:30 +0000 (22:31 +0000)]
[chromium] update flakiness dashboard to reflect current bots

Reviewed by Ojan Vafai.

* TestResultServer/static-dashboards/builders.js: Remove (deps) debug
    bots and merged linux debug bots into a single bot.
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
(setupExpectationsTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUninitialized Heap member var
commit-queue@webkit.org [Mon, 7 Nov 2011 22:20:20 +0000 (22:20 +0000)]
Uninitialized Heap member var
https://bugs.webkit.org/show_bug.cgi?id=71722

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-11-07
Reviewed by Filip Pizlo.

* heap/Heap.cpp:
(JSC::Heap::Heap): Initialize m_blockFreeingThreadShouldQuit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG 32_64 - registers cannot be reused arbitrarily if speculation failures are possible
yuqiang.xian@intel.com [Mon, 7 Nov 2011 22:13:50 +0000 (22:13 +0000)]
DFG 32_64 - registers cannot be reused arbitrarily if speculation failures are possible
https://bugs.webkit.org/show_bug.cgi?id=71684

Reviewed by Filip Pizlo.

Currently in DFG JIT, we try to reuse the physical register of an
operand for temporary usage if the current use of the operand is the
last use. But sometimes this can be wrong, for example if there are
possible speculation failures and we need to fallback to baseline JIT,
the value of the operand which is supposed to be hold in the physical
register can be modified by register reusing. The fixes the last
inspector failures in layout test on Mac 32-bit if switching on DFG.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r99436): Broke Snow Leopard debug build
rniwa@webkit.org [Mon, 7 Nov 2011 22:10:08 +0000 (22:10 +0000)]
REGRESSION(r99436): Broke Snow Leopard debug build
https://bugs.webkit.org/show_bug.cgi?id=71713

Reviewed by Darin Adler.

Put the assertion in a template and use template specialization
to avoid warning when instantiated with UChar or LChar.

In the long term, we should have traits for unsigned integral types
and use that to specialize template instead of specializing it for UChar and LChar.

* parser/Lexer.cpp:
(JSC::assertCharIsIn8BitRange):
(JSC::::append8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd TiledCoreAnimationDrawingArea stub classes
andersca@apple.com [Mon, 7 Nov 2011 22:09:12 +0000 (22:09 +0000)]
Add TiledCoreAnimationDrawingArea stub classes
https://bugs.webkit.org/show_bug.cgi?id=71729

Reviewed by Sam Weinig.

* Shared/DrawingAreaInfo.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView _shouldUseTiledDrawingArea]):
(-[WKView WebKit::]):
* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm: Copied from Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp.
(WebKit::TiledCoreAnimationDrawingAreaProxy::create):
(WebKit::TiledCoreAnimationDrawingAreaProxy::TiledCoreAnimationDrawingAreaProxy):
(WebKit::TiledCoreAnimationDrawingAreaProxy::~TiledCoreAnimationDrawingAreaProxy):
(WebKit::TiledCoreAnimationDrawingAreaProxy::deviceScaleFactorDidChange):
(WebKit::TiledCoreAnimationDrawingAreaProxy::sizeDidChange):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h: Copied from Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: Copied from Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp.
(WebKit::TiledCoreAnimationDrawingArea::create):
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::~TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::setNeedsDisplay):
(WebKit::TiledCoreAnimationDrawingArea::scroll):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerSync):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Update WebCore.gyp to not use WebKitLibraries in include_dirs
commit-queue@webkit.org [Mon, 7 Nov 2011 22:03:55 +0000 (22:03 +0000)]
[chromium] Update WebCore.gyp to not use WebKitLibraries in include_dirs
https://bugs.webkit.org/show_bug.cgi?id=71694

Patch by Robert Sesek <rsesek@chromium.org> on 2011-11-07
Reviewed by Adam Barth.

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove initPopStateEvent method
dominicc@chromium.org [Mon, 7 Nov 2011 21:59:19 +0000 (21:59 +0000)]
Remove initPopStateEvent method
https://bugs.webkit.org/show_bug.cgi?id=71691

Reviewed by Ojan Vafai.

Source/WebCore:

* dom/PopStateEvent.cpp:
* dom/PopStateEvent.h:
* dom/PopStateEvent.idl:

LayoutTests:

* fast/events/fire-popstate-event.html: use 'new PopStateEvent' now

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd cc-bugs group to watch changes in chromium graphics
commit-queue@webkit.org [Mon, 7 Nov 2011 21:30:41 +0000 (21:30 +0000)]
Add cc-bugs group to watch changes in chromium graphics
https://bugs.webkit.org/show_bug.cgi?id=71690

Patch by Dana Jansens <danakj@chromium.org> on 2011-11-07
Reviewed by James Robinson.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[NRWT] Parsing of test_expectations.txt should be agnostic to newline at end
commit-queue@webkit.org [Mon, 7 Nov 2011 21:20:10 +0000 (21:20 +0000)]
[NRWT] Parsing of test_expectations.txt should be agnostic to newline at end
https://bugs.webkit.org/show_bug.cgi?id=70912

Patch by Balazs Ankes <Ankes.Balazs@stud.u-szeged.hu> on 2011-11-07
Reviewed by Ojan Vafai.

* Scripts/webkitpy/layout_tests/port/webkit.py: Add newline at the end of test_expectations.txt.
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Make up the test_test_expectations method for the updated webkit.py.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCSSValue: Devirtualize isFooType().
andreas.kling@nokia.com [Mon, 7 Nov 2011 21:19:45 +0000 (21:19 +0000)]
CSSValue: Devirtualize isFooType().
<http://webkit.org/b/71668>

Reviewed by Darin Adler.

Add a member to CSSValue to determine which subclass a given
value object is, along with 5 bits to tell us whether the
value is primitive/mutable/initial/inherited/a list.

All non-private subclass constructors now take CSSValue::ClassType
as their first argument. A few constructors were duplicated as
private members to allow calling them from ::create() methods
without passing an explicit ClassType.

Furthermore, since CSSValue::cssValueType() can be inferred from
the subclass type, we compute it instead of storing it in a member.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

    Adding CSSValue.cpp.

* css/CSSValue.cpp: Added.
(WebCore::CSSValue::cssValueType):

    Out-of-line implementation of this method. Only used by CSSOM.

* css/CSSValue.h:
(WebCore::CSSValue::isMutableValue):
(WebCore::CSSValue::isPrimitiveValue):
(WebCore::CSSValue::isValueList):
(WebCore::CSSValue::isInitialValue):
(WebCore::CSSValue::isInheritedValue):
(WebCore::CSSValue::isBorderImageValue):
(WebCore::CSSValue::isBorderImageSliceValue):
(WebCore::CSSValue::isCursorImageValue):
(WebCore::CSSValue::isFontFamilyValue):
(WebCore::CSSValue::isFontFeatureValue):
(WebCore::CSSValue::isFontValue):
(WebCore::CSSValue::isImageGeneratorValue):
(WebCore::CSSValue::isImageValue):
(WebCore::CSSValue::isImplicitInitialValue):
(WebCore::CSSValue::isReflectValue):
(WebCore::CSSValue::isShadowValue):
(WebCore::CSSValue::isTimingFunctionValue):
(WebCore::CSSValue::isWebKitCSSTransformValue):
(WebCore::CSSValue::isCSSLineBoxContainValue):
(WebCore::CSSValue::isFlexValue):
(WebCore::CSSValue::isWebKitCSSFilterValue):
(WebCore::CSSValue::isSVGColor):
(WebCore::CSSValue::isSVGPaint):
(WebCore::CSSValue::classType):
(WebCore::CSSValue::CSSValue):
(WebCore::CSSValue::isPrimitiveType):
(WebCore::CSSValue::isListType):
(WebCore::CSSValue::isMutableType):
(WebCore::CSSValue::isInheritedType):
(WebCore::CSSValue::isInitialType):

    Store subclass type information into a member variable and
    made all the isFooValue() functions non-virtual and inline.
    Some subclass type lookups (primitive values, notably) are
    cached in a bool member on construction.

* css/CSSAspectRatioValue.h:
(WebCore::CSSAspectRatioValue::CSSAspectRatioValue):
* css/CSSBorderImageSliceValue.cpp:
(WebCore::CSSBorderImageSliceValue::CSSBorderImageSliceValue):
* css/CSSBorderImageSliceValue.h:
* css/CSSBorderImageValue.cpp:
(WebCore::CSSBorderImageValue::CSSBorderImageValue):
* css/CSSBorderImageValue.h:
* css/CSSCanvasValue.h:
(WebCore::CSSCanvasValue::CSSCanvasValue):
* css/CSSCrossfadeValue.h:
(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
* css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::CSSCursorImageValue):
* css/CSSCursorImageValue.h:
* css/CSSFlexValue.h:
(WebCore::CSSFlexValue::CSSFlexValue):
* css/CSSFontFaceSrcValue.h:
(WebCore::CSSFontFaceSrcValue::CSSFontFaceSrcValue):
* css/CSSFunctionValue.cpp:
(WebCore::CSSFunctionValue::CSSFunctionValue):
* css/CSSGradientValue.h:
(WebCore::CSSGradientValue::isLinearGradient):
(WebCore::CSSGradientValue::isRadialGradient):
(WebCore::CSSGradientValue::CSSGradientValue):
(WebCore::CSSLinearGradientValue::CSSLinearGradientValue):
(WebCore::CSSRadialGradientValue::CSSRadialGradientValue):
* css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::CSSImageGeneratorValue):
* css/CSSImageGeneratorValue.h:
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::CSSImageValue):
* css/CSSImageValue.h:
* css/CSSInheritedValue.h:
(WebCore::CSSInheritedValue::CSSInheritedValue):
* css/CSSInitialValue.h:
(WebCore::CSSInitialValue::CSSInitialValue):
(WebCore::CSSInitialValue::create):
* css/CSSLineBoxContainValue.cpp:
(WebCore::CSSLineBoxContainValue::CSSLineBoxContainValue):
* css/CSSLineBoxContainValue.h:
* css/CSSMutableValue.h:
(WebCore::CSSMutableValue::CSSMutableValue):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSReflectValue.h:
(WebCore::CSSReflectValue::CSSReflectValue):
* css/CSSTimingFunctionValue.h:
(WebCore::CSSTimingFunctionValue::isLinearTimingFunctionValue):
(WebCore::CSSTimingFunctionValue::isCubicBezierTimingFunctionValue):
(WebCore::CSSTimingFunctionValue::isStepsTimingFunctionValue):
(WebCore::CSSTimingFunctionValue::CSSTimingFunctionValue):
(WebCore::CSSLinearTimingFunctionValue::CSSLinearTimingFunctionValue):
(WebCore::CSSCubicBezierTimingFunctionValue::CSSCubicBezierTimingFunctionValue):
(WebCore::CSSStepsTimingFunctionValue::CSSStepsTimingFunctionValue):
* css/CSSUnicodeRangeValue.h:
(WebCore::CSSUnicodeRangeValue::CSSUnicodeRangeValue):
* css/CSSValueList.cpp:
(WebCore::CSSValueList::CSSValueList):
* css/CSSValueList.h:
* css/FontFamilyValue.cpp:
(WebCore::FontFamilyValue::FontFamilyValue):
* css/FontFamilyValue.h:
* css/FontFeatureValue.cpp:
(WebCore::FontFeatureValue::FontFeatureValue):
* css/FontFeatureValue.h:
* css/FontValue.h:
(WebCore::FontValue::FontValue):
* css/ShadowValue.cpp:
(WebCore::ShadowValue::ShadowValue):
* css/ShadowValue.h:
* css/WebKitCSSFilterValue.cpp:
(WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue):
* css/WebKitCSSFilterValue.h:
* css/WebKitCSSTransformValue.cpp:
(WebCore::WebKitCSSTransformValue::WebKitCSSTransformValue):
* css/WebKitCSSTransformValue.h:
* svg/SVGColor.cpp:
(WebCore::SVGColor::SVGColor):
* svg/SVGColor.h:
* svg/SVGPaint.cpp:
(WebCore::SVGPaint::SVGPaint):
* svg/SVGPaint.h:

    Propagate subclass type information and kill isFooType() virtuals.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLeaks seen in RenderRegion::setRenderBoxRegionInfo on Leaks bot
mihnea@adobe.com [Mon, 7 Nov 2011 21:14:53 +0000 (21:14 +0000)]
Leaks seen in RenderRegion::setRenderBoxRegionInfo on Leaks bot
https://bugs.webkit.org/show_bug.cgi?id=71259

Reviewed by Darin Adler.

Leak fixes covered by existing tests.

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::logicalWidthChangedInRegions):
The RenderBoxRegionInfo taken out of RenderRegion must be deleted on all code paths.
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::removeRenderBoxRegionInfo):
The RenderBoxRegionInfo map owns the values, therefore, when values are removed from map
they must also be deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoiframe sandbox treats vertical tab as a valid delimiter
abarth@webkit.org [Mon, 7 Nov 2011 21:05:06 +0000 (21:05 +0000)]
iframe sandbox treats vertical tab as a valid delimiter
https://bugs.webkit.org/show_bug.cgi?id=71704

Reviewed by Eric Seidel.

Source/WebCore:

This patch adjusts our parser slightly to match the HTML5 spec.  The
only difference is in how we handle vertical tabs.  Previously, we
treated them as a delimiter, but we're not supposed to do that.

Test: fast/frames/sandboxed-iframe-parsing-space-characters.html

* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::parseSandboxPolicy):

LayoutTests:

Test which space-like charaters are treating as delimiters.

* fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt: Added.
* fast/frames/sandboxed-iframe-parsing-space-characters.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFollow-up build fix.
andersca@apple.com [Mon, 7 Nov 2011 21:01:45 +0000 (21:01 +0000)]
Follow-up build fix.

* WebProcess/WebPage/DrawingAreaImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFactor SecurityContext out of ScriptExecutionContext
abarth@webkit.org [Mon, 7 Nov 2011 21:01:14 +0000 (21:01 +0000)]
Factor SecurityContext out of ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=71721

Reviewed by Eric Seidel.

The new SecurityContext object lets us tightly scope control of
the security-critical information in ScriptExecutionContext.
Originally I had hoped to put all this state on SecurityOrigin, but
SecurityOrigin gets shared between documents in some corner cases, so
it's not a good fit for state like the sandbox flags and the CSP policy
that really needs to be per-document.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::ScriptExecutionContext):
* dom/ScriptExecutionContext.h:
* loader/FrameLoader.h:
* loader/FrameLoaderTypes.h:
* page/SecurityOrigin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRefactor CodeGeneratorV8.pm before making a core change for bug 71093.
haraken@chromium.org [Mon, 7 Nov 2011 20:50:13 +0000 (20:50 +0000)]
Refactor CodeGeneratorV8.pm before making a core change for bug 71093.
https://bugs.webkit.org/show_bug.cgi?id=71659

Reviewed by Adam Barth.

Just refactor CodeGeneratorV8.pm without any change in behavior,
as the first step for fixing bug 71093.

Tests: WebCore/bindings/scripts/test/TestObj.idl
       WebCore/bindings/scripts/test/TestInterface.idl

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader): Sort generated headers in alphabetical order. Removed unnecessary variable names from method signatures. These changes are for silencing style check errors when a new TestXXXX.idl is added.
(GenerateConstructorCallback): Renamed variables to clarify their roles.
(WriteData): Removed an unused array @implHeaderContent.
* bindings/scripts/test/V8/V8TestInterface.h: Updated a run-binding-tests result.
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h: Ditto.
* bindings/scripts/test/V8/V8TestObj.h: Ditto.
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash due to mixed direction text runs
commit-queue@webkit.org [Mon, 7 Nov 2011 20:48:35 +0000 (20:48 +0000)]
Crash due to mixed direction text runs
https://bugs.webkit.org/show_bug.cgi?id=66015

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-11-07
Reviewed by David Hyatt.

Source/WebCore:

Test for bug fix.

* fast/text/international/bidi-neutral-in-mixed-direction-run-crash.html: Added
* fast/text/international/bidi-neutral-in-mixed-direction-run-cras-expected.txt: Added

LayoutTests:

In some cases extra bidi runs were being added because appendRun() was being called
after the last run of the line was already appended.

This converts a previous fix for this bug to an ASSERT, because the check is
unnecessary, though it is a symptom that text runs have somehow gotten messed up.

* rendering/InlineIterator.h:
(WebCore::InlineBidiResolver::appendRun): Abort append if we've already appended the last
run of the line
* rendering/RenderBox.cpp:
(WebCore::RenderBox::positionLineBox): Revert the previous patch, change to an assert

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agonew-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests
eric@webkit.org [Mon, 7 Nov 2011 20:42:33 +0000 (20:42 +0000)]
new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=62199

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogetBBox() on a SVGPathElement with curves incorrectly includes control points
timothy_horton@apple.com [Mon, 7 Nov 2011 20:40:24 +0000 (20:40 +0000)]
getBBox() on a SVGPathElement with curves incorrectly includes control points
https://bugs.webkit.org/show_bug.cgi?id=53512
<rdar://problem/9861154>

Reviewed by Oliver Hunt.

Split Path::boundingRect() into two, adding Path::fastBoundingRect()
for a rough estimate of the bounding rect (always equal to or larger
than boundingRect()). fastBoundingRect() currently falls back to
boundingRect() for all ports besides CG, though in most cases
(on a port-by-port basis) the current implementation of boundingRect()
will need to become fastBoundingRect(), and a new, more accurate method will
be implemented for boundingRect().

All previous callers of boundingRect() are transitioned to using fastBoundingRect()
except SVGPathElement::getBBox, which wants an accurate bounding box.

The CoreGraphics implementation of Path::boundingRect() called
CGPathGetBoundingBox, which includes the path's control points in its
calculations. Snow Leopard added CGPathGetPathBoundingBox, which
finds the bounding box of only points within the path, and does not
include control points. On Snow Leopard and above, we now use the latter.

Test: svg/custom/getBBox-path.svg

* html/HTMLAreaElement.cpp:
* html/canvas/CanvasRenderingContext2D.cpp:
* platform/graphics/Path.cpp:
* platform/graphics/Path.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
* platform/graphics/cg/PathCG.cpp:
(WebCore::Path::boundingRect):
* rendering/RenderObject.h:
* rendering/svg/RenderSVGPath.cpp:
* svg/SVGPathElement.cpp:
* svg/SVGPathElement.h:

Add a test that ensures that getBBox does not include control points in the rect it returns.

* platform/chromium/test_expectations.txt:
* svg/custom/getBBox-path-expected.txt: Added.
* svg/custom/getBBox-path.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Suggest box should be open immediately if forced by Ctrl+Space.
vsevik@chromium.org [Mon, 7 Nov 2011 20:37:06 +0000 (20:37 +0000)]
Web Inspector: Suggest box should be open immediately if forced by Ctrl+Space.
https://bugs.webkit.org/show_bug.cgi?id=71710

Reviewed by Pavel Feldman.

* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.clearAutoComplete):
(WebInspector.TextPrompt.prototype.autoCompleteSoon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Suggest box should consume enter key pressed event.
vsevik@chromium.org [Mon, 7 Nov 2011 20:35:16 +0000 (20:35 +0000)]
Web Inspector: Suggest box should consume enter key pressed event.
https://bugs.webkit.org/show_bug.cgi?id=71700

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):

LayoutTests:

* http/tests/inspector/inspector-test.js:
(initialize_InspectorTest.InspectorTest.evaluateInConsole):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] css2.1/20110323/block-non-replaced-width-008.htm fails on mac 10.5 CG
robert@webkit.org [Mon, 7 Nov 2011 20:29:09 +0000 (20:29 +0000)]
[chromium] css2.1/20110323/block-non-replaced-width-008.htm fails on mac 10.5 CG
https://bugs.webkit.org/show_bug.cgi?id=71214

Reviewed by Adam Barth.

* platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Build all libraries in both debug and release on Mac OS X
vestbo@webkit.org [Mon, 7 Nov 2011 20:26:49 +0000 (20:26 +0000)]
[Qt] Build all libraries in both debug and release on Mac OS X

We were already building the final shared library in debug and release,
but were missing the static JavaScriptCore and WebCore libraries, which
then broke the build.

Reviewed-by Andreas Kling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove unused DrawingArea::syncCompositingLayers
andersca@apple.com [Mon, 7 Nov 2011 20:21:36 +0000 (20:21 +0000)]
Remove unused DrawingArea::syncCompositingLayers
https://bugs.webkit.org/show_bug.cgi?id=71717

Reviewed by John Sullivan.

* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
* WebProcess/WebPage/TiledDrawingArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoOptimize outline rendering to avoid transparency layers
commit-queue@webkit.org [Mon, 7 Nov 2011 20:18:52 +0000 (20:18 +0000)]
Optimize outline rendering to avoid transparency layers
https://bugs.webkit.org/show_bug.cgi?id=60750

Source/WebCore:

Add fast path for solid block outlines with alpha.
Improve readability of piecewise path while at it.

Patch by David Barr <davidbarr@chromium.org> on 2011-11-07
Reviewed by Simon Fraser.

No intended change in behaviour, no new tests.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::paintOutline):

LayoutTests:

Rebaseline pixel tests to accommodate subtle change in rounding.

Patch by David Barr <davidbarr@chromium.org> on 2011-11-07
Reviewed by Simon Fraser.

* platform/chromium-linux/fast/box-shadow/box-shadow-radius-expected.png: Added.
* platform/chromium-linux/fast/layers/self-painting-outline-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Suggest box should not accept suggestion on space key pressed.
vsevik@chromium.org [Mon, 7 Nov 2011 20:09:42 +0000 (20:09 +0000)]
Web Inspector: Suggest box should not accept suggestion on space key pressed.
https://bugs.webkit.org/show_bug.cgi?id=71706

Reviewed by Pavel Feldman.

* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.SuggestBox.prototype.tabKeyPressed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Mark perf/documnet-contians.html as slow.
tony@chromium.org [Mon, 7 Nov 2011 19:32:04 +0000 (19:32 +0000)]
[chromium] Mark perf/documnet-contians.html as slow.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't use CSSOM's CSSValue.cssValueType internally in WebCore.
andreas.kling@nokia.com [Mon, 7 Nov 2011 19:20:59 +0000 (19:20 +0000)]
Don't use CSSOM's CSSValue.cssValueType internally in WebCore.
<http://webkit.org/b/71679>

Reviewed by Darin Adler.

Swap out cssValueType() usage for isPrimitiveValue(), isInitialValue()
and isInheritedValue() to increase code clarity.

The plan is to turn cssValueType() into a computed value based on the
CSSValue subclass (coming soon to <http://webkit.org/b/71668>.)
This is a clean-up in preparation for that.

* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::nameGetter):
* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(WebCore::V8CSSStyleDeclaration::namedPropertyGetter):
* css/CSSInheritedValue.h:
(WebCore::CSSInheritedValue::isInheritedValue):
* css/CSSInitialValue.h:
(WebCore::CSSInitialValue::isInitialValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseColor):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapFillAttachment):
(WebCore::CSSStyleSelector::mapFillClip):
(WebCore::CSSStyleSelector::mapFillComposite):
(WebCore::CSSStyleSelector::mapFillOrigin):
(WebCore::CSSStyleSelector::mapFillImage):
(WebCore::CSSStyleSelector::mapFillRepeatX):
(WebCore::CSSStyleSelector::mapFillRepeatY):
(WebCore::CSSStyleSelector::mapFillSize):
(WebCore::CSSStyleSelector::mapFillXPosition):
(WebCore::CSSStyleSelector::mapFillYPosition):
(WebCore::CSSStyleSelector::mapAnimationDelay):
(WebCore::CSSStyleSelector::mapAnimationDirection):
(WebCore::CSSStyleSelector::mapAnimationDuration):
(WebCore::CSSStyleSelector::mapAnimationFillMode):
(WebCore::CSSStyleSelector::mapAnimationIterationCount):
(WebCore::CSSStyleSelector::mapAnimationName):
(WebCore::CSSStyleSelector::mapAnimationPlayState):
(WebCore::CSSStyleSelector::mapAnimationProperty):
(WebCore::CSSStyleSelector::mapAnimationTimingFunction):
* css/CSSValue.h:
(WebCore::CSSValue::isInheritedValue):
(WebCore::CSSValue::isInitialValue):
* css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty):
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::extractFontSizeDelta):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename NetscapePlugin::wantsWindowRelativeNPWindowCoordinates to NetscapePlugin:...
andersca@apple.com [Mon, 7 Nov 2011 19:20:40 +0000 (19:20 +0000)]
Rename NetscapePlugin::wantsWindowRelativeNPWindowCoordinates to NetscapePlugin::wantsPluginRelativeNPWindowCoordinates
https://bugs.webkit.org/show_bug.cgi?id=71708

Reviewed by Sam Weinig.

The name wantsPluginRelativeNPWindowCoordinates is more clear than wantsWindowRelativeNPWindowCoordinates. Rename the functions
everywhere and, since the meaning is now inverted, invert the checks and return values.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::callSetWindow):
(WebKit::NetscapePlugin::geometryDidChange):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/NetscapePluginNone.cpp:
(WebKit::NetscapePlugin::wantsPluginRelativeNPWindowCoordinates):
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::wantsPluginRelativeNPWindowCoordinates):
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::wantsPluginRelativeNPWindowCoordinates):
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::wantsPluginRelativeNPWindowCoordinates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNetscapePlugin::wantsWindowRelativeNPWindowCoordinates should return false on Mac
andersca@apple.com [Mon, 7 Nov 2011 19:20:34 +0000 (19:20 +0000)]
NetscapePlugin::wantsWindowRelativeNPWindowCoordinates should return false on Mac
https://bugs.webkit.org/show_bug.cgi?id=71707

Reviewed by Sam Weinig.

This changes the way the fake Carbon plug-in window is positioned, so that it's always the same size
and location as the plug-in (relative to the screen).

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformGeometryDidChange):
Call updateFakeWindowBounds.

(WebKit::NetscapePlugin::updateFakeWindowBounds):
Convert the plug-in position to screen coordinates and set the window bounds to be the location and
size of the plug-in, where the location is relative to the screen.

(WebKit::NetscapePlugin::wantsWindowRelativeNPWindowCoordinates):
Return false.

(WebKit::NetscapePlugin::windowAndViewFramesChanged):
Call updateFakeWindowBounds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r99432.
ossy@webkit.org [Mon, 7 Nov 2011 19:12:08 +0000 (19:12 +0000)]
Unreviewed, rolling out r99432.
http://trac.webkit.org/changeset/99432
https://bugs.webkit.org/show_bug.cgi?id=71709

It made layout tests extra slow on all bots (Requested by
Ossy_night on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-07

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r99409): Broke transitions/clip-transition.html
andreas.kling@nokia.com [Mon, 7 Nov 2011 19:09:44 +0000 (19:09 +0000)]
REGRESSION(r99409): Broke transitions/clip-transition.html
<http://webkit.org/b/71692>

Reviewed by Darin Adler.

Add missing base class initializers to CSSPrimitiveValue constructors.
This was causing some CSSPrimitiveValues to masquerade as CSS_CUSTOM values.

* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWKPage.h should be in PrivateHeaders.
weinig@apple.com [Mon, 7 Nov 2011 18:46:58 +0000 (18:46 +0000)]
WKPage.h should be in PrivateHeaders.

Rubber-stamped by Anders Carlsson.

* WebKit2.xcodeproj/project.pbxproj:
Mark WKPage.h private.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Support requestAnimationFrame API
commit-queue@webkit.org [Mon, 7 Nov 2011 18:28:28 +0000 (18:28 +0000)]
[EFL] Support requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=67112

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2011-11-07
Reviewed by Andreas Kling.

.:

Add build-option for requestAnimationFrame feature.

* Source/cmake/OptionsEfl.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Let EFL port use REQUEST_ANIMATION_FRAME_TIMER.

* wtf/Platform.h:

Source/WebCore:

Add some files to build-target when enabling requestAnimationFrame option.

fast/animation/request-animation-frame-cancel.html
fast/animation/request-animation-frame-cancel2.html
fast/animation/request-animation-frame-display.html
fast/animation/request-animation-frame-during-modal.html
fast/animation/request-animation-frame-timestamps.html
fast/animation/request-animation-frame-within-callback.html
fast/animation/request-animation-frame.html

* CMakeLists.txt:
* UseJSC.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd missing .in and .pl files to the Xcode project for easy access.
weinig@apple.com [Mon, 7 Nov 2011 18:26:49 +0000 (18:26 +0000)]
Add missing .in and .pl files to the Xcode project for easy access.

Reviewed by Eric Carlson.

* WebCore.xcodeproj/project.pbxproj:
Add some missing files to the Xcode project.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore
fsamuel@chromium.org [Mon, 7 Nov 2011 18:24:48 +0000 (18:24 +0000)]
[Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore
https://bugs.webkit.org/show_bug.cgi?id=71485

Reviewed by Darin Fisher.

Source/WebKit/chromium:

Created new method setPageScaleFactor to replace scalePage to match
renamed method in WebCore. This change will happen in three stages:

1. A new method is created called setPageScaleFactor with the same
   functionality as scalePage.
2. All call sites of scalePage are changed to setPageScaleFactor in the Chromium
   repository.
3. scalePage is deleted from WebView/WebViewImpl

* public/WebView.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::pageScaleFactor):
(WebKit::WebViewImpl::scalePage):
(WebKit::WebViewImpl::setPageScaleFactor):
* src/WebViewImpl.h:

Tools:

* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::scalePageBy):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::resetTestController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNeed a way to allow a scheme access to Local Storage and Databases while Private...
jberlin@webkit.org [Mon, 7 Nov 2011 18:16:33 +0000 (18:16 +0000)]
Need a way to allow a scheme access to Local Storage and Databases while Private Browsing is
enabled.
https://bugs.webkit.org/show_bug.cgi?id=71631

Reviewed by Jon Honeycutt.

Source/WebCore:

Check the SchemeRegistry before preventing read/write access to Local Storage and Databases
in Private Browsing.

* WebCore.exp.in:
Export the symbols for registering the schemes as allowing Local Storage and Database access
in Private Browsing.

* dom/Document.cpp:
(WebCore::Document::allowDatabaseAccess):
Check if the scheme allows Database access in Private Browsing.

* platform/SchemeRegistry.cpp:
(WebCore::schemesAllowingLocalStorageAccessInPrivateBrowsing):
(WebCore::schemesAllowingDatabaseAccessInPrivateBrowsing):
(WebCore::SchemeRegistry::registerURLSchemeAsAllowingLocalStorageAccessInPrivateBrowsing):
(WebCore::SchemeRegistry::allowsLocalStorageAccessInPrivateBrowsing):
(WebCore::SchemeRegistry::registerURLSchemeAsAllowingDatabaseAccessInPrivateBrowsing):
(WebCore::SchemeRegistry::allowsDatabaseAccessInPrivateBrowsing):
* platform/SchemeRegistry.h:

* storage/Storage.cpp:
(WebCore::Storage::length):
Ask the storage area if it is disabled by Private Browsing in the frame instead of just
checking if Private Browsing is enabled for that frame because the answer might depend on
what type of storage that storage area is.
(WebCore::Storage::key):
Ditto.
(WebCore::Storage::getItem):
Ditto.
(WebCore::Storage::contains):
Ditto.

* storage/StorageArea.h:
Make it possible to query a StorageArea for whether it is disabled by Private Browsing in a
Frame.
* storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::disabledByPrivateBrowsingInFrame):
Renamed from privateBrowsingEnabled.
Check not only if Private Browsing is enabled for the Frame, but also if the storage type is
Local Storage and if there is an exception for the scheme of the resource currently loaded
into the Frame.
(WebCore::StorageAreaImpl::setItem):
Renamed privateBrowsingEnabled -> disabledByPrivateBrowsingInFrame.
(WebCore::StorageAreaImpl::removeItem):
Ditto.
(WebCore::StorageAreaImpl::clear):
Ditto.
* storage/StorageAreaImpl.h:

Source/WebKit/chromium:

* src/StorageAreaProxy.h:
(WebCore::StorageAreaProxy::disabledByPrivateBrowsingInFrame):
Chromium uses a different method to track its icognito mode, so always return false.

Source/WebKit/mac:

Add WebKit1 API to register a scheme as ignoring Private Browsing for Local Storage and
Databases.

* WebView/WebView.mm:
(+[WebView _registerURLSchemeAsAllowingLocalStorageAccessInPrivateBrowsing:]):
Call through to the SchemeRegistry function.
(+[WebView _registerURLSchemeAsAllowingDatabaseAccessInPrivateBrowsing:]):
Ditto.
* WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove initCloseEvent method
dominicc@chromium.org [Mon, 7 Nov 2011 18:04:51 +0000 (18:04 +0000)]
Remove initCloseEvent method
https://bugs.webkit.org/show_bug.cgi?id=71374

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/dom/Window/window-properties.html

* websockets/CloseEvent.h:
(WebCore::CloseEvent::initCloseEvent):
* websockets/CloseEvent.idl:

LayoutTests:

* fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/win/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSimplify NetscapePlugin::convertPoint and make it work (in theory) with transformed...
andersca@apple.com [Mon, 7 Nov 2011 18:00:24 +0000 (18:00 +0000)]
Simplify NetscapePlugin::convertPoint and make it work (in theory) with transformed plug-ins
https://bugs.webkit.org/show_bug.cgi?id=71699

Reviewed by Sam Weinig.

Source/WebCore:

Export AffineTransform symbols used by WebKit2.

* WebCore.exp.in:

Source/WebKit2:

Add a getScreenTransform function which given a coordinate space returns a transform that converts a
point from that coordinate space to the screen coordinate space. We then get the source -> screen transform
and the destination -> screen transform. We invert the destination -> screen transform, multiply it with the
source -> screen transform and use mapPoint to get a complete affine transform from the source to the destination space
and use mapPoint to map the source point and return the destination point.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::getScreenTransform):
(WebKit::NetscapePlugin::convertPoint):

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::initializePlugin):
Call windowAndViewFramesChanged before viewGeometryDidChange so that the window and view frames will be up to date by
the time NPP_SetWindow is called in the plug-in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTowards 8 Bit Strings: Templatize JSC::Lexer class by character type
msaboff@apple.com [Mon, 7 Nov 2011 17:54:15 +0000 (17:54 +0000)]
Towards 8 Bit Strings: Templatize JSC::Lexer class by character type
https://bugs.webkit.org/show_bug.cgi?id=71331

Source/JavaScriptCore:

Change the Lexer class to be a template class based on the character
type of the source.  In the process updated the parseIdentifier()
and parseString() methods to create 8 bit strings where possible.
Also added some helper methods for accumulating temporary string
data in the 8 and 16 bit vectors.

Changed the SourceProvider::data() virtual method to return a
StringImpl* instead of a UChar*.

Updated the KeywordLookup generator to create code to match keywords
for both 8 and 16 bit source strings.

Due to a compiler bug (<rdar://problem/10194295>) moved enum
definition outside of Lexer class declaration.  Remove second enum
no longer needed.

Reviewed by Darin Adler.

* KeywordLookupGenerator.py:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
* parser/Lexer.cpp:
(JSC::::Lexer):
(JSC::::~Lexer):
(JSC::::getInvalidCharMessage):
(JSC::::currentCharacter):
(JSC::::setCode):
(JSC::::internalShift):
(JSC::::shift):
(JSC::::peek):
(JSC::::getUnicodeCharacter):
(JSC::::shiftLineTerminator):
(JSC::::lastTokenWasRestrKeyword):
(JSC::::record8):
(JSC::::append8):
(JSC::::append16):
(JSC::::record16):
(JSC::::parseIdentifier):
(JSC::::parseIdentifierSlowCase):
(JSC::::parseString):
(JSC::::parseStringSlowCase):
(JSC::::parseHex):
(JSC::::parseOctal):
(JSC::::parseDecimal):
(JSC::::parseNumberAfterDecimalPoint):
(JSC::::parseNumberAfterExponentIndicator):
(JSC::::parseMultilineComment):
(JSC::::nextTokenIsColon):
(JSC::::lex):
(JSC::::scanRegExp):
(JSC::::skipRegExp):
(JSC::::clear):
(JSC::::sourceCode):
* parser/Lexer.h:
(JSC::Lexer::append16):
(JSC::Lexer::currentOffset):
(JSC::Lexer::setOffsetFromCharOffset):
(JSC::::isWhiteSpace):
(JSC::::isLineTerminator):
(JSC::::convertHex):
(JSC::::convertUnicode):
(JSC::::makeIdentifier):
(JSC::::setCodeStart):
(JSC::::makeIdentifierLCharFromUChar):
(JSC::::lexExpectIdentifier):
* parser/Parser.cpp:
(JSC::Parser::Parser):
(JSC::Parser::parseProperty):
(JSC::Parser::parseMemberExpression):
* parser/Parser.h:
(JSC::Parser::next):
(JSC::Parser::nextExpectIdentifier):
* parser/ParserArena.h:
(JSC::IdentifierArena::makeIdentifier):
(JSC::IdentifierArena::makeIdentifierLCharFromUChar):
* parser/SourceCode.h:
(JSC::SourceCode::subExpression):
* parser/SourceProvider.h:
(JSC::UStringSourceProvider::stringData):
* parser/SourceProviderCache.h:
* parser/SyntaxChecker.h:
* runtime/FunctionPrototype.cpp:
(JSC::insertSemicolonIfNeeded):
* runtime/Identifier.cpp:
(JSC::IdentifierTable::add):
(JSC::IdentifierLCharFromUCharTranslator::hash):
(JSC::IdentifierLCharFromUCharTranslator::equal):
(JSC::IdentifierLCharFromUCharTranslator::translate):
(JSC::Identifier::add8):
* runtime/Identifier.h:
(JSC::Identifier::Identifier):
(JSC::Identifier::createLCharFromUChar):
(JSC::Identifier::canUseSingleCharacterString):
(JSC::IdentifierCharBufferTranslator::hash):
(JSC::IdentifierCharBufferTranslator::equal):
(JSC::IdentifierCharBufferTranslator::translate):
(JSC::Identifier::add):
(JSC::Identifier::equal):
(JSC::IdentifierTable::add):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::decode):
(JSC::parseIntOverflow):
(JSC::globalFuncUnescape):
* runtime/JSGlobalObjectFunctions.h:
(JSC::parseIntOverflow):
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::tryJSONPParse):
(JSC::LiteralParser::Lexer::lexString):
* wtf/text/StringImpl.h:

Source/WebCore:

Changed the SourceProvider::data() virtual method to return a
StringImpl* instead of a UChar*.
Changed Identifier() constructor to use JSGlobalData*.

Reviewed by Darin Adler.

No new tests - refactored SourceProvider class and sub-classes.

* bindings/js/CachedScriptSourceProvider.h:
(WebCore::CachedScriptSourceProvider::stringData):
* bindings/js/StringSourceProvider.h:
(WebCore::StringSourceProvider::stringData):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertQVariantToValue):

Source/WebKit/qt:

Changed Identifier() constructor to use JSGlobalData*.

Reviewed by Darin Adler.

* Api/qwebframe.cpp:
(QWebFrame::addToJavaScriptWindowObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove initOverflowEvent from JavaScript bindings
dominicc@chromium.org [Mon, 7 Nov 2011 17:51:09 +0000 (17:51 +0000)]
Remove initOverflowEvent from JavaScript bindings
https://bugs.webkit.org/show_bug.cgi?id=71687

Reviewed by Ojan Vafai.

Source/WebCore:

Now that OverflowEvent has a constructor, we don't need the
initOverflowEvent method. It has to remain in the Objective C
binding because it is part of the Objective C public API.

* dom/OverflowEvent.idl:

LayoutTests:

OverflowEvent initialization is tested in
fast/events/constructors/overflow-event-constructor.html

* fast/events/init-events-expected.txt:
* fast/events/script-tests/init-events.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRefactor canvas encoding mimeType validation
noel.gordon@gmail.com [Mon, 7 Nov 2011 17:48:41 +0000 (17:48 +0000)]
Refactor canvas encoding mimeType validation
https://bugs.webkit.org/show_bug.cgi?id=71651

Reviewed by Andreas Kling.

No new tests, refactoring only, covered by existing canvas tests.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::toEncodingMimeType): move encoder mimeType
validation logic into a helper routine.
(WebCore::HTMLCanvasElement::toDataURL):
* html/HTMLCanvasElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] fast/frames/flattening/frameset-flattening-simple.html is flaky
philn@webkit.org [Mon, 7 Nov 2011 17:43:43 +0000 (17:43 +0000)]
[GTK] fast/frames/flattening/frameset-flattening-simple.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=71655

Reviewed by Martin Robinson.

* fast/frames/flattening/frameset-flattening-simple.html: Trigger
the test only after the embedded frame has been loaded.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Suggest box should consume enter key pressed event.
vsevik@chromium.org [Mon, 7 Nov 2011 17:36:23 +0000 (17:36 +0000)]
Web Inspector: Suggest box should consume enter key pressed event.
https://bugs.webkit.org/show_bug.cgi?id=71700

Reviewed by Pavel Feldman.

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove initPageTransitionEvent method
dominicc@chromium.org [Mon, 7 Nov 2011 17:16:18 +0000 (17:16 +0000)]
Remove initPageTransitionEvent method
https://bugs.webkit.org/show_bug.cgi?id=71689

Reviewed by Ojan Vafai.

initPageTransitionEvent was removed from the HTML spec; it has
been replaced by new PageTransitionEvent(...).

Removing a method, so no new tests.

* dom/PageTransitionEvent.cpp:
* dom/PageTransitionEvent.h:
* dom/PageTransitionEvent.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: TextPrompt+SuggestBox should autocomplete on "Right" keydown and with...
apavlov@chromium.org [Mon, 7 Nov 2011 17:15:36 +0000 (17:15 +0000)]
Web Inspector: TextPrompt+SuggestBox should autocomplete on "Right" keydown and with a single suggestion in place
https://bugs.webkit.org/show_bug.cgi?id=71676

Reviewed by Pavel Feldman.

* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.SuggestBox.prototype._updateItems):
* inspector/front-end/inspectorCommon.css:
(body): Revert inadvertent style change from a preceding commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the Qt build on Mac OS X when using the QuickTime media backend
vestbo@webkit.org [Mon, 7 Nov 2011 16:51:28 +0000 (16:51 +0000)]
Fix the Qt build on Mac OS X when using the QuickTime media backend

When QtWebKit is built on Mac OS X using the QuickTime media backend
we build both KURLCFNet.cpp and KURLMac, just like the Mac port, so
we have to guard the potentially duplicate symbol createCFURL with
more than just !PLATFORM(MAC).

Reviewed by Andreas Kling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Put the jsc binary in 'bin' instead of leaving it deep in the build tree
vestbo@webkit.org [Mon, 7 Nov 2011 16:51:15 +0000 (16:51 +0000)]
[Qt] Put the jsc binary in 'bin' instead of leaving it deep in the build tree

Allows us to not package up the whole Source/JavaScriptCore directory for the
buildbots.

Reviewed-by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-11-07 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Mon, 7 Nov 2011 16:48:35 +0000 (16:48 +0000)]
2011-11-07  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: follow up to r99407. Style the suggest box.
        https://bugs.webkit.org/show_bug.cgi?id=65511

        * inspector/front-end/TextPrompt.js:
        * inspector/front-end/inspector.css:
        * inspector/front-end/textPrompt.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=70223
rolandsteiner@chromium.org [Mon, 7 Nov 2011 16:31:51 +0000 (16:31 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=70223
CSSStyleSheet: finding the owner node should be in its own method

Add styleSheetOwnerNode() function that returns the owner Node of the style sheet, or 0.

Reviewed by Dimitri Glazkov.

No new tests. (refactoring)

* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::styleSheetOwnerNode):
(WebCore::CSSStyleSheet::document):
* css/CSSStyleSheet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Put handling of gestures and their interaction in one place
kenneth@webkit.org [Mon, 7 Nov 2011 16:24:50 +0000 (16:24 +0000)]
[Qt] Put handling of gestures and their interaction in one place
https://bugs.webkit.org/show_bug.cgi?id=71682

Reviewed by Simon Hausmann.

Before this patch, the interaction (ie. cancelling animations, events)
was handled in the respective recognizers which then knew about each
others.

* UIProcess/qt/QtGestureRecognizer.h:
(WebKit::QtGestureRecognizer::isRecognized):
* UIProcess/qt/QtPanGestureRecognizer.cpp:
(WebKit::QtPanGestureRecognizer::recognize):
* UIProcess/qt/QtPanGestureRecognizer.h:
* UIProcess/qt/QtPinchGestureRecognizer.cpp:
(WebKit::QtPinchGestureRecognizer::recognize):
* UIProcess/qt/QtPinchGestureRecognizer.h:
* UIProcess/qt/QtTouchWebPageProxy.cpp:
(QtTouchWebPageProxy::QtTouchWebPageProxy):
(QtTouchWebPageProxy::doneWithTouchEvent):
* UIProcess/qt/QtTouchWebPageProxy.h:
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::scrollAnimationActive):
(WebKit::QtViewportInteractionEngine::interruptScrollAnimation):
(WebKit::QtViewportInteractionEngine::panGestureActive):
(WebKit::QtViewportInteractionEngine::scaleAnimationActive):
(WebKit::QtViewportInteractionEngine::interruptScaleAnimation):
(WebKit::QtViewportInteractionEngine::pinchGestureActive):
* UIProcess/qt/QtViewportInteractionEngine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Make it possible to include qdesktopwebview.h from apps
hausmann@webkit.org [Mon, 7 Nov 2011 15:58:00 +0000 (15:58 +0000)]
[Qt] Make it possible to include qdesktopwebview.h from apps

Reviewed by Tor Arne Vestbø.

* UIProcess/API/qt/qdesktopwebview.h: Don't include C API headers, forward
declare the structs manually.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] More gardening. Skip keygen related tests.
hausmann@webkit.org [Mon, 7 Nov 2011 15:43:21 +0000 (15:43 +0000)]
[Qt] More gardening. Skip keygen related tests.

Rubber-stamped by Ossy.

* platform/qt/Skipped: We don't support <keygen>, so group
the keygen failures and add a comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Gardening, unskip tests that appear to pass now.
hausmann@webkit.org [Mon, 7 Nov 2011 15:22:41 +0000 (15:22 +0000)]
[Qt] Gardening, unskip tests that appear to pass now.

Rubber-stamped by Ossy.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Ensure we always export symbols for the QtWebKit API when building WebKit
vestbo@webkit.org [Mon, 7 Nov 2011 14:43:17 +0000 (14:43 +0000)]
[Qt] Ensure we always export symbols for the QtWebKit API when building WebKit

Reviewed-by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Sanitize qmake paths correctly before comparing
vestbo@webkit.org [Mon, 7 Nov 2011 14:43:01 +0000 (14:43 +0000)]
[Qt] Sanitize qmake paths correctly before comparing

The qmake function toSanitizedPath had a bug causing empty paths on MinGW,
which caused us to always generate derived webcore sources, but never build
them. The bug has been fixed, and we now also sanitize paths for the injected
bundle derived sources.

Reviewed-by Simon Husmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Print right order for changing feature defines
vestbo@webkit.org [Mon, 7 Nov 2011 14:42:42 +0000 (14:42 +0000)]
[Qt] Print right order for changing feature defines

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix failing inspector tests after build system changes https://bugs.webkit.org...
hausmann@webkit.org [Mon, 7 Nov 2011 14:32:57 +0000 (14:32 +0000)]
[Qt] Fix failing inspector tests after build system changes https://bugs.webkit.org/show_bug.cgi?id=71677

Reviewed by Tor Arne Vestbø.

Source/WebKit/qt:

Ensure symbols from the qt resource system are referenced
from outside the static webcore library. One way of doing that is
to initialize the resources right away, as explained in the documentation
of th Qt resource system.

* Api/qwebpage.cpp:
(initResources):
(QWebPagePrivate::QWebPagePrivate):

Source/WebKit2:

Ensure symbols from the qt resource system are referenced
from outside the static webcore library. One way of doing that is
to initialize the resources right away, as explained in the documentation
of th Qt resource system.

* WebProcess/WebPage/qt/WebPageQt.cpp:
(initResources):
(WebKit::WebPage::platformInitialize):

LayoutTests:

* platform/qt/Skipped: Unskip previously failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Web Inspector: use native worker inspector instead of fake workers
yurys@chromium.org [Mon, 7 Nov 2011 14:30:41 +0000 (14:30 +0000)]
[Chromium] Web Inspector: use native worker inspector instead of fake workers
https://bugs.webkit.org/show_bug.cgi?id=71670

Source/WebCore:

Removed context menu option for switching between native and "fake" workers
debugger. Native debugger is used by default on platforms that support it.

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
* inspector/front-end/WorkersSidebarPane.js:
(WebInspector.WorkerListSidebarPane):
(WebInspector.WorkerListSidebarPane.prototype._autoattachToWorkersClicked):
* inspector/front-end/scriptsPanel.css:
(#shared-workers-list):

Source/WebKit/chromium:

chrome://workers link is replaced with instructions on discovering shared workers
in Task Manager.

Reviewed by Pavel Feldman.

* src/js/DevTools.js:
():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Add advanced search shortcut to ShortcutsScreen.
vsevik@chromium.org [Mon, 7 Nov 2011 14:20:23 +0000 (14:20 +0000)]
Web Inspector: Add advanced search shortcut to ShortcutsScreen.
https://bugs.webkit.org/show_bug.cgi?id=71302

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* inspector/front-end/AdvancedSearchController.js:
(WebInspector.AdvancedSearchController.createShortcut):
* inspector/front-end/inspector.js:
(WebInspector._registerShortcuts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCSSImageValue: Remove inheritance from CachedImageClient.
andreas.kling@nokia.com [Mon, 7 Nov 2011 14:10:56 +0000 (14:10 +0000)]
CSSImageValue: Remove inheritance from CachedImageClient.
<http://webkit.org/b/71675>

Reviewed by Antti Koivisto.

CSSImageValue doesn't actually use any of the CachedImageClient
functionality, and holds a reference to the resource via the
CachedResourceHandle in StyleCachedImage.

So we can safely remove the multiple inheritance and simplify
the class.

* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::~CSSImageValue):
(WebCore::CSSImageValue::cachedImage):
(WebCore::CSSImageValue::clearCachedImage):
* css/CSSImageValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Mon, 7 Nov 2011 14:09:57 +0000 (14:09 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-07

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Skip a new failing test on Qt
ossy@webkit.org [Mon, 7 Nov 2011 14:04:34 +0000 (14:04 +0000)]
[Qt] Skip a new failing test on Qt
https://bugs.webkit.org/show_bug.cgi?id=70893

Patch by Ben Wells <benwells@chromium.org> on 2011-11-07
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCSSPrimitiveValue: Remove unused virtual function parseString().
andreas.kling@nokia.com [Mon, 7 Nov 2011 13:46:37 +0000 (13:46 +0000)]
CSSPrimitiveValue: Remove unused virtual function parseString().
<http://webkit.org/b/71671>

Reviewed by Antti Koivisto.

* css/CSSPrimitiveValue.cpp:
* css/CSSPrimitiveValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: use toString as the Date object description.
caseq@chromium.org [Mon, 7 Nov 2011 13:43:17 +0000 (13:43 +0000)]
Web Inspector: use toString as the Date object description.
https://bugs.webkit.org/show_bug.cgi?id=71605

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/remote-object.html

* inspector/InjectedScriptSource.js:
(.):

LayoutTests:

* inspector/remote-object-expected.txt: Added.
* inspector/remote-object.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: [refactoring] get JS-specific methods out of SourceFrame
caseq@chromium.org [Mon, 7 Nov 2011 13:40:40 +0000 (13:40 +0000)]
Web Inspector: [refactoring] get JS-specific methods out of SourceFrame
https://bugs.webkit.org/show_bug.cgi?id=70885

Reviewed by Pavel Feldman.

No new tests, as there's no new functionality.

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.willHide):
(WebInspector.JavaScriptSourceFrame.prototype.requestContent):
(WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
(WebInspector.JavaScriptSourceFrame.prototype.suggestedFileName):
(WebInspector.JavaScriptSourceFrame.prototype.editContent):
(WebInspector.JavaScriptSourceFrame.prototype.contentChanged):
(WebInspector.JavaScriptSourceFrame.prototype.setReadonly):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.else):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.cancelEditing):
(WebInspector.JavaScriptSourceFrame.prototype.didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._getPopoverAnchor):
(WebInspector.JavaScriptSourceFrame.prototype._onShowPopover.showObjectPopover):
(WebInspector.JavaScriptSourceFrame.prototype._onShowPopover):
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):
(WebInspector.JavaScriptSourceFrame.prototype.addBreakpoint):
(WebInspector.JavaScriptSourceFrame.prototype.removeBreakpoint):
(WebInspector.JavaScriptSourceFrame.prototype._mouseDown):
(WebInspector.JavaScriptSourceFrame.prototype._editBreakpointCondition.finishEditing):
(WebInspector.JavaScriptSourceFrame.prototype._editBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype._createConditionElement):
(WebInspector.JavaScriptSourceFrame.prototype.setExecutionLine):
(WebInspector.JavaScriptSourceFrame.prototype.clearExecutionLine):
(WebInspector.JavaScriptSourceFrame.prototype._lineNumberAfterEditing):
(WebInspector.JavaScriptSourceFrame.prototype._onTextViewerContentLoaded):
(WebInspector.JavaScriptSourceFrameDelegate):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.requestContent):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.setBreakpoint):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.removeBreakpoint):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.updateBreakpoint):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.findBreakpoint):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.continueToLine):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.canEditScriptSource):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.setScriptSource):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.setScriptSourceIsBeingEdited):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.suggestedFileName):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.addToWatch):
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceSourceFrame):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.SourceFrameDelegateForScriptsPanel):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.willHide):
(WebInspector.SourceFrame.prototype.get textViewer):
(WebInspector.SourceFrame.prototype.requestContent):
(WebInspector.SourceFrame.prototype._saveViewerState):
(WebInspector.SourceFrame.prototype._restoreViewerState):
(WebInspector.SourceFrame.prototype.beforeTextChanged):
(WebInspector.SourceFrame.prototype.afterTextChanged):
(WebInspector.SourceFrame.prototype._initializeTextViewer):
(WebInspector.SourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.SourceFrame.prototype.suggestedFileName):
(WebInspector.SourceFrame.prototype.canEditSource):
(WebInspector.SourceFrame.prototype.startEditing):
(WebInspector.SourceFrame.prototype.commitEditing):
(WebInspector.SourceFrame.prototype.didEditContent):
(WebInspector.SourceFrame.prototype.editContent):
(WebInspector.SourceFrame.prototype.cancelEditing):
(WebInspector.SourceFrame.prototype.setReadOnly):
* inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCSSValue: Devirtualize cssValueType().
andreas.kling@nokia.com [Mon, 7 Nov 2011 13:31:31 +0000 (13:31 +0000)]
CSSValue: Devirtualize cssValueType().
<http://webkit.org/b/71667>

Reviewed by Antti Koivisto.

Keep the cssValueType in a CSSValue member instead of using
virtual functions.

This is part of a project to completely devirtualize CSSValue
<http://webkit.org/b/71666> and will incur a temporary object
size regression for CSSValue while the work is ongoing.

* css/CSSInheritedValue.cpp:
* css/CSSInheritedValue.h:
(WebCore::CSSInheritedValue::CSSInheritedValue):
* css/CSSInitialValue.cpp:
* css/CSSInitialValue.h:
(WebCore::CSSInitialValue::CSSInitialValue):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSPrimitiveValue.h:
* css/CSSValue.h:
(WebCore::CSSValue::cssValueType):
(WebCore::CSSValue::CSSValue):
* css/CSSValueList.cpp:
(WebCore::CSSValueList::CSSValueList):
* css/CSSValueList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: introduce UserAgent override setting.
pfeldman@chromium.org [Mon, 7 Nov 2011 13:22:09 +0000 (13:22 +0000)]
Web Inspector: introduce UserAgent override setting.
https://bugs.webkit.org/show_bug.cgi?id=71627

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-11-07
Reviewed by Yury Semikhatsky.

* English.lproj/localizedStrings.js:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::clearFrontend):
(WebCore::InspectorResourceAgent::applyUserAgentOverride):
(WebCore::InspectorResourceAgent::setUserAgentOverride):
* inspector/front-end/HelpScreen.js:
(WebInspector.HelpScreen):
(WebInspector.HelpScreen.prototype.show):
(WebInspector.HelpScreen.prototype._onBlur):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype._cacheDisabledSettingChanged):
(WebInspector.NetworkManager.prototype._userAgentSettingChanged):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):
(WebInspector.SettingsScreen.prototype._createSelectSetting.get for):
(WebInspector.SettingsScreen.prototype._createCustomSetting):
(WebInspector.SettingsScreen.prototype._createUserActionControl.checkboxClicked):
(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):
(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.textDoubleClicked):
(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.textChanged):
* inspector/front-end/helpScreen.css:
(.help-table td):
(.help-content fieldset label):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: autocomplete combobox for Styles sidebar and Console.
apavlov@chromium.org [Mon, 7 Nov 2011 12:50:02 +0000 (12:50 +0000)]
Web Inspector: autocomplete combobox for Styles sidebar and Console.
https://bugs.webkit.org/show_bug.cgi?id=65511

Reviewed by Pavel Feldman.

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):
():
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt):
(WebInspector.TextPrompt.prototype.setSuggestBoxEnabled):
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype.applySuggestion):
(WebInspector.TextPrompt.prototype.acceptSuggestion):
(WebInspector.TextPromptWithHistory):
* inspector/front-end/inspector.css:
(.suggest-box.generic-suggest):
(.suggest-box.generic-suggest.above-anchor):
(.suggest-box.generic-suggest .content):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, GTK flaky tests clean-up. Moved most of them to
philn@webkit.org [Mon, 7 Nov 2011 12:44:33 +0000 (12:44 +0000)]
Unreviewed, GTK flaky tests clean-up. Moved most of them to
test_expectations.

* platform/gtk/Skipped:
* platform/gtk/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt:
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: split script-formatter test into multiple tests.
pfeldman@chromium.org [Mon, 7 Nov 2011 12:19:57 +0000 (12:19 +0000)]
Web Inspector: split script-formatter test into multiple tests.
https://bugs.webkit.org/show_bug.cgi?id=71607

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-11-07
Reviewed by Yury Semikhatsky.

Source/WebCore:

Tests: inspector/debugger/script-formatter-breakpoints.html
       inspector/debugger/script-formatter-console.html

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._removeSourceFrame):

LayoutTests:

* inspector/debugger/script-formatter-breakpoints-expected.txt: Added.
* inspector/debugger/script-formatter-breakpoints.html: Added.
* inspector/debugger/script-formatter-console-expected.txt: Added.
* inspector/debugger/script-formatter-console.html: Added.
* inspector/debugger/script-formatter-expected.txt:
* inspector/debugger/script-formatter.html:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, fast/dom/gc-11.html is now passing on GTK, it seems.
philn@webkit.org [Mon, 7 Nov 2011 11:46:23 +0000 (11:46 +0000)]
Unreviewed, fast/dom/gc-11.html is now passing on GTK, it seems.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChange ColorChooser from singleton to ordinary object
keishi@webkit.org [Mon, 7 Nov 2011 11:39:32 +0000 (11:39 +0000)]
Change ColorChooser from singleton to ordinary object
https://bugs.webkit.org/show_bug.cgi?id=71644

Reviewed by Kent Tamura.

Source/WebCore:

Changing WebCore::ColorChooser from a singleton to an ordinary object can broaden how browsers implement the color chooser interface.

* WebCore.exp.in:
* html/ColorInputType.cpp:
(WebCore::ColorInputType::~ColorInputType):
(WebCore::ColorInputType::setValue): If a chooser exists, calls Chrome::setSelectedColorInColorChooser
(WebCore::ColorInputType::handleDOMActivateEvent):
(WebCore::ColorInputType::detach):
(WebCore::ColorInputType::didCleanup): Called after cleanup is complete.
(WebCore::ColorInputType::cleanupColorChooser): Renamed from cleanupColorChooserIfCurrentClient.
* html/ColorInputType.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::selectColorInColorChooser):
* html/HTMLInputElement.h:
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::cleanupColorChooser): Added colorChooser argument because there are many WebCore::ColorChoosers now.
(WebCore::EmptyChromeClient::setSelectedColorInColorChooser): Ditto.
* page/Chrome.cpp:
(WebCore::Chrome::cleanupColorChooser): Added colorChooser argument because there are many WebCore::ColorChoosers now.
(WebCore::Chrome::setSelectedColorInColorChooser): Ditto.
* page/Chrome.h:
* page/ChromeClient.h:
* platform/ColorChooser.cpp:
(WebCore::ColorChooserClient::~ColorChooserClient):
(WebCore::ColorChooserClient::newColorChooser): Creates a new color chooser that is connected to itself.
(WebCore::ColorChooserClient::discardChooser): Discards the connected color chooser.
(WebCore::ColorChooser::ColorChooser): ColorChooser is RefCounted.
(WebCore::ColorChooser::create): Creates a ColorChooser that is connected to the given ColorChooserClient.
(WebCore::ColorChooser::~ColorChooser):
(WebCore::ColorChooser::didChooseColor): Called from WebKit side when user chose a color. Calls ColorChooserClient::didChooseColor
(WebCore::ColorChooser::didCleanup): Called from WebKit side when user color chooser was cleaned up. Calls ColorChooserClient::didCleanup
* platform/ColorChooser.h:
(WebCore::ColorChooserClient::chooser): Returns the current ColorChooser.
(WebCore::ColorChooser::disconnectClient): Disconnects the ColorChooserClient.
* testing/Internals.cpp:
(WebCore::Internals::selectColorInColorChooser): Added element argument. This calls didChooseColor on the ColorChooser of that element.
* testing/Internals.h:
* testing/Internals.idl: Removed connectColorChooserClient and updated selectColorInColorChooser.

LayoutTests:

* fast/forms/color/input-color-onchange-event.html: Changed to match the changes to window.internals object

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Cannot edit elements commented with <!--
yutak@chromium.org [Mon, 7 Nov 2011 10:51:30 +0000 (10:51 +0000)]
Web Inspector: Cannot edit elements commented with <!--
https://bugs.webkit.org/show_bug.cgi?id=71357

Patch by Alexander Pavlov <apavlov@chromium.org> on 2011-11-07
Reviewed by Pavel Feldman.

* inspector/elements/edit-dom-actions-expected.txt:
* inspector/elements/edit-dom-actions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99402 268f45cc-cd09-0410-ab3c-d52691b4dbfc