fsamuel@chromium.org [Tue, 23 Aug 2011 19:21:05 +0000 (19:21 +0000)]
New MainFrame views should inherit fixed layout settings from existing MainFrame view in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=66780
Fixed layout mode is set from WebViewImpl, but new main FrameViews are created on loading new pages. The new page's FrameView should get its
fixed layout settings from the current page.
Reviewed by Darin Fisher.
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFrameView):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93622
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Aug 2011 19:07:59 +0000 (19:07 +0000)]
Unreviewed, rolling out r93616.
http://trac.webkit.org/changeset/93616
https://bugs.webkit.org/show_bug.cgi?id=66796
"causes fast/css/absolute-child-with-percent-height-inside-
relative-parent.html to fail" (Requested by mwenge2 on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-23
Source/WebCore:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustPositionedBlock):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::setStaticPositions):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
LayoutTests:
* fast/inline/absolute-positioned-block-in-centred-block-expected.png: Removed.
* fast/inline/absolute-positioned-block-in-centred-block-expected.txt: Removed.
* fast/inline/absolute-positioned-block-in-centred-block.html: Removed.
* fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Removed.
* fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Removed.
* fast/inline/absolute-positioned-inline-in-centred-block.html: Removed.
* platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
* platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93621
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Tue, 23 Aug 2011 18:46:33 +0000 (18:46 +0000)]
[Qt][WK2] Fix an awful memory leak introduced in r92376.
https://bugs.webkit.org/show_bug.cgi?id=65528
Reviewed by Benjamin Poulain.
The non-virtual destructor would create a leak of the tile update buffer because
the NodeUpdateSetTexture's QImage member destructor wouldn't be called.
* UIProcess/qt/SGAgent.h:
(WebKit::NodeUpdate::~NodeUpdate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93620
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Aug 2011 18:30:33 +0000 (18:30 +0000)]
[chromium] Update WebSettings to support per-script font settings
https://bugs.webkit.org/show_bug.cgi?id=66220
Patch by Matt Falkenhagen <falken@chromium.org> on 2011-08-23
Reviewed by Tony Chang.
* WebKit.gyp:
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setStandardFontFamily):
(WebKit::WebSettingsImpl::setFixedFontFamily):
(WebKit::WebSettingsImpl::setSerifFontFamily):
(WebKit::WebSettingsImpl::setSansSerifFontFamily):
(WebKit::WebSettingsImpl::setCursiveFontFamily):
(WebKit::WebSettingsImpl::setFantasyFontFamily):
* src/WebSettingsImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93618
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Aug 2011 18:27:51 +0000 (18:27 +0000)]
[EFL] Do not treat valid cases in ewk_frame_child_add() as failures.
https://bugs.webkit.org/show_bug.cgi?id=66692
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-23
Rubber-stamped by Kenneth Rohde Christiansen.
Frame::page() and FrameTree::parent() returning 0 were being considered
failure cases, however it is possible for them to return 0 when some
arbitrary JavaScript is run.
The function's return type has been changed to make it easier to convey
these cases to the caller (which is only ewk_view_frame_create).
This should make tests like
fast/dom/null-page-show-modal-dialog-crash.html stop outputting
erroneous messages to stderr.
* ewk/ewk_frame.cpp:
(ewk_frame_child_add):
* ewk/ewk_private.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93617
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Tue, 23 Aug 2011 18:11:44 +0000 (18:11 +0000)]
div align="center" rendering problem
https://bugs.webkit.org/show_bug.cgi?id=4860
Reviewed by David Hyatt.
Source/WebCore:
Tests: fast/inline/absolute-positioned-block-in-centred-block.html
fast/inline/absolute-positioned-inline-in-centred-block.html
When an element with absolute position was the sole or first child of a render block with
centred alignment, it wasn't obeying its parent's alignment. However it would obey the
alignment if it was preceded by some text. The problem was that the element's render object
was getting skipped as leading white space, so it was not included in a normal line block in
a bidi run. Instead, its position was getting set by RenderBlockLineLayout::setStaticPositions()
which does not pay attention to alignment. Preceding the element with some text allowed the object
to get included in a Bidi run and so get a linebox which would get properly aligned.
The fix is to get RenderBlockLineLayout::setStaticPositions() to obey the alignment specified by
the object's container. This allows WebKit to get the same result on the test as Firefox and IE.
Opera has the same bug as unpatched WebKit.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustPositionedBlock): use startAlignedOffsetForBlock
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::updateLogicalWidthForAlignment):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Move the alignment check to updateLogicalWidthForAlignment.
(WebCore::setStaticPositions): use startAlignedOffsetForLine and use startAlignedOffsetForBlock
(WebCore::RenderBlock::LineBreaker::nextLineBreak): use startAlignedOffsetForLine
(WebCore::RenderBlock::startAlignedOffsetForBlock): New function, find the aligned offset using updateLogicalWidthForAlignment
(WebCore::RenderBlock::startAlignedOffsetForLine): ditto
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::updateLogicalWidthForAlignment):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Move the alignment check to updateLogicalWidthForAlignment.
(WebCore::setStaticPositions): use startAlignedOffsetForLine.
(WebCore::RenderBlock::startAlignedOffsetForLine): New function, find the aligned offset using updateLogicalWidthForAlignment
LayoutTests:
* fast/inline/absolute-positioned-block-in-centred-block-expected.png: Added.
* fast/inline/absolute-positioned-block-in-centred-block-expected.txt: Added.
* fast/inline/absolute-positioned-block-in-centred-block.html: Added.
* fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
* fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
* fast/inline/absolute-positioned-inline-in-centred-block.html: Added.
* platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
* platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
Both of these two tests were based on the incorrect behaviour of ignoring the alignment specified
by the container of an element absolute position when there was no text preceding the element.
The updated results agree with Firefox and IE.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93616
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Tue, 23 Aug 2011 18:08:46 +0000 (18:08 +0000)]
[chromium] Remove LayerRendererChromium references from TiledLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=66433
Reviewed by James Robinson.
Covered by existing tests.
Updated TiledLayerChromium and the texture updater classes to not
access LayerRendererChromium or cache GraphicsContext3D. Some settings
like max texture size were moved from LayerRendererChromium to
CCLayerTreeHost in order to facilitate this refactoring.
LayerTextureUpdaterSkPicture has been #ifdef'd to only work when the
compositor is not threaded. It will need to be refactored more in
order to not own graphics resources from the main thread.
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::createTextureUpdater):
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::create):
(WebCore::ImageLayerTextureUpdater::updateTextureRect):
(WebCore::ImageLayerTextureUpdater::ImageLayerTextureUpdater):
(WebCore::ImageLayerChromium::paintContentsIfDirty):
(WebCore::ImageLayerChromium::createTextureUpdater):
* platform/graphics/chromium/ImageLayerChromium.h:
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setLayerRenderer):
(WebCore::LayerChromium::setLayerTreeHost):
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/LayerTextureUpdater.h:
(WebCore::LayerTextureUpdater::LayerTextureUpdater):
* platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
(WebCore::LayerTextureUpdaterCanvas::LayerTextureUpdaterCanvas):
(WebCore::LayerTextureUpdaterBitmap::create):
(WebCore::LayerTextureUpdaterBitmap::LayerTextureUpdaterBitmap):
(WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::create):
(WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
* platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
(WebCore::LayerTextureUpdaterSkPicture::context):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::invalidateRect):
(WebCore::TiledLayerChromium::prepareToUpdate):
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::layerRenderer):
(WebCore::CCLayerTreeHost::contextSupportsMapSub):
(WebCore::CCLayerTreeHost::maxTextureSize):
(WebCore::CCLayerTreeHost::bestTextureFormat):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Tue, 23 Aug 2011 18:02:43 +0000 (18:02 +0000)]
Reduce the amount of RenderLayer rectangles' update when scrolling
https://bugs.webkit.org/show_bug.cgi?id=66618
Reviewed by David Hyatt.
Source/WebCore:
This patch avoids recomputing the RenderLayers rectangles if not needed.
The current code path for scrolling would update RenderLayers' repaint rectangles
twice. However we do need to update only children of a fixed element as they are
the only type of layers that move during a scroll.
We just change a call to updateLayerPositions for a call to updateLayerPositionsAfterScroll.
updateLayerPositions being pessimist about the layer's state - because it is called after layout -
it is missing some optimization that can be done during scrolling.
Tests: fast/repaint/scroll-absolute-layer-with-reflection.html
fast/repaint/scroll-fixed-layer-with-reflection.html
fast/repaint/scroll-fixed-layer-with-transformed-parent-layer.html
fast/repaint/scroll-fixed-reflected-layer.html
fast/repaint/scroll-in-clipped-layer.html
fast/repaint/scroll-in-fixed-layer.html
fast/repaint/scroll-in-transformed-layer.html
fast/repaint/scroll-with-transformed-parent-layer.html
* rendering/RenderLayer.h:
* page/FrameView.cpp:
(WebCore::FrameView::repaintFixedElementsAfterScrolling):
Updated those 2 call sites after updateRepaintRectsAfterScroll renaming.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositionsAfterScroll): Beefed up the method
to take care of also updating the layer's position (that sounded like a bug in
the previous code that is covered by the tests above). Note that we don't care
if one of our ancestor has a fixed position as we are scrolling *inside* this
ancestor.
(WebCore::RenderLayer::scrollTo): Call updateLayerPositionsAfterScroll instead of
updateLayerPositions.
LayoutTests:
* fast/repaint/resources/default.css:
Added more shortcuts.
* fast/repaint/scroll-absolute-layer-with-reflection-expected.txt: Added.
* fast/repaint/scroll-absolute-layer-with-reflection.html: Added.
* fast/repaint/scroll-fixed-layer-with-reflection-expected.txt: Added.
* fast/repaint/scroll-fixed-layer-with-reflection.html: Added.
* fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.txt: Added.
* fast/repaint/scroll-fixed-layer-with-transformed-parent-layer.html: Added.
* fast/repaint/scroll-fixed-reflected-layer-expected.txt: Added.
* fast/repaint/scroll-fixed-reflected-layer.html: Added.
* fast/repaint/scroll-in-clipped-layer-expected.txt: Added.
* fast/repaint/scroll-in-clipped-layer.html: Added.
* fast/repaint/scroll-in-fixed-layer-expected.txt: Added.
* fast/repaint/scroll-in-fixed-layer.html: Added.
* fast/repaint/scroll-in-transformed-layer-expected.txt: Added.
* fast/repaint/scroll-in-transformed-layer.html: Added.
* fast/repaint/scroll-with-transformed-parent-layer-expected.txt: Added.
* fast/repaint/scroll-with-transformed-parent-layer.html: Added.
Those are a variation on the same theme: scrolling inside a layers (sometimes the layer is itself scrolled)
to show that we are still doing the right thing.
* platform/chromium-cg-mac/scroll-absolute-layer-with-reflection-expected.png: Added.
* platform/chromium-cg-mac/scroll-fixed-layer-with-reflection-expected.png: Added.
* platform/chromium-cg-mac/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Added.
* platform/chromium-cg-mac/scroll-fixed-reflected-layer-expected.png: Added.
* platform/chromium-cg-mac/scroll-in-clipped-layer-expected.png: Added.
* platform/chromium-cg-mac/scroll-in-fixed-layer-expected.png: Added.
* platform/chromium-cg-mac/scroll-in-transformed-layer-expected.png: Added.
* platform/chromium-cg-mac/scroll-with-transformed-parent-layer-expected.png: Added.
* platform/chromium-win/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Added.
* platform/chromium-win/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Added.
* platform/chromium-win/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Added.
* platform/chromium-win/fast/repaint/scroll-fixed-reflected-layer-expected.png: Added.
* platform/chromium-win/fast/repaint/scroll-in-clipped-layer-expected.png: Added.
* platform/chromium-win/fast/repaint/scroll-in-fixed-layer-expected.png: Added.
* platform/chromium-win/fast/repaint/scroll-in-transformed-layer-expected.png: Added.
* platform/chromium-win/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Added.
* platform/mac/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Added.
* platform/mac/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Added.
* platform/mac/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Added.
* platform/mac/fast/repaint/scroll-fixed-reflected-layer-expected.png: Added.
* platform/mac/fast/repaint/scroll-in-clipped-layer-expected.png: Added.
* platform/mac/fast/repaint/scroll-in-fixed-layer-expected.png: Added.
* platform/mac/fast/repaint/scroll-in-transformed-layer-expected.png: Added.
* platform/mac/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Added.
Baseline for Chromium and Mac.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93614
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jpfau@apple.com [Tue, 23 Aug 2011 17:47:55 +0000 (17:47 +0000)]
New XML parser: pretty XML tree viewer
https://bugs.webkit.org/show_bug.cgi?id=66489
Reviewed by Adam Barth.
* xml/parser/NewXMLDocumentParser.cpp:
(WebCore::NewXMLDocumentParser::finish):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93613
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Tue, 23 Aug 2011 17:41:19 +0000 (17:41 +0000)]
2011-08-23 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Disabled inspector/extensions/extensions-resources.html.
https://bugs.webkit.org/show_bug.cgi?id=66786
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93612
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leandro@webkit.org [Tue, 23 Aug 2011 17:08:21 +0000 (17:08 +0000)]
Unreviewed build fix after r66685.
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):
Assert using the right variable name.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93611
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Tue, 23 Aug 2011 16:31:32 +0000 (16:31 +0000)]
2011-08-23 Andrey Kosyakov <caseq@chromium.org>
Unreviewed test fix following r93605.
* http/tests/inspector/resources/extension-main.js:
(trimURL):
* inspector/extensions/extensions-resources-expected.txt:
* inspector/extensions/extensions-resources.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93610
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
nduca@chromium.org [Tue, 23 Aug 2011 16:25:36 +0000 (16:25 +0000)]
Unreviewd, roll chromium reverse DEPS 97698:97834
https://bugs.webkit.org/show_bug.cgi?id=66781
* DEPS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93609
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Tue, 23 Aug 2011 16:20:06 +0000 (16:20 +0000)]
Build fix.
* inspector/InspectorDOMAgent.h:
HighlightData is a struct, not a class.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93608
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 23 Aug 2011 16:02:41 +0000 (16:02 +0000)]
garden-o-matic summary should be able to examine failures
https://bugs.webkit.org/show_bug.cgi?id=66748
Reviewed by Dimitri Glazkov.
This patch refactors a bunch of code from summary.js to independent
controllers in controllers.js. This patch also contains the first
iteration of binding the "examine" event to a the behavior showing the
details view for the tests. There's more work to do here to make this
work properly (and elegantly), but this patch is a start.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93607
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Aug 2011 15:48:55 +0000 (15:48 +0000)]
[EFL] Treat the case of WebCore::History->currentItem() returning NULL.
https://bugs.webkit.org/show_bug.cgi?id=66698
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-23
Reviewed by Kenneth Rohde Christiansen.
WebCore::History->currentItem() may return NULL, and we'd better treat
it in ewk_history_history_item_current_get itself than propagate the
issue to _ewk_history_item_new.
* ewk/ewk_history.cpp:
(ewk_history_history_item_current_get):
* ewk/ewk_history.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93606
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Tue, 23 Aug 2011 15:35:58 +0000 (15:35 +0000)]
Web Inspector: [Extensions API] provide access to page resources
https://bugs.webkit.org/show_bug.cgi?id=66767
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/extensions/extensions-resources.html
* inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI.EventSinkImpl.prototype.addListener):
(WebInspector.injectedExtensionAPI):
(WebInspector.injectedExtensionAPI.RequestImpl.prototype.getContent):
(WebInspector.injectedExtensionAPI.InspectedWindow.resourceDispatch):
(WebInspector.injectedExtensionAPI.InspectedWindow.resourceContentDispatch):
(WebInspector.injectedExtensionAPI.InspectedWindow):
(WebInspector.injectedExtensionAPI.InspectedWindow.prototype.eval):
(WebInspector.injectedExtensionAPI.InspectedWindow.prototype.getResources):
(WebInspector.injectedExtensionAPI.InspectedWindow.prototype.getResources.callbackWrapper):
(WebInspector.injectedExtensionAPI.ResourceImpl.prototype.get url):
(WebInspector.injectedExtensionAPI.ResourceImpl.prototype.get type):
(WebInspector.injectedExtensionAPI.ResourceImpl.prototype.getContent):
(WebInspector.injectedExtensionAPI.ResourceImpl.prototype.setContent):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._notifyResourceAdded):
(WebInspector.ExtensionServer.prototype.notifyResourceContentCommitted):
(WebInspector.ExtensionServer.prototype._makeResource):
(WebInspector.ExtensionServer.prototype._onGetPageResources):
(WebInspector.ExtensionServer.prototype._getResourceContent):
(WebInspector.ExtensionServer.prototype._onGetRequestContent):
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
(WebInspector.ExtensionServer.prototype._onSetResourceContent):
(WebInspector.ExtensionServer.prototype.initExtensions):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.addRevision):
LayoutTests:
* http/tests/inspector/resources/extension-main.js:
(trimURL):
* inspector/extensions/extensions-api-expected.txt:
* inspector/extensions/extensions-network-expected.txt:
* inspector/extensions/extensions-network.html:
* inspector/extensions/extensions-resources-expected.txt: Added.
* inspector/extensions/extensions-resources.html: Added.
* inspector/extensions/resources/Ahem.ttf:
* inspector/extensions/resources/test-script.js: Added.
(__test_function):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93605
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 23 Aug 2011 15:08:14 +0000 (15:08 +0000)]
2011-08-23 Pavel Feldman <pfeldman@google.com>
Not reviewed: fixing build. One line drive-by typo fix in the inspector shortcut (Esc -> Backspace).
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::highlightFrame):
* inspector/front-end/treeoutline.js:
(TreeOutline.prototype._treeKeyDown):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93604
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Tue, 23 Aug 2011 14:38:07 +0000 (14:38 +0000)]
Web Inspector: differentiate element highlight colors for margin and padding
https://bugs.webkit.org/show_bug.cgi?id=37768
The highlighting WIP API is slightly changed: clients will specify colors for certain elements of the highlighted objects,
rather than a generic "highlighting mode". This allows to:
- use entirely custom colors for highlighting (and vary them over time);
- display any combination of fill/outline for the highlighted area;
- highlight any combinations of element parts.
Reviewed by Pavel Feldman.
* inspector/DOMNodeHighlighter.cpp:
(WebCore::DOMNodeHighlighter::drawHighlight):
* inspector/DOMNodeHighlighter.h:
* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::parseColor):
(WebCore::parseConfigColor):
(WebCore::InspectorDOMAgent::~InspectorDOMAgent):
(WebCore::InspectorDOMAgent::clearFrontend):
(WebCore::InspectorDOMAgent::highlightedNode):
(WebCore::InspectorDOMAgent::handleMousePress):
(WebCore::InspectorDOMAgent::mouseDidMoveOverElement):
(WebCore::InspectorDOMAgent::setSearchingForNode):
(WebCore::InspectorDOMAgent::setInspectModeEnabled):
(WebCore::InspectorDOMAgent::setHighlightDataFromConfig):
(WebCore::InspectorDOMAgent::highlight):
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightNode):
(WebCore::InspectorDOMAgent::highlightFrame):
(WebCore::InspectorDOMAgent::hideHighlight):
(WebCore::InspectorDOMAgent::drawHighlight):
* inspector/InspectorDOMAgent.h:
* inspector/front-end/Color.js:
(WebInspector.Color.fromRGBA):
(WebInspector.Color.prototype.toProtocolRGBA):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.setSearchingForNode):
* inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype._highlightDOMNode.handleMouseOver):
(WebInspector.MetricsSidebarPane.prototype._highlightDOMNode.handleMouseOut):
(WebInspector.MetricsSidebarPane.prototype._highlightDOMNode):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameTreeElement.prototype.set hovered):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._highlightRect):
* inspector/front-end/inspector.css:
* inspector/front-end/inspector.js:
(WebInspector.buildHighlightConfig):
(WebInspector.highlightDOMNode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93603
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Aug 2011 13:37:39 +0000 (13:37 +0000)]
[EFL] Add auxiliary history functions for DRT
https://bugs.webkit.org/show_bug.cgi?id=66700
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-23
Reviewed by Kent Tamura.
EFL's DumpRenderTree implementation needs some private, auxiliary
functions in ewk in order to iterate and dump the history tree when
necessary.
* ewk/ewk_history.cpp:
(ewk_history_item_target_get):
(ewk_history_item_target_is):
(ewk_history_item_children_get):
* ewk/ewk_private.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93602
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Aug 2011 13:36:35 +0000 (13:36 +0000)]
Unreviewed, rolling out r93579.
http://trac.webkit.org/changeset/93579
https://bugs.webkit.org/show_bug.cgi?id=66774
"ASSERTION FAILED: m_purgePreventCount" (Requested by tonyg-cr
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-23
* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getFontDataForCharacters):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93601
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Tue, 23 Aug 2011 13:26:26 +0000 (13:26 +0000)]
[Qt] Fix build on Lion
https://bugs.webkit.org/show_bug.cgi?id=66770
Reviewed by Andreas Kling.
We were mistakenly picking up mac/WebCoreSystemInterface.h instead of
the Qt one, and building on Lion revealed this when a typedef for
IOSurfaceRef was wrapped in PLATFORM(MAC).
For now we fix this by including WebCoreSystemInterface using
brackets, so that we'll pick up the right file based on the
include paths. This also means exposing a few missing enums
in our own version of the file, so those were added.
Lasty, we need to link against the right system interface library
on Lion.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93600
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Aug 2011 13:19:40 +0000 (13:19 +0000)]
[EFL] Add auxiliary ewk_util functions for DRT.
https://bugs.webkit.org/show_bug.cgi?id=66702
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-23
Reviewed by Kenneth Rohde Christiansen.
Add some auxiliary functions needed by EFL's DRT implementation. They
all revolve around talking to the garbage collector and counting the
worker threads.
* ewk/ewk_private.h:
* ewk/ewk_util.cpp:
(ewk_util_javascript_gc_collect):
(ewk_util_javascript_gc_alternate_thread_collect):
(ewk_util_javascript_gc_object_count_get):
(ewk_util_worker_thread_count):
(ewk_util_dpi_get):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93599
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 23 Aug 2011 13:12:28 +0000 (13:12 +0000)]
[Qt] Unreviewed gardening. Remove a non-existent test from the skipped list.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93598
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Tue, 23 Aug 2011 13:07:19 +0000 (13:07 +0000)]
Remove last occurrences of PLATFORM(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66763
Reviewed by Tony Gentilcore.
Source/JavaScriptCore:
* wtf/Platform.h:
Source/WebCore:
No new tests, removing dead code only.
* bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::checkMemoryUsage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93597
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Tue, 23 Aug 2011 12:45:59 +0000 (12:45 +0000)]
Remove Android-specific modifications to non-client-based Geolocation
https://bugs.webkit.org/show_bug.cgi?id=66759
Reviewed by Tony Gentilcore.
No new tests, removing dead code only.
* page/Geolocation.cpp:
* page/Geolocation.h:
* platform/GeolocationService.h:
* platform/efl/GeolocationServiceEfl.cpp:
* platform/efl/GeolocationServiceEfl.h:
* platform/gtk/GeolocationServiceGtk.cpp:
* platform/gtk/GeolocationServiceGtk.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93596
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Tue, 23 Aug 2011 12:43:31 +0000 (12:43 +0000)]
Web Inspector: switch to using BreakpointManager.
https://bugs.webkit.org/show_bug.cgi?id=66225
Reviewed by Pavel Feldman.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addScript.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
(WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.PresentationBreakpoint.prototype.loadSnippet):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93595
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Tue, 23 Aug 2011 12:40:59 +0000 (12:40 +0000)]
Remove all mention of removed Android files from build scripts
https://bugs.webkit.org/show_bug.cgi?id=66755
Reviewed by Tony Gentilcore.
.:
* Source/cmake/WebKitPackaging.cmake:
Source/JavaScriptCore:
* JavaScriptCore.gyp/JavaScriptCore.gyp:
* JavaScriptCore.gypi:
* gyp/JavaScriptCore.gyp:
Source/WebCore:
No new tests, removing dead code only.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* gyp/WebCore.gyp:
Source/WebKit2:
* Scripts/generate-forwarding-headers.pl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93594
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 23 Aug 2011 12:39:55 +0000 (12:39 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=66651
Move <input type=range> tests to fast/forms/range/
Reviewed by Tony Chang.
* fast/forms/ValidityState-stepMismatch-expected.txt: Removed 'range' part.
* fast/forms/input-appearance-range-rtl-expected.html: Removed.
* fast/forms/input-appearance-range-rtl.html: Removed.
* fast/forms/input-appearance-range.html: Removed.
* fast/forms/input-stepup-stepdown-expected.txt: Removed 'range' part.
* fast/forms/input-stepup-stepdown-from-renderer-expected.txt: Removed 'range' part.
* fast/forms/input-valueasnumber-range-expected.txt: Removed.
* fast/forms/input-valueasnumber-range.html: Removed.
* fast/forms/range: Added.
* fast/forms/range-default-value-expected.txt: Removed.
* fast/forms/range-default-value.html: Removed.
* fast/forms/range-drag-expected.txt: Removed.
* fast/forms/range-drag.html: Removed.
* fast/forms/range-input-dynamic-oninput-expected.txt: Removed.
* fast/forms/range-input-dynamic-oninput.html: Removed.
* fast/forms/range-keyoperation-expected.txt: Removed.
* fast/forms/range-keyoperation.html: Removed.
* fast/forms/range-reset-expected.txt: Removed.
* fast/forms/range-reset.html: Removed.
* fast/forms/range-set-attribute-expected.txt: Removed.
* fast/forms/range-set-attribute.html: Removed.
* fast/forms/range-thumb-height-percentage.html: Removed.
* fast/forms/range/ValidityState-stepMismatch-range-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-stepMismatch-expected.txt.
* fast/forms/range/ValidityState-stepMismatch-range.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js.
* fast/forms/range/input-appearance-range-rtl-expected.html: Copied from LayoutTests/fast/forms/input-appearance-range-rtl-expected.html.
* fast/forms/range/input-appearance-range-rtl.html: Copied from LayoutTests/fast/forms/input-appearance-range-rtl.html.
* fast/forms/range/input-appearance-range.html: Copied from LayoutTests/fast/forms/input-appearance-range.html.
* fast/forms/range/input-valueasnumber-range-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-range-expected.txt.
* fast/forms/range/input-valueasnumber-range.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-range.js.
* fast/forms/range/range-default-value-expected.txt: Copied from LayoutTests/fast/forms/range-default-value-expected.txt.
* fast/forms/range/range-default-value.html: Copied from LayoutTests/fast/forms/range-default-value.html.
* fast/forms/range/range-drag-expected.txt: Copied from LayoutTests/fast/forms/range-drag-expected.txt.
* fast/forms/range/range-drag.html: Copied from LayoutTests/fast/forms/range-drag.html.
* fast/forms/range/range-input-dynamic-oninput-expected.txt: Copied from LayoutTests/fast/forms/range-input-dynamic-oninput-expected.txt.
* fast/forms/range/range-input-dynamic-oninput.html: Copied from LayoutTests/fast/forms/range-input-dynamic-oninput.html.
* fast/forms/range/range-keyoperation-expected.txt: Copied from LayoutTests/fast/forms/range-keyoperation-expected.txt.
* fast/forms/range/range-keyoperation.html: Copied from LayoutTests/fast/forms/range-keyoperation.html.
* fast/forms/range/range-reset-expected.txt: Copied from LayoutTests/fast/forms/range-reset-expected.txt.
* fast/forms/range/range-reset.html: Copied from LayoutTests/fast/forms/range-reset.html.
* fast/forms/range/range-set-attribute-expected.txt: Copied from LayoutTests/fast/forms/range-set-attribute-expected.txt.
* fast/forms/range/range-set-attribute.html: Copied from LayoutTests/fast/forms/range-set-attribute.html.
* fast/forms/range/range-stepup-stepdown-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-expected.txt.
* fast/forms/range/range-stepup-stepdown-from-renderer-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt.
* fast/forms/range/range-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js.
* fast/forms/range/range-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js.
* fast/forms/range/range-thumb-height-percentage.html: Copied from LayoutTests/fast/forms/range-thumb-height-percentage.html.
* fast/forms/range/slider-delete-while-dragging-thumb-expected.txt: Copied from LayoutTests/fast/forms/slider-delete-while-dragging-thumb-expected.txt.
* fast/forms/range/slider-delete-while-dragging-thumb.html: Copied from LayoutTests/fast/forms/slider-delete-while-dragging-thumb.html.
* fast/forms/range/slider-hit-testing-expected.txt: Copied from LayoutTests/fast/forms/slider-hit-testing-expected.txt.
* fast/forms/range/slider-hit-testing.html: Copied from LayoutTests/fast/forms/slider-hit-testing.html.
* fast/forms/range/slider-mouse-events-expected.txt: Copied from LayoutTests/fast/forms/slider-mouse-events-expected.txt.
* fast/forms/range/slider-mouse-events.html: Copied from LayoutTests/fast/forms/slider-mouse-events.html.
* fast/forms/range/slider-onchange-event-expected.txt: Copied from LayoutTests/fast/forms/slider-onchange-event-expected.txt.
* fast/forms/range/slider-onchange-event.html: Copied from LayoutTests/fast/forms/slider-onchange-event.html.
* fast/forms/range/slider-padding.html: Copied from LayoutTests/fast/forms/slider-padding.html.
* fast/forms/range/slider-thumb-shared-style.html: Copied from LayoutTests/fast/forms/slider-thumb-shared-style.html.
* fast/forms/range/slider-thumb-stylability.html: Copied from LayoutTests/fast/forms/slider-thumb-stylability.html.
* fast/forms/range/slider-transformed-expected.txt: Copied from LayoutTests/fast/forms/slider-transformed-expected.txt.
* fast/forms/range/slider-transformed.html: Copied from LayoutTests/fast/forms/slider-transformed.html.
* fast/forms/range/slider-zoomed-expected.txt: Copied from LayoutTests/fast/forms/slider-zoomed-expected.txt.
* fast/forms/range/slider-zoomed.html: Copied from LayoutTests/fast/forms/slider-zoomed.html.
* fast/forms/range/thumbslider-crash-expected.txt: Copied from LayoutTests/fast/forms/thumbslider-crash-expected.txt.
* fast/forms/range/thumbslider-crash.html: Copied from LayoutTests/fast/forms/thumbslider-crash.html.
* fast/forms/range/thumbslider-no-parent-slider.html: Copied from LayoutTests/fast/forms/thumbslider-no-parent-slider.html.
* fast/forms/script-tests/ValidityState-stepMismatch.js: Removed 'range' part.
* fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Removed 'range' part.
* fast/forms/script-tests/input-stepup-stepdown.js: Removed 'range' part.
* fast/forms/script-tests/input-valueasnumber-range.js: Removed.
* fast/forms/slider-delete-while-dragging-thumb-expected.txt: Removed.
* fast/forms/slider-delete-while-dragging-thumb.html: Removed.
* fast/forms/slider-hit-testing-expected.txt: Removed.
* fast/forms/slider-hit-testing.html: Removed.
* fast/forms/slider-mouse-events-expected.txt: Removed.
* fast/forms/slider-mouse-events.html: Removed.
* fast/forms/slider-onchange-event-expected.txt: Removed.
* fast/forms/slider-onchange-event.html: Removed.
* fast/forms/slider-padding.html: Removed.
* fast/forms/slider-thumb-shared-style.html: Removed.
* fast/forms/slider-thumb-stylability.html: Removed.
* fast/forms/slider-transformed-expected.txt: Removed.
* fast/forms/slider-transformed.html: Removed.
* fast/forms/slider-zoomed-expected.txt: Removed.
* fast/forms/slider-zoomed.html: Removed.
* fast/forms/thumbslider-crash-expected.txt: Removed.
* fast/forms/thumbslider-crash.html: Removed.
* fast/forms/thumbslider-no-parent-slider.html: Removed.
* platform/chromium-cg-mac-leopard/fast/forms/input-appearance-range-expected.png: Removed.
* platform/chromium-cg-mac-leopard/fast/forms/range: Added.
* platform/chromium-cg-mac-leopard/fast/forms/range/input-appearance-range-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/input-appearance-range-expected.png.
* platform/chromium-cg-mac-leopard/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/slider-padding-expected.png.
* platform/chromium-cg-mac-leopard/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/slider-thumb-shared-style-expected.png.
* platform/chromium-cg-mac-leopard/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/slider-thumb-stylability-expected.png.
* platform/chromium-cg-mac-leopard/fast/forms/range/thumbslider-no-parent-slider-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/thumbslider-no-parent-slider-expected.png.
* platform/chromium-cg-mac-leopard/fast/forms/slider-padding-expected.png: Removed.
* platform/chromium-cg-mac-leopard/fast/forms/slider-thumb-shared-style-expected.png: Removed.
* platform/chromium-cg-mac-leopard/fast/forms/slider-thumb-stylability-expected.png: Removed.
* platform/chromium-cg-mac-leopard/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
* platform/chromium-linux/fast/forms/input-appearance-range-expected.png: Removed.
* platform/chromium-linux/fast/forms/input-appearance-range-expected.txt: Removed.
* platform/chromium-linux/fast/forms/range: Added.
* platform/chromium-linux/fast/forms/range-thumb-height-percentage-expected.png: Removed.
* platform/chromium-linux/fast/forms/range/input-appearance-range-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-appearance-range-expected.png.
* platform/chromium-linux/fast/forms/range/input-appearance-range-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-appearance-range-expected.txt.
* platform/chromium-linux/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/range-thumb-height-percentage-expected.png.
* platform/chromium-linux/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/slider-padding-expected.png.
* platform/chromium-linux/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/slider-thumb-shared-style-expected.png.
* platform/chromium-linux/fast/forms/range/thumbslider-no-parent-slider-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/thumbslider-no-parent-slider-expected.png.
* platform/chromium-linux/fast/forms/slider-padding-expected.png: Removed.
* platform/chromium-linux/fast/forms/slider-thumb-shared-style-expected.png: Removed.
* platform/chromium-linux/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
* platform/chromium-win/fast/forms/input-appearance-range-expected.png: Removed.
* platform/chromium-win/fast/forms/input-appearance-range-expected.txt: Removed.
* platform/chromium-win/fast/forms/range: Added.
* platform/chromium-win/fast/forms/range-thumb-height-percentage-expected.png: Removed.
* platform/chromium-win/fast/forms/range-thumb-height-percentage-expected.txt: Removed.
* platform/chromium-win/fast/forms/range/input-appearance-range-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-range-expected.png.
* platform/chromium-win/fast/forms/range/input-appearance-range-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-range-expected.txt.
* platform/chromium-win/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/range-thumb-height-percentage-expected.png.
* platform/chromium-win/fast/forms/range/range-thumb-height-percentage-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/range-thumb-height-percentage-expected.txt.
* platform/chromium-win/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-padding-expected.png.
* platform/chromium-win/fast/forms/range/slider-padding-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-padding-expected.txt.
* platform/chromium-win/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-thumb-shared-style-expected.png.
* platform/chromium-win/fast/forms/range/slider-thumb-shared-style-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-thumb-shared-style-expected.txt.
* platform/chromium-win/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-thumb-stylability-expected.png.
* platform/chromium-win/fast/forms/range/thumbslider-no-parent-slider-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.png.
* platform/chromium-win/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.txt.
* platform/chromium-win/fast/forms/slider-padding-expected.png: Removed.
* platform/chromium-win/fast/forms/slider-padding-expected.txt: Removed.
* platform/chromium-win/fast/forms/slider-thumb-shared-style-expected.png: Removed.
* platform/chromium-win/fast/forms/slider-thumb-shared-style-expected.txt: Removed.
* platform/chromium-win/fast/forms/slider-thumb-stylability-expected.png: Removed.
* platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
* platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/gtk/fast/forms/input-appearance-range-expected.txt: Removed.
* platform/gtk/fast/forms/range: Added.
* platform/gtk/fast/forms/range-thumb-height-percentage-expected.png: Removed.
* platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt: Removed.
* platform/gtk/fast/forms/range/input-appearance-range-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/input-appearance-range-expected.txt.
* platform/gtk/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/range-thumb-height-percentage-expected.png.
* platform/gtk/fast/forms/range/range-thumb-height-percentage-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt.
* platform/gtk/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/slider-padding-expected.png.
* platform/gtk/fast/forms/range/slider-padding-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/slider-padding-expected.txt.
* platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/slider-thumb-shared-style-expected.png.
* platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt.
* platform/gtk/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/slider-thumb-stylability-expected.png.
* platform/gtk/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/slider-thumb-stylability-expected.txt.
* platform/gtk/fast/forms/range/slider-transformed-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/slider-transformed-expected.txt.
* platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt.
* platform/gtk/fast/forms/slider-padding-expected.png: Removed.
* platform/gtk/fast/forms/slider-padding-expected.txt: Removed.
* platform/gtk/fast/forms/slider-thumb-shared-style-expected.png: Removed.
* platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt: Removed.
* platform/gtk/fast/forms/slider-thumb-stylability-expected.png: Removed.
* platform/gtk/fast/forms/slider-thumb-stylability-expected.txt: Removed.
* platform/gtk/fast/forms/slider-transformed-expected.txt: Removed.
* platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt: Removed.
* platform/mac-leopard/fast/forms/range: Added.
* platform/mac-leopard/fast/forms/range-thumb-height-percentage-expected.png: Removed.
* platform/mac-leopard/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/range-thumb-height-percentage-expected.png.
* platform/mac-leopard/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/slider-padding-expected.png.
* platform/mac-leopard/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/slider-thumb-shared-style-expected.png.
* platform/mac-leopard/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/slider-thumb-stylability-expected.png.
* platform/mac-leopard/fast/forms/slider-padding-expected.png: Removed.
* platform/mac-leopard/fast/forms/slider-thumb-shared-style-expected.png: Removed.
* platform/mac-leopard/fast/forms/slider-thumb-stylability-expected.png: Removed.
* platform/mac/fast/forms/input-appearance-range-expected.png: Removed.
* platform/mac/fast/forms/input-appearance-range-expected.txt: Removed.
* platform/mac/fast/forms/range: Added.
* platform/mac/fast/forms/range-thumb-height-percentage-expected.png: Removed.
* platform/mac/fast/forms/range-thumb-height-percentage-expected.txt: Removed.
* platform/mac/fast/forms/range/input-appearance-range-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-range-expected.png.
* platform/mac/fast/forms/range/input-appearance-range-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-range-expected.txt.
* platform/mac/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/mac/fast/forms/range-thumb-height-percentage-expected.png.
* platform/mac/fast/forms/range/range-thumb-height-percentage-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/range-thumb-height-percentage-expected.txt.
* platform/mac/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/mac/fast/forms/slider-padding-expected.png.
* platform/mac/fast/forms/range/slider-padding-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/slider-padding-expected.txt.
* platform/mac/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/mac/fast/forms/slider-thumb-shared-style-expected.png.
* platform/mac/fast/forms/range/slider-thumb-shared-style-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/slider-thumb-shared-style-expected.txt.
* platform/mac/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/mac/fast/forms/slider-thumb-stylability-expected.png.
* platform/mac/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/slider-thumb-stylability-expected.txt.
* platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.png: Copied from LayoutTests/platform/mac/fast/forms/thumbslider-no-parent-slider-expected.png.
* platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/thumbslider-no-parent-slider-expected.txt.
* platform/mac/fast/forms/slider-padding-expected.png: Removed.
* platform/mac/fast/forms/slider-padding-expected.txt: Removed.
* platform/mac/fast/forms/slider-thumb-shared-style-expected.png: Removed.
* platform/mac/fast/forms/slider-thumb-shared-style-expected.txt: Removed.
* platform/mac/fast/forms/slider-thumb-stylability-expected.png: Removed.
* platform/mac/fast/forms/slider-thumb-stylability-expected.txt: Removed.
* platform/mac/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
* platform/mac/fast/forms/thumbslider-no-parent-slider-expected.txt: Removed.
* platform/qt-mac/Skipped:
* platform/qt/Skipped:
* platform/qt/fast/forms/range: Added.
* platform/qt/fast/forms/range-thumb-height-percentage-expected.txt: Removed.
* platform/qt/fast/forms/range/range-thumb-height-percentage-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/range-thumb-height-percentage-expected.txt.
* platform/qt/fast/forms/range/slider-thumb-shared-style-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/slider-thumb-shared-style-expected.txt.
* platform/qt/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/slider-thumb-stylability-expected.txt.
* platform/qt/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/thumbslider-no-parent-slider-expected.txt.
* platform/qt/fast/forms/slider-thumb-shared-style-expected.txt: Removed.
* platform/qt/fast/forms/slider-thumb-stylability-expected.txt: Removed.
* platform/qt/fast/forms/thumbslider-no-parent-slider-expected.txt: Removed.
* platform/wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93593
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin.poulain@nokia.com [Tue, 23 Aug 2011 12:38:23 +0000 (12:38 +0000)]
[Qt][WK2] ViewportInteractionEngine: the position of the content is not corrected when scaling the page manually
https://bugs.webkit.org/show_bug.cgi?id=66672
Reviewed by Kenneth Rohde Christiansen.
Add the method animateContentIntoBoundariesIfNeeded() to move the content back into both scale and position boundaries.
This method is now used as the entry point for animations in order to avoid bugs regarding scale or position.
The existing animation methods were renamed accordingly for clarity and consistency with the updateContent methods.
* UIProcess/qt/ViewportInteractionEngine.cpp:
(WebKit::ViewportInteractionEngine::panGestureEnded):
(WebKit::ViewportInteractionEngine::pinchGestureEnded):
(WebKit::ViewportInteractionEngine::animateContentIntoBoundariesIfNeeded):
(WebKit::ViewportInteractionEngine::animateContentPositionIntoBoundariesIfNeeded):
(WebKit::ViewportInteractionEngine::animateContentScaleIntoBoundariesIfNeeded):
* UIProcess/qt/ViewportInteractionEngine.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93592
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Tue, 23 Aug 2011 12:21:01 +0000 (12:21 +0000)]
Web Inspector: [Chromium] Fix handling of aggregate names in profiler.
https://bugs.webkit.org/show_bug.cgi?id=66753
Reviewed by Pavel Feldman.
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._buildAggregates):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93591
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 23 Aug 2011 10:34:28 +0000 (10:34 +0000)]
Remove WebCore/editing/android and other Android-specific directories
https://bugs.webkit.org/show_bug.cgi?id=66739
Reviewed by Steve Block.
Now that Android shares more code with Chromium, we don't need these
Android-specific files.
Source/JavaScriptCore:
* wtf/android: Removed.
* wtf/android/AndroidThreading.h: Removed.
* wtf/android/MainThreadAndroid.cpp: Removed.
Source/WebCore:
* editing/android: Removed.
* editing/android/EditorAndroid.cpp: Removed.
* history/android: Removed.
* history/android/AndroidWebHistoryBridge.h: Removed.
* history/android/HistoryItemAndroid.cpp: Removed.
* page/android: Removed.
* page/android/DragControllerAndroid.cpp: Removed.
* page/android/EventHandlerAndroid.cpp: Removed.
* platform/network/android: Removed.
* platform/network/android/AuthenticationChallenge.h: Removed.
* platform/network/android/CookieJarAndroid.cpp: Removed.
* platform/network/android/ProxyServerAndroid.cpp: Removed.
* platform/network/android/ResourceError.h: Removed.
* platform/network/android/ResourceHandleAndroid.cpp: Removed.
* platform/network/android/ResourceLoaderAndroid.h: Removed.
* platform/network/android/ResourceRequest.h: Removed.
* platform/network/android/ResourceRequestAndroid.cpp: Removed.
* platform/network/android/ResourceResponse.h: Removed.
* platform/text/android: Removed.
* platform/text/android/HyphenationAndroid.cpp: Removed.
* platform/text/android/TextBreakIteratorInternalICU.cpp: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93590
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 23 Aug 2011 09:59:48 +0000 (09:59 +0000)]
Remove WebCore/platform/android
https://bugs.webkit.org/show_bug.cgi?id=66734
Reviewed by Steve Block.
This directory is not needed now that Android shares more code with
Chromium.
* platform/android: Removed.
* platform/android/ClipboardAndroid.cpp: Removed.
* platform/android/ClipboardAndroid.h: Removed.
* platform/android/CursorAndroid.cpp: Removed.
* platform/android/DragDataAndroid.cpp: Removed.
* platform/android/EventLoopAndroid.cpp: Removed.
* platform/android/FileSystemAndroid.cpp: Removed.
* platform/android/GeolocationServiceAndroid.cpp: Removed.
* platform/android/GeolocationServiceAndroid.h: Removed.
* platform/android/GeolocationServiceBridge.cpp: Removed.
* platform/android/GeolocationServiceBridge.h: Removed.
* platform/android/KeyEventAndroid.cpp: Removed.
* platform/android/LanguageAndroid.cpp: Removed.
* platform/android/LocalizedStringsAndroid.cpp: Removed.
* platform/android/PlatformBridge.h: Removed.
* platform/android/PlatformTouchEventAndroid.cpp: Removed.
* platform/android/PlatformTouchPointAndroid.cpp: Removed.
* platform/android/PopupMenuAndroid.cpp: Removed.
* platform/android/RenderThemeAndroid.cpp: Removed.
* platform/android/RenderThemeAndroid.h: Removed.
* platform/android/SSLKeyGeneratorAndroid.cpp: Removed.
* platform/android/ScreenAndroid.cpp: Removed.
* platform/android/ScrollViewAndroid.cpp: Removed.
* platform/android/SearchPopupMenuAndroid.cpp: Removed.
* platform/android/SharedTimerAndroid.cpp: Removed.
* platform/android/SoundAndroid.cpp: Removed.
* platform/android/SystemTimeAndroid.cpp: Removed.
* platform/android/TemporaryLinkStubs.cpp: Removed.
* platform/android/WidgetAndroid.cpp: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93589
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 23 Aug 2011 09:52:26 +0000 (09:52 +0000)]
webkitpy/common/config/build.py shouldn't mention non-existant Android directory
https://bugs.webkit.org/show_bug.cgi?id=66737
Reviewed by Steve Block.
This directory doesn't exist anymore now that the Android port shares
more code with Chromium.
* Scripts/webkitpy/common/config/build.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93588
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 23 Aug 2011 09:47:50 +0000 (09:47 +0000)]
2011-08-23 Pavel Feldman <pfeldman@google.com>
Not reviewed. Adding a file that slipped from r93586.
* inspector/generate-protocol-externs: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93587
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 23 Aug 2011 09:33:54 +0000 (09:33 +0000)]
Web Inspector: generate protocol externs API for the front-end compilation.
https://bugs.webkit.org/show_bug.cgi?id=66677
Reviewed by Tony Gentilcore.
Source/WebCore:
* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setAttributesText):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
* inspector/InspectorDebuggerAgent.h:
* inspector/compile-front-end.sh: Added.
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.setAttribute):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.setBreakpoint):
* inspector/front-end/externs.js: Added.
(console.warn):
LayoutTests:
* inspector/debugger/debugger-set-breakpoint-regex.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93586
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Tue, 23 Aug 2011 09:32:42 +0000 (09:32 +0000)]
2011-08-23 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix for compile error on Windows for r93560.
* runtime/SamplingCounter.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93585
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 23 Aug 2011 09:23:31 +0000 (09:23 +0000)]
Web Inspector: Prepare utilities.js for compilation.
https://bugs.webkit.org/show_bug.cgi?id=66656
Removes "this" usage in functions, does not define getters for offsets.
Reviewed by Tony Gentilcore.
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleMessage.prototype._format):
(WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.valueFormatter):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.appropriateSelectorFor):
(WebInspector.DOMNode.prototype.isAncestor):
(WebInspector.DOMNode.prototype.isDescendant):
(WebInspector.DOMNode.prototype.isWhitespace):
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype._resizerDragging):
(WebInspector.DataGridNode.prototype.isEventWithinDisclosureTriangle):
* inspector/front-end/Drawer.js:
(WebInspector.Drawer.prototype.get savedHeight):
(WebInspector.Drawer.prototype.onResize):
(WebInspector.Drawer.prototype._startStatusBarDragging):
(WebInspector.Drawer.prototype._statusBarDragging):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.updateModifiedNodes):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
(WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes.crumbsAreSmallerThanContainer):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.findTreeElement):
(WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
():
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject):
* inspector/front-end/ResourceTimingView.js:
(WebInspector.ResourceTimingView.createTimingTable):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.BaseStorageTreeElement.prototype.isEventWithinDisclosureTriangle):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._startSidebarResizeDrag):
* inspector/front-end/SoftContextMenu.js:
(.WebInspector.SoftContextMenu.prototype.show):
* inspector/front-end/Toolbar.js:
(WebInspector.ToolbarDropdown.prototype.show):
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype._updateHoveredElement):
* inspector/front-end/inspector.js:
(Number.secondsToString):
(Number.bytesToString):
* inspector/front-end/treeoutline.js:
(TreeElement.prototype.isEventWithinDisclosureTriangle):
* inspector/front-end/utilities.js:
(setupPrototypeUtilities.Element.prototype.totalOffsetLeft):
(setupPrototypeUtilities.Element.prototype.totalOffsetTop):
(setupPrototypeUtilities.Element.prototype.offsetRelativeToWindow):
(setupPrototypeUtilities):
(setupPrototypeUtilities.):
():
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93584
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 23 Aug 2011 08:50:59 +0000 (08:50 +0000)]
Unreviewed gardening. Remove Windows style new lines from the test introduced in r93521.
* fast/loader/document-destruction-within-unload-expected.txt:
* fast/loader/document-destruction-within-unload.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93583
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 23 Aug 2011 08:43:18 +0000 (08:43 +0000)]
[WK2] Unreviewed gardening.
* platform/wk2/Skipped: Skip fast/frames/focus-controller-crash-change-event.html, because eventSender.keyDown is unimplemented.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93582
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reni@webkit.org [Tue, 23 Aug 2011 08:25:17 +0000 (08:25 +0000)]
[Qt] REGRESSION after r93567.
https://bugs.webkit.org/show_bug.cgi?id=66749
Three tests have assertion failed error in debug mode on x86-32 Linux Qt. They are skipped.
Unreviewed gardening.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93581
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Aug 2011 05:45:49 +0000 (05:45 +0000)]
Implemented skia support for caching resizes of cropped images.
https://bugs.webkit.org/show_bug.cgi?id=65587
Patch by John Bates <jbates@google.com> on 2011-08-22
Reviewed by Darin Fisher.
Previously, resizes of cropped images would not be cached. This causes various websites to have janky CSS animations in software compositing mode.
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::drawResampledBitmap): Changed to use new APIs for subset caching.
(WebCore::Image::drawPattern): Added allowCaching parameter.
* platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::NativeImageSkia):
(WebCore::NativeImageSkia::CachedImageInfo::CachedImageInfo):
(WebCore::NativeImageSkia::CachedImageInfo::isEqual):
(WebCore::NativeImageSkia::CachedImageInfo::set):
(WebCore::NativeImageSkia::hasResizedBitmap): Changed this method so that it does not modify caching data. Added a second version used for cropped image resizes.
(WebCore::NativeImageSkia::resizedBitmap): Added parameter to let caller specify whether caching is allowed.
(WebCore::NativeImageSkia::shouldCacheResampling): Added a second version used for cropped image resizes.
(WebCore::NativeImageSkia::shouldCacheResamplingInternal): Both shouldCacheResampling methods call down to this for the shared logic.
* platform/graphics/skia/NativeImageSkia.h: Added CachedImageInfo to uniquely identify the cached or requested image resize operation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93580
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Tue, 23 Aug 2011 04:09:07 +0000 (04:09 +0000)]
[chromium] Fonts returned by FontCache::getFontDataForCharacters() are never released
https://bugs.webkit.org/show_bug.cgi?id=66673
Reviewed by James Robinson.
This was fixed for other ports in http://trac.webkit.org/changeset/88260.
However, it was missed in FontCacheLinux likely due to similar param in the nested call to getCachedFontPlatformData().
No new tests because no directly observable change in behavior.
* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getFontDataForCharacters):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93579
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Aug 2011 03:55:42 +0000 (03:55 +0000)]
Unreviewed, rolling out r93565.
http://trac.webkit.org/changeset/93565
https://bugs.webkit.org/show_bug.cgi?id=66745
Breaks layout tests (Requested by koz2 on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-22
Source/WebCore:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaLabeledByElements):
(WebCore::AccessibilityRenderObject::ariaLabeledByAttribute):
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::hasTextAlternative):
* accessibility/AccessibilityRenderObject.h:
LayoutTests:
* accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt: Removed.
* accessibility/aria-labelledby-overrides-aria-labeledby.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93578
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Aug 2011 02:53:26 +0000 (02:53 +0000)]
Unreviewed, rolling out r93575.
http://trac.webkit.org/changeset/93575
https://bugs.webkit.org/show_bug.cgi?id=66744
Does not compile on chromium canaries (Requested by jamesr on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-22
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setStandardFontFamily):
(WebKit::WebSettingsImpl::setFixedFontFamily):
(WebKit::WebSettingsImpl::setSerifFontFamily):
(WebKit::WebSettingsImpl::setSansSerifFontFamily):
(WebKit::WebSettingsImpl::setCursiveFontFamily):
(WebKit::WebSettingsImpl::setFantasyFontFamily):
* src/WebSettingsImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93577
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Aug 2011 02:15:22 +0000 (02:15 +0000)]
[chromium] Update WebSettings to support per-script font settings
https://bugs.webkit.org/show_bug.cgi?id=66220
Patch by Matt Falkenhagen <falken@chromium.org> on 2011-08-22
Reviewed by Tony Chang.
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setStandardFontFamily):
(WebKit::WebSettingsImpl::setFixedFontFamily):
(WebKit::WebSettingsImpl::setSerifFontFamily):
(WebKit::WebSettingsImpl::setSansSerifFontFamily):
(WebKit::WebSettingsImpl::setCursiveFontFamily):
(WebKit::WebSettingsImpl::setFantasyFontFamily):
* src/WebSettingsImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93575
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Aug 2011 02:07:03 +0000 (02:07 +0000)]
Range::setEnd(const Position&, ExceptionCode) calls setStart() instead of setEnd()
https://bugs.webkit.org/show_bug.cgi?id=66638
Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-08-22
Reviewed by Ryosuke Niwa.
Relevant layout test coming in a future patch (see https://bugs.webkit.org/show_bug.cgi?id=65900)
* dom/Range.cpp:
(WebCore::Range::setEnd):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93574
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 23 Aug 2011 02:05:48 +0000 (02:05 +0000)]
Remove PLATFORM(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66741
Reviewed by Darin Adler.
PLATFORM(CHROMIUM) && OS(ANDROID) is the new hotness. These special
cases can be removed now that Android shares more code with Chromium.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsRichSourceInfo):
* bindings/v8/ScriptCachedFrameData.cpp:
* bindings/v8/ScriptCachedFrameData.h:
* bindings/v8/V8GCController.cpp:
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::invokeMethod):
* history/HistoryItem.cpp:
(WebCore::HistoryItem::~HistoryItem):
(WebCore::HistoryItem::setDocumentState):
(WebCore::HistoryItem::clearDocumentState):
(WebCore::HistoryItem::setIsTargetItem):
(WebCore::HistoryItem::addChildItem):
(WebCore::HistoryItem::setFormInfoFromRequest):
* history/HistoryItem.h:
* loader/cache/CachedFont.cpp:
* platform/DragImage.h:
* platform/PlatformTouchEvent.h:
* platform/PlatformTouchPoint.h:
(WebCore::PlatformTouchPoint::PlatformTouchPoint):
* platform/Widget.h:
* platform/network/NetworkStateNotifier.cpp:
* platform/network/NetworkStateNotifier.h:
* platform/network/NetworkingContext.h:
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleInternal.h:
* platform/network/ResourceRequestBase.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93573
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Aug 2011 02:02:35 +0000 (02:02 +0000)]
[EFL] Implement FrameLoaderClient::dispatchDidClearWindowObjectInWorld
https://bugs.webkit.org/show_bug.cgi?id=66685
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-22
Reviewed by Kent Tamura.
Implement dispatchDidClearWindowObjectInWorld, as it is needed by
DumpRenderTree to, among other things, properly install the event
sender in the window object.
This implementation works by emitting a "window,object,cleared" signal
with a private struct containing the required information (context,
window object and frame).
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):
* WebCoreSupport/FrameLoaderClientEfl.h:
* ewk/ewk_private.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93572
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Tue, 23 Aug 2011 01:35:48 +0000 (01:35 +0000)]
[chromium] Remove compositing assertions about creating layers when painting
https://bugs.webkit.org/show_bug.cgi?id=66731
Reviewed by James Robinson.
The trigger for this assertion would cause a real rendering issue, but
it is both intermittent and in the wrong place in the codebase to
catch the source of the problem.
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::~LayerChromium):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
* platform/graphics/chromium/LayerRendererChromium.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93571
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Tue, 23 Aug 2011 01:07:33 +0000 (01:07 +0000)]
[chromium] Mark some tests on Mac as flakily crashing.
Unreviewed, test expectations update.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93570
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Tue, 23 Aug 2011 00:49:58 +0000 (00:49 +0000)]
[chromium] Mark some tests on Windows as flaky.
Unreviewed, test expectations update.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93568
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 23 Aug 2011 00:43:32 +0000 (00:43 +0000)]
showModalDialog does not correctly return the defined returnValue in case domain relaxing is used
https://bugs.webkit.org/show_bug.cgi?id=53191
<rdar://problem/
8629478>
Reviewed by Geoff Garen.
Cannot test domain relaxing, we only have 127.0.0.1 and localhost.
* bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlot):
Added a FIXME about a difference with Firefox.
(WebCore::DialogHandler::DialogHandler):
(WebCore::DialogHandler::dialogCreated):
(WebCore::DialogHandler::returnValue):
Changed to fetch returnValue from the global object that's in the frame when the dialog is
dismissed. A dialog can navigate itself, and it also creates a new JSDOMWindow on first load
if the origin doesn't match opener origin (which the case with domain relaxing).
Re-added a security check for returnValue that got lost in r73829, so that we don't send the
result across origins. This matches Firefox.
* bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::setWindow): Added an assertion
against a very confusing case that should no longer occur.
* page/Frame.cpp: (WebCore::Frame::pageDestroyed): Don't clear the window shell, it doesn't
seem necessary, but prevents DialogHandler from fetching the return value. Added a keepAlive
call to avoid changing life support timer behavior in this patch.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93567
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Aug 2011 00:37:15 +0000 (00:37 +0000)]
[chromium] WebViewImpl should not reshape the 3D context
https://bugs.webkit.org/show_bug.cgi?id=66704
Patch by Iain Merrick <husky@google.com> on 2011-08-22
Reviewed by James Robinson.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::createLayerTreeHostContext3D):
(WebKit::WebViewImpl::graphicsContext3D):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93566
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Aug 2011 00:24:30 +0000 (00:24 +0000)]
Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-08-22
Reviewed by Chris Fleizach.
aria-labelledby should be used in preference to aria-labeledby
https://bugs.webkit.org/show_bug.cgi?id=62351
Source/WebCore:
Test: accessibility/aria-labelledby-overrides-aria-labeledby.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaLabelledByElements): Renamed from ariaLabeledByElements.
(WebCore::AccessibilityRenderObject::ariaLabelledByAttribute): Renamed from ariaLabeledByAttribute,
and re-ordered to prefer the standard spelling.
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::hasTextAlternative):
* accessibility/AccessibilityRenderObject.h:
LayoutTests:
* accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt: Added.
* accessibility/aria-labelledby-overrides-aria-labeledby.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93565
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
nduca@chromium.org [Tue, 23 Aug 2011 00:14:13 +0000 (00:14 +0000)]
Make GraphicsContext3D::isResourceSafe a function and, on Chromium, determine its value lazily
https://bugs.webkit.org/show_bug.cgi?id=66708
Reviewed by Kenneth Russell.
Source/WebCore:
* platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::texImage2DResourceSafe):
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/gtk/GraphicsContext3DGtk.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
* platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D):
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::isResourceSafe):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
Source/WebKit/chromium:
* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::isResourceSafe):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::isResourceSafe):
* src/GraphicsContext3DInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93564
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 23 Aug 2011 00:05:10 +0000 (00:05 +0000)]
Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
I won't have ssh access to the bot again for a couple days, so
attempting to fix by changing this script. If this doesn't
work we'll just live with the it hung for now.
Unreviewed.
* EWSTools/start-queue.sh:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93563
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Mon, 22 Aug 2011 23:53:19 +0000 (23:53 +0000)]
webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file.
https://bugs.webkit.org/show_bug.cgi?id=66727
Reviewed by Adam Barth.
* Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter,
in which case the serializer treats all expectations as unparsed.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93562
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 22 Aug 2011 23:52:37 +0000 (23:52 +0000)]
HTMLSourceTracker crashes when network packets break poorly
https://bugs.webkit.org/show_bug.cgi?id=66728
Reviewed by Darin Adler.
Source/WebCore:
If there is a network packet boundary in the middle of an attribute
that begins with the letters "on", then the HTMLSourceTracker will get
confused and try to extract too many characters from future input. If
the future input is small enough, that will walk off the end of the
input and crash.
Test: http/tests/security/xssAuditor/crash-while-loading-tag-with-pause.html
* html/parser/HTMLSourceTracker.cpp:
(WebCore::HTMLSourceTracker::sourceForToken):
LayoutTests:
Test that we don't crash when we get a bad network packet boundary.
* http/tests/security/xssAuditor/crash-while-loading-tag-with-pause-expected.txt: Added.
* http/tests/security/xssAuditor/crash-while-loading-tag-with-pause.html: Added.
* http/tests/security/xssAuditor/resources/tag-with-pause.php: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93561
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Mon, 22 Aug 2011 23:41:20 +0000 (23:41 +0000)]
Sampling counter support is in the bytecode directory
https://bugs.webkit.org/show_bug.cgi?id=66724
Reviewed by Darin Adler.
Moved SamplingCounter to a separate header in runtime/.
* GNUmakefile.list.am:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/SamplingTool.cpp:
* bytecode/SamplingTool.h:
* runtime/SamplingCounter.cpp: Added.
(JSC::AbstractSamplingCounter::dump):
* runtime/SamplingCounter.h: Added.
(JSC::AbstractSamplingCounter::count):
(JSC::AbstractSamplingCounter::addressOfCounter):
(JSC::AbstractSamplingCounter::init):
(JSC::SamplingCounter::SamplingCounter):
(JSC::GlobalSamplingCounter::name):
(JSC::DeletableSamplingCounter::DeletableSamplingCounter):
(JSC::DeletableSamplingCounter::~DeletableSamplingCounter):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93560
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 22 Aug 2011 23:34:31 +0000 (23:34 +0000)]
Attempt to clean up bidiNext usage
https://bugs.webkit.org/show_bug.cgi?id=66721
Reviewed by Ryosuke Niwa.
bidiNext and bidiFirst are horribly confusing.
Even worse is that bidiNext takes a bunch of mutually exclusive options.
It appears that there is a "return me every inline, even if its empty"
mode which is only used for simplified inline layout in RenderBlock.cpp.
To support that mode, there is a endOfInline pointer which keeps track
of if we just returned at the end of an inline to so we don't get stuck in
and empty inline (unable to distinguish the start from the finish).
The actual bidi/line-layout code uses bidiNext/bidiFirst in a "skip empty inlines"
mode. (Since empty inlines do not participate in the Unicode Bidi Algorithm.)
This change renames bidiNext to bidiNextShared (still a horrible name) and moves
all callers to explicitly calling bidiNextSkippingEmptyInlines or bidiNextIncludingEmptyInlines.
It becomes obvious which code uses which.
In reviewing this code be aware that the previous bidiNext default was to "skip empty inlines" (skipInlines = true).
Thus any caller who didn't pass true/false should now be calling bidiNextSkippingEmptyInlines instead.
No functional change, thus no tests.
* rendering/InlineIterator.h:
(WebCore::bidiNextShared):
(WebCore::bidiNextSkippingEmptyInlines):
(WebCore::bidiNextIncludingEmptyInlines):
(WebCore::bidiFirstSkippingEmptyInlines):
(WebCore::bidiFirstIncludingEmptyInlines):
(WebCore::InlineWalker::InlineWalker):
(WebCore::InlineWalker::advance):
(WebCore::InlineIterator::increment):
(WebCore::InlineBidiResolver::appendRun):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::determineStartPosition):
(WebCore::shouldSkipWhitespaceAfterStartObject):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93559
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Mon, 22 Aug 2011 23:30:10 +0000 (23:30 +0000)]
Fix usage of PassRefPtr in postMessage and structured clone code.
https://bugs.webkit.org/show_bug.cgi?id=66725
Reviewed by Darin Adler.
No new functionality exposed so no new tests.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::postMessage): Changed PassRefPtr to RefPtr and added release when handed off.
* bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::initMessageEvent): Ditto.
* bindings/js/JSMessagePortCustom.h:
(WebCore::handlePostMessage): Ditto.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create): Ditto.
* workers/SharedWorkerContext.cpp:
(WebCore::createConnectEvent): Added release() when a RefPtr is returned.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93558
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Mon, 22 Aug 2011 23:24:18 +0000 (23:24 +0000)]
Implement cast between CSSPrimitiveValue and EBackfaceVisibility, use in CSSStyleSelector::applyProperty.
https://bugs.webkit.org/show_bug.cgi?id=66648
Reviewed by Dan Bernstein.
No new tests / no functionality changed.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Support cast from EBackfaceVisibility.
(WebCore::CSSPrimitiveValue::operator EBackfaceVisibility):
Support cast from EBackfaceVisibility.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93557
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Mon, 22 Aug 2011 23:15:05 +0000 (23:15 +0000)]
Unreviewed, rolling out r93538.
http://trac.webkit.org/changeset/93538
https://bugs.webkit.org/show_bug.cgi?id=66143
Broke Leopard, SnowLeopard, and Chromium Mac bots
Source/WebCore:
* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::logicalRightOffsetForLine):
* rendering/RenderBlock.h:
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
* rendering/RenderFlowThread.h:
* rendering/RenderRegion.cpp:
* rendering/RenderRegion.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
* rendering/RenderView.h:
(WebCore::RenderView::pushLayoutState):
LayoutTests:
* fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
* fast/regions/webkit-flow-floats-inside-regions-bounds.html: Removed.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Removed.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr-expected.txt: Removed.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr.html: Removed.
* fast/regions/webkit-flow-inlines-inside-regions-bounds.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93556
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Mon, 22 Aug 2011 23:08:37 +0000 (23:08 +0000)]
Delay GC triggered NP object destruction to the next runloop cycle
https://bugs.webkit.org/show_bug.cgi?id=66717
Reviewed by Anders Carlsson.
Delay destruction of plugin objects caused by GC until the next
runloop cycle so that they can execute JS in their finalizers.
We do this using a zero delay timer coupled with a queue of
objects to be finalised.
* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::releaseObject):
* WebProcess/Plugins/Netscape/JSNPObject.h:
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::NPRuntimeObjectMap):
(WebKit::NPRuntimeObjectMap::invalidate):
(WebKit::NPRuntimeObjectMap::invalidateQueuedObjects):
(WebKit::NPRuntimeObjectMap::addToInvalidationQueue):
(WebKit::NPRuntimeObjectMap::finalize):
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
* WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp:
(WebKit::trySafeReleaseNPObject):
* WebProcess/Plugins/Netscape/NPRuntimeUtilities.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93555
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Mon, 22 Aug 2011 23:08:36 +0000 (23:08 +0000)]
Move chromium-mac/plugins/keyboard-events-expected.txt to
chromium-cg-mac/plugins/keyboard-events-expected.txt since the results
for chromium-mac are currently in chromium-cg-mac. This result was
added in r93519 and put in the wrong place.
* platform/chromium-cg-mac/plugins/keyboard-events-expected.txt: Copied from LayoutTests/platform/chromium-mac/plugins/keyboard-events-expected.txt.
* platform/chromium-mac/plugins: Removed.
* platform/chromium-mac/plugins/keyboard-events-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93554
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Mon, 22 Aug 2011 22:44:31 +0000 (22:44 +0000)]
[chromium] Remove deprecated and unused bits of WebIDB* headers
https://bugs.webkit.org/show_bug.cgi?id=66711
Reviewed by Tony Chang.
The Chromium side of this patch was submitted as
http://crrev.com/97687.
* public/WebIDBCallbacks.h:
* public/WebIDBCursor.h:
(WebKit::WebIDBCursor::primaryKey):
(WebKit::WebIDBCursor::value):
(WebKit::WebIDBCursor::deleteFunction):
* public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::transaction):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93553
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Mon, 22 Aug 2011 22:35:53 +0000 (22:35 +0000)]
Update unit test expectations after r93530.
* Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93552
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Mon, 22 Aug 2011 22:20:17 +0000 (22:20 +0000)]
Add CSS parsing of -webkit-flex-pack
https://bugs.webkit.org/show_bug.cgi?id=66701
Reviewed by Eric Seidel.
Source/WebCore:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexPack):
* css/CSSPropertyNames.in:
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::flexPack):
(WebCore::InheritedFlags::setFlexPack):
(WebCore::InheritedFlags::initialFlexPack):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
* rendering/style/StyleFlexibleBoxData.h:
LayoutTests:
* css3/flexbox/css-properties-expected.txt:
* css3/flexbox/script-tests/css-properties.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93551
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 22 Aug 2011 22:08:33 +0000 (22:08 +0000)]
Move code from PageClientImpl::doneWithKeyEvent to WKView
https://bugs.webkit.org/show_bug.cgi?id=66722
Reviewed by Darin Adler.
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::doneWithKeyEvent):
* UIProcess/API/mac/WKView.mm:
(-[WKView _doneWithKeyEvent:WebKit::eventWasHandled:]):
* UIProcess/API/mac/WKViewInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93550
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 22 Aug 2011 22:01:17 +0000 (22:01 +0000)]
Add editing/selection/caret-at-bidi-boundary.html back to the Qt's skipped list
because r93529 didn't fix it. The failure is still tracked by the bug 66514.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93549
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 22 Aug 2011 21:56:22 +0000 (21:56 +0000)]
Update the text input context when the plug-in focus changes and not when the complex text input state changes
https://bugs.webkit.org/show_bug.cgi?id=66716
Reviewed by Darin Adler.
* UIProcess/API/mac/WKView.mm:
(-[WKView _pluginFocusOrWindowFocusChanged:pluginComplexTextInputIdentifier:]):
(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93548
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Mon, 22 Aug 2011 21:49:06 +0000 (21:49 +0000)]
handle child margin values when flexing
https://bugs.webkit.org/show_bug.cgi?id=65887
Reviewed by David Hyatt.
Source/WebCore:
Test: css3/flexbox/002.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidth):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutHorizontalBlock):
(WebCore::RenderFlexibleBox::computePreferredSize): If the margin is
auto, treat it as flex(1 0 0).
* rendering/RenderObject.cpp:
(WebCore::RenderObject::isFlexibleBoxIncludingDeprecated): Added.
LayoutTests:
* css3/flexbox/002-expected.txt: Added.
* css3/flexbox/002.html: Added.
* css3/flexbox/resources/flexbox.js:
(checkHorizontalBoxen):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93547
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Mon, 22 Aug 2011 21:46:58 +0000 (21:46 +0000)]
REGRESSION (r92231): Apple campus proposal PDF doesn't display in Safari
https://bugs.webkit.org/show_bug.cgi?id=66464
Changed ArgumentEncoder to use system malloc instead of fastMalloc.
FastMalloc uses madvise(MADV_FREE_REUSABLE) which is incompatible with
mach message Out Of Line (OOL) messages that use MACH_MSG_VIRTUAL_COPY.
The system malloc has no such limitation.
Changed sendOutgoingMessage to use MACH_MSG_VIRTUAL_COPY again as it
doesn't have size limitations that MACH_MSG_PHYSICAL_COPY.
Reviewed by Anders Carlsson.
* Platform/CoreIPC/ArgumentEncoder.cpp:
(CoreIPC::ArgumentEncoder::~ArgumentEncoder):
(CoreIPC::ArgumentEncoder::grow):
* Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::sendOutgoingMessage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93546
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Mon, 22 Aug 2011 21:45:39 +0000 (21:45 +0000)]
[Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
https://bugs.webkit.org/show_bug.cgi?id=66705
Reviewed by Adam Barth.
* Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93545
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 22 Aug 2011 21:38:41 +0000 (21:38 +0000)]
Use -[NSApplication updateWindows] to update the current input context
https://bugs.webkit.org/show_bug.cgi?id=66715
Reviewed by Alexey Proskuryakov.
* UIProcess/API/mac/WKView.mm:
(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93544
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 22 Aug 2011 21:35:23 +0000 (21:35 +0000)]
The UI process should keep track of whether a plug-in has focus or not
https://bugs.webkit.org/show_bug.cgi?id=66712
Reviewed by Darin Adler.
This is in preparation for implementing the updated Cocoa text input model.
Pipe through whether a plug-in and its containing window has focus or not, from the
plug-in process and all the way to the UI process.
* PluginProcess/PluginControllerProxy.h:
* PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::pluginFocusOrWindowFocusChanged):
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::pluginFocusOrWindowFocusChanged):
* UIProcess/API/mac/WKView.mm:
(-[WKView _pluginFocusOrWindowFocusChanged:pluginComplexTextInputIdentifier:]):
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::pluginFocusOrWindowFocusChanged):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformSetFocus):
(WebKit::NetscapePlugin::windowFocusChanged):
(WebKit::NetscapePlugin::pluginFocusOrWindowFocusChanged):
* WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
(WebKit::PluginProxy::pluginFocusOrWindowFocusChanged):
* WebProcess/Plugins/PluginController.h:
* WebProcess/Plugins/PluginProxy.h:
* WebProcess/Plugins/PluginProxy.messages.in:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::pluginFocusOrWindowFocusChanged):
* WebProcess/Plugins/PluginView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93543
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
nduca@chromium.org [Mon, 22 Aug 2011 21:23:23 +0000 (21:23 +0000)]
[chromium] Make compositor context current before querying for extensions
https://bugs.webkit.org/show_bug.cgi?id=66696
Reviewed by James Robinson.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93542
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Mon, 22 Aug 2011 21:13:35 +0000 (21:13 +0000)]
[chromium] Disable compositing tests for Leopard.
Reviewed by James Robinson.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93541
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caryclark@google.com [Mon, 22 Aug 2011 21:07:03 +0000 (21:07 +0000)]
Webkit Mac10.6 Builder-Tester (Skia)(deps)(dbg) has compile failures
https://bugs.webkit.org/show_bug.cgi?id=66703
This error was detected by the debug build of the Chromium WebKit
Canary.
Reviewed by James Robinson.
No new tests. This change suppresses a compile-time warning
but does not affect the generated code.
* platform/graphics/mac/FontCustomPlatformData.h:
Replaced struct with class in a forward reference.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93540
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 22 Aug 2011 21:05:33 +0000 (21:05 +0000)]
Update the current NSTextInputContext whenever the plug-in complex text input state changes
https://bugs.webkit.org/show_bug.cgi?id=66709
Reviewed by Sam Weinig.
Call [NSTextInputContext currentInputContext] which will force AppKit to update the current input
context. Fixes a rare case when the out-of-line editing window wouldn't appear.
* UIProcess/API/mac/WKView.mm:
(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93539
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 22 Aug 2011 21:04:33 +0000 (21:04 +0000)]
[CSSRegions] RenderFlowThread layout should use the attached region sizes
https://bugs.webkit.org/show_bug.cgi?id=66143
Source/WebCore:
When RenderFlowThread is doing the layout it also sets the current RenderFlowThread on
the RenderView. RenderFlowThread cannot be nested inside a single RenderView, so there's no
need to put that on the LayoutState.
The right offset used to layout the inlines inside a RenderFlowThread
is now adjusted to fit inside the current region.
Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-22
Reviewed by David Hyatt.
Tests: fast/regions/webkit-flow-floats-inside-regions-bounds.html
fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr.html
fast/regions/webkit-flow-inlines-inside-regions-bounds.html
* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::adjustForRegionFittingIfNeeded):
(WebCore::RenderBlock::logicalRightOffsetForLine):
* rendering/RenderBlock.h:
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
(WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::renderRegionForLine):
(WebCore::RenderFlowThread::regionLogicalWidthForLine):
* rendering/RenderFlowThread.h:
(WebCore::RegionFittingDisabler::RegionFittingDisabler):
(WebCore::RegionFittingDisabler::~RegionFittingDisabler):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::layout):
* rendering/RenderRegion.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
* rendering/RenderView.h:
(WebCore::RenderView::hasRenderFlowThread):
(WebCore::RenderView::currentRenderFlowThread):
(WebCore::RenderView::setCurrentRenderFlowThread):
(WebCore::RenderView::pushLayoutState):
LayoutTests:
Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-22
Reviewed by David Hyatt.
* fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
* fast/regions/webkit-flow-floats-inside-regions-bounds.html: Added.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr-expected.txt: Added.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr.html: Added.
* fast/regions/webkit-flow-inlines-inside-regions-bounds.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93538
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Mon, 22 Aug 2011 20:53:40 +0000 (20:53 +0000)]
Remove third_party/leveldb, because it's no longer used and doesn't exist downstream.
* DEPS: Done it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93537
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Mon, 22 Aug 2011 20:45:20 +0000 (20:45 +0000)]
REGRESSION (r89086): All worker xhr requests trigger preflight requests.
https://bugs.webkit.org/show_bug.cgi?id=66340
Reviewed by Darin Adler.
Added tests which are similar to the non worker test with the same name.
* http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt: Added.
* http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple.html: Added.
* http/tests/xmlhttprequest/workers/resources/access-control-basic-get-fail-non-simple-test.js: Added.
* http/tests/xmlhttprequest/workers/resources/access-control-basic-get-fail-non-simple.js: Added.
* http/tests/xmlhttprequest/workers/shared-worker-access-control-basic-get-fail-non-simple-expected.txt: Added.
* http/tests/xmlhttprequest/workers/shared-worker-access-control-basic-get-fail-non-simple.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93536
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Mon, 22 Aug 2011 20:39:11 +0000 (20:39 +0000)]
Roll Chromium DEPS to 97698.
* DEPS: Rolled.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93535
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Mon, 22 Aug 2011 20:38:52 +0000 (20:38 +0000)]
[chromium] Rename chromium-gpu-mac to chromium-gpu-cg-mac
* platform/chromium-gpu-cg-mac: Copied from LayoutTests/platform/chromium-gpu-mac.
* platform/chromium-gpu-mac: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93534
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Mon, 22 Aug 2011 20:23:58 +0000 (20:23 +0000)]
Unreviewed, rolling out r93517.
http://trac.webkit.org/changeset/93517
https://bugs.webkit.org/show_bug.cgi?id=63553
Breaks GTK Linux and Chromium Win
Source/WebCore:
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):
LayoutTests:
* svg/animations/animate-end-attribute-expected.txt: Removed.
* svg/animations/animate-end-attribute.html: Removed.
* svg/animations/script-tests/animate-end-attribute.js: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93532
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 22 Aug 2011 20:05:51 +0000 (20:05 +0000)]
FrameSelection::setNonDirectionalSelectionIfNeeded should not have a FrameSelection passed to it
https://bugs.webkit.org/show_bug.cgi?id=66636
Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-22
Reviewed by Darin Adler.
setNonDirectionalSelection was moved into FrameSelection in r93134 for
bug 60529, and still took a FrameSelection as an argument, which has been removed.
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::setNonDirectionalSelectionIfNeeded):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93531
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Mon, 22 Aug 2011 19:35:50 +0000 (19:35 +0000)]
[chromium] Update builder names for chromium gpu bots due to CG switchover
https://bugs.webkit.org/show_bug.cgi?id=66693
Reviewed by Dirk Pranke.
Update the port and builder names for the chromium mac gpu bots to
account for the CG transition.
* Scripts/webkitpy/layout_tests/port/builders.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93530
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 22 Aug 2011 19:12:59 +0000 (19:12 +0000)]
editing/selection/caret-at-bidi-boundary.html timing out on Windows since it was added
https://bugs.webkit.org/show_bug.cgi?id=66551
Reviewed by Adam Roben.
Replaced leapForward by dummy clicks to make it work on Windows and other ports.
* editing/selection/caret-at-bidi-boundary.html:
* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93529
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Mon, 22 Aug 2011 19:08:36 +0000 (19:08 +0000)]
Add CSS parsing of -webkit-flex-order
https://bugs.webkit.org/show_bug.cgi?id=65384
Source/WebCore:
The property is an int described here:
http://dev.w3.org/csswg/css3-flexbox/#flex-order
Doesn't do anything yet, just hooking it up.
Reviewed by Ojan Vafai.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPropertyNames.in:
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::flexOrder):
(WebCore::InheritedFlags::setFlexOrder):
(WebCore::InheritedFlags::initialFlexOrder):
* rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
* rendering/style/StyleFlexibleBoxData.h:
LayoutTests:
Reviewed by Ojan Vafai.
* css3/flexbox/css-properties-expected.txt:
* css3/flexbox/css-properties.html:
* css3/flexbox/script-tests/css-properties.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93528
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Mon, 22 Aug 2011 19:03:59 +0000 (19:03 +0000)]
fix the GPU bot names on the layout test dashboard
https://bugs.webkit.org/show_bug.cgi?id=66697
Reviewed by Dimitri Glazkov.
* TestResultServer/static-dashboards/builders.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93527
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Mon, 22 Aug 2011 18:49:42 +0000 (18:49 +0000)]
[chromium] Fix nullptr deref when switching composited tabs
https://bugs.webkit.org/show_bug.cgi?id=66691
Reviewed by James Robinson.
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::protectTileTextures):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93526
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 22 Aug 2011 18:18:59 +0000 (18:18 +0000)]
[chromium] Content and render surface textures not freed when compositor context destroyed
https://bugs.webkit.org/show_bug.cgi?id=66589
Patch by James Robinson <jamesr@chromium.org> on 2011-08-22
Reviewed by Kenneth Russell.
Explicitly delete all managed textures when destroying the compositor
context. This regressed due to a combination of using share groups
(so destroying a context no longer implicitly releases all resources
in that context) and switching the TextureManager over to support
deferred texture destruction.
We sadly don't have a way to construct automated tests for resource
leaks currently.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::cleanupSharedObjects):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93523
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Mon, 22 Aug 2011 18:15:48 +0000 (18:15 +0000)]
garden-o-matic's relative time display should be updated regularly.
https://bugs.webkit.org/show_bug.cgi?id=66682
Reviewed by Adam Barth.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93522
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Mon, 22 Aug 2011 18:12:45 +0000 (18:12 +0000)]
Source/WebCore: Unload events can crash us when they blank out
a parent frame.
https://bugs.webkit.org/show_bug.cgi?id=64741
Reviewed by Adam Barth.
Test: fast/loader/document-destruction-within-unload.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading): Prevent unload events
from going into infinite recursion.
(WebCore::FrameLoader::setDocumentLoader): Ensure we don't
let set m_documentLoader to a DocumentLoader with a null Frame*.
(WebCore::FrameLoader::detachChildren): Save off a vector of
children to detach, rather than doing it inline.
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=64741.
Reviewed by Adam Barth.
* fast/loader/document-destruction-within-unload-expected.txt: Added.
* fast/loader/document-destruction-within-unload.html: Added.
* fast/loader/resources/document-destruction-within-unload-iframe.html: Added.
* fast/loader/resources/document-destruction-within-unload.svg: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93521
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Mon, 22 Aug 2011 18:07:22 +0000 (18:07 +0000)]
[chromium] Skip rtl-composited, as it causes other tests to crash.
Unreviewed expectation change.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93520
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 22 Aug 2011 18:06:00 +0000 (18:06 +0000)]
[Chromium] plugins/keyboard-events.html should pass on linux/mac
https://bugs.webkit.org/show_bug.cgi?id=65964
Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-22
Reviewed by Tony Chang.
Update the Chromium Linux test results following r88712. Also rebaseline test results
for Chromium Mac. Note the WebKit Mac and Win ports both report 0 for the line number
for all console.log() events. The Chromium port reports the actual line number, hence
the need for separate test results for Chromium. The test now runs, and passes on all
the Chromium ports, following r87855. The test confirms user-plugin interactivity, so
we don't regress sites like youtube.com. Refer to bug 34936.
* platform/chromium-linux/plugins/keyboard-events-expected.txt: Added.
* platform/chromium-mac/plugins/keyboard-events-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93519
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 22 Aug 2011 18:03:49 +0000 (18:03 +0000)]
Rebaseline for webkit bug 65295
https://bugs.webkit.org/show_bug.cgi?id=66637
Patch by Ben Wells <benwells@chromium.org> on 2011-08-22
Reviewed by Kenneth Russell.
* fast/box-shadow/box-shadow-radius-expected.txt: Renamed from LayoutTests/platform/gtk/fast/box-shadow/box-shadow-radius-expected.txt.
* fast/layers/self-painting-outline-expected.txt: Renamed from LayoutTests/platform/gtk/fast/layers/self-painting-outline-expected.txt.
* platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png:
* platform/chromium-win/fast/layers/self-painting-outline-expected.png:
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/box-shadow/box-shadow-radius-expected.png: Renamed from LayoutTests/fast/box-shadow/box-shadow-radius-expected.png.
* platform/mac/fast/layers/self-painting-outline-expected.txt: Removed.
* platform/qt/fast/layers/self-painting-outline-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93518
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 22 Aug 2011 18:00:59 +0000 (18:00 +0000)]
Patch by Young Han Lee <joybro@company100.net> on 2011-08-22
Reviewed by Dirk Schulze.
SVG animation fill="freeze" doesn't set baseVal to current animVal if animation stops before reaching the end
https://bugs.webkit.org/show_bug.cgi?id=63553
calculateAnimationPercentAndRepeat() is returning 1, which means 100%, whenever
elapsed >= m_intervalEnd, but this is wrong because m_intervalEnd can be in the middle
of the animation duration. (e.g. begin="0s" end="2s" dur="3s")
This change makes the function return the animations's true progress instead of 100%
when the animation ends.
Source/WebCore:
Test: svg/animations/animate-end-attribute.html
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):
LayoutTests:
* svg/animations/animate-end-attribute-expected.txt: Added.
* svg/animations/animate-end-attribute.html: Added.
* svg/animations/script-tests/animate-end-attribute.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93517
268f45cc-cd09-0410-ab3c-
d52691b4dbfc