WebKit-https.git
12 years ago2009-10-26 Yuzo Fujishima <yuzo@google.com>
eric@webkit.org [Mon, 26 Oct 2009 22:10:26 +0000 (22:10 +0000)]
2009-10-26  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Eric Seidel.

        Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.

        https://bugs.webkit.org/show_bug.cgi?id=30763

        * pywebsocket/mod_pywebsocket/__init__.py:
        * pywebsocket/mod_pywebsocket/dispatch.py:
        * pywebsocket/mod_pywebsocket/headerparserhandler.py:
        * pywebsocket/mod_pywebsocket/standalone.py:
        * pywebsocket/setup.py:
        * pywebsocket/test/test_dispatch.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-26 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 26 Oct 2009 22:04:00 +0000 (22:04 +0000)]
2009-10-26  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        Roll back r50073 because r50041-50043 were reverted.  r50073 was
        a chromium side fix for r50041.
        https://bugs.webkit.org/show_bug.cgi?id=30789

        * bindings/v8/V8Collection.h:
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
        (WebCore::getNamedItems):
        (WebCore::getItem):
        (WebCore::NAMED_PROPERTY_GETTER):
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
        (WebCore::getNamedItems):
        (WebCore::getItem):
        (WebCore::NAMED_PROPERTY_GETTER):
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Fixed https://bugs.webkit.org/show_bug.cgi?id=30765
ggaren@apple.com [Mon, 26 Oct 2009 22:02:47 +0000 (22:02 +0000)]
WebCore: Fixed https://bugs.webkit.org/show_bug.cgi?id=30765
REGRESSION (r48701): Removing an event listener causes the one added just after it not to fire

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-26
Reviewed by Dimitri Glazkov.

and related bugs.

If the event listener being removed is prior to the current firing event
iterator, we need to decrement the current firing event iterator in
addition to the endpoint. (Otherwise, shrinking the event listener vector
by one implicity moves the current firing event iterator forward by one.
It's like relativity, only without the planets.)

Also took the opportunity to change some pointers to references, since
they can't be null.

* dom/EventTarget.cpp:
(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::removeAllEventListeners): Update iterator in addition
to end, if need be.
(WebCore::EventTarget::fireEventListeners): Updated for interface changes.
Added a comment to explain a behavior that was implicit enough to be
confusing.

* dom/EventTarget.h:
(WebCore::FiringEventIterator::FiringEventIterator):
(WebCore::EventTarget::isFiringEventListeners): Updated for interface changes.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=30765
REGRESSION (r48701): Removing an event listener causes one added after it to not fire

Patch by Dimitri Glazkov <dglazkov@chromium.org> on 2009-10-26
Reviewed by Geoffrey Garen.

* fast/events/event-listener-list-mutation-expected.txt: Added.
* fast/events/event-listener-list-mutation.html: Added.
* fast/events/script-tests/event-listener-list-mutation.js: Added.
(TestMutation.listeners):
(TestMutation.mutateList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed documentation fix from David Boddie (Qt Doc Team)
kenneth@webkit.org [Mon, 26 Oct 2009 21:52:59 +0000 (21:52 +0000)]
Unreviewed documentation fix from David Boddie (Qt Doc Team)

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-26
Removes the check around the RenderHints property documentation
that was clearly added to synchronize the source and header files
when the #if !defined(Q_OS_SYMBIAN) guards was added to the
property.

The documentation has also been updated to ensure that Symbian
users know that there is no actual RenderHints property on their
platform.

* Api/qwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes <http://webkit.org/b/30792>.
bweinstein@apple.com [Mon, 26 Oct 2009 21:50:41 +0000 (21:50 +0000)]
Fixes <http://webkit.org/b/30792>.
Web Inspector: When changing resource scope, resource graph can get in weird state.

Reviewed by Timothy Hatcher.

If the user was scrolled down while looking at All resources, and then just
selects Fonts, or something that doesn't have many resources, then the graph
will stay scrolled down, even when there is no content there.

When the filter is updated, scroll to the top of the graph view, so this won't
happen.

* inspector/front-end/AbstractTimelinePanel.js:
(WebInspector.AbstractTimelinePanel.prototype._updateFilter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix mac clean build.
weinig@apple.com [Mon, 26 Oct 2009 21:46:02 +0000 (21:46 +0000)]
Fix mac clean build.

* html/HTMLOptionsCollection.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed documentation fix from David Boddie (Qt Doc Team)
kenneth@webkit.org [Mon, 26 Oct 2009 21:42:38 +0000 (21:42 +0000)]
Unreviewed documentation fix from David Boddie (Qt Doc Team)

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-26
Ensure that qdoc will always see the RenderHints property.

The property was only defined in the header file if the Q_OS_SYMBIAN
symbol was not defined, resulting in the property not showing up
in the Qt documentation just because one platform doesn't support it.

A follow up commit will improve the documentation for the property
and note that it is not supported on the Symbiam platform.

* Api/qwebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-26 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 26 Oct 2009 21:35:50 +0000 (21:35 +0000)]
2009-10-26  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Extract AbstractTimelinePanel that will be a base
        class for ResourcesPanel and TimelinePanel.

        https://bugs.webkit.org/show_bug.cgi?id=30776

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/AbstractTimelinePanel.js: Added.
        (WebInspector.AbstractTimelinePanel):
        (WebInspector.AbstractTimelinePanel.prototype.get categories):
        (WebInspector.AbstractTimelinePanel.prototype.showCategory):
        (WebInspector.AbstractTimelinePanel.prototype.hideCategory):
        (WebInspector.AbstractTimelinePanel.prototype.createTimelinePanels):
        (WebInspector.AbstractTimelinePanel.prototype._createFilterPanel.createFilterElement):
        (WebInspector.AbstractTimelinePanel.prototype._createFilterPanel):
        (WebInspector.AbstractTimelinePanel.prototype.filter):
        (WebInspector.AbstractTimelinePanel.prototype._updateFilter):
        (WebInspector.AbstractTimelinePanel.prototype._createGraph):
        (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
        (WebInspector.AbstractTimelinePanel.prototype._updateSummaryGraph):
        (WebInspector.AbstractTimelinePanel.prototype._updateDividersLabelBarPosition):
        (WebInspector.AbstractTimelinePanel.prototype.get needsRefresh):
        (WebInspector.AbstractTimelinePanel.prototype.set needsRefresh):
        (WebInspector.AbstractTimelinePanel.prototype.refreshIfNeeded):
        (WebInspector.AbstractTimelinePanel.prototype.show):
        (WebInspector.AbstractTimelinePanel.prototype.resize):
        (WebInspector.AbstractTimelinePanel.prototype.updateMainViewWidth):
        (WebInspector.TimelineCalculator):
        (WebInspector.TimelineCalculator.prototype.computeSummaryValues):
        (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
        (WebInspector.TimelineCalculator.prototype.computeBarGraphLabels):
        (WebInspector.TimelineCalculator.prototype.get boundarySpan):
        (WebInspector.TimelineCalculator.prototype.updateBoundaries):
        (WebInspector.TimelineCalculator.prototype.reset):
        (WebInspector.TimelineCalculator.prototype._value):
        (WebInspector.TimelineCalculator.prototype.formatValue):
        * inspector/front-end/ResourceCategory.js:
        (WebInspector.ResourceCategory):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel):
        (WebInspector.ResourcesPanel.prototype.toolbarItemClass.get toolbarItemLabel):
        (WebInspector.ResourcesPanel.prototype.get statusBarItems):
        (WebInspector.ResourcesPanel.prototype.get categories):
        (WebInspector.ResourcesPanel.prototype.showCategory):
        (WebInspector.ResourcesPanel.prototype.hideCategory):
        (WebInspector.ResourcesPanel.prototype.isCategoryVisible):
        (WebInspector.ResourcesPanel.prototype.populateSidebar):
        (WebInspector.ResourcesPanel.prototype.createPanelEnabler):
        (WebInspector.ResourcesPanel.prototype.createStatusbarButtons):
        (WebInspector.ResourcesPanel.prototype.set mainResourceLoadTime):
        (WebInspector.ResourcesPanel.prototype.set mainResourceDOMContentTime):
        (WebInspector.ResourcesPanel.prototype.show):
        (WebInspector.ResourcesPanel.prototype.resize):
        (WebInspector.ResourcesPanel.prototype.reset):
        (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded):
        (WebInspector.ResourcesPanel.prototype.updateMainViewWidth):
        (WebInspector.ResourceTimeCalculator):
        (WebInspector.ResourceTransferSizeCalculator):
        (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphLabels):
        * inspector/front-end/SummaryBar.js:
        (WebInspector.SummaryBar.prototype.update):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector.loaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-26 Avi Drissman <avi@google.com>
eric@webkit.org [Mon, 26 Oct 2009 21:09:55 +0000 (21:09 +0000)]
2009-10-26  Avi Drissman  <avi@google.com>

        Reviewed by Darin Adler.

        Use Helvetica in the Inspector as intended.
        https://bugs.webkit.org/show_bug.cgi?id=30787

        * inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-26 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 26 Oct 2009 21:05:55 +0000 (21:05 +0000)]
2009-10-26  Xan Lopez  <xlopez@igalia.com>

        Skip test fast/loader/opaque-base-url.html with a reference to the
        bug tracking it, https://bugs.webkit.org/show_bug.cgi?id=30724

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-26 Nate Chapin <japhet@chromium.org>
eric@webkit.org [Mon, 26 Oct 2009 21:02:10 +0000 (21:02 +0000)]
2009-10-26  Nate Chapin  <japhet@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Update no-referrer-reset for https://bugs.webkit.org/show_bug.cgi?id=30781.

        * http/tests/navigation/no-referrer-reset-expected.txt: Expect window.opener to still be set.
        * http/tests/navigation/no-referrer-reset.html: Update text to reflect what the test actually does.
2009-10-26  Nate Chapin  <japhet@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Don't set window.opener to 0 for the current FrameLoader if a noreferrer link was clicked, only suppress opener in a new frame.
        https://bugs.webkit.org/show_bug.cgi?id=30781

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::urlSelected): Don't suppress opener in the current frame for noreferrer navigations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-26 Carol Szabo <carol.szabo@nokia.com>
eric@webkit.org [Mon, 26 Oct 2009 20:53:44 +0000 (20:53 +0000)]
2009-10-26  Carol Szabo  <carol.szabo@nokia.com>

        Reviewed by David Levin.

        REGRESSION: 2 failures in run-webkit-unittests
        https://bugs.webkit.org/show_bug.cgi?id=30645

        * Scripts/modules/cpp_style_unittest.py:
        Fixed a few test scenarios which apparently lost some spaces from
        text literals.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoData loss occurs when unbolding nested bold tags.
rniwa@webkit.org [Mon, 26 Oct 2009 20:48:55 +0000 (20:48 +0000)]
Data loss occurs when unbolding nested bold tags.
https://bugs.webkit.org/show_bug.cgi?id=30083

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-26
Reviewed by Eric Seidel.

WebCore:

Fixes the loop in swapInNodePreservingAttributesAndChildren by saving nextSibling() of child
to a temporary valuable.  It was originally calling nextSibling() after appending the child
to new parent, in which case, nextSibling is always 0.

Test: editing/style/unbolding-nested-b.html

* editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):

LayoutTests:

Adds a test to make sure WebKit can remove nested b, i, & s tags properly
without loosing the content of inner elements.

* editing/style/remove-nested-inline-styles-expected.txt: Added.
* editing/style/remove-nested-inline-styles.html: Added.
* editing/style/script-tests/remove-nested-inline-styles.js: Added.
(removeStyleAndExpect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Jan Alonzo.
kov@webkit.org [Mon, 26 Oct 2009 20:16:59 +0000 (20:16 +0000)]
Reviewed by Jan Alonzo.

Alternative solution to regression introduced in r48672.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-21 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Mon, 26 Oct 2009 20:11:41 +0000 (20:11 +0000)]
2009-10-21  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Adler.

        Storage events should use Document::url() rather than documentURI()
        https://bugs.webkit.org/show_bug.cgi?id=30535

        Storage events should use Document::url() rather than Document::documentURI()
        per http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-October/023703.html

        Test: storage/domstorage/documentURI.html

        * storage/StorageEventDispatcher.cpp:
        (WebCore::StorageEventDispatcher::dispatch):
2009-10-26  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Darin Adler.

        Rollout r50041-50043.  The HTML5 spec changed to make HTMLOptionsCollection
        inherit from HTMLCollection.

        * fast/dom/wrapper-classes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by Darin Adler.
weinig@apple.com [Mon, 26 Oct 2009 20:04:22 +0000 (20:04 +0000)]
Rubber-stamped by Darin Adler.

Rollout r50041-50043.  The HTML5 spec changed to make HTMLOptionsCollection
inherit from HTMLCollection.

WebCore:

* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::callHTMLCollection):
(WebCore::JSHTMLCollection::nameGetter):
(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):
(WebCore::toJS):
* bindings/js/JSHTMLCollectionFunctions.h: Removed.
* bindings/js/JSHTMLDocumentCustom.cpp:
* bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::JSHTMLOptionsCollection::length):
(WebCore::JSHTMLOptionsCollection::indexSetter):
* bindings/objc/DOMHTML.mm:
(kitClass):
* bindings/objc/DOMUtility.mm:
(JSC::createDOMWrapper):
* bindings/scripts/CodeGeneratorJS.pm:
* html/HTMLCollection.idl:
* html/HTMLOptionsCollection.idl:

WebKit/win:

* DOMCreateInstance.cpp:

LayoutTests:

* fast/dom/wrapper-classes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
kevino@webkit.org [Mon, 26 Oct 2009 19:46:34 +0000 (19:46 +0000)]
wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix for ENABLE_FILTERS under Windows.
bfulgham@webkit.org [Mon, 26 Oct 2009 19:34:45 +0000 (19:34 +0000)]
Build fix for ENABLE_FILTERS under Windows.
https://bugs.webkit.org/show_bug.cgi?id=30762

Reviewed by Adam Roben.

Build correction for ENABLE_FILTERS feature.  No new tests needed.

* WebCore.vcproj/WebCore.vcproj:  Make the following changes:
  (1) Create a new 'filters' sub-folder of the platform/graphics
      folder to properly show the sources held in this directory.
  (2) Move the files that are currently shown in svn/graphics/filters
      to platform/graphics/filters (where they actually live on disk).
  (3) Add the missing SVGFilter, SVGFilterBuilder, and SVGFETile to
      the project so they are built.
  (4) Remove SVGFEFloodElement.cpp from the build, since it is already
      being compiled by SVGAllInOne.cpp.  Its presence as a separate
      entity is causing a linker warning for duplicate symbols.
  (5) Add ImageBuffer.cpp to the build to support color space
      calculations for non-CG builds.
* WebCore.vcproj/WebCoreCommon.vsprops: Add the platform/graphics/filters
  path to the search paths in the project.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-26 Keishi Hattori <casey.hattori@gmail.com>
eric@webkit.org [Mon, 26 Oct 2009 19:30:58 +0000 (19:30 +0000)]
2009-10-26  Keishi Hattori  <casey.hattori@gmail.com>

        Reviewed by Timothy Hatcher.

        console.assert should prefix messages with "Assertion failed: "
        https://bugs.webkit.org/show_bug.cgi?id=19135

        * English.lproj/localizedStrings.js:
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleMessage.prototype.toMessageElement): Append "Assertion failed: " for AssertMessageType.
        (WebInspector.ConsoleMessage.prototype.toString):
        * page/Console.cpp:
        (WebCore::Console::assertCondition): Use AssertMessageType.
        * page/Console.h:
        (WebCore::MessageType): Added AssertMessageType.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-26 Rahul Kuchhal <kuchhal@chromium.org>
eric@webkit.org [Mon, 26 Oct 2009 19:19:58 +0000 (19:19 +0000)]
2009-10-26  Rahul Kuchhal  <kuchhal@chromium.org>

        Reviewed by Eric Seidel.

        Prevent crash when optgroup element is empty.

        https://bugs.webkit.org/show_bug.cgi?id=30365

        * fast/forms/select-empty-optgroup-expected.txt: Added.
        * fast/forms/select-empty-optgroup.html: Added.
2009-10-26  Rahul Kuchhal  <kuchhal@chromium.org>

        Reviewed by Eric Seidel.

        Prevent crash when optgroup element is empty by adding a NULL check.

        https://bugs.webkit.org/show_bug.cgi?id=30365

        Test: fast/forms/select-empty-optgroup.html

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::appendFormData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-21 Steven Knight <sgk@chromium.org>
tony@chromium.org [Mon, 26 Oct 2009 19:11:37 +0000 (19:11 +0000)]
2009-10-21  Steven Knight  <sgk@chromium.org>

        Reviewed by David Levin.

        Refactor gyp for separate webcore_bindings{,_sources} targets.

        https://bugs.webkit.org/show_bug.cgi?id=30447

        Handle long link lines by building .idl-generated bindings in a
        separate webcore_bindings library target.  Avoid Visual Studio
        dependency issues by building additional generated .cpp and .h files
        in a separate webcore_bindings_sources target.

        Chrome should still build and test successfully.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnification of using null device in perl scripts.
ossy@webkit.org [Mon, 26 Oct 2009 18:57:21 +0000 (18:57 +0000)]
Unification of using null device in perl scripts.
https://bugs.webkit.org/show_bug.cgi?id=30572

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-26
Reviewed by Darin Adler.

* Scripts/VCSUtils.pm:
* Scripts/bisect-builds:
* Scripts/resolve-ChangeLogs:
* Scripts/run-iexploder-tests:
* Scripts/run-jsc:
* Scripts/run-mangleme-tests:
* Scripts/run-webkit-tests:
* Scripts/webkitdirs.pm:
Using File::Spec->devnull() instead of hard coded /dev/null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-26 Mike Belshe <mike@belshe.com>
eric@webkit.org [Mon, 26 Oct 2009 18:40:45 +0000 (18:40 +0000)]
2009-10-26  Mike Belshe  <mike@belshe.com>

        Reviewed by Darin Fisher.

        Make the number of connections for chromium controlled by
        chromium rather than by ResourceRequestBase.
        https://bugs.webkit.org/show_bug.cgi?id=30661

        * platform/network/ResourceRequestBase.cpp:
        * platform/network/chromium/ResourceRequest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 26 Oct 2009 18:38:33 +0000 (18:38 +0000)]
2009-10-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Holger Freyther.

        Reviewers are missing from committers.py
        https://bugs.webkit.org/show_bug.cgi?id=30733

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-23 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 26 Oct 2009 18:33:50 +0000 (18:33 +0000)]
2009-10-23  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Roben.

        PrettyPatch should show images even when they have the wrong mime type
        https://bugs.webkit.org/show_bug.cgi?id=29506

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed typo fix.
ossy@webkit.org [Mon, 26 Oct 2009 17:54:28 +0000 (17:54 +0000)]
Unreviewed typo fix.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-26
* platform/qt/Skipped: shared-workers-close.html replaced with shared-worker-close.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed. make distcheck build fixes.
kov@webkit.org [Mon, 26 Oct 2009 17:45:02 +0000 (17:45 +0000)]
Unreviewed. make distcheck build fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed. Fix make dist regression introduced by r48672.
kov@webkit.org [Mon, 26 Oct 2009 17:44:47 +0000 (17:44 +0000)]
Unreviewed. Fix make dist regression introduced by r48672.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-26 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Mon, 26 Oct 2009 17:35:16 +0000 (17:35 +0000)]
2009-10-26  Anton Muhin  <antonm@chromium.org>

        Reviewed by Dimitri Glazkov.

        Unbreak Chromium build: that requires adding custom implementations
        for HTMLOptionsCollection's item and namedItem.  Keep v8 binding
        close to JSC bindings as well.
        https://bugs.webkit.org/show_bug.cgi?id=30780

        * bindings/v8/V8Collection.h:
        (WebCore::getNamedItemsFromCollection):
        (WebCore::getItemFromCollection):
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
        (WebCore::NAMED_PROPERTY_GETTER):
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
        (WebCore::NAMED_PROPERTY_GETTER):
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Barth and Darin Adler.
ap@apple.com [Mon, 26 Oct 2009 17:26:26 +0000 (17:26 +0000)]
    Reviewed by Adam Barth and Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=30723
        <rdar://problem/6189415> Input names added to multipart/form-data headers need to be escaped.

        Test: http/tests/security/escape-form-data-field-names.html

        * platform/network/FormDataBuilder.cpp:
        (WebCore::appendQuotedString):
        (WebCore::FormDataBuilder::beginMultiPartHeader):
        (WebCore::FormDataBuilder::addFilenameToMultiPartHeader):
        Percent-escape line breaks and quotation marks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Skip two flakey tests because of sporadic timeouts.
ossy@webkit.org [Mon, 26 Oct 2009 17:10:26 +0000 (17:10 +0000)]
[Qt] Skip two flakey tests because of sporadic timeouts.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Skipping two other tests because of missing features on our platform.
ossy@webkit.org [Mon, 26 Oct 2009 17:06:01 +0000 (17:06 +0000)]
[Qt] Skipping two other tests because of missing features on our platform.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Add platform-dependent expected file for test added in r49875.
ossy@webkit.org [Mon, 26 Oct 2009 17:00:57 +0000 (17:00 +0000)]
[Qt] Add platform-dependent expected file for test added in r49875.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.

* platform/qt/fast/css/getComputedStyle/marginComputedStyle-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-26 Kelly Norton <knorton@google.com>
eric@webkit.org [Mon, 26 Oct 2009 16:46:48 +0000 (16:46 +0000)]
2009-10-26  Kelly Norton  <knorton@google.com>

        Reviewed by Pavel Feldman.

        Adds DOMTimer support to InspectorTimelineAgent.
        https://bugs.webkit.org/show_bug.cgi?id=30467

        * inspector/InspectorTimelineAgent.cpp: Added timer support and fixed some method names.
        (WebCore::InspectorTimelineAgent::didDispatchDOMEvent):
        (WebCore::InspectorTimelineAgent::didLayout):
        (WebCore::InspectorTimelineAgent::didRecalculateStyle):
        (WebCore::InspectorTimelineAgent::didPaint):
        (WebCore::InspectorTimelineAgent::didWriteHTML):
        (WebCore::InspectorTimelineAgent::didInstallTimer): Added.
        (WebCore::InspectorTimelineAgent::didRemoveTimer): Added.
        (WebCore::InspectorTimelineAgent::willFireTimer): Added.
        (WebCore::InspectorTimelineAgent::didFireTimer): Added.
        (WebCore::InspectorTimelineAgent::addItemToTimeline): Added.
        (WebCore::InspectorTimelineAgent::didCompleteCurrentTimelineItem): Renamed.
        * inspector/InspectorTimelineAgent.h:
        (WebCore::):
        * inspector/TimelineItemFactory.cpp: Add methods for timer-related ScriptObjects.
        (WebCore::TimelineItemFactory::createGenericTimerTimelineItem):
        (WebCore::TimelineItemFactory::createTimerInstallTimelineItem):
        * inspector/TimelineItemFactory.h:
        * page/DOMTimer.cpp: Added instrumentation points.
        (WebCore::DOMTimer::install):
        (WebCore::DOMTimer::removeById):
        (WebCore::DOMTimer::fired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-26 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 26 Oct 2009 16:31:49 +0000 (16:31 +0000)]
2009-10-26  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/6988966> Hardware layers do not show up in page snapshots

        * WebView/WebHTMLViewPrivate.h:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _compositingLayersHostingView]):
        Add a private method that returns the NSView used to host compositing layers.

        * platform/graphics/mac/Canvas3DLayer.h:
        * platform/graphics/mac/Canvas3DLayer.mm:
        (-[Canvas3DLayer copyImageSnapshotWithColorSpace:]):
        Add a method that gets called when snapshotting Canvas3DLayers for page snapshots,
        that allows the layer to return a CGImageRef of its contents.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Update outdated expected files which expected wrong color values.
ossy@webkit.org [Mon, 26 Oct 2009 16:22:46 +0000 (16:22 +0000)]
[Qt] Update outdated expected files which expected wrong color values.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.

* platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-26 Yury Semikhatsky <yurys@chromium.org>
eric@webkit.org [Mon, 26 Oct 2009 16:17:31 +0000 (16:17 +0000)]
2009-10-26  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Pass "console" as object group when evaluating selection.

        https://bugs.webkit.org/show_bug.cgi?id=30738

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-26 Keishi Hattori <casey.hattori@gmail.com>
eric@webkit.org [Mon, 26 Oct 2009 16:10:06 +0000 (16:10 +0000)]
2009-10-26  Keishi Hattori  <casey.hattori@gmail.com>

        Reviewed by Pavel Feldman.

        Fix for Console not showing repeat count when repeatedly logging an Event
        https://bugs.webkit.org/show_bug.cgi?id=30324

        * inspector/console-tests-expected.txt:
2009-10-26  Keishi Hattori  <casey.hattori@gmail.com>

        Reviewed by Pavel Feldman.

        Fix for Console not showing repeat count when repeatedly logging an Event
        https://bugs.webkit.org/show_bug.cgi?id=30324

        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::addToConsole):
        (WebCore::ConsoleMessage::updateRepeatCountInConsole): Added.
        * inspector/ConsoleMessage.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::addConsoleMessage): Calls updateRepeatCountInConsole if it is a repeating message.
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::addConsoleMessage): Renamed WebCore::InspectorFrontend::addMessageToConsole
        (WebCore::InspectorFrontend::updateConsoleMessageRepeatCount): Added. Called when repeatCount is incremented.
        * inspector/InspectorFrontend.h:
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.addMessage): Removed calls to msg.isEqual.
        (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): Added.
        (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): Added. Updates the error/warning count.
        (WebInspector.ConsoleView.prototype.clearMessages):
        (WebInspector.ConsoleMessage):
        (WebInspector.ConsoleMessage.prototype.toMessageElement): Use ConsoleMessage._updateRepeatCount
        (WebInspector.ConsoleMessage.prototype._updateRepeatCount):
        * inspector/front-end/inspector.js:
        (WebInspector.addConsoleMessage): Renamed WebInspector.addMessageToConsole.
        (WebInspector.updateConsoleMessageRepeatCount): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-26 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 26 Oct 2009 15:27:57 +0000 (15:27 +0000)]
2009-10-26  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Eric Seidel.

        Remove HTML5 media element 'load' event
        https://bugs.webkit.org/show_bug.cgi?id=30464

        Part 1, change layout tests to not use the event.

        * media/audio-constructor-autobuffer-expected.txt:
        * media/audio-constructor-autobuffer.html:
        * media/audio-constructor-expected.txt:
        * media/audio-constructor-src-expected.txt:
        * media/audio-constructor-src.html:
        * media/audio-constructor.html:
        * media/audio-controls-rendering.html:
        * media/audio-data-url-expected.txt:
        * media/audio-data-url.html:
        * media/audio-mpeg-supported-expected.txt:
        * media/audio-mpeg-supported.html:
        * media/media-load-event-expected.txt:
        * media/media-load-event.html:
        * media/progress-event-expected.txt:
        * media/progress-event-total-expected.txt:
        * media/progress-event-total.html:
        * media/progress-event.html:
        * media/remove-from-document-expected.txt:
        * media/remove-from-document-no-load-expected.txt:
        * media/remove-from-document-no-load.html:
        * media/remove-from-document.html:
        * media/restore-from-page-cache-expected.txt:
        * media/restore-from-page-cache.html:
        * media/video-append-source-expected.txt:
        * media/video-append-source.html:
        * media/video-buffered-expected.txt:
        * media/video-buffered.html:
        * media/video-canvas-source-expected.txt:
        * media/video-canvas-source.html:
        * media/video-controls-expected.txt:
        * media/video-controls-transformed-expected.txt:
        * media/video-controls-transformed.html:
        * media/video-controls-zoomed-expected.txt:
        * media/video-controls-zoomed.html:
        * media/video-controls.html:
        * media/video-currentTime-expected.txt:
        * media/video-currentTime-set-expected.txt:
        * media/video-currentTime-set.html:
        * media/video-currentTime-set2-expected.txt:
        * media/video-currentTime-set2.html:
        * media/video-currentTime.html:
        * media/video-dom-src-expected.txt:
        * media/video-dom-src.html:
        * media/video-error-abort-expected.txt:
        * media/video-error-abort.html:
        * media/video-error-does-not-exist.html:
        * media/video-muted-expected.txt:
        * media/video-muted.html:
        * media/video-no-autoplay-expected.txt:
        * media/video-no-autoplay.html:
        * media/video-seek-past-end-paused-expected.txt:
        * media/video-seek-past-end-paused.html:
        * media/video-seek-past-end-playing-expected.txt:
        * media/video-seek-past-end-playing.html:
        * media/video-seekable-expected.txt:
        * media/video-seekable.html:
        * media/video-seeking-expected.txt:
        * media/video-seeking.html:
        * media/video-src-change-expected.txt:
        * media/video-src-change.html:
        * media/video-volume-expected.txt:
        * media/video-volume.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agocrash with AX on when an image map contains an anchor tag
cfleizach@apple.com [Mon, 26 Oct 2009 14:49:50 +0000 (14:49 +0000)]
crash with AX on when an image map contains an anchor tag
https://bugs.webkit.org/show_bug.cgi?id=30739

Reviewed by Darin Adler.

WebCore:

Tests: accessibility/crashing-a-tag-in-map.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::addChildren):

LayoutTests:

* accessibility/crashing-a-tag-in-map-expected.txt: Added.
* accessibility/crashing-a-tag-in-map.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 26 Oct 2009 13:51:29 +0000 (13:51 +0000)]
2009-10-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed. Update documentation control files for 1.1.16.

        * docs/webkitgtk-docs.sgml:
        * docs/webkitgtk-sections.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Xan Lopez.
kov@webkit.org [Mon, 26 Oct 2009 13:49:48 +0000 (13:49 +0000)]
Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30759
[GTK] Should use WebKitNetworkResponse, and expose it

WebKitDownload now uses our WebKitNetworkResponse instead of using
ResourceResponse directly. By exposing the response, like we do
with the request, we give our users the ability to look at the
response headers, status code, and so on, through the SoupMessage
object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-26 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 26 Oct 2009 13:25:11 +0000 (13:25 +0000)]
2009-10-26  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Update for 1.1.16 release.

        * configure.ac:

WebKit/gtk:

2009-10-26  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Update for 1.1.16 release.

        * NEWS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-26 Benjamin Poulain <benjamin.poulain@nokia.com>
eric@webkit.org [Mon, 26 Oct 2009 13:06:03 +0000 (13:06 +0000)]
2009-10-26  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Reintroduce QWebElementCollection

        Revert the patch that has replaced QWebElementCollection
        with QList<QWebElement>. Update the tests accordingly.

        Remove the constness of the return type of QWebElement operator[].

        https://bugs.webkit.org/show_bug.cgi?id=30767

        * Api/qwebelement.cpp:
        (QWebElement::findAll):
        (QWebElementCollectionPrivate::QWebElementCollectionPrivate):
        (QWebElementCollectionPrivate::create):
        (QWebElementCollection::QWebElementCollection):
        (QWebElementCollection::operator=):
        (QWebElementCollection::~QWebElementCollection):
        (QWebElementCollection::operator+):
        (QWebElementCollection::append):
        (QWebElementCollection::count):
        (QWebElementCollection::at):
        (QWebElementCollection::toList):
        * Api/qwebelement.h:
        (const_iterator::begin):
        (const_iterator::end):
        (const_iterator::operator[]):
        * Api/qwebframe.cpp:
        (QWebFrame::findAllElements):
        * Api/qwebframe.h:
        * QtLauncher/main.cpp:
        (MainWindow::selectElements):
        * tests/qwebelement/tst_qwebelement.cpp:
        (tst_QWebElement::simpleCollection):
        (tst_QWebElement::iteration):
        (tst_QWebElement::emptyCollection):
        (tst_QWebElement::appendCollection):
        (tst_QWebElement::nullSelect):
        (tst_QWebElement::hasSetFocus):
        (tst_QWebElement::render):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::inputMethods):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdds feature ENABLE guards to V8 bindings.
benm@google.com [Mon, 26 Oct 2009 12:44:53 +0000 (12:44 +0000)]
Adds feature ENABLE guards to V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=30697

Patch by Steve Block <steveblock@google.com> on 2009-10-26
Reviewed by Eric Seidel.

This adds guards for the following features to the V8 bindings,
to allow builds with V8 to succeed when these features are not enabled.
- DATABASE
- WORKERS
- SHARED_WORKERS
- SVG
- XPATH
- XSLT
- INSPECTOR

This is a build fix only, no new tests required.

* bindings/v8/DOMObjectsInclude.h: Modified.
* bindings/v8/DerivedSourcesAllInOne.cpp: Modified.
* bindings/v8/V8Index.cpp: Modified.
* bindings/v8/V8Index.h: Modified.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by Tor Arne Vestbø.
ossy@webkit.org [Mon, 26 Oct 2009 12:32:10 +0000 (12:32 +0000)]
Rubber-stamped by Tor Arne Vestbø.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-26
http/tests/cookies/simple-cookies-max-age.html moved to flakey tests group.
http/tests/xmlhttprequest/workers/close.html added to flakey tests group.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed trivial fix for r49854.
ossy@webkit.org [Mon, 26 Oct 2009 11:58:58 +0000 (11:58 +0000)]
Unreviewed trivial fix for r49854.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-26
* platform/qt/Skipped: Missing html extension added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-26 Joanmarie Diggs <joanmarie.diggs@gmail.com>
eric@webkit.org [Mon, 26 Oct 2009 11:42:42 +0000 (11:42 +0000)]
2009-10-26  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=25679
        [Gtk] Improve accessibility of focusable lists

        Fixes the issues with the Atk states exposed for ListBoxOption

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (setAtkStateSetFromCoreObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-26 Joanmarie Diggs <joanmarie.diggs@gmail.com>
eric@webkit.org [Mon, 26 Oct 2009 11:35:25 +0000 (11:35 +0000)]
2009-10-26  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=27085
        [Gtk] Incorrect rendering of list

        Adds a way for platforms to indicate that a particular object
        should not be ignored.

        * accessibility/AccessibilityObject.h:
        * accessibility/chromium/AccessibilityObjectChromium.cpp:
        * accessibility/gtk/AccessibilityObjectAtk.cpp:
        * accessibility/mac/AccessibilityObjectMac.mm:
        * accessibility/qt/AccessibilityObjectQt.cpp:
        * accessibility/win/AccessibilityObjectWin.cpp:
        * accessibility/wx/AccessibilityObjectWx.cpp:
        (AccessibilityObject::accessibilityPlatformIncludesObject):
        * accessibility/AccessibilityRenderObject.cpp:
        (AccessibilityRenderObject::accessibilityIsIgnored):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-26 Steve Block <steveblock@google.com>
eric@webkit.org [Mon, 26 Oct 2009 10:46:55 +0000 (10:46 +0000)]
2009-10-26  Steve Block  <steveblock@google.com>

        Reviewed by Darin Adler.

        Adds ability to disable ReadWriteLock on platforms (eg Android) that use pthreads but do not support pthread_rwlock.
        https://bugs.webkit.org/show_bug.cgi?id=30713

        * wtf/Platform.h: Modified. Defines HAVE_PTHREAD_RWLOCK for all platforms currently using pthreads.
        * wtf/Threading.h: Modified. Use pthread_rwlock_t only when HAVE_PTHREAD_RWLOCK is defined.
        * wtf/ThreadingPthreads.cpp: Modified. Build ReadWriteLock methods only when HAVE_PTHREAD_RWLOCK is defined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-26 Kinuko Yasuda <kinuko@google.com>
eric@webkit.org [Mon, 26 Oct 2009 10:29:21 +0000 (10:29 +0000)]
2009-10-26  Kinuko Yasuda  <kinuko@google.com>

        Reviewed by Jan Alonzo.

        Bug 30619: [Linux] Menu key doesn't work
        https://bugs.webkit.org/show_bug.cgi?id=30619

        Test: manual-tests/keyboard-menukey-event.html
        No new layout tests: testing this will require changes in the test
        controller in a platform-specific way.

        * platform/chromium/KeyCodeConversionGtk.cpp:
        (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for
        GDK_Menu to return VKEY_APPS instead of VKEY_MENU.
        * platform/gtk/KeyEventGtk.cpp:
        (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for
        GDK_Menu to return V_APPS instead of VK_MENU.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-26 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Mon, 26 Oct 2009 10:07:59 +0000 (10:07 +0000)]
2009-10-26  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Gustavo Noronha.

        [Gtk] Reenable mod_rewrite in Fedora's httpd.conf
        https://bugs.webkit.org/show_bug.cgi?id=30741

        * http/conf/fedora-httpd.conf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-25 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Mon, 26 Oct 2009 04:33:02 +0000 (04:33 +0000)]
2009-10-25  Anton Muhin  <antonm@chromium.org>

        Reviewed by Adam Barth.

        Reuse already fetched proxy.
        https://bugs.webkit.org/show_bug.cgi?id=30747

        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::convertNewNodeToV8Object):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 26 Oct 2009 00:45:37 +0000 (00:45 +0000)]
2009-10-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed. Rebaseline test after 49998.

        * platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-25 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Sun, 25 Oct 2009 22:39:45 +0000 (22:39 +0000)]
2009-10-25  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed build fix.

        Build fix for WIN_OS if Netscape plugin support is turned off
        https://bugs.webkit.org/show_bug.cgi?id=30753

        * plugins/PluginDatabase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-25 Hironori Bono <hbono@chromium.org>
eric@webkit.org [Sun, 25 Oct 2009 20:15:56 +0000 (20:15 +0000)]
2009-10-25  Hironori Bono  <hbono@chromium.org>

        Reviewed by Darin Adler.

        A quick fix for Bug 29103.
        Since String::startsWith() cannot fold non-ASCII characters, this change folds the prefix string
        and the option string before calling String::startsWith().
        https://bugs.webkit.org/show_bug.cgi?id=29103

        * fast/forms/listbox-typeahead-cyrillic-expected.txt: Added.
        * fast/forms/listbox-typeahead-cyrillic.html: Added.
        * fast/forms/listbox-typeahead-greek-expected.txt: Added.
        * fast/forms/listbox-typeahead-greek.html: Added.
2009-10-25  Hironori Bono  <hbono@chromium.org>

        Reviewed by Darin Adler.

        A quick fix for Bug 29103.
        Since String::startsWith() cannot fold non-ASCII characters, this change folds the prefix string
        and the option string before calling String::startsWith().
        https://bugs.webkit.org/show_bug.cgi?id=29103

        Tests: fast/forms/listbox-typeahead-cyrillic.html
               fast/forms/listbox-typeahead-greek.html

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::typeAheadFind):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd contextForWorldID to the IWebFramePrivate interface.
mitz@apple.com [Sun, 25 Oct 2009 17:28:10 +0000 (17:28 +0000)]
Add contextForWorldID to the IWebFramePrivate interface.

Reviewed by John Sullivan.

* Interfaces/IWebFramePrivate.idl:
* WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-25 Keishi Hattori <casey.hattori@gmail.com>
eric@webkit.org [Sun, 25 Oct 2009 08:54:45 +0000 (08:54 +0000)]
2009-10-25  Keishi Hattori  <casey.hattori@gmail.com>

        Reviewed by Timothy Hatcher.

        Web Inspector: Expanding a node in the Console should not show the element in Elements panel
        https://bugs.webkit.org/show_bug.cgi?id=30749

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype.onmousedown): Check if inside disclosure triangle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAnother try at fixing windows.
weinig@apple.com [Sun, 25 Oct 2009 08:22:01 +0000 (08:22 +0000)]
Another try at fixing windows.

* DOMCreateInstance.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTouch WebKit.idl in an effort to try and regenerate the COM bindings.
weinig@apple.com [Sun, 25 Oct 2009 07:52:57 +0000 (07:52 +0000)]
Touch WebKit.idl in an effort to try and regenerate the COM bindings.

* Interfaces/WebKit.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=30751
weinig@apple.com [Sun, 25 Oct 2009 07:52:10 +0000 (07:52 +0000)]
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection

Reviewed by Dan Bernstein.

* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Added JSHTMLCollectionFunctions.h

* bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::callHTMLCollection):
(WebCore::JSHTMLCollection::nameGetter):
(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):
* bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::callHTMLCollection):
(WebCore::JSHTMLOptionsCollection::getCallData):
(WebCore::JSHTMLOptionsCollection::canGetItemsForName):
(WebCore::JSHTMLOptionsCollection::nameGetter):
(WebCore::JSHTMLOptionsCollection::indexSetter):
(WebCore::JSHTMLOptionsCollection::item):
(WebCore::JSHTMLOptionsCollection::namedItem):
Refactor to use generic implementation of HTMLCollection bindings functions
from JSHTMLCollectionFunctions.h

* bindings/js/JSHTMLCollectionFunctions.h: Added.
(WebCore::getCollectionNamedItems):
(WebCore::getCollectionItems):
(WebCore::callHTMLCollectionGeneric):
Added generic functions that JSHTMLCollection, JSHTMLAllCollection and
JSHTMLOptionsCollection can all use.

* bindings/js/JSHTMLDocumentCustom.cpp: Add include of JSHTMLAllCollection.h
for toJS on document.all.

* bindings/objc/DOMHTML.mm:
* bindings/objc/DOMUtility.mm:
(JSC::createDOMWrapper):
Remove special cases for HTMLOptionsCollection.

* bindings/scripts/CodeGeneratorJS.pm:
* html/HTMLAllCollection.idl:
* html/HTMLCollection.idl:
* html/HTMLOptionsCollection.idl:

LayoutTests: Update tests for https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection

Reviewed by Dan Bernstein.

* fast/dom/wrapper-classes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRoll out r50037 as it broke the Windows build.
bweinstein@apple.com [Sun, 25 Oct 2009 07:08:03 +0000 (07:08 +0000)]
Roll out r50037 as it broke the Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebInspector: Fixed issue with IME inside console
timothy@apple.com [Sun, 25 Oct 2009 04:56:40 +0000 (04:56 +0000)]
WebInspector: Fixed issue with IME inside console
https://bugs.webkit.org/show_bug.cgi?id=30660

Patch by Keishi Hattori <casey.hattori@gmail.com> on 2009-10-24
Reviewed by Timothy Hatcher.

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._promptKeyDown):
* inspector/front-end/DatabaseQueryView.js:
(WebInspector.DatabaseQueryView.prototype._promptKeyDown):
* inspector/front-end/inspector.js:
(WebInspector.loaded):
(WebInspector.searchKeyDown): Moved performSearch here from WebInspector.searchKeyUp.
(WebInspector.startEditing.element.handleKeyEvent):
(WebInspector.startEditing):
* inspector/front-end/utilities.js:
(isEnterKey): Added. Check if in IME.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes <https://bugs.webkit.org/show_bug.cgi?id=30752>.
bweinstein@apple.com [Sun, 25 Oct 2009 04:13:13 +0000 (04:13 +0000)]
Fixes <https://bugs.webkit.org/show_bug.cgi?id=30752>.
Web Inspector: Multiple Selection on Scope Bars by default Conflicts with other behavior on OSX.

Reviewed by Timothy Hatcher.

Have the scope bars select one scope by default, but if the multiple selection key
is pressed, allow for multiple selection.

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
(WebInspector.ConsoleView.prototype._updateFilter):
(WebInspector.ConsoleView.prototype.filter):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.filter):
(WebInspector.ResourcesPanel.prototype._updateFilter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=30751
weinig@apple.com [Sun, 25 Oct 2009 02:44:50 +0000 (02:44 +0000)]
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection

Reviewed by Dan Bernstein.

* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Added JSHTMLCollectionFunctions.h

* bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::callHTMLCollection):
(WebCore::JSHTMLCollection::nameGetter):
(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):
* bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::callHTMLCollection):
(WebCore::JSHTMLOptionsCollection::getCallData):
(WebCore::JSHTMLOptionsCollection::canGetItemsForName):
(WebCore::JSHTMLOptionsCollection::nameGetter):
(WebCore::JSHTMLOptionsCollection::indexSetter):
(WebCore::JSHTMLOptionsCollection::item):
(WebCore::JSHTMLOptionsCollection::namedItem):
Refactor to use generic implementation of HTMLCollection bindings functions
from JSHTMLCollectionFunctions.h

* bindings/js/JSHTMLCollectionFunctions.h: Added.
(WebCore::getCollectionNamedItems):
(WebCore::getCollectionItems):
(WebCore::callHTMLCollectionGeneric):
Added generic functions that JSHTMLCollection, JSHTMLAllCollection and
JSHTMLOptionsCollection can all use.

* bindings/js/JSHTMLDocumentCustom.cpp: Add include of JSHTMLAllCollection.h
for toJS on document.all.

* bindings/objc/DOMHTML.mm:
* bindings/objc/DOMUtility.mm:
(JSC::createDOMWrapper):
Remove special cases for HTMLOptionsCollection.

* bindings/scripts/CodeGeneratorJS.pm:
* html/HTMLAllCollection.idl:
* html/HTMLCollection.idl:
* html/HTMLOptionsCollection.idl:

LayoutTests: Update tests for https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection

Reviewed by Dan Bernstein.

* fast/dom/wrapper-classes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake the scope bars in the Web Inspector match other scope bars in Mac OS X.
timothy@apple.com [Sat, 24 Oct 2009 23:08:27 +0000 (23:08 +0000)]
Make the scope bars in the Web Inspector match other scope bars in Mac OS X.
Also cleans up the CSS to use classes instead of ID selectors.

https://bugs.webkit.org/show_bug.cgi?id=28186

Reviewed by Dan Bernstein.

* inspector/front-end/ResourcesPanel.js: Add the scope-bar class.
* inspector/front-end/inspector.css: Lots of changes to make it look right.
* inspector/front-end/inspector.html: Add the scope-bar class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix selecting Resources in the Web Inspector's Resources panel.
timothy@apple.com [Sat, 24 Oct 2009 23:08:21 +0000 (23:08 +0000)]
Fix selecting Resources in the Web Inspector's Resources panel.

https://bugs.webkit.org/show_bug.cgi?id=30743

Reviewed by Pavel Feldman.

* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.isCategoryVisible): Added.
(WebInspector.ResourceSidebarTreeElement.prototype.get selectable): Call
isCategoryVisible on the ResourcesPanel.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Scope Bar in the Web Inspector's Resource panel, so that selecting
timothy@apple.com [Sat, 24 Oct 2009 23:08:15 +0000 (23:08 +0000)]
Fix the Scope Bar in the Web Inspector's Resource panel, so that selecting
All will deselect the other filters.

https://bugs.webkit.org/show_bug.cgi?id=30744

Reviewed by Pavel Feldman.

* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.createFilterElement): Better syntax.
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.filter): Use a normal for loop,
and the child variable instead of target in the loop. Other clean up.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake resizing the Web Inspector's Elements panel sidebar work again.
timothy@apple.com [Sat, 24 Oct 2009 23:08:09 +0000 (23:08 +0000)]
Make resizing the Web Inspector's Elements panel sidebar work again.
Also makes Resources panel use the sidebar code in Panel.

https://bugs.webkit.org/show_bug.cgi?id=30742

Reviewed by Pavel Feldman.

* inspector/front-end/Panel.js:
(WebInspector.Panel): Don't create the sidebar with an argument.
(WebInspector.Panel.prototype.show): Call updateSidebarWidth.
(WebInspector.Panel.prototype.handleKeyEvent): Call handleSidebarKeyEvent.
(WebInspector.Panel.prototype.handleSidebarKeyEvent): Added.
(WebInspector.Panel.prototype.createSidebar): Renamed from _createSidebar.
(WebInspector.Panel.prototype._sidebarDragging): Call updateSidebarWidth.
(WebInspector.Panel.prototype.updateSidebarWidth): Renamed from _updateSidebarWidth.
(WebInspector.Panel.prototype.setSidebarWidth): Added. Called by updateSidebarWidth.
(WebInspector.Panel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel): Call createSidebar.
(WebInspector.ProfilesPanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.show): Remove call to _updateSidebarWidth.
(WebInspector.ResourcesPanel.prototype.showResource): Call updateSidebarWidth
(WebInspector.ResourcesPanel.prototype.closeVisibleResource): Ditto.
(WebInspector.ResourcesPanel.prototype.setSidebarWidth): Added.
(WebInspector.ResourcesPanel.prototype.updateMainViewWidth): Added.
* inspector/front-end/StoragePanel.js:
(WebInspector.StoragePanel): Call createSidebar.
(WebInspector.StoragePanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel): Call createSidebar.
(WebInspector.TimelinePanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCall updateSelection() in a few places so hovering in the Web Inspector's
timothy@apple.com [Sat, 24 Oct 2009 23:08:00 +0000 (23:08 +0000)]
Call updateSelection() in a few places so hovering in the Web Inspector's
Elements panel always has the correct row selection height.

https://bugs.webkit.org/show_bug.cgi?id=30735

Reviewed by Pavel Feldman.

* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton): Call updateSelection().
(WebInspector.ElementsTreeElement.prototype._insertInLastAttributePosition): Ditto.
* inspector/front-end/inspector.css: Prevent text wrapping in the middle of the add attribute text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-24 Timothy Hatcher <timothy@apple.com>
eric@webkit.org [Sat, 24 Oct 2009 23:02:45 +0000 (23:02 +0000)]
2009-10-24  Timothy Hatcher  <timothy@apple.com>

        Remove the re-root tree feature from the Web Inspector's
        Elements panel. This feature wasn't super useful and gets
        in the way of double-click to edit.

        https://bugs.webkit.org/show_bug.cgi?id=30736

        Reviewed by Pavel Feldman.

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype.ondblclick):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-24 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Sat, 24 Oct 2009 22:40:17 +0000 (22:40 +0000)]
2009-10-24  Anton Muhin  <antonm@chromium.org>

        Reviewed by Adam Barth.

        Implements ReturnsNew hint for V8 bindings generation code.
        https://bugs.webkit.org/show_bug.cgi?id=30745

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8DOMWrapper.h:
        (WebCore::V8DOMWrapper::convertNewNodeToV8Object):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMissing images at 350.org due to wrong URLs
mitz@apple.com [Sat, 24 Oct 2009 22:16:30 +0000 (22:16 +0000)]
Missing images at 350.org due to wrong URLs
https://bugs.webkit.org/show_bug.cgi?id=30748

Reviewed by Sam Weinig.

WebCore:

Test: fast/dom/HTMLImageElement/parse-src.html

* dom/Element.cpp:
(WebCore::Element::getURLAttribute): Pass the attribute value through deprecateParseURL().
This matches what the Objective-C bindings do, as well as what HTMLImageLoader::sourceURI()
and SVGImageLoader::sourceURI() do.

LayoutTests:

* fast/dom/HTMLImageElement/parse-src-expected.txt: Added.
* fast/dom/HTMLImageElement/parse-src.html: Added.
* fast/dom/HTMLImageElement/script-tests: Added.
* fast/dom/HTMLImageElement/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/Document/script-tests/TEMPLATE.html.
* fast/dom/HTMLImageElement/script-tests/parse-src.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Sat, 24 Oct 2009 20:55:35 +0000 (20:55 +0000)]
2009-10-24  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed.

        [Qt] Build fix for QtWebKit after r50013.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-24 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 24 Oct 2009 16:12:33 +0000 (16:12 +0000)]
2009-10-24  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, build fix.

        [V8] Fix up to accommodate for HTMLAllCollection changes in
        http://trac.webkit.org/changeset/49998.

        * WebCore.gypi:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8HTMLDocumentCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Sat, 24 Oct 2009 15:28:20 +0000 (15:28 +0000)]
2009-10-24  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Holger Freyther.

        [Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
        https://bugs.webkit.org/show_bug.cgi?id=30476

        Set the stack size to 80 Kb and heap size to the 128kB - 32MB range
        to all executables linking against WebKit library.

        * WebKit.pri:
2009-10-24  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Holger Freyther.

        [Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
        https://bugs.webkit.org/show_bug.cgi?id=30476

        Assign ReadUserData WriteUserData NetworkServices Symbian capabilities
        to jsc.exe.

        * jsc.pro:
2009-10-24  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Holger Freyther.

        [Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
        https://bugs.webkit.org/show_bug.cgi?id=30476

        Assign ReadUserData WriteUserData NetworkServices Symbian capabilities
        to all QtWebkit executables.

        * QGVLauncher/QGVLauncher.pro:
        * QtLauncher/QtLauncher.pro:
        * tests/benchmarks/loading/tst_loading.pro:
        * tests/benchmarks/painting/tst_painting.pro:
        * tests/qgraphicswebview/qgraphicswebview.pro:
        * tests/qwebelement/qwebelement.pro:
        * tests/qwebframe/qwebframe.pro:
        * tests/qwebhistory/qwebhistory.pro:
        * tests/qwebhistoryinterface/qwebhistoryinterface.pro:
        * tests/qwebpage/qwebpage.pro:
        * tests/qwebplugindatabase/qwebplugindatabase.pro:
        * tests/qwebview/qwebview.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/7294131> Assertion failure in AuthenticationMac at
mitz@apple.com [Sat, 24 Oct 2009 04:12:56 +0000 (04:12 +0000)]
<rdar://problem/7294131> Assertion failure in AuthenticationMac at
mac(const Credential&) after authenticating to MobileMe Gallery movie

Reviewed by Alexey Proskuryakov.

* platform/network/Credential.cpp:
(WebCore::Credential::Credential): Initialize m_persistence.
(WebCore::Credential::isEmpty): Made this method const.
* platform/network/Credential.h:
* platform/network/mac/AuthenticationMac.mm:
(WebCore::mac): Return nil if the Credential is empty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix engineering builds in the mysterious future.
mrowe@apple.com [Sat, 24 Oct 2009 03:16:40 +0000 (03:16 +0000)]
Fix engineering builds in the mysterious future.

* Configurations/DebugRelease.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes <https://bugs.webkit.org/show_bug.cgi?id=30617>.
bweinstein@apple.com [Sat, 24 Oct 2009 03:05:19 +0000 (03:05 +0000)]
Fixes <https://bugs.webkit.org/show_bug.cgi?id=30617>.
Web Inspector: Resources Scope Bar Should Allow Combinations.

Reviewed by Timothy Hatcher.

Refactor the filtering in ResourcePanel to make it match ConsoleView,
and add a divider between All, and the other choices of Resource types.

* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.filter):
(WebInspector.ResourcesPanel.prototype._updateFilter):
* inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix. Include config.h before including other files.
mrowe@apple.com [Sat, 24 Oct 2009 03:01:26 +0000 (03:01 +0000)]
Build fix.  Include config.h before including other files.

* AccessibleImage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-23 Chris Evans <cevans@chromium.org>
eric@webkit.org [Sat, 24 Oct 2009 02:06:48 +0000 (02:06 +0000)]
2009-10-23  Chris Evans  <cevans@chromium.org>

        Reviewed by Adam Barth.

        Added test for bug 27239 (ignore Refresh for view source mode).
        https://bugs.webkit.org/show_bug.cgi?id=27239

        * http/tests/security/view-source-no-refresh.html: Added
        * http/tests/security/view-source-no-refresh-expected.txt: Added
        * http/tests/security/resources/view-source-no-refresh.php: Added
2009-10-23  Chris Evans  <cevans@chromium.org>

        Reviewed by Adam Barth.

        Ignore the Refresh header if we're in view source mode.

        https://bugs.webkit.org/show_bug.cgi?id=27239

        Test: http/tests/security/view-source-no-refresh.html

        * loader/FrameLoader.cpp: ignore Refresh in view-source mode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam Weinig.
ap@apple.com [Sat, 24 Oct 2009 01:10:36 +0000 (01:10 +0000)]
    Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=30734
        Remove XMLTokenizer::m_currentNodeIsReferenced

        No change in behavior, no tests.

        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::setCurrentNode):
        * dom/XMLTokenizer.h:
        Don't store a boolean for the current node being the document - we can always check for that.

        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::XMLTokenizer::XMLTokenizer):
        * dom/XMLTokenizerQt.cpp:
        (WebCore::XMLTokenizer::XMLTokenizer):
        A fragment passed to XMLTokenizer is never null - in fact, the first thing we do is dereference
        it unconditionally, and then begin checking it for null, as if it could help.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNo review since this is a build fix.
bdakin@apple.com [Sat, 24 Oct 2009 01:09:34 +0000 (01:09 +0000)]
No review since this is a build fix.

Build fix for the Mac. (Build is only broken when SVG filters are
enabled.)

Labelled these function static.
* platform/graphics/filters/FEComponentTransfer.cpp:
(WebCore::identity):
(WebCore::table):
(WebCore::discrete):
(WebCore::linear):
(WebCore::gamma):
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::boxBlur):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-23 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sat, 24 Oct 2009 00:40:14 +0000 (00:40 +0000)]
2009-10-23  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Implement a Timeline panel.

        https://bugs.webkit.org/show_bug.cgi?id=30725

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/Images/timelineIcon.png: Added.
        * inspector/front-end/TimelineAgent.js:
        (WebInspector.addItemToTimeline):
        (WebInspector.timelineProfilerWasStarted):
        (WebInspector.timelineProfilerWasStopped):
        * inspector/front-end/TimelinePanel.js: Added.
        (WebInspector.TimelinePanel):
        (WebInspector.TimelinePanel.prototype.toolbarItemClass.get toolbarItemLabel):
        (WebInspector.TimelinePanel.prototype.get statusBarItems):
        (WebInspector.TimelinePanel.prototype.handleKeyEvent):
        (WebInspector.TimelinePanel.prototype.timelineWasStarted):
        (WebInspector.TimelinePanel.prototype.timelineWasStopped):
        (WebInspector.TimelinePanel.prototype.addItemToTimeline):
        (WebInspector.TimelinePanel.prototype._innerAddItemToTimeline):
        (WebInspector.TimelinePanel.prototype._toggleTimelineButton):
        (WebInspector.TimelinePanel.prototype.setMainViewWidth):
        (WebInspector.TimelinePanel.prototype.getItemTypeName):
        (WebInspector.TimelineRecordTreeElement):
        (WebInspector.TimelineRecordTreeElement.prototype.onattach):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector._createPanels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-23 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sat, 24 Oct 2009 00:26:31 +0000 (00:26 +0000)]
2009-10-23  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Clash Between Search's onkeyup and incremental search events
        https://bugs.webkit.org/show_bug.cgi?id=30731

        * inspector/front-end/inspector.js:
        (WebInspector.performSearch): prevent incremental search event from clobbering a forced search

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-23 Kelly Norton <knorton@google.com>
pfeldman@chromium.org [Sat, 24 Oct 2009 00:24:49 +0000 (00:24 +0000)]
2009-10-23  Kelly Norton  <knorton@google.com>

        Reviewed by Pavel Feldman.

        Removes the need for C++ Timeline types in InspectorTimelineAgent in favor
        of ScriptObjects.
        https://bugs.webkit.org/show_bug.cgi?id=30707

        * GNUmakefile.am:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/DOMDispatchTimelineItem.cpp: Removed.
        * inspector/DOMDispatchTimelineItem.h: Removed.
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
        (WebCore::InspectorTimelineAgent::willDispatchDOMEvent):
        (WebCore::InspectorTimelineAgent::didDispatchDOMEvent):
        (WebCore::InspectorTimelineAgent::willLayout):
        (WebCore::InspectorTimelineAgent::didLayout):
        (WebCore::InspectorTimelineAgent::willRecalculateStyle):
        (WebCore::InspectorTimelineAgent::didRecalculateStyle):
        (WebCore::InspectorTimelineAgent::willPaint):
        (WebCore::InspectorTimelineAgent::didPaint):
        (WebCore::InspectorTimelineAgent::willWriteHTML):
        (WebCore::InspectorTimelineAgent::didWriteHTML):
        (WebCore::InspectorTimelineAgent::reset):
        (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
        (WebCore::InspectorTimelineAgent::pushCurrentTimelineItem):
        * inspector/InspectorTimelineAgent.h:
        (WebCore::InspectorTimelineAgent::TimelineItemEntry::TimelineItemEntry):
        * inspector/TimelineItem.cpp: Removed.
        * inspector/TimelineItem.h: Removed.
        * inspector/TimelineItemFactory.cpp: Added.
        (WebCore::TimelineItemFactory::createGenericTimelineItem):
        (WebCore::TimelineItemFactory::createDOMDispatchTimelineItem):
        * inspector/TimelineItemFactory.h: Added.
        (WebCore::):
        (WebCore::TimelineItemFactory::TimelineItemFactory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agohttps://bugs.webkit.org/show_bug.cgi?id=30729
barraclough@apple.com [Sat, 24 Oct 2009 00:13:03 +0000 (00:13 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=30729
Provide private API to request the global context for a specific world.
Used to initialize parameters on the global object.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-23
Reviewed by Geoff Garen.

WebCore:

* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::globalObject):
* bindings/js/ScriptController.h:

WebKit/mac:

* WebView/WebFramePrivate.h:
* WebView/WebFrame.mm:
(-[WebFrame contextForWorldID:]):

WebKit/win:

* WebFrame.cpp:
(WebFrame::contextForWorldID):
* WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPan-scrolling pointer shows up in other tabs or windows, can't "fix" it.
bweinstein@apple.com [Fri, 23 Oct 2009 23:35:35 +0000 (23:35 +0000)]
Pan-scrolling pointer shows up in other tabs or windows, can't "fix" it.
<http://webkit.org/b/30732> and <rdar://7332018>.

Reviewed by John Sullivan.

Turns off pan-scrolling on a WebView when it is about to lose focus.

* WebView.cpp:
(WebViewWndProc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-23 Steve Block <steveblock@google.com>
eric@webkit.org [Fri, 23 Oct 2009 22:40:33 +0000 (22:40 +0000)]
2009-10-23  Steve Block  <steveblock@google.com>

        Reviewed by Eric Seidel.

        Fixes style problems in Android-specific files.
        https://bugs.webkit.org/show_bug.cgi?id=30717

        Style changes only, no new tests possible.

        * page/android/EventHandlerAndroid.cpp: Modified.
        (WebCore::EventHandler::passMouseDownEventToWidget): Fixes whitespace in method signature.
        (WebCore::EventHandler::passSubframeEventToSubframe): Fixes whitespace in method signature.
        (WebCore::EventHandler::passWheelEventToWidget): Fixes whitespace in method signature.
        (WebCore::EventHandler::passMouseMoveEventToSubframe): Fixes whitespace in method signature.
        * platform/android/ClipboardAndroid.h: Modified. Fixes header include order and indenting.
        * platform/android/CursorAndroid.cpp: Modified.
        (WebCore::grabCursor): Fixes function braces.
        (WebCore::grabbingCursor): Fixes function braces.
        * platform/android/FileChooserAndroid.cpp: Modified.
        (WebCore::FileChooser::basenameForWidth): Fixes braces on while statement, and updates String::copy to String::threadsafeCopy.
        * platform/android/FileSystemAndroid.cpp: Modified. Fixes header include order.
        (WebCore::unloadModule): Fixes zero test.
        (WebCore::writeToFile): Fixes if statement structure.
        * platform/android/KeyEventAndroid.cpp: Modified.
        (WebCore::windowsKeyCodeForKeyEvent): Fixes switch statement indenting.
        (WebCore::keyIdentifierForAndroidKeyCode): Fixes switch statement indenting.
        * platform/android/ScreenAndroid.cpp: Modified. Fixes header include order and switch statement indenting.
        * platform/android/TemporaryLinkStubs.cpp: Modified. Fixes header include order.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-23 Alejandro G. Castro <alex@igalia.com>
eric@webkit.org [Fri, 23 Oct 2009 22:25:58 +0000 (22:25 +0000)]
2009-10-23  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Modified the tests results according to the last changes due
        to the fixes of the bug (r49985):
        https://bugs.webkit.org/show_bug.cgi?id=29697.

        * platform/gtk/editing/execCommand/4916541-expected.txt:
        * platform/gtk/editing/execCommand/5138441-expected.txt:
        * platform/gtk/editing/execCommand/5481523-expected.txt:
        * platform/gtk/editing/execCommand/indent-paragraphs-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMSAA: Name for image elements should use alt attribute text
jhoneycutt@apple.com [Fri, 23 Oct 2009 22:16:33 +0000 (22:16 +0000)]
MSAA: Name for image elements should use alt attribute text

https://bugs.webkit.org/show_bug.cgi?id=30727
<rdar://problem/7328291>

Reviewed by Alice Liu.

WebKit/win:

* AccessibleBase.cpp:
(AccessibleBase::createInstance):
If the AccessibilityObject is an image, return an AccessibleImage.

* AccessibleImage.cpp: Added.
(AccessibleImage::AccessibleImage):
Call the base constructor.
(AccessibleImage::name):
If the object is not an AccessibilityRenderObject, return the base's
name(). Look first for an ARIA "labeled-by" attribute, then look for an
alternate text attribute. Fall back to the base's name().

* AccessibleImage.h: Added.
(AccessibleImage::~AccessibleImage):

* WebKit.vcproj/WebKit.vcproj:
Add AccessibleImage to the project.

LayoutTests:

* platform/win/accessibility/img-alt-attribute-expected.txt: Added.
* platform/win/accessibility/img-alt-attribute.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-23 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 23 Oct 2009 21:49:00 +0000 (21:49 +0000)]
2009-10-23  Eric Seidel  <eric@webkit.org>

        No review, only adding Alice to the list of reviewers.

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAnother shot at a fixed build.
weinig@apple.com [Fri, 23 Oct 2009 21:45:14 +0000 (21:45 +0000)]
Another shot at a fixed build.

* DerivedSources.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAnother shot at a fixed build.
weinig@apple.com [Fri, 23 Oct 2009 21:33:39 +0000 (21:33 +0000)]
Another shot at a fixed build.

* html/HTMLOptionsCollection.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago50,000!
beidson@apple.com [Fri, 23 Oct 2009 21:25:24 +0000 (21:25 +0000)]
50,000!

* ChangeLog: Point out revision 50,000.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTry and fix the windows build.
weinig@apple.com [Fri, 23 Oct 2009 21:25:09 +0000 (21:25 +0000)]
Try and fix the windows build.

* Interfaces/WebKit.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=30695
weinig@apple.com [Fri, 23 Oct 2009 21:12:03 +0000 (21:12 +0000)]
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=30695
Drop .tags() support from HTMLCollection

Reviewed by Anders Carlsson.

- Make .tags() only work for HTMLAllCollections in JS. .tags() is still
  available for all HTMLCollection like objects in Objective-C since that
  is API.
- Auto-generate HTMLAllCollection.

Test: fast/dom/HTMLDocument/document-all.html

* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSHTMLAllCollection.cpp: Removed.
* bindings/js/JSHTMLAllCollection.h: Removed.
* bindings/js/JSHTMLAllCollectionCustom.cpp: Added.
(WebCore::getNamedItems):
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::getCallData):
(WebCore::JSHTMLAllCollection::canGetItemsForName):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::toJS):
* bindings/js/JSHTMLDocumentCustom.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
* dom/Document.cpp:
(WebCore::Document::all):
* dom/Document.h:
* dom/HTMLAllCollection.idl: Removed.
* html/HTMLAllCollection.cpp: Added.
(WebCore::HTMLAllCollection::create):
(WebCore::HTMLAllCollection::HTMLAllCollection):
(WebCore::HTMLAllCollection::~HTMLAllCollection):
* html/HTMLAllCollection.h: Added.
* html/HTMLAllCollection.idl: Added.
* html/HTMLCollection.h:
* html/HTMLCollection.idl:
* html/HTMLDocument.idl:
* page/DOMWindow.idl:

LayoutTests: Update and add test for https://bugs.webkit.org/show_bug.cgi?id=30695
Drop .tags() support from HTMLCollection

Reviewed by Anders Carlsson.

* fast/dom/HTMLDocument/document-all-expected.txt: Added.
* fast/dom/HTMLDocument/document-all.html: Added.
* fast/dom/HTMLDocument/script-tests: Added.
* fast/dom/HTMLDocument/script-tests/document-all.js: Added.
* fast/dom/Window/window-properties-expected.txt:
* fast/dom/dom-constructors-expected.txt:
* fast/dom/dom-constructors.html:
* fast/dom/domListEnumeration-expected.txt:
* fast/dom/prototype-inheritance-2-expected.txt:
* fast/dom/prototype-inheritance-expected.txt:
* fast/dom/script-tests/domListEnumeration.js:
* fast/dom/undetectable-document-all-expected.txt:
* fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-23 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 23 Oct 2009 20:47:58 +0000 (20:47 +0000)]
2009-10-23  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: pull basic sidebar implementation into the Panel.

        https://bugs.webkit.org/show_bug.cgi?id=30720

        * inspector/front-end/Panel.js:
        (WebInspector.Panel):
        (WebInspector.Panel.prototype.jumpToPreviousSearchResult):
        (WebInspector.Panel.prototype.handleKeyEvent):
        (WebInspector.Panel.prototype._createSidebar):
        (WebInspector.Panel.prototype._startSidebarDragging):
        (WebInspector.Panel.prototype._sidebarDragging):
        (WebInspector.Panel.prototype._endSidebarDragging):
        (WebInspector.Panel.prototype._updateSidebarWidth):
        (WebInspector.Panel.prototype.setCenterViewWidth):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel):
        (WebInspector.ProfilesPanel.prototype.setCenterViewWidth):
        * inspector/front-end/StoragePanel.js:
        (WebInspector.StoragePanel):
        (WebInspector.StoragePanel.prototype.setCenterViewWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-23 Jens Alfke <snej@chromium.org>
eric@webkit.org [Fri, 23 Oct 2009 20:43:17 +0000 (20:43 +0000)]
2009-10-23  Jens Alfke  <snej@chromium.org>

        Reviewed by Dimitri Glazkov.

        Slight optimizations to object returning and exception handling in generated V8 bindings.
        https://bugs.webkit.org/show_bug.cgi?id=30599

        * bindings/scripts/CodeGeneratorV8.pm: Generate better code
        * bindings/v8/V8DOMWrapper.h:
        (WebCore::V8DOMWrapper::convertToV8Object): Added overload that takes a Ref<>
        * bindings/v8/custom/V8InspectorBackendCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL): Remove unnecessary template param to prevent compile error

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-23 Alpha Lam <hclam@chromium.org>
eric@webkit.org [Fri, 23 Oct 2009 20:35:15 +0000 (20:35 +0000)]
2009-10-23  Alpha Lam  <hclam@chromium.org>

        Reviewed by Eric Carlson.

        Volume slider always starts at half volume
        https://bugs.webkit.org/show_bug.cgi?id=28322

        * media/video-volume-slider.html: Added.
        Pixel test for the volume slider of the media control. This test
        assumes volume slider is implemented and usable. It moves the mouse
        over the right bottom corner of a video element to trigger the
        volume slider. If volume slider is not implemented at all, you'll
        only see a video element with the first frame.
        * platform/gtk/Skipped: The above test requires a volume slider so it's skipped.
        * platform/mac/Skipped: ditto.
        * platform/win/Skipped: ditto.
2009-10-23  Alpha Lam  <hclam@chromium.org>

        Reviewed by Eric Carlson.

        Volume slider always starts at half volume
        https://bugs.webkit.org/show_bug.cgi?id=28322

        Sets the value attribute of volume slider to the volume attribute
        of the media element. Also update the value attribute of the
        input element for the volume slider when the volume attribute
        of the media element is updated.

        Test: media/video-volume-slider.html

        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlVolumeSliderElement::update):
        Set the value attribute of the input element for the volume slider
        using the current volume of the media element.
        * rendering/MediaControlElements.h:
        Add method definition of update().
        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::createVolumeSlider):
        Creates a volume slider with value attribute equals to the current
        volume attribute of the media element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49995 268f45cc-cd09-0410-ab3c-d52691b4dbfc