WebKit-https.git
9 years ago[chromium] Apply sent deltas on finishCommit
commit-queue@webkit.org [Tue, 6 Dec 2011 21:00:29 +0000 (21:00 +0000)]
[chromium] Apply sent deltas on finishCommit
https://bugs.webkit.org/show_bug.cgi?id=73884

Patch by Alexandre Elias <aelias@google.com> on 2011-12-06
Reviewed by James Robinson.

This moves scroll and pageScale "sent" deltas to be applied to
the layer at the end of the commit, instead of the beginning.

This has several advantages, especially for page scale:
- When pageScale changes, no longer any need to change the scroll's
coordinate space at beginning of commit, which is complex and prone to
bugs (this fixes a problem where we were forgetting to modify the
scrollPosition before).
- No need for non-commit-related code to consider the "sent" values.
m_pageScale is now always the content scale factor, and
m_pageScaleDelta is the scale to be on the impl-side matrix.
- This will make it easy to send arbitrary fake or future delta
values for example while pinch zooming out.

The scroll logic is similarly altered for consistency's sake.  Note that
I also moved the tree synchronize to the beginning of finishCommit
in order to avoid having to change the pageScale coordinate space of
sentScrollDelta in adjustScrollsForPageScaleChange().

Source/WebCore:

No new tests. (Refactoring of existing code.)

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
(WebCore::CCLayerTreeHostImpl::applyPageScaleDeltaToScrollLayer):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't allocate register in typedarray control flow
oliver@apple.com [Tue, 6 Dec 2011 20:48:27 +0000 (20:48 +0000)]
Don't allocate register in typedarray control flow
https://bugs.webkit.org/show_bug.cgi?id=73944

Reviewed by Gavin Barraclough.

Move a temporary allocation outside of control flow.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix assertion in QtViewportInteractionEngine.cpp:468
commit-queue@webkit.org [Tue, 6 Dec 2011 20:47:31 +0000 (20:47 +0000)]
[Qt] Fix assertion in QtViewportInteractionEngine.cpp:468
https://bugs.webkit.org/show_bug.cgi?id=73914

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-12-06
Reviewed by Kenneth Rohde Christiansen.

m_suspendCount should always be zero when a pinch gesture is started.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=68328
barraclough@apple.com [Tue, 6 Dec 2011 20:46:07 +0000 (20:46 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=68328
The generator and intrinsic fields in HashTableValue/HashEntry and associated structures and methods are redundant

Reviewed by Geoff Garen.

../JavaScriptCore:

Move the instrinsic enum out of the DFG, into runtime. Add entires for all host functions
that have an intrinsic in the form of a generated thunk. Remove the thunk pointer from the
hashtable, and make Intrinsic field no longer ifdef on JIT/DFG. In getHostFunction select
a thunk genertaor to use based on the Intrinsic.

* JavaScriptCore.xcodeproj/project.pbxproj:
* create_hash_table:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
* dfg/DFGCapabilities.h:
* dfg/DFGIntrinsic.h: Removed.
* jit/JITStubs.cpp:
(JSC::JITThunks::hostFunctionStub):
* jit/JITStubs.h:
* runtime/Executable.cpp:
(JSC::ExecutableBase::intrinsic):
(JSC::NativeExecutable::intrinsic):
* runtime/Executable.h:
(JSC::ExecutableBase::intrinsicFor):
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):
* runtime/Intrinsic.h: Copied from Source/JavaScriptCore/dfg/DFGIntrinsic.h.
* runtime/JSGlobalData.cpp:
(JSC::thunkGeneratorForIntrinsic):
(JSC::JSGlobalData::getHostFunction):
* runtime/JSGlobalData.h:
* runtime/Lookup.cpp:
(JSC::HashTable::createTable):
(JSC::setUpStaticFunctionSlot):
* runtime/Lookup.h:
(JSC::HashEntry::initialize):
(JSC::HashEntry::intrinsic):

../WebCore:

Intrinsic is no longer in the DFG namespace, is always in the
hash table. Removed ThunkGenerator.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHashTable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove forwarding header now that downstream has been fixed to refer to
abarth@webkit.org [Tue, 6 Dec 2011 20:39:43 +0000 (20:39 +0000)]
Remove forwarding header now that downstream has been fixed to refer to
the actual location of this header.

* public/WebRect.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r102091.
dglazkov@chromium.org [Tue, 6 Dec 2011 20:27:57 +0000 (20:27 +0000)]
Unreviewed, rolling out r102091.
http://trac.webkit.org/changeset/102091
https://bugs.webkit.org/show_bug.cgi?id=73711

Caused Clang Linux compile failure.

Source/WebCore:

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setAnchorPoint):
(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::setChildrenTransform):
(WebCore::GraphicsLayerChromium::setMasksToBounds):
(WebCore::GraphicsLayerChromium::setBackgroundColor):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setNeedsCommit):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setAnchorPoint):
(WebCore::LayerChromium::setAnchorPointZ):
(WebCore::LayerChromium::setBackgroundColor):
(WebCore::LayerChromium::setMasksToBounds):
(WebCore::LayerChromium::setMaskLayer):
(WebCore::LayerChromium::setOpacity):
(WebCore::LayerChromium::setOpaque):
(WebCore::LayerChromium::setPosition):
(WebCore::LayerChromium::setSublayerTransform):
(WebCore::LayerChromium::setTransform):
(WebCore::LayerChromium::setScrollPosition):
(WebCore::LayerChromium::setScrollable):
(WebCore::LayerChromium::setDoubleSided):
(WebCore::LayerChromium::setReplicaLayer):
* platform/graphics/chromium/NonCompositedContentHost.cpp:
(WebCore::NonCompositedContentHost::notifySyncRequired):
* platform/graphics/chromium/NonCompositedContentHost.h:

Source/WebKit/chromium:

* tests/LayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Make root layer always opaque
commit-queue@webkit.org [Tue, 6 Dec 2011 20:17:02 +0000 (20:17 +0000)]
[Chromium] Make root layer always opaque
https://bugs.webkit.org/show_bug.cgi?id=70564

Patch by Dana Jansens <danakj@chromium.org> on 2011-12-06
Reviewed by James Robinson.

* platform/graphics/chromium/NonCompositedContentHost.cpp:
(WebCore::NonCompositedContentHost::NonCompositedContentHost):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a pid parameter to CrashLogs.find_newest_log
aroben@apple.com [Tue, 6 Dec 2011 20:04:25 +0000 (20:04 +0000)]
Add a pid parameter to CrashLogs.find_newest_log

When a PID is passed, only crash logs corresponding to a crashed process with that PID are
considered.

Fixes <http://webkit.org/b/73942> webkitpy provides no way to specify the PID of the crashed
process whose crash log you want to find

Reviewed by Dirk Pranke.

* Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs.find_newest_log): Added an optional pid parameter.
(CrashLogs._find_newest_log_darwin): Added a pid parameter. When specified, we look at each
candidate log's app_description extended attribute to see if that log corresponds to a
crashed process with the specified PID.

* Scripts/webkitpy/common/system/crashlogs_unittest.py:
(CrashLogsTest.test_find_newest_log_darwin): Added a few more mock crash logs with various
contents and PIDs. Added tests that show that the pid parameter to find_newest_log is
respected. Also fixed an erroneous use of assertTrue instead of assertEqual.

* Scripts/webkitpy/common/system/filesystem.py:
(FileSystem.getxattr): Added. On Darwin, calls through to the xattr module. On other
systems, raises a KeyError, mimicking the behavior on Darwin when the given attribute isn't
present.

* Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.__init__): Added an optional xattrs parameter. Documented other parameters.
(MockFileSystem.getxattr): Added. Just pulls the given attribute out of the xattrs
dictionary.

* Scripts/webkitpy/tool/commands/queries.py:
(CrashLog): Added help text. Added an optional PID parameter.
(CrashLog.execute): Pass the PID, if any, through to find_newest_log.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWait for Crash Reporter to finish even when it lets the crashed process die quickly
aroben@apple.com [Tue, 6 Dec 2011 20:04:08 +0000 (20:04 +0000)]
Wait for Crash Reporter to finish even when it lets the crashed process die quickly

NRWT was only waiting for Crash Reporter in cases where it was keeping the crashed process
alive beyond the normal timeout limit. In cases where the crashed process was able to die
faster, NRWT would assume that Crash Reporter had finished even though it often was still
running, which would lead to an incorrect crash log being picked up.

Part of <http://webkit.org/b/71380> NRWT incorrectly associates crash logs with tests

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess._reset):
(ServerProcess.write):
(ServerProcess._check_for_crash): Changed to use new set_crashed function instead of setting
.crashed directly. Added wait_for_crash_reporter parameter, which we pass along to
set_crashed.

(ServerProcess._handle_timeout): Fixed a logic error that would cause .crashed and
.timed_out both to be set to True in cases where Crash Reporter took a long time to run. Now
we bail out of handling the failure as a timeout if we find out that the process in fact
crashed. We tell _check_for_crash not to wait for Crash Reporter because we've already done
so.
(ServerProcess.set_crashed): Added. When the process crashes, we wait for Crash Reporter to
finish running (unless directed otherwise) so we can be sure the crash log has been saved to
disk.

* Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
(TrivialMockPort.is_crash_reporter): Added.

* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver._check_for_driver_crash): Changed to use set_crashed. (This also fixed a typo
that would have partially broken crash detection on Windows, if NRWT worked on Windows.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNRWT fails on unreleased versions of Mac OS X
abarth@webkit.org [Tue, 6 Dec 2011 20:00:03 +0000 (20:00 +0000)]
NRWT fails on unreleased versions of Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=72748

Reviewed by Dirk Pranke.

Hopefully this patch will make NRWT work on future versions on Mac OS X.
Most of the infrastructure was already in place, but there were some
asserts that failed.  I've tested this patch by haxoring the version
detection logic to simulate an unknown version.  We might need to
iterate based on feedback from folks with a real future version.

* Scripts/webkitpy/layout_tests/port/apple.py:
(ApplePort.__init__):
    - mac-future is an allowed port_name that's used internally by
      webkitpy to represent future versions of Mac OS X.
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(test_versions):
    - Test that we don't throw exceptions when dealing with future
      versions of Mac OS X.
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._expectations_from_skipped_files):
    - Demote this logging message to "debug".  It's expected that
      mac-future doesn't have a Skipped file.
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.__init__):
* Scripts/webkitpy/layout_tests/port/win.py:
(WinPort.__init__):
    - Re-order some code in these constructors so that
      self._operating_system is available to the ApplePort constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUI process crashes if the Web Process crashes on launch
simon.fraser@apple.com [Tue, 6 Dec 2011 19:58:41 +0000 (19:58 +0000)]
UI process crashes if the Web Process crashes on launch
https://bugs.webkit.org/show_bug.cgi?id=73943

Reviewed by Sam Weinig.

When the Web Process crashes on launch, the WebConnectionToWebProcess
object was getting deleted inside of didClose. Add a protector to
prevent this.

* UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::didClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Do not lose message flags when converting to/from Soup Requests/Responses
kubo@profusion.mobi [Tue, 6 Dec 2011 19:29:44 +0000 (19:29 +0000)]
[EFL] Do not lose message flags when converting to/from Soup Requests/Responses
https://bugs.webkit.org/show_bug.cgi?id=73924

Reviewed by Gustavo Noronha Silva.

Apply the same change added to the GTK+ port in r55086 to prevent
soup message flags from being lost by updating the request flags when
a response is received.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebPImageDecoder computes image width and height multiple times
noel.gordon@gmail.com [Tue, 6 Dec 2011 19:29:42 +0000 (19:29 +0000)]
WebPImageDecoder computes image width and height multiple times
https://bugs.webkit.org/show_bug.cgi?id=73796

Reviewed by Adam Barth.

Once sufficient image data arrives, we can compute the decoded image height
and width from the WEBP image header data.

From then on, the decoded image size is known so there's no need to re-read
it from the WEBP image header again.

No change in behavior, so no new tests.

* platform/image-decoders/webp/WEBPImageDecoder.cpp:
(WebCore::WEBPImageDecoder::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agooptimize TransformationMatrix::scale by not calling through to generic multiply
reed@google.com [Tue, 6 Dec 2011 19:27:31 +0000 (19:27 +0000)]
optimize TransformationMatrix::scale by not calling through to generic multiply
https://bugs.webkit.org/show_bug.cgi?id=73830

Reviewed by Kenneth Russell.

No new tests. Optimization only, existing tests exercise the code

* platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::scaleNonUniform):
(WebCore::TransformationMatrix::scale3d):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix page overlay rendering with AC.
jocelyn.turcotte@nokia.com [Tue, 6 Dec 2011 19:26:33 +0000 (19:26 +0000)]
[Qt] Fix page overlay rendering with AC.
https://bugs.webkit.org/show_bug.cgi?id=73935

Reviewed by Noam Rosenthal.

The inspector node highlight would display old highlights as well
since the overlay is normally rendered right after the page on top
of the same graphics context.

* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::paintContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGenerated some new expected results for Lion.
darin@apple.com [Tue, 6 Dec 2011 19:07:36 +0000 (19:07 +0000)]
Generated some new expected results for Lion.

Discussed aspects of this with Adam Roben and Dan Bernstein.

* platform/mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
* platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
* platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
* platform/mac/fast/regions/region-overflow-break-expected.txt: Added.
* platform/mac/fast/regions/render-region-custom-style-mark-expected.txt: Added.
* platform/mac/http/tests/inspector/resource-har-conversion-expected.txt: Updated.
* platform/mac/media/controls-strict-expected.txt: Added.
* platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Updated.
* platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
* platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Updated.
* platform/mac/svg/text/text-intro-05-t-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert WebCore track Settings changes made in r101977
eric.carlson@apple.com [Tue, 6 Dec 2011 19:01:22 +0000 (19:01 +0000)]
Revert WebCore track Settings changes made in r101977
https://bugs.webkit.org/show_bug.cgi?id=73879

Reviewed by Sam Weinig.

No new tests yet, still nothing to test.

* page/Settings.cpp: Move the preference setters back into the .h file.
* page/Settings.h:
(WebCore::Settings::setShouldDisplaySubtitles):
(WebCore::Settings::setShouldDisplayCaptions):
(WebCore::Settings::setShouldDisplayTextDescriptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium expectations update.
vsevik@chromium.org [Tue, 6 Dec 2011 18:37:47 +0000 (18:37 +0000)]
Unreviewed chromium expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMediaList: Remove constructor that takes a CSSImportRule*.
kling@webkit.org [Tue, 6 Dec 2011 18:19:38 +0000 (18:19 +0000)]
MediaList: Remove constructor that takes a CSSImportRule*.
<http://webkit.org/b/73833>

Reviewed by Antti Koivisto.

* css/MediaList.h:
* css/MediaList.cpp:

    Remove MediaList(CSSImportRule*, ...) constructor.

* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::CSSImportRule):

    Have CSSImportRule construct its MediaList by passing the parent
    style sheet, which is exactly what the old constructor accomplished.
    Also assert that we're always created with a non-null parent sheet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium tests rebaseline.
vsevik@chromium.org [Tue, 6 Dec 2011 17:59:49 +0000 (17:59 +0000)]
Unreviewed chromium tests rebaseline.

* platform/chromium-cg-mac-leopard/fast/table/027-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdded myself as a committer.
tommyw@google.com [Tue, 6 Dec 2011 17:57:39 +0000 (17:57 +0000)]
Added myself as a committer.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogetComputedStyle returns wrong value for margin-*
jarred@sencha.com [Tue, 6 Dec 2011 17:43:28 +0000 (17:43 +0000)]
getComputedStyle returns wrong value for margin-*
https://bugs.webkit.org/show_bug.cgi?id=73334

Source/WebCore:

margin-* getComputedStyle values should return the "used" absolute value when there is a renderer
and the specified value is relative (percentage, auto, etc.).
When there is no renderer, the specified value should be returned.
See http://dev.w3.org/csswg/cssom/#resolved-values.

Reviewed by Darin Adler.

Test: fast/css/getComputedStyle/getComputedStyle-resolved-values.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Modified baseline tests for getComputedStyle margin values where a "used" value is returned.

Reviewed by Darin Adler.

* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* fast/css/getComputedStyle/getComputedStyle-margin-auto-expected.txt:
* fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt:
* fast/css/getComputedStyle/getComputedStyle-resolved-values-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-resolved-values.html: Added.
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago REGRESSION (WebKit2): Kill ring is not cleared when selection changes
ap@apple.com [Tue, 6 Dec 2011 17:36:48 +0000 (17:36 +0000)]
    REGRESSION (WebKit2): Kill ring is not cleared when selection changes
        https://bugs.webkit.org/show_bug.cgi?id=73888
        <rdar://problem/10532310>

        Reviewed by Mark Rowe.

        Test: editing/pasteboard/emacs-ctrl-k-with-move.html

        * editing/Editor.cpp: (WebCore::Editor::respondToChangedSelection): Moved the code to clear
        kill ring from Mac WebKit, as it's needed in all Mac ports at least.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse HashMap<OwnPtr> in CollectionCache
darin@apple.com [Tue, 6 Dec 2011 17:30:00 +0000 (17:30 +0000)]
Use HashMap<OwnPtr> in CollectionCache
https://bugs.webkit.org/show_bug.cgi?id=73784

Reviewed by Andreas Kling.

* html/CollectionCache.cpp:
(WebCore::CollectionCache::copyCacheMap): Use adoptPtr.
(WebCore::CollectionCache::reset): Removed now-unneeded calls to deleteAllValues.
(WebCore::append): Added. Helper function for appending elements to the maps from
the collection cache.

* html/CollectionCache.h: Changed mapped type in NodeCacheMap to OwnPtr.
Added append function.

* html/HTMLCollection.cpp:
(WebCore::nameShouldBeVisibleInDocumentAll): Added, to factor out common code in
two functions below.
(WebCore::HTMLCollection::checkForNameMatch): Changed to call nameShouldBeVisibleInDocumentAll.
(WebCore::HTMLCollection::updateNameCache): Ditto. Also updated cache code to use the append
function, so it will work with OwnPtr. Also eliminated an unneeded get call before
each hash table add; we do both at once in the new append function.
* html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::updateNameCache): More of the same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd 8 bit paths to global object functions
msaboff@apple.com [Tue, 6 Dec 2011 17:21:11 +0000 (17:21 +0000)]
Add 8 bit paths to global object functions
https://bugs.webkit.org/show_bug.cgi?id=73875

Added 8 bit paths for converions methods.

This is worth 1.5% on kraken audio-oscillator,
1.6% on stanford-crypto-ccm and 2.5% on
stanford-crypto-sha256-iterative.  See bug for
a full report.

Reviewed by Oliver Hunt.

* runtime/JSGlobalObjectFunctions.cpp:
(JSC::decode): Split into a templated helper.
(JSC::parseInt): Split into a templated helper.
(JSC::parseFloat): Added an 8 bit path
(JSC::globalFuncEscape): Added 8 bit path
(JSC::globalFuncUnescape): Added 8 bit path
* runtime/JSStringBuilder.h:
(JSC::JSStringBuilder::append): New append for LChar
* wtf/text/StringBuilder.h:
(WTF::StringBuilder::append): New append for LChar

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium expectations update.
vsevik@chromium.org [Tue, 6 Dec 2011 17:05:57 +0000 (17:05 +0000)]
Unreviewed chromium expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdded myself as a committer.
peter@chromium.org [Tue, 6 Dec 2011 16:36:03 +0000 (16:36 +0000)]
Added myself as a committer.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[qt][wk2] Tests of QQuickWebView assert in debug builds when destroying QQuickWebView...
commit-queue@webkit.org [Tue, 6 Dec 2011 16:35:41 +0000 (16:35 +0000)]
[qt][wk2] Tests of QQuickWebView assert in debug builds when destroying QQuickWebViewPrivate
https://bugs.webkit.org/show_bug.cgi?id=73907

Patch by Michael Brüning <michael.bruning@nokia.com> on 2011-12-06
Reviewed by Kenneth Rohde Christiansen.

* UIProcess/API/qt/qquickwebview.cpp: Disconnect signals from
QtViewportInteractionEngine in ~QQuickWebViewPrivate.
(QQuickWebViewPrivate::~QQuickWebViewPrivate):
* UIProcess/API/qt/qquickwebview_p_p.h: Remove empty inline implementation of ~QQuickWebViewPrivate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r102102.
vsevik@chromium.org [Tue, 6 Dec 2011 16:25:15 +0000 (16:25 +0000)]
Unreviewed, rolling out r102102.
http://trac.webkit.org/changeset/102102
https://bugs.webkit.org/show_bug.cgi?id=73925

Causes segmentation fault on chromium unit_tests,
content_unittests, sync_unit_tests (Requested by vsevik on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-06

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Web Inspector: getFunctionLocation should return scriptId as String not...
yurys@chromium.org [Tue, 6 Dec 2011 16:16:44 +0000 (16:16 +0000)]
[Chromium] Web Inspector: getFunctionLocation should return scriptId as String not as int
https://bugs.webkit.org/show_bug.cgi?id=73892

Reviewed by Pavel Feldman.

* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::functionLocationCallback): scriptId should be a string not a number
* inspector/Inspector.json: removed unused parameter

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium expectations update.
vsevik@chromium.org [Tue, 6 Dec 2011 15:38:57 +0000 (15:38 +0000)]
Unreviewed chromium expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium tests rebaseline.
vsevik@chromium.org [Tue, 6 Dec 2011 15:36:15 +0000 (15:36 +0000)]
Unreviewed chromium tests rebaseline.

* platform/chromium-cg-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.
* platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium expectations update.
vsevik@chromium.org [Tue, 6 Dec 2011 15:31:00 +0000 (15:31 +0000)]
Unreviewed chromium expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add initial support for focusing when entering edit mode.
kenneth@webkit.org [Tue, 6 Dec 2011 15:24:26 +0000 (15:24 +0000)]
[Qt] Add initial support for focusing when entering edit mode.

Reviewed by Simon Hausmann.

Next step would be to properly upstream our EditorState code.

* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::focusEditableArea):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/qt/QtPageClient.cpp:
(QtPageClient::focusEditableArea):
* UIProcess/qt/QtPageClient.h:
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::itemCoordFromCSS):
(WebKit::QtViewportInteractionEngine::itemRectFromCSS):
(WebKit::QtViewportInteractionEngine::focusEditableArea):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
* UIProcess/qt/QtViewportInteractionEngine.h:
* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::focusEditableArea):
* UIProcess/qt/QtWebPageEventHandler.h:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection):
(WebKit::WebEditorClient::setInputMethodState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] Unreviewed gardening. Skip a failing test because of missing layoutTestControll...
ossy@webkit.org [Tue, 6 Dec 2011 15:05:40 +0000 (15:05 +0000)]
[WK2] Unreviewed gardening. Skip a failing test because of missing layoutTestController.dumpFrameLoadCallbacks()
https://bugs.webkit.org/show_bug.cgi?id=42331

* platform/wk2/Skipped: Skip http/tests/security/mixedContent/insecure-video-in-iframe.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium expectations update.
vsevik@chromium.org [Tue, 6 Dec 2011 15:04:28 +0000 (15:04 +0000)]
Unreviewed chromium expectations update.

* platform/chromium-cg-mac-leopard/fast/table/027-vertical-expected.png: Added.
* platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug14929-expected.png:
* platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug2947-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium expectations update.
vsevik@chromium.org [Tue, 6 Dec 2011 14:38:08 +0000 (14:38 +0000)]
Unreviewed chromium expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable ParallelJobs by default
kbalazs@webkit.org [Tue, 6 Dec 2011 14:30:16 +0000 (14:30 +0000)]
Enable ParallelJobs by default
https://bugs.webkit.org/show_bug.cgi?id=70032

Reviewed by Zoltan Herczeg.

Source/JavaScriptCore:

Relanding with typo fix.

According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.

Remove the ENABLE(PARALLEL_JOBS) guard.
Fix build on Windows and Chromium.

* JavaScriptCore.gypi:  Add the files to the build. It was
missing for the gyp build system.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Export symbols.
* wtf/ParallelJobs.h:
* wtf/ParallelJobsGeneric.cpp:
(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):
Deinline these to avoid exporting a lot of symbols.
These are non-trivial and called only once on a given object
so it doesn't seems to be worthwile to inline them.
Additionally fix a signed-unsigned comparison in the constructor.
* wtf/ParallelJobsGeneric.h:
* wtf/Platform.h:

Source/WebCore:

Covered by existing tests.

According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.

Remove the ENABLE(PARALLEL_JOBS) guard. Fix the Windows build
by qualifying ParallelJobs with the WTF namespace (otherwise
MSVC believes it belongs to WebCore which is likely a compiler bug).

* platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::setInteriorPixelsWorker):
(WebCore::FEConvolveMatrix::platformApplySoftware):
* platform/graphics/filters/FEConvolveMatrix.h:
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplyWorker):
(WebCore::FEGaussianBlur::platformApply):
* platform/graphics/filters/FEGaussianBlur.h:
* platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::platformApplyGenericWorker):
(WebCore::FELighting::platformApplyGeneric):
* platform/graphics/filters/FELighting.h:
* platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::platformApplyWorker):
(WebCore::FEMorphology::platformApply):
* platform/graphics/filters/FEMorphology.h:
* platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::fillRegionWorker):
(WebCore::FETurbulence::platformApplySoftware):
* platform/graphics/filters/FETurbulence.h:
* platform/graphics/filters/arm/FELightingNEON.cpp:
(WebCore::FELighting::platformApplyNeonWorker):
* platform/graphics/filters/arm/FELightingNEON.h:
(WebCore::FELighting::platformApplyNeon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Mac] Unreviewed gardening. Paint the bot green skipping with all failing tests.
ossy@webkit.org [Tue, 6 Dec 2011 14:19:21 +0000 (14:19 +0000)]
[Qt][Mac] Unreviewed gardening. Paint the bot green skipping with all failing tests.

* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix assertion in QtWebPageEventHandler.cpp
commit-queue@webkit.org [Tue, 6 Dec 2011 14:17:16 +0000 (14:17 +0000)]
[Qt] Fix assertion in QtWebPageEventHandler.cpp
https://bugs.webkit.org/show_bug.cgi?id=73908

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-12-06
Reviewed by Kenneth Rohde Christiansen.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] fast/forms/access-key-for-all-elements.html fails
ossy@webkit.org [Tue, 6 Dec 2011 14:13:48 +0000 (14:13 +0000)]
[Qt][WK2] fast/forms/access-key-for-all-elements.html fails
https://bugs.webkit.org/show_bug.cgi?id=73917

* platform/qt-wk2/Skipped: Skip fast/forms/access-key-for-all-elements.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed assertion fix for r102123.
kling@webkit.org [Tue, 6 Dec 2011 13:59:18 +0000 (13:59 +0000)]
Unreviewed assertion fix for r102123.

* platform/KURL.cpp:
(WebCore::checkEncodedString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] Unreviewed gardening. New tests introduced in 100895 fail
ossy@webkit.org [Tue, 6 Dec 2011 13:55:23 +0000 (13:55 +0000)]
[WK2] Unreviewed gardening. New tests introduced in 100895 fail
https://bugs.webkit.org/show_bug.cgi?id=73913

* platform/wk2/Skipped: Skip failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium expectations update.
vsevik@chromium.org [Tue, 6 Dec 2011 13:49:43 +0000 (13:49 +0000)]
Unreviewed chromium expectations update.

* platform/chromium-cg-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
* platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] build-jsc script doesn't work
commit-queue@webkit.org [Tue, 6 Dec 2011 13:43:24 +0000 (13:43 +0000)]
[Qt] build-jsc script doesn't work
https://bugs.webkit.org/show_bug.cgi?id=73910

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2011-12-06
Reviewed by Tor Arne Vestbø.

.:

* WebKit.pro: Move WTF SUBDIR stuff out of here and
straight into JavaScriptCore/JavaScriptCore.pro.
Unconditionally "recurse" into JavaScriptCore now,
as we'll do the v8 scoping there to only build WTF.

Source/JavaScriptCore:

* JavaScriptCore.pro: Build WTF before JavaScriptCore and JSC
(moved from top-level WebKit.pro). Also add v8 scopes to only build
WTF during v8 builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium expectations update.
vsevik@chromium.org [Tue, 6 Dec 2011 13:43:19 +0000 (13:43 +0000)]
Unreviewed chromium expectations update.

* platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt:
* platform/chromium-cg-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt:
* platform/chromium-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt:
* platform/chromium-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSimplify KURL's checkEncodedString()
benjamin@webkit.org [Tue, 6 Dec 2011 13:04:45 +0000 (13:04 +0000)]
Simplify KURL's checkEncodedString()
https://bugs.webkit.org/show_bug.cgi?id=73890

Reviewed by Andreas Kling.

The method was reimplementing String::containsOnlyASCII().
Use the method from String and we can remove the #if NDEBUG.

* platform/KURL.cpp:
(WebCore::checkEncodedString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium expectations update.
vsevik@chromium.org [Tue, 6 Dec 2011 12:53:48 +0000 (12:53 +0000)]
Unreviewed chromium expectations update.

* tests/KURLTest.cpp:
(ComponentCase::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium expectations update.
vsevik@chromium.org [Tue, 6 Dec 2011 12:12:11 +0000 (12:12 +0000)]
Unreviewed chromium expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r102111.
vsevik@chromium.org [Tue, 6 Dec 2011 11:38:16 +0000 (11:38 +0000)]
Unreviewed, rolling out r102111.
http://trac.webkit.org/changeset/102111
https://bugs.webkit.org/show_bug.cgi?id=73902

Breaks compilation (Requested by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-06

* editing/Editor.cpp:
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
* editing/Editor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Refactoring] Accessing Node::m_document should be minimized.
commit-queue@webkit.org [Tue, 6 Dec 2011 11:30:45 +0000 (11:30 +0000)]
[Refactoring] Accessing Node::m_document should be minimized.
https://bugs.webkit.org/show_bug.cgi?id=73800

Patch by Hajime Morrita <morrita@chromium.org> on 2011-12-06
Reviewed by Kent Tamura.

No new tests. No behavioral change.

Replaced m_document reference with the document() accessor
or temporaril variables. This is a preparation for using
m_document space to point a shadow root pointer.

* dom/Document.h:
(WebCore::Node::Node):
* dom/Node.cpp:
(WebCore::Node::~Node):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=73889
commit-queue@webkit.org [Tue, 6 Dec 2011 11:24:03 +0000 (11:24 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=73889
TextCheckingParagraph::offsetTo should not have a side effect.

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-06
Reviewed by Hajime Morita.

Since TextCheckingParagraph::offsetTo had a side effect, its cache often became inconsistent.
This is likely to cause a bug when changing SpellChecker and Editor.

No new tests. Covered by existing tests.

* editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingParagraph::offsetTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] http/tests/misc/drag-over-iframe-invalid-source-crash.html and fast/events/drag...
ossy@webkit.org [Tue, 6 Dec 2011 11:20:54 +0000 (11:20 +0000)]
[Qt] http/tests/misc/drag-over-iframe-invalid-source-crash.html and fast/events/drag-selects-image.html fails with timeout
https://bugs.webkit.org/show_bug.cgi?id=73901

* platform/qt-wk1/Skipped: Skip the failint tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium tests rebaseline.
vsevik@chromium.org [Tue, 6 Dec 2011 11:12:40 +0000 (11:12 +0000)]
Unreviewed chromium tests rebaseline.

* platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug14929-expected.png: Renamed from LayoutTests/platform/chromium/tables/mozilla/bugs/bug14929-expected.png.
* platform/chromium-mac-leopard/fast/table/027-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug14929-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2947-expected.png:
* platform/chromium-mac-snowleopard/fast/table/027-vertical-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug14929-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2947-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Set texture limits as multiples of viewport size instead of hardcoded...
commit-queue@webkit.org [Tue, 6 Dec 2011 11:05:02 +0000 (11:05 +0000)]
[chromium] Set texture limits as multiples of viewport size instead of hardcoded values
https://bugs.webkit.org/show_bug.cgi?id=72202

Patch by Eric Penner <epenner@google.com> on 2011-12-06
Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayers): added viewport param
(WebCore::LayerRendererChromium::initializeSharedObjects): ditto
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::highLimitBytes): calculated based on viewport
(WebCore::TextureManager::reclaimLimitBytes): ditto
(WebCore::TextureManager::lowLimitBytes): ditto
(WebCore::TextureManager::TextureManager): added viewport param
(WebCore::TextureManager::setMaxMemoryLimitBytes): changed name
(WebCore::TextureManager::setPreferredMemoryLimitBytes): added function
(WebCore::TextureManager::requestTexture): added viewport param
* platform/graphics/chromium/TextureManager.h: ditto
(WebCore::TextureManager::create): ditto
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp: ditto
(WebCore::CCLayerTreeHost::initialize): ditto
(WebCore::CCLayerTreeHost::beginCommitOnImplThread): ditto
(WebCore::CCLayerTreeHost::setViewport): ditto
(WebCore::CCLayerTreeHost::setVisible): ditto
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread): ditto

Source/WebKit/chromium:

* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Tue, 6 Dec 2011 10:52:00 +0000 (10:52 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-5.0/Skipped:
 - Skip one more failing tests because of missing testfont handling.
 - Remove non-existent files.
* platform/qt-5.0/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
* platform/qt-5.0/svg/custom/pointer-events-text-css-transform-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[TexMap][QT] Draw the borders of media and webgl elements in TexMap.
commit-queue@webkit.org [Tue, 6 Dec 2011 10:47:13 +0000 (10:47 +0000)]
[TexMap][QT] Draw the borders of media and webgl elements in TexMap.
https://bugs.webkit.org/show_bug.cgi?id=73817

GraphicsContext3D only draws the content of the WebGL canvas, not the additional
CSS such as the borders. TextureMapper should render the content of a
media/webgl layer before drawing the actual canvas.
This makes LayoutTests/compositing/webgl/webgl-reflection.html work.

Patch by Huang Dongsung <luxtella@company100.net> on 2011-12-06
Reviewed by Noam Rosenthal.

* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::setContentsNeedsDisplay):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::paintSelf):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r102043.
vsevik@chromium.org [Tue, 6 Dec 2011 10:37:45 +0000 (10:37 +0000)]
Unreviewed, rolling out r102043.
http://trac.webkit.org/changeset/102043
https://bugs.webkit.org/show_bug.cgi?id=73898

Breaks chromium mac-cg compilation. (Requested by vsevik on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-06

Source/WebCore:

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsToImage):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore::GraphicsLayerChromium::contentsLayer):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::setContents):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/ImageLayerChromiumTest.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefactoring: Editor::markAllMisspellingsAndBadGrammarInRanges should be refactored.
commit-queue@webkit.org [Tue, 6 Dec 2011 10:31:57 +0000 (10:31 +0000)]
Refactoring: Editor::markAllMisspellingsAndBadGrammarInRanges should be refactored.
https://bugs.webkit.org/show_bug.cgi?id=73628

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-06
Reviewed by Hajime Morita.

Extracted a code for adding markers and replacing misspelled words from WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges.

No new tests. covered by existing tests.

* editing/Editor.cpp:
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  Extracted a code for adding markers and replacing missplled words, and moved to markAndReplaceFor.
(WebCore::Editor::markAndReplaceFor):
* editing/Editor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Mac] Building debug version only fails.
zeno.albisser@nokia.com [Tue, 6 Dec 2011 10:06:46 +0000 (10:06 +0000)]
[Qt][Mac] Building debug version only fails.
https://bugs.webkit.org/show_bug.cgi?id=73895

WebKit pro/pri files should not explicitly adjust
the debug_and_release settings.

Reviewed by Kenneth Rohde Christiansen.

* declarative/experimental/experimental.pri:
* declarative/public.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Audits] Implement "Stop" button and progress bar instead of spinner.
apavlov@chromium.org [Tue, 6 Dec 2011 10:05:07 +0000 (10:05 +0000)]
Web Inspector: [Audits] Implement "Stop" button and progress bar instead of spinner.
https://bugs.webkit.org/show_bug.cgi?id=73626

Reviewed by Yury Semikhatsky.

* English.lproj/localizedStrings.js:
* inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView):
(WebInspector.AuditLauncherView.prototype._setAuditRunning):
(WebInspector.AuditLauncherView.prototype._launchButtonClicked):
(WebInspector.AuditLauncherView.prototype._createLauncherUI):
(WebInspector.AuditLauncherView.prototype._updateResourceProgress):
(WebInspector.AuditLauncherView.prototype._updateButton):
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
(WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.documentLoaded):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
(WebInspector.AuditRules.CacheControlRule.prototype.doRun):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.onDocumentAvailable):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.onDocumentAvailable):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun.resultCallback):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun):
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel):
(WebInspector.AuditsPanel.prototype._executeAudit.ruleResultReadyCallback):
(WebInspector.AuditsPanel.prototype._executeAudit):
(WebInspector.AuditsPanel.prototype._auditFinishedCallback):
(WebInspector.AuditsPanel.prototype.terminateAudit):
(WebInspector.AuditCategory.prototype.run):
(WebInspector.AuditRule.prototype.run):
(WebInspector.AuditRule.prototype.doRun):
(WebInspector.AuditProgressMonitor):
(WebInspector.AuditProgressMonitor.prototype.setTotalWork):
(WebInspector.AuditProgressMonitor.prototype.worked):
(WebInspector.AuditProgressMonitor.prototype.get indeterminate):
(WebInspector.AuditProgressMonitor.prototype.done):
(WebInspector.AuditProgressMonitor.prototype.get canceled):
(WebInspector.AuditProgressMonitor.prototype.set canceled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<style scoped>: disable on Windows by default
rolandsteiner@chromium.org [Tue, 6 Dec 2011 08:38:54 +0000 (08:38 +0000)]
<style scoped>: disable on Windows by default
https://bugs.webkit.org/show_bug.cgi?id=73893

Reviewed by Andreas Kling.

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] [WK2] MiniBrowser assert on startup in debug build after r101713
commit-queue@webkit.org [Tue, 6 Dec 2011 08:38:54 +0000 (08:38 +0000)]
[Qt] [WK2] MiniBrowser assert on startup in debug build after r101713
https://bugs.webkit.org/show_bug.cgi?id=73874

This change partially reverts r101713 restoring original behaviour for
KUrl creation from empty string and fixes asserts in debug build.

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-12-06
Reviewed by Alexey Proskuryakov.

No new tests. Tests from r101713 pass.

* platform/KURL.cpp:
(WebCore::KURL::init):
(WebCore::KURL::parse):
* platform/KURL.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse HashMap<OwnPtr> for EventListenerMap's internal map.
kling@webkit.org [Tue, 6 Dec 2011 08:21:43 +0000 (08:21 +0000)]
Use HashMap<OwnPtr> for EventListenerMap's internal map.
<http://webkit.org/b/73761>

Reviewed by Benjamin Poulain.

Changed the value type of EventListenerMap::m_hashMap to OwnPtr<EventListenerVector>.
This means we no longer need to manually delete the vectors when taking them out of
the map, which makes the code a little prettier.

A few tweaks were necessary; release() instead of leakPtr() when switching modes
and adoptPtr()/get() sprinkled as needed.

* dom/EventListenerMap.h:
* dom/EventListenerMap.cpp:
(WebCore::EventListenerMap::clear):
(WebCore::EventListenerMap::add):
(WebCore::EventListenerMap::remove):
(WebCore::EventListenerMap::find):
(WebCore::EventListenerMap::removeFirstEventListenerCreatedFromMarkup):
(WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Refactoring] In webkitpy/bindings/main.py, replace subprocess.Popen() with Executive
haraken@chromium.org [Tue, 6 Dec 2011 08:05:11 +0000 (08:05 +0000)]
[Refactoring] In webkitpy/bindings/main.py, replace subprocess.Popen() with Executive
https://bugs.webkit.org/show_bug.cgi?id=73637

Reviewed by Adam Barth.

This patch replaces subprocess.Popen() with Executive, similar to other
Python scripts in webkitpy/. I manually confirmed that run-bindings-tests
works well for cases where no exception is raised, no exception is raised
but diff is found, and ScriptError is raised.

* Scripts/run-bindings-tests:
(main):
* Scripts/webkitpy/bindings/main.py: Replaces subprocess.Popen() with Executive.
(BindingsTests.__init__):
(BindingsTests.generate_from_idl):
(BindingsTests.generate_supplemental_dependency):
(BindingsTests.detect_changes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Tue, 6 Dec 2011 08:00:53 +0000 (08:00 +0000)]
[Qt] Unreviewed gardening.

Layout Test fast/forms/input-step-as-double.html fails after running touch event tests
https://bugs.webkit.org/show_bug.cgi?id=71181

* platform/qt/Skipped: Skip fast/forms/input-step-as-double.html until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Tue, 6 Dec 2011 07:51:13 +0000 (07:51 +0000)]
[Qt] Unreviewed gardening.

New test introduced in r102048 fails on Qt-WK1
https://bugs.webkit.org/show_bug.cgi?id=73366

* platform/qt-wk1/Skipped: Skip fast/events/dont-loose-last-event.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[MutationObservers] Enable in Chromium trunk
commit-queue@webkit.org [Tue, 6 Dec 2011 07:49:49 +0000 (07:49 +0000)]
[MutationObservers] Enable in Chromium trunk
https://bugs.webkit.org/show_bug.cgi?id=73851

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-12-05
Reviewed by Ojan Vafai.

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agochromium build fix
jamesr@google.com [Tue, 6 Dec 2011 07:45:24 +0000 (07:45 +0000)]
chromium build fix

* src/WebLayerTreeView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[MutationObservers] Support 'attributes' mutation records for element.removeAttribute
commit-queue@webkit.org [Tue, 6 Dec 2011 07:37:07 +0000 (07:37 +0000)]
[MutationObservers] Support 'attributes' mutation records for element.removeAttribute
https://bugs.webkit.org/show_bug.cgi?id=73880

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-12-05
Reviewed by Ojan Vafai.

Source/WebCore:

* dom/Element.cpp:
(WebCore::enqueueAttributesMutationRecord):
(WebCore::Element::removeAttribute):

LayoutTests:

* fast/mutation/observe-attributes-expected.txt:
* fast/mutation/observe-attributes.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRollout http://trac.webkit.org/changeset/102019, dependent has not
jamesr@google.com [Tue, 6 Dec 2011 07:24:07 +0000 (07:24 +0000)]
Rollout trac.webkit.org/changeset/102019, dependent has not
landed in chromium

* WebKit.gyp:
* public/WebContentLayer.h: Added.
* public/WebExternalTextureLayer.h: Added.
* public/WebLayer.h: Added.
* public/WebLayerClient.h: Added.
* public/WebLayerTreeView.h: Added.
* public/WebLayerTreeViewClient.h: Added.
* src/WebLayerTreeView.cpp:
* src/WebLayerTreeViewImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSet opaque flag for WebGLLayerChromium
commit-queue@webkit.org [Tue, 6 Dec 2011 06:56:03 +0000 (06:56 +0000)]
Set opaque flag for WebGLLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=73876

Patch by Dana Jansens <danakj@chromium.org> on 2011-12-05
Reviewed by James Robinson.

Source/WebCore:

New unit test in tests/WebGLLayerChromiumTest.cpp

* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::platformLayer):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/WebGLLayerChromiumTest.cpp: Added.
(WebKit::CompositorMockWebGraphicsContext3D::create):
(WebKit::CompositorMockWebGraphicsContext3D::makeContextCurrent):
(WebKit::CompositorMockWebGraphicsContext3D::createProgram):
(WebKit::CompositorMockWebGraphicsContext3D::createShader):
(WebKit::CompositorMockWebGraphicsContext3D::getShaderiv):
(WebKit::CompositorMockWebGraphicsContext3D::getProgramiv):
(WebKit::CompositorMockWebGraphicsContext3D::getContextAttributes):
(WebKit::CompositorMockWebGraphicsContext3D::CompositorMockWebGraphicsContext3D):
(WebKit::createGraphicsContext):
(WebKit::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpstream the Cursor implementation of iOS
benjamin@webkit.org [Tue, 6 Dec 2011 06:31:37 +0000 (06:31 +0000)]
Upstream the Cursor implementation of iOS
https://bugs.webkit.org/show_bug.cgi?id=73724

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-05
Reviewed by David Kilzer.

iOS does not need to support the Cursor of WebKit. For compatibility, Cursor
is implemented as an empty class on the platform.

* Configurations/WebCore.xcconfig:
* WebCore.xcodeproj/project.pbxproj:
* platform/Cursor.h:
(WebCore::Cursor::Cursor):
* platform/ios/CursorIOS.cpp: Added.
(WebCore::cursor):
(WebCore::pointerCursor):
(WebCore::crossCursor):
(WebCore::handCursor):
(WebCore::moveCursor):
(WebCore::iBeamCursor):
(WebCore::waitCursor):
(WebCore::helpCursor):
(WebCore::eastResizeCursor):
(WebCore::northResizeCursor):
(WebCore::northEastResizeCursor):
(WebCore::northWestResizeCursor):
(WebCore::southResizeCursor):
(WebCore::southEastResizeCursor):
(WebCore::southWestResizeCursor):
(WebCore::westResizeCursor):
(WebCore::northSouthResizeCursor):
(WebCore::eastWestResizeCursor):
(WebCore::northEastSouthWestResizeCursor):
(WebCore::northWestSouthEastResizeCursor):
(WebCore::columnResizeCursor):
(WebCore::rowResizeCursor):
(WebCore::middlePanningCursor):
(WebCore::eastPanningCursor):
(WebCore::northPanningCursor):
(WebCore::northEastPanningCursor):
(WebCore::northWestPanningCursor):
(WebCore::southPanningCursor):
(WebCore::southEastPanningCursor):
(WebCore::southWestPanningCursor):
(WebCore::westPanningCursor):
(WebCore::verticalTextCursor):
(WebCore::cellCursor):
(WebCore::contextMenuCursor):
(WebCore::noDropCursor):
(WebCore::notAllowedCursor):
(WebCore::progressCursor):
(WebCore::aliasCursor):
(WebCore::zoomInCursor):
(WebCore::zoomOutCursor):
(WebCore::copyCursor):
(WebCore::noneCursor):
(WebCore::grabCursor):
(WebCore::grabbingCursor):
(WebCore::determineHotSpot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] GIF image test crashes on 32- and 64-bit Release
noel.gordon@gmail.com [Tue, 6 Dec 2011 06:20:00 +0000 (06:20 +0000)]
[GTK] GIF image test crashes on 32- and 64-bit Release
https://bugs.webkit.org/show_bug.cgi?id=73812

Reviewed by Adam Barth.

Call resize() on the image pixel backing store after allocation to see if
that stops the GIF image decoder animation tests crashes on GTK.

No new tests, covered by exiting tests ...
  fast/backgrounds/animated-gif-as-background.html
  fast/images/dont-crash-with-null-gif-frames.html
  fast/images/gif-loop-count.html

* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageFrame::setSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCould save a lot of memory in CharacterData by not always storing a String
arv@chromium.org [Tue, 6 Dec 2011 06:13:01 +0000 (06:13 +0000)]
Could save a lot of memory in CharacterData by not always storing a String
https://bugs.webkit.org/show_bug.cgi?id=72404

Reviewed by Ojan Vafai.

When a Text node is created by the parser we check if the string is all whitespace
and if so we put it in the AtomicString table so that all future identical whitespace
strings can share the StringImpl.

No new tests. Covered by existing tests.

* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLNames::isAllWhitespace):
(WebCore::HTMLConstructionSite::insertTextNode):

    If we do not know whether the string is all whitespace this now checks the string
    If the string is all whitespace we create an AtomicString for it.

* html/parser/HTMLConstructionSite.h:
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeadingNonWhitespace): We never cared about the return value here.
(WebCore::HTMLTreeBuilder::processCharacterBuffer): Pass WhitespaceMode in the case we know whether the string is all whitespace or not.
(WebCore::HTMLTreeBuilder::defaultForInTableText): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate KURL's copy copyASCII to avoid String::characters()
benjamin@webkit.org [Tue, 6 Dec 2011 06:10:15 +0000 (06:10 +0000)]
Update KURL's copy copyASCII to avoid String::characters()
https://bugs.webkit.org/show_bug.cgi?id=73794

Reviewed by Andreas Kling.

When the String is already on 8 bits, we can simply copy the
data. In the 16 bits case, everything remains the same.

* platform/KURL.cpp:
(WebCore::copyASCII):
(WebCore::appendASCII):
(WebCore::KURL::init):
(WebCore::KURL::parse):
(WebCore::KURL::copyToBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] MiniBrowser should default to touch behavior
commit-queue@webkit.org [Tue, 6 Dec 2011 05:55:18 +0000 (05:55 +0000)]
[Qt] MiniBrowser should default to touch behavior
https://bugs.webkit.org/show_bug.cgi?id=73863

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-12-05
Reviewed by Chang Shu.

MiniBrowser currently defaults to the traditional desktop behaviour
instead of touch behaviour which is prefered.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(printHelp):
(MiniBrowserApplication::handleUserOptions):
* MiniBrowser/qt/MiniBrowserApplication.h:
(WindowOptions::WindowOptions):
(WindowOptions::setUseTraditionalDesktopBehavior):
(WindowOptions::useTraditionalDesktopBehavior):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=73683
commit-queue@webkit.org [Tue, 6 Dec 2011 05:30:08 +0000 (05:30 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=73683
Implement KeyframeValueList::operator=() and KeyframeValueList::swap().

Patch by Yong Li <yoli@rim.com> on 2011-12-05
Reviewed by Darin Adler.

No new tests as no functional change.

* platform/graphics/GraphicsLayer.h:
(WebCore::KeyframeValueList::operator=): Added
(WebCore::KeyframeValueList::swap): Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] setNeedsCommit on non-composited host layers should trigger commit
enne@google.com [Tue, 6 Dec 2011 05:05:06 +0000 (05:05 +0000)]
[chromium] setNeedsCommit on non-composited host layers should trigger commit
https://bugs.webkit.org/show_bug.cgi?id=73711

Reviewed by James Robinson.

Source/WebCore:

Pipe non-composited content host syncs to setNeedsCommit.

Since now the NonCompositedContentHost generates setNeedsCommit, don't
call it unnecessarily, e.g. calling setBackgroundColor to the same
color each frame should not retrigger more commits.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setAnchorPoint):
(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::setChildrenTransform):
(WebCore::GraphicsLayerChromium::setMasksToBounds):
(WebCore::GraphicsLayerChromium::setBackgroundColor):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setNeedsCommit):
(WebCore::LayerChromium::setAnchorPoint):
(WebCore::LayerChromium::setAnchorPointZ):
(WebCore::LayerChromium::setBackgroundColor):
(WebCore::LayerChromium::setMasksToBounds):
(WebCore::LayerChromium::setMaskLayer):
(WebCore::LayerChromium::setOpacity):
(WebCore::LayerChromium::setOpaque):
(WebCore::LayerChromium::setPosition):
(WebCore::LayerChromium::setSublayerTransform):
(WebCore::LayerChromium::setTransform):
(WebCore::LayerChromium::setScrollPosition):
(WebCore::LayerChromium::setScrollable):
(WebCore::LayerChromium::setDoubleSided):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setReplicaLayer):
* platform/graphics/chromium/NonCompositedContentHost.cpp:
(WebCore::NonCompositedContentHost::notifySyncRequired):
* platform/graphics/chromium/NonCompositedContentHost.h:

Source/WebKit/chromium:

Add some tests to make sure that modifying the noncomposited content
host triggers commits.

Properties that trigger setNeedsCommit should only do so when the
property changes. Additionally, make more property changes properly
trigger commits.

* tests/LayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agosmall refactor of RenderFlexibleBox
tony@chromium.org [Tue, 6 Dec 2011 04:59:11 +0000 (04:59 +0000)]
small refactor of RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=73854

Reviewed by Darin Adler.

No new tests, just a refactor.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::isLeftToRightFlow): Inline isReverseFlow since it's only used in one place.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Rename startEdge
to mainAxisOffset.  Rename logicalTop to crossAxisOffset.  Get rid of
logicalLeft local variable since it's confusing.  Move shouldFlipMainAxis
out of the for loop to avoid computing it each iteration.
* rendering/RenderFlexibleBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHeap-buffer-overflow in WebCore::HTMLTreeBuilder::processEndTag
commit-queue@webkit.org [Tue, 6 Dec 2011 04:46:01 +0000 (04:46 +0000)]
Heap-buffer-overflow in WebCore::HTMLTreeBuilder::processEndTag
https://bugs.webkit.org/show_bug.cgi?id=73765

Patch by Florin Malita <fmalita@google.com> on 2011-12-05
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/parser/foreign-content-crash.html

Use m_tree.currentNode() instead of m_tree.currentElement() as the top node is not always an Element.

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processEndTag):

LayoutTests:

* fast/parser/foreign-content-crash-expected.txt: Added.
* fast/parser/foreign-content-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAllow the ImageBuffers used by SVG filters to be accelerated
senorblanco@chromium.org [Tue, 6 Dec 2011 04:16:28 +0000 (04:16 +0000)]
Allow the ImageBuffers used by SVG filters to be accelerated
https://bugs.webkit.org/show_bug.cgi?id=73842

Reviewed by Kenneth Russell.

Source/WebCore:

Regressions covered by existing SVG tests; new functionality to be
tested by the API exposed on Internals.

* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setAcceleratedFiltersEnabled):
(WebCore::Settings::acceleratedFiltersEnabled):
* platform/graphics/filters/FETile.cpp:
(WebCore::FETile::platformApplySoftware):
* platform/graphics/filters/Filter.h:
(WebCore::Filter::Filter):
(WebCore::Filter::renderingMode):
(WebCore::Filter::setRenderingMode):
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::asImageBuffer):
(WebCore::FilterEffect::createImageBufferResult):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::platformTransformColorSpace):
* rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):
* rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::createTileImage):
* rendering/svg/SVGImageBufferTools.cpp:
(WebCore::SVGImageBufferTools::createImageBuffer):
* rendering/svg/SVGImageBufferTools.h:
* testing/Internals.cpp:
(WebCore::Internals::setAcceleratedFiltersEnabled):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit/chromium:

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setAcceleratedFiltersEnabled):
* src/WebSettingsImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Frame is not being showed in the screen when frameLoadCompleted is called
igor.oliveira@openbossa.org [Tue, 6 Dec 2011 04:07:02 +0000 (04:07 +0000)]
[Qt][WK2] Frame is not being showed in the screen when frameLoadCompleted is called
https://bugs.webkit.org/show_bug.cgi?id=73850

WebKit2 has a mechanism to prevent  the composited layer tree of the outgoing page
from being torn down or updated until the incoming page has layout. However, for simple
pages, when the frame is loaded the page is not rendered in the screen.

This patch fixes this bug calling LayerTreeHostQt::scheduleLayerFlush when m_layerFlushSchedulingEnabled
is true.

Reviewed by Noam Rosenthal.

* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::setLayerFlushSchedulingEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpstream htmlSelectMultipleItems needed for <select multiple> by iOS
benjamin@webkit.org [Tue, 6 Dec 2011 03:48:35 +0000 (03:48 +0000)]
Upstream htmlSelectMultipleItems needed for <select multiple> by iOS
https://bugs.webkit.org/show_bug.cgi?id=73734

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-05
Reviewed by David Kilzer.

* platform/DefaultLocalizationStrategy.cpp:
(WebCore::DefaultLocalizationStrategy::htmlSelectMultipleItems):
* platform/DefaultLocalizationStrategy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse HashMap<OwnPtr> in CrossOriginPreflightResultCache
darin@apple.com [Tue, 6 Dec 2011 02:55:47 +0000 (02:55 +0000)]
Use HashMap<OwnPtr> in CrossOriginPreflightResultCache
https://bugs.webkit.org/show_bug.cgi?id=73785

Reviewed by Andreas Kling.

* loader/CrossOriginPreflightResultCache.cpp:
(WebCore::CrossOriginPreflightResultCache::appendEntry): Changed code to use set
instead of add, since it wants to replace existing entries. Also removed leakPtr
and removed the FIXME that documented the memory leak now fixed here.
(WebCore::CrossOriginPreflightResultCache::canSkipPreflight): Removed unneeded
std:: prefix here and also unneeded explicit delete call.
(WebCore::CrossOriginPreflightResultCache::empty): Removed unneeded deleteAllValues
call here.

* loader/CrossOriginPreflightResultCache.h: Make mapped value of the
CrossOriginPreflightResultHashMap be OwnPtr instead of raw pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd HashMap::keys() and HashMap::values() for easy iteration of hash map keys and...
andersca@apple.com [Tue, 6 Dec 2011 02:17:22 +0000 (02:17 +0000)]
Add HashMap::keys() and HashMap::values() for easy iteration of hash map keys and values in C++11.

Reviewed by Darin Adler.

* wtf/HashMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkit.py: Really fix the printing of StringImpl now that 8-bit strings are present.
kubo@profusion.mobi [Tue, 6 Dec 2011 02:07:23 +0000 (02:07 +0000)]
webkit.py: Really fix the printing of StringImpl now that 8-bit strings are present.
https://bugs.webkit.org/show_bug.cgi?id=73878

Reviewed by Tony Chang.

r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}.
r98785 made webkit.py always use m_data16, which does not work when
the string is an 8-bit string (such as KURL::string()).

I was not able to directly call StringImpl::is8Bit() in the Python
code, so I just reproduced the implementation there.

* gdb/webkit.py:
(WTFStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
(WTFStringPrinter.to_string):
(JSCUStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
(JSCUStringPrinter.to_string):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCreate StringImpl::empty() as an 8 bit string
msaboff@apple.com [Tue, 6 Dec 2011 02:06:48 +0000 (02:06 +0000)]
Create StringImpl::empty() as an 8 bit string
https://bugs.webkit.org/show_bug.cgi?id=73871

Reviewed by Oliver Hunt.

* wtf/text/StringStatics.cpp:
(WTF::StringImpl::empty): Changed to be an 8 bit string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSome small improvements to ContainerNode.h
darin@apple.com [Tue, 6 Dec 2011 02:04:16 +0000 (02:04 +0000)]
Some small improvements to ContainerNode.h
https://bugs.webkit.org/show_bug.cgi?id=73786

Reviewed by Alexey Proskuryakov.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::suspendPostAttachCallbacks): Added a FIXME comment about the
peculiar behavior of this function. Somehow the post-attach suspend state is both
global and specific to a certain Page object. That can't be right. If it was truly
global then this would be a static member function. If it was truly per-page, then
the related functions could not be static.

* dom/ContainerNode.h: Removed some unneeded argument names. Moved the hasChildNodes
function up with the other basic getters. Put the other getters, childNodeCount and
childNode, right after the basic getters. Used ASSERT_NO_EXCEPTION in all the basic
mutation functions so they can be used in a cleaner fashion in C++ code where we have
some reason to know an exception won't occur. Grouped all the overrides of functions
from Node into a single paragraph and used the OVERRIDE macro on all of them. Made the
queuePostAttachCallback and postAttachCallbacksAreSuspended functions protected.

* dom/Element.h: Moved the include of ExceptionCodePlaceholder.h into ContainerNode.h.

* dom/Node.cpp:
(WebCore::Node::lazyAttach): Use hasChildNodes instead of firstChild for clarity.
(WebCore::Node::isDescendantOf): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGet rid of KURL::KURL(ParsedURLStringTag, const char*);
benjamin@webkit.org [Tue, 6 Dec 2011 01:51:27 +0000 (01:51 +0000)]
Get rid of KURL::KURL(ParsedURLStringTag, const char*);
https://bugs.webkit.org/show_bug.cgi?id=73792

Reviewed by Andreas Kling.

In all cases where the constructor is used, the constructor
taking a String is as effective because the string is valid and converted
to String for m_string.

This patch remove the constructor KURL::KURL(ParsedURLStringTag, const char*)
and change the call sites that were using that constructor to build
empty URLs.

* dom/Document.cpp:
(WebCore::Document::initSecurityContext):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::init):
* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::createWindow):
* platform/KURL.cpp:
* platform/KURL.h:
* platform/KURLGoogle.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed extremely minor SVG filter pixel rebaselines for Lion.
timothy_horton@apple.com [Tue, 6 Dec 2011 01:41:16 +0000 (01:41 +0000)]
Unreviewed extremely minor SVG filter pixel rebaselines for Lion.

Mostly text antialiasing differences, all only noticeable at tolerances very near 0.

* platform/mac-snowleopard/svg/filters/feComposite-expected.png: Copied from LayoutTests/platform/mac/svg/filters/feComposite-expected.png.
* platform/mac-snowleopard/svg/filters/feLighting-crash-expected.png: Copied from LayoutTests/platform/mac/svg/filters/feLighting-crash-expected.png.
* platform/mac-snowleopard/svg/filters/feOffset-expected.png: Copied from LayoutTests/platform/mac/svg/filters/feOffset-expected.png.
* platform/mac-snowleopard/svg/filters/filter-on-tspan-expected.png: Copied from LayoutTests/platform/mac/svg/filters/filter-on-tspan-expected.png.
* platform/mac-snowleopard/svg/filters/filter-width-update-expected.png: Copied from LayoutTests/platform/mac/svg/filters/filter-width-update-expected.png.
* platform/mac-snowleopard/svg/filters/sourceAlpha-expected.png: Copied from LayoutTests/platform/mac/svg/filters/sourceAlpha-expected.png.
* platform/mac-snowleopard/svg/filters/subRegion-one-effect-expected.png: Copied from LayoutTests/platform/mac/svg/filters/subRegion-one-effect-expected.png.
* platform/mac-snowleopard/svg/filters/subRegion-two-effects-expected.png: Copied from LayoutTests/platform/mac/svg/filters/subRegion-two-effects-expected.png.
* platform/mac/svg/filters/feComposite-expected.png:
* platform/mac/svg/filters/feLighting-crash-expected.png:
* platform/mac/svg/filters/feOffset-expected.png:
* platform/mac/svg/filters/filter-on-tspan-expected.png:
* platform/mac/svg/filters/filter-width-update-expected.png:
* platform/mac/svg/filters/sourceAlpha-expected.png:
* platform/mac/svg/filters/subRegion-one-effect-expected.png:
* platform/mac/svg/filters/subRegion-two-effects-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Chromium fails to compile due to missing WebContentLayerClient.h
abarth@webkit.org [Tue, 6 Dec 2011 01:35:50 +0000 (01:35 +0000)]
[Chromium] Chromium fails to compile due to missing WebContentLayerClient.h
https://bugs.webkit.org/show_bug.cgi?id=73881

This patch adds a forwarding header to fix the downstream Windows build:
http://build.chromium.org/p/chromium.webkit/builders/Win%20Builder/builds/12955/steps/compile/logs/stdio

* public/WebContentLayerClient.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed feGaussianBlur rebaseline for Mac after r101638.
timothy_horton@apple.com [Tue, 6 Dec 2011 01:30:21 +0000 (01:30 +0000)]
Unreviewed feGaussianBlur rebaseline for Mac after r101638.

* platform/mac/svg/filters/feGaussianBlur-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a shim to fix the downstream Chromium compile. The real fix should
abarth@webkit.org [Tue, 6 Dec 2011 01:29:25 +0000 (01:29 +0000)]
Add a shim to fix the downstream Chromium compile.  The real fix should
be made downstream via http://codereview.chromium.org/8801036/, but the
Chromium tree is closed at the moment.

* public/WebRect.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove methods declared but never implemented with GOOGLEURL
benjamin@webkit.org [Tue, 6 Dec 2011 01:10:13 +0000 (01:10 +0000)]
Remove methods declared but never implemented with GOOGLEURL
https://bugs.webkit.org/show_bug.cgi?id=73795

Reviewed by Adam Barth.

* platform/KURL.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUp the "expected ram for each DRT instance" to 400MB instead of 300MB
eric@webkit.org [Tue, 6 Dec 2011 01:08:04 +0000 (01:08 +0000)]
Up the "expected ram for each DRT instance" to 400MB instead of 300MB
in hopes of making the Snow Leopard bot stop timing out.

Unreviewed.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.default_child_processes):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_default_child_processes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChange CSSFontSelector to use HashMap<OwnPtr>
darin@apple.com [Tue, 6 Dec 2011 01:03:53 +0000 (01:03 +0000)]
Change CSSFontSelector to use HashMap<OwnPtr>
https://bugs.webkit.org/show_bug.cgi?id=73781

Reviewed by Dan Bernstein.

* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::~CSSFontSelector): Removed calls to deleteAllValues.
(WebCore::CSSFontSelector::addFontFaceRule): Updated to use OwnPtr instead of raw
pointer for the entry in m_fontFaces and m_locallyInstalledFontFaces.
(WebCore::CSSFontSelector::getFontData): Updated to use OwnPtr instead of raw
pointer for the entry in m_fonts. Also removed an unneeded std:: prefix.

* css/CSSFontSelector.h: Made m_fontFaces, m_locallyInstalledFontFaces, and m_fonts
be HashMap<OwnPtr>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoV8RecursionScope should call didLeaveScriptContext when recursionLevel reaches zero
adamk@chromium.org [Tue, 6 Dec 2011 00:33:28 +0000 (00:33 +0000)]
V8RecursionScope should call didLeaveScriptContext when recursionLevel reaches zero
https://bugs.webkit.org/show_bug.cgi?id=73867

Reviewed by Adam Barth.

Moved V8RecursionScope into its own file, and moved
V8Proxy::didLeaveScriptContext into that file, along with a static
recursionLevel accessor, hiding the V8BindingPerIsolateData methods
from V8Proxy.

This will make it easy and less error-prone to use V8RecursionScope
properly. I plan to make use of it in V8LazyEventListener to fix
https://bugs.webkit.org/show_bug.cgi?id=73492.

No new tests, refactoring only.

* Target.pri:
* UseV8.cmake:
* WebCore.gypi:
* bindings/v8/V8Binding.h:
(WebCore::V8BindingPerIsolateData::incrementRecursionLevel): return the new recursion level.
(WebCore::V8BindingPerIsolateData::decrementRecursionLevel): return the new recursion level.
* bindings/v8/V8Proxy.cpp: remove didLeaveScriptContext.
(WebCore::V8Proxy::runScript): remove explicit call to didLeaveScriptContext.
(WebCore::V8Proxy::instrumentedCallFunction): remove explicit call to didLeaveScriptContext.
* bindings/v8/V8Proxy.h: remove didLeaveScriptContext.
* bindings/v8/V8RecursionScope.cpp: Added.
(WebCore::V8RecursionScope::didLeaveScriptContext): copied from V8Proxy.cpp.
* bindings/v8/V8RecursionScope.h: Added.
(WebCore::V8RecursionScope::V8RecursionScope):
(WebCore::V8RecursionScope::~V8RecursionScope):
(WebCore::V8RecursionScope::recursionLevel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConvert JSClassRef to use HashMap<OwnPtr>
darin@apple.com [Tue, 6 Dec 2011 00:17:34 +0000 (00:17 +0000)]
Convert JSClassRef to use HashMap<OwnPtr>
https://bugs.webkit.org/show_bug.cgi?id=73780

Reviewed by Andreas Kling.

* API/JSCallbackObjectFunctions.h:
(JSC::JSCallbackObject::getOwnPropertyNames): Use get() on the hash map
entries because the hash map now has an OwnPtr instead of a raw pointer.

* API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass): No need to initialize m_staticValues and
m_staticFunctions since they are now OwnPtr. Use adoptPtr when allocating.
Removed the code that gets and deletes existing entries, and just use set,
which now handles deletion automatically due to it being OwnPtr.
(OpaqueJSClass::~OpaqueJSClass): Replaced code to do all the deletion
with assertion-only NDEBUG-only code.
(OpaqueJSClassContextData::OpaqueJSClassContextData): Use adoptPtr when
allocating. Use OwnPtr when adding. Removed unneeded code to set
staticValues and staticFunctions to 0. Removed unneeded destructor.
(OpaqueJSClass::staticValues): Added get call. Also removed unneeded local.
(OpaqueJSClass::staticFunctions): Ditto.
(OpaqueJSClass::prototype): Added use of adoptPtr.

* API/JSClassRef.h: Made the static values and static functions tables
use OwnPtr for the entries. Also used OwnPtr for the pointers to the
tables themselves. Also removed ~OpaqueJSClassContextData(), letting
the compiler generate it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix for SecurityOrigin.cpp when neither BLOB nor FILE_SYSTEM are defined
benjamin@webkit.org [Tue, 6 Dec 2011 00:17:13 +0000 (00:17 +0000)]
Build fix for SecurityOrigin.cpp when neither BLOB nor FILE_SYSTEM are defined

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-05
Reviewed by David Kilzer.

When neither BLOB nor FILE_SYSTEM are defined, the parameter is unused.

* page/SecurityOrigin.cpp:
(WebCore::shouldUseInnerURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102064 268f45cc-cd09-0410-ab3c-d52691b4dbfc