darin [Sat, 18 Feb 2006 00:06:30 +0000 (00:06 +0000)]
* coding/coding-style.html: Mention other non-function brace cases.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12880
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Fri, 17 Feb 2006 23:48:17 +0000 (23:48 +0000)]
Reviewed by eric
This test appears to be occasionally hanging. Disabling it while
I figure out why.
* editing/selection/drag-to-contenteditable-iframe.html: Removed.
* editing/selection/drag-to-contenteditable-iframe.html-disabled: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12879
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 17 Feb 2006 23:36:26 +0000 (23:36 +0000)]
2006-02-17 Eric Seidel <eseidel@apple.com>
Reviewed by Beth.
* Scripts/build-webkit: make win32 actually report errors
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12878
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 17 Feb 2006 23:08:34 +0000 (23:08 +0000)]
2006-02-17 Eric Seidel <eseidel@apple.com>
Reviewed by adele.
* Scripts/run-webkit-tests: Ignore quicktime plugin leaks
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12877
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 17 Feb 2006 22:49:43 +0000 (22:49 +0000)]
2006-02-17 Eric Seidel <eseidel@apple.com>
Reviewed by adele.
* Scripts/run-webkit-tests: Ignore flash leaks
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12876
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 17 Feb 2006 22:18:11 +0000 (22:18 +0000)]
Reviewed by Tim H.
Added left position and margin-bottom to blog footer.
* css/main.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12875
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Fri, 17 Feb 2006 19:15:06 +0000 (19:15 +0000)]
Reviewed by Beth.
Adding isEdited/setEdited hooks so onChange will fire for the new text fields.
* rendering/RenderTextField.cpp:
(WebCore::m_dirty):
(WebCore::RenderTextField::updateFromElement): setEdited to false when value attribute has changed.
(WebCore::RenderTextField::subtreeHasChanged): setEdited to true when anonymous editable div has changed.
* rendering/RenderTextField.h:
(WebCore::RenderTextField::isEdited):
(WebCore::RenderTextField::setEdited):
(WebCore::RenderTextField::isTextField):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12874
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 17 Feb 2006 18:31:22 +0000 (18:31 +0000)]
Reviewed by John.
- Fixed <rdar://problem/
4448534> TOT REGRESSION: crash in KJS::
Bindings::Instance::deref when leaving page @ gigaom.com
* bindings/c/c_instance.cpp:
(KJS::Bindings::CInstance::~CInstance): Since we cache the class object
globally, we shouldn't delete it, so don't.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12873
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vicki [Fri, 17 Feb 2006 09:54:15 +0000 (09:54 +0000)]
Reviewed by Justin.
Get rid of handleFocusOut on text fields and textareas - move this functionality to the place
where we resign focus on the previous node in setFocusNode. Add isTextField on RenderObject
as one way to distinguish from contenteditable elements - Win IE does not fire onChange for
contenteditable elements, so we won't either. Also, expose the dirty bit variables previously
checked in handleFocusOut methods in isEdited() and setEdited().
Fixes the following bugs:
<rdar://problem/
4315673> REGRESSION (1.2.2 - 1.3): onChange and onFocus events firing order differs for mouse click and tab (7227)
<rdar://problem/
4447009> for text fields, onChange should fire before onBlur to match Win IE
Test case is on the way.
* dom/DocumentImpl.cpp:
(WebCore::DocumentImpl::setFocusNode): For textareas and text fields, fire a change event
on the node that is resigning focus. Make sure the blur event fires after the change event -
4447009.
* rendering/render_form.cpp:
(WebCore::RenderLineEdit::slotReturnPressed): Replace call to handleFocusOut with equivalent code.
(WebCore::RenderLineEdit::isEdited): Added.
(WebCore::RenderLineEdit::setEdited): Added.
(WebCore::RenderTextArea::setEdited): Added.
* rendering/render_form.h:
(WebCore::RenderLineEdit::isTextField): Added.
(WebCore::RenderTextArea::isTextArea): Make this non-virtual.
(WebCore::RenderTextArea::isEdited): Added.
* rendering/render_object.h:
(WebCore::RenderObject::isEdited): Added.
(WebCore::RenderObject::setEdited): Added.
(WebCore::RenderObject::isTextField): Added.
* rendering/render_replaced.h: Remove handleFocusOut().
* rendering/render_replaced.cpp: Ditto.
(WebCore::RenderWidget::eventFilter): Remove call to handleFocusOut(). Safe to do here,
since we call setFocusNode immediately beforehand.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12872
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Fri, 17 Feb 2006 09:49:37 +0000 (09:49 +0000)]
LayoutTests:
Reviewed by Anders Carlsson.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7265
REGRESSION: noscript, noframes, nolayer, noembed tags insert break inside paragraph tag
* fast/parser/nofoo-tags-inside-paragraph-expected.checksum: Added.
* fast/parser/nofoo-tags-inside-paragraph-expected.png: Added.
* fast/parser/nofoo-tags-inside-paragraph-expected.txt: Added.
* fast/parser/nofoo-tags-inside-paragraph.html: Added.
WebCore:
Test: fast/parser/nofoo-tags-inside-paragraph.html
Reviewed by Anders Carlsson.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7265
REGRESSION: noscript, noframes, nolayer, noembed tags insert break inside paragraph tag
* khtml/html/htmlparser.cpp:
(HTMLParser::isInline): Treat noframes, nolayer, noembed and skipped noscript
as inline elements.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12871
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Fri, 17 Feb 2006 09:43:40 +0000 (09:43 +0000)]
Reviewed by Hyatt.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7235
Pure CSS Tooltips method renders wrong and creates artifacts
* manual-tests/bugzilla-7235.html: Added.
* rendering/render_box.cpp:
(WebCore::RenderBox::absolutePosition): Copied in here the logic for positioning
relative to a relpositioned inline from RenderLayer::updateLayerPosition.
(WebCore::RenderBox::computeAbsoluteRepaintRect): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12870
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Fri, 17 Feb 2006 09:37:34 +0000 (09:37 +0000)]
LayoutTests:
Reviewed by Maciej.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7218
Text underlined on mouse over
* fast/css/universal-hover-quirk-expected.checksum: Added.
* fast/css/universal-hover-quirk-expected.png: Added.
* fast/css/universal-hover-quirk-expected.txt: Added.
* fast/css/universal-hover-quirk.html: Added.
WebCore:
Test: fast/css/universal-hover-quirk.html
Reviewed by Maciej.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7218
Text underlined on mouse over
* css/cssstyleselector.cpp:
(WebCore::CSSStyleSelector::checkOneSelector): Prevent *:hover and *:active
from matching anything in quirks mode.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12869
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Fri, 17 Feb 2006 09:31:35 +0000 (09:31 +0000)]
LayoutTests:
Reviewed by Dave Hyatt.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7216
white-space: pre-wrap collapses leading whitespace following a newline
* fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum: Added.
* fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png: Added.
* fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt: Added.
* fast/text/whitespace/pre-wrap-spaces-after-newline.html: Added.
WebCore:
Test: fast/text/whitespace/pre-wrap-spaces-after-newline.html
Reviewed by Dave Hyatt.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7216
white-space: pre-wrap collapses leading whitespace following a newline
* rendering/bidi.cpp:
(khtml::RenderBlock::bidiReorderLine): Use previousLineBrokeCleanly instead of
resetBidiAtEnd now that the former is always correct.
(khtml::RenderBlock::layoutInlineChildren): Use new skipTrailingNewline flag.
(khtml::RenderBlock::findNextLineBreak): Set previousLineBrokeCleanly for line breaks
caused by newlines as well. Added skipTrailingNewline flag.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12868
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomernic [Fri, 17 Feb 2006 08:02:39 +0000 (08:02 +0000)]
Reviewed by Adele.
<rdar://problem/
4193286> enabledPlugin returns a non-NULL object even when plugins are
disabled (4140)
* khtml/ecma/kjs_navigator.cpp:
(KJS::MimeType::getValueProperty):
Only return a Plugin object for the "enabledPlugin" property if plugins are enabled. This
matches what other browsers do.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12867
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 17 Feb 2006 05:36:46 +0000 (05:36 +0000)]
Reviewed by Maciej.
Fixes PNGs with 8bit alpha on IE.
* css/ie.css: attach the pngbehavior.htc to img tags
* images/blank.png: Added.
* index.html: add the width and height to the download img
* pngbehavior.htc: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12866
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 17 Feb 2006 01:08:41 +0000 (01:08 +0000)]
Reviewed by Eric and Justin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7310
fix leaks by using RefPtr more
* bindings/objc/DOM.mm:
(-[DOMDocument adoptNode:]):
(-[DOMDocument createElement:]):
(-[DOMDocument createDocumentFragment]):
(-[DOMDocument createTextNode:]):
(-[DOMDocument createComment:]):
(-[DOMDocument createCDATASection:]):
(-[DOMDocument createProcessingInstruction::]):
(-[DOMDocument createEntityReference:]):
(-[DOMDocument importNode::]):
(-[DOMDocument createElementNS::]):
(-[DOMDocument createRange]):
(-[DOMDocument createCSSStyleDeclaration]):
(-[DOMDocument createNodeIterator::::]):
(-[DOMDocument createTreeWalker::::]):
* bindings/objc/DOMCSS.mm:
(-[DOMCSSStyleDeclaration getPropertyCSSValue:]):
* bindings/objc/DOMEvents.mm:
(-[DOMDocument createEvent:]):
* bridge/mac/MacFrame.h:
* bridge/mac/MacFrame.mm:
(WebCore::MacFrame::MacFrame):
(WebCore::MacFrame::freeClipboard):
(WebCore::MacFrame::setView):
(WebCore::MacFrame::wheelEvent):
(WebCore::MacFrame::openURLFromPageCache):
(WebCore::MacFrame::mouseDownViewIfStillGood):
(WebCore::MacFrame::khtmlMouseMoveEvent):
(WebCore::MacFrame::dispatchCPPEvent):
(WebCore::MacFrame::mouseDown):
(WebCore::MacFrame::mouseDragged):
(WebCore::MacFrame::mouseUp):
(WebCore::MacFrame::mouseMoved):
(WebCore::MacFrame::sendContextMenuEvent):
(WebCore::MacFrame::dispatchDragSrcEvent):
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge convertToDOMRange:]):
(-[WebCoreFrameBridge convertNSRangeToDOMRange:]):
(-[WebCoreFrameBridge selectNSRange:]):
(-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]):
(-[WebCoreFrameBridge typingStyle]):
(-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
(-[WebCoreFrameBridge dragExitedWithDraggingInfo:]):
(-[WebCoreFrameBridge concludeDragForDraggingInfo:]):
* css/css_computedstyle.cpp:
(WebCore::CSSComputedStyleDeclarationImpl::CSSComputedStyleDeclarationImpl):
(WebCore::CSSComputedStyleDeclarationImpl::cssText):
(WebCore::CSSComputedStyleDeclarationImpl::setCssText):
(WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclarationImpl::getPropertyValue):
(WebCore::CSSComputedStyleDeclarationImpl::removeProperty):
(WebCore::CSSComputedStyleDeclarationImpl::setProperty):
(WebCore::CSSComputedStyleDeclarationImpl::item):
(WebCore::CSSComputedStyleDeclarationImpl::copyInheritableProperties):
(WebCore::CSSComputedStyleDeclarationImpl::copy):
(WebCore::CSSComputedStyleDeclarationImpl::makeMutable):
* css/css_computedstyle.h:
* css/css_grammar.y:
* css/css_ruleimpl.cpp:
(WebCore::CSSStyleRuleImpl::~CSSStyleRuleImpl):
(WebCore::CSSStyleRuleImpl::setDeclaration):
* css/css_ruleimpl.h:
(DOM::CSSStyleRuleImpl::style):
(DOM::CSSStyleRuleImpl::declaration):
* css/css_valueimpl.cpp:
(WebCore::propertyID):
(WebCore::quoteStringIfNeeded):
(WebCore::CSSStyleDeclarationImpl::getPropertyCSSValue):
(WebCore::CSSStyleDeclarationImpl::getPropertyValue):
(WebCore::CSSStyleDeclarationImpl::getPropertyPriority):
(WebCore::CSSStyleDeclarationImpl::getPropertyShorthand):
(WebCore::CSSStyleDeclarationImpl::isPropertyImplicit):
(WebCore::CSSStyleDeclarationImpl::setProperty):
(WebCore::CSSStyleDeclarationImpl::removeProperty):
(WebCore::CSSStyleDeclarationImpl::isPropertyName):
(WebCore::CSSMutableStyleDeclarationImpl::getPropertyValue):
(WebCore::CSSMutableStyleDeclarationImpl::get4Values):
(WebCore::CSSMutableStyleDeclarationImpl::getShortHandValue):
(WebCore::CSSMutableStyleDeclarationImpl::getPropertyCSSValue):
(WebCore::CSSMutableStyleDeclarationImpl::removeProperty):
(WebCore::CSSMutableStyleDeclarationImpl::setProperty):
(WebCore::CSSMutableStyleDeclarationImpl::setStringProperty):
(WebCore::CSSMutableStyleDeclarationImpl::setImageProperty):
(WebCore::CSSMutableStyleDeclarationImpl::parseDeclaration):
(WebCore::CSSMutableStyleDeclarationImpl::setLengthProperty):
(WebCore::CSSMutableStyleDeclarationImpl::item):
(WebCore::CSSMutableStyleDeclarationImpl::cssText):
(WebCore::CSSMutableStyleDeclarationImpl::setCssText):
(WebCore::CSSMutableStyleDeclarationImpl::copyBlockProperties):
(WebCore::CSSStyleDeclarationImpl::copyPropertiesInSet):
(WebCore::CSSMutableStyleDeclarationImpl::removePropertiesInSet):
(WebCore::CSSMutableStyleDeclarationImpl::makeMutable):
(WebCore::CSSMutableStyleDeclarationImpl::copy):
(WebCore::CSSInheritedValueImpl::cssText):
(WebCore::CSSInitialValueImpl::cssText):
(WebCore::CSSValueListImpl::append):
(WebCore::CSSValueListImpl::cssText):
(WebCore::CSSPrimitiveValueImpl::CSSPrimitiveValueImpl):
(WebCore::CSSPrimitiveValueImpl::cleanup):
(WebCore::CSSPrimitiveValueImpl::setStringValue):
(WebCore::CSSPrimitiveValueImpl::getStringValue):
(WebCore::CSSPrimitiveValueImpl::parseString):
(WebCore::CSSPrimitiveValueImpl::cssText):
(WebCore::CSSImageValueImpl::CSSImageValueImpl):
(WebCore::CSSBorderImageValueImpl::CSSBorderImageValueImpl):
(WebCore::CSSBorderImageValueImpl::cssText):
(WebCore::FontFamilyValueImpl::FontFamilyValueImpl):
(WebCore::FontFamilyValueImpl::cssText):
(WebCore::FontValueImpl::cssText):
(WebCore::ShadowValueImpl::ShadowValueImpl):
(WebCore::ShadowValueImpl::cssText):
(WebCore::CSSProperty::cssText):
* css/css_valueimpl.h:
(WebCore::CSSValueImpl::setCssText):
(WebCore::CSSValueListImpl::item):
(WebCore::CSSPrimitiveValueImpl::getFloatValue):
(WebCore::CSSPrimitiveValueImpl::getCounterValue):
(WebCore::CSSPrimitiveValueImpl::getRectValue):
(WebCore::CSSPrimitiveValueImpl::getRGBColorValue):
(WebCore::CSSPrimitiveValueImpl::getPairValue):
(WebCore::CSSPrimitiveValueImpl::getDashboardRegionValue):
(WebCore::CSSPrimitiveValueImpl::):
(WebCore::CSSQuirkPrimitiveValueImpl::CSSQuirkPrimitiveValueImpl):
(WebCore::CounterImpl::identifier):
(WebCore::CounterImpl::listStyle):
(WebCore::CounterImpl::separator):
(WebCore::RectImpl::top):
(WebCore::RectImpl::right):
(WebCore::RectImpl::bottom):
(WebCore::RectImpl::left):
(WebCore::RectImpl::setTop):
(WebCore::RectImpl::setRight):
(WebCore::RectImpl::setBottom):
(WebCore::RectImpl::setLeft):
(WebCore::PairImpl::first):
(WebCore::PairImpl::second):
(WebCore::PairImpl::setFirst):
(WebCore::PairImpl::setSecond):
(WebCore::DashboardRegionImpl::DashboardRegionImpl):
(WebCore::FontFamilyValueImpl::fontName):
(WebCore::CSSProperty::CSSProperty):
(WebCore::CSSProperty::value):
(WebCore::CSSMutableStyleDeclarationImpl::setNode):
(WebCore::CSSMutableStyleDeclarationImpl::setProperty):
(WebCore::CSSMutableStyleDeclarationImpl::removeProperty):
* css/cssparser.cpp:
(CSSParser::createStyleDeclaration):
(CSSParser::parseDashboardRegions):
* css/cssparser.h:
(WebCore::Value::):
(WebCore::qString):
(WebCore::domString):
(WebCore::atomicString):
(WebCore::ValueList::current):
(WebCore::ValueList::next):
(WebCore::CSSParser::current):
* css/cssstyleselector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* dom/DOMImplementationImpl.cpp:
(DOM::DOMImplementationImpl::createDocument):
(DOM::DOMImplementationImpl::instance):
* dom/DOMImplementationImpl.h:
* dom/DocumentImpl.cpp:
(WebCore::DocumentImpl::DocumentImpl):
(WebCore::DocumentImpl::~DocumentImpl):
(WebCore::DocumentImpl::setDocType):
(WebCore::DocumentImpl::createElement):
(WebCore::DocumentImpl::createDocumentFragment):
(WebCore::DocumentImpl::createTextNode):
(WebCore::DocumentImpl::createComment):
(WebCore::DocumentImpl::createCDATASection):
(WebCore::DocumentImpl::createProcessingInstruction):
(WebCore::DocumentImpl::createEntityReference):
(WebCore::DocumentImpl::createEditingTextNode):
(WebCore::DocumentImpl::createCSSStyleDeclaration):
(WebCore::DocumentImpl::importNode):
(WebCore::DocumentImpl::adoptNode):
(WebCore::DocumentImpl::createElementNS):
(WebCore::DocumentImpl::setTitle):
(WebCore::DocumentImpl::createRange):
(WebCore::DocumentImpl::createNodeIterator):
(WebCore::DocumentImpl::createTreeWalker):
(WebCore::DocumentImpl::setStyleSheet):
(WebCore::DocumentImpl::setHoverNode):
(WebCore::DocumentImpl::setActiveNode):
(WebCore::DocumentImpl::setFocusNode):
(WebCore::DocumentImpl::defaultView):
(WebCore::DocumentImpl::createEvent):
(WebCore::DocumentImpl::setHTMLWindowEventListener):
(WebCore::DocumentImpl::addWindowEventListener):
(WebCore::DocumentImpl::createHTMLEventListener):
(WebCore::DocumentImpl::images):
(WebCore::DocumentImpl::applets):
(WebCore::DocumentImpl::embeds):
(WebCore::DocumentImpl::objects):
(WebCore::DocumentImpl::links):
(WebCore::DocumentImpl::forms):
(WebCore::DocumentImpl::anchors):
(WebCore::DocumentImpl::all):
(WebCore::DocumentImpl::windowNamedItems):
(WebCore::DocumentImpl::documentNamedItems):
(WebCore::DocumentImpl::getElementsByName):
* dom/DocumentImpl.h:
(WebCore::DocumentImpl::realDocType):
(WebCore::DocumentImpl::createAttribute):
(WebCore::DocumentImpl::title):
(WebCore::DocumentImpl::styleSelector):
(WebCore::DocumentImpl::setRestoreState):
(WebCore::DocumentImpl::restoreState):
(WebCore::DocumentImpl::view):
(WebCore::DocumentImpl::docLoader):
(WebCore::DocumentImpl::tokenizer):
(WebCore::DocumentImpl::focusNode):
(WebCore::DocumentImpl::hoverNode):
(WebCore::DocumentImpl::activeNode):
(WebCore::DocumentImpl::policyBaseURL):
(WebCore::DocumentImpl::setPolicyBaseURL):
(WebCore::DocumentImpl::):
(WebCore::DocumentImpl::transformSourceDocument):
(WebCore::DocumentImpl::domTreeVersion):
(WebCore::DocumentImpl::decoder):
* dom/NodeListImpl.cpp:
(DOM::NodeListImpl::NodeListImpl):
(DOM::NodeListImpl::~NodeListImpl):
(DOM::NodeListImpl::recursiveLength):
(DOM::NodeListImpl::recursiveItem):
(DOM::NodeListImpl::itemById):
* dom/NodeListImpl.h:
* dom/dom2_eventsimpl.cpp:
(WebCore::RegisteredEventListener::RegisteredEventListener):
* dom/dom2_eventsimpl.h:
(WebCore::operator!=):
* dom/dom2_traversalimpl.cpp:
(DOM::TraversalImpl::TraversalImpl):
(DOM::NodeIteratorImpl::NodeIteratorImpl):
(DOM::TreeWalkerImpl::TreeWalkerImpl):
* dom/dom2_traversalimpl.h:
(WebCore::TraversalImpl::root):
(WebCore::TraversalImpl::filter):
(WebCore::NodeIteratorImpl::referenceNode):
(WebCore::NodeIteratorImpl::setPointerBeforeReferenceNode):
(WebCore::NodeIteratorImpl::setDetached):
(WebCore::NodeIteratorImpl::document):
(WebCore::TreeWalkerImpl::currentNode):
* dom/dom_position.cpp:
(WebCore::Position::computedStyle):
* dom/dom_position.h:
* dom/xml_tokenizer.cpp:
(WebCore::XMLTokenizer::insertErrorMessageBlock):
* editing/ApplyStyleCommand.cpp:
(WebCore::createFontElement):
(WebCore::createStyleSpanElement):
(WebCore::ApplyStyleCommand::ApplyStyleCommand):
(WebCore::ApplyStyleCommand::updateStartEnd):
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::extractTextDecorationStyle):
(WebCore::ApplyStyleCommand::extractAndNegateTextDecorationStyle):
(WebCore::ApplyStyleCommand::applyTextDecorationStyle):
(WebCore::ApplyStyleCommand::removeInlineStyle):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
(WebCore::ApplyStyleCommand::computedFontSize):
* editing/ApplyStyleCommand.h:
(WebCore::ApplyStyleCommand::style):
* editing/EditCommand.cpp:
(WebCore::EditCommandPtr::setTypingStyle):
(WebCore::EditCommand::setTypingStyle):
(WebCore::EditCommand::styleAtPosition):
* editing/EditCommand.h:
(WebCore::EditCommand::document):
(WebCore::EditCommand::typingStyle):
* editing/InsertLineBreakCommand.cpp:
(WebCore::InsertLineBreakCommand::InsertLineBreakCommand):
(WebCore::InsertLineBreakCommand::doApply):
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::prepareForTextInsertion):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::computeAndStoreNodeDesiredStyle):
(WebCore::NodeDesiredStyle::NodeDesiredStyle):
(WebCore::ReplaceSelectionCommand::doApply):
* editing/ReplaceSelectionCommand.h:
(WebCore::NodeDesiredStyle::node):
(WebCore::NodeDesiredStyle::style):
(WebCore::ReplacementFragment::root):
* editing/WrapContentsInDummySpanCommand.cpp:
(WebCore::WrapContentsInDummySpanCommand::doApply):
* editing/htmlediting.cpp:
(WebCore::createDefaultParagraphElement):
(WebCore::createBreakElement):
* editing/markup.cpp:
(WebCore::createFragmentFromMarkup):
(WebCore::createParagraphContentsFromString):
* editing/visible_text.cpp:
(khtml::TextIterator::rangeFromLocationAndLength):
* editing/visible_text.h:
(WebCore::isCollapsibleWhitespace):
(WebCore::WordAwareIterator::range):
* khtml/ecma/kjs_css.cpp:
(KJS::DOMCSSStyleDeclaration::cssPropertyGetter):
(KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction):
* khtml/ecma/kjs_dom.cpp:
(KJS::DOMDocumentProtoFunc::callAsFunction):
* khtml/ecma/kjs_html.cpp:
(KJS::KJS::HTMLSelectCollection::put):
(KJS::OptionConstructorImp::construct):
* khtml/html/HTMLElementImpl.cpp:
(WebCore::HTMLElementImpl::createContextualFragment):
(WebCore::HTMLElementImpl::setInnerHTML):
(WebCore::HTMLElementImpl::setOuterHTML):
(WebCore::HTMLElementImpl::setOuterText):
* khtml/html/HTMLElementImpl.h:
* khtml/html/HTMLNameCollectionImpl.cpp:
(WebCore::HTMLNameCollectionImpl::HTMLNameCollectionImpl):
(WebCore::HTMLNameCollectionImpl::traverseNextItem):
* khtml/html/HTMLNameCollectionImpl.h:
* khtml/html/html_documentimpl.cpp:
(WebCore::HTMLDocumentImpl::createElement):
* khtml/html/html_documentimpl.h:
(WebCore::HTMLDocumentImpl::collectionInfo):
* khtml/html/htmlfactory.cpp:
(DOM::htmlConstructor):
(DOM::headConstructor):
(DOM::bodyConstructor):
(DOM::baseConstructor):
(DOM::linkConstructor):
(DOM::metaConstructor):
(DOM::styleConstructor):
(DOM::titleConstructor):
(DOM::frameConstructor):
(DOM::framesetConstructor):
(DOM::iframeConstructor):
(DOM::formConstructor):
(DOM::buttonConstructor):
(DOM::inputConstructor):
(DOM::isindexConstructor):
(DOM::fieldsetConstructor):
(DOM::labelConstructor):
(DOM::legendConstructor):
(DOM::optgroupConstructor):
(DOM::optionConstructor):
(DOM::selectConstructor):
(DOM::textareaConstructor):
(DOM::dlConstructor):
(DOM::ulConstructor):
(DOM::olConstructor):
(DOM::dirConstructor):
(DOM::menuConstructor):
(DOM::liConstructor):
(DOM::blockquoteConstructor):
(DOM::divConstructor):
(DOM::headingConstructor):
(DOM::hrConstructor):
(DOM::paragraphConstructor):
(DOM::preConstructor):
(DOM::basefontConstructor):
(DOM::fontConstructor):
(DOM::modConstructor):
(DOM::anchorConstructor):
(DOM::imageConstructor):
(DOM::mapConstructor):
(DOM::areaConstructor):
(DOM::canvasConstructor):
(DOM::appletConstructor):
(DOM::embedConstructor):
(DOM::objectConstructor):
(DOM::paramConstructor):
(DOM::scriptConstructor):
(DOM::tableConstructor):
(DOM::tableCaptionConstructor):
(DOM::tableColConstructor):
(DOM::tableRowConstructor):
(DOM::tableCellConstructor):
(DOM::tableSectionConstructor):
(DOM::brConstructor):
(DOM::quoteConstructor):
(DOM::marqueeConstructor):
(DOM::HTMLElementFactory::createHTMLElement):
* khtml/html/htmlfactory.h:
* khtml/html/htmlparser.cpp:
(HTMLParser::parseToken):
(HTMLParser::textCreateErrorCheck):
(HTMLParser::commentCreateErrorCheck):
(HTMLParser::headCreateErrorCheck):
(HTMLParser::bodyCreateErrorCheck):
(HTMLParser::framesetCreateErrorCheck):
(HTMLParser::iframeCreateErrorCheck):
(HTMLParser::formCreateErrorCheck):
(HTMLParser::isindexCreateErrorCheck):
(HTMLParser::selectCreateErrorCheck):
(HTMLParser::ddCreateErrorCheck):
(HTMLParser::dtCreateErrorCheck):
(HTMLParser::nestedCreateErrorCheck):
(HTMLParser::nestedStyleCreateErrorCheck):
(HTMLParser::tableCellCreateErrorCheck):
(HTMLParser::tableSectionCreateErrorCheck):
(HTMLParser::noembedCreateErrorCheck):
(HTMLParser::noframesCreateErrorCheck):
(HTMLParser::noscriptCreateErrorCheck):
(HTMLParser::mapCreateErrorCheck):
(HTMLParser::getNode):
* khtml/html/htmlparser.h:
* khtml/html/htmltokenizer.cpp:
(WebCore::HTMLTokenizer::parseTag):
(WebCore::HTMLTokenizer::processToken):
* khtml/html/htmltokenizer.h:
* ksvg2/misc/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::createSVGEventListener):
* ksvg2/misc/SVGDocumentExtensions.h:
* ksvg2/svg/SVGDOMImplementationImpl.cpp:
(SVGDOMImplementationImpl::createDocumentType):
(SVGDOMImplementationImpl::createDocument):
(SVGDOMImplementationImpl::createCSSStyleSheet):
* ksvg2/svg/SVGDOMImplementationImpl.h:
* ksvg2/svg/SVGDocumentImpl.cpp:
(WebCore::SVGDocumentImpl::createElement):
(WebCore::SVGDocumentImpl::dispatchZoomEvent):
(WebCore::SVGDocumentImpl::dispatchKeyEvent):
(WebCore::SVGDocumentImpl::dispatchUIEvent):
(WebCore::SVGDocumentImpl::dispatchMouseEvent):
* ksvg2/svg/SVGDocumentImpl.h:
* ksvg2/svg/SVGElementImpl.cpp:
(WebCore::SVGElementImpl::addSVGEventListener):
* ksvg2/svg/SVGSVGElementImpl.cpp:
(WebCore::SVGSVGElementImpl::addSVGWindowEventListner):
* page/Frame.cpp:
(WebCore::Frame::view):
(WebCore::Frame::begin):
(WebCore::Frame::computeAndSetTypingStyle):
(WebCore::Frame::selectionHasStyle):
(WebCore::Frame::selectionStartHasStyle):
(WebCore::Frame::selectionStartStylePropertyValue):
(WebCore::Frame::selectionComputedStyle):
(WebCore::Frame::forceLayout):
(WebCore::Frame::sendResizeEvent):
(WebCore::Frame::sendScrollEvent):
(WebCore::Frame::clearTimers):
(WebCore::Frame::styleForSelectionStart):
* page/FramePrivate.h:
* page/FrameTree.h:
(WebCore::FrameTree::name):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12865
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Fri, 17 Feb 2006 00:32:02 +0000 (00:32 +0000)]
Changed by Darin on my machine.
* coding/coding-style.html: Re-merged in changes Darin made to the guidelines
a few days back.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12863
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Fri, 17 Feb 2006 00:28:33 +0000 (00:28 +0000)]
Reviewed by Darin.
Test:
* manual-tests/mail-attachments.html: Added.
Automated test not currently possible because widgets do not actually draw when not in a window.
Geoff and Justin are fixing that and will add this test.
* rendering/render_frames.cpp:
(WebCore::RenderPartObject::updateWidget):
Fix unique param check when processing object tag attributes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12862
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 16 Feb 2006 23:37:25 +0000 (23:37 +0000)]
Adding -Wno-deprecated-declarations to more files that include ObjC headers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12859
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 16 Feb 2006 23:03:32 +0000 (23:03 +0000)]
Fix build failure.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12858
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 16 Feb 2006 23:01:38 +0000 (23:01 +0000)]
Added -Wno-deprecated-declarations to all the ObjC binding files to prevent deprecation
warnings. Using <rdar://problem/
4448350> to track this.
* JavaScriptCore.xcodeproj/project.pbxproj:
* bindings/objc/objc_jsobject.h: Removed empty file.
* bindings/objc/objc_jsobject.mm: Removed empty file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Thu, 16 Feb 2006 22:57:36 +0000 (22:57 +0000)]
Reviewed by Darin.
- Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=7113
Typing in editable overflow:hidden div doesn't scroll
* bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge ensureSelectionVisible]):
Changed scrollRectToVisible call so that it will align to the edge instead of trying to center the selection.
Centering looks funny when it happens after typing, deleting, moving the cursor, etc.
* rendering/render_layer.cpp: (WebCore::RenderLayer::scrollRectToVisible):
Use scrollWidth() and scrollHeight() functions instead of m_scrollWidth and m_scrollHeight.
These functions will cause the correct scroll dimensions to be calculated for overflow:hidden layers.
Also subtracted scrollbar width and height when calculating the layer bounds. This was causing scroll problems in overflow:scroll.
I also did some cleanup to use xPos() and yPos() instead of m_x and m_y, and to use scrollYOffset() instead of m_scrollY.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Thu, 16 Feb 2006 22:47:55 +0000 (22:47 +0000)]
LayoutTests:
Updating results for fix:
http://bugzilla.opendarwin.org/show_bug.cgi?id=6812
Missing focus ring on new text fields
* fast/forms/input-appearance-focus-expected.checksum:
* fast/forms/input-appearance-focus-expected.png:
WebCore:
Reviewed by Darin.
- Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6812
Missing focus ring on new text fields
Tests:
* fast/forms/input-appearance-focus.html: Updated.
* rendering/render_object.cpp: (WebCore::RenderObject::paintOutline):
call supportsFocusRing instead of checking the appearance.
* rendering/render_theme.cpp: (khtml::RenderTheme::supportsFocusRing): Added.
Checks appearance. Theme will draw focus ring if there's an appearance, but not for the new text fields.
* rendering/render_theme.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 16 Feb 2006 19:35:28 +0000 (19:35 +0000)]
Added a file and function to a change log entry.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 16 Feb 2006 19:27:44 +0000 (19:27 +0000)]
Reviewed by Hyatt.
- eliminate QFrame and QObject::inherits, fix some strange stuff
in RenderCanvas that showed up when I tested that change
* kwq/KWQFrame.h: Removed.
* kwq/KWQFrame.mm: Removed.
* bridge/mac/FrameViewMac.mm: Added.
* WebCore.xcodeproj/project.pbxproj: Updated for adds and removes.
* WebCore.vcproj/WebCore/WebCore.vcproj: Updated for removes.
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:]):
* khtml/ecma/kjs_window.cpp:
(KJS::FrameArray::indexGetter):
(KJS::FrameArray::nameGetter):
* kwq/KWQAccObject.mm:
(-[KWQAccObject doAXTextMarkerForPosition:]):
* kwq/KWQRenderTreeDebug.cpp:
(write):
* page/Frame.cpp:
(WebCore::isFrameElement):
* page/FramePrivate.h:
(WebCore::FramePrivate::FramePrivate):
Change QObject::inherits callers to call the "is" functions directly.
* kwq/KWQObject.h:
* kwq/KWQObject.cpp: Removed QObject::inherits, QObject::isQFrame,
and QObject::isQScrollView.
* kwq/KWQScrollView.h: Inherit from Widget instead of QFrame.
Remove isQScrollView.
* kwq/KWQScrollView.mm: Remove isQScrollView.
* page/FrameView.h:
* page/FrameView.cpp: Changed underMouse and clickNode to be RefPtr.
Added m_hasBorder.
(WebCore::FrameViewPrivate::FrameViewPrivate):
(WebCore::FrameViewPrivate::~FrameViewPrivate):
(WebCore::FrameViewPrivate::reset):
(WebCore::FrameView::layout):
(WebCore::FrameView::viewportMousePressEvent):
(WebCore::FrameView::invalidateClick):
(WebCore::FrameView::viewportMouseReleaseEvent):
(WebCore::FrameView::keyPressEvent):
(WebCore::FrameView::dispatchDragEvent): Use RefPtr for MouseEventImpl.
(WebCore::FrameView::nodeUnderMouse):
(WebCore::FrameView::dispatchMouseEvent):
(WebCore::FrameView::setHasBorder): Added.
(WebCore::FrameView::hasBorder): Added.
(WebCore::FrameView::borderWidth): Added.
* rendering/render_canvas.h: Eliminated unneeded setWidth/Height overrides.
Eliminated viewportWidth(), viewportHeight(), m_rootWidth, m_rootHeight,
m_viewportWidth, and m_viewportHeight.
* rendering/render_canvas.cpp:
(RenderCanvas::calcHeight): Remove unneeded code to set height when there's
no view.
(RenderCanvas::calcWidth): Fix code to set width to visibleWidth(). Removed
incorrect old width setting, and removed unneeded code to set width when
there's no view. Also removed incorrect margin-setting code.
(RenderCanvas::layout): Removed incorrect code to set width and height.
Instead letting calcWidth and calcHeight do the job.
(RenderCanvas::repaintViewRectangle): Use new FrameView::hasBorder instead
of QFrame::frameStyle.
(RenderCanvas::viewRect): Removed unneeded "root width" feature for a canvas
without a view.
* rendering/render_frames.cpp:
(WebCore::RenderFrame::slotViewCleared): Use new setHasBorder.
(WebCore::RenderPartObject::slotViewCleared): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Thu, 16 Feb 2006 19:23:21 +0000 (19:23 +0000)]
2006-02-17 Eric Seidel <eseidel@apple.com>
Reviewed by justing.
Close several age-old leaks in xslt code.
Tests already were catching these.
* khtml/xsl/xsl_stylesheetimpl.cpp:
(WebCore::XSLStyleSheetImpl::loadChildSheets):
(WebCore::XSLStyleSheetImpl::locateStylesheetSubResource):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomernic [Thu, 16 Feb 2006 18:33:23 +0000 (18:33 +0000)]
Reviewed by Geoff.
<rdar://problem/
4428609> Flash Player 8.0.22 can crash Safari (and WebKit apps)
with javascript disabled (7015)
Added a test case, manual-tests/NPN_Invoke. This is a skeleton of a Netscape
plugin which uses NPN_Invoke() to call the window.alert() JavaScript function.
* bridge/mac/MacFrame.mm:
(WebCore::MacFrame::windowScriptNPObject):
Removed the check Darin added to return 0 when JavaScript is disabled.
This method cannot return 0, because plugins are not guaranteed to check
for that.
Removed my old fix for Radar
4428609 (7015) in favor of a better solution.
Instead of creating a "dummy" JSObject to represent the window script object
when JavaScript is disabled, we use the new JavaScriptCore bindings API to
create a "no script" NPObject. This solution is better because it does not
cause entry into any JavaScript interpreter code.
* manual-tests/NPN_Invoke: Added.
* manual-tests/NPN_Invoke/English.lproj: Added.
* manual-tests/NPN_Invoke/English.lproj/Localized.r: Added.
* manual-tests/NPN_Invoke/Info.plist: Added.
* manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Added.
* manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj: Added.
* manual-tests/NPN_Invoke/main.c: Added.
* manual-tests/NPN_Invoke/test.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomernic [Thu, 16 Feb 2006 18:32:31 +0000 (18:32 +0000)]
Reviewed by Geoff.
<rdar://problem/
4428609> Flash Player 8.0.22 can crash Safari (and WebKit apps) with
javascript disabled (7015)
* bindings/NP_jsobject.cpp:
(_NPN_CreateNoScriptObject):
Returns an NPObject which is not bound to a JavaScript object. This kind of NPObject
can be given to a plugin as the "window script object" when JavaScript is disabled.
The object has a custom NPClass, NPNoScriptObjectClass, which has no defined methods.
Because of this, none of the NPN_* functions called by the plugin on this "no script
object" will cause entry into JavaScript code.
(_NPN_InvokeDefault):
Make sure the NPVariant is filled before returning from this function. This never
mattered before because we never reached this case, having only created NPObjects of
the class NPScriptObjectClass.
(_NPN_Invoke):
ditto
(_NPN_Evaluate):
ditto
(_NPN_GetProperty):
ditto
* bindings/NP_jsobject.h:
Declared _NPN_CreateNoScriptObject().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 16 Feb 2006 17:53:05 +0000 (17:53 +0000)]
Fixing name to use "ue" since I can't figure out how to include
and umlaut in a change log message.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 16 Feb 2006 17:52:23 +0000 (17:52 +0000)]
Reviewed by me, change by Peter Kummel.
* kjs/operations.cpp: (KJS::isNegInf): Fix Windows code, which was
checking for positive infinity (rolling in fix from KDE side).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Thu, 16 Feb 2006 17:09:51 +0000 (17:09 +0000)]
Fix by Mitz Pettel, reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7274
Assertion failure in TimerBase::checkHeapIndex() (Timer.cpp:199) !timerHeap->isEmpty()
* platform/Timer.cpp:
(WebCore::TimerBase::stop): Call setNextFireTime(0) unconditionally to make sure the timer
is removed from timersReadyToFire so that fireTimers doesn't try to fire a deleted timer.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 16 Feb 2006 10:20:01 +0000 (10:20 +0000)]
Reviewed and landed by Maciej.
Made the author name bold on the frontpage.
Moved the "Posted by" line up under the title and made the author name
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 16 Feb 2006 09:22:39 +0000 (09:22 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 16 Feb 2006 09:21:52 +0000 (09:21 +0000)]
WebKit:
Reviewed by darin
<http://bugzilla.opendarwin.org/show_bug.cgi?id=7148>
Add drag and drop support to DumpRenderTree
Added a UI delegate method so that DumpRenderTree can perform dragging on its own.
Made _updateFocusState SPI, to allow us to test the behavior and appearance of
windows that have or don't have focus.
* WebView/WebHTMLView.m:
(-[WebHTMLView _updateFocusState]):
(-[NSArray viewDidMoveToWindow]):
(-[NSArray windowDidBecomeKey:]):
(-[NSArray windowDidResignKey:]):
(-[NSArray dragImage:at:offset:event:pasteboard:source:slideBack:]):
(-[NSArray becomeFirstResponder]):
(-[NSArray resignFirstResponder]):
(-[WebHTMLView _formControlIsResigningFirstResponder:]):
* WebView/WebHTMLViewInternal.h:
* WebView/WebHTMLViewPrivate.h:
* WebView/WebUIDelegatePrivate.h:
* WebView/WebView.m:
WebKitTools:
Reviewed by darin
<http://bugzilla.opendarwin.org/show_bug.cgi?id=7148>
Add drag and drop support to DumpRenderTree
Intercept the drag start using the new UI delegate method, package an NSDraggingInfo,
and send dragging updates. Put DumpRenderTree's WebView into an offscreen window.
* DumpRenderTree/DumpRenderTree.m:
(main):
(-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]):
(-[WaitUntilDoneDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
(-[WaitUntilDoneDelegate webViewFocus:]):
(+[LayoutTestController isSelectorExcludedFromWebScript:]):
(+[LayoutTestController webScriptNameForSelector:]):
(-[LayoutTestController setWindowIsKey:]):
(-[LayoutTestController setMainFrameIsFirstResponder:]):
(-[EventSendingController init]):
(-[EventSendingController mouseDown]):
(-[EventSendingController mouseUp]):
(-[EventSendingController mouseMoveToX:Y:]):
(dumpRenderTree):
(-[DumpRenderTreeWindow isKeyWindow]):
(-[DumpRenderTreeDraggingInfo initWithImage:offset:pasteboard:source:]):
(-[DumpRenderTreeDraggingInfo dealloc]):
(-[DumpRenderTreeDraggingInfo draggingDestinationWindow]):
(-[DumpRenderTreeDraggingInfo draggingSourceOperationMask]):
(-[DumpRenderTreeDraggingInfo draggingLocation]):
(-[DumpRenderTreeDraggingInfo draggedImageLocation]):
(-[DumpRenderTreeDraggingInfo draggedImage]):
(-[DumpRenderTreeDraggingInfo draggingPasteboard]):
(-[DumpRenderTreeDraggingInfo draggingSource]):
(-[DumpRenderTreeDraggingInfo draggingSequenceNumber]):
(-[DumpRenderTreeDraggingInfo slideDraggedImageTo:]):
(-[DumpRenderTreeDraggingInfo namesOfPromisedFilesDroppedAtDestination:]):
* DumpRenderTree/TextInputController.m:
(-[TextInputController firstRectForCharactersFrom:length:]):
(-[TextInputController characterIndexForPointX:Y:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 16 Feb 2006 09:20:55 +0000 (09:20 +0000)]
Reviewed by darin
<http://bugzilla.opendarwin.org/show_bug.cgi?id=7148>
Add drag and drop support to DumpRenderTree
* css1/basic/comments-expected.checksum:
* css1/basic/comments-expected.png:
* css1/basic/containment-expected.checksum:
* css1/basic/containment-expected.png:
* css1/basic/id_as_selector-expected.checksum:
* css1/basic/id_as_selector-expected.png:
* css1/basic/inheritance-expected.checksum:
* css1/basic/inheritance-expected.png:
* css1/box_properties/border-expected.checksum:
* css1/box_properties/border-expected.png:
* css1/box_properties/border_bottom-expected.checksum:
* css1/box_properties/border_bottom-expected.png:
* css1/box_properties/border_bottom_width-expected.checksum:
* css1/box_properties/border_bottom_width-expected.png:
* css1/box_properties/border_left-expected.checksum:
* css1/box_properties/border_left-expected.png:
* css1/box_properties/border_left_width-expected.checksum:
* css1/box_properties/border_left_width-expected.png:
* css1/box_properties/border_right_inline-expected.checksum:
* css1/box_properties/border_right_inline-expected.png:
* css1/box_properties/border_right_width-expected.checksum:
* css1/box_properties/border_right_width-expected.png:
* css1/box_properties/border_style-expected.checksum:
* css1/box_properties/border_style-expected.png:
* css1/box_properties/border_top-expected.checksum:
* css1/box_properties/border_top-expected.png:
* css1/box_properties/border_top_width-expected.checksum:
* css1/box_properties/border_top_width-expected.png:
* css1/box_properties/border_width-expected.checksum:
* css1/box_properties/border_width-expected.png:
* css1/box_properties/clear-expected.checksum:
* css1/box_properties/clear-expected.png:
* css1/box_properties/clear_float-expected.checksum:
* css1/box_properties/clear_float-expected.png:
* css1/box_properties/float_elements_in_series-expected.checksum:
* css1/box_properties/float_elements_in_series-expected.png:
* css1/box_properties/float_margin-expected.checksum:
* css1/box_properties/float_margin-expected.png:
* css1/box_properties/float_on_text_elements-expected.checksum:
* css1/box_properties/float_on_text_elements-expected.png:
* css1/box_properties/height-expected.checksum:
* css1/box_properties/height-expected.png:
* css1/box_properties/margin-expected.checksum:
* css1/box_properties/margin-expected.png:
* css1/box_properties/margin_bottom-expected.checksum:
* css1/box_properties/margin_bottom-expected.png:
* css1/box_properties/margin_inline-expected.checksum:
* css1/box_properties/margin_inline-expected.png:
* css1/box_properties/margin_left-expected.checksum:
* css1/box_properties/margin_left-expected.png:
* css1/box_properties/margin_right-expected.checksum:
* css1/box_properties/margin_right-expected.png:
* css1/box_properties/margin_top-expected.checksum:
* css1/box_properties/margin_top-expected.png:
* css1/box_properties/padding-expected.checksum:
* css1/box_properties/padding-expected.png:
* css1/box_properties/padding_bottom-expected.checksum:
* css1/box_properties/padding_bottom-expected.png:
* css1/box_properties/padding_inline-expected.checksum:
* css1/box_properties/padding_inline-expected.png:
* css1/box_properties/padding_left-expected.checksum:
* css1/box_properties/padding_left-expected.png:
* css1/box_properties/padding_right-expected.checksum:
* css1/box_properties/padding_right-expected.png:
* css1/box_properties/padding_top-expected.checksum:
* css1/box_properties/padding_top-expected.png:
* css1/box_properties/width-expected.checksum:
* css1/box_properties/width-expected.png:
* css1/cascade/cascade_order-expected.checksum:
* css1/cascade/cascade_order-expected.png:
* css1/classification/display-expected.checksum:
* css1/classification/display-expected.png:
* css1/classification/list_style_type-expected.checksum:
* css1/classification/list_style_type-expected.png:
* css1/classification/white_space-expected.checksum:
* css1/classification/white_space-expected.png:
* css1/color_and_background/background-expected.checksum:
* css1/color_and_background/background-expected.png:
* css1/color_and_background/background_attachment-expected.checksum:
* css1/color_and_background/background_attachment-expected.png:
* css1/color_and_background/background_position-expected.checksum:
* css1/color_and_background/background_position-expected.png:
* css1/color_and_background/background_repeat-expected.checksum:
* css1/color_and_background/background_repeat-expected.png:
* css1/conformance/forward_compatible_parsing-expected.checksum:
* css1/conformance/forward_compatible_parsing-expected.png:
* css1/font_properties/font-expected.checksum:
* css1/font_properties/font-expected.png:
* css1/font_properties/font_family-expected.checksum:
* css1/font_properties/font_family-expected.png:
* css1/font_properties/font_size-expected.checksum:
* css1/font_properties/font_size-expected.png:
* css1/font_properties/font_weight-expected.checksum:
* css1/font_properties/font_weight-expected.png:
* css1/formatting_model/floating_elements-expected.checksum:
* css1/formatting_model/floating_elements-expected.png:
* css1/formatting_model/height_of_lines-expected.checksum:
* css1/formatting_model/height_of_lines-expected.png:
* css1/formatting_model/horizontal_formatting-expected.checksum:
* css1/formatting_model/horizontal_formatting-expected.png:
* css1/formatting_model/inline_elements-expected.checksum:
* css1/formatting_model/inline_elements-expected.png:
* css1/formatting_model/replaced_elements-expected.checksum:
* css1/formatting_model/replaced_elements-expected.png:
* css1/formatting_model/vertical_formatting-expected.checksum:
* css1/formatting_model/vertical_formatting-expected.png:
* css1/pseudo/anchor-expected.checksum:
* css1/pseudo/anchor-expected.png:
* css1/pseudo/firstletter-expected.checksum:
* css1/pseudo/firstletter-expected.png:
* css1/pseudo/firstline-expected.checksum:
* css1/pseudo/firstline-expected.png:
* css1/pseudo/multiple_pseudo_elements-expected.checksum:
* css1/pseudo/multiple_pseudo_elements-expected.png:
* css1/text_properties/letter_spacing-expected.checksum:
* css1/text_properties/letter_spacing-expected.png:
* css1/text_properties/line_height-expected.checksum:
* css1/text_properties/line_height-expected.png:
* css1/text_properties/text-transCapitalize-expected.checksum:
* css1/text_properties/text-transCapitalize-expected.png:
* css1/text_properties/text_decoration-expected.checksum:
* css1/text_properties/text_decoration-expected.png:
* css1/text_properties/text_indent-expected.checksum:
* css1/text_properties/text_indent-expected.png:
* css1/text_properties/text_transform-expected.checksum:
* css1/text_properties/text_transform-expected.png:
* css1/text_properties/vertical_align-expected.checksum:
* css1/text_properties/vertical_align-expected.png:
* css1/text_properties/word_spacing-expected.checksum:
* css1/text_properties/word_spacing-expected.png:
* css1/units/color_units-expected.checksum:
* css1/units/color_units-expected.png:
* css1/units/length_units-expected.checksum:
* css1/units/length_units-expected.png:
* css2.1/t0801-c412-hz-box-00-b-a-expected.checksum:
* css2.1/t0801-c412-hz-box-00-b-a-expected.png:
* css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum:
* css2.1/t0803-c5502-mrgn-r-02-c-expected.png:
* css2.1/t0803-c5505-mrgn-02-c-expected.checksum:
* css2.1/t0803-c5505-mrgn-02-c-expected.png:
* css2.1/t080301-c411-vt-mrgn-00-b-expected.checksum:
* css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
* css2.1/t0905-c5525-fltclr-00-c-ag-expected.checksum:
* css2.1/t0905-c5525-fltclr-00-c-ag-expected.png:
* css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.checksum:
* css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png:
* css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
* css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
* css2.1/t1002-c5523-width-02-b-g-expected.checksum:
* css2.1/t1002-c5523-width-02-b-g-expected.png:
* css2.1/t140201-c535-bg-fixd-00-b-g-expected.checksum:
* css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
* css2.1/t140201-c537-bgfxps-00-c-ag-expected.checksum:
* css2.1/t140201-c537-bgfxps-00-c-ag-expected.png:
* css2.1/t1508-c527-font-07-b-expected.checksum:
* css2.1/t1508-c527-font-07-b-expected.png:
* editing/deleting/delete-after-span-ws-001-expected.checksum:
* editing/deleting/delete-after-span-ws-001-expected.png:
* editing/deleting/delete-after-span-ws-002-expected.checksum:
* editing/deleting/delete-after-span-ws-002-expected.png:
* editing/deleting/delete-after-span-ws-003-expected.checksum:
* editing/deleting/delete-after-span-ws-003-expected.png:
* editing/deleting/delete-and-undo-expected.checksum:
* editing/deleting/delete-and-undo-expected.png:
* editing/deleting/delete-and-undo-expected.txt:
* editing/deleting/delete-line-end-ws-001-expected.checksum:
* editing/deleting/delete-line-end-ws-001-expected.png:
* editing/deleting/delete-line-end-ws-002-expected.checksum:
* editing/deleting/delete-line-end-ws-002-expected.png:
* editing/inserting/insert-div-023-expected.checksum:
* editing/inserting/insert-div-023-expected.png:
* editing/selection/caret-and-focus-ring.html:
* editing/selection/drag-to-contenteditable-iframe-expected.checksum: Added.
* editing/selection/drag-to-contenteditable-iframe-expected.png: Added.
* editing/selection/drag-to-contenteditable-iframe-expected.txt: Added.
* editing/selection/drag-to-contenteditable-iframe.html: Added.
* editing/selection/focus_editable_html-expected.checksum:
* editing/selection/focus_editable_html-expected.png:
* editing/selection/iframe-expected.checksum:
* editing/selection/iframe-expected.png:
* editing/selection/replaced-boundaries-3-expected.checksum:
* editing/selection/replaced-boundaries-3-expected.png:
* editing/selection/select-all-001-expected.checksum:
* editing/selection/select-all-001-expected.png:
* editing/selection/select-all-002-expected.checksum:
* editing/selection/select-all-002-expected.png:
* editing/selection/select-all-003-expected.checksum:
* editing/selection/select-all-003-expected.png:
* editing/selection/select-all-004-expected.checksum:
* editing/selection/select-all-004-expected.png:
* editing/selection/select-box-expected.checksum:
* editing/selection/select-box-expected.png:
* editing/selection/selection-background.html:
* editing/selection/unrendered-001-expected.checksum:
* editing/selection/unrendered-001-expected.png:
* editing/selection/unrendered-002-expected.checksum:
* editing/selection/unrendered-002-expected.png:
* editing/selection/unrendered-003-expected.checksum:
* editing/selection/unrendered-003-expected.png:
* editing/selection/unrendered-004-expected.checksum:
* editing/selection/unrendered-004-expected.png:
* editing/selection/unrendered-005-expected.checksum:
* editing/selection/unrendered-005-expected.png:
* editing/undo/
4063751-expected.txt:
* editing/undo/redo-typing-001-expected.txt:
* editing/undo/undo-typing-001-expected.checksum:
* editing/undo/undo-typing-001-expected.png:
* editing/undo/undo-typing-001-expected.txt:
* fast/block/basic/016-expected.checksum:
* fast/block/basic/016-expected.png:
* fast/block/basic/text-indent-rtl-expected.checksum:
* fast/block/float/008-expected.checksum:
* fast/block/float/008-expected.png:
* fast/block/float/013-expected.checksum:
* fast/block/float/013-expected.png:
* fast/block/float/019-expected.checksum:
* fast/block/float/019-expected.png:
* fast/block/float/021-expected.checksum:
* fast/block/float/021-expected.png:
* fast/block/float/025-expected.checksum:
* fast/block/float/025-expected.png:
* fast/block/float/026-expected.checksum:
* fast/block/float/026-expected.png:
* fast/block/float/027-expected.checksum:
* fast/block/float/027-expected.png:
* fast/block/float/028-expected.checksum:
* fast/block/float/028-expected.png:
* fast/block/float/032-expected.checksum:
* fast/block/float/032-expected.png:
* fast/block/float/033-expected.checksum:
* fast/block/float/033-expected.png:
* fast/block/margin-collapse/103-expected.checksum:
* fast/block/margin-collapse/103-expected.png:
* fast/block/margin-collapse/104-expected.checksum:
* fast/block/margin-collapse/104-expected.png:
* fast/block/positioning/047-expected.checksum:
* fast/block/positioning/047-expected.png:
* fast/block/positioning/051-expected.checksum:
* fast/block/positioning/051-expected.png:
* fast/block/positioning/055-expected.checksum:
* fast/block/positioning/055-expected.png:
* fast/block/positioning/auto/007-expected.checksum:
* fast/block/positioning/auto/007-expected.png:
* fast/block/positioning/relayout-on-position-change-expected.checksum:
* fast/box-sizing/box-sizing-expected.checksum:
* fast/box-sizing/box-sizing-expected.png:
* fast/clip/014-expected.checksum:
* fast/clip/014-expected.png:
* fast/css-generated-content/014-expected.checksum:
* fast/css-generated-content/014-expected.png:
* fast/css/005-expected.checksum:
* fast/css/005-expected.png:
* fast/css/MarqueeLayoutTest-expected.checksum:
* fast/css/MarqueeLayoutTest-expected.png:
* fast/css/imageTileOpacity-expected.checksum:
* fast/css/imageTileOpacity-expected.png:
* fast/css/word-space-extra-expected.checksum:
* fast/css/word-space-extra-expected.png:
* fast/dom/HTMLObjectElement/object-as-frame.html:
* fast/dom/focus-contenteditable-expected.checksum:
* fast/dom/focus-contenteditable-expected.png:
* fast/dom/window-onFocus.html:
* fast/dynamic/008-expected.checksum:
* fast/dynamic/008-expected.png:
* fast/encoding/utf-16-big-endian-expected.checksum:
* fast/encoding/utf-16-big-endian-expected.png:
* fast/encoding/utf-16-little-endian-expected.checksum:
* fast/encoding/utf-16-little-endian-expected.png:
* fast/flexbox/009-expected.checksum:
* fast/flexbox/009-expected.png:
* fast/flexbox/016-expected.checksum:
* fast/flexbox/016-expected.png:
* fast/forms/001-expected.checksum:
* fast/forms/001-expected.png:
* fast/forms/003-expected.checksum:
* fast/forms/003-expected.png:
* fast/forms/004-expected.checksum:
* fast/forms/004-expected.png:
* fast/forms/HTMLOptionElement_label01-expected.checksum:
* fast/forms/HTMLOptionElement_label01-expected.png:
* fast/forms/HTMLOptionElement_label02-expected.checksum:
* fast/forms/HTMLOptionElement_label02-expected.png:
* fast/forms/HTMLOptionElement_label03-expected.checksum:
* fast/forms/HTMLOptionElement_label03-expected.png:
* fast/forms/HTMLOptionElement_label04-expected.checksum:
* fast/forms/HTMLOptionElement_label04-expected.png:
* fast/forms/button-sizes-expected.checksum:
* fast/forms/button-sizes-expected.png:
* fast/forms/checkbox-radio-onchange-expected.checksum:
* fast/forms/checkbox-radio-onchange-expected.png:
* fast/forms/form-element-geometry-expected.checksum:
* fast/forms/form-element-geometry-expected.png:
* fast/forms/indeterminate-expected.checksum:
* fast/forms/indeterminate-expected.png:
* fast/forms/option-script-expected.checksum:
* fast/forms/option-script-expected.png:
* fast/forms/option-strip-whitespace-expected.checksum:
* fast/forms/option-strip-whitespace-expected.png:
* fast/forms/radio_checked-expected.checksum:
* fast/forms/radio_checked-expected.png:
* fast/forms/radio_checked_dynamic-expected.checksum:
* fast/forms/radio_checked_dynamic-expected.png:
* fast/forms/textAreaLineHeight-expected.checksum:
* fast/forms/textAreaLineHeight-expected.png:
* fast/inline-block/tricky-baseline-expected.checksum:
* fast/inline-block/tricky-baseline-expected.png:
* fast/invalid/014-expected.checksum:
* fast/invalid/014-expected.png:
* fast/lists/008-expected.checksum:
* fast/lists/008-expected.png:
* fast/lists/li-br-expected.checksum:
* fast/lists/li-br-expected.png:
* fast/lists/olstart-expected.checksum:
* fast/lists/olstart-expected.png:
* fast/loader/form-events-back-forward.html: Removed.
* fast/loader/form-events-back-forward.html-disabled: Added.
* fast/overflow/002-expected.checksum:
* fast/overflow/002-expected.png:
* fast/overflow/003-expected.checksum:
* fast/overflow/003-expected.png:
* fast/overflow/005-expected.checksum:
* fast/overflow/005-expected.png:
* fast/overflow/006-expected.checksum:
* fast/overflow/006-expected.png:
* fast/overflow/007-expected.checksum:
* fast/overflow/007-expected.png:
* fast/overflow/image-selection-highlight-expected.checksum:
* fast/overflow/image-selection-highlight-expected.png:
* fast/overflow/overflow-auto-table-expected.checksum:
* fast/overflow/overflow-auto-table-expected.png:
* fast/overflow/overflow-rtl-expected.checksum:
* fast/overflow/overflow-rtl-expected.png:
* fast/overflow/overflow-text-hit-testing-expected.checksum:
* fast/overflow/overflow-text-hit-testing-expected.png:
* fast/overflow/scrollRevealButton-expected.checksum:
* fast/overflow/scrollRevealButton-expected.png:
* fast/parser/comments-expected.checksum:
* fast/parser/comments-expected.png:
* fast/parser/document-write-option-expected.checksum:
* fast/parser/document-write-option-expected.png:
* fast/parser/entities-in-xhtml-expected.checksum:
* fast/parser/entities-in-xhtml-expected.png:
* fast/replaced/005-expected.checksum:
* fast/replaced/005-expected.png:
* fast/replaced/width100percent-expected.checksum:
* fast/replaced/width100percent-expected.png:
* fast/selectors/166-expected.checksum:
* fast/selectors/166-expected.png:
* fast/table/023-expected.checksum:
* fast/table/023-expected.png:
* fast/table/034-expected.checksum:
* fast/table/034-expected.png:
* fast/table/040-expected.checksum:
* fast/table/040-expected.png:
* fast/table/border-collapsing/004-expected.checksum:
* fast/table/border-collapsing/004-expected.png:
* fast/table/edge-offsets-expected.checksum:
* fast/table/edge-offsets-expected.png:
* fast/table/height-percent-test-expected.checksum:
* fast/table/height-percent-test-expected.png:
* fast/table/overflowHidden-expected.checksum:
* fast/table/overflowHidden-expected.png:
* fast/table/wide-colspan-expected.checksum:
* fast/table/wide-colspan-expected.png:
* fast/table/wide-column-expected.checksum:
* fast/table/wide-column-expected.png:
* fast/text/softHyphen-expected.checksum:
* fast/text/softHyphen-expected.png:
* fast/text/whitespace/024-expected.checksum:
* fast/text/whitespace/024-expected.png:
* fast/tokenizer/004-expected.checksum:
* fast/tokenizer/004-expected.png:
* svg/custom/feDisplacementMap-01-expected.png: Removed.
* svg/custom/junk-data-expected.checksum:
* svg/custom/junk-data-expected.png:
* svg/custom/missing-xlink-expected.checksum:
* svg/custom/missing-xlink-expected.png:
* svg/custom/path-bad-data-expected.checksum:
* svg/custom/path-bad-data-expected.png:
* traversal/tree-walker-004-expected.checksum:
* traversal/tree-walker-004-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 16 Feb 2006 09:20:15 +0000 (09:20 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 16 Feb 2006 09:16:32 +0000 (09:16 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 16 Feb 2006 06:34:49 +0000 (06:34 +0000)]
JavaScriptCore:
Reviewed by Maciej, Eric.
- WebCore half of fix for <rdar://problem/
4176077> CrashTracer: 6569
crashes in DashboardClient at com.apple.JavaScriptCore:
KJS::Bindings::ObjcFallbackObjectImp::type()
WebCore and JavaScriptCore weren't sharing Instance objects very
nicely. I made them use RefPtrs, and sent them to bed without dessert.
* bindings/jni/jni_instance.cpp: Made _instance a RefPtr
(JavaInstance::~JavaInstance):
(JObjectWrapper::JObjectWrapper):
* bindings/jni/jni_instance.h:
(KJS::Bindings::JObjectWrapper::ref):
(KJS::Bindings::JObjectWrapper::deref):
* bindings/jni/jni_runtime.cpp: Made _array a RefPtr
(JavaArray::~JavaArray):
(JavaArray::JavaArray):
* bindings/jni/jni_runtime.h:
(KJS::Bindings::JavaArray::operator=):
* bindings/objc/objc_runtime.h:
- Prohibited copying because that would muss the ref count.
- Prohibited construction without instance because an instance wrapper
without an instance is almost certainly a bug.
* bindings/objc/objc_runtime.mm:
(ObjcFallbackObjectImp::ObjcFallbackObjectImp):
* bindings/runtime.cpp:
(KJS::Bindings::Instance::Instance):
(KJS::Bindings::Instance::createBindingForLanguageInstance):
(KJS::Bindings::Instance::createRuntimeObject):
* bindings/runtime.h:
(KJS::Bindings::Instance::ref):
(KJS::Bindings::Instance::deref):
* bindings/runtime_object.cpp:
(RuntimeObjectImp::RuntimeObjectImp):
(RuntimeObjectImp::fallbackObjectGetter):
(RuntimeObjectImp::fieldGetter):
(RuntimeObjectImp::methodGetter):
(RuntimeObjectImp::getOwnPropertySlot):
(RuntimeObjectImp::put):
(RuntimeObjectImp::canPut):
* bindings/runtime_object.h:
- Removed ownsInstance data member because RefPtr takes care of
instance lifetime now.
- Prohibited copying because that would muss the ref count.
- Prohibited construction without instance because an instance wrapper
without an instance is almost certainly a bug.
(KJS::RuntimeObjectImp::getInternalInstance):
LayoutTests:
Reviewed by Eric.
- Layout test for <rdar://problem/
4176077> CrashTracer: 6569
crashes in DashboardClient at com.apple.JavaScriptCore:
KJS::Bindings::ObjcFallbackObjectImp::type()
* plugins: Added.
* plugins/undefined-property-crash-expected.txt: Added.
* plugins/undefined-property-crash.html: Added.
WebCore:
Reviewed by Maciej, Eric.
- WebCore half of fix for <rdar://problem/
4176077> CrashTracer: 6569
crashes in DashboardClient at com.apple.JavaScriptCore:
KJS::Bindings::ObjcFallbackObjectImp::type()
WebCore and JavaScriptCore weren't sharing Instance objects very
nicely. I made them use RefPtrs, and sent them to bed without dessert.
* khtml/html/html_objectimpl.cpp:
(WebCore::HTMLAppletElementImpl::HTMLAppletElementImpl): Made
appletInstance a RefPtr
(WebCore::HTMLAppletElementImpl::getAppletInstance):
(WebCore::HTMLAppletElementImpl::detach):
(WebCore::HTMLEmbedElementImpl::HTMLEmbedElementImpl): Made
embedInstance a RefPtr
(WebCore::HTMLEmbedElementImpl::getEmbedInstance):
(WebCore::HTMLEmbedElementImpl::detach):
(WebCore::HTMLObjectElementImpl::HTMLObjectElementImpl): Made
objectInstance a RefPtr
(WebCore::HTMLObjectElementImpl::getObjectInstance):
(WebCore::HTMLObjectElementImpl::detach):
* bindings/js/JSDOMCore.cpp:
* khtml/ecma/kjs_dom.cpp:
(KJS::getRuntimeObject):
* khtml/html/html_objectimpl.h:
WebKitTools:
Reviewed by Eric.
* DumpRenderTree/DumpRenderTree.m:
(-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]):
Added a dummy method for the sake of LayoutTests/plugins/
undefined-property-crash.html. (It tests a crash due to fallback
object use. WebCore won't create a fallback object if the method is
not defined.)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 16 Feb 2006 06:11:16 +0000 (06:11 +0000)]
Reviewed by Tim H.
Updated the site to use the new layout.
* .htaccess: Added.
* ChangeLog:
* blog/wp-content/themes/classic: Removed.
* blog/wp-content/themes/classic/comments-popup.php: Removed.
* blog/wp-content/themes/classic/comments.php: Removed.
* blog/wp-content/themes/classic/footer.php: Removed.
* blog/wp-content/themes/classic/header.php: Removed.
* blog/wp-content/themes/classic/index.php: Removed.
* blog/wp-content/themes/classic/sidebar.php: Removed.
* blog/wp-content/themes/classic/style.css: Removed.
* blog/wp-content/themes/default: Removed.
* blog/wp-content/themes/default/404.php: Removed.
* blog/wp-content/themes/default/archive.php: Removed.
* blog/wp-content/themes/default/archives.php: Removed.
* blog/wp-content/themes/default/comments-popup.php: Removed.
* blog/wp-content/themes/default/comments.php: Removed.
* blog/wp-content/themes/default/footer.php: Removed.
* blog/wp-content/themes/default/header.php: Removed.
* blog/wp-content/themes/default/images: Removed.
* blog/wp-content/themes/default/images/kubrickbg.jpg: Removed.
* blog/wp-content/themes/default/images/kubrickbgcolor.jpg: Removed.
* blog/wp-content/themes/default/images/kubrickbgwide.jpg: Removed.
* blog/wp-content/themes/default/images/kubrickfooter.jpg: Removed.
* blog/wp-content/themes/default/images/kubrickheader.jpg: Removed.
* blog/wp-content/themes/default/index.php: Removed.
* blog/wp-content/themes/default/links.php: Removed.
* blog/wp-content/themes/default/page.php: Removed.
* blog/wp-content/themes/default/search.php: Removed.
* blog/wp-content/themes/default/searchform.php: Removed.
* blog/wp-content/themes/default/sidebar.php: Removed.
* blog/wp-content/themes/default/single.php: Removed.
* blog/wp-content/themes/default/style.css: Removed.
* blog/wp-content/themes/webkit/404.php:
* blog/wp-content/themes/webkit/archive.php:
* blog/wp-content/themes/webkit/archives.php:
* blog/wp-content/themes/webkit/footer.php:
* blog/wp-content/themes/webkit/header.php:
* blog/wp-content/themes/webkit/images: Removed.
* blog/wp-content/themes/webkit/images/bluebanner.png: Removed.
* blog/wp-content/themes/webkit/images/kubrickbg.jpg: Removed.
* blog/wp-content/themes/webkit/images/kubrickbgcolor.jpg: Removed.
* blog/wp-content/themes/webkit/images/kubrickbgwide.jpg: Removed.
* blog/wp-content/themes/webkit/images/kubrickfooter.jpg: Removed.
* blog/wp-content/themes/webkit/images/kubrickheader.jpg: Removed.
* blog/wp-content/themes/webkit/images/separator.png: Removed.
* blog/wp-content/themes/webkit/images/webkit-background.png: Removed.
* blog/wp-content/themes/webkit/index.php:
* blog/wp-content/themes/webkit/page.php:
* blog/wp-content/themes/webkit/search.php:
* blog/wp-content/themes/webkit/sidebar.php:
* blog/wp-content/themes/webkit/single.php:
* blog/wp-content/themes/webkit/style.css:
* building/build.html:
* building/checkout.html:
* coding/coding-style.html:
* coding/contributing.html:
* contact.html:
* css: Added.
* css/blue.css: Added.
* css/gray.css: Added.
* css/green.css: Added.
* css/ie.css: Added.
* css/main.css: Added.
* css/pink.css: Added.
* css/purple.css: Added.
* css/yellow.css: Added.
* footer.inc: Added.
* header.inc: Added.
* images/blue-background.png: Added.
* images/blue-bullet.png: Added.
* images/bluebanner.png: Removed.
* images/download.png: Added.
* images/end.png: Added.
* images/gray-background.png: Added.
* images/green-background.png: Added.
* images/green-bullet.png: Added.
* images/icon-gold.png: Added.
* images/icon.png: Added.
* images/ie-nav.png: Added.
* images/middle.png: Added.
* images/nav.png: Added.
* images/pink-background.png: Added.
* images/pink-bullet.png: Added.
* images/purple-background.png: Added.
* images/purple-bullet.png: Added.
* images/separator.png: Removed.
* images/webkit-background.png: Removed.
* images/welcomeopen.gif: Removed.
* images/yellow-background.png: Added.
* images/yellow-bullet.png: Added.
* index.html:
* nav.inc: Added.
* projects/accessibility/index.html:
* projects/cleanup/index.html:
* projects/compat/index.html:
* projects/css/index.html:
* projects/documentation/index.html:
* projects/dom/index.html:
* projects/editing/index.html:
* projects/forms/index.html:
* projects/html/index.html:
* projects/index.html:
* projects/javascript/index.html:
* projects/layout/index.html:
* projects/mathml/index.html:
* projects/performance/index.html:
* projects/plugins/index.html:
* projects/portability/index.html:
* projects/printing/index.html:
* projects/svg/index.html:
* projects/webkit/index.html:
* projects/xml/index.html:
* projects/xslt/index.html:
* quality/bugpriorities.html:
* quality/bugwriting.html:
* quality/bugzilla.html:
* quality/lifecycle.html:
* quality/reduction.html:
* quality/reporting.html:
* quality/testing.html:
* quality/testwriting.html:
* sidebar.css: Removed.
* sidebar.html: Removed.
* webkitdev.css: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Thu, 16 Feb 2006 04:21:14 +0000 (04:21 +0000)]
2006-02-15 Eric Seidel <eseidel@apple.com>
Add files missing from previous commit.
* svg/custom/feDisplacementMap-01-expected.checksum: Added.
* svg/custom/feDisplacementMap-01-expected.png: Added.
* svg/custom/feDisplacementMap-01-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 16 Feb 2006 00:19:21 +0000 (00:19 +0000)]
Reviewed by Eric.
- Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4674
LEAK: WheelEventImpl leaked when mousewheel used
No test case because it requires manual mouse wheeling.
* dom/NodeImpl.cpp:
(WebCore::NodeImpl::dispatchWheelEvent): Use a RefPtr instead of just
leaking the WheelEventImpl.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 16 Feb 2006 00:16:34 +0000 (00:16 +0000)]
Reviewed by John.
- Applied the
4330457 change to CClass and ObjcClass as well.
Once plugins work in DumpRenderTree, running run-webkit-tests --leaks
will catch this.
This change isn't as critical because CClass and ObjcClass objects get
cached globally and never deleted, but it's good practice, in case we
ever do decide to delete CClass and ObjcClass objects.
This change requires prohibiting copying, because we don't do any
intelligent ref-counting -- when a Class is destroyed, it destroys its
methods and fields unconditionally. (Java classes already prohibited
copying.)
* bindings/c/c_class.cpp:
- Merged _commonInit and _commonDelete into constructor and destructor.
(CClass::CClass):
(CClass::~CClass):
(CClass::methodsNamed): Added delete callbacks
(CClass::fieldNamed): Added delete callbacks
* bindings/c/c_class.h: Prohibited copying
* bindings/c/c_instance.cpp:
(KJS::Bindings::CInstance::getClass): Changed to use the preferred
class factory method, to take advantage of the global cache.
[ Repeated changes applied to CClass for ObjcClass: ]
* bindings/objc/objc_class.h:
* bindings/objc/objc_class.mm:
(KJS::Bindings::ObjcClass::ObjcClass):
(KJS::Bindings::ObjcClass::~ObjcClass):
(KJS::Bindings::ObjcClass::methodsNamed):
(KJS::Bindings::ObjcClass::fieldNamed):
* bindings/objc/objc_runtime.h:
(KJS::Bindings::ObjcMethod::ObjcMethod): Initialized uninitialized
variable to prevent bad CFRelease.
(KJS::Bindings::ObjcMethod::~ObjcMethod): Removed erroneous ';' from
if statement to prevent bad CFRelease.
* bindings/objc/objc_runtime.cpp: Changed to use the preferred
ObjectStructPtr, for clarity.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 15 Feb 2006 23:50:09 +0000 (23:50 +0000)]
Reviewed by John.
- Fixed <rdar://problem/
4330457> CrashTracer: [REGRESSION] 3763 crashes
in Safari at com.apple.JavaScriptCore: KJS::Bindings::JavaInstance::
getClass const + 56
This was a memory leak in the bindings code. The leak was so extreme
that it would cause Safari or the JVM to abort from lack of memory.
Upon construction, Class objects create field and method objects,
storing them in CFDictionaries. The bug was that upon destruction, the
class objects released the dictionaries but didn't destroy the stored
objects.
The fix is to supply CFDictionary callbacks for destroying the values
added to the dictionary. This also requires prohibiting copying,
because we don't do any intelligent ref-counting -- when a Class is
destroyed, it destroys its methods and fields unconditionally.
* bindings/jni/jni_class.cpp:
(JavaClass::JavaClass): Added delete callbacks
* bindings/runtime.cpp: Added definitions for delete callbacks
(KJS::Bindings::deleteMethodList):
(KJS::Bindings::deleteMethod):
(KJS::Bindings::deleteField):
* bindings/runtime.h: Added declarations for delete callbacks
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 15 Feb 2006 23:04:54 +0000 (23:04 +0000)]
Build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 15 Feb 2006 22:58:40 +0000 (22:58 +0000)]
Make FontFamily compile on Win32. Fix image decoder issue with frameBufferAtIndex API.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 15 Feb 2006 22:57:09 +0000 (22:57 +0000)]
Make FontFamily compile on Win32. Fix image decoder issue with frameBufferAtIndex API.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 15 Feb 2006 22:37:24 +0000 (22:37 +0000)]
Make KWQFontFamily portable. Split it out into a cross-platform core and the Mac-specific version.
Move it to platform and rename it to FontFamily (and FontFamilyMac).
Reviewed by eric
* WebCore.xcodeproj/project.pbxproj:
* css/cssstyleselector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* kwq/KWQFont.h:
(QFont::firstFamily):
* kwq/KWQFont.mm:
(QFont::setFirstFamily):
* kwq/KWQFontFamily.h: Removed.
* kwq/KWQFontFamily.mm: Removed.
* platform/FontFamily.cpp: Added.
(WebCore::FontFamily::FontFamily):
(WebCore::FontFamily::~FontFamily):
(WebCore::FontFamily::operator=):
(WebCore::FontFamily::setFamily):
(WebCore::FontFamily::operator==):
* platform/FontFamily.h: Added.
(WebCore::FontFamily::family):
(WebCore::FontFamily::familyIsEmpty):
(WebCore::FontFamily::next):
(WebCore::FontFamily::appendFamily):
(WebCore::FontFamily::operator!=):
(WebCore::FontFamily::ref):
(WebCore::FontFamily::deref):
* platform/mac/FontFamilyMac.mm: Added.
(WebCore::retainDOMStringImpl):
(WebCore::releaseDOMStringImpl):
(WebCore::):
(WebCore::FontFamily::getNSFamily):
* rendering/font.h:
(khtml::FontDef::firstFamily):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 15 Feb 2006 16:36:43 +0000 (16:36 +0000)]
* English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12821
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 15 Feb 2006 14:47:17 +0000 (14:47 +0000)]
Reviewed by Tim H.
Updated page to show 10.4.4 or 10.4.5
Added support for recognizing Shiira.
* quality/reporting.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12820
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 15 Feb 2006 10:30:52 +0000 (10:30 +0000)]
2006-02-15 Oliver Hunt <ojh16@student.canterbury.ac.nz>
Reviewed by eseidel. Landed by eseidel.
Implemented feDisplacementMap.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5862
Test: svg/custom/feDisplacementMap-01.svg
* WebCore.xcodeproj/project.pbxproj: added files.
* kcanvas/KCanvasFilters.cpp:
(WebCore::KCanvasFEDisplacementMap::externalRepresentation):
* kcanvas/KCanvasFilters.h:
(WebCore::KCanvasFEDisplacementMap::KCanvasFEDisplacementMap):
(WebCore::KCanvasFEDisplacementMap::xChannelSelector):
(WebCore::KCanvasFEDisplacementMap::setXChannelSelector):
(WebCore::KCanvasFEDisplacementMap::yChannelSelector):
(WebCore::KCanvasFEDisplacementMap::setYChannelSelector):
(WebCore::KCanvasFEDisplacementMap::scale):
(WebCore::KCanvasFEDisplacementMap::setScale):
* kcanvas/device/quartz/KCanvasFilterQuartz.h:
* kcanvas/device/quartz/KCanvasFilterQuartz.mm:
(WebCore::getVectorForChannel):
(WebCore::KCanvasFEDisplacementMapQuartz::getCIFilter):
* kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
(WebCore::KRenderingDeviceQuartz::createFilterEffect):
* kcanvas/device/quartz/filters/WKDisplacementMapFilter.cikernel: Added.
* kcanvas/device/quartz/filters/WKDisplacementMapFilter.h: Added.
* kcanvas/device/quartz/filters/WKDisplacementMapFilter.m: Added.
(+[WKDisplacementMapFilter initialize]):
(+[WKDisplacementMapFilter filterWithName:]):
(-[WKDisplacementMapFilter init]):
(-[WKDisplacementMapFilter outputImage]):
* ksvg2/svg/SVGFEDisplacementMapElementImpl.cpp: Added.
(SVGFEDisplacementMapElementImpl::SVGFEDisplacementMapElementImpl):
(SVGFEDisplacementMapElementImpl::~SVGFEDisplacementMapElementImpl):
(SVGFEDisplacementMapElementImpl::in1):
(SVGFEDisplacementMapElementImpl::in2):
(SVGFEDisplacementMapElementImpl::xChannelSelector):
(SVGFEDisplacementMapElementImpl::yChannelSelector):
(SVGFEDisplacementMapElementImpl::scale):
(SVGFEDisplacementMapElementImpl::stringToChannel):
(SVGFEDisplacementMapElementImpl::parseMappedAttribute):
(SVGFEDisplacementMapElementImpl::filterEffect):
* ksvg2/svg/SVGFEDisplacementMapElementImpl.h: Added.
* ksvg2/svg/svgtags.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 15 Feb 2006 09:54:43 +0000 (09:54 +0000)]
2006-02-15 Eric Seidel <eseidel@apple.com>
Update missing result from last commit.
* fast/xsl/xslt-recursion-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 15 Feb 2006 09:44:49 +0000 (09:44 +0000)]
Rubber stamped by Anders.
* WebView/WebControllerPolicyHandlerDelegate.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 15 Feb 2006 09:20:41 +0000 (09:20 +0000)]
Reviewed by Anders.
- remove some voodoo code
* WebView/WebDataSource.m:
(-[WebDataSource _setLoading:]): Removed useless ref/deref of self and WebView.
A WebDataSource cannot be loading unless it is still connected to the WebView that
owns it and retained by it, because getting disconnected stops loading.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 15 Feb 2006 09:16:08 +0000 (09:16 +0000)]
2006-02-15 Eric Seidel <eseidel@apple.com>
Reviewed by darin.
Commit change forgotten after editing directory move.
* editing/markup.cpp:
(khtml::startMarkup): add support for serializing DOCTYPEs in xml
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Wed, 15 Feb 2006 05:49:40 +0000 (05:49 +0000)]
Reviewed by Maciej.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6452
KURL::appendEscapingBadChars() doesn't know about %u-escaping.
Test case: fast/encoding/percent-escaping.html
* kwq/KWQKURL.mm: (appendEscapingBadChars):
Rather than adding support for %u, remove the existing
"do what I mean" escaping of percent characters that do not
look like a result of prior escaping.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12814
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 15 Feb 2006 03:30:42 +0000 (03:30 +0000)]
2006-02-14 Eric Seidel <eseidel@apple.com>
Fix build failure from last minute edit.
* khtml/xsl/xsl_stylesheetimpl.cpp:
(WebCore::XSLStyleSheetImpl::parseString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 15 Feb 2006 03:01:43 +0000 (03:01 +0000)]
2006-02-14 Eric Seidel <eseidel@apple.com>
Reviewed by darin.
Add incremental parsing support to XMLTokenizer.
This patch also does a few other little things:
- removes (unused) onHold support from Tokenizer
- adds serialization of DOCTYPEs for xml documents
- fixes xslt support to no longer depend on synchronous parsing
- fixes css styling for pages where xsl recursion is blocked
http://bugzilla.opendarwin.org/show_bug.cgi?id=6057
* dom/DocumentImpl.cpp:
(WebCore::DocumentImpl::DocumentImpl):
(WebCore::DocumentImpl::createProcessingInstruction):
(WebCore::DocumentImpl::open):
(WebCore::DocumentImpl::recalcStyleSelector):
* dom/dom_xmlimpl.cpp:
(WebCore::ProcessingInstructionImpl::checkStyleSheet):
* dom/xml_tokenizer.cpp:
(WebCore::XMLTokenizer::XMLTokenizer):
(WebCore::XMLTokenizer::write):
(WebCore::XMLTokenizer::startElementNs):
(WebCore::XMLTokenizer::error):
(WebCore::XMLTokenizer::initializeParserContext):
(WebCore::XMLTokenizer::finish):
(WebCore::xmlDocPtrForString):
(WebCore::parseAttributes):
* dom/xml_tokenizer.h:
* khtml/editing/markup.cpp:
(khtml::startMarkup): DOCTYPE serialization
* khtml/html/htmltokenizer.cpp:
(WebCore::HTMLTokenizer::HTMLTokenizer): removed onHold
(WebCore::HTMLTokenizer::reset): removed onHold
(WebCore::HTMLTokenizer::begin): removed onHold
(WebCore::HTMLTokenizer::write): removed onHold
(WebCore::HTMLTokenizer::finish): removed onHold
* khtml/html/htmltokenizer.h: removed onHold support
* khtml/xsl/xsl_stylesheetimpl.cpp:
(WebCore::XSLStyleSheetImpl::XSLStyleSheetImpl):
(WebCore::XSLStyleSheetImpl::~XSLStyleSheetImpl):
(WebCore::XSLStyleSheetImpl::document):
(WebCore::XSLStyleSheetImpl::setDocument):
(WebCore::XSLStyleSheetImpl::parseString):
(WebCore::XSLStyleSheetImpl::loadChildSheets):
(WebCore::XSLStyleSheetImpl::compileStyleSheet):
(WebCore::XSLStyleSheetImpl::locateStylesheetSubResource):
* khtml/xsl/xsl_stylesheetimpl.h: moved functions to .cpp file
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 15 Feb 2006 02:55:20 +0000 (02:55 +0000)]
Reviewed by Anders.
Improvements to frame loading:
- remove LayoutAcceptable state entirely
- fix WebImageView to work right without LayoutAcceptable state
- move guts of commitIfReady: to WebFrame
- try to separate page cache loading from normal loading a bit more
* English.lproj/StringsNotToBeLocalized.txt:
* WebView/WebDataSource.m:
(-[WebDataSource _prepareForLoadStart]):
(-[WebDataSource _loadFromPageCache:]):
(-[WebDataSource _startLoading]):
(-[WebDataSource _commitIfReady]):
(-[WebDataSource _setupForReplaceByMIMEType:]):
* WebView/WebDataSourcePrivate.h:
* WebView/WebFrame.m:
(-[WebFrame _transitionToCommitted:]):
(-[WebFrame _commitProvisionalLoad:]):
(-[WebFrame _checkLoadCompleteForThisFrame]):
(-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
* WebView/WebFramePrivate.h:
* WebView/WebImageRepresentation.h:
* WebView/WebImageRepresentation.m:
* WebView/WebImageView.m:
(-[WebImageView dataSourceUpdated:]):
(-[WebImageView setNeedsLayout:]):
(-[WebImageView writeImageToPasteboard:types:]):
(-[WebImageView copy:]):
(-[WebImageView mouseDragged:]):
* WebView/WebView.m:
(-[WebView _finishedLoadingResourceFromDataSource:]):
(-[WebView _mainReceivedBytesSoFar:fromDataSource:complete:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 15 Feb 2006 02:35:29 +0000 (02:35 +0000)]
LayoutTests:
Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=6815
Calculate correct width for new text fields
* fast/forms/input-appearance-width.html: Added.
* fast/forms/input-appearance-width-expected.txt: Added.
* fast/forms/input-appearance-width-expected.png: Added.
* fast/forms/input-appearance-width-expected.checksum: Added.
* fast/forms/input-appearance-minWidth.html: Added.
* fast/forms/input-appearance-minWidth-expected.txt: Added.
* fast/forms/input-appearance-minWidth-expected.png: Added.
* fast/forms/input-appearance-minWidth-expected.checksum: Added.
WebCore:
Reviewed by Maciej.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6815
Calculate correct width for new text fields
Tests:
fast/forms/input-appearance-width.html
fast/forms/input-appearance-minWidth.html
* rendering/RenderTextField.cpp:
(WebCore::RenderTextField::createDivStyle): Remove fixed width for text field.
(WebCore::RenderTextField::calcMinMaxWidth): Added. This calls RenderBlock::calcMinMaxWidth and
then uses the size attribute to determine what the maxWidth should be.
* rendering/RenderTextField.h: Added calcMinMaxWidth.
* rendering/render_theme_mac.h: Added adjustTextFieldStyle.
* rendering/render_theme_mac.mm:
(WebCore::RenderThemeMac::adjustRepaintRect): Remove inflation of rect. This is no longer necessary.
(WebCore::RenderThemeMac::paintTextField): ditto.
(WebCore::RenderThemeMac::setTextFieldCellState): change true to YES.
(WebCore::RenderThemeMac::adjustTextFieldStyle): Added. This is the temporary home of the code to set the
right padding and margins. When we flip the switch, this will go in html4.css.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 15 Feb 2006 02:07:07 +0000 (02:07 +0000)]
2006-02-14 Eric Seidel <eseidel@apple.com>
Reviewed by adele.
* Scripts/run-webkit-tests: added --results-directory (-o) option
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Wed, 15 Feb 2006 01:36:25 +0000 (01:36 +0000)]
Reviewed by Tim Hatcher.
removed -[DOMHTMLSelectElement _optionLabels], formerly used only by Safari, now unused.
* bindings/objc/DOMHTML.mm:
* bindings/objc/DOMPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 15 Feb 2006 00:15:17 +0000 (00:15 +0000)]
JavaScriptCore:
Reviewed by Justin.
Fixed <rdar://problem/
4415050> STD: WebCore build steps use echo -n, which will change
behavior due to POSIX version of sh
* JavaScriptCore.xcodeproj/project.pbxproj: removed the use of echo -n, replaced with printf ""
WebCore:
Reviewed by Justin.
Fixed <rdar://problem/
4415050> STD: WebCore build steps use echo -n, which will change
behavior due to POSIX version of sh
* WebCore.xcodeproj/project.pbxproj: removed the use of echo -n, replaced with printf ""
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 14 Feb 2006 22:42:26 +0000 (22:42 +0000)]
One more of the same (this one tests list boxes instead of pop-up menus)
* fast/forms/HTMLOptionElement_label05-expected.checksum: Added.
* fast/forms/HTMLOptionElement_label05-expected.png: Added.
* fast/forms/HTMLOptionElement_label05-expected.txt: Added.
* fast/forms/HTMLOptionElement_label05.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 14 Feb 2006 22:33:12 +0000 (22:33 +0000)]
Added another option element label test at Dave Hyatt's suggestion
* fast/forms/HTMLOptionElement_label04-expected.checksum: Added.
* fast/forms/HTMLOptionElement_label04-expected.png: Added.
* fast/forms/HTMLOptionElement_label04-expected.txt: Added.
* fast/forms/HTMLOptionElement_label04.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Tue, 14 Feb 2006 22:14:08 +0000 (22:14 +0000)]
Reviewed by Eric.
Moving these tests to a better location.
* dom/html/level2/html/HTMLOptionElement_label01-expected.checksum: Removed.
* dom/html/level2/html/HTMLOptionElement_label01-expected.png: Removed.
* dom/html/level2/html/HTMLOptionElement_label01-expected.txt: Removed.
* dom/html/level2/html/HTMLOptionElement_label01.html: Removed.
* dom/html/level2/html/HTMLOptionElement_label02-expected.checksum: Removed.
* dom/html/level2/html/HTMLOptionElement_label02-expected.png: Removed.
* dom/html/level2/html/HTMLOptionElement_label02-expected.txt: Removed.
* dom/html/level2/html/HTMLOptionElement_label02.html: Removed.
* dom/html/level2/html/HTMLOptionElement_label03-expected.checksum: Removed.
* dom/html/level2/html/HTMLOptionElement_label03-expected.png: Removed.
* dom/html/level2/html/HTMLOptionElement_label03-expected.txt: Removed.
* dom/html/level2/html/HTMLOptionElement_label03.html: Removed.
* fast/forms/HTMLOptionElement_label01-expected.checksum: Added.
* fast/forms/HTMLOptionElement_label01-expected.png: Added.
* fast/forms/HTMLOptionElement_label01-expected.txt: Added.
* fast/forms/HTMLOptionElement_label01.html: Added.
* fast/forms/HTMLOptionElement_label02-expected.checksum: Added.
* fast/forms/HTMLOptionElement_label02-expected.png: Added.
* fast/forms/HTMLOptionElement_label02-expected.txt: Added.
* fast/forms/HTMLOptionElement_label02.html: Added.
* fast/forms/HTMLOptionElement_label03-expected.checksum: Added.
* fast/forms/HTMLOptionElement_label03-expected.png: Added.
* fast/forms/HTMLOptionElement_label03-expected.txt: Added.
* fast/forms/HTMLOptionElement_label03.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 14 Feb 2006 21:40:54 +0000 (21:40 +0000)]
Rubber-stamped by Eric.
- moved editing sources from khtml/editing to editing, and renamed files with single classes
* WebCore.xcodeproj/project.pbxproj: Added new, removed old.
* WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
* bridge/mac/MacFrame.mm:
* bridge/mac/WebCoreFrameBridge.mm:
* dom/DocumentImpl.cpp:
* dom/dom2_rangeimpl.cpp:
* dom/dom_position.cpp:
* khtml/khtml_events.cpp:
* kwq/KWQAccObject.mm:
* kwq/KWQAccObjectCache.h:
* kwq/KWQEditCommand.mm:
* page/Frame.cpp:
* page/FramePrivate.h:
* rendering/RenderBlock.cpp:
* rendering/RenderContainer.cpp:
* rendering/RenderText.cpp:
* rendering/render_br.cpp:
* rendering/render_inline.cpp:
* rendering/render_object.cpp:
* rendering/render_replaced.cpp:
Fixed up includes.
* editing: Added.
* editing/AppendNodeCommand.cpp: Added.
* editing/AppendNodeCommand.h: Added.
* editing/ApplyStyleCommand.cpp: Added.
* editing/ApplyStyleCommand.h: Added.
* editing/BreakBlockquoteCommand.cpp: Added.
* editing/BreakBlockquoteCommand.h: Added.
* editing/CompositeEditCommand.cpp: Added.
* editing/CompositeEditCommand.h: Added.
* editing/DeleteFromTextNodeCommand.cpp: Added.
* editing/DeleteFromTextNodeCommand.h: Added.
* editing/DeleteSelectionCommand.cpp: Added.
* editing/DeleteSelectionCommand.h: Added.
* editing/EditCommand.cpp: Added.
* editing/EditCommand.h: Added.
* editing/InsertIntoTextNodeCommand.cpp: Added.
* editing/InsertIntoTextNodeCommand.h: Added.
* editing/InsertLineBreakCommand.cpp: Added.
* editing/InsertLineBreakCommand.h: Added.
* editing/InsertNodeBeforeCommand.cpp: Added.
* editing/InsertNodeBeforeCommand.h: Added.
* editing/InsertParagraphSeparatorCommand.cpp: Added.
* editing/InsertParagraphSeparatorCommand.h: Added.
* editing/InsertTextCommand.cpp: Added.
* editing/InsertTextCommand.h: Added.
* editing/JoinTextNodesCommand.cpp: Added.
* editing/JoinTextNodesCommand.h: Added.
* editing/MergeIdenticalElementsCommand.cpp: Added.
* editing/MergeIdenticalElementsCommand.h: Added.
* editing/MoveSelectionCommand.cpp: Added.
* editing/MoveSelectionCommand.h: Added.
* editing/RebalanceWhitespaceCommand.cpp: Added.
* editing/RebalanceWhitespaceCommand.h: Added.
* editing/RemoveCSSPropertyCommand.cpp: Added.
* editing/RemoveCSSPropertyCommand.h: Added.
* editing/RemoveNodeAttributeCommand.cpp: Added.
* editing/RemoveNodeAttributeCommand.h: Added.
* editing/RemoveNodeCommand.cpp: Added.
* editing/RemoveNodeCommand.h: Added.
* editing/RemoveNodePreservingChildrenCommand.cpp: Added.
* editing/RemoveNodePreservingChildrenCommand.h: Added.
* editing/ReplaceSelectionCommand.cpp: Added.
* editing/ReplaceSelectionCommand.h: Added.
* editing/Selection.cpp:
* editing/SelectionController.cpp:
* editing/SetNodeAttributeCommand.cpp: Added.
* editing/SetNodeAttributeCommand.h: Added.
* editing/SplitElementCommand.cpp: Added.
* editing/SplitElementCommand.h: Added.
* editing/SplitTextNodeCommand.cpp: Added.
* editing/SplitTextNodeCommand.h: Added.
* editing/SplitTextNodeContainingElementCommand.cpp: Added.
* editing/SplitTextNodeContainingElementCommand.h: Added.
* editing/TypingCommand.cpp: Added.
* editing/TypingCommand.h: Added.
* editing/VisiblePosition.cpp: Added.
* editing/VisiblePosition.h: Added.
* editing/VisibleRange.cpp: Added.
* editing/VisibleRange.h: Added.
* editing/WrapContentsInDummySpanCommand.cpp: Added.
* editing/WrapContentsInDummySpanCommand.h: Added.
* editing/append_node_command.cpp: Removed.
* editing/append_node_command.h: Removed.
* editing/apply_style_command.cpp: Removed.
* editing/apply_style_command.h: Removed.
* editing/break_blockquote_command.cpp: Removed.
* editing/break_blockquote_command.h: Removed.
* editing/composite_edit_command.cpp: Removed.
* editing/composite_edit_command.h: Removed.
* editing/delete_from_text_node_command.cpp: Removed.
* editing/delete_from_text_node_command.h: Removed.
* editing/delete_selection_command.cpp: Removed.
* editing/delete_selection_command.h: Removed.
* editing/edit_command.cpp: Removed.
* editing/edit_command.h: Removed.
* editing/htmlediting.cpp:
* editing/insert_into_text_node_command.cpp: Removed.
* editing/insert_into_text_node_command.h: Removed.
* editing/insert_line_break_command.cpp: Removed.
* editing/insert_line_break_command.h: Removed.
* editing/insert_node_before_command.cpp: Removed.
* editing/insert_node_before_command.h: Removed.
* editing/insert_paragraph_separator_command.cpp: Removed.
* editing/insert_paragraph_separator_command.h: Removed.
* editing/insert_text_command.cpp: Removed.
* editing/insert_text_command.h: Removed.
* editing/join_text_nodes_command.cpp: Removed.
* editing/join_text_nodes_command.h: Removed.
* editing/jsediting.cpp:
* editing/markup.cpp:
* editing/merge_identical_elements_command.cpp: Removed.
* editing/merge_identical_elements_command.h: Removed.
* editing/move_selection_command.cpp: Removed.
* editing/move_selection_command.h: Removed.
* editing/rebalance_whitespace_command.cpp: Removed.
* editing/rebalance_whitespace_command.h: Removed.
* editing/remove_css_property_command.cpp: Removed.
* editing/remove_css_property_command.h: Removed.
* editing/remove_node_attribute_command.cpp: Removed.
* editing/remove_node_attribute_command.h: Removed.
* editing/remove_node_command.cpp: Removed.
* editing/remove_node_command.h: Removed.
* editing/remove_node_preserving_children_command.cpp: Removed.
* editing/remove_node_preserving_children_command.h: Removed.
* editing/replace_selection_command.cpp: Removed.
* editing/replace_selection_command.h: Removed.
* editing/set_node_attribute_command.cpp: Removed.
* editing/set_node_attribute_command.h: Removed.
* editing/split_element_command.cpp: Removed.
* editing/split_element_command.h: Removed.
* editing/split_text_node_command.cpp: Removed.
* editing/split_text_node_command.h: Removed.
* editing/split_text_node_containing_element.cpp: Removed.
* editing/split_text_node_containing_element_command.h: Removed.
* editing/typing_command.cpp: Removed.
* editing/typing_command.h: Removed.
* editing/visible_position.cpp: Removed.
* editing/visible_position.h: Removed.
* editing/visible_range.cpp: Removed.
* editing/visible_range.h: Removed.
* editing/visible_units.cpp:
* editing/wrap_contents_in_dummy_span_command.cpp: Removed.
* editing/wrap_contents_in_dummy_span_command.h: Removed.
* khtml/editing: Removed.
* khtml/editing/Selection.cpp: Removed.
* khtml/editing/Selection.h: Removed.
* khtml/editing/SelectionController.cpp: Removed.
* khtml/editing/SelectionController.h: Removed.
* khtml/editing/append_node_command.cpp: Removed.
* khtml/editing/append_node_command.h: Removed.
* khtml/editing/apply_style_command.cpp: Removed.
* khtml/editing/apply_style_command.h: Removed.
* khtml/editing/break_blockquote_command.cpp: Removed.
* khtml/editing/break_blockquote_command.h: Removed.
* khtml/editing/composite_edit_command.cpp: Removed.
* khtml/editing/composite_edit_command.h: Removed.
* khtml/editing/delete_from_text_node_command.cpp: Removed.
* khtml/editing/delete_from_text_node_command.h: Removed.
* khtml/editing/delete_selection_command.cpp: Removed.
* khtml/editing/delete_selection_command.h: Removed.
* khtml/editing/edit_actions.h: Removed.
* khtml/editing/edit_command.cpp: Removed.
* khtml/editing/edit_command.h: Removed.
* khtml/editing/html_interchange.cpp: Removed.
* khtml/editing/html_interchange.h: Removed.
* khtml/editing/htmlediting.cpp: Removed.
* khtml/editing/htmlediting.h: Removed.
* khtml/editing/insert_into_text_node_command.cpp: Removed.
* khtml/editing/insert_into_text_node_command.h: Removed.
* khtml/editing/insert_line_break_command.cpp: Removed.
* khtml/editing/insert_line_break_command.h: Removed.
* khtml/editing/insert_node_before_command.cpp: Removed.
* khtml/editing/insert_node_before_command.h: Removed.
* khtml/editing/insert_paragraph_separator_command.cpp: Removed.
* khtml/editing/insert_paragraph_separator_command.h: Removed.
* khtml/editing/insert_text_command.cpp: Removed.
* khtml/editing/insert_text_command.h: Removed.
* khtml/editing/join_text_nodes_command.cpp: Removed.
* khtml/editing/join_text_nodes_command.h: Removed.
* khtml/editing/jsediting.cpp: Removed.
* khtml/editing/jsediting.h: Removed.
* khtml/editing/markup.cpp: Removed.
* khtml/editing/markup.h: Removed.
* khtml/editing/merge_identical_elements_command.cpp: Removed.
* khtml/editing/merge_identical_elements_command.h: Removed.
* khtml/editing/move_selection_command.cpp: Removed.
* khtml/editing/move_selection_command.h: Removed.
* khtml/editing/rebalance_whitespace_command.cpp: Removed.
* khtml/editing/rebalance_whitespace_command.h: Removed.
* khtml/editing/remove_css_property_command.cpp: Removed.
* khtml/editing/remove_css_property_command.h: Removed.
* khtml/editing/remove_node_attribute_command.cpp: Removed.
* khtml/editing/remove_node_attribute_command.h: Removed.
* khtml/editing/remove_node_command.cpp: Removed.
* khtml/editing/remove_node_command.h: Removed.
* khtml/editing/remove_node_preserving_children_command.cpp: Removed.
* khtml/editing/remove_node_preserving_children_command.h: Removed.
* khtml/editing/replace_selection_command.cpp: Removed.
* khtml/editing/replace_selection_command.h: Removed.
* khtml/editing/set_node_attribute_command.cpp: Removed.
* khtml/editing/set_node_attribute_command.h: Removed.
* khtml/editing/split_element_command.cpp: Removed.
* khtml/editing/split_element_command.h: Removed.
* khtml/editing/split_text_node_command.cpp: Removed.
* khtml/editing/split_text_node_command.h: Removed.
* khtml/editing/split_text_node_containing_element.cpp: Removed.
* khtml/editing/split_text_node_containing_element_command.h: Removed.
* khtml/editing/text_affinity.h: Removed.
* khtml/editing/text_granularity.h: Removed.
* khtml/editing/typing_command.cpp: Removed.
* khtml/editing/typing_command.h: Removed.
* khtml/editing/visible_position.cpp: Removed.
* khtml/editing/visible_position.h: Removed.
* khtml/editing/visible_range.cpp: Removed.
* khtml/editing/visible_range.h: Removed.
* khtml/editing/visible_text.cpp: Removed.
* khtml/editing/visible_text.h: Removed.
* khtml/editing/visible_units.cpp: Removed.
* khtml/editing/visible_units.h: Removed.
* khtml/editing/wrap_contents_in_dummy_span_command.cpp: Removed.
* khtml/editing/wrap_contents_in_dummy_span_command.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 14 Feb 2006 21:40:48 +0000 (21:40 +0000)]
Reviewed by Adele Peterson.
- tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=7255
label attribute in option elements is ignored
* dom/html/level2/html/HTMLOptionElement_label01-expected.checksum: Added.
* dom/html/level2/html/HTMLOptionElement_label01-expected.png: Added.
* dom/html/level2/html/HTMLOptionElement_label01-expected.txt: Added.
* dom/html/level2/html/HTMLOptionElement_label01.html: Added.
* dom/html/level2/html/HTMLOptionElement_label02-expected.checksum: Added.
* dom/html/level2/html/HTMLOptionElement_label02-expected.png: Added.
* dom/html/level2/html/HTMLOptionElement_label02-expected.txt: Added.
* dom/html/level2/html/HTMLOptionElement_label02.html: Added.
* dom/html/level2/html/HTMLOptionElement_label03-expected.checksum: Added.
* dom/html/level2/html/HTMLOptionElement_label03-expected.png: Added.
* dom/html/level2/html/HTMLOptionElement_label03-expected.txt: Added.
* dom/html/level2/html/HTMLOptionElement_label03.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 14 Feb 2006 21:39:36 +0000 (21:39 +0000)]
Reviewed by Adele Peterson.
- fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=7255
label attribute in option elements is ignored
Test cases:
* dom/html/level2/html/HTMLOptionElement_label01.html
* dom/html/level2/html/HTMLOptionElement_label02.html
* dom/html/level2/html/HTMLOptionElement_label03.html
* rendering/render_form.cpp:
(WebCore::RenderSelect::updateFromElement):
use label attribute, if present, when setting text on the widget.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vicki [Tue, 14 Feb 2006 21:18:37 +0000 (21:18 +0000)]
Reviewed by Maciej.
Change formatting in this file to match the style guidelines. No spaces after
opening parentheses or before closing parentheses.
* dom/DocumentImpl.cpp:
(WebCore::DocumentImpl::createDocumentFragment):
(WebCore::DocumentImpl::recalcStyle):
(WebCore::DocumentImpl::attach):
(WebCore::DocumentImpl::detach):
(WebCore::DocumentImpl::open):
(WebCore::DocumentImpl::write):
(WebCore::DocumentImpl::writeln):
(WebCore::DocumentImpl::setUserStyleSheet):
(WebCore::DocumentImpl::determineParseMode):
(WebCore::DocumentImpl::processHttpEquiv):
(WebCore::DocumentImpl::childAllowed):
(WebCore::DocumentImpl::childTypeAllowed):
(WebCore::DocumentImpl::recalcStyleSelector):
(WebCore::DocumentImpl::dispatchImageLoadEventsNow):
(WebCore::DocumentImpl::domain):
(WebCore::DocumentImpl::setDomain):
(WebCore::DocumentImpl::parseQualifiedName):
(WebCore::DocumentImpl::addMarker):
(WebCore::DocumentImpl::removeMarkers):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 14 Feb 2006 19:13:51 +0000 (19:13 +0000)]
Reviewed by Tim Hatcher.
Some cleanup from the previous checkin, inspired by Darin's comments
* bridge/mac/MacFrame.h:
* bridge/mac/MacFrame.mm:
moved highlightAllMatchesForString out of here
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge highlightAllMatchesForString:caseSensitive:]):
now converts NSString to QString here, rather than in Frame/MacFrame
* dom/DocumentMarker.h: Added.
(WebCore::DocumentMarker::):
(WebCore::DocumentMarker::operator == ):
(WebCore::DocumentMarker::operator != ):
moved this struct to its own header file
* dom/DocumentImpl.h:
moved DocumentMarker out; now includes DocumentMarker.h
* page/Frame.h:
* page/Frame.cpp:
(WebCore::Frame::highlightAllMatchesForString):
moved here from MacFrame.[h,mm]. I thought this used other code from
MacFrame.mm but it doesn't.
* rendering/InlineTextBox.h:
removed unnecesssary variable names; use DocumentMarker::MarkerType in signature
of paintAllMarkersOfType
* rendering/InlineTextBox.cpp:
(khtml::InlineTextBox::paintTextMatchMarker):
better name for a variable, fixed bad indent
(khtml::InlineTextBox::paintAllMarkersOfType):
rewrote loop to bail out early if past end, for clarity;
use DocumentMarker::MarkerType in signature
* WebCore.xcodeproj/project.pbxproj:
updated for new file
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 14 Feb 2006 18:01:29 +0000 (18:01 +0000)]
More build fixes for case-sensitive drives. The #include "String.h" does not fail on normal HFS+ drives.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 14 Feb 2006 17:55:31 +0000 (17:55 +0000)]
Build fix for case-sensitive drives.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 14 Feb 2006 16:57:47 +0000 (16:57 +0000)]
Reviewed by Tim Omernick.
Support for highlighting multiple text matches.
* WebView/WebHTMLViewPrivate.h:
* WebView/WebHTMLView.m:
(-[WebHTMLView highlightAllMatchesForString:caseSensitive:]):
new method, calls through to bridge
(-[WebHTMLView clearHighlightedMatches]):
ditto
* WebView/WebViewPrivate.h:
* WebView/WebView.m:
(-[WebView highlightAllMatchesForString:caseSensitive:]):
new method, calls through to documentView. For now this is hardwired to only work
with WebHTMLViews.
(-[WebView clearHighlightedMatches]):
ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 14 Feb 2006 16:57:34 +0000 (16:57 +0000)]
Reviewed by Tim Omernick.
Support for highlighting multiple text matches.
* dom/DocumentImpl.h:
(WebCore::DocumentMarker::):
Added new marker type TextMatch
* bridge/mac/WebCoreFrameBridge.h:
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge highlightAllMatchesForString:caseSensitive:]):
new method, calls through to MacFrame implementation
(-[WebCoreFrameBridge clearHighlightedMatches]):
new method, removes all markers of type TextMatch
* bridge/mac/MacFrame.h:
* bridge/mac/MacFrame.mm:
(WebCore::MacFrame::highlightAllMatchesForString):
new method, adds a document marker for each range that matches the given string
* rendering/InlineTextBox.h:
* rendering/InlineTextBox.cpp:
(khtml::InlineTextBox::paint):
Moved DocumentMarker loop into separate method paintAllMarkersOfType. We now call
that method twice, once for spelling markers (after drawing text) and once for
text match markers (before drawing text)
(khtml::InlineTextBox::paintTextMatchMarker):
new method, paints a color behind a text match marker
(khtml::InlineTextBox::paintSpellingMarker):
renamed from paintMarker
(khtml::InlineTextBox::paintAllMarkersOfType):
new method, loops through all DocumentMarkers of a particular type and calls the
appropriate painting method for each one
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 14 Feb 2006 04:19:40 +0000 (04:19 +0000)]
WebCore:
Reviewed by Maciej.
- move pointer from frame to page here from WebKit
* WebCore.xcodeproj/project.pbxproj: Added PageMac.h.
* bridge/mac/PageMac.h: Added.
* bridge/mac/MacFrame.h: Added a page parameter to the constructor.
* bridge/mac/MacFrame.mm:
(WebCore::MacFrame::MacFrame): Pass the page and renderer to the Frame constructor.
Moved the call to Cache::init up into Frame, and got rid of the call to Frame::init
since that's now handled by the constructor. Also put the code to create the
browser extension object here.
(WebCore::MacFrame::submitForm): Update for new method name.
(WebCore::MacFrame::createFrame): Ditto.
(WebCore::MacFrame::sendContextMenuEvent): Update since m_doc is a RefPtr.
* bridge/mac/WebCoreFrameBridge.h: Changed parameters on init methods. Renamed
the part method to impl. Added a page method.
* bridge/mac/WebCoreFrameBridge.mm:
(frameHasSelection): Change use of part method to impl.
(-[WebCoreFrameBridge appendChild:]): Use m_frame directly instead of calling part method.
(-[WebCoreFrameBridge removeChild:]): Ditto.
(-[WebCoreFrameBridge initMainFrameWithPage:]): Added. Now does the first-time initialization
only here and create a frame for a main frame.
(-[WebCoreFrameBridge initSubframeWithRenderer:]): Added. Doesn't do the first-time initialization
and creates a frame for a subframe.
(-[WebCoreFrameBridge page]): Added.
(-[WebCoreFrameBridge setOpener:]): Change to use impl method instead of part.
(-[WebCoreFrameBridge executionContextForView:]): Ditto.
(-[WebCoreFrameBridge impl]): Added.
* bridge/mac/WebCorePageBridge.h: Removed init method and added setMainFrame: method and impl method.
* bridge/mac/WebCorePageBridge.mm:
(-[WebCorePageBridge init]): Changed to create a PageMac.
(-[WebCorePageBridge setMainFrame:]): Added.
(-[WebCorePageBridge impl]): Added.
* bridge/mac/BrowserExtensionMac.mm:
(WebCore::BrowserExtensionMac::createNewWindow):
* kwq/KWQAccObject.mm:
(-[KWQAccObject rendererForView:]):
* kwq/KWQComboBox.mm:
(-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]):
* kwq/KWQFileButton.mm:
(KWQFileButton::focusPolicy):
* kwq/KWQSlider.mm:
(QSlider::focusPolicy):
* kwq/KWQTextArea.mm:
(-[KWQTextAreaTextView _isResizableByUser]):
(-[KWQTextAreaTextView _trackResizeFromMouseDown:]):
Change methods to get from bridge back to objects to be named "impl".
The old one was named "part".
* page/Frame.h: Added Page and RenderPart parameter to constructor.
Added a page function. Removed the createBrowserExtension function.
* page/Frame.cpp:
(WebCore::parentFromOwnerRenderer): Added. Helper for constructor.
(WebCore::Frame::Frame): Moved all the code from init into here. Also change
to set the parent right from the start.
(WebCore::Frame::stopLoading): Change since m_doc is now a RefPtr.
(WebCore::Frame::clear): Ditto.
(WebCore::Frame::document): Ditto.
(WebCore::Frame::setDocument): Ditto.
(WebCore::Frame::begin): Ditto.
(WebCore::Frame::gotoAnchor): Ditto.
(WebCore::Frame::typingStyle): Change since m_typingStyle is now a RefPtr.
(WebCore::Frame::setTypingStyle): Ditto.
(WebCore::Frame::clearTypingStyle): Ditto.
(WebCore::Frame::isFrameSet): Change since m_doc is now a RefPtr.
(WebCore::Frame::page): Added.
* page/FramePrivate.h: Changed initialization to use member-initialization
syntax. Removed unused m_frames. Changed m_doc and m_typingStyle to use
RefPtr. Added an m_frame.
* page/Page.h: Made destructor virtual so we could have a Mac derived class.
Added a setMainFrame function and removed the mainFrame parameter from the constructor.
* page/Page.cpp:
(WebCore::Page::Page): Removed the mainFrame parameter.
(WebCore::Page::setMainFrame): Added.
WebKit:
Reviewed by Maciej.
- move pointer from frame to page over to WebCore
* WebCoreSupport/WebPageBridge.m: (-[WebPageBridge initWithMainFrameName:webView:frameView:]):
Call super init to create the page before creating the main frame and calling setMainFrame: with it.
* WebCoreSupport/WebFrameBridge.h: Remove page pointer, and change init function parameters.
* WebCoreSupport/WebFrameBridge.m:
(-[WebFrameBridge initMainFrameWithPage:frameName:view:]): New function that is used only for
the main frame. Passes the page over to the other side of the bridge.
(-[WebFrameBridge initSubframeWithRenderer:frameName:view:]): New function that is used only for
subframes. Passes the renderer over to the other side of the bridge.
(-[WebFrameBridge mainFrame]):
(-[WebFrameBridge webView]):
(-[WebFrameBridge createWindowWithURL:frameName:]):
(-[WebFrameBridge showWindow]):
(-[WebFrameBridge areToolbarsVisible]):
(-[WebFrameBridge setToolbarsVisible:]):
(-[WebFrameBridge isStatusbarVisible]):
(-[WebFrameBridge setStatusbarVisible:]):
(-[WebFrameBridge setWindowFrame:]):
(-[WebFrameBridge windowFrame]):
(-[WebFrameBridge setWindowContentRect:]):
(-[WebFrameBridge windowContentRect]):
(-[WebFrameBridge setWindowIsResizable:]):
(-[WebFrameBridge windowIsResizable]):
(-[WebFrameBridge firstResponder]):
(-[WebFrameBridge makeFirstResponder:]):
(-[WebFrameBridge closeWindowSoon]):
(-[WebFrameBridge runJavaScriptAlertPanelWithMessage:]):
(-[WebFrameBridge runJavaScriptConfirmPanelWithMessage:]):
(-[WebFrameBridge canRunBeforeUnloadConfirmPanel]):
(-[WebFrameBridge runBeforeUnloadConfirmPanelWithMessage:]):
(-[WebFrameBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]):
(-[WebFrameBridge addMessageToConsole:]):
(-[WebFrameBridge runOpenPanelForFileButtonWithResultListener:]):
(-[WebFrameBridge setStatusText:]):
(-[WebFrameBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
(-[WebFrameBridge focusWindow]):
(-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]):
(-[WebFrameBridge userAgentForURL:]):
(-[WebFrameBridge _nextKeyViewOutsideWebFrameViewsWithValidityCheck:]):
(-[WebFrameBridge previousKeyViewOutsideWebFrameViews]):
(-[WebFrameBridge defersLoading]):
(-[WebFrameBridge setDefersLoading:]):
(-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]):
(-[WebFrameBridge _preferences]):
(-[WebFrameBridge selectWordBeforeMenuEvent]):
(-[WebFrameBridge historyLength]):
(-[WebFrameBridge canGoBackOrForward:]):
(-[WebFrameBridge goBackOrForward:]):
(-[WebFrameBridge print]):
(-[WebFrameBridge pollForAppletInView:]):
(-[WebFrameBridge respondToChangedContents]):
(-[WebFrameBridge respondToChangedSelection]):
(-[WebFrameBridge undoManager]):
(-[WebFrameBridge issueCutCommand]):
(-[WebFrameBridge issueCopyCommand]):
(-[WebFrameBridge issuePasteCommand]):
(-[WebFrameBridge issuePasteAndMatchStyleCommand]):
(-[WebFrameBridge canPaste]):
(-[WebFrameBridge overrideMediaType]):
(-[WebFrameBridge isEditable]):
(-[WebFrameBridge shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
(-[WebFrameBridge shouldBeginEditing:]):
(-[WebFrameBridge shouldEndEditing:]):
(-[WebFrameBridge windowObjectCleared]):
(-[WebFrameBridge spellCheckerDocumentTag]):
(-[WebFrameBridge isContinuousSpellCheckingEnabled]):
(-[WebFrameBridge didFirstLayout]):
(-[WebFrameBridge dashboardRegionsChanged:]):
(-[WebFrameBridge createModalDialogWithURL:]):
(-[WebFrameBridge canRunModal]):
(-[WebFrameBridge runModal]):
Change all calls to [_page webView] to use [self webView] instead.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Tue, 14 Feb 2006 04:11:21 +0000 (04:11 +0000)]
Updated test case after improving table deletion.
* selection/move-between-blocks-no-001-expected.txt: Updated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Tue, 14 Feb 2006 03:29:43 +0000 (03:29 +0000)]
Reviewed by Justin.
- merge VisiblePosition:isCandidate() into Position::inRenderedContent()
These functions were answering the same question in different ways! We
only need one implementation.
* khtml/editing/visible_position.cpp:
(khtml::VisiblePosition::init):
(khtml::VisiblePosition::previousVisiblePosition):
(khtml::VisiblePosition::nextVisiblePosition):
(khtml::VisiblePosition::deepEquivalent):
* khtml/editing/visible_position.h:
* dom/dom_position.cpp:
(DOM::hasRenderedChildrenWithHeight):
(DOM::Position::inRenderedContent):
- improved table deletion.
Fixes: delete back by word from just after table did not delete the table
delete forward by char or word did not delete the table
deleting back to a table and again did not delete the table
* khtml/editing/htmlediting.cpp:
(WebCore::isFirstVisiblePositionAfterTableElement):
simpler implementation
(WebCore::positionBeforePrecedingTableElement):
simpler implementation
(WebCore::isFirstVisiblePositionBeforeTableElement):
new
(WebCore::positionAfterFollowingTableElement):
new
* khtml/editing/htmlediting.h:
* khtml/editing/SelectionController.cpp:
(WebCore::SelectionController::modifyExtendingRightForward):
select following table if granularity is char or word
(WebCore::SelectionController::modifyExtendingLeftBackward):
select preceding table if granularity is char or word
* khtml/editing/typing_command.cpp:
(khtml::TypingCommand::deleteKeyPressed):
simpler implementation, and let other deleteKeyPressed do boundary checking
(khtml::TypingCommand::forwardDeleteKeyPressed):
simpler implementation, and let other forwardDeleteKeyPressed do boundary checking
(khtml::TypingCommand::insertText):
standard formatting
(khtml::TypingCommand::insertLineBreak):
standard formatting
(khtml::TypingCommand::insertParagraphSeparatorInQuotedContent):
standard formatting
(khtml::TypingCommand::insertParagraphSeparator):
standard formatting
(khtml::TypingCommand::insertTextRunWithoutNewlines):
standard formatting
(khtml::TypingCommand::deleteKeyPressed):
use SelectionController to extend selection, to get all the selection
logic incl. table selection and editable/noneditable boundary checks
(khtml::TypingCommand::forwardDeleteKeyPressed):
use SelectionController to extend selection, to get all the selection
logic incl. table selection and editable/noneditable boundary checks
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 14 Feb 2006 01:01:11 +0000 (01:01 +0000)]
Fix for bug 5605, XSLT fails to import to arbitrary depth. Make sure m_embedded is initialized to false
in the XSLTStyleSheetImpl constructor.
Reviewed by timo
Adding xslt-import-depth.xml to fast/xsl
* khtml/xsl/xsl_stylesheetimpl.cpp:
(DOM::XSLStyleSheetImpl::XSLStyleSheetImpl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 14 Feb 2006 01:00:39 +0000 (01:00 +0000)]
Add layout test for import depth.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Mon, 13 Feb 2006 23:13:47 +0000 (23:13 +0000)]
Fix Win32 WebCore bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Mon, 13 Feb 2006 23:02:40 +0000 (23:02 +0000)]
2006-02-12 Alexander Kellett <lypanov@kde.org>
Reviewed by eseidel.
Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7207.
No testcases as this is not possible to reproduce via anything
other than manual interaction.
* kcanvas/device/quartz/KCanvasFilterQuartz.mm:
(WebCore::KCanvasFilterQuartz::getCIFilterStack):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Mon, 13 Feb 2006 22:49:32 +0000 (22:49 +0000)]
Fix Win32 JavaScriptCore bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 13 Feb 2006 22:02:26 +0000 (22:02 +0000)]
Reviewed by Hyatt.
- moved QWidget to platform directory, renamed to Widget,
split into cross-platform and platform-specific parts,
removed some of the unused bits
* ForwardingHeaders/qwidget.h: Removed.
* kwq/KWQWidget.h: Removed.
* kwq/KWQWidget.mm: Removed.
* WebCore.vcproj/WebCore/WebCore.vcproj: Update for file removals and adds.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* platform/Widget.h: Moved code here, fixed it up.
* platform/Widget.cpp: Ditto.
* platform/mac/WidgetMac.mm: Added.
* bindings/objc/DOMHTML.mm:
(viewForElement):
* bridge/mac/KWQKHTMLView.cpp:
(WebCore::FrameView::topLevelWidget):
* bridge/mac/MacFrame.h:
* bridge/mac/MacFrame.mm:
(WebCore::MacFrame::createPlugin):
(WebCore::MacFrame::nextKeyViewInFrame):
(WebCore::MacFrame::nextKeyViewForWidget):
(WebCore::MacFrame::currentEventIsMouseDownInWidget):
(WebCore::MacFrame::bridgeForWidget):
(WebCore::MacFrame::passMouseDownEventToWidget):
(WebCore::MacFrame::passSubframeEventToSubframe):
(WebCore::MacFrame::passWheelEventToChildWidget):
(WebCore::MacFrame::getAppletInstanceForWidget):
(WebCore::MacFrame::getEmbedInstanceForWidget):
(WebCore::MacFrame::getObjectInstanceForWidget):
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge createFrameViewWithNSView:marginWidth:marginHeight:]):
(-[WebCoreFrameBridge copyRenderNode:copier:]):
(-[WebCoreFrameBridge elementForView:]):
(-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:]):
* dom/DocumentImpl.cpp:
(WebCore::widgetForNode):
(WebCore::DocumentImpl::setFocusNode):
* khtml/ecma/kjs_window.cpp:
(KJS::Screen::getValueProperty):
(KJS::WindowFunc::callAsFunction):
* khtml/html/HTMLGenericFormElementImpl.cpp:
(WebCore::HTMLGenericFormElementImpl::isKeyboardFocusable):
(WebCore::HTMLGenericFormElementImpl::isMouseFocusable):
* khtml/html/html_objectimpl.cpp:
(WebCore::HTMLEmbedElementImpl::getEmbedInstance):
(WebCore::HTMLObjectElementImpl::getObjectInstance):
* kwq/KWQAccObject.mm:
(-[KWQAccObject addChildrenToArray:]):
(-[KWQAccObject attachmentView]):
(-[KWQAccObject doAXTextMarkerForPosition:]):
* kwq/KWQComboBox.h:
* kwq/KWQComboBox.mm:
(QComboBox::frameGeometry):
(QComboBox::setFrameGeometry):
(QComboBox::setFont):
(QComboBox::focusPolicy):
(-[KWQPopUpButtonCell widget]):
(-[KWQPopUpButton widget]):
(-[KWQPopUpButton mouseDown:]):
(-[KWQPopUpButton becomeFirstResponder]):
(-[KWQPopUpButton resignFirstResponder]):
(-[KWQPopUpButton nextKeyView]):
(-[KWQPopUpButton previousKeyView]):
* kwq/KWQFileButton.h:
* kwq/KWQFileButton.mm:
(KWQFileButton::focusPolicy):
* kwq/KWQFrame.h:
* kwq/KWQKCursor.h:
* kwq/KWQKJavaAppletWidget.h:
* kwq/KWQKJavaAppletWidget.mm:
(KJavaAppletWidget::KJavaAppletWidget):
* kwq/KWQLineEdit.h:
* kwq/KWQLineEdit.mm:
(QLineEdit::setFont):
(QLineEdit::setPalette):
(QLineEdit::focusPolicy):
* kwq/KWQListBox.h:
* kwq/KWQListBox.mm:
(QListBox::QListBox):
(QListBox::focusPolicy):
(QListBox::setFont):
(-[KWQListBoxScrollView widget]):
(-[KWQListBoxScrollView becomeFirstResponder]):
(-[KWQTableView mouseDown:]):
(-[KWQTableView widget]):
* kwq/KWQPainter.h:
* kwq/KWQRenderTreeDebug.cpp:
(write):
* kwq/KWQScrollBar.h:
* kwq/KWQScrollBar.mm:
(-[KWQScrollBar widget]):
(-[KWQScrollBar mouseDown:]):
(QScrollBar::QScrollBar):
(QScrollBar::~QScrollBar):
* kwq/KWQScrollView.h:
(QScrollView::QScrollView):
* kwq/KWQScrollView.mm:
(QScrollView::viewport):
(QScrollView::childX):
(QScrollView::childY):
(QScrollView::addChild):
(QScrollView::removeChild):
* kwq/KWQSlider.h:
* kwq/KWQSlider.mm:
(-[KWQSlider mouseDown:]):
(-[KWQSlider widget]):
(QSlider::setFont):
(QSlider::focusPolicy):
* kwq/KWQTextArea.mm:
(-[KWQTextAreaTextView widget]):
* kwq/KWQTextEdit.h:
* kwq/KWQTextEdit.mm:
(QTextEdit::QTextEdit):
(QTextEdit::setFont):
(QTextEdit::focusPolicy):
(QTextEdit::setPalette):
* kwq/KWQTextField.mm:
(-[KWQTextFieldController widget]):
(-[KWQTextFieldController textView:shouldHandleEvent:]):
(-[KWQTextFieldController textView:didHandleEvent:]):
(-[KWQTextField widget]):
(-[KWQTextField nextKeyView]):
(-[KWQTextField previousKeyView]):
(-[KWQSecureTextField widget]):
(-[KWQSecureTextField nextKeyView]):
(-[KWQSecureTextField previousKeyView]):
(-[KWQSearchField widget]):
(-[KWQSearchField nextKeyView]):
(-[KWQSearchField previousKeyView]):
* kwq/KWQView.h:
* kwq/KWQWindowWidget.h:
* kwq/KWQWindowWidget.mm:
(KWQWindowWidget::topLevelWidget):
* page/Frame.cpp:
(WebCore::isFrameElement):
(WebCore::Frame::frameForWidget):
(WebCore::Frame::nodeForWidget):
(WebCore::Frame::setDocumentFocus):
(WebCore::Frame::clearDocumentFocus):
(WebCore::Frame::passWidgetMouseDownEventToWidget):
* page/Frame.h:
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::init):
* page/FrameView.h:
* page/Plugin.h:
(WebCore::Plugin::Plugin):
(WebCore::Plugin::view):
* platform/Screen.h:
* platform/mac/ScreenMac.mm:
(WebCore::screen):
(WebCore::screenDepth):
(WebCore::screenRect):
(WebCore::usableScreenRect):
* rendering/render_applet.cpp:
(WebCore::RenderApplet::layout):
* rendering/render_form.cpp:
(WebCore::ComboBoxWidget::ComboBoxWidget):
(WebCore::RenderSelect::createListBox):
* rendering/render_form.h:
* rendering/render_frames.cpp:
(WebCore::RenderPart::setWidget):
* rendering/render_frames.h:
* rendering/render_object.cpp:
* rendering/render_replaced.cpp:
(WebCore::RenderWidget::resizeWidget):
(WebCore::RenderWidget::setQWidget):
* rendering/render_replaced.h:
(WebCore::RenderWidget::widget):
Change name from QWidget to Widget, a few other changes to get compiling.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 13 Feb 2006 21:57:47 +0000 (21:57 +0000)]
Versioning to 521.7
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 13 Feb 2006 19:34:53 +0000 (19:34 +0000)]
Reviewed by Darin.
Replaced the old NS_DURING exception blocking with @try/@catch.
* JavaScriptCorePrefix.h: undef try and catch to workaround a C++ conflict
* bindings/objc/objc_instance.mm:
(ObjcInstance::invokeMethod):
(ObjcInstance::invokeDefaultMethod):
(ObjcInstance::setValueOfUndefinedField):
(ObjcInstance::getValueOfUndefinedField):
* bindings/objc/objc_runtime.mm:
(ObjcField::valueFromInstance):
(ObjcField::setValueToInstance):
(ObjcArray::setValueAt):
(ObjcArray::valueAt):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 13 Feb 2006 09:34:10 +0000 (09:34 +0000)]
- fix a couple problems building on Windows, based on requests
from Krzysztof Kowalczyk <kkowalczyk@gmail.com>
* kjs/JSImmediate.h: Change code using non-standard u_int32/64_t types
to the standard uint32/64_t. Also removed curious "isIEEE()" function
that checked the sizes of some types (and type sizes alone don't tell you if
the floating point conforms to the IEEE-standard). Added missing include
of <stdint.h>.
* kjs/property_slot.h: Added missing include of <assert.h>.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 13 Feb 2006 05:31:22 +0000 (05:31 +0000)]
Reviewed and tweaked by Darin.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7206
REGRESSION: PDF "images" no longer render within HTML pages
* fast/replaced/page-as-image.html: Added.
* fast/replaced/page-as-image-expected.txt: Added.
* fast/replaced/page-as-image-expected.png: Added.
* fast/replaced/page-as-image-expected.checksum: Added.
* fast/replaced/resources/image.pdf: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 13 Feb 2006 05:27:27 +0000 (05:27 +0000)]
Reviewed by Hyatt.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7206
REGRESSION: PDF "images" no longer render within HTML pages
Test: fast/replaced/page-as-image.html
* platform/Image.cpp: (WebCore::Image::setNativeData):
Return false in the case where the PDF document has not been created yet.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 13 Feb 2006 04:11:27 +0000 (04:11 +0000)]
Rubber stamped by Geoff.
- comment out remote <base> URLs, these were making the tests hang for a long time
This also made the affected tests start passing.
* dom/xhtml/level2/html/HTMLBodyElement01-expected.checksum: Removed.
* dom/xhtml/level2/html/HTMLBodyElement01-expected.png: Removed.
* dom/xhtml/level2/html/HTMLBodyElement01-expected.txt:
* dom/xhtml/level2/html/HTMLBodyElement01.xhtml:
* dom/xhtml/level2/html/HTMLBodyElement02-expected.checksum: Removed.
* dom/xhtml/level2/html/HTMLBodyElement02-expected.png: Removed.
* dom/xhtml/level2/html/HTMLBodyElement02-expected.txt:
* dom/xhtml/level2/html/HTMLBodyElement02.xhtml:
* dom/xhtml/level2/html/HTMLBodyElement03-expected.checksum: Removed.
* dom/xhtml/level2/html/HTMLBodyElement03-expected.png: Removed.
* dom/xhtml/level2/html/HTMLBodyElement03-expected.txt:
* dom/xhtml/level2/html/HTMLBodyElement03.xhtml:
* dom/xhtml/level2/html/HTMLBodyElement04-expected.checksum: Removed.
* dom/xhtml/level2/html/HTMLBodyElement04-expected.png: Removed.
* dom/xhtml/level2/html/HTMLBodyElement04-expected.txt:
* dom/xhtml/level2/html/HTMLBodyElement04.xhtml:
* dom/xhtml/level2/html/HTMLBodyElement05-expected.checksum: Removed.
* dom/xhtml/level2/html/HTMLBodyElement05-expected.png: Removed.
* dom/xhtml/level2/html/HTMLBodyElement05-expected.txt:
* dom/xhtml/level2/html/HTMLBodyElement05.xhtml:
* dom/xhtml/level2/html/HTMLBodyElement06-expected.checksum: Removed.
* dom/xhtml/level2/html/HTMLBodyElement06-expected.png: Removed.
* dom/xhtml/level2/html/HTMLBodyElement06-expected.txt:
* dom/xhtml/level2/html/HTMLBodyElement06.xhtml:
* dom/xhtml/level2/html/body01-expected.checksum: Removed.
* dom/xhtml/level2/html/body01-expected.png: Removed.
* dom/xhtml/level2/html/body01-expected.txt:
* dom/xhtml/level2/html/body01.xhtml:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Mon, 13 Feb 2006 03:06:19 +0000 (03:06 +0000)]
Reviewed by darin.
Cleaned up testkjs, added new "run" functionality to allow scripting
tests from within JS. ("run" is a part of my new super-accurate
JS iBench.)
No regressions in run-javascriptcore-tests.
* kjs/testkjs.cpp:
(GlobalImp::className):
(TestFunctionImp::):
(TestFunctionImp::callAsFunction):
(main):
(run):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 13 Feb 2006 02:43:45 +0000 (02:43 +0000)]
Reviewed by Maciej.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=7209
reimplement Timer so it uses only a single timer from the underlying OS
* WebCore.vcproj/WebCore/WebCore.vcproj: Removed old files, added new.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* platform/Timer.h: Updated for new timer implementation.
* platform/Timer.cpp: Added. Platform-independent implementation of timers
in terms of a single shared timer. Uses a heap to implement a priority queue
so we know which timer to fire first.
* platform/SharedTimer.h: Added.
* platform/mac/SharedTimerMac.cpp: Added.
* platform/win/SharedTimerWin.cpp: Added.
* platform/mac/TimerMac.cpp: Removed.
* platform/win/TimerWin.cpp: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Mon, 13 Feb 2006 00:51:35 +0000 (00:51 +0000)]
2006-02-12 Eric Seidel <eseidel@apple.com>
Reviewed by mjs.
* loader/CachedXSLStyleSheet.cpp: removed duplicate copy of xbl code.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Sun, 12 Feb 2006 22:07:15 +0000 (22:07 +0000)]
2006-02-12 Joost de Valk <jdevalk@opendarwin.org>
Reviewed by eseidel.
Added a little piece of text to the page about reductions, pointing to the bugzilla page.
Changed "Sign up for a" into "Create a" bugzilla account.
* quality/reduction.html:
* quality/reporting.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sun, 12 Feb 2006 16:31:24 +0000 (16:31 +0000)]
Unreviewed build fix.
- fix build
* bindings/scripts/CodeGeneratorJS.pm: Update for splitting of the
dom_textimpl.h header.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sun, 12 Feb 2006 10:11:54 +0000 (10:11 +0000)]
Reviewed by Hyatt.
- factor WebArchive creation code out of other classes into new WebArchiver
http://bugzilla.opendarwin.org/show_bug.cgi?id=7208
* DOM/WebDOMOperations.m:
(-[DOMNode webArchive]):
(-[DOMRange webArchive]):
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebArchiver.h: Added.
* WebView/WebArchiver.m: Added.
(+[WebArchiver _subframeArchivesForFrame:]):
(+[WebArchiver archiveFrame:]):
(+[WebArchiver _archiveCurrentStateForFrame:]):
(+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
(+[WebArchiver archiveRange:]):
(+[WebArchiver archiveNode:]):
(+[WebArchiver archiveSelectionInFrame:]):
* WebView/WebDataSource.m:
(-[WebDataSource webArchive]):
* WebView/WebDataSourcePrivate.h:
* WebView/WebHTMLView.m:
(-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
(-[WebHTMLView _writeSelectionToPasteboard:]):
* WebView/WebHTMLViewPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sun, 12 Feb 2006 10:07:23 +0000 (10:07 +0000)]
Correct tyop in ChangeLog
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sun, 12 Feb 2006 10:03:59 +0000 (10:03 +0000)]
Reviewed by Darin.
- rename FrameTreeNode to FameTree and treeNode() to tree()
http://bugzilla.opendarwin.org/show_bug.cgi?id=7210
This may be slightly less accurate, but reads better.
* WebCore.xcodeproj/project.pbxproj:
* bridge/mac/BrowserExtensionMac.mm:
(WebCore::BrowserExtensionMac::createNewWindow):
* bridge/mac/MacFrame.mm:
(WebCore::MacFrame::submitForm):
(WebCore::MacFrame::nextKeyViewInFrameHierarchy):
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge firstChild]):
(-[WebCoreFrameBridge lastChild]):
(-[WebCoreFrameBridge childCount]):
(-[WebCoreFrameBridge previousSibling]):
(-[WebCoreFrameBridge nextSibling]):
(-[WebCoreFrameBridge appendChild:]):
(-[WebCoreFrameBridge removeChild:]):
(-[WebCoreFrameBridge setParent:]):
(-[WebCoreFrameBridge parent]):
(-[WebCoreFrameBridge setName:]):
(-[WebCoreFrameBridge name]):
* dom/DocumentImpl.cpp:
(WebCore::DocumentImpl::parentDocument):
* khtml/ecma/kjs_window.cpp:
(KJS::Window::getValueProperty):
(KJS::Window::put):
(KJS::Window::isSafeScript):
(KJS::WindowFunc::callAsFunction):
* khtml/html/html_baseimpl.cpp:
(WebCore::HTMLFrameElementImpl::isURLAllowed):
* khtml/html/html_headimpl.cpp:
(WebCore::HTMLLinkElementImpl::process):
* page/Frame.cpp:
(WebCore::Frame::stopLoading):
(WebCore::Frame::clear):
(WebCore::Frame::stopAnimations):
(WebCore::Frame::checkCompleted):
(WebCore::Frame::checkEmitLoadEvent):
(WebCore::Frame::slotChildCompleted):
(WebCore::Frame::findFrame):
(WebCore::Frame::setZoomFactor):
(WebCore::Frame::frameNames):
(WebCore::Frame::frames):
(WebCore::Frame::childFrameNamed):
(WebCore::Frame::incrementFrameCount):
(WebCore::Frame::decrementFrameCount):
(WebCore::Frame::topLevelFrameCount):
(WebCore::Frame::selectFrameElementInParentIfFullySelected):
(WebCore::Frame::userGestureHint):
(WebCore::Frame::canCachePage):
(WebCore::Frame::updatePolicyBaseURL):
(WebCore::Frame::setPolicyBaseURL):
(WebCore::Frame::tree):
(WebCore::Frame::frameDetached):
(WebCore::Frame::updateBaseURLForEmptyDocument):
* page/Frame.h:
* page/FramePrivate.h:
* page/FrameTree.cpp: Added.
(WebCore::FrameTree::~FrameTree):
(WebCore::FrameTree::setName):
(WebCore::FrameTree::appendChild):
(WebCore::FrameTree::removeChild):
* page/FrameTree.h: Added.
(WebCore::FrameTree::FrameTree):
* page/FrameTreeNode.cpp: Removed.
* page/FrameTreeNode.h: Removed.
* rendering/render_frames.cpp:
(WebCore::isURLAllowed):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sun, 12 Feb 2006 08:50:21 +0000 (08:50 +0000)]
Fix bug 7182, animated GIFs don't clear previous animation frames.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Sun, 12 Feb 2006 03:10:30 +0000 (03:10 +0000)]
- Fixed bad free resulting from 0 legnth StringImpl
No test case because currently this bug only has the effect of a bad
free on exit().
* platform/StringImpl.cpp:
(WebCore::StringImpl::StringImpl): Factored varied approaches to
initialization into two common routines: initWithChar and
initWithQChar. The common rule is: if we're not going to allocate
a string, make sure to set s to 0 so fastFree doesn't try to free it
later. For speed, initWithQChar uses memcpy() -- that's the only
difference between the two.
(WebCore::StringImpl::initWithChar):
(WebCore::StringImpl::initWithQChar):
* platform/StringImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sun, 12 Feb 2006 01:18:46 +0000 (01:18 +0000)]
Rubber stamped by Eric.
- split dom_textimpl.{h,cpp} by class.
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOM.mm:
* bridge/mac/MacFrame.mm:
* dom/CDATASectionImpl.cpp: Added.
* dom/CDATASectionImpl.h: Added.
* dom/CharacterDataImpl.cpp: Added.
* dom/CharacterDataImpl.h: Added.
* dom/CommentImpl.cpp: Added.
* dom/CommentImpl.h: Added.
* dom/DocumentImpl.cpp:
* dom/EditingTextImpl.cpp: Added.
* dom/EditingTextImpl.h: Added.
* dom/NodeImpl.cpp:
* dom/TextImpl.cpp: Added.
* dom/TextImpl.h: Added.
* dom/dom2_rangeimpl.cpp:
* dom/dom_elementimpl.cpp:
* dom/dom_textimpl.cpp: Removed.
* dom/dom_textimpl.h: Removed.
* dom/xml_tokenizer.cpp:
* khtml/ecma/kjs_dom.cpp:
* khtml/ecma/kjs_html.cpp:
* khtml/editing/SelectionController.cpp:
* khtml/editing/apply_style_command.cpp:
* khtml/editing/break_blockquote_command.cpp:
* khtml/editing/composite_edit_command.cpp:
* khtml/editing/delete_from_text_node_command.cpp:
* khtml/editing/delete_selection_command.cpp:
* khtml/editing/htmlediting.cpp:
* khtml/editing/insert_into_text_node_command.cpp:
* khtml/editing/insert_line_break_command.cpp:
* khtml/editing/insert_paragraph_separator_command.cpp:
* khtml/editing/insert_text_command.cpp:
* khtml/editing/join_text_nodes_command.cpp:
* khtml/editing/markup.cpp:
* khtml/editing/rebalance_whitespace_command.cpp:
* khtml/editing/replace_selection_command.cpp:
* khtml/editing/split_text_node_command.cpp:
* khtml/editing/split_text_node_containing_element.cpp:
* khtml/editing/visible_position.cpp:
* khtml/html/HTMLElementImpl.cpp:
* khtml/html/HTMLKeygenElementImpl.cpp:
* khtml/html/HTMLOptionElementImpl.cpp:
* khtml/html/HTMLTextAreaElementImpl.cpp:
* khtml/html/html_headimpl.cpp:
* khtml/html/html_objectimpl.cpp:
* khtml/html/htmlparser.cpp:
* khtml/xsl/xslt_processorimpl.cpp:
* page/Frame.cpp:
* rendering/RenderText.h:
* rendering/render_frames.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log