WebKit-https.git
15 years ago Reviewed by Adam.
thatcher [Fri, 27 Oct 2006 00:25:31 +0000 (00:25 +0000)]
    Reviewed by Adam.

        <rdar://problem/4796941> Table deletion outline is misplaced at nytimes.com

        The main table at nytimes.com has a fixed width of 874px, but the table ends
        up overflowing to 963px. We now use overflowWidth() and overflowHeight() to correct
        this. The other bug was a missing top and left of 0px on the container element,
        causing the deletion UI to sometimes be offset below the table.

        Now check for the element's renderer at the beginning of show() and
        return early if it is null.

        * editing/DeleteButtonController.cpp:
        (WebCore::DeleteButtonController::updateOutlineStyle):
        (WebCore::DeleteButtonController::show):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-10-26 Anders Carlsson <acarlsson@apple.com>
andersca [Thu, 26 Oct 2006 23:12:29 +0000 (23:12 +0000)]
2006-10-26  Anders Carlsson  <acarlsson@apple.com>

        Build fix.

        * html/CanvasRenderingContext2D.cpp:
        Include MathExtras.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
sullivan [Thu, 26 Oct 2006 22:57:03 +0000 (22:57 +0000)]
WebCore:

        Reviewed by Anders.

        Some changes to support new grammar checking code in WebKit.

        * WebCore.exp:
        added mangled symbol for Document->removeMarkers() so I can call it from WebKit

        * WebCore.xcodeproj/project.pbxproj:
        Made Document.h and DocumentMarker.h private so I can include them from WebKit.
        Made HTMLCollection.h private because Document.h uses it.

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        removed unmarkAllMisspellings(); WebKit now calls through to the Document directly

WebKit:

        Reviewed by Anders

        * WebView/WebFrame.mm:
        now includes <WebCore/Document.h> and <WebCore/DocumentMarker.h>
        (-[WebFrame _unmarkAllBadGrammar]):
        filled in guts
        (-[WebFrame _unmarkAllMisspellings]):
        rewrote to call Document directly, bypassing bridge

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * English.lproj/WebViewEditingContextMenu.nib/info.nib:
sullivan [Thu, 26 Oct 2006 22:30:39 +0000 (22:30 +0000)]
    * English.lproj/WebViewEditingContextMenu.nib/info.nib:
        * English.lproj/WebViewEditingContextMenu.nib/objects.nib:

        Changed "Spelling" to "Spelling and Grammar" in context menu for post-Tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
ggaren [Thu, 26 Oct 2006 22:27:49 +0000 (22:27 +0000)]
    Reviewed by Geoff.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=11419
        REGRESSION (r17299): Assertion failure in -[WebHTMLView(WebPrivate) _topHTMLView]
        ([view isKindOfClass:[WebHTMLView class]]) when running the layout tests

        * DumpRenderTree/EventSendingController.m:
        (-[EventSendingController mouseMoveToX:Y:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-10-26 Anders Carlsson <acarlsson@apple.com>
andersca [Thu, 26 Oct 2006 22:22:43 +0000 (22:22 +0000)]
2006-10-26  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Brady.

        Add reverseFind to String and use it instead of findRev.
        Use CString instead of DeprecatedCString in one place.

        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::formData):
        * ksvg2/svg/SVGURIReference.cpp:
        (WebCore::SVGURIReference::getTarget):
        * loader/Decoder.cpp:
        (WebCore::Decoder::checkForCSSCharset):
        * platform/PlatformString.h:
        (WebCore::String::reverseFind):
        * platform/StringImpl.cpp:
        (WebCore::StringImpl::reverseFind):
        * platform/StringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin
sullivan [Thu, 26 Oct 2006 21:27:17 +0000 (21:27 +0000)]
    Reviewed by Darin

        More plumbing for grammar checking. Still no grammars is checked.

        * dom/DocumentMarker.h:
        (WebCore::DocumentMarker::):
        added Grammar to enum of marker types; removed explicit enum values; removed unnecessary "enum"

        * platform/GraphicsContext.h:
        renamed method drawLineForMisspelling to drawLineForMisspellingOrBadGrammar;
        now takes a bool parameter for whether it represents bad grammar or a misspelling

        * platform/mac/GraphicsContextMac.mm:
        (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
        Renamed from drawLineForMisspelling; uses green dot instead of red dot for grammar case. Changed
        an existing "assert" to "ASSERT".

        * rendering/InlineTextBox.h:
        renamed function paintSpellingMarker to paintSpellingOrGrammarMarker;

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
        Renamed from paintSpellingMarker; now takes a bool parameter for whether it represents
        bad grammar or a misspelling
        (WebCore::InlineTextBox::paintAllMarkersOfType):
        now handles markers of type Grammar

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdded bug number to change log entry.
darin [Thu, 26 Oct 2006 21:19:31 +0000 (21:19 +0000)]
Added bug number to change log entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
darin [Thu, 26 Oct 2006 21:17:34 +0000 (21:17 +0000)]
    Reviewed by Adam.

        * editing/execCommand/remove-formatting-expected.txt: Roll back results.
        The ones just checked in showed the same kind of intermittent failure that
        copy-paste-bidi.html used to show -- now we consistently get these results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRe-versioning
thatcher [Thu, 26 Oct 2006 20:42:45 +0000 (20:42 +0000)]
Re-versioning

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoVersioning
thatcher [Thu, 26 Oct 2006 20:32:21 +0000 (20:32 +0000)]
Versioning

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mitz.
weinig [Thu, 26 Oct 2006 20:23:55 +0000 (20:23 +0000)]
    Reviewed by Mitz.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=11424
        Cleanup rendering code

        - Assorted code cleanup.

        * rendering/AutoTableLayout.cpp:
        * rendering/AutoTableLayout.h:
        (WebCore::AutoTableLayout::totalPercent):
        * rendering/CounterListItem.h:
        * rendering/CounterNode.cpp:
        * rendering/CounterNode.h:
        (WebCore::CounterNode::~CounterNode):
        (WebCore::CounterNode::isReset):
        * rendering/CounterResetNode.cpp:
        * rendering/CounterResetNode.h:
        * rendering/DataRef.h:
        (WebCore::DataRef::DataRef):
        * rendering/DeprecatedRenderSelect.h:
        * rendering/DeprecatedSlider.cpp:
        * rendering/DeprecatedSlider.h:
        * rendering/EllipsisBox.cpp:
        * rendering/EllipsisBox.h:
        (WebCore::EllipsisBox::EllipsisBox):
        * rendering/FixedTableLayout.cpp:
        * rendering/FixedTableLayout.h:
        * rendering/GapRects.h:
        * rendering/InlineBox.cpp:
        * rendering/InlineBox.h:
        (WebCore::InlineBox::InlineBox):
        (WebCore::InlineBox::setConstructed):
        (WebCore::InlineBox::clearTruncation):
        (WebCore::InlineBox::markDirty):
        * rendering/InlineFlowBox.cpp:
        * rendering/InlineFlowBox.h:
        (WebCore::InlineFlowBox::InlineFlowBox):
        (WebCore::InlineFlowBox::setConstructed):
        (WebCore::InlineFlowBox::setEdges):
        (WebCore::InlineFlowBox::setVerticalOverflowPositions):
        (WebCore::InlineFlowBox::setVerticalSelectionPositions):
        * rendering/InlineRunBox.h:
        (WebCore::InlineRunBox::paintBackgroundAndBorder):
        (WebCore::InlineRunBox::paintDecorations):
        * rendering/InlineTextBox.cpp:
        * rendering/InlineTextBox.h:
        (WebCore::InlineTextBox::InlineTextBox):
        (WebCore::InlineTextBox::end):
        (WebCore::InlineTextBox::textObject):
        * rendering/Length.h:
        (WebCore::Length::Length):
        * rendering/ListMarkerBox.cpp:
        * rendering/ListMarkerBox.h:
        * rendering/RenderPartObject.h:
        * rendering/RootInlineBox.cpp:
        * rendering/RootInlineBox.h:
        * rendering/SVGInlineFlowBox.cpp:
        * rendering/SVGInlineFlowBox.h:
        (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
        * rendering/SVGRootInlineBox.cpp:
        * rendering/SVGRootInlineBox.h:
        (WebCore::SVGRootInlineBox::SVGRootInlineBox):
        * rendering/TableLayout.h:
        (WebCore::TableLayout::TableLayout):
        (WebCore::TableLayout::~TableLayout):
        * rendering/bidi.h:
        (WebCore::BidiStatus::BidiStatus):
        (WebCore::BidiRun::BidiRun):
        * rendering/break_lines.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Thu, 26 Oct 2006 19:44:24 +0000 (19:44 +0000)]
LayoutTests:

        Reviewed by john

        <http://bugs.webkit.org/show_bug.cgi?id=11329>
        Gmail Editor: Can't remove styling applied to selection after clicking "Remove Formatting" toolbar icon.

        * editing/execCommand/remove-formatting-2-expected.checksum: Added.
        * editing/execCommand/remove-formatting-2-expected.png: Added.
        * editing/execCommand/remove-formatting-2-expected.txt: Added.
        * editing/execCommand/remove-formatting-2.html: Added.
        * editing/execCommand/remove-formatting-expected.txt:

WebCore:

        Reviewed by john

        <http://bugs.webkit.org/show_bug.cgi?id=11329>
        Gmail Editor: Can't remove styling applied to selection after clicking "Remove Formatting" toolbar icon.

        * editing/Editor.cpp:
        (WebCore::Editor::removeFormattingAndStyle): Moved from JSEditor.
        Wrapped the plain text fragment in a style span with the document
        default style so that it will appear unstyled regardless of where
        it is inserted.  Could have also inserted the plain text fragment
        and then applied the document default style to it, but there is not
        yet any redundant style prevention in ApplyStyleCommand, so this
        is cleaner.
        * editing/Editor.h:
        * editing/JSEditor.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-10-26 Oliver Hunt <oliver@apple.com>
oliver [Thu, 26 Oct 2006 18:54:16 +0000 (18:54 +0000)]
2006-10-26  Oliver Hunt  <oliver@apple.com>

        Reviewed by Anders.
        Fixes <rdar://problem/4800518> -- needed to update existing
        canvas path elements when transforms are performed on the
        context.

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::scale):
        (WebCore::CanvasRenderingContext2D::rotate):
        (WebCore::CanvasRenderingContext2D::translate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
weinig [Thu, 26 Oct 2006 18:27:47 +0000 (18:27 +0000)]
    Reviewed by Darin.

        Fix build with older gcc 3.3.4.

        * kjs/DateMath.cpp: Remove inline prefix.
        (KJS::equivalentYearForDST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
weinig [Thu, 26 Oct 2006 18:25:07 +0000 (18:25 +0000)]
WebCore:

        Reviewed by Darin.

        Fix Qt/Linux build.

        * platform/network/qt/ResourceLoaderManager.cpp:
        (WebCore::ResourceLoaderManager::slotData):
        (WebCore::ResourceLoaderManager::slotMimetype):
        (WebCore::ResourceLoaderManager::remove):
        (WebCore::ResourceLoaderManager::add):
        * platform/network/qt/ResourceLoaderQt.cpp:
        (WebCore::ResourceLoader::receivedResponse):
        * platform/qt/FrameQtClient.cpp:
        (WebCore::FrameQtClientDefault::openURL):
        * platform/qt/LoaderFunctionsQt.cpp:
        (WebCore::ServeSynchronousRequest):

WebKitQt:

        Reviewed by Darin.

        Fix Qt/Linux build.

        * QtLauncher/main.cpp:
        (main):
        * WebKitPart/WebKitPart.cpp:
        (WebKitPart::openUrl):

WebKitTools:

        Reviewed by Darin.

        Fix Qt/Linux build.

        * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
        (WebCore::DumpRenderTree::open):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele.
aroben [Thu, 26 Oct 2006 18:19:57 +0000 (18:19 +0000)]
    Reviewed by Adele.

        Fix: <rdar://problem/3951815> add "type-to-select" feature for list
        boxes (<select> elements)

        This also adds type-ahead find for closed menulists (popups).

        * WebCore.xcodeproj/project.pbxproj: Version wars.
        * html/HTMLSelectElement.h: Add new instance variables for type-ahead
        find.
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::HTMLSelectElement): Initialize new
        instance variables.
        (WebCore::HTMLSelectElement::defaultEventHandler): Perform type-ahead
        find on printable character presses.
        (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Remove
        redundant check that the listIndex has changed (setSelectedIndex does
        this for us), and fix indentation.
        (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Change an if
        to an else-if.
        (WebCore::stripLeadingWhiteSpace): Helper function for typeAheadFind()
        to strip leading whitespace (including non-breaking spaces) from a
        string.
        (WebCore::HTMLSelectElement::typeAheadFind): New method to perform
        type-ahead find.
        * platform/PopupMenu.h: Added new updateFromElement() method to be
        called from RenderMenuList::updateFromElement().
        * platform/mac/PopupMenuMac.mm:
        (WebCore::PopupMenu::updateFromElement): While we are using
        NSPopUpButtonCell for our popups, this method can stay empty.
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::updateFromElement): Scroll to reveal the first
        selected element.
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::updateFromElement): Tell the popup to update
        if it's visible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago"causing give inconsistent results" -> "causing inconsistent results"
darin [Thu, 26 Oct 2006 17:40:59 +0000 (17:40 +0000)]
"causing give inconsistent results" -> "causing inconsistent results"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Thu, 26 Oct 2006 17:39:43 +0000 (17:39 +0000)]
LayoutTests:

        Reviewed by Anders.

        - removed non-deterministic behavior in editing that was causing
          give inconsistent results for editing/pasteboard/copy-paste-bidi.html

        * editing/pasteboard/copy-paste-bidi-expected.txt: New results, without the
        anonymous block that sometimes appeared and sometimes did not.

WebCore:

        Reviewed by Anders.

        - removed non-deterministic behavior in editing that was causing
          give inconsistent results for editing/pasteboard/copy-paste-bidi.html

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
        Use two vectors instead of a map: more efficient, deterministic. There was no
        reason to use a hash table.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - oops, checked in failure results, not success
darin [Thu, 26 Oct 2006 16:59:16 +0000 (16:59 +0000)]
    - oops, checked in failure results, not success

        * fast/js/string-property-iteration-expected.txt:
        Successful results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - checked in some missing results
darin [Thu, 26 Oct 2006 16:46:26 +0000 (16:46 +0000)]
    - checked in some missing results
          (if these are wrong we could remove or disable the test)

        * svg/hixie/cascade/002-expected.checksum: Added.
        * svg/hixie/cascade/002-expected.png: Added.
        * svg/hixie/cascade/002-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
darin [Thu, 26 Oct 2006 16:39:00 +0000 (16:39 +0000)]
JavaScriptCore:

        Reviewed by John.

        - fix iteration of properties of string objects (found because of a warning
          emitted by the MSVC compiler)

        * kjs/string_object.cpp: (StringInstance::getPropertyNames): Change code that
        wants to format a number as a string to use UString::from. Before it was using
        the UString constructor that makes a string from a character!

        * kjs/ustring.h:
        * kjs/ustring.cpp: Remove the dangerous and not all that helpful UString(char)
        constructor.

        * kjs/grammar.y: Change code to not depend on the UString(char) constructor.
        This is potentially more efficient anyway because we could overload the + operator
        some day to handle char* directly instead of creating a UString.

        * kjs/nodes2string.cpp: (SourceStream::operator<<): Change code to not depend on
        the UString(char) constructor.

LayoutTests:

        Reviewed by John.

        - add a test for iteration of properties of string objects

        * fast/js/resources/string-property-iteration.js: Added.
        * fast/js/string-property-iteration-expected.txt: Added.
        * fast/js/string-property-iteration.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@17305 268f45cc-cd09-0410...
sullivan [Thu, 26 Oct 2006 16:06:10 +0000 (16:06 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago No review, just two localized string changes.
sullivan [Thu, 26 Oct 2006 16:05:22 +0000 (16:05 +0000)]
    No review, just two localized string changes.

        * WebView/WebHTMLView.m:
        (-[NSArray validateUserInterfaceItem:]):
        changed "Show/Hide Spelling" to "Show/Hide Spelling and Grammar" post-Tiger to match framework change

        * English.lproj/Localizable.strings:
        updated for these changes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders.
mjs [Thu, 26 Oct 2006 10:34:24 +0000 (10:34 +0000)]
    Reviewed by Anders.

        - .5% speed improvement by avoiding excess CFURLRef allocation

        * loader/CachedResource.cpp:
        (WebCore::CachedResource::getCFURL): New method. For Mac only (for now), cache the CFURL
        here for later reuse.
        * loader/CachedResource.h:
        * loader/mac/LoaderFunctionsMac.mm:
        (WebCore::CheckCacheObjectStatus): Use the cached CFURL, don't make a whole new one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
darin [Thu, 26 Oct 2006 05:04:54 +0000 (05:04 +0000)]
WebCore:

        Reviewed by Anders.

        - removed 55 methods from WebCoreFrameBridge
        - changed callers to use Frame directly instead
        - put FrameLoaderTypes.h types into the WebCore namespace
        - first steps to get FrameLoader.h ready for cross-platform duty

        * WebCore.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * bridge/mac/BrowserExtensionMac.mm:
        (WebCore::BrowserExtensionMac::createNewWindow):
        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::loadRequest):
        (WebCore::FrameMac::startRedirectionTimer):
        (WebCore::FrameMac::stopRedirectionTimer):
        (WebCore::FrameMac::passSubframeEventToSubframe):
        (WebCore::FrameMac::handledOnloadEvents):
        (WebCore::FrameMac::isLoadTypeReload):
        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge executionContextForView:]):
        (updateRenderingForBindings):
        (-[WebCoreFrameBridge canTargetLoadInFrame:]):
        (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]):
        (-[WebCoreFrameBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
        (-[WebCoreFrameBridge installInFrame:]):
        (-[WebCoreFrameBridge numPendingOrLoadingRequests]):
        (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
        (-[WebCoreFrameBridge baseWritingDirectionForSelectionStart]):
        (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
        (stringByCollapsingNonPrintingCharacters):
        (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
        (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
        (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
        * loader/FrameLoaderTypes.h:
        * loader/mac/FrameLoader.h:
        * loader/mac/FrameLoader.mm:
        (WebCore::FrameLoader::FrameLoader):
        (WebCore::FrameLoader::setupForReplace):
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::activeDocumentLoader):
        (WebCore::FrameLoader::state):
        (WebCore::FrameLoader::setState):
        (WebCore::FrameLoader::clearProvisionalLoad):
        (WebCore::FrameLoader::markLoadComplete):
        (WebCore::FrameLoader::commitProvisionalLoad):
        (WebCore::FrameLoader::receivedMainResourceError):
        (WebCore::FrameLoader::handleFallbackContent):
        (WebCore::FrameLoader::isLoadingMainFrame):
        (WebCore::FrameLoader::continueAfterNewWindowPolicy):
        (WebCore::FrameLoader::continueAfterNavigationPolicy):
        (WebCore::FrameLoader::continueAfterWillSubmitForm):
        (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
        (WebCore::FrameLoader::transitionToCommitted):
        (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
        (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
        (-[WebCoreFrameLoaderAsDelegate continueAfterNewWindowPolicy:]):
        (-[WebCoreFrameLoaderAsDelegate continueAfterNavigationPolicy:]):
        (-[WebCoreFrameLoaderAsDelegate continueAfterWillSubmitForm:]):
        * loader/mac/ImageDocumentMac.mm:
        (WebCore::finishImageLoad):
        * loader/mac/WebDocumentLoader.mm:
        (WebCore::DocumentLoader::isLoadingInAPISense):
        * loader/mac/WebMainResourceLoader.h:
        * loader/mac/WebMainResourceLoader.mm:
        (WebCore::MainResourceLoader::continueAfterContentPolicy):
        (-[WebCoreMainResourceLoaderAsPolicyDelegate continueAfterContentPolicy:]):
        * loader/mac/WebSubresourceLoader.mm:
        (-[WebCoreSubresourceHandle initWithLoader:]):
        * platform/mac/ListBoxMac.mm:
        (-[WebCoreTableView keyDown:]):
        (-[WebCoreTableView keyUp:]):
        * platform/mac/WebCoreTextField.mm:
        (-[WebCoreTextFieldController textView:shouldHandleEvent:]):

WebKit:

        Reviewed by Anders.

        - removed 55 methods from WebCoreFrameBridge
        - changed callers to use Frame directly instead
        - put FrameLoaderTypes.h types into the WebCore namespace
        - first steps to get FrameLoader.h ready for cross-platform duty

        * DefaultDelegates/WebDefaultContextMenuDelegate.m:
        (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView requestWithURLCString:]):
        (-[WebBaseNetscapePluginView loadPluginRequest:]):
        (-[WebBaseNetscapePluginView getVariable:value:]):
        * Plugins/WebNetscapePluginEmbeddedView.m:
        (-[WebNetscapePluginEmbeddedView didStart]):
        * Plugins/WebNetscapePluginStream.mm:
        * Plugins/WebPluginContainerCheck.m:
        (-[WebPluginContainerCheck _continueWithPolicy:]):
        (-[WebPluginContainerCheck _isForbiddenFileLoad]):
        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::shouldDeleteRange):
        (WebEditorClient::shouldShowDeleteInterface):
        * WebCoreSupport/WebFrameBridge.mm:
        (-[WebFrameBridge webView]):
        (-[WebFrameBridge finishInitializingWithFrameName:view:]):
        (-[WebFrameBridge createWindowWithURL:]):
        (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
        (-[WebFrameBridge windowObjectCleared]):
        (-[WebFrameBridge createModalDialogWithURL:]):
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchCreatePage):
        (WebFrameLoaderClient::dispatchWillSubmitForm):
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebArchiver.m:
        (+[WebArchiver archiveSelectionInFrame:]):
        * WebView/WebDataSource.mm:
        (-[WebDataSource _documentFragmentWithImageResource:]):
        (-[WebDataSource _imageElementWithImageResource:]):
        * WebView/WebEditingDelegatePrivate.h:
        * WebView/WebFrame.mm:
        (core):
        (kit):
        (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]):
        (-[WebFrame _canCachePage]):
        (-[WebFrame _childFramesMatchItem:]):
        (-[WebFrame _URLsMatchItem:]):
        (-[WebFrame _loadItem:withLoadType:]):
        (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]):
        (-[WebFrame _viewWillMoveToHostWindow:]):
        (-[WebFrame _viewDidMoveToHostWindow]):
        (-[WebFrame _addChild:]):
        (-[WebFrame _saveDocumentAndScrollState]):
        (-[WebFrame _numPendingOrLoadingRequests:]):
        (-[WebFrame _reloadForPluginChanges]):
        (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
        (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
        (-[WebFrame _initWithWebFrameView:webView:coreFrame:]):
        (-[WebFrame _documentViews]):
        (-[WebFrame _updateBackground]):
        (-[WebFrame _unmarkAllMisspellings]):
        (-[WebFrame _hasSelection]):
        (-[WebFrame _atMostOneFrameHasSelection]):
        (-[WebFrame _findFrameWithSelection]):
        (-[WebFrame _frameLoader]):
        (-[WebFrame _isDescendantOfFrame:]):
        (-[WebFrame _setShouldCreateRenderers:]):
        (-[WebFrame _bodyBackgroundColor]):
        (-[WebFrame init]):
        (-[WebFrame initWithName:webFrameView:webView:]):
        (-[WebFrame dealloc]):
        (-[WebFrame finalize]):
        (-[WebFrame name]):
        (-[WebFrame webView]):
        (-[WebFrame DOMDocument]):
        (-[WebFrame frameElement]):
        (-[WebFrame findFrameNamed:]):
        (-[WebFrame parentFrame]):
        (-[WebFrame childFrames]):
        (-[WebFrame _invalidateCurrentItemPageCache]):
        (-[WebFrame _dispatchCreateWebViewWithRequest:]):
        (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
        (-[WebFrame _prepareForDataSourceReplacement]):
        (-[WebFrame _provisionalLoadStarted]):
        * WebView/WebFrameInternal.h:
        * WebView/WebHTMLRepresentation.m:
        (-[WebHTMLRepresentation DOMDocument]):
        (-[WebHTMLRepresentation attributedText]):
        * WebView/WebHTMLView.m:
        (-[WebHTMLView _documentRange]):
        (-[WebHTMLView _documentFragmentWithPaths:]):
        (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]):
        (-[WebHTMLView _selectedRange]):
        (-[WebHTMLView _updateMouseoverWithEvent:]):
        (-[WebHTMLView _canEditRichly]):
        (-[WebHTMLView _hasSelection]):
        (-[WebHTMLView _hasSelectionOrInsertionPoint]):
        (-[WebHTMLView _hasInsertionPoint]):
        (-[WebHTMLView _isEditable]):
        (-[WebHTMLView _isSelectionInPasswordField]):
        (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
        (-[WebHTMLView _selectionDraggingImage]):
        (-[WebHTMLView _canIncreaseSelectionListLevel]):
        (-[WebHTMLView _canDecreaseSelectionListLevel]):
        (-[WebHTMLView _updateActiveState]):
        (-[NSArray readSelectionFromPasteboard:]):
        (-[NSArray validateUserInterfaceItem:]):
        (-[NSArray maintainsInactiveSelection]):
        (-[NSArray menuForEvent:]):
        (-[NSArray scrollWheel:]):
        (-[NSArray acceptsFirstMouse:]):
        (-[NSArray shouldDelayWindowOrderingForEvent:]):
        (-[NSArray mouseDown:]):
        (-[NSArray mouseDragged:]):
        (-[NSArray mouseUp:]):
        (-[NSArray keyDown:]):
        (-[NSArray keyUp:]):
        (-[NSArray centerSelectionInVisibleArea:]):
        (-[NSArray _selectionStartFontAttributesAsRTF]):
        (-[NSArray _emptyStyle]):
        (-[NSArray performKeyEquivalent:]):
        (-[NSArray indent:]):
        (-[NSArray outdent:]):
        (-[WebHTMLView cut:]):
        (-[WebHTMLView paste:]):
        (-[WebHTMLView _selectRangeInMarkedText:]):
        (-[WebTextCompleteController doCompletion]):
        (-[WebHTMLView selectionRect]):
        (-[WebHTMLView selectionImageForcingWhiteText:]):
        (-[WebHTMLView selectionImageRect]):
        (-[WebHTMLView attributedString]):
        (-[WebHTMLView _isMoveDrag]):
        (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
        * WebView/WebPolicyDelegate.mm:
        (-[WebPolicyDecisionListener _usePolicy:]):
        (-[WebPolicyDecisionListener use]):
        (-[WebPolicyDecisionListener ignore]):
        (-[WebPolicyDecisionListener download]):
        (-[WebPolicyDecisionListener continue]):
        * WebView/WebScriptDebugDelegate.m:
        (-[WebScriptCallFrame _initWithFrame:initWithWebFrame:]):
        (-[WebScriptCallFrame globalObject]):
        * WebView/WebView.mm:
        (-[WebView _attachScriptDebuggerToAllFrames]):
        (-[WebView _detachScriptDebuggerFromAllFrames]):
        (-[WebView windowScriptObject]):
        (incrementFrame):
        (-[WebView searchFor:direction:caseSensitive:wrap:]):
        (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]):
        (-[WebView removeDragCaret]):
        (-[WebView setScriptDebugDelegate:]):
        (-[WebView scriptDebugDelegate]):
        (-[WebView shouldClose]):
        (-[WebView selectedDOMRange]):
        (-[WebView styleDeclarationWithText:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-10-25 Mitz Pettel <mitz@webkit.org>
bdash [Thu, 26 Oct 2006 02:43:25 +0000 (02:43 +0000)]
2006-10-25  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Adele.

        - http://bugs.webkit.org/show_bug.cgi?id=11412
          Stray list item in coding/coding-style.html

        * coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-10-25 Steve Falkenburg <sfalken@apple.com>
sfalken [Thu, 26 Oct 2006 00:43:59 +0000 (00:43 +0000)]
2006-10-25  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Darin.

        Printing fixes

        * page/Frame.cpp:
        (WebCore::Frame::adjustPageHeight):
        * page/Frame.h:
        (WebCore::Frame::setupRootForPrinting):
        (WebCore::Frame::computePageRects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Steve (rubber stamp).
kmccullo [Thu, 26 Oct 2006 00:29:51 +0000 (00:29 +0000)]
    Reviewed by Steve (rubber stamp).

        - Link against your local build of JavaScriptCore.lib first, this fixes some errors on release builds of testkjs.

        * JavaScriptCore.vcproj/testkjs/testkjs.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReverting my change, broke the Tiger build.
thatcher [Thu, 26 Oct 2006 00:27:53 +0000 (00:27 +0000)]
Reverting my change, broke the Tiger build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-10-25 Anders Carlsson <acarlsson@apple.com>
andersca [Thu, 26 Oct 2006 00:12:45 +0000 (00:12 +0000)]
2006-10-25  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        <rdar://problem/4799088>
        REGRESSION: Translation widget fails to convert data and reports a "Data unavailable" error.

        * loader/mac/WebSubresourceLoader.h:
        * loader/mac/WebSubresourceLoader.mm:
        (-[WebCoreSubresourceHandle initWithLoader:]):
        Set the HTTP method before the HTTP body.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Kevin Decker.
thatcher [Wed, 25 Oct 2006 23:42:52 +0000 (23:42 +0000)]
    Reviewed by Kevin Decker.

        * libWebKitSystemInterface.a: updated to be 64-bit universal

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Lou.
ggaren [Wed, 25 Oct 2006 20:51:22 +0000 (20:51 +0000)]
    Reviewed by Lou.

        Removed duplicate symbol declaration.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/grammar.y:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
ggaren [Wed, 25 Oct 2006 20:49:47 +0000 (20:49 +0000)]
WebCore:

        Reviewed by Adam.

        Renamed WebFrameLoader to FrameLoader, to match class name.

        * WebCore.xcodeproj/project.pbxproj:
        * bridge/mac/FrameMac.mm:
        * bridge/mac/WebCoreFrameBridge.mm:
        * loader/mac/FrameLoader.mm: Added.
        * loader/mac/IconLoaderMac.mm:
        * loader/mac/WebDocumentLoader.mm:
        * loader/mac/WebFrameLoader.h: Removed.
        * loader/mac/WebFrameLoader.mm: Removed.
        * loader/mac/WebLoader.mm:
        * loader/mac/WebMainResourceLoader.mm:
        * loader/mac/WebNetscapePlugInStreamLoader.mm:
        * loader/mac/WebSubresourceLoader.mm:

WebKit:

        Reviewed by Adam.

        Renamed WebFrameLoader to FrameLoader, to match class name.

        * Plugins/WebBaseNetscapePluginView.mm:
        * Plugins/WebNetscapePluginStream.mm:
        * Plugins/WebPluginController.mm:
        * WebCoreSupport/WebFrameBridge.mm:
        * WebView/WebDataSource.mm:
        * WebView/WebFrame.mm:
        * WebView/WebPDFView.mm:
        * WebView/WebPolicyDelegate.mm:
        * WebView/WebView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fix full builds
darin [Wed, 25 Oct 2006 19:29:53 +0000 (19:29 +0000)]
    - fix full builds

        * WebCore.xcodeproj/project.pbxproj: Mark bridge/mac/WebCoreResourceLoader.h as private.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-10-25 David Smith <catfish.man@gmail.com>
bdash [Wed, 25 Oct 2006 12:12:34 +0000 (12:12 +0000)]
2006-10-25  David Smith  <catfish.man@gmail.com>

        Reviewed by Mitz.

        Fixed REGRESSION (r17280): Repro crash when clicking a link with target="_blank"
        http://bugs.webkit.org/show_bug.cgi?id=11411

        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge canTargetLoadInFrame:]): Check that the target has a frame before using it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Mitz.
mjs [Wed, 25 Oct 2006 09:57:24 +0000 (09:57 +0000)]
    Rubber stamped by Mitz.

        - moved some files that are essentially part of the ResourceLoader implementation to platform/network/mac

        * WebCore.xcodeproj/project.pbxproj:
        * bridge/mac/WebCoreResourceLoader.h: Moved to platform/network/mac.
        * bridge/mac/WebCoreResourceLoaderImp.h: Moved to platform/network/mac.
        * bridge/mac/WebCoreResourceLoaderImp.mm: Moved to platform/network/mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Mark.
mjs [Wed, 25 Oct 2006 09:55:24 +0000 (09:55 +0000)]
    Rubber stamped by Mark.

        - remove no longer existing symbol that was breaking linking

        * WebCore.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mitz.
mjs [Wed, 25 Oct 2006 08:52:04 +0000 (08:52 +0000)]
    Reviewed by Mitz.

        - fixed "REGRESSION: Activity window doesn't always list all files until refresh"
        http://bugs.webkit.org/show_bug.cgi?id=11212

        I couldn't figure out how to write a test case.

        * bindings/js/kjs_window.cpp:
        (KJS::Window::clear): Avoid crashing if already detached.
        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::clear): Change prototype to make this a proper
        overload for Frame::clear once again(!).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-10-25 Mark Rowe <bdash@webkit.org>
bdash [Wed, 25 Oct 2006 08:22:35 +0000 (08:22 +0000)]
2006-10-25  Mark Rowe  <bdash@webkit.org>

        Reviewed by Maciej.

        Fix some HTML bugs in the coding style guidelines.

        * coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-10-25 Mark Rowe <bdash@webkit.org>
bdash [Wed, 25 Oct 2006 07:52:09 +0000 (07:52 +0000)]
2006-10-25  Mark Rowe  <bdash@webkit.org>

        Reviewed by Anders.

        Build fix for the Buildbot.

        * WebView/WebHTMLView.m:
        (-[NSArray _addToStyle:fontA:fontB:]): Explicit cast.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders.
mjs [Wed, 25 Oct 2006 07:30:44 +0000 (07:30 +0000)]
    Reviewed by Anders.

        <rdar://problem/4785575> REGRESSION: form resubmission warning occurs twice, then Safari crashes in autorelease pool
        <rdar://problem/4799383> REGRESSION: Crash occurs when dismissing the "Would you like to save this password" sheet

        * WebView/WebPolicyDeciderMac.m:
        (-[WebPolicyDeciderMac dealloc]): release the listener, don't dealloc it

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-10-24 Anders Carlsson <acarlsson@apple.com>
andersca [Wed, 25 Oct 2006 05:38:53 +0000 (05:38 +0000)]
2006-10-24  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Darin.

        * WebKitPrefix.h:
        Include FastMalloc.h from C++ code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
darin [Wed, 25 Oct 2006 05:35:02 +0000 (05:35 +0000)]
WebCore:

        Reviewed by Anders.

        - converted WebFrameLoaderClient to C++
        - renamed frame->frameLoader() function to frame->loader()
        - renamed [bridge impl] to [bridge _frame]
        - removed some bridge methods

        * WebCore.exp: Added more exports.
        * WebCore.xcodeproj/project.pbxproj: Made FrameTree.h private instead of project-internal
        so it can be used in WebKit.

        * bridge/mac/BrowserExtensionMac.mm:
        (WebCore::BrowserExtensionMac::createNewWindow):
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::createFrame):
        (WebCore::FrameMac::didFirstLayout):
        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject rendererForView:]):
        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge _shouldAllowAccessFrom:]):
        (-[WebCoreFrameBridge canTargetLoadInFrame:]):
        (-[WebCoreFrameBridge setOpener:]):
        (-[WebCoreFrameBridge getData:andResponse:forURL:]):
        (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
        (-[WebCoreFrameBridge setTitle:]):
        (-[WebCoreFrameBridge originalRequestURL]):
        (-[WebCoreFrameBridge isLoadTypeReload]):
        (-[WebCoreFrameBridge frameDetached]):
        (-[WebCoreFrameBridge tokenizerProcessedData]):
        (-[WebCoreFrameBridge receivedData:textEncodingName:]):
        (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
        (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
        (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
        (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
        (-[WebCoreFrameBridge incomingReferrer]):
        (-[WebCoreFrameBridge isReloading]):
        (-[WebCoreFrameBridge handledOnloadEvents]):
        (-[WebCoreFrameBridge mainResourceURLResponse]):
        (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
        (-[WebCoreFrameBridge _frame]):
        (-[WebCoreFrameBridge executionContextForView:]):
        * bridge/mac/WebCorePageBridge.mm:
        (-[WebCorePageBridge setMainFrame:]):
        * dom/Position.cpp:
        (WebCore::Position::upstream):
        * loader/mac/IconLoaderMac.mm:
        (IconLoader::notifyIconChanged):
        * loader/mac/WebDocumentLoader.mm:
        (WebCore::DocumentLoader::frameLoader):
        (WebCore::DocumentLoader::stopLoading):
        (WebCore::DocumentLoader::finishedLoading):
        (WebCore::DocumentLoader::setupForReplaceByMIMEType):
        * loader/mac/WebFormState.mm:
        (WebCore::FormState::FormState):
        * loader/mac/WebFrameLoader.h:
        * loader/mac/WebFrameLoader.mm:
        (WebCore::FrameLoader::~FrameLoader):
        (WebCore::FrameLoader::prepareForLoadStart):
        (WebCore::FrameLoader::finalSetupForReplace):
        (WebCore::FrameLoader::safeLoad):
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::startLoading):
        (WebCore::FrameLoader::stopLoadingSubframes):
        (WebCore::FrameLoader::stopLoading):
        (WebCore::FrameLoader::cancelPendingArchiveLoad):
        (WebCore::FrameLoader::defersCallbacksChanged):
        (WebCore::FrameLoader::setDefersCallbacks):
        (WebCore::FrameLoader::setDocumentLoader):
        (WebCore::FrameLoader::provisionalLoadStarted):
        (WebCore::FrameLoader::clearProvisionalLoad):
        (WebCore::FrameLoader::identifierForInitialRequest):
        (WebCore::FrameLoader::willSendRequest):
        (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
        (WebCore::FrameLoader::didCancelAuthenticationChallenge):
        (WebCore::FrameLoader::didReceiveResponse):
        (WebCore::FrameLoader::didReceiveData):
        (WebCore::FrameLoader::didFinishLoad):
        (WebCore::FrameLoader::didFailToLoad):
        (WebCore::FrameLoader::privateBrowsingEnabled):
        (WebCore::FrameLoader::receivedMainResourceError):
        (WebCore::FrameLoader::clientRedirectCancelledOrFinished):
        (WebCore::FrameLoader::clientRedirected):
        (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
        (WebCore::FrameLoader::closeOldDataSources):
        (WebCore::FrameLoader::opened):
        (WebCore::FrameLoader::commitProvisionalLoad):
        (WebCore::FrameLoader::download):
        (WebCore::FrameLoader::finishedLoading):
        (WebCore::FrameLoader::notifyIconChanged):
        (WebCore::FrameLoader::cancelledError):
        (WebCore::FrameLoader::fileDoesNotExistError):
        (WebCore::FrameLoader::willUseArchive):
        (WebCore::FrameLoader::isArchiveLoadPending):
        (WebCore::FrameLoader::handleUnimplementablePolicy):
        (WebCore::FrameLoader::cannotShowMIMEType):
        (WebCore::FrameLoader::interruptionForPolicyChangeError):
        (WebCore::FrameLoader::canShowMIMEType):
        (WebCore::FrameLoader::representationExistsForURLScheme):
        (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
        (WebCore::FrameLoader::checkContentPolicy):
        (WebCore::FrameLoader::reloadAllowingStaleData):
        (WebCore::FrameLoader::reload):
        (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame):
        (WebCore::FrameLoader::finishedLoadingDocument):
        (WebCore::FrameLoader::committedLoad):
        (WebCore::FrameLoader::revertToProvisional):
        (WebCore::FrameLoader::setMainDocumentError):
        (WebCore::FrameLoader::mainReceivedCompleteError):
        (WebCore::FrameLoader::subframeIsLoading):
        (WebCore::FrameLoader::willChangeTitle):
        (WebCore::FrameLoader::didChangeTitle):
        (WebCore::FrameLoader::checkNewWindowPolicy):
        (WebCore::FrameLoader::continueAfterNewWindowPolicy):
        (WebCore::FrameLoader::checkNavigationPolicy):
        (WebCore::FrameLoader::continueAfterNavigationPolicy):
        (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
        (WebCore::FrameLoader::didFirstLayout):
        (WebCore::FrameLoader::frameLoadCompleted):
        (WebCore::FrameLoader::transitionToCommitted):
        (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
        (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
        (WebCore::FrameLoader::sendRemainingDelegateMessages):
        (WebCore::FrameLoader::requestFromDelegate):
        (WebCore::FrameLoader::post):
        (WebCore::FrameLoader::detachChildren):
        (WebCore::FrameLoader::detachFromParent):
        (WebCore::FrameLoader::addExtraFieldsToRequest):
        (WebCore::FrameLoader::actionInformation):
        (WebCore::FrameLoader::checkLoadComplete):
        (WebCore::FrameLoader::setClient):
        (WebCore::FrameLoader::client):
        (WebCore::FrameLoaderClient::~FrameLoaderClient):
        * loader/mac/WebFrameLoaderClient.h:
        * loader/mac/WebLoader.mm:
        (WebCore::WebResourceLoader::frameLoader):
        * loader/mac/WebSubresourceLoader.mm:
        (-[WebCoreSubresourceHandle initWithLoader:]):
        * page/Frame.cpp:
        (WebCore::Frame::loader):
        * page/Frame.h:
        * platform/mac/SliderMac.mm:
        (Slider::focusPolicy):

WebKit:

        Reviewed by Anders.

        - converted WebFrameLoaderClient to C++
        - renamed frame->frameLoader() function to frame->loader()
        - renamed [bridge impl] to [bridge _frame]
        - removed some bridge methods

        * Plugins/WebNetscapePluginStream.mm:
        * WebCoreSupport/WebEditorClient.mm:
        * WebCoreSupport/WebFrameLoaderClient.h: Added.
        (WebFrameLoaderClient::webFrame):
        * WebCoreSupport/WebFrameLoaderClient.mm: Added.
        (WebFrameLoaderClient::detachFrameLoader):
        (WebFrameLoaderClient::hasWebView):
        (WebFrameLoaderClient::hasFrameView):
        (WebFrameLoaderClient::hasBackForwardList):
        (WebFrameLoaderClient::resetBackForwardList):
        (WebFrameLoaderClient::provisionalItemIsTarget):
        (WebFrameLoaderClient::loadProvisionalItemFromPageCache):
        (WebFrameLoaderClient::invalidateCurrentItemPageCache):
        (WebFrameLoaderClient::privateBrowsingEnabled):
        (WebFrameLoaderClient::makeDocumentView):
        (WebFrameLoaderClient::makeRepresentation):
        (WebFrameLoaderClient::setDocumentViewFromPageCache):
        (WebFrameLoaderClient::forceLayout):
        (WebFrameLoaderClient::forceLayoutForNonHTML):
        (WebFrameLoaderClient::updateHistoryForCommit):
        (WebFrameLoaderClient::updateHistoryForBackForwardNavigation):
        (WebFrameLoaderClient::updateHistoryForReload):
        (WebFrameLoaderClient::updateHistoryForStandardLoad):
        (WebFrameLoaderClient::updateHistoryForInternalLoad):
        (WebFrameLoaderClient::updateHistoryAfterClientRedirect):
        (WebFrameLoaderClient::setCopiesOnScroll):
        (WebFrameLoaderClient::tokenForLoadErrorReset):
        (WebFrameLoaderClient::resetAfterLoadError):
        (WebFrameLoaderClient::doNotResetAfterLoadError):
        (WebFrameLoaderClient::detachedFromParent1):
        (WebFrameLoaderClient::detachedFromParent2):
        (WebFrameLoaderClient::detachedFromParent3):
        (WebFrameLoaderClient::detachedFromParent4):
        (WebFrameLoaderClient::loadedFromPageCache):
        (WebFrameLoaderClient::download):
        (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
        (WebFrameLoaderClient::dispatchWillSendRequest):
        (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
        (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
        (WebFrameLoaderClient::dispatchDidReceiveResponse):
        (WebFrameLoaderClient::dispatchDidReceiveContentLength):
        (WebFrameLoaderClient::dispatchDidFinishLoading):
        (WebFrameLoaderClient::dispatchDidFailLoading):
        (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
        (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
        (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
        (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
        (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
        (WebFrameLoaderClient::dispatchWillClose):
        (WebFrameLoaderClient::dispatchDidReceiveIcon):
        (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
        (WebFrameLoaderClient::dispatchDidReceiveTitle):
        (WebFrameLoaderClient::dispatchDidCommitLoad):
        (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
        (WebFrameLoaderClient::dispatchDidFailLoad):
        (WebFrameLoaderClient::dispatchDidFinishLoad):
        (WebFrameLoaderClient::dispatchDidFirstLayout):
        (WebFrameLoaderClient::dispatchCreatePage):
        (WebFrameLoaderClient::dispatchShow):
        (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
        (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
        (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
        (WebFrameLoaderClient::dispatchUnableToImplementPolicy):
        (WebFrameLoaderClient::dispatchWillSubmitForm):
        (WebFrameLoaderClient::dispatchDidLoadMainResource):
        (WebFrameLoaderClient::clearLoadingFromPageCache):
        (WebFrameLoaderClient::isLoadingFromPageCache):
        (WebFrameLoaderClient::revertToProvisionalState):
        (WebFrameLoaderClient::setMainDocumentError):
        (WebFrameLoaderClient::clearUnarchivingState):
        (WebFrameLoaderClient::progressStarted):
        (WebFrameLoaderClient::progressCompleted):
        (WebFrameLoaderClient::incrementProgress):
        (WebFrameLoaderClient::completeProgress):
        (WebFrameLoaderClient::setMainFrameDocumentReady):
        (WebFrameLoaderClient::startDownload):
        (WebFrameLoaderClient::willChangeTitle):
        (WebFrameLoaderClient::didChangeTitle):
        (WebFrameLoaderClient::committedLoad):
        (WebFrameLoaderClient::finishedLoading):
        (WebFrameLoaderClient::finalSetupForReplace):
        (WebFrameLoaderClient::cancelledError):
        (WebFrameLoaderClient::cannotShowURLError):
        (WebFrameLoaderClient::interruptForPolicyChangeError):
        (WebFrameLoaderClient::cannotShowMIMETypeError):
        (WebFrameLoaderClient::fileDoesNotExistError):
        (WebFrameLoaderClient::shouldFallBack):
        (WebFrameLoaderClient::mainFrameURL):
        (WebFrameLoaderClient::setDefersCallbacks):
        (WebFrameLoaderClient::willUseArchive):
        (WebFrameLoaderClient::isArchiveLoadPending):
        (WebFrameLoaderClient::cancelPendingArchiveLoad):
        (WebFrameLoaderClient::clearArchivedResources):
        (WebFrameLoaderClient::canHandleRequest):
        (WebFrameLoaderClient::canShowMIMEType):
        (WebFrameLoaderClient::representationExistsForURLScheme):
        (WebFrameLoaderClient::generatedMIMETypeForURLScheme):
        (WebFrameLoaderClient::elementForEvent):
        (WebFrameLoaderClient::createPolicyDecider):
        (WebFrameLoaderClient::frameLoadCompleted):
        (WebFrameLoaderClient::restoreScrollPositionAndViewState):
        (WebFrameLoaderClient::provisionalLoadStarted):
        (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent):
        (WebFrameLoaderClient::addHistoryItemForFragmentScroll):
        (WebFrameLoaderClient::didFinishLoad):
        (WebFrameLoaderClient::prepareForDataSourceReplacement):
        (WebFrameLoaderClient::createDocumentLoader):
        (WebFrameLoaderClient::setTitle):
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebDataSource.mm:
        (-[WebDataSource webFrame]):
        * WebView/WebFrame.mm:
        (frame):
        (-[WebFrame _loadItem:withLoadType:]):
        (-[WebFrame _reloadForPluginChanges]):
        (-[WebFrame _initWithWebFrameView:webView:bridge:]):
        (-[WebFrame _frameLoader]):
        (-[WebFrame provisionalDataSource]):
        (-[WebFrame dataSource]):
        (-[WebFrame parentFrame]):
        (-[WebFrame _provisionalLoadStarted]):
        * WebView/WebFrameInternal.h:
        * WebView/WebHTMLRepresentation.m:
        (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
        * WebView/WebHTMLView.m:
        (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
        (-[NSArray validateUserInterfaceItem:]):
        (-[NSArray scrollWheel:]):
        (-[NSArray acceptsFirstMouse:]):
        (-[NSArray shouldDelayWindowOrderingForEvent:]):
        (-[NSArray _selectionStartFontAttributesAsRTF]):
        (-[NSArray changeBaseWritingDirection:]):
        (-[NSArray indent:]):
        (-[NSArray outdent:]):
        (-[WebHTMLView copy:]):
        (-[WebHTMLView cut:]):
        (-[WebHTMLView paste:]):
        * WebView/WebView.mm:
        (-[WebView _dashboardRegions]):
        (-[WebView setProhibitsMainFrameScrolling:]):
        (-[WebView _setInViewSourceMode:]):
        (-[WebView _inViewSourceMode]):
        (-[WebView setEditable:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Anders.
darin [Wed, 25 Oct 2006 05:30:39 +0000 (05:30 +0000)]
    Rubber stamped by Anders.

        - get rid of the assertion firing while running the layout tests

        This does not fix the real problem, which is that we need to map offsets within
        possibly-text-transformed text in the render tree to DOM tree offsets and vice
        versa -- but it gets the tests running again.

        * dom/Position.cpp: (WebCore::Position::upstream): Commented out the assertion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
mjs [Wed, 25 Oct 2006 04:25:02 +0000 (04:25 +0000)]
LayoutTests:

        Reviewed by Oliver.

        - re-enable testing of HEAD methods, now that bugs relating to these are fixed

        * http/tests/xmlhttprequest/methods-async-expected.txt:
        * http/tests/xmlhttprequest/methods-async.html:
        * http/tests/xmlhttprequest/methods-expected.txt:
        * http/tests/xmlhttprequest/methods.html:

WebCore:

        Reviewed by Oliver.

        - more ResourceLoader cleanup
            - moved HTTPHeaderMap out of ResourceRequest class, so ResourceResponse will be able to use it too
            - took out attempts to suppress setting of "HEAD" and "GET" methods, since underlying bugs are now fixed

        * loader/LoaderFunctions.h:
        * loader/mac/LoaderFunctionsMac.mm:
        (WebCore::ServeSynchronousRequest):
        * loader/mac/WebSubresourceLoader.mm:
        (-[WebCoreSubresourceHandle initWithLoader:]):
        * platform/network/HTTPHeaderMap.h: Added.
        * platform/network/ResourceLoader.cpp:
        (WebCore::ResourceLoader::requestHeaders):
        * platform/network/ResourceLoader.h:
        * platform/network/ResourceRequest.h:
        * platform/network/cf/ResourceLoaderCFNet.cpp:
        (WebCore::addHeadersFromHashMap):
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::send):
        * xml/xmlhttprequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-10-24 Stephanie Lewis <slewis@apple.com>
slewis [Wed, 25 Oct 2006 04:23:13 +0000 (04:23 +0000)]
2006-10-24  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Maciej.

        - Changed run-javascriptcore tests to build testkjs before running.

        * Scripts/run-javascriptcore-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Wed, 25 Oct 2006 01:37:04 +0000 (01:37 +0000)]
LayoutTests:

        Reviewed by darin

        <http://bugs.webkit.org/show_bug.cgi?id=10993>
        GMail Editor: Caret doesn't always position itself after list marker

        * editing/execCommand/create-list-1-expected.checksum: Added.
        * editing/execCommand/create-list-1-expected.png: Added.
        * editing/execCommand/create-list-1-expected.txt: Added.
        * editing/execCommand/create-list-1.html: Added.

        Fixed:
        * editing/execCommand/create-list-with-hr-expected.checksum:
        * editing/execCommand/create-list-with-hr-expected.png:
        * editing/execCommand/create-list-with-hr-expected.txt:
        * editing/execCommand/create-list-with-hr.html:
        * editing/execCommand/remove-list-1-expected.checksum:
        * editing/execCommand/remove-list-1-expected.png:
        * editing/execCommand/remove-list-1-expected.txt:
        * fast/text/attributed-substring-from-range-001-expected.txt:

WebCore:

        Reviewed by darin

        <http://bugs.webkit.org/show_bug.cgi?id=10993>
        GMail Editor: Caret doesn't always position itself after list marker

        List creation uses moveParagraphs to push content into list items.
        moveParagraphs uses a TextIterator to restore selections after moves.
        Some characters emitted by the TextIterator had bad ranges associated
        with them.  rangeFromLocationAndLength would skip past the range it
        should have used when asked for ranges of length 0.

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::TextIterator): No longer need to initialize a
        removed member variable.
        (WebCore::TextIterator::advance): An extra newline is emitted when leaving
        some blocks.  Use the same range for this newline as for the first newline.
        We should remove this code and just emit two '\n's.
        (WebCore::TextIterator::handleTextNode): Setup m_range.
        (WebCore::TextIterator::handleTextBox): Ditto.
        (WebCore::TextIterator::handleReplacedElement): Ditto.
        (WebCore::TextIterator::handleNonTextNode): Ditto.
        (WebCore::TextIterator::exitNode): Use an m_range from the last VisiblePosition
        in the block we're leaving to that VP after that one.
        (WebCore::TextIterator::emitCharacter): This function now takes in the start
        and the end of the range associated with the emited character, and sets up m_range.
        (WebCore::TextIterator::range): Return m_range.  If it is null (we are atEnd),
        return the end of the range used to create the iterator, as a convenience to
        callers that use call range() on an iterator that is atEnd.
        (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
        Same as the changes made to TextIterator's constructor.
        (WebCore::SimplifiedBackwardsTextIterator::advance): Use a null m_range instead of
        a null m_positionNode to signal that we're finished.
        (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Ditto.
        (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement): Similar to changes
        made to TextIterator.
        (WebCore::SimplifiedBackwardsTextIterator::emitCharacter): Ditto.
        (WebCore::SimplifiedBackwardsTextIterator::emitNewline): Simplified.
        (WebCore::SimplifiedBackwardsTextIterator::range): Similar to the changes made to
        TextIterator::range.
        (WebCore::CharacterIterator::range): This function assumed that an iterator's
        range() was safe to modify.
        (WebCore::TextIterator::rangeFromLocationAndLength):
        If the range we're looking for starts in the current chunk, this function assumed
        that if the chunk started in a text node, it would end in the same text node.  This
        is no longer the case.
        If the range we're looking for starts in the middle of the current chunk, I assume
        that the chunk is inside a text node, because those are the only chunks with length
        greater than one at the moment.
        If the range we're looking for is a zero length range that starts/ends at the end of the
        current chunk, we used to return the start of the next chunk, but that's wrong and
        is what caused this bug.
        * editing/TextIterator.h:
        (WebCore::TextIterator::atEnd): The iterator is atEnd when m_range is null.
        (WebCore::SimplifiedBackwardsTextIterator::atEnd):
        * editing/visible_units.cpp:
        (WebCore::previousBoundary): Cleaned up by using a convenience function.
        (WebCore::nextBoundary): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-10-24 Steve Falkenburg <sfalken@apple.com>
sfalken [Wed, 25 Oct 2006 00:31:11 +0000 (00:31 +0000)]
2006-10-24  Steve Falkenburg  <sfalken@apple.com>

        Build config change

        * JavaScriptCore.vcproj/testkjs/testkjs.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Kevin Decker
sullivan [Wed, 25 Oct 2006 00:11:15 +0000 (00:11 +0000)]
    Reviewed by Kevin Decker

        - fixed <rdar://problem/4801331> "Spelling..." menu item should be "Show/Hide Spelling" post-Tiger, to match AppKit

        * WebView/WebHTMLView.m:
        (-[NSArray validateUserInterfaceItem:]):
        post-Tiger, update the menu item text to "Show Spelling"/"Hide Spelling" based on whether
        the spelling panel is already showing. Also, removed else's after returns, and removed
        braces around one-line if clauses.
        (-[NSArray showGuessPanel:]):
        post-Tiger, make this item hide the spelling panel if it's already showing

        * English.lproj/Localizable.strings:
        updated for this change

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-10-24 Anders Carlsson <acarlsson@apple.com>
andersca [Tue, 24 Oct 2006 23:49:20 +0000 (23:49 +0000)]
2006-10-24  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Maciej.

        * platform/network/mac/ResourceLoaderMac.mm:
        (WebCore::ResourceLoader::start):
        Don't retain the header dictionary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders.
ggaren [Tue, 24 Oct 2006 23:11:41 +0000 (23:11 +0000)]
    Reviewed by Anders.

        Fixed http://bugs.webkit.org/show_bug.cgi?id=11404
        REGRESSION: Reproducible assertion failure in Shared<WebCore::StringImpl>::ref()
        running svg/custom/svg/custom/gradient-attr-update.svg

        SVGRenderStyle wasn't ref-ing the shared objects it held onto. Oops.

        * ksvg2/css/SVGRenderStyle.h:
        * ksvg2/css/SVGRenderStyleDefs.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-10-24 Anders Carlsson <acarlsson@apple.com>
andersca [Tue, 24 Oct 2006 22:56:12 +0000 (22:56 +0000)]
2006-10-24  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Mitz.

        * platform/network/ResourceRequest.h:
        (WebCore::ResourceRequest::ResourceRequest):
        Set the http method to "GET" in the constructor that takes a String.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim H.
weinig [Tue, 24 Oct 2006 22:48:59 +0000 (22:48 +0000)]
    Reviewed by Tim H.

        Move kcanvas/Render* and kcanvas/SVG* to rendering/Render*
        and rendering/SVG* respectively.  Fix Xcode project and
        CMakeLists.txt to account for the moves.

        * CMakeLists.txt:
        * WebCore.xcodeproj/project.pbxproj:
        * kcanvas/RenderForeignObject.cpp: Removed.
        * kcanvas/RenderForeignObject.h: Removed.
        * kcanvas/RenderPath.cpp: Removed.
        * kcanvas/RenderPath.h: Removed.
        * kcanvas/RenderSVGContainer.cpp: Removed.
        * kcanvas/RenderSVGContainer.h: Removed.
        * kcanvas/RenderSVGImage.cpp: Removed.
        * kcanvas/RenderSVGImage.h: Removed.
        * kcanvas/RenderSVGInline.cpp: Removed.
        * kcanvas/RenderSVGInline.h: Removed.
        * kcanvas/RenderSVGInlineText.cpp: Removed.
        * kcanvas/RenderSVGInlineText.h: Removed.
        * kcanvas/RenderSVGTSpan.cpp: Removed.
        * kcanvas/RenderSVGTSpan.h: Removed.
        * kcanvas/RenderSVGText.cpp: Removed.
        * kcanvas/RenderSVGText.h: Removed.
        * kcanvas/SVGInlineFlowBox.cpp: Removed.
        * kcanvas/SVGInlineFlowBox.h: Removed.
        * kcanvas/SVGRootInlineBox.cpp: Removed.
        * kcanvas/SVGRootInlineBox.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBuild fix.
thatcher [Tue, 24 Oct 2006 22:37:06 +0000 (22:37 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders.
thatcher [Tue, 24 Oct 2006 22:34:40 +0000 (22:34 +0000)]
    Reviewed by Anders.

        <rdar://problem/4588878> 'WebHTMLView' may not respond to '-_webView'

        * Misc/WebNSViewExtras.h:
        * Misc/WebNSViewExtras.m:
        (-[NSView _webView]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rolling back in, now fixed:
ggaren [Tue, 24 Oct 2006 22:24:18 +0000 (22:24 +0000)]
    Rolling back in, now fixed:

        Nixed a few more redundant loading functions in Frame. Did my best to update
        the non-Mac builds.

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::urlSelected): Kept always 'true' argument for userGesture
        always 'true', because changing it broke the world, and testing seems to
        indicate that the one caller that might have passed 'false' didn't need to.
        * page/Frame.cpp:
        (WebCore::Frame::requestFrame):
        (WebCore::Frame::frameLoader):
        (WebCore::Frame::redirectionTimerFired):
        * page/Frame.h:
        * platform/gdk/FrameGdk.cpp:
        * platform/gdk/FrameGdk.h:
        * platform/gdk/TemporaryLinkStubs.cpp:
        (FrameGdk::issueCopyCommand):
        * platform/qt/FrameQt.cpp:
        * platform/qt/FrameQt.h:
        * platform/win/TemporaryLinkStubs.cpp:
        (WebCore::FrameWin::shouldInterruptJavaScript):
        (WebCore::FrameWin::issueCopyCommand):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-10-24 Anders Carlsson <acarlsson@apple.com>
andersca [Tue, 24 Oct 2006 22:06:28 +0000 (22:06 +0000)]
2006-10-24  Anders Carlsson  <acarlsson@apple.com>

        Fix the build (Update for changes to ResourceLoader)

        * platform/network/cf/ResourceLoaderCFNet.cpp:
        (WebCore::addHeadersFromHashMap):
        (WebCore::ResourceLoader::start):
        (WebCore::ResourceLoader::cancel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mitz.
weinig [Tue, 24 Oct 2006 21:57:42 +0000 (21:57 +0000)]
    Reviewed by Mitz.

        Change #includes using <kcanvas/*.h> to use "*.h" instead
        to prepare for moving the kcanvas files.

        * kcanvas/RenderSVGContainer.h:
        * ksvg2/svg/SVGAElement.cpp:
        * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
        * ksvg2/svg/SVGFETileElement.cpp:
        * ksvg2/svg/SVGStyledLocatableElement.cpp:
        * ksvg2/svg/SVGStyledTransformableElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
mjs [Tue, 24 Oct 2006 21:53:08 +0000 (21:53 +0000)]
    Reviewed by Darin.

        - More movement towards the final network API.

        Changed ResourceLoader::create to take a ResurceRequest and start
        the load. Removed methods relating to setting request
        headers. Removed methods relating to metaData. Added some more
        convenience methods to ResourceRequest.

        * dom/XMLTokenizer.cpp:
        (WebCore::openFunc):
        * loader/LoaderFunctions.h:
        * loader/icon/IconLoader.cpp:
        (IconLoader::startLoading):
        (IconLoader::didFinishLoading):
        * loader/icon/IconLoader.h:
        * loader/loader.cpp:
        (WebCore::Loader::servePendingRequests):
        * loader/mac/LoaderFunctionsMac.mm:
        (WebCore::ServeSynchronousRequest):
        * platform/gdk/FrameGdk.cpp:
        (WebCore::FrameGdkClientDefault::openURL):
        (WebCore::FrameGdkClientDefault::submitForm):
        * platform/network/ResourceLoader.cpp:
        (WebCore::ResourceLoader::ResourceLoader):
        (WebCore::ResourceLoader::create):
        (WebCore::ResourceLoader::responseHTTPHeadersAsString):
        (WebCore::ResourceLoader::url):
        (WebCore::ResourceLoader::postData):
        (WebCore::ResourceLoader::method):
        (WebCore::ResourceLoader::client):
        * platform/network/ResourceLoader.h:
        * platform/network/ResourceLoaderInternal.h:
        (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
        * platform/network/ResourceRequest.h:
        (WebCore::ResourceRequest::ResourceRequest):
        (WebCore::ResourceRequest::httpAccept):
        (WebCore::ResourceRequest::setHTTPAccept):
        (WebCore::ResourceRequest::addHTTPHeaderFields):
        * platform/network/mac/ResourceLoaderMac.mm:
        (WebCore::ResourceLoader::start):
        (WebCore::ResourceLoader::receivedResponse):
        * platform/qt/FrameQtClient.cpp:
        (WebCore::FrameQtClientDefault::openURL):
        (WebCore::FrameQtClientDefault::submitForm):
        * platform/win/TemporaryLinkStubs.cpp:
        (WebCore::ResourceLoader::retrieveResponseEncoding):
        * xml/XSLTProcessor.cpp:
        (WebCore::docLoaderFunc):
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::send):
        (WebCore::XMLHttpRequest::didFinishLoading):
        (WebCore::XMLHttpRequest::didReceiveData):
        * xml/xmlhttprequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-10-24 Anders Carlsson <acarlsson@apple.com>
andersca [Tue, 24 Oct 2006 21:26:46 +0000 (21:26 +0000)]
2006-10-24  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        * loader/FormData.cpp:
        (WebCore::FormData::FormData):
        * loader/FormData.h:
        (WebCore::FormData::FormData):
        Add new constructor that takes a void* and a size.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBuild fix for un-initialized var.
thatcher [Tue, 24 Oct 2006 21:25:25 +0000 (21:25 +0000)]
Build fix for un-initialized var.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders
beidson [Tue, 24 Oct 2006 21:24:20 +0000 (21:24 +0000)]
    Reviewed by Anders

        http://bugs.webkit.org/show_bug.cgi?id=11406 - Crash in [WebFrame dataSource]
        In the transition to ObjC++ we lost alot of our free nil checking that we must now do manually
        to prevent null dereferencing.

        * WebView/WebFrame.mm:
        (-[WebFrame provisionalDataSource]):
        (-[WebFrame dataSource]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rolling out my last change because it broke the world.
ggaren [Tue, 24 Oct 2006 21:14:25 +0000 (21:14 +0000)]
    Rolling out my last change because it broke the world.

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::openURL):
        (WebCore::FrameMac::openURLRequest):
        (WebCore::FrameMac::urlSelected):
        * page/Frame.cpp:
        (WebCore::Frame::openURL):
        (WebCore::Frame::frameLoader):
        (WebCore::Frame::requestFrame):
        (WebCore::Frame::redirectionTimerFired):
        * page/Frame.h:
        * platform/gdk/FrameGdk.cpp:
        (WebCore::FrameGdk::openURL):
        * platform/gdk/FrameGdk.h:
        * platform/gdk/TemporaryLinkStubs.cpp:
        * platform/qt/FrameQt.cpp:
        (WebCore::FrameQt::openURL):
        (WebCore::FrameQt::openURLRequest):
        * platform/qt/FrameQt.h:
        * platform/win/TemporaryLinkStubs.cpp:
        (WebCore::FrameWin::openURL):
        (WebCore::FrameWin::openURLRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBuild fixes for 64-bit.
thatcher [Tue, 24 Oct 2006 20:50:14 +0000 (20:50 +0000)]
Build fixes for 64-bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady.
kmccullo [Tue, 24 Oct 2006 20:46:03 +0000 (20:46 +0000)]
    Reviewed by Brady.

        - Fixes a date formatting issue on win.  Specifically strftime cannot handle some ranges of time so we shift time call strftime and then manipulate the returned string, if needed.

        * kjs/date_object.cpp:
        (KJS::):
        (KJS::formatLocaleDate):
        (KJS::DateProtoFunc::callAsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-10-24 Nikolas Zimmermann <zimmermann@kde.org>
bdash [Tue, 24 Oct 2006 20:03:17 +0000 (20:03 +0000)]
2006-10-24  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by Adam.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11396
        Kill KRenderingFillPainter/KRenderingStrokePainter. Those are not needed
        anymore, since kcanvas/ksvg2 are tightly integrated. No LayoutTests fixed
        or broken.

        * CMakeLists.txt:
        * WebCore.xcodeproj/project.pbxproj:
        * kcanvas/KCanvasTreeDebug.cpp:
        (WebCore::operator<<):
        (WebCore::writeStyle):
        * kcanvas/RenderPath.cpp:
        (WebCore::RenderPath::fillContains):
        * kcanvas/device/KRenderingFillPainter.cpp:
        * kcanvas/device/KRenderingFillPainter.h:
        * kcanvas/device/KRenderingStrokePainter.cpp:
        * kcanvas/device/KRenderingStrokePainter.h:
        * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
        (WebCore::KRenderingPaintServerLinearGradientQt::setup):
        (WebCore::KRenderingPaintServerRadialGradientQt::setup):
        * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
        * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
        (WebCore::KRenderingPaintServerQt::setPenProperties):
        * kcanvas/device/qt/KRenderingPaintServerQt.h:
        * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
        (WebCore::KRenderingPaintServerSolidQt::setup):
        * kcanvas/device/qt/RenderPathQt.cpp:
        (WebCore::getPathStroke):
        (WebCore::RenderPath::strokeBBox):
        * kcanvas/device/quartz/KCanvasItemQuartz.mm:
        (WebCore::RenderPath::strokeBBox):
        * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
        * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
        * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
        (WebCore::KRenderingPaintServerQuartzHelper::fillPath):
        (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
        * kcanvas/device/quartz/QuartzSupport.h:
        (WebCore::CGLineCapFromKC):
        (WebCore::CGLineJoinFromKC):
        * kcanvas/device/quartz/QuartzSupport.mm:
        (WebCore::applyStrokeStyleToContext):
        (WebCore::strokeBoundingBox):
        * ksvg2/css/SVGCSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applySVGProperty):
        * ksvg2/css/SVGRenderStyle.h:
        (WebCore::SVGRenderStyle::InheritedFlags::):
        * ksvg2/css/SVGRenderStyleDefs.h:
        * ksvg2/misc/KCanvasRenderingStyle.cpp:
        (WebCore::KSVGPainterFactory::dashArrayFromRenderingStyle):
        * ksvg2/misc/KCanvasRenderingStyle.h:
        * ksvg2/svg/SVGFEImageElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders.
ggaren [Tue, 24 Oct 2006 19:17:06 +0000 (19:17 +0000)]
    Reviewed by Anders.

        Nixed a few more redundant loading functions in Frame. Did my best to update
        the non-Mac builds.

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::urlSelected): Changed always 'true' argument for userGesture
        to actually check for a user gesture. New callers rely on this behavior,
        and it seems like the previous behavior must have been a bug.
        * page/Frame.cpp:
        (WebCore::Frame::requestFrame):
        (WebCore::Frame::frameLoader):
        (WebCore::Frame::redirectionTimerFired):
        * page/Frame.h:
        * platform/gdk/FrameGdk.cpp:
        * platform/gdk/FrameGdk.h:
        * platform/gdk/TemporaryLinkStubs.cpp:
        (FrameGdk::issueCopyCommand):
        * platform/qt/FrameQt.cpp:
        * platform/qt/FrameQt.h:
        * platform/win/TemporaryLinkStubs.cpp:
        (WebCore::FrameWin::shouldInterruptJavaScript):
        (WebCore::FrameWin::issueCopyCommand):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin
sullivan [Tue, 24 Oct 2006 19:14:30 +0000 (19:14 +0000)]
    Reviewed by Darin

        Initial plumbing for grammar checking. No actual grammar are checked at this time.

        * English.lproj/WebViewEditingContextMenu.nib/classes.nib:
        * English.lproj/WebViewEditingContextMenu.nib/info.nib:
        * English.lproj/WebViewEditingContextMenu.nib/objects.nib:
        Added grammar-checking item, reworded to match changes in framework. This will be used
        post-Tiger.

        * English.lproj/WebViewEditingContextMenuOld.nib/classes.nib: Added.
        * English.lproj/WebViewEditingContextMenuOld.nib/info.nib: Added.
        * English.lproj/WebViewEditingContextMenuOld.nib/objects.nib: Added.
        Copy of WebViewEditingContextMenu.nib, unchanged. This will be used on Tiger.

        * DefaultDelegates/WebDefaultContextMenuDelegate.m:
        (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
        Choose the right context menu based on BUILDING_ON_TIGER.

        * WebView/WebPreferenceKeysPrivate.h:
        declare grammar-related NSUserDefault value

        * WebView/WebViewPrivate.h:
        declare grammar-related methods

        * WebView/WebView.mm:
        declare static BOOL grammarCheckingEnabled
        (-[WebViewPrivate init]):
        initialize grammarCheckingEnabled to NSUserDefaults value
        (-[WebView validateUserInterfaceItem:]):
        validate toggleGrammarChecking: menu item
        (-[WebView isGrammarCheckingEnabled]):
        return value of grammarCheckingEnabled
        (-[WebView setGrammarCheckingEnabled:]):
        set value of grammarCheckingEnabled, call frame to remove existing bad grammar markers
        (-[WebView toggleGrammarChecking:]):
        flip the value

        * WebView/WebFrameInternal.h:
        * WebView/WebFrame.mm:
        (-[WebFrame _unmarkAllBadGrammar]):
        new placeholder method, does nothing yet

        * WebView/WebHTMLViewInternal.h:
        declare grammar-related methods

        * WebView/WebHTMLView.m:
        (-[NSArray validateUserInterfaceItem:]):
        validate toggleGrammarChecking: menu item
        (-[WebHTMLView isGrammarCheckingEnabled]):
        new method, calls through to WebView
        (-[WebHTMLView setGrammarCheckingEnabled:]):
        ditto
        (-[WebHTMLView toggleGrammarChecking:]):
        ditto

        * English.lproj/StringsNotToBeLocalized.txt:
        Updated for these changes

        * WebKit.xcodeproj/project.pbxproj:
        updated for new files

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
weinig [Tue, 24 Oct 2006 13:10:10 +0000 (13:10 +0000)]
WebCore:

        Reviewed by Maciej.

        Fix Qt/Linux build.

        - Remove BrowserExtensionQt, move it's methods to Page/FrameQt.
        - Fix CMakeLists.txt to include platform/network.

        * CMakeLists.txt:
        * platform/qt/BrowserExtensionQt.cpp: Removed.
        * platform/qt/BrowserExtensionQt.h: Removed.
        * platform/qt/FrameQt.cpp:
        (WebCore::FrameQt::FrameQt):
        (WebCore::FrameQt::createNewWindow):
        (WebCore::FrameQt::goBackOrForward):
        (WebCore::FrameQt::historyURL):
        (WebCore::FrameQt::getHistoryLength):
        * platform/qt/FrameQt.h:
        * platform/qt/PageQt.cpp:
        (WebCore::Page::canRunModal):
        (WebCore::Page::canRunModalNow):
        (WebCore::Page::runModal):

WebKitQt:

        Reviewed by Maciej.

        Fix Qt/Linux build.

        - Remove BrowserExtensionQt, move it's methods to Page/FrameQt.
        - Fix CMakeLists.txt to include platform/network.

        * QtLauncher/CMakeLists.txt:
        * WebKitPart/CMakeLists.txt:

WebKitTools:

        Reviewed by Maciej.

        Fix Qt/Linux build.

        - Remove BrowserExtensionQt, move it's methods to Page/FrameQt.
        - Fix CMakeLists.txt to include platform/network.

        * DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim H.
weinig [Tue, 24 Oct 2006 13:06:16 +0000 (13:06 +0000)]
    Reviewed by Tim H.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=11314
        Fix build when XSLT_SUPPORT is not defined

        Fix unconditional use of XSLT support.

        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::end):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-10-24 Simon Hausmann <hausmann@kde.org>
bdash [Tue, 24 Oct 2006 11:26:21 +0000 (11:26 +0000)]
2006-10-24  Simon Hausmann  <hausmann@kde.org>

        Reviewed by Darin.

        * CMakeLists.txt: Added project name to kde4_automoc macro, as
          required by the latest KDE4 cmake module.

2006-10-24  Simon Hausmann  <hausmann@kde.org>

        Reviewed by Darin.

        * QtLauncher/CMakeLists.txt, WebKitPart/CMakeLists.txt: Added project name to
          kde4_automoc macro, as required by the latest KDE4 cmake module.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-10-24 David Smith <catfish.man@gmail.com>
bdash [Tue, 24 Oct 2006 11:19:30 +0000 (11:19 +0000)]
2006-10-24  David Smith  <catfish.man@gmail.com>

        Reviewed by Tim H.

        Bug 11382: [Drosera] Dragging breakpoints onto each other can mess up inline editor
        http://bugs.webkit.org/show_bug.cgi?id=11382

        * Drosera/debugger.js: Breakpoint dragging now ensures that editors aren't orphaned.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-10-24 Mitz Pettel <mitz@webkit.org>
bdash [Tue, 24 Oct 2006 11:15:36 +0000 (11:15 +0000)]
2006-10-24  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Tim H.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11394
          HTMLViewSourceDocuments are leaking

        * html/HTMLViewSourceDocument.h: Changed RefPtr to plain pointer to avoid
        ref cycle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ggaren [Tue, 24 Oct 2006 08:49:55 +0000 (08:49 +0000)]
    Reviewed by Darin.

        Removed one of Frame's redundant urlSelected methods.

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::urlSelected):
        since it's unused.
        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::defaultEventHandler): Changed DeprecatedString
        to String because the former is deprecated and its performance is irrelevant
        here. Added call to completeURL because Frame no longer does it for us.
        Having the call here also improves clarity about the element's behavior.
        * ksvg2/svg/SVGAElement.cpp:
        (WebCore::SVGAElement::defaultEventHandler): ditto. Also removed bizarre
        irrelevent NULL checks on ownerDocument() because I couldn't help myself.
        * page/Frame.cpp:
        (WebCore::Frame::changeLocation):
        (WebCore::Frame::urlSelected):
        * page/Frame.h:
        * platform/network/ResourceRequest.h: Removed explicit keyword on constructor
        because we want to be able to use these constructors instead of helper functions
        mimicking their behavior sprinkled across different classes.
        (WebCore::ResourceRequest::ResourceRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej
beidson [Tue, 24 Oct 2006 07:59:07 +0000 (07:59 +0000)]
    Reviewed by Maciej

        Moved FrameLoader from WebCoreFrameBridge to Frame.  Frame.h/cpp have generic accessors to the FrameLoader itself
        and creation/deletion is currently managed in FrameMac.mm

        Besides explicitly commented-upon methods, most of the touched code simply changes to get the FrameLoader from the
        frame instead of the bridge.

        The method [WebCoreFrameBridge frameLoader] remains but only for WebKit's use - No new WebCore code should make
        use of it as its days are numbered!

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::FrameMac): Create the FrameLoader
        (WebCore::FrameMac::~FrameMac): Nuke it
        (WebCore::FrameMac::loadRequest):

        * bridge/mac/WebCoreFrameBridge.h: No longer holds an m_frameLoader
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]): No longer creates the FrameLoader
        (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]): Ditto
        (-[WebCoreFrameBridge clearFrame]): No longer tears down the FrameLoader
        (-[WebCoreFrameBridge setFrameLoaderClient:]):
        (-[WebCoreFrameBridge frameLoader]):
        (-[WebCoreFrameBridge setTitle:]):
        (-[WebCoreFrameBridge didFirstLayout]):
        (-[WebCoreFrameBridge notifyIconChanged:]):
        (-[WebCoreFrameBridge originalRequestURL]):
        (-[WebCoreFrameBridge isLoadTypeReload]):
        (-[WebCoreFrameBridge frameDetached]):
        (-[WebCoreFrameBridge tokenizerProcessedData]):
        (-[WebCoreFrameBridge receivedData:textEncodingName:]):
        (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
        (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
        (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
        (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
        (-[WebCoreFrameBridge incomingReferrer]):
        (-[WebCoreFrameBridge isReloading]):
        (-[WebCoreFrameBridge handledOnloadEvents]):
        (-[WebCoreFrameBridge mainResourceURLResponse]):
        (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):

        * loader/mac/WebDocumentLoader.mm:
        (WebCore::DocumentLoader::frameLoader):

        * loader/mac/WebFrameLoader.mm:
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::stopLoadingSubframes):
        (WebCore::FrameLoader::defersCallbacksChanged):
        (WebCore::FrameLoader::setState):
        (WebCore::FrameLoader::closeOldDataSources):
        (WebCore::FrameLoader::subframeIsLoading):
        (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
        (WebCore::FrameLoader::post):
        (WebCore::FrameLoader::detachChildren):
        (WebCore::FrameLoader::checkLoadComplete):

        * loader/mac/WebLoader.mm:
        (WebCore::WebResourceLoader::frameLoader):

        * loader/mac/WebSubresourceLoader.mm:
        (-[WebCoreSubresourceHandle initWithLoader:]):

        * page/Frame.cpp:
        (WebCore::Frame::frameLoader):
        * page/Frame.h:
        * page/FramePrivate.h:
        (WebCore::FramePrivate::FramePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Tue, 24 Oct 2006 07:33:59 +0000 (07:33 +0000)]
    Reviewed by Maciej.

        - fixed two crashes in layout tests I just introduced

        * loader/mac/WebFrameLoader.mm:
        (WebCore::FrameLoader::load): Add null check.
        (WebCore::FrameLoader::setState): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
darin [Tue, 24 Oct 2006 06:19:43 +0000 (06:19 +0000)]
WebCore:

        Reviewed by Geoff.

        - converted WebDocumentLoader to C++

        * WebCore.exp:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge setTitle:]):
        (-[WebCoreFrameBridge originalRequestURL]):
        (-[WebCoreFrameBridge receivedData:textEncodingName:]):
        (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
        (-[WebCoreFrameBridge incomingReferrer]):
        (-[WebCoreFrameBridge isReloading]):
        (-[WebCoreFrameBridge mainResourceURLResponse]):
        * loader/mac/WebDocumentLoader.h:
        * loader/mac/WebDocumentLoader.mm:
        (WebCore::DocumentLoader::DocumentLoader):
        (WebCore::DocumentLoader::frameLoader):
        (WebCore::DocumentLoader::~DocumentLoader):
        (WebCore::DocumentLoader::setMainResourceData):
        (WebCore::DocumentLoader::mainResourceData):
        (WebCore::DocumentLoader::originalRequest):
        (WebCore::DocumentLoader::originalRequestCopy):
        (WebCore::DocumentLoader::request):
        (WebCore::DocumentLoader::initialRequest):
        (WebCore::DocumentLoader::actualRequest):
        (WebCore::DocumentLoader::URL):
        (WebCore::DocumentLoader::unreachableURL):
        (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
        (WebCore::DocumentLoader::setRequest):
        (WebCore::DocumentLoader::setResponse):
        (WebCore::DocumentLoader::isStopping):
        (WebCore::DocumentLoader::bridge):
        (WebCore::DocumentLoader::setMainDocumentError):
        (WebCore::DocumentLoader::mainDocumentError):
        (WebCore::DocumentLoader::clearErrors):
        (WebCore::DocumentLoader::mainReceivedError):
        (WebCore::DocumentLoader::stopLoading):
        (WebCore::DocumentLoader::setupForReplace):
        (WebCore::DocumentLoader::commitIfReady):
        (WebCore::DocumentLoader::finishedLoading):
        (WebCore::DocumentLoader::setCommitted):
        (WebCore::DocumentLoader::isCommitted):
        (WebCore::DocumentLoader::setLoading):
        (WebCore::DocumentLoader::isLoading):
        (WebCore::DocumentLoader::commitLoad):
        (WebCore::DocumentLoader::doesProgressiveLoad):
        (WebCore::DocumentLoader::receivedData):
        (WebCore::DocumentLoader::setupForReplaceByMIMEType):
        (WebCore::DocumentLoader::updateLoading):
        (WebCore::DocumentLoader::response):
        (WebCore::DocumentLoader::setFrame):
        (WebCore::DocumentLoader::attachToFrame):
        (WebCore::DocumentLoader::detachFromFrame):
        (WebCore::DocumentLoader::prepareForLoadStart):
        (WebCore::DocumentLoader::loadingStartedTime):
        (WebCore::DocumentLoader::setIsClientRedirect):
        (WebCore::DocumentLoader::isClientRedirect):
        (WebCore::DocumentLoader::setPrimaryLoadComplete):
        (WebCore::DocumentLoader::isLoadingInAPISense):
        (WebCore::DocumentLoader::addResponse):
        (WebCore::DocumentLoader::stopRecordingResponses):
        (WebCore::DocumentLoader::title):
        (WebCore::DocumentLoader::setLastCheckedRequest):
        (WebCore::DocumentLoader::lastCheckedRequest):
        (WebCore::DocumentLoader::triggeringAction):
        (WebCore::DocumentLoader::setTriggeringAction):
        (WebCore::DocumentLoader::responses):
        (WebCore::DocumentLoader::setOverrideEncoding):
        (WebCore::DocumentLoader::overrideEncoding):
        (WebCore::DocumentLoader::setTitle):
        (WebCore::DocumentLoader::URLForHistory):
        * loader/mac/WebFrameLoader.h:
        * loader/mac/WebFrameLoader.mm:
        (WebCore::FrameLoader::setupForReplaceByMIMEType):
        (WebCore::FrameLoader::finalSetupForReplace):
        (WebCore::FrameLoader::safeLoad):
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::startLoading):
        (WebCore::FrameLoader::stopLoading):
        (WebCore::FrameLoader::activeDocumentLoader):
        (WebCore::FrameLoader::addPlugInStreamLoader):
        (WebCore::FrameLoader::removePlugInStreamLoader):
        (WebCore::FrameLoader::addSubresourceLoader):
        (WebCore::FrameLoader::removeSubresourceLoader):
        (WebCore::FrameLoader::setDocumentLoader):
        (WebCore::FrameLoader::documentLoader):
        (WebCore::FrameLoader::setPolicyDocumentLoader):
        (WebCore::FrameLoader::provisionalDocumentLoader):
        (WebCore::FrameLoader::setProvisionalDocumentLoader):
        (WebCore::FrameLoader::setState):
        (WebCore::FrameLoader::clearProvisionalLoad):
        (WebCore::FrameLoader::commitProvisionalLoad):
        (WebCore::FrameLoader::didReceiveResponse):
        (WebCore::FrameLoader::originalRequest):
        (WebCore::FrameLoader::receivedMainResourceError):
        (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
        (WebCore::FrameLoader::opened):
        (WebCore::FrameLoader::initialRequest):
        (WebCore::FrameLoader::receivedData):
        (WebCore::FrameLoader::setRequest):
        (WebCore::FrameLoader::isStopping):
        (WebCore::FrameLoader::setResponse):
        (WebCore::FrameLoader::mainReceivedError):
        (WebCore::FrameLoader::finishedLoading):
        (WebCore::FrameLoader::notifyIconChanged):
        (WebCore::FrameLoader::URL):
        (WebCore::FrameLoader::checkContentPolicy):
        (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
        (WebCore::FrameLoader::reloadAllowingStaleData):
        (WebCore::FrameLoader::reload):
        (WebCore::FrameLoader::finishedLoadingDocument):
        (WebCore::FrameLoader::committedLoad):
        (WebCore::FrameLoader::revertToProvisional):
        (WebCore::FrameLoader::setMainDocumentError):
        (WebCore::FrameLoader::mainReceivedCompleteError):
        (WebCore::FrameLoader::subframeIsLoading):
        (WebCore::FrameLoader::willChangeTitle):
        (WebCore::FrameLoader::didChangeTitle):
        (WebCore::FrameLoader::checkNavigationPolicy):
        (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
        (WebCore::FrameLoader::transitionToCommitted):
        (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
        (WebCore::FrameLoader::detachFromParent):
        * loader/mac/WebFrameLoaderClient.h:

WebKit:

        Reviewed by Geoff.

        - converted WebDocumentLoader to C++

        * Plugins/WebPluginController.mm:
        (-[WebPluginController pluginView:receivedResponse:]):
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebDataSource.mm:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _mainDocumentError]):
        (-[WebDataSource _URL]):
        (-[WebDataSource _loadFromPageCache:]):
        (-[WebDataSource _bridge]):
        (-[WebDataSource _URLForHistory]):
        (-[WebDataSource _documentLoader]):
        (-[WebDataSource _initWithDocumentLoader:]):
        (-[WebDataSource initWithRequest:]):
        (-[WebDataSource data]):
        (-[WebDataSource webFrame]):
        (-[WebDataSource initialRequest]):
        (-[WebDataSource request]):
        (-[WebDataSource response]):
        (-[WebDataSource textEncodingName]):
        (-[WebDataSource isLoading]):
        (-[WebDataSource unreachableURL]):
        (-[WebDataSource webArchive]):
        * WebView/WebDataSourceInternal.h:
        * WebView/WebDocumentLoaderMac.h:
        * WebView/WebDocumentLoaderMac.mm:
        (WebDocumentLoaderMac::WebDocumentLoaderMac):
        (WebDocumentLoaderMac::setDataSource):
        (WebDocumentLoaderMac::dataSource):
        (WebDocumentLoaderMac::attachToFrame):
        (WebDocumentLoaderMac::detachFromFrame):
        * WebView/WebFrame.mm:
        (-[WebFrame _createItem:]):
        (-[WebFrame _loadItem:withLoadType:]):
        (-[WebFrame _addChild:]):
        (dataSource):
        (-[WebFrame _dataSourceForDocumentLoader:]):
        (-[WebFrame _addDocumentLoader:toUnarchiveState:]):
        (-[WebFrame loadArchive:]):
        (-[WebFrame _updateHistoryForReload]):
        (-[WebFrame _updateHistoryForStandardLoad]):
        (-[WebFrame _updateHistoryForInternalLoad]):
        (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]):
        (-[WebFrame _dispatchResource:willSendRequest:redirectResponse:fromDocumentLoader:]):
        (-[WebFrame _dispatchDidReceiveAuthenticationChallenge:forResource:fromDocumentLoader:]):
        (-[WebFrame _dispatchDidCancelAuthenticationChallenge:forResource:fromDocumentLoader:]):
        (-[WebFrame _dispatchResource:didReceiveResponse:fromDocumentLoader:]):
        (-[WebFrame _dispatchResource:didReceiveContentLength:fromDocumentLoader:]):
        (-[WebFrame _dispatchResource:didFinishLoadingFromDocumentLoader:]):
        (-[WebFrame _dispatchResource:didFailLoadingWithError:fromDocumentLoader:]):
        (-[WebFrame _dispatchDidLoadMainResourceForDocumentLoader:]):
        (-[WebFrame _clearLoadingFromPageCacheForDocumentLoader:]):
        (-[WebFrame _isDocumentLoaderLoadingFromPageCache:]):
        (-[WebFrame _makeRepresentationForDocumentLoader:]):
        (-[WebFrame _revertToProvisionalStateForDocumentLoader:]):
        (-[WebFrame _setMainDocumentError:forDocumentLoader:]):
        (-[WebFrame _clearUnarchivingStateForLoader:]):
        (-[WebFrame _willChangeTitleForDocument:]):
        (-[WebFrame _didChangeTitleForDocument:]):
        (-[WebFrame _finishedLoadingDocument:]):
        (-[WebFrame _committedLoadWithDocumentLoader:data:]):
        (-[WebFrame _documentLoader:setMainDocumentError:]):
        (-[WebFrame _finalSetupForReplaceWithDocumentLoader:]):
        (-[WebFrame _createDocumentLoaderWithRequest:]):
        (-[WebFrame _provisionalLoadStarted]):
        * WebView/WebFrameInternal.h:
        * WebView/WebHTMLRepresentation.m:
        (-[WebHTMLRepresentation title]):
        * WebView/WebView.mm:
        (-[WebView _mainFrameOverrideEncoding]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago RS by Maciej.
ggaren [Tue, 24 Oct 2006 05:13:40 +0000 (05:13 +0000)]
    RS by Maciej.

        Gave ObjC++ files .mm extension instead of .m.

        * WebCoreSupport/WebPageBridge.m: Removed.
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebDocumentLoaderMac.m: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Lovingly reviewed by Maciej
beidson [Tue, 24 Oct 2006 04:59:00 +0000 (04:59 +0000)]
    Lovingly reviewed by Maciej

        Moved loadURL and postURL logic out of WebCoreFrameBridge to FrameMac::loadRequest
        This is a big step towards moving FrameLoader out of the Bridge into Frame/Mac itself

        * bridge/mac/BrowserExtensionMac.mm:
        (WebCore::BrowserExtensionMac::createNewWindow): Use FrameMac::loadRequest

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::loadRequest): loadURL and postURL logic moved from WebCoreFrameBridge to here

        * bridge/mac/WebCoreFrameBridge.h: Nuked loadURL and postURL
        * bridge/mac/WebCoreFrameBridge.mm: Ditto
        * loader/mac/WebFrameLoader.mm:
        (-[WebFrameLoader safeLoadURL:]): Use FrameMac::loadRequest

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago RS by Maciej.
ggaren [Tue, 24 Oct 2006 04:45:39 +0000 (04:45 +0000)]
    RS by Maciej.

        Inside Frame, moved the plethora of load() and stopLoading() functions next
        to each other to facilitate merging and crying.

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::loadRequest):
        (WebCore::FrameMac::submitForm):
        (WebCore::FrameMac::openURL):
        (WebCore::FrameMac::openURLRequest):
        (WebCore::FrameMac::urlSelected):
        (WebCore::FrameMac::openURLFromPageCache):
        (WebCore::FrameMac::createFrame):
        * page/Frame.cpp:
        (WebCore::Frame::openURL):
        (WebCore::Frame::changeLocation):
        (WebCore::Frame::urlSelected):
        (WebCore::Frame::requestFrame):
        (WebCore::Frame::loadSubframe):
        (WebCore::Frame::submitFormAgain):
        (WebCore::Frame::submitForm):
        (WebCore::Frame::stop):
        (WebCore::Frame::closeURL):
        (WebCore::Frame::cancelRedirection):
        (WebCore::Frame::iconURL):
        (WebCore::Frame::didOpenURL):
        (WebCore::Frame::didExplicitOpen):
        * page/Frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago RS by Maciej.
ggaren [Tue, 24 Oct 2006 04:12:22 +0000 (04:12 +0000)]
    RS by Maciej.

        Moved our plethora of load() and stopLoading() functions next to each other
        to facilitate merging and laughter.

        * loader/mac/WebFrameLoader.h:
        * loader/mac/WebFrameLoader.mm:
        (WebCore::cancelAll):
        (WebCore::FrameLoader::prepareForLoadStart):
        (WebCore::FrameLoader::setupForReplace):
        (WebCore::FrameLoader::setupForReplaceByMIMEType):
        (WebCore::FrameLoader::finalSetupForReplace):
        (WebCore::FrameLoader::safeLoad):
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::startLoadingMainResource):
        (WebCore::FrameLoader::startLoading):
        (WebCore::FrameLoader::stopLoadingPlugIns):
        (WebCore::FrameLoader::stopLoadingSubresources):
        (WebCore::FrameLoader::stopLoading):
        (WebCore::FrameLoader::stopLoadingSubframes):
        (WebCore::FrameLoader::cancelMainResourceLoad):
        (WebCore::FrameLoader::cancelPendingArchiveLoad):
        (WebCore::FrameLoader::removeSubresourceLoader):
        (WebCore::FrameLoader::mainResourceData):
        (WebCore::FrameLoader::releaseMainResourceLoader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by
kmccullo [Tue, 24 Oct 2006 03:55:22 +0000 (03:55 +0000)]
    Reviewed by

       - Build fix

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/grammar.y:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
kmccullo [Tue, 24 Oct 2006 03:44:48 +0000 (03:44 +0000)]
    Reviewed by Maciej.

        - Makes the toTM function an operator.  Was going to piggy back on a patch but the patch needs more work.

        * kjs/DateMath.cpp:
        (KJS::equivalentYearForDST):
        * kjs/DateMath.h:
        (KJS::GregorianDateTime::operator tm):
        * kjs/date_object.cpp:
        (KJS::formatTime):
        (KJS::DateProtoFunc::callAsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
darin [Tue, 24 Oct 2006 03:28:02 +0000 (03:28 +0000)]
WebCore:

        Reviewed by Maciej.

        - converted WebFrameLoader to C++

        * WebCore.exp: Added many new entry points for WebKit.
        * WebCore.xcodeproj/project.pbxproj: Made more files private (SPI).

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]):
        (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]):
        (-[WebCoreFrameBridge dealloc]):
        (-[WebCoreFrameBridge close]):
        (-[WebCoreFrameBridge clearFrame]):
        (-[WebCoreFrameBridge setFrameLoaderClient:]):
        (-[WebCoreFrameBridge frameLoader]):
        (-[WebCoreFrameBridge setTitle:]):
        (-[WebCoreFrameBridge didFirstLayout]):
        (-[WebCoreFrameBridge notifyIconChanged:]):
        (-[WebCoreFrameBridge originalRequestURL]):
        (-[WebCoreFrameBridge isLoadTypeReload]):
        (-[WebCoreFrameBridge frameDetached]):
        (-[WebCoreFrameBridge tokenizerProcessedData]):
        (-[WebCoreFrameBridge receivedData:textEncodingName:]):
        (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
        (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
        (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
        (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
        (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
        (-[WebCoreFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
        (-[WebCoreFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
        (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
        (-[WebCoreFrameBridge incomingReferrer]):
        (-[WebCoreFrameBridge isReloading]):
        (-[WebCoreFrameBridge handledOnloadEvents]):
        (-[WebCoreFrameBridge mainResourceURLResponse]):
        (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
        * loader/mac/WebDocumentLoader.h:
        * loader/mac/WebDocumentLoader.mm:
        (-[WebDocumentLoader frameLoader]):
        (-[WebDocumentLoader dealloc]):
        (-[WebDocumentLoader mainResourceData]):
        (-[WebDocumentLoader setRequest:]):
        (-[WebDocumentLoader bridge]):
        (-[WebDocumentLoader setMainDocumentError:]):
        (-[WebDocumentLoader mainReceivedError:complete:]):
        (-[WebDocumentLoader stopLoading]):
        (-[WebDocumentLoader setupForReplace]):
        (-[WebDocumentLoader commitIfReady]):
        (-[WebDocumentLoader finishedLoading]):
        (-[WebDocumentLoader commitLoadWithData:]):
        (-[WebDocumentLoader doesProgressiveLoadWithMIMEType:]):
        (-[WebDocumentLoader setupForReplaceByMIMEType:]):
        (-[WebDocumentLoader updateLoading]):
        (-[WebDocumentLoader setFrame:]):
        (-[WebDocumentLoader attachToFrame]):
        (-[WebDocumentLoader detachFromFrame]):
        (-[WebDocumentLoader prepareForLoadStart]):
        (-[WebDocumentLoader setPrimaryLoadComplete:]):
        (-[WebDocumentLoader isLoadingInAPISense]):
        (-[WebDocumentLoader setTitle:]):
        * loader/mac/WebFrameLoader.h:
        (WebCore::FrameLoader::frame):
        * loader/mac/WebFrameLoader.mm:
        (WebCore::FrameLoader::FrameLoader):
        (WebCore::FrameLoader::~FrameLoader):
        (WebCore::FrameLoader::activeDocumentLoader):
        (WebCore::FrameLoader::addPlugInStreamLoader):
        (WebCore::FrameLoader::removePlugInStreamLoader):
        (WebCore::FrameLoader::defersCallbacksChanged):
        (WebCore::FrameLoader::defersCallbacks):
        (WebCore::setAllDefersCallbacks):
        (WebCore::FrameLoader::setDefersCallbacks):
        (WebCore::cancelAll):
        (WebCore::FrameLoader::stopLoadingPlugIns):
        (WebCore::FrameLoader::isLoadingMainResource):
        (WebCore::FrameLoader::isLoadingSubresources):
        (WebCore::FrameLoader::isLoadingPlugIns):
        (WebCore::FrameLoader::isLoading):
        (WebCore::FrameLoader::stopLoadingSubresources):
        (WebCore::FrameLoader::addSubresourceLoader):
        (WebCore::FrameLoader::removeSubresourceLoader):
        (WebCore::FrameLoader::mainResourceData):
        (WebCore::FrameLoader::releaseMainResourceLoader):
        (WebCore::FrameLoader::cancelMainResourceLoad):
        (WebCore::FrameLoader::startLoadingMainResource):
        (WebCore::FrameLoader::stopLoading):
        (WebCore::FrameLoader::setDocumentLoader):
        (WebCore::FrameLoader::documentLoader):
        (WebCore::FrameLoader::setPolicyDocumentLoader):
        (WebCore::FrameLoader::provisionalDocumentLoader):
        (WebCore::FrameLoader::setProvisionalDocumentLoader):
        (WebCore::FrameLoader::state):
        (WebCore::FrameLoader::timeOfLastCompletedLoad):
        (WebCore::FrameLoader::provisionalLoadStarted):
        (WebCore::FrameLoader::setState):
        (WebCore::FrameLoader::clearProvisionalLoad):
        (WebCore::FrameLoader::markLoadComplete):
        (WebCore::FrameLoader::commitProvisionalLoad):
        (WebCore::FrameLoader::stopLoadingSubframes):
        (WebCore::FrameLoader::startLoading):
        (WebCore::FrameLoader::setupForReplace):
        (WebCore::FrameLoader::identifierForInitialRequest):
        (WebCore::FrameLoader::willSendRequest):
        (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
        (WebCore::FrameLoader::didCancelAuthenticationChallenge):
        (WebCore::FrameLoader::didReceiveResponse):
        (WebCore::FrameLoader::didReceiveData):
        (WebCore::FrameLoader::didFinishLoad):
        (WebCore::FrameLoader::didFailToLoad):
        (WebCore::FrameLoader::privateBrowsingEnabled):
        (WebCore::FrameLoader::originalRequest):
        (WebCore::FrameLoader::receivedMainResourceError):
        (WebCore::FrameLoader::clientRedirectCancelledOrFinished):
        (WebCore::FrameLoader::clientRedirected):
        (WebCore::FrameLoader::shouldReload):
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
        (WebCore::FrameLoader::closeOldDataSources):
        (WebCore::FrameLoader::opened):
        (WebCore::FrameLoader::initialRequest):
        (WebCore::FrameLoader::receivedData):
        (WebCore::FrameLoader::setRequest):
        (WebCore::FrameLoader::download):
        (WebCore::FrameLoader::bridge):
        (WebCore::FrameLoader::handleFallbackContent):
        (WebCore::FrameLoader::isStopping):
        (WebCore::FrameLoader::setupForReplaceByMIMEType):
        (WebCore::FrameLoader::setResponse):
        (WebCore::FrameLoader::mainReceivedError):
        (WebCore::FrameLoader::finishedLoading):
        (WebCore::FrameLoader::notifyIconChanged):
        (WebCore::FrameLoader::URL):
        (WebCore::FrameLoader::cancelledError):
        (WebCore::FrameLoader::fileDoesNotExistError):
        (WebCore::FrameLoader::willUseArchive):
        (WebCore::FrameLoader::isArchiveLoadPending):
        (WebCore::FrameLoader::cancelPendingArchiveLoad):
        (WebCore::FrameLoader::handleUnimplementablePolicy):
        (WebCore::FrameLoader::cannotShowMIMEType):
        (WebCore::FrameLoader::interruptionForPolicyChangeError):
        (WebCore::FrameLoader::isHostedByObjectElement):
        (WebCore::FrameLoader::isLoadingMainFrame):
        (WebCore::FrameLoader::canShowMIMEType):
        (WebCore::FrameLoader::representationExistsForURLScheme):
        (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
        (WebCore::FrameLoader::checkNavigationPolicy):
        (WebCore::FrameLoader::checkContentPolicy):
        (WebCore::FrameLoader::cancelContentPolicyCheck):
        (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
        (WebCore::FrameLoader::reloadAllowingStaleData):
        (WebCore::FrameLoader::reload):
        (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame):
        (WebCore::FrameLoader::finishedLoadingDocument):
        (WebCore::FrameLoader::committedLoad):
        (WebCore::FrameLoader::isReplacing):
        (WebCore::FrameLoader::setReplacing):
        (WebCore::FrameLoader::revertToProvisional):
        (WebCore::FrameLoader::setMainDocumentError):
        (WebCore::FrameLoader::mainReceivedCompleteError):
        (WebCore::FrameLoader::finalSetupForReplace):
        (WebCore::FrameLoader::prepareForLoadStart):
        (WebCore::FrameLoader::subframeIsLoading):
        (WebCore::FrameLoader::willChangeTitle):
        (WebCore::FrameLoader::didChangeTitle):
        (WebCore::FrameLoader::loadType):
        (WebCore::FrameLoader::invalidatePendingPolicyDecision):
        (WebCore::FrameLoader::checkNewWindowPolicy):
        (WebCore::FrameLoader::continueAfterNewWindowPolicy):
        (WebCore::FrameLoader::continueAfterNavigationPolicy):
        (WebCore::FrameLoader::continueAfterWillSubmitForm):
        (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
        (WebCore::FrameLoader::didFirstLayout):
        (WebCore::FrameLoader::frameLoadCompleted):
        (WebCore::FrameLoader::firstLayoutDone):
        (WebCore::FrameLoader::isQuickRedirectComing):
        (WebCore::FrameLoader::transitionToCommitted):
        (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
        (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
        (WebCore::FrameLoader::sendRemainingDelegateMessages):
        (WebCore::FrameLoader::requestFromDelegate):
        (WebCore::FrameLoader::post):
        (WebCore::FrameLoader::detachChildren):
        (WebCore::FrameLoader::detachFromParent):
        (WebCore::FrameLoader::addExtraFieldsToRequest):
        (WebCore::FrameLoader::safeLoad):
        (WebCore::FrameLoader::actionInformation):
        (WebCore::FrameLoader::checkLoadComplete):
        (WebCore::FrameLoader::setFrameLoaderClient):
        (WebCore::FrameLoader::client):
        (WebCore::FrameLoader::asDelegate):
        (-[WebCoreFrameLoaderAsDelegate initWithLoader:]):
        (-[WebCoreFrameLoaderAsDelegate detachFromLoader]):
        (-[WebCoreFrameLoaderAsDelegate continueFragmentScrollAfterNavigationPolicy:formState:]):
        (-[WebCoreFrameLoaderAsDelegate continueAfterNewWindowPolicy:]):
        (-[WebCoreFrameLoaderAsDelegate continueAfterNavigationPolicy:]):
        (-[WebCoreFrameLoaderAsDelegate continueAfterWillSubmitForm:]):
        (-[WebCoreFrameLoaderAsDelegate continueLoadRequestAfterNavigationPolicy:formState:]):
        (-[WebCoreFrameLoaderAsDelegate continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
        * loader/mac/WebLoader.h:
        (WebCore::WebResourceLoader::identifier):
        (WebCore::WebResourceLoader::reachedTerminalState):
        (WebCore::WebResourceLoader::cancelled):
        * loader/mac/WebLoader.mm:
        (WebCore::WebResourceLoader::WebResourceLoader):
        (WebCore::WebResourceLoader::releaseResources):
        (WebCore::WebResourceLoader::load):
        (WebCore::WebResourceLoader::frameLoader):
        (WebCore::WebResourceLoader::willSendRequest):
        (WebCore::WebResourceLoader::didReceiveAuthenticationChallenge):
        (WebCore::WebResourceLoader::didCancelAuthenticationChallenge):
        (WebCore::WebResourceLoader::didReceiveResponse):
        (WebCore::WebResourceLoader::didReceiveData):
        (WebCore::WebResourceLoader::didFinishLoading):
        (WebCore::WebResourceLoader::didFinishLoadingOnePart):
        (WebCore::WebResourceLoader::didFail):
        (WebCore::WebResourceLoader::willCacheResponse):
        (WebCore::WebResourceLoader::didCancel):
        (WebCore::WebResourceLoader::cancel):
        (WebCore::WebResourceLoader::cancelledError):
        (WebCore::WebResourceLoader::delegate):
        * loader/mac/WebMainResourceLoader.h:
        * loader/mac/WebMainResourceLoader.mm:
        (WebCore::MainResourceLoader::MainResourceLoader):
        (WebCore::MainResourceLoader::create):
        (WebCore::MainResourceLoader::receivedError):
        (WebCore::MainResourceLoader::didCancel):
        (WebCore::MainResourceLoader::interruptionForPolicyChangeError):
        (WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
        (WebCore::MainResourceLoader::addData):
        (WebCore::MainResourceLoader::willSendRequest):
        (WebCore::MainResourceLoader::continueAfterContentPolicy):
        (WebCore::MainResourceLoader::didReceiveResponse):
        (WebCore::MainResourceLoader::didReceiveData):
        (WebCore::MainResourceLoader::didFinishLoading):
        (WebCore::MainResourceLoader::didFail):
        (WebCore::MainResourceLoader::loadNow):
        (WebCore::MainResourceLoader::policyDelegate):
        * loader/mac/WebNetscapePlugInStreamLoader.h:
        * loader/mac/WebNetscapePlugInStreamLoader.mm:
        (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
        (WebCore::NetscapePlugInStreamLoader::create):
        (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
        (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
        (WebCore::NetscapePlugInStreamLoader::didFail):
        (WebCore::NetscapePlugInStreamLoader::didCancel):
        * loader/mac/WebSubresourceLoader.h:
        * loader/mac/WebSubresourceLoader.mm:
        (-[WebCoreSubresourceHandle initWithLoader:]):

WebKit:

        Reviewed by Maciej.

        - converted WebFrameLoader to C++

        * History/WebHistoryItem.m:
        (+[WebHistoryItem _closeObjectsInPendingPageCaches]):
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
        * Plugins/WebNetscapePluginStream.mm:
        (-[WebNetscapePluginStream start]):
        (-[WebNetscapePluginStream stop]):
        * Plugins/WebPluginController.mm:
        (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
        (-[WebPluginController pluginView:receivedResponse:]):
        * WebCoreSupport/WebFrameBridge.h:
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebDataSource.mm:
        (-[WebDataSource _loadFromPageCache:]):
        (-[WebDataSource _webView]):
        (-[WebDataSource webFrame]):
        * WebView/WebDocumentLoaderMac.h:
        * WebView/WebDocumentLoaderMac.m:
        (-[WebDocumentLoaderMac dealloc]):
        (-[WebDocumentLoaderMac attachToFrame]):
        (-[WebDocumentLoaderMac detachFromFrame]):
        * WebView/WebFrame.mm:
        (+[WebFrame _timeOfLastCompletedLoad]):
        (-[WebFrame _loadItem:withLoadType:]):
        (-[WebFrame _loadURL:referrer:intoChild:]):
        (-[WebFrame _currentBackForwardListItemToResetTo]):
        (-[WebFrame _itemForRestoringDocState]):
        (-[WebFrame _frameLoader]):
        (-[WebFrame _firstLayoutDone]):
        (-[WebFrame _loadType]):
        (-[WebFrame provisionalDataSource]):
        (-[WebFrame dataSource]):
        (-[WebFrame loadRequest:]):
        (-[WebFrame loadArchive:]):
        (-[WebFrame stopLoading]):
        (-[WebFrame reload]):
        (-[WebFrame _updateHistoryForCommit]):
        (-[WebFrame _updateHistoryForReload]):
        (-[WebFrame _updateHistoryForInternalLoad]):
        (-[WebFrame _deliverArchivedResourcesAfterDelay]):
        (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]):
        (-[WebFrame _deliverArchivedResources]):
        (-[WebFrame _prepareForDataSourceReplacement]):
        (-[WebFrame _provisionalLoadStarted]):
        * WebView/WebFrameInternal.h:
        * WebView/WebHTMLView.m:
        (-[WebHTMLView _clearLastHitViewIfSelf]):
        (-[WebHTMLView _updateMouseoverWithEvent:]):
        (-[NSArray removeMouseMovedObserverUnconditionally]):
        (-[NSArray removeMouseMovedObserver]):
        (-[NSArray viewWillMoveToWindow:]):
        (-[NSArray viewDidMoveToWindow]):
        (-[WebHTMLView _canMakeTextSmaller]):
        (-[WebHTMLView _canMakeTextLarger]):
        (-[WebHTMLView _canMakeTextStandardSize]):
        * WebView/WebPDFView.mm:
        (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
        * WebView/WebView.mm:
        (-[WebView _close]):
        (-[WebView setDefersCallbacks:]):
        (-[WebView setCustomTextEncodingName:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
kmccullo [Tue, 24 Oct 2006 03:18:50 +0000 (03:18 +0000)]
    Reviewed by Maciej.

       - Fixes two regressions on win.  Both are stack overflows. For one the number of regressions is capped at 100, and for the other, nested parenthesis pairs are not evaluated (since they would evaluate to whatever is in them anyway).

        * kjs/grammar.y:
        * kjs/object.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
ggaren [Tue, 24 Oct 2006 03:18:28 +0000 (03:18 +0000)]
WebCore:

        Reviewed by Bradee.

        Shrunk BrowserExtension in preparation for its imminent death, moving page-
        level operations to Page and frame-level operations to Frame.

        Removed bizarre Mac(this) syntax inside virtual FrameMac member functions,
        because 'this' is guaranteed by the compiler to be a FrameMac*.

        * bindings/js/kjs_window.cpp: Added NULL checks for m_frame in places
        where it can be NULL.
        * bindings/js/kjs_window.cpp:
        (KJS::canShowModalDialog):
        (KJS::canShowModalDialogNow):
        (KJS::showModalDialog):
        (KJS::History::getValueProperty):
        (KJS::HistoryFunc::callAsFunction):
        * bridge/BrowserExtension.h:
        (WebCore::BrowserExtension::~BrowserExtension):
        * bridge/mac/BrowserExtensionMac.h:
        * bridge/mac/BrowserExtensionMac.mm:
        (WebCore::BrowserExtensionMac::createNewWindow):
        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::frameDetached):
        (WebCore::FrameMac::unfocusWindow):
        (WebCore::FrameMac::bridgeForWidget):
        (WebCore::FrameMac::documentViewForNode):
        (WebCore::FrameMac::passSubframeEventToSubframe):
        (WebCore::Frame::setNeedsReapplyStyles):
        (WebCore::FrameMac::customHighlightLineRect):
        (WebCore::FrameMac::paintCustomHighlight):
        (WebCore::FrameMac::getHistoryLength):
        (WebCore::FrameMac::goBackOrForward):
        (WebCore::FrameMac::historyURL):
        * bridge/mac/PageMac.mm:
        (WebCore::Page::canRunModal):
        (WebCore::Page::canRunModalNow):
        (WebCore::Page::runModal):
        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCorePageBridge.h:
        * bridge/win/BrowserExtensionWin.h:
        * page/Frame.cpp:
        (WebCore::Frame::scheduleHistoryNavigation):
        (WebCore::Frame::redirectionTimerFired):
        * page/Frame.h:
        * page/Page.h:

WebKit:

        Reviewed by Bradee.

        Moved some page-level operations from WebFrameBridge to WebPageBridge.

        * WebCoreSupport/WebFrameBridge.m:
        * WebCoreSupport/WebPageBridge.m:
        (-[WebPageBridge createModalDialogWithURL:referrer:]):
        (-[WebPageBridge canRunModal]):
        (-[WebPageBridge canRunModalNow]):
        (-[WebPageBridge runModal]):
        * WebKit.xcodeproj/project.pbxproj: Made WebPageBridge.m ObjC++ to support
        WebCore #includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@17235 268f45cc-cd09-0410...
justing [Tue, 24 Oct 2006 02:36:47 +0000 (02:36 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Tue, 24 Oct 2006 02:35:42 +0000 (02:35 +0000)]
LayoutTests:

        Reviewed by mjs

        <http://bugs.webkit.org/show_bug.cgi?id=11334>
        Writely Editor: Placing caret in a list "highlights" both Numbered List and Bulleted List toolbar icons

        * editing/execCommand/queryCommandState-01-expected.txt: Added.
        * editing/execCommand/queryCommandState-01.html: Added.

WebCore:

        Reviewed by mjs

        <http://bugs.webkit.org/show_bug.cgi?id=11334>
        Writely Editor: Placing caret in a list "highlights" both Numbered List and Bulleted List toolbar icons

        * WebCore.xcodeproj/project.pbxproj:
        * editing/Editor.cpp:
        (WebCore::Editor::selectionUnorderedListState): Added.
        (WebCore::Editor::selectionOrderedListState): Added.
        * editing/Editor.h:
        * editing/JSEditor.cpp:
        * page/Frame.cpp:
        * page/Frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * WebKitPrefix.h:
sullivan [Mon, 23 Oct 2006 23:57:48 +0000 (23:57 +0000)]
    * WebKitPrefix.h:
        Removed redundant definition of BUILDING_ON_TIGER that I just added. It turns out this had
        already been added between the last time I updated in this tree and when I needed it locally.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoChecked in this file that I mentioned in the previous ChangeLog entry but forgot...
sullivan [Mon, 23 Oct 2006 23:10:45 +0000 (23:10 +0000)]
Checked in this file that I mentioned in the previous ChangeLog entry but forgot to check in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Ander
sullivan [Mon, 23 Oct 2006 23:03:56 +0000 (23:03 +0000)]
    Reviewed by Ander

        * WebKit.xcodeproj/project.pbxproj:
        Move WebKitPrefix.h from Misc group to top level, to match WebCore

        * WebKitPrefix.h:
        defined BUILDING_ON_TIGER a la WebCore, in preparation for future use of post-Tiger API

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim H
sullivan [Mon, 23 Oct 2006 22:56:18 +0000 (22:56 +0000)]
    Reviewed by Tim H

        * WebCore.xcodeproj/project.pbxproj:
        Include WebCorePrefix.h in Xcode project for convenience and for consistency with WebKit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
thatcher [Mon, 23 Oct 2006 22:40:58 +0000 (22:40 +0000)]
    Reviewed by Darin.

        Rename the now ObjC++ files to be .mm and remove the explicit file types.

        * DefaultDelegates/WebDefaultContextMenuDelegate.m:
        (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
        * English.lproj/StringsNotToBeLocalized.txt:
        * Plugins/WebBaseNetscapePluginView.m: Removed.
        * Plugins/WebNetscapePluginStream.m: Removed.
        * Plugins/WebPluginController.m: Removed.
        * WebCoreSupport/WebFrameBridge.m: Removed.
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebDataSource.m: Removed.
        * WebView/WebFrame.m: Removed.
        * WebView/WebFrameView.m: Removed.
        * WebView/WebPDFView.m: Removed.
        * WebView/WebPolicyDelegate.m: Removed.
        * WebView/WebView.m: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
thatcher [Mon, 23 Oct 2006 22:27:44 +0000 (22:27 +0000)]
    Reviewed by Darin.

        Move the undef try/catch to WebKitPrfix.h and include algorithm so we get
        exception_defines.h and so the undef of try/catch works.

        Break off the BGRA to ARGB code into WebGraphicsExtras.c, this lets
        WebBaseNetscapePluginView.m safely compile as ObjC++ and not cause the Accelerate
        framework to complain about C++ exceptions being disabled.

        * Misc/WebGraphicsExtras.c: Added.
        (WebConvertBGRAToARGB):
        * Misc/WebGraphicsExtras.h: Added.
        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
        * WebKit.xcodeproj/project.pbxproj:
        * WebKitPrefix.h:
        * WebView/WebView.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim H.
weinig [Mon, 23 Oct 2006 22:22:46 +0000 (22:22 +0000)]
    Reviewed by Tim H.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=11291
        PNG as cursor image format instead of TIFF

        Original patch by Lars Naesbye Christensen (larsnaesbye@stud.ku.dk)

        - Convert cursor images from TIFF to PNG.

        * Resources/eastResizeCursor.png: Added.
        * Resources/eastResizeCursor.tiff: Removed.
        * Resources/eastWestResizeCursor.png: Added.
        * Resources/eastWestResizeCursor.tiff: Removed.
        * Resources/helpCursor.png: Added.
        * Resources/helpCursor.tiff: Removed.
        * Resources/linkCursor.png: Added.
        * Resources/linkCursor.tiff: Removed.
        * Resources/moveCursor.png: Added.
        * Resources/moveCursor.tiff: Removed.
        * Resources/northEastResizeCursor.png: Added.
        * Resources/northEastResizeCursor.tiff: Removed.
        * Resources/northEastSouthWestResizeCursor.png: Added.
        * Resources/northEastSouthWestResizeCursor.tiff: Removed.
        * Resources/northResizeCursor.png: Added.
        * Resources/northResizeCursor.tiff: Removed.
        * Resources/northSouthResizeCursor.png: Added.
        * Resources/northSouthResizeCursor.tiff: Removed.
        * Resources/northWestResizeCursor.png: Added.
        * Resources/northWestResizeCursor.tiff: Removed.
        * Resources/northWestSouthEastResizeCursor.png: Added.
        * Resources/northWestSouthEastResizeCursor.tiff: Removed.
        * Resources/southEastResizeCursor.png: Added.
        * Resources/southEastResizeCursor.tiff: Removed.
        * Resources/southResizeCursor.png: Added.
        * Resources/southResizeCursor.tiff: Removed.
        * Resources/southWestResizeCursor.png: Added.
        * Resources/southWestResizeCursor.tiff: Removed.
        * Resources/waitCursor.png: Added.
        * Resources/waitCursor.tiff: Removed.
        * Resources/westResizeCursor.png: Added.
        * Resources/westResizeCursor.tiff: Removed.
        * WebCore.xcodeproj/project.pbxproj:
        * platform/mac/CursorMac.mm:
        (WebCore::leakNamedCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Not reviewed.
mjs [Mon, 23 Oct 2006 22:15:00 +0000 (22:15 +0000)]
    Not reviewed.

        - fixed build from last change.

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::loadRequest):
        (WebCore::FrameMac::openURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele.
aroben [Mon, 23 Oct 2006 22:00:20 +0000 (22:00 +0000)]
    Reviewed by Adele.

        Move border-radius rule for <select>s into RenderThemeMac, as this is
        really a platform-specific look.

        * css/html4.css:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::adjustMenuListButtonStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady.
mjs [Mon, 23 Oct 2006 21:44:05 +0000 (21:44 +0000)]
    Reviewed by Brady.

        - moved things around so loadURL:... is only called from one place

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::frameDetached):
        (WebCore::FrameMac::loadRequest):
        (WebCore::FrameMac::submitForm):
        (WebCore::FrameMac::openURL):
        (WebCore::FrameMac::openURLRequest):
        (WebCore::FrameMac::urlSelected):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Mon, 23 Oct 2006 21:29:49 +0000 (21:29 +0000)]
LayoutTests:

        Reviewed by john

        <http://bugs.webkit.org/show_bug.cgi?id=11333>
        Writely Editor: After inserting a HR element, pressing return key creates a copy of this HR element in the document

        * editing/inserting/insert-br-009-expected.checksum: Added.
        * editing/inserting/insert-br-009-expected.png: Added.
        * editing/inserting/insert-br-009-expected.txt: Added.
        * editing/inserting/insert-br-009.html: Added.
        * editing/inserting/insert-paragraph-01-expected.checksum: Added.
        * editing/inserting/insert-paragraph-01-expected.png: Added.
        * editing/inserting/insert-paragraph-01-expected.txt: Added.
        * editing/inserting/insert-paragraph-01.html: Added.
        * editing/inserting/insert-paragraph-02-expected.checksum: Added.
        * editing/inserting/insert-paragraph-02-expected.png: Added.
        * editing/inserting/insert-paragraph-02-expected.txt: Added.
        * editing/inserting/insert-paragraph-02.html: Added.
        * editing/inserting/insert-paragraph-03-expected.checksum: Added.
        * editing/inserting/insert-paragraph-03-expected.png: Added.
        * editing/inserting/insert-paragraph-03-expected.txt: Added.
        * editing/inserting/insert-paragraph-03.html: Added.
        * editing/inserting/insert-paragraph-04-expected.checksum: Added.
        * editing/inserting/insert-paragraph-04-expected.png: Added.
        * editing/inserting/insert-paragraph-04-expected.txt: Added.
        * editing/inserting/insert-paragraph-04.html: Added.

WebCore:

        Reviewed by john

        <http://bugs.webkit.org/show_bug.cgi?id=11333>
        Writely Editor: After inserting a HR element, pressing return key creates a copy of this HR element in the document

        Added special cases in InsertLineBreakCommand for inserting before
        and after tables and horizontal rules.  Also, perform InsertLineBreak
        instead of InsertParagraphSeparator at these positions.

        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::doApply):  Use the canonical form
        of the caret position when we check for the new special cases because
        we know that we canonicalize VisiblePositions to those positions.
        Added code to handle inserting before/after tables and horizontal rules.
        Fixed a bug when inserting at the end of a block (it checked for a collapse
        of the inserted br by looking for the absence of a br, but the line break
        might have been a '\n' in white-space:pre text).  Removed unused LOGs.
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply): Perform an
        InsertLineBreakCommand when before/after a table or a horizontal rule
        so that we don't have to maintain two pieces of special case code.
        Migrated to enclosingBlock.
        * editing/htmlediting.cpp: Added a FIXME.
        * editing/visible_units.cpp:
        (WebCore::startOfParagraph): Added a workaround for 8622.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17223 268f45cc-cd09-0410-ab3c-d52691b4dbfc