ddkilzer [Wed, 7 Jun 2006 03:14:35 +0000 (03:14 +0000)]
WebKitTools:
Reviewed by darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9322
Teach svn-create-patch to sort its output
* Scripts/svn-create-patch: Clean up perl code. Sort patch output alphabetically
by text files first, then by binary files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 7 Jun 2006 03:13:43 +0000 (03:13 +0000)]
LayoutTests:
Reviewed by Hyatt.
- repaint test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9121
REGRESSION: [Incremental Repaint] DHTML movement test failures
* fast/repaint/containing-block-position-change-expected.checksum: Added.
* fast/repaint/containing-block-position-change-expected.png: Added.
* fast/repaint/containing-block-position-change-expected.txt: Added.
* fast/repaint/containing-block-position-change.html: Added.
WebCore:
Reviewed by Hyatt.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9121
REGRESSION: [Incremental Repaint] DHTML movement test failures
Test (repaint): fast/repaint/containing-block-position-change.html
* manual-tests/containing-block-position-chage.html: Added.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock): Unrelated change: fixed typo from
the RenderCanvas to RenderView rename.
(WebCore::RenderBlock::removePositionedObject): Added a return immediately
after removing the object.
(WebCore::RenderBlock::removePositionedObjects): Added.
* rendering/RenderBlock.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::setStyle): Added code to remove absolutely positioned
descendants from the positioned objects list of their current containing block
when they are going to have a new one as a result of this block's position
property changing.
* rendering/RenderObject.h:
(WebCore::RenderObject::removePositionedObjects):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 7 Jun 2006 03:12:53 +0000 (03:12 +0000)]
* fast/repaint/table-extra-bottom-grow.html: Removed unneeded line of code.
* fast/repaint/table-extra-bottom-grow-expected.png: Regenerated.
* fast/repaint/table-extra-bottom-grow-expected.checksum: Regenerated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 7 Jun 2006 00:09:37 +0000 (00:09 +0000)]
LayoutTests:
Reviewed by levi
Added to demonstrate fixes:
* editing/pasteboard/merge-after-delete-expected.checksum: Added.
* editing/pasteboard/merge-after-delete-expected.png: Added.
* editing/pasteboard/merge-after-delete-expected.txt: Added.
* editing/pasteboard/merge-after-delete.html: Added.
* editing/inserting/line-break-expected.checksum: Added.
* editing/inserting/line-break-expected.png: Added.
* editing/inserting/line-break-expected.txt: Added.
* editing/inserting/line-break.html: Added.
* editing/inserting/multiple-lines-selected-expected.checksum: Added.
* editing/inserting/multiple-lines-selected-expected.png: Added.
* editing/inserting/multiple-lines-selected-expected.txt: Added.
* editing/inserting/multiple-lines-selected.html: Added.
Fixed:
* editing/deleting/collapse-whitespace-
3587601-fix-expected.txt:
* editing/deleting/delete-
3775172-fix-expected.txt:
* editing/deleting/delete-
3928305-fix-expected.txt:
* editing/deleting/delete-
3959464-fix-expected.checksum:
* editing/deleting/delete-
3959464-fix-expected.png:
* editing/deleting/delete-
3959464-fix-expected.txt:
* editing/deleting/delete-
4038408-fix-expected.checksum:
* editing/deleting/delete-
4038408-fix-expected.png:
* editing/deleting/delete-
4038408-fix-expected.txt:
* editing/deleting/delete-
4038408-fix.html:
* editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
* editing/deleting/delete-at-paragraph-boundaries-011-expected.checksum:
* editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
* editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
* editing/deleting/delete-block-contents-001-expected.txt:
* editing/deleting/delete-block-contents-002-expected.txt:
* editing/deleting/delete-block-contents-003-expected.txt:
* editing/deleting/delete-br-011-expected.checksum:
* editing/deleting/delete-br-011-expected.png:
* editing/deleting/delete-br-011-expected.txt:
* editing/deleting/delete-image-004-expected.txt:
* editing/deleting/delete-line-010-expected.txt:
* editing/deleting/delete-line-015-expected.txt:
* editing/deleting/delete-select-all-001-expected.checksum:
* editing/deleting/delete-select-all-001-expected.png:
* editing/deleting/delete-select-all-001-expected.txt:
* editing/deleting/delete-select-all-002-expected.txt:
* editing/deleting/delete-select-all-003-expected.checksum:
* editing/deleting/delete-select-all-003-expected.png:
* editing/deleting/delete-select-all-003-expected.txt:
* editing/execCommand/insertImage-expected.checksum:
* editing/execCommand/insertImage-expected.png:
* editing/input/attributed-substring-from-range-lines-expected.txt:
* editing/input/text-input-controller-expected.txt:
* editing/inserting/insert-
3654864-fix-expected.txt:
* editing/inserting/insert-
3659587-fix-expected.txt:
* editing/inserting/insert-
3775316-fix-expected.txt:
* editing/inserting/insert-after-delete-001-expected.txt:
* editing/inserting/insert-at-end-01-expected.txt:
* editing/inserting/insert-at-end-02-expected.txt:
* editing/inserting/insert-br-001-expected.txt:
* editing/inserting/insert-br-005-expected.txt:
* editing/pasteboard/
4076267-3-expected.txt:
* editing/pasteboard/
4076267-expected.txt:
* editing/pasteboard/drag-drop-modifies-page-expected.txt:
* editing/pasteboard/paste-
4035648-fix-expected.txt:
* editing/pasteboard/paste-
4039777-fix-expected.checksum:
* editing/pasteboard/paste-
4039777-fix-expected.png:
* editing/pasteboard/paste-
4039777-fix-expected.txt:
* editing/pasteboard/paste-match-style-001-expected.txt:
* editing/pasteboard/paste-match-style-002-expected.txt:
* editing/pasteboard/smart-paste-006-expected.txt:
* editing/pasteboard/smart-paste-007-expected.txt:
* editing/selection/drag-to-contenteditable-iframe-expected.txt:
* editing/style/block-style-005-expected.txt:
* editing/style/typing-style-002-expected.txt:
* editing/unsupported-content/list-delete-001-expected.checksum:
* editing/unsupported-content/list-delete-001-expected.png:
* editing/unsupported-content/list-delete-001-expected.txt:
* editing/unsupported-content/list-delete-002-expected.checksum:
* editing/unsupported-content/list-delete-002-expected.png:
* editing/unsupported-content/list-delete-002-expected.txt:
* editing/unsupported-content/table-delete-001-expected.checksum:
* editing/unsupported-content/table-delete-001-expected.png:
* editing/unsupported-content/table-delete-001-expected.txt:
* editing/unsupported-content/table-delete-003-expected.checksum:
* editing/unsupported-content/table-delete-003-expected.png:
* editing/unsupported-content/table-delete-003-expected.txt:
* fast/text/attributed-substring-from-range.html:
WebCore:
Reviewed by levi
* dom/Node.cpp:
(WebCore::Node::firstDescendant): Added.
* dom/Node.h:
* dom/Range.cpp: Added a constructor that takes in Positions.
(WebCore::Range::Range):
* dom/Range.h:
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::insertNodeAt):
Let this function insert children into empty containers.
Calls canHaveChildrenForEditing.
(WebCore::CompositeEditCommand::appendNode): Assert that the parent canHaveChildrenForEditing.
(WebCore::CompositeEditCommand::moveParagraph): Tell ReplaceSelectionCommand to select the
replacement so that moveParagraph's callers have a valid destination after the move.
* editing/CompositeEditCommand.h: Moved removeFullySelectedNode to DeleteSelectionCommand,
made deleteTextFromNode virtual so that DeleteSelectionCommand can update it's endingPosition.
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
Removed m_startNode, used a local variable.
(WebCore::DeleteSelectionCommand::initializeStartEnd): Fixed special element expansion.
(WebCore::DeleteSelectionCommand::initializePositionData): Compute the endingPosition up
front and keep track of it as nodes and text are removed.
(WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): Removed use of m_startNode.
(WebCore::DeleteSelectionCommand::removeFullySelectedNode): Moved from CompositeEditCommand.
Update m_endingPosition as we remove nodes.
(WebCore::DeleteSelectionCommand::deleteTextFromNode):
Update m_endingPosition as we delete text.
(WebCore::DeleteSelectionCommand::handleGeneralDelete): Retain the start block. Cleaned up.
(WebCore::DeleteSelectionCommand::mergeParagraphs): Recompute m_endingPosition since moveParagraph
clobbers the old one.
(WebCore::DeleteSelectionCommand::doApply): Fixed the logic for placeholder insertion after
deletion. Make the placeholder decision before we do special element expansion.
* editing/DeleteSelectionCommand.h:
* editing/InsertLineBreakCommand.cpp:
(WebCore::InsertLineBreakCommand::doApply): Fixed a bug where an extra br was inserted and cleaned
up the code.
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply): Deletion of the current selection should do
a merge (added a testcase).
* editing/RebalanceWhitespaceCommand.cpp:
(WebCore::RebalanceWhitespaceCommand::doUnapply): Remove/insert in a way that will trigger a layout.
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply): Ditto.
Merge even when the incoming fragment has interchange newlines (added a testcase).
Merge when the selection being pasted into starts at the start of a block because not
doing so would leave one or more hanging empty blocks.
(WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
Rebalance whitespace using rebalanceWhitespaceAt because rebalanceWhitespace requires
a selection, and a selection can't be created until whitespace has been rebalanced.
* editing/htmlediting.cpp:
(WebCore::canHaveChildrenForEditing): Added.
* editing/htmlediting.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Wed, 7 Jun 2006 00:03:02 +0000 (00:03 +0000)]
Reviewed by Maciej.
Fix for <rdar://problem/
4570475> Dashboard regions do not scale for
non-1.0 scale factors.
No test cases added since this only affects non-1.0 resolution
scale factors.
* platform/FloatRect.cpp:
(WebCore::FloatRect::scale): Added new function that scales a
rect's origin and size by a given factor.
* platform/FloatRect.h:
* platform/IntRect.cpp:
(WebCore::IntRect::scale): Same as above.
* platform/IntRect.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::addDashboardRegions): After the bounds and
clip rects on the Dashboard region have been calculated, get the
user space scale factor, and if it is not 1.0, scale the rects.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 6 Jun 2006 22:58:33 +0000 (22:58 +0000)]
Reviewed by Darin Adler.
- fixed <rdar://problem/
4566087> REGRESSION (420+): Crash occurs while completing a find again query at
http://www.apple.com/ (RenderObject::repaint(bool))
This wasn't a new problem in the code, but the recent use of DocumentMarkers for find results brought
it to the surface.
* dom/Document.h:
Use a RefPtr<Node> instead of a Node* in MarkerMap, so the node will be retained
* dom/Document.cpp:
(WebCore::Document::removeMarkers):
Add a .get() to compensate for using RefPtr. Also, only repaint if this node actually had a marker
removed.
(WebCore::Document::repaintMarkers):
Add a .get() to compensate for using RefPtr.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Tue, 6 Jun 2006 22:28:48 +0000 (22:28 +0000)]
Reviewed by Justin.
* COM/WebView.cpp:
(WebView::keyPress): Added case for VK_RETURN.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 6 Jun 2006 18:26:12 +0000 (18:26 +0000)]
WebCore:
2006-06-06 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9325
clientWidth/clientHeight on document element in strict mode should return visible frame size
* dom/Element.cpp:
(WebCore::Element::clientWidth):
(WebCore::Element::clientHeight):
If we're the document element, and in strict mode, return the visible size of the frame.
LayoutTests:
2006-06-06 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9325
clientWidth/clientHeight on document element in strict mode should return visible frame size
* fast/dom/client-width-height-expected.txt: Added.
* fast/dom/client-width-height.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 6 Jun 2006 17:55:00 +0000 (17:55 +0000)]
WebCore:
2006-06-06 Anders Carlsson <acarlsson@apple.com>
Reviewed by John.
* bridge/mac/WebCoreFrameBridge.h:
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge containsPlugins]):
* page/Frame.cpp:
(WebCore::Frame::containsPlugins):
* page/Frame.h:
Add containsPlugins function which returns whether a frame contains plugins
or not.
WebKit:
2006-06-06 Anders Carlsson <acarlsson@apple.com>
Reviewed by John.
* WebView/WebFrame.m:
(-[WebFrame _reloadForPluginChanges]):
Don't traverse the view hierarchy looking for plugin views. Instead, just
ask the frame whether it contains any plugins.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 6 Jun 2006 05:59:43 +0000 (05:59 +0000)]
Reviewed and landed by Geoff.
- fix a regression in ecma_3/String/regress-104375.js
* kjs/string_object.cpp:
(substituteBackreferences): If a 2-digit back reference is out of range,
parse it as a 1-digit reference (followed by the other digit). This matches
Firefox's behavior.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Tue, 6 Jun 2006 03:52:30 +0000 (03:52 +0000)]
2006-06-06 Steve Falkenburg <sfalken@apple.com>
Fix build break
* platform/win/TemporaryLinkStubs.cpp:
(GraphicsContext::roundToDevicePixels):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Tue, 6 Jun 2006 03:13:33 +0000 (03:13 +0000)]
LayoutTests:
Reviewed by mjs.
testcases for http://bugzilla.opendarwin.org/show_bug.cgi?id=5564
'font' shorthand parsing should be more tolerant in quirks mode
* fast/css/font_property_compatibility-expected.checksum: Added.
* fast/css/font_property_compatibility-expected.png: Added.
* fast/css/font_property_compatibility-expected.txt: Added.
* fast/css/font_property_compatibility.html: Added.
* fast/css/font_property_normal-expected.checksum: Added.
* fast/css/font_property_normal-expected.png: Added.
* fast/css/font_property_normal-expected.txt: Added.
* fast/css/font_property_normal.html: Added.
WebCore:
Reviewed by mjs.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5564
'font' shorthand parsing should be more tolerant in quirks mode
When not in strict mode accept font property specifications
lacking a font family part, like WinIE does.
* css/cssparser.cpp:
(WebCore::CSSParser::parseFont):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Tue, 6 Jun 2006 02:27:00 +0000 (02:27 +0000)]
Reviewed by Darin.
Fix for <rdar://problem/
4567520> Pixel cracks in weather widget at
1.83 scaling
To prevent pixel cracks at non-integral scaling factors, before we
call into CG to draw an image, we have to convert the rect to
device space, round the origin and size to integers in device
space, and convert back to user space.
No test cases added since this only affects non-1.0 resolution
scale factors.
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::JSCanvasRenderingContext2D::drawImage): drawImage() now
takes FloatRects.
* html/CanvasPattern.cpp:
(WebCore::patternCallback): Call roundToDevicePixels()
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage): drawImage() now
takes FloatRects and call roundToDevicePixels()
* html/CanvasRenderingContext2D.h: drawImage() now takes
FloatRects.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paint): Call roundToDevicePixels()
* kcanvas/device/quartz/QuartzSupport.mm:
(WebCore::debugDumpCGImageToFile): Same as above.
* platform/GraphicsContext.h:
* platform/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::roundToDevicePixels): Takes care of
converting between coordinate spaces and rounding.
(WebCore::GraphicsContext::drawLineForText):
* platform/mac/ImageMac.mm: Call roundToDevicePixels()
(WebCore::Image::draw): Same as above.
(WebCore::drawPattern): Same as above.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Tue, 6 Jun 2006 01:51:02 +0000 (01:51 +0000)]
LayoutTests:
Reviewed by ggaren.
- Test results for http://bugzilla.opendarwin.org/show_bug.cgi?id=9310
Add missing DOM prototypes and other DOM cleanup
* fast/dom/global-constructors-expected.txt: Fixed test results.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 6 Jun 2006 00:23:57 +0000 (00:23 +0000)]
Fix for perf regression with single-processor windows machines on ibench.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Mon, 5 Jun 2006 22:12:48 +0000 (22:12 +0000)]
Reviewed By Maciej.
Darin already reviewed this change on the branch. See <rdar://problem/
4317701>.
- Fixed <rdar://problem/
4291345> PCRE overflow in Safari JavaScriptCore
No test case because there's no behavior change.
* pcre/pcre_compile.c:
(read_repeat_counts): Check for integer overflow / out of bounds
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Mon, 5 Jun 2006 17:15:38 +0000 (17:15 +0000)]
LayoutTests:
- Merged test-prototypes.html into global-constructors.html
- Added prototypes.html, which tests for some missing prototypes in DOM objects
* fast/dom/global-constructors-expected.txt:
* fast/dom/global-constructors.html:
* fast/dom/prototypes-expected.txt: Added.
* fast/dom/prototypes.html: Added.
* fast/dom/test-prototypes-expected.txt: Removed.
* fast/dom/test-prototypes.html: Removed.
* fast/dom/undetectable-document-all-expected.txt: Updated to reflect
change from "HTMLCollection" to "Collection"
WebCore:
Reviewed by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9310
Add missing DOM prototypes and other DOM cleanup
- Added the built-in object prototype to DOM objects that were missing it
so that primitive operations like == work on them.
- Removed dead EventConstructor class (it's autogenerated now)
- Changed HTML collections to describe themselves as "[object Collection]",
to match IE.
- Made DOMCSSRule constructor private because JSCSSRule is the class
to use.
* bindings/js/JSHTMLOptionElementConstructor.cpp:
(WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
* bindings/js/kjs_css.cpp:
(KJS::DOMStyleSheet::DOMStyleSheet):
(KJS::DOMStyleSheetList::DOMStyleSheetList):
(KJS::DOMCSSRule::DOMCSSRule):
(KJS::DOMCSSValue::DOMCSSValue):
(KJS::toJS):
(KJS::DOMRGBColor::DOMRGBColor):
(KJS::getDOMRGBColor):
(KJS::DOMRect::DOMRect):
* bindings/js/kjs_css.h:
* bindings/js/kjs_dom.cpp:
(KJS::DOMNodeList::DOMNodeList):
(KJS::DOMExceptionConstructor::DOMExceptionConstructor):
(KJS::DOMExceptionConstructor::getOwnPropertySlot):
(KJS::):
(KJS::DOMNamedNodesCollection::DOMNamedNodesCollection):
* bindings/js/kjs_dom.h:
(KJS::DOMNamedNodesCollection::classInfo):
* bindings/js/kjs_events.h:
* bindings/js/kjs_html.cpp:
(KJS::):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Mon, 5 Jun 2006 16:37:59 +0000 (16:37 +0000)]
Reviewed by aliu.
- Changed CString length from int to size_t. We sould probably do this
for UString, too. (Darin, if you're reading this: Maciej said so.)
* kjs/function.cpp:
(KJS::encode):
* kjs/ustring.cpp:
(KJS::CString::CString):
(KJS::operator==):
* kjs/ustring.h:
(KJS::CString::size):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 5 Jun 2006 05:20:32 +0000 (05:20 +0000)]
Reviewed by Maciej.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9031
REGRESSION: Crash when closing tabs on newegg.com
- removed a no-longer-needed Win32-specific workaround (not reviewed)
* bindings/js/kjs_window.cpp: Added include of <wtf/MathExtras.h>.
(WebCore::floatFeature): Remove WIN32 ifdef around isnan.
(WebCore::toJS): Add null checks.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 5 Jun 2006 04:15:18 +0000 (04:15 +0000)]
LayoutTests:
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9176
REGRESSION: repro crash in WebCore::StringImpl::hash() const + 28 (StringImpl.h:67)
* fast/loader/link-no-URL.html: Added.
* fast/loader/link-no-URL-expected.txt: Added.
WebCore:
Reviewed by Maciej.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9176
REGRESSION: repro crash in WebCore::StringImpl::hash() const + 28 (StringImpl.h:67)
Test: fast/loader/link-no-URL.html
* loader/Cache.h:
* loader/Cache.cpp:
(WebCore::Cache::updateCacheStatus): Removed the URL parameter. Instead get the URL
from the cached object itself. Callers were passing in the wrong URL. When it was a
null string, it caused the crash mentioned above. But in other cases it may have
caused some other minor problems as well. Added an assert to catch cases where the
URL is null (should never happen).
(WebCore::Cache::requestImage): Changed call site to not pass URL.
(WebCore::Cache::requestStyleSheet): Ditto.
(WebCore::Cache::requestScript): Ditto.
(WebCore::Cache::requestXSLStyleSheet): Ditto.
(WebCore::Cache::requestXBLDocument): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Mon, 5 Jun 2006 03:09:22 +0000 (03:09 +0000)]
Reviewed by Maciej.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9304
Minor cleanup in JavaScriptCore
* kjs/value.h: Removed redundant declarations
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 4 Jun 2006 23:05:35 +0000 (23:05 +0000)]
Reviewed by Adele.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7291
REGRESSION: delete key does not work in isIndex fields
* platform/mac/WebCoreTextField.mm:
(inputElement): Added. Helper function to get the Objective-C wrapper for an
input element associated with a QTextEdit. Returns nil if the element is not
an input element. The bug was caused by passing a non-input element to the
delegate methods.
(-[KWQTextFieldController controlTextDidBeginEditing:]): Use inputElement
and don't make the delegate call at all if there is none. This happens only
with isindex elements; it's not important to have auto-fill work with those.
(-[KWQTextFieldController controlTextDidEndEditing:]): Ditto.
(-[KWQTextFieldController controlTextDidChange:]): Ditto.
(-[KWQTextFieldController control:textShouldEndEditing:]): Ditto.
(-[KWQTextFieldController control:textView:doCommandBySelector:]): Ditto.
(-[KWQTextFieldController textView:shouldHandleEvent:]): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 4 Jun 2006 23:03:41 +0000 (23:03 +0000)]
Reviewed by Anders.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8995
memory leak in XPath code -- seen in layout tests
- fixed malloc error on exit due to SVGDOMImplementation destructor
- attempted to fix the no-XPATH_SUPPORT build by adding an #if
- changed around includes and header-file formatting in XPath code
* bindings/scripts/CodeGeneratorJS.pm: Include PlatformString.h when
generating the bindings for XPathNSResolver.
* dom/DOMImplementation.h: Added a virtual destructor for the benefit of
SVGDOMImplementation.
* dom/DOMImplementation.cpp: (WebCore::DOMImplementation::~DOMImplementation): Added.
* ksvg2/svg/SVGDOMImplementation.h: Reformatted a bit, removed unneeded declarations.
* ksvg2/svg/SVGDOMImplementation.cpp:
(SVGDOMImplementation::~SVGDOMImplementation): Remove commented-out code.
(SVGDOMImplementation::createDocument): Remove a reference to KDOMView.
* xpath/XPathExpression.cpp:
(WebCore::XPathExpression::createExpression): Called release to avoid a tiny bit of
reference count churn.
(WebCore::XPathExpression::evaluate): Set exception code explicitly, because the code
relies on it being 0 when the function succeeds.
* xpath/XPathResult.cpp:
(WebCore::InvalidatingEventListener::InvalidatingEventListener): Removed
unneeded target node data member.
(WebCore::XPathResult::XPathResult): Updated for enum name changes and
InvalidatingEventListener name change. Added an assertion.
* xpath/impl/XPathFunctions.h: Removed the FunctionLibrary class. Changed the parameter
for createFunction to be a String instead of char*.
* xpath/impl/XPathFunctions.cpp: Got rid of local implementation of "round", and
used <wtf/MathExtras.h> instead. Also removed unused Interval::asString. Marked all
the Interval functions inline.
(WebCore::XPath::FunSubstring::doEvaluate): Use lround() instead of (long)round().
(WebCore::XPath::FunLang::doEvaluate): Removed some unneeded temporary String variables.
Use equalIgnoringCase() instead of calling lower() on two strings.
(WebCore::XPath::createFunctionMap): Changed how this works so that it's all local to
this function. Also removed a duplicate entry for the "last" function.
(WebCore::XPath::createFunction): Changed from a member function to a separate function.
Also changed so that if the args are not used in the function they are deleted.
This was one of the sources of the storage leaks.
* xpath/impl/XPathGrammar.y: Put XPATH_SUPPORT ifdef in. Replaced <num> with values of
specific types (numop, eqop). Updated for name change from AxisType to Axis. Changed
tokens that were declared as <str> but weren't actually using the string to be
declared with no type (PLUS, MINUS, OR, AND, DOTDOT, SLASHSLASH). Replaced use of
unregisterString, unregisterPredicateVector, and unregisterExpressionVector to
call delete functions instead that both unregister and delete. Change call sites for
createFunction to just use the String, removing the deprecatedString().latin1() call
that is no longer needed. Added a call to unregisterParseNode that was missing in the
"FilterExpr DescendantOrSelf RelativeLocationPath" production.
* xpath/impl/XPathParser.h: Changed Token to hold a String, Step::Axis, NumericOp::Opcode,
and EqTestOp::Opcode. The token ID number tells us which to use. Rearranged to put the private
part of the Parser class last. Moved a number of private things inside the cpp file.
* xpath/impl/XPathParser.cpp:
(WebCore::XPath::charCat): Made this a separate function, instead of a static member.
(WebCore::XPath::isAxisName): Ditto. Also put the global axis map inside the function,
allowing use of a map instead of a map pointer.
(WebCore::XPath::isNodeTypeName): Ditto.
(WebCore::XPath::Parser::isOperatorContext): Made this const.
(WebCore::XPath::Parser::makeTokenAndAdvance): Got rid of the "int" version of this.
By using the actual types, we can safely use overload instead.
(WebCore::XPath::Parser::lexString): Use substring() instead of deprecatedString().mid().
(WebCore::XPath::Parser::lexNumber): Ditto.
(WebCore::XPath::Parser::lexNCName): Changed to return a bool and a String instead of a
Token. This avoids the hack of using a token value of "ERROR + 1" which I found quite
confusing and is also a bit more explicit.
(WebCore::XPath::Parser::lexQName): Ditto.
(WebCore::XPath::Parser::nextTokenInternal): Changed to adapt to the changes above and
to remove some unneeded else statements.
(WebCore::XPath::Parser::lex): Changed the logic that sets up yylval to use the token ID
to decide what the type is. This matches what the grammar expects, and removes the need
for the token object to track which part of the value is good and the need to reserve 0
to have a special meaning.
(WebCore::XPath::Parser::parseStatement): Added code to delete the predicates and the
expressions in the predicate and expression vectors. Before, we were only deleting
the vectors. This was one of the sources of the storage leaks.
(WebCore::XPath::Parser::deletePredicateVector): Renamed, and changed to delete
the vector. However this does not delete the predicates in the vector.
(WebCore::XPath::Parser::deleteExpressionVector): Renamed, and changed to delete
the vector. However this does not delete the expressions in the vector.
(WebCore::XPath::Parser::deleteString): Renamed, and changed to delete the string.
* xpath/impl/XPathPredicate.h:
* xpath/impl/XPathPredicate.cpp:
(WebCore::XPath::NumericOp::NumericOp): Changed opcode from an int to an enum, and
renamed to "opcode" instead of "opCode".
(WebCore::XPath::NumericOp::doEvaluate): More of the same.
(WebCore::XPath::EqTestOp::EqTestOp): Ditto.
(WebCore::XPath::EqTestOp::doEvaluate): Ditto.
(WebCore::XPath::LogicalOp::LogicalOp): Ditto.
(WebCore::XPath::LogicalOp::shortCircuitOn): Ditto.
(WebCore::XPath::Predicate::evaluate): Removed an unneeded "new".
* xpath/impl/XPathStep.h:
* xpath/impl/XPathStep.cpp: Renamed AxisType to Axis. Removed unused axisAsString
function and default constructor.
* xpath/impl/XPathValue.h: Renamed the type constants to have a Value suffix,
instead of the underscore suffix used before on NodeVector and String.
* xpath/impl/XPathValue.cpp: Updated for name change. Added asserts.
* xpath/impl/XPathVariableReference.cpp: (WebCore::XPath::VariableReference::doEvaluate):
Use a reference instead of a pointer.
* xpath/XPathEvaluator.cpp:
* xpath/XPathEvaluator.h:
* xpath/XPathExpression.h:
* xpath/XPathNSResolver.cpp:
* xpath/XPathNSResolver.h:
* xpath/XPathNamespace.cpp:
* xpath/XPathNamespace.h:
* xpath/XPathResult.h:
* xpath/impl/XPathExpressionNode.cpp:
* xpath/impl/XPathExpressionNode.h:
* xpath/impl/XPathPath.cpp:
* xpath/impl/XPathPath.h:
* xpath/impl/XPathUtil.cpp:
* xpath/impl/XPathUtil.h:
* xpath/impl/XPathVariableReference.h:
Reformatted and changed includes around; no substantive changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 4 Jun 2006 22:51:57 +0000 (22:51 +0000)]
Reviewed by Anders.
- changed deleteAllValues so it can work on "const" collections
Deleting the values affects the values, not the pointers in the
collection, so it's legitimate to do it to a const collection,
and a case of that actually came up in the XPath code.
* wtf/HashMap.h:
(WTF::deleteAllPairSeconds): Use const iterators.
(WTF::deleteAllValues): Take const HashMap reference as a parameter.
* wtf/HashSet.h:
(WTF::deleteAllValues): Take const HashSet reference as a parameter,
and use const iterators.
* wtf/Vector.h:
(WTF::deleteAllValues): Take const Vector reference as a parameter.
- added more functions that are present in <math.h> on some platforms,
but not on others; moved here from various files in WebCore
* wtf/MathExtras.h:
(isinf): Added.
(isnan): Added.
(lround): Added.
(lroundf): Tweaked.
(round): Added.
(roundf): Tweaked.
(signbit): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sun, 4 Jun 2006 22:41:35 +0000 (22:41 +0000)]
LayoutTests:
Reviewed by hyatt.
- tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=9213
Absolutely positioned objects with relatively positioned inline
containing blocks are rendered incorrectly
* fast/block/positioning/absolute-in-inline-ltr-2.html: Added.
* fast/block/positioning/absolute-in-inline-ltr-3.html: Added.
* fast/block/positioning/absolute-in-inline-ltr.html: Added.
* fast/block/positioning/absolute-in-inline-rtl-2.html: Added.
* fast/block/positioning/absolute-in-inline-rtl-3.html: Added.
* fast/block/positioning/absolute-in-inline-rtl.html: Added.
* fast/block/positioning/absolute-in-inline-short-ltr.html: Added.
* fast/block/positioning/absolute-in-inline-short-rtl.html: Added.
WebCore:
Reviewed by hyatt.
- fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9213
Absolutely positioned objects with relatively positioned inline
containing blocks are rendered incorrectly
* rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockWidthForPositioned):
(WebCore::RenderBox::containingBlockHeightForPositioned):
(WebCore::RenderBox::calcAbsoluteHorizontal):
(WebCore::RenderBox::calcAbsoluteHorizontalValues):
(WebCore::RenderBox::calcAbsoluteVertical):
(WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
(WebCore::RenderBox::calcAbsoluteVerticalReplaced):
* rendering/RenderBox.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sun, 4 Jun 2006 20:37:17 +0000 (20:37 +0000)]
WebKitSite:
Reviewed by ggaren.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9303
JavaScript error when loading WebKit blog page
* blog/wp-content/themes/webkit/sidebar.php: Removed unused JavaScript. Synced with nav.inc.
* nav.inc: Removed evil tabs--whitespace change only.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sun, 4 Jun 2006 18:52:24 +0000 (18:52 +0000)]
WebKitTools:
Reviewed by darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9299
Teach svn-create-patch and friends to work with binary files
* Scripts/svn-apply: Updated to use base64-encoded text for binary files when applying patches.
* Scripts/svn-create-patch: Updated to include binary file content as base64-encoded text in patches.
* Scripts/svn-unapply: Updated to recognize binary files when unapplying patches.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sun, 4 Jun 2006 08:08:31 +0000 (08:08 +0000)]
WebCore:
2006-06-04 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9035
document.evaluate and createNSResolver miss on namespaced elements
* xpath/XPathExpression.cpp:
(WebCore::XPathExpression::createExpression):
Pass the resolver to the parser.
* xpath/XPathResult.cpp:
(WebCore::XPathResult::iterateNext):
Fix off-by-one error.
* xpath/impl/XPathExpressionNode.h:
(WebCore::XPath::EvaluationContext::EvaluationContext):
Get rid of the resolver in the evaluation context.
* xpath/impl/XPathGrammar.y:
Fetch the resolver from the parser. Only return the local name.
* xpath/impl/XPathParser.cpp:
(WebCore::XPath::Parser::parseStatement):
* xpath/impl/XPathParser.h:
(WebCore::XPath::Parser::resolver):
Update to hold the resolver.
* xpath/impl/XPathStep.cpp:
(WebCore::XPath::Step::Step):
If the parser has stored a namespace URI, set it.
(WebCore::XPath::Step::nodeTestMatches):
Check namespace URIs.
* xpath/impl/XPathStep.h:
Add m_namespaceURI.
LayoutTests:
2006-06-04 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9035
document.evaluate and createNSResolver miss on namespaced elements
* fast/xpath: Added.
* fast/xpath/xpath-namespaces-expected.txt: Added.
* fast/xpath/xpath-namespaces.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sun, 4 Jun 2006 04:33:21 +0000 (04:33 +0000)]
LayoutTests:
Reviewed by Eric.
Added missing pixel test output:
http://bugzilla.opendarwin.org/show_bug.cgi?id=8848
TFOOT borders are copied to THEAD and TBODY
* fast/table/border-collapsing/border-collapsing-head-foot-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sat, 3 Jun 2006 22:23:52 +0000 (22:23 +0000)]
LayoutTests:
Reviewed by mjs. Tweaked and landed by ddkilzer.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7281
With java disabled wrong information is displayed.
* fast/replaced/applet-rendering-java-disabled.html: Added.
* fast/replaced/applet-rendering-java-disabled-expected.checksum: Added.
* fast/replaced/applet-rendering-java-disabled-expected.html: Added.
* fast/replaced/applet-rendering-java-disabled-expected.png: Added.
* tables/mozilla_expected_failures/bugs/bug8499-expected.checksum: Changed after removing RenderEmptyApplet.
* tables/mozilla_expected_failures/bugs/bug8499-expected.png: Ditto.
* tables/mozilla_expected_failures/bugs/bug8499-expected.txt: Ditto.
WebCore:
Reviewed by mjs. Tweaked and landed by ddkilzer.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7281
With java disabled wrong information is displayed.
Test: fast/replaced/applet-rendering-java-disabled.html
Match WinIE, render applet content inline when java is
disabled.
* WebCore.vcproj/WebCore/WebCore.vcproj: Removed RenderEmptyApplet.cpp and RenderEmptyApplet.h.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* WebCoreSources.bkl: Ditto.
* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::createRenderer):
* rendering/RenderEmptyApplet.cpp: Removed.
* rendering/RenderEmptyApplet.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sat, 3 Jun 2006 20:40:14 +0000 (20:40 +0000)]
LayoutTests:
Reviewed by Hyatt.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9252
REGRESSION: Very odd roll-over issues (content disappearing)
* fast/dom/HTMLLinkElement/pending-stylesheet-count.html: Added.
* fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.txt: Added.
* fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.png: Added.
* fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.checksum: Added.
WebCore:
Reviewed by Hyatt.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9252
REGRESSION: Very odd roll-over issues (content disappearing)
Test: fast/dom/HTMLLinkElement/pending-stylesheet-count.html
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::~HTMLLinkElement): If the stylesheet was being
loaded, call stylesheetLoaded() on the document, to keep the pending stylesheet
count correct.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sat, 3 Jun 2006 20:38:22 +0000 (20:38 +0000)]
WebKitTools:
Reviewed by Maciej.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9296
Performance improvement for svn-create-patch
* Scripts/svn-create-patch: Undef $indexPath after all paths have been fixed for a given patch.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sat, 3 Jun 2006 20:03:50 +0000 (20:03 +0000)]
- fix Windows build
* platform/Widget.h: Moved scaleFactor function out of Apple-specific
section of the header into the common part.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Sat, 3 Jun 2006 18:37:07 +0000 (18:37 +0000)]
Reviewed by Darin.
Fix for <rdar://problem/
4537274> HiDPI: <canvas> needs to apply a
scale. <canvas> needs to scale itself along with whatever scale
factor is set on the window.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createDrawingContext): Get the scale
factor and use it to create a larger buffer and to scale the
CGContext.
* platform/Widget.h: Provide a new function that returns the user
space scale factor.
* platform/mac/WidgetMac.mm:
(WebCore::Widget::scaleFactor): Get the scale factor from the
window and return it.
* platform/win/WidgetWin.cpp:
(WebCore::Widget::scaleFactor): Just return 1.0f for now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14711
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sat, 3 Jun 2006 17:59:05 +0000 (17:59 +0000)]
WebKit:
Reviewed by darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9290
Teach svn-apply and svn-unapply to patch ChangeLogs cleanly
* Scripts/svn-apply: Fixed to apply ChangeLog patches without failing.
* Scripts/svn-unapply: Ditto. Also simplified reversing a deletion.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Sat, 3 Jun 2006 07:16:57 +0000 (07:16 +0000)]
2006-06-03 Steve Falkenburg <sfalken@apple.com>
Reviewed by hyatt.
Removed unused code.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Sat, 3 Jun 2006 07:15:42 +0000 (07:15 +0000)]
2006-06-03 Steve Falkenburg <sfalken@apple.com>
Reviewed by hyatt.
Switch Spinneret to new hosting mechanism
* Spinneret/Spinneret.sln:
* Spinneret/Spinneret/Spinneret.cpp:
(SpinneretWebHost::updateAddressBar):
(SpinneretWebHost::QueryInterface):
(SpinneretWebHost::AddRef):
(SpinneretWebHost::Release):
(resizeSubViews):
(_tWinMain):
(WndProc):
(MyEditProc):
(About):
(loadURL):
* Spinneret/Spinneret/Spinneret.h:
(SpinneretWebHost::didStartProvisionalLoadForFrame):
(SpinneretWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
(SpinneretWebHost::didFailProvisionalLoadWithError):
(SpinneretWebHost::didCommitLoadForFrame):
(SpinneretWebHost::didReceiveTitle):
(SpinneretWebHost::didReceiveIcon):
(SpinneretWebHost::didFinishLoadForFrame):
(SpinneretWebHost::didFailLoadWithError):
(SpinneretWebHost::didChangeLocationWithinPageForFrame):
(SpinneretWebHost::willPerformClientRedirectToURL):
(SpinneretWebHost::didCancelClientRedirectForFrame):
(SpinneretWebHost::willCloseFrame):
(SpinneretWebHost::windowScriptObjectAvailable):
* Spinneret/Spinneret/Spinneret.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Sat, 3 Jun 2006 07:13:07 +0000 (07:13 +0000)]
2006-06-03 Steve Falkenburg <sfalken@apple.com>
Reviewed by hyatt.
Add implementation of loadHTMLString for Spinneret
* COM/WebFrame.cpp:
(WebFrame::loadHTMLString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Sat, 3 Jun 2006 07:10:24 +0000 (07:10 +0000)]
2006-06-03 Steve Falkenburg <sfalken@apple.com>
Reviewed by hyatt.
Don't send empty referrers. Fixes image load fail on Spinneret default content.
* platform/win/TransferJobWin.cpp:
(WebCore::TransferJob::start):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sat, 3 Jun 2006 04:56:56 +0000 (04:56 +0000)]
JavaScriptCore:
Reviewed by ggaren.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9234
Implement $&, $' and $` replacement codes in String.prototype.replace
Test: fast/js/string-replace-3.html
* kjs/string_object.cpp:
(substituteBackreferences): Added support for $& (matched substring),
$` (everything preceding matched substring), $' (everything following
matched substring) and 2-digit back references, and cleaned up a little.
LayoutTests:
Reviewed by ggaren.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9234
Implement $&, $' and $` replacement codes in String.prototype.replace
* fast/js/resources/string-replace-3.js: Added.
* fast/js/string-replace-3-expected.txt: Added.
* fast/js/string-replace-3.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Sat, 3 Jun 2006 01:41:00 +0000 (01:41 +0000)]
Reviewed by Darin.
Windows theme for textareas. Also made some formatting changes.
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::supportsFocus):
(WebCore::RenderThemeWin::getThemeData):
(WebCore::RenderThemeWin::adjustButtonStyle):
(WebCore::RenderThemeWin::adjustTextFieldStyle):
(WebCore::RenderThemeWin::adjustTextAreaStyle):
(WebCore::RenderThemeWin::paintTextArea):
* rendering/RenderThemeWin.h:
(WebCore::RenderThemeWin::supportsHover):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sat, 3 Jun 2006 01:28:25 +0000 (01:28 +0000)]
Reviewed by Hyatt, checked in by Tim H.
Explicitly run perl on *.pl files instead of relying
on Windows shell figuring out which program to run for
this extention.
* DerivedSources.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Sat, 3 Jun 2006 01:16:33 +0000 (01:16 +0000)]
Reviewed by Darin.
Set incremental linking to no. This seems to fix a build problem I was seeing
where dftables couldn't find a dll.
* JavaScriptCore.vcproj/dftables/dftables.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sat, 3 Jun 2006 01:15:11 +0000 (01:15 +0000)]
LayoutTests:
Reviewed by Hyatt, checked in by Tim H.
For: http://bugzilla.opendarwin.org/show_bug.cgi?id=9115
Added test case to test opacity layers, in particular, opacities
with a value of zero.
* fast/css/ZeroOpacityLayers.html: Added.
* fast/css/ZeroOpacityLayers-expected.txt: Added.
* fast/css/ZeroOpacityLayers-expected.png: Added.
* fast/css/ZeroOpacityLayers-expected.checksum: Added.
* fast/css/ZeroOpacityLayers2.html: Added.
* fast/css/ZeroOpacityLayers2-expected.txt: Added.
* fast/css/ZeroOpacityLayers2-expected.png: Added.
* fast/css/ZeroOpacityLayers2-expected.checksum: Added.
WebCore:
Reviewed by Hyatt, checked in by Tim H.
fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=9115
Changed RenderLayer to only render layers that are not
totally transparent.
* rendering/RenderLayer.cpp
(RenderLayer::paintLayer):
Changed function to also check if the layer is totally transparent
and if it is, don't bother painting it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14701
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sat, 3 Jun 2006 00:52:34 +0000 (00:52 +0000)]
LayoutTests:
Reviewed by Hyatt, checked in by Tim H.
Adding testcase for bug 8223.
* fast/dom/css-inline-style-important-expected.checksum: Added.
* fast/dom/css-inline-style-important-expected.png: Added.
* fast/dom/css-inline-style-important-expected.txt: Added.
* fast/dom/css-inline-style-important.html: Added.
WebCore:
Reviewed by Hyatt, checked in by Tim H.
http://bugzilla.opendarwin.org/show_bug.cgi?id=8223
WebKit fails to update style on element via DOM
Handle !important by detecting it and using a different code
path from normal priority.
* bindings/js/kjs_css.cpp:
(KJS::DOMCSSStyleDeclaration::put):
* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::setProperty):
* css/CSSStyleDeclaration.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14700
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sat, 3 Jun 2006 00:19:02 +0000 (00:19 +0000)]
Reviewed by Geoff, checked in by Maciej.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9236
REGRESSION: focus method does not work on some elements before they are laid out
* dom/Element.cpp: (WebCore::Element::focus): Do the updateLayout call before
calling isFocusable, since isFocusable looks at the size of the renderer.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14699
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Fri, 2 Jun 2006 19:35:26 +0000 (19:35 +0000)]
2006-06-02 Steve Falkenburg <sfalken@apple.com>
Reviewed by darin.
Updated build script
* Scripts/build-webkit:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Fri, 2 Jun 2006 19:35:01 +0000 (19:35 +0000)]
2006-06-02 Steve Falkenburg <sfalken@apple.com>
Reviewed by darin.
Updated to latest hosting interface
* WebFramePrivate.cpp:
(WebKit::WebFramePrivate::openURL):
(WebKit::WebFramePrivate::setTitle):
(WebKit::WebFramePrivate::setStatusText):
* WebFramePrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14690
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Fri, 2 Jun 2006 19:34:27 +0000 (19:34 +0000)]
2006-06-02 Steve Falkenburg <sfalken@apple.com>
Reviewed by darin.
Platform hookup fixes
* bridge/win/FrameWin.cpp:
(WebCore::FrameWin::urlSelected):
(WebCore::FrameWin::setTitle):
(WebCore::FrameWin::setStatusBarText):
* bridge/win/FrameWin.h:
* platform/win/TemporaryLinkStubs.cpp:
(FrameWin::overrideMediaType):
* platform/win/TransferJobWin.cpp:
(WebCore::TransferJobWndProc):
(WebCore::TransferJob::start):
(WebCore::TransferJob::fileLoadTimer):
(WebCore::TransferJob::cancel):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Fri, 2 Jun 2006 19:32:33 +0000 (19:32 +0000)]
2006-06-02 Steve Falkenburg <sfalken@apple.com>
Reviewed by darin.
New hosting for Spinneret to avoid static linking
* COM: Added.
* COM/Interfaces: Added.
* COM/Interfaces/DOMCSS.idl: Added.
* COM/Interfaces/DOMCore.idl: Added.
* COM/Interfaces/DOMHTML.idl: Added.
* COM/Interfaces/DOMRange.idl: Added.
* COM/Interfaces/IWebArchive.idl: Added.
* COM/Interfaces/IWebAttributedString.idl: Added.
* COM/Interfaces/IWebBackForwardList.idl: Added.
* COM/Interfaces/IWebDataSource.idl: Added.
* COM/Interfaces/IWebDocument.idl: Added.
* COM/Interfaces/IWebDownload.idl: Added.
* COM/Interfaces/IWebEditingDelegate.idl: Added.
* COM/Interfaces/IWebError.idl: Added.
* COM/Interfaces/IWebFrame.idl: Added.
* COM/Interfaces/IWebFrameLoadDelegate.idl: Added.
* COM/Interfaces/IWebFrameView.idl: Added.
* COM/Interfaces/IWebHistoryItem.idl: Added.
* COM/Interfaces/IWebIconDatabase.idl: Added.
* COM/Interfaces/IWebImage.idl: Added.
* COM/Interfaces/IWebMutableURLRequest.idl: Added.
* COM/Interfaces/IWebNotification.idl: Added.
* COM/Interfaces/IWebPolicyDelegate.idl: Added.
* COM/Interfaces/IWebPreferences.idl: Added.
* COM/Interfaces/IWebResource.idl: Added.
* COM/Interfaces/IWebResourceLoadDelegate.idl: Added.
* COM/Interfaces/IWebScriptObject.idl: Added.
* COM/Interfaces/IWebUIDelegate.idl: Added.
* COM/Interfaces/IWebURLAuthenticationChallenge.idl: Added.
* COM/Interfaces/IWebURLRequest.idl: Added.
* COM/Interfaces/IWebURLResponse.idl: Added.
* COM/Interfaces/IWebUndoManager.idl: Added.
* COM/Interfaces/IWebView.idl: Added.
* COM/Interfaces/WebKit.idl: Added.
* COM/WebBackForwardList.cpp: Added.
(WebBackForwardList::WebBackForwardList):
(WebBackForwardList::~WebBackForwardList):
(WebBackForwardList::createInstance):
(WebBackForwardList::QueryInterface):
(WebBackForwardList::AddRef):
(WebBackForwardList::Release):
(WebBackForwardList::addItem):
(WebBackForwardList::goBack):
(WebBackForwardList::goForward):
(WebBackForwardList::goToItem):
(WebBackForwardList::backItem):
(WebBackForwardList::currentItem):
(WebBackForwardList::forwardItem):
(WebBackForwardList::backListWithLimit):
(WebBackForwardList::forwardListWithLimit):
(WebBackForwardList::capacity):
(WebBackForwardList::setCapacity):
(WebBackForwardList::backListCount):
(WebBackForwardList::forwardListCount):
(WebBackForwardList::containsItem):
(WebBackForwardList::itemAtIndex):
(WebBackForwardList::setPageCacheSize):
(WebBackForwardList::pageCacheSize):
* COM/WebBackForwardList.h: Added.
* COM/WebDataSource.cpp: Added.
(WebDataSource::WebDataSource):
(WebDataSource::~WebDataSource):
(WebDataSource::createInstance):
(WebDataSource::QueryInterface):
(WebDataSource::AddRef):
(WebDataSource::Release):
(WebDataSource::initWithRequest):
(WebDataSource::data):
(WebDataSource::representation):
(WebDataSource::webFrame):
(WebDataSource::initialRequest):
(WebDataSource::request):
(WebDataSource::response):
(WebDataSource::textEncodingName):
(WebDataSource::isLoading):
(WebDataSource::pageTitle):
(WebDataSource::unreachableURL):
(WebDataSource::webArchive):
(WebDataSource::mainResource):
(WebDataSource::subresources):
(WebDataSource::subresourceForURL):
(WebDataSource::addSubresource):
* COM/WebDataSource.h: Added.
* COM/WebFrame.cpp: Added.
(WebFrame::WebFramePrivate::WebFramePrivate):
(WebFrame::WebFramePrivate::~WebFramePrivate):
(WebFrame::WebFrame):
(WebFrame::~WebFrame):
(WebFrame::createInstance):
(WebFrame::QueryInterface):
(WebFrame::AddRef):
(WebFrame::Release):
(WebFrame::initWithName):
(WebFrame::name):
(WebFrame::webView):
(WebFrame::frameView):
(WebFrame::DOMDocument):
(WebFrame::frameElement):
(WebFrame::loadRequest):
(WebFrame::loadData):
(WebFrame::loadHTMLString):
(WebFrame::loadAlternateHTMLString):
(WebFrame::loadArchive):
(WebFrame::dataSource):
(WebFrame::provisionalDataSource):
(WebFrame::stopLoading):
(WebFrame::reload):
(WebFrame::findFrameNamed):
(WebFrame::parentFrame):
(WebFrame::childFrames):
(WebFrame::paint):
(WebFrame::impl):
(WebFrame::loadDataSource):
(WebFrame::loading):
(WebFrame::goToItem):
(WebFrame::loadItem):
(WebSystemMainMemory):
(WebFrame::getObjectCacheSize):
(WebFrame::receivedRedirect):
(WebFrame::receivedResponse):
(WebFrame::receivedData):
(WebFrame::receivedAllData):
(WebFrame::openURL):
(WebFrame::submitForm):
(WebFrame::setTitle):
(WebFrame::setStatusText):
* COM/WebFrame.h: Added.
* COM/WebHistoryItem.cpp: Added.
(WebHistoryItem::WebHistoryItem):
(WebHistoryItem::~WebHistoryItem):
(WebHistoryItem::createInstance):
(WebHistoryItem::QueryInterface):
(WebHistoryItem::AddRef):
(WebHistoryItem::Release):
(WebHistoryItem::initWithURLString):
(WebHistoryItem::originalURLString):
(WebHistoryItem::URLString):
(WebHistoryItem::title):
(WebHistoryItem::lastVisitedTimeInterval):
(WebHistoryItem::setAlternateTitle):
(WebHistoryItem::alternateTitle):
(WebHistoryItem::icon):
* COM/WebHistoryItem.h: Added.
* COM/WebIconDatabase.cpp: Added.
(WebIconDatabase::WebIconDatabase):
(WebIconDatabase::~WebIconDatabase):
(WebIconDatabase::createInstance):
(WebIconDatabase::QueryInterface):
(WebIconDatabase::AddRef):
(WebIconDatabase::Release):
(WebIconDatabase::sharedIconDatabase):
(WebIconDatabase::iconForURL):
(WebIconDatabase::defaultIconWithSize):
(WebIconDatabase::retainIconForURL):
(WebIconDatabase::releaseIconForURL):
(WebIconDatabase::delayDatabaseCleanup):
(WebIconDatabase::allowDatabaseCleanup):
* COM/WebIconDatabase.h: Added.
* COM/WebKitClassFactory.cpp: Added.
(WebKitClassFactory::WebKitClassFactory):
(WebKitClassFactory::~WebKitClassFactory):
(WebKitClassFactory::QueryInterface):
(WebKitClassFactory::AddRef):
(WebKitClassFactory::Release):
(WebKitClassFactory::CreateInstance):
(WebKitClassFactory::LockServer):
* COM/WebKitClassFactory.h: Added.
* COM/WebKitDLL.cpp: Added.
(DllMain):
(DllGetClassObject):
(DllCanUnloadNow):
(DllUnregisterServer):
(DllRegisterServer):
* COM/WebKitDLL.h: Added.
* COM/WebMutableURLRequest.cpp: Added.
(WebMutableURLRequest::WebMutableURLRequest):
(WebMutableURLRequest::~WebMutableURLRequest):
(WebMutableURLRequest::createInstance):
(WebMutableURLRequest::QueryInterface):
(WebMutableURLRequest::AddRef):
(WebMutableURLRequest::Release):
(WebMutableURLRequest::requestWithURL):
(WebMutableURLRequest::allHTTPHeaderFields):
(WebMutableURLRequest::cachePolicy):
(WebMutableURLRequest::HTTPBody):
(WebMutableURLRequest::HTTPBodyStream):
(WebMutableURLRequest::HTTPMethod):
(WebMutableURLRequest::HTTPShouldHandleCookies):
(WebMutableURLRequest::initWithURL):
(WebMutableURLRequest::mainDocumentURL):
(WebMutableURLRequest::timeoutInterval):
(WebMutableURLRequest::URL):
(WebMutableURLRequest::valueForHTTPHeaderField):
(WebMutableURLRequest::addValue):
(WebMutableURLRequest::setAllHTTPHeaderFields):
(WebMutableURLRequest::setCachePolicy):
(WebMutableURLRequest::setHTTPBody):
(WebMutableURLRequest::setHTTPBodyStream):
(WebMutableURLRequest::setHTTPMethod):
(WebMutableURLRequest::setHTTPShouldHandleCookies):
(WebMutableURLRequest::setMainDocumentURL):
(WebMutableURLRequest::setTimeoutInterval):
(WebMutableURLRequest::setURL):
(WebMutableURLRequest::setValue):
(WebMutableURLRequest::setFormData):
(WebMutableURLRequest::formData):
* COM/WebMutableURLRequest.h: Added.
* COM/WebView.cpp: Added.
(WebView::WebView):
(WebView::~WebView):
(WebView::createInstance):
(WebView::mouseMoved):
(WebView::mouseDown):
(WebView::mouseUp):
(WebView::mouseDoubleClick):
(WebView::keyPress):
(registerWebView):
(WebViewWndProc):
(calculateScrollDelta):
(scrollMessageForKey):
(WebView::goToItem):
(WebView::QueryInterface):
(WebView::AddRef):
(WebView::Release):
(WebView::canShowMIMEType):
(WebView::canShowMIMETypeAsHTML):
(WebView::MIMETypesShownAsHTML):
(WebView::setMIMETypesShownAsHTML):
(WebView::URLFromPasteboard):
(WebView::URLTitleFromPasteboard):
(WebView::initWithFrame):
(WebView::setUIDelegate):
(WebView::uiDelegate):
(WebView::setResourceLoadDelegate):
(WebView::resourceLoadDelegate):
(WebView::setDownloadDelegate):
(WebView::downloadDelegate):
(WebView::setFrameLoadDelegate):
(WebView::frameLoadDelegate):
(WebView::setPolicyDelegate):
(WebView::policyDelegate):
(WebView::mainFrame):
(WebView::backForwardList):
(WebView::setMaintainsBackForwardList):
(WebView::goBack):
(WebView::goForward):
(WebView::goToBackForwardItem):
(WebView::setTextSizeMultiplier):
(WebView::textSizeMultiplier):
(WebView::setApplicationNameForUserAgent):
(WebView::applicationNameForUserAgent):
(WebView::setCustomUserAgent):
(WebView::customUserAgent):
(WebView::userAgentForURL):
(WebView::supportsTextEncoding):
(WebView::setCustomTextEncodingName):
(WebView::customTextEncodingName):
(WebView::setMediaStyle):
(WebView::mediaStyle):
(WebView::stringByEvaluatingJavaScriptFromString):
(WebView::windowScriptObject):
(WebView::setPreferences):
(WebView::preferences):
(WebView::setPreferencesIdentifier):
(WebView::preferencesIdentifier):
(WebView::setHostWindow):
(WebView::hostWindow):
(WebView::searchFor):
(WebView::registerViewClass):
(WebView::takeStringURLFrom):
(WebView::stopLoading):
(WebView::reload):
(WebView::canGoBack):
(WebView::canGoForward):
(WebView::canMakeTextLarger):
(WebView::makeTextLarger):
(WebView::canMakeTextSmaller):
(WebView::makeTextSmaller):
(WebView::computedStyleForElement):
(WebView::editableDOMRangeForPoint):
(WebView::setSelectedDOMRange):
(WebView::selectedDOMRange):
(WebView::selectionAffinity):
(WebView::setEditable):
(WebView::isEditable):
(WebView::setTypingStyle):
(WebView::typingStyle):
(WebView::setSmartInsertDeleteEnabled):
(WebView::smartInsertDeleteEnabled):
(WebView::setContinuousSpellCheckingEnabled):
(WebView::isContinuousSpellCheckingEnabled):
(WebView::spellCheckerDocumentTag):
(WebView::undoManager):
(WebView::setEditingDelegate):
(WebView::editingDelegate):
(WebView::styleDeclarationWithText):
(WebView::replaceSelectionWithNode):
(WebView::replaceSelectionWithText):
(WebView::replaceSelectionWithMarkupString):
(WebView::replaceSelectionWithArchive):
(WebView::deleteSelection):
(WebView::applyStyle):
(WebView::copy):
(WebView::cut):
(WebView::paste):
(WebView::copyFont):
(WebView::pasteFont):
(WebView::delete_):
(WebView::pasteAsPlainText):
(WebView::pasteAsRichText):
(WebView::changeFont):
(WebView::changeAttributes):
(WebView::changeDocumentBackgroundColor):
(WebView::changeColor):
(WebView::alignCenter):
(WebView::alignJustified):
(WebView::alignLeft):
(WebView::alignRight):
(WebView::checkSpelling):
(WebView::showGuessPanel):
(WebView::performFindPanelAction):
(WebView::startSpeaking):
(WebView::stopSpeaking):
(WebView::viewWindow):
* COM/WebView.h: Added.
* WebKit.vcproj: Added.
* WebKit.vcproj/Interfaces.vcproj: Added.
* WebKit.vcproj/WebKit.def: Added.
* WebKit.vcproj/WebKit.rc: Added.
* WebKit.vcproj/WebKit.sln: Added.
* WebKit.vcproj/WebKit.vcproj: Added.
* WebKit.vcproj/WebKitGUID.vcproj: Added.
* WebKit.vcproj/autoversion.h: Added.
* WebKit.vcproj/resource.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 2 Jun 2006 17:24:41 +0000 (17:24 +0000)]
LayoutTests:
Reviewed by Hyatt.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=3379
attr(X) does not work
* fast/css-generated-content/016-expected.checksum: Added.
* fast/css-generated-content/016-expected.png: Added.
* fast/css-generated-content/016-expected.txt: Added.
* fast/css-generated-content/016.html: Added.
WebCore:
Reviewed by Hyatt.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3379
attr(X) does not work
Test: fast/css-generated-content/016.html
* css/cssstyleselector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement): Don't share style
if the unique bit is set.
(WebCore::CSSStyleSelector::applyProperty): When applying the "attr" property,
set the unique bit and add to m_selectorAttrs.
* rendering/render_style.cpp: Did a lot of reformatting, and this one real change.
(WebCore::RenderStyle::RenderStyle): Initialize m_unique to false.
* rendering/render_style.h:
(WebCore::RenderStyle::unique): Added. Returns value of m_unique.
(WebCore::RenderStyle::setUnique): Added. Sets m_unique.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14687
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 2 Jun 2006 16:39:35 +0000 (16:39 +0000)]
Reviewed by Anders.
Updated test so that is will once again exercise the fix for
http://bugzilla.opendarwin.org/show_bug.cgi?id=9009
* fast/table/empty-section-crash-expected.txt:
* fast/table/empty-section-crash.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14685
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Fri, 2 Jun 2006 09:50:12 +0000 (09:50 +0000)]
LayoutTests:
Reviewed by mjs.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9183
Finish renaming of RenderCanvas to RenderView
* editing/selection/7152-1-expected.checksum: Layout changed due to text change in HTML file.
* editing/selection/7152-1-expected.png: Ditto.
* editing/selection/7152-1-expected.txt: Ditto.
* editing/selection/7152-1.html: Changed text in HTML content.
* editing/selection/7152-2-expected.checksum: Layout changed due to text change in HTML file.
* editing/selection/7152-2-expected.png: Ditto.
* editing/selection/7152-2-expected.txt: Ditto.
* editing/selection/7152-2.html: Changed text in HTML content.
* *-expected.txt: Replaced "RenderCanvas" with "RenderView" in 3023 more files.
WebCore:
Reviewed by mjs.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9183
Finish renaming of RenderCanvas to RenderView
* rendering/RenderView.h: Changed renderName from "RenderCanvas" to "RenderView".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14684
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 2 Jun 2006 07:29:29 +0000 (07:29 +0000)]
* WebCoreSupport/WebImageRendererFactory.m: Fix crash on Safari startup
by include NSObject as a superclass (oops!).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14683
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 2 Jun 2006 06:59:34 +0000 (06:59 +0000)]
- try to fix Windows build
* bridge/win/FrameWin.cpp: Added include of Decoder.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14682
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 2 Jun 2006 06:56:47 +0000 (06:56 +0000)]
WebCore:
Reviewed by Maciej.
- WebCore doesn't need to load WebKit images any more; removed code for that
* WebCore.exp: Removed WebCoreImageRendererFactory.
* WebCore.xcodeproj/project.pbxproj: Removed WebCoreImageRendererFactory.h/mm.
* bridge/mac/WebCoreFrameBridge.mm: Removed include of WebCoreImageRendererFactory.h.
* platform/mac/ImageMac.mm: Removed include of WebCoreImageRendererFactory.h.
* platform/mac/WebCoreImageRendererFactory.h: Removed.
* platform/mac/WebCoreImageRendererFactory.m: Removed.
WebKit:
Reviewed by Maciej.
- WebCore doesn't need to load WebKit images any more; removed code for that
* Resources/missing_image.tiff: Removed.
* WebCoreSupport/WebImageRendererFactory.h: Removed.
* WebCoreSupport/WebImageRendererFactory.m: Moved @interface in here.
Removed all but the "threaded decoding" calls that older Safari calls.
This file can go altogether when compatibility with that older Safari
is no longer needed.
* WebKit.xcodeproj/project.pbxproj: Removed WebImageRendererFactory.h
and missing_image.tiff.
* WebView/WebFrameView.m: (-[WebFrameView initWithFrame:]): Removed call
to [WebImageRendererFactory createSharedFactory].
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14681
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 2 Jun 2006 06:30:49 +0000 (06:30 +0000)]
Reviewed by Geoff, tweaked a bit by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9064
Split dom2_traversalimpl.* into separate files (one class per file).
* WebCore.xcodeproj/project.pbxproj: Updated for new files.
* WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
* bindings/js/kjs_traversal.h:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/objc/DOM.mm:
* dom/Document.cpp:
* dom/Document.h:
Updated includes.
* dom/NodeFilter.cpp: Added.
* dom/NodeFilter.h: Added.
* dom/NodeFilterCondition.cpp: Added.
* dom/NodeFilterCondition.h: Added.
* dom/NodeIterator.cpp: Added.
* dom/NodeIterator.h: Added.
* dom/Traversal.cpp: Added.
* dom/Traversal.h: Added.
* dom/TreeWalker.cpp: Added.
* dom/TreeWalker.h: Added.
* dom/dom2_traversalimpl.cpp: Removed.
* dom/dom2_traversalimpl.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14680
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 2 Jun 2006 05:55:22 +0000 (05:55 +0000)]
LayoutTests:
Reviewed by Maciej and Adele
Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=8398
Updated and extended select/option form tests
* fast/forms/HTMLOptionElement_label01.html:
* fast/forms/HTMLOptionElement_label01-expected.txt:
* fast/forms/HTMLOptionElement_label01-expected.png:
* fast/forms/HTMLOptionElement_label02.html:
* fast/forms/HTMLOptionElement_label02-expected.txt:
* fast/forms/HTMLOptionElement_label02-expected.png:
* fast/forms/HTMLOptionElement_label03.html:
* fast/forms/HTMLOptionElement_label03-expected.txt:
* fast/forms/HTMLOptionElement_label03-expected.png
* fast/forms/HTMLOptionElement_label04.html:
* fast/forms/HTMLOptionElement_label04-expected.txt:
* fast/forms/HTMLOptionElement_label04-expected.png
* fast/forms/HTMLOptionElement_label05.html:
* fast/forms/HTMLOptionElement_label05-expected.txt:
* fast/forms/HTMLOptionElement_label05-expected.png:
Updated to reflect success and added some description
* fast/forms/HTMLOptionElement_label06.html:
* fast/forms/HTMLOptionElement_label06-expected.txt:
* fast/forms/HTMLOptionElement_label05-expected.png:
* fast/forms/HTMLOptionElement_label07.html:
* fast/forms/HTMLOptionElement_label07-expected.txt:
* fast/forms/HTMLOptionElement_label07-expected.png:
Added.
WebCore:
Reviewed by Maciej and Adele
Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8398
REGRESSION: LABEL in OPTION element is clobbering display #TEXT
Patch provided by Darin.
* rendering/RenderSelect.cpp
(RenderSelect::updateFromElement):
Changed to use the containing text by default, and not the label text
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14679
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 2 Jun 2006 05:46:37 +0000 (05:46 +0000)]
LayoutTests:
Reviewed by Hyatt
Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=8646
Test the window.screen.pixelDepth and window.screen.colorDepth
* fast/dom/window/window-screen-properties.html: Added
* fast/dom/window/window-screen-properties-expected.txt: Added.
WebCore:
Reviewed by Hyatt.
Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8646
Correcting the value returned for window.screen.pixelDepth and
window.screen.colorDepth
* platform/mac/ScreenMac.mm
(screenDepth):
Changed to return the BitsPerPixelFromDepth rather than the WindowDepth
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14678
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 2 Jun 2006 03:15:26 +0000 (03:15 +0000)]
Fix win32 build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14677
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Fri, 2 Jun 2006 02:18:56 +0000 (02:18 +0000)]
Reviewed by Maciej.
Missed an initialization in my last checkin which caused too many
resizers to be drawn.
* rendering/render_style.cpp: (WebCore::resize):
Initialize resize to RESIZE_NONE.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14676
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 2 Jun 2006 01:13:58 +0000 (01:13 +0000)]
Implement form posting via WinINet. This code is crazy... CRAZY
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14675
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Fri, 2 Jun 2006 00:05:15 +0000 (00:05 +0000)]
Reviewed by Hyatt.
Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9216
Implement CSS3 resize property
* css/html4.css: Sets resize:both for textareas. This won't affect old-style textareas.
* css/CSSPropertyNames.in: Added resize property.
* css/cssparser.cpp: (WebCore::CSSParser::parseValue): Added case for CSS_PROP_RESIZE.
* css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): ditto.
* css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): ditto.
* rendering/render_style.cpp: (WebCore::StyleCSS3InheritedData): Initialize resize.
* rendering/render_style.h:
(WebCore::): Added EResize enum.
(WebCore::RenderStyle::resize):
(WebCore::RenderStyle::setResize):
(WebCore::RenderStyle::initialResize):
* page/FrameView.cpp:
(WebCore::FrameViewPrivate::FrameViewPrivate): Added m_resizeLayer to keep track of a layer that has begun resizing.
(WebCore::FrameViewPrivate::reset): Reset m_resizeLayer.
(WebCore::FrameView::handleMousePressEvent): If the mouse was pressed in a layer's resize control, then put the layer into resize mode.
(WebCore::selectCursor): Updated so we get a pointer cursor for the resize control.
(WebCore::FrameView::handleMouseMoveEvent): If there's a layer currently resizing, then tell the layer to continue resizing.
(WebCore::FrameView::handleMouseReleaseEvent): If there's a layer currently resizing, then pull it out of resize mode.
* rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInScrollbar): Updated so the resize control isn't considered part of the scrollbar.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer): Initialize m_inResizeMode
(WebCore::RenderLayer::updateLayerPositions): Calls positionResizeControl.
(WebCore::RenderLayer::resize): Added. Sets a new width and height based on the current mouse point.
(WebCore::RenderLayer::isPointInResizeControl): Added.
(WebCore::RenderLayer::positionResizeControl): Added.
(WebCore::RenderLayer::positionScrollbars): Calls positionResizeControl.
(WebCore::RenderLayer::paintScrollbars): Calls positionResizeControl.
(WebCore::RenderLayer::paintResizeControl): Added.
(WebCore::RenderLayer::paintLayer): Calls paintResizeControl.
* rendering/RenderLayer.h: Added m_inResizeMode.
(WebCore::RenderLayer::resizeControlRect):
(WebCore::RenderLayer::setResizeControlRect):
(WebCore::RenderLayer::inResizeMode): Added.
(WebCore::RenderLayer::setInResizeMode): Added.
* platform/mac/ImageMac.mm: (WebCore::Image::loadResource): Moved code from WebImageRendererFactory. Now loads images from WebCore's resources.
WebImageRendererFactory is no longer used and should be removed.
* Resources/missingImage.tiff: Added. Copied from WebKit.
* WebCore.xcodeproj/project.pbxproj: Added missingImage.tiff
* loader/Cache.cpp: (WebCore::Cache::init): Updated name from missing_image to missingImage.
* rendering/RenderTheme.h:
* rendering/RenderTheme.cpp: (WebCore::RenderTheme::paintResizeControl): Added.
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::RenderThemeMac): Initialize resizeCornerImage.
(WebCore::RenderThemeMac::paintResizeControl): Paints resizeCornerImage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14674
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Thu, 1 Jun 2006 23:02:47 +0000 (23:02 +0000)]
WebKit:
Simple changes to hook up the new WebCore based Icon Database
for testing.
WebCore:
Added the beginnings of sqlite-based code in a WebCore
based version of the Icon Database. Right now the code
is very loosely hooked up through a Bridge and only
creates an sqlite3 database.
There are also changes to our String classes to allow appending
a single character to a String without creating a temporary object.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14673
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 1 Jun 2006 22:23:59 +0000 (22:23 +0000)]
2006-06-01 Mitz Pettel <opendarwin.org@mitzpettel.com>
Reviewed and landed by Anders.
- fixed all places in the Canvas to RenderView rename patch where
view() should have been changed to frameView().
* kwq/WebCoreAXObject.mm:
(-[WebCoreAXObject position]):
(-[WebCoreAXObject accessibilityAttributeValue:]):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBackgroundExtended):
* rendering/RenderTreeAsText.cpp:
(externalRepresentation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14672
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 1 Jun 2006 21:52:17 +0000 (21:52 +0000)]
LayoutTests:
- Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9113
REGRESSION (14581): XMLHttpRequest never calls onreadystatechange with
a readystate == 4
* http/tests/xmlhttprequest/event-listener-gc.html: Added.
* http/tests/xmlhttprequest/event-listener-gc-expected.txt: Added.
WebCore:
Fix by Mitz. Reviewed, tweaked, tested, landed by me.
- Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=9113
REGRESSION (14581): XMLHttpRequest never calls onreadystatechange with
a readystate == 4
An XMLHttpRequest must be added to the DOMObject cache so that its
DOM implementation object can protect it, and by extension, its event
listeners.
This design seems slightly backwards to me -- the bindings should know
about the DOM, not the other way around -- but I'm restoring it for
now to fix the regression.
* bindings/js/JSXMLHttpRequest.cpp:
(KJS::JSXMLHttpRequest::JSXMLHttpRequest):
(KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14671
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 1 Jun 2006 21:41:42 +0000 (21:41 +0000)]
2006-06-01 Anders Carlsson <acarlsson@apple.com>
* platform/KURL.cpp:
(equalIgnoringRef):
Whoops. Fix build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14670
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 1 Jun 2006 21:29:31 +0000 (21:29 +0000)]
WebCore:
2006-06-01 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6309
multiple problems prevent bookmarking/back button technique for AJAX/DHTML applications from working
* bindings/js/kjs_window.cpp:
(KJS::Location::put):
Handle the case where the hash starts with a "#". Also, don't do anything if the previous and new hashes
are equal.
* bridge/BrowserExtension.h:
* bridge/mac/BrowserExtensionMac.h:
* bridge/mac/BrowserExtensionMac.mm:
(WebCore::BrowserExtensionMac::historyURL):
* bridge/mac/WebCoreFrameBridge.h:
* bridge/mac/WebCoreFrameBridge.mm:
New function historyURL which returns the complete URL for a given item in the history.
* page/Frame.cpp:
(WebCore::Frame::scheduleLocationChange):
(WebCore::Frame::scheduleHistoryNavigation):
If the URL of the new location only differs in the hash, don't schedule the load. Instead, load it
directly.
* platform/KURL.cpp:
* platform/KURL.h:
Add equalsIgnoringRef which returns whether two URLs are equal, ignoring the ref.
WebKit:
2006-06-01 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6309
multiple problems prevent bookmarking/back button technique for AJAX/DHTML applications from working
* Misc/WebNSURLExtras.m:
(-[NSString _webkit_URLFragment]):
Don't include the "#" character in the fragment.
* WebCoreSupport/WebFrameBridge.m:
(-[WebFrameBridge historyURL:]):
New function, returns the history URL for a given position in the back/forward list
* WebView/WebFrame.m:
(-[WebFrame _loadItem:withLoadType:]):
Always call scrollToAnchorWithURL, even if there is no fragment. This way we keep the WebCore frame's
URL up-to-date.
WebKitTools:
2006-06-01 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
* DumpRenderTree/DumpRenderTree.m:
(+[LayoutTestController isSelectorExcludedFromWebScript:]):
(-[LayoutTestController clearBackForwardList]):
Add clearBackForwardList function to layoutTestController
LayoutTests:
2006-06-01 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6309
multiple problems prevent bookmarking/back button technique for AJAX/DHTML applications from working
* fast/dom/location-hash-expected.txt: Added.
* fast/dom/location-hash.html: Added.
Added tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14669
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 1 Jun 2006 19:06:09 +0000 (19:06 +0000)]
2006-06-01 Anders Carlsson <acarlsson@apple.com>
Reviewed by Maciej.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9212
dispatchEvent13.html crashes under GuardMalloc
* dom/EventTargetNode.cpp:
(WebCore::EventTargetNode::addEventListener):
(WebCore::EventTargetNode::removeEventListener):
(WebCore::EventTargetNode::handleLocalEvents):
(WebCore::EventTargetNode::removeHTMLEventListener):
(WebCore::EventTargetNode::getHTMLEventListener):
* dom/EventTargetNode.h:
Make the list of registered event listeners refcount the listeners
by using a value list of RefPtr objects.
Set removed flag to true in removeEventListener
Only invoke event listeners if they don't have the removed flag.
* dom/dom2_eventsimpl.cpp:
(WebCore::RegisteredEventListener::RegisteredEventListener):
* dom/dom2_eventsimpl.h:
Make RegisteredEventListener refcounted.
(WebCore::RegisteredEventListener::removed):
(WebCore::RegisteredEventListener::setRemoved):
Add removed flag and getter and setter
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14668
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 1 Jun 2006 19:01:39 +0000 (19:01 +0000)]
LayoutTests:
Reviewed by Anders.
- fixed "REGRESSION: Can't order from Pizza Hut (ToT, 05/24/06)"
http://bugzilla.opendarwin.org/show_bug.cgi?id=9103
* http/tests/misc/redirect-expected.txt: Added.
* http/tests/misc/redirect.php: Added.
* http/tests/misc/resources/redirect-result.php: Added.
WebKit:
Reviewed by Anders.
- fixed "REGRESSION: Can't order from Pizza Hut (ToT, 05/24/06)"
http://bugzilla.opendarwin.org/show_bug.cgi?id=9103
* WebView/WebDataSource.m:
(-[WebDataSource _willSendRequest:forResource:redirectResponse:]): Set up the
User-Agent header.
* WebView/WebDataSourceInternal.h:
* WebView/WebLoader.m:
(-[NSURLProtocol willSendRequest:redirectResponse:]): Pass a mutable URL request
so the above can work.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14667
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 1 Jun 2006 18:33:28 +0000 (18:33 +0000)]
LayoutTests:
Reviewed by harrison
* editing/selection/focus-body-expected.checksum: Added.
* editing/selection/focus-body-expected.png: Added.
* editing/selection/focus-body-expected.txt: Added.
* editing/selection/focus-body.html: Added.
* editing/selection/focus_editable_html-expected.checksum:
* editing/selection/focus_editable_html-expected.png:
* editing/selection/focus_editable_html-expected.txt:
WebCore:
Reviewed by harrison
<rdar://problem/
4567752> When forwarding a message, pressing TAB key to place caret in body actually selects the entire message instead
* dom/Element.cpp:
(WebCore::Element::focus):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14666
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 1 Jun 2006 17:35:45 +0000 (17:35 +0000)]
WebKit:
2006-06-01 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
* WebView/WebFrameView.m:
(+[WebFrameView _canShowMIMETypeAsHTML:]):
Use _webkit_objectForMIMEType here so we'll get an object back for "text/".
WebKitTools:
2006-06-01 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=8996
slow-utf8-text layout test case failing (no longer deterministic?)
* DumpRenderTree/DumpRenderTree.m:
(dump):
Dump as text when the response MIME type is text/plain
LayoutTests:
2006-06-01 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=8996
slow-utf8-text layout test case failing (no longer deterministic?)
* http/tests/incremental/slow-utf8-text-expected.txt:
Updated
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14665
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Thu, 1 Jun 2006 11:00:37 +0000 (11:00 +0000)]
2006-06-01 David Kilzer <ddkilzer@kilzer.net>
Reviewed by darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9144
Test for Bug 8079 (REGRESSION: Redraw from page cache does not show visited links)
* manual-tests/redraw-page-cache-visited-links.html: Added.
* manual-tests/resources/redraw-page-cache-visited-links-2.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14664
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Thu, 1 Jun 2006 06:34:24 +0000 (06:34 +0000)]
LayoutTests:
Reviewed by Hyatt.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9124
Drop shadow obscures "add more stuff" bubble at live.com
* fast/css/find-next-layer-expected.checksum: Added.
* fast/css/find-next-layer-expected.png: Added.
* fast/css/find-next-layer-expected.txt: Added.
* fast/css/find-next-layer.html: Added.
WebCore:
Reviewed by Hyatt.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9124
Drop shadow obscures "add more stuff" bubble at live.com
Test: fast/css/find-next-layer.html
* rendering/RenderObject.cpp:
(WebCore::RenderObject::findNextLayer): Fixed a bug where this function could reach
two levels down in the layer tree and return 0.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14663
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Thu, 1 Jun 2006 06:30:08 +0000 (06:30 +0000)]
Reviewed by Geoff.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9109
Remove bogus assertion in RenderBlock::tabWidth
Changed the uninitialized value of m_tabWidth to -1 and removed the
assertion that it cannot be 0.
* rendering/RenderBlock.cpp:
(WebCore:::RenderBlock::RenderBlock):
(WebCore::RenderBlock::setStyle):
* rendering/bidi.cpp:
(WebCore::RenderBlock::tabWidth):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14662
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Thu, 1 Jun 2006 06:24:56 +0000 (06:24 +0000)]
Updated test results for bugzilla.opendarwin.org/show_bug.cgi?id=8848
TFOOT borders are copied to THEAD and TBODY
* tables/mozilla/marvin/backgr_layers-opacity-expected.checksum:
* tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
* tables/mozilla/marvin/backgr_position-table-expected.checksum:
* tables/mozilla/marvin/backgr_position-table-expected.txt:
* tables/mozilla/marvin/backgr_simple-table-cell-expected.checksum:
* tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
* tables/mozilla/marvin/backgr_simple-table-column-expected.checksum:
* tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
* tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum:
* tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
* tables/mozilla/marvin/backgr_simple-table-expected.checksum:
* tables/mozilla/marvin/backgr_simple-table-expected.txt:
* tables/mozilla/marvin/backgr_simple-table-row-expected.checksum:
* tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
* tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum:
* tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
* tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.checksum:
* tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
* tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
* tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
* tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
* tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
* tables/mozilla_expected_failures/marvin/backgr_border-table-expected.checksum:
* tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
* tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.checksum:
* tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
* tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
* tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
* tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum:
* tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
* tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
* tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
* tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum:
* tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
* tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.checksum:
* tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
* tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.checksum:
* tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
* tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum:
* tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
* tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum:
* tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
* tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum:
* tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
* tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum:
* tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14661
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Thu, 1 Jun 2006 06:16:28 +0000 (06:16 +0000)]
LayoutTests:
Reviewed by Hyatt.
- tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=9100
Absolutely positioned replaced elements with all non-auto
values are rendered incorrectly
* fast/replaced/absolute-position-with-auto-height-and-top-and-bottom.html: Added.
* fast/replaced/absolute-position-with-auto-width-and-left-and-right.html: Added.
WebCore:
Reviewed by Hyatt.
- fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9100
Absolutely positioned replaced elements with all non-auto
values are rendered incorrectly
* rendering/RenderBox.cpp:
(WebCore::RenderBox::calcAbsoluteHorizontalReplaced): Add support for case when all values are specified.
(WebCore::RenderBox::calcAbsoluteVerticalReplaced): ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14660
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Thu, 1 Jun 2006 06:07:23 +0000 (06:07 +0000)]
LayoutTests:
Reviewed by Hyatt.
- test and updated results for
http://bugzilla.opendarwin.org/show_bug.cgi?id=9012
Row height not updated when cell heights change
* fast/table/row-height-recalc-expected.checksum: Added.
* fast/table/row-height-recalc-expected.png: Added.
* fast/table/row-height-recalc-expected.txt: Added.
* fast/table/row-height-recalc.html: Added.
WebCore:
Reviewed by Hyatt.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9012
Row height not updated when cell heights change
Test: fast/table/row-height-recalc.html
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::setStyle): Mark the section as needing recalculation
if the height property changed.
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::setStyle): Ditto.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::recalcCells): Initialize the grid row height
to the height of the row element (like addChild() does).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14659
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Thu, 1 Jun 2006 05:56:54 +0000 (05:56 +0000)]
Reviewed by Hyatt.
- fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8969
REGRESSION: typing in textfield repaints whole web page at gamefaqs.com
No test possible (no functionality change)
* dom/Document.cpp:
(WebCore::Document::updateLayout): Changed to ensure that pending subtree
layouts are performed too.
* page/Frame.cpp:
(WebCore::Frame::forceLayout): Force a full layout.
* page/FrameView.cpp:
(WebCore::FrameViewPrivate::reset):
(WebCore::FrameView::layout): Changed to relayout only the subtree rooted
at d->layoutRoot if it's non-zero and allowSubtree is true.
(WebCore::FrameView::scheduleRelayout): Change pending subtree relayout into
normal relayout by clearing d->layoutRoot and propagating needsLayout to the
root.
(WebCore::FrameView::scheduleRelayoutOfSubtree): Added.
* page/FrameView.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::markContainingBlocksForLayout): Added scheduleRelayout
parameter. FrameView passes false to force marking all the way to the root
when turning a pending subtree relayout into a full relayout. Otherwise,
marking stops at the first textField (or at the root) and
relayout of the last object reached is scheduled.
(WebCore::RenderObject::scheduleRelayout):
* rendering/RenderObject.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14658
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Thu, 1 Jun 2006 05:35:28 +0000 (05:35 +0000)]
Reviewed by Darin.
patch for <http://bugzilla.opendarwin.org/show_bug.cgi?id=8910>
Bug 8910: Various code cleanups in RenderBox
Clean up with some slight optimizations.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::contentWidth):
(WebCore::RenderBox::contentHeight):
(WebCore::RenderBox::setPos):
(WebCore::RenderBox::calcWidth):
(WebCore::RenderBox::calcWidthUsing):
* rendering/RenderBox.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14657
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Thu, 1 Jun 2006 05:28:13 +0000 (05:28 +0000)]
Reviewed by Hyatt.
patch for <http://bugzilla.opendarwin.org/show_bug.cgi?id=8899>
Bug 8899: Removes some unneeded code from RenderBox
Removes the use of WidthType where not needed to simplify
the code a little.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::calcWidthUsing):
(WebCore::RenderBox::sizesToIntrinsicWidth):
(WebCore::RenderBox::calcReplacedWidth):
(WebCore::RenderBox::calcReplacedWidthUsing):
(WebCore::RenderBox::calcReplacedHeight):
(WebCore::RenderBox::calcReplacedHeightUsing):
* rendering/RenderBox.h:
(WebCore::):
(WebCore::RenderBox::renderName):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::calcReplacedWidth):
(WebCore::RenderImage::calcReplacedHeight):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14656
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Thu, 1 Jun 2006 05:09:01 +0000 (05:09 +0000)]
LayoutTests:
Reviewed by Geoff.
Testcase for http://bugzilla.opendarwin.org/show_bug.cgi?id=8455
* fast/forms/select-reset.html: Added.
WebCore:
Reviewed by Geoff.
Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8455
selectedIndex for a select after a Form reset() has wrong value
Make sure the list items are reset properly by selecting
the first option in case no options have the selected attribute
set.
* html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::reset):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14655
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Thu, 1 Jun 2006 05:02:18 +0000 (05:02 +0000)]
LayoutTests:
Reviewed by Geoff.
Add a test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8024
* fast/dom/document-all-input.html: Added.
WebCore:
Reviewed by Geoff.
Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8024
"Go" button (search) doesn't work at fifa.com (document.all.FormName)
Allow input elements with name attributes as possible named
items for document.all.
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::checkForNameMatch):
(WebCore::HTMLCollection::updateNameCache):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14654
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 1 Jun 2006 01:06:13 +0000 (01:06 +0000)]
Tweaks to remove fragments when loading urls via wininet or cookies.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14653
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 31 May 2006 22:19:04 +0000 (22:19 +0000)]
Add stubs for bmp/ico/xbm decoders on win32.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14652
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 31 May 2006 21:36:19 +0000 (21:36 +0000)]
WebCore:
Fix for the gmail tab-focus-stealing bug.
Reviewed by darin
* bindings/js/kjs_window.cpp:
(KJS::WindowFunc::callAsFunction):
* bridge/mac/BrowserExtensionMac.mm:
(WebCore::BrowserExtensionMac::createNewWindow):
* bridge/mac/FrameMac.h:
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::focusWindow):
(WebCore::FrameMac::unfocusWindow):
* bridge/mac/WebCoreFrameBridge.h:
* page/Frame.h:
* platform/Widget.h:
* platform/mac/WidgetMac.mm:
* platform/win/TemporaryLinkStubs.cpp:
(FrameWin::focusWindow):
* platform/win/WidgetWin.cpp:
WebKit:
Make programmatic focus/blur actually work on sub-frames. Make the
top-level UI delegate get called for deactivation of windows.
Reviewed by darin
* WebCoreSupport/WebFrameBridge.m:
(-[WebFrameBridge activateWindow]):
(-[WebFrameBridge deactivateWindow]):
(-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
(-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14651
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Wed, 31 May 2006 21:30:21 +0000 (21:30 +0000)]
Reviewed by Hyatt.
Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6755 CSS3:
Borders rounded with border-radius don't draw the roundings
This patch does not draw all of the different border styles
perfectly, so I have filed a few followup bugs that I will
reference from this Bugzilla.
* platform/GraphicsContext.h:
* platform/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawArc): drawArc() has different
parameters now, but mostly this needs to be implemented to match
the Mac side later.
(WebCore::GraphicsContext::addRoundedRectClip): Just a stub.
Implement this later.
(WebCore::GraphicsContext::addInnerRoundedRectClip): Just a stub.
Implement this later.
* platform/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawArc): drawArc() now handles drawing
elliptical arcs as well as circular arcs, it also takes a thickness
parameter to draw an arc of a given thickness and draws with the
appropriate pen style.
(WebCore::GraphicsContext::addInnerRoundedRectClip): Adds a clip to
the inside of an arc instead of to the outside which is already
done by addRoundedClipRect()
* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawBorderArc): Draws the border arcs in
the appropriate styles.
(WebCore::RenderObject::paintBorder): Calls drawBorderArc() when
border arcs are needed.
* rendering/RenderObject.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14650
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 31 May 2006 20:05:01 +0000 (20:05 +0000)]
Fix Win32 build bustage from Screen/Page FloatRect conversion
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14649
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 31 May 2006 18:04:24 +0000 (18:04 +0000)]
Remove accidentally-checked-in file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14647
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 31 May 2006 17:25:30 +0000 (17:25 +0000)]
2006-05-30 Eric Seidel <eric@eseidel.com>
Reviewed by andersca.
Add first-cut SVG JS bindings autogeneration.
SVGSVGElement and various other support classes are generated.
Various small style fixes.
http://bugzilla.opendarwin.org/show_bug.cgi?id=4249
* DerivedSources.make:
* WebCore+SVG/RGBColor.cpp: Removed.
* WebCore+SVG/RGBColor.h: Removed.
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSHTMLElementWrapperFactory.cpp:
(WebCore::createJSHTMLWrapper): renamed from createJSWrapper
* bindings/js/JSHTMLElementWrapperFactory.h:
* bindings/js/kjs_dom.cpp:
(KJS::DOMNode::DOMNode):
(KJS::DOMNode::toBoolean):
(KJS::DOMNode::getOwnPropertySlot):
(KJS::DOMNode::getValueProperty):
(KJS::DOMNode::put):
(KJS::DOMNode::putValueProperty):
(KJS::DOMNode::toPrimitive):
(KJS::DOMNode::toString):
(KJS::DOMNodeProtoFunc::callAsFunction):
(KJS::toEventTargetNode):
(KJS::DOMEventTargetNode::getOwnPropertySlot):
(KJS::DOMEventTargetNode::getValueProperty):
(KJS::DOMEventTargetNode::put):
(KJS::DOMEventTargetNode::putValueProperty):
(KJS::DOMEventTargetNode::setListener):
(KJS::DOMEventTargetNode::getListener):
(KJS::DOMEventTargetNode::pushEventHandlerScope):
(KJS::DOMEventTargetNodeProtoFunc::callAsFunction):
(KJS::DOMNodeList::toPrimitive):
(KJS::DOMNodeList::getValueProperty):
(KJS::DOMNodeList::indexGetter):
(KJS::DOMNodeList::nameGetter):
(KJS::DOMNodeList::getOwnPropertySlot):
(KJS::DOMNodeList::callAsFunction):
(KJS::DOMNodeListFunc::callAsFunction):
(KJS::toElement):
(KJS::toDocumentType):
(KJS::DOMNamedNodeMap::DOMNamedNodeMap):
(KJS::DOMNamedNodeMap::~DOMNamedNodeMap):
(KJS::DOMNamedNodeMap::lengthGetter):
(KJS::DOMNamedNodeMap::indexGetter):
(KJS::DOMNamedNodeMap::nameGetter):
(KJS::DOMNamedNodeMapProtoFunc::callAsFunction):
(KJS::toJS):
(KJS::checkNodeSecurity):
(KJS::getRuntimeObject):
(KJS::DOMExceptionConstructor::getOwnPropertySlot):
(KJS::DOMExceptionConstructor::getValueProperty):
(KJS::getDOMExceptionConstructor):
(KJS::DOMNamedNodesCollection::DOMNamedNodesCollection):
(KJS::DOMNamedNodesCollection::lengthGetter):
(KJS::DOMNamedNodesCollection::indexGetter):
(KJS::DOMNamedNodesCollection::getOwnPropertySlot):
* bindings/scripts/CodeGenerator.pm:
* bindings/scripts/CodeGeneratorJS.pm:
* dom/Document.cpp:
(WebCore::Document::implicitClose):
* dom/Element.h:
* dom/StyledElement.h:
* ksvg2/bindings/idl/svg/SVGAngle.idl: Removed.
* ksvg2/bindings/idl/svg/SVGAnimatedLength.idl: Removed.
* ksvg2/bindings/idl/svg/SVGColor.idl: Removed.
* ksvg2/bindings/idl/svg/SVGDocument.idl: Removed.
* ksvg2/bindings/idl/svg/SVGElement.idl: Removed.
* ksvg2/bindings/idl/svg/SVGLength.idl: Removed.
* ksvg2/bindings/idl/svg/SVGMatrix.idl: Removed.
* ksvg2/bindings/idl/svg/SVGNumber.idl: Removed.
* ksvg2/bindings/idl/svg/SVGPoint.idl: Removed.
* ksvg2/bindings/idl/svg/SVGRect.idl: Removed.
* ksvg2/bindings/idl/svg/SVGSVGElement.idl: Removed.
* ksvg2/bindings/idl/svg/SVGTransform.idl: Removed.
* ksvg2/bindings/idl/svg/kdomdefs.idl: Removed.
* ksvg2/bindings/js: Added.
* ksvg2/bindings/js/JSSVGNumber.cpp: Added.
(WebCore::):
(WebCore::JSSVGNumber::~JSSVGNumber):
(WebCore::JSSVGNumber::getOwnPropertySlot):
(WebCore::JSSVGNumber::getValue):
(WebCore::getJSSVGNumber):
* ksvg2/bindings/js/JSSVGNumber.h: Added.
(WebCore::JSSVGNumber::JSSVGNumber):
(WebCore::JSSVGNumber::classInfo):
* ksvg2/bindings/js/JSSVGPoint.cpp: Added.
(WebCore::):
(WebCore::JSSVGPoint::~JSSVGPoint):
(WebCore::JSSVGPoint::getOwnPropertySlot):
(WebCore::JSSVGPoint::getValueProperty):
(WebCore::getJSSVGPoint):
(WebCore::toFloatPoint):
* ksvg2/bindings/js/JSSVGPoint.h: Added.
(WebCore::JSSVGPoint::JSSVGPoint):
(WebCore::JSSVGPoint::classInfo):
(WebCore::JSSVGPoint::):
(WebCore::JSSVGPoint::impl):
* ksvg2/bindings/js/JSSVGRect.cpp: Added.
(WebCore::):
(WebCore::JSSVGRect::~JSSVGRect):
(WebCore::JSSVGRect::getOwnPropertySlot):
(WebCore::JSSVGRect::getValueProperty):
(WebCore::getJSSVGRect):
(WebCore::toFloatRect):
* ksvg2/bindings/js/JSSVGRect.h: Added.
(WebCore::JSSVGRect::JSSVGRect):
(WebCore::JSSVGRect::classInfo):
(WebCore::JSSVGRect::):
(WebCore::JSSVGRect::impl):
* ksvg2/css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
* ksvg2/css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty):
* ksvg2/events/SVGZoomEvent.cpp:
(SVGZoomEvent::SVGZoomEvent):
(SVGZoomEvent::zoomRectScreen):
(SVGZoomEvent::previousTranslate):
(SVGZoomEvent::newTranslate):
* ksvg2/events/SVGZoomEvent.h:
* ksvg2/ksvg.h:
(WebCore::):
* ksvg2/misc/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::SVGDocumentExtensions):
(WebCore::SVGDocumentExtensions::~SVGDocumentExtensions):
(WebCore::SVGDocumentExtensions::addTimeContainer):
(WebCore::SVGDocumentExtensions::removeTimeContainer):
(WebCore::SVGDocumentExtensions::startAnimations):
(WebCore::SVGDocumentExtensions::pauseAnimations):
(WebCore::SVGDocumentExtensions::unpauseAnimations):
* ksvg2/misc/SVGDocumentExtensions.h:
* ksvg2/svg/SVGAElement.h:
* ksvg2/svg/SVGAngle.h:
(WebCore::SVGAngle::):
* ksvg2/svg/SVGAngle.idl: Added.
* ksvg2/svg/SVGAnimateColorElement.cpp:
(WebCore::SVGAnimateColorElement::SVGAnimateColorElement):
(WebCore::SVGAnimateColorElement::handleTimerEvent):
(WebCore::SVGAnimateColorElement::clampColor):
* ksvg2/svg/SVGAnimateColorElement.h:
* ksvg2/svg/SVGAnimateElement.cpp:
(SVGAnimateElement::SVGAnimateElement):
(SVGAnimateElement::handleTimerEvent):
* ksvg2/svg/SVGAnimateElement.h:
* ksvg2/svg/SVGAnimateTransformElement.cpp:
(WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
(WebCore::SVGAnimateTransformElement::parseMappedAttribute):
(WebCore::SVGAnimateTransformElement::handleTimerEvent):
(WebCore::SVGAnimateTransformElement::parseTransformValue):
(WebCore::SVGAnimateTransformElement::calculateRotationFromMatrix):
(WebCore::SVGAnimateTransformElement::initialMatrix):
* ksvg2/svg/SVGAnimateTransformElement.h:
* ksvg2/svg/SVGAnimatedLength.idl: Added.
* ksvg2/svg/SVGAnimationElement.cpp:
(SVGAnimationElement::closeRenderer):
* ksvg2/svg/SVGAnimationElement.h:
* ksvg2/svg/SVGCircleElement.h:
* ksvg2/svg/SVGClipPathElement.h:
* ksvg2/svg/SVGColor.cpp:
(WebCore::SVGColor::SVGColor):
(WebCore::SVGColor::rgbColor):
(WebCore::SVGColor::setRGBColor):
(WebCore::SVGColor::setRGBColorICCColor):
(WebCore::SVGColor::setColor):
(WebCore::SVGColor::color):
* ksvg2/svg/SVGColor.h:
(WebCore::SVGColor::):
(WebCore::SVGColor::setRGBColor):
* ksvg2/svg/SVGColor.idl: Added.
* ksvg2/svg/SVGComponentTransferFunctionElement.h:
* ksvg2/svg/SVGCursorElement.h:
* ksvg2/svg/SVGDefsElement.h:
* ksvg2/svg/SVGDescElement.h:
* ksvg2/svg/SVGDocument.idl: Added.
* ksvg2/svg/SVGElement.cpp:
(WebCore::SVGElement::SVGElement):
(WebCore::SVGElement::isSupported):
(WebCore::SVGElement::id):
(WebCore::SVGElement::setId):
(WebCore::SVGElement::xmlbase):
(WebCore::SVGElement::setXmlbase):
(WebCore::SVGElement::ownerSVGElement):
(WebCore::SVGElement::viewportElement):
(WebCore::SVGElement::tryGetAttribute):
(WebCore::SVGElement::tryGetAttributeNS):
(WebCore::SVGElement::childShouldCreateRenderer):
* ksvg2/svg/SVGElement.h:
* ksvg2/svg/SVGElement.idl: Added.
* ksvg2/svg/SVGEllipseElement.h:
* ksvg2/svg/SVGEvent.idl: Added.
* ksvg2/svg/SVGFEBlendElement.h:
* ksvg2/svg/SVGFEColorMatrixElement.h:
* ksvg2/svg/SVGFEComponentTransferElement.h:
* ksvg2/svg/SVGFECompositeElement.h:
* ksvg2/svg/SVGFEDiffuseLightingElement.h:
* ksvg2/svg/SVGFEDistantLightElement.h:
* ksvg2/svg/SVGFEFloodElement.h:
* ksvg2/svg/SVGFEFuncAElement.h:
* ksvg2/svg/SVGFEFuncBElement.h:
* ksvg2/svg/SVGFEFuncGElement.h:
* ksvg2/svg/SVGFEFuncRElement.h:
* ksvg2/svg/SVGFEGaussianBlurElement.h:
* ksvg2/svg/SVGFEImageElement.h:
* ksvg2/svg/SVGFELightElement.h:
* ksvg2/svg/SVGFEMergeElement.h:
* ksvg2/svg/SVGFEMergeNodeElement.h:
* ksvg2/svg/SVGFEOffsetElement.h:
* ksvg2/svg/SVGFEPointLightElement.h:
* ksvg2/svg/SVGFESpecularLightingElement.h:
* ksvg2/svg/SVGFESpotLightElement.h:
* ksvg2/svg/SVGFETileElement.h:
* ksvg2/svg/SVGFETurbulenceElement.h:
* ksvg2/svg/SVGFilterElement.h:
* ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
* ksvg2/svg/SVGForeignObjectElement.h:
* ksvg2/svg/SVGGElement.h:
* ksvg2/svg/SVGGradientElement.h:
* ksvg2/svg/SVGHelper.cpp:
(WebCore::SVGHelper::PercentageOfViewport):
(WebCore::SVGHelper::ParseSeperatedList):
* ksvg2/svg/SVGImageElement.h:
* ksvg2/svg/SVGLength.h:
(WebCore::SVGLength::):
* ksvg2/svg/SVGLength.idl: Added.
* ksvg2/svg/SVGLineElement.h:
* ksvg2/svg/SVGLinearGradientElement.h:
* ksvg2/svg/SVGLocatable.cpp:
(SVGLocatable::getBBox):
* ksvg2/svg/SVGLocatable.h:
* ksvg2/svg/SVGMarkerElement.h:
* ksvg2/svg/SVGMaskElement.h:
* ksvg2/svg/SVGMatrix.cpp:
(SVGMatrix::inverse):
(SVGMatrix::rotateFromVector):
* ksvg2/svg/SVGMatrix.h:
* ksvg2/svg/SVGMatrix.idl: Added.
* ksvg2/svg/SVGNumber.idl: Added.
* ksvg2/svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::getPointAtLength):
* ksvg2/svg/SVGPathElement.h:
* ksvg2/svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::x):
(WebCore::SVGPatternElement::y):
(WebCore::SVGPatternElement::width):
(WebCore::SVGPatternElement::height):
(WebCore::SVGPatternElement::pushAttributeContext):
(WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
(WebCore::SVGPatternElement::drawPatternContentIntoTile):
(WebCore::SVGPatternElement::notifyClientsToRepaint):
(WebCore::SVGPatternElement::notifyAttributeChange):
(WebCore::SVGPatternElement::canvasResource):
(WebCore::SVGPatternElement::getCTM):
* ksvg2/svg/SVGPatternElement.h:
* ksvg2/svg/SVGPoint.idl: Added.
* ksvg2/svg/SVGPolyElement.h:
* ksvg2/svg/SVGPolygonElement.h:
* ksvg2/svg/SVGPolylineElement.h:
* ksvg2/svg/SVGRadialGradientElement.h:
* ksvg2/svg/SVGRect.idl: Added.
* ksvg2/svg/SVGRectElement.h:
* ksvg2/svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement):
(WebCore::SVGSVGElement::~SVGSVGElement):
(WebCore::SVGSVGElement::viewport):
(WebCore::SVGSVGElement::currentTranslate):
(WebCore::SVGSVGElement::unsuspendRedraw):
(WebCore::SVGSVGElement::getIntersectionList):
(WebCore::SVGSVGElement::getEnclosureList):
(WebCore::SVGSVGElement::checkIntersection):
(WebCore::SVGSVGElement::checkEnclosure):
(WebCore::SVGSVGElement::createSVGNumber):
(WebCore::SVGSVGElement::createSVGPoint):
(WebCore::SVGSVGElement::createSVGRect):
(WebCore::SVGSVGElement::pauseAnimations):
(WebCore::SVGSVGElement::unpauseAnimations):
(WebCore::SVGSVGElement::animationsPaused):
(WebCore::SVGSVGElement::getCurrentTime):
(WebCore::SVGSVGElement::setCurrentTime):
* ksvg2/svg/SVGSVGElement.h:
(WebCore::SVGSVGElement::timeScheduler):
* ksvg2/svg/SVGSVGElement.idl: Added.
* ksvg2/svg/SVGScriptElement.h:
* ksvg2/svg/SVGSetElement.cpp:
(WebCore::SVGSetElement::SVGSetElement):
(WebCore::SVGSetElement::handleTimerEvent):
* ksvg2/svg/SVGSetElement.h:
* ksvg2/svg/SVGStopElement.h:
* ksvg2/svg/SVGStyleElement.h:
* ksvg2/svg/SVGStyledElement.h:
* ksvg2/svg/SVGStyledLocatableElement.cpp:
(SVGStyledLocatableElement::getBBox):
* ksvg2/svg/SVGStyledLocatableElement.h:
* ksvg2/svg/SVGStyledTransformableElement.cpp:
(SVGStyledTransformableElement::getBBox):
* ksvg2/svg/SVGStyledTransformableElement.h:
* ksvg2/svg/SVGSwitchElement.h:
* ksvg2/svg/SVGSymbolElement.h:
* ksvg2/svg/SVGTRefElement.h:
* ksvg2/svg/SVGTSpanElement.h:
* ksvg2/svg/SVGTextContentElement.cpp:
(SVGTextContentElement::getStartPositionOfChar):
(SVGTextContentElement::getEndPositionOfChar):
(SVGTextContentElement::getExtentOfChar):
(SVGTextContentElement::getCharNumAtPosition):
(SVGTextContentElement::parseMappedAttribute):
* ksvg2/svg/SVGTextContentElement.h:
* ksvg2/svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::getBBox):
* ksvg2/svg/SVGTextElement.h:
* ksvg2/svg/SVGTextPositioningElement.h:
* ksvg2/svg/SVGTitleElement.h:
* ksvg2/svg/SVGTransform.h:
(WebCore::SVGTransform::):
* ksvg2/svg/SVGTransform.idl: Added.
* ksvg2/svg/SVGUseElement.h:
* ksvg2/svg/SVGViewElement.h:
* page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore::Frame::pauseTimeouts):
(WebCore::Frame::resumeTimeouts):
* platform/Color.h:
* rendering/RenderBR.h:
* rendering/RenderBox.h:
(WebCore::RenderBox::renderName):
* rendering/RenderCanvas.h:
(WebCore::RenderCanvas::view):
* rendering/RenderContainer.h:
* rendering/RenderFlexibleBox.h:
* rendering/RenderFlow.h:
(WebCore::RenderFlow::RenderFlow):
* rendering/RenderInline.h:
* rendering/RenderTableSection.h:
* rendering/RenderTextFragment.h:
(WebCore::RenderTextFragment::contentString):
* xml/xmlattrs.in: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14646
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 31 May 2006 07:48:22 +0000 (07:48 +0000)]
Reviewed by Maciej.
- Fixed <rdar://problem/
4559720> window sizing: make javascript window
and screen sizing methods and properties work @ HIDPI
The general approach here is to change some ints to floats, make
a few key functions that scale between WebView and window/screen
coordinates, and change other functions that work with screen
coordinates to use the scaling functions for their underlying
implementations.
* manual-tests/window-open-features.html: Removed.
* manual-tests/window-sizing.html: Added. More test coverage.
* bindings/js/kjs_window.cpp: Changed ints to floats and IntRects to
FloatRects, because window coordinates can be fractional when scaled
to WebView/DOM coordinates.
(KJS::floatFeature):
(KJS::showModalDialog):
(KJS::Window::getValueProperty):
(KJS::constrainToVisible):
(KJS::WindowFunc::callAsFunction):
* bridge/BrowserExtension.h:
* bridge/mac/BrowserExtensionMac.mm:
(WebCore::BrowserExtensionMac::createNewWindow): Removed custom scaling
code and replaced with calls to Page::windowRect and
Page::setWindowRect. Renamed 'page' and 'bridge' to 'pageBridge' and
'frameBridge,' respectively.
* bridge/mac/PageMac.mm:
(WebCore::Page::windowRect): Changed to use scaling
(WebCore::Page::setWindowRect): ditto
* bridge/mac/WebCoreFrameBridge.mm:
(globalPoint):
* page/Page.h:
* platform/IntRect.h:
* platform/Screen.h:
* platform/mac/MouseEventMac.mm:
(WebCore::globalPositionForEvent): Changed to use flipScreenPoint
* platform/mac/ScreenMac.mm:
(WebCore::flipScreenRect): New key function
(WebCore::flipScreenPoint): New key function
(WebCore::scaleScreenRectToView): New key function
(WebCore::scaleViewRectToScreen): New key function
(WebCore::screenRect): Changed to use scaling
(WebCore::usableScreenRect): ditto
Feeble attempt to preserve Windows build:
* platform/win/ScreenWin.cpp:
(WebCore::scaleScreenRectToWidget): stub -- doesn't actually scale
(WebCore::scaleWidgetRectToScreen): ditto
* bridge/win/PageWin.cpp:
(WebCore::Page::Page):
(WebCore::Page::widget):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14643
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 31 May 2006 07:12:58 +0000 (07:12 +0000)]
Fix layout tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14642
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 31 May 2006 01:48:18 +0000 (01:48 +0000)]
Rename RenderCanvas to RenderView. Rename canvas(), isCanvas()
to view(), isView(). Rename the frame view accessor on the old canvas
from view() to frameView() (to avoid view()->view(), since that just looks
stupid). :)
Reviewed by andersca
* WebCore.vcproj/WebCore/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/kjs_dom.cpp:
* bindings/js/kjs_window.cpp:
* bridge/mac/FrameMac.mm:
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge _setupRootForPrinting:]):
(-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]):
(-[WebCoreFrameBridge selectionColor]):
(-[WebCoreFrameBridge accessibilityTree]):
* dom/Document.cpp:
(WebCore::Document::attach):
(WebCore::Document::updateSelection):
(WebCore::Document::prepareMouseEvent):
* editing/SelectionController.cpp:
* kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
* ksvg2/svg/SVGClipPathElement.cpp:
(SVGClipPathElement::canvasResource):
* ksvg2/svg/SVGFEFloodElement.cpp:
(SVGFEFloodElement::filterEffect):
* ksvg2/svg/SVGGradientElement.cpp:
(SVGGradientElement::rebuildStops):
* ksvg2/svg/SVGHelper.cpp:
(SVGHelper::PercentageOfViewport):
* ksvg2/svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::getPointAtLength):
* ksvg2/svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::currentTranslate):
* ksvg2/svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::view):
(WebCore::SVGStyledElement::pushAttributeContext):
* ksvg2/svg/SVGStyledElement.h:
* kwq/WebCoreAXObject.mm:
(-[WebCoreAXObject accessibilityShouldUseUniqueId]):
(-[WebCoreAXObject role]):
(-[WebCoreAXObject value]):
(-[WebCoreAXObject position]):
(-[WebCoreAXObject accessibilityIsIgnored]):
(-[WebCoreAXObject accessibilityAttributeNames]):
(-[WebCoreAXObject topView]):
(-[WebCoreAXObject accessibilityAttributeValue:]):
* page/Frame.cpp:
(WebCore::Frame::selectionRect):
(WebCore::Frame::paint):
(WebCore::Frame::adjustPageHeight):
(WebCore::Frame::forceLayoutWithPageWidthRange):
* page/FrameView.cpp:
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::layout):
* page/FrameView.h:
* rendering/AutoTableLayout.cpp:
(WebCore::shouldScaleColumns):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::isSelfCollapsingBlock):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::setSelectionState):
(WebCore::RenderBlock::isSelectionRoot):
(WebCore::RenderBlock::fillInlineSelectionGaps):
(WebCore::RenderBlock::lowestPosition):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::calcBlocminMaxWidth):
(WebCore::RenderBlock::inRootBlockContext):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::setStyle):
(WebCore::RenderBox::paintRootBoxDecorations):
(WebCore::RenderBox::paintBackgroundExtended):
(WebCore::RenderBox::calcHeight):
(WebCore::RenderBox::calcPercentageHeight):
(WebCore::RenderBox::availableHeightUsing):
* rendering/RenderCanvas.cpp: Removed.
* rendering/RenderCanvas.h: Removed.
* rendering/RenderContainer.cpp:
(WebCore::RenderContainer::removeChildNode):
* rendering/RenderFileButton.cpp:
(WebCore::RenderFileButton::RenderFileButton):
* rendering/RenderFlow.cpp:
(WebCore::RenderFlow::destroy):
(WebCore::RenderFlow::paintLines):
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layout):
(WebCore::RenderFrameSet::userResize):
(WebCore::RenderFrameSet::setResizing):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paint):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updateLayerPosition):
(WebCore::RenderLayer::stackingContext):
(WebCore::RenderLayer::enclosingPositionedAncestor):
(WebCore::RenderLayer::convertToLayerCoords):
(WebCore::RenderLayer::scrollToOffset):
(WebCore::isSubframeCanvas):
(WebCore::RenderLayer::intersectsDamageRect):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::isStackingContext):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::scroll):
(WebCore::RenderObject::containingBlock):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
(WebCore::RenderObject::draggableNode):
(WebCore::RenderObject::selectionStartEnd):
(WebCore::RenderObject::setStyle):
(WebCore::RenderObject::viewRect):
(WebCore::RenderObject::view):
(WebCore::RenderObject::container):
(WebCore::RenderObject::removeFromObjectLists):
(WebCore::RenderObject::scheduleRelayout):
(WebCore::RenderObject::imageChanged):
(WebCore::RenderObject::maximalOutlineSize):
* rendering/RenderObject.h:
(WebCore::RenderObject::isRenderView):
* rendering/RenderTextArea.cpp:
(WebCore::RenderTextArea::RenderTextArea):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintCheckbox):
(WebCore::RenderThemeMac::paintRadio):
(WebCore::RenderThemeMac::paintButton):
* rendering/RenderTreeAsText.cpp:
(externalRepresentation):
* rendering/RenderView.cpp: Added.
(WebCore::RenderView::RenderView):
(WebCore::RenderView::~RenderView):
(WebCore::RenderView::calcHeight):
(WebCore::RenderView::calcWidth):
(WebCore::RenderView::calcMinMaxWidth):
(WebCore::RenderView::layout):
(WebCore::RenderView::absolutePosition):
(WebCore::RenderView::paint):
(WebCore::RenderView::paintBoxDecorations):
(WebCore::RenderView::repaintViewRectangle):
(WebCore::RenderView::getAbsoluteRepaintRect):
(WebCore::RenderView::computeAbsoluteRepaintRect):
(WebCore::RenderView::absoluteRects):
(WebCore::RenderView::selectionRect):
(WebCore::RenderView::setSelection):
(WebCore::RenderView::clearSelection):
(WebCore::RenderView::selectionStartEnd):
(WebCore::RenderView::updateWidgetPositions):
(WebCore::RenderView::addWidget):
(WebCore::RenderView::removeWidget):
(WebCore::RenderView::viewRect):
(WebCore::RenderView::docHeight):
(WebCore::RenderView::docWidth):
(WebCore::RenderView::setBestTruncatedAt):
* rendering/RenderView.h: Added.
(WebCore::RenderView::renderName):
(WebCore::RenderView::isRenderView):
(WebCore::RenderView::frameView):
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::RenderWidget):
(WebCore::RenderWidget::destroy):
(WebCore::RenderWidget::updateWidgetPosition):
* rendering/RenderWidget.h:
(WebCore::RenderWidget::widget):
* rendering/bidi.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14638
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomernic [Wed, 31 May 2006 01:31:27 +0000 (01:31 +0000)]
Reviewed by Geoff.
<rdar://problem/
4567776> REGRESSION: window.open() links do not work at www.newarchery.com
* bindings/js/kjs_window.cpp:
(KJS::WindowFunc::callAsFunction):
Set the URL in the ResourceRequest; otherwise, it'll be uninitialized and createNewWindow() will
not be able to load the URL into a pre-existing frame.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14637
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Tue, 30 May 2006 21:10:22 +0000 (21:10 +0000)]
Reviewed by Maciej, landed by Beth.
- fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9137
Children with percentage heights of absolutely positioned element
with height: auto and top and bottom non-auto does not lay out
correctly
Adds special case.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::calcPercentageHeight):
(WebCore::RenderBox::calcReplacedHeightUsing):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14634
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Tue, 30 May 2006 20:47:37 +0000 (20:47 +0000)]
Reviewed by Hyatt, landed by Beth.
- Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9085
Absolutely positioned objects with 'height': auto and 'top': and
'bottom': non-auto should not be content based
* rendering/RenderBox.cpp:
(WebCore::RenderBox::calcAbsoluteVertical):
(WebCore::RenderBox::calcAbsoluteVerticalValues):
(WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
(WebCore::RenderBox::calcAbsoluteVerticalReplaced):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14633
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 30 May 2006 18:20:43 +0000 (18:20 +0000)]
Versioning
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14623
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 30 May 2006 08:34:40 +0000 (08:34 +0000)]
2006-05-30 Eric Seidel <eric@eseidel.com>
Reviewed by andersca.
Small amount of svg-related code cleanup.
No test case possible.
* ksvg2/svg/SVGColor.h:
* ksvg2/svg/SVGLength.cpp:
(SVGLength::SVGLength):
(SVGLength::value):
* ksvg2/svg/SVGMarkerElement.cpp:
* ksvg2/svg/SVGMatrix.cpp:
(SVGMatrix::SVGMatrix):
(SVGMatrix::copy):
(SVGMatrix::postMultiply):
(SVGMatrix::inverse):
(SVGMatrix::postTranslate):
(SVGMatrix::postScale):
(SVGMatrix::postScaleNonUniform):
(SVGMatrix::postRotate):
(SVGMatrix::postRotateFromVector):
(SVGMatrix::postFlipX):
(SVGMatrix::postFlipY):
(SVGMatrix::postSkewX):
(SVGMatrix::postSkewY):
(SVGMatrix::multiply):
(SVGMatrix::translate):
(SVGMatrix::scale):
(SVGMatrix::scaleNonUniform):
(SVGMatrix::rotate):
(SVGMatrix::rotateFromVector):
(SVGMatrix::flipX):
(SVGMatrix::flipY):
(SVGMatrix::skewX):
(SVGMatrix::skewY):
(SVGMatrix::setMatrix):
(SVGMatrix::qmatrix):
(SVGMatrix::removeScale):
* ksvg2/svg/SVGMatrix.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14621
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 30 May 2006 08:30:38 +0000 (08:30 +0000)]
2006-05-30 Eric Seidel <eric@eseidel.com>
Reviewed by andersca.
Small ammount of bindings-related code cleanup.
No test case possible.
* bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::nameGetter):
* bindings/js/JSXMLSerializer.cpp:
(WebCore::JSXMLSerializerConstructorImp::JSXMLSerializerConstructorImp):
(WebCore::JSXMLSerializerConstructorImp::implementsConstruct):
(WebCore::JSXMLSerializerConstructorImp::construct):
(WebCore::):
(WebCore::JSXMLSerializer::JSXMLSerializer):
(WebCore::JSXMLSerializerProtoFunc::callAsFunction):
* bindings/js/JSXMLSerializer.h:
(WebCore::JSXMLSerializer::toBoolean):
(WebCore::JSXMLSerializer::classInfo):
(WebCore::JSXMLSerializer::):
* bindings/js/kjs_window.cpp:
(KJS::Window::getValueProperty):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14620
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sat, 27 May 2006 18:33:32 +0000 (18:33 +0000)]
2006-05-27 Anders Carlsson <acarlsson@apple.com>
* bindings/js/JSHTMLElementWrapperFactory.cpp:
Correct include file names.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14619
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log