WebKit-https.git
9 years agowebkit_unit_tests crashing on chromium lion in ScrollbarLayerChromiumTest.resolveScro...
commit-queue@webkit.org [Wed, 28 Mar 2012 01:56:30 +0000 (01:56 +0000)]
webkit_unit_tests crashing on chromium lion in ScrollbarLayerChromiumTest.resolveScrollLayerPointer
https://bugs.webkit.org/show_bug.cgi?id=82381

Patch by James Robinson <jamesr@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.

Use the mock scrollbar theme for this unit test. The real ScrollbarThemeMac isn't compatible with the mocks this
test uses and the test isn't designed to cover the theming code, only code inside the compositor.

* tests/ScrollbarLayerChromiumTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRestore a couple of leopard/snowleopard expectations I overzealously deleted.
dpranke@chromium.org [Wed, 28 Mar 2012 01:16:21 +0000 (01:16 +0000)]
Restore a couple of leopard/snowleopard expectations I overzealously deleted.

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove move tests passing on win and linux.
dpranke@chromium.org [Wed, 28 Mar 2012 01:10:37 +0000 (01:10 +0000)]
Remove move tests passing on win and linux.

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove more tests passing on lion
dpranke@chromium.org [Wed, 28 Mar 2012 01:01:40 +0000 (01:01 +0000)]
Remove more tests passing on lion

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReinforce Geolocation to prevent accidental leak of the user position
benjamin@webkit.org [Wed, 28 Mar 2012 00:58:20 +0000 (00:58 +0000)]
Reinforce Geolocation to prevent accidental leak of the user position
https://bugs.webkit.org/show_bug.cgi?id=82396

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-27
Reviewed by Adam Barth.

It is very important not to provide the position of the user to a page
unless the user authorize it.

The code used to make it easy to cause such problems, because any part
of the Geolocation object could invoke the success callback directly.

This patch add encapsulation for all the attributes of GeoNotifier,
and add extra guards for the two callbacks.

In the case of the success callback, we do one extra check before sending
the value to the bindings.

* Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::GeoNotifier::runSuccessCallback):
(WebCore::Geolocation::GeoNotifier::runErrorCallback):
(WebCore):
(WebCore::Geolocation::GeoNotifier::stopTimer):
(WebCore::Geolocation::GeoNotifier::timerFired):
(WebCore::Geolocation::startRequest):
(WebCore::Geolocation::sendError):
(WebCore::Geolocation::sendPosition):
(WebCore::Geolocation::stopTimer):
(WebCore::Geolocation::extractNotifiersWithCachedPosition):
(WebCore::Geolocation::startUpdating):
* Modules/geolocation/Geolocation.h:
(WebCore::Geolocation::isAllowed):
(Geolocation):
(GeoNotifier):
(WebCore::Geolocation::GeoNotifier::options):
(WebCore::Geolocation::GeoNotifier::useCachedPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r112339.
dpranke@chromium.org [Wed, 28 Mar 2012 00:52:40 +0000 (00:52 +0000)]
Unreviewed, rolling out r112339.
http://trac.webkit.org/changeset/112339
https://bugs.webkit.org/show_bug.cgi?id=82354

webkit_unit_tests crashing on chromium mac bots

* src/AssociatedURLLoader.cpp:
(AssociatedURLLoader::ClientAdapter):
* tests/AssociatedURLLoaderTest.cpp:
(WebKit::AssociatedURLLoaderTest::TearDown):
(WebKit):
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd suppression for flaky plugins/netscape-dom-access-and-reload.html on mac and...
dpranke@chromium.org [Wed, 28 Mar 2012 00:47:43 +0000 (00:47 +0000)]
Add suppression for flaky plugins/netscape-dom-access-and-reload.html on mac and linux.

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Coverity] Address some uninitialized constructor values.
commit-queue@webkit.org [Wed, 28 Mar 2012 00:37:41 +0000 (00:37 +0000)]
[Coverity] Address some uninitialized constructor values.
https://bugs.webkit.org/show_bug.cgi?id=82376

Patch by Kausalya Madhusudhanan <kmadhusu@chromium.org> on 2012-03-27
Reviewed by James Robinson.

Source/WebCore:

New tests are not required since I did not modify any code behavior.

* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
* inspector/InspectorIndexedDBAgent.h:
(InspectorIndexedDBAgent):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::ScrollingCoordinator):
* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
* platform/chromium/DataTransferItemChromium.cpp:
(WebCore::DataTransferItemChromium::DataTransferItemChromium):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* storage/StorageTask.cpp:
(WebCore::StorageTask::StorageTask):

Source/WebKit/chromium:

New tests are not required since I did not modify any code behavior. I just initialized the class member variables in the constructor.

* src/WebCompositorInputHandlerImpl.cpp:
(WebCore::PlatformGestureToCCGestureAdapter::PlatformGestureToCCGestureAdapter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRoll chromium DEPS to r129300.
dpranke@chromium.org [Wed, 28 Mar 2012 00:28:07 +0000 (00:28 +0000)]
Roll chromium DEPS to r129300.

Unreviewed, deps change.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSimplify CSSPropertyBorderSpacing parsing.
alexis.menard@openbossa.org [Wed, 28 Mar 2012 00:27:27 +0000 (00:27 +0000)]
Simplify CSSPropertyBorderSpacing parsing.
https://bugs.webkit.org/show_bug.cgi?id=82397

Reviewed by Benjamin Poulain.

Remove the local array of longhand properties as it doesn't really
bring much in this simple parsing algorithm.

No new tests, no functionality change intended.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix race condition when initializing the scrolling thread
andersca@apple.com [Wed, 28 Mar 2012 00:21:13 +0000 (00:21 +0000)]
Fix race condition when initializing the scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=82398
<rdar://problem/11002166>

Reviewed by Sam Weinig.

Lock m_initializeRunLoopConditionMutex when assigning m_threadIdentifier since we're
asserting that it's not null in the scrolling thread.

* page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::createThreadIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAssociatedURLLoader does not support Cross Origin Redirects when using
bbudge@chromium.org [Wed, 28 Mar 2012 00:19:47 +0000 (00:19 +0000)]
AssociatedURLLoader does not support Cross Origin Redirects when using
Access Control.
https://bugs.webkit.org/show_bug.cgi?id=82354

AssociatedURLLoader's internal adapter now overrides didFailRedirectCheck,
which cancels the load, causing didFail to notify the client that the
load failed. AssociatedURLLoaderTest adds test cases for CORS requests
that receive redirects and pass or fail the redirect access check.

Reviewed by Adam Barth.

* src/AssociatedURLLoader.cpp:
(AssociatedURLLoader::ClientAdapter):
(WebKit::AssociatedURLLoader::ClientAdapter::didFailRedirectCheck):
(WebKit):
* tests/AssociatedURLLoaderTest.cpp:
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPlug-ins using the Core Animation drawing model should work when hosting the layer...
andersca@apple.com [Wed, 28 Mar 2012 00:16:52 +0000 (00:16 +0000)]
Plug-ins using the Core Animation drawing model should work when hosting the layer tree in the window server
https://bugs.webkit.org/show_bug.cgi?id=82387
<rdar://problem/11031942>

Reviewed by Sam Weinig.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::PluginControllerProxy):
(WebKit::PluginControllerProxy::initialize):
Remove m_pluginCreationParameters; it was used by the old NPRuntime short-circuit code.
Make platformInitialize take creation parameters.

* PluginProcess/PluginControllerProxy.messages.in:
Add SetLayerHostingMode message.

* PluginProcess/gtk/PluginControllerProxyGtk.cpp:
(WebKit::PluginControllerProxy::platformInitialize):
Make platformInitialize take creation parameters.

* PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::platformInitialize):
Call updateLayerHostingContext.

(WebKit::PluginControllerProxy::setLayerHostingMode):
Call updateLayerHostingContext and send back the new context ID.

(WebKit::PluginControllerProxy::updateLayerHostingContext):
Create a new LayerHostingContext given the layer hosting mode.

* PluginProcess/qt/PluginControllerProxyQt.cpp:
(WebKit::PluginControllerProxy::platformInitialize):
Make platformInitialize take creation parameters.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::setLayerHostingMode):
Add stub.

* WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
(WebKit::makeRenderLayer):
Add helper function for creating a new render layer.

(WebKit::PluginProxy::pluginLayer):
Call makeRenderLayer.

(WebKit::PluginProxy::setLayerHostingMode):
Send a message to the plug-in process.

(WebKit::PluginProxy::setLayerHostingContextID):
Update the context ID and make a new render layer.

* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::setLayerHostingMode):
Add stub.
* WebProcess/Plugins/PDF/BuiltInPDFView.h:

* WebProcess/Plugins/Plugin.cpp:
(WebKit::Plugin::Parameters::encode):
(WebKit::Plugin::Parameters::decode):
* WebProcess/Plugins/Plugin.h:
Add the layer hosting mode as a parameter. Add a new setLayerHostingMode pure virtual member function.

* WebProcess/Plugins/PluginProxy.messages.in:
Add a SetLayerHostingContextID message.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::setLayerHostingMode):
Call down to the plug-in.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin):
Set the layer hosting mode of the page.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Initialize m_layerHostingMode to false.

* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::layerHostingMode):
Add m_layerHostingMode and a getter.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setLayerHostingMode):
Call WebPage::setLayerHostingMode.

* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::setLayerHostingMode):
Tell all plug-ins that the layer hosting mode changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonew-run-webkit-tests: suppress debug output from run-safari on results file
dpranke@chromium.org [Wed, 28 Mar 2012 00:12:57 +0000 (00:12 +0000)]
new-run-webkit-tests: suppress debug output from run-safari on results file
https://bugs.webkit.org/show_bug.cgi?id=82400

Reviewed by Ryosuke Niwa.

Send the run-safari output to /dev/null rather than the console.

* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.show_results_html_file):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd assertions to valueForLength() and RenderBox::computeLogicalWidthInRegionUsing...
macpherson@chromium.org [Wed, 28 Mar 2012 00:12:30 +0000 (00:12 +0000)]
Add assertions to valueForLength() and RenderBox::computeLogicalWidthInRegionUsing() to help with debugging.
https://bugs.webkit.org/show_bug.cgi?id=82393

Reviewed by Eric Seidel.

No new tests / adding assetions only.

* css/LengthFunctions.cpp:
(WebCore::valueForLength):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove more passing tests, tighten overly broad expectations.
dpranke@chromium.org [Wed, 28 Mar 2012 00:02:34 +0000 (00:02 +0000)]
Remove more passing tests, tighten overly broad expectations.

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agouse the correct size when computing flex-pack space
tony@chromium.org [Tue, 27 Mar 2012 23:56:11 +0000 (23:56 +0000)]
use the correct size when computing flex-pack space
https://bugs.webkit.org/show_bug.cgi?id=82378

Reviewed by Ojan Vafai.

Source/WebCore:

Fix 2 bugs:
- We weren't properly updating available space before computing
  packing space. If a min/max is not hit, we still need to adjust
  the available free space.
- For flex-pack:end, we need to put the overflow in the start edge.

New test cases in css3/flexbox/flex-pack.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
(WebCore::initialPackingOffset):

LayoutTests:

* css3/flexbox/flex-pack-expected.txt:
* css3/flexbox/flex-pack.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unknown transforms should be treated as non-axis aligned on main thread
commit-queue@webkit.org [Tue, 27 Mar 2012 23:49:04 +0000 (23:49 +0000)]
[chromium] Unknown transforms should be treated as non-axis aligned on main thread
https://bugs.webkit.org/show_bug.cgi?id=82370

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.

Source/WebCore:

On main thread, animating transforms have "unknown" values as they are changing
out of sync on the impl thread. So treat them as non-axis-aligned since they
may be, when deciding to create a render surface.

In addition, since surfaces are cheap on main thread, create one for all layers
with animating transforms and a drawing descendant, as this allows paint culling
within the layer's subtree (the animated transform won't affect drawTransforms
inside the subtree).

Also renamed the layerIsInAnimatingSubtreeFor* to animatingTransformTo*.
The old name made me pause and think what it meant and I'm the one who
created it. Hopefully this is more clear.

Unit test: CCLayerTreeHostCommonTest.verifyAnimationsForRenderSurfaceHierarchy

* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::transformToParentIsKnown):
(WebCore):
(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

Source/WebKit/chromium:

* tests/CCLayerTreeHostCommonTest.cpp:
(WebKitTests::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRe-land r112277; reverting it doesn't seem to have fixed anything.
dpranke@chromium.org [Tue, 27 Mar 2012 23:21:14 +0000 (23:21 +0000)]
Re-land r112277; reverting it doesn't seem to have fixed anything.

Unreviewed, build fix.

* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::insertedIntoDocument):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::willRecalcStyle):
(WebCore::SVGUseElement::finishParsingChildren):
* xml/XMLErrors.cpp:
(WebCore::XMLErrors::insertErrorMessageBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rename opaqueContentsRegion() to visibleContentOpaqueRegion()
commit-queue@webkit.org [Tue, 27 Mar 2012 22:46:36 +0000 (22:46 +0000)]
[chromium] Rename opaqueContentsRegion() to visibleContentOpaqueRegion()
https://bugs.webkit.org/show_bug.cgi?id=81689

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.

Source/WebCore:

The return value from this function is a region of opaque pixels in the
layer's content space that intersect with its visible rect. Rather than
adding a comment to this effect, renaming the method to make it clear.

* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::visibleContentOpaqueRegion):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::visibleContentOpaqueRegion):
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::visibleContentOpaqueRegion):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::computeOcclusionBehindLayer):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::visibleContentOpaqueRegion):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):

Source/WebKit/chromium:

* tests/CCLayerTreeHostTest.cpp:
(WTF::TestLayerChromium::opaqueVisibleContents):
* tests/CCOcclusionTrackerTest.cpp:
(WebCore::TestContentLayerChromium::opaqueVisibleContents):
(WebCore::TestContentLayerImpl::opaqueVisibleContents):
* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] A unit test to verify clipping is honored when moving occlusion to parent...
commit-queue@webkit.org [Tue, 27 Mar 2012 22:29:21 +0000 (22:29 +0000)]
[chromium] A unit test to verify clipping is honored when moving occlusion to parent surface
https://bugs.webkit.org/show_bug.cgi?id=81783

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.

* tests/CCOcclusionTrackerTest.cpp:
(WebCore::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest):
(WebCore):
(CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping):
(WebCore::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoScrollable plugins not registered properly in ScrollingCoordinator
commit-queue@webkit.org [Tue, 27 Mar 2012 22:24:36 +0000 (22:24 +0000)]
Scrollable plugins not registered properly in ScrollingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=82163

Patch by James Robinson <jamesr@chromium.org> on 2012-03-27
Reviewed by Anders Carlsson.

Source/WebCore:

Whenever a ScrollableArea is added or removed from a FrameView's ScrollableAreaSet, we have to recalculate the
nonFastScrollableRegion. This can happen for certain types of plugins that are scrollable.

This also reverts 112142 which was a not quite right way to handle these plugins.

* page/FrameView.cpp:
(WebCore::FrameView::addScrollableArea):
(WebCore::FrameView::removeScrollableArea):
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::frameViewScrollableAreasDidChange):
(WebCore):
* page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
* plugins/PluginViewBase.h:

Source/WebKit/chromium:

Since ScrollbarGroups are ScrollableAreas, they need to be able to report their bounds for the
ScrollingCoordinator's calculateNonFastScrollableRegion. This also changes ScrollbarGroups to only be registered
as ScrollableAreas on the FrameView's set when they actually have Scrollbars.

* src/ScrollbarGroup.cpp:
(WebKit::ScrollbarGroup::ScrollbarGroup):
(WebKit::ScrollbarGroup::~ScrollbarGroup):
(WebKit::ScrollbarGroup::scrollbarCreated):
(WebKit::ScrollbarGroup::scrollbarDestroyed):
(WebKit::ScrollbarGroup::setFrameRect):
(WebKit):
(WebKit::ScrollbarGroup::scrollableAreaBoundingBox):
* src/ScrollbarGroup.h:
(ScrollbarGroup):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::reportGeometry):
(WebKit):
(WebKit::WebPluginContainerImpl::scrollbarGroup):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove a bunch of lines that are no longer failing.
dpranke@chromium.org [Tue, 27 Mar 2012 22:21:11 +0000 (22:21 +0000)]
Remove a bunch of lines that are no longer failing.

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHold a reference to refChild in insertBefore before calling collectChildrenAndRemoveF...
adamk@chromium.org [Tue, 27 Mar 2012 22:13:06 +0000 (22:13 +0000)]
Hold a reference to refChild in insertBefore before calling collectChildrenAndRemoveFromOldParent
https://bugs.webkit.org/show_bug.cgi?id=82377

Reviewed by Ryosuke Niwa.

Source/WebCore:

This fixes a regression from r111925.

Test: fast/dom/insertBefore-refChild-crash.html

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::insertBefore): Move the 'next' RefPtr above the call to
collectChildrenAndRemoveFromOldParent and rename refChildPreviousSibling
to 'prev' (matching appendChild and replaceChild).

LayoutTests:

* fast/dom/insertBefore-refChild-crash-expected.txt: Added.
* fast/dom/insertBefore-refChild-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImprove error reporting in run-javascriptcore-tests
simon.fraser@apple.com [Tue, 27 Mar 2012 22:07:18 +0000 (22:07 +0000)]
Improve error reporting in run-javascriptcore-tests
https://bugs.webkit.org/show_bug.cgi?id=82379

Reviewed by Jessie Berlin.

When the script dies, have it print out the reason for dying.

* Scripts/run-javascriptcore-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocssText should not generate literal 'initial' in shorthand properties
rniwa@webkit.org [Tue, 27 Mar 2012 22:01:03 +0000 (22:01 +0000)]
cssText should not generate literal 'initial' in shorthand properties
https://bugs.webkit.org/show_bug.cgi?id=82364

Reviewed by Antti Koivisto.

Source/WebCore:

Fixed the bug by treating initial value as if the value is not set.
While this is incorrect for properties that inherits by default,
it's strictly better than generating unparsable value as we do today.

The proper fix is for CSSInitialValue::cssText to fetch the respective
default value from what's currently in CSSStyleSelector code but that requires
a considerable amount of refactoring and work.

* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getShorthandValue):
(WebCore::StylePropertySet::getCommonValue):

LayoutTests:

* fast/css/cssText-shorthand-expected.txt: Rebaselined.
* fast/css/cssText-shorthand.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG OSR exit should not generate an exit for variables of inlinees if the
fpizlo@apple.com [Tue, 27 Mar 2012 21:54:40 +0000 (21:54 +0000)]
DFG OSR exit should not generate an exit for variables of inlinees if the
inlinees are not in scope
https://bugs.webkit.org/show_bug.cgi?id=82312

Reviewed by Oliver Hunt.

* bytecode/CodeBlock.h:
(JSC::baselineCodeBlockForInlineCallFrame):
(JSC):
(JSC::baselineCodeBlockForOriginAndBaselineCodeBlock):
* dfg/DFGOSRExit.cpp:
(JSC::DFG::computeNumVariablesForCodeOrigin):
(DFG):
(JSC::DFG::OSRExit::OSRExit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Dave Barton to the Contributors list so I can more easily CC him on bugs
eric@webkit.org [Tue, 27 Mar 2012 21:39:35 +0000 (21:39 +0000)]
Add Dave Barton to the Contributors list so I can more easily CC him on bugs
https://bugs.webkit.org/show_bug.cgi?id=82373

Reviewed by Ryosuke Niwa.

Dave's committer-status in in-progress, so until then
list him as a Contributor so at least I can more easily CC him on bugs.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAlways set V8 wrappers via V8DOMWrapper::setJSWrapperFor* instead of WeakReferenceMap...
adamk@chromium.org [Tue, 27 Mar 2012 21:38:33 +0000 (21:38 +0000)]
Always set V8 wrappers via V8DOMWrapper::setJSWrapperFor* instead of WeakReferenceMap::set()
https://bugs.webkit.org/show_bug.cgi?id=82256

Reviewed by Adam Barth.

This moves leakRef() calls out of generated code, centralizing them in
V8DOMWrapper implementation. Ideally, WeakReferenceMap::set would take
PassRefPtrs, but that's tricky given that some WeakReferenceMap's KeyType is 'void'
(which clearly can't be wrapped in a PassRefPtr).

Updated binding tests to reflect changes in CodeGeneratorV8.pm, no change in behavior.

Relanding r112207 with setJSWrapperForDOMSVGElementInstance defined
out-of-line to avoid SVG header dependencies.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorCallback): Use GetDomMapFunction instead of custom logic.
(GenerateNamedConstructorCallback): ditto.
(GenerateToV8Converters): Call V8DOMWrapper::setJSWrapper* method
instead of directly accessing the wrapper maps and calling set.
(GetDomMapFunction): Refactored to call new GetDomWrapperMapName function.
(GetDomWrapperMapName): Helper pulled out of GetDomMapFunction.
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
* bindings/v8/V8DOMWrapper.cpp: Moved setJSWrapperForDOMNode method to header to inline it.
(WebCore::V8DOMWrapper::setJSWrapperForDOMSVGElementInstance): New helper method for SVGElementInstances.
Not inline to avoid header dependency on SVGElementInstance.h.
* bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject): Made inline.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject): ditto.
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode): Refactored into two methods;
this one handles non-active Nodes.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMNode): Pulled out of previouse
DOMNode method, now handles only active Nodes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Make use of common animation unit test methods
commit-queue@webkit.org [Tue, 27 Mar 2012 21:34:55 +0000 (21:34 +0000)]
[chromium] Make use of common animation unit test methods
https://bugs.webkit.org/show_bug.cgi?id=82357

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.

* tests/CCAnimationTestCommon.cpp:
(WebKitTests::addAnimatedTransformToController):
(WebKitTests):
* tests/CCAnimationTestCommon.h:
(WebKitTests):
* tests/CCLayerTreeHostCommonTest.cpp:
(WebKitTests::TEST):
* tests/CCOcclusionTrackerTest.cpp:
(WebKitTests):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCorrect LayoutUnit usage in virtual function layoutBlock in RenderFlexibleBox
leviw@chromium.org [Tue, 27 Mar 2012 21:34:21 +0000 (21:34 +0000)]
Correct LayoutUnit usage in virtual function layoutBlock in RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=82344

Reviewed by Eric Seidel.

Correcting the signature of RenderFlexibleBox::layoutBlock to use a LayoutUnit
for the page height, and avoiding assigning the renderer's size to an IntSize.

No new tests. No change in behavior.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix a missing block call that was found post review.
timothy@apple.com [Tue, 27 Mar 2012 21:29:41 +0000 (21:29 +0000)]
Fix a missing block call that was found post review.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChange media/track/track-delete-during-startup bug #
dpranke@chromium.org [Tue, 27 Mar 2012 21:29:05 +0000 (21:29 +0000)]
Change media/track/track-delete-during-startup bug #

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStop compiling Interpreter.cpp with -fno-var-tracking
mlilek@apple.com [Tue, 27 Mar 2012 21:15:43 +0000 (21:15 +0000)]
Stop compiling Interpreter.cpp with -fno-var-tracking
https://bugs.webkit.org/show_bug.cgi?id=82299

Reviewed by Anders Carlsson.

* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake WebKit properly load a staged framework when soft linking.
timothy@apple.com [Tue, 27 Mar 2012 20:44:18 +0000 (20:44 +0000)]
Make WebKit properly load a staged framework when soft linking.

https://webkit.org/b/82371
rdar://problem/11125989

Reviewed by Dan Bernstein.

Source/WebCore:

* platform/mac/SoftLinking.h: Replaced SOFT_LINK_PRIVATE_FRAMEWORK_OPTIONAL with
SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL and made it use the StagedFrameworks path
if the first dlopen failed.

Source/WebKit/mac:

* WebCoreSupport/WebInspectorClient.mm: Use SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL to properly
load the WebInspector framework.

Source/WebKit2:

* UIProcess/mac/WebInspectorProxyMac.mm: Use SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL to properly
load the WebInspector framework.
* WebProcess/WebPage/mac/WebInspectorMac.mm: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMark media/track/track-delete-during-startup as crashing in debug.
dpranke@chromium.org [Tue, 27 Mar 2012 20:33:31 +0000 (20:33 +0000)]
Mark media/track/track-delete-during-startup as crashing in debug.

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse enumeration for CSS parser mode
krit@webkit.org [Tue, 27 Mar 2012 20:33:27 +0000 (20:33 +0000)]
Use enumeration for CSS parser mode
https://bugs.webkit.org/show_bug.cgi?id=82056

Reviewed by Antti Koivisto.

Introduce a new CSSParserMode enum to differ between strict / quirks and SVG presentation
attribute parsing modes.
The followup patch will make use of the enum in all other classes.
After that it will be easier possible to reuse the CSS parser in SVG as much as possible and
introduce SVG specific functionality.

No new tests. No change on functionality yet. This is just a refactoring to use the enumeration.

* GNUmakefile.list.am: Added new file CSSParserMode.h with the new enum, which can be used by any caller of CSSParser, CSSStyleSheet and others.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* css/CSSGrammar.y: Make use of the new enumeration.
* css/CSSParser.cpp: Replaced boolean by enumeration. No change of functionality at this point of time.
(WebCore::CSSParser::inStrictMode): Helper function.
(WebCore):
(WebCore::CSSParser::inQuirksMode): Helper function.
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::checkForOrphanedUnits):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseSizeParameter):
(WebCore::CSSParser::parseBackgroundColor):
(WebCore::CSSParser::parseFillPositionX):
(WebCore::CSSParser::parseFillPositionY):
(WebCore::CSSParser::parseFillPositionComponent):
(WebCore::CSSParser::parseFillSize):
(WebCore::CSSParser::parseAnimationDelay):
(WebCore::CSSParser::parseAnimationDuration):
(WebCore::CSSParser::parseAnimationIterationCount):
(WebCore::CSSParser::parseTransformOriginShorthand):
(WebCore::CSSParser::parseCubicBezierTimingFunctionValue):
(WebCore::CSSParser::parseAnimationTimingFunction):
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::CSSParser::parseShape):
(WebCore::CSSParser::parseWrapShapeRect):
(WebCore::CSSParser::parseWrapShapeCircle):
(WebCore::CSSParser::parseWrapShapeEllipse):
(WebCore::CSSParser::parseWrapShapePolygon):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseFontWeight):
(WebCore::CSSParser::parseColorParameters):
(WebCore::CSSParser::parseHSLParameters):
(WebCore::CSSParser::parseColorFromValue):
(WebCore::CSSParser::parseShadow):
(WebCore::CSSParser::parseReflect):
(WebCore::CSSParser::parseFlex):
(WebCore::CSSParser::parseBorderImageSlice):
(WebCore::CSSParser::parseBorderImageQuad):
(WebCore::CSSParser::parseBorderRadius):
(WebCore::CSSParser::parseAspectRatio):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parseGradientColorStops):
(WebCore::CSSParser::parseTransform):
(WebCore::CSSParser::parseCustomFilter):
(WebCore::CSSParser::parseBuiltinFilterArguments):
(WebCore::CSSParser::parseTransformOrigin):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframeRule):
* css/CSSParser.h:
(CSSParser):
* css/CSSParserMode.h: Added. New enumeration CSSParserMode.
* css/SVGCSSParser.cpp: Use new SVGAttributeMode CSS parsing mode.
(WebCore::CSSParser::parseSVGValue):
(WebCore::CSSParser::parseSVGStrokeDasharray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[jhbuild] Prepend jhbuildrc's directory to sys.path instead of appending.
kubo@profusion.mobi [Tue, 27 Mar 2012 20:33:07 +0000 (20:33 +0000)]
[jhbuild] Prepend jhbuildrc's directory to sys.path instead of appending.
https://bugs.webkit.org/show_bug.cgi?id=82252

Reviewed by Gustavo Noronha Silva.

Appending the directory containing common.py may be problematic if
another path in sys.path also contains either a common.py or a
common/ module, so prepend to select our version instead. This is
the case with fail2ban, which has a common/ directory which may
end up being in Python's default path.

* efl/jhbuildrc:
* gtk/jhbuildrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-03-27 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 27 Mar 2012 20:30:28 +0000 (20:30 +0000)]
2012-03-27  Nate Chapin  <japhet@chromium.org>

        Don't manually set an identifier for main resource
        loads in FrameLoader. ResourceLoader::willSendRequest()
        will set an identifier for the request if one isn't found,
        so this code appears to be unnecessary duplication.
        https://bugs.webkit.org/show_bug.cgi?id=82248

        Reviewed by Adam Barth.

        No new tests, no functionality change intended.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::startLoadingMainResource): Mark navigation start
            here, since it's conceptually part of starting the main resource load.
        * loader/DocumentLoader.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): Remove duplicate identifier
            logic, and move navigation timing call to startLoadingMainResource, since
            it fits better logically there.
        * loader/ResourceLoader.h: No callers of setIdentifier() remain, so delete it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, expectations change.
dpranke@chromium.org [Tue, 27 Mar 2012 20:20:38 +0000 (20:20 +0000)]
Unreviewed, expectations change.

Mark css3/filters/custom/effect-custom-parameters.html as an image failure on linux debug, 32-bit

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r112277.
dpranke@chromium.org [Tue, 27 Mar 2012 20:18:09 +0000 (20:18 +0000)]
Unreviewed, rolling out r112277.
http://trac.webkit.org/changeset/112277
https://bugs.webkit.org/show_bug.cgi?id=81985

possibly causing crashes?

* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::insertedIntoDocument):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::willRecalcStyle):
(WebCore::SVGUseElement::finishParsingChildren):
* xml/XMLErrors.cpp:
(WebCore::XMLErrors::insertErrorMessageBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/82362> Web Inspector: Provide private -[DOMNode inspect]
commit-queue@webkit.org [Tue, 27 Mar 2012 20:08:07 +0000 (20:08 +0000)]
<webkit.org/b/82362> Web Inspector: Provide private -[DOMNode inspect]

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-27
Reviewed by Timothy Hatcher.

No new tests, this is only an ObjC SPI.

* bindings/objc/DOM.mm:
* bindings/objc/DOMPrivate.h:
(-[DOMNode inspect]):
Call through to InspectorController inspect for the node.

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::handleMousePress):
(WebCore::InspectorDOMAgent::inspect):
Whenever we inspect an element, clear the node search.
The frontend already takes this approach.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] fix confusing destruction sequence in LayerCompositingThread
commit-queue@webkit.org [Tue, 27 Mar 2012 20:06:14 +0000 (20:06 +0000)]
[BlackBerry] fix confusing destruction sequence in LayerCompositingThread
https://bugs.webkit.org/show_bug.cgi?id=81706

Patch by Joe Mason <jmason@rim.com> on 2012-03-27
Reviewed by Rob Buis.

LayerCompositingThread has a destructor that does a synchronous
dispatch to the compositing thread and then does the actual cleanup
from a helper function. This is confusing.It should be the
opposite: the helper function dispatches to the compositing thread,
which calls delete.

No new tests since the existing animation tests will exercise this
code.

* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::destroyOnCompositingThread):
(WebCore):
(WebCore::LayerCompositingThread::~LayerCompositingThread):
* platform/graphics/blackberry/LayerCompositingThread.h:
(LayerCompositingThread):
(WTF):
(WTF::::deref):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoShow image diffs for gpu_tests on flakiness dashboard
commit-queue@webkit.org [Tue, 27 Mar 2012 19:36:20 +0000 (19:36 +0000)]
Show image diffs for gpu_tests on flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=81848

Patch by Dave Tu <dtu@chromium.org> on 2012-03-27
Reviewed by Ojan Vafai.

Add a new results layout for gpu_tests that pulls the image diffs in
addition to the text output. Also add new gpu_tests builders.

* Tools/TestResultServer/static-dashboards/builders.js: Update
gpu_tests builders.
* Tools/TestResultServer/static-dashboards/dashboard_base.js: Add a
function to check for GPU test type.
* Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:
Add new GPU results layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago [Mac] Stop using NSMapTable in FormDataStreamMac.mm
ap@apple.com [Tue, 27 Mar 2012 19:32:36 +0000 (19:32 +0000)]
    [Mac] Stop using NSMapTable in FormDataStreamMac.mm
        https://bugs.webkit.org/show_bug.cgi?id=82358

        Reviewed by Darin Adler.

        * platform/network/mac/FormDataStreamMac.mm: Use WTF::HashMap, as we always do. All accesses
        are protected with a mutex anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement vw/vh/vmin (viewport sizes) from CSS3 Values and Units
commit-queue@webkit.org [Tue, 27 Mar 2012 19:19:59 +0000 (19:19 +0000)]
Implement vw/vh/vmin (viewport sizes) from CSS3 Values and Units
https://bugs.webkit.org/show_bug.cgi?id=27160

Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-27
Reviewed by Antti Koivisto.

vw/vh/vmin are implemented as primitive length units. Added the parsing logic for these new units.
New Length types such as ViewportRelativeWidth, ViewportRelativeHeight and ViewportRelativeMin are added for these length units
and included the support for fetching the value of these relative units based on the current viewport size.

The specification related to this implementation is http://dev.w3.org/csswg/css3-values/#viewport-relative-lengths.

Source/WebCore:

Tests: css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html
       css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html
       css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html
       css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html
       css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html
       css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html
       css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html

* accessibility/gtk/WebKitAccessibleInterfaceText.cpp: Modified to support viewport relative Length types.
(getAttributeSetForAccessibilityObject):
* css/CSSComputedStyleDeclaration.cpp: Ditto.
(WebCore::getPositionOffsetValue):
(WebCore::getBorderRadiusCornerValues):
(WebCore::getBorderRadiusCornerValue):
(WebCore::getBorderRadiusShorthandValue):
(WebCore::lineHeightFromStyle):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSGrammar.y: Added vw/vh/vmin support.
* css/CSSParser.cpp: Parsing of relative units and creation of CSSPrimitiveValue.
(WebCore::CSSParser::validUnit): Added vw/vh/vmin to the valid units.
(WebCore::CSSParser::createPrimitiveNumericValue): Added vw/vh/vmin as valid primitive units.
(WebCore::unitFromString):
(WebCore::CSSParser::parseValidPrimitive): Creation of CSSPrimitiveValue for vw/vh/vmin.
(WebCore::CSSParser::detectNumberToken): Parsing the vw/vh/vmin tokens.
* css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion): Added support for vw/vh/vmin.
(WebCore::unitCategory): Ditto.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory): Added support for vw/vh/vmin.
(WebCore::CSSPrimitiveValue::customCssText): Ditto.
(WebCore::CSSPrimitiveValue::viewportRelativeLength): Function to create the Length structure for the viewport-relative unit types.
(WebCore):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isViewportRelativeLength): Checks whether the primitive value is ViewportRelative Lengths.
(CSSPrimitiveValue):
* css/CSSPrimitiveValue.idl: Added support for vw/vh/vmin.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertToLength): Ditto.
* css/CSSStyleApplyProperty.cpp: Applying relative viewport length units to the specific CSS property.
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
* css/CSSStyleSelector.cpp: Added support for viewport relative units.
* css/LengthFunctions.cpp: Calcuation of length value based on the current viewport size.
(WebCore::miminumValueForLength):
(WebCore::valueForLength):
(WebCore::floatValueForLength):
* css/LengthFunctions.h: Added new RenderView argument.
(WebCore):
* dom/Document.cpp:
(WebCore::Document::pageSizeAndMarginsInPixels): Modified to support viewport relative Length types.
(WebCore::Document::viewportSize): New function to fetch the current viewport size.
(WebCore):
* dom/Document.h: Ditto.
(Document):
* html/HTMLAreaElement.cpp: Modified to support viewport relative Length types.
(WebCore::HTMLAreaElement::getRegion):
* platform/Length.h:
(WebCore::Length::isViewportRelative): To check the Length is of type ViewportRelative.
(WebCore::Length::viewportRelativeLength): To get the relative value.
* rendering/RenderBR.cpp: Modified to support viewport relative Length types.
(WebCore::RenderBR::lineHeight):
* rendering/RenderBlock.cpp: Ditto.
(WebCore::RenderBlock::textIndentOffset):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::lineHeight):
* rendering/RenderBox.cpp: Ditto.
(WebCore::RenderBox::reflectionOffset):
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::clipRect):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeContentLogicalHeightUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::computeBlockDirectionMargins):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
* rendering/RenderBoxModelObject.cpp: Ditto.
(WebCore::RenderBoxModelObject::relativePositionOffsetX):
(WebCore::RenderBoxModelObject::relativePositionOffsetY):
(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
(WebCore::RenderBoxModelObject::getBackgroundRoundedRect):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::computeBorderImageSide):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::paintBoxShadow):
* rendering/RenderFlexibleBox.cpp: Ditto.
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
* rendering/RenderInline.cpp: Ditto.
(WebCore::computeMargin):
(WebCore::RenderInline::lineHeight):
* rendering/RenderMenuList.cpp: Ditto.
(WebCore::RenderMenuList::updateOptionsWidth):
* rendering/RenderObject.cpp: Ditto.
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
* rendering/RenderReplaced.cpp: Ditto.
(WebCore::RenderReplaced::paint):
* rendering/RenderScrollbarPart.cpp: Ditto.
(WebCore::calcScrollbarThicknessUsing):
(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):
* rendering/RenderTable.cpp: Ditto.
(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
* rendering/RenderTableCell.cpp: Ditto.
(WebCore::RenderTableCell::logicalHeightForRowSizing):
* rendering/RenderTableSection.cpp: Ditto.
(WebCore::RenderTableSection::calcRowLogicalHeight):
* rendering/RenderText.h: Ditto.
(WebCore::RenderText::marginLeft):
(WebCore::RenderText::marginRight):
* rendering/RenderThemeMac.mm: Ditto.
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
* rendering/RenderView.h:
(WebCore::RenderView::viewportSize):
* rendering/RenderWidget.cpp: Ditto.
(WebCore::RenderWidget::paint):
* rendering/RootInlineBox.cpp: Ditto.
(WebCore::RootInlineBox::verticalPositionForBox):
* rendering/style/RenderStyle.cpp: Ditto.
(WebCore::calcRadiiFor):
(WebCore::RenderStyle::getRoundedBorderFor):
* rendering/style/RenderStyle.h: Ditto.
* rendering/svg/RenderSVGRoot.cpp: Ditto.
(WebCore::resolveLengthAttributeForSVG):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):

LayoutTests:

* css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle-expected.txt: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute-expected.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-expected.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute-expected.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-expected.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute-expected.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-expected.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html: Added.
* fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/win/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate ANGLE in WebKit https://bugs.webkit.org/show_bug.cgi?id=81717
dino@apple.com [Tue, 27 Mar 2012 19:19:18 +0000 (19:19 +0000)]
Update ANGLE in WebKit https://bugs.webkit.org/show_bug.cgi?id=81717

Reviewed by Kenneth Russell.

Update angleproject to r1009. Synced the source directory
between the angle repository and WebKit. Ran the OS X Lion
version of Bison over the glslang.l input which generates
a slightly different output than angle provided.

Converted tabs to spaces in preprocessor/new files.

* include/EGL/eglext.h:
* include/GLES2/gl2ext.h:
* include/GLSLANG/ShaderLang.h:
* src/common/RefCountObject.cpp: Renamed from Source/ThirdParty/ANGLE/src/libGLESv2/RefCountObject.cpp.
(RefCountObject::RefCountObject):
(RefCountObject::~RefCountObject):
(RefCountObject::addRef):
(RefCountObject::release):
(RefCountObjectBindingPointer::set):
* src/common/RefCountObject.h: Renamed from Source/ThirdParty/ANGLE/src/libGLESv2/RefCountObject.h.
(RefCountObject):
(RefCountObject::id):
(RefCountObjectBindingPointer):
(RefCountObjectBindingPointer::RefCountObjectBindingPointer):
(RefCountObjectBindingPointer::~RefCountObjectBindingPointer):
(RefCountObjectBindingPointer::get):
(RefCountObjectBindingPointer::id):
(RefCountObjectBindingPointer::operator ! ):
(BindingPointer):
(BindingPointer::set):
(BindingPointer::get):
(BindingPointer::operator -> ):
* src/common/debug.cpp:
(gl::output):
* src/common/version.h:
* src/compiler/BaseTypes.h:
* src/compiler/Compiler.cpp:
(TCompiler::TCompiler):
(TCompiler::~TCompiler):
(TCompiler::mapLongVariableNames):
* src/compiler/ConstantUnion.h:
(ConstantUnion::ConstantUnion):
(ConstantUnion::operator==):
(ConstantUnion::operator>):
(ConstantUnion::operator<):
* src/compiler/Intermediate.cpp:
(TIntermConstantUnion::fold):
* src/compiler/MapLongVariableNames.cpp:
(LongNameMap::LongNameMap):
(LongNameMap::~LongNameMap):
(LongNameMap::GetInstance):
(LongNameMap::Release):
(LongNameMap::Find):
(LongNameMap::Insert):
(LongNameMap::Size):
(MapLongVariableNames::MapLongVariableNames):
(MapLongVariableNames::visitSymbol):
(MapLongVariableNames::mapGlobalLongName):
* src/compiler/MapLongVariableNames.h:
(LongNameMap):
(MapLongVariableNames):
* src/compiler/OutputHLSL.cpp:
(sh::OutputHLSL::OutputHLSL):
(sh::OutputHLSL::header):
(sh::OutputHLSL::visitSymbol):
(sh::OutputHLSL::visitUnary):
(sh::OutputHLSL::visitAggregate):
(sh::OutputHLSL::visitLoop):
(sh::OutputHLSL::handleExcessiveLoop):
(sh::OutputHLSL::typeString):
(sh::OutputHLSL::addConstructor):
(sh::OutputHLSL::decorateUniform):
* src/compiler/OutputHLSL.h:
(OutputHLSL):
* src/compiler/PoolAlloc.cpp:
(TAllocation::checkGuardBlock):
* src/compiler/ShHandle.h:
(TCompiler):
* src/compiler/SymbolTable.cpp:
* src/compiler/SymbolTable.h:
(TSymbolTable):
(TSymbolTable::getOuterLevel):
* src/compiler/VariableInfo.cpp:
(getVariableDataType):
* src/compiler/glslang.l:
* src/compiler/glslang.y:
* src/compiler/glslang_lex.cpp:
(yy_buffer_state):
(yyguts_t):
(input):
(yyensure_buffer_stack):
(yy_scan_bytes):
(yyget_leng):
* src/compiler/glslang_tab.cpp:
* src/compiler/osinclude.h:
* src/compiler/preprocessor/cpp.c:
* src/compiler/preprocessor/memory.c:
* src/compiler/preprocessor/new/Context.cpp: Added.
(isMacroNameReserved):
(pp):
(pp::Context::Context):
(pp::Context::~Context):
(pp::Context::init):
(pp::Context::process):
(pp::Context::defineMacro):
(pp::Context::undefineMacro):
(pp::Context::isMacroDefined):
(pp::Context::reset):
(pp::Context::defineBuiltInMacro):
* src/compiler/preprocessor/new/Context.h: Added.
(pp):
(Context):
(pp::Context::lexer):
(pp::Context::output):
* src/compiler/preprocessor/new/Input.cpp: Added.
(pp):
(pp::Input::Input):
(pp::Input::eof):
(pp::Input::read):
(pp::Input::getChar):
(pp::Input::peekChar):
(pp::Input::switchToNextString):
(pp::Input::isStringEmpty):
(pp::Input::stringLength):
* src/compiler/preprocessor/new/Input.h: Added.
(pp):
(Input):
(pp::Input::error):
(pp::Input::stringIndex):
* src/compiler/preprocessor/new/Macro.cpp: Added.
(pp):
(pp::Macro::Macro):
(pp::Macro::~Macro):
* src/compiler/preprocessor/new/Macro.h: Added.
(pp):
(Macro):
(pp::Macro::type):
(pp::Macro::identifier):
(pp::Macro::parameters):
(pp::Macro::replacements):
* src/compiler/preprocessor/new/Preprocessor.cpp: Added.
(pp):
(pp::Preprocessor::Preprocessor):
(pp::Preprocessor::~Preprocessor):
(pp::Preprocessor::init):
(pp::Preprocessor::process):
(pp::Preprocessor::reset):
* src/compiler/preprocessor/new/Preprocessor.h: Added.
(pp):
(Preprocessor):
(pp::Preprocessor::begin):
(pp::Preprocessor::end):
* src/compiler/preprocessor/new/Token.cpp: Added.
(pp):
(pp::Token::encodeLocation):
(pp::Token::decodeLocation):
(pp::Token::Token):
(pp::Token::~Token):
(pp::operator<<):
* src/compiler/preprocessor/new/Token.h: Added.
(pp):
(Token):
(pp::Token::location):
(pp::Token::type):
(pp::Token::value):
* src/compiler/preprocessor/new/generate_parser.sh: Added.
* src/compiler/preprocessor/new/pp.l: Added.
* src/compiler/preprocessor/new/pp.y: Added.
* src/compiler/preprocessor/new/pp_lex.cpp: Added.
(yy_buffer_state):
(yy_trans_info):
(yyguts_t):
(yy_get_previous_state):
(yy_try_NUL_trans):
(input):
(pprestart):
(pp_switch_to_buffer):
(pp_load_buffer_state):
(pp_create_buffer):
(pp_delete_buffer):
(pp_init_buffer):
(pp_flush_buffer):
(pppush_buffer_state):
(pppop_buffer_state):
(ppensure_buffer_stack):
(pp_scan_buffer):
(pp_scan_string):
(pp_scan_bytes):
(yy_push_state):
(yy_pop_state):
(yy_top_state):
(yy_fatal_error):
(ppget_extra):
(ppget_lineno):
(ppget_column):
(ppget_in):
(ppget_out):
(ppget_leng):
(ppget_text):
(ppset_extra):
(ppset_lineno):
(ppset_column):
(ppset_in):
(ppset_out):
(ppget_debug):
(ppset_debug):
(ppget_lval):
(ppset_lval):
(ppget_lloc):
(ppset_lloc):
(pplex_init):
(pplex_init_extra):
(yy_init_globals):
(pplex_destroy):
(yy_flex_strncpy):
(yy_flex_strlen):
(ppalloc):
(pprealloc):
(ppfree):
(extractMacroName):
(pp):
(pp::Context::readInput):
(pp::Context::initLexer):
(pp::Context::destroyLexer):
* src/compiler/preprocessor/new/pp_tab.cpp: Added.
(YYLTYPE):
(yysyntax_error):
(yyerror):
(pushConditionalBlock):
(popConditionalBlock):
(pp::Context::parse):
* src/compiler/preprocessor/new/pp_tab.h: Added.
(YYLTYPE):
* src/compiler/preprocessor/new/stl_utils.h: Added.
(pp):
(Delete):
(pp::Delete::operator()):
(DeleteSecond):
(pp::DeleteSecond::operator()):
* src/compiler/preprocessor/new/token_type.h: Added.
* src/compiler/preprocessor/scanner.c:
(yylex_CPP):
* src/compiler/preprocessor/symbols.c:
* src/compiler/preprocessor/tokens.c:
* src/libEGL/Config.cpp:
(egl::ConfigSet::getConfigs):
* src/libEGL/Display.cpp:
(egl::Display::initialize):
(egl::Display::terminate):
(egl::Display::restoreLostDevice):
(egl::Display::sync):
(egl):
(egl::Display::allocateEventQuery):
(egl::Display::freeEventQuery):
(egl::Display::getFloat32TextureSupport):
(egl::Display::getFloat16TextureSupport):
(egl::Display::getEventQuerySupport):
(egl::Display::initExtensionString):
(egl::Display::shareHandleSupported):
(egl::Display::getOcclusionQuerySupport):
(egl::Display::getInstancingSupport):
* src/libEGL/Display.h:
(Display):
(egl::Display::isD3d9ExDevice):
* src/libEGL/Surface.cpp:
(egl::Surface::resetSwapChain):
* src/libEGL/libEGL.cpp:
* src/libEGL/libEGL.vcproj:
* src/libGLESv2/Blit.cpp:
(gl::Blit::setCommonBlitState):
* src/libGLESv2/Buffer.h:
(Buffer):
* src/libGLESv2/Context.cpp:
(gl::Context::Context):
(gl::Context::~Context):
(gl::Context::makeCurrent):
(gl::Context::getActiveQuery):
(gl):
(gl::Context::createFence):
(gl::Context::createQuery):
(gl::Context::deleteQuery):
(gl::Context::beginQuery):
(gl::Context::endQuery):
(gl::Context::getQuery):
(gl::Context::applyVertexBuffer):
(gl::Context::applyIndexBuffer):
(gl::Context::readPixels):
(gl::Context::clear):
(gl::Context::drawArrays):
(gl::Context::drawElements):
(gl::Context::sync):
(gl::Context::drawLineLoop):
(gl::Context::supportsOcclusionQueries):
(gl::Context::supportsInstancing):
(gl::Context::setVertexAttribDivisor):
(gl::Context::initExtensionString):
(gl::VertexDeclarationCache::applyDeclaration):
(gl::VertexDeclarationCache::markStateDirty):
* src/libGLESv2/Context.h:
(gl):
(gl::VertexAttribute::VertexAttribute):
(State):
(VertexDeclarationCache):
(Context):
* src/libGLESv2/Fence.cpp:
(gl::Fence::Fence):
(gl::Fence::~Fence):
(gl::Fence::setFence):
* src/libGLESv2/Fence.h:
(egl):
(Fence):
* src/libGLESv2/Framebuffer.cpp:
(gl::Framebuffer::lookupRenderbuffer):
(gl::Framebuffer::detachTexture):
(gl::Framebuffer::completeness):
* src/libGLESv2/Framebuffer.h:
* src/libGLESv2/IndexDataManager.cpp:
(gl::IndexDataManager::IndexDataManager):
(gl::IndexDataManager::~IndexDataManager):
(gl::computeRange):
(gl::IndexDataManager::prepareIndexData):
(gl::IndexDataManager::getCountingIndices):
(gl):
* src/libGLESv2/IndexDataManager.h:
(IndexDataManager):
* src/libGLESv2/Program.cpp:
(gl::Program::getUniformLocation):
(gl::Program::setUniform1fv):
(gl::Program::setUniform2fv):
(gl::Program::setUniform3fv):
(gl::Program::setUniform4fv):
(gl::Program::setUniform1iv):
(gl::Program::setUniform2iv):
(gl::Program::setUniform3iv):
(gl::Program::setUniform4iv):
(gl::Program::packVaryings):
(gl::Program::linkVaryings):
(gl::Program::defineUniform):
(gl::Program::createUniform):
(gl::Program::applyUniformnbv):
(gl::Program::applyUniform1iv):
(gl::Program::applyUniform2iv):
(gl::Program::applyUniform3iv):
(gl::Program::applyUniform4iv):
(gl::Program::getInfoLog):
* src/libGLESv2/Program.h:
(Program):
* src/libGLESv2/Query.cpp: Added.
(gl):
(gl::Query::Query):
(gl::Query::~Query):
(gl::Query::begin):
(gl::Query::end):
(gl::Query::getResult):
(gl::Query::isResultAvailable):
(gl::Query::getType):
(gl::Query::testQuery):
* src/libGLESv2/Query.h: Added.
(gl):
(Query):
* src/libGLESv2/Renderbuffer.cpp:
(gl):
(gl::RenderbufferInterface::addProxyRef):
(gl::RenderbufferInterface::releaseProxy):
(gl::RenderbufferTexture::RenderbufferTexture):
(gl::RenderbufferTexture::~RenderbufferTexture):
(gl::RenderbufferTexture::addProxyRef):
(gl::RenderbufferTexture::releaseProxy):
(gl::Renderbuffer::addRef):
(gl::Renderbuffer::release):
* src/libGLESv2/Renderbuffer.h:
(gl):
(RenderbufferInterface):
(RenderbufferTexture):
(Renderbuffer):
* src/libGLESv2/Shader.cpp:
(gl::Shader::Shader):
(gl::Shader::getInfoLog):
(gl::Shader::getSourceImpl):
(gl):
(gl::Shader::initializeCompiler):
(gl::Shader::parseVaryings):
(gl::Shader::uncompile):
(gl::Shader::compileToHLSL):
(gl::VertexShader::uncompile):
(gl::VertexShader::compile):
(gl::VertexShader::parseAttributes):
(gl::FragmentShader::compile):
* src/libGLESv2/Shader.h:
(Shader):
(VertexShader):
* src/libGLESv2/Texture.cpp:
(gl::Texture2D::Texture2D):
(gl::Texture2D::~Texture2D):
(gl):
(gl::Texture2D::addProxyRef):
(gl::Texture2D::releaseProxy):
(gl::Texture2D::getRenderbuffer):
(gl::TextureCubeMap::TextureCubeMap):
(gl::TextureCubeMap::~TextureCubeMap):
(gl::TextureCubeMap::addProxyRef):
(gl::TextureCubeMap::releaseProxy):
(gl::TextureCubeMap::isSamplerComplete):
(gl::TextureCubeMap::convertToRenderTarget):
(gl::TextureCubeMap::getRenderbuffer):
* src/libGLESv2/Texture.h:
(Texture):
(Texture2D):
(TextureCubeMap):
* src/libGLESv2/VertexDataManager.cpp:
(gl::VertexDataManager::writeAttributeData):
(gl::VertexDataManager::prepareVertexData):
(gl::VertexDataManager::spaceRequired):
(gl):
* src/libGLESv2/VertexDataManager.h:
(TranslatedAttribute):
(VertexDataManager):
* src/libGLESv2/libGLESv2.cpp:
* src/libGLESv2/libGLESv2.def:
* src/libGLESv2/libGLESv2.vcproj:
* src/libGLESv2/utilities.cpp:
(gl::IsInternalTextureTarget):
* src/libGLESv2/utilities.h:
(gl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove deprecated LowPass2FilterNode and HighPass2FilterNode
commit-queue@webkit.org [Tue, 27 Mar 2012 19:16:11 +0000 (19:16 +0000)]
Remove deprecated LowPass2FilterNode and HighPass2FilterNode
https://bugs.webkit.org/show_bug.cgi?id=82296

Patch by Gao Chun <chun.gao@intel.com> on 2012-03-27
Reviewed by Chris Rogers.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Modules/webaudio/AudioContext.cpp:
* Modules/webaudio/AudioContext.h:
(WebCore):
(AudioContext):
* Modules/webaudio/AudioContext.idl:
* Modules/webaudio/AudioNode.h:
* Modules/webaudio/BiquadFilterNode.cpp:
(WebCore::BiquadFilterNode::BiquadFilterNode):
* Modules/webaudio/BiquadProcessor.cpp:
* Modules/webaudio/BiquadProcessor.h:
* Modules/webaudio/HighPass2FilterNode.cpp: Removed.
* Modules/webaudio/HighPass2FilterNode.h: Removed.
* Modules/webaudio/HighPass2FilterNode.idl: Removed.
* Modules/webaudio/LowPass2FilterNode.cpp: Removed.
* Modules/webaudio/LowPass2FilterNode.h: Removed.
* Modules/webaudio/LowPass2FilterNode.idl: Removed.
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agotest-webkitpy: prepare for better test run output
dpranke@chromium.org [Tue, 27 Mar 2012 19:15:53 +0000 (19:15 +0000)]
test-webkitpy: prepare for better test run output
https://bugs.webkit.org/show_bug.cgi?id=82290

Reviewed by Adam Barth.

This code basically re-implements the output of the TextTestRunner default
runner code from unittest, although the implementation is quite
different, in preparation for changing the test output to be
metered and possibly running in parallel.

The output is almost identical to before, except that instead of
logging "test_regular (webkitpy.main.RunnerTest) passed" we log
"webkitpy.main.RunnerTest.test_regular passed". It has always
annoyed me that they invert the names to be harder to read and
so that you can't copy & paste back to the input for
test-webkitpy.

This patch is provided to add a skeleton for unit tests and for
comparison to an upcoming patch that will actually add new
functionality.

* Scripts/webkitpy/test/main.py:
(Tester.__init__):
(Tester._configure_logging):
(Tester._run_tests):
* Scripts/webkitpy/test/runner.py: Added.
(TestRunner):
(TestRunner.__init__):
(TestRunner.test_name):
(TestRunner.all_test_names):
(TestRunner.run):
(TestRunner.write_result):
(TestRunner.write_summary):
* Scripts/webkitpy/test/runner_unittest.py: Added.
(FakeModuleSuite):
(FakeModuleSuite.__init__):
(FakeModuleSuite.__str__):
(FakeModuleSuite.run):
(FakeTopSuite):
(FakeTopSuite.__init__):
(FakeLoader):
(FakeLoader.__init__):
(FakeLoader.top_suite):
(FakeLoader.loadTestsFromName):
(RunnerTest):
(RunnerTest.test_regular):
(RunnerTest.test_verbose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Build gnutls without p11-kit support
kov@webkit.org [Tue, 27 Mar 2012 18:58:08 +0000 (18:58 +0000)]
[GTK] Build gnutls without p11-kit support
https://bugs.webkit.org/show_bug.cgi?id=82212

Reviewed by Martin Robinson.

* gtk/jhbuild.modules: pass --without-p11-kit to gnutls'
configure, to avoid requiring that dependency, which is not used
by libsoup and WebKit anyway

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't update the layer hosting state unless the WKView is added to a window
andersca@apple.com [Tue, 27 Mar 2012 18:42:02 +0000 (18:42 +0000)]
Don't update the layer hosting state unless the WKView is added to a window
https://bugs.webkit.org/show_bug.cgi?id=82359

Reviewed by Sam Weinig.

This avoids thrashing the layer hosting state when switching tabs.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Switch WebPageCompositor to use AnimationFrameRateController instead...
commit-queue@webkit.org [Tue, 27 Mar 2012 18:39:59 +0000 (18:39 +0000)]
[BlackBerry] Switch WebPageCompositor to use AnimationFrameRateController instead of timer
https://bugs.webkit.org/show_bug.cgi?id=82350

Switch timer in WebPageCompositor to use AnimationFrameRateController.

Patch by Andrew Lo <anlo@rim.com> on 2012-03-27
Reviewed by Rob Buis.

* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::~WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
(BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):
* Api/WebPageCompositor_p.h:
(WebPageCompositorPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add TextureCopier for copying texture contents
commit-queue@webkit.org [Tue, 27 Mar 2012 18:18:42 +0000 (18:18 +0000)]
[chromium] Add TextureCopier for copying texture contents
https://bugs.webkit.org/show_bug.cgi?id=80870

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-03-27
Reviewed by Stephen White.

Source/WebCore:

This patch introduces a TextureCopier class whose job is to copy the
contents from one GL texture to another using the most efficient means
for the current GPU. This version uses render-to-texture to do the copy,
but a path based on EXT_framebuffer_blit can be added later.

The class is intended to replace the use of image path operations such
as glCopyTex{Sub}Image2D for duplicating texture contents. The reason is
that such functions may not be very well optimized in some -- mainly
mobile -- GPU drivers.

With this patch the new copier is used just for Canvas2D layer
presentation, but another potential use is for WebGL layer presentation.

Test: webkit_unit_tests: TextureCopierTest

* WebCore.gypi:
* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
* platform/graphics/chromium/Canvas2DLayerChromium.h:
(Canvas2DLayerChromium):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initializeSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore):
(WebCore::LayerRendererChromium::textureCopier):
(LayerRendererChromium):
* platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::VertexShaderPosTexIdentity::getShaderString):
(WebCore):
(WebCore::FragmentShaderRGBATexCopy::getShaderString):
* platform/graphics/chromium/ShaderChromium.h:
(VertexShaderPosTexIdentity):
(WebCore::VertexShaderPosTexIdentity::init):
(WebCore):
(FragmentShaderRGBATexCopy):
* platform/graphics/chromium/TextureCopier.cpp: Added.
(WebCore):
(WebCore::AcceleratedTextureCopier::AcceleratedTextureCopier):
(WebCore::AcceleratedTextureCopier::~AcceleratedTextureCopier):
(WebCore::AcceleratedTextureCopier::copyTexture):
* platform/graphics/chromium/TextureCopier.h: Added.
(WebCore):
(TextureCopier):
(WebCore::TextureCopier::~TextureCopier):
(AcceleratedTextureCopier):
(WebCore::AcceleratedTextureCopier::create):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doCommit):
* platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::CCTextureUpdater):
* platform/graphics/chromium/cc/CCTextureUpdater.h:
(WebCore):
(CCTextureUpdater):
(WebCore::CCTextureUpdater::copier):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):

Source/WebKit/chromium:

Add new test for TextureCopier.

* WebKit.gypi:
* tests/Canvas2DLayerChromiumTest.cpp:
* tests/TextureCopierTest.cpp: Added.
* tests/TiledLayerChromiumTest.cpp:
(FakeTextureCopier):
(WTF::FakeTextureCopier::copyTexture):
(WTF):
(WTF::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCompiler warning when JIT is not enabled
psolanki@apple.com [Tue, 27 Mar 2012 18:06:21 +0000 (18:06 +0000)]
Compiler warning when JIT is not enabled
https://bugs.webkit.org/show_bug.cgi?id=82352

Reviewed by Filip Pizlo.

* runtime/JSFunction.cpp:
(JSC::JSFunction::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCorrect SVG paint functions that are still using IntPoints
leviw@chromium.org [Tue, 27 Mar 2012 18:03:32 +0000 (18:03 +0000)]
Correct SVG paint functions that are still using IntPoints
https://bugs.webkit.org/show_bug.cgi?id=82343

Reviewed by Eric Seidel.

Two small corrections to SVG paint functions that should use LayoutPoint instead
of IntPoint.

No new tests. No change in behavior.

* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::paint):
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFrame flattening: childframe in FrameView::layout() needs protector.
commit-queue@webkit.org [Tue, 27 Mar 2012 18:00:50 +0000 (18:00 +0000)]
Frame flattening: childframe in FrameView::layout() needs protector.
https://bugs.webkit.org/show_bug.cgi?id=82345

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-03-27
Reviewed by Kenneth Rohde Christiansen.

RefPtr<FrameView> protector(this) is supposed to protect the current frameview in
FrameView::layout() from being destroyed by recalcStyle().
However, when frame flattening is on and a child frame is re-starting layout from
the topmost parent, the protection is missing and parent's recalcStyle()
can destroy the child frame.
Moving the protector before the layout re-starting is initiated makes the child frame
safe.

No new tests. Unable to create a test case, where this scenario is reproducible.

* page/FrameView.cpp:
(WebCore::FrameView::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Make debug build work on 32 bit
ossy@webkit.org [Tue, 27 Mar 2012 17:47:39 +0000 (17:47 +0000)]
[Qt] Make debug build work on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=82331

Use --no-keep-memory option of ld not to cache the symbol tables of input files in
memory to avoid memory exhaustion during the linking phase for x86-debug builds.

Reviewed by Tor Arne Vestbø.

* qmake/mkspecs/features/unix/default_post.prf:
* qmake/mkspecs/features/unix/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConstruct CSSCharsetRule on CSSOM API access only
antti@apple.com [Tue, 27 Mar 2012 17:46:59 +0000 (17:46 +0000)]
Construct CSSCharsetRule on CSSOM API access only
https://bugs.webkit.org/show_bug.cgi?id=82332

Reviewed by Andreas Kling.

Charset is just a string. There is usually no need to construct CSSCharsetRule at all.

- Make CSS parser to return encoding string instead of CSSCharsetRule object. This
  string is used for constructing CSSCharsetRule if it is needed (and nothing else,
  @charset has no effect after string decoding).
- Remove internal interface for adding and removing rules. It has no clients.

* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore):
* css/CSSParser.h:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::parserAppendRule):
(WebCore::CSSStyleSheet::ensureCharsetRule):
(WebCore):
(WebCore::CSSStyleSheet::length):
(WebCore::CSSStyleSheet::item):
(WebCore::CSSStyleSheet::clearCharsetRule):
(WebCore::CSSStyleSheet::clearRules):
(WebCore::CSSStyleSheet::parserSetEncodingFromCharsetRule):
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::addRule):
(WebCore::CSSStyleSheet::deleteRule):
* css/CSSStyleSheet.h:
(WebCore):
(CSSStyleSheet):
(WebCore::CSSStyleSheet::ruleVector):
(WebCore::CSSStyleSheet::hasCharsetRule):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::reparseStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, skip fast/events/dropzone-005.html on mac-wk1.
kling@webkit.org [Tue, 27 Mar 2012 17:44:28 +0000 (17:44 +0000)]
Unreviewed, skip fast/events/dropzone-005.html on mac-wk1.

It has been failing since its introduction and is skipped for every
port but chromium.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: [chromium] Fix filter context creation to be more conservative.
senorblanco@chromium.org [Tue, 27 Mar 2012 17:02:51 +0000 (17:02 +0000)]
Source/WebCore: [chromium] Fix filter context creation to be more conservative.
https://bugs.webkit.org/show_bug.cgi?id=82349

Reviewed by James Robinson.

Covered by webkit_unit_tests, and css3/filters layout tests.

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setFilters):
Only request a filter context if the filter lists is non-empty.
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::setNeedsFilterContext):
Add a bool param, so tests can cancel a request for filter contexts.

Source/WebKit/chromium: [chromium] Fix filter context usage in webkit_unit_tests.
https://bugs.webkit.org/show_bug.cgi?id=82349

Reviewed by James Robinson.

* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
Cancel request for filter context after test run.
(WTF::TEST_F):
* tests/CCOcclusionTrackerTest.cpp:
Re-enable CCLayerTreeHostTestSetSingleLostContext.runMultiThread.
(WebCore::CCOcclusionTrackerTest::TearDown):
Cancel request for filter context after test run.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<svg:use> elements in the parser can create elements not marked as created by the...
schenney@chromium.org [Tue, 27 Mar 2012 15:58:03 +0000 (15:58 +0000)]
<svg:use> elements in the parser can create elements not marked as created by the parser
https://bugs.webkit.org/show_bug.cgi?id=81985

Reviewed by Adam Barth.

The SVGUseElement was creating its shadow tree immediately upon
demand. This resulted in nodes being created that were not marked as
"createdByParser", even during parsing. As it happens, there is
already code in there to track "createdByParser" in the SVGUseElement,
it was just being ignored all the time. This may even have been
inefficient. Now we delay creating the shadow dom tree until children
are finished, which is the standard time to handle the createdByParser
flag.

I also verified that other SVG classes that derived from core DOM
classes that use the createdByParser flag do correctly pass this flag
on.

No new tests as this is covered by existing tests and does not have new behavior.

* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::insertedIntoDocument):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::willRecalcStyle):
(WebCore::SVGUseElement::finishParsingChildren):
* xml/XMLErrors.cpp:
(WebCore::XMLErrors::insertErrorMessageBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Disable DisallowCType.h usage
commit-queue@webkit.org [Tue, 27 Mar 2012 15:44:16 +0000 (15:44 +0000)]
[BlackBerry] Disable DisallowCType.h usage
https://bugs.webkit.org/show_bug.cgi?id=82211

Patch by Ming Xie <mxie@rim.com> on 2012-03-27
Reviewed by Rob Buis.

Build fix: QNX port does use ctype.h, so we should not
include <wtf/DisallowCType.h> in WebCore/config.h

No new tests - Build Fix

* config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: testSourceMapCouldNotBeLoaded logs different error messages on differe...
podivilov@chromium.org [Tue, 27 Mar 2012 15:41:04 +0000 (15:41 +0000)]
Web Inspector: testSourceMapCouldNotBeLoaded logs different error messages on different platforms.
https://bugs.webkit.org/show_bug.cgi?id=82314

Reviewed by Vsevolod Vlasov.

* http/tests/inspector/compiler-script-mapping.html:
* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement WebFrameNetworkingContext for soup in WebKit2
carlosgc@webkit.org [Tue, 27 Mar 2012 15:22:56 +0000 (15:22 +0000)]
Implement WebFrameNetworkingContext for soup in WebKit2

[SOUP] Implement WebFrameNetworkingContext for soup in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=82081

Reviewed by Martin Robinson.

* GNUmakefile.am: Add new files to compilation
* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp: Copied from Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebFrameNetworkingContext.h.
(WebKit::WebFrameNetworkingContext::soupSession): Return the
default SoupSession.
* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h: Renamed from Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebFrameNetworkingContext.h.
(WebKit):
(WebFrameNetworkingContext):
(WebKit::WebFrameNetworkingContext::create): Create a new
WebFrameNetworkingContext().
(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChange default position attribute of media control panel to relative for Android.
commit-queue@webkit.org [Tue, 27 Mar 2012 15:17:42 +0000 (15:17 +0000)]
Change default position attribute of media control panel to relative for Android.
https://bugs.webkit.org/show_bug.cgi?id=82303

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-03-27
Reviewed by Eric Carlson.

Follow up https://bugs.webkit.org/show_bug.cgi?id=79746 .

* css/mediaControlsChromiumAndroid.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Speed up snapshot parsing.
yurys@chromium.org [Tue, 27 Mar 2012 15:15:18 +0000 (15:15 +0000)]
Web Inspector: Speed up snapshot parsing.
https://bugs.webkit.org/show_bug.cgi?id=82325

Replacing the iterators with raw nodes/edges access speeds up
some phases phasses up to 10 times, taking down the whole init
time to less than 6 sec.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-03-27
Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._buildNodeIndex):
(WebInspector.HeapSnapshot.prototype._buildDominatedNodes):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd png checking to check-webkit-style
kkristof@inf.u-szeged.hu [Tue, 27 Mar 2012 15:03:44 +0000 (15:03 +0000)]
Add png checking to check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=75824

Reviewed by NOBODY Tony Chang.

* Scripts/webkitpy/style/checker.py:
(_all_categories):
(FileType):
(CheckerDispatcher._should_skip_file_path):
(CheckerDispatcher._file_type):
(CheckerDispatcher._create_checker):
* Scripts/webkitpy/style/checker_unittest.py:
(CheckerDispatcherDispatchTest.test_none_paths):
* Scripts/webkitpy/style/checkers/png.py: Added.
(PNGChecker):
(PNGChecker.__init__):
(PNGChecker.check):
(PNGChecker._config_file_path):
* Scripts/webkitpy/style/checkers/png_unittest.py: Added.
(MockSCMDetector):
(MockSCMDetector.__init__):
(MockSCMDetector.display_name):
(MockSCMDetector.propget):
(PNGCheckerTest):
(PNGCheckerTest.test_init):
(PNGCheckerTest.test_init.mock_handle_style_error):
(PNGCheckerTest.test_check):
(PNGCheckerTest.test_check.mock_handle_style_error):
* Scripts/webkitpy/style/patchreader.py:
(PatchReader.check):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAssertion failure in acid2.
antti@apple.com [Tue, 27 Mar 2012 15:01:00 +0000 (15:01 +0000)]
Assertion failure in acid2.

Rubber-stamped by Andreas Kling.

Remove assert added in http://trac.webkit.org/changeset/112258. It seems insertedInto/removedFromDocument
don't always pair.

* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::~SVGDocumentExtensions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: simplify heap profiler front-end
yurys@chromium.org [Tue, 27 Mar 2012 14:55:27 +0000 (14:55 +0000)]
Web Inspector: simplify heap profiler front-end
https://bugs.webkit.org/show_bug.cgi?id=82338

Source/WebCore:

Simplify constructors of WebInspector.HeapSnapshotArraySlice and
WebInspector.HeapSnapshotEdgesProvider.

Reviewed by Pavel Feldman.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotArraySlice):
(WebInspector.HeapSnapshotArraySlice.prototype.item):
(WebInspector.HeapSnapshotArraySlice.prototype.slice):
(WebInspector.HeapSnapshotNode.prototype.get rawEdges):
(WebInspector.HeapSnapshot.prototype._retainersForNode):
(WebInspector.HeapSnapshot.prototype._dominatedNodesOfNode):
(WebInspector.HeapSnapshot.prototype.createEdgesProvider):
(WebInspector.HeapSnapshotEdgesProvider):

LayoutTests:

Reviewed by Pavel Feldman.

* inspector/profiler/heap-snapshot.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Tabbed pane should set focus on its contents on tab click.
vsevik@chromium.org [Tue, 27 Mar 2012 14:51:03 +0000 (14:51 +0000)]
Web Inspector: Tabbed pane should set focus on its contents on tab click.
https://bugs.webkit.org/show_bug.cgi?id=82323

Reviewed by Pavel Feldman.

Otherwise selected tab does not have focus.
Also added tabIndex on tabElements to prevent pasting on closing middle click.

* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane):
(WebInspector.TabbedPane.prototype.focus):
(WebInspector.TabbedPane.prototype.selectTab):
(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabClicked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: dispatch breakpoint-added and breakpoint-removed events on UISourceCode.
podivilov@chromium.org [Tue, 27 Mar 2012 14:43:46 +0000 (14:43 +0000)]
Web Inspector: dispatch breakpoint-added and breakpoint-removed events on UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=82318

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Breakpoint-added and breakpoint-removed events are always related to specific UISourceCode.
See bug 82224 for more details.

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._addBreakpointToUI):
(WebInspector.BreakpointManager.prototype._removeBreakpointFromUI):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.UISourceCodeImpl.prototype.breakpointAdded):
(WebInspector.UISourceCodeImpl.prototype.breakpointRemoved):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
(WebInspector.ScriptsPanel.prototype._addBreakpointListeners):
(WebInspector.ScriptsPanel.prototype._removeBreakpointListeners):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
* inspector/front-end/UISourceCode.js:

LayoutTests:

* inspector/debugger/breakpoint-manager.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Merge setVisibleContentsRect with setFixedVisibleContentRect
yael.aharon@nokia.com [Tue, 27 Mar 2012 14:42:47 +0000 (14:42 +0000)]
[Qt][WK2] Merge setVisibleContentsRect with setFixedVisibleContentRect
https://bugs.webkit.org/show_bug.cgi?id=82289

Reviewed by Kenneth Rohde Christiansen.

As we scroll, we constantly send 2 messages. Those 2 messages can be merged into one.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::_q_contentViewportChanged):
* UIProcess/WebPageProxy.cpp:
(WebKit):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::setVisibleContentsRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry]Cleanup WTF string in platform/network/blackberry
commit-queue@webkit.org [Tue, 27 Mar 2012 14:32:49 +0000 (14:32 +0000)]
[BlackBerry]Cleanup WTF string in platform/network/blackberry
https://bugs.webkit.org/show_bug.cgi?id=82005

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-27
Reviewed by Rob Buis.

No new tests. Just replace WTF::String with String.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyDataReceived):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Enable "number" parameters in the web inspector protocol methods
apavlov@chromium.org [Tue, 27 Mar 2012 14:30:29 +0000 (14:30 +0000)]
Web Inspector: Enable "number" parameters in the web inspector protocol methods
https://bugs.webkit.org/show_bug.cgi?id=82334

The generated protocol dispatcher does not understand protocol method parameters of type "number"
(mapped to "double" in the native code.)

Reviewed by Vsevolod Vlasov.

* inspector/CodeGeneratorInspector.py:
(RawTypes.Number.get_getter_name):
(RawTypes.Number.get_c_initializer):
(RawTypes.Number.get_js_bind_type):
(RawTypes.Number.get_validate_method_params.ValidateMethodParams):
(RawTypes.Number.get_validate_method_params):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Fix missing objects in the dominators view.
yurys@chromium.org [Tue, 27 Mar 2012 14:23:22 +0000 (14:23 +0000)]
Web Inspector: Fix missing objects in the dominators view.
https://bugs.webkit.org/show_bug.cgi?id=82194

Due to the nature of dominators tree it is not possible to hide internal
objects there because they may happen to contain user objects that can't
be hidden.
Besides that it fixes a small bug in HeapSnapshotArraySlice.slice
function.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-03-27
Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotArraySlice.prototype.slice):

LayoutTests:

* inspector/profiler/heap-snapshot-expected.txt:
* inspector/profiler/heap-snapshot.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Skip GTK+ unit tests that fail in the bots
carlosgc@webkit.org [Tue, 27 Mar 2012 13:37:43 +0000 (13:37 +0000)]
Unreviewed. Skip GTK+ unit tests that fail in the bots

* Scripts/run-gtk-tests:
(TestRunner): Add failing tests to the skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Kling's name.
antti@apple.com [Tue, 27 Mar 2012 12:45:46 +0000 (12:45 +0000)]
Fix Kling's name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove Document::mappedElementSheet()
antti@apple.com [Tue, 27 Mar 2012 12:40:38 +0000 (12:40 +0000)]
Remove Document::mappedElementSheet()
https://bugs.webkit.org/show_bug.cgi?id=82242

Reviewed by Anreas Kling and Nikolas Zimmermann.

The only thing this is used for anymore is SVGFontFaceElement. That can be handled without
the confusing extra stylesheet.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
* css/CSSStyleSelector.h:
(CSSStyleSelector):

    - Add font face rules from registered SVGFontFaceElements.
    - Simplify the constructor signature. Stylesheets are part of the document.

* dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::createStyleSelector):
(WebCore):
(WebCore::Document::updateBaseURL):
* dom/Document.h:
(WebCore):
(WebCore::Document::documentUserSheets):
(Document):

    - Remove mappedElementSheet
    - Adapt to the CSSStyleSelector constructor signature changes.

* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::svgFontFaceElements):
(WebCore):
(WebCore::SVGDocumentExtensions::registerSVGFontFaceElement):
(WebCore::SVGDocumentExtensions::unregisterSVGFontFaceElement):
* svg/SVGDocumentExtensions.h:
(WebCore):
(SVGDocumentExtensions):

    - Add map for SVGFontFaceElements

* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::insertedIntoDocument):
(WebCore::SVGFontFaceElement::removedFromDocument):
(WebCore):
* svg/SVGFontFaceElement.h:
(SVGFontFaceElement):
(WebCore::SVGFontFaceElement::fontFaceRule):

    - Switch to updating svgFontFaceElements map.
    - Use elementSheet as the parent sheet (nothing is ever added to the elementSheet, it is used for
      resolving relative URLs only).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: startEditing should remove tabIndex attribute from the element if...
vsevik@chromium.org [Tue, 27 Mar 2012 12:32:06 +0000 (12:32 +0000)]
Web Inspector: startEditing should remove tabIndex attribute from the element if it was not set before.
https://bugs.webkit.org/show_bug.cgi?id=82322

Reviewed by Pavel Feldman.

This patch removes tabIndex attribute from the element after editing if it was not present before.
Otherwise tabIndex becomes set unexpectedly after exiting edit mode.

* inspector/front-end/UIUtils.js:
(WebInspector.startEditing.cleanUpAfterEditing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Tree outline should not start search on key press if it is being edited.
vsevik@chromium.org [Tue, 27 Mar 2012 12:22:42 +0000 (12:22 +0000)]
Web Inspector: Tree outline should not start search on key press if it is being edited.
https://bugs.webkit.org/show_bug.cgi?id=82327

Reviewed by Pavel Feldman.

This is needed for snippet renaming support.

* inspector/front-end/treeoutline.js:
(TreeOutline):
(TreeOutline.prototype._treeKeyPress):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert RenderApplet::intrinsicSize to integers
leviw@chromium.org [Tue, 27 Mar 2012 12:13:17 +0000 (12:13 +0000)]
Revert RenderApplet::intrinsicSize to integers
https://bugs.webkit.org/show_bug.cgi?id=82206

Reviewed by Eric Seidel.

Intrinsic sizes originate either outside of WebCore, or from their initial values,
which are always integers. Reverting RenderApplet::intrinsicSize to integers, the
last spot improperly using LayoutUnits

No new tests. No change in behavior.

* rendering/RenderApplet.cpp:
(WebCore::RenderApplet::intrinsicSize):
* rendering/RenderApplet.h:
(RenderApplet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIncrease code sharing between CSSComputedStyleDeclaration and CSSPropertyLonghand.
alexis.menard@openbossa.org [Tue, 27 Mar 2012 12:00:52 +0000 (12:00 +0000)]
Increase code sharing between CSSComputedStyleDeclaration and CSSPropertyLonghand.
https://bugs.webkit.org/show_bug.cgi?id=82261

Reviewed by Ryosuke Niwa.

Source/WebCore:

Use longhands declaration from CSSPropertyLonghand in CSSComputedStyleDeclaration to avoid
code duplication.

No new tests : refactoring only, we shouldn't have any behavior difference.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForShorthandProperties):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForSidesShorthand):
* css/CSSComputedStyleDeclaration.h:
(WebCore):
(CSSComputedStyleDeclaration):
* css/CSSPropertyLonghand.cpp:
(WebCore::outlineLonghand):
Re-order to match the spec default order and also remove outline-offset as it is not part
of the shorthand (http://www.w3.org/TR/css3-ui/#outline). Luckily this was cover by a layout test.

LayoutTests:

Update expectation as it was relying on inaccurate order. All other outline related tests
are expecting the same order (e.g. fast/getComputedStyle/getComputedStyle-outline-shorthand) as well
as Opera.

* fast/css/cssText-shorthand-expected.txt:
* fast/css/cssText-shorthand.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a perf test which updates the value of an already declared CSS property.
alexis.menard@openbossa.org [Tue, 27 Mar 2012 11:57:05 +0000 (11:57 +0000)]
Add a perf test which updates the value of an already declared CSS property.
https://bugs.webkit.org/show_bug.cgi?id=82321

Reviewed by Andreas Kling.

This benchmark update CSS existing properties of the style from JS.

* CSS/CSSPropertyUpdateValue.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoA page containing multiparts with "multipart/x-mixed-replace" should not be cached.
commit-queue@webkit.org [Tue, 27 Mar 2012 11:53:15 +0000 (11:53 +0000)]
A page containing multiparts with "multipart/x-mixed-replace" should not be cached.
https://bugs.webkit.org/show_bug.cgi?id=82291

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-03-27
Reviewed by Rob Buis.

If we have a multiPart reponse with multipart/x-mixed-replace,
the current page should not be cached. I use isMultipartPayload()
API which was supposed to be set in NetworkJob to decide to
cache page or not.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::canCachePage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Editable TextViewer should show cursor when it is focused.
vsevik@chromium.org [Tue, 27 Mar 2012 11:40:29 +0000 (11:40 +0000)]
Web Inspector: Editable TextViewer should show cursor when it is focused.
https://bugs.webkit.org/show_bug.cgi?id=82320

Reviewed by Pavel Feldman.

TextViewer now focuses editable inner container unless read-only flag is set.

* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype.focus):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype._handleElementFocus):
(WebInspector.TextEditorMainPanel.prototype.focus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Unskip all GTK+ unit test.
carlosgc@webkit.org [Tue, 27 Mar 2012 11:08:49 +0000 (11:08 +0000)]
Unreviewed. Unskip all GTK+ unit test.

Currently, skipped tests contains the list of unit tests that have
failed in one or more bots. In this moment it's not possible to
skip just the test cases that fail, so the complete unit test is
skipped when a single test case fails. For that reason, we don't
know which test cases are actually failing for every skipped
test. We are planning to land a patch to allow skipping individual
test cases, but first we need to know which test cases are
currently failing in the bots to skip them. So, this patch simply
unskips all unit tests in order to watch the bots and get the list
of test cases failing. Failing tests will be skipped again as soon
as we have the new list of failing test cases.

* Scripts/run-gtk-tests:
(TestRunner): Reset the list of skipped tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Removing change markers from ChangeLog.
leviw@chromium.org [Tue, 27 Mar 2012 11:03:08 +0000 (11:03 +0000)]
Unreviewed. Removing change markers from ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConvert RenderSelectionInfo::rect to LayoutUnits
leviw@chromium.org [Tue, 27 Mar 2012 10:52:49 +0000 (10:52 +0000)]
Convert RenderSelectionInfo::rect to LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=82213

Reviewed by Eric Seidel.

RenderSelectionInfoBase stores a cached repaint rect in local coordinates. Coordinates local to
renderers should be stored in LayoutUnits.

No new tests. No change in behavior.

* rendering/RenderSelectionInfo.h:
(WebCore::RenderSelectionInfo::rect):
(RenderSelectionInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable animVal support for SVGAnimatedRect
zimmermann@webkit.org [Tue, 27 Mar 2012 10:47:05 +0000 (10:47 +0000)]
Enable animVal support for SVGAnimatedRect
https://bugs.webkit.org/show_bug.cgi?id=82317

Reviewed by Zoltan Herczeg.

Source/WebCore:

Enable animVal support for SVGAnimatedRect. Very simple now that everything is prepared.
All we have to do is add startAnimValAnimation/etc. methods to SVGAnimatedRectAnimator.

Extended existing tests to cover this.

* svg/SVGAnimatedRect.cpp:
(WebCore::SVGAnimatedRectAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedRectAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedRectAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedRectAnimator::animValWillChange):
(WebCore::SVGAnimatedRectAnimator::animValDidChange):
* svg/SVGAnimatedRect.h:
(SVGAnimatedRectAnimator):
* svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::supportsAnimVal):

LayoutTests:

Extend SVGAnimatedRect tests to cover animVal support.

* svg/animations/script-tests/svgrect-animation-1.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgrect-animation-2.js:
(sample1):
(sample2):
(sample3):
* svg/animations/svgrect-animation-1-expected.txt:
* svg/animations/svgrect-animation-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-03-27 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 27 Mar 2012 10:44:12 +0000 (10:44 +0000)]
2012-03-27  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Use shouldBe() instead of shouldBeCloseEnough() when testing the baseVal in the SVGAngle tests.
        It doesn't get animated, and thus isn't timing dependant. All other tests are correct.

        * svg/animations/script-tests/svgangle-animation-deg-to-grad.js:
        (sample1):
        (sample2):
        (sample3):
        * svg/animations/script-tests/svgangle-animation-deg-to-rad.js:
        (sample1):
        (sample2):
        (sample3):
        * svg/animations/script-tests/svgangle-animation-grad-to-deg.js:
        (sample1):
        (sample2):
        (sample3):
        * svg/animations/script-tests/svgangle-animation-grad-to-rad.js:
        (sample1):
        (sample2):
        (sample3):
        * svg/animations/script-tests/svgangle-animation-rad-to-deg.js:
        (sample1):
        (sample2):
        (sample3):
        * svg/animations/script-tests/svgangle-animation-rad-to-grad.js:
        (sample1):
        (sample2):
        (sample3):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r112201.
commit-queue@webkit.org [Tue, 27 Mar 2012 10:43:36 +0000 (10:43 +0000)]
Unreviewed, rolling out r112201.
http://trac.webkit.org/changeset/112201
https://bugs.webkit.org/show_bug.cgi?id=82302

Breaks chromium's WebPageSerializerTest.HTMLNodes test
(Requested by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-27

* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::error):
(WebCore):
* loader/cache/CachedCSSStyleSheet.h:
(CachedCSSStyleSheet):
* loader/cache/CachedFont.cpp:
(WebCore):
(WebCore::CachedFont::error):
* loader/cache/CachedFont.h:
(CachedFont):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::error):
* loader/cache/CachedResource.h:
(CachedResource):
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::error):
(WebCore):
* loader/cache/CachedScript.h:
(CachedScript):
* loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::error):
(WebCore):
* loader/cache/CachedXSLStyleSheet.h:
(CachedXSLStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Skip accidentally unskipped tests again.
ossy@webkit.org [Tue, 27 Mar 2012 10:40:59 +0000 (10:40 +0000)]
[Qt] Unreviewed gardening. Skip accidentally unskipped tests again.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLayoutRepainter: Remove unused constructor parameter and update to LayoutUnits
leviw@chromium.org [Tue, 27 Mar 2012 10:35:27 +0000 (10:35 +0000)]
LayoutRepainter: Remove unused constructor parameter and update to LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=82185

Reviewed by Eric Seidel.

Removing an optional parameter for old bounds in LayoutRepainter's constructor that
is no longer used. The old bounds are instead always gleaned from the renderer's
clippedOverflowRectForRepaint.

The renderer's bounds and outline rect also are stored in LayoutUnits to properly
detect sub-pixel changes during layout. Eventually, we'll pixel snap these values
when telling the embedder to invalidate. Adding a comment to that effect.

No new tests. No change in behavior.

* rendering/LayoutRepainter.cpp:
(WebCore::LayoutRepainter::LayoutRepainter):
* rendering/LayoutRepainter.h:
(LayoutRepainter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed: chromium baselines updated.
pfeldman@chromium.org [Tue, 27 Mar 2012 10:29:52 +0000 (10:29 +0000)]
Not reviewed: chromium baselines updated.

* platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening after r112229.
ossy@webkit.org [Tue, 27 Mar 2012 10:23:28 +0000 (10:23 +0000)]
[Qt] Unreviewed gardening after r112229.

* platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.txt:
* platform/qt/fast/table/quote-text-around-iframe-expected.png:
* platform/qt/fast/table/quote-text-around-iframe-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable animVal support for SVGAnimatedString
zimmermann@webkit.org [Tue, 27 Mar 2012 10:22:35 +0000 (10:22 +0000)]
Enable animVal support for SVGAnimatedString
https://bugs.webkit.org/show_bug.cgi?id=82316

Reviewed by Zoltan Herczeg.

Source/WebCore:

Enable animVal support for SVGAnimatedString. Very simple now that everything is prepared.
All we have to do is add startAnimValAnimation/etc. methods to SVGAnimatedStringAnimator.

Test: svg/animations/svgstring-animation-1.html

* svg/SVGAnimatedString.cpp:
(WebCore::SVGAnimatedStringAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedStringAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedStringAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedStringAnimator::animValWillChange):
(WebCore::SVGAnimatedStringAnimator::animValDidChange):
* svg/SVGAnimatedString.h:
(SVGAnimatedStringAnimator):
* svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::supportsAnimVal):

LayoutTests:

Add new test covering animVal+SVGAnimatedString.

* svg/animations/script-tests/svgstring-animation-1.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/svgstring-animation-1-expected.txt: Added.
* svg/animations/svgstring-animation-1.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r112229.
philn@webkit.org [Tue, 27 Mar 2012 10:18:41 +0000 (10:18 +0000)]
Unreviewed, GTK rebaseline after r112229.

* platform/gtk/fast/repaint/block-layout-inline-children-replaced-expected.txt:
* platform/gtk/fast/table/quote-text-around-iframe-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate usage of LayoutUnits in RenderListMarker
leviw@chromium.org [Tue, 27 Mar 2012 10:08:50 +0000 (10:08 +0000)]
Update usage of LayoutUnits in RenderListMarker
https://bugs.webkit.org/show_bug.cgi?id=81921

Reviewed by Eric Seidel.

Implementing proper pixel snapping in list marker painting, and correcting usage of integers
for local coordinates/margins that should be sub-pixel.

No new tests. No change in behavior.

* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::localSelectionRect): Changed to LayoutUnits since this represents
a rect in local coordinates.
(WebCore::RenderListMarker::paint): Doing proper pixel snapping, and using integers for
results from text measurement.
(WebCore::RenderListMarker::computePreferredLogicalWidths): Using integers for results
from text measurement.
(WebCore::RenderListMarker::updateMargins): Fixing to be LayoutUnits.
* rendering/RenderListMarker.h:
(RenderListMarker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert linesBoundingBox to integers
leviw@chromium.org [Tue, 27 Mar 2012 10:06:49 +0000 (10:06 +0000)]
Revert linesBoundingBox to integers
https://bugs.webkit.org/show_bug.cgi?id=82182

Reviewed by Eric Seidel.

LayoutRects are intended to be pixel snapped to determine the ultimate screen
coordinates, but the Inline Box tree is laid out using floats, and pixel snapping
the resulting box from linesBoundingBox would produce a potentially incorrect
rectangle. Keeping this using enclosingIntRect retains the previous accuracy and
prevents misuse.

No new tests. No change in behavior.

* rendering/RenderInline.cpp:
(WebCore::RenderInline::linesBoundingBox):
* rendering/RenderInline.h:
(RenderInline):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition):
* rendering/RenderText.cpp:
(WebCore::RenderText::linesBoundingBox):
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::linesBoundingBox):
* rendering/svg/RenderSVGInlineText.h:
(RenderSVGInlineText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: store UIBreakpoints on UISourceCode.
podivilov@chromium.org [Tue, 27 Mar 2012 09:55:18 +0000 (09:55 +0000)]
Web Inspector: store UIBreakpoints on UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=82214

Source/WebCore:

This change will allow us to make breakpoint-added and breakpoint-removed events a part of UISourceCode interface.
See bug 82224 for more details.

Reviewed by Vsevolod Vlasov.

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.uiSourceCodeRemoved):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype.removeBreakpoint):
(WebInspector.BreakpointManager.prototype._addBreakpointToUI):
(WebInspector.BreakpointManager.prototype._removeBreakpointFromUI):
(WebInspector.BreakpointManager.prototype.debuggerReset):
* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.addScript):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForUISourceCode):
(WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
(WebInspector.UISourceCodeImpl):
(WebInspector.UISourceCodeImpl.prototype.breakpoints):
(WebInspector.UISourceCodeImpl.prototype.breakpointAdded):
(WebInspector.UISourceCodeImpl.prototype.breakpointRemoved):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createUISourceCode):
* inspector/front-end/SnippetsModel.js:
(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._createUISourceCodeForScript):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.get domain):
(WebInspector.UISourceCode.prototype.get folderName):
(WebInspector.UISourceCode.prototype.get fileName):
(WebInspector.UISourceCode.prototype.get displayName):
(WebInspector.UISourceCode.prototype._parseURL):
(WebInspector.UISourceCode.prototype._didRequestContent):
(WebInspector.UISourceCode.prototype.breakpoints):
* inspector/front-end/inspector.html:

LayoutTests:

Reviewed by Vsevolod Vlasov.

* inspector/debugger/breakpoint-manager.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112236 268f45cc-cd09-0410-ab3c-d52691b4dbfc