WebKit-https.git
12 years agoPlanetWebKit:
mitz@apple.com [Fri, 27 Jun 2008 21:08:40 +0000 (21:08 +0000)]
PlanetWebKit:

        Reviewed by Timothy Hatcher.

        * wwwroot/planetwebkit.css: Reduced text shadow offsets.

WebKitSite:

        Reviewed by Timothy Hatcher.

        * css/main.css: Reduced text shadow offsets.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Change WebKitGraphics truncation functions to return the length of the trunca...
aroben@apple.com [Fri, 27 Jun 2008 20:35:34 +0000 (20:35 +0000)]
    Change WebKitGraphics truncation functions to return the length of the truncated string

        Reviewed by Darin Adler.

        * WebKitGraphics.cpp:
        (CenterTruncateStringToWidth):
        (RightTruncateStringToWidth):
        Return the length.
        * WebKitGraphics.h:
        The truncation functions now return an unsigned int that is the length
        of the truncated string. The whole file has been marked extern "C" to
        keep the symbols for these functions from changing (which would break
        nightly builds).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix mime-types. Not sure how to do this with git.
abarth@webkit.org [Fri, 27 Jun 2008 18:11:39 +0000 (18:11 +0000)]
Fix mime-types.  Not sure how to do this with git.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
abarth@webkit.org [Fri, 27 Jun 2008 18:09:21 +0000 (18:09 +0000)]
WebCore:

2008-06-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=19784

        Properly handle untermianted <!-- comments in <textarea>s.

        Tests: fast/parser/open-comment-in-script-tricky.html
               fast/parser/open-comment-in-style.html
               fast/parser/open-comment-in-textarea.html

        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::finish):

LayoutTests:

2008-06-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Test our handling of unterminated <!-- comments in various special
        parsing contexts.  This change does not test our handling of
        unterminated comments in <title> or <iframe> because I'm unsure whether
        our behaviour is correct.

        * fast/parser/open-comment-in-script-tricky-expected.txt: Added.
        * fast/parser/open-comment-in-script-tricky.html: Added.
        * fast/parser/open-comment-in-style.html: Added.
        * fast/parser/open-comment-in-textarea.html: Added.
        * platform/mac/fast/parser/open-comment-in-style-expected.checksum: Added.
        * platform/mac/fast/parser/open-comment-in-style-expected.png: Added.
        * platform/mac/fast/parser/open-comment-in-style-expected.txt: Added.
        * platform/mac/fast/parser/open-comment-in-textarea-expected.checksum: Added.
        * platform/mac/fast/parser/open-comment-in-textarea-expected.png: Added.
        * platform/mac/fast/parser/open-comment-in-textarea-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
abarth@webkit.org [Fri, 27 Jun 2008 18:09:03 +0000 (18:09 +0000)]
WebCore:

2008-06-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Fix <https://bugs.webkit.org/show_bug.cgi?id=19784>:
          Text areas in Wikipedia edit pages are empty, following content is missing

        Don't treat entities as comment starters in parseSpecial.

        Tests: fast/parser/comment-in-iframe.html
               fast/parser/entity-comment-in-iframe.html
               fast/parser/entity-comment-in-script-tricky.html
               fast/parser/entity-comment-in-style.html
               fast/parser/entity-comment-in-textarea.html
               fast/parser/entity-comment-in-title.html

        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::parseSpecial):

LayoutTests:

2008-06-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=19784

        Test that entities are not used to start comments.

        * fast/parser/comment-in-iframe-expected.txt: Added.
        * fast/parser/comment-in-iframe.html: Added.
        * fast/parser/entity-comment-in-iframe-expected.txt: Added.
        * fast/parser/entity-comment-in-iframe.html: Added.
        * fast/parser/entity-comment-in-script-tricky-expected.txt: Added.
        * fast/parser/entity-comment-in-script-tricky.html: Added.
        * fast/parser/entity-comment-in-style.html: Added.
        * fast/parser/entity-comment-in-textarea.html: Added.
        * fast/parser/entity-comment-in-title-expected.txt: Added.
        * fast/parser/entity-comment-in-title.html: Added.
        * platform/mac/fast/parser/entity-comment-in-style-expected.checksum: Added.
        * platform/mac/fast/parser/entity-comment-in-style-expected.png: Added.
        * platform/mac/fast/parser/entity-comment-in-style-expected.txt: Added.
        * platform/mac/fast/parser/entity-comment-in-textarea-expected.checksum: Added.
        * platform/mac/fast/parser/entity-comment-in-textarea-expected.png: Added.
        * platform/mac/fast/parser/entity-comment-in-textarea-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
antti@apple.com [Fri, 27 Jun 2008 12:40:23 +0000 (12:40 +0000)]
WebCore:

2008-06-27  Antti Koivisto  <antti@apple.com>

        Reviewed by Oliver.

        <rdar://problem/6030720>
        REGRESSION: Discrete animation between incompatible paths does not work

        Fall back to discrete path animation if paths are not suitable for morphing.

        Test: svg/custom/animate-path-discrete.svg

        * svg/SVGAnimateElement.cpp:
        (WebCore::SVGAnimateElement::calculateAnimatedValue):

LayoutTests:

2008-06-27  Antti Koivisto  <antti@apple.com>

        Reviewed by Oliver.

        <rdar://problem/6030720>
        REGRESSION: Discrete animation between incompatible paths does not work

        * svg/custom/animate-path-discrete.svg: Added.
        * platform/mac/svg/custom/animate-path-discrete-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-26 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 27 Jun 2008 07:00:47 +0000 (07:00 +0000)]
2008-06-26  Darin Adler  <darin@apple.com>

        * Scripts/check-for-weak-vtables: Fixed comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-26 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 27 Jun 2008 04:54:39 +0000 (04:54 +0000)]
2008-06-26  Darin Adler  <darin@apple.com>

        * Scripts/check-for-weak-vtables: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSpeculative fix for the Windows build.
mrowe@apple.com [Fri, 27 Jun 2008 04:44:43 +0000 (04:44 +0000)]
Speculative fix for the Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-26 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 27 Jun 2008 04:32:47 +0000 (04:32 +0000)]
2008-06-26  Mark Rowe  <mrowe@apple.com>

        Reviewed by Darin Adler and Geoff Garen.

        Fix the malloc zone introspection functions so that malloc_zone_statistics does not give
        bogus output in an application that uses JavaScriptCore.

        * kjs/CollectorHeapIntrospector.cpp:
        (KJS::CollectorHeapIntrospector::statistics): Return statistics about memory allocated by the collector.
        * kjs/CollectorHeapIntrospector.h:
        * wtf/FastMalloc.cpp: Zero out the statistics.  FastMalloc doesn't track this information at present.
        Returning zero for all values is preferable to returning bogus data.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
dsmith@webkit.org [Fri, 27 Jun 2008 03:28:49 +0000 (03:28 +0000)]
WebCore:

2008-06-26  David Smith  <catfish.man@gmail.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=19002

        Optimize simple id selectors in querySelector/querySelectorAll.
        ~4.4x speedup on the 4 subtests of http://webkit.org/perf/slickspeed/ that it applies to.

        * dom/Document.h:
        (WebCore::Document::containsMultipleElementsWithId): Added to allow optimizing the common case of no duplicates
        * dom/Node.cpp:
        (WebCore::Node::querySelector): Uses getElementById instead of DOM traversal where possible now
        * dom/SelectorNodeList.cpp:
        (WebCore::createSelectorNodeList): Uses getElementById instead of DOM traversal where possible now

LayoutTests:

2008-06-26  David Smith  <catfish.man@gmail.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=19002

        Optimize simple id selectors in querySelector/querySelectorAll.
        ~4.4x speedup on the 4 subtests of http://webkit.org/perf/slickspeed/ that it applies to.

        * fast/dom/SelectorAPI/dumpNodeList-expected.txt:
        * fast/dom/SelectorAPI/dumpNodeList.html: Add tests for finding ids not in the document, and finding duplicate ids

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Fri, 27 Jun 2008 03:24:51 +0000 (03:24 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix <rdar://problem/3099526> Find command doesn't search form input controls (textareas and text fields)
          http://bugs.webkit.org/show_bug.cgi?id=7023

        Test: editing/selection/find-in-text-control.html

        * WebCore.base.exp: Updated the TextIterator constructor signature.

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::TextIterator): Added an enterTextControls
        boolean parameter that determines whether the iterator should visit text
        inside text areas and text fields. Added code to initialize the
        m_inShadowContent member variable based on whether the range is in
        shadow content.
        (WebCore::TextIterator::advance): Added code to step out of shadow
        content.
        (WebCore::TextIterator::handleReplacedElement): Added code to enter
        text controls if desired.
        (WebCore::CharacterIterator::CharacterIterator): Added an
        enterTextControls boolean parameter that determines whether the iterator
        should visit text inside text areas and text fields. This is passed to
        the TextIterator constructor.
        (WebCore::findPlainText): Changed to use a CharacterIterator that
        visits text controls.

        * editing/TextIterator.h: Added member variables to track whether the
        current node is in a shadow tree and whether the iterator should visit
        text controls.

        * page/Frame.cpp:
        (WebCore::Frame::findString): Changed to find inside text controls.
        (WebCore::Frame::markAllMatchesForText): Ditto.

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::innerTextElement): Added.
        * rendering/RenderTextControl.h: Added innerTextElement(), a private
        accessor method that is accessible to TextIterator through class
        friendship.

LayoutTests:

        Reviewed by Darin Adler.

        - test for <rdar://problem/3099526> Find command doesn't search form input controls (textareas and text fields)
          http://bugs.webkit.org/show_bug.cgi?id=7023

        * editing/selection/find-in-text-control-expected.txt: Added.
        * editing/selection/find-in-text-control.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-26 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 27 Jun 2008 02:53:42 +0000 (02:53 +0000)]
2008-06-26  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        - https://bugs.webkit.org/show_bug.cgi?id=19721
          speed up JavaScriptCore by not wrapping strings in objects just
          to call functions on them

        - optimize UString append and the replace function a bit

        SunSpider says 1.8% faster.

        * JavaScriptCore.exp: Updated.

        * VM/JSPropertyNameIterator.cpp: Added include of JSString.h, now needed
        because jsString returns a JSString*.

        * VM/Machine.cpp:
        (KJS::Machine::privateExecute): Removed the toObject call from native
        function calls. Also removed code to put the this value into a register.

        * kjs/BooleanObject.cpp:
        (KJS::booleanProtoFuncToString): Rewrite to handle false and true
        separately.

        * kjs/FunctionPrototype.cpp:
        (KJS::constructFunction): Use single-character append rather than building
        a string for each character.
        * kjs/JSFunction.cpp:
        (KJS::globalFuncUnescape): Ditto.

        * kjs/JSImmediate.cpp:
        (KJS::JSImmediate::prototype): Added. Gets the appropriate prototype for
        use with an immediate value. To be used instead of toObject when doing a
        get on an immediate value.
        * kjs/JSImmediate.h: Added prototype.

        * kjs/JSObject.cpp:
        (KJS::JSObject::toString): Tweaked formatting.

        * kjs/JSObject.h:
        (KJS::JSValue::get): Use prototype instead of toObject to avoid creating
        an object wrapper just to search for properties. This also saves an
        unnecessary hash table lookup since the object wrappers themselves don't
        have any properties.

        * kjs/JSString.h: Added toThisString and toThisJSString.

        * kjs/JSValue.cpp:
        (KJS::JSCell::toThisString): Added.
        (KJS::JSCell::toThisJSString): Added.
        (KJS::JSCell::getJSNumber): Added.
        (KJS::jsString): Changed return type to JSString*.
        (KJS::jsOwnedString): Ditto.

        * kjs/JSValue.h:
        (KJS::JSValue::toThisString): Added.
        (KJS::JSValue::toThisJSString): Added.
        (KJS::JSValue::getJSNumber): Added.

        * kjs/NumberObject.cpp:
        (KJS::NumberObject::getJSNumber): Added.
        (KJS::integer_part_noexp): Append C string directly rather than first
        turning it into a UString.
        (KJS::numberProtoFuncToString): Use getJSNumber to check if the value
        is a number rather than isObject(&NumberObject::info). This works for
        immediate numbers, number cells, and NumberObject instances.
        (KJS::numberProtoFuncToLocaleString): Ditto.
        (KJS::numberProtoFuncValueOf): Ditto.
        (KJS::numberProtoFuncToFixed): Ditto.
        (KJS::numberProtoFuncToExponential): Ditto.
        (KJS::numberProtoFuncToPrecision): Ditto.
        * kjs/NumberObject.h: Added getJSNumber.

        * kjs/PropertySlot.cpp: Tweaked comment.

        * kjs/internal.cpp:
        (KJS::JSString::toThisString): Added.
        (KJS::JSString::toThisJSString): Added.
        (KJS::JSString::getOwnPropertySlot): Changed code that searches the
        prototype chain to start with the string prototype and not create a
        string object.
        (KJS::JSNumberCell::toThisString): Added.
        (KJS::JSNumberCell::getJSNumber): Added.

        * kjs/lookup.cpp:
        (KJS::staticFunctionGetter): Moved here, because there's no point in
        having a function that's only used for a function pointer be inline.
        (KJS::setUpStaticFunctionSlot): New function for getStaticFunctionSlot.

        * kjs/lookup.h:
        (KJS::staticValueGetter): Don't mark this inline. It doesn't make sense
        to have a function that's only used for a function pointer be inline.
        (KJS::getStaticFunctionSlot): Changed to get properties from the parent
        first before doing any handling of functions. This is the fastest way
        to return the function once the initial setup is done.

        * kjs/string_object.cpp:
        (KJS::StringObject::getPropertyNames): Call value() instead of getString(),
        avoiding an unnecessary virtual function call (the call to the type()
        function in the implementation of the isString() function).
        (KJS::StringObject::toString): Added.
        (KJS::StringObject::toThisString): Added.
        (KJS::StringObject::toThisJSString): Added.
        (KJS::substituteBackreferences): Rewrote to use a appending algorithm
        instead of a the old one that tried to replace in place.
        (KJS::stringProtoFuncReplace): Merged this function and the replace function.
        Replaced the hand-rolled dynamic arrays for source ranges and replacements
        with Vector.
        (KJS::stringProtoFuncToString): Handle JSString as well as StringObject.
        Removed the separate valueOf implementation, since it can just share this.
        (KJS::stringProtoFuncCharAt): Use toThisString, which handles JSString as
        well as StringObject, and is slightly more efficient than the old code too.
        (KJS::stringProtoFuncCharCodeAt): Ditto.
        (KJS::stringProtoFuncConcat): Ditto.
        (KJS::stringProtoFuncIndexOf): Ditto.
        (KJS::stringProtoFuncLastIndexOf): Ditto.
        (KJS::stringProtoFuncMatch): Ditto.
        (KJS::stringProtoFuncSearch): Ditto.
        (KJS::stringProtoFuncSlice): Ditto.
        (KJS::stringProtoFuncSplit): Ditto.
        (KJS::stringProtoFuncSubstr): Ditto.
        (KJS::stringProtoFuncSubstring): Ditto.
        (KJS::stringProtoFuncToLowerCase): Use toThisJSString.
        (KJS::stringProtoFuncToUpperCase): Ditto.
        (KJS::stringProtoFuncToLocaleLowerCase): Ditto.
        (KJS::stringProtoFuncToLocaleUpperCase): Ditto.
        (KJS::stringProtoFuncLocaleCompare): Ditto.
        (KJS::stringProtoFuncBig): Use toThisString.
        (KJS::stringProtoFuncSmall): Ditto.
        (KJS::stringProtoFuncBlink): Ditto.
        (KJS::stringProtoFuncBold): Ditto.
        (KJS::stringProtoFuncFixed): Ditto.
        (KJS::stringProtoFuncItalics): Ditto.
        (KJS::stringProtoFuncStrike): Ditto.
        (KJS::stringProtoFuncSub): Ditto.
        (KJS::stringProtoFuncSup): Ditto.
        (KJS::stringProtoFuncFontcolor): Ditto.
        (KJS::stringProtoFuncFontsize): Ditto.
        (KJS::stringProtoFuncAnchor): Ditto.
        (KJS::stringProtoFuncLink): Ditto.

        * kjs/string_object.h: Added toString, toThisString, and toThisJSString.

        * kjs/ustring.cpp:
        (KJS::UString::append): Added a version that takes a character pointer and
        size, so we don't have to create a UString just to append to another UString.
        * kjs/ustring.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-26 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 27 Jun 2008 02:18:40 +0000 (02:18 +0000)]
2008-06-26  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        * bridge/runtime.h: Added include of JSString.h since jsString will soon
        change to return a JSString*.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-26 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 27 Jun 2008 02:17:52 +0000 (02:17 +0000)]
2008-06-26  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        * JSUtils.cpp: Added include of <JavaScriptCore/JSString.h> since jsString
        will soon be changed to return a JSString*.
        * UserObjectImp.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-26 Adele Peterson <adele@apple.com>
adele@apple.com [Fri, 27 Jun 2008 00:08:49 +0000 (00:08 +0000)]
2008-06-26  Adele Peterson  <adele@apple.com>

        Fix suggested by Eric Carlson, added by me, reviewed by Adam.

        Fix for <rdar://problem/5733006> <video> and <audio> element should not prompt user for missing files

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie):
        Set object with key QTMovieAskUnresolvedDataRefsAttribute to NO in the attributes dictionary passed to -[QTMovie initWithAttributes:]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-26 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 27 Jun 2008 00:03:25 +0000 (00:03 +0000)]
2008-06-26  Sam Weinig  <sam@webkit.org>

        Reviewed by John Sullivan.

        <rdar://problem/6031969> Crash in SecurityOrigin code going Forward to a page in the back/forward cache

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::open): Make sure to update the SecurityOrigin and URL of the
        DOMWindow when opening a CachedPage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKitTools:
bdakin@apple.com [Thu, 26 Jun 2008 22:54:55 +0000 (22:54 +0000)]
WebKitTools:

2008-06-26  Beth Dakin  <bdakin@apple.com>

        Reviewed by Sam.

        Do not include AXPosition in the dump of all of the accessibility
        attributes since it is screen-specific.

        * DumpRenderTree/mac/AccessibilityControllerMac.mm:
        (AccessibilityController::allAttributesOfFocusedElement):

LayoutTests:

2008-06-26  Beth Dakin  <bdakin@apple.com>

        Reviewed by Sam.

        Updated results that will pass on all platforms.

        * accessibility/document-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Beth Dakin.
eric@webkit.org [Thu, 26 Jun 2008 22:45:47 +0000 (22:45 +0000)]
    Reviewed by Beth Dakin.

        CSS @import statements can cause DocLoader to use
        a dead Frame pointer.
        https://bugs.webkit.org/show_bug.cgi?id=19618

        The fix is to get rid of the Frame pointer on DocLoader.

        I also took this opportunity to clean up Document::detach
        a little to make it clear why we clear the m_frame pointer
        there, and to note that in the future we should stop
        using Node::detach to mean "tear down the whole rendering
        tree and detach from the frame".

        Test: I don't know how to make a good test for this, the test
        we have is network timing dependent and does not make a good
        layout test.

        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::detach):
        (WebCore::Document::clearFramePointer):
        * dom/Document.h:
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::frame):
        * loader/DocLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-26 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 26 Jun 2008 22:22:01 +0000 (22:22 +0000)]
2008-06-26  Sam Weinig  <sam@webkit.org>

        Update result after adding new progress events to XMLHttpRequest.

        * fast/dom/xmlhttprequest-get-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-26 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Thu, 26 Jun 2008 21:32:48 +0000 (21:32 +0000)]
2008-06-26  Beth Dakin  <bdakin@apple.com>

        Reviewed by Anders.

        This is a speculative fix for the failing layout test on the build
        bot. It seems that the problem that the Build Bot is having is
        Tiger-specific. On Tiger, [NSValue description] was not very smart.
        So I replaced our call to description with a hand-rolled equivalent
        that will match on both platforms.

        * DumpRenderTree/mac/AccessibilityControllerMac.mm:
        (descriptionOfValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit:
andersca@apple.com [Thu, 26 Jun 2008 20:13:50 +0000 (20:13 +0000)]
WebKit:

2008-06-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Add MainThreadObjectDeallocator to sources.

        * WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-06-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Add a new MainThreadObjectDeallocator which can schedule dealloc calls on the main thread
        if necessary. Use this for the WebView class.

        * WebView/MainThreadObjectDeallocator.h: Added.
        * WebView/MainThreadObjectDeallocator.mm: Added.
        (deallocCallback):
        (scheduleDeallocateOnMainThread):
        * WebView/WebView.mm:
        (-[WebViewPrivate dealloc]):
        (+[WebView initialize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-26 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 26 Jun 2008 19:07:32 +0000 (19:07 +0000)]
2008-06-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Brady.

        Don't enumerate document.applets trying to determine if a page contains applets.
        Instead, set m_containsPlugIns to true when an applet has been created.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::canCachePage):
        (WebCore::FrameLoader::createJavaAppletWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Maciej.
ap@webkit.org [Thu, 26 Jun 2008 18:59:26 +0000 (18:59 +0000)]
    Reviewed by Maciej.

        Make JSGlobalData per-thread.

        No change on SunSpider total.

        * wtf/ThreadSpecific.h: Re-enabled the actual implementation.

        * kjs/JSGlobalObject.cpp:
        (KJS::JSGlobalObject::~JSGlobalObject): Re-added a JSLock-related assertion. We'll probably
        want to preserve these somehow to keep legacy behavior in working condition.
        (KJS::JSGlobalObject::init): Initialize globalData pointer earlier, so that it is ready
        when updating JSGlobalObject linked list.

        * kjs/JSGlobalObject.h: (KJS::JSGlobalObject::head): Changed head() to be non-static, and
        to use JSGlobalData associated with the current object.

        * kjs/InitializeThreading.cpp: (KJS::initializeThreadingOnce): Removed a no longer needed
        Heap::registerAsMainThread() call.

        * kjs/JSGlobalData.h: Removed a lying lie comment - parserObjectExtraRefCounts is not
        transient, and while newParserObjects may conceptually be such, there is still some node
        manipulation going on outside Parser::parse which touches it.

        * kjs/JSGlobalData.cpp:
        (KJS::JSGlobalData::~JSGlobalData): Delete recently added members.
        (KJS::JSGlobalData::sharedInstance): Actually use a separate instance.

        * kjs/collector.cpp:
        (KJS::Heap::Heap):
        (KJS::Heap::~Heap): Added a destructor, which unconditionally deletes everything.
        (KJS::Heap::sweep): Removed code related to "collect on main thread only" logic.
        (KJS::Heap::collect): Ditto.
        (KJS::Heap::globalObjectCount): Explicitly use per-thread instance of JSGlobalObject linked
        list now that JSGlobalObject::head() is not static. Curently, WebCoreStatistics methods only
        work with the main thread currently anyway.
        (KJS::Heap::protectedGlobalObjectCount): Ditto.

        * kjs/collector.h: Removed code related to "collect on main thread only" logic.

        * JavaScriptCore.exp: Removed Heap::collectOnMainThreadOnly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Thu, 26 Jun 2008 18:37:44 +0000 (18:37 +0000)]
    Reviewed by Darin.

        https://bugs.webkit.org/show_bug.cgi?id=19767
        REGRESSION: Crash in sort() when visiting http://www.onnyturf.com/subway/

        * kjs/JSArray.cpp: (KJS::AVLTreeAbstractorForArrayCompare::set_balance_factor):
        Made changing balance factor from -1 to +1 work correctly.

        * wtf/AVLTree.h: (KJS::AVLTreeDefaultBSet::operator[]): Added an assertion that catches
        this slightly earlier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-26 Holger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Thu, 26 Jun 2008 17:17:49 +0000 (17:17 +0000)]
2008-06-26  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Simon.

        [svg] Disable plugins for SVG images
        The Qt platform allows to have a plugin factory per Page. Now SVG Images
        are using a Page and dummy/empty clients for Chrome. The only way to get
        the kit from the WebCore::Page is to go through the ChromeClient but this
        is not possible when the ChromeClient is an empty client. This leads to a
        crash in PluginDataQt.cpp. One way to avoid this would have been the
        addition of a rtti like field to ChromeClient to see if it is an empty
        client. The other possibility is to not enable plugins for images.

        The SVGImage relies on the fact that the document is a SVGDocument and
        that the rootElement is a SVGSVGElement. If plugins are used we could
        end up with a PluginDocument and crash badly. Do not try to use plugins
        if plugins are disabled for the WebCore::Page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-25 Holger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Thu, 26 Jun 2008 17:17:29 +0000 (17:17 +0000)]
2008-06-25  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Simon.

        CodingStyle fixes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-25 Holger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Thu, 26 Jun 2008 17:17:02 +0000 (17:17 +0000)]
2008-06-25  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Simon.

        [svg] Make QtWebKit build more of the SVG support
        Add the proper defines and files, update SVGResourceFilterQt.cpp
        to be enabled by the filter option and not by experimental svg support

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-25 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 26 Jun 2008 15:41:00 +0000 (15:41 +0000)]
2008-06-25  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark.

        <rdar://problem/5984270>
        REGRESSION (Tiger only) : Mail crashes because message load is being processed on a secondary thread

        * WebView/WebView.mm:
        (tigerMailReleaseIMP):
        New method that makes sure that the final release happens on the main thread.

        (-[WebView release]):
        New method that just calls [super release];

        (+[WebView initialize]):
        When running under Tiger mail, replace the release method with tigerMailReleaseIMP.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-25 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 26 Jun 2008 01:52:39 +0000 (01:52 +0000)]
2008-06-25  Maciej Stachowiak  <mjs@apple.com>

        Not reviewed, web site fix.

        Remove blank lines in an attempt to fix feeds.

        * blog/wp-content/themes/webkit/index.php:
        * blog/wp-content/themes/webkit/links.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-25 Jean-Charles VerdiƩ <jcverdie@pleyo.com>
mitz@apple.com [Thu, 26 Jun 2008 01:10:17 +0000 (01:10 +0000)]
2008-06-25  Jean-Charles VerdiĆ©  <jcverdie@pleyo.com>

        Reviewed by Geoffrey Garen.

        - https://bugs.webkit.org/show_bug.cgi?id=19581
          Disable hanging test

        * dom/xhtml/level2/html/HTMLFrameElement09.xhtml: Removed.
        * dom/xhtml/level2/html/HTMLFrameElement09.xhtml-disabled: Copied from LayoutTests/dom/xhtml/level2/html/HTMLFrameElement09.xhtml.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKitTools:
bdakin@apple.com [Thu, 26 Jun 2008 00:22:59 +0000 (00:22 +0000)]
WebKitTools:

2008-06-25  Beth Dakin  <bdakin@apple.com>

        Reviewed by Sam Weinig.

        This patch adds support to the AccessibilityController to query the
        following attributes specifically, without a full attribute dump:
        AXRole, AXTitle, and AXDescription.

        * DumpRenderTree/AccessibilityController.cpp:
        (allAttributesForFocusedElementCallback):
        (roleOfFocusedElementCallback):
        (titleOfFocusedElementCallback):
        (descriptionOfFocusedElementCallback):
        (AccessibilityController::staticFunctions):
        * DumpRenderTree/AccessibilityController.h:
        * DumpRenderTree/mac/AccessibilityControllerMac.mm:
        (AccessibilityController::allAttributesForFocusedElement):
        (concatenateAttributeAndValue):
        (AccessibilityController::roleOfFocusedElement):
        (AccessibilityController::titleOfFocusedElement):
        (AccessibilityController::descriptionOfFocusedElement):

LayoutTests:

2008-06-25  Beth Dakin  <bdakin@apple.com>

        Reviewed by Sam Weinig.

        New tests that exercise the ability to query the following
        accessibility attributes individually: role, title, and
        description.

        * accessibility/aria-describedby-on-input-expected.txt: Added.
        * accessibility/aria-describedby-on-input.html: Added.
        * accessibility/aria-labelledby-on-input-expected.txt: Added.
        * accessibility/aria-labelledby-on-input.html: Added.
        * accessibility/aria-roles-expected.txt: Added.
        * accessibility/aria-roles.html: Added.
        * accessibility/document-attributes.html:
        * accessibility/resources: Added.
        * accessibility/resources/cake.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-25 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 25 Jun 2008 23:44:02 +0000 (23:44 +0000)]
2008-06-25  Sam Weinig  <sam@webkit.org>

        Reviewed by Brady Eidson.

        Move XMLHttpRequestState enum into XMLHttpRequest and rename to State.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::readyState):
        (WebCore::XMLHttpRequest::changeState):
        (WebCore::XMLHttpRequest::open):
        * xml/XMLHttpRequest.h:
        (WebCore::XMLHttpRequest::create):
        (WebCore::XMLHttpRequest::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fixes an ASSERT in the profiler when starting multiple profiles
timothy@apple.com [Wed, 25 Jun 2008 21:44:42 +0000 (21:44 +0000)]
    Fixes an ASSERT in the profiler when starting multiple profiles
        with the same name inside the same function/program.

        Reviewed by Kevin McCullough.

        * profiler/Profile.cpp:
        (KJS::Profile::Profile): Initialize m_stoppedCallDepth to zero.
        (KJS::Profile::stopProfiling): Set the current node to the parent,
        because we are in a call that will not get a didExecute call.
        (KJS::Profile::removeProfile): Increment m_stoppedCallDepth to
        account for didExecute not being called for profile.
        (KJS::Profile::willExecute): Increment m_stoppedCallDepth if stopped.
        (KJS::Profile::didExecute): Decrement m_stoppedCallDepth if stopped and
        greater than zero, and return early.
        * profiler/Profile.h: Added stoppedProfiling().
        * profiler/Profiler.cpp:
        (KJS::Profiler::findProfile): Removed.
        (KJS::Profiler::startProfiling): Don't return early for stopped profiles.
        (KJS::Profiler::stopProfiling): Skipp stopped profiles.
        (KJS::Profiler::didFinishAllExecution): Code clean-up.
        * profiler/Profiler.h: Removed findProfile.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justin.garcia@apple.com [Wed, 25 Jun 2008 21:22:12 +0000 (21:22 +0000)]
WebCore:

2008-06-25  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John.

        <rdar://problem/5994480> Line break lost on some pastes

        Merging the the first paragraph of inserted content with the content that came
        before the selection that was pasted into would also move content after
        the selection that was pasted into if:

        1) Only one paragraph was being pasted, and it was not wrapped in a block
        2) The selection that was pasted into ended at the end of a block
        3) The next paragraph didn't start at the start of a block.

        Insert a line break just after the inserted content to separate it from what
        comes after and prevent that from happening.

        Doing this exposed a bug in deletion where it would insert an unnecessary placeholder
        when deleting a paragraph that started or ended with an input element.  This was
        because its m_startBlock and m_endBlock were still computed with the old deprecated
        enclosingBlockFlowOrTableElement().

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::initializePositionData): Use the new method for
        getting an enclosing block.
        (WebCore::DeleteSelectionCommand::doApply): The new method for getting an enclosing
        block will return 0 if it reaches the root editable element before finding a block,
        so if we're deleting inside an inline editable root, m_start/endBlock will
        be 0.  Removed an early return for this case (we already have test coverage for it).
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): Insert a line break just after the inserted
        content to separate it from what comes after.
        * dom/Node.h: Removed enclosingBlockFlowOrTableElement().
        * dom/Node.cpp: Ditto.

LayoutTests:

2008-06-25  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John.

        <rdar://problem/5994480> Line break lost on some pastes

        These demonstrate fixes:
        * editing/inserting/5994480.html: Added.
        * editing/inserting/5994480-expected.txt: Added.
        * editing/inserting/5994480-2.html: Added.
        * editing/inserting/5994480-2-expected.txt: Added.

        The changes made in this fix caused more of the unrendered text from the original
        file to be preserved and show up in the test results.  We insert a line break after
        inserted content to separate it from content that comes after and prevent it from
        being merged.  In these what came after was unrendered whitespace that was previously
        clobbered by the merge:
        * platform/mac/editing/pasteboard/paste-match-style-001-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-010-expected.txt:
        * platform/mac/editing/pasteboard/smart-paste-001-expected.txt:
        * platform/mac/editing/style/style-boundary-005-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixed date.
ddkilzer@apple.com [Wed, 25 Jun 2008 20:51:10 +0000 (20:51 +0000)]
Fixed date.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Make PrettyPatch handle diffs with no Index or diff headers
ddkilzer@apple.com [Wed, 25 Jun 2008 18:49:52 +0000 (18:49 +0000)]
    Make PrettyPatch handle diffs with no Index or diff headers

        Part of Bug 19290: More patches not handled by PrettyPatch.rb
        <https://bugs.webkit.org/show_bug.cgi?id=19290>

        Reviewed by Adam.

        * PrettyPatch/PrettyPatch.rb:
        (PrettyPatch.DIFF_HEADER_FORMATS): Added regular expression to
        match on "+++ " lines for patches with no "Index" or "diff" header.
        (PrettyPatch.FileDiff.initialize): Look for filename on "+++ " line
        when the first line of a patch has no "Index" or "diff" header.
        (PrettyPatch.FileDiff.parse): Added haveSeenDiffHeader state
        variable to determine when no "Index" or "diff" header has been
        found, but a new patch has started with a "--- " line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-25 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 25 Jun 2008 18:21:56 +0000 (18:21 +0000)]
2008-06-25  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dave Hyatt.

        Fix refcount leak in CSSVariablesRule.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::createVariablesRule):
        * css/CSSVariablesRule.h:
        (WebCore::CSSVariablesRule::create):
        (WebCore::CSSVariablesRule::setDeclaration):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca@apple.com [Wed, 25 Jun 2008 17:31:14 +0000 (17:31 +0000)]
WebCore:

2008-06-25  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        <rdar://problem/6007111>
        https://bugs.webkit.org/show_bug.cgi?id=19516
        DOM modification causes Access Violation (NULL pointer?)

        Null check the document element.

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::handleError):

LayoutTests:

2008-06-25  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        <rdar://problem/6007111>
        https://bugs.webkit.org/show_bug.cgi?id=19516
        DOM modification causes Access Violation (NULL pointer?)

        * fast/dom/HTMLHtmlElement/duplicate-html-element-crash-expected.txt: Added.
        * fast/dom/HTMLHtmlElement/duplicate-html-element-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Wed, 25 Jun 2008 16:36:17 +0000 (16:36 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5873639> REGRESSION (r31620): css2.1/t1506-c525-font-wt-00-b fails on Windows

        - fix https://bugs.webkit.org/show_bug.cgi?id=18863
          <rdar://problem/5908890> weight mappings with @font-face aren't consistent

        Tests: fast/css/font-face-locally-installed.html
               fast/css/font-face-multiple-faces.html

        * WebCore.vcproj/WebCore.vcproj: Added FontTraitsMask.h.

        * WebCore.xcodeproj/project.pbxproj: Ditto.

        * css/CSSFontFace.h:
        Made CSSFontFace store descriptors from the @font-face rule, as follows:
        (WebCore::CSSFontFace::create): Added a FontTraitsMask argument.
        (WebCore::CSSFontFace::traitsMask): Added this accessor.
        (WebCore::CSSFontFace::addRange): Added.
        (WebCore::CSSFontFace::ranges): Added.
        (WebCore::CSSFontFace::UnicodeRange::UnicodeRange):
        (WebCore::CSSFontFace::UnicodeRange::from):
        (WebCore::CSSFontFace::UnicodeRange::to):
        (WebCore::CSSFontFace::CSSFontFace): Added a FontTraitsMask and a vector
        of UnicodeRanges as member variables.

        * css/CSSFontFaceSource.cpp:
        Changed the hash key from the font size alone to the font size and
        the synthetic style bits, needed if the same source supplies different
        synthesized versions.
        (WebCore::CSSFontFaceSource::pruneTable):
        (WebCore::CSSFontFaceSource::getFontData):

        * css/CSSFontFaceSource.h:

        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::~CSSFontSelector): Added code to delete
        the contents of the font face, locally-installed font face and segmented
        font tables.
        (WebCore::CSSFontSelector::addFontFaceRule): Changed this function to
        not create segmented font faces, but instead just collect font faces
        and annotate them with descriptors (traits and unicode ranges).
        (WebCore::compareFontFaces): Added. Used in getFontData() to sort the
        font faces by proximity to the desired traits.
        (WebCore::CSSFontSelector::getFontData): Changed to create the segmented
        font face here and cache it.

        * css/CSSFontSelector.h:

        * css/CSSSegmentedFontFace.cpp:
        Changed to keep a vector of font faces instead of font face ranges, as
        font faces now know their Unicode ranges.
        (WebCore::CSSSegmentedFontFace::~CSSSegmentedFontFace):
        (WebCore::CSSSegmentedFontFace::isLoaded):
        (WebCore::CSSSegmentedFontFace::isValid):
        (WebCore::CSSSegmentedFontFace::appendFontFace):
        (WebCore::CSSSegmentedFontFace::getFontData): Removed the synthetic
        traits parameters, and instead changed to set them on each FontData
        separately based on the difference between the desired traits and
        the font face's traits.

        * css/CSSSegmentedFontFace.h:

        * platform/graphics/FontCache.h:
        Removed fontExists() and added getTraitsInFamily().

        * platform/graphics/FontDescription.cpp:
        (WebCore::FontDescription::traitsMask): Added.

        * platform/graphics/FontDescription.h:

        * platform/graphics/FontTraitsMask.h: Added.

        * platform/graphics/GlyphPageTreeNode.cpp:
        (WebCore::GlyphPageTreeNode::initializePage): Changed to fill in with
        glyphs from all fonts in the segmented font, using each font in turn to
        fill in characters not covered by earlier fonts.

        * platform/graphics/gtk/FontCacheGtk.cpp:
        (WebCore::FontCache::getTraitsInFamily): Added a stub.

        * platform/graphics/mac/FontCacheMac.mm:
        (WebCore::FontCache::getTraitsInFamily): Added.

        * platform/graphics/qt/FontCacheQt.cpp:
        (WebCore::FontCache::getTraitsInFamily): Added a stub.

        * platform/graphics/win/FontCacheWin.cpp:
        (WebCore::TraitsInFamilyProcData::TraitsInFamilyProcData): Added.
        (WebCore::traitsInFamilyEnumProc): Added.
        (WebCore::FontCache::getTraitsInFamily): Added.

        * platform/graphics/wx/FontCacheWx.cpp:
        (WebCore::FontCache::getTraitsInFamily): Added a stub.

        * platform/mac/WebFontCache.h:
        * platform/mac/WebFontCache.mm:
        (toTraitsMask): Added.
        (+[WebFontCache getTraits:inFamily:]): Added.

LayoutTests:

        Reviewed by Dave Hyatt.

        - tests for https://bugs.webkit.org/show_bug.cgi?id=18863
          <rdar://problem/5908890> weight mappings with @font-face aren't consistent

        * fast/css/font-face-locally-installed.html: Added.
        * fast/css/font-face-multiple-faces.html: Added.
        * platform/mac/fast/css/font-face-locally-installed-expected.checksum: Added.
        * platform/mac/fast/css/font-face-locally-installed-expected.png: Added.
        * platform/mac/fast/css/font-face-locally-installed-expected.txt: Added.
        * platform/mac/fast/css/font-face-multiple-faces-expected.checksum: Added.
        * platform/mac/fast/css/font-face-multiple-faces-expected.png: Added.
        * platform/mac/fast/css/font-face-multiple-faces-expected.txt: Added.
        * platform/win/Skipped: Removed css2.1/t1506-c525-font-wt-00-b.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-25 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Wed, 25 Jun 2008 08:38:07 +0000 (08:38 +0000)]
2008-06-25  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Alexey Proskuryakov.

        Attempt to fix Windows debug build. The compiler gives a warning when
        Structured Exception Handling and destructors are used in the same
        function. Using manual locking and unlocking instead of constructors
        and destructors should fix the warning.

        * kjs/Shell.cpp:
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Forgot to address a review comment about better names for tracked objects...
ap@webkit.org [Wed, 25 Jun 2008 07:15:20 +0000 (07:15 +0000)]
    Forgot to address a review comment about better names for tracked objects, doing it now.

        * kjs/JSGlobalData.cpp:
        (KJS::JSGlobalData::JSGlobalData):
        * kjs/JSGlobalData.h:
        * kjs/nodes.cpp:
        (KJS::ParserRefCounted::ParserRefCounted):
        (KJS::ParserRefCounted::ref):
        (KJS::ParserRefCounted::deref):
        (KJS::ParserRefCounted::hasOneRef):
        (KJS::ParserRefCounted::deleteNewObjects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoff.
ap@webkit.org [Wed, 25 Jun 2008 07:07:38 +0000 (07:07 +0000)]
    Reviewed by Geoff.

        Remove more threadInstance() calls.

        * kjs/JSFunction.cpp:
        (KJS::JSFunction::getParameterName):
        (KJS::IndexToNameMap::unMap):
        (KJS::Arguments::deleteProperty):
        * kjs/JSFunction.h:
        Access nullIdentifier without going to thread specific storage.

        * JavaScriptCore.exp:
        * kjs/JSGlobalData.cpp:
        (KJS::JSGlobalData::JSGlobalData):
        * kjs/JSGlobalData.h:
        * kjs/Parser.cpp:
        (KJS::Parser::parse):
        * kjs/Parser.h:
        (KJS::ParserRefCountedData::ParserRefCountedData):
        (KJS::Parser::parse):
        * kjs/grammar.y:
        * kjs/nodes.cpp:
        (KJS::ParserRefCounted::ParserRefCounted):
        (KJS::ParserRefCounted::ref):
        (KJS::ParserRefCounted::deref):
        (KJS::ParserRefCounted::hasOneRef):
        (KJS::ParserRefCounted::deleteNewObjects):
        (KJS::Node::Node):
        (KJS::StatementNode::StatementNode):
        (KJS::BreakpointCheckStatement::BreakpointCheckStatement):
        (KJS::ConstDeclNode::ConstDeclNode):
        (KJS::BlockNode::BlockNode):
        (KJS::ForInNode::ForInNode):
        (KJS::ScopeNode::ScopeNode):
        (KJS::ProgramNode::ProgramNode):
        (KJS::ProgramNode::create):
        (KJS::EvalNode::EvalNode):
        (KJS::EvalNode::create):
        (KJS::FunctionBodyNode::FunctionBodyNode):
        (KJS::FunctionBodyNode::create):
        * kjs/nodes.h:
        (KJS::ExpressionNode::):
        (KJS::NullNode::):
        (KJS::BooleanNode::):
        (KJS::NumberNode::):
        (KJS::ImmediateNumberNode::):
        (KJS::StringNode::):
        (KJS::RegExpNode::):
        (KJS::ThisNode::):
        (KJS::ResolveNode::):
        (KJS::ElementNode::):
        (KJS::ArrayNode::):
        (KJS::PropertyNode::):
        (KJS::PropertyListNode::):
        (KJS::ObjectLiteralNode::):
        (KJS::BracketAccessorNode::):
        (KJS::DotAccessorNode::):
        (KJS::ArgumentListNode::):
        (KJS::ArgumentsNode::):
        (KJS::NewExprNode::):
        (KJS::EvalFunctionCallNode::):
        (KJS::FunctionCallValueNode::):
        (KJS::FunctionCallResolveNode::):
        (KJS::FunctionCallBracketNode::):
        (KJS::FunctionCallDotNode::):
        (KJS::PrePostResolveNode::):
        (KJS::PostIncResolveNode::):
        (KJS::PostDecResolveNode::):
        (KJS::PostfixBracketNode::):
        (KJS::PostIncBracketNode::):
        (KJS::PostDecBracketNode::):
        (KJS::PostfixDotNode::):
        (KJS::PostIncDotNode::):
        (KJS::PostDecDotNode::):
        (KJS::PostfixErrorNode::):
        (KJS::DeleteResolveNode::):
        (KJS::DeleteBracketNode::):
        (KJS::DeleteDotNode::):
        (KJS::DeleteValueNode::):
        (KJS::VoidNode::):
        (KJS::TypeOfResolveNode::):
        (KJS::TypeOfValueNode::):
        (KJS::PreIncResolveNode::):
        (KJS::PreDecResolveNode::):
        (KJS::PrefixBracketNode::):
        (KJS::PreIncBracketNode::):
        (KJS::PreDecBracketNode::):
        (KJS::PrefixDotNode::):
        (KJS::PreIncDotNode::):
        (KJS::PreDecDotNode::):
        (KJS::PrefixErrorNode::):
        (KJS::UnaryOpNode::UnaryOpNode):
        (KJS::UnaryPlusNode::):
        (KJS::NegateNode::):
        (KJS::BitwiseNotNode::):
        (KJS::LogicalNotNode::):
        (KJS::BinaryOpNode::BinaryOpNode):
        (KJS::ReverseBinaryOpNode::ReverseBinaryOpNode):
        (KJS::MultNode::):
        (KJS::DivNode::):
        (KJS::ModNode::):
        (KJS::AddNode::):
        (KJS::SubNode::):
        (KJS::LeftShiftNode::):
        (KJS::RightShiftNode::):
        (KJS::UnsignedRightShiftNode::):
        (KJS::LessNode::):
        (KJS::GreaterNode::):
        (KJS::LessEqNode::):
        (KJS::GreaterEqNode::):
        (KJS::InstanceOfNode::):
        (KJS::InNode::):
        (KJS::EqualNode::):
        (KJS::NotEqualNode::):
        (KJS::StrictEqualNode::):
        (KJS::NotStrictEqualNode::):
        (KJS::BitAndNode::):
        (KJS::BitOrNode::):
        (KJS::BitXOrNode::):
        (KJS::LogicalAndNode::):
        (KJS::LogicalOrNode::):
        (KJS::ConditionalNode::):
        (KJS::ReadModifyResolveNode::):
        (KJS::AssignResolveNode::):
        (KJS::ReadModifyBracketNode::):
        (KJS::AssignBracketNode::):
        (KJS::AssignDotNode::):
        (KJS::ReadModifyDotNode::):
        (KJS::AssignErrorNode::):
        (KJS::CommaNode::):
        (KJS::VarDeclCommaNode::):
        (KJS::ConstStatementNode::):
        (KJS::SourceElements::SourceElements):
        (KJS::EmptyStatementNode::):
        (KJS::DebuggerStatementNode::):
        (KJS::ExprStatementNode::):
        (KJS::VarStatementNode::):
        (KJS::IfNode::):
        (KJS::IfElseNode::):
        (KJS::DoWhileNode::):
        (KJS::WhileNode::):
        (KJS::ForNode::):
        (KJS::ContinueNode::):
        (KJS::BreakNode::):
        (KJS::ReturnNode::):
        (KJS::WithNode::):
        (KJS::LabelNode::):
        (KJS::ThrowNode::):
        (KJS::TryNode::):
        (KJS::ParameterNode::):
        (KJS::FuncExprNode::):
        (KJS::FuncDeclNode::):
        (KJS::CaseClauseNode::):
        (KJS::ClauseListNode::):
        (KJS::CaseBlockNode::):
        (KJS::SwitchNode::):
        Changed ParserRefCounted to hold a JSGlobalData pointer, and used it to replace
        threadInstance calls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-24 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Wed, 25 Jun 2008 06:34:06 +0000 (06:34 +0000)]
2008-06-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Alexey Proskuryakov.

        Make the JavaScript shell collect the heap from main() instead of
        jscmain() to suppress leak messages in debug builds.

        * kjs/Shell.cpp:
        (main):
        (jscmain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
abarth@webkit.org [Wed, 25 Jun 2008 04:35:46 +0000 (04:35 +0000)]
WebCore:

2008-06-24  Anonymous

        Reviewed by Darin Adler.  Committed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=19470

        Check for a null documentElement() to fix four crashes.

        * WebCore/dom/Document.cpp:
        * WebCore/dom/Node.cpp:

LayoutTests:

2008-06-24  Anonymous

        Reviewed by Darin Adler.  Committed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=19470

        Check for a null documentElement() to fix four crashes.

        * LayoutTests/fast/dom/documentElement-null-expected.txt: Added.
        * LayoutTests/fast/dom/documentElement-null.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix png mime-type
abarth@webkit.org [Wed, 25 Jun 2008 04:32:59 +0000 (04:32 +0000)]
Fix png mime-type

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
abarth@webkit.org [Wed, 25 Jun 2008 04:14:08 +0000 (04:14 +0000)]
WebCore:

2008-06-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Fix <https://bugs.webkit.org/show_bug.cgi?id=19597>

        Correctly parse <!-- </textarea> --> inside a <textarea>, matching
        Internet Explorer, Firefox, Opera, and HTML 5.

        Tests: fast/parser/comment-in-script-tricky.html
               fast/parser/comment-in-style.html
               fast/parser/comment-in-textarea.html
               fast/parser/comment-in-title.html

        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::parseSpecial):

LayoutTests:

2008-06-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=19597

        Test that we correctly parse comments containing end tags in CDATA and
        RCDATA contexts.

        * fast/parser/comment-in-script-tricky-expected.txt: Added.
        * fast/parser/comment-in-script-tricky.html: Added.
        * fast/parser/comment-in-style.html: Added.
        * fast/parser/comment-in-textarea.html: Added.
        * fast/parser/comment-in-title-expected.txt: Added.
        * fast/parser/comment-in-title.html: Added.
        * platform/mac/fast/parser/comment-in-style-expected.checksum: Added.
        * platform/mac/fast/parser/comment-in-style-expected.png: Added.
        * platform/mac/fast/parser/comment-in-style-expected.txt: Added.
        * platform/mac/fast/parser/comment-in-textarea-expected.checksum: Added.
        * platform/mac/fast/parser/comment-in-textarea-expected.png: Added.
        * platform/mac/fast/parser/comment-in-textarea-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mark Rowe.
mitz@apple.com [Wed, 25 Jun 2008 02:41:09 +0000 (02:41 +0000)]
    Reviewed by Mark Rowe.

        - add another test using remote fonts to the Tiger skipped list

        * platform/mac-tiger/Skipped: Added fast/css/font-weight-1.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-24 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Wed, 25 Jun 2008 02:04:23 +0000 (02:04 +0000)]
2008-06-24  Mark Rowe  <mrowe@apple.com>

        Exclude the newly-added accessibilityController from the dumped window properties.

        * fast/dom/Window/window-properties.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-24 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Wed, 25 Jun 2008 00:41:40 +0000 (00:41 +0000)]
2008-06-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej.

        Make the conversion of the pair (less, jtrue) to jless use register
        reference counting information for safety instead of requiring callers
        to decide whether it is safe.

        No changes on SunSpider codegen.

        * VM/CodeGenerator.cpp:
        (KJS::CodeGenerator::emitJumpIfTrue):
        * VM/CodeGenerator.h:
        * kjs/nodes.cpp:
        (KJS::DoWhileNode::emitCode):
        (KJS::WhileNode::emitCode):
        (KJS::ForNode::emitCode):
        (KJS::CaseBlockNode::emitCodeForBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Stephanie Lewis.
mitz@apple.com [Wed, 25 Jun 2008 00:36:52 +0000 (00:36 +0000)]
    Reviewed by Stephanie Lewis.

        - move the linker flags from the debug configuration in the project
          to the shared configuration

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - try to fix the Tiger build
mitz@apple.com [Wed, 25 Jun 2008 00:03:35 +0000 (00:03 +0000)]
    - try to fix the Tiger build

        * DumpRenderTree/mac/AccessibilityControllerMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-24 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Tue, 24 Jun 2008 23:03:11 +0000 (23:03 +0000)]
2008-06-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Rubber stamped by Oliver.

        Roll out r34777 due to multiple assertion failures on tests.

        * ChangeLog:
        * VM/CodeGenerator.cpp:
        (KJS::CodeGenerator::emitJump):
        (KJS::CodeGenerator::emitJumpIfTrueMayCombine):
        (KJS::CodeGenerator::emitJumpIfTrue):
        (KJS::CodeGenerator::emitJumpIfFalse):
        (KJS::CodeGenerator::emitJumpScopes):
        * VM/LabelID.h:
        * VM/Machine.cpp:
        (KJS::Machine::privateExecute):
        * VM/Machine.h:
        * VM/Opcode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justin.garcia@apple.com [Tue, 24 Jun 2008 22:31:40 +0000 (22:31 +0000)]
WebCore:

2008-06-24  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John.

        <rdar://problem/6026335> REGRESSION: Caret disappears after deleting a particular selection involving a ToDo

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraphs): If asked to preserveStyle, we
        apply styles from the moved paragraph to the destination with applyStyle, which
        does selection preservation when it needs to apply block styles.  Selection preservation
        uses relatively untested code in TextIterator to count VisiblePositions which fails in
        this particular test case because it doesn't handle changes in editability properly.
        We can avoid this bug by not applying block styles from moved paragraphs.  This is
        something that should be done anyway, since the moved paragraph should assume the
        block styles of the destination.
        * editing/EditCommand.cpp:
        (WebCore::EditCommand::styleAtPosition): Added a FIXME about how it is misleading for
        this function to also include the typing style.
        * editing/TextIterator.h: Added a FIXME about how the code path used for selection preservation
        is buggy and should be phased out when we rewrite moveParagraphs.

LayoutTests:

2008-06-24  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John.

        <rdar://problem/6026335> REGRESSION: Caret disappears after deleting a particular selection involving a ToDo

        * editing/deleting/6026335-expected.txt: Added.
        * editing/deleting/6026335.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-24 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 24 Jun 2008 21:30:27 +0000 (21:30 +0000)]
2008-06-24  Kevin McCullough  <kmccullough@apple.com>

        -Added a manual test for the profiler.

        * manual-tests/inspector/profiler-test-compare-multiple-profiles.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-24 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 24 Jun 2008 21:22:21 +0000 (21:22 +0000)]
2008-06-24  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        <rdar://problem/6031594> JSProfiler: Profiler goes into an infinite
        loop sometimes.
        <rdar://problem/6031603> JSProfiler: Profiler asserts in debug and
        give the wrong times in release

        Fixed two issues found by Tim in the same test.

        * profiler/Profile.cpp:
        (KJS::Profile::removeProfileStart): No longer take profile's time from
        all ancestors, but instead attribute it to its parent.  Also add an
        Assert to ensure we only delete the child we mean to.
        (KJS::Profile::removeProfileEnd): Ditto for profileEnd.
        (KJS::Profile::didExecute): Cleaned up the execution order and correctly
        attribute all of the parent's time to the new node.
        * profiler/ProfileNode.cpp: If this node does not have a startTime it
        should not get a giant total time, but instead be 0.
        (KJS::ProfileNode::endAndRecordCall):
        * profiler/ProfileNode.h:
        (KJS::ProfileNode::removeChild): Should reset the sibling pointers since
        one of them has been removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoGroundwork for reimplementing the slow script dialog
oliver@apple.com [Tue, 24 Jun 2008 21:19:56 +0000 (21:19 +0000)]
Groundwork for reimplementing the slow script dialog

Reviewed by Cameron.

Add special loop opcodes as groundwork for slow script
termination.  Also added a few assertions to prevent us
from accidentally coalescing conditional jump operands
in a way that might bypass the slow script opcodes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKitTools:
bdakin@apple.com [Tue, 24 Jun 2008 21:02:38 +0000 (21:02 +0000)]
WebKitTools:

2008-06-24  Sam Weinig and Beth Dakin  <bdakin@apple.com and sam@webkit.org>

        Reviewed by Darin.

        Fix for <rdar://problem/5884881> Make DumpRenderTree support
        accessibility tests

        This patch adds some basic support for accessibility layout tests
        on the Mac.

        * DumpRenderTree/AccessibilityController.cpp: Added.
        (AccessibilityController::AccessibilityController):
        (AccessibilityController::~AccessibilityController):
        (dumpCurrentAttributesCallback):
        (AccessibilityController::makeWindowObject):
        (AccessibilityController::getJSClass):
        (AccessibilityController::staticFunctions):
        * DumpRenderTree/AccessibilityController.h: Added.
        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/mac/AccessibilityControllerMac.mm: Added.
        (descriptionOfValue):
        (AccessibilityController::dumpCurrentAttributes):
        * DumpRenderTree/mac/DumpRenderTree.mm:
        * DumpRenderTree/mac/FrameLoadDelegate.h:
        * DumpRenderTree/mac/FrameLoadDelegate.mm:
        (-[FrameLoadDelegate init]):
        (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):

LayoutTests:

2008-06-24  Sam Weinig and Beth Dakin  <bdakin@apple.com and sam@webkit.org>

        Reviewed by Darin.

        First test for <rdar://problem/5884881> Make DumpRenderTree support
        accessibility tests

        * accessibility: Added.
        * accessibility/document-attributes-expected.txt: Added.
        * accessibility/document-attributes.html: Added.
        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Tue, 24 Jun 2008 20:09:42 +0000 (20:09 +0000)]
WebCore:

2008-06-24  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Add support for loadstart, abort and error events for XMLHttpRequests.

        Tests: http/tests/xmlhttprequest/onabort-event.html
               http/tests/xmlhttprequest/onerror-event.html
               http/tests/xmlhttprequest/onloadstart-event.html

        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::mark):
        (WebCore::JSXMLHttpRequest::onreadystatechange):
        (WebCore::JSXMLHttpRequest::onabort):
        (WebCore::JSXMLHttpRequest::setOnabort):
        (WebCore::JSXMLHttpRequest::onerror):
        (WebCore::JSXMLHttpRequest::setOnerror):
        (WebCore::JSXMLHttpRequest::onload):
        (WebCore::JSXMLHttpRequest::onloadstart):
        (WebCore::JSXMLHttpRequest::setOnloadstart):
        (WebCore::JSXMLHttpRequest::onprogress):
        * dom/EventNames.h:
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::callReadyStateChangeListener):
        (WebCore::XMLHttpRequest::createRequest):
        (WebCore::XMLHttpRequest::abort):
        (WebCore::XMLHttpRequest::networkError):
        (WebCore::XMLHttpRequest::abortError):
        (WebCore::XMLHttpRequest::didFail):
        (WebCore::XMLHttpRequest::updateAndDispatchOnProgress):
        (WebCore::XMLHttpRequest::dispatchReadyStateChangeEvent):
        (WebCore::XMLHttpRequest::dispatchXMLHttpRequestProgressEvent):
        (WebCore::XMLHttpRequest::dispatchAbortEvent):
        (WebCore::XMLHttpRequest::dispatchErrorEvent):
        (WebCore::XMLHttpRequest::dispatchLoadEvent):
        (WebCore::XMLHttpRequest::dispatchLoadStartEvent):
        (WebCore::XMLHttpRequest::dispatchProgressEvent):
        * xml/XMLHttpRequest.h:
        (WebCore::XMLHttpRequest::setOnAbortListener):
        (WebCore::XMLHttpRequest::onAbortListener):
        (WebCore::XMLHttpRequest::setOnErrorListener):
        (WebCore::XMLHttpRequest::onErrorListener):
        (WebCore::XMLHttpRequest::setOnLoadStartListener):
        (WebCore::XMLHttpRequest::onLoadStartListener):
        * xml/XMLHttpRequest.idl:

LayoutTests:

2008-06-24  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Add tests for loadstart, abort and error events for XMLHttpRequests

        * http/tests/xmlhttprequest/onabort-event-expected.txt: Added.
        * http/tests/xmlhttprequest/onabort-event.html: Added.
        * http/tests/xmlhttprequest/onerror-event-expected.txt: Added.
        * http/tests/xmlhttprequest/onerror-event.html: Added.
        * http/tests/xmlhttprequest/onloadstart-event-expected.txt: Added.
        * http/tests/xmlhttprequest/onloadstart-event.html: Added.
        * http/tests/xmlhttprequest/resources/get.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-24 John Sullivan <sullivan@apple.com>
sullivan@apple.com [Tue, 24 Jun 2008 20:03:20 +0000 (20:03 +0000)]
2008-06-24  John Sullivan  <sullivan@apple.com>

        Reviewed by Dan Bernstein

        * Scripts/extract-localizable-strings:
        add UI_STRING_LOCALIZE_LATER, LPCTSTR_UI_STRING_LOCALIZE_LATER, and LOG_WARNING to the
        list of debugging macros, to avoid noise when keeping the list of localized string
        exceptions up to date

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-24 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 24 Jun 2008 20:00:48 +0000 (20:00 +0000)]
2008-06-24  Darin Adler  <darin@apple.com>

        Reviewed by Cameron.

        - fix https://bugs.webkit.org/show_bug.cgi?id=19739
          REGRESSION: fast/js/property-getters-and-setters.html fails

        * kjs/JSObject.cpp:
        (KJS::JSObject::put): Remove an untested optimization I checked in by accident.
        The two loops up the prototype chain both need to start from this; instead the
        second loop was starting where the first loop left off.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-24 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 24 Jun 2008 19:56:58 +0000 (19:56 +0000)]
2008-06-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        <rdar://problem/5957606>
        CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::DocumentLoader::cancelPendingSubstituteLoad + 23

        Remove the loader from the document loader after calling didFail, so that the loader will be deferred corectly
        in case the call do didFail starts a new run loop.

        * loader/NetscapePlugInStreamLoader.cpp:
        (WebCore::NetscapePlugInStreamLoader::didCancel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKitTools:
mitz@apple.com [Tue, 24 Jun 2008 19:54:09 +0000 (19:54 +0000)]
WebKitTools:

        Rubber-stamped by Darin Adler.

        - add a font family for testing font-weight

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linker
        flags to create data sections for the WeightWatcher fonts.
        * DumpRenderTree/fonts: Added.
        * DumpRenderTree/fonts/WebKitWeightWatcher100.ttf: Added.
        * DumpRenderTree/fonts/WebKitWeightWatcher200.ttf: Added.
        * DumpRenderTree/fonts/WebKitWeightWatcher300.ttf: Added.
        * DumpRenderTree/fonts/WebKitWeightWatcher400.ttf: Added.
        * DumpRenderTree/fonts/WebKitWeightWatcher500.ttf: Added.
        * DumpRenderTree/fonts/WebKitWeightWatcher600.ttf: Added.
        * DumpRenderTree/fonts/WebKitWeightWatcher700.ttf: Added.
        * DumpRenderTree/fonts/WebKitWeightWatcher800.ttf: Added.
        * DumpRenderTree/fonts/WebKitWeightWatcher900.ttf: Added.
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (activateFonts): Renamed activateAhemFont to this and made it activate
        the WeightWatcher fonts in addition to Ahem.
        (prepareConsistentTestingEnvironment): Adjusted for the name change.
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (initialize): Added the WeightWatcher fonts.

LayoutTests:

        Rubber-stamped by Darin Adler.

        - add font-weight test for a family that has 9 weights

        * fast/css/font-weight-1.html: Added.
        * platform/mac/fast/css/font-weight-1-expected.checksum: Added.
        * platform/mac/fast/css/font-weight-1-expected.png: Added.
        * platform/mac/fast/css/font-weight-1-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix.
sfalken@apple.com [Tue, 24 Jun 2008 19:50:50 +0000 (19:50 +0000)]
    Build fix.

        * kjs/nodes.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-24 John Sullivan <sullivan@apple.com>
sullivan@apple.com [Tue, 24 Jun 2008 18:06:37 +0000 (18:06 +0000)]
2008-06-24  John Sullivan  <sullivan@apple.com>

        Rubber-stamped by Sam Weinig

        * StringsNotToBeLocalized.txt:
        brought this file up to date

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Release build fix.
ap@webkit.org [Tue, 24 Jun 2008 15:43:08 +0000 (15:43 +0000)]
    Release build fix.

        * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
        (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
        * bindings/js/JSCustomSQLTransactionCallback.cpp:
        (WebCore::JSCustomSQLTransactionCallback::handleEvent):
        Initialize callbackCallType, as the compiler is not smart enough to figure out data flow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-24 Joerg Bornemann <joerg.bornemann@trolltech.com>
hausmann@webkit.org [Tue, 24 Jun 2008 14:33:32 +0000 (14:33 +0000)]
2008-06-24  Joerg Bornemann  <joerg.bornemann@trolltech.com>

        Reviewed by Simon.

        For the Qt build on Windows don't depend on the presence of GNU CPP
        but use MSVC's preprocessor instead.
        dftables accepts a --preprocessor option which is set in pcre.pri for MSVC platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Tue, 24 Jun 2008 12:35:52 +0000 (12:35 +0000)]
    Reviewed by Darin.

        https://bugs.webkit.org/show_bug.cgi?id=19723
        REGRESSION(r34648): Some SVG tests crash when running under --threaded

        * rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::destroy): Do not attempt
        to paint during document destruction, because rendering structures are not kept in a
        consistent state then.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-24 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk>
hausmann@webkit.org [Tue, 24 Jun 2008 11:28:55 +0000 (11:28 +0000)]
2008-06-24  Jonathon Jongsma  <jonathon.jongsma@collabora.co.uk>

        Reviewed by Darin.

        https://bugs.webkit.org/show_bug.cgi?id=19727

        Return bool from GraphicsContext::getShadow() so the tests aren't duplicated so
        many times in Cairo and Qt ports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-24 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk>
hausmann@webkit.org [Tue, 24 Jun 2008 10:58:32 +0000 (10:58 +0000)]
2008-06-24  Jonathon Jongsma  <jonathon.jongsma@collabora.co.uk>

        Reviewed by Simon.

        https://bugs.webkit.org/show_bug.cgi?id=18459

        Clean up and remove unused platform shadow code.

        Minor edits by Simon, removed unused TextShadow struct.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-24 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk>
hausmann@webkit.org [Tue, 24 Jun 2008 10:35:53 +0000 (10:35 +0000)]
2008-06-24  Jonathon Jongsma  <jonathon.jongsma@collabora.co.uk>

        Reviewed by Simon.

        https://bugs.webkit.org/show_bug.cgi?id=18459

        Implemented basic text-shadow support for the Qt port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Qt build, adapt to various JSCore API changes.
hausmann@webkit.org [Tue, 24 Jun 2008 10:27:40 +0000 (10:27 +0000)]
Fix the Qt build, adapt to various JSCore API changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Remove XMLHttpRequestProgressEvent.cpp from more project files.
ap@webkit.org [Tue, 24 Jun 2008 10:07:30 +0000 (10:07 +0000)]
    Remove XMLHttpRequestProgressEvent.cpp from more project files.

        * GNUmakefile.am:
        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Cameron Zwarich.
ap@webkit.org [Tue, 24 Jun 2008 09:51:07 +0000 (09:51 +0000)]
    Reviewed by Cameron Zwarich.

        Make ParserRefCountedCounter actually perform a leak check.

        * kjs/nodes.cpp:
        (KJS::ParserRefCountedCounter::~ParserRefCountedCounter): Check for leaks in destructor,
        not in constructor.
        (KJS::ParserRefCountedCounter::increment):
        (KJS::ParserRefCountedCounter::decrement):
        (KJS::ParserRefCounted::ParserRefCounted):
        (KJS::ParserRefCounted::~ParserRefCounted):
        While at it, also made counting thread-safe.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-24 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Tue, 24 Jun 2008 09:39:39 +0000 (09:39 +0000)]
2008-06-24  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        For the Qt port, fix linking with MinGW.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-24 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Tue, 24 Jun 2008 09:38:40 +0000 (09:38 +0000)]
2008-06-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Bug 19730: REGRESSION (r34497): Text in alerts in "Leisure suit Larry" is not wrapped
        <https://bugs.webkit.org/show_bug.cgi?id=19730>

        Do not convert the pair (less, jtrue) to jless when jtrue is a jump
        target. An example of this is when the condition of a while loop is a
        LogicalOrNode.

        JavaScriptCore:

        * VM/CodeGenerator.cpp:
        (KJS::CodeGenerator::emitLabel):

        LayoutTests:

        * fast/js/codegen-loops-logical-nodes-expected.txt: Added.
        * fast/js/codegen-loops-logical-nodes.html: Added.
        * fast/js/resources/codegen-loops-logical-nodes.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-20 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Tue, 24 Jun 2008 09:06:07 +0000 (09:06 +0000)]
2008-06-20  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Adam Roben.

        Fix compile with MinGW.

        * kjs/Shell.cpp:
        * wtf/Threading.h:
        (WTF::atomicIncrement):
        (WTF::atomicDecrement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPrepration for returning memory to the OS on Windows. Track whether a portion of...
mrowe@apple.com [Tue, 24 Jun 2008 05:34:24 +0000 (05:34 +0000)]
Prepration for returning memory to the OS on Windows.  Track whether a portion of a span of memory was returned to the OS.
If it was, ask that it be recommitted before returning it to the application as an allocated region.

Reviewed by Oliver Hunt.

* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::New):  If the span was decommitted, ask that it be recommitted before returning it.
(WTF::TCMalloc_PageHeap::AllocLarge):  Ditto.
(WTF::TCMalloc_PageHeap::Carve):  When splitting a span, ensure that the decommitted state propogates to the two new spans.
(WTF::TCMalloc_PageHeap::Delete):  When merging a span, ensure that the resulting span is marked as decommitted if any of the
spans being merged were marked as decommitted.
(WTF::TCMalloc_PageHeap::IncrementalScavenge):  Mark as decommitted after releasing the span.
(WTF::TCMalloc_Central_FreeList::FetchFromSpans): Add an assertion to catch a decommitted span being returned to the application
without first being recommitted.
(WTF::TCMalloc_Central_FreeList::Populate): Ditto.
* wtf/TCSystemAlloc.cpp: Stub out TCMalloc_SystemCommit.
* wtf/TCSystemAlloc.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove the sample member of Span when NO_TCMALLOC_SAMPLES is defined.
mrowe@apple.com [Tue, 24 Jun 2008 05:34:21 +0000 (05:34 +0000)]
Remove the sample member of Span when NO_TCMALLOC_SAMPLES is defined.

Reviewed by Sam Weinig.

* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::Delete): Only update Span::sample if NO_TCMALLOC_SAMPLES is not defined.
(WTF::TCMallocStats::do_free):  Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
darin@apple.com [Tue, 24 Jun 2008 05:23:17 +0000 (05:23 +0000)]
JavaScriptCore:

2008-06-23  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        - work toward https://bugs.webkit.org/show_bug.cgi?id=19721

        More preparation toward making functions work on primitive types without
        creating wrapper objects. No speedup this time, but prepares for a future
        speedup without slowing things down.

        SunSpider reports no change.

        - Eliminated the implementsCall, callAsFunction and construct virtual
          functions from JSObject. Instead, the CallData and ConstructData for
          a native function includes a function pointer that the caller can use
          directly. Changed all call sites to use CallData and ConstructData.

        - Changed the "this" argument to native functions to be a JSValue rather
          than a JSObject. This prepares us for passing primitives into these
          functions. The conversion to an object now must be done inside the
          function. Critically, if it's a function that can be called on a DOM
          window object, then we have to be sure to call toThisObject on the
          argument before we use it for anything even if it's already an object.

        - Eliminated the practice of using constructor objects in the global
          object to make objects of the various basic types. Since these
          constructors can't be replaced by script, there's no reason to involve
          a constructor object at all. Added functions to do the construction
          directly.

        - Made some more class members private and protected, including virtual
          function overrides. This can catch code using unnecessarily slow virtual
          function code paths when the type of an object is known statically. If we
          later find a new reason use the members outside the class it's easy to
          make them public again.

        - Moved the declarations of the native implementations for functions out
          of header files. These can have internal linkage and be declared inside
          the source file.

        - Changed PrototypeFunction to take function pointers with the right
          arguments to be put directly into CallData. This eliminates the
          need to have a separate PrototypeReflexiveFunction, and reveals that the
          real purpose of that class included something else specific to eval --
          storage of a cached global object. So renamed PrototypeReflexiveFunction
          to GlobalEvalFunction.

        * API/JSCallbackConstructor.cpp:
        (KJS::constructJSCallback):
        (KJS::JSCallbackConstructor::getConstructData):
        * API/JSCallbackConstructor.h:
        * API/JSCallbackFunction.cpp:
        (KJS::JSCallbackFunction::implementsHasInstance):
        (KJS::JSCallbackFunction::call):
        (KJS::JSCallbackFunction::getCallData):
        * API/JSCallbackFunction.h:
        (KJS::JSCallbackFunction::classInfo):
        * API/JSCallbackObject.h:
        (KJS::JSCallbackObject::classRef):
        (KJS::JSCallbackObject::classInfo):
        * API/JSCallbackObjectFunctions.h:
        (KJS::::getConstructData):
        (KJS::::construct):
        (KJS::::getCallData):
        (KJS::::call):
        * API/JSObjectRef.cpp:
        (JSObjectMakeFunction):
        (JSObjectIsFunction):
        (JSObjectCallAsFunction):
        (JSObjectCallAsConstructor):
        * JavaScriptCore.exp:
        * VM/Machine.cpp:
        (KJS::jsTypeStringForValue):
        (KJS::Machine::privateExecute):
        * kjs/ArrayPrototype.cpp:
        (KJS::arrayProtoFuncToString):
        (KJS::arrayProtoFuncToLocaleString):
        (KJS::arrayProtoFuncJoin):
        (KJS::arrayProtoFuncConcat):
        (KJS::arrayProtoFuncPop):
        (KJS::arrayProtoFuncPush):
        (KJS::arrayProtoFuncReverse):
        (KJS::arrayProtoFuncShift):
        (KJS::arrayProtoFuncSlice):
        (KJS::arrayProtoFuncSort):
        (KJS::arrayProtoFuncSplice):
        (KJS::arrayProtoFuncUnShift):
        (KJS::arrayProtoFuncFilter):
        (KJS::arrayProtoFuncMap):
        (KJS::arrayProtoFuncEvery):
        (KJS::arrayProtoFuncForEach):
        (KJS::arrayProtoFuncSome):
        (KJS::arrayProtoFuncIndexOf):
        (KJS::arrayProtoFuncLastIndexOf):
        (KJS::ArrayConstructor::ArrayConstructor):
        (KJS::constructArrayWithSizeQuirk):
        (KJS::constructWithArrayConstructor):
        (KJS::ArrayConstructor::getConstructData):
        (KJS::callArrayConstructor):
        (KJS::ArrayConstructor::getCallData):
        * kjs/ArrayPrototype.h:
        * kjs/BooleanObject.cpp:
        (KJS::booleanProtoFuncToString):
        (KJS::booleanProtoFuncValueOf):
        (KJS::constructBoolean):
        (KJS::constructWithBooleanConstructor):
        (KJS::BooleanConstructor::getConstructData):
        (KJS::callBooleanConstructor):
        (KJS::BooleanConstructor::getCallData):
        (KJS::constructBooleanFromImmediateBoolean):
        * kjs/BooleanObject.h:
        * kjs/CallData.h:
        (KJS::):
        * kjs/ConstructData.h:
        (KJS::):
        * kjs/FunctionPrototype.cpp:
        (KJS::callFunctionPrototype):
        (KJS::FunctionPrototype::getCallData):
        (KJS::functionProtoFuncToString):
        (KJS::functionProtoFuncApply):
        (KJS::functionProtoFuncCall):
        (KJS::constructWithFunctionConstructor):
        (KJS::FunctionConstructor::getConstructData):
        (KJS::callFunctionConstructor):
        (KJS::FunctionConstructor::getCallData):
        (KJS::constructFunction):
        * kjs/FunctionPrototype.h:
        * kjs/JSArray.cpp:
        (KJS::AVLTreeAbstractorForArrayCompare::compare_key_key):
        (KJS::JSArray::sort):
        (KJS::constructEmptyArray):
        (KJS::constructArray):
        * kjs/JSArray.h:
        (KJS::JSArray::classInfo):
        * kjs/JSFunction.cpp:
        (KJS::JSFunction::call):
        (KJS::globalFuncEval):
        (KJS::globalFuncParseInt):
        (KJS::globalFuncParseFloat):
        (KJS::globalFuncIsNaN):
        (KJS::globalFuncIsFinite):
        (KJS::globalFuncDecodeURI):
        (KJS::globalFuncDecodeURIComponent):
        (KJS::globalFuncEncodeURI):
        (KJS::globalFuncEncodeURIComponent):
        (KJS::globalFuncEscape):
        (KJS::globalFuncUnescape):
        (KJS::globalFuncKJSPrint):
        (KJS::PrototypeFunction::PrototypeFunction):
        (KJS::PrototypeFunction::getCallData):
        (KJS::GlobalEvalFunction::GlobalEvalFunction):
        (KJS::GlobalEvalFunction::mark):
        * kjs/JSFunction.h:
        (KJS::InternalFunction::classInfo):
        (KJS::InternalFunction::functionName):
        (KJS::JSFunction::classInfo):
        (KJS::GlobalEvalFunction::cachedGlobalObject):
        * kjs/JSGlobalObject.cpp:
        (KJS::JSGlobalObject::reset):
        (KJS::JSGlobalObject::mark):
        * kjs/JSGlobalObject.h:
        (KJS::JSGlobalObject::JSGlobalObject):
        (KJS::JSGlobalObject::evalFunction):
        * kjs/JSImmediate.cpp:
        (KJS::JSImmediate::toObject):
        * kjs/JSNotAnObject.cpp:
        * kjs/JSNotAnObject.h:
        * kjs/JSObject.cpp:
        (KJS::JSObject::put):
        (KJS::callDefaultValueFunction):
        (KJS::JSObject::defaultValue):
        (KJS::JSObject::lookupGetter):
        (KJS::JSObject::lookupSetter):
        (KJS::JSObject::hasInstance):
        (KJS::JSObject::fillGetterPropertySlot):
        (KJS::Error::create):
        (KJS::constructEmptyObject):
        * kjs/JSObject.h:
        (KJS::GetterSetter::GetterSetter):
        (KJS::GetterSetter::getter):
        (KJS::GetterSetter::setGetter):
        (KJS::GetterSetter::setter):
        (KJS::GetterSetter::setSetter):
        * kjs/JSValue.cpp:
        (KJS::JSCell::deleteProperty):
        (KJS::call):
        (KJS::construct):
        * kjs/JSValue.h:
        * kjs/MathObject.cpp:
        (KJS::mathProtoFuncAbs):
        (KJS::mathProtoFuncACos):
        (KJS::mathProtoFuncASin):
        (KJS::mathProtoFuncATan):
        (KJS::mathProtoFuncATan2):
        (KJS::mathProtoFuncCeil):
        (KJS::mathProtoFuncCos):
        (KJS::mathProtoFuncExp):
        (KJS::mathProtoFuncFloor):
        (KJS::mathProtoFuncLog):
        (KJS::mathProtoFuncMax):
        (KJS::mathProtoFuncMin):
        (KJS::mathProtoFuncPow):
        (KJS::mathProtoFuncRandom):
        (KJS::mathProtoFuncRound):
        (KJS::mathProtoFuncSin):
        (KJS::mathProtoFuncSqrt):
        (KJS::mathProtoFuncTan):
        * kjs/MathObject.h:
        * kjs/NumberObject.cpp:
        (KJS::numberProtoFuncToString):
        (KJS::numberProtoFuncToLocaleString):
        (KJS::numberProtoFuncValueOf):
        (KJS::numberProtoFuncToFixed):
        (KJS::numberProtoFuncToExponential):
        (KJS::numberProtoFuncToPrecision):
        (KJS::NumberConstructor::NumberConstructor):
        (KJS::constructWithNumberConstructor):
        (KJS::NumberConstructor::getConstructData):
        (KJS::callNumberConstructor):
        (KJS::NumberConstructor::getCallData):
        (KJS::constructNumber):
        (KJS::constructNumberFromImmediateNumber):
        * kjs/NumberObject.h:
        (KJS::NumberObject::classInfo):
        (KJS::NumberConstructor::classInfo):
        * kjs/PropertySlot.cpp:
        (KJS::PropertySlot::functionGetter):
        * kjs/RegExpObject.cpp:
        (KJS::regExpProtoFuncTest):
        (KJS::regExpProtoFuncExec):
        (KJS::regExpProtoFuncCompile):
        (KJS::regExpProtoFuncToString):
        (KJS::callRegExpObject):
        (KJS::RegExpObject::getCallData):
        (KJS::constructRegExp):
        (KJS::constructWithRegExpConstructor):
        (KJS::RegExpConstructor::getConstructData):
        (KJS::callRegExpConstructor):
        (KJS::RegExpConstructor::getCallData):
        * kjs/RegExpObject.h:
        (KJS::RegExpConstructor::classInfo):
        * kjs/Shell.cpp:
        (GlobalObject::GlobalObject):
        (functionPrint):
        (functionDebug):
        (functionGC):
        (functionVersion):
        (functionRun):
        (functionLoad):
        (functionReadline):
        (functionQuit):
        * kjs/date_object.cpp:
        (KJS::gmtoffset):
        (KJS::formatLocaleDate):
        (KJS::fillStructuresUsingDateArgs):
        (KJS::DateInstance::getTime):
        (KJS::DateInstance::getUTCTime):
        (KJS::DateConstructor::DateConstructor):
        (KJS::constructDate):
        (KJS::DateConstructor::getConstructData):
        (KJS::callDate):
        (KJS::DateConstructor::getCallData):
        (KJS::dateParse):
        (KJS::dateNow):
        (KJS::dateUTC):
        (KJS::dateProtoFuncToString):
        (KJS::dateProtoFuncToUTCString):
        (KJS::dateProtoFuncToDateString):
        (KJS::dateProtoFuncToTimeString):
        (KJS::dateProtoFuncToLocaleString):
        (KJS::dateProtoFuncToLocaleDateString):
        (KJS::dateProtoFuncToLocaleTimeString):
        (KJS::dateProtoFuncValueOf):
        (KJS::dateProtoFuncGetTime):
        (KJS::dateProtoFuncGetFullYear):
        (KJS::dateProtoFuncGetUTCFullYear):
        (KJS::dateProtoFuncToGMTString):
        (KJS::dateProtoFuncGetMonth):
        (KJS::dateProtoFuncGetUTCMonth):
        (KJS::dateProtoFuncGetDate):
        (KJS::dateProtoFuncGetUTCDate):
        (KJS::dateProtoFuncGetDay):
        (KJS::dateProtoFuncGetUTCDay):
        (KJS::dateProtoFuncGetHours):
        (KJS::dateProtoFuncGetUTCHours):
        (KJS::dateProtoFuncGetMinutes):
        (KJS::dateProtoFuncGetUTCMinutes):
        (KJS::dateProtoFuncGetSeconds):
        (KJS::dateProtoFuncGetUTCSeconds):
        (KJS::dateProtoFuncGetMilliSeconds):
        (KJS::dateProtoFuncGetUTCMilliseconds):
        (KJS::dateProtoFuncGetTimezoneOffset):
        (KJS::dateProtoFuncSetTime):
        (KJS::setNewValueFromTimeArgs):
        (KJS::setNewValueFromDateArgs):
        (KJS::dateProtoFuncSetMilliSeconds):
        (KJS::dateProtoFuncSetUTCMilliseconds):
        (KJS::dateProtoFuncSetSeconds):
        (KJS::dateProtoFuncSetUTCSeconds):
        (KJS::dateProtoFuncSetMinutes):
        (KJS::dateProtoFuncSetUTCMinutes):
        (KJS::dateProtoFuncSetHours):
        (KJS::dateProtoFuncSetUTCHours):
        (KJS::dateProtoFuncSetDate):
        (KJS::dateProtoFuncSetUTCDate):
        (KJS::dateProtoFuncSetMonth):
        (KJS::dateProtoFuncSetUTCMonth):
        (KJS::dateProtoFuncSetFullYear):
        (KJS::dateProtoFuncSetUTCFullYear):
        (KJS::dateProtoFuncSetYear):
        (KJS::dateProtoFuncGetYear):
        * kjs/date_object.h:
        (KJS::DateInstance::internalNumber):
        (KJS::DateInstance::classInfo):
        * kjs/error_object.cpp:
        (KJS::errorProtoFuncToString):
        (KJS::constructError):
        (KJS::constructWithErrorConstructor):
        (KJS::ErrorConstructor::getConstructData):
        (KJS::callErrorConstructor):
        (KJS::ErrorConstructor::getCallData):
        (KJS::NativeErrorConstructor::construct):
        (KJS::constructWithNativeErrorConstructor):
        (KJS::NativeErrorConstructor::getConstructData):
        (KJS::callNativeErrorConstructor):
        (KJS::NativeErrorConstructor::getCallData):
        * kjs/error_object.h:
        (KJS::NativeErrorConstructor::classInfo):
        * kjs/internal.cpp:
        (KJS::JSNumberCell::toObject):
        (KJS::JSNumberCell::toThisObject):
        (KJS::GetterSetter::mark):
        (KJS::GetterSetter::toPrimitive):
        (KJS::GetterSetter::toBoolean):
        (KJS::GetterSetter::toNumber):
        (KJS::GetterSetter::toString):
        (KJS::GetterSetter::toObject):
        (KJS::InternalFunction::InternalFunction):
        (KJS::InternalFunction::implementsHasInstance):
        * kjs/lookup.h:
        (KJS::HashEntry::):
        * kjs/nodes.cpp:
        (KJS::FuncDeclNode::makeFunction):
        (KJS::FuncExprNode::makeFunction):
        * kjs/object_object.cpp:
        (KJS::objectProtoFuncValueOf):
        (KJS::objectProtoFuncHasOwnProperty):
        (KJS::objectProtoFuncIsPrototypeOf):
        (KJS::objectProtoFuncDefineGetter):
        (KJS::objectProtoFuncDefineSetter):
        (KJS::objectProtoFuncLookupGetter):
        (KJS::objectProtoFuncLookupSetter):
        (KJS::objectProtoFuncPropertyIsEnumerable):
        (KJS::objectProtoFuncToLocaleString):
        (KJS::objectProtoFuncToString):
        (KJS::ObjectConstructor::ObjectConstructor):
        (KJS::constructObject):
        (KJS::constructWithObjectConstructor):
        (KJS::ObjectConstructor::getConstructData):
        (KJS::callObjectConstructor):
        (KJS::ObjectConstructor::getCallData):
        * kjs/object_object.h:
        * kjs/string_object.cpp:
        (KJS::replace):
        (KJS::stringProtoFuncToString):
        (KJS::stringProtoFuncValueOf):
        (KJS::stringProtoFuncCharAt):
        (KJS::stringProtoFuncCharCodeAt):
        (KJS::stringProtoFuncConcat):
        (KJS::stringProtoFuncIndexOf):
        (KJS::stringProtoFuncLastIndexOf):
        (KJS::stringProtoFuncMatch):
        (KJS::stringProtoFuncSearch):
        (KJS::stringProtoFuncReplace):
        (KJS::stringProtoFuncSlice):
        (KJS::stringProtoFuncSplit):
        (KJS::stringProtoFuncSubstr):
        (KJS::stringProtoFuncSubstring):
        (KJS::stringProtoFuncToLowerCase):
        (KJS::stringProtoFuncToUpperCase):
        (KJS::stringProtoFuncToLocaleLowerCase):
        (KJS::stringProtoFuncToLocaleUpperCase):
        (KJS::stringProtoFuncLocaleCompare):
        (KJS::stringProtoFuncBig):
        (KJS::stringProtoFuncSmall):
        (KJS::stringProtoFuncBlink):
        (KJS::stringProtoFuncBold):
        (KJS::stringProtoFuncFixed):
        (KJS::stringProtoFuncItalics):
        (KJS::stringProtoFuncStrike):
        (KJS::stringProtoFuncSub):
        (KJS::stringProtoFuncSup):
        (KJS::stringProtoFuncFontcolor):
        (KJS::stringProtoFuncFontsize):
        (KJS::stringProtoFuncAnchor):
        (KJS::stringProtoFuncLink):
        (KJS::stringFromCharCode):
        (KJS::StringConstructor::StringConstructor):
        (KJS::constructWithStringConstructor):
        (KJS::StringConstructor::getConstructData):
        (KJS::callStringConstructor):
        (KJS::StringConstructor::getCallData):
        * kjs/string_object.h:

JavaScriptGlue:

2008-06-23  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        * JSValueWrapper.cpp:
        (JSValueWrapper::JSObjectCallFunction): Updated to use getCallData and call instead
        of the old callAsFunction.

WebCore:

2008-06-23  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        Update for JavaScript changes.

        - Use CallData and ConstructData instead of the obsolete implementsCall,
          callAsFunction, and construct functions.

        - Updated native function arguments, specifically to allow a JSValue
          rather than a JSObject for the this argument, and to call toThisObject
          as needed when treating it as an object.

        - Made some more class members private and protected, including virtual
          function overrides.

        - Eliminated the use of getCallData in the JavaScript bridging code as
          a way to check if an instance supports invokeDefaultMethod.

        - Eliminated unnecessary polymorphism in the NodeIterator and TreeWalker
          classes. They were using virtual functions simply to share an instance
          of the RefCounted template, which was not helpful.

        * bindings/js/JSAudioConstructor.cpp:
        (WebCore::constructAudio):
        (WebCore::JSAudioConstructor::getConstructData):
        * bindings/js/JSAudioConstructor.h:
        (WebCore::JSAudioConstructor::document):
        (WebCore::JSAudioConstructor::classInfo):
        * bindings/js/JSClipboardCustom.cpp:
        (WebCore::JSClipboard::types):
        * bindings/js/JSCustomSQLStatementCallback.cpp:
        (WebCore::JSCustomSQLStatementCallback::handleEvent):
        * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
        (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
        * bindings/js/JSCustomSQLTransactionCallback.cpp:
        (WebCore::JSCustomSQLTransactionCallback::handleEvent):
        * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
        (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
        * bindings/js/JSCustomVoidCallback.cpp:
        (WebCore::JSCustomVoidCallback::handleEvent):
        * bindings/js/JSCustomXPathNSResolver.cpp:
        (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
        * bindings/js/JSDOMBinding.h:
        (WebCore::DOMObject::DOMObject):
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::windowProtoFuncAToB):
        (WebCore::windowProtoFuncBToA):
        (WebCore::windowProtoFuncOpen):
        (WebCore::windowProtoFuncSetTimeout):
        (WebCore::windowProtoFuncClearTimeout):
        (WebCore::windowProtoFuncSetInterval):
        (WebCore::windowProtoFuncAddEventListener):
        (WebCore::windowProtoFuncRemoveEventListener):
        (WebCore::windowProtoFuncShowModalDialog):
        (WebCore::windowProtoFuncNotImplemented):
        (WebCore::toJSDOMWindow):
        * bindings/js/JSDOMWindowBase.h:
        * bindings/js/JSDOMWindowShell.h:
        (WebCore::JSDOMWindowShell::classInfo):
        * bindings/js/JSEventListener.cpp:
        (WebCore::JSAbstractEventListener::handleEvent):
        (WebCore::JSLazyEventListener::parseCode):
        * bindings/js/JSEventTargetBase.cpp:
        (WebCore::retrieveEventTargetAndCorrespondingNode):
        (WebCore::jsEventTargetAddEventListener):
        (WebCore::jsEventTargetRemoveEventListener):
        (WebCore::jsEventTargetDispatchEvent):
        * bindings/js/JSEventTargetBase.h:
        * bindings/js/JSHTMLAppletElementCustom.cpp:
        (WebCore::JSHTMLAppletElement::customGetOwnPropertySlot):
        (WebCore::JSHTMLAppletElement::customPut):
        (WebCore::JSHTMLAppletElement::getCallData):
        * bindings/js/JSHTMLCollectionCustom.cpp:
        (WebCore::callHTMLCollection):
        (WebCore::JSHTMLCollection::getCallData):
        * bindings/js/JSHTMLDocumentCustom.cpp:
        (WebCore::JSHTMLDocument::open):
        * bindings/js/JSHTMLEmbedElementCustom.cpp:
        (WebCore::JSHTMLEmbedElement::customGetOwnPropertySlot):
        (WebCore::JSHTMLEmbedElement::customPut):
        (WebCore::JSHTMLEmbedElement::getCallData):
        * bindings/js/JSHTMLInputElementBase.cpp:
        (WebCore::jsHTMLInputElementBaseFunctionSetSelectionRange):
        * bindings/js/JSHTMLInputElementBase.h:
        * bindings/js/JSHTMLObjectElementCustom.cpp:
        (WebCore::JSHTMLObjectElement::customGetOwnPropertySlot):
        (WebCore::JSHTMLObjectElement::customPut):
        (WebCore::JSHTMLObjectElement::getCallData):
        * bindings/js/JSHTMLOptionElementConstructor.cpp:
        (WebCore::constructHTMLOptionElement):
        (WebCore::JSHTMLOptionElementConstructor::getConstructData):
        * bindings/js/JSHTMLOptionElementConstructor.h:
        (WebCore::JSHTMLOptionElementConstructor::document):
        (WebCore::JSHTMLOptionElementConstructor::classInfo):
        * bindings/js/JSImageConstructor.cpp:
        (WebCore::constructImage):
        (WebCore::JSImageConstructor::getConstructData):
        * bindings/js/JSImageConstructor.h:
        (WebCore::JSImageConstructor::document):
        (WebCore::JSImageConstructor::classInfo):
        * bindings/js/JSInspectedObjectWrapper.h:
        (WebCore::JSInspectedObjectWrapper::classInfo):
        * bindings/js/JSInspectorCallbackWrapper.cpp:
        (WebCore::JSInspectorCallbackWrapper::prepareIncomingValue):
        * bindings/js/JSJavaScriptCallFrameCustom.cpp:
        (WebCore::JSJavaScriptCallFrame::scopeChain):
        * bindings/js/JSNodeFilterCondition.cpp:
        (WebCore::JSNodeFilterCondition::JSNodeFilterCondition):
        (WebCore::JSNodeFilterCondition::mark):
        (WebCore::JSNodeFilterCondition::acceptNode):
        * bindings/js/JSNodeFilterCondition.h:
        (WebCore::JSNodeFilterCondition::create):
        * bindings/js/JSNodeFilterCustom.cpp:
        (WebCore::toNodeFilter):
        * bindings/js/JSNodeListCustom.cpp:
        (WebCore::callNodeList):
        (WebCore::JSNodeList::getCallData):
        (WebCore::JSNodeList::canGetItemsForName):
        (WebCore::JSNodeList::nameGetter):
        * bindings/js/JSPluginElementFunctions.cpp:
        (WebCore::runtimeObjectGetter):
        (WebCore::runtimeObjectPropertyGetter):
        (WebCore::runtimeObjectCustomGetOwnPropertySlot):
        (WebCore::runtimeObjectCustomPut):
        (WebCore::runtimeObjectGetCallData):
        (WebCore::pluginInstance):
        (WebCore::getRuntimeObject):
        (WebCore::callPlugin):
        * bindings/js/JSPluginElementFunctions.h:
        * bindings/js/JSQuarantinedObjectWrapper.cpp:
        (WebCore::JSQuarantinedObjectWrapper::put):
        (WebCore::JSQuarantinedObjectWrapper::construct):
        (WebCore::JSQuarantinedObjectWrapper::getConstructData):
        (WebCore::JSQuarantinedObjectWrapper::hasInstance):
        (WebCore::JSQuarantinedObjectWrapper::call):
        (WebCore::JSQuarantinedObjectWrapper::getCallData):
        * bindings/js/JSQuarantinedObjectWrapper.h:
        (WebCore::JSQuarantinedObjectWrapper::className):
        * bindings/js/JSRGBColor.cpp:
        * bindings/js/JSXMLHttpRequestConstructor.cpp:
        (WebCore::constructXMLHttpRequest):
        (WebCore::JSXMLHttpRequestConstructor::getConstructData):
        * bindings/js/JSXMLHttpRequestConstructor.h:
        (WebCore::JSXMLHttpRequestConstructor::document):
        (WebCore::JSXMLHttpRequestConstructor::classInfo):
        * bindings/js/JSXSLTProcessorConstructor.cpp:
        (WebCore::constructXSLTProcessor):
        (WebCore::JSXSLTProcessorConstructor::getConstructData):
        * bindings/js/JSXSLTProcessorConstructor.h:
        (WebCore::JSXSLTProcessorConstructor::classInfo):
        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::ScheduledAction):
        (WebCore::ScheduledAction::execute):
        * bindings/js/ScheduledAction.h:
        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject callWebScriptMethod:withArguments:]):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/NP_jsobject.cpp:
        (_NPN_InvokeDefault):
        (_NPN_Invoke):
        * bridge/c/c_instance.cpp:
        (KJS::Bindings::CInstance::supportsInvokeDefaultMethod):
        * bridge/c/c_instance.h:
        * bridge/jni/jni_jsobject.mm:
        (JavaJSObject::call):
        * bridge/objc/objc_instance.h:
        * bridge/objc/objc_instance.mm:
        (ObjcInstance::supportsInvokeDefaultMethod):
        * bridge/objc/objc_runtime.h:
        (KJS::Bindings::ObjcFallbackObjectImp::propertyName):
        (KJS::Bindings::ObjcFallbackObjectImp::classInfo):
        * bridge/objc/objc_runtime.mm:
        (Bindings::webScriptObjectClass):
        (Bindings::webUndefinedClass):
        (ObjcFallbackObjectImp::ObjcFallbackObjectImp):
        (callObjCFallbackObject):
        (ObjcFallbackObjectImp::getCallData):
        * bridge/qt/qt_instance.h:
        * bridge/runtime.cpp:
        (KJS::Bindings::Instance::createRuntimeObject):
        (KJS::Bindings::Instance::getInstance):
        * bridge/runtime.h:
        (KJS::Bindings::Field::~Field):
        (KJS::Bindings::Method::~Method):
        (KJS::Bindings::Class::~Class):
        (KJS::Bindings::Instance::supportsInvokeDefaultMethod):
        * bridge/runtime_method.cpp:
        (KJS::callRuntimeMethod):
        (KJS::RuntimeMethod::getCallData):
        * bridge/runtime_method.h:
        (KJS::RuntimeMethod::methods):
        * bridge/runtime_object.cpp:
        (RuntimeObjectImp::defaultValue):
        (callRuntimeObject):
        (RuntimeObjectImp::getCallData):
        * bridge/runtime_object.h:
        (KJS::RuntimeObjectImp::getInternalInstance):
        (KJS::RuntimeObjectImp::classInfo):
        * dom/NodeIterator.h:
        * dom/Traversal.cpp:
        * dom/Traversal.h:
        * dom/TreeWalker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 24 Jun 2008 03:00:21 +0000 (03:00 +0000)]
2008-06-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=16756

        Move isAllowedToLoadLocalResources into SecurityOrigin.

        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::setURL):
        (WebCore::Document::initSecurityContext):
        * dom/Document.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::canLoad):
        * platform/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::SecurityOrigin):
        (WebCore::SecurityOrigin::isLocal):
        * platform/SecurityOrigin.h:
        (WebCore::SecurityOrigin::protocol):
        (WebCore::SecurityOrigin::host):
        (WebCore::SecurityOrigin::domain):
        (WebCore::SecurityOrigin::port):
        (WebCore::SecurityOrigin::canLoadLocalResources):
        (WebCore::SecurityOrigin::grantLoadLocalResources):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::setRequestHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix Windows build.
mrowe@apple.com [Tue, 24 Jun 2008 00:23:20 +0000 (00:23 +0000)]
Fix Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-23 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Tue, 24 Jun 2008 00:19:25 +0000 (00:19 +0000)]
2008-06-23  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Bug 19716: REGRESSION (SquirrelFish): Reproducible crash after entering a username at mint.com
        <https://bugs.webkit.org/show_bug.cgi?id=19716>

        When unwinding callframes for exceptions, check whether the callframe
        was created by a reentrant native call to JavaScript after tearing off
        the local variables instead of before.

        JavaScriptCore:

        * VM/Machine.cpp:
        (KJS::Machine::unwindCallFrame):

        LayoutTests:

        * fast/js/reentrant-call-unwind-expected.txt: Added.
        * fast/js/reentrant-call-unwind.html: Added.
        * fast/js/resources/reentrant-call-unwind.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix a math error in my last change.
sfalken@apple.com [Tue, 24 Jun 2008 00:00:32 +0000 (00:00 +0000)]
    Fix a math error in my last change.

        Reviewed by Ada Chan.

        * platform/win/FileSystemWin.cpp:
        (WebCore::openTemporaryFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-23 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Mon, 23 Jun 2008 23:48:23 +0000 (23:48 +0000)]
2008-06-23  Kevin McCullough  <kmccullough@apple.com>

        -Build fix.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/6024267> VO unable to read massive emails because AccessibilityObject...
cfleizach@apple.com [Mon, 23 Jun 2008 23:20:50 +0000 (23:20 +0000)]
<rdar://problem/6024267> VO unable to read massive emails because AccessibilityObject::lengthForVisiblePositionRange makes the string

Improves performance of asking for the length/string of text marker ranges

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoGet testapi passing again in a debug build.
mrowe@apple.com [Mon, 23 Jun 2008 21:41:55 +0000 (21:41 +0000)]
Get testapi passing again in a debug build.

Reviewed by Oliver Hunt.

* API/testapi.c:
(main): Update the expected output of calling JSValueMakeString on a function object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Added our own mechanism for generating temporary file names.
sfalken@apple.com [Mon, 23 Jun 2008 20:58:37 +0000 (20:58 +0000)]
    Added our own mechanism for generating temporary file names.

        Reviewed by Ada Chan, Darin Adler.

        * platform/win/FileSystemWin.cpp:
        (WebCore::openTemporaryFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-23 David Kilzer <ddkilzer@apple.com>
ddkilzer@apple.com [Mon, 23 Jun 2008 20:57:21 +0000 (20:57 +0000)]
2008-06-23  David Kilzer  <ddkilzer@apple.com>

        Updated test for Bug 15823: getPropertyValue for border returns null, should compute the shorthand value

        <https://bugs.webkit.org/show_bug.cgi?id=15823>

        Rubber-stamped by Darin.

        * fast/css/getPropertyValue-border-expected.txt: Updated results.
        * fast/css/getPropertyValue-border.html: Test all combinations of
        (mismatched) border values.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-23 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 23 Jun 2008 20:33:17 +0000 (20:33 +0000)]
2008-06-23  Sam Weinig  <sam@webkit.org>

        Remove XMLHttpRequestProgressEvent.cpp from project files.

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-23 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 23 Jun 2008 20:30:42 +0000 (20:30 +0000)]
2008-06-23  Sam Weinig  <sam@webkit.org>

        Reviewed by Dave Hyatt.

        Remove empty file.

        * xml/XMLHttpRequestProgressEvent.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-23 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 23 Jun 2008 20:28:49 +0000 (20:28 +0000)]
2008-06-23  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Tim Hatcher.

        Rename XMLHttpRequest::sameOriginRequest to XMLHttpRequest::makeSameOriginRequest
        and XMLHttpRequest::crossSiteAccessRequest to XMLHttpRequest::makeCrossSiteAccessRequest.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::createRequest):
        (WebCore::XMLHttpRequest::makeSameOriginRequest):
        (WebCore::XMLHttpRequest::makeCrossSiteAccessRequest):
        * xml/XMLHttpRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-23 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 23 Jun 2008 20:07:52 +0000 (20:07 +0000)]
2008-06-23  Sam Weinig  <sam@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Some XMLHttpRequest re-organization to aid further enhancements coming soon.

        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::send): Explicitly call overloaded versions of send,
        instead of always calling though send(DOMString).
        * dom/Document.idl: Adds native converter.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::open):
        (WebCore::XMLHttpRequest::initSend):
        (WebCore::XMLHttpRequest::send):
        (WebCore::XMLHttpRequest::createRequest):
        (WebCore::XMLHttpRequest::sameOriginRequest):
        (WebCore::XMLHttpRequest::crossSiteAccessRequest):
        (WebCore::XMLHttpRequest::abort):
        (WebCore::XMLHttpRequest::clearResponse):
        (WebCore::XMLHttpRequest::clearRequest):
        (WebCore::XMLHttpRequest::genericError):
        (WebCore::XMLHttpRequest::dispatchProgressEvent):
        * xml/XMLHttpRequest.h:
        (WebCore::XMLHttpRequest::setOnReadyStateChangeListener): Inline.
        (WebCore::XMLHttpRequest::onReadyStateChangeListener): Ditto.
        (WebCore::XMLHttpRequest::setOnLoadListener): Ditto.
        (WebCore::XMLHttpRequest::onLoadListener): Ditto.
        (WebCore::XMLHttpRequest::setOnProgressListener): Ditto.
        (WebCore::XMLHttpRequest::onProgressListener): Ditto.
        Makes the request entity body a member variable so that the send method
        can be more easily broken up.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Make profiles of the same name in the Inspector group in the
timothy@apple.com [Mon, 23 Jun 2008 17:33:49 +0000 (17:33 +0000)]
    Make profiles of the same name in the Inspector group in the
        sidebar under a collapsable item that contains all the runs.

        https://bugs.webkit.org/show_bug.cgi?id=19713

        Reviewed by Darin Adler.

        * English.lproj/localizedStrings.js: New strings.
        * page/inspector/Images/profileGroupIcon.png: Added.
        * page/inspector/Images/profileSmallIcon.png: Added.
        * page/inspector/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.reset): Clear _profileGroups.
        Remove the "some-expandable" class from the sidebarTree.
        (WebInspector.ProfilesPanel.prototype.addProfile): Append new profiles
        that have the same name as a previous profile into a group. When a
        group has 2 profiles a ProfileGroupSidebarTreeElement is made and the
        ProfileSidebarTreeElements are appended to the group's element.
        (WebInspector.ProfileSidebarTreeElement.prototype.get mainTitle):
        Return _mainTitle is it is set.
        (WebInspector.ProfileSidebarTreeElement.prototype.set mainTitle):
        Set _mainTitle which is an override title.
        (WebInspector.ProfileGroupSidebarTreeElement): Inherit SidebarTreeElement.
        (WebInspector.ProfileGroupSidebarTreeElement.prototype.onselect):
        Show the last profile in the group when selected.
        * page/inspector/SidebarTreeElement.js:
        (WebInspector.SidebarTreeElement.prototype.get small): Return _small.
        (WebInspector.SidebarTreeElement.prototype.set small): Set _small and
        update the style to match.
        (WebInspector.SidebarTreeElement.prototype.onattach): Set the small
        class if the small property is true.
        * page/inspector/inspector.css: New styles for profiles groups
        and for the small profiles.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 23 Jun 2008 16:24:24 +0000 (16:24 +0000)]
2008-06-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoff.

        Make changedDocuments a HashSet.

        * dom/Document.cpp:
        (WebCore::Document::setDocumentChanged):
        (WebCore::Document::updateDocumentsRendering):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-23 Benjamin C Meyer <ben@meyerhome.net>
hausmann@webkit.org [Mon, 23 Jun 2008 15:19:44 +0000 (15:19 +0000)]
2008-06-23  Benjamin C Meyer  <ben@meyerhome.net>

        Reviewed by Simon.

        Add function to retrieve the standard context menu

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mark Rowe.
ap@webkit.org [Mon, 23 Jun 2008 08:10:50 +0000 (08:10 +0000)]
    Reviewed by Mark Rowe.

        Restore a collectOnMainThreadOnly call that was accidentally removed in r34659. It will not
        be needed when heaps are actually per-thread, but this isn't the case yet, and collecting
        on a different thread causes crashes.

        * bindings/js/JSDOMBinding.h:
        (WebCore::DOMObject::DOMObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-22 Aaron Digulla <digulla@hepe.com>
mrowe@apple.com [Mon, 23 Jun 2008 01:30:47 +0000 (01:30 +0000)]
2008-06-22  Aaron Digulla  <digulla@hepe.com>

        Reviewed by Darin Adler.

        Fix https://bugs.webkit.org/show_bug.cgi?id=18993
        Bug 18993: Update of buttons in editing toolbar demo lags behind

        * demos/editingToolbar/FancyToolbar.js:
        * demos/editingToolbar/index.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-22 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk>
mrowe@apple.com [Mon, 23 Jun 2008 01:25:50 +0000 (01:25 +0000)]
2008-06-22  Jonathon Jongsma  <jonathon.jongsma@collabora.co.uk>

        Reviewed by Darin Adler.

        Fix https://bugs.webkit.org/show_bug.cgi?id=19465
        Bug 19465: Cursor sometimes gets 'stuck' in textareas when trying to navigate with arrow keys

        Test: editing/input/textarea-arrow-navigation.html

        * rendering/RenderText.cpp:
        (WebCore::RenderText::positionForCoordinates): In the case when the next position is to the right
        of the last text box but the text offset is 0, set the affinity to DOWNSTREAM instead of UPSTREAM so
        that the cursor doesn't remain on the previous line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-22 Robert Blaut <webkit@blaut.biz>
mrowe@apple.com [Mon, 23 Jun 2008 01:20:07 +0000 (01:20 +0000)]
2008-06-22  Robert Blaut  <webkit@blaut.biz>

        Reviewed by Darin Adler.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=17421
        Bug 17421: Lack of end tag for SELECT element causes the rest of page to not be rendered

        Test: fast/parser/input-textarea-inside-select-element.html

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::handleError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34734 268f45cc-cd09-0410-ab3c-d52691b4dbfc