lforschler@apple.com [Fri, 18 Mar 2011 23:11:33 +0000 (23:11 +0000)]
Versioning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81527
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 18 Mar 2011 23:07:16 +0000 (23:07 +0000)]
2011-03-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
[GTK] JSC crashes in 32bit Release bots after r80743
https://bugs.webkit.org/show_bug.cgi?id=56180
The crash was caused by referencing GC memory from a GC destructor. This
is not safe because destruction time / order is not guaranteed.
* profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::create):
(JSC::ProfileGenerator::ProfileGenerator):
(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):
* profiler/ProfileGenerator.h:
(JSC::ProfileGenerator::origin): Made ExecState* the first argument,
to match the rest of this class and JSC.
Use a JSGlobalObject* instead of an ExecState* with an indirect reference
to a JSGlobalObject* to track our origin. This is simpler and more
efficient, and it removes the destruction order dependency that was causing
our crash.
* profiler/Profiler.cpp:
(JSC::Profiler::startProfiling): Updated for change to JSGlobalObject*.
(JSC::Profiler::stopProfiling): New function for stopping all profiles
for a given global object. This is more straight-forward than multiplexing
through the old function.
(JSC::dispatchFunctionToProfiles): Updated for change to JSGlobalObject*.
* profiler/Profiler.h: Ditto.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::~JSGlobalObject): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81525
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dcheng@chromium.org [Fri, 18 Mar 2011 23:02:31 +0000 (23:02 +0000)]
2011-03-18 Daniel Cheng <dcheng@chromium.org>
Reviewed by David Levin.
Fix incorrect test onpaste-text-html-types.html
https://bugs.webkit.org/show_bug.cgi?id=56621
The test was checking for the presence of "Text" in event.clipboardData.types,
but per http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2010-February/024956.html,
this should not be the case.
* editing/pasteboard/onpaste-text-html-types.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81522
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simonjam@chromium.org [Fri, 18 Mar 2011 22:41:38 +0000 (22:41 +0000)]
2011-03-18 James Simonsen <simonjam@chromium.org>
[Chromium] Unreviewed, remove stale expectations for r81489.
* platform/chromium-win-vista/fast/text/stroking-decorations-expected.checksum: Removed.
* platform/chromium-win-vista/fast/text/stroking-decorations-expected.png: Removed.
* platform/chromium-win-vista/fast/text/stroking-expected.checksum: Removed.
* platform/chromium-win-vista/fast/text/stroking-expected.png: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81520
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 18 Mar 2011 22:32:25 +0000 (22:32 +0000)]
2011-03-18 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Crash when sending a sync message ends up invalidating the connection
https://bugs.webkit.org/show_bug.cgi?id=56686
<rdar://problem/
9048781>
Guard against a null client.
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::sendSyncMessage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81519
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 18 Mar 2011 22:20:02 +0000 (22:20 +0000)]
2011-03-18 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
REGRESSION(81374, 81384): editing/deleting/
5206311-1.html hits assertion on non-Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=56599
Re-enabled the test on non-Mac platforms.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
2011-03-18 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
REGRESSION(81374, 81384): editing/deleting/
5206311-1.html hits assertion on non-Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=56599
Debug build fix.
* dom/Position.cpp:
(WebCore::Position::parentAnchoredEquivalent): If the original position was a position before a node,
then we can't necessarily instantiate a position inside the node.
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::toNormalizedRange): Even if s and e were not null, container nodes of s and e
could be null. Exit early in those cases as well.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81518
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 18 Mar 2011 22:14:05 +0000 (22:14 +0000)]
2011-03-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add ObjC bindings to the WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=56671
It turns out we generate a bunch of ObjC bindings files that we don't
actually build. I've manually synced the list of ObjC derived source
files to match the existing list. This brings us down to 19 link
errors.
* WebCore.gypi:
* gyp/WebCore.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81517
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 18 Mar 2011 21:55:16 +0000 (21:55 +0000)]
2011-03-18 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Eric Seidel.
[CMAKE] Split JSC related configurations from WebCore/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=56624
No new tests, just splitting jsc related configuration.
* CMakeLists.txt:
* UseJSC.cmake: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81515
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 18 Mar 2011 21:50:03 +0000 (21:50 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=56685
webarchive/test-link-rel-icon.html is now flaky
Rubberstamped by Adam Roben.
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81514
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Fri, 18 Mar 2011 21:44:04 +0000 (21:44 +0000)]
2011-03-18 Stephen White <senorblanco@chromium.org>
Unreviewed; new test baselines.
One last attempt at rebaselining these tests (now that I know how
the --gpu flag works).
* platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-expected.checksum:
* platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-expected.png: Removed.
* platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.checksum:
* platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.png: Removed.
* platform/chromium-gpu-win/compositing/geometry/clipping-foreground-expected.checksum:
* platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.checksum:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81512
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Fri, 18 Mar 2011 21:17:14 +0000 (21:17 +0000)]
2011-03-18 Stephen White <senorblanco@chromium.org>
Unreviewed; more test baselines.
Update the checksums I forgot to update in r81504.
* platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-expected.checksum:
* platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.checksum:
* platform/chromium-gpu-win/compositing/geometry/clipping-foreground-expected.checksum:
* platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.checksum:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81511
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Fri, 18 Mar 2011 21:15:31 +0000 (21:15 +0000)]
2011-03-18 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
[chromium] make devtool concatenation targets conditional based on debug_devtools
https://bugs.webkit.org/show_bug.cgi?id=56667
We don't want to run these targets when debug_devtools=1 because it
will overwrite the devtools.js and devtools.css files copied by
inspector_resources. On Linux, this triggers a warning because
there are two commands that target the same output file when
debug_devtools=1.
I also removed the 'sources' lines since I don't think they do
anything for actions.
* WebKit.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81510
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Fri, 18 Mar 2011 21:03:43 +0000 (21:03 +0000)]
2011-03-16 Stephen White <senorblanco@chromium.org>
Reviewed by Kenneth Russell.
Implement GPU-accelerated shadows.
https://bugs.webkit.org/show_bug.cgi?id=56476
For hard shadows, we simply offset the CTM and draw in the shadow
color. For soft shadows, we use a separable Gaussian convolution,
with a bilinear downsample and Mitchell-Netravali upsample in order to
preserve quality.
* WebCore.gypi:
Add BicubicShader and ConvolutionShader to the build.
* platform/graphics/chromium/GLES2Canvas.cpp:
(WebCore::GLES2Canvas::State::State):
Add shadow-related members to the GLES2Canvas::State
(WebCore::GLES2Canvas::State::shadowActive):
Add a helper function to know if shadows are active.
(WebCore::GLES2Canvas::clearRect):
(WebCore::GLES2Canvas::scissorClear):
Refactor the scissor clearing function out of clearRect().
(WebCore::GLES2Canvas::fillPath):
Add hook for shadow rendering in paths. Bind framebuffer at this level.
(WebCore::GLES2Canvas::fillRect):
Add hook for shadow rendering in rects. Bind framebuffer at this level.
(WebCore::GLES2Canvas::fillRectInternal):
Rename fillRect() -> fillRectInternal(), which does bind its vertex
buffer, but does not bind the framebuffer.
(WebCore::GLES2Canvas::setShadowColor):
(WebCore::GLES2Canvas::setShadowOffset):
(WebCore::GLES2Canvas::setShadowBlur):
(WebCore::GLES2Canvas::setShadowsIgnoreTransforms):
Implement graphicsContext-style setters for shadow parameters.
(WebCore::GLES2Canvas::clipPath):
Call fillPathInternal(), not fillPath().
(WebCore::GLES2Canvas::restore):
(WebCore::GLES2Canvas::drawTexturedRect):
Bind the framebuffer at this level. Do not bind vertices here (will
be done in drawTexturedQuad).
(WebCore::GLES2Canvas::drawTexturedRectTile):
drawQuad() -> drawTexturedQuad().
(WebCore::GLES2Canvas::convolveRect):
Implement one pass of a convolution filter (X or Y).
(WebCore::gauss):
(WebCore::buildKernel):
Some helper functions to build a Gaussian convolution kernel.
(WebCore::GLES2Canvas::drawTexturedQuad):
Rename drawQuad() -> drawTexturedQuad(), to be more clear. Do not
bind the framebuffer at this level (it will be done higher).
(WebCore::GLES2Canvas::drawTexturedQuadMitchell):
Implement Mitchell-Netravali bicubic sampling, using BicubicShader.
(WebCore::GLES2Canvas::fillPathInternal):
Rename fillPath() -> fillPathInternal(), which does use quad vertices,
but does not bind the framebuffer or set the compositing mode.
(WebCore::GLES2Canvas::flipRect):
Implement a helper function to flip a rectangle in Y within the canvas.
(WebCore::GLES2Canvas::clearBorders):
Implement a helper function to clear an n-pixel border around a rect.
(WebCore::GLES2Canvas::beginShadowDraw):
Setup before drawing a primitive's shadow: for hard shadows, just
offset the CTM by the shadow offset. For soft shadows, bind to an
offscreen DrawingBuffer.
(WebCore::GLES2Canvas::endShadowDraw):
Tear-down after drawing a primitive's shadow: for hard shadows, just
restore the CTM. For soft shadows, downsample (if necessary), then
blur in X, blur in Y, upsample if necessary).
* platform/graphics/chromium/GLES2Canvas.h:
* platform/graphics/gpu/BicubicShader.cpp: Added.
(WebCore::BicubicShader::BicubicShader):
(WebCore::BicubicShader::create):
(WebCore::BicubicShader::use):
* platform/graphics/gpu/BicubicShader.h: Added.
Implement a bicubic image filtering shader.
* platform/graphics/gpu/ConvolutionShader.cpp: Added.
(WebCore::ConvolutionShader::ConvolutionShader):
(WebCore::ConvolutionShader::create):
(WebCore::ConvolutionShader::use):
* platform/graphics/gpu/ConvolutionShader.h: Added.
Implement a 1-dimensional convolution shader. In order to minimize
texture samples, this shader is parameterized at compile time by the
width of the convolution kernel.
* platform/graphics/gpu/DrawingBuffer.h:
(WebCore::DrawingBuffer::colorBuffer):
Add an accessor to retrieve a DrawingBuffer's texture ID.
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::create):
(WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
(WebCore::SharedGraphicsContext3D::useBicubicProgram):
(WebCore::SharedGraphicsContext3D::useConvolutionProgram):
Create BicubicShader and cMaxKernelWidth ConvolutionShader's (one for
each possible kernel width).
(WebCore::SharedGraphicsContext3D::getOffscreenBuffer):
Implement a simple cache of offscreen DrawingBuffers, integer-indexed.
This is done to minimize the VRAM usage: only 2 buffers are used for
all canvases.
* platform/graphics/gpu/SharedGraphicsContext3D.h:
Add bicubic and convolution shader members, and useXXX() functions.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setPlatformShadow):
Hook into GraphicsContextSkia's platform shadow setters to set
parameters on GLES2Canvas.
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::canAccelerate):
Remove shadows (loopers) from the list of things we can't accelerate.
2011-03-16 Stephen White <senorblanco@chromium.org>
Reviewed by Kenneth Russell.
Canvas2D GPU acceleration should support shadows
https://bugs.webkit.org/show_bug.cgi?id=56476
* fast/canvas/script-tests/canvas-transforms-fillRect-shadow.js:
(shouldBeAround):
Widen the threshold for this test, which doesn't seem to allow for
a true Gaussian blur implementation.
* platform/chromium/test_expectations.txt:
Update some tests which are now passing on GPU, and some which time out
due to Mesa slowness.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81509
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simonjam@chromium.org [Fri, 18 Mar 2011 20:59:20 +0000 (20:59 +0000)]
2011-03-18 James Simonsen <simonjam@chromium.org>
[Chromium] Unreviewed, re-enable some stable tests and add a flaky one.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81508
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Fri, 18 Mar 2011 20:57:11 +0000 (20:57 +0000)]
2011-03-18 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Benjamin Poulain.
[Qt][WK2] Need a way to debug the web process after the UI process dies
https://bugs.webkit.org/show_bug.cgi?id=56116
Allow the web process to outlive it's parent process
in debug builds if the QT_WEBKIT_KEEP_ALIVE_WEB_PROCESS
environment variable is set.
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::QtWebProcess::setupChildProcess): Used getenv
since the prctl call is already in a Linux-only block
and the implementation in this file is a candidate
for sharing across ports in the future.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81507
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Fri, 18 Mar 2011 20:18:55 +0000 (20:18 +0000)]
2011-03-18 Stephen White <senorblanco@chromium.org>
Unreviewed; new test baselines.
New GPU baselines for shadow quality improved by http://trac.webkit.org/changeset/81489.
* platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-expected.png:
* platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.png:
* platform/chromium-gpu-win/compositing/geometry/clipping-foreground-expected.png:
* platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81504
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Fri, 18 Mar 2011 20:04:34 +0000 (20:04 +0000)]
2011-03-18 Andreas Kling <kling@webkit.org>
Reviewed by Darin Adler.
Remove unused method FontFallbackList::fontDataForCharacters()
https://bugs.webkit.org/show_bug.cgi?id=56657
* platform/graphics/Font.h:
* platform/graphics/FontFallbackList.cpp:
* platform/graphics/FontFallbackList.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81503
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Fri, 18 Mar 2011 20:03:10 +0000 (20:03 +0000)]
2011-03-18 Andreas Kling <kling@webkit.org>
Reverting accidental changes in r81498.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81501
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Mar 2011 19:58:36 +0000 (19:58 +0000)]
Windows build fix
* WebKitTestRunner/config.h: Add a missing #endif.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81500
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 18 Mar 2011 19:49:09 +0000 (19:49 +0000)]
2011-03-18 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: rename console agent events.
https://bugs.webkit.org/show_bug.cgi?id=56646
addConsoleMessage -> consoleMessage
updateConsoleMessageExpiredCount -> consoleMessageExpiredCountUpdate
updateConsoleMessageRepeatCount -> consoleMessageRepeatCountUpdate
WebCore:
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::addToFrontend):
(WebCore::ConsoleMessage::updateRepeatCountInConsole):
* inspector/Inspector.json:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessage):
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessageExpiredCountUpdate):
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessageRepeatCountUpdate):
LayoutTests:
* inspector/protocol/console-agent-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81499
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Fri, 18 Mar 2011 19:46:34 +0000 (19:46 +0000)]
2011-03-18 Andreas Kling <kling@webkit.org>
Unbreak Qt build after r81494.
* WebKitTestRunner/qt/TestInvocationQt.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81498
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Fri, 18 Mar 2011 19:38:25 +0000 (19:38 +0000)]
2011-03-18 Stephen White <senorblanco@chromium.org>
Unreviewed; new test baselines.
New baselines for shadow quality improved by http://trac.webkit.org/changeset/81489.
* platform/chromium-linux/compositing/geometry: Added.
* platform/chromium-linux/compositing/geometry/clipping-foreground-expected.checksum: Added.
* platform/chromium-linux/compositing/geometry/clipping-foreground-expected.png: Added.
* platform/chromium-linux/compositing/iframes: Added.
* platform/chromium-linux/compositing/iframes/composited-iframe-alignment-expected.checksum: Added.
* platform/chromium-linux/compositing/iframes/composited-iframe-alignment-expected.png: Added.
* platform/chromium-linux/fast/blockflow/english-lr-text-expected.checksum:
* platform/chromium-linux/fast/blockflow/english-lr-text-expected.png:
* platform/chromium-linux/fast/borders/border-radius-split-inline-expected.checksum:
* platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
* platform/chromium-linux/fast/box-shadow/basic-shadows-expected.checksum:
* platform/chromium-linux/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-linux/fast/box-shadow/border-radius-big-expected.checksum:
* platform/chromium-linux/fast/box-shadow/border-radius-big-expected.png:
* platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.checksum:
* platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.checksum:
* platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
* platform/chromium-linux/fast/box-shadow/inset-expected.checksum:
* platform/chromium-linux/fast/box-shadow/inset-expected.png:
* platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.checksum:
* platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.png:
* platform/chromium-linux/fast/box-shadow/spread-expected.checksum:
* platform/chromium-linux/fast/box-shadow/spread-expected.png:
* platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.checksum:
* platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.png:
* platform/chromium-linux/fast/canvas/shadow-offset-4-expected.checksum:
* platform/chromium-linux/fast/canvas/shadow-offset-4-expected.png:
* platform/chromium-linux/fast/canvas/shadow-offset-5-expected.checksum:
* platform/chromium-linux/fast/canvas/shadow-offset-5-expected.png:
* platform/chromium-linux/fast/canvas/shadow-offset-6-expected.checksum:
* platform/chromium-linux/fast/canvas/shadow-offset-6-expected.png:
* platform/chromium-linux/fast/canvas/shadow-offset-7-expected.checksum:
* platform/chromium-linux/fast/canvas/shadow-offset-7-expected.png:
* platform/chromium-linux/fast/multicol/shadow-breaking-expected.checksum:
* platform/chromium-linux/fast/multicol/shadow-breaking-expected.png:
* platform/chromium-linux/fast/repaint/box-shadow-h-expected.checksum:
* platform/chromium-linux/fast/repaint/box-shadow-h-expected.png:
* platform/chromium-linux/fast/repaint/box-shadow-v-expected.checksum:
* platform/chromium-linux/fast/repaint/box-shadow-v-expected.png:
* platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.checksum:
* platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.png:
* platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.checksum:
* platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.png:
* platform/chromium-linux/fast/repaint/shadow-multiple-horizontal-expected.checksum:
* platform/chromium-linux/fast/repaint/shadow-multiple-horizontal-expected.png:
* platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum:
* platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
* platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.checksum:
* platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.png:
* platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.checksum:
* platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-linux/fast/repaint/text-shadow-expected.checksum:
* platform/chromium-linux/fast/repaint/text-shadow-expected.png:
* platform/chromium-linux/fast/repaint/text-shadow-horizontal-expected.checksum:
* platform/chromium-linux/fast/repaint/text-shadow-horizontal-expected.png:
* platform/chromium-linux/fast/text/shadow-no-blur-expected.checksum:
* platform/chromium-linux/fast/text/shadow-no-blur-expected.png:
* platform/chromium-linux/fast/text/shadow-translucent-fill-expected.checksum:
* platform/chromium-linux/fast/text/shadow-translucent-fill-expected.png:
* platform/chromium-linux/fast/text/stroking-decorations-expected.checksum:
* platform/chromium-linux/fast/text/stroking-decorations-expected.png:
* platform/chromium-linux/fast/text/stroking-expected.checksum:
* platform/chromium-linux/fast/text/stroking-expected.png:
* platform/chromium-linux/fast/transforms/shadows-expected.checksum:
* platform/chromium-linux/fast/transforms/shadows-expected.png:
* platform/chromium-linux/svg/css/composite-shadow-example-expected.checksum:
* platform/chromium-linux/svg/css/composite-shadow-example-expected.png:
* platform/chromium-linux/svg/css/composite-shadow-text-expected.checksum:
* platform/chromium-linux/svg/css/composite-shadow-text-expected.png:
* platform/chromium-linux/svg/css/composite-shadow-with-opacity-expected.checksum:
* platform/chromium-linux/svg/css/composite-shadow-with-opacity-expected.png:
* platform/chromium-linux/svg/css/group-with-shadow-expected.checksum:
* platform/chromium-linux/svg/css/group-with-shadow-expected.png:
* platform/chromium-linux/svg/css/shadow-changes-expected.checksum:
* platform/chromium-linux/svg/css/shadow-changes-expected.png:
* platform/chromium-linux/svg/css/stars-with-shadow-expected.checksum:
* platform/chromium-linux/svg/css/stars-with-shadow-expected.png:
* platform/chromium-linux/svg/css/text-gradient-shadow-expected.checksum:
* platform/chromium-linux/svg/css/text-gradient-shadow-expected.png:
* platform/chromium-linux/svg/css/text-shadow-multiple-expected.checksum:
* platform/chromium-linux/svg/css/text-shadow-multiple-expected.png:
* platform/chromium-linux/transitions/svg-text-shadow-transition-expected.checksum:
* platform/chromium-linux/transitions/svg-text-shadow-transition-expected.png:
* platform/chromium-win/compositing/geometry: Added.
* platform/chromium-win/compositing/geometry/clipping-foreground-expected.checksum: Added.
* platform/chromium-win/compositing/geometry/clipping-foreground-expected.png: Added.
* platform/chromium-win/compositing/geometry/clipping-foreground-expected.txt: Added.
* platform/chromium-win/compositing/iframes: Added.
* platform/chromium-win/compositing/iframes/composited-iframe-alignment-expected.checksum: Added.
* platform/chromium-win/compositing/iframes/composited-iframe-alignment-expected.png: Added.
* platform/chromium-win/compositing/iframes/composited-iframe-alignment-expected.txt: Added.
* platform/chromium-win/fast/blockflow/english-lr-text-expected.checksum:
* platform/chromium-win/fast/blockflow/english-lr-text-expected.png:
* platform/chromium-win/fast/borders/border-radius-split-inline-expected.checksum:
* platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
* platform/chromium-win/fast/box-shadow/basic-shadows-expected.checksum:
* platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-win/fast/box-shadow/border-radius-big-expected.checksum:
* platform/chromium-win/fast/box-shadow/border-radius-big-expected.png:
* platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.checksum:
* platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png:
* platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.checksum:
* platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.checksum:
* platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png:
* platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.checksum:
* platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
* platform/chromium-win/fast/box-shadow/inset-expected.checksum:
* platform/chromium-win/fast/box-shadow/inset-expected.png:
* platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.checksum:
* platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
* platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.checksum:
* platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.png:
* platform/chromium-win/fast/box-shadow/spread-expected.checksum:
* platform/chromium-win/fast/box-shadow/spread-expected.png:
* platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.checksum:
* platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.png:
* platform/chromium-win/fast/canvas/shadow-offset-4-expected.checksum:
* platform/chromium-win/fast/canvas/shadow-offset-4-expected.png:
* platform/chromium-win/fast/canvas/shadow-offset-5-expected.checksum:
* platform/chromium-win/fast/canvas/shadow-offset-5-expected.png:
* platform/chromium-win/fast/canvas/shadow-offset-6-expected.checksum:
* platform/chromium-win/fast/canvas/shadow-offset-6-expected.png:
* platform/chromium-win/fast/canvas/shadow-offset-7-expected.checksum:
* platform/chromium-win/fast/canvas/shadow-offset-7-expected.png:
* platform/chromium-win/fast/multicol/shadow-breaking-expected.checksum:
* platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
* platform/chromium-win/fast/repaint/box-shadow-h-expected.checksum:
* platform/chromium-win/fast/repaint/box-shadow-h-expected.png:
* platform/chromium-win/fast/repaint/box-shadow-v-expected.checksum:
* platform/chromium-win/fast/repaint/box-shadow-v-expected.png:
* platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.checksum:
* platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.png:
* platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.checksum:
* platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.checksum:
* platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum:
* platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.checksum:
* platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.checksum:
* platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-win/fast/repaint/transform-replaced-shadows-expected.checksum:
* platform/chromium-win/fast/repaint/transform-replaced-shadows-expected.png:
* platform/chromium-win/fast/text/shadow-translucent-fill-expected.checksum:
* platform/chromium-win/fast/text/shadow-translucent-fill-expected.png:
* platform/chromium-win/fast/text/stroking-decorations-expected.checksum:
* platform/chromium-win/fast/text/stroking-decorations-expected.png:
* platform/chromium-win/fast/text/stroking-expected.checksum:
* platform/chromium-win/fast/text/stroking-expected.png:
* platform/chromium-win/fast/transforms/shadows-expected.checksum:
* platform/chromium-win/fast/transforms/shadows-expected.png:
* platform/chromium-win/svg/css/arrow-with-shadow-expected.checksum:
* platform/chromium-win/svg/css/arrow-with-shadow-expected.png:
* platform/chromium-win/svg/css/composite-shadow-example-expected.checksum:
* platform/chromium-win/svg/css/composite-shadow-example-expected.png:
* platform/chromium-win/svg/css/composite-shadow-text-expected.checksum:
* platform/chromium-win/svg/css/composite-shadow-text-expected.png:
* platform/chromium-win/svg/css/composite-shadow-with-opacity-expected.checksum:
* platform/chromium-win/svg/css/composite-shadow-with-opacity-expected.png:
* platform/chromium-win/svg/css/group-with-shadow-expected.checksum:
* platform/chromium-win/svg/css/group-with-shadow-expected.png:
* platform/chromium-win/svg/css/shadow-changes-expected.checksum:
* platform/chromium-win/svg/css/shadow-changes-expected.png:
* platform/chromium-win/svg/css/shadow-with-large-radius-expected.checksum:
* platform/chromium-win/svg/css/shadow-with-large-radius-expected.png:
* platform/chromium-win/svg/css/shadow-with-negative-offset-expected.checksum:
* platform/chromium-win/svg/css/shadow-with-negative-offset-expected.png:
* platform/chromium-win/svg/css/stars-with-shadow-expected.checksum:
* platform/chromium-win/svg/css/stars-with-shadow-expected.png:
* platform/chromium-win/svg/css/text-gradient-shadow-expected.checksum:
* platform/chromium-win/svg/css/text-gradient-shadow-expected.png:
* platform/chromium-win/svg/css/text-shadow-multiple-expected.checksum:
* platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
* platform/chromium-win/transitions/svg-text-shadow-transition-expected.checksum:
* platform/chromium-win/transitions/svg-text-shadow-transition-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81497
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 18 Mar 2011 19:36:47 +0000 (19:36 +0000)]
Fix windows build. This was really Adam Roben's fault. I swear!
* WebKitTestRunner/config.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81496
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 18 Mar 2011 19:28:22 +0000 (19:28 +0000)]
2011-03-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r81487.
http://trac.webkit.org/changeset/81487
https://bugs.webkit.org/show_bug.cgi?id=56662
"Breaks inspector/styles/styles-add-blank-property.html"
(Requested by apavlov on #webkit).
* inspector/styles/get-set-stylesheet-text-expected.txt: Removed.
* inspector/styles/get-set-stylesheet-text.html: Removed.
* inspector/styles/resources/get-set-stylesheet-text.css: Removed.
* inspector/styles/styles-new-API.html:
2011-03-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r81487.
http://trac.webkit.org/changeset/81487
https://bugs.webkit.org/show_bug.cgi?id=56662
"Breaks inspector/styles/styles-add-blank-property.html"
(Requested by apavlov on #webkit).
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getAllStyles):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
* inspector/InspectorStyleSheet.h:
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
(WebInspector.CSSStyleModel.prototype._styleSheetChanged):
(WebInspector.CSSStyleModel.prototype._onRevert):
(WebInspector.CSSStyleSheet):
(WebInspector.CSSStyleSheet.prototype.setText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81495
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 18 Mar 2011 19:24:05 +0000 (19:24 +0000)]
2011-03-18 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
Pixel tests don't work in WebKitTestRunner on Windows
https://bugs.webkit.org/show_bug.cgi?id=56630
Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
built-in snapshotting instead of using the window server on the Mac.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::InjectedBundle):
(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::beginTesting):
(WTR::InjectedBundle::done):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::setPixelResult):
(WTR::InjectedBundle::shouldDumpPixels):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump):
Take the snapshot in the bundle and send it to the UIProcess for dumping.
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::dump):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
* WebKitTestRunner/TestInvocation.h:
* WebKitTestRunner/cg: Added.
* WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
(WTR::createCGContextFromImage):
(WTR::computeMD5HashStringForContext):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
* WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
* WebKitTestRunner/win/TestInvocationWin.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
Keep stub for Cairo build.
* WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
Add CG configuration.
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/win/WebKitTestRunner.vcproj:
Add new files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81494
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 18 Mar 2011 19:15:28 +0000 (19:15 +0000)]
2011-03-18 Darin Adler <darin@apple.com>
Reviewed by Anders Carlsson.
Command-period does not stop load when page has focus in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=56601
* UIProcess/API/mac/WKView.mm:
(-[WKView doCommandBySelector:]): If called outside interpretKeyEvents,
call through to super.
(-[WKView insertText:]): Assert that we are inside interpretKeyEvents.
(-[WKView unmarkText]): Ditto.
(-[WKView setMarkedText:selectedRange:]): Ditto.
(-[WKView _interceptKeyEvent:]): Set a flag to indicate we are inside
interpretKeyEvents for use by the above.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81493
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Mar 2011 19:10:43 +0000 (19:10 +0000)]
Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
Rubber-stamped by Simon Fraser.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
(.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
overflow-y:overlay so that the scrollbar doesn't overlay the content.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81492
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Fri, 18 Mar 2011 19:03:20 +0000 (19:03 +0000)]
2011-03-18 Stephen White <senorblanco@chromium.org>
Unreviewed; test expectations update.
[chromium] Add some test expectations missing from r81489.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81491
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Mar 2011 19:00:20 +0000 (19:00 +0000)]
Don't ellipsize long or indented function names in Leaks Viewer
Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
scrollbar
Reviewed by Simon Fraser.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
(.data-grid .data-container):
(.data-grid td > div, .data-grid th > div):
Allow the contents to extend to the right.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81490
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 18 Mar 2011 18:14:14 +0000 (18:14 +0000)]
2011-03-18 Justin Novosad <junov@chromium.org>
Reviewed by Kenneth Russell.
[Chromium] Canvas shadow is not working with drawImage
https://bugs.webkit.org/show_bug.cgi?id=55506
Patch also fixes shadow blur quality and color.
Affects Chromium win/linux. Also fixes the following bugs:
https://bugs.webkit.org/show_bug.cgi?id=50112
https://bugs.webkit.org/show_bug.cgi?id=51989
https://bugs.webkit.org/show_bug.cgi?id=55410
No tests were added, impact is already covered by multiple layout tests.
* platform/chromium/test_expectations.txt:
2011-03-18 Justin Novosad <junov@chromium.org>
Reviewed by Kenneth Russell.
[Chromium] Canvas shadow is not working with drawImage
https://bugs.webkit.org/show_bug.cgi?id=55506
Patch also fixes shadow blur quality and color.
Affects Chromium win/linux. Also fixes the following bugs:
https://bugs.webkit.org/show_bug.cgi?id=50112
https://bugs.webkit.org/show_bug.cgi?id=51989
https://bugs.webkit.org/show_bug.cgi?id=55410
No tests were added, impact is already covered by multiple layout tests.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setPlatformShadow):
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::paintSkBitmap):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81489
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Fri, 18 Mar 2011 18:11:19 +0000 (18:11 +0000)]
Web Inspector: inspector/elements/mutate-unknown-node.html is flakey.
https://bugs.webkit.org/show_bug.cgi?id=56457
Unreviewed, disable the test and remove it from the Qt Skipped list because this test is
also being flakey on Windows.
* inspector/elements/mutate-unknown-node.html: Removed.
* inspector/elements/mutate-unknown-node.html-disabled: Copied from inspector/elements/mutate-unknown-node.html.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81488
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Fri, 18 Mar 2011 17:55:49 +0000 (17:55 +0000)]
2011-03-15 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Fix handling of the CSSAgent.setStyleSheetText() results in CSSStyleModel.js
https://bugs.webkit.org/show_bug.cgi?id=56310
Instead of stylesheet ids, CSSAgent.getAllStyleSheets() now returns metainfo objects containing
"styleSheetId", "sourceURL", "disabled", and "title" fields. The latter three are not returned
by CSSAgent.getStyleSheet() anymore.
Test: inspector/styles/get-set-stylesheet-text.html
WebCore:
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getAllStyleSheets):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo):
* inspector/InspectorStyleSheet.h:
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
(WebInspector.CSSStyleModel.prototype._styleSheetChanged):
(WebInspector.CSSStyleModel.prototype._onRevert):
(WebInspector.CSSStyleSheet):
(WebInspector.CSSStyleSheet.prototype.setText):
LayoutTests:
* inspector/styles/get-set-stylesheet-text-expected.txt: Added.
* inspector/styles/get-set-stylesheet-text.html: Added.
* inspector/styles/resources/get-set-stylesheet-text.css: Added.
(body):
(/* comment before selector */body.main1/* comment after selector */):
(body.main2):
* inspector/styles/styles-new-API.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81487
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Fri, 18 Mar 2011 17:25:42 +0000 (17:25 +0000)]
Source/WebCore:
2011-03-18 David Keijser <keijser@gmail.com> and Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] On-demand event-listeners for DOM event signals
https://bugs.webkit.org/show_bug.cgi?id=49649
Add explicit EventTarget API to add/remove event listeners instead
of using GSignal, which due to internal limitations in glib makes
us preemptively add listeners for all event types.
* bindings/gobject/GObjectEventListener.cpp: add new
addEventListener/removeEventListener methods, and small
refactoring to store an EventTarget internally instead of a DOM
node, which is more generic and can be reused in more cases.
* bindings/gobject/GObjectEventListener.h: ditto.
* bindings/gobject/WebKitDOMEventTarget.cpp:
(webkit_dom_event_target_add_event_listener): new iface method to
add an event listener.
(webkit_dom_event_target_remove_event_listener): new iface method
to remove an event listener.
* bindings/gobject/WebKitDOMEventTarget.h: add new iface methods.
* bindings/scripts/CodeGeneratorGObject.pm: change code generation
accordingly.
Source/WebKit/gtk:
2011-03-18 David Keijser <keijser@gmail.com> and Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] On-demand event-listeners for DOM event signals
https://bugs.webkit.org/show_bug.cgi?id=49649
* tests/testdomdomwindow.c: update unit tests for new APIs.
(load_event_callback): ditto.
(test_dom_domview_signals): ditto.
(load_status_callback): ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81486
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 18 Mar 2011 17:07:22 +0000 (17:07 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=56425
More groundwork for WebKit2 IconDatabase
Reviewed by Sam Weinig.
../WebCore:
-Update the synchronous method names to be prefixed with "synchronous."
-Call asynchronous versions of the appropriate methods if the IconDatabase supports them.
Update icon database calls to be prefixed with "synchronous":
* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
* loader/icon/IconDatabaseBase.h:
(WebCore::IconDatabaseBase::synchronousIconDataKnownForIconURL):
(WebCore::IconDatabaseBase::synchronousLoadDecisionForIconURL):
(WebCore::IconDatabaseBase::synchronousIconForPageURL):
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::synchronousIconForPageURL):
(WebCore::IconDatabase::readIconForPageURLFromDisk):
(WebCore::IconDatabase::synchronousIconURLForPageURL):
(WebCore::IconDatabase::synchronousLoadDecisionForIconURL):
(WebCore::IconDatabase::synchronousIconDataKnownForIconURL):
* loader/icon/IconDatabase.h:
* loader/icon/IconDatabaseBase.cpp:
(WebCore::IconDatabaseBase::synchronousIconURLForPageURL):
Add nascent support for an asynchronous icon database mode:
* loader/icon/IconDatabaseBase.h:
(WebCore::EnumCallback::create):
(WebCore::EnumCallback::~EnumCallback):
(WebCore::EnumCallback::performCallback):
(WebCore::EnumCallback::invalidate):
(WebCore::EnumCallback::EnumCallback):
(WebCore::ObjectCallback::create):
(WebCore::ObjectCallback::~ObjectCallback):
(WebCore::ObjectCallback::performCallback):
(WebCore::ObjectCallback::invalidate):
(WebCore::ObjectCallback::ObjectCallback):
(WebCore::IconDatabaseBase::supportsAsynchronousMode):
(WebCore::IconDatabaseBase::loadDecisionForIconURL):
(WebCore::IconDatabaseBase::iconDataForIconURL):
Add interfaces to use the asynchronous versions of certain IconDatabase calls:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::iconLoadDecisionAvailable):
(WebCore::iconLoadDecisionCallback):
(WebCore::DocumentLoader::getIconLoadDecisionForIconURL):
(WebCore::DocumentLoader::continueIconLoadWithDecision):
(WebCore::iconDataCallback):
(WebCore::DocumentLoader::getIconDataForIconURL):
* loader/DocumentLoader.h:
Break "startIconLoader" into two pieces so it can be used from both the synchronous and asynchronous
icon database modes:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::iconLoadDecisionReceived):
(WebCore::FrameLoader::startIconLoader):
(WebCore::FrameLoader::continueIconLoadWithDecision):
* loader/FrameLoader.h:
* WebCore.exp.in:
../WebKit/efl:
Update already-used function names:
* ewk/ewk_history.cpp:
(ewk_history_item_icon_surface_get):
(ewk_history_item_icon_object_add):
* ewk/ewk_settings.cpp:
(ewk_settings_icon_database_icon_surface_get):
(ewk_settings_icon_database_icon_object_add):
../WebKit/gtk:
Update already-used function names:
* webkit/webkiticondatabase.cpp:
(webkit_icon_database_get_icon_uri):
(webkit_icon_database_get_icon_pixbuf):
* webkit/webkitwebview.cpp:
(webkit_web_view_get_icon_uri):
../WebKit/mac:
Update already-used function names:
* Misc/WebIconDatabase.mm:
(-[WebIconDatabase iconForURL:withSize:cache:]):
(-[WebIconDatabase iconURLForURL:]):
* WebView/WebView.mm:
(-[WebView _dispatchDidReceiveIconFromWebFrame:]):
../WebKit/qt:
Update already-used function names:
* Api/qwebhistory.cpp:
(QWebHistoryItem::icon):
* Api/qwebsettings.cpp:
(QWebSettings::iconForUrl):
../WebKit/win:
Update already-used function names:
* WebIconDatabase.cpp:
(WebIconDatabase::iconForURL):
(WebIconDatabase::iconURLForURL):
(WebIconDatabase::hasIconForURL):
../WebKit2:
-Update the synchronous method names to be prefixed with "synchronous."
-Add empty implementations for the asynchronous accessors.
* WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:
(WebKit::WebIconDatabaseProxy::setEnabled):
(WebKit::WebIconDatabaseProxy::synchronousIconForPageURL):
(WebKit::WebIconDatabaseProxy::synchronousIconURLForPageURL):
(WebKit::WebIconDatabaseProxy::synchronousIconDataKnownForIconURL):
(WebKit::WebIconDatabaseProxy::synchronousLoadDecisionForIconURL):
(WebKit::WebIconDatabaseProxy::supportsAsynchronousMode):
(WebKit::WebIconDatabaseProxy::loadDecisionForIconURL):
(WebKit::WebIconDatabaseProxy::iconDataForIconURL):
* WebProcess/IconDatabase/WebIconDatabaseProxy.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81484
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 18 Mar 2011 16:56:37 +0000 (16:56 +0000)]
2011-03-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
1 Structure leaked beneath JSGlobalData::storeVPtrs()
https://bugs.webkit.org/show_bug.cgi?id=56595
* runtime/Executable.cpp:
(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::FunctionExecutable::FunctionExecutable):
* runtime/Executable.h:
(JSC::ExecutableBase::ExecutableBase):
(JSC::NativeExecutable::NativeExecutable):
(JSC::VPtrHackExecutable::VPtrHackExecutable):
(JSC::ScriptExecutable::ScriptExecutable): Use a raw pointer instead of
PassRefPtr, like JSString does, since JSGlobalData owns the singleton
exectuable structure.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81483
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Mar 2011 16:50:18 +0000 (16:50 +0000)]
Fix some leaks in DRT seen on the leaks bot
Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
setWillSendRequestClearHeaderCallback in DRT are leaky
Reviewed by Alexey Proskuryakov.
* DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
* DumpRenderTree/LayoutTestController.cpp:
(addURLToRedirectCallback):
(setWillSendRequestClearHeaderCallback):
Use OwnArrayPtr to cause the strings to be deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81482
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Mar 2011 16:49:37 +0000 (16:49 +0000)]
Fix a NSURLCredential leak seen on the leaks bot
Fixes <http://webkit.org/b/56637> -[SynchronousLoader
connection:didReceiveAuthenticationChallenge:] is leaky
Reviewed by John Sullivan.
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
cause the NSURLCredential to be released.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81481
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 18 Mar 2011 16:48:09 +0000 (16:48 +0000)]
2011-03-18 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: add missing brace to the generated Inspector.idl.
* inspector/generate-inspector-idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81480
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 18 Mar 2011 16:42:55 +0000 (16:42 +0000)]
2011-03-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: migrate from Inspector.idl to InspectorAPI.json for protocol schema definition meta bug.
https://bugs.webkit.org/show_bug.cgi?id=56294
* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* inspector/Inspector.idl: Removed.
* inspector/Inspector.json: Added.
* inspector/generate-inspector-idl: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81479
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Fri, 18 Mar 2011 16:40:20 +0000 (16:40 +0000)]
2011-03-18 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
Fixed compilation after r80925.
* GNUmakefile.am:
* UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp: Added.
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::finishedEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::finishedExitFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::enterAcceleratedCompositingMode):
(WebKit::WebFullScreenManagerProxy::exitAcceleratedCompositingMode):
(WebKit::WebFullScreenManagerProxy::getFullScreenRect):
* WebProcess/FullScreen/gtk/WebFullScreenManagerGtk.cpp: Added.
(WebKit::WebFullScreenManagerGtk::WebFullScreenManagerGtk):
(WebKit::WebFullScreenManager::create):
(WebKit::WebFullScreenManagerGtk::setRootFullScreenLayer):
(WebKit::WebFullScreenManagerGtk::beginEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerGtk::beginExitFullScreenAnimation):
* WebProcess/FullScreen/gtk/WebFullScreenManagerGtk.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81478
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Fri, 18 Mar 2011 16:36:57 +0000 (16:36 +0000)]
inspector/console/command-line-api.html timing out on Windows 7 Release (WebKit2 Tests).
https://bugs.webkit.org/show_bug.cgi?id=56633
Unreviewed, skip command-line-api-inspect.html instead of command-line-api.html, since the
former appears to be causing the latter (and probably console-clear.html as well) to time
out.
* platform/win-wk2/Skipped:
* platform/win-wk2/inspector: Removed.
* platform/win-wk2/inspector/console: Removed.
* platform/win-wk2/inspector/console/command-line-api-inspect-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81477
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Fri, 18 Mar 2011 16:36:51 +0000 (16:36 +0000)]
2011-03-18 Alejandro G. Castro <alex@igalia.com>
Unreviewed, fixed compilation after r81208.
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81476
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sergio@webkit.org [Fri, 18 Mar 2011 16:09:26 +0000 (16:09 +0000)]
2011-03-18 Sergio Villar Senin <svillar@igalia.com>
Added new GTK+ test expectations.
* platform/gtk/fast/text/emphasis-combined-text-expected.checksum: Added.
* platform/gtk/fast/text/emphasis-combined-text-expected.png: Added.
* platform/gtk/fast/text/emphasis-combined-text-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81475
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jknotten@chromium.org [Fri, 18 Mar 2011 15:51:39 +0000 (15:51 +0000)]
2011-03-18 John Knottenbelt <jknotten@chromium.org>
Unreviewed.
Remove unnecessary brackets around my email address.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81474
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Fri, 18 Mar 2011 15:31:40 +0000 (15:31 +0000)]
Two inspector tests failing due to SECURITY_ERR exceptions on Windows 7 Release (WebKit2
Tests).
https://bugs.webkit.org/show_bug.cgi?id=56632
Unreviewed, landing expected failing results in order to get the Windows 7 Release
WebKit2 bots green.
* platform/win-wk2/http: Added.
* platform/win-wk2/http/tests: Added.
* platform/win-wk2/http/tests/inspector-enabled: Added.
* platform/win-wk2/http/tests/inspector-enabled/database-open-expected.txt: Added.
* platform/win-wk2/inspector: Added.
* platform/win-wk2/inspector/console: Added.
* platform/win-wk2/inspector/console/command-line-api-inspect-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81473
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Fri, 18 Mar 2011 15:29:39 +0000 (15:29 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=56645
Assertion fires when hidden Find-on-Page matches are encountered in WebKit2
Reviewed by Dan Bernstein.
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
Bail out if the selection rect is empty, before trying to generate an appropriately-sized
bitmap. (Previously it was bailing out afterwards, but encountering an assertion in debug
builds along the way.)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81472
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 18 Mar 2011 15:27:14 +0000 (15:27 +0000)]
2011-03-18 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Benjamin Poulain.
[Qt] console.log not being exposed to QmlViewer
https://bugs.webkit.org/show_bug.cgi?id=56536
The documentation is bogus the feature does not exist.
* declarative/qdeclarativewebview.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81471
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Fri, 18 Mar 2011 15:21:55 +0000 (15:21 +0000)]
2011-03-18 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: implement inspector session storage.
https://bugs.webkit.org/show_bug.cgi?id=56643
We would like to enable debugger/profiler from frontend side only.
However, when user clicks "Start Debugging JavaScript" in Safari, we
need to enable debugger when frontend is opened or re-opened for the
same page. The idea is to store debugger-enabled setting in session
storage and check it on frontend load.
* inspector/InspectorFrontendClient.h:
(WebCore::InspectorFrontendClient::saveSessionSetting):
(WebCore::InspectorFrontendClient::loadSessionSetting):
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::saveSessionSetting):
(WebCore::InspectorFrontendHost::loadSessionSetting):
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.idl:
2011-03-18 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: implement inspector session storage.
https://bugs.webkit.org/show_bug.cgi?id=56643
* WebCoreSupport/WebInspectorClient.h:
* WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::saveSessionSetting):
(WebInspectorClient::loadSessionSetting):
(WebInspectorFrontendClient::saveSessionSetting):
(WebInspectorFrontendClient::loadSessionSetting):
(-[WebInspectorWindowController inspectorClient]):
2011-03-18 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: implement inspector session storage.
https://bugs.webkit.org/show_bug.cgi?id=56643
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::saveSessionSetting):
(WebInspectorClient::loadSessionSetting):
(WebInspectorFrontendClient::saveSessionSetting):
(WebInspectorFrontendClient::loadSessionSetting):
* WebCoreSupport/WebInspectorClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81470
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Fri, 18 Mar 2011 14:31:20 +0000 (14:31 +0000)]
2011-03-18 Alexander Pavlov <apavlov@chromium.org>
[Chromium] Unreviewed, suppress editing/deleting/
5206311-1.html crashes on Mac Debug
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81469
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 18 Mar 2011 14:28:04 +0000 (14:28 +0000)]
2011-03-18 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Enable GraphicsContext3D only when the window surface support OpenGL
https://bugs.webkit.org/show_bug.cgi?id=56555
Allow creation of WebGLRenderingContext in the HTMLCanvasElement
only if accelerated compositing is enabled. In GraphicsContext3D,
while blitting the surface check that viewport hasn't changed from
creation and painter is associated to the viewport.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::getViewportGLWidget):
(WebCore::GraphicsContext3DInternal::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81468
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Fri, 18 Mar 2011 14:11:57 +0000 (14:11 +0000)]
2011-03-17 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: extract content loading logic from scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=55237
* inspector/debugger/debug-inlined-scripts.html:
2011-03-17 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: extract content loading logic from scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=55237
Encapsulate source files creation logic in debugger presentation model
to support source mappings in a pluggable way.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.sourceFile):
(WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent.else.didRequestSource):
(WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent):
(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._addScript.else.resourceFinished):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._ensureSourceFileAdded):
(WebInspector.DebuggerPresentationModel.prototype._resourceForURL):
(WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
(WebInspector.DebuggerPresentationModel.prototype._sourceFileAdded):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
(WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
(WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation):
(WebInspector.DebuggerPresentationModel.prototype.reset):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._sourceFileAdded):
(WebInspector.ScriptsPanel.prototype._showSourceFrame):
(WebInspector.ScriptsPanel.prototype._sourceFileChanged):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81467
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Fri, 18 Mar 2011 13:48:19 +0000 (13:48 +0000)]
2011-03-18 Alexander Pavlov <apavlov@chromium.org>
[Chromium] Unreviewed, rebaseline GPU tests after r81414
* platform/chromium-gpu-linux/compositing/geometry/clipped-video-controller-expected.checksum:
* platform/chromium-gpu-linux/compositing/geometry/clipped-video-controller-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.checksum:
* platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/video-opacity-overlay-expected.checksum:
* platform/chromium-gpu-linux/compositing/geometry/video-opacity-overlay-expected.png:
* platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.checksum:
* platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
* platform/chromium-gpu-linux/compositing/overflow/overflow-compositing-descendant-expected.checksum:
* platform/chromium-gpu-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
* platform/chromium-gpu-linux/compositing/overflow/scroll-ancestor-update-expected.checksum:
* platform/chromium-gpu-linux/compositing/overflow/scroll-ancestor-update-expected.png:
* platform/chromium-gpu-linux/compositing/reflections/load-video-in-reflection-expected.checksum:
* platform/chromium-gpu-linux/compositing/reflections/load-video-in-reflection-expected.png:
* platform/chromium-gpu-linux/compositing/self-painting-layers-expected.checksum:
* platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
* platform/chromium-gpu-linux/media/video-canvas-alpha-expected.checksum: Added.
* platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png: Added.
* platform/chromium-gpu-linux/media/video-display-toggle-expected.checksum:
* platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
* platform/chromium-gpu-linux/media/video-no-audio-expected.checksum:
* platform/chromium-gpu-linux/media/video-no-audio-expected.png:
* platform/chromium-gpu-linux/media/video-volume-slider-expected.checksum:
* platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
* platform/chromium-gpu-linux/media/video-zoom-expected.checksum:
* platform/chromium-gpu-linux/media/video-zoom-expected.png:
* platform/chromium-gpu-win/compositing/geometry/clipped-video-controller-expected.checksum:
* platform/chromium-gpu-win/compositing/geometry/clipped-video-controller-expected.png:
* platform/chromium-gpu-win/compositing/geometry/video-fixed-scrolling-expected.checksum:
* platform/chromium-gpu-win/compositing/geometry/video-fixed-scrolling-expected.png:
* platform/chromium-gpu-win/compositing/geometry/video-opacity-overlay-expected.checksum:
* platform/chromium-gpu-win/compositing/geometry/video-opacity-overlay-expected.png:
* platform/chromium-gpu-win/compositing/layers-inside-overflow-scroll-expected.checksum:
* platform/chromium-gpu-win/compositing/layers-inside-overflow-scroll-expected.png:
* platform/chromium-gpu-win/compositing/overflow/overflow-compositing-descendant-expected.checksum:
* platform/chromium-gpu-win/compositing/overflow/overflow-compositing-descendant-expected.png:
* platform/chromium-gpu-win/compositing/overflow/scroll-ancestor-update-expected.checksum:
* platform/chromium-gpu-win/compositing/overflow/scroll-ancestor-update-expected.png:
* platform/chromium-gpu-win/compositing/reflections/load-video-in-reflection-expected.checksum:
* platform/chromium-gpu-win/compositing/reflections/load-video-in-reflection-expected.png:
* platform/chromium-gpu-win/compositing/self-painting-layers-expected.checksum:
* platform/chromium-gpu-win/compositing/self-painting-layers-expected.png:
* platform/chromium-gpu-win/media/video-canvas-alpha-expected.checksum:
* platform/chromium-gpu-win/media/video-canvas-alpha-expected.png:
* platform/chromium-gpu-win/media/video-display-toggle-expected.checksum:
* platform/chromium-gpu-win/media/video-display-toggle-expected.png:
* platform/chromium-gpu-win/media/video-no-audio-expected.checksum:
* platform/chromium-gpu-win/media/video-no-audio-expected.png:
* platform/chromium-gpu-win/media/video-volume-slider-expected.checksum:
* platform/chromium-gpu-win/media/video-volume-slider-expected.png:
* platform/chromium-gpu-win/media/video-zoom-expected.checksum:
* platform/chromium-gpu-win/media/video-zoom-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81466
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 18 Mar 2011 12:08:26 +0000 (12:08 +0000)]
<rdar://problem/
9153929> PluginProcess fails to launch due to PluginProcessShim.dylib building for 64-bit only
Rubber-stamped by Jon Honeycutt.
Fix a bogus change from r81392 that made PluginProcessShim.xcconfig import DebugRelease.xcconfig.
As its name suggests, DebugRelease.xcconfig is only applicable for the debug and release configurations.
It overrides the valid build architectures and also restricts the build to only the active architecture.
* Configurations/PluginProcessShim.xcconfig: Import BaseTarget.xcconfig instead. This is what
each target-specific .xcconfig file should import.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81465
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Fri, 18 Mar 2011 11:18:08 +0000 (11:18 +0000)]
2011-03-18 Alexander Pavlov <apavlov@chromium.org>
[Chromium] Unreviewed, fix custom expectation after r81438
* platform/chromium/fast/dom/prototype-inheritance-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81464
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 18 Mar 2011 10:26:56 +0000 (10:26 +0000)]
2011-03-18 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: console doesn't scroll when multiline expression is being evaluated
https://bugs.webkit.org/show_bug.cgi?id=56639
Always scoll in the console when command result is received.
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.addMessage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81463
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 18 Mar 2011 10:09:01 +0000 (10:09 +0000)]
2011-03-18 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed fix for chromium test_expectations.txt.
There was a duplicate for inspector/mutate-unknown-node.html
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81462
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Fri, 18 Mar 2011 09:36:53 +0000 (09:36 +0000)]
2011-03-18 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
http/tests/inspector/resource-parameters.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=55867
Fixed test flakiness by not finishing test before proper resource arrives.
* http/tests/inspector/resource-parameters.html: Renamed from LayoutTests/http/tests/inspector/resource-parameters.html-disabled.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81461
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Mar 2011 09:14:29 +0000 (09:14 +0000)]
Remove some files I accidentally added in r81454
* WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
* WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81460
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 18 Mar 2011 09:12:05 +0000 (09:12 +0000)]
2011-03-18 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: chromium: cleanup Web Inspector expectations.
https://bugs.webkit.org/show_bug.cgi?id=56635
Many Inspector tests are passing now but they still have expectations.
I've removed unnecessary expectations and grouped the remainings.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81459
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Mar 2011 09:08:44 +0000 (09:08 +0000)]
Add Windows WebKit2 expected failure results for a media test
The failure is tracked by <http://webkit.org/b/56636>.
* platform/win-wk2/media/controls-without-preload-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81458
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Mar 2011 09:07:00 +0000 (09:07 +0000)]
Skip some timing out tests in WebKit2 on Windows
Tracked by <http://webkit.org/b/56633> and <http://webkit.org/b/56634>.
* platform/win-wk2/Skipped: Added inspector/console/command-line-api.html and
http/tests/xmlhttprequest/cross-origin-authorization.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81457
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Mar 2011 09:05:16 +0000 (09:05 +0000)]
Add expected failure results for WebKit2 tests failing on Windows due to font differences
<http://webkit.org/b/56617> tracks the failures.
* platform/win-wk2/css2.1/t0905-c5525-flthw-00-c-g-expected.txt: Added.
* platform/win-wk2/css2.1/t0905-c5526-flthw-00-c-g-expected.txt: Added.
* platform/win-wk2/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
* platform/win-wk2/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
* platform/win-wk2/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
* platform/win-wk2/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
* platform/win-wk2/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
* platform/win-wk2/svg/text/bidi-text-query-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81456
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Mar 2011 09:03:27 +0000 (09:03 +0000)]
Skip a test in that is probably causing the next test to crash in WebKit2
<http://webkit.org/b/55780> tracks the failure.
* platform/win-wk2/Skipped: Skip platform/win/plugins/draws-gradient.html instead of
platform/win/plugins/get-value-netscape-window.html. The former was probably causing the
latter to crash.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81455
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Mar 2011 09:01:41 +0000 (09:01 +0000)]
Disable a flakey inspector test
<http://webkit.org/b/56565> tracks the failure.
* inspector/elements/elements-panel-xhtml-structure.xhtml-disabled: Renamed from LayoutTests/inspector/elements/elements-panel-xhtml-structure.xhtml.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81454
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Mar 2011 07:39:33 +0000 (07:39 +0000)]
Ignore an NSNumberFormatter leak on SnowLeopard
* Scripts/old-run-webkit-tests:
(countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
getObjectValue:forString:errorDescription:].
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81453
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Mar 2011 07:37:42 +0000 (07:37 +0000)]
Fix a CFNumber leak seen on the leaks bot
Reviewed by Gavin Barraclough.
* platform/network/mac/FormDataStreamMac.mm:
(WebCore::advanceCurrentStream): Use a RetainPtr to cause the CFNumber we allocate to be
released.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81452
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Mar 2011 07:19:24 +0000 (07:19 +0000)]
Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
Rubber-stamped by Mark Rowe.
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
released.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81449
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Mar 2011 07:09:55 +0000 (07:09 +0000)]
Address a review comment I missed in r81445
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
(LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
leaked bytes to speed up searching on long lines.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81448
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Mar 2011 07:01:43 +0000 (07:01 +0000)]
Mark leaky builds orange, even if all regression tests passed
Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
build.webkit.org when all tests pass even though there are still leaks
Reviewed by Dan Bernstein.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
be marked orange if this build step generates warnings.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81447
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Mar 2011 06:59:58 +0000 (06:59 +0000)]
Allow values in Leaks Viewer to be shown as percentages
Double-clicking on a column will toggle between showing percentages and showing real values.
Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
number of leaked bytes in Leaks Viewer
Reviewed by Joe Pecoraro.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
(LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
node's totalTime, which is used in calculating percentages.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
(monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
showing them as percentages.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81446
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Mar 2011 06:58:10 +0000 (06:58 +0000)]
Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
The Self and Total columns now report the number of leaked bytes. The new Calls column shows
the number of leaked allocations. And the new Average column shows the average number of
leaked bytes per call.
Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
just how many allocations
Reviewed by Joe Pecoraro.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
(LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
line and store it with the leak stack.
(LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
properties.
(LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
.numberOfCalls now holds the number of leaked allocations.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
(Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
appear.
(monkeyPatchInspectorObjects): Format the values as bytes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81445
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Mar 2011 05:39:42 +0000 (05:39 +0000)]
Skip a test that is likely causing later tests to assert
<http://webkit.org/b/56599> tracks the failure.
* platform/win/Skipped: Replaced editing/deleting/
5206311-1.html with
editing/deleting/
5168598.html, which is likely causing the former to assert.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81444
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Mar 2011 05:19:56 +0000 (05:19 +0000)]
Add Windows XP results for test added in r81404
The differences from Windows 7 seem to be due to different fonts being used.
* platform/win-xp/fast/text/emphasis-combined-text-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81443
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Mar 2011 05:18:09 +0000 (05:18 +0000)]
Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
regression tests
Reviewed by James Robinson.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
(RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
is always populated, even when all regression tests pass.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81442
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Fri, 18 Mar 2011 05:09:20 +0000 (05:09 +0000)]
2011-03-10 Hayato Ito <hayato@chromium.org>
Reviewed by Tony Chang.
Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
https://bugs.webkit.org/show_bug.cgi?id=56076
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81441
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 18 Mar 2011 04:10:32 +0000 (04:10 +0000)]
2011-03-17 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QML WebView emits iconChanged() when the page title changes
https://bugs.webkit.org/show_bug.cgi?id=56570
* declarative/qdeclarativewebview.cpp:
(QDeclarativeWebView::setPage): Don't forward the frame's titleChanged
signal to the view's iconChanged signal.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81440
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 18 Mar 2011 04:03:35 +0000 (04:03 +0000)]
2011-03-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add some of the remaining platform/mac files to WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=56616
These files used to be hard, but are now magically easy. 76 link errors.
* gyp/WebCore.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81439
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 18 Mar 2011 03:53:43 +0000 (03:53 +0000)]
2011-03-17 Adam Klein <adamk@chromium.org>
Reviewed by Adam Barth.
[filesystem] Rename toURI->toURL, resolveLocalFileSystemURI->resolveLocalFileSystemURL
https://bugs.webkit.org/show_bug.cgi?id=56502
Leaving the file names as-is for now to avoid svn-apply's
handling of move-and-modify.
* fast/filesystem/directory-entry-to-uri-expected.txt:
* fast/filesystem/file-entry-to-uri-expected.txt:
* fast/filesystem/resources/directory-entry-to-uri.js:
* fast/filesystem/resources/file-entry-to-uri-sync.js:
* fast/filesystem/resources/file-entry-to-uri.js:
* fast/filesystem/workers/file-entry-to-uri-sync-expected.txt:
* http/tests/filesystem/resolve-uri-expected.txt:
* http/tests/filesystem/script-tests/resolve-uri.js:
2011-03-17 Adam Klein <adamk@chromium.org>
Reviewed by Adam Barth.
[filesystem] Rename toURI->toURL, resolveLocalFileSystemURI->resolveLocalFileSystemURL
https://bugs.webkit.org/show_bug.cgi?id=56502
* fileapi/Entry.idl:
* fileapi/EntryBase.cpp:
(WebCore::EntryBase::toURL):
* fileapi/EntryBase.h:
* fileapi/EntrySync.idl:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::resolveLocalFileSystemURL):
* page/DOMWindow.h:
* page/DOMWindow.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81438
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 18 Mar 2011 02:43:33 +0000 (02:43 +0000)]
Fix the build.
* WebKit2.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81427
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simonjam@chromium.org [Fri, 18 Mar 2011 02:14:53 +0000 (02:14 +0000)]
2011-03-17 James Simonsen <simonjam@chromium.org>
Unreviewed, rebaseline a bunch of chromium tests.
* platform/chromium-mac-leopard/fast/block/positioning/auto/vertical-lr/007-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
* platform/chromium-mac-leopard/fast/block/positioning/auto/vertical-rl/007-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
* platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
* platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
* platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.checksum:
* platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.png:
* platform/chromium-mac-leopard/fast/blockflow/english-lr-text-expected.checksum:
* platform/chromium-mac-leopard/fast/blockflow/english-lr-text-expected.png:
* platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.png: Added.
* platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.checksum:
* platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.png:
* platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.checksum:
* platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.png:
* platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.checksum:
* platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.png:
* platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.checksum:
* platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.png:
* platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
* platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png:
* platform/chromium-mac-leopard/fast/ruby/base-shorter-than-text-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/ruby/base-shorter-than-text-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.checksum:
* platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81426
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 18 Mar 2011 01:58:18 +0000 (01:58 +0000)]
2011-03-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Update CSP directive parser to match spec
https://bugs.webkit.org/show_bug.cgi?id=56582
Test some error-handling cases.
* http/tests/security/contentSecurityPolicy/directive-parsing-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/directive-parsing.html: Added.
2011-03-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Update CSP directive parser to match spec
https://bugs.webkit.org/show_bug.cgi?id=56582
Brandon updated the CSP spec. I've updated our implementation to
match. In the process, I found a couple bugs in the spec, which I've
sent to the working group. This patch assumes that the bugs will be
fixed in the way I suggested. If they get fixed a different way, we
might need to update the parser again.
Test: http/tests/security/contentSecurityPolicy/directive-parsing.html
* page/ContentSecurityPolicy.cpp:
(WebCore::isDirectiveNameCharacter):
(WebCore::isDirectiveValueCharacter):
(WebCore::advanceUntil):
(WebCore::ContentSecurityPolicy::parse):
(WebCore::ContentSecurityPolicy::parseDirective):
* page/ContentSecurityPolicy.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81425
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 18 Mar 2011 01:36:22 +0000 (01:36 +0000)]
2011-03-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
WebCore GYP build should have PrivateHeaders
https://bugs.webkit.org/show_bug.cgi?id=56604
I've manually verified that this produces the correct set of
PrivateHeaders (modulo the ForwardingHeaders and icu issue).
Unforunately, this patch breakes compile slightly, but I'll fix that
in a followup patch.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* gyp/WebCore.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81424
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simonjam@chromium.org [Fri, 18 Mar 2011 01:31:28 +0000 (01:31 +0000)]
2011-03-17 James Simonsen <simonjam@chromium.org>
Unreviewed, update chromium test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81423
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Fri, 18 Mar 2011 01:17:41 +0000 (01:17 +0000)]
2011-03-17 Alexey Marinichev <amarinichev@chromium.org>
Reviewed by Kenneth Russell.
chromium: uninitialized field in WebViewImpl
https://bugs.webkit.org/show_bug.cgi?id=56620
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81422
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 18 Mar 2011 01:11:10 +0000 (01:11 +0000)]
2011-03-17 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Implement PluginProcessProxy::setFullscreenWindowIsShowing
https://bugs.webkit.org/show_bug.cgi?id=56618
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::PluginProcessProxy):
Initialize m_fullscreenWindowIsShowing.
(WebKit::PluginProcessProxy::didClose):
if m_fullscreenWindowIsShowing is true, call exitFullscreen.
* UIProcess/Plugins/PluginProcessProxy.h:
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::getPluginProcessSerialNumber):
Add helper function for getting a PSN for the plug-in process.
(WebKit::PluginProcessProxy::makePluginProcessTheFrontProcess):
Make the plug-in process the front process.
(WebKit::PluginProcessProxy::makeUIProcessTheFrontProcess):
Make the current process (the UI process) the front process.
(WebKit::PluginProcessProxy::setFullscreenWindowIsShowing):
Call enterFullscreen or exitFullscreen.
(WebKit::PluginProcessProxy::enterFullscreen):
Make the plug-in process the front process and hide the menu bar.
(WebKit::PluginProcessProxy::exitFullscreen):
Show the menu bar and if necessary make the UI process the front process.
(WebKit::PluginProcessProxy::endModal):
call makeUIProcessTheFrontProcess.
(WebKit::PluginProcessProxy::applicationDidBecomeActive):
Call makePluginProcessTheFrontProcess.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81421
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 18 Mar 2011 01:11:06 +0000 (01:11 +0000)]
2011-03-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Mark Rowe.
Fixed some string leaks seen on the buildbot
https://bugs.webkit.org/show_bug.cgi?id=56619
* runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::~PropertyTable): DEref!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81420
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Mar 2011 00:52:01 +0000 (00:52 +0000)]
Make bidi text in <select> menus in WebKit2 on Windows match WebKit1
Fixes <http://webkit.org/b/56614> 3 <select> bidi tests failing on Windows 7 Release
(WebKit2 Tests)
Reviewed by Sam Weinig.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::selectItemWritingDirectionIsNatural):
(WebKit::WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection):
On Windows, return the same values we return in WebKit1.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81419
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 18 Mar 2011 00:45:24 +0000 (00:45 +0000)]
2011-03-17 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Implement PluginProcessProxy::setModalWindowIsShowing
https://bugs.webkit.org/show_bug.cgi?id=56615
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::PluginProcessProxy):
Initialize m_modalWindowIsShowing.
(WebKit::PluginProcessProxy::didClose):
If m_modalWindowIsShowing is true, we must call endModal.
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(-[WKPlaceholderModalWindow _wantsUserAttention]):
Add a WKPlaceholderModalWindow.
(WebKit::PluginProcessProxy::setModalWindowIsShowing):
Call beginModal or endModal depending on whether we're showing a modal window or not.
(WebKit::PluginProcessProxy::beginModal):
Create a fake window and start a nested run loop. Listen for NSApplicationWillBecomeActiveNotification notifications.
(WebKit::PluginProcessProxy::endModal):
Tear down the window and the run loop.
(WebKit::PluginProcessProxy::applicationDidBecomeActive):
Make sure that the plug-in process is frontmost.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81418
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Fri, 18 Mar 2011 00:18:01 +0000 (00:18 +0000)]
Misc clean-up (see files for details).
* platform/chromium-mac-leopard/media/controls-after-reload-expected.checksum: Due to r81300.
* platform/chromium-mac-leopard/media/controls-after-reload-expected.png: Ditto.
* platform/chromium-mac-leopard/media/controls-without-preload-expected.checksum: Due to r81280.
* platform/chromium-mac-leopard/media/controls-without-preload-expected.png: Ditto.
* platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.checksum: Due to r81285.
* platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png: Ditto.
* platform/chromium-win-xp/media/controls-without-preload-expected.checksum: Due to r81280.
* platform/chromium-win-xp/media/controls-without-preload-expected.png: Ditto.
* platform/chromium/test_expectations.txt: Replace BUG_LEVIN with a bug number.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81417
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Fri, 18 Mar 2011 00:11:45 +0000 (00:11 +0000)]
2011-03-17 Jeff Miller <jeffm@apple.com>
Reviewed by Adam Roben.
Web page shouldn't swallow alt-key combinations on Windows
https://bugs.webkit.org/show_bug.cgi?id=56612
Make Alt+Left Arrow and Alt+Right Arrow go back and forward, but make
sure any alt-key combinations bubble up to the client.
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::performDefaultBehaviorForKeyEvent): Make Alt+Left Arrow and Alt+Right Arrow go back and forward, ignore any other alt-key combinations.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81416
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 18 Mar 2011 00:11:17 +0000 (00:11 +0000)]
Added platform-specific expected results for fast/text/emphasis-combined-text.html
* platform/mac-leopard/fast/text/emphasis-combined-text-expected.txt: Added.
* platform/win/fast/text/emphasis-combined-text-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81415
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 18 Mar 2011 00:10:53 +0000 (00:10 +0000)]
2011-03-17 Victoria Kirst <vrk@google.com>
Reviewed by Kenneth Russell.
[chromium] Video colors have wrong brightness/contrast
https://bugs.webkit.org/show_bug.cgi?id=56598
This patch changes the YUV to RGB color conversion matrix
to have brighter whites and darker blacks in accordance to
the BT.601 standard.
* platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::FragmentShaderYUVVideo::FragmentShaderYUVVideo):
(WebCore::FragmentShaderYUVVideo::init):
(WebCore::FragmentShaderYUVVideo::getShaderString):
* platform/graphics/chromium/ShaderChromium.h:
(WebCore::FragmentShaderYUVVideo::yuvAdjLocation):
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::drawYUV):
* platform/graphics/chromium/VideoLayerChromium.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81414
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Mar 2011 00:08:39 +0000 (00:08 +0000)]
Skip a compositing-sensitive test when accelerated compositing is disabled
Reviewed by Sam Weinig.
Tools:
* Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
accelerated compositing is disabled.
LayoutTests:
Remove some non-compositing results for a test that is now skipped in non-compositing builds
* platform/win-xp/media/media-document-audio-repaint-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81413
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 18 Mar 2011 00:08:09 +0000 (00:08 +0000)]
2011-03-17 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Send SetModalWindowIsShowing and SetFullscreenWindowIsShowing messages to the UI process
https://bugs.webkit.org/show_bug.cgi?id=56610
* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::FullscreenWindowTracker::FullscreenWindowTracker):
Add fullscreen window tracker class.
(WebKit::rectCoversAnyScreen):
Return whether the given rect covers any screen.
(WebKit::windowCoversAnyScreen):
Return whether the given window covers any screen.
(WebKit::FullscreenWindowTracker::windowShown):
If we're showing a fullscreen window, call PluginProcess::setFullscreenWindowIsShowing.
(WebKit::FullscreenWindowTracker::windowHidden):
If we're hiding the last fullscreen window, call PluginProcess::setFullscreenWindowIsShowing.
(WebKit::cocoaWindowShown):
(WebKit::cocoaWindowHidden):
(WebKit::carbonWindowShown):
(WebKit::carbonWindowHidden):
Call the window tracking functions.
(WebKit::setModal):
Call PluginProcess::setModalWindowIsShowing.
(WebKit::PluginProcess::setModalWindowIsShowing):
(WebKit::PluginProcess::setFullscreenWindowIsShowing):
Send CoreIPC messages.
* UIProcess/Plugins/PluginProcessProxy.h:
* UIProcess/Plugins/PluginProcessProxy.messages.in:
Add new messages.
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::setModalWindowIsShowing):
(WebKit::PluginProcessProxy::setFullscreenWindowIsShowing):
Add stubs.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81412
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 17 Mar 2011 23:57:56 +0000 (23:57 +0000)]
2011-03-17 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Crash in JSC::MarkStack::drain Under Stress
https://bugs.webkit.org/show_bug.cgi?id=56470
We perform a number of gc allocations while when
we are setting up new globals in a piece of global
code. We do this by adding new properties to the
symbol table, and then expanding the storage to fit
at the end.
If a GC happens during this time we will report an
incorrect size for the global object's symbol table
storage.
This patch corrects this by growing the storage size
before we starting adding entries to the symbol table.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::resizeRegisters):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81411
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 17 Mar 2011 23:46:58 +0000 (23:46 +0000)]
2011-03-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
1 Structure leaked beneath JSGlobalData::storeVPtrs()
https://bugs.webkit.org/show_bug.cgi?id=56595
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::storeVPtrs): Take local ownership of the Structure
we're using, since the Executable is not designed to own the Structure.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81410
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 17 Mar 2011 23:27:14 +0000 (23:27 +0000)]
Rubber Stamped by Sam Weinig.
Add missing register-register branchTest8 to MacroAssemblerX86Common/X86Assembler.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branchTest8):
* assembler/X86Assembler.h:
(JSC::X86Assembler::testb_rr):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81408
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Thu, 17 Mar 2011 23:26:27 +0000 (23:26 +0000)]
2011-03-17 Zhenyao Mo <zmo@google.com>
Reviewed by Adam Barth.
RequestAnimationFrame callbacks prevent Document from being released on detach
https://bugs.webkit.org/show_bug.cgi?id=56607
* dom/Document.cpp:
(WebCore::Document::removedLastRef): Remove RequestAnimationFrame callbacks.
(WebCore::Document::detach): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81407
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Thu, 17 Mar 2011 23:22:20 +0000 (23:22 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=56596 Overlay scrollbars sometimes
fail to appear
-and corresponding-
<rdar://problem/
8953779>
Reviewed by Darin Adler.
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81406
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lforschler@apple.com [Thu, 17 Mar 2011 23:16:10 +0000 (23:16 +0000)]
Versioning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81405
268f45cc-cd09-0410-ab3c-
d52691b4dbfc