WebKit-https.git
12 years agoAdd a mechanism to store and retrieve preferences for the Web Inspector.
timothy@apple.com [Fri, 24 Oct 2008 18:49:39 +0000 (18:49 +0000)]
Add a mechanism to store and retrieve preferences for the Web Inspector.

WebCore:

2008-10-24  Timothy Hatcher  <timothy@apple.com>

        Add a mechanism to ask the InspectorClient for key/value setting pairs.
        These settings can be strings, numbers, booleans or string vectors. The
        settings are also bridged to and from JavaScript.

        https://bugs.webkit.org/show_bug.cgi?id=21856

        Reviewed by Darin Adler.

        * WebCore.base.exp: Expose the String CFStringRef constructor.
        * inspector/InspectorClient.h:
        (WebCore::InspectorClient::populateSetting): Added, pure virtual.
        (WebCore::InspectorClient::storeSetting): Ditto.
        (WebCore::InspectorClient::removeSetting): Ditto.
        * inspector/InspectorController.cpp:
        (WebCore::setting): Calls InspectorController::setting and wraps the result in script types.
        (WebCore::setSetting): Calls InspectorController::setSetting after converting from script types.
        (WebCore::InspectorController::InspectorController): Increment a global static
        to track the number of live InspectorControllers.
        (WebCore::InspectorController::~InspectorController): Decrement the global static
        that tracks the number of live InspectorControllers. Delete the setting cache if there
        are no more live controllers.
        (WebCore::InspectorController::setting): Check the cache and return the setting from there,
        otherwise make a new Setting and ask the client to populate it.
        (WebCore::InspectorController::setSetting): Change the cache and ask the client to store it.
        (WebCore::InspectorController::windowScriptObjectAvailable): Add setting and setSetting
        to the InspectorController script class.
        * inspector/InspectorController.h:
        (WebCore::InspectorController::Setting::Setting):
        (WebCore::InspectorController::Setting::operator=):
        (WebCore::InspectorController::Setting::type): Return m_type.
        (WebCore::InspectorController::Setting::string): Return m_string. Assert the type is correct.
        (WebCore::InspectorController::Setting::stringVector): Return m_stringVector.
        Assert the type is correct.
        (WebCore::InspectorController::Setting::doubleValue): Return m_simpleContent.m_double.
        Assert the type is correct.
        (WebCore::InspectorController::Setting::integerValue): Return m_simpleContent.m_integer.
        Assert the type is correct.
        (WebCore::InspectorController::Setting::booleanValue): Return m_simpleContent.m_boolean.
        Assert the type is correct.
        (WebCore::InspectorController::Setting::set): Overloaded for each data type, sets the right
        field and the type.
        * loader/EmptyClients.h:
        (WebCore::EmptyInspectorClient::populateSetting): Added, empty method.
        (WebCore::EmptyInspectorClient::storeSetting): Ditto.
        (WebCore::EmptyInspectorClient::removeSetting): Ditto.

WebKit:

2008-10-24  Timothy Hatcher  <timothy@apple.com>

        Implement new InspectorClient methods to work with Settings.

        https://bugs.webkit.org/show_bug.cgi?id=21856

        Reviewed by Darin Adler.

        * WebKit.xcodeproj/project.pbxproj: Add the new InspectorClientCF.cpp file.

WebKit/gtk:

2008-10-24  Timothy Hatcher  <timothy@apple.com>

        Stub out new InspectorClient methods.

        https://bugs.webkit.org/show_bug.cgi?id=21856

        Reviewed by Darin Adler.

        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::InspectorClient::populateSetting): Not implemented.
        (WebKit::InspectorClient::storeSetting): Ditto.
        (WebKit::InspectorClient::removeSetting): Ditto.
        * WebCoreSupport/InspectorClientGtk.h:

WebKit/mac:

2008-10-24  Timothy Hatcher  <timothy@apple.com>

        Implement new InspectorClient methods to work with Settings.

        https://bugs.webkit.org/show_bug.cgi?id=21856

        Reviewed by Darin Adler.

        * WebCoreSupport/WebInspectorClient.h: Add the new methods and
        guard the ObjC parts of the header.

WebKit/qt:

2008-10-24  Timothy Hatcher  <timothy@apple.com>

        Stub out new InspectorClient methods.

        https://bugs.webkit.org/show_bug.cgi?id=21856

        Reviewed by Darin Adler.

        * WebCoreSupport/InspectorClientQt.cpp:
        (WebCore::InspectorClientQt::populateSetting): Not implemented.
        (WebCore::InspectorClientQt::storeSetting): Ditto.
        (WebCore::InspectorClientQt::removeSetting): Ditto.
        * WebCoreSupport/InspectorClientQt.h:

WebKit/win:

2008-10-24  Timothy Hatcher  <timothy@apple.com>

        Implement new InspectorClient methods to work with Settings.

        https://bugs.webkit.org/show_bug.cgi?id=21856

        Reviewed by Adam Roben.

        * WebKit.vcproj/WebKit.vcproj: Add the new InspectorClientCF.cpp file.
        * WebCoreSupport/WebInspectorClient.h: Add the new methods.

WebKit/wx:

2008-10-24  Timothy Hatcher  <timothy@apple.com>

        Stub out new InspectorClient methods.

        https://bugs.webkit.org/show_bug.cgi?id=21856

        Reviewed by Darin Adler.

        * WebKitSupport/InspectorClientWx.cpp:
        (WebCore::InspectorClient::populateSetting): Not implemented.
        (WebCore::InspectorClient::storeSetting): Ditto.
        (WebCore::InspectorClient::removeSetting): Ditto.
        * WebKitSupport/InspectorClientWx.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Bug 21850: svn-apply and svn-unapply should preserve patch line endings
ddkilzer@apple.com [Fri, 24 Oct 2008 18:19:50 +0000 (18:19 +0000)]
    Bug 21850: svn-apply and svn-unapply should preserve patch line endings

        <https://bugs.webkit.org/show_bug.cgi?id=21850>

        Reviewed by Adam Roben.

        * Scripts/svn-apply: Save end-of-line characters when stripping them
        off each line of a patch so that they may be restored after
        processing the line.
        * Scripts/svn-unapply: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-24 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Fri, 24 Oct 2008 18:10:17 +0000 (18:10 +0000)]
2008-10-24  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Sam Weinig.

        Remove some C-style casts.

        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::addViewSourceToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
darin@apple.com [Fri, 24 Oct 2008 16:22:51 +0000 (16:22 +0000)]
JavaScriptCore:

2008-10-24  Darin Adler  <darin@apple.com>

        - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732

        * API/APICast.h:
        * API/JSCallbackConstructor.h:
        * API/JSCallbackFunction.cpp:
        * API/JSCallbackFunction.h:
        * API/JSCallbackObject.h:
        * API/JSCallbackObjectFunctions.h:
        * API/JSContextRef.cpp:
        * API/JSObjectRef.cpp:
        * API/JSValueRef.cpp:
        * VM/CTI.cpp:
        * VM/CTI.h:
        * VM/CodeBlock.cpp:
        * VM/CodeBlock.h:
        * VM/CodeGenerator.cpp:
        * VM/CodeGenerator.h:
        * VM/ExceptionHelpers.cpp:
        * VM/ExceptionHelpers.h:
        * VM/JSPropertyNameIterator.cpp:
        * VM/JSPropertyNameIterator.h:
        * VM/Machine.cpp:
        * VM/Machine.h:
        * VM/Register.h:
        * kjs/ArgList.cpp:
        * kjs/ArgList.h:
        * kjs/Arguments.cpp:
        * kjs/Arguments.h:
        * kjs/ArrayConstructor.cpp:
        * kjs/ArrayPrototype.cpp:
        * kjs/BooleanConstructor.cpp:
        * kjs/BooleanConstructor.h:
        * kjs/BooleanObject.h:
        * kjs/BooleanPrototype.cpp:
        * kjs/CallData.cpp:
        * kjs/CallData.h:
        * kjs/ConstructData.cpp:
        * kjs/ConstructData.h:
        * kjs/DateConstructor.cpp:
        * kjs/DateInstance.h:
        * kjs/DatePrototype.cpp:
        * kjs/DatePrototype.h:
        * kjs/DebuggerCallFrame.cpp:
        * kjs/DebuggerCallFrame.h:
        * kjs/ErrorConstructor.cpp:
        * kjs/ErrorPrototype.cpp:
        * kjs/ExecState.cpp:
        * kjs/ExecState.h:
        * kjs/FunctionConstructor.cpp:
        * kjs/FunctionPrototype.cpp:
        * kjs/FunctionPrototype.h:
        * kjs/GetterSetter.cpp:
        * kjs/GetterSetter.h:
        * kjs/InternalFunction.h:
        * kjs/JSActivation.cpp:
        * kjs/JSActivation.h:
        * kjs/JSArray.cpp:
        * kjs/JSArray.h:
        * kjs/JSCell.cpp:
        * kjs/JSCell.h:
        * kjs/JSFunction.cpp:
        * kjs/JSFunction.h:
        * kjs/JSGlobalData.h:
        * kjs/JSGlobalObject.cpp:
        * kjs/JSGlobalObject.h:
        * kjs/JSGlobalObjectFunctions.cpp:
        * kjs/JSGlobalObjectFunctions.h:
        * kjs/JSImmediate.cpp:
        * kjs/JSImmediate.h:
        * kjs/JSNotAnObject.cpp:
        * kjs/JSNotAnObject.h:
        * kjs/JSNumberCell.cpp:
        * kjs/JSNumberCell.h:
        * kjs/JSObject.cpp:
        * kjs/JSObject.h:
        * kjs/JSStaticScopeObject.cpp:
        * kjs/JSStaticScopeObject.h:
        * kjs/JSString.cpp:
        * kjs/JSString.h:
        * kjs/JSValue.h:
        * kjs/JSVariableObject.h:
        * kjs/JSWrapperObject.h:
        * kjs/MathObject.cpp:
        * kjs/MathObject.h:
        * kjs/NativeErrorConstructor.cpp:
        * kjs/NumberConstructor.cpp:
        * kjs/NumberConstructor.h:
        * kjs/NumberObject.cpp:
        * kjs/NumberObject.h:
        * kjs/NumberPrototype.cpp:
        * kjs/ObjectConstructor.cpp:
        * kjs/ObjectPrototype.cpp:
        * kjs/ObjectPrototype.h:
        * kjs/PropertyMap.h:
        * kjs/PropertySlot.cpp:
        * kjs/PropertySlot.h:
        * kjs/RegExpConstructor.cpp:
        * kjs/RegExpConstructor.h:
        * kjs/RegExpMatchesArray.h:
        * kjs/RegExpObject.cpp:
        * kjs/RegExpObject.h:
        * kjs/RegExpPrototype.cpp:
        * kjs/Shell.cpp:
        * kjs/StringConstructor.cpp:
        * kjs/StringObject.cpp:
        * kjs/StringObject.h:
        * kjs/StringObjectThatMasqueradesAsUndefined.h:
        * kjs/StringPrototype.cpp:
        * kjs/StructureID.cpp:
        * kjs/StructureID.h:
        * kjs/collector.cpp:
        * kjs/collector.h:
        * kjs/completion.h:
        * kjs/grammar.y:
        * kjs/interpreter.cpp:
        * kjs/interpreter.h:
        * kjs/lookup.cpp:
        * kjs/lookup.h:
        * kjs/nodes.h:
        * kjs/operations.cpp:
        * kjs/operations.h:
        * kjs/protect.h:
        * profiler/ProfileGenerator.cpp:
        * profiler/Profiler.cpp:
        * profiler/Profiler.h:
        Use JSValue* instead of JSValuePtr.

JavaScriptGlue:

2008-10-24  Darin Adler  <darin@apple.com>

        - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732

        * JSObject.cpp:
        (nativeCallFunction):
        * JSUtils.cpp:
        (KJSValueToJSObject):
        (JSObjectKJSValue):
        (KJSValueToCFTypeInternal):
        (KJSValueToCFType):
        * JSUtils.h:
        * JSValueWrapper.cpp:
        (JSValueWrapper::JSValueWrapper):
        (JSValueWrapper::GetValue):
        (JSValueWrapper::JSObjectCopyProperty):
        (JSValueWrapper::JSObjectSetProperty):
        (JSValueWrapper::JSObjectCallFunction):
        * JSValueWrapper.h:
        * UserObjectImp.cpp:
        (UserObjectImp::callAsFunction):
        (UserObjectImp::userObjectGetter):
        (UserObjectImp::getOwnPropertySlot):
        (UserObjectImp::put):
        (UserObjectImp::toPrimitive):
        * UserObjectImp.h:
        (UserObjectImp::createStructureID):
        Use JSValue* instead of JSValuePtr.

WebCore:

2008-10-24  Darin Adler  <darin@apple.com>

        - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732

        * bindings/js/JSAttrCustom.cpp:
        * bindings/js/JSCSSRuleCustom.cpp:
        * bindings/js/JSCSSStyleDeclarationCustom.cpp:
        * bindings/js/JSCSSValueCustom.cpp:
        * bindings/js/JSCanvasPixelArrayCustom.h:
        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        * bindings/js/JSClipboardCustom.cpp:
        * bindings/js/JSConsoleCustom.cpp:
        * bindings/js/JSCustomSQLStatementCallback.cpp:
        * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
        * bindings/js/JSCustomSQLTransactionCallback.cpp:
        * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
        * bindings/js/JSCustomVoidCallback.cpp:
        * bindings/js/JSCustomVoidCallback.h:
        * bindings/js/JSCustomXPathNSResolver.cpp:
        * bindings/js/JSCustomXPathNSResolver.h:
        * bindings/js/JSDOMApplicationCacheCustom.cpp:
        * bindings/js/JSDOMBinding.cpp:
        * bindings/js/JSDOMBinding.h:
        * bindings/js/JSDOMWindowBase.cpp:
        * bindings/js/JSDOMWindowBase.h:
        * bindings/js/JSDOMWindowCustom.cpp:
        * bindings/js/JSDOMWindowCustom.h:
        * bindings/js/JSDOMWindowShell.cpp:
        * bindings/js/JSDOMWindowShell.h:
        * bindings/js/JSDatabaseCustom.cpp:
        * bindings/js/JSDedicatedWorkerCustom.cpp:
        * bindings/js/JSDocumentCustom.cpp:
        * bindings/js/JSElementCustom.cpp:
        * bindings/js/JSEventCustom.cpp:
        * bindings/js/JSEventListener.cpp:
        * bindings/js/JSEventTarget.cpp:
        * bindings/js/JSEventTarget.h:
        * bindings/js/JSEventTargetBase.h:
        * bindings/js/JSEventTargetNodeCustom.cpp:
        * bindings/js/JSHTMLAllCollection.h:
        * bindings/js/JSHTMLAppletElementCustom.cpp:
        * bindings/js/JSHTMLCollectionCustom.cpp:
        * bindings/js/JSHTMLDocumentCustom.cpp:
        * bindings/js/JSHTMLEmbedElementCustom.cpp:
        * bindings/js/JSHTMLFormElementCustom.cpp:
        * bindings/js/JSHTMLFrameElementCustom.cpp:
        * bindings/js/JSHTMLFrameSetElementCustom.cpp:
        * bindings/js/JSHTMLIFrameElementCustom.cpp:
        * bindings/js/JSHTMLInputElementCustom.cpp:
        * bindings/js/JSHTMLObjectElementCustom.cpp:
        * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
        * bindings/js/JSHTMLSelectElementCustom.cpp:
        * bindings/js/JSHTMLSelectElementCustom.h:
        * bindings/js/JSHistoryCustom.cpp:
        * bindings/js/JSImageDataCustom.cpp:
        * bindings/js/JSInspectedObjectWrapper.cpp:
        * bindings/js/JSInspectedObjectWrapper.h:
        * bindings/js/JSInspectorCallbackWrapper.cpp:
        * bindings/js/JSInspectorCallbackWrapper.h:
        * bindings/js/JSJavaScriptCallFrameCustom.cpp:
        * bindings/js/JSLocationCustom.cpp:
        * bindings/js/JSMessagePortCustom.cpp:
        * bindings/js/JSMimeTypeArrayCustom.cpp:
        * bindings/js/JSNamedNodeMapCustom.cpp:
        * bindings/js/JSNamedNodesCollection.cpp:
        * bindings/js/JSNamedNodesCollection.h:
        * bindings/js/JSNavigatorCustom.cpp:
        * bindings/js/JSNodeCustom.cpp:
        * bindings/js/JSNodeFilterCondition.cpp:
        * bindings/js/JSNodeFilterCondition.h:
        * bindings/js/JSNodeFilterCustom.cpp:
        * bindings/js/JSNodeIteratorCustom.cpp:
        * bindings/js/JSNodeListCustom.cpp:
        * bindings/js/JSPluginArrayCustom.cpp:
        * bindings/js/JSPluginCustom.cpp:
        * bindings/js/JSPluginElementFunctions.cpp:
        * bindings/js/JSPluginElementFunctions.h:
        * bindings/js/JSQuarantinedObjectWrapper.cpp:
        * bindings/js/JSQuarantinedObjectWrapper.h:
        * bindings/js/JSRGBColor.cpp:
        * bindings/js/JSRGBColor.h:
        * bindings/js/JSSQLResultSetRowListCustom.cpp:
        * bindings/js/JSSQLTransactionCustom.cpp:
        * bindings/js/JSSVGElementInstanceCustom.cpp:
        * bindings/js/JSSVGLengthCustom.cpp:
        * bindings/js/JSSVGMatrixCustom.cpp:
        * bindings/js/JSSVGPathSegCustom.cpp:
        * bindings/js/JSSVGPathSegListCustom.cpp:
        * bindings/js/JSSVGPointListCustom.cpp:
        * bindings/js/JSSVGTransformListCustom.cpp:
        * bindings/js/JSStorageCustom.cpp:
        * bindings/js/JSStyleSheetCustom.cpp:
        * bindings/js/JSStyleSheetListCustom.cpp:
        * bindings/js/JSTextCustom.cpp:
        * bindings/js/JSTreeWalkerCustom.cpp:
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
        * bindings/js/JSXSLTProcessorCustom.cpp:
        * bindings/js/ScheduledAction.cpp:
        * bindings/js/ScheduledAction.h:
        * bindings/js/ScriptController.cpp:
        * bindings/js/ScriptController.h:
        * bindings/objc/WebScriptObject.mm:
        * bindings/objc/WebScriptObjectPrivate.h:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/NP_jsobject.cpp:
        * bridge/c/c_instance.cpp:
        * bridge/c/c_instance.h:
        * bridge/c/c_runtime.cpp:
        * bridge/c/c_runtime.h:
        * bridge/c/c_utility.cpp:
        * bridge/c/c_utility.h:
        * bridge/jni/jni_instance.cpp:
        * bridge/jni/jni_instance.h:
        * bridge/jni/jni_jsobject.h:
        * bridge/jni/jni_jsobject.mm:
        * bridge/jni/jni_objc.mm:
        * bridge/jni/jni_runtime.cpp:
        * bridge/jni/jni_runtime.h:
        * bridge/jni/jni_utility.cpp:
        * bridge/jni/jni_utility.h:
        * bridge/objc/WebScriptObject.h:
        * bridge/objc/objc_class.h:
        * bridge/objc/objc_class.mm:
        * bridge/objc/objc_instance.h:
        * bridge/objc/objc_instance.mm:
        * bridge/objc/objc_runtime.h:
        * bridge/objc/objc_runtime.mm:
        * bridge/objc/objc_utility.h:
        * bridge/objc/objc_utility.mm:
        * bridge/qt/qt_class.cpp:
        * bridge/qt/qt_class.h:
        * bridge/qt/qt_instance.cpp:
        * bridge/qt/qt_instance.h:
        * bridge/qt/qt_runtime.cpp:
        * bridge/qt/qt_runtime.h:
        * bridge/runtime.cpp:
        * bridge/runtime.h:
        * bridge/runtime_array.cpp:
        * bridge/runtime_array.h:
        * bridge/runtime_method.cpp:
        * bridge/runtime_method.h:
        * bridge/runtime_object.cpp:
        * bridge/runtime_object.h:
        * bridge/testqtbindings.cpp:
        * inspector/JavaScriptCallFrame.cpp:
        * inspector/JavaScriptCallFrame.h:
        * inspector/JavaScriptProfile.cpp:
        * inspector/JavaScriptProfile.h:
        * inspector/JavaScriptProfileNode.cpp:
        * inspector/JavaScriptProfileNode.h:
        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:
        * page/Console.cpp:
        * page/Console.h:
        * plugins/MimeTypeArray.h:
        * plugins/Plugin.h:
        * plugins/PluginArray.h:
        * plugins/PluginView.cpp:
        * xml/XMLHttpRequest.cpp:
        Use JSValue* instead of JSValuePtr.

WebKit/mac:

2008-10-24  Darin Adler  <darin@apple.com>

        - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732

        * WebView/WebFrame.mm:
        (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
        * WebView/WebScriptDebugDelegate.mm:
        (-[WebScriptCallFrame _convertValueToObjcValue:]):
        (-[WebScriptCallFrame exception]):
        (-[WebScriptCallFrame evaluateWebScript:]):
        * WebView/WebView.mm:
        (aeDescFromJSValue):
        (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
        Use JSValue* instead of JSValuePtr.

WebKit/qt:

2008-10-24  Darin Adler  <darin@apple.com>

        - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732

        * Api/qwebframe.cpp:
        (QWebFrame::evaluateJavaScript): Use JSValue* instead of JSValuePtr.

WebKit/win:

2008-10-24  Darin Adler  <darin@apple.com>

        - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732

        * WebScriptCallFrame.cpp:
        (WebScriptCallFrame::jsValueToString):
        (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString):
        (WebScriptCallFrame::valueForVariable):
        (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
        * WebScriptCallFrame.h:
        * WebView.cpp:
        (WebView::stringByEvaluatingJavaScriptFromString):
        Use JSValue* instead of JSValuePtr.

WebKit/wx:

2008-10-24  Darin Adler  <darin@apple.com>

        - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732

        * WebFrame.cpp: (wxWebFrame::RunScript): Use JSValue* instead of JSValuePtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-24 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Fri, 24 Oct 2008 14:43:29 +0000 (14:43 +0000)]
2008-10-24  Simon Hausmann  <hausmann@webkit.org>

        Fix the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-23 Yael Aharon <yael.aharon@nokia.com>
hausmann@webkit.org [Fri, 24 Oct 2008 13:42:35 +0000 (13:42 +0000)]
2008-10-23  Yael Aharon <yael.aharon@nokia.com>

        Reviewed by Simon Hausmann.

        Invalid history entries could cause a crash in QT Webkit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRolled out r37840 and r37841.
ddkilzer@apple.com [Fri, 24 Oct 2008 07:39:15 +0000 (07:39 +0000)]
Rolled out r37840 and r37841.

JavaScriptCore:

        Rolled out r37840.

        * wtf/Platform.h:

WebCore:

        Rolled out r37840 and r37841.

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSCustomPositionCallback.cpp: Removed.
        * bindings/js/JSCustomPositionCallback.h: Removed.
        * bindings/js/JSCustomPositionErrorCallback.cpp: Removed.
        * bindings/js/JSCustomPositionErrorCallback.h: Removed.
        * bindings/js/JSDOMBinding.cpp:
        * bindings/js/JSDOMBinding.h:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::markDOMObjectWrapper):
        * bindings/js/JSGeolocationCustom.cpp: Removed.
        * bindings/js/JSNavigatorCustom.cpp:
        * dom/Document.cpp:
        (WebCore::Document::Document):
        * dom/Document.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::canCachePage):
        * page/Geolocation.cpp: Removed.
        * page/Geolocation.h: Removed.
        * page/Geolocation.idl: Removed.
        * page/Geoposition.cpp: Removed.
        * page/Geoposition.h: Removed.
        * page/Geoposition.idl: Removed.
        * page/Navigator.cpp:
        (WebCore::Navigator::disconnectFrame):
        * page/Navigator.h:
        * page/Navigator.idl:
        * page/PositionCallback.h: Removed.
        * page/PositionCallback.idl: Removed.
        * page/PositionError.h: Removed.
        * page/PositionError.idl: Removed.
        * page/PositionErrorCallback.h: Removed.
        * page/PositionErrorCallback.idl: Removed.
        * page/PositionOptions.h: Removed.
        * page/PositionOptions.idl: Removed.
        * platform/GeolocationService.cpp: Removed.
        * platform/GeolocationService.h: Removed.

LayoutTests:

        Rolled out r37840.

        * geolocation/geolocation-not-implemented-expected.txt: Removed.
        * geolocation/geolocation-not-implemented.html: Removed.
        * geolocation/geolocation-test.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Attempt to fix GTK build.
ddkilzer@apple.com [Fri, 24 Oct 2008 05:39:28 +0000 (05:39 +0000)]
    Attempt to fix GTK build.

        * GNUmakefile.am: Added new *.idl files that were missing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
ddkilzer@apple.com [Fri, 24 Oct 2008 05:05:47 +0000 (05:05 +0000)]
JavaScriptCore:

2008-10-23  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=21475

        Provide support for the Geolocation API

        http://dev.w3.org/geo/api/spec-source.html

        * wtf/Platform.h: ENABLE_GEOLOCATION defaults to 0

WebCore:

2008-10-23  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=21475

        Provide support for the Geolocation API

        http://dev.w3.org/geo/api/spec-source.html

        Test: geolocation/geolocation-not-implemented.html

        * DerivedSources.make:
        * GNUmakefile.am: Added Geolocation support
        * WebCore.pro: Added Geolocation support
        * WebCore.vcproj/WebCore.vcproj: Added Geolocation support
        * WebCore.xcodeproj/project.pbxproj: Added Geolocation support
        * WebCoreSources.bkl: Added Geolocation support
        * bindings/js/JSCustomPositionCallback.cpp: Added.
        (WebCore::JSCustomPositionCallback::JSCustomPositionCallback):
        (WebCore::JSCustomPositionCallback::handleEvent):
        * bindings/js/JSCustomPositionCallback.h: Added.
        (WebCore::JSCustomPositionCallback::create):
        * bindings/js/JSCustomPositionErrorCallback.cpp: Added.
        (WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback):
        (WebCore::JSCustomPositionErrorCallback::handleEvent):
        * bindings/js/JSCustomPositionErrorCallback.h: Added.
        (WebCore::JSCustomPositionErrorCallback::create):
        * bindings/js/JSDOMBinding.cpp: move markDOMObjectWrapper here from JSDOMWindowCustom
        (WebCore::markDOMObjectWrapper):
        * bindings/js/JSDOMBinding.h: move markDOMObjectWrapper here from JSDOMWindowCustom
        * bindings/js/JSDOMWindowCustom.cpp: move markDOMObjectWrapper to JSDOMBinding
        * bindings/js/JSGeolocationCustom.cpp: Added.
        (WebCore::JSGeolocation::getCurrentPosition):
        (WebCore::JSGeolocation::watchPosition):
        * bindings/js/JSNavigatorCustom.cpp: handle marking Geolocation
        (WebCore::JSNavigator::mark):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        * dom/Document.h:
        (WebCore::Document::setUsingGeolocation):
        (WebCore::Document::usingGeolocation):
        * loader/FrameLoader.cpp: don't add to back forward cache if using Geolocation
        (WebCore::FrameLoader::canCachePage):
        * page/Geolocation.cpp: Added.
        (WebCore::Geolocation::GeoNotifier::GeoNotifier):
        (WebCore::Geolocation::GeoNotifier::timerFired):
        (WebCore::Geolocation::Geolocation):
        (WebCore::Geolocation::disconnectFrame):
        (WebCore::Geolocation::getCurrentPosition):
        (WebCore::Geolocation::watchPosition):
        (WebCore::Geolocation::clearWatch):
        (WebCore::Geolocation::stopUpdatingIfEmpty):
        (WebCore::Geolocation::sendErrorToOneShots):
        (WebCore::Geolocation::sendErrorToWatchers):
        (WebCore::Geolocation::sendPositionToOneShots):
        (WebCore::Geolocation::sendPositionToWatchers):
        (WebCore::Geolocation::handleError):
        (WebCore::Geolocation::geolocationServicePositionChanged):
        (WebCore::Geolocation::geolocationServiceErrorOccurred):
        * page/Geolocation.h: Added.
        (WebCore::Geolocation::create):
        (WebCore::Geolocation::~Geolocation):
        (WebCore::Geolocation::lastPosition):
        (WebCore::Geolocation::GeoNotifier::create):
        * page/Geolocation.idl: Added.
        * page/Geoposition.cpp: Added.
        (WebCore::Geoposition::toString):
        * page/Geoposition.h: Added.
        (WebCore::Geoposition::create):
        (WebCore::Geoposition::latitude):
        (WebCore::Geoposition::longitude):
        (WebCore::Geoposition::altitude):
        (WebCore::Geoposition::accuracy):
        (WebCore::Geoposition::altitudeAccuracy):
        (WebCore::Geoposition::heading):
        (WebCore::Geoposition::velocity):
        (WebCore::Geoposition::timestamp):
        (WebCore::Geoposition::Geoposition):
        * page/Geoposition.idl: Added.
        * page/Navigator.cpp:
        (WebCore::Navigator::disconnectFrame): disconnect Geolocation
        (WebCore::Navigator::geolocation): accessor for Geolocation
        * page/Navigator.h:
        (WebCore::Navigator::optionalGeolocation): accessor for Geolocation
        * page/Navigator.idl: accessor for Geolocation
        * page/PositionCallback.h: Added.
        (WebCore::PositionCallback::~PositionCallback):
        * page/PositionCallback.idl: Added.
        * page/PositionError.h: Added.
        (WebCore::PositionError::):
        (WebCore::PositionError::create):
        (WebCore::PositionError::code):
        (WebCore::PositionError::message):
        (WebCore::PositionError::PositionError):
        * page/PositionError.idl: Added.
        * page/PositionErrorCallback.h: Added.
        (WebCore::PositionErrorCallback::~PositionErrorCallback):
        * page/PositionErrorCallback.idl: Added.
        * page/PositionOptions.h: Added.
        (WebCore::PositionOptions::create):
        (WebCore::PositionOptions::enableHighAccuracy):
        (WebCore::PositionOptions::setEnableHighAccuracy):
        (WebCore::PositionOptions::timeout):
        (WebCore::PositionOptions::setTimeout):
        (WebCore::PositionOptions::PositionOptions):
        * page/PositionOptions.idl: Added.
        * platform/GeolocationService.cpp: Added.
        (WebCore::GeolocationService::GeolocationService):
        (WebCore::GeolocationService::positionChanged):
        (WebCore::GeolocationService::errorOccurred):
        * platform/GeolocationService.h: Added.
        (WebCore::GeolocationServiceClient::~GeolocationServiceClient):
        (WebCore::GeolocationServiceClient::geolocationServicePositionChanged):
        (WebCore::GeolocationServiceClient::geolocationServiceErrorOccurred):
        (WebCore::GeolocationService::~GeolocationService):

LayoutTests:

2008-10-23  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=21475

        Provide support for the Geolocation API

        http://dev.w3.org/geo/api/spec-source.html

        Tests to verify Geolocation isn't implemented (so that it didn't leak into
        WebCore for platforms that do not support it).

        * geolocation: Added.
        * geolocation/geolocation-not-implemented-expected.txt: Added.
        * geolocation/geolocation-not-implemented.html: Added.
        * geolocation/geolocation-test.js: Added.
        (reset):
        (hanged):
        (watchPositionAndEnd):
        (watchPosition._positionCallback):
        (watchPosition):
        (watchPositionTestAndEnd):
        (watchPositionAndFail):
        (watchPositionAndTest._positionCallback):
        (watchPositionAndTest):
        (getCurrentPositionAndEnd):
        (getCurrentPosition._positionCallback):
        (getCurrentPosition):
        (getCurrentPositionTestAndEnd):
        (getCurrentPositionAndFail):
        (getCurrentPositionAndTest._positionCallback):
        (getCurrentPositionAndTest):
        (endTest):
        (relativeURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-23 Alp Toker <alp@nuanti.com>
alp@webkit.org [Fri, 24 Oct 2008 04:52:50 +0000 (04:52 +0000)]
2008-10-23  Alp Toker  <alp@nuanti.com>

        Fix typo in comment in previous commit. GTK -> GLIB

        * platform/gtk/guriescape.c:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-23 Kalle Vahlman <kalle.vahlman@movial.com>
alp@webkit.org [Fri, 24 Oct 2008 04:32:51 +0000 (04:32 +0000)]
2008-10-23  Kalle Vahlman  <kalle.vahlman@movial.com>

        Reviewed by Alp Toker.

        https://bugs.webkit.org/show_bug.cgi?id=21824
        [GTK] FileSystem abstraction uses features from Glib 2.16

        Wrap g_uri_unescape_string() to fix building with pre-2.16 Glib

        * platform/gtk/guriescape.c:
        (unescape_character):
        (_webcore_g_uri_unescape_segment):
        (_webcore_g_uri_unescape_string):
        * platform/gtk/guriescape.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-23 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Fri, 24 Oct 2008 03:44:10 +0000 (03:44 +0000)]
2008-10-23  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Fix Gtk build typo introduced in http://trac.webkit.org/changeset/37826.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-23 Darin Fisher <darin@chromium.org>
darin@chromium.org [Fri, 24 Oct 2008 01:04:33 +0000 (01:04 +0000)]
2008-10-23  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        m_frame null checked but then dereferenced
        https://bugs.webkit.org/show_bug.cgi?id=21845

        This error was found using a static analysis tool, and so I do not know
        how to produce a null m_frame on entry to this method.  Hence, I have
        not included a regression test.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::allowDHTMLDrag): Add an early return.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-23 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 24 Oct 2008 00:18:48 +0000 (00:18 +0000)]
2008-10-23  Kevin McCullough  <kmccullough@apple.com>

        Rubber stamped by Mark Rowe.

        -Skipping the profiler tests until we know why they fail on tiger:
        <rdar://problem/6316530> Profiler tests fail on tiger

        * platform/mac-tiger/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10
ddkilzer@apple.com [Thu, 23 Oct 2008 23:58:28 +0000 (23:58 +0000)]
    Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10

JavaScriptCore:

        Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10

        <https://bugs.webkit.org/show_bug.cgi?id=21832>

        Reviewed by Sam Weinig.

        * pcre/dftables: Use imported tempfile() from File::Temp instead of
        'new File::Temp' to make the script work with Perl 5.10.

WebKitTools:

        Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10

        <https://bugs.webkit.org/show_bug.cgi?id=21832>

        Reviewed by Sam Weinig.

        * Scripts/bisect-builds: Use imported tempfile() from File::Temp
        instead of 'new File::Temp' to make the script work with Perl 5.10.
        * Scripts/sort-Xcode-project-file: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-23 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Thu, 23 Oct 2008 22:29:54 +0000 (22:29 +0000)]
2008-10-23  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Fix hideous pathological case performance when looking up repatch info, bug #21727.

        When repatching JIT code to optimize we look up records providing information about
        the generated code (also used to track recsources used in linking to be later released).
        The lookup was being performed using a linear scan of all such records.

        (1) Split up the different types of reptach information.  This means we can search them
            separately, and in some cases should reduce their size.
        (2) In the case of property accesses, search with a binary chop over the data.
        (3) In the case of calls, pass a pointer to the repatch info into the relink function.

        * VM/CTI.cpp:
        (JSC::CTI::CTI):
        (JSC::CTI::compileOpCall):
        (JSC::CTI::privateCompileMainPass):
        (JSC::CTI::privateCompileSlowCases):
        (JSC::CTI::privateCompile):
        (JSC::CTI::unlinkCall):
        (JSC::CTI::linkCall):
        * VM/CTI.h:
        * VM/CodeBlock.cpp:
        (JSC::CodeBlock::dump):
        (JSC::CodeBlock::~CodeBlock):
        (JSC::CodeBlock::unlinkCallers):
        (JSC::CodeBlock::derefStructureIDs):
        * VM/CodeBlock.h:
        (JSC::StructureStubInfo::StructureStubInfo):
        (JSC::CallLinkInfo::CallLinkInfo):
        (JSC::CallLinkInfo::setUnlinked):
        (JSC::CallLinkInfo::isLinked):
        (JSC::getStructureStubInfoReturnLocation):
        (JSC::binaryChop):
        (JSC::CodeBlock::addCaller):
        (JSC::CodeBlock::getStubInfo):
        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::emitResolve):
        (JSC::CodeGenerator::emitGetById):
        (JSC::CodeGenerator::emitPutById):
        (JSC::CodeGenerator::emitCall):
        (JSC::CodeGenerator::emitConstruct):
        * VM/Machine.cpp:
        (JSC::Machine::cti_vm_lazyLinkCall):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-23 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Thu, 23 Oct 2008 22:12:18 +0000 (22:12 +0000)]
2008-10-23  Kevin McCullough  <kmccullough@apple.com>

        Forgot to remove the tests from the skipped lists, this should have been
        apart of the last checkin.

        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-23 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Thu, 23 Oct 2008 22:10:35 +0000 (22:10 +0000)]
2008-10-23  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=21817
        Bug 21817: Manual profiler tests should be made into layout tests

        - Added the expected results for the profiler tests and removed the
        tests from the skipped list.
        - Also removed two tests that were accidentally checked in previously.
        - Also changed the text on the tests to be more apparent how to run them
        manually.

        * fast/profiler/anonymous-event-handler-expected.txt: Added.
        * fast/profiler/anonymous-event-handler.html:
        * fast/profiler/anonymous-function-called-from-different-contexts-expected.txt: Added.
        * fast/profiler/anonymous-function-called-from-different-contexts.html:
        * fast/profiler/anonymous-function-calls-built-in-functions-expected.txt: Added.
        * fast/profiler/anonymous-function-calls-built-in-functions.html:
        * fast/profiler/anonymous-function-calls-eval-expected.txt: Added.
        * fast/profiler/anonymous-function-calls-eval.html:
        * fast/profiler/apply-expected.txt: Added.
        * fast/profiler/apply.html:
        * fast/profiler/built-in-function-calls-anonymous-expected.txt: Added.
        * fast/profiler/built-in-function-calls-anonymous.html:
        * fast/profiler/built-in-function-calls-user-defined-function-expected.txt: Added.
        * fast/profiler/built-in-function-calls-user-defined-function.html:
        * fast/profiler/call-expected.txt: Added.
        * fast/profiler/call-nodelist-as-function-expected.txt: Added.
        * fast/profiler/call-nodelist-as-function.html:
        * fast/profiler/call.html: Added.
        * fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope-expected.txt: Added.
        * fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html:
        * fast/profiler/compare-multiple-profiles-expected.txt: Added.
        * fast/profiler/compare-multiple-profiles.html:
        * fast/profiler/constructor-expected.txt: Added.
        * fast/profiler/constructor.html:
        * fast/profiler/dead-time-expected.txt: Added.
        * fast/profiler/dead-time.html:
        * fast/profiler/deep-recursion.html: Removed.
        * fast/profiler/document-dot-write-expected.txt: Added.
        * fast/profiler/document-dot-write.html:
        * fast/profiler/event-handler-expected.txt: Added.
        * fast/profiler/event-handler.html:
        * fast/profiler/execution-context-and-eval-on-same-line-expected.txt: Added.
        * fast/profiler/execution-context-and-eval-on-same-line.html:
        * fast/profiler/heavy-view-expected.txt: Added.
        * fast/profiler/heavy-view.html:
        * fast/profiler/inline-event-handler-expected.txt: Added.
        * fast/profiler/inline-event-handler.html:
        * fast/profiler/many-calls-in-the-same-scope-expected.txt: Added.
        * fast/profiler/many-calls-in-the-same-scope.html: Added.
        * fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt: Added.
        * fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html:
        * fast/profiler/multiple-and-different-scoped-function-calls-expected.txt: Added.
        * fast/profiler/multiple-and-different-scoped-function-calls.html:
        * fast/profiler/multiple-frames-expected.txt: Added.
        * fast/profiler/multiple-frames.html:
        * fast/profiler/multiple-windows.html: Removed.
        * fast/profiler/nested-anonymous-functon-expected.txt: Added.
        * fast/profiler/nested-anonymous-functon.html:
        * fast/profiler/nested-start-and-stop-profiler-expected.txt: Added.
        * fast/profiler/nested-start-and-stop-profiler.html:
        * fast/profiler/no-execution-context-expected.txt: Added.
        * fast/profiler/no-execution-context.html:
        * fast/profiler/one-execution-context-expected.txt: Added.
        * fast/profiler/one-execution-context.html:
        * fast/profiler/profile-calls-in-included-file-expected.txt: Added.
        * fast/profiler/profile-calls-in-included-file.html:
        * fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt: Added.
        * fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html:
        * fast/profiler/profiling-from-a-nested-location-expected.txt: Added.
        * fast/profiler/profiling-from-a-nested-location.html:
        * fast/profiler/simple-event-call-expected.txt: Added.
        * fast/profiler/simple-event-call.html:
        * fast/profiler/simple-no-level-change-expected.txt: Added.
        * fast/profiler/simple-no-level-change.html:
        * fast/profiler/start-and-stop-profiler-multiple-times-expected.txt: Added.
        * fast/profiler/start-and-stop-profiler-multiple-times.html:
        * fast/profiler/start-and-stop-profiling-in-the-same-function-expected.txt: Added.
        * fast/profiler/start-and-stop-profiling-in-the-same-function.html:
        * fast/profiler/start-but-dont-stop-profiling-expected.txt: Added.
        * fast/profiler/start-but-dont-stop-profiling.html:
        * fast/profiler/stop-profiling-after-setTimeout-expected.txt: Added.
        * fast/profiler/stop-profiling-after-setTimeout.html:
        * fast/profiler/stop-then-function-call-expected.txt: Added.
        * fast/profiler/stop-then-function-call.html:
        * fast/profiler/throw-exception-from-eval-expected.txt: Added.
        * fast/profiler/throw-exception-from-eval.html:
        * fast/profiler/two-execution-contexts-expected.txt: Added.
        * fast/profiler/two-execution-contexts.html:
        * fast/profiler/user-defined-function-calls-built-in-functions-expected.txt: Added.
        * fast/profiler/user-defined-function-calls-built-in-functions.html:
        * fast/profiler/window-dot-eval-expected.txt: Added.
        * fast/profiler/window-dot-eval.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Thu, 23 Oct 2008 21:56:03 +0000 (21:56 +0000)]
WebCore:

        Reviewed by Sam Weinig with no hesitation.

        - fix the HTML/CSS case of https://bugs.webkit.org/show_bug.cgi?id=19839
          <rdar://problem/6304805> A PDF,RLE sequence that should be a no-op affects bidi reordering

        Test: fast/text/bidi-embedding-pop-and-push-same.html

        * platform/text/BidiResolver.h:
        (WebCore::BidiResolver::embed): Changed to only add the embedding
        operation to a vector of pending operations.

        (WebCore::BidiResolver::lowerExplicitEmbeddingLevel): Added. Moved the
        code that used to be in the PDF case of embed() here, except the part
        that sets the context.

        (WebCore::BidiResolver::raiseExplicitEmbeddingLevel): Added. Moved the
        code that used to be in the non-PDF case of embed() here, except the
        part the sets the context.

        (WebCore::BidiResolver::commitExplicitEmbedding): Added. Processes the
        explicit embedding operations in the vector by creating an updated
        context and determining the old and new embedding levels. If the levels
        are not the same, calls {lower,raise}ExplicitEmbeddingLevel(). Always
        sets the context to the new one.

        (WebCore::BidiResolver::createBidiRunsForLine): Added calls to
        commitExplicitEmbedding() after calling embed() and after calling
        increment().

        * rendering/bidi.cpp:
        (WebCore::bidiFirst): Added calls to commitExplicitEmbedding() because
        this function increments the resolver.

        (WebCore::RenderBlock::skipLeadingWhitespace): Ditto.

LayoutTests:

        Reviewed by Sam Weinig with no hesitation.

        - test for the HTML/CSS case of https://bugs.webkit.org/show_bug.cgi?id=19839
          <rdar://problem/6304805> A PDF,RLE sequence that should be a no-op affects bidi reordering

        * fast/text/bidi-embedding-pop-and-push-same.html: Added.
        * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum: Added.
        * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.png: Added.
        * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix.
mrowe@apple.com [Thu, 23 Oct 2008 21:35:54 +0000 (21:35 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-23 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Thu, 23 Oct 2008 21:24:14 +0000 (21:24 +0000)]
2008-10-23  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk build fix. Not reviewed.

        Add DNSCurl and DNSSoup to the Gtk build

        * GNUmakefile.am:
        * platform/gtk/TemporaryLinkStubs.cpp:
        * platform/network/soup/DNSSoup.cpp: Copied from WebCore/platform/network/curl/DNSCurl.cpp.
        (WebCore::prefetchDNS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam Weinig.
eric@webkit.org [Thu, 23 Oct 2008 21:17:27 +0000 (21:17 +0000)]
    Reviewed by Sam Weinig.

        Un-break the Darwin build.

        * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
        * platform/graphics/cg/ImageCG.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-23 Darin Fisher <darin@chromium.org>
darin@chromium.org [Thu, 23 Oct 2008 21:13:50 +0000 (21:13 +0000)]
2008-10-23  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        Fix forward decls to be struct instead of class.
        https://bugs.webkit.org/show_bug.cgi?id=21838

        * rendering/style/StyleRareInheritedData.h:
        * rendering/style/StyleRareNonInheritedData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-23 Brent Fulgham <bfulgham@gmail.com>
weinig@apple.com [Thu, 23 Oct 2008 20:36:25 +0000 (20:36 +0000)]
2008-10-23  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Oliver Hunt.

        * platform/network/curl/ResourceRequest.h:  A better implementation
          of CFURLRequest, rather than void*.  This gives better compatibility
          with the WebKit.idl interface.
        (WebCore::ResourceRequest::cfURLRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-23 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Thu, 23 Oct 2008 20:28:51 +0000 (20:28 +0000)]
2008-10-23  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=21817
        Bug 21817: Manual profiler tests should be made into layout tests

        - Here are the changes to the tests.  The most significant part is the
        change to profiler-test-JS-resources.js where endTest will now notify
        the layout test controller if it was waiting and call the print function
        to iterate over all of the profiles and log their structure.
        - Most of these tests changed to include the layoutTestController, use
        endTest() or call the print function directly if there was some reason
        that they could not use endTest().

        * fast/profiler/resources/profiler-test-JS-resources.js:
        (endTest): Stop any waits and print the profile information.
        (printHeavyProfilesDataWithoutTime): Print all profile information in
        heavy view, without time.
        (printProfilesDataWithoutTime): Print all profile information in tree
        view, without time.
        (printProfileNodeWithoutTime): Print a profile node's informmation and
        all of it's children's information.
        * fast/profiler/anonymous-event-handler.html:
        * fast/profiler/anonymous-function-called-from-different-contexts.html:
        * fast/profiler/anonymous-function-calls-built-in-functions.html:
        * fast/profiler/anonymous-function-calls-eval.html:
        * fast/profiler/apply.html:
        * fast/profiler/built-in-function-calls-anonymous.html:
        * fast/profiler/built-in-function-calls-user-defined-function.html:
        * fast/profiler/call-nodelist-as-function.html:
        * fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html:
        * fast/profiler/compare-multiple-profiles.html:
        * fast/profiler/constructor.html:
        * fast/profiler/dead-time.html:
        * fast/profiler/deep-recursion.html:
        * fast/profiler/document-dot-write.html:
        * fast/profiler/event-handler.html:
        * fast/profiler/execution-context-and-eval-on-same-line.html:
        * fast/profiler/heavy-view.html:
        * fast/profiler/inline-event-handler.html:
        * fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html:
        * fast/profiler/multiple-and-different-scoped-function-calls.html:
        * fast/profiler/multiple-frames.html:
        * fast/profiler/nested-anonymous-functon.html:
        * fast/profiler/nested-start-and-stop-profiler.html:
        * fast/profiler/no-execution-context.html:
        * fast/profiler/one-execution-context.html:
        * fast/profiler/profile-calls-in-included-file.html:
        * fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html:
        * fast/profiler/profiling-from-a-nested-location.html:
        * fast/profiler/simple-event-call.html:
        * fast/profiler/simple-no-level-change.html:
        * fast/profiler/start-and-stop-profiler-multiple-times.html:
        * fast/profiler/start-and-stop-profiling-in-the-same-function.html:
        * fast/profiler/start-but-dont-stop-profiling.html:
        * fast/profiler/stop-profiling-after-setTimeout.html:
        * fast/profiler/stop-then-function-call.html:
        * fast/profiler/throw-exception-from-eval.html:
        * fast/profiler/two-execution-contexts.html:
        * fast/profiler/user-defined-function-calls-built-in-functions.html:
        * fast/profiler/window-dot-eval.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-23 Mike Pinkerton <pinkerton@chromium.org>
eric@webkit.org [Thu, 23 Oct 2008 19:59:42 +0000 (19:59 +0000)]
2008-10-23  Mike Pinkerton  <pinkerton@chromium.org>

        Reviewed by Eric Seidel.

        PLATFORM(CHROMIUM) uses CG the same way PLATFORM(MAC) does so fix
        ifdefs to reflect that.

        * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
        * platform/graphics/cg/ImageCG.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
pkasting@chromium.org [Thu, 23 Oct 2008 19:37:35 +0000 (19:37 +0000)]
JavaScriptCore:

2008-10-23  Peter Kasting  <pkasting@google.com>

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=21833
        Place JavaScript Debugger hooks under #if ENABLE(JAVASCRIPT_DEBUGGER).

        * wtf/Platform.h:

WebCore:

2008-10-23  Peter Kasting  <pkasting@google.com>

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=21833
        Place JavaScript Debugger hooks under #if ENABLE(JAVASCRIPT_DEBUGGER).

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::setWindowVisible):
        (WebCore::InspectorController::windowScriptObjectAvailable):
        (WebCore::InspectorController::close):
        * inspector/InspectorController.h:
        * page/Page.cpp:
        (WebCore::Page::Page):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Bug 21831: Fix create_hash_table for Perl 5.10
ddkilzer@apple.com [Thu, 23 Oct 2008 19:24:48 +0000 (19:24 +0000)]
    Bug 21831: Fix create_hash_table for Perl 5.10

        <https://bugs.webkit.org/show_bug.cgi?id=21831>

        Reviewed by Sam Weinig.

        * kjs/create_hash_table: Escaped square brackets so that Perl 5.10
        doesn't try to use @nameEntries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-23 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 23 Oct 2008 19:20:30 +0000 (19:20 +0000)]
2008-10-23  Darin Adler  <darin@apple.com>

        - try to get buildbot green again

        * platform/gtk/Skipped: Added fast/profiler.
        * platform/mac/Skipped: Fixed typo: fast/profiler, not fast/profile.
        * platform/qt/Skipped: Added fast/profiler.
        * platform/win/Skipped: Fixed typo: fast/profiler, not fast/profile.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-23 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Thu, 23 Oct 2008 18:43:43 +0000 (18:43 +0000)]
2008-10-23  Kevin McCullough  <kmccullough@apple.com>

        Forgot to actually check these files in from last time :(

        * fast/profiler: Added.
        * fast/profiler/anonymous-event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-event-handler.html.
        * fast/profiler/anonymous-function-called-from-different-contexts.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-called-from-different-contexts.html.
        * fast/profiler/anonymous-function-calls-built-in-functions.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-calls-built-in-functions.html.
        * fast/profiler/anonymous-function-calls-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html.
        * fast/profiler/apply.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-apply.html.
        * fast/profiler/built-in-function-calls-anonymous.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-built-in-function-calls-anonymous.html.
        * fast/profiler/built-in-function-calls-user-defined-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-built-in-function-calls-user-defined-function.html.
        * fast/profiler/call-nodelist-as-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-call-nodelist-as-function.html.
        * fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-calling-the-function-that-started-the-profiler-from-another-scope.html.
        * fast/profiler/compare-multiple-profiles.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-compare-multiple-profiles.html.
        * fast/profiler/constructor.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-constructor.html.
        * fast/profiler/dead-time.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-dead-time.html.
        * fast/profiler/deep-recursion.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-deep-recursion.html.
        * fast/profiler/document-dot-write.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-document-dot-write.html.
        * fast/profiler/event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-event-handler.html.
        * fast/profiler/execution-context-and-eval-on-same-line.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-execution-context-and-eval-on-same-line.html.
        * fast/profiler/heavy-view.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-heavy-view.html.
        * fast/profiler/inline-event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-inline-event-handler.html.
        * fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-and-different-scoped-anonymous-function-calls.html.
        * fast/profiler/multiple-and-different-scoped-function-calls.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-and-different-scoped-function-calls.html.
        * fast/profiler/multiple-frames.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-frames.html.
        * fast/profiler/multiple-windows.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-windows.html.
        * fast/profiler/nested-anonymous-functon.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-nested-anonymous-functon.html.
        * fast/profiler/nested-start-and-stop-profiler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html.
        * fast/profiler/no-execution-context.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-no-execution-context.html.
        * fast/profiler/one-execution-context.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-one-execution-context.html.
        * fast/profiler/profile-calls-in-included-file.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profile-calls-in-included-file.html.
        * fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html.
        * fast/profiler/profiling-from-a-nested-location.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profiling-from-a-nested-location.html.
        * fast/profiler/resources: Added.
        * fast/profiler/resources/other-frame.html: Copied from ../WebCore/manual-tests/inspector/resources/other-frame.html.
        * fast/profiler/resources/other-window.html: Copied from ../WebCore/manual-tests/inspector/resources/other-window.html.
        * fast/profiler/resources/profiler-test-JS-resources.js: Copied from ../WebCore/manual-tests/inspector/resources/profiler-test-JS-resources.js.
        * fast/profiler/simple-event-call.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-simple-event-call.html.
        * fast/profiler/simple-no-level-change.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-simple-no-level-change.html.
        * fast/profiler/start-and-stop-profiler-multiple-times.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-and-stop-profiler-multiple-times.html.
        * fast/profiler/start-and-stop-profiling-in-the-same-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-and-stop-profiling-in-the-same-function.html.
        * fast/profiler/start-but-dont-stop-profiling.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html.
        * fast/profiler/stop-profiling-after-setTimeout.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html.
        * fast/profiler/stop-then-function-call.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-stop-then-function-call.html.
        * fast/profiler/throw-exception-from-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-throw-exception-from-eval.html.
        * fast/profiler/two-execution-contexts.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-two-execution-contexts.html.
        * fast/profiler/user-defined-function-calls-built-in-functions.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-user-defined-function-calls-built-in-functions.html.
        * fast/profiler/window-dot-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-window-dot-eval.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
kmccullough@apple.com [Thu, 23 Oct 2008 18:33:46 +0000 (18:33 +0000)]
WebCore:

2008-10-23  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=21817
        Bug 21817: Manual profiler tests should be made into layout tests

        -Moving the tests before diffing so that it's clear what changed.

        * manual-tests/inspector/profiler-test-anonymous-event-handler.html: Removed.
        * manual-tests/inspector/profiler-test-anonymous-function-called-from-different-contexts.html: Removed.
        * manual-tests/inspector/profiler-test-anonymous-function-calls-built-in-functions.html: Removed.
        * manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html: Removed.
        * manual-tests/inspector/profiler-test-apply.html: Removed.
        * manual-tests/inspector/profiler-test-built-in-function-calls-anonymous.html: Removed.
        * manual-tests/inspector/profiler-test-built-in-function-calls-user-defined-function.html: Removed.
        * manual-tests/inspector/profiler-test-call-nodelist-as-function.html: Removed.
        * manual-tests/inspector/profiler-test-calling-the-function-that-started-the-profiler-from-another-scope.html: Removed.
        * manual-tests/inspector/profiler-test-compare-multiple-profiles.html: Removed.
        * manual-tests/inspector/profiler-test-constructor.html: Removed.
        * manual-tests/inspector/profiler-test-dead-time.html: Removed.
        * manual-tests/inspector/profiler-test-deep-recursion.html: Removed.
        * manual-tests/inspector/profiler-test-document-dot-write.html: Removed.
        * manual-tests/inspector/profiler-test-event-handler.html: Removed.
        * manual-tests/inspector/profiler-test-execution-context-and-eval-on-same-line.html: Removed.
        * manual-tests/inspector/profiler-test-heavy-view.html: Removed.
        * manual-tests/inspector/profiler-test-inline-event-handler.html: Removed.
        * manual-tests/inspector/profiler-test-multiple-and-different-scoped-anonymous-function-calls.html: Removed.
        * manual-tests/inspector/profiler-test-multiple-and-different-scoped-function-calls.html: Removed.
        * manual-tests/inspector/profiler-test-multiple-frames.html: Removed.
        * manual-tests/inspector/profiler-test-multiple-windows.html: Removed.
        * manual-tests/inspector/profiler-test-nested-anonymous-functon.html: Removed.
        * manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html: Removed.
        * manual-tests/inspector/profiler-test-no-execution-context.html: Removed.
        * manual-tests/inspector/profiler-test-one-execution-context.html: Removed.
        * manual-tests/inspector/profiler-test-profile-calls-in-included-file.html: Removed.
        * manual-tests/inspector/profiler-test-profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Removed.
        * manual-tests/inspector/profiler-test-profiling-from-a-nested-location.html: Removed.
        * manual-tests/inspector/profiler-test-simple-event-call.html: Removed.
        * manual-tests/inspector/profiler-test-simple-no-level-change.html: Removed.
        * manual-tests/inspector/profiler-test-start-and-stop-profiler-multiple-times.html: Removed.
        * manual-tests/inspector/profiler-test-start-and-stop-profiling-in-the-same-function.html: Removed.
        * manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html: Removed.
        * manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html: Removed.
        * manual-tests/inspector/profiler-test-stop-then-function-call.html: Removed.
        * manual-tests/inspector/profiler-test-throw-exception-from-eval.html: Removed.
        * manual-tests/inspector/profiler-test-two-execution-contexts.html: Removed.
        * manual-tests/inspector/profiler-test-user-defined-function-calls-built-in-functions.html: Removed.
        * manual-tests/inspector/profiler-test-window-dot-eval.html: Removed.
        * manual-tests/inspector/resources/other-frame.html: Removed.
        * manual-tests/inspector/resources/other-window.html: Removed.
        * manual-tests/inspector/resources/profiler-test-JS-resources.js: Removed.

LayoutTests:

2008-10-23  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=21817
        Bug 21817: Manual profiler tests should be made into layout tests

        -Moving the tests before diffing so that it's clear what changed.

        * platform/mac/Skipped: Skipping until the new files are in place.
        * platform/win/Skipped:
        * fast/profiler: Added.
        * fast/profiler/anonymous-event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-event-handler.html.
        * fast/profiler/anonymous-function-called-from-different-contexts.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-called-from-different-contexts.html.
        * fast/profiler/anonymous-function-calls-built-in-functions.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-calls-built-in-functions.html.
        * fast/profiler/anonymous-function-calls-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html.
        * fast/profiler/apply.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-apply.html.
        * fast/profiler/built-in-function-calls-anonymous.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-built-in-function-calls-anonymous.html.
        * fast/profiler/built-in-function-calls-user-defined-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-built-in-function-calls-user-defined-function.html.
        * fast/profiler/call-nodelist-as-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-call-nodelist-as-function.html.
        * fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-calling-the-function-that-started-the-profiler-from-another-scope.html.
        * fast/profiler/compare-multiple-profiles.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-compare-multiple-profiles.html.
        * fast/profiler/constructor.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-constructor.html.
        * fast/profiler/dead-time.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-dead-time.html.
        * fast/profiler/deep-recursion.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-deep-recursion.html.
        * fast/profiler/document-dot-write.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-document-dot-write.html.
        * fast/profiler/event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-event-handler.html.
        * fast/profiler/execution-context-and-eval-on-same-line.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-execution-context-and-eval-on-same-line.html.
        * fast/profiler/heavy-view.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-heavy-view.html.
        * fast/profiler/inline-event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-inline-event-handler.html.
        * fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-and-different-scoped-anonymous-function-calls.html.
        * fast/profiler/multiple-and-different-scoped-function-calls.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-and-different-scoped-function-calls.html.
        * fast/profiler/multiple-frames.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-frames.html.
        * fast/profiler/multiple-windows.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-windows.html.
        * fast/profiler/nested-anonymous-functon.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-nested-anonymous-functon.html.
        * fast/profiler/nested-start-and-stop-profiler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html.
        * fast/profiler/no-execution-context.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-no-execution-context.html.
        * fast/profiler/one-execution-context.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-one-execution-context.html.
        * fast/profiler/profile-calls-in-included-file.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profile-calls-in-included-file.html.
        * fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html.
        * fast/profiler/profiling-from-a-nested-location.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profiling-from-a-nested-location.html.
        * fast/profiler/resources: Added.
        * fast/profiler/resources/other-frame.html: Copied from ../WebCore/manual-tests/inspector/resources/other-frame.html.
        * fast/profiler/resources/other-window.html: Copied from ../WebCore/manual-tests/inspector/resources/other-window.html.
        * fast/profiler/resources/profiler-test-JS-resources.js: Copied from ../WebCore/manual-tests/inspector/resources/profiler-test-JS-resources.js.
        * fast/profiler/simple-event-call.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-simple-event-call.html.
        * fast/profiler/simple-no-level-change.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-simple-no-level-change.html.
        * fast/profiler/start-and-stop-profiler-multiple-times.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-and-stop-profiler-multiple-times.html.
        * fast/profiler/start-and-stop-profiling-in-the-same-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-and-stop-profiling-in-the-same-function.html.
        * fast/profiler/start-but-dont-stop-profiling.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html.
        * fast/profiler/stop-profiling-after-setTimeout.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html.
        * fast/profiler/stop-then-function-call.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-stop-then-function-call.html.
        * fast/profiler/throw-exception-from-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-throw-exception-from-eval.html.
        * fast/profiler/two-execution-contexts.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-two-execution-contexts.html.
        * fast/profiler/user-defined-function-calls-built-in-functions.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-user-defined-function-calls-built-in-functions.html.
        * fast/profiler/window-dot-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-window-dot-eval.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 23 Oct 2008 17:52:25 +0000 (17:52 +0000)]
2008-10-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by John Sullivan.

        Fix <rdar://problem/6306513> by adding a workaround for <rdar://problem/6304600>.

        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 23 Oct 2008 17:07:24 +0000 (17:07 +0000)]
2008-10-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=21826

        Add accessor for SecurityOrigin::m_domainWasSetInDOM.

        * page/SecurityOrigin.h:
        (WebCore::SecurityOrigin::domainWasSetInDOM):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix Bug 21401: Comments field on "Review Patch" page should be initially...
aroben@apple.com [Thu, 23 Oct 2008 16:49:56 +0000 (16:49 +0000)]
    Fix Bug 21401: Comments field on "Review Patch" page should be initially filled with quoted patch

        <https://bugs.webkit.org/show_bug.cgi?id=21401>

        Reviewed by Dave Hyatt.

        * attachment.cgi:
        (edit): Retrieve the attachment data from the database instead of just
        its length. When the attachment is a patch, create a quotedpatch
        template variable that contains the patch data with each line
        prepended with "> ".
        * template/en/custom/attachment/reviewform.html.tmpl:
          - Changed the comments field to have a monospace font
          - Added an "Enter comments below:" caption above the comments field
            to make it clearer that this is where comments should go, now that
            the comments field is not initially empty
          - Fill the comments field with the quoted patch

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
darin@apple.com [Thu, 23 Oct 2008 15:55:41 +0000 (15:55 +0000)]
JavaScriptCore:

2008-10-23  Darin Adler  <darin@apple.com>

        - roll out https://bugs.webkit.org/show_bug.cgi?id=21732
          to remove the JSValuePtr class, to fix two problems

            1) slowness under MSVC, since it doesn't handle a
               class with a single pointer in it as efficiently
               as a pointer

            2) uninitialized pointers in Vector

        * JavaScriptCore.exp: Updated.

        * API/APICast.h:
        (toRef):
        * VM/CTI.cpp:
        (JSC::CTI::asInteger):
        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::addConstant):
        * VM/CodeGenerator.h:
        (JSC::CodeGenerator::JSValueHashTraits::constructDeletedValue):
        (JSC::CodeGenerator::JSValueHashTraits::isDeletedValue):
        * VM/Machine.cpp:
        (JSC::Machine::cti_op_add):
        (JSC::Machine::cti_op_pre_inc):
        (JSC::Machine::cti_op_get_by_id):
        (JSC::Machine::cti_op_get_by_id_second):
        (JSC::Machine::cti_op_get_by_id_generic):
        (JSC::Machine::cti_op_get_by_id_fail):
        (JSC::Machine::cti_op_instanceof):
        (JSC::Machine::cti_op_del_by_id):
        (JSC::Machine::cti_op_mul):
        (JSC::Machine::cti_op_call_NotJSFunction):
        (JSC::Machine::cti_op_resolve):
        (JSC::Machine::cti_op_construct_NotJSConstruct):
        (JSC::Machine::cti_op_get_by_val):
        (JSC::Machine::cti_op_sub):
        (JSC::Machine::cti_op_lesseq):
        (JSC::Machine::cti_op_negate):
        (JSC::Machine::cti_op_resolve_base):
        (JSC::Machine::cti_op_resolve_skip):
        (JSC::Machine::cti_op_resolve_global):
        (JSC::Machine::cti_op_div):
        (JSC::Machine::cti_op_pre_dec):
        (JSC::Machine::cti_op_not):
        (JSC::Machine::cti_op_eq):
        (JSC::Machine::cti_op_lshift):
        (JSC::Machine::cti_op_bitand):
        (JSC::Machine::cti_op_rshift):
        (JSC::Machine::cti_op_bitnot):
        (JSC::Machine::cti_op_mod):
        (JSC::Machine::cti_op_less):
        (JSC::Machine::cti_op_neq):
        (JSC::Machine::cti_op_urshift):
        (JSC::Machine::cti_op_bitxor):
        (JSC::Machine::cti_op_bitor):
        (JSC::Machine::cti_op_call_eval):
        (JSC::Machine::cti_op_throw):
        (JSC::Machine::cti_op_next_pname):
        (JSC::Machine::cti_op_typeof):
        (JSC::Machine::cti_op_is_undefined):
        (JSC::Machine::cti_op_is_boolean):
        (JSC::Machine::cti_op_is_number):
        (JSC::Machine::cti_op_is_string):
        (JSC::Machine::cti_op_is_object):
        (JSC::Machine::cti_op_is_function):
        (JSC::Machine::cti_op_stricteq):
        (JSC::Machine::cti_op_nstricteq):
        (JSC::Machine::cti_op_to_jsnumber):
        (JSC::Machine::cti_op_in):
        (JSC::Machine::cti_op_del_by_val):
        (JSC::Machine::cti_vm_throw):
        Removed calls to payload functions.

        * VM/Register.h:
        (JSC::Register::Register): Removed overload for JSCell and call
        to payload function.

        * kjs/JSCell.h: Changed JSCell to derive from JSValue again.
        Removed JSValuePtr constructor.
        (JSC::asCell): Changed cast from reinterpret_cast to static_cast.

        * kjs/JSImmediate.h: Removed JSValuePtr class. Added typedef back.

        * kjs/JSValue.h:
        (JSC::JSValue::JSValue): Added empty protected inline constructor back.
        (JSC::JSValue::~JSValue): Same for destructor.
        Removed == and != operator for JSValuePtr.

        * kjs/PropertySlot.h:
        (JSC::PropertySlot::PropertySlot): Chnaged argument to const JSValue*
        and added a const_cast.

        * kjs/protect.h: Removed overloads and specialization for JSValuePtr.

JavaScriptGlue:

2008-10-23  Darin Adler  <darin@apple.com>

        - roll out https://bugs.webkit.org/show_bug.cgi?id=21732

        * JSValueWrapper.cpp:
        (JSValueWrapper::GetValue): Added missing call to .get().
        * JSValueWrapper.h: ProtectedPtr<JSValue> instead of ProtectedPtr<JSValuePtr>.

WebCore:

2008-10-23  Darin Adler  <darin@apple.com>

        - roll out https://bugs.webkit.org/show_bug.cgi?id=21732

        * bindings/js/ScheduledAction.h:
        * inspector/InspectorController.cpp:
        ProtectedPtr<JSValue> instead of ProtectedPtr<JSValuePtr>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-22 Yael Aharon <yael.aharon@nokia.com>
hausmann@webkit.org [Thu, 23 Oct 2008 13:27:06 +0000 (13:27 +0000)]
2008-10-22  Yael Aharon <yael.aharon@nokia.com>

        Reviewed by Simon Hausmann.

        emit scrollRequested unconditionally when scrolling.

        See https://bugs.webkit.org/show_bug.cgi?id=21790

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the ChangeLog after in r37761 I changed the wrong file accidentially.
hausmann@webkit.org [Thu, 23 Oct 2008 13:26:59 +0000 (13:26 +0000)]
Fix the ChangeLog after in r37761 I changed the wrong file accidentially.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-23 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Thu, 23 Oct 2008 13:18:18 +0000 (13:18 +0000)]
2008-10-23  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Tor Arne.

        Fix handling of mouse events when embedding QWebView into the
        QGraphicsView.

        QWebPage accepts or ignores events to indicate whether the web page
        handled the event. However for QWebView to behave like a good widget
        it should always accept the mouse events to indicate that it handled
        them and that they should not be subject to event propagation.

        The graphics view relies on acceptance of the initial mouse click to
        make the embedded widget the focus item.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-23 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Thu, 23 Oct 2008 12:27:41 +0000 (12:27 +0000)]
2008-10-23  Simon Hausmann  <hausmann@webkit.org>

        Fix the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Maciej Stachowiak.
ap@webkit.org [Thu, 23 Oct 2008 12:23:13 +0000 (12:23 +0000)]
    Reviewed by Maciej Stachowiak.

        Fix fast/events/message-port.html to not be timing-dependent (it was failing on some bots).

        * fast/events/message-port.html:
        * fast/events/message-port-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Maciej Stachowiak.
ap@webkit.org [Thu, 23 Oct 2008 10:15:55 +0000 (10:15 +0000)]
    Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=21825
        JSDOMBinding should not blindly cast the global object to JSDOMWindow

        * bindings/js/JSDOMGlobalObject.cpp:
        * bindings/js/JSDOMGlobalObject.h:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        Added JSDOMGlobalObject, a base class to be used by both Window and worker contexts.

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::getCachedDOMStructure):
        (WebCore::cacheDOMStructure):
        (WebCore::getCachedDOMConstructor):
        (WebCore::cacheDOMConstructor):
        Cast to JSDOMGlobalObject, as DOM objects live in DOM global objects.

        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::JSDOMWindowBase):
        * bindings/js/JSDOMWindowBase.h:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::mark):
        Moved constructor and structure tracking to JSDOMGlobalObject.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
abarth@webkit.org [Thu, 23 Oct 2008 09:43:34 +0000 (09:43 +0000)]
WebCore:

2008-10-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=21787

        Update postMessage to send origin = "null" for non-serializable
        origins to match latest spec.  Merge SecurityOrigin::toString and
        SecurityOrigin::toHTTPOrigin because they are now the same.

        Test: http/tests/security/postMessage/data-url-sends-null-origin.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::outgoingOrigin):
        (WebCore::FrameLoader::loadURL):
        (WebCore::FrameLoader::addHTTPOriginIfNeeded):
        (WebCore::FrameLoader::loadItem):
        * loader/loader.cpp:
        (WebCore::Loader::Host::servePendingRequests):
        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::toString):
        * page/SecurityOrigin.h:
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest):
        (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
        (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult):
        (WebCore::XMLHttpRequest::didReceiveResponsePreflight):

LayoutTests:

2008-10-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=21787

        Add test coverage for postMessaging from a data URL.

        * http/tests/security/postMessage/data-url-sends-null-origin-expected.txt: Added.
        * http/tests/security/postMessage/data-url-sends-null-origin.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReally "fix" CTI mode on windows 2k3.
oliver@apple.com [Thu, 23 Oct 2008 03:36:04 +0000 (03:36 +0000)]
Really "fix" CTI mode on windows 2k3.

Reviewed my Maciej Stachowiak

This adds new methods fastMallocExecutable and fastFreeExecutable
to wrap allocation for cti code.  This still just makes fastMalloc
return executable memory all the time, which will be fixed in a
later patch.

However in windows debug builds all executable allocations will be
allocated on separate executable pages, which should resolve any
remaining 2k3 issues.  Conveniently the 2k3 bot will now also fail
if there are any fastFree vs. fastFreeExecutable errors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Bug 21781: WebCore::Settings should have a maximum decoded image size setting
ddkilzer@apple.com [Thu, 23 Oct 2008 02:53:02 +0000 (02:53 +0000)]
    Bug 21781: WebCore::Settings should have a maximum decoded image size setting

        <https://bugs.webkit.org/show_bug.cgi?id=21781>

        Reviewed by Antti.

        No tests since there is no change in behavior.

        * loader/CachedImage.cpp:
        (WebCore::CachedImage::maximumDecodedImageSize): Added.  Returns
        WebCore::Settings::maximumDecodedImageSize() or 0 on error.
        (WebCore::CachedImage::data): Flag an error if the image being
        loaded is too big.
        * loader/CachedImage.h:
        (WebCore::CachedImage::maximumDecodedImageSize): Added declaration.
        * page/Settings.cpp:
        (WebCore::Settings::Settings): Initialize m_maximumDecodedImageSize
        to the maximum value of size_t.
        * page/Settings.h:
        (WebCore::Settings::setMaximumDecodedImageSize): Added method.
        (WebCore::Settings::maximumDecodedImageSize): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-22 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Thu, 23 Oct 2008 02:31:39 +0000 (02:31 +0000)]
2008-10-22  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Kevin McCullough.

        Check in changed test results for r37792.

        * fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-22 Mike Pinkerton <pinkerton@chromium.org>
darin@apple.com [Thu, 23 Oct 2008 01:43:37 +0000 (01:43 +0000)]
2008-10-22  Mike Pinkerton  <pinkerton@chromium.org>

        Reviewed by Dan Bernstein.
        Landed and tweaked a bit by Darin Adler.

        - fix https://bugs.webkit.org/show_bug.cgi?id=21809

        Remove PLATFORM(MAC) wrapping USE(ATSUI). It's redundant and inhibits
        its use for PLATFORM(CHROMIUM) in the future.

        * platform/graphics/SimpleFontData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
dsmith@webkit.org [Thu, 23 Oct 2008 00:49:27 +0000 (00:49 +0000)]
WebCore:

2008-10-22  David Smith  <catfish.man@gmail.com>

        Reviewed by andersca.

        https://bugs.webkit.org/show_bug.cgi?id=19974
        getElementsByClassName not live enough

        Test: fast/dom/getElementsByClassName/015.html

        * dom/StyledElement.cpp:
        (WebCore::StyledElement::classAttributeChanged): call dispatchSubtreeModifiedEvent()

LayoutTests:

2008-10-22  David Smith  <catfish.man@gmail.com>

        Reviewed by andersca.

        https://bugs.webkit.org/show_bug.cgi?id=19974
        getElementsByClassName not live enough

        * fast/dom/getElementsByClassName/015-expected.txt: Added.
        * fast/dom/getElementsByClassName/015.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
darin@apple.com [Thu, 23 Oct 2008 00:11:11 +0000 (00:11 +0000)]
JavaScriptCore:

2008-10-22  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        - fix https://bugs.webkit.org/show_bug.cgi?id=21294
          Bug 21294: Devirtualize getOwnPropertySlot()

        A bit over 3% faster on V8 tests.

        * JavascriptCore.exp: Export leak-related functions..

        * API/JSCallbackConstructor.h:
        (JSC::JSCallbackConstructor::createStructureID): Set HasStandardGetOwnPropertySlot
        since this class doesn't override getPropertySlot.
        * API/JSCallbackFunction.h:
        (JSC::JSCallbackFunction::createStructureID): Ditto.

        * VM/ExceptionHelpers.cpp:
        (JSC::InterruptedExecutionError::InterruptedExecutionError): Use a structure
        that's created just for this class instead of trying to share a single "null
        prototype" structure.

        * VM/Machine.cpp:
        (JSC::Machine::cti_op_create_arguments_no_params): Rename
        Arguments::ArgumentsNoParameters to Arguments::NoParameters.

        * kjs/Arguments.h: Rename the enum from Arguments::ArgumentsParameters to
        Arguments::NoParametersType and the value from Arguments::ArgumentsNoParameters
        to Arguments::NoParameters.
        (JSC::Arguments::createStructureID): Added. Returns a structure without
        HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
        (JSC::Arguments::Arguments): Added an assertion that there are no parameters.

        * kjs/DatePrototype.h:
        (JSC::DatePrototype::createStructureID): Added. Returns a structure without
        HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.

        * kjs/FunctionPrototype.h:
        (JSC::FunctionPrototype::createStructureID): Set HasStandardGetOwnPropertySlot
        since this class doesn't override getPropertySlot.
        * kjs/InternalFunction.h:
        (JSC::InternalFunction::createStructureID): Ditto.

        * kjs/JSArray.h:
        (JSC::JSArray::createStructureID): Added. Returns a structure without
        HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.

        * kjs/JSCell.h: Added declaration of fastGetOwnPropertySlot; a non-virtual
        version that uses the structure bit to decide whether to call the virtual
        version.

        * kjs/JSFunction.h:
        (JSC::JSFunction::createStructureID): Added. Returns a structure without
        HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.

        * kjs/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData): Initialize new structures; removed
        nullProtoStructureID.
        * kjs/JSGlobalData.h: Added new structures. Removed nullProtoStructureID.

        * kjs/JSGlobalObject.h:
        (JSC::JSGlobalObject::createStructureID): Added. Returns a structure without
        HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.

        * kjs/JSNotAnObject.h:
        (JSC::JSNotAnObjectErrorStub::JSNotAnObjectErrorStub): Use a structure
        that's created just for this class instead of trying to share a single "null
        prototype" structure.
        (JSC::JSNotAnObjectErrorStub::isNotAnObjectErrorStub): Marked this function
        virtual for clarity and made it private since no one should call it if they
        already have a pointer to this specific type.
        (JSC::JSNotAnObject::JSNotAnObject): Use a structure that's created just
        for this class instead of trying to share a single "null prototype" structure.
        (JSC::JSNotAnObject::createStructureID): Added. Returns a structure without
        HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.

        * kjs/JSObject.h:
        (JSC::JSObject::createStructureID): Added HasStandardGetOwnPropertySlot.
        (JSC::JSObject::inlineGetOwnPropertySlot): Added. Used so we can share code
        between getOwnPropertySlot and fastGetOwnPropertySlot.
        (JSC::JSObject::getOwnPropertySlot): Moved so that functions are above the
        functions that call them. Moved the guts of this function into
        inlineGetOwnPropertySlot.
        (JSC::JSCell::fastGetOwnPropertySlot): Added. Checks the
        HasStandardGetOwnPropertySlot bit and if it's set, calls
        inlineGetOwnPropertySlot, otherwise calls getOwnPropertySlot.
        (JSC::JSObject::getPropertySlot): Changed to call fastGetOwnPropertySlot.
        (JSC::JSValue::get): Changed to call fastGetOwnPropertySlot.

        * kjs/JSWrapperObject.h: Made constructor protected to emphasize that
        this class is only a base class and never instantiated.

        * kjs/MathObject.h:
        (JSC::MathObject::createStructureID): Added. Returns a structure without
        HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
        * kjs/NumberConstructor.h:
        (JSC::NumberConstructor::createStructureID): Ditto.
        * kjs/RegExpConstructor.h:
        (JSC::RegExpConstructor::createStructureID): Ditto.
        * kjs/RegExpObject.h:
        (JSC::RegExpObject::createStructureID): Ditto.
        * kjs/StringObject.h:
        (JSC::StringObject::createStructureID): Ditto.

        * kjs/TypeInfo.h: Added HasStandardGetOwnPropertySlot flag and
        hasStandardGetOwnPropertySlot accessor function.

JavaScriptGlue:

2008-10-22  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        - fix https://bugs.webkit.org/show_bug.cgi?id=21294
          Bug 21294: Devirtualize getOwnPropertySlot()

        * JSRun.cpp:
        (JSGlueGlobalObject::JSGlueGlobalObject): Moved constructor here.
        Set up flags in its new location in global object data, and set up
        a structure for UserObjectImp too.
        (JSRun::JSRun): Added code to give the JSGlueGlobalObject its own unique
        structure, rather than using the default one from JSGlobalObject.

        * JSRun.h: Made JSGlueGlobalObject take a structure ID. Also moved
        the data into a separate data object. And added userObjectStructure,
        a Structure to be used by UserObjectImp.

        * JSUtils.cpp: Removed unused sharedGlobalData global.
        (JSObjectKJSValue): Pass Structure in when creating UserObjectImp.
        (unprotectGlobalObject): Use JSGlueGLobalObject type specifically.
        (initializeGlobalObjectKey): Removed code to set up unused sharedGlobalData.
        (getThreadGlobalObject): Added. Shared by JSObjectKJSValue and
        getThreadGlobalExecState. Also now passes in a structure ID when creating
        the global object.
        (getThreadGlobalExecState): Changed to call getThreadGlobalObject.

        * UserObjectImp.cpp:
        (UserObjectImp::UserObjectImp): Changed to take a structure.
        * UserObjectImp.h:
        (UserObjectImp::createStructureID): Added. Returns a structure without
        HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.

WebCore:

2008-10-22  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        - fix https://bugs.webkit.org/show_bug.cgi?id=21294
          Bug 21294: Devirtualize getOwnPropertySlot()

        * bindings/js/JSDOMWindowShell.h:
        (WebCore::JSDOMWindowShell::createStructureID): Added. Returns a structure without
        HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.

        * bindings/js/JSInspectorCallbackWrapper.cpp:
        (WebCore::JSInspectorCallbackWrapper::wrap): Change to use a unique structure
        for this class rather than sharing nullProtoStructureID, which no longer exists.

        * bindings/js/JSNamedNodesCollection.h:
        (WebCore::JSNamedNodesCollection::createStructureID): Added. Returns a structure without
        HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
        * bindings/js/JSRGBColor.h:
        (WebCore::JSRGBColor::createStructureID): Ditto.

        * bindings/scripts/CodeGeneratorJS.pm: Added createStructureID functions for the wrappers,
        constructors, and prototypes in any case where they override getOwnPropertySlot, without
        HasStandardGetOwnPropertySlot.

        * bridge/objc/objc_runtime.h:
        (JSC::Bindings::ObjcFallbackObjectImp::createStructureID): Added. Returns a structure
        without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
        * bridge/qt/qt_runtime.h:
        (JSC::Bindings::QtRuntimeMethod::createStructureID): Ditto.
        * bridge/runtime_array.h:
        (JSC::RuntimeArray::createStructureID): Ditto.
        * bridge/runtime_method.h:
        (JSC::RuntimeMethod::createStructureID): Ditto.
        * bridge/runtime_object.h:
        (JSC::RuntimeObjectImp::createStructureID): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Bring Windows Cairo Port's font handling in line with CG.
aroben@apple.com [Wed, 22 Oct 2008 23:34:22 +0000 (23:34 +0000)]
    Bring Windows Cairo Port's font handling in line with CG.
        http://bugs.webkit.org/show_bug.cgi?id=21812.

        Reviewed by Adam Roben.

        * platform/graphics/win/FontCacheWin.cpp:
        (WebCore::createGDIFont): Remove unnecessary special-case for Cairo
        TrueType font search. It should match CG in all font selections.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
aroben@apple.com [Wed, 22 Oct 2008 23:33:58 +0000 (23:33 +0000)]
WebCore:

2008-10-22  Brent Fulgham  <bfulgham@gmail.com>

        Correct build regressions in Cairo port for Windows.
        http://bugs.webkit.org/show_bug.cgi?id=21724

        Reviewed by Adam Roben.

        * WebCore.vcproj/WebCore.vcproj:  Fixed include paths and post-build event for the Debug_Cairo and Release_Cairo configurations.
        * platform/graphics/win/GraphicsContextCairoWin.cpp:
        (WebCore::GraphicsContext::GraphicsContext): Update to newer constructor signature.
        * platform/network/curl/DNSCurl.cpp: Added.
        (WebCore::prefetchDNS):
        * platform/network/curl/ResourceRequest.h:
        * platform/win/ScrollbarThemeWin.cpp:
        (WebCore::ScrollbarTheme::nativeTheme):

WebKit/win:

2008-10-22  Brent Fulgham  <bfulgham@gmail.com>

        Correct build regressions in Cairo port for Windows.
        http://bugs.webkit.org/show_bug.cgi?id=21724

        Reviewed by Adam Roben.

        * WebView.cpp:
        (WebView::notifyPreferencesChanged): Don't try to call
        setShouldPaintNativeControls when SafariTheme support is disabled, as
        that function doesn't exist in that case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
beidson@apple.com [Wed, 22 Oct 2008 23:31:28 +0000 (23:31 +0000)]
LayoutTests:
2008-10-22  Brady Eidson  <beidson@apple.com>

        Reviewed by Adam Roben

        <rdar://6261773> - autocomplete="off" doesn't work on Windows

        Remove a skipped test that can now pass with proper DRT support

        * platform/win/Skipped: Remove security/autocomplete-cleared-on-back.html

WebKitTools:
2008-10-22  Brady Eidson  <beidson@apple.com>

        Reviewed by Adam Roben

        <rdar://6261773> - autocomplete="off" doesn't work on Windows

        Implement LayoutTestController::elementDoesAutoCompleteForElementWithId() on Windows

        * DumpRenderTree/win/LayoutTestControllerWin.cpp:

WebKit/win:
2008-10-22  Brady Eidson  <beidson@apple.com>

        Reviewed by Adam Roben

        Move elementDoesAutoComplete() to IWebFramePrivate so it is exposed for DRT to use

        * Interfaces/IWebFramePrivate.idl:

        * WebFrame.cpp:
        (WebFrame::elementDoesAutoComplete):
        * WebFrame.h:

        * WebHTMLRepresentation.cpp:
        (WebHTMLRepresentation::elementDoesAutoComplete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd a license to ElementsTreeOutline.js that was left off when it was split out from...
timothy@apple.com [Wed, 22 Oct 2008 23:12:44 +0000 (23:12 +0000)]
Add a license to ElementsTreeOutline.js that was left off when it was split out from ElementsPanel.js.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben
beidson@apple.com [Wed, 22 Oct 2008 23:06:53 +0000 (23:06 +0000)]
    Reviewed by Adam Roben

        <rdar://6261773> - autocomplete="off" doesn't work on Windows

        Visual Studio makes a poor decision regarding the combination of enums and bitfields, such that a
        statement like "m_autocomplete = Off" followed by "return m_autocomplete == Off" would return "false"
        instead of the much more correct "true."

        In the past we have worked around this by declaring the bitfield member as an unsigned instead
        of the enum type.

        For more discussion, see http://trac.webkit.org/changeset/25329

        * html/HTMLInputElement.h:  Work around insane Visual Studio enum issue  *sigh*

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-22 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Wed, 22 Oct 2008 23:05:23 +0000 (23:05 +0000)]
2008-10-22  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Oliver Hunt and Tim Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=19225
        Bug 19225: JSProfiler: Create automated profiler tests
        - This change exports profiles on the console object so that they can be
        iterated over via JavaScript, and thus can be used in automated tests.

        * bindings/js/JSConsoleCustom.cpp: Get the profiles and return an array
        that JS can use.
        (WebCore::JSConsole::profiles):
        * inspector/InspectorController.h: Use the new typedef.
        (WebCore::InspectorController::profiles):
        * page/Console.cpp: Keep our own array of profile objects.
        (WebCore::Console::profileEnd):
        * page/Console.h: Ditto.
        (WebCore::Console::profiles):
        * page/Console.idl: Expose the profiles to JS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-22 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Wed, 22 Oct 2008 23:04:00 +0000 (23:04 +0000)]
2008-10-22  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Oliver Hunt and Tim Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=19225
        Bug 19225: JSProfiler: Create automated profiler tests
        - This change exports profiles on the console object so that they can be
        iterated over via JavaScript, and thus can be used in automated tests.

        * bindings/js/JSConsoleCustom.cpp: Get the profiles and return an array
        that JS can use.
        (WebCore::JSConsole::profiles):
        * inspector/InspectorController.h: Use the new typedef.
        (WebCore::InspectorController::profiles):
        * page/Console.cpp: Keep our own array of profile objects.
        (WebCore::Console::profileEnd):
        * page/Console.h: Ditto.
        (WebCore::Console::profiles):
        * page/Console.idl: Expose the profiles to JS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-22 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 22 Oct 2008 21:51:23 +0000 (21:51 +0000)]
2008-10-22  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21775

        Convert buttons over to use the new Theme API on OS X.

        Reviewed by Adam Roben

        * platform/LengthBox.h:
        (WebCore::LengthBox::LengthBox):
        * platform/Theme.cpp:
        (WebCore::Theme::controlBorder):
        (WebCore::Theme::controlPadding):
        * platform/Theme.h:
        (WebCore::Theme::controlFont):
        (WebCore::Theme::controlSize):
        (WebCore::Theme::minControlSize):
        (WebCore::Theme::controlRequiresPreWhiteSpace):
        * platform/mac/ThemeMac.h:
        (WebCore::ThemeMac::controlRequiresPreWhiteSpace):
        * platform/mac/ThemeMac.mm:
        (WebCore::checkboxSize):
        (WebCore::radioSize):
        (WebCore::buttonSizes):
        (WebCore::buttonMargins):
        (WebCore::button):
        (WebCore::paintButton):
        (WebCore::ThemeMac::controlFont):
        (WebCore::ThemeMac::controlSize):
        (WebCore::ThemeMac::minControlSize):
        (WebCore::ThemeMac::controlBorder):
        (WebCore::ThemeMac::controlPadding):
        (WebCore::ThemeMac::inflateControlPaintRect):
        (WebCore::ThemeMac::paint):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::adjustStyle):
        (WebCore::RenderTheme::paint):
        (WebCore::RenderTheme::controlStatesForRenderer):
        (WebCore::RenderTheme::isDefault):
        (WebCore::RenderTheme::adjustRadioStyle):
        * rendering/RenderTheme.h:
        (WebCore::RenderTheme::setRadioSize):
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::adjustRepaintRect):
        (WebCore::menuListButtonSizes):
        (WebCore::RenderThemeMac::adjustMenuListStyle):
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::paddingBox):
        (WebCore::InheritedFlags::setPaddingBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-22 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Wed, 22 Oct 2008 21:06:30 +0000 (21:06 +0000)]
2008-10-22  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Geoff Garen.

        Bug 21803: Fuse op_jfalse with op_eq_null and op_neq_null
        <https://bugs.webkit.org/show_bug.cgi?id=21803>

        Fuse op_jfalse with op_eq_null and op_neq_null to make the new opcodes
        op_jeq_null and op_jneq_null.

        This is a 2.6% speedup on the V8 Raytrace benchmark, and strangely also
        a 4.7% speedup on the V8 Arguments benchmark, even though it uses
        neither of the two new opcodes.

        * VM/CTI.cpp:
        (JSC::CTI::privateCompileMainPass):
        * VM/CodeBlock.cpp:
        (JSC::CodeBlock::dump):
        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::emitJumpIfTrue):
        (JSC::CodeGenerator::emitJumpIfFalse):
        * VM/Machine.cpp:
        (JSC::Machine::privateExecute):
        * VM/Opcode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-22 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 22 Oct 2008 19:53:33 +0000 (19:53 +0000)]
2008-10-22  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        Moved tests from css3 to animations/transforms directories.

        * animations/change-keyframes-expected.txt: Renamed from LayoutTests/css3/change-keyframes-expected.txt.
        * animations/change-keyframes.html: Renamed from LayoutTests/css3/change-keyframes.html.
        * animations/keyframes-rule-expected.txt: Renamed from LayoutTests/css3/keyframes-rule-expected.txt.
        * animations/keyframes-rule.html: Renamed from LayoutTests/css3/keyframes-rule.html.
        * transforms/transform-value-types-expected.txt: Renamed from LayoutTests/css3/transform-value-types-expected.txt.
        * transforms/transform-value-types.html: Renamed from LayoutTests/css3/transform-value-types.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-22 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Wed, 22 Oct 2008 19:53:00 +0000 (19:53 +0000)]
2008-10-22  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon Hausmann.

        For public API, use the term boundingRect instead of boundingBox.

        * Api/qwebframe.cpp:
        (QWebHitTestResultPrivate::QWebHitTestResultPrivate):
        (QWebHitTestResult::boundingRect):
        * Api/qwebframe.h:
        * Api/qwebframe_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-22 Chris Marrin <cmarrin@apple.com>
simon.fraser@apple.com [Wed, 22 Oct 2008 19:35:52 +0000 (19:35 +0000)]
2008-10-22  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Dave Hyatt

        Make sure that the AtomicString that identifies a set of animation keyframes
        stays live by keeping a copy in the WebKitCSSKeyframesRule.

        Also call styleSheetChanged() when the keyframes name changes, but
        add an internal method that doesn't call styleSheetChanged() for use
        during normal stylesheet parsing.

        Test: animations/change-keyframes-name.html

        * css/CSSGrammar.y:
        * css/WebKitCSSKeyframesRule.cpp:
        (WebCore::WebKitCSSKeyframesRule::setName):
        * css/WebKitCSSKeyframesRule.h:
        (WebCore::WebKitCSSKeyframesRule::setNameInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-22 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 22 Oct 2008 18:32:14 +0000 (18:32 +0000)]
2008-10-22  Darin Adler  <darin@apple.com>

        * Scripts/do-webcore-rename: More renaming plans.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam Weinig.
ap@webkit.org [Wed, 22 Oct 2008 17:43:26 +0000 (17:43 +0000)]
    Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=21791
        WebCore JS bindings should be able to use non-static hash tables for properties

        Add a map for HashTables to WebCore JS client data.

        This makes property access noticeably slower, so it is an opt-in. For classes that need to be
        supported in workers in forseeable future this is not critical.

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::DOMObjectHashTableMap::get):
        (WebCore::DOMObjectHashTableMap::mapFor):
        (WebCore::getHashTableForGlobalData):
        (WebCore::DOMObjectWrapperMap::mapFor):
        WebCore client data is now a class that contains both a DOM wrapper map and a property hash
        table one.

        * bindings/js/JSDOMBinding.h: Added getHashTableForGlobalData() to query the hash table map.

        * bindings/scripts/CodeGeneratorJS.pm: If the class has a NoStaticTables attribute, use
        JSDOMBinding map to access its property hash tables.

        * dom/MessageChannel.idl:
        * dom/MessagePort.idl:
        Added NoStaticTables attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-22 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 22 Oct 2008 16:47:02 +0000 (16:47 +0000)]
2008-10-22  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        Should not define PLATFORM(WIN,MAC,GTK) when PLATFORM(CHROMIUM) is defined
        https://bugs.webkit.org/show_bug.cgi?id=21757

        PLATFORM(CHROMIUM) implies HAVE_ACCESSIBILITY

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-22 Alp Toker <alp@nuanti.com>
alp@webkit.org [Wed, 22 Oct 2008 16:16:44 +0000 (16:16 +0000)]
2008-10-22  Alp Toker  <alp@nuanti.com>

        Build fix for older GTK+ versions where GTK_TYPE_TARGET_LIST isn't
        defined.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-22 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Wed, 22 Oct 2008 14:24:24 +0000 (14:24 +0000)]
2008-10-22  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Alexey Proskuryakov.

        Correct opcode names in documentation.

        * VM/Machine.cpp:
        (JSC::Machine::privateExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-22 Gustavo Noronha Silva <gns@gnome.org>
alp@webkit.org [Wed, 22 Oct 2008 13:55:06 +0000 (13:55 +0000)]
2008-10-22  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Timothy Hatcher.

        Build failure because of missing include
        https://bugs.webkit.org/show_bug.cgi?id=21765

        Build failure fix for WebKit/GTK+; added missing
        include (GOwnPtr.h)

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-22 Alp Toker <alp@nuanti.com>
alp@webkit.org [Wed, 22 Oct 2008 13:51:16 +0000 (13:51 +0000)]
2008-10-22  Alp Toker  <alp@nuanti.com>

        Reviewed by Adam Roben.

        Fix crashes on older GTK+ versions (2.8). gtk_widget_style_get()
        doesn't initialize values if the requested property doesn't exist, so
        initialize the values to the documented defaults before calling it
        where necessary. Additionally, avoid critical warnings by not calling
        gtk_widget_style_get() when we know the property isn't available.

        Note that this is an imported source file which doesn't follow the
        WebKit coding style.

        Avoid critical warnings on older GTK+ versions (2.8) by not checking
        for GTK+ setting properties when we know they don't exist.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-22 Alp Toker <alp@nuanti.com>
alp@webkit.org [Wed, 22 Oct 2008 10:38:23 +0000 (10:38 +0000)]
2008-10-22  Alp Toker  <alp@nuanti.com>

        Fix build for Cairo 1.2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-22 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 22 Oct 2008 07:56:41 +0000 (07:56 +0000)]
2008-10-22  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        A little more PLATFORM(CHROMIUM) in WebCore
        https://bugs.webkit.org/show_bug.cgi?id=21758

        * page/AccessibilityObject.h:
        * platform/graphics/Icon.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-22 Jungshik Shin <jshin@chromium.org>
abarth@webkit.org [Wed, 22 Oct 2008 07:54:57 +0000 (07:54 +0000)]
2008-10-22  Jungshik Shin  <jshin@chromium.org>

        Reviewed by Alexey Proskuryakov.
        Landed by Adam Barth.

        - https://bugs.webkit.org/show_bug.cgi?id=21581

        Replace x-mac-cyrillic by windows-1256.

        * http/tests/misc/frame-default-enc-same-domain-expected.txt:
        * http/tests/misc/frame-default-enc-same-domain.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAttempt to make the win2k3 bot be more useful for testing
oliver@apple.com [Wed, 22 Oct 2008 06:49:28 +0000 (06:49 +0000)]
Attempt to make the win2k3 bot be more useful for testing

RS=Maciej Stachowiak.

Force FastMalloc to make all allocated pages executable in
a vague hope this will allow the Win2k3 bot to be able to
run tests.

Filed Bug 21783: Need more granular control over allocation of executable memory
to cover a more granular version of this patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
ap@webkit.org [Wed, 22 Oct 2008 06:07:32 +0000 (06:07 +0000)]
    Reviewed by Darin Adler.

        Test: fast/events/message-channel-gc-3.html

        https://bugs.webkit.org/show_bug.cgi?id=21769
        MessagePort should be GC protected if there are messages to be delivered

        * dom/MessagePort.h: Removed pending activity count. Now we track if a close event is
        pending, and check if the queue is non-empty.
        (WebCore::MessagePort::workerContext): Added a stub implementation for a cross-heap GC bug
        fix (below).

        * dom/MessagePort.cpp:
        (WebCore::CloseMessagePortTimer::fired):
        (WebCore::MessagePort::MessagePort):
        (WebCore::MessagePort::queueCloseEvent):
        (WebCore::MessagePort::dispatchCloseEvent):
        (WebCore::MessagePort::hasPendingActivity):
        Track message and close event activity separately.

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::markCrossHeapDependentObjectsForDocument): Fixed a bug in cross-heap GC that was
        causing same-heap ports to never be deleted.

        * wtf/MessageQueue.h:
        (WTF::::isEmpty): Added. Also added a warning for methods that return a snapshot of queue
        state, thus likely to cause race conditions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam Weinig.
mitz@apple.com [Wed, 22 Oct 2008 03:10:23 +0000 (03:10 +0000)]
    Reviewed by Sam Weinig.

        - remove unreachable code

        * platform/text/BidiResolver.h:
        (WebCore::::embed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-21 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Wed, 22 Oct 2008 00:41:05 +0000 (00:41 +0000)]
2008-10-21  Steve Falkenburg  <sfalken@apple.com>

        Exclude strings marked with UNLOCALIZED_STRING or UNLOCALIZED_LPCTSTR.

        * Scripts/extract-localizable-strings:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-21 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Wed, 22 Oct 2008 00:22:55 +0000 (00:22 +0000)]
2008-10-21  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin Adler.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=20352
        REGRESSION(r31030-31055): Choosing "Print window" from frame set
        prints blank page
        and corresponding: <rdar://problem/6142398>

        viewHeight() and viewWidth() only return valuable information if we
        are not printing. Everywhere else in the code, we make sure we are
        not printing before we call these functions. Adding a check for
        printing here fixes this bug, and framesets print again.

        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-03 Siraj Razick <siraj.razick@collabora.co.uk>
hausmann@webkit.org [Tue, 21 Oct 2008 22:33:10 +0000 (22:33 +0000)]
2008-06-03  Siraj Razick  <siraj.razick@collabora.co.uk>

        Reviewed by Simon Hausmann.

        https://bugs.webkit.org/show_bug.cgi?id=19374

        Expose boundingBox value in QWebHitTestResult

        Add API function QRect QWebHitResult::boundingBox() const

        API docs by Ariya.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-21 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 21 Oct 2008 21:29:31 +0000 (21:29 +0000)]
2008-10-21  Darin Adler  <darin@apple.com>

        Reviewed by Maciej Stachowiak.

        - convert post-increment to pre-increment in a couple more places for speed

        Speeds up V8 benchmarks a little on most computers. (But, strangely, slows
        them down a little on my computer.)

        * kjs/nodes.cpp:
        (JSC::statementListEmitCode): Removed default argument, since we always want
        to specify this explicitly.
        (JSC::ForNode::emitCode): Tolerate ignoredResult() as the dst -- means the
        same thing as 0.
        (JSC::ReturnNode::emitCode): Ditto.
        (JSC::ThrowNode::emitCode): Ditto.
        (JSC::FunctionBodyNode::emitCode): Pass ignoredResult() so that we know we
        don't have to compute the result of function statements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-21 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Tue, 21 Oct 2008 21:09:15 +0000 (21:09 +0000)]
2008-10-21  Peter Kasting  <pkasting@google.com>

        Reviewed by Maciej Stachowiak.

        Fix an include of a non-public header to use "" instead of <>.

        * API/JSProfilerPrivate.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-21 Yael <yael.aharon@nokia.com>
hausmann@webkit.org [Tue, 21 Oct 2008 17:27:18 +0000 (17:27 +0000)]
2008-10-21  Yael  <yael.aharon@nokia.com>

        Reviewed by Simon Hausmann.

        emit repaintRequested unconditionally when repaint is requested.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-21 Yael Aharon <yael.aharon@nokia.com>
hausmann@webkit.org [Tue, 21 Oct 2008 12:57:35 +0000 (12:57 +0000)]
2008-10-21  Yael Aharon <yael.aharon@nokia.com>

        Reviewed by Simon.

        Pixmap in canvas tag was not getting initialized.

        See https://bugs.webkit.org/show_bug.cgi?id=21771

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
weinig@apple.com [Tue, 21 Oct 2008 06:08:06 +0000 (06:08 +0000)]
JavaScriptCore:

2008-10-20  Sam Weinig  <sam@webkit.org>

        Reviewed by Cameron Zwarich.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=21766
        REGRESSION: 12 JSC tests fail

        The JSGlobalObject was mutating the shared nullProtoStructureID when
        used in jsc.  Instead of using nullProtoStructureID, use a new StructureID.

        * API/JSCallbackObject.h:
        * API/JSCallbackObjectFunctions.h:
        (JSC::::JSCallbackObject):
        * API/JSContextRef.cpp:
        (JSGlobalContextCreateInGroup):
        * kjs/JSGlobalObject.h:
        (JSC::JSGlobalObject::JSGlobalObject):
        * kjs/Shell.cpp:
        (GlobalObject::GlobalObject):
        (jscmain):

JavaScriptGlue:

2008-10-20  Sam Weinig  <sam@webkit.org>

        Reviewed by Cameron Zwarich.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=21766
        REGRESSION: 12 JSC tests fail

        The JSGlobalObject constructor no longer takes a JSGlobalData
        as an argument.

        * JSRun.cpp:
        (JSRun::JSRun):
        * JSRun.h:
        (JSGlueGlobalObject::JSGlueGlobalObject):
        * JSUtils.cpp:
        (getThreadGlobalExecState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-20 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 21 Oct 2008 06:01:03 +0000 (06:01 +0000)]
2008-10-20  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein

        Add a comment explaining layoutDelta(), and an assertion
        that checks that delta changes were correctly paired during layout.

        * rendering/RenderView.cpp:
        (WebCore::RenderView::layout):
        * rendering/RenderView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Make auto-complete only suggest properties that are valid syntax
timothy@apple.com [Tue, 21 Oct 2008 04:50:34 +0000 (04:50 +0000)]
    Make auto-complete only suggest properties that are valid syntax
        when using dot-notation. Also when completing numeric properties,
        the quotes are omitted inside the brackets.

        https://bugs.webkit.org/show_bug.cgi?id=21760
        https://bugs.webkit.org/show_bug.cgi?id=21761

        Reviewed by Oliver Hunt.

        * inspector/front-end/Console.js:
        (WebInspector.Console.prototype.completions): Skip properties that
        are not valid identifies when using dot-notation. And omit the quotes
        when completing numbers in bracket-notation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fixes the Profiles panel in the Web Inspector, which was broken by
timothy@apple.com [Tue, 21 Oct 2008 04:50:24 +0000 (04:50 +0000)]
    Fixes the Profiles panel in the Web Inspector, which was broken by
        the JSValue base-class changes. Also renames some functions and
        variables in JavaScriptProfileNode.cpp that where title case.

        https://bugs.webkit.org/show_bug.cgi?id=21764

        Reviewed by Oliver Hunt.

        * inspector/JavaScriptProfile.cpp:
        (WebCore::toJS): Use a JSObject pointer instead of JSValuePtr so the
        returned JSValuePtr will be treated as an object and not a value.
        * inspector/JavaScriptProfileNode.cpp:
        (WebCore::toJS): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-20 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Tue, 21 Oct 2008 02:45:57 +0000 (02:45 +0000)]
2008-10-20  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Maciej Stachowiak.

        Remove an untaken branch in CodeGenerator::emitJumpIfFalse(). This
        function is never called with a backwards target LabelID, and there is
        even an assertion to this effect at the top of the function body.

        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::emitJumpIfFalse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Tue, 21 Oct 2008 02:14:45 +0000 (02:14 +0000)]
WebCore:

2008-10-20  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Remove FrameLoaderClient::detachedFromParent4.  It is no longer used by any port.

        * loader/EmptyClients.h:
        (WebCore::EmptyFrameLoaderClient::detachedFromParent4):.
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::detachFromParent):
        * loader/FrameLoaderClient.h:

WebKit/gtk:

2008-10-20  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Remove FrameLoaderClient::detachedFromParent4.  It is no longer used by any port.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        * WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

2008-10-20  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Remove FrameLoaderClient::detachedFromParent4.  It is no longer used by any port.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:

WebKit/qt:

2008-10-20  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Remove FrameLoaderClient::detachedFromParent4.  It is no longer used by any port.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        * WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

2008-10-20  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Remove FrameLoaderClient::detachedFromParent4.  It is no longer used by any port.

        * WebFrame.cpp:
        * WebFrame.h:

WebKit/wx:

2008-10-20  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Remove FrameLoaderClient::detachedFromParent4.  It is no longer used by any port.

        * WebKitSupport/FrameLoaderClientWx.cpp:
        * WebKitSupport/FrameLoaderClientWx.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-20 Antti Koivisto <antti@apple.com>
antti@apple.com [Tue, 21 Oct 2008 01:22:51 +0000 (01:22 +0000)]
2008-10-20  Antti Koivisto  <antti@apple.com>

        Reviewed by Adele Peterson.

        Fix https://bugs.webkit.org/show_bug.cgi?id=21763
        REGRESSION (r36108-r36113): Can't load picture content on wired.com galleries
        <rdar://problem/6285025

        If we get 304 response we need to explicitly check if that completes the frame load.

        No test case, simulating the condition is pretty difficult.

        * loader/loader.cpp:
        (WebCore::Loader::Host::didReceiveResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-20 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 21 Oct 2008 01:05:19 +0000 (01:05 +0000)]
2008-10-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark Rowe.

        Work around <rdar://problem/6301728>.

        Don't assert that loads are deferred when we're using CFNetwork on Mac or Windows.

        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::didReceiveResponse):
        (WebCore::MainResourceLoader::didReceiveData):
        (WebCore::MainResourceLoader::didFinishLoading):
        (WebCore::MainResourceLoader::didFail):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-20 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Tue, 21 Oct 2008 00:20:30 +0000 (00:20 +0000)]
2008-10-20  Cameron Zwarich  <zwarich@apple.com>

        Not reviewed.

        Update the ChangeLog for previous commit to contain meaningful
        information.

        * ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-20 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Tue, 21 Oct 2008 00:10:01 +0000 (00:10 +0000)]
2008-10-20  Cameron Zwarich  <zwarich@apple.com>

        Rubber-stamped by Sam Weinig.

        * VM/Machine.cpp:
        (JSC::Machine::privateExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-20 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Mon, 20 Oct 2008 22:47:19 +0000 (22:47 +0000)]
2008-10-20  Beth Dakin  <bdakin@apple.com>

        Reviewed by Adele Peterson.

        Speculative fix for <rdar://problem/6242585> CrashTracer: [USER] 19
        crashes in Safari at com.apple.WebCore
        WebCore::ScrollView::visibleContentRect const + 153

        d->m_view can be null and is null-checked at other points in the
        code. The logs indicate that this crash occurs when closing a
        window containing a PDF, so in case where we crash, the PDF's view
        is probably already null. So the fix is to simply add a null-check.

        * page/Frame.cpp:
        (WebCore::Frame::selectionRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-20 Adele Peterson <adele@apple.com>
adele@apple.com [Mon, 20 Oct 2008 21:31:08 +0000 (21:31 +0000)]
2008-10-20  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
        Removed stray increment that would screw up any form with multiple files in it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-16 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 20 Oct 2008 21:27:44 +0000 (21:27 +0000)]
2008-10-16  Sam Weinig  <sam@webkit.org>

        Reviewed by Cameron Zwarich.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=21683
        Don't create intermediate StructureIDs for builtin objects

        Second stage in reduce number of StructureIDs created when initializing the
        JSGlobalObject.

        - Use putDirectWithoutTransition for the remaining singleton objects to reduce
          the number of StructureIDs create for about:blank from 132 to 73.

        * kjs/ArrayConstructor.cpp:
        (JSC::ArrayConstructor::ArrayConstructor):
        * kjs/BooleanConstructor.cpp:
        (JSC::BooleanConstructor::BooleanConstructor):
        * kjs/BooleanPrototype.cpp:
        (JSC::BooleanPrototype::BooleanPrototype):
        * kjs/DateConstructor.cpp:
        (JSC::DateConstructor::DateConstructor):
        * kjs/ErrorConstructor.cpp:
        (JSC::ErrorConstructor::ErrorConstructor):
        * kjs/ErrorPrototype.cpp:
        (JSC::ErrorPrototype::ErrorPrototype):
        * kjs/FunctionConstructor.cpp:
        (JSC::FunctionConstructor::FunctionConstructor):
        * kjs/FunctionPrototype.cpp:
        (JSC::FunctionPrototype::FunctionPrototype):
        (JSC::FunctionPrototype::addFunctionProperties):
        * kjs/FunctionPrototype.h:
        (JSC::FunctionPrototype::createStructureID):
        * kjs/InternalFunction.cpp:
        * kjs/InternalFunction.h:
        (JSC::InternalFunction::InternalFunction):
        * kjs/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::reset):
        * kjs/JSObject.h:
        * kjs/MathObject.cpp:
        (JSC::MathObject::MathObject):
        * kjs/NumberConstructor.cpp:
        (JSC::NumberConstructor::NumberConstructor):
        * kjs/NumberPrototype.cpp:
        (JSC::NumberPrototype::NumberPrototype):
        * kjs/ObjectConstructor.cpp:
        (JSC::ObjectConstructor::ObjectConstructor):
        * kjs/RegExpConstructor.cpp:
        (JSC::RegExpConstructor::RegExpConstructor):
        * kjs/RegExpPrototype.cpp:
        (JSC::RegExpPrototype::RegExpPrototype):
        * kjs/StringConstructor.cpp:
        (JSC::StringConstructor::StringConstructor):
        * kjs/StringPrototype.cpp:
        (JSC::StringPrototype::StringPrototype):
        * kjs/StructureID.cpp:
        (JSC::StructureID::dumpStatistics):
        * kjs/StructureID.h:
        (JSC::StructureID::setPrototypeWithoutTransition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-20 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 20 Oct 2008 20:42:46 +0000 (20:42 +0000)]
2008-10-20  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by David Hyatt.

        Split LengthBox and LengthSize into their own files.

        * GNUmakefile.am:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/Length.h:
        (WebCore::Length::blend):
        * platform/LengthBox.h: Copied from platform/Length.h.
        (WebCore::LengthBox::LengthBox):
        (WebCore::LengthBox::nonZero):
        * platform/LengthSize.h: Copied from platform/Length.h.
        (WebCore::LengthSize::LengthSize):
        (WebCore::LengthSize::setWidth):
        (WebCore::LengthSize::setHeight):
        (WebCore::LengthSize::height):
        * platform/Theme.h:
        * rendering/style/FillLayer.h:
        * rendering/style/NinePieceImage.h:
        (WebCore::NinePieceImage::NinePieceImage):
        * rendering/style/RenderStyle.h:
        * rendering/style/StyleDashboardRegion.h:
        * rendering/style/StyleSurroundData.h:
        * rendering/style/StyleVisualData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - Mac build fix
mitz@apple.com [Mon, 20 Oct 2008 20:15:27 +0000 (20:15 +0000)]
    - Mac build fix

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-20 Alp Toker <alp@nuanti.com>
alp@webkit.org [Mon, 20 Oct 2008 19:30:26 +0000 (19:30 +0000)]
2008-10-20  Alp Toker  <alp@nuanti.com>

        Fix autotools dist build target by listing recently added header
        files only. Not reviewed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-20 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 20 Oct 2008 19:27:58 +0000 (19:27 +0000)]
2008-10-20  David Hyatt  <hyatt@apple.com>

        Clean up some USE(NEW_THEME) ifdefs (I botched one of them and have broken non-Mac platforms).  Also
        refactor some of the code that I put in ThemeMac to be cross-platform, since it was in RenderTheme.cpp
        originally.

        ifdef some methods in RenderTheme.cpp also that are no longer needed with the new Theme.

        Reviewed by Adam Roben

        * WebCore.xcodeproj/project.pbxproj:
        * platform/Theme.cpp: Added.
        (WebCore::Theme::controlSupportsBorder):
        (WebCore::Theme::controlSupportsPadding):
        * platform/Theme.h:
        * platform/mac/ThemeMac.h:
        * platform/mac/ThemeMac.mm:
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::adjustStyle):
        * rendering/RenderTheme.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-20 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 20 Oct 2008 19:18:38 +0000 (19:18 +0000)]
2008-10-20  David Hyatt  <hyatt@apple.com>

        Rename LengthBox's members to have m_ in front of them.

        Reviewed by Sam Weinig

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::valueForNinePieceImage):
        (WebCore::getPositionOffsetValue):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::mapNinePieceImage):
        * platform/Length.h:
        (WebCore::LengthBox::LengthBox):
        (WebCore::LengthBox::left):
        (WebCore::LengthBox::right):
        (WebCore::LengthBox::top):
        (WebCore::LengthBox::bottom):
        (WebCore::LengthBox::operator==):
        (WebCore::LengthBox::nonZero):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::paintNinePieceImage):
        (WebCore::RenderObject::addDashboardRegions):
        * rendering/style/RenderStyle.cpp:
        (WebCore::positionedObjectMoved):
        (WebCore::RenderStyle::setClip):
        (WebCore::RenderStyle::noneDashboardRegions):
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::left):
        (WebCore::InheritedFlags::right):
        (WebCore::InheritedFlags::top):
        (WebCore::InheritedFlags::bottom):
        (WebCore::InheritedFlags::clipLeft):
        (WebCore::InheritedFlags::clipRight):
        (WebCore::InheritedFlags::clipTop):
        (WebCore::InheritedFlags::clipBottom):
        (WebCore::InheritedFlags::marginTop):
        (WebCore::InheritedFlags::marginBottom):
        (WebCore::InheritedFlags::marginLeft):
        (WebCore::InheritedFlags::marginRight):
        (WebCore::InheritedFlags::paddingTop):
        (WebCore::InheritedFlags::paddingBottom):
        (WebCore::InheritedFlags::paddingLeft):
        (WebCore::InheritedFlags::paddingRight):
        (WebCore::InheritedFlags::setLeft):
        (WebCore::InheritedFlags::setRight):
        (WebCore::InheritedFlags::setTop):
        (WebCore::InheritedFlags::setBottom):
        (WebCore::InheritedFlags::setDashboardRegion):
        (WebCore::InheritedFlags::setClipLeft):
        (WebCore::InheritedFlags::setClipRight):
        (WebCore::InheritedFlags::setClipTop):
        (WebCore::InheritedFlags::setClipBottom):
        (WebCore::InheritedFlags::setMarginTop):
        (WebCore::InheritedFlags::setMarginBottom):
        (WebCore::InheritedFlags::setMarginLeft):
        (WebCore::InheritedFlags::setMarginRight):
        (WebCore::InheritedFlags::setPaddingTop):
        (WebCore::InheritedFlags::setPaddingBottom):
        (WebCore::InheritedFlags::setPaddingLeft):
        (WebCore::InheritedFlags::setPaddingRight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Make the Resource panel perform graph updates atomically, so when resources
timothy@apple.com [Mon, 20 Oct 2008 19:03:15 +0000 (19:03 +0000)]
    Make the Resource panel perform graph updates atomically, so when resources
        are added the graph and summary graph update at the same time.

        https://bugs.webkit.org/show_bug.cgi?id=21755

        Reviewed by Kevin McCullough.

        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype.get startTime): Return -1 if the _startTime
        property is undefined, null or 0. This allows callers to check for -1 and not
        the other values when there is no startTime yet.
        (WebInspector.Resource.prototype.get responseReceivedTime): Ditto.
        (WebInspector.Resource.prototype.get endTime): Ditto.
        (WebInspector.Resource.prototype.get duration): Remove an extra empty line.
        (WebInspector.Resource.prototype.get latency): Ditto.
        (WebInspector.Resource.prototype.get contentLength): Return 0 if the _duration
        property is undefined or null. This allows callers to always assume a number.
        (WebInspector.Resource.prototype.get expectedContentLength): Ditto.
        (WebInspector.Resource.prototype.get errors): Simplify the case where there is
        no _errors property yet.
        (WebInspector.Resource.prototype.set errors): Remove the check if the new value
        if the same as the previous value, since there is no work to guard.
        (WebInspector.Resource.prototype.get warnings): Simplify the case where there is
        no _warnings property yet.
        (WebInspector.Resource.prototype.set warnings): Remove the check if the new value
        if the same as the previous value, since there is no work to guard.
        (WebInspector.Resource.CompareByResponseReceivedTime): Add cases for when the
        responseReceivedTime is -1.
        (WebInspector.Resource.CompareByEndTime): Add cases for when the endTime is -1.
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.get searchableViews): If a resource does not
        have a _resourcesTreeElement yet, exclude it from the searchable views.
        (WebInspector.ResourcesPanel.prototype.set calculator): Set _staleResource to _resources
        and call refresh to refresh the entire graph.
        (WebInspector.ResourcesPanel.prototype.set needsRefresh): Set a timeout if the panel
        is visible that calls refresh.
        (WebInspector.ResourcesPanel.prototype.refresh): Create the resource tree element and
        graph for a resource if it hasn't been created yet. If the boundaries changed during
        the first stale resource pass, do a full pass of all resources when updating the graphs.
        (WebInspector.ResourcesPanel.prototype.reset): Remove the legend items.
        (WebInspector.ResourcesPanel.prototype.addResource): Don't create the tree element and
        graph, these are now created during the first refresh.
        (WebInspector.ResourcesPanel.prototype.removeResource): Null check _resourcesTreeElement.
        (WebInspector.ResourcesPanel.prototype.addMessageToResource): Ditto.
        (WebInspector.ResourcesPanel.prototype.clearMessages): Ditto.
        (WebInspector.ResourcesPanel.prototype.refreshResource): Remove most of the work, just
        add the resource to the _staleResources and set needsRefresh.
        (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): Null check
        _resourcesTreeElement.
        (WebInspector.ResourcesPanel.prototype._sortResourcesIfNeeded): Remove code to clear
        the timeout used by the deleted _sortResourcesSoonIfNeeded. Remove call to removeChild
        since the insertBefore call will do it if needed.
        (WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded): Remove code to
        clear the timeout used by the deleted _updateGraphDividersSoonIfNeeded.
        (WebInspector.ResourcesPanel.prototype._updateSummaryGraph): Remove code to clear the
        timeout used by the deleted _updateSummaryGraphSoon. No need to remove the totalLegendLabel,
        since all the legend items are removed in one pass right before.
        (WebInspector.ResourcesPanel.prototype._changeSortingFunction): Set the sortingFunction
        before the calculator so the correct sortingFunction is there when a refresh happens.
        (WebInspector.ResourceTimeCalculator.prototype.computeBarGraphPercentages): Set start to 0
        when the startTime is -1, since that looks best visually. Also set middle and end
        to the start and middle (respectfully) when startAtZero. This looks best visually.
        (WebInspector.ResourceGraph): Start the graph as hidden until the first refresh.
        (WebInspector.ResourceGraph.prototype.refresh): Remove the hidden class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-10-20 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 20 Oct 2008 18:45:17 +0000 (18:45 +0000)]
2008-10-20  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21733

        Make sure that the haveMetadata flag is set to true for generated images from image buffers, so that
        no attempt is made to re-cache the frame from a non-existent image source.

        Reviewed by Sam Weinig

        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::BitmapImage::BitmapImage):
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::BitmapImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37740 268f45cc-cd09-0410-ab3c-d52691b4dbfc