loislo@chromium.org [Wed, 9 Mar 2011 06:32:41 +0000 (06:32 +0000)]
2011-03-08 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove groupName from objectId.
https://bugs.webkit.org/show_bug.cgi?id=55825
* inspector/protocol/runtime-agent-expected.txt:
2011-03-08 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove groupName from objectId.
https://bugs.webkit.org/show_bug.cgi?id=55825
* inspector/InjectedScriptSource.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80623
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xji@chromium.org [Wed, 9 Mar 2011 06:23:37 +0000 (06:23 +0000)]
2011-03-08 Xiaomei Ji <xji@chromium.org>
Reviewed by David Hyatt.
Fix Regression: Content not drawn when scrolling horizontally in an RTL page.
https://bugs.webkit.org/show_bug.cgi?id=55077.
* fast/dom/scroll-reveal-left-overflow.html: Added.
* fast/dom/scroll-reveal-top-overflow.html: Added.
* platform/mac/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
* platform/mac/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
* platform/mac/fast/dom/scroll-reveal-left-overflow-expected.txt: Added.
* platform/mac/fast/dom/scroll-reveal-top-overflow-expected.checksum: Added.
* platform/mac/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
* platform/mac/fast/dom/scroll-reveal-top-overflow-expected.txt: Added.
2011-03-08 Xiaomei Ji <xji@chromium.org>
Reviewed by David Hyatt.
Fix Regression: Content not drawn when scrolling horizontally in an RTL page.
https://bugs.webkit.org/show_bug.cgi?id=55077.
Inside ScrollView::calculateOverhangAreasForPainting(), when scroll position
is negative, should include the position value into overhang rectangle's
starting position.
Tests: fast/dom/scroll-reveal-left-overflow.html
fast/dom/scroll-reveal-top-overflow.html
* platform/ScrollView.cpp:
(WebCore::ScrollView::calculateOverhangAreasForPainting):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80622
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 9 Mar 2011 05:57:29 +0000 (05:57 +0000)]
Bug 55994 - Functions on Array.prototype should check length first.
These methods are designed to work on generic objects too, and if 'length'
is a getter that throws an exception, ensure this is correctly thrown
(even if other exceptions would be thrown, too).
Reviewed by Sam Weinig
Source/JavaScriptCore:
Make the length check the first thing we do.
This change shows a progression on SunSpider on my machine, but this is likely bogus.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):
LayoutTests:
Added test cases.
* fast/js/array-proto-func-length-getter-except-expected.txt: Added.
* fast/js/array-proto-func-length-getter-except.html: Added.
* fast/js/script-tests/array-proto-func-length-getter-except.js: Added.
(lengthGetter):
(test):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80621
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Wed, 9 Mar 2011 05:57:23 +0000 (05:57 +0000)]
2011-03-08 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Add templatized CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}()
https://bugs.webkit.org/show_bug.cgi?id=55351
By using some template magic CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}()
can be called on an array A without the caller explicitly specifying the size of A.
No functionality was changed. So no new tests.
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::getPropertyValue): Modified to call templatized variants of
CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}().
(WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Renamed second argument from "number" to "size"
to better reflect its purpose - to be the size of the passed array.
(WebCore::CSSMutableStyleDeclaration::getShorthandValue): Ditto.
(WebCore::CSSMutableStyleDeclaration::getCommonValue): Ditto.
(WebCore::CSSMutableStyleDeclaration::cssText): Modified to call templatized variant of CSSMutableStyleDeclaration::getShorthandValue().
* css/CSSMutableStyleDeclaration.h:
(WebCore::CSSMutableStyleDeclaration::getShorthandValue): Added templatized function that can determine
the size of a passed array. Changed type of second argument to size_t since it represents the size of
an array.
(WebCore::CSSMutableStyleDeclaration::getCommonValue): Ditto.
(WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80620
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 9 Mar 2011 05:19:38 +0000 (05:19 +0000)]
2011-03-08 Jer Noble <jer.noble@apple.com>
Reviewed by Sam Weinig.
WebKit2: Plumb through the FULLSCREEN_API Chrome client calls
https://bugs.webkit.org/show_bug.cgi?id=55273
The FULLSCREEN_API Chrome client calls need to be plumbed through from the
WebProcess to the UIProcess. To do this, WebFullScreenManager (and Proxy)
classes have been added to WebPage.
* DerivedSources.make: Added rules necessary to build DerivedSources for new .in files.
* DerivedSources.pro: Ditto.
* Platform/CoreIPC/MessageID.h: Added message types for WebFullScreenManager.
* Shared/API/c/WKBase.h: Added WKFullScreenManagerRef.
* Shared/APIObject.h: Added APIType for WebFullScreenManager.
* UIProcess/WebFullScreenManagerProxy.cpp: Added.
* UIProcess/WebFullScreenManagerProxy.h: Added.
* UIProcess/WebFullScreenManagerProxy.messages.in: Added.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close): Invalidate and clear m_fullScreenManager.
(WebKit::WebPageProxy::processDidCrash): Ditto.
(WebKit::WebPageProxy::didReceiveMessage): Pass messages on to WebFullScreenManagerProxy.
(WebKit::WebPageProxy::didReceiveSyncMessage): Ditto.
(WebKit::WebPageProxy::fullScreenManager): Added. Lazy instantiation of m_fullScreenManager.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/WebUIClient.cpp:
* UIProcess/WebUIClient.h:
* WebKit2.xcodeproj/project.pbxproj: Added references to new classes in project file.
* WebKit2.pro: Ditto.
* win/WebKit2.vcproj: Ditto.
* WebKit2.pri: Added new directories to include file path.
* win/WebKit2Common.vsprops: Ditto.
* WebProcess/FullScreen/WebFullScreenManager.cpp: Added.
* WebProcess/FullScreen/WebFullScreenManager.h: Added.
* WebProcess/FullScreen/WebFullScreenManager.messages.in: Added.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::supportsFullScreenForElement): Pass through to WebFullScreenManager.
(WebKit::WebChromeClient::enterFullScreenForElement): Ditto.
(WebKit::WebChromeClient::exitFullScreenForElement): Ditto.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close): Invalidate and clear m_fullScreenManager.
(WebKit::WebPage::fullScreenManager): Lazy instantiation of m_fullScreenManager.
(WebKit::WebPage::didReceiveMessage): Pass messages through to WebFullScreenManager.
* WebProcess/WebPage/WebPage.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80619
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Wed, 9 Mar 2011 03:44:27 +0000 (03:44 +0000)]
2011-03-08 Mihai Parparita <mihaip@chromium.org>
Add failing expectation for compositing/webgl/
webgl-nonpremultiplied-blend.html.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80618
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Wed, 9 Mar 2011 03:15:28 +0000 (03:15 +0000)]
2011-03-08 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Destroying WorkerFileSystemCallbacksBridge on main thread results in ASSERT in WorkerContext::Observer::~Observer
https://bugs.webkit.org/show_bug.cgi?id=55895
* src/WorkerFileSystemCallbacksBridge.cpp:
(WebKit::WorkerFileSystemCallbacksBridge::runTaskOnWorkerThread):
Added stopObserving() so that releasing the bridge on the main thread
(this could happen before or after the runTaskOnWorkerThread) does
not cause the assertion error.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80617
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 9 Mar 2011 03:04:24 +0000 (03:04 +0000)]
There's more chance that this will work if the file is compiled.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80616
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Wed, 9 Mar 2011 02:28:12 +0000 (02:28 +0000)]
REGRESSION: Copied content loses formatting on paste to external apps.
https://bugs.webkit.org/show_bug.cgi?id=47615
<rdar://problem/
9001214>
Reviewed by Darin Adler.
This is a resubmission of a patch that was landed a while ago then rolled
back because of a build failure on SnowLeopard and Leopard on the 32-bit builds.
This patch adds a way for WebKit2 to create NSAttributedStrings from
a DOM range without using the AppKit api initWithDOMRange that internally
needs to access the WebView. The NSAttributedString is needed to create
RTF formats in the pasteboard.
This is to be considered a first step, since in the future we want to have
an implementation based on the TextIterator.
* WebCore.xcodeproj/project.pbxproj:
* platform/mac/HTMLConverter.h: Added.
* platform/mac/HTMLConverter.mm: Added.
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 9 Mar 2011 02:25:54 +0000 (02:25 +0000)]
2011-03-08 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Explicitly copy compositing properties from LayerChromium to CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=55900
This adds an explicit step to synchronize properties from
LayerChromiums to their corresponding CCLayerImpls.
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setBounds):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::bounds):
(WebCore::LayerChromium::doubleSided):
(WebCore::LayerChromium::setDoubleSided):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::updateFromLayer):
(WebCore::CCLayerImpl::descendantsDrawsContent):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::anchorPoint):
(WebCore::CCLayerImpl::anchorPointZ):
(WebCore::CCLayerImpl::masksToBounds):
(WebCore::CCLayerImpl::opacity):
(WebCore::CCLayerImpl::position):
(WebCore::CCLayerImpl::preserves3D):
(WebCore::CCLayerImpl::sublayerTransform):
(WebCore::CCLayerImpl::transform):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80614
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 9 Mar 2011 02:22:45 +0000 (02:22 +0000)]
2011-03-08 James Robinson <jamesr@chromium.org>
Chromium compile fix.
* platform/graphics/chromium/SimpleFontDataLinux.cpp:
(WebCore::SimpleFontData::platformInit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80613
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 9 Mar 2011 02:09:18 +0000 (02:09 +0000)]
2011-03-08 Jer Noble <jer.noble@apple.com>
Reviewed by Sam Weinig.
WebKit2: Plumb through the "supportsFullScreen" preference.
https://bugs.webkit.org/show_bug.cgi?id=55261
The "supportsFullScreen" preference needs to be plumbed through from
the UIProcess to the WebProcess.
* Shared/WebPreferencesStore.h: Add a new macro entry.
* UIProcess/API/C/WKPreferences.cpp: Implement preferences getter and setter.
(WKPreferencesSetFullScreenEnabled):
(WKPreferencesGetFullScreenEnabled):
* UIProcess/API/C/WKPreferences.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Sync the fullScreenEnabled setting through to
the settings object.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80612
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Wed, 9 Mar 2011 01:44:10 +0000 (01:44 +0000)]
Unify Windows version checks, part 1.
https://bugs.webkit.org/show_bug.cgi?id=55979
Reviewed by James Robinson.
Make everyone (I hope) pull in SystemInfo.cpp. Eliminate the
now-unnecessary WindowsVersion.cpp from Chromium.
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::invalidateOnMouseEnterExit):
(WebCore::ScrollbarThemeChromiumWin::getThemeState):
(WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):
* platform/chromium/WindowsVersion.cpp: Removed.
* platform/chromium/WindowsVersion.h: Removed.
* platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::fillBMPGlyphs):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore::getNonClientMetrics):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80611
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 9 Mar 2011 01:39:46 +0000 (01:39 +0000)]
2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
Chromium Linux build fix attempt after r80582.
* platform/graphics/chromium/FontLinux.cpp:
(WebCore::Font::drawGlyphs):
* platform/graphics/chromium/SimpleFontDataLinux.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
(WebCore::GlyphPage::fill):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80610
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Wed, 9 Mar 2011 01:35:18 +0000 (01:35 +0000)]
2011-03-08 Jeff Miller <jeffm@apple.com>
Reviewed by Adele Peterson.
WebKit2: Implement Windows glue for Undo/Redo
https://bugs.webkit.org/show_bug.cgi?id=55961
Expose Undo/Redo infrastructure through WKView on Windows by
adding an undo client as well as APIs to reapply and unapply
an edit command.
* UIProcess/API/C/win/WKView.cpp:
(WKViewSetViewUndoClient): Added.
(WKViewReapplyEditCommand): Added.
(WKViewUnapplyEditCommand): Added.
* UIProcess/API/C/win/WKView.h: Added WKViewUndoClient, WKViewSetViewUndoClient(), and WKViewUnapplyEditCommand().
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::isValidEditCommand): Added, used to validated an edit command from a WKView API.
* UIProcess/WebPageProxy.h: Added isValidEditCommand().
* UIProcess/win/WebUndoClient.cpp: Added, APIClient for WKViewUndoClient.
(WebKit::WebUndoClient::registerEditCommand): Added.
(WebKit::WebUndoClient::clearAllEditCommands): Added.
* UIProcess/win/WebUndoClient.h: Added, APIClient for WKViewUndoClient.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::initializeUndoClient): Added.
(WebKit::WebView::close): Clear out undo client.
(WebKit::WebView::registerEditCommand): Implemented to call through to WKViewUndoClient.
(WebKit::WebView::clearAllEditCommands): Implmented to call through to WKViewUndoClient.
(WebKit::WebView::reapplyEditCommand): Added.
(WebKit::WebView::unapplyEditCommand): Added.
* UIProcess/win/WebView.h: Added undo client support.
* win/WebKit2.vcproj: Added WebUndoClient.cpp and WebUndoClient.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80609
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 9 Mar 2011 01:27:48 +0000 (01:27 +0000)]
2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
Mac build fix attempt for r80582.
* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::disableLigatures):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80608
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
imasaki@chromium.org [Wed, 9 Mar 2011 01:25:31 +0000 (01:25 +0000)]
Adding myself to the committer file.
Reviewed by David Levin.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80607
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
imasaki@chromium.org [Wed, 9 Mar 2011 01:16:52 +0000 (01:16 +0000)]
[Chromium] Clean up Media GPU test expectation since
http://crbug.com?id=74887 was fixed. These expectations are based
on the results on flakiness dashboard.
Reviewed by David Levin.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80606
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Wed, 9 Mar 2011 01:00:35 +0000 (01:00 +0000)]
2011-03-08 Jeff Miller <jeffm@apple.com>
Reviewed by Sam Weinig.
WebKit2: Expose WebEditCommandProxy in the C API on Windows
https://bugs.webkit.org/show_bug.cgi?id=55962
Make WebEditCommandProxy a subclass of APIObject, and define
WKEditCommandRef as the type that will be exposed through the C API.
* Shared/API/c/win/WKBaseWin.h: Add WKEditCommandRef.
* Shared/APIObject.h: Add platform-specific TypeEditCommandProxy.
* UIProcess/API/C/win/WKAPICastWin.h: Add API mapping for WKEditCommandRef.
* UIProcess/WebEditCommandProxy.h: Subclass WebEditCommandProxy from APIObject.
(WebKit::WebEditCommandProxy::type): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80605
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 9 Mar 2011 00:51:00 +0000 (00:51 +0000)]
2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Remove calls to deprecatedEditingOffset in SelectionController and VisibleSelection
https://bugs.webkit.org/show_bug.cgi?id=54937
* editing/SelectionController.cpp:
(WebCore::SelectionController::setSelection): Calls anchorNode() instead of deprecatedNode() to obtain
the document. Also restrained the lifetime of document variable.
(WebCore::removingNodeRemovesPosition): Compare the node with anchorNode() instead of deprecatedNode()
to determine whether or not position becomes null after removing a node.
(WebCore::SelectionController::directionOfEnclosingBlock): The enclosing block is always a container
so call containerNode() instead of deprecatedNode().
(WebCore::SelectionController::debugRenderer): Call containerNode() and computeOffsetInContainer()
instead of deprecatedNode() and deprecatedEditingOffset() respectively.
(WebCore::SelectionController::isInPasswordField): Look for the shadow root from containerNode()
instead of deprecatedNode to determine whether or not selection inside a password field. Also assert
that the specified position is not before or after the shadow root as it violates our assumption.
* editing/VisibleSelection.cpp:
(WebCore::makeSearchRange): Call containerNode() and offsetInContainerNode() instead of deprecatedNode()
and deprecatedEditingOffset() respectively because start is always parent anchored and therefore
guaranteed to be an offset inside an anchor node.
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries): Call containerNode()
instead of deprecatedNode() to look for the lowest editable ancestor because position before or after
an editable element isn't editable.
* page/DOMSelection.cpp: Call containerNode() and offsetInContainerNode() instead of deprecatedNode()
and deprecatedEditingOffset() respectively in the following functions because they are exposed to
DOM, which doesn't have before/after concept.
(WebCore::DOMSelection::anchorNode):
(WebCore::DOMSelection::anchorOffset):
(WebCore::DOMSelection::focusNode):
(WebCore::DOMSelection::focusOffset):
(WebCore::DOMSelection::baseNode):
(WebCore::DOMSelection::baseOffset):
(WebCore::DOMSelection::extentNode):
(WebCore::DOMSelection::extentOffset):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80604
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Wed, 9 Mar 2011 00:18:46 +0000 (00:18 +0000)]
2011-03-08 Jeff Miller <jeffm@apple.com>
Reviewed by Oliver Hunt.
WebKit2: Redo is broken
https://bugs.webkit.org/show_bug.cgi?id=55978
WebEditCommandProxy::unapply() and WebEditCommandProxy::reapply() were registering the wrong edit command when an undo or redo happens.
For example, when we unapply(), we should register a Redo command, not an Undo command.
* UIProcess/WebEditCommandProxy.cpp:
(WebKit::WebEditCommandProxy::unapply): Register a Redo command, not an Undo command.
(WebKit::WebEditCommandProxy::reapply): Register an Undo command, not a Redo command.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80603
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 9 Mar 2011 00:02:34 +0000 (00:02 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=55977
Refine CF/CFNet distinctions for better code sharing.
1. Rename Downloads/cf/win/DownloadCFNetWin.cpp to DownloadCFWin.cpp
since it does not use any CFNETWORK features.
2. Create new cfnet directory.
3. Move Downloads/cf/DownloadCFNet.cpp to Downloads/cfnet
4. Update project file.
Reviewed by Adam Roben.
* WebProcess/Downloads/cf/DownloadCFNet.cpp: Removed.
* WebProcess/Downloads/cf/win/DownloadCFNetWin.cpp: Removed.
* WebProcess/Downloads/cf/win/DownloadCFWin.cpp: Copied from WebProcess/Downloads/cf/win/DownloadCFNetWin.cpp.
* WebProcess/Downloads/cfnet: Added.
* WebProcess/Downloads/cfnet/DownloadCFNet.cpp: Copied from WebProcess/Downloads/cf/DownloadCFNet.cpp.
* win/WebKit2.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80602
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 9 Mar 2011 00:00:26 +0000 (00:00 +0000)]
Correct uninitialized variable in PolicyCallback found while
running WebKit in BoundsChecker.
https://bugs.webkit.org/show_bug.cgi?id=45199.
Reviewed by Adam Roben.
* loader/PolicyCallback.cpp:
(WebCore::PolicyCallback::PolicyCallback): Initialize
m_argument.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80601
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Tue, 8 Mar 2011 23:44:35 +0000 (23:44 +0000)]
<webkit.org/b/55976> Provisional URL should be loaded when restoring session state even if there are back / forward list entries.
Reviewed by Brady Eidson.
* UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::restoreFromSessionStateData): If there's a provisional URL that we will load then restore the session state
without navigating to the current item.
* WebProcess/WebPage/WebPage.messages.in: Expose the ability to restore the session state without navigating to the current item.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80600
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Tue, 8 Mar 2011 23:43:23 +0000 (23:43 +0000)]
Fix two leaks I introduced into the API tests.
Rubber-stamped by Adam Roben.
* TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
(TestWebKitAPI::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80599
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Tue, 8 Mar 2011 23:17:32 +0000 (23:17 +0000)]
2011-03-07 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Make CodeBlock GC write barrier safe
https://bugs.webkit.org/show_bug.cgi?id=55910
In order to make CodeBlock WriteBarrier safe it was necessary
to make it have a single GC owner, and for that reason I have
made ExecutableBase a GC allocated object. This required
updating their creation routines as well as all sites that hold
a reference to them. GC objects that held Executable's have been
converted to WriteBarriers, and all other sites now use Global<>.
As an added benefit this gets rid of JSGlobalData's list of
GlobalCodeBlocks.
Perf testing shows a 0.5% progression on v8, vs. a 0.3% regression
on SunSpider. Given none of the tests that show regressions
demonstrate a regression on their own, and sampling shows up nothing.
I suspect we're just getting one or two additional gc passes at
the end of the run.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::EvalCodeCache::markAggregate):
(JSC::CodeBlock::markAggregate):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::ownerExecutable):
(JSC::CodeBlock::addConstant):
(JSC::CodeBlock::constantRegister):
(JSC::CodeBlock::getConstant):
(JSC::CodeBlock::addFunctionDecl):
(JSC::CodeBlock::addFunctionExpr):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ExecState::r):
* bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::get):
* bytecode/SamplingTool.h:
(JSC::ScriptSampleRecord::ScriptSampleRecord):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addConstantValue):
(JSC::BytecodeGenerator::emitEqualityOp):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::makeFunction):
* debugger/Debugger.cpp:
(JSC::evaluateInGlobalCallFrame):
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluate):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
* jit/JITInlineMethods.h:
(JSC::JIT::emitLoadDouble):
(JSC::JIT::emitLoadInt32ToDouble):
* jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
(JSC::JITThunks::hostFunctionStub):
(JSC::JITThunks::clearHostFunctionStubs):
* jit/JITStubs.h:
* runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
* runtime/Executable.cpp:
(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::~FunctionExecutable):
(JSC::EvalExecutable::markChildren):
(JSC::ProgramExecutable::markChildren):
(JSC::FunctionExecutable::markChildren):
(JSC::FunctionExecutable::fromGlobalCode):
* runtime/Executable.h:
(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::createStructure):
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::NativeExecutable):
(JSC::VPtrHackExecutable::VPtrHackExecutable):
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::EvalExecutable::create):
(JSC::EvalExecutable::createStructure):
(JSC::ProgramExecutable::create):
(JSC::ProgramExecutable::createStructure):
(JSC::FunctionExecutable::create):
(JSC::FunctionExecutable::createStructure):
* runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
* runtime/Heap.cpp:
(JSC::Heap::destroy):
(JSC::Heap::markRoots):
* runtime/Heap.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
(JSC::JSActivation::markChildren):
* runtime/JSActivation.h:
(JSC::JSActivation::JSActivationData::JSActivationData):
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::~JSFunction):
(JSC::JSFunction::markChildren):
* runtime/JSFunction.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::storeVPtrs):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::getHostFunction):
* runtime/JSGlobalData.h:
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
* runtime/JSObject.cpp:
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::markChildren):
* runtime/JSStaticScopeObject.h:
(JSC::JSStaticScopeObject::JSStaticScopeObjectData::JSStaticScopeObjectData):
(JSC::JSStaticScopeObject::JSStaticScopeObject):
* runtime/JSZombie.cpp:
(JSC::JSZombie::leakedZombieStructure):
* runtime/JSZombie.h:
(JSC::JSZombie::createStructure):
* runtime/MarkedSpace.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80598
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 8 Mar 2011 23:13:19 +0000 (23:13 +0000)]
2011-03-08 Martin Robinson <mrobinson@igalia.com>
Rebaseline a GTK+ result after r80582.
* platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80597
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 8 Mar 2011 23:06:08 +0000 (23:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=55956
WebKit2 Changes to correct WinCairo port build
Reviewed by Anders Carlsson.
* Shared/LayerTreeContext.h: Don't exclude CoreIPC declarations for non-accelerated
compositing case.
* UIProcess/DrawingAreaProxy.h: Add "stdint.h" include needed for Cairo build.
* UIProcess/DrawingAreaProxyImpl.cpp: Exclude accelerated compositing code for
WinCairo build.
(WebKit::DrawingAreaProxyImpl::~DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::waitForAndDispatchDidUpdateBackingStoreState):
* UIProcess/DrawingAreaProxyImpl.h: Exclude declarations for code only used when
accelerated compositing is enabled.
(WebKit::DrawingAreaProxyImpl::isInAcceleratedCompositingMode):
* UIProcess/win/WebView.cpp: Protect CG-specific drawing code.
(WebKit::WebView::setFindIndicator):
* WebProcess/Downloads/Download.h: Allow CFLite implentation to share overwrite flag,
as well as destination and bundle paths.
* WebProcess/Downloads/curl/DownloadCurl.cpp: Remove stub (to share CFNet implementation
of file handling. This will be moved to a common area in a future patch.)
* WebProcess/WebPage/DrawingAreaImpl.cpp: Exclude accelerated-compositing paths.
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers):
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
* WebProcess/WebPage/WebPage.cpp: Protect CG-specific drawing code.
(WebKit::WebPage::drawRectToPDF):
(WebKit::WebPage::drawPagesToPDF):
* win/WebKit2.vcproj: Exclude unused LayerTreeContext from WinCairo
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80596
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 8 Mar 2011 22:49:02 +0000 (22:49 +0000)]
Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=48540, support the text-orientation CSS property.
Update Qt specific expected results after r80582.
* platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80595
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 8 Mar 2011 22:37:38 +0000 (22:37 +0000)]
More build bustage fix.
* platform/graphics/win/cairo/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation): Duplicate accessor
in WinCairo-local header. This is such a mess!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80594
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ike@apple.com [Tue, 8 Mar 2011 22:16:21 +0000 (22:16 +0000)]
2011-03-08 Ivan Krstić <ike@apple.com>
Reviewed by Sam Weinig.
Re-fix: can't paste from 3rd party text editor into WebKit2 window
<rdar://problem/
8978624>
* WebProcess/com.apple.WebProcess.sb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80593
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 8 Mar 2011 22:05:14 +0000 (22:05 +0000)]
Fix build bustage. Hide orientation setting behind a setter and stub it out in all
FontPlatformData classes. (This class really needs to move to a common header with ifdefs.)
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::verticalRightOrientationFontData):
* platform/graphics/cg/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):
* platform/graphics/chromium/FontPlatformDataChromiumWin.h:
(WebCore::FontPlatformData::setOrientation):
* platform/graphics/chromium/FontPlatformDataLinux.h:
(WebCore::FontPlatformData::setOrientation):
* platform/graphics/cocoa/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):
* platform/graphics/freetype/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):
* platform/graphics/qt/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):
* platform/graphics/wince/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):
* platform/graphics/wx/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80589
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 8 Mar 2011 21:57:20 +0000 (21:57 +0000)]
2011-03-08 Martin Robinson <mrobinson@igalia.com>
Fix the WebKit2 compilation after r80578.
* UIProcess/gtk/WebView.cpp:
(WebKit::WebView::setFocus): Added.
* UIProcess/gtk/WebView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80588
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 8 Mar 2011 21:49:04 +0000 (21:49 +0000)]
2011-03-08 Joe Wild <joseph.wild@nokia.com>
Reviewed by Csaba Osztrogonác.
[Qt] Missing SVG variables
https://bugs.webkit.org/show_bug.cgi?id=32941
Basically, this patch just modifies features.pri to the Qt build to
pass on the ENABLE_SVG_* flags to the IDL binding generator.
Also I had remove global-construtors.html from the skip list and
updated the associated expected results files.
* platform/qt/Skipped:
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-expected.txt:
* platform/qt/fast/js/global-constructors-expected.txt:
2011-03-08 Joe Wild <joseph.wild@nokia.com>
Reviewed by Csaba Osztrogonác.
[Qt] Missing SVG variables
https://bugs.webkit.org/show_bug.cgi?id=32941
Basically, this patch just modifies features.pri to the Qt build to
pass on the ENABLE_SVG_* flags to the IDL binding generator.
Also I had remove global-construtors.html from the skip list and
updated the associated expected results files.
* features.pri:
* page/DOMWindow.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80587
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Tue, 8 Mar 2011 21:42:32 +0000 (21:42 +0000)]
Crash in CFNetwork visiting google.com
https://bugs.webkit.org/show_bug.cgi?id=55958
Reviewed by Anders Carlsson.
Source/WebKit2:
* Shared/API/c/cf/WKURLResponseCF.cpp:
(WKURLResponseCopyCFURLResponse):
If the response to copy is null, return 0;
Tools:
Add a test for not trying to copy a null CFURLResponse.
* TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.
(TestWebKitAPI::TEST):
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80586
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Tue, 8 Mar 2011 21:19:25 +0000 (21:19 +0000)]
Reverted the patch for https://bugs.webkit.org/show_bug.cgi?id=55940
The patch was insufficient, and it wasn't useful for the intended client use either.
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80585
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 8 Mar 2011 21:18:59 +0000 (21:18 +0000)]
2011-03-08 Alok priyadarshi <alokp@chromium.org>
Reviewed by Dimitri Glazkov.
Plugins needs a way to trigger style recalc
https://bugs.webkit.org/show_bug.cgi?id=55242
No test needed. A simple get function is added.
* platform/graphics/chromium/PluginLayerChromium.h:
(WebCore::PluginLayerChromium::getTextureId):
2011-03-08 Alok priyadarshi <alokp@chromium.org>
Reviewed by Dimitri Glazkov.
Plugins needs a way to trigger style recalc
https://bugs.webkit.org/show_bug.cgi?id=55242
It will be tested by Pepper2D and Pepper3D layout/smoke tests
on the Chromium side.
* public/WebPluginContainer.h:
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingTextureId):
* src/WebPluginContainerImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80584
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 8 Mar 2011 21:18:46 +0000 (21:18 +0000)]
Fix Lion build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80583
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 8 Mar 2011 20:53:58 +0000 (20:53 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=48540, support the text-orientation CSS property.
Reviewed by Dan Bernstein.
This patch adds support for two values of the text-orientation property (the ones that actually matter): vertical-right and upright.
The TextOrientation is part of the FontDescription and used to look up fonts (similar to FontOrientation).
Orientation of non-CJK characters is done using fallback font data of the appropriate orientation type, e.g., verticalRightOrientation and
uprightOrientation fallback font data. Vertical right is just implemented as a normal horizontal font. Upright is implemented as a
vertically oriented font that rotates all glyphs.
The main complication implementing text-orientation is that fonts have "baked-in" vertical glyphs for letters that are hardcoded to
a vertical right facing. This means that you can use those special vertical glyphs for vertical-right orientation without having to
fall back, but then for upright orientation you have to ignore them and still fall back. As you can see from the test case, this doesn't
work very well, but hopefully it won't be all that common. Limitations of CoreText prevent this case from rendering properly in either the
simple or complex code paths, although the simple code path at least gets close.
Added fast/blockflow/text-orientation-basic.html
Source/WebCore:
* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextOrientation):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSValueKeywords.in:
* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::platformDataFromCustomData):
* loader/cache/CachedFont.h:
* platform/graphics/FontCache.cpp:
(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
(WebCore::FontPlatformDataCacheKey::operator==):
(WebCore::computeHash):
(WebCore::FontCache::getCachedFontPlatformData):
* platform/graphics/FontDescription.h:
(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::textOrientation):
(WebCore::FontDescription::setTextOrientation):
(WebCore::FontDescription::operator==):
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::glyphDataForCharacter):
(WebCore::offsetToMiddleOfGlyph):
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::SimpleFontData):
(WebCore::SimpleFontData::verticalRightOrientationFontData):
(WebCore::SimpleFontData::uprightOrientationFontData):
(WebCore::SimpleFontData::brokenIdeographFontData):
(WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):
* platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::hasVerticalGlyphs):
(WebCore::SimpleFontData::isTextOrientationFallback):
* platform/graphics/cairo/FontCustomPlatformData.h:
* platform/graphics/cocoa/FontPlatformData.h:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::textOrientation):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
* platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/haiku/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/haiku/FontCustomPlatformData.h:
* platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/mac/FontCustomPlatformData.h:
* platform/graphics/mac/FontMac.mm:
(WebCore::showGlyphsWithAdvances):
(WebCore::Font::drawGlyphs):
* platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
(WebCore::shouldUseCoreText):
(WebCore::GlyphPage::fill):
* platform/graphics/mac/SimpleFontDataCoreText.cpp:
(WebCore::SimpleFontData::getCFStringAttributes):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
* platform/graphics/pango/FontCustomPlatformDataPango.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/qt/FontCustomPlatformData.h:
* platform/graphics/qt/FontCustomPlatformDataQt.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/skia/FontCustomPlatformData.h:
* platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/win/FontCustomPlatformData.h:
* platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/win/FontCustomPlatformDataCairo.h:
* platform/graphics/wince/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/wince/FontCustomPlatformData.h:
* platform/text/TextOrientation.h: Added.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::requiresIdeographicBaseline):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::initialTextOrientation):
LayoutTests:
* fast/blockflow/text-orientation-basic.html: Added.
* platform/mac/fast/blockflow/text-orientation-basic-expected.checksum: Added.
* platform/mac/fast/blockflow/text-orientation-basic-expected.png: Added.
* platform/mac/fast/blockflow/text-orientation-basic-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80582
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Tue, 8 Mar 2011 20:14:48 +0000 (20:14 +0000)]
2011-03-08 Alejandro G. Castro <alex@igalia.com>
Unreviewed, fixed GTK+ compilation after r80569.
* UIProcess/gtk/WebView.cpp:
(WebKit::WebView::windowToScreen):
* UIProcess/gtk/WebView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80581
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 8 Mar 2011 20:12:09 +0000 (20:12 +0000)]
2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
addInlineStyleIfNeeded should take EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55950
Deployed EditingStyle in addInlineStyleIfNeeded, StyleChange::StyleChange, and StyleChange::init.
Also extracted EditingStyle::styleIsPresentInComputedStyleOfNode from removeStyleFromRunBeforeApplyingStyle.
* editing/ApplyStyleCommand.cpp:
(WebCore::StyleChange::StyleChange): Takes EditingStyle instead of CSSStyleDeclaration.
(WebCore::StyleChange::init): Ditto.
(WebCore::ApplyStyleCommand::applyBlockStyle): Instantiates StyleChange.
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Calls addInlineStyleIfNeeded.
(WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Calls styleIsPresentInComputedStyleOfNode.
(WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Calls EditingStyle::mergeInlineStyleOfElement
instead of manually merging styles.
(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Calls addInlineStyleIfNeeded.
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Takes EditingStyle instead of CSSMutableStyleDeclaration.
* editing/ApplyStyleCommand.h:
* editing/CompositeEditCommand.h:
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::styleIsPresentInComputedStyleOfNode): Extracted from removeStyleFromRunBeforeApplyingStyle.
* editing/EditingStyle.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80580
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Tue, 8 Mar 2011 20:07:00 +0000 (20:07 +0000)]
2011-03-08 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
Crash on big blur radius with canvas
https://bugs.webkit.org/show_bug.cgi?id=55951
* fast/canvas/shadow-huge-blur-expected.txt: Added.
* fast/canvas/shadow-huge-blur.html: Added.
2011-03-08 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
Crash on big blur radius with canvas
https://bugs.webkit.org/show_bug.cgi?id=55951
Move the clamping code out of an if branch, so that it happens in the
canvas case as well.
Test: fast/canvas/shadow-huge-blur.html
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setPlatformShadow):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80579
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Tue, 8 Mar 2011 20:04:42 +0000 (20:04 +0000)]
Source/WebCore: WK2: Cannot set focus on an element when focus is outside of WKView
https://bugs.webkit.org/show_bug.cgi?id=55281
Reviewed by Sam Weinig.
In WK2, focus cannot be set from the WebProcess side because there's no platformWidget().
Instead, the focus/unfocus messages need to be sent to the UIProcess side.
* platform/mac/WidgetMac.mm:
(WebCore::Widget::setFocus):
Source/WebKit2: WK2: Cannot set focus on an element when focus is outside of WKView
https://bugs.webkit.org/show_bug.cgi?id=55281
Reviewed by Sam Weinig.
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setFocus):
* UIProcess/API/qt/qwkpage_p.h:
(QWKPagePrivate::setFocus):
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setFocus):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/win/WebView.h:
(WebKit::WebView::setFocus):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::focus):
(WebKit::WebChromeClient::unfocus):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80578
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Tue, 8 Mar 2011 19:50:52 +0000 (19:50 +0000)]
Unreviewed, fix last change so WKBaseWin.h is in alphabetical order in the project XML.
* win/WebKit2.vcproj: Move WKBaseWin.h to be in alphabetical order.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80577
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 8 Mar 2011 19:40:47 +0000 (19:40 +0000)]
2011-03-08 Tony Chang <tony@chromium.org>
Unreviewed, add pngs to chromium and chromium-linux .checksum files
that are missing pngs. I generated these on my local desktop.
* platform/chromium-linux/fast/block/float/clear-element-too-wide-for-containing-block-expected.png: Added.
* platform/chromium-linux/fast/blockflow/english-bt-text-expected.png: Added.
* platform/chromium-linux/fast/blockflow/english-lr-text-expected.png: Added.
* platform/chromium-linux/fast/blockflow/english-rl-text-expected.png: Added.
* platform/chromium-linux/fast/multicol/border-padding-pagination-expected.png: Added.
* platform/chromium-linux/fast/multicol/margin-collapse-expected.png: Added.
* platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.png: Added.
* platform/chromium/fast/images/png_per_row_alpha_decoding-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80576
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 8 Mar 2011 19:33:57 +0000 (19:33 +0000)]
2011-03-08 Martin Maly <mmaly@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Expectation updates for strict mode V8 features.
https://bugs.webkit.org/show_bug.cgi?id=55789
* platform/chromium/fast/js/mozilla/strict/15.5.5.1-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80575
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Tue, 8 Mar 2011 19:32:16 +0000 (19:32 +0000)]
2011-03-08 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
Remove Source/WebKit2/UIProcess/API/C/win/WKBaseWin.h
https://bugs.webkit.org/show_bug.cgi?id=55952
* UIProcess/API/C/win/WKBaseWin.h: Removed.
* win/WebKit2.vcproj: Refer to the Shared version of WKBaseWin.h instead of the one in UIProcess.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80574
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 8 Mar 2011 19:24:26 +0000 (19:24 +0000)]
2011-03-08 Darin Adler <darin@apple.com>
Reviewed by Timothy Hatcher.
Promote a method used outside WebKit from internal to private
https://bugs.webkit.org/show_bug.cgi?id=55949
* Misc/WebNSPasteboardExtras.mm: Removed an unused category declaration.
Minor tweak, not directly related to the rest of this patch.
* WebView/WebFrame.mm:
(-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): Moved
this method from the internal category into the private category.
Streamlined the code a bit.
* WebView/WebFrameInternal.h: Removed _computePageRects method.
* WebView/WebFramePrivate.h: Added _computePageRects method.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80573
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 8 Mar 2011 19:02:09 +0000 (19:02 +0000)]
Overflow: scroll areas should not paint white in scroll corner if the
scrollbars are overlay.
<rdar://problem/
9082871>
Reviewed by Anders Carlsson.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintScrollCorner):
Don't paint the scroll corner white if we have overlay scrollbars.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80572
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Tue, 8 Mar 2011 18:42:53 +0000 (18:42 +0000)]
2011-03-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add new files to compilation after r77974
https://bugs.webkit.org/show_bug.cgi?id=54076
The commit added new code to allow passing context to policy
delegate methods, we also added dummy ResourceRequest and
ResourceResponse decoders until we implement them.
* GNUmakefile.am:
* Shared/gtk/WebCoreArgumentCodersGtk.cpp:
(CoreIPC::decodeResourceRequest):
(CoreIPC::decodeResourceResponse):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80571
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cmarrin@apple.com [Tue, 8 Mar 2011 18:29:04 +0000 (18:29 +0000)]
2011-03-08 Chris Marrin <cmarrin@apple.com>
Reviewed by Darin Adler.
The first time animations are committed they have a bad start time
https://bugs.webkit.org/show_bug.cgi?id=55947
Do a check for a returned lastCommitTime of <=0 and replace it
with the mediaTime.
* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::notifyAnimationsStarted):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80570
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Tue, 8 Mar 2011 18:18:51 +0000 (18:18 +0000)]
AX: Webkit2 not sending UAZoomFocusChanged notifications
https://bugs.webkit.org/show_bug.cgi?id=55916
Reviewed by Darin Adler.
Needed to implement the windowToScreen() method so that the right frame
could be calculated to send for zoom focus changes.
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::windowToScreen):
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::windowToScreen):
* UIProcess/API/qt/qwkpage_p.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::windowToScreen):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::windowToScreen):
* UIProcess/win/WebView.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::windowToScreen):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowToScreen):
* WebProcess/WebPage/WebPage.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80569
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Tue, 8 Mar 2011 18:10:52 +0000 (18:10 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=55940
WebKit2 should support Ignore policy from injected bundle client
Reviewed by Darin Adler.
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
Added WKBundlePagePolicyActionIgnore.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
If the injected bundle client returns WKBundlePagePolicyActionIgnore, convert it
to the loader's PolicyIgnore.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80568
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 8 Mar 2011 18:03:19 +0000 (18:03 +0000)]
2011-03-08 Tony Chang <tony@chromium.org>
Unreviewed, remove png layout test results that don't have
corresponding checksum files. I checked a few of these and they
were cases where the .checksum was removed and the .png forgotten.
* platform/gtk/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
* platform/gtk/fast/encoding/utf-16-no-bom-expected.png: Removed.
* platform/gtk/svg/hixie/error/004-expected.png: Removed.
* platform/gtk/svg/hixie/error/005-expected.png: Removed.
* platform/mac-leopard/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
* platform/mac-leopard/fast/encoding/utf-16-no-bom-expected.png: Removed.
* platform/mac-leopard/svg/hixie/error/004-expected.png: Removed.
* platform/mac-leopard/svg/hixie/error/005-expected.png: Removed.
* platform/mac/editing/selection/contenteditable-click-outside-expected.png: Removed.
* platform/mac/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
* platform/mac/fast/dynamic/8952-reduction-expected.png: Removed.
* platform/mac/fast/encoding/utf-16-no-bom-expected.png: Removed.
* platform/mac/fast/js/Plug-ins-expected.png: Removed.
* platform/mac/fast/table/row-height-recalc2-expected.png: Removed.
* platform/mac/svg/hixie/error/004-expected.png: Removed.
* platform/mac/svg/hixie/error/005-expected.png: Removed.
* platform/qt/fast/table/row-height-recalc2-expected.png: Removed.
* platform/win/fast/table/row-height-recalc2-expected.png: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80567
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 8 Mar 2011 17:41:13 +0000 (17:41 +0000)]
2011-03-08 James Kozianski <koz@chromium.org>
Reviewed by David Levin.
Expose isValidProtocol() in KURL.h.
https://bugs.webkit.org/show_bug.cgi?id=54594
This is needed to validate protocols used in calls to
navigator.registerProtocolHandler().
* platform/KURL.cpp:
* platform/KURL.h:
* platform/KURLGoogle.cpp:
(WebCore::isValidProtocol):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80566
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 8 Mar 2011 17:32:14 +0000 (17:32 +0000)]
Set svn:mime-type to text/css for all Inspector CSS files
This will cause them to be served with the correct MIME type from svn.webkit.org's web
interface.
Rubber-stamped by Tim Hatcher.
* inspector/front-end/audits.css: Added property svn:mime-type.
* inspector/front-end/goToLineDialog.css: Added property svn:mime-type.
* inspector/front-end/heapProfiler.css: Added property svn:mime-type.
* inspector/front-end/helpScreen.css: Added property svn:mime-type.
* inspector/front-end/inspector.css: Added property svn:mime-type.
* inspector/front-end/inspectorSyntaxHighlight.css: Added property svn:mime-type.
* inspector/front-end/networkPanel.css: Added property svn:mime-type.
* inspector/front-end/popover.css: Added property svn:mime-type.
* inspector/front-end/textViewer.css: Added property svn:mime-type.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80565
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreip@google.com [Tue, 8 Mar 2011 16:05:26 +0000 (16:05 +0000)]
2011-03-08 Andrei Popescu <andreip@google.com>
Reviewed by Steve Block.
IDBCallbacks::onsuccess(IDBIndex*) is unused and should be removed.
https://bugs.webkit.org/show_bug.cgi?id=55938
The IndexedDatabase specification changed and IDBIndex objects are no
longer created asynchronously. We therefore no longer need this method.
No new tests, just cleanup.
* storage/IDBCallbacks.h:
* storage/IDBRequest.cpp:
* storage/IDBRequest.h:
2011-03-08 Andrei Popescu <andreip@google.com>
Reviewed by Steve Block.
IDBCallbacks::onsuccess(IDBIndex*) is unused and should be removed.
https://bugs.webkit.org/show_bug.cgi?id=55938
* public/WebIDBCallbacks.h:
* src/IDBCallbacksProxy.cpp:
* src/IDBCallbacksProxy.h:
* src/WebIDBCallbacksImpl.cpp:
* src/WebIDBCallbacksImpl.h:
* src/WebIDBObjectStoreImpl.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80564
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 8 Mar 2011 15:42:33 +0000 (15:42 +0000)]
2011-03-08 Grzegorz Czajkowski <g.czajkowski@samsung.com>
Reviewed by Kent Tamura.
[EFL] Doxygen documentation for ewk_window_features and ewk_context_menu
https://bugs.webkit.org/show_bug.cgi?id=55026
* ewk/ewk_contextmenu.cpp:
(ewk_context_menu_item_select): returns EINA_FALSE when CONTEXT_MENU is disabled
* ewk/ewk_contextmenu.h:
* ewk/ewk_window_features.cpp:
* ewk/ewk_window_features.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80563
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 8 Mar 2011 15:20:12 +0000 (15:20 +0000)]
2011-03-08 Philippe Normand <pnormand@igalia.com>
REGRESSION (r80478): broke GTK inspector tests
https://bugs.webkit.org/show_bug.cgi?id=55941
Unreviewed, skipping inspector crashing tests on GTK.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80562
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
christian@webkit.org [Tue, 8 Mar 2011 14:48:03 +0000 (14:48 +0000)]
[GTK] provide an API to control the IconDatabase
https://bugs.webkit.org/show_bug.cgi?id=32510
Reviewed by Martin Robinson.
* GNUmakefile.am:
* WebCoreSupport/FrameLoaderClientGtk.cpp: Emit signals on
the icon database for new icons.
* webkit/webkit.h:
* webkit/webkitdefines.h:
* webkit/webkitglobals.cpp:
* webkit/webkitglobals.h: Add a function to obtain the global
icon database.
* webkit/webkiticondatabase.cpp:
* webkit/webkiticondatabase.h: Implement public icon database
object with methods for obtaining icon URLs, pixbufs, clearing
waiting for new icons.
* webkit/webkitwebview.cpp:
* webkit/webkitwebview.h: Add a method to obtain an icon pixbuf
for the web view.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80561
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 8 Mar 2011 13:03:46 +0000 (13:03 +0000)]
2011-03-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80551.
http://trac.webkit.org/changeset/80551
https://bugs.webkit.org/show_bug.cgi?id=55933
It broke 285 tests on Qt bot (Requested by Ossy on #webkit).
* WebCore.pro:
* platform/SharedBuffer.cpp:
* platform/SharedBuffer.h:
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::start):
* platform/network/qt/QNetworkReplyHandler.h:
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::supportsBufferedData):
(WebCore::ResourceHandle::bufferedData):
* platform/qt/QtByteBlock.cpp: Removed.
* platform/qt/QtByteBlock.h: Removed.
* platform/qt/SharedBufferQt.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80560
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Tue, 8 Mar 2011 12:35:53 +0000 (12:35 +0000)]
2011-03-08 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
RenderObject: Pass complex type arguments as const-references.
* WebCore.exp.in:
* rendering/RenderObject.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawBoxSideFromPath):
(WebCore::RenderObject::drawArcForBoxSide):
(WebCore::RenderObject::localToAbsolute):
(WebCore::RenderObject::absoluteToLocal):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80559
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Tue, 8 Mar 2011 11:47:37 +0000 (11:47 +0000)]
2011-03-08 Hayato Ito <hayato@chromium.org>
Reviewed by Ojan Vafai.
[NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.
FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.
https://bugs.webkit.org/show_bug.cgi?id=55450
* Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80558
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 8 Mar 2011 11:18:08 +0000 (11:18 +0000)]
2011-03-08 Andreas Kling <kling@webkit.org>
Reviewed by Antonio Gomes.
Path: Make measurement functions const
https://bugs.webkit.org/show_bug.cgi?id=55914
* platform/graphics/Path.cpp:
(WebCore::Path::length):
(WebCore::Path::pointAtLength):
(WebCore::Path::normalAngleAtLength):
* platform/graphics/Path.h:
* platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::strokeBoundingRect):
* platform/graphics/cg/PathCG.cpp:
(WebCore::Path::strokeBoundingRect):
* platform/graphics/openvg/PathOpenVG.cpp:
(WebCore::Path::strokeBoundingRect):
(WebCore::Path::length):
(WebCore::Path::pointAtLength):
(WebCore::Path::normalAngleAtLength):
* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::strokeBoundingRect):
(WebCore::Path::length):
(WebCore::Path::pointAtLength):
(WebCore::Path::normalAngleAtLength):
* platform/graphics/skia/PathSkia.cpp:
(WebCore::Path::strokeBoundingRect):
* platform/graphics/wince/PathWinCE.cpp:
(WebCore::Path::strokeBoundingRect):
* platform/graphics/wx/PathWx.cpp:
(WebCore::Path::strokeBoundingRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80557
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 8 Mar 2011 10:17:59 +0000 (10:17 +0000)]
2011-03-08 Philippe Normand <pnormand@igalia.com>
Unreviewed, updated GTK baselines of fast/text and 2 SVG
text-related tests after r80526.
* platform/gtk/fast/text/international/complex-character-based-fallback-expected.txt:
* platform/gtk/fast/text/international/thai-line-breaks-expected.txt:
* platform/gtk/fast/text/large-text-composed-char-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
* platform/gtk/svg/text/text-intro-05-t-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80556
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 8 Mar 2011 10:04:13 +0000 (10:04 +0000)]
2011-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Do not set juntion sides on scrollbar stepper buttons
https://bugs.webkit.org/show_bug.cgi?id=55868
Fixes rendering of steppers for themes using rounded stepper
buttons on scrollbars like Adwaita.
* platform/gtk/ScrollbarThemeGtk3.cpp:
(WebCore::ScrollbarThemeGtk::paintButton):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80555
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 8 Mar 2011 10:00:38 +0000 (10:00 +0000)]
2011-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Use doubles instead of integers for coordinates when rendering arrows
https://bugs.webkit.org/show_bug.cgi?id=55866
To prevent off-by-one rounding errors.
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::paintMenuList):
* platform/gtk/ScrollbarThemeGtk3.cpp:
(WebCore::ScrollbarThemeGtk::paintButton):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80554
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 8 Mar 2011 09:54:26 +0000 (09:54 +0000)]
2011-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add layoutTestController.setValueForUser() after r80412
https://bugs.webkit.org/show_bug.cgi?id=55862
* platform/gtk/Skipped: Unskip test
fast/forms/onchange-setvalueforuser.html that passes now.
2011-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add layoutTestController.setValueForUser() after r80412
https://bugs.webkit.org/show_bug.cgi?id=55862
Add setValueForUser method to DumpRenderTreeSupportGTK.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setValueForUser):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add layoutTestController.setValueForUser() after r80412
https://bugs.webkit.org/show_bug.cgi?id=55862
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setValueForUser): Implement setValueForUser()
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80553
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Tue, 8 Mar 2011 09:27:32 +0000 (09:27 +0000)]
2011-03-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [Symbian] [WK2] Fix building WebKit 2 API tests
https://bugs.webkit.org/show_bug.cgi?id=55876
Make sure TESTS_SOURCE_DIR is set for Symbian the same way
as it is for WK1.
* UIProcess/API/qt/tests/qgraphicswkview/tst_qgraphicswkview.cpp:
(tst_QGraphicsWKView::loadEmptyPage):
* UIProcess/API/qt/tests/tests.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80552
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Tue, 8 Mar 2011 09:14:10 +0000 (09:14 +0000)]
2011-03-08 Markus Goetz <guruz@guruz.de>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Use the QNetworkAccessManager zerocopy feature
https://bugs.webkit.org/show_bug.cgi?id=50082
The feature will be introduced in Qt 4.8.
This patch is backwards compatible with Qt 4.7.
* WebCore.pro:
* platform/SharedBuffer.cpp:
* platform/SharedBuffer.h:
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::bufferedData):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::downloadProgress):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::start):
* platform/network/qt/QNetworkReplyHandler.h:
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::supportsBufferedData):
(WebCore::ResourceHandle::bufferedData):
* platform/qt/SharedBufferQt.cpp:
(WebCore::SharedBuffer::wrapQtByteBlock):
(WebCore::SharedBuffer::hasPlatformData):
(WebCore::SharedBuffer::platformData):
(WebCore::SharedBuffer::platformDataSize):
(WebCore::SharedBuffer::maybeTransferPlatformData):
(WebCore::SharedBuffer::clearPlatformData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80551
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 8 Mar 2011 09:13:01 +0000 (09:13 +0000)]
2011-03-08 Noel Gordon <noel.gordon@gmail.com>
Reviewed by James Robinson.
[Chromium] Rebaseline CSS3 elliptical gradient tests linux, win32
https://bugs.webkit.org/show_bug.cgi?id=55742
Skia CSS3 elliptical gradient support was added on r79063; rebaseline the associated
win32 and linux tests. There are separate linux results herein due to (minor) pixel
differences with win32. See the bug for the diff images.
* platform/chromium-linux/fast/gradients/css3-color-stop-units-expected.checksum: Added.
* platform/chromium-linux/fast/gradients/css3-color-stop-units-expected.png: Added.
* platform/chromium-linux/fast/gradients/css3-color-stops-expected.checksum: Added.
* platform/chromium-linux/fast/gradients/css3-color-stops-expected.png: Added.
* platform/chromium-linux/fast/gradients/css3-linear-angle-gradients-expected.checksum: Added.
* platform/chromium-linux/fast/gradients/css3-linear-angle-gradients-expected.png: Added.
* platform/chromium-linux/fast/gradients/css3-radial-gradients-expected.checksum: Added.
* platform/chromium-linux/fast/gradients/css3-radial-gradients-expected.png: Added.
* platform/chromium-linux/fast/gradients/css3-radial-gradients2-expected.checksum: Added.
* platform/chromium-linux/fast/gradients/css3-radial-gradients2-expected.png: Added.
* platform/chromium-linux/fast/gradients/css3-repeating-radial-gradients-expected.checksum: Added.
* platform/chromium-linux/fast/gradients/css3-repeating-radial-gradients-expected.png: Added.
* platform/chromium-win/fast/gradients/css3-color-stop-units-expected.checksum: Added.
* platform/chromium-win/fast/gradients/css3-color-stop-units-expected.png: Added.
* platform/chromium-win/fast/gradients/css3-color-stops-expected.checksum: Added.
* platform/chromium-win/fast/gradients/css3-color-stops-expected.png: Added.
* platform/chromium-win/fast/gradients/css3-linear-angle-gradients-expected.checksum: Added.
* platform/chromium-win/fast/gradients/css3-linear-angle-gradients-expected.png: Added.
* platform/chromium-win/fast/gradients/css3-radial-gradients-expected.checksum: Added.
* platform/chromium-win/fast/gradients/css3-radial-gradients-expected.png: Added.
* platform/chromium-win/fast/gradients/css3-radial-gradients2-expected.checksum: Added.
* platform/chromium-win/fast/gradients/css3-radial-gradients2-expected.png: Added.
* platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.checksum: Added.
* platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.png: Added.
* platform/chromium-win/fast/gradients/css3-repeating-radial-gradients-expected.checksum: Added.
* platform/chromium-win/fast/gradients/css3-repeating-radial-gradients-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80550
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Tue, 8 Mar 2011 09:06:42 +0000 (09:06 +0000)]
2011-03-08 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Add script_shell_command to WebKitPort
https://bugs.webkit.org/show_bug.cgi?id=55925
Add a central place where we generate the shell command from the script name.
This function will be used later to detect the correct script interpreter on Win32.
* Scripts/webkitpy/common/config/ports.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/tool/steps/abstractstep.py:
* Scripts/webkitpy/tool/steps/preparechangelog.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80549
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Tue, 8 Mar 2011 08:45:12 +0000 (08:45 +0000)]
2011-03-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix compilation warnings after r80429
https://bugs.webkit.org/show_bug.cgi?id=55864
* platform/gtk/WidgetGtk.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80548
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 8 Mar 2011 08:21:54 +0000 (08:21 +0000)]
2011-03-08 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK build fix after r80536
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80547
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 8 Mar 2011 08:10:04 +0000 (08:10 +0000)]
2011-03-08 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Martin Robinson.
[Gtk] toDataURL uses incorrect quality value when saving GdkPixbuf to buffer
https://bugs.webkit.org/show_bug.cgi?id=55878
Enable a passing test now that we properly use the quality value when requesting
a GdkPixbuf to be saved into a buffer.
* platform/gtk/Skipped:
2011-03-08 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Martin Robinson.
[Gtk] toDataURL uses incorrect quality value when saving GdkPixbuf to buffer
https://bugs.webkit.org/show_bug.cgi?id=55878
Multiply the quality parameter by 100 to put it in the range [0, 100] as needed
when saving GdkPixbuf to a buffer.
* platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::ImageBuffer::toDataURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80546
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ukai@chromium.org [Tue, 8 Mar 2011 07:49:42 +0000 (07:49 +0000)]
Unreviewed, update chromium test expectations.
Looks editing/pasteboard/data-transfer-items.html is slow.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80545
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dcheng@chromium.org [Tue, 8 Mar 2011 07:47:14 +0000 (07:47 +0000)]
2011-03-07 Daniel Cheng <dcheng@chromium.org>
Unreviewed.
Final build fix for r80536.
* DerivedSources.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80544
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Tue, 8 Mar 2011 07:33:34 +0000 (07:33 +0000)]
2011-03-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kent Tamura.
[EFL] Adjust functions of WebCore's efl port to WebKit coding style
https://bugs.webkit.org/show_bug.cgi?id=55924
Adjust webkit style to PlatformKeyboardEventEfl, PlatformMouseEventEfl and WidgetEfl files.
* platform/efl/PlatformKeyboardEventEfl.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
* platform/efl/PlatformMouseEventEfl.cpp:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
* platform/efl/WidgetEfl.cpp:
(WebCore::Widget::frameRectsChanged):
(WebCore::Widget::setEvasObject):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80543
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Tue, 8 Mar 2011 07:27:28 +0000 (07:27 +0000)]
2011-03-07 Andy Estes <aestes@apple.com>
Reviewed by Dan Bernstein.
REGRESSION (r79060): Timestamp is missing from tweets in twitter.
https://bugs.webkit.org/show_bug.cgi?id=55228
A change to the date parser to handle the case where the year is
specified before the time zone inadvertently started accepting strings
such as '+0000' as valid years. Those strings actually represent time
zones in an offset of hours and minutes from UTC, not years.
* wtf/DateMath.cpp:
(WTF::parseDateFromNullTerminatedCharacters): If the current character
in dateString is '+' or '-', do not try to parse the next token as a
year.
2011-03-07 Andy Estes <aestes@apple.com>
Reviewed by Dan Bernstein.
REGRESSION (r79060): Timestamp is missing from tweets in twitter.
https://bugs.webkit.org/show_bug.cgi?id=55228
* fast/js/date-parse-test-expected.txt:
* fast/js/script-tests/date-parse-test.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80542
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dcheng@chromium.org [Tue, 8 Mar 2011 07:18:01 +0000 (07:18 +0000)]
2011-03-07 Daniel Cheng <dcheng@chromium.org>
Unreviewed.
More build fixes for r80536.
* CMakeLists.txt:
* platform/chromium/ClipboardChromium.cpp:
* platform/chromium/ClipboardChromium.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80541
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Tue, 8 Mar 2011 07:05:00 +0000 (07:05 +0000)]
2011-03-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Adjust functions of ScrollbarEfl.cpp to WebKit coding style
https://bugs.webkit.org/show_bug.cgi?id=55917
Adjust webkit style to ScrollbarEfl files.
* platform/efl/ScrollbarEfl.cpp:
(scrollbarEflEdjeMessage):
(ScrollbarEfl::setParent):
(ScrollbarEfl::updateThumbPositionAndProportion):
(ScrollbarEfl::frameRectsChanged):
(ScrollbarEfl::paint):
* platform/efl/ScrollbarEfl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80540
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ukai@chromium.org [Tue, 8 Mar 2011 06:45:24 +0000 (06:45 +0000)]
Unreviewed, update chromium test expectations.
Fix jquery/effects.html and fast/viewpoert/viewport-129.html
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80539
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dcheng@chromium.org [Tue, 8 Mar 2011 06:18:13 +0000 (06:18 +0000)]
2011-03-07 Daniel Cheng <dcheng@chromium.org>
Unreviewed.
Build fix for Chromium after r80536.
* platform/chromium/DataTransferItemChromium.cpp:
* platform/chromium/DataTransferItemsChromium.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80538
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 8 Mar 2011 05:58:26 +0000 (05:58 +0000)]
2011-03-07 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
add webkit-patch attach-to-bug for posting to bugzilla from the commandline
https://bugs.webkit.org/show_bug.cgi?id=55749
* Scripts/webkitpy/tool/commands/upload.py:
* Scripts/webkitpy/tool/commands/upload_unittest.py:
* Scripts/webkitpy/tool/steps/__init__.py:
* Scripts/webkitpy/tool/steps/attachtobug.py: Added.
* Scripts/webkitpy/tool/steps/options.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80537
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dcheng@chromium.org [Tue, 8 Mar 2011 05:48:33 +0000 (05:48 +0000)]
2011-03-07 Daniel Cheng <dcheng@chromium.org>
Reviewed by David Levin.
Add support for DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=55115
Layout test to verify that the basic properties of dataTransfer.items function as expected.
* editing/pasteboard/data-transfer-items-expected.txt: Added.
* editing/pasteboard/data-transfer-items.html: Added.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
2011-03-07 Daniel Cheng <dcheng@chromium.org>
Reviewed by David Levin.
Add support for DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=55115
This patch adds stubs for DataTransferItems/DataTransferItem as well as implementing the
basic functionality on the Chromium port. With the exception of DataTransferItem::getAsFile,
all functionality on the DataTransferItems collection has been implemented.
This change does not actually hook up DataTransferItems to reflect the actual contents of a
drop/paste operation or to allow mutation of data in a copy/drag start yet. That will be
enabled via several followup patches.
Test: editing/pasteboard/data-transfer-items.html
* Android.mk:
* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/generic/RuntimeEnabledFeatures.cpp:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled):
(WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled):
* bindings/scripts/CodeGeneratorV8.pm: Do not emit an #include line for DOMString, since it's built-in.
* dom/Clipboard.h:
(WebCore::Clipboard::policy):
* dom/Clipboard.idl:
* dom/DataTransferItem.cpp: Added.
* dom/DataTransferItem.h: Added.
(WebCore::DataTransferItem::~DataTransferItem):
* dom/DataTransferItem.idl: Added.
* dom/DataTransferItems.h: Added.
(WebCore::DataTransferItems::~DataTransferItems):
* dom/DataTransferItems.idl: Added.
* dom/StringCallback.cpp: Added.
(WebCore::StringCallback::scheduleCallback):
* dom/StringCallback.h: Added.
(WebCore::StringCallback::~StringCallback):
* dom/StringCallback.idl: Added.
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::items):
* platform/chromium/ClipboardChromium.h:
* platform/chromium/DataTransferItemChromium.cpp: Added.
(WebCore::DataTransferItemChromium::create):
(WebCore::DataTransferItemChromium::DataTransferItemChromium):
(WebCore::DataTransferItemChromium::kind):
(WebCore::DataTransferItemChromium::type):
(WebCore::DataTransferItemChromium::getAsString):
* platform/chromium/DataTransferItemChromium.h: Added.
* platform/chromium/DataTransferItemsChromium.cpp: Added.
(WebCore::DataTransferItemsChromium::create):
(WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
(WebCore::DataTransferItemsChromium::length):
(WebCore::DataTransferItemsChromium::item):
(WebCore::DataTransferItemsChromium::deleteItem):
(WebCore::DataTransferItemsChromium::clear):
(WebCore::DataTransferItemsChromium::add):
* platform/chromium/DataTransferItemsChromium.h: Added.
2011-03-07 Daniel Cheng <dcheng@chromium.org>
Reviewed by David Levin.
Add support for DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=55115
Add new runtime enabled flag for data transfer items feature.
* public/WebRuntimeFeatures.h:
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableDataTransferItems):
(WebKit::WebRuntimeFeatures::isDataTransferItemsEnabled):
2011-03-07 Daniel Cheng <dcheng@chromium.org>
Reviewed by David Levin.
Add support for DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=55115
Enable data transfer items in DRT.
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80536
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 8 Mar 2011 05:41:06 +0000 (05:41 +0000)]
2011-03-06 Ojan Vafai <ojan@chromium.org>
Reviewed by Tony Chang.
[test dashboard] pull treemap files
https://bugs.webkit.org/show_bug.cgi?id=55852
* TestResultServer/handlers/dashboardhandler.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80535
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ukai@chromium.org [Tue, 8 Mar 2011 05:22:41 +0000 (05:22 +0000)]
Unreviewed, update chromium test expectations.
Update fast/text/large-text-composed-char.html on Windows
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80534
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 8 Mar 2011 05:19:30 +0000 (05:19 +0000)]
2011-03-07 Victoria Kirst <vrk@google.com>
Reviewed by Mihai Parparita.
Rebaseline GPU media/video-display-toggle.html for snow leopard
https://bugs.webkit.org/show_bug.cgi?id=55920
* platform/chromium-gpu-mac/media/video-display-toggle-expected.checksum:
* platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
* platform/chromium-gpu-mac/media/video-no-audio-expected.checksum:
* platform/chromium-gpu-mac/media/video-no-audio-expected.png:
* platform/chromium-gpu-mac/media/video-volume-slider-expected.checksum:
* platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80533
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ukai@chromium.org [Tue, 8 Mar 2011 05:06:37 +0000 (05:06 +0000)]
Unreviewed, update chromium test expectations.
Update fast/viewport/viewport-{128,129}.html
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80532
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dcheng@chromium.org [Tue, 8 Mar 2011 04:49:37 +0000 (04:49 +0000)]
2011-03-07 Daniel Cheng <dcheng@chromium.org>
Unreviewed.
Updated Skipped lists for editing/pasteboard/onpaste-text-html-types.html.
https://bugs.webkit.org/show_bug.cgi?id=55921
https://bugs.webkit.org/show_bug.cgi?id=55922
* platform/qt-wk2/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80531
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 8 Mar 2011 04:07:13 +0000 (04:07 +0000)]
2011-03-07 Ryosuke Niwa <rniwa@webkit.org>
Chromium build fix.
* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80530
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ukai@chromium.org [Tue, 8 Mar 2011 04:02:06 +0000 (04:02 +0000)]
Unreviewed, update chromium test expectations.
Update fast/text/large-text-composed-char-dos.html
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80529
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 8 Mar 2011 03:54:41 +0000 (03:54 +0000)]
2011-03-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
selectionHasStyle and selectionStartHasStyle should use EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55902
selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration.
* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Calls selectionHasStyle.
2011-03-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
selectionHasStyle and selectionStartHasStyle should use EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55902
selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration.
* WebView/WebHTMLView.mm: Removed unused selectionHasStyle.
(-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Calls Editor::selectionHasStyle.
2011-03-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
selectionHasStyle and selectionStartHasStyle should use EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55902
Deployed EditingStyle in selectionHasStyle and selectionStartHasStyle.
This allowed us to move triStateOfStyle from Editor.cpp to EditingStyle.cpp.
Also changed the argument lists of selectionHasStyle and selectionStartHasStyle
to take a property id and a value instead of a CSSMutableStyleDeclaration to cleanup
call sites of these two functions.
* WebCore.exp.in: Updated the signature of selectionHasStyle. No longer exports
selectionStartHasStyle because it's not called anywhere outside of WebCore.
* WebCore.order: Ditto.
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::EditingStyle): Added a new constructor that takes a property id
and a property value.
(WebCore::EditingStyle::triStateOfStyle): Moved from Editor.cpp.
* editing/EditingStyle.h:
(WebCore::EditingStyle::create): Added.
* editing/Editor.cpp:
(WebCore::Editor::selectionStartHasStyle): Takes a property id and a value instead of
a CSSStyleDeclaration.
(WebCore::Editor::selectionHasStyle): Ditto.
* editing/Editor.h: Updated the signatures of selectionStartHasStyle and selectionHasStyle.
* editing/EditorCommand.cpp:
(WebCore::executeToggleStyle): Calls selectionStartHasStyle and selectionHasStyle.
(WebCore::stateStyle): Ditto.
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::checkOrEnableIfNeeded): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80528
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ukai@chromium.org [Tue, 8 Mar 2011 03:31:20 +0000 (03:31 +0000)]
Unreviewed, update chromium test expectations.
Add svg/css/rect-gradient-stroke-shadow.svg added by webkit r80515
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80527
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 8 Mar 2011 03:17:48 +0000 (03:17 +0000)]
2011-03-07 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
REGRESSION (HTML5 tree builder): Text selection in a large text document is extremely slow
https://bugs.webkit.org/show_bug.cgi?id=55898
* platform/mac/fast/text/large-text-composed-char-expected.txt: The huge text run is split
into multiple text nodes again.
2011-03-07 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
REGRESSION (HTML5 tree builder): Text selection in a large text document is extremely slow
https://bugs.webkit.org/show_bug.cgi?id=55898
<rdar://problem/
9095839> REGRESSION: Mail hangs with a certain large mail message when
linkifying e-mail addresses in in -[DOMCharacterData setData:]
Changes render tree of fast/text/large-text-composed-char.html, but not image results.
* dom/CharacterData.cpp: (WebCore::CharacterData::parserAppendData):
Changed parserAppendData() to accept a maximum length, and moved code from Text::createWithLengthLimit().
* dom/CharacterData.h: Moved a constant for maximum length from Text.h.
* dom/Text.cpp: (WebCore::Text::createWithLengthLimit):
* dom/Text.h:
This function was unused in ToT. Moved code around to share with CharacterData.
* html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertTextNode):
Chnaged to split large text nodes while parsing again.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80526
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ukai@chromium.org [Tue, 8 Mar 2011 03:13:54 +0000 (03:13 +0000)]
Unreviewed, update chromium test expectations.
svg/W3C-SVG-1.1/struct-image-07-t.svg failing
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80525
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Tue, 8 Mar 2011 03:07:49 +0000 (03:07 +0000)]
2011-03-03 Hayato Ito <hayato@chromium.org>
Reviewed by Mihai Parparita.
[NRWT] Clear output image file used by DumpRenderTree to make sure the
previous image should not be used in the ChromiumDriver.
Also make sure that output image from the ChromiumDriver should be ''
(empty string) if a test crashes for consistency with the WebKitDriver
implementation.
https://bugs.webkit.org/show_bug.cgi?id=55746
* Scripts/webkitpy/layout_tests/port/chromium.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80524
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 8 Mar 2011 02:32:53 +0000 (02:32 +0000)]
2011-03-07 Damian Kaleta <dkaleta@apple.com>
Reviewed by Anders Carlsson.
QuickTime plugin should opt in to a 32-bit non-executable heap
https://bugs.webkit.org/show_bug.cgi?id=55704
<rdar://problem/
8105706>
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::pluginNeedsExecutableHeap): Decides per plugin if it should opt-in to a 32-bit non-executable heap.
By default it should opt-out.
(WebKit::PluginProcessProxy::PluginProcessProxy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80523
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ukai@chromium.org [Tue, 8 Mar 2011 02:25:39 +0000 (02:25 +0000)]
Unreviewed, update chromium test expectations.
Mark several jquery tests slow for debug build.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80522
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 8 Mar 2011 02:19:16 +0000 (02:19 +0000)]
2011-03-07 Alice Boxhall <aboxhall@chromium.org>
Reviewed by Adam Barth.
Fix platform/image-encoders/JPEGImageEncoder.cpp empty_output_buffer() behaviour
https://bugs.webkit.org/show_bug.cgi?id=54522
Fix jpegEmptyOutputBuffer() by ignoring free_in_buffer value as required.
No new tests, as this code is not yet used in WebKit. Once this code is used to implement canvas.toDataUrl(), the canvas tests will exercise it.
* platform/image-encoders/JPEGImageEncoder.cpp:
(WebCore::jpegEmptyOutputBuffer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80521
268f45cc-cd09-0410-ab3c-
d52691b4dbfc