WebKit-https.git
11 years ago2009-12-08 Dominik Röttsches <dominik.roettsches@access-company.com>
eric@webkit.org [Tue, 8 Dec 2009 14:58:50 +0000 (14:58 +0000)]
2009-12-08  Dominik Röttsches  <dominik.roettsches@access-company.com>

        Reviewed by Gustavo Noronha Silva.

        [Gtk] Create a TextBreakIterator implementation based on GLib (without ICU)
        https://bugs.webkit.org/show_bug.cgi?id=31469

        Removing hybrid configuration for --with-unicode-backend=glib
        ICU not required anymore.

        * autotools/webkit.m4:
2009-12-08  Dominik Röttsches  <dominik.roettsches@access-company.com>

        Reviewed by Gustavo Noronha Silva.

        [Gtk] Create a TextBreakIterator implementation based on GLib (without ICU)
        https://bugs.webkit.org/show_bug.cgi?id=31469

        Added a TextBreakIterator implementation based on GLib and pango,
        which allows compiling WebCore without ICU.

        * GNUmakefile.am:
        * platform/text/gtk/TextBreakIteratorGtk.cpp: Added.
        (WebCore::):
        (WebCore::setUpIterator):
        (WebCore::characterBreakIterator):
        (WebCore::cursorMovementIterator):
        (WebCore::wordBreakIterator):
        (WebCore::lineBreakIterator):
        (WebCore::sentenceBreakIterator):
        (WebCore::textBreakFirst):
        (WebCore::textBreakLast):
        (WebCore::textBreakNext):
        (WebCore::textBreakPrevious):
        (WebCore::textBreakPreceding):
        (WebCore::textBreakFollowing):
        (WebCore::textBreakCurrent):
        (WebCore::isTextBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 8 Dec 2009 14:35:02 +0000 (14:35 +0000)]
2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Update Gtk's custom prototype-inheritance-2-expected.txt, after enabling filters
        (As gtk builds with geolocation, unlike the other platforms, it needs its own results)

        This turns the Gtk slave to green again.

        * platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-08 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Tue, 8 Dec 2009 13:21:03 +0000 (13:21 +0000)]
2009-12-08  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Change the way cookies are retrieved in the WebInspector frontend.

        Moved the cookie filtering from the native code into the frontend so that
        all cookies can be retrieved regardless of the associated domain
        (required for certain audits to run.)
        https://bugs.webkit.org/show_bug.cgi?id=32160

        * inspector/cookie-resource-match-expected.txt: Added.
        * inspector/cookie-resource-match.html: Added.
2009-12-08  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Change the way cookies are retrieved in the WebInspector frontend.

        Moved the cookie filtering from the native code into the frontend so that
        all cookies can be retrieved regardless of the associated domain
        (required for certain audits to run.)
        https://bugs.webkit.org/show_bug.cgi?id=32160

        Test: inspector/cookie-resource-match.html

        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::getCookies):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::getCookies):
        * inspector/InspectorController.h:
        * inspector/front-end/CookieItemsView.js:
        (WebInspector.CookieItemsView.prototype.update.callback):
        (WebInspector.CookieItemsView.prototype.update):
        (WebInspector.CookieItemsView.prototype._cookiesForDomain):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.Cookies.getCookiesAsync):
        (WebInspector.Cookies.cookieMatchesResourceURL):
        (WebInspector.Cookies.cookieDomainMatchesResourceDomain):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource):
        (WebInspector.Resource.prototype.get documentURL):
        (WebInspector.Resource.prototype.set documentURL):
        * inspector/front-end/inspector.js:
        (WebInspector.addResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 8 Dec 2009 12:55:43 +0000 (12:55 +0000)]
2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Touch svgtags.in, in order to force SVGNames.* regeneration. Praying for gtk bot to be fixed :-)

        * svg/svgtags.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 8 Dec 2009 12:30:47 +0000 (12:30 +0000)]
2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Trying to force a rebuild on the Gtk slave. If that doesn't work, someone must force a rebuild from scratch.

        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 8 Dec 2009 11:51:42 +0000 (11:51 +0000)]
2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Rubber-stamped by Maciej Stachowiak.

        Turn on (SVG) Filters for Gtk.
        https://bugs.webkit.org/show_bug.cgi?id=32224

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 8 Dec 2009 11:21:23 +0000 (11:21 +0000)]
2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Skip some tests that fail for a longer period on the SnowLeopard bot. Filed two bugs, notifying the authors.

        * platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 8 Dec 2009 10:58:55 +0000 (10:58 +0000)]
2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Oops forgot to update three results -> Qt slave green again.

        * platform/qt/svg/filters/feGaussianBlur-expected.txt:
        * platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
        * platform/qt/svg/filters/feOffset-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 8 Dec 2009 10:47:57 +0000 (10:47 +0000)]
2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Now that the Qt slave has been rebuilt, reenable all tests that failed
        because of the build problems (Qt slave didn't rebuild all files with ENABLE_FILTERS set).

        Update some Qt specfic filter test results.

        * platform/qt/Skipped:
        * platform/qt/svg/filters/feComposite-expected.txt:
        * platform/qt/svg/filters/feMerge-expected.txt:
        * platform/qt/svg/filters/feTile-expected.txt:
        * platform/qt/svg/filters/shadow-on-filter-expected.txt:
        * platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
        * platform/qt/svg/filters/sourceAlpha-expected.txt:
        * platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
        * platform/qt/svg/filters/subRegion-one-effect-expected.txt:
        * platform/qt/svg/filters/subRegion-two-effects-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-06 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 8 Dec 2009 10:19:28 +0000 (10:19 +0000)]
2009-12-06  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: provide custom context menu in the front-end window.

        https://bugs.webkit.org/show_bug.cgi?id=32200

        * English.lproj/localizedStrings.js:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSInspectorFrontendHostCustom.cpp:
        (WebCore::JSInspectorFrontendHost::showContextMenu):
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::contextMenuItemSelected):
        (WebCore::InspectorFrontend::contextMenuCleared):
        * inspector/InspectorFrontend.h:
        * inspector/InspectorFrontendHost.cpp:
        (WebCore::InspectorFrontendHost::InspectorFrontendHost):
        (WebCore::InspectorFrontendHost::~InspectorFrontendHost):
        (WebCore::InspectorFrontendHost::showContextMenu):
        (WebCore::InspectorFrontendHost::contextMenuItemSelected):
        (WebCore::InspectorFrontendHost::contextMenuCleared):
        * inspector/InspectorFrontendHost.h:
        (WebCore::InspectorFrontendHost::MenuSelectionHandler::create):
        (WebCore::InspectorFrontendHost::MenuSelectionHandler::~MenuSelectionHandler):
        (WebCore::InspectorFrontendHost::MenuSelectionHandler::disconnect):
        (WebCore::InspectorFrontendHost::MenuSelectionHandler::contextMenuItemSelected):
        (WebCore::InspectorFrontendHost::MenuSelectionHandler::contextMenuCleared):
        (WebCore::InspectorFrontendHost::MenuSelectionHandler::MenuSelectionHandler):
        * inspector/InspectorFrontendHost.idl:
        * inspector/front-end/ContextMenu.js: Added.
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector.loaded):
        (WebInspector.documentContextMenu):
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::ContextMenuController):
        (WebCore::ContextMenuController::clearContextMenu):
        (WebCore::ContextMenuController::handleContextMenuEvent):
        (WebCore::ContextMenuController::showContextMenu):
        (WebCore::ContextMenuController::createContextMenu):
        (WebCore::ContextMenuController::contextMenuItemSelected):
        * page/ContextMenuController.h:
        * page/ContextMenuSelectionHandler.h: Added.
        (WebCore::ContextMenuSelectionHandler::ContextMenuSelectionHandler):
        (WebCore::ContextMenuSelectionHandler::~ContextMenuSelectionHandler):
        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::checkOrEnableIfNeeded):
        * platform/ContextMenuItem.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Kenneth Rohde Christiansen.
ossy@webkit.org [Tue, 8 Dec 2009 10:04:46 +0000 (10:04 +0000)]
Rubber-stamped by Kenneth Rohde Christiansen.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-08
[Qt] Build fix of duplicated platform/graphics/filters/FEGaussianBlur.cpp in WebCore.pro after enabled svg filters.

No new tests needed.
* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-08 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Tue, 8 Dec 2009 08:32:26 +0000 (08:32 +0000)]
2009-12-08  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Darin Adler.

        Add tests that WebSocket protocol argument works.
        https://bugs.webkit.org/show_bug.cgi?id=3178

        * websocket/tests/bad-sub-protocol-expected.txt: Added.
        * websocket/tests/bad-sub-protocol.html: Added.
        * websocket/tests/handshake-fail-by-sub-protocol-mismatch-expected.txt: Added.
        * websocket/tests/handshake-fail-by-sub-protocol-mismatch.html: Added.
        * websocket/tests/protocol-test_wsh.py: Added.
        * websocket/tests/script-tests/bad-sub-protocol.js: Added.
        * websocket/tests/script-tests/handshake-fail-by-sub-protocol-mismatch.js: Added.
        * websocket/tests/script-tests/sub-protocol.js: Added.
        * websocket/tests/sub-protocol-expected.txt: Added.
        * websocket/tests/sub-protocol.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Unreviewed fix to make QtBuildBot green.
ossy@webkit.org [Tue, 8 Dec 2009 06:00:08 +0000 (06:00 +0000)]
[Qt] Unreviewed fix to make QtBuildBot green.
Skip failing tests caused by r51828 (Turn on (SVG) Filters for Qt.)
https://bugs.webkit.org/show_bug.cgi?id=32224
http://build.webkit.org/results/Qt%20Linux%20Release/r51828%20(4620)/results.html

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Tue, 8 Dec 2009 05:58:34 +0000 (05:58 +0000)]
2009-12-07  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Levin.

        [check-webkit-style] S_OK is a fine identifier
        https://bugs.webkit.org/show_bug.cgi?id=32225

        * Scripts/modules/cpp_style.py:
        * Scripts/modules/cpp_style_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Tue, 8 Dec 2009 05:48:40 +0000 (05:48 +0000)]
2009-12-07  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        editing/selection/last-empty-inline is failing in Windows
        https://bugs.webkit.org/show_bug.cgi?id=31985

        * editing/selection/last-empty-inline-expected.txt:
        * editing/selection/last-empty-inline.html:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Tue, 8 Dec 2009 05:29:46 +0000 (05:29 +0000)]
2009-12-07  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        Add a function to show render tree for debugging
        https://bugs.webkit.org/show_bug.cgi?id=31288

        No new tests because this just adds a function for debugging.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::showRenderObject):
        (WebCore::RenderObject::showRenderTreeAndMark):
        (showRenderTree):
        * rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Zhe Su <suzhe@chromium.org>
eric@webkit.org [Tue, 8 Dec 2009 04:55:46 +0000 (04:55 +0000)]
2009-12-07  Zhe Su  <suzhe@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] accesskey is not supported on Chromium Mac.
        https://bugs.webkit.org/show_bug.cgi?id=32213

        This change fixes (partially) the accesskey issue by decoupling the
        code for handling accesskeys and system keys. Because on Mac,
        the modifiers of accesskeys are ctrl+alt, which are not marked as
        system keys.
        In order to fully fix this issue, some changes in Chromium code is
        also required.

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::keyEvent):
        (WebKit::WebViewImpl::charEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Victor Wang <victorw@chromium.org>
eric@webkit.org [Tue, 8 Dec 2009 04:33:34 +0000 (04:33 +0000)]
2009-12-07  Victor Wang  <victorw@chromium.org>

        Reviewed by Dimitri Glazkov.

        Implement NamedPropertyEnumerator and IndexedPropertyEnumerator for
        V8 NPObject. This should make the object enumerable and fix the
        enumeration issue in layout test plugins/netscape-enumerate.html.

        Also fix some existing style issues per webkit style guidelines.

        https://bugs.webkit.org/show_bug.cgi?id=32254

        Test: plugins/netscape-enumerate.html

        * bindings/v8/V8NPObject.cpp:
        (npObjectInvokeImpl):
        (npObjectInvokeDefaultHandler):
        (npObjectGetProperty):
        (npObjectPropertyEnumerator):
        (npObjectNamedPropertyEnumerator):
        (npObjectIndexedPropertyEnumerator):
        (createV8ObjectForNPObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Tue, 8 Dec 2009 04:19:59 +0000 (04:19 +0000)]
2009-12-07  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Fragments now make WebSocket URL parsing fail.
        https://bugs.webkit.org/show_bug.cgi?id=32144

        * websocket/tests/script-tests/url-parsing.js:
        * websocket/tests/script-tests/url-with-fragment.js: Removed.
        * websocket/tests/url-parsing-expected.txt:
        * websocket/tests/url-with-fragment-expected.txt: Removed.
        * websocket/tests/url-with-fragment.html: Removed.
2009-12-07  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Fragments now make WebSocket URL parsing fail.
        https://bugs.webkit.org/show_bug.cgi?id=32144

        * websockets/WebSocket.cpp:
        (WebCore::WebSocket::connect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Tue, 8 Dec 2009 04:03:42 +0000 (04:03 +0000)]
2009-12-07  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Darin Adler.

        Fix wrong length parsing in WebSocket.
        https://bugs.webkit.org/show_bug.cgi?id=32203

        These two tests assumed wrong length encoding in frame: it parsed
        length from bytes with 8th bit on.  But spec says length is encoded
        as a series of 7-bit bytes stored in octests with the 8th bit on
        *but the last byte*.
        These tests encodes a frame that has 129 length, so it must be
        \x81\0x01 instead of \x81\0x81.

        * websocket/tests/frame-length-longer-than-buffer_wsh.py:
        * websocket/tests/frame-length-skip_wsh.py:
2009-12-07  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Darin Adler.

        Fix wrong length parsing in WebSocket.
        https://bugs.webkit.org/show_bug.cgi?id=32203

        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::didReceiveData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 8 Dec 2009 03:44:11 +0000 (03:44 +0000)]
2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>

        Rubber-stamped by Maciej Stachowiak.

        Turn on (SVG) Filters for Qt.
        https://bugs.webkit.org/show_bug.cgi?id=32224

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Evan Martin <evan@chromium.org>
eric@webkit.org [Tue, 8 Dec 2009 02:54:52 +0000 (02:54 +0000)]
2009-12-07  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        Chromium: theme scrollbars to match GTK theme.
        Add functions to RenderThemeChromiumLinux to change the scrollbar
        color.

        Since the change is to the Chromium WebKit API layer, testing will
        be in Chromium's test shell.
        http://bugs.webkit.org/show_bug.cgi?id=32048

        Patch from Markus Gutschke <markus@chromium.org>.

        * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
        (WebCore::saturateAndBrighten):
        (WebCore::outlineColor):
        (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
        (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
        * rendering/RenderThemeChromiumLinux.cpp:
        (WebCore::RenderThemeChromiumLinux::setScrollbarColors):
        * rendering/RenderThemeChromiumLinux.h:
        (WebCore::RenderThemeChromiumLinux::thumbInactiveColor):
        (WebCore::RenderThemeChromiumLinux::thumbActiveColor):
        (WebCore::RenderThemeChromiumLinux::trackColor):
2009-12-07  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        Chromium: theme scrollbars to match GTK theme.
        Add API to set the colors.

        Since the change is to the Chromium WebKit API layer, testing will
        be in Chromium's test shell.
        http://bugs.webkit.org/show_bug.cgi?id=32048

        Patch from Markus Gutschke <markus@chromium.org>.

        * public/WebView.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setScrollbarColors):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Tue, 8 Dec 2009 02:50:35 +0000 (02:50 +0000)]
2009-12-07  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Kilzer.

        Bugzilla should show images in git patches
        https://bugs.webkit.org/show_bug.cgi?id=31395

        Attempt to go r51748 again using --directory option of git-apply.

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore
kov@webkit.org [Tue, 8 Dec 2009 02:44:05 +0000 (02:44 +0000)]
WebCore

        Reviewed by Xan Lopez.

        [GTK] Doesn't respect Content-Disposition for downloads, and provides no way for apps to do that
        https://bugs.webkit.org/show_bug.cgi?id=32247

        Allow creating a ResourceResponse from a SoupMessage.

        Covered by API test.

        * platform/network/soup/ResourceResponse.h:
        (WebCore::ResourceResponse::ResourceResponse):
        * platform/network/soup/ResourceResponseSoup.cpp:
        (WebCore::ResourceResponse::updateFromSoupMessage):

WebKit/gtk

        Reviewed by Xan Lopez.

        [GTK] Doesn't respect Content-Disposition for downloads, and provides no way for apps to do that
        https://bugs.webkit.org/show_bug.cgi?id=32247

        Provide a way for applications to respect Content-Disposition, by
        fetching the WebKitNetworkResponse from the frame during
        mime-type-policy-decision-requested.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): Download
        content when Content-Disposition is attachment.
        * tests/testmimehandling.c:
        (server_callback):
        (mime_type_policy_decision_requested_cb):
        * tests/testwebframe.c:
        (test_webkit_web_frame_response):
        (main):
        * webkit/webkitprivate.cpp:
        (WebKit::core):
        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_get_network_response):
        * webkit/webkitwebframe.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Yuzo Fujishima <yuzo@google.com>
eric@webkit.org [Tue, 8 Dec 2009 02:40:46 +0000 (02:40 +0000)]
2009-12-07  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Alexey Proskuryakov.

        Make run-webkit-websocketserver log to stderr rather than to a file.
        https://bugs.webkit.org/show_bug.cgi?id=32234

        * Scripts/run-webkit-websocketserver:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 8 Dec 2009 02:29:28 +0000 (02:29 +0000)]
2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Reverting problematic patch, causing errors.

        Revert r51789 (Avoid zero division during SVGPaintServerPattern::setup()). Crashes on all Windows slaves.
        Reopen bug https://bugs.webkit.org/show_bug.cgi?id=29912.

        * svg/graphics/SVGPaintServerPattern.cpp:
        (WebCore::SVGPaintServerPattern::setup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 8 Dec 2009 02:26:53 +0000 (02:26 +0000)]
2009-12-07  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Add tests for HTMLInputElement::stepUp() and stepDown().
        https://bugs.webkit.org/show_bug.cgi?id=27451

        * fast/forms/input-step-number-expected.txt: Added.
        * fast/forms/input-step-number.html: Added.
        * fast/forms/input-step-range-expected.txt: Added.
        * fast/forms/input-step-range.html: Added.
        * fast/forms/input-step-unsupported-expected.txt: Added.
        * fast/forms/input-step-unsupported.html: Added.
        * fast/forms/script-tests/input-step-number.js: Added.
        * fast/forms/script-tests/input-step-range.js: Added.
        * fast/forms/script-tests/input-step-unsupported.js: Added.

2009-12-07  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Add support for HTMLInputElement::stepUp() and stepDown() for
        type=number and type=range.
        https://bugs.webkit.org/show_bug.cgi?id=27451

        Our implementation of stepUp() and stepDown() rounds the resultant
        value to conform to the step value.
        Change the number-string conversion method for RenderSlider to be
        consistent with type=number.

        Tests: fast/forms/input-step-number.html
               fast/forms/input-step-range.html
               fast/forms/input-step-unsupported.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::rangeUnderflow): Unify the code for NUMBER and RANGE.
        (WebCore::HTMLInputElement::rangeOverflow): Unify the code for NUMBER and RANGE.
        (WebCore::HTMLInputElement::minimum): Renamed from rangeMinimum(), and support for NUMBER.
        (WebCore::HTMLInputElement::maximum): Renamed from rangeMaximum(), and support for NUMBER.
        (WebCore::HTMLInputElement::stepBase):
        (WebCore::HTMLInputElement::stepMismatch): Use stepBase().
        (WebCore::HTMLInputElement::applyStepForNumberOrRange):
        (WebCore::HTMLInputElement::stepUp):
        (WebCore::HTMLInputElement::stepDown):
        (WebCore::HTMLInputElement::formStringFromDouble):
        * html/HTMLInputElement.h:
        (WebCore::HTMLInputElement::stepUp):
        (WebCore::HTMLInputElement::stepDown):
        * html/HTMLInputElement.idl: Add stepUp() and stepDown().
        * rendering/RenderSlider.cpp:
        (WebCore::SliderRange::SliderRange): Sync with rangeMinimum()/rangeMaximum() renaming.
        (WebCore::RenderSlider::updateFromElement): Use formStringFromDouble().
        (WebCore::RenderSlider::setValueForPosition): Use formStringFromDouble().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed: Chromium build fix try 2 (dumb error).
ajwong@chromium.org [Tue, 8 Dec 2009 02:21:21 +0000 (02:21 +0000)]
Not reviewed: Chromium build fix try 2 (dumb error).

* bindings/v8/ScriptValue.h:
(WebCore::ScriptValue::getString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed: Chromium build fix.
ajwong@chromium.org [Tue, 8 Dec 2009 01:55:17 +0000 (01:55 +0000)]
Not reviewed: Chromium build fix.

Fix Chromium build break caused by an added dependency from
ScriptControllerBase to JSDOMWindowShell, and an API change in
ScriptValue.

* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
* bindings/v8/ScriptValue.h:
(WebCore::ScriptValue::getString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: REGRESSION(4.0.4-42a12): Indent does not work for twice modified with backgr...
enrica@apple.com [Tue, 8 Dec 2009 01:31:07 +0000 (01:31 +0000)]
WebCore: REGRESSION(4.0.4-42a12): Indent does not work for twice modified with background text in gmail.
<rdar://problem/7442387>
https://bugs.webkit.org/show_bug.cgi?id=32233

Reviewed by Darin Adler.

Fixes problem in re-creating the correct hierarchy under the new block.
Added extensive testing to cover all the cases.

Test: editing/execCommand/indent-with-style2.html

* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):

LayoutTests: REGRESSION(4.0.4-42a12): Indent does not work for twice modified with background text in gmail.
<rdar://problem/7442387>
https://bugs.webkit.org/show_bug.cgi?id=32233

Reviewed by Darin Adler.

* editing/execCommand/indent-with-style2-expected.txt: Added.
* editing/execCommand/indent-with-style2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Finnur Thorarinsson <finnur.webkit@gmail.com>
eric@webkit.org [Tue, 8 Dec 2009 01:22:23 +0000 (01:22 +0000)]
2009-12-07  Finnur Thorarinsson  <finnur.webkit@gmail.com>

        Reviewed by Darin Fisher.

        A patch for Chromium to restrict the scope of the Gmail focus fix,
        where we set the Selection to 0,0 for content-editable fields and
        also make sure we set the selection end-state for find to select the
        text found (when not focusing a link we found).
        WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=32248

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setFocus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Add some missing files that depend on SVG Filters support, only mac...
zimmermann@webkit.org [Tue, 8 Dec 2009 01:15:57 +0000 (01:15 +0000)]
Not reviewed. Add some missing files that depend on SVG Filters support, only mac supports it for now.
Still one more crash affecting the win slaves, unrelated to the filters patch though.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix for checkouts with a space in the path
aroben@apple.com [Tue, 8 Dec 2009 01:03:41 +0000 (01:03 +0000)]
Windows build fix for checkouts with a space in the path

* win/tools/scripts/auto-version.sh: Quote the output file's directory
before passing it to mkdir.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Unreviewed. Skip a timeouter flakey test.
ossy@webkit.org [Tue, 8 Dec 2009 00:59:30 +0000 (00:59 +0000)]
[Qt] Unreviewed. Skip a timeouter flakey test.

* platform/qt/Skipped: fast/frames/sandboxed-iframe-plugins.html added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Skip yet another test, what a journey...
zimmermann@webkit.org [Tue, 8 Dec 2009 00:51:22 +0000 (00:51 +0000)]
Not reviewed. Skip yet another test, what a journey...

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove ENABLE_SHARED_SCRIPT flags
dimich@chromium.org [Tue, 8 Dec 2009 00:50:21 +0000 (00:50 +0000)]
Remove ENABLE_SHARED_SCRIPT flags
https://bugs.webkit.org/show_bug.cgi?id=32245
This patch was obtained by "git revert" command and then un-reverting of ChangeLog files.

Rubber-stamped by Darin Adler.

* configure.ac:

JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:
* wtf/Platform.h:

WebCore:

* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* WebCore.pro:

WebKit/chromium:

* features.gypi:

WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

WebKitTools:

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Adjust one layout test to the results of the Leopard Intel slave.
zimmermann@webkit.org [Tue, 8 Dec 2009 00:40:22 +0000 (00:40 +0000)]
Not reviewed. Adjust one layout test to the results of the Leopard Intel slave.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Turn Qt slave green again, after landing filters.
zimmermann@webkit.org [Tue, 8 Dec 2009 00:37:30 +0000 (00:37 +0000)]
Not reviewed. Turn Qt slave green again, after landing filters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 8 Dec 2009 00:10:51 +0000 (00:10 +0000)]
2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Force JS binding regeneration, eventually fixing the broken tests on the bots.

        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCorrected expected results
mitz@apple.com [Tue, 8 Dec 2009 00:04:39 +0000 (00:04 +0000)]
Corrected expected results

* platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.checksum:
* platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.png:
* platform/mac/fast/repaint/block-selection-gap-stale-cache-expected.checksum:
* platform/mac/fast/repaint/block-selection-gap-stale-cache-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Simon Fraser.
mitz@apple.com [Tue, 8 Dec 2009 00:02:43 +0000 (00:02 +0000)]
Rubber-stamped by Simon Fraser.

Re-enabled this test now that <rdar://problem/7450481> is fixed.

* fast/repaint/block-selection-gap-in-composited-layer.html: Copied from LayoutTests/fast/repaint/block-selection-gap-in-composited-layer.html.disabled.
* fast/repaint/block-selection-gap-in-composited-layer.html.disabled: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd new exported symbols to finally fix the build.
bweinstein@apple.com [Tue, 8 Dec 2009 00:00:17 +0000 (00:00 +0000)]
Add new exported symbols to finally fix the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* WebView.cpp:
barraclough@apple.com [Mon, 7 Dec 2009 23:53:37 +0000 (23:53 +0000)]
* WebView.cpp:
(WebView::stringByEvaluatingJavaScriptFromString):

Reviewed by NOBODY (Windows build fix part III).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* WebView.cpp:
barraclough@apple.com [Mon, 7 Dec 2009 23:47:45 +0000 (23:47 +0000)]
* WebView.cpp:
(WebView::stringByEvaluatingJavaScriptFromString):

Reviewed by NOBODY (Windows build fix part II).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 7 Dec 2009 23:30:34 +0000 (23:30 +0000)]
2009-12-07  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/7450481> One compositing test keeps DRT in "compositing mode", breaks repaint tests

        The counter that WebView used to keep track of the number of enclosed WebHTMLViews using
        accelerated compositing was hard to manage, and maintained incorrectly in a number of cases.
        This caused one compositing test make DumpRenderTree think that all subsequent tests
        were compositing too.

        Replace this counter with notifications, which are only fired if a client (DRT) requests them. The
        notification informs the client that a WebHTMLView entered compositing mode (or an already-
        compositing WebHTML was added); it does not say when a view becomes uncomposited, or all
        compositing subviews were removed, since this is tricky to get right.

        Change -[WebView _isUsingAcceleratedCompositing] to manually walk the frames, and
        return YES if any document view is composited.

        * WebKit.exp:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView close]):
        (-[WebHTMLView viewDidMoveToSuperview]):
        (-[WebHTMLView attachRootLayer:]):
        (-[WebHTMLView detachRootLayer]):
        * WebView/WebView.mm:
        (+[WebView automaticallyNotifiesObserversForKey:]):
        (-[WebView _postsAcceleratedCompositingNotifications]):
        (-[WebView _setPostsAcceleratedCompositingNotifications:]):
        (-[WebView _isUsingAcceleratedCompositing]):
        * WebView/WebViewData.h:
        * WebView/WebViewInternal.h:
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
barraclough@apple.com [Mon, 7 Dec 2009 23:26:28 +0000 (23:26 +0000)]
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Reviewed by NOBODY (Windows build fixage part I).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 7 Dec 2009 23:15:20 +0000 (23:15 +0000)]
2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Try to fix mac builds by touching svgtags.in - I only tried from-scratch builds.

        * svg/svgtags.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=32184
barraclough@apple.com [Mon, 7 Dec 2009 23:14:04 +0000 (23:14 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=32184
Handle out-of-memory conditions with JSC Ropes with a JS exception, rather than crashing.
Switch from using fastMalloc to tryFastMalloc, pass an ExecState to record the exception on.

Reviewed by Oliver Hunt.

JavaScriptCore:

* API/JSCallbackObjectFunctions.h:
(JSC::::toString):
* API/JSValueRef.cpp:
(JSValueIsStrictEqual):
* JavaScriptCore.exp:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitEqualityOp):
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::functionName):
(JSC::DebuggerCallFrame::calculatedFunctionName):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::addParentForConsoleStart):
* profiler/Profiler.cpp:
(JSC::Profiler::willExecute):
(JSC::Profiler::didExecute):
(JSC::Profiler::createCallIdentifier):
(JSC::createCallIdentifierFromFunctionImp):
* profiler/Profiler.h:
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):
* runtime/DateConstructor.cpp:
(JSC::constructDate):
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::name):
(JSC::InternalFunction::displayName):
(JSC::InternalFunction::calculatedDisplayName):
* runtime/InternalFunction.h:
* runtime/JSCell.cpp:
(JSC::JSCell::getString):
* runtime/JSCell.h:
(JSC::JSValue::getString):
* runtime/JSONObject.cpp:
(JSC::gap):
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::appendStringifiedValue):
* runtime/JSObject.cpp:
(JSC::JSObject::putDirectFunction):
(JSC::JSObject::putDirectFunctionWithoutTransition):
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::get):
* runtime/JSString.cpp:
(JSC::JSString::Rope::~Rope):
(JSC::JSString::resolveRope):
(JSC::JSString::getPrimitiveNumber):
(JSC::JSString::toNumber):
(JSC::JSString::toString):
(JSC::JSString::toThisString):
(JSC::JSString::getStringPropertyDescriptor):
* runtime/JSString.h:
(JSC::JSString::Rope::createOrNull):
(JSC::JSString::Rope::operator new):
(JSC::JSString::value):
(JSC::JSString::tryGetValue):
(JSC::JSString::getIndex):
(JSC::JSString::getStringPropertySlot):
(JSC::JSValue::toString):
* runtime/JSValue.h:
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
* runtime/Operations.cpp:
(JSC::JSValue::strictEqualSlowCase):
* runtime/Operations.h:
(JSC::JSValue::equalSlowCaseInline):
(JSC::JSValue::strictEqualSlowCaseInline):
(JSC::JSValue::strictEqual):
(JSC::jsLess):
(JSC::jsLessEq):
(JSC::jsAdd):
(JSC::concatenateStrings):
* runtime/PropertyDescriptor.cpp:
(JSC::PropertyDescriptor::equalTo):
* runtime/PropertyDescriptor.h:
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):

WebCore:

* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::toHTMLCanvasStyle):
(WebCore::JSCanvasRenderingContext2D::setFillColor):
(WebCore::JSCanvasRenderingContext2D::setStrokeColor):
(WebCore::JSCanvasRenderingContext2D::setShadow):
* bindings/js/ScriptCallStack.cpp:
(WebCore::ScriptCallStack::ScriptCallStack):
(WebCore::ScriptCallStack::initialize):
* bindings/js/ScriptValue.cpp:
(WebCore::ScriptValue::getString):
* bindings/js/ScriptValue.h:
* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializingTreeWalker::convertIfTerminal):
* bindings/objc/WebScriptObject.mm:
(+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
* page/Console.cpp:
(WebCore::Console::addMessage):

WebKit/mac:

* WebView/WebView.mm:
(aeDescFromJSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 7 Dec 2009 23:03:55 +0000 (23:03 +0000)]
2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Holger Hans Peter Freyther.

        Turn on (SVG) Filters support, by default.
        https://bugs.webkit.org/show_bug.cgi?id=32224

        Only enable filters on mac for now, skipped all affected tests on the other platforms.
        Will enable them one after another, to minimize breakage.

        * Configurations/FeatureDefines.xcconfig: Enable FILTERS build flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Mon, 7 Dec 2009 22:50:15 +0000 (22:50 +0000)]
2009-12-07  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Some changes to ValidityState-typeMismatch-url.html.
        https://bugs.webkit.org/show_bug.cgi?id=29913

        - Add more test cases
          Username, IPv6 address, mailto:, file:, tel:, fragment, and IDN.
        - Handle difference between KURL and KURLGoogle

        * fast/forms/ValidityState-typeMismatch-url-expected.txt:
        * fast/forms/script-tests/ValidityState-typeMismatch-url.js:
2009-12-07  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Fix a bug that KURL rejects a host name which has an IPv4 address
        inside an IPv6 form like [::127.0.0.1].
        https://bugs.webkit.org/show_bug.cgi?id=29913

        * platform/KURL.cpp:
        (WebCore::characterClassTable): Add IPv6Char to '.'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Darin Fisher <darin@chromium.org>
darin@chromium.org [Mon, 7 Dec 2009 22:43:13 +0000 (22:43 +0000)]
2009-12-07  Darin Fisher  <darin@chromium.org>

        Reviewed by Darin Adler.

        http/tests/cache/subresource-failover-to-network.html is flaky
        https://bugs.webkit.org/show_bug.cgi?id=32038

        Rewrite test to avoid dumpResourceLoadCallbacks, which do not
        interleave predictably with the output of dumpFrameLoadCallbacks.
        Other things besides resource loading can delay onload.

        The newly written test uses a cookie to determine if the test has
        passed.

        Unskip this test for platform/win.

        * http/tests/cache/resources/subresource-failover-to-network.cgi:
        * http/tests/cache/subresource-failover-to-network-expected.txt:
        * http/tests/cache/subresource-failover-to-network.html:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@apple.com [Mon, 7 Dec 2009 22:35:17 +0000 (22:35 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=32244
        Test sending and receiving small WebSocket messages of different lengths

        * websocket/tests/frame-lengths-expected.txt: Added.
        * websocket/tests/frame-lengths.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/7443417> - Closing a window opened with "New windows open with: Same...
beidson@apple.com [Mon, 7 Dec 2009 22:27:49 +0000 (22:27 +0000)]
<rdar://problem/7443417> - Closing a window opened with "New windows open with: Same Page" results in crash in ::~HistoryItem

Reviewed by Sam Weinig.

The HistoryItem copy constructor has one very specific use case - to support the feature of a WebView copying another WebView's
BackForwardList.  That constructor wasn't initializing its m_document pointer, leading to this crash in the destructor.

* history/HistoryItem.cpp:
(WebCore::HistoryItem::~HistoryItem): Change the setDocument(0) to an ASSERT that the document is already 0. A HistoryItem cannot
  outlive its Document and Documents will always clear the back-pointer in their ::detach() method.
(WebCore::HistoryItem::HistoryItem): Missed the m_document initializer in the copy constructor. Also remove an invalid assertion
  about the original items m_cachedPage object (which is irrelevant to the copy).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed - fix typo in ChangeLog.
dimich@chromium.org [Mon, 7 Dec 2009 21:54:15 +0000 (21:54 +0000)]
Not reviewed - fix typo in ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Mon, 7 Dec 2009 21:52:22 +0000 (21:52 +0000)]
2009-12-07  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Darin Fisher.

        Chromium buildbots are not red when they fail
        https://bugs.webkit.org/show_bug.cgi?id=32235

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove partial SharedScript implementation.
dimich@chromium.org [Mon, 7 Dec 2009 21:51:35 +0000 (21:51 +0000)]
Remove partial SharedScript implementation.
https://bugs.webkit.org/show_bug.cgi?id=32237
The patch was obtained by running "git revert" command and then un-reverting WebCore/ChangeLog.

Reviewed by Daring Adler.

* DerivedSources.make:
* SharedScript/SharedScriptContext.cpp: Removed.
* SharedScript/SharedScriptContext.h: Removed.
* SharedScript/SharedScriptContext.idl: Removed.
* SharedScript/SharedScriptController.h: Removed.
* SharedScript/WebKitSharedScript.cpp: Removed.
* SharedScript/WebKitSharedScript.h: Removed.
* SharedScript/WebKitSharedScript.idl: Removed.
* SharedScript/WebKitSharedScriptRepository.cpp: Removed.
* SharedScript/WebKitSharedScriptRepository.h: Removed.
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::detach):
* dom/EventTarget.cpp:
* dom/EventTarget.h:
* dom/ScriptExecutionContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Mon, 7 Dec 2009 21:25:11 +0000 (21:25 +0000)]
2009-12-07  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Darin Fisher.

        Typo in chromium linux builder
        https://bugs.webkit.org/show_bug.cgi?id=32238

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 7 Dec 2009 21:06:11 +0000 (21:06 +0000)]
2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Add two tests generating new results to gtks collection of tests doing so.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Nikolas Zimmermann.
ap@apple.com [Mon, 7 Dec 2009 21:05:39 +0000 (21:05 +0000)]
    Reviewed by Nikolas Zimmermann.

        https://bugs.webkit.org/show_bug.cgi?id=32226
        Random crashes in WebSocket tests on Leopard Debug builbot

        * platform/network/SocketStreamHandleBase.cpp: (WebCore::SocketStreamHandleBase::close):
        Make sure the object still exists when setting m_state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Shiki Okasaka <shiki@google.com>
krit@webkit.org [Mon, 7 Dec 2009 20:32:07 +0000 (20:32 +0000)]
2009-12-07  Shiki Okasaka  <shiki@google.com>

        Reviewed by Dirk Schulze.

        Avoid zero division during SVGPaintServerPattern::setup()
        https://bugs.webkit.org/show_bug.cgi?id=29912

        Fix zero division bugs in SVGPaintServerPattern::setup() that occurred
        if the tile of a pattern was bigger than the pattern and the pattern
        size was < 0.5, and if the attribute overflow was set to visible.

        Test: svg/custom/small-pattern.html

        * svg/graphics/SVGPaintServerPattern.cpp:
        (WebCore::SVGPaintServerPattern::setup):

2009-12-07  Dirk Schulze  <krit@webkit.org>

        Reviewed by Adam Barth.

        If the tile of a pattern is bigger than the pattern and the
        pattern size is < 0.5, the SVGPaintServer produced a division
        by zero. This also only happens, if the attribute overflow is
        set to visible.
        This is a test with a pattern size of 0.1 and a tile size of 1.

        * svg/custom/script-tests/small-pattern.js: Added.
        * svg/custom/small-pattern-expected.txt: Added.
        * svg/custom/small-pattern.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Mon, 7 Dec 2009 20:17:20 +0000 (20:17 +0000)]
2009-12-07  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Darin Fisher.

        fixes to build-webkit --chromium
        https://bugs.webkit.org/show_bug.cgi?id=32179

        * DEPS:
        * WebKit.gyp:
        * gyp_webkit:
2009-12-07  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Darin Fisher.

        fixes to build-webkit --chromium
        https://bugs.webkit.org/show_bug.cgi?id=32179

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 7 Dec 2009 19:46:21 +0000 (19:46 +0000)]
2009-12-07  Eric Seidel  <eric@webkit.org>

        No review, just adding two recently approved committers.

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago * Scripts/run-webkit-websocketserver: Added property svn:executable.
ap@apple.com [Mon, 7 Dec 2009 19:36:37 +0000 (19:36 +0000)]
    * Scripts/run-webkit-websocketserver: Added property svn:executable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Kenneth Russell <kbr@google.com>
eric@webkit.org [Mon, 7 Dec 2009 19:36:34 +0000 (19:36 +0000)]
2009-12-07  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        [v8] WebCore::WebGLArrayBufferInternal::byteLengthAttrGetter NULL pointer
        https://bugs.webkit.org/show_bug.cgi?id=31889

        Fixed bug in handling of zero-argument constructor call.

        Test: fast/canvas/webgl/bug-31889.html

        * fast/canvas/webgl/bug-31889-expected.txt: Added.
        * fast/canvas/webgl/bug-31889.html: Added.
2009-12-07  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        [v8] WebCore::WebGLArrayBufferInternal::byteLengthAttrGetter NULL pointer
        https://bugs.webkit.org/show_bug.cgi?id=31889

        Fixed bug in handling of zero-argument constructor call.

        Test: fast/canvas/webgl/bug-31889.html

        * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed. Landing files I forgot to add to my working copy before
kov@webkit.org [Mon, 7 Dec 2009 19:26:41 +0000 (19:26 +0000)]
Unreviewed. Landing files I forgot to add to my working copy before
committing r51734.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Gyuyoung Kim <gyuyoung@gmail.com>
eric@webkit.org [Mon, 7 Dec 2009 19:22:48 +0000 (19:22 +0000)]
2009-12-07  Gyuyoung Kim  <gyuyoung@gmail.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=32024
        [GTK] WebKit does not compile without JAVASCRIPT_DEBUGGER

        Fix build errors when javascript-debugger is disabled on GTK

        * GNUmakefile.am:
2009-12-07  Gyuyoung Kim  <gyuyoung@gmail.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=32024
        [GTK] WebKit does not compile without JAVASCRIPT_DEBUGGER

        Fix build errors when javascript-debugger is disabled on GTK

        * webkit/webkitwebinspector.cpp:
        (webkit_web_inspector_set_property):
        (webkit_web_inspector_get_property):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Don't skip websocket/tests/url-with-credential.html, it's one of earlier...
ap@apple.com [Mon, 7 Dec 2009 19:09:16 +0000 (19:09 +0000)]
    Don't skip websocket/tests/url-with-credential.html, it's one of earlier tests that is
        to blame.

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Steve Falkenburg.
bweinstein@apple.com [Mon, 7 Dec 2009 19:06:05 +0000 (19:06 +0000)]
Rubber-stamped by Steve Falkenburg.

Add one more fast/js test to the Skipped list - also due to:
https://bugs.webkit.org/show_bug.cgi?id=32228.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 7 Dec 2009 18:51:44 +0000 (18:51 +0000)]
2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Cleaning up Skipped files in order to make more bots green, as I plan to land changes, that affect all bots (svg filters support).

        Remove non-existant animations/3d directory in qt&win Skipped lists.
        Skip one more test on windows (see bug #32228, already in radar, just guessing - not yet sure if it's a random crash issue though)
        Skip 19 (!) tests on the Qt slave, failing since a longer time. Qt developers: Please investigate.

        * platform/qt/Skipped: Also remove some duplicates I spotted.
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Yuzo Fujishima <yuzo@google.com>
eric@webkit.org [Mon, 7 Dec 2009 18:34:50 +0000 (18:34 +0000)]
2009-12-07  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Alexey Proskuryakov.

        Add run-webkit-websocketserver

        https://bugs.webkit.org/show_bug.cgi?id=31390

        * Scripts/run-webkit-websocketserver: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 7 Dec 2009 18:23:32 +0000 (18:23 +0000)]
2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Disable two flaky SnowLeopard tests, filed bug and notified author.

        Tests "plugins/document-open.html" and "plugins/mouse-events.html" are flaky on SnowLeopard
        https://bugs.webkit.org/show_bug.cgi?id=32229

        * platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Fixed <rdar://problem/7437820> Weird selection artifacts
mitz@apple.com [Mon, 7 Dec 2009 18:22:33 +0000 (18:22 +0000)]
WebCore: Fixed <rdar://problem/7437820> Weird selection artifacts

Reviewed by Darin Adler.

Tests: fast/repaint/block-selection-gap-stale-cache-2.html
       fast/repaint/block-selection-gap-stale-cache.html

Instead of caching the block selection gaps’ bounds in the RenderView at setSelection()
time, cache them in each RenderLayer at paint time. This prevents the cache from getting
stale due to layout changes and overflow scrolling.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::selectionGapRectsForRepaint): Account for overflow scroll.
(WebCore::RenderBlock::paintSelection): Update the enclosing layer’s selection gaps bounds.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::addBlockSelectionGapsBounds): Added. Updates the selection gaps
bounds to include the given rect.
(WebCore::RenderLayer::clearBlockSelectionGapsBounds): Added. Recursively clears the cached
selection gaps bounds.
(WebCore::RenderLayer::repaintBlockSelectionGaps): Added. Recursively invalidates the
selection gaps bounds.
* rendering/RenderLayer.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::setSelection): Clear the layer-level selection gaps bounds instead
of the view-level cache.
(WebCore::RenderView::clearSelection): Changed to call repaintBlockSelectionGaps().
* rendering/RenderView.h:

LayoutTests: Tests for <rdar://problem/7437820> Weird selection artifacts

Reviewed by Darin Adler.

* fast/repaint/block-selection-gap-stale-cache-2.html: Added.
* fast/repaint/block-selection-gap-stale-cache.html: Added.
* platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.checksum: Added.
* platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.png: Added.
* platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.txt: Added.
* platform/mac/fast/repaint/block-selection-gap-stale-cache-expected.checksum: Added.
* platform/mac/fast/repaint/block-selection-gap-stale-cache-expected.png: Added.
* platform/mac/fast/repaint/block-selection-gap-stale-cache-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 7 Dec 2009 18:09:47 +0000 (18:09 +0000)]
2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        REGRESSION: fast/js/excessive-comma-usage.html and fast/js/math-transforms.html fail on win
        https://bugs.webkit.org/show_bug.cgi?id=32228

        Adding above two tests to the Skipped list on win, attempting to turn the win slave green again.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix. Be flexible about which version of ICU is used on Windows.
sfalken@apple.com [Mon, 7 Dec 2009 18:03:38 +0000 (18:03 +0000)]
Build fix. Be flexible about which version of ICU is used on Windows.

JavaScriptCore:

* JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Add optional xcopy commands to copy ICU 4.2.

WebKitTools:

* DumpRenderTree/win/DumpRenderTree.vcproj: Add optional xcopy commands to copy ICU 4.2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 7 Dec 2009 17:43:02 +0000 (17:43 +0000)]
2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Remove non-existant files in gtk/Skipped list, and exclude a printing test, without results. Should turn the gtk slave green again.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 7 Dec 2009 17:21:10 +0000 (17:21 +0000)]
2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Attempt to get all mac build slaves to green again. Disable crashing test, and notify the author of it to fix it.

        New test "websocket/tests/url-with-credential.html" crashes in debug builds
        https://bugs.webkit.org/show_bug.cgi?id=32226

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Add missing layout test result.
zimmermann@webkit.org [Mon, 7 Dec 2009 17:10:47 +0000 (17:10 +0000)]
Not reviewed. Add missing layout test result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Philippe Normand <pnormand@igalia.com>
kov@webkit.org [Mon, 7 Dec 2009 17:07:53 +0000 (17:07 +0000)]
2009-12-07  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha.

        Fixed whitelist comment and removed useless (tags, sdp) mimetypes
        from it. Also, GStreamer doesn't handle directly SMIL.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mimeTypeCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Joanmarie Diggs <joanmarie.diggs@gmail.com>
eric@webkit.org [Mon, 7 Dec 2009 15:38:48 +0000 (15:38 +0000)]
2009-12-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=25415
        [GTK][ATK] Please implement support for get_text_at_offset

        Eliminate the segfaults which occur when accessing the text interface now
        implemented by text controls.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (getPangoLayoutForAtk):
2009-12-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=25415
        [GTK][ATK] Please implement support for get_text_at_offset

        Eliminate the segfaults which occur when accessing the text interface now
        implemented by text controls.

        * tests/testatk.c
        (test_webkit_atk_get_text_at_offset_textarea):
        (test_webkit_atk_get_text_at_offset_text_input):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Benjamin Poulain <benjamin.poulain@nokia.com>
eric@webkit.org [Mon, 7 Dec 2009 15:31:42 +0000 (15:31 +0000)]
2009-12-07  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Improve the autotests of QtWebkit
        https://bugs.webkit.org/show_bug.cgi?id=32216

        Remove the calls to qWait() of the autotest of QWebView

        * tests/qwebview/tst_qwebview.cpp:
        (tst_QWebView::reusePage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Mikhail Naganov <mnaganov@chromium.org>
eric@webkit.org [Mon, 7 Dec 2009 15:02:17 +0000 (15:02 +0000)]
2009-12-07  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        [Chromium] Add declarations for DevTools message dispatching on IO thread
        (see http://codereview.chromium.org/460018)

        https://bugs.webkit.org/show_bug.cgi?id=32217

        * public/WebDevToolsAgent.h:
        * public/WebDevToolsAgentClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 7 Dec 2009 14:52:37 +0000 (14:52 +0000)]
2009-12-07  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Oliver Hunt.

        op_loop_if_less JIT codegen is broken for 64-bit
        https://bugs.webkit.org/show_bug.cgi?id=32221

        * jit/JITOpcodes.cpp:
        (JSC::JIT::emit_op_loop_if_false): Fix codegen in this version - test was backwards.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Xan Lopez.
kov@webkit.org [Mon, 7 Dec 2009 14:35:30 +0000 (14:35 +0000)]
    Reviewed by Xan Lopez.

        Build the new API test.

        [GTK] REGRESSION: webkit thinks it can render PDFs
        https://bugs.webkit.org/show_bug.cgi?id=32183

        * GNUmakefile.am:

WebCore

        Reviewed by Xan Lopez.

        Turn the MediaPlayer supported types blacklist into a whitelist

        [GTK] REGRESSION: webkit thinks it can render PDFs
        https://bugs.webkit.org/show_bug.cgi?id=32183

        Covered by API test.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mimeTypeCache):

WebKit/gtk

        Reviewed by Xan Lopez.

        New test to make sure we do not regress this feature anymore. All
        test files were created by me.

        [GTK] REGRESSION: webkit thinks it can render PDFs
        https://bugs.webkit.org/show_bug.cgi?id=32183

        * tests/resources/test.html: Added.
        * tests/resources/test.ogg: Added.
        * tests/resources/test.pdf: Added.
        * tests/resources/test.txt: Added.
        * tests/testmimehandling.c: Added.
        (server_callback):
        (idle_quit_loop_cb):
        (mime_type_policy_decision_requested_cb):
        (test_mime_type):
        (test_mime_pdf):
        (test_mime_html):
        (test_mime_text):
        (test_mime_ogg):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Benjamin Poulain <benjamin.poulain@nokia.com>
eric@webkit.org [Mon, 7 Dec 2009 14:34:50 +0000 (14:34 +0000)]
2009-12-07  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Improve the autotests of QtWebkit
        https://bugs.webkit.org/show_bug.cgi?id=32216

        Refactor tst_qwebframe to remove qWait() and use
        the function waitForSignal() from util.h

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Joanmarie Diggs <joanmarie.diggs@gmail.com>
eric@webkit.org [Mon, 7 Dec 2009 14:27:44 +0000 (14:27 +0000)]
2009-12-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=25524
        [Gtk] Expose the title attribute to assistive technologies

        * platform/gtk/accessibility/title-and-alt.html: Added.
        * platform/gtk/accessibility/title-and-alt-expected.txt: Added.
2009-12-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=25524
        [Gtk] Expose the title attribute to assistive technologies

        Expose 'alt' attribute from images as accessible name.
        Expose the 'title' core HTML attribute as accessible description.
        This is a modified version of the original fix submitted by Mario Sanchez Prada,
        adjusted so that it doesn't impact other platforms.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (webkit_accessible_get_name):
        (webkit_accessible_get_description):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Benjamin Poulain <benjamin.poulain@nokia.com>
eric@webkit.org [Mon, 7 Dec 2009 14:13:45 +0000 (14:13 +0000)]
2009-12-07  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Improve the autotests of QtWebkit
        https://bugs.webkit.org/show_bug.cgi?id=32216

        Refactor the test of QGraphicsWebView:
        -make waitForSignal() available to all the tests.
        -remove QTest::qWait()

        * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
        (tst_QGraphicsWebView::crashOnViewlessWebPages):
        * tests/util.h:
        (waitForSignal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoObject.create fails if properties on the descriptor are getters
oliver@apple.com [Mon, 7 Dec 2009 13:50:57 +0000 (13:50 +0000)]
Object.create fails if properties on the descriptor are getters
https://bugs.webkit.org/show_bug.cgi?id=32219

Reviewed by Maciej Stachowiak.

Correctly initialise the PropertySlots with the descriptor object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Plugins: Force windowless mode when there is no native window handle
girish@forwardbias.in [Mon, 7 Dec 2009 13:44:35 +0000 (13:44 +0000)]
[Qt] Plugins: Force windowless mode when there is no native window handle

Reviewed by Simon Hausmann.

Inject wmode=opaque while instantiating the plugin for the case when the
webpage is not backed by a native window handle.

https://bugs.webkit.org/show_bug.cgi?id=32059

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Fix support for generic font families
vestbo@webkit.org [Mon, 7 Dec 2009 13:29:20 +0000 (13:29 +0000)]
[Qt] Fix support for generic font families

Reviewed by Simon Hausmann.

By not propagating the resolved font family in FontCacheQt and
only concidering the font description we ended up passing the
generic font families to Qt directly. Since most systems don't
have a mapping for these font families we ended up using the
default font in most cases.

* platform/graphics/qt/FontCacheQt.cpp:
* platform/graphics/qt/FontPlatformData.h:
* platform/graphics/qt/FontPlatformDataQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoObject.getOwnPropertyDescriptor() allows cross-frame access
oliver@apple.com [Mon, 7 Dec 2009 13:06:18 +0000 (13:06 +0000)]
Object.getOwnPropertyDescriptor() allows cross-frame access
https://bugs.webkit.org/show_bug.cgi?id=32119

Reviewed by Maciej Stachowiak.

Make all implementations of getOwnPropertyDescriptor that have
cross domain restrictions simply fail immediately on cross domain
access, rather than trying to mimic the behaviour of normal
property access.

Test: http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMoves JSC-specific functions from jni_utility and moves them to new jsc/jni_utility_p...
steveblock@google.com [Mon, 7 Dec 2009 12:36:56 +0000 (12:36 +0000)]
Moves JSC-specific functions from jni_utility and moves them to new jsc/jni_utility_private files.
https://bugs.webkit.org/show_bug.cgi?id=32157

Reviewed by Adam Barth.

Build fix only, no new tests.

* WebCore.xcodeproj/project.pbxproj: Modified. Add jni_utility_private.[cpp|h].
* bridge/jni/jni_instance.cpp: Modified. Include jni_utility_private.h for JSC.
* bridge/jni/jni_jsobject.mm: Modified. Include jni_utility_private.h for JSC.
* bridge/jni/jni_objc.mm: Modified. Include jni_utility_private.h for JSC.
* bridge/jni/jni_runtime.cpp: Modified. Include jni_utility_private.h for JSC.
* bridge/jni/jni_utility.cpp: Modified. Removed convertValueToJValue and convertArrayInstanceToJavaArray.
* bridge/jni/jni_utility.h: Modified. Removed convertValueToJValue and dispatchJNICall.
* bridge/jni/jsc: Added.
* bridge/jni/jsc/jni_utility_private.cpp: Added.
(JSC::Bindings::convertArrayInstanceToJavaArray):
(JSC::Bindings::convertValueToJValue):
* bridge/jni/jsc/jni_utility_private.h: Added. Header for convertValueToJValue and dispatchJNICall.
* platform/android/TemporaryLinkStubs.cpp: Modified. Include jni_utility_private.h for JSC.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-07 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 7 Dec 2009 12:04:00 +0000 (12:04 +0000)]
2009-12-07  Dirk Schulze  <krit@webkit.org>

        Not reviewed, adding myself to the reviewers list.

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 7 Dec 2009 07:53:48 +0000 (07:53 +0000)]
2009-12-06  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add an API for uploading results files to StatusBot
        https://bugs.webkit.org/show_bug.cgi?id=32210

        Add Content-Type: plain/text which was forgotten
        from the previous commit when I landed with land-patches
        instead of land-diff.

        * QueueStatusServer/queue_status.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 7 Dec 2009 07:45:07 +0000 (07:45 +0000)]
2009-12-06  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add an API for uploading results files to StatusBot
        https://bugs.webkit.org/show_bug.cgi?id=32210

        * Scripts/modules/statusbot.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 7 Dec 2009 07:42:31 +0000 (07:42 +0000)]
2009-12-06  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Status Server needs a way to handle uploaded results
        https://bugs.webkit.org/show_bug.cgi?id=32209

        * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
        * QueueStatusServer/update_status.html: Add file upload.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-06 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Mon, 7 Dec 2009 07:06:06 +0000 (07:06 +0000)]
2009-12-06  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed. Revert r51748.

        Bugzilla should show images in git patches
        https://bugs.webkit.org/show_bug.cgi?id=31395

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 7 Dec 2009 06:42:55 +0000 (06:42 +0000)]
2009-12-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] BuildAttachment should not check the builders
        https://bugs.webkit.org/show_bug.cgi?id=32207

        This is code that got copied here by accident when the class was created.

        * Scripts/modules/commands/download.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 7 Dec 2009 06:42:31 +0000 (06:42 +0000)]
2009-12-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Make LandingSequence.update aware of ports
        https://bugs.webkit.org/show_bug.cgi?id=32208

        This is required to make build work on the Chromium port because
        Chromium has a custom update-webkit.

        * Scripts/modules/landingsequence.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-06 Shinichiro Hamaji <shinichiro.hamaji@gmail.com>
hamaji@chromium.org [Mon, 7 Dec 2009 06:42:05 +0000 (06:42 +0000)]
2009-12-06  Shinichiro Hamaji  <shinichiro.hamaji@gmail.com>

        Reviewed by David Kilzer.

        Bugzilla should show images in git patches
        https://bugs.webkit.org/show_bug.cgi?id=31395

        Show images in git patches using git-apply.

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 7 Dec 2009 05:20:13 +0000 (05:20 +0000)]
2009-12-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add early warning system commands to bugzilla-tool.

        * Scripts/bugzilla-tool:
        * Scripts/modules/landingsequence.py:
        * Scripts/modules/webkitport.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51747 268f45cc-cd09-0410-ab3c-d52691b4dbfc