yurys@chromium.org [Wed, 26 Jan 2011 11:43:09 +0000 (11:43 +0000)]
2011-01-26 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: inspector should start in attached state by default
https://bugs.webkit.org/show_bug.cgi?id=53165
* WebCoreSupport/WebInspectorClientCF.cpp:
(WebInspectorClient::inspectorStartsAttached):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76684
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 26 Jan 2011 11:39:52 +0000 (11:39 +0000)]
2011-01-26 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: inspector tests fix.
* http/tests/inspector/inspector-test2.js:
(initialize_InspectorTest.InspectorTest.evaluateInPage):
* inspector/console-format.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76683
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Wed, 26 Jan 2011 10:26:56 +0000 (10:26 +0000)]
2011-01-26 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed, unskip passing canvas tests in GTK port.
* platform/gtk/Skipped: Unskip passing canvas tests.
* platform/gtk/fast/canvas/arc360-expected.checksum: Added.
* platform/gtk/fast/canvas/arc360-expected.png: Added.
* platform/gtk/fast/canvas/arc360-expected.txt: Added.
* platform/gtk/fast/canvas/canvas-as-image-expected.checksum: Added.
* platform/gtk/fast/canvas/canvas-as-image-expected.png: Added.
* platform/gtk/fast/canvas/canvas-as-image-expected.txt: Added.
* platform/gtk/fast/canvas/canvas-as-image-incremental-repaint-expected.checksum: Added.
* platform/gtk/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Added.
* platform/gtk/fast/canvas/canvas-as-image-incremental-repaint-expected.txt: Added.
* platform/gtk/fast/canvas/canvas-before-css-expected.checksum: Added.
* platform/gtk/fast/canvas/canvas-before-css-expected.png: Added.
* platform/gtk/fast/canvas/canvas-before-css-expected.txt: Added.
* platform/gtk/fast/canvas/canvas-bg-expected.checksum: Added.
* platform/gtk/fast/canvas/canvas-bg-expected.png: Added.
* platform/gtk/fast/canvas/canvas-bg-expected.txt: Added.
* platform/gtk/fast/canvas/canvas-bg-zoom-expected.checksum: Added.
* platform/gtk/fast/canvas/canvas-bg-zoom-expected.png: Added.
* platform/gtk/fast/canvas/canvas-bg-zoom-expected.txt: Added.
* platform/gtk/fast/canvas/canvas-incremental-repaint-2-expected.checksum: Added.
* platform/gtk/fast/canvas/canvas-incremental-repaint-2-expected.png: Added.
* platform/gtk/fast/canvas/canvas-incremental-repaint-2-expected.txt: Added.
* platform/gtk/fast/canvas/canvas-resize-reset-expected.checksum: Added.
* platform/gtk/fast/canvas/canvas-resize-reset-expected.png: Added.
* platform/gtk/fast/canvas/canvas-resize-reset-expected.txt: Added.
* platform/gtk/fast/canvas/canvas-size-change-after-layout-expected.checksum: Added.
* platform/gtk/fast/canvas/canvas-size-change-after-layout-expected.png: Added.
* platform/gtk/fast/canvas/canvas-size-change-after-layout-expected.txt: Added.
* platform/gtk/fast/canvas/canvas-text-baseline-expected.checksum: Added.
* platform/gtk/fast/canvas/canvas-text-baseline-expected.png: Added.
* platform/gtk/fast/canvas/canvas-text-baseline-expected.txt: Added.
* platform/gtk/fast/canvas/canvas-transforms-during-path-expected.checksum: Added.
* platform/gtk/fast/canvas/canvas-transforms-during-path-expected.png: Added.
* platform/gtk/fast/canvas/canvas-transforms-during-path-expected.txt: Added.
* platform/gtk/fast/canvas/canvasDrawingIntoSelf-expected.checksum: Added.
* platform/gtk/fast/canvas/canvasDrawingIntoSelf-expected.png: Added.
* platform/gtk/fast/canvas/canvasDrawingIntoSelf-expected.txt: Added.
* platform/gtk/fast/canvas/drawImage-expected.checksum: Added.
* platform/gtk/fast/canvas/drawImage-expected.png: Added.
* platform/gtk/fast/canvas/drawImage-expected.txt: Added.
* platform/gtk/fast/canvas/drawImage-with-globalAlpha-expected.checksum: Added.
* platform/gtk/fast/canvas/drawImage-with-globalAlpha-expected.png: Added.
* platform/gtk/fast/canvas/drawImage-with-globalAlpha-expected.txt: Added.
* platform/gtk/fast/canvas/fill-stroke-clip-reset-path-expected.checksum: Added.
* platform/gtk/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
* platform/gtk/fast/canvas/fill-stroke-clip-reset-path-expected.txt: Added.
* platform/gtk/fast/canvas/fillrect-gradient-zero-stops-expected.checksum: Added.
* platform/gtk/fast/canvas/fillrect-gradient-zero-stops-expected.png: Added.
* platform/gtk/fast/canvas/fillrect-gradient-zero-stops-expected.txt: Added.
* platform/gtk/fast/canvas/fillrect_gradient-expected.checksum: Added.
* platform/gtk/fast/canvas/fillrect_gradient-expected.png: Added.
* platform/gtk/fast/canvas/fillrect_gradient-expected.txt: Added.
* platform/gtk/fast/canvas/gradient-add-second-start-end-stop-expected.checksum: Added.
* platform/gtk/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
* platform/gtk/fast/canvas/gradient-add-second-start-end-stop-expected.txt: Added.
* platform/gtk/fast/canvas/image-object-in-canvas-expected.checksum: Added.
* platform/gtk/fast/canvas/image-object-in-canvas-expected.png: Added.
* platform/gtk/fast/canvas/image-object-in-canvas-expected.txt: Added.
* platform/gtk/fast/canvas/quadraticCurveTo-expected.checksum: Added.
* platform/gtk/fast/canvas/quadraticCurveTo-expected.png: Added.
* platform/gtk/fast/canvas/quadraticCurveTo-expected.txt: Added.
* platform/gtk/fast/canvas/zero-size-fill-rect-expected.checksum: Added.
* platform/gtk/fast/canvas/zero-size-fill-rect-expected.png: Added.
* platform/gtk/fast/canvas/zero-size-fill-rect-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76682
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 26 Jan 2011 10:24:59 +0000 (10:24 +0000)]
2011-01-26 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: live edit does not update source snippet.
https://bugs.webkit.org/show_bug.cgi?id=53097
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76681
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 26 Jan 2011 10:19:04 +0000 (10:19 +0000)]
2011-01-26 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Incorrect on-hover evaluation of a variable named 'profile'.
https://bugs.webkit.org/show_bug.cgi?id=53018
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getCompletions):
(WebCore::InjectedScript::getCompletionsOnCallFrame):
* inspector/InjectedScript.h:
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.idl:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::getCompletions):
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.completions):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
(WebInspector.ConsoleView.prototype._enterKeyPressed):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper):
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._showPopup):
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype.update):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76680
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 26 Jan 2011 10:12:50 +0000 (10:12 +0000)]
2011-01-26 Hironori Bono <hbono@chromium.org>
Reviewed by Kent Tamura.
A speculative fix for Bug 52422 - [chromium] More crash in
FontFallbackList::determinePitch(const Font* font)
https://bugs.webkit.org/show_bug.cgi?id=52422
My previous change may not work on non-US Windows whose system fonts
have localized aliases matching to the system locale because of a
font-name mismatch in createFontIndirectAndGetWinName(). This change
tries all the fonts installed in a PC and returns the first font that we
can create without errors.
* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData):
Added a struct used for getLastResortFallbackFontProc().
(WebCore::getLastResortFallbackFontProc): Added a callback for EnumFontFamilies().
(WebCore::FontCache::getLastResortFallbackFont): Use EnumFontFamilies() to find a last-resort font.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76679
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Wed, 26 Jan 2011 09:42:02 +0000 (09:42 +0000)]
2011-01-26 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change.
Mark some complex script tests as failing since r76674.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76678
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 26 Jan 2011 09:18:17 +0000 (09:18 +0000)]
2011-01-26 James Robinson <jamesr@chromium.org>
Reviewed by Nate Chapin.
Add a DOMTimeStamp parameter to the requestAnimationFrame callback
https://bugs.webkit.org/show_bug.cgi?id=53142
Adds a test for the parameter passed to the requestAnimationFrame callback.
* fast/animation/request-animation-frame-timestamps-expected.txt: Added.
* fast/animation/request-animation-frame-timestamps.html: Added.
* fast/animation/script-tests/request-animation-frame-timestamps.js: Added.
2011-01-26 James Robinson <jamesr@chromium.org>
Reviewed by Nate Chapin.
Add a DOMTimeStamp parameter to the requestAnimationFrame callback
https://bugs.webkit.org/show_bug.cgi?id=53142
This adds a DOMTimeStamp parameter to the requestAnimationFrame callback to more
closely match mozilla's proposal. This is useful if the page has multiple imperative animations
and wants to ensure that they all remain synchronized. If each callback used Date.now() to
update its animation state, they would potentially be out of sync with each other. If they use
the timestamp then all callbacks for the same "frame" will update to the same state.
Test: fast/animation/request-animation-frame-timestamps.html
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/V8/V8TestCallback.cpp:
(WebCore::V8TestCallback::callbackWithClass2Param):
* dom/Document.cpp:
(WebCore::Document::serviceScriptedAnimations):
* dom/Document.h:
* dom/RequestAnimationFrameCallback.h:
* dom/RequestAnimationFrameCallback.idl:
* page/FrameView.cpp:
(WebCore::FrameView::serviceScriptedAnimations):
* page/FrameView.h:
2011-01-26 James Robinson <jamesr@chromium.org>
Reviewed by Nate Chapin.
Add a DOMTimeStamp parameter to the requestAnimationFrame callback
https://bugs.webkit.org/show_bug.cgi?id=53142
Provides a timestamp to use for imperative animation callbacks. In this patch the timestamp is
just the current time at the start of the callback invocation algorithm. In the future we
could enhance this to try to take the compositing delay into effect to try to synchronize
imperative animations more closely with declarative ones, but this should do for now.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::animate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76677
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Wed, 26 Jan 2011 07:58:06 +0000 (07:58 +0000)]
2011-01-25 Yuzo Fujishima <yuzo@google.com>
Unreviewed attempt to fix compilation error for Chromium Clang.
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::advance):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76676
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Wed, 26 Jan 2011 07:17:33 +0000 (07:17 +0000)]
2011-01-25 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change
Mark fast/text/offsetForPosition-complex-fallback.html as failing for WIN and LINUX.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76675
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 26 Jan 2011 06:08:41 +0000 (06:08 +0000)]
2011-01-25 Ned Holbrook <nholbrook@apple.com>
Reviewed by Dan Bernstein.
ComplexTextController incorrectly conflates string length and range of indexes
https://bugs.webkit.org/show_bug.cgi?id=52760
* fast/text/offsetForPosition-complex-fallback-expected.txt: Added.
* fast/text/offsetForPosition-complex-fallback.html: Added.
2011-01-25 Ned Holbrook <nholbrook@apple.com>
Reviewed by Dan Bernstein.
ComplexTextController incorrectly conflates string length and range of indexes
https://bugs.webkit.org/show_bug.cgi?id=52760
Test: fast/text/offsetForPosition-complex-fallback.html
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::offsetForPosition):
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
(WebCore::ComplexTextController::ComplexTextRun::setIsNonMonotonic):
(WebCore::ComplexTextController::advance):
* platform/graphics/mac/ComplexTextController.h:
(WebCore::ComplexTextController::ComplexTextRun::create):
(WebCore::ComplexTextController::ComplexTextRun::indexEnd):
* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
* platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76674
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 26 Jan 2011 05:41:57 +0000 (05:41 +0000)]
Make this test a bit more robust agains different scrollbar widths.
* fast/overflow/overflow-rtl-vertical-origin.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76673
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Wed, 26 Jan 2011 05:13:03 +0000 (05:13 +0000)]
Windows production build fix.
Build correct configuration of Interfaces for Debug_All.
* WebKit.vcproj/WebKit.submit.sln:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76671
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 26 Jan 2011 05:02:13 +0000 (05:02 +0000)]
Scrollbars don't work correctly for top-to-bottom text in an overflow: scroll area
https://bugs.webkit.org/show_bug.cgi?id=53048
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/overflow/overflow-rtl-vertical-origin.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollPosition):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
Take the scroll origin into account when calculating scrollbars in more places.
LayoutTests:
* fast/overflow/overflow-rtl-vertical-origin-expected.txt: Added.
* fast/overflow/overflow-rtl-vertical-origin.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76669
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 26 Jan 2011 04:50:12 +0000 (04:50 +0000)]
2011-01-25 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
* platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.checksum: Added.
* platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Added.
* platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Added.
* platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.checksum:
* platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
* platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
* platform/chromium/test_expectations.txt:
2011-01-25 Kent Tamura <tkent@chromium.org>
Unreviewed trivial change.
* DEPS: Roll to r72581 to have a webkit_support fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76668
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Wed, 26 Jan 2011 04:39:25 +0000 (04:39 +0000)]
Windows production build fix.
Use correct configuration-specific path in makefile.
* WebCore.vcproj/WebCore.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76665
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 26 Jan 2011 04:18:51 +0000 (04:18 +0000)]
Radio button group state is not restored correctly
https://bugs.webkit.org/show_bug.cgi?id=50442
Reviewed by Dimitri Glazkov.
Source/WebCore:
Fixes a bug that radio button states are not restored correctly in
a case that non-first radio button in a group is checked.
If "checked" attribute is present, the radio button is checked and
other radio buttons in the group are unchecked. This behavior
disturbs form state restoring. This patch changes this behavior so
that the "checked" attribute handling is delayed after form state
restoring.
Test: fast/forms/state-restore-radio-group.html
* html/HTMLFormControlElement.h:
Make finishParsingChildren() protected so that HTMLInpuElement can call it.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement):
- Add createdByParser parameter.
- Initialize m_stateRestored and m_parsingInProgress.
(WebCore::HTMLInputElement::create): Sync with the constructor.
(WebCore::HTMLInputElement::restoreFormControlState):
Set m_stateRestored in order to refer it in finishParsingChildren().
(WebCore::HTMLInputElement::parseMappedAttribute):
Don't call setChecked() during parsing. Move setNeedsValidityCheck()
to setChecked().
(WebCore::HTMLInputElement::finishParsingChildren):
Call setChecked() if form state is not restored.
(WebCore::HTMLInputElement::setChecked):
Move setNeedsValidityCheck() from parseMappedAttribute() because
finishParsingChildren() also needs to call setNeedsValidityCheck().
* html/HTMLInputElement.h:
- Remove the default value of HTMLFormElement* of the HTMLInputElement
constructor, and add createdByParser parameter.
- Introduce m_parsingInProgress and m_stateRestored.
* html/HTMLIsIndexElement.cpp:
(WebCore::HTMLIsIndexElement::HTMLIsIndexElement):
Sync with the HTMLInputElement constructor change.
* html/HTMLTagNames.in: Add constructorNeedsCreatedByParser flag.
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlInputElement::MediaControlInputElement):
Sync with the HTMLInputElement constructor change.
* rendering/ShadowElement.cpp:
(WebCore::ShadowInputElement::ShadowInputElement): ditto.
* rendering/ShadowElement.h:
(WebCore::ShadowElement::ShadowElement): ditto.
LayoutTests:
* fast/forms/state-restore-radio-group-expected.txt: Added.
* fast/forms/state-restore-radio-group.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76664
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 26 Jan 2011 04:00:14 +0000 (04:00 +0000)]
HTMLFormElement::checkValidity() returns incorrect result if 'invalid' events are canceled.
https://bugs.webkit.org/show_bug.cgi?id=52565
Reviewed by Dimitri Glazkov.
Source/WebCore:
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::validateInteractively):
Check checkInvalidControlsAndCollectUnhandled() result instead of
checking emptiness of unhandled invalid controls list.
(WebCore::HTMLFormElement::checkValidity): ditto.
(WebCore::HTMLFormElement::checkInvalidControlsAndCollectUnhandled):
Renamed from collectUnhandledInvalidControls().
Returns true if there is any invalid control regardless of event canceling.
* html/HTMLFormElement.h: Rename collectUnhandledInvalidControls() to
checkInvalidControlsAndCollectUnhandled().
LayoutTests:
Fix tests and results for the behavior change.
* fast/forms/checkValidity-cancel-expected.txt:
* fast/forms/checkValidity-handler-updates-dom-expected.txt:
* fast/forms/interactive-validation-cancel-expected.txt:
* fast/forms/interactive-validation-cancel.html:
* fast/forms/script-tests/checkValidity-cancel.js:
* fast/forms/script-tests/checkValidity-handler-updates-dom.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76663
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 26 Jan 2011 03:50:52 +0000 (03:50 +0000)]
2011-01-25 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Range and number inputs should reject increment and decrement by
keyboard or mouse wheel if they are disabled or read-only
https://bugs.webkit.org/show_bug.cgi?id=53151
Add checks for 'disabled' and 'readOnly'.
* fast/forms/input-number-keyoperation-expected.txt:
* fast/forms/input-number-wheel-expected.txt:
* fast/forms/range-keyoperation-expected.txt:
* fast/forms/range-keyoperation.html:
* fast/forms/script-tests/input-number-keyoperation.js:
* fast/forms/script-tests/input-number-wheel.js:
2011-01-25 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Range and number inputs should reject increment and decrement by
keyboard or mouse wheel if they are disabled or read-only
https://bugs.webkit.org/show_bug.cgi?id=53151
* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleKeydownEvent): Check disabled() and readOnly().
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleKeydownEventForSpinButton): ditto.
(WebCore::TextFieldInputType::handleWheelEventForSpinButton): ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76662
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 26 Jan 2011 03:44:26 +0000 (03:44 +0000)]
API to support localized numbers for <input type=number>
https://bugs.webkit.org/show_bug.cgi?id=45730
Reviewed by Dimitri Glazkov.
Introduce platform/text/LocalizedNumber.h, and
LocalizedNumberNone.cpp, which is an empty implementation of the
functions in LocalizedNumber.h. We use LocalizedNumberNone.cpp in
all platforms for now.
A string in a type=number field is parsed as a localized number
first. If the parsing fails, it is parsed as the HTML5 number.
We introduce HTMLInputElement::visibleValue(). It represents a value
which should be drawn by a renderer. HTMLInputElement::value() always
returns a number formatted for HTML5, and visibleValue() may return a
localized number.
No new tests because this doesn't change any behavior.
* Android.mk: Add LocalizedNumber.h and/or LocalizedNumberNone.cpp.
* CMakeLists.txt: ditto.
* GNUmakefile.am: ditto.
* WebCore.gypi: ditto.
* WebCore.pro: ditto.
* WebCore.vcproj/WebCore.vcproj: ditto.
* WebCore.xcodeproj/project.pbxproj: ditto.
* dom/InputElement.h: Add visibleValue().
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::visibleValue): Added. Just call InputType::visibleValue().
* html/HTMLInputElement.h: Declare visibleValue().
* html/InputType.cpp:
(WebCore::InputType::visibleValue): Add the default implementation of
visibleValue(), which returns HTMLInputElement::value().
* html/InputType.h: Add declarations.
* html/NumberInputType.cpp:
(WebCore::isHTMLNumberCharacter): Renamed from isNumberCharacter().
(WebCore::isNumberCharacter): Calls isLocalizedNumberCharacter() and isHTMLNumberCharacter().
(WebCore::NumberInputType::visibleValue):
Returns a localized number string produced by formatLocalizedNumber().
(WebCore::NumberInputType::isAcceptableValue): Calls parseLocalizedNumber().
(WebCore::NumberInputType::sanitizeValue): Calls parseLocalizedNumber().
* html/NumberInputType.h: Add declarations.
* platform/text/LocalizedNumber.h: Added.
* platform/text/LocalizedNumberNone.cpp: Added.
(WebCore::parseLocalizedNumber):
(WebCore::formatLocalizedNumber):
(WebCore::isLocalizedNumberCharacter):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::updateFromElement):
Calls InputElement::visibleValue() instead of value().
* wml/WMLInputElement.h:
(WebCore::WMLInputElement::visibleValue): Added. It just calls value().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76661
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Wed, 26 Jan 2011 03:29:52 +0000 (03:29 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=53143
Add IntRectHash
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/IntRectHash.h: Added.
* platform/graphics/IntSizeHash.h: Don't do "using WebCore::IntSize"!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76660
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 26 Jan 2011 03:19:57 +0000 (03:19 +0000)]
2011-01-25 Ilya Sherman <isherman@chromium.org>
Reviewed by Ryosuke Niwa.
Remove trailing whitespace in HTMLInputElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=53152
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateCheckedRadioButtons):
(WebCore::HTMLInputElement::applyStep):
(WebCore::HTMLInputElement::updateFocusAppearance):
(WebCore::HTMLInputElement::mapToEntry):
(WebCore::HTMLInputElement::setAutofilled):
(WebCore::HTMLInputElement::willMoveToNewOwnerDocument):
(WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76659
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 26 Jan 2011 02:13:46 +0000 (02:13 +0000)]
2011-01-25 Mike Reed <reed@google.com>
Reviewed by James Robinson.
DrawingBufer::reset() today checks if the new size is the same as its
m_size, and if so, returns immediately. This does not match the
semantics of <canvas>, which wants to clear its contents anytime the
size is specified.
https://bugs.webkit.org/show_bug.cgi?id=53149
Test: Covered by existing <canvas> tests using gpu.
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::reset):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76658
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Wed, 26 Jan 2011 01:54:10 +0000 (01:54 +0000)]
WK2 leaks when a page is closed
https://bugs.webkit.org/show_bug.cgi?id=53100
Reviewed by Darin Adler.
Allow the WKView a chance to clean up on a page close. In this case,
cleaning up means removing the references the accessibility token has
to the window.
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::pageClosed):
* UIProcess/API/mac/WKView.mm:
(-[WKView _setRemoteAccessibilityWindow:]):
(-[WKView _setAccessibilityChildToken:]):
(-[WKView _processDidCrash]):
(-[WKView _pageClosed]):
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/API/qt/qwkpage_p.h:
(QWKPagePrivate::pageClosed):
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
* UIProcess/win/WebView.cpp:
(WebKit::WebView::pageClosed):
* UIProcess/win/WebView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76657
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Wed, 26 Jan 2011 01:17:17 +0000 (01:17 +0000)]
2011-01-25 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Move main CMakeLists.txt into Source directory
https://bugs.webkit.org/show_bug.cgi?id=52888
* CMakeLists.txt: Removed.
* Source/CMakeLists.txt: Copied from CMakeLists.txt.
* Source/cmakeconfig.h.cmake: Copied from cmakeconfig.h.cmake.
* cmakeconfig.h.cmake: Removed.
2011-01-25 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Move main CMakeLists.txt into Source directory
https://bugs.webkit.org/show_bug.cgi?id=52888
* Scripts/webkitdirs.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76656
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Wed, 26 Jan 2011 00:50:34 +0000 (00:50 +0000)]
2011-01-25 Patrick Gansterer <paroga@webkit.org>
Reviewed by Eric Seidel.
Improve label text in submit-to-ews
https://bugs.webkit.org/show_bug.cgi?id=53130
* QueueStatusServer/templates/submittoews.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76655
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cmarrin@apple.com [Wed, 26 Jan 2011 00:36:39 +0000 (00:36 +0000)]
2011-01-25 Chris Marrin <cmarrin@apple.com>
Reviewed by Adam Roben.
Expose WebGL flag set/get in WK2
https://bugs.webkit.org/show_bug.cgi?id=53096
* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetWebGLEnabled):
(WKPreferencesGetWebGLEnabled):
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76654
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 26 Jan 2011 00:18:06 +0000 (00:18 +0000)]
2011-01-25 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Add and implement LayerTreeHost::scheduleLayerFlush
https://bugs.webkit.org/show_bug.cgi?id=53135
* WebKit2.xcodeproj/project.pbxproj:
Add LayerTreeHostMac.mm.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::scheduleCompositingLayerSync):
Call LayerTreeHost::scheduleLayerFlush.
* WebProcess/WebPage/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::~LayerTreeHost):
Call platformInvalidate().
(WebKit::LayerTreeHost::flushPendingLayerChanges):
Rename from syncCompositingLayers.
* WebProcess/WebPage/mac/LayerTreeHostMac.mm: Added.
(WebKit::LayerTreeHost::scheduleLayerFlush):
Create a run loop observer if needed. This code is copied from LayerBackedDrawingAreaMac.mm
(WebKit::LayerTreeHost::platformInvalidate):
Invalidate the run loop observer.
(WebKit::LayerTreeHost::flushPendingLayerChangesRunLoopObserverCallback):
Call flushPendingChanges() and remove the run loop observer if it succeeded.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76653
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Wed, 26 Jan 2011 00:10:34 +0000 (00:10 +0000)]
2011-01-25 Cris Neckar <cdn@chromium.org>
Reviewed by Adam Barth.
Test for crash when a window's location changes before creating an object URL.
https://bugs.webkit.org/show_bug.cgi?id=53038
* fast/dom/window-domurl-crash-expected.txt: Added.
* fast/dom/window-domurl-crash.html: Added.
2011-01-25 Cris Neckar <cdn@chromium.org>
Reviewed by Adam Barth.
Add a hashset of DOMURLs to ScriptExecutionContext to track back references.
https://bugs.webkit.org/show_bug.cgi?id=53038
Test: fast/dom/window-domurl-crash.html
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::createdDomUrl):
(WebCore::ScriptExecutionContext::destroyedDomUrl):
* dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::domUrls):
* html/DOMURL.cpp:
(WebCore::DOMURL::DOMURL):
(WebCore::DOMURL::~DOMURL):
(WebCore::DOMURL::contextDestroyed):
* html/DOMURL.h:
(WebCore::DOMURL::scriptExecutionContext):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76652
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 25 Jan 2011 23:46:21 +0000 (23:46 +0000)]
Windows Production build fix
Reviewed by Steve Falkenburg.
* JavaScriptCore.vcproj/JavaScriptCore.make: Set BUILDSTYLE to Release_PGO at the very start
of the file so that ConfigurationBuildDir takes that into account. Also set it the right way
(by redefining the macro) rather than the wrong way (by modifying the environment variable).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76650
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 25 Jan 2011 23:40:57 +0000 (23:40 +0000)]
2011-01-25 Anders Carlsson <andersca@apple.com>
Reviewed by Simon Fraser.
Add LayerTreeHost class
https://bugs.webkit.org/show_bug.cgi?id=53132
* WebKit2.xcodeproj/project.pbxproj:
Add LayerTreeHost files.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl):
Initialize m_layerTreeHost.
(WebKit::DrawingAreaImpl::setRootCompositingLayer):
Call the m_layerTreeHost.
* WebProcess/WebPage/LayerTreeHost.cpp: Added.
(WebKit::LayerTreeHost::attachRootCompositingLayer):
(WebKit::LayerTreeHost::detachRootCompositingLayer):
Add stubbed out functions.
(WebKit::LayerTreeHost::syncCompositingLayers):
Sync the compositing layers in the main frame.
* WebProcess/WebPage/LayerTreeHost.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76649
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Tue, 25 Jan 2011 23:31:18 +0000 (23:31 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=52983
Eliminate m_tagHistory pointer from CSSSelector
Reviewed by Darin Adler.
Keep the component selectors in the array in CSSSelectorList instead
of maintaining a linked list between them. This allows eliminating
m_tagHistory pointer, shrinking CSSSelector by 25% (selection performance
seems to improve some too due to better locality).
* WebCore.xcodeproj/project.pbxproj:
Make CSSSelector.h a private header.
* css/CSSGrammar.y:
Use CSSParserSelector during parsing to keep the tag history in
a linked list. This is flattened to an array after parsing.
Use accessors for setting selector values.
Use OwnPtr in selector vector.
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::CSSPageRule):
* css/CSSPageRule.h:
(WebCore::CSSPageRule::create):
Simplify.
* css/CSSParser.cpp:
(WebCore::CSSParser::~CSSParser):
(WebCore::CSSParser::createFloatingSelector):
(WebCore::CSSParser::sinkFloatingSelector):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::updateSpecifiersWithElementName):
(WebCore::CSSParser::createPageRule):
* css/CSSParser.h:
(WebCore::CSSParser::reusableSelectorVector):
CSSSelector -> CSSParserSelector.
Use OwnPtr in selector vector.
* css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::CSSParserSelector):
(WebCore::CSSParserSelector::~CSSParserSelector):
* css/CSSParserValues.h:
(WebCore::CSSParserSelector::releaseSelector):
(WebCore::CSSParserSelector::setTag):
(WebCore::CSSParserSelector::setValue):
(WebCore::CSSParserSelector::setAttribute):
(WebCore::CSSParserSelector::setArgument):
(WebCore::CSSParserSelector::setSimpleSelector):
(WebCore::CSSParserSelector::setMatch):
(WebCore::CSSParserSelector::setRelation):
(WebCore::CSSParserSelector::setForPage):
(WebCore::CSSParserSelector::pseudoType):
(WebCore::CSSParserSelector::isUnknownPseudoElement):
(WebCore::CSSParserSelector::isSimple):
(WebCore::CSSParserSelector::tagHistory):
(WebCore::CSSParserSelector::setTagHistory):
Linked list used during parsing.
Avoid recursive destruction.
* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
(WebCore::CSSSelector::operator==):
(WebCore::CSSSelector::selectorText):
(WebCore::CSSSelector::setSimpleSelector):
* css/CSSSelector.h:
(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::~CSSSelector):
(WebCore::CSSSelector::tagHistory):
(WebCore::CSSSelector::tag):
(WebCore::CSSSelector::value):
(WebCore::CSSSelector::setTag):
(WebCore::CSSSelector::isLastInTagHistory):
(WebCore::CSSSelector::setNotLastInTagHistory):
(WebCore::CSSSelector::RareData::RareData):
(WebCore::CSSSelector::RareData::~RareData):
(WebCore::CSSSelector::createRareData):
(WebCore::CSSSelector::setValue):
Remove m_tagHistory.
Keep m_value in the union with the rare data pointer instead.
Make m_value and m_tag private, implement accessors.
Add a new bit to indicate end of the tag history (multipart selector).
Eliminate complex destruction. Selectors are now deleted as an array or by a CSSParserSelector chain.
* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::adoptSelectorVector):
Flatten everything to an array.
(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
* css/CSSSelectorList.h:
(WebCore::CSSSelectorList::hasOneSelector):
(WebCore::CSSSelectorList::next):
Skip over the subparts of multipart selectors to find the next selector.
* css/CSSStyleRule.h:
(WebCore::CSSStyleRule::adoptSelectorVector):
CSSSelector -> CSSParserSelector.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSRuleSet::addRule):
(WebCore::collectIdsAndSiblingRulesFromList):
(WebCore::CSSStyleSelector::matchPageRulesForList):
* dom/Node.cpp:
(WebCore::Node::querySelector):
* dom/SelectorNodeList.cpp:
(WebCore::createSelectorNodeList):
Use accessors.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76648
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 25 Jan 2011 23:20:37 +0000 (23:20 +0000)]
2011-01-25 Mansi Mithal <mansi.mithal@nokia.com>
Reviewed by Antonio Gomes.
QtTestBrowser should have a UI Settings to prevent loading images
https://bugs.webkit.org/show_bug.cgi?id=52409
Added a new action item named "DisableAutoLoadImages"
under the "Settings" menu
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::createChrome):
(LauncherWindow::toggleAutoLoadImages):
* QtTestBrowser/launcherwindow.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76646
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simonjam@chromium.org [Tue, 25 Jan 2011 23:07:06 +0000 (23:07 +0000)]
2011-01-25 James Simonsen <simonjam@chromium.org>
Reviewed by Tony Chang.
[Chromium] Support small caps in complex text on linux
https://bugs.webkit.org/show_bug.cgi?id=53051
* platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.checksum: Added.
* platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.png: Added.
* platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.txt: Added.
* platform/chromium-linux/fast/text/atsui-small-caps-punctuation-size-expected.checksum: Added.
* platform/chromium-linux/fast/text/atsui-small-caps-punctuation-size-expected.png: Added.
* platform/chromium/test_expectations.txt: Re-enable 2 tests on linux.
2011-01-25 James Simonsen <simonjam@chromium.org>
Reviewed by Tony Chang.
[Chromium] Support small caps in complex text on linux
https://bugs.webkit.org/show_bug.cgi?id=53051
* platform/graphics/chromium/ComplexTextControllerLinux.cpp:
(WebCore::ComplexTextController::nextScriptRun): Break runs at small caps boundaries.
(WebCore::ComplexTextController::setupFontForScriptRun): Setup small caps font data if needed.
* platform/graphics/chromium/ComplexTextControllerLinux.h: Store small caps text in separate string.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76644
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Tue, 25 Jan 2011 22:52:17 +0000 (22:52 +0000)]
2011-01-25 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
Minor bug fixes and cleanup for filesystem wrappers, port/* test
classes, test_expectations.py. This change adds "test-win" and
"test-mac" variants to the test port so that we can better test
rebaselining, and adds a MockUser() object for reuse in testing.
https://bugs.webkit.org/show_bug.cgi?id=53036
* Scripts/webkitpy/common/system/filesystem.py:
* Scripts/webkitpy/common/system/filesystem_mock.py:
* Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
* Scripts/webkitpy/layout_tests/port/factory.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76642
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Tue, 25 Jan 2011 22:23:06 +0000 (22:23 +0000)]
Unreviewed build fix: add failing test to gtk/Skipped.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76640
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Tue, 25 Jan 2011 21:49:57 +0000 (21:49 +0000)]
Windows production build fix.
Use correct environment variable escaping
Rubber-stamped by Adam Roben.
Source/JavaScriptCore:
* JavaScriptCore.vcproj/JavaScriptCore.make:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
Source/WebCore:
* WebCore.vcproj/WebCore.make:
Source/WebKit/win:
* WebKit.vcproj/WebKit.make:
Source/WebKit2:
* win/WebKit2.make:
* win/WebKit2Generated.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76638
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 25 Jan 2011 21:29:14 +0000 (21:29 +0000)]
2011-01-25 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Empty URLs are never display isolated
https://bugs.webkit.org/show_bug.cgi?id=53053
This check mirrors the check in the local case. There isn't a good way
to test this with a LayoutTest, but it is tested in Chromium (where
this registry is used).
* platform/SchemeRegistry.cpp:
(WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76637
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 25 Jan 2011 21:14:50 +0000 (21:14 +0000)]
2011-01-25 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Pipe a timestamp down into the PlatformWheelEvent for the Mac.
https://bugs.webkit.org/show_bug.cgi?id=53111
* platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(WebCore::PlatformWheelEvent::timestamp):
Add timestamp member.
* platform/mac/WheelEventMac.mm:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
Initialize the timestamp from the event.
2011-01-25 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Don't inform the UI process about compositing changes when using the new drawing area
https://bugs.webkit.org/show_bug.cgi?id=53120
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::changeAcceleratedCompositingMode):
Return early if we're using the new drawing area.
(WebKit::WebPage::exitAcceleratedCompositingMode):
Call setRootCompositingLayer(0) so the drawing area knows when we leave accelerated compositing.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76636
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Tue, 25 Jan 2011 21:13:55 +0000 (21:13 +0000)]
2011-01-25 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
JSON.stringify processing time exponentially grows with size of object
https://bugs.webkit.org/show_bug.cgi?id=51922
Remove last use of reserveCapacity from JSON stringification, as it results
in appalling append behaviour when there are a large number of property names
and nothing else.
* runtime/JSONObject.cpp:
(JSC::Stringifier::appendQuotedString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76635
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 25 Jan 2011 21:11:32 +0000 (21:11 +0000)]
2011-01-25 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Don't inform the UI process about compositing changes when using the new drawing area
https://bugs.webkit.org/show_bug.cgi?id=53120
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::changeAcceleratedCompositingMode):
Return early if we're using the new drawing area.
(WebKit::WebPage::exitAcceleratedCompositingMode):
Call setRootCompositingLayer(0) so the drawing area knows when we leave accelerated compositing.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76634
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 25 Jan 2011 21:08:26 +0000 (21:08 +0000)]
2011-01-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r76625.
http://trac.webkit.org/changeset/76625
https://bugs.webkit.org/show_bug.cgi?id=53119
"incorrect pixel test results" (Requested by rniwa on
#webkit).
* rendering/RenderBox.cpp:
(WebCore::RenderBox::localCaretRect):
2011-01-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r76625.
http://trac.webkit.org/changeset/76625
https://bugs.webkit.org/show_bug.cgi?id=53119
"incorrect pixel test results" (Requested by rniwa on
#webkit).
* editing/selection/caret-painting-after-paste-undo-rtl.html: Removed.
* editing/selection/caret-painting-after-paste-undo.html: Removed.
* platform/mac/editing/deleting/
5408255-expected.checksum:
* platform/mac/editing/deleting/
5408255-expected.png:
* platform/mac/editing/selection/caret-painting-after-paste-undo-expected.checksum: Removed.
* platform/mac/editing/selection/caret-painting-after-paste-undo-expected.png: Removed.
* platform/mac/editing/selection/caret-painting-after-paste-undo-expected.txt: Removed.
* platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.checksum: Removed.
* platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.png: Removed.
* platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76633
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 25 Jan 2011 21:05:31 +0000 (21:05 +0000)]
2011-01-25 Tony Chang <tony@chromium.org>
Unreviewed, debugger-scripts.html is failing on windows too.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76632
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Tue, 25 Jan 2011 21:03:09 +0000 (21:03 +0000)]
[Chromium] Not reviewed, rebaseline for a test.
The difference is because V8 has different error messages.
* platform/chromium-mac/fast/js/js-continue-break-restrictions-expected.txt: Added.
* platform/chromium-win/fast/js/js-continue-break-restrictions-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76631
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Tue, 25 Jan 2011 20:55:39 +0000 (20:55 +0000)]
2011-01-25 James Robinson <jamesr@chromium.org>
Remove = TEXT PASS lines for tests that consistently pass.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76630
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Tue, 25 Jan 2011 20:55:38 +0000 (20:55 +0000)]
2011-01-25 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
[WINCE] Ensure layouted frame when painting
https://bugs.webkit.org/show_bug.cgi?id=53108
* WebView.cpp:
(WebView::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76629
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Tue, 25 Jan 2011 20:52:02 +0000 (20:52 +0000)]
Unreviewed build fix: rollback untintentional changes in media expected results.
* media/video-source-moved-expected.txt:
* media/video-source-none-supported-expected.txt:
* LayoutTests/platform/win/media/audio-data-url-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76628
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 25 Jan 2011 20:48:44 +0000 (20:48 +0000)]
2011-01-25 Tony Chang <tony@chromium.org>
Unreviewed, mark inspector/debugger-scripts.html as failing on chromium linux.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76627
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Tue, 25 Jan 2011 20:41:55 +0000 (20:41 +0000)]
2011-01-25 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r76614.
* platform/FileSystem.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76626
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Tue, 25 Jan 2011 20:17:08 +0000 (20:17 +0000)]
2011-01-21 Levi Weintraub <leviw@chromium.org>
Reviewed by Darin Adler.
Adding border and padding to the calculation of the local caret rect for RenderBoxes.
Undo moves caret to invalid position
https://bugs.webkit.org/show_bug.cgi?id=49744
Tests: editing/selection/caret-painting-after-paste-undo-rtl.html
editing/selection/caret-painting-after-paste-undo.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::localCaretRect):
2011-01-21 Levi Weintraub <leviw@chromium.org>
Reviewed by Darin Adler.
Updating the expected result for
5408255 and adding tests for caret positioning at the
beginning and end of RenderBoxes.
Undo moves caret to invalid position
https://bugs.webkit.org/show_bug.cgi?id=49744
* editing/selection/caret-painting-after-paste-undo-rtl.html: Added.
* editing/selection/caret-painting-after-paste-undo.html: Added.
* platform/mac/editing/deleting/
5408255-expected.checksum:
* platform/mac/editing/deleting/
5408255-expected.png:
* platform/mac/editing/selection/caret-painting-after-paste-undo-expected.checksum: Added.
* platform/mac/editing/selection/caret-painting-after-paste-undo-expected.png: Added.
* platform/mac/editing/selection/caret-painting-after-paste-undo-expected.txt: Added.
* platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.checksum: Added.
* platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.png: Added.
* platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76625
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 25 Jan 2011 20:03:06 +0000 (20:03 +0000)]
2011-01-25 Tony Chang <tony@chromium.org>
Unreviewed, add chromium-mac baselines after r76599.
The platform/mac-leopard results were stale which is why the expected
text results aren't updated as well.
* platform/chromium-mac/svg/custom/junk-data-expected.checksum: Added.
* platform/chromium-mac/svg/custom/junk-data-expected.png: Added.
* platform/chromium-mac/svg/custom/missing-xlink-expected.checksum: Added.
* platform/chromium-mac/svg/custom/missing-xlink-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76624
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Tue, 25 Jan 2011 20:01:12 +0000 (20:01 +0000)]
2011-01-25 James Robinson <jamesr@chromium.org>
Reviewed by Mihai Parparita.
Convert requestAnimationFrame tests to be script-tests
https://bugs.webkit.org/show_bug.cgi?id=53109
This converts the new requestAnimationFrame tests to be proper script-tests using make-script-test-wrapper.
* fast/animation/request-animation-frame-cancel-expected.txt:
* fast/animation/request-animation-frame-cancel.html:
* fast/animation/request-animation-frame-cancel2-expected.txt:
* fast/animation/request-animation-frame-cancel2.html:
* fast/animation/request-animation-frame-display-expected.txt:
* fast/animation/request-animation-frame-display.html:
* fast/animation/request-animation-frame-expected.txt:
* fast/animation/request-animation-frame-within-callback-expected.txt:
* fast/animation/request-animation-frame-within-callback.html:
* fast/animation/request-animation-frame.html:
* fast/animation/script-tests/TEMPLATE.html: Added.
* fast/animation/script-tests/request-animation-frame-cancel.js: Copied from LayoutTests/fast/animation/request-animation-frame-cancel.html.
* fast/animation/script-tests/request-animation-frame-cancel2.js: Copied from LayoutTests/fast/animation/request-animation-frame-cancel2.html.
(secondCallbackId):
* fast/animation/script-tests/request-animation-frame-display.js: Added.
* fast/animation/script-tests/request-animation-frame-within-callback.js: Copied from LayoutTests/fast/animation/request-animation-frame-within-callback.html.
(window):
* fast/animation/script-tests/request-animation-frame.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76623
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 25 Jan 2011 19:54:58 +0000 (19:54 +0000)]
2011-01-25 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add hasPreciseScrollingDeltas bit to PlatformWheelEvent on the Mac.
https://bugs.webkit.org/show_bug.cgi?id=53107
* platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(WebCore::PlatformWheelEvent::hasPreciseScrollingDeltas):
* platform/mac/WheelEventMac.mm:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
2011-01-25 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add hasPreciseScrollingDeltas bit to PlatformWheelEvent on the Mac.
https://bugs.webkit.org/show_bug.cgi?id=53107
* Shared/WebEvent.h:
(WebKit::WebWheelEvent::hasPreciseScrollingDeltas):
* Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):
* Shared/WebWheelEvent.cpp:
(WebKit::WebWheelEvent::WebWheelEvent):
* Shared/mac/WebEventFactory.mm:
(WebKit::WebEventFactory::createWebWheelEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76622
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Tue, 25 Jan 2011 19:52:17 +0000 (19:52 +0000)]
2011-01-20 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
REGRESSION (r72119): Audio never plays on Star Wars intro animation
https://bugs.webkit.org/show_bug.cgi?id=52467
Test the ability to read audio/m4a files. Disabled this new test
on the chromium and qt platforms, as they do not support M4A/AAC.
* media/audio-mpeg4-supported-expected.txt: Added.
* media/audio-mpeg4-supported.html: Added.
* media/content/silence.m4a: Added.
* platform/chromium/test_expectations.txt:
* platform/qt/Skipped:
2011-01-20 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
REGRESSION (r72119): Audio never plays on Star Wars intro animation
https://bugs.webkit.org/show_bug.cgi?id=52467
QuickTime's eat/m4a movie importer compontent doesn't list audio/m4a as a mime
type which it supports, though it handles .m4a files just fine. Change the way
we build the list of supported MIME Types through a new WebKitSystemInterface
function.
Caused by r72119, which adds system-specific extension->MIME entries to the cache
before global entries, and the system-specific entries include QuickTime's registry
entries which contain the audio/m4a MIME type, while its components do not.
Test: media/audio-mpeg4-supported.html
* WebCore.vcproj/QTMovieWinCommon.vsprops:
* platform/graphics/win/QTMovie.cpp:
(getMIMETypeCallBack):
(initializeSupportedTypes):
(QTMovie::countSupportedTypes): gSupportedTypes is now a CFArrayRef.
(QTMovie::getSupportedType): Ditto.
2011-01-24 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
REGRESSION (r72119): Audio never plays on Star Wars intro animation
https://bugs.webkit.org/show_bug.cgi?id=52467
Add wkGetQuickTimeMIMETypeList() function.
* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76621
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 25 Jan 2011 19:39:58 +0000 (19:39 +0000)]
2011-01-25 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] remove unused layoutTestController callback
https://bugs.webkit.org/show_bug.cgi?id=53103
This method is used by a test_shell_test, but not needed by DRT.
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/chromium/LayoutTestController.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76620
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 25 Jan 2011 19:39:04 +0000 (19:39 +0000)]
2011-01-25 Tony Chang <tony@chromium.org>
Unreviewed, rebaseline a test on chromium-win. Part of r76586 rebaselines.
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76619
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 25 Jan 2011 19:25:26 +0000 (19:25 +0000)]
2011-01-25 Ryosuke Niwa <rniwa@webkit.org>
Another unreviewed SVG rebaselines for Chromium.
* platform/chromium-linux/svg/text/text-text-05-t-expected.checksum:
* platform/chromium-linux/svg/text/text-text-05-t-expected.png:
* platform/chromium-mac/svg/text/text-text-05-t-expected.checksum:
* platform/chromium-mac/svg/text/text-text-05-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
* platform/chromium-win/svg/text/text-text-05-t-expected.checksum:
* platform/chromium-win/svg/text/text-text-05-t-expected.png:
* platform/chromium-win/svg/text/text-text-05-t-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76618
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 25 Jan 2011 19:14:35 +0000 (19:14 +0000)]
2011-01-25 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
need a way to request the host CALayer render server port
https://bugs.webkit.org/show_bug.cgi?id=53101
<rdar://problem/
8913620>
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::compositingRenderServerPort):
Get the render server port from the plug-in process.
* PluginProcess/PluginControllerProxy.h:
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
Call NetscapePlugin::compositingRenderServerPort.
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::compositingRenderServerPort):
Call PluginController::compositingRenderServerPort.
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::compositingRenderServerPort):
Get the render server port from the web process.
* WebProcess/Plugins/PluginView.h:
Add compositingRenderServerPort.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76617
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Tue, 25 Jan 2011 19:07:09 +0000 (19:07 +0000)]
2011-01-25 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Remove PlatformBridge::idbShutdown()
https://bugs.webkit.org/show_bug.cgi?id=53077
Since Chromium r72157, this is not used anymore. The previous use was
to signal to the embedder that IndexedDB was shutting down, but we
agreed it is better if the embedder keeps track of that itself.
No new tests: this does not change any functionality.
* platform/chromium/PlatformBridge.h:
* storage/IDBFactoryBackendInterface.cpp:
* storage/IDBFactoryBackendInterface.h:
(WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
* storage/chromium/IDBFactoryBackendInterface.cpp:
2011-01-25 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Remove PlatformBridge::idbShutdown()
https://bugs.webkit.org/show_bug.cgi?id=53077
Since Chromium r72157, this is not used anymore. Chromium keeps track
of when it shuts down IndexedDB itself.
* public/WebKitClient.h:
* src/PlatformBridge.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76616
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Tue, 25 Jan 2011 19:06:58 +0000 (19:06 +0000)]
Not reviewed.
Try to fix windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 25 Jan 2011 19:03:16 +0000 (19:03 +0000)]
2011-01-25 Darin Adler <darin@apple.com>
Reviewed by Anders Carlsson.
WebKit is using CSBackupSetItemExcluded incorrectly
https://bugs.webkit.org/show_bug.cgi?id=53095
rdar://problem/
8790540
* Misc/WebIconDatabase.mm:
(importToWebCoreFormat): Removed code that was calling CSBackupSetItemExcluded.
It was incorrect, and this responsibility has been moved to WebCore.
2011-01-25 Darin Adler <darin@apple.com>
Reviewed by Anders Carlsson.
WebKit is using CSBackupSetItemExcluded incorrectly
https://bugs.webkit.org/show_bug.cgi?id=53095
rdar://problem/
8790540
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::performOpenInitialization): Added code to
exclude the database from backup one time, and record inside the
database that this has been done.
(WebCore::IconDatabase::wasExcludedFromBackup): Added.
(WebCore::IconDatabase::setWasExcludedFromBackup): Added.
* loader/icon/IconDatabase.h: Added new functions above.
* platform/FileSystem.cpp:
(WebCore::canExcludeFromBackup): Added.
(WebCore::excludeFromBackup): Added.
* platform/FileSystem.h: Added canExcludeFromBackup, excludeFromBackup,
and pathAsURL functions. Cleaned up ifdefs and comments a bit and sorted
things alphabetically, particularly platform-specific sections.
* platform/cf/FileSystemCF.cpp:
(WebCore::pathAsURL): Added.
* platform/mac/FileSystemMac.mm:
(WebCore::canExcludeFromBackup): Added.
(WebCore::excludeFromBackup): Added.
* platform/network/cf/FormDataStreamCFNet.cpp:
(WebCore::advanceCurrentStream): Changed to call pathAsURL.
* platform/network/mac/FormDataStreamMac.mm:
(WebCore::advanceCurrentStream): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76614
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Tue, 25 Jan 2011 18:56:26 +0000 (18:56 +0000)]
2011-01-25 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
Skip another new test that uses eventSender
https://bugs.webkit.org/show_bug.cgi?id=53094
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76613
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 25 Jan 2011 18:54:30 +0000 (18:54 +0000)]
2011-01-25 Helder Correia <helder@sencha.com>
Reviewed by Dirk Schulze.
REGRESSION(75139): SVG gradients are not applied to texts
https://bugs.webkit.org/show_bug.cgi?id=52531
CGContextConcatCTM should use the CGLayer context, not the
GraphicsContext. Also, the CTM needs to be adjusted (translated).
This fixes SVG text gradient fill.
Test: svg/css/composite-shadow-text.svg
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::fillRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76612
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Tue, 25 Jan 2011 18:44:11 +0000 (18:44 +0000)]
REGRESSION: Leak in JSParser::Scope::copyCapturedVariablesToVector()
https://bugs.webkit.org/show_bug.cgi?id=53061
Reviewed by Oliver Hunt.
Cache did not know about the subclass so failed to fully delete the items.
Got rid of the subclass and moved the classes to separate files.
* CMakeLists.txt:
* GNUmakefile.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* parser/JSParser.cpp:
(JSC::JSParser::Scope::saveFunctionInfo):
(JSC::JSParser::Scope::restoreFunctionInfo):
(JSC::JSParser::findCachedFunctionInfo):
(JSC::JSParser::parseFunctionInfo):
* parser/SourceProvider.h:
* parser/SourceProviderCache.cpp: Added.
(JSC::SourceProviderCache::~SourceProviderCache):
(JSC::SourceProviderCache::byteSize):
* parser/SourceProviderCache.h: Added.
(JSC::SourceProviderCache::SourceProviderCache):
(JSC::SourceProviderCache::add):
(JSC::SourceProviderCache::get):
* parser/SourceProviderCacheItem.h: Added.
(JSC::SourceProviderCacheItem::SourceProviderCacheItem):
(JSC::SourceProviderCacheItem::approximateByteSize):
(JSC::SourceProviderCacheItem::closeBraceToken):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76611
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 25 Jan 2011 18:42:43 +0000 (18:42 +0000)]
2011-01-25 Benjamin Kalman <kalman@chromium.org>
Reviewed by Ryosuke Niwa.
Cannot extend or modify forward by word over a non-contenteditable region
https://bugs.webkit.org/show_bug.cgi?id=53070
Add regression test.
* editing/selection/extend-forward-by-word-over-non-editable-expected.txt: Added.
* editing/selection/extend-forward-by-word-over-non-editable.html: Added.
2011-01-25 Benjamin Kalman <kalman@chromium.org>
Reviewed by Ryosuke Niwa.
Cannot extend or modify forward by word over a non-contenteditable region
https://bugs.webkit.org/show_bug.cgi?id=53070
Test: editing/selection/extend-forward-by-word-over-non-editable.html
Change all instances of honorEditableBoundaryAtOrAfter to honorEditableBoundaryAtOrBefore and vice versa in the
functions which determine the end/start of words/lines/sentences in visible_units.cpp.
This fixes the bug where moving forwards by a word over a non-contenteditable region would place the cursor
inside that region, and then get moved back to the start of the word due to honorEditableBoundaryAtOrBefore.
The cursor is now moved to the end of the region (which is effectively a noop in this case).
* editing/visible_units.cpp: Change all instances of honorEditableBoundaryAtOrAfter to
honorEditableBoundaryAtOrBefore and vice versa.
(WebCore::previousWordPosition):
(WebCore::nextWordPosition):
(WebCore::startOfLine):
(WebCore::endOfLine):
(WebCore::previousSentencePosition):
(WebCore::nextSentencePosition):
(WebCore::logicalStartOfLine):
(WebCore::logicalEndOfLine):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76610
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 25 Jan 2011 18:28:35 +0000 (18:28 +0000)]
2011-01-25 Marcilio Mendonca <mamendonca@rim.com>
Reviewed by Darin Adler.
Bug 53087: Refactoring: replaced a hanging "else" with a "return"
statement
https://bugs.webkit.org/show_bug.cgi?id=53087.
Refactoring work: Replaced a hanging "else" within an #if PLATFORM(M
with a "return" so that the code is more readable and less error pro
(e.g., "else" doesn't use braces so adding extra lines to the else
block won't have any effect; even worse, code still compiles
successfully.
* wtf/Assertions.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76609
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Tue, 25 Jan 2011 18:26:51 +0000 (18:26 +0000)]
Change some floating point constants from 1.0 to 1.
Rubber stamped by Dan Bernstein.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76608
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 25 Jan 2011 18:19:29 +0000 (18:19 +0000)]
2011-01-25 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed SVG rebaselines for Chromium.
* platform/chromium-linux/svg/batik/text/textEffect-expected.checksum:
* platform/chromium-linux/svg/batik/text/textEffect-expected.png:
* platform/chromium-linux/svg/batik/text/textEffect-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/textEffect3-expected.checksum:
* platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
* platform/chromium-linux/svg/batik/text/textEffect3-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
* platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.checksum:
* platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.txt: Added.
* platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
* platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.png:
* platform/chromium-linux/svg/custom/svg-fonts-without-missing-glyph-expected.checksum:
* platform/chromium-linux/svg/custom/svg-fonts-without-missing-glyph-expected.png:
* platform/chromium-linux/svg/text/text-text-06-t-expected.checksum:
* platform/chromium-linux/svg/text/text-text-06-t-expected.png:
* platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.checksum:
* platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-mac/svg/text/text-text-06-t-expected.checksum:
* platform/chromium-mac/svg/text/text-text-06-t-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
* platform/chromium-win/svg/batik/text/textEffect-expected.checksum:
* platform/chromium-win/svg/batik/text/textEffect-expected.png:
* platform/chromium-win/svg/batik/text/textEffect-expected.txt:
* platform/chromium-win/svg/batik/text/textEffect3-expected.checksum:
* platform/chromium-win/svg/batik/text/textEffect3-expected.png:
* platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
* platform/chromium-win/svg/batik/text/textPosition2-expected.txt:
* platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
* platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png:
* platform/chromium-win/svg/custom/svg-fonts-without-missing-glyph-expected.checksum:
* platform/chromium-win/svg/custom/svg-fonts-without-missing-glyph-expected.png:
* platform/chromium-win/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
* platform/chromium-win/svg/text/text-text-06-t-expected.checksum:
* platform/chromium-win/svg/text/text-text-06-t-expected.png:
* platform/chromium-win/svg/text/text-text-06-t-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76607
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Tue, 25 Jan 2011 18:18:28 +0000 (18:18 +0000)]
Unreviewed build fix.
After r76466, efsrv.lib is used unconditionally.
Don't guard it with ENABLE_NETSCAPE_PLUGIN_API.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76606
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 25 Jan 2011 18:09:41 +0000 (18:09 +0000)]
2011-01-25 Tony Chang <tony@chromium.org>
Unreviewed, remove passing chromium win tests.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76605
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Tue, 25 Jan 2011 17:54:27 +0000 (17:54 +0000)]
2011-01-25 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders Carlsson.
Improve scale factor resetting
https://bugs.webkit.org/show_bug.cgi?id=53093
Two key changes:
- Don't set the scale factor to what it already is, as this causes an
uneeded force layout and scroll
- Don't ever set the scale factor based on a non-main frame committing
This fixes two WebKit2 layout tests.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76604
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Tue, 25 Jan 2011 17:47:30 +0000 (17:47 +0000)]
2011-01-24 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Style cleanup for WebGLRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=52352
* html/canvas/WebGLBuffer.cpp:
* html/canvas/WebGLBuffer.h:
* html/canvas/WebGLObject.cpp:
* html/canvas/WebGLProgram.cpp:
* html/canvas/WebGLRenderbuffer.cpp:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::create):
(WebCore::WebGLRenderingContext::blendFunc):
(WebCore::WebGLRenderingContext::createShader):
(WebCore::WebGLRenderingContext::deleteBuffer):
(WebCore::WebGLRenderingContext::deleteShader):
(WebCore::WebGLRenderingContext::deleteTexture):
(WebCore::WebGLRenderingContext::disableVertexAttribArray):
(WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
(WebCore::WebGLRenderingContext::validateRenderingState):
(WebCore::WebGLRenderingContext::enableVertexAttribArray):
(WebCore::WebGLRenderingContext::getUniform):
(WebCore::WebGLRenderingContext::detachAndRemoveAllObjects):
* html/canvas/WebGLRenderingContext.h:
* html/canvas/WebGLShader.cpp:
* html/canvas/WebGLTexture.cpp:
* html/canvas/WebGLUniformLocation.cpp:
* html/canvas/WebGLUniformLocation.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76603
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 25 Jan 2011 17:43:34 +0000 (17:43 +0000)]
2011-01-25 Ilya Sherman <isherman@chromium.org>
Reviewed by Darin Fisher.
Chromium WebKit API: Move dispatchFormControlChangeEvent() from WebInputElement to WebFormControlElement
In service of https://code.google.com/p/chromium/issues/detail?id=42716
https://bugs.webkit.org/show_bug.cgi?id=53069
* public/WebFormControlElement.h:
* public/WebInputElement.h:
* src/WebFormControlElement.cpp:
(WebKit::WebFormControlElement::dispatchFormControlChangeEvent): Moved from WebInputElement
* src/WebInputElement.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76602
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Tue, 25 Jan 2011 17:34:34 +0000 (17:34 +0000)]
2011-01-24 Chris Marrin <cmarrin@apple.com>
Reviewed by Eric Seidel.
Change ENABLE_3D_CANVAS to ENABLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=53041
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.cpp:
* GNUmakefile.am:
* WebCore.pro:
* bindings/generic/RuntimeEnabledFeatures.h:
* bindings/js/JSArrayBufferCustom.cpp:
* bindings/js/JSCanvasRenderingContextCustom.cpp:
(WebCore::toJS):
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/js/JSDataViewCustom.cpp:
* bindings/js/JSDocumentCustom.cpp:
* bindings/js/JSFloat32ArrayCustom.cpp:
* bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
* bindings/js/JSInt16ArrayCustom.cpp:
* bindings/js/JSInt32ArrayCustom.cpp:
* bindings/js/JSInt8ArrayCustom.cpp:
* bindings/js/JSUint16ArrayCustom.cpp:
* bindings/js/JSUint32ArrayCustom.cpp:
* bindings/js/JSUint8ArrayCustom.cpp:
* bindings/js/JSWebGLRenderingContextCustom.cpp:
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::markChildren):
(WebCore::JSXMLHttpRequest::send):
(WebCore::JSXMLHttpRequest::response):
* bindings/v8/custom/V8ArrayBufferCustom.cpp:
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
* bindings/v8/custom/V8DataViewCustom.cpp:
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::getCSSCanvasContextCallback):
* bindings/v8/custom/V8Float32ArrayCustom.cpp:
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
* bindings/v8/custom/V8Int16ArrayCustom.cpp:
* bindings/v8/custom/V8Int32ArrayCustom.cpp:
* bindings/v8/custom/V8Int8ArrayCustom.cpp:
* bindings/v8/custom/V8Uint16ArrayCustom.cpp:
* bindings/v8/custom/V8Uint32ArrayCustom.cpp:
* bindings/v8/custom/V8Uint8ArrayCustom.cpp:
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::responseAccessorGetter):
(WebCore::V8XMLHttpRequest::sendCallback):
* features.pri:
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
(WebCore::HTMLCanvasElement::reset):
* html/HTMLCanvasElement.h:
* html/canvas/ArrayBuffer.cpp:
* html/canvas/ArrayBuffer.idl:
* html/canvas/ArrayBufferView.cpp:
* html/canvas/ArrayBufferView.idl:
* html/canvas/DataView.cpp:
* html/canvas/DataView.idl:
* html/canvas/Float32Array.cpp:
* html/canvas/Float32Array.idl:
* html/canvas/Int16Array.cpp:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.cpp:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.cpp:
* html/canvas/Int8Array.idl:
* html/canvas/OESStandardDerivatives.cpp:
* html/canvas/OESStandardDerivatives.idl:
* html/canvas/OESTextureFloat.cpp:
* html/canvas/OESTextureFloat.idl:
* html/canvas/Uint16Array.cpp:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.cpp:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.cpp:
* html/canvas/Uint8Array.idl:
* html/canvas/WebGLActiveInfo.idl:
* html/canvas/WebGLBuffer.cpp:
* html/canvas/WebGLBuffer.idl:
* html/canvas/WebGLContextAttributes.cpp:
* html/canvas/WebGLContextAttributes.idl:
* html/canvas/WebGLContextEvent.idl:
* html/canvas/WebGLExtension.cpp:
* html/canvas/WebGLFramebuffer.cpp:
* html/canvas/WebGLFramebuffer.idl:
* html/canvas/WebGLGetInfo.cpp:
* html/canvas/WebGLObject.cpp:
* html/canvas/WebGLProgram.cpp:
* html/canvas/WebGLProgram.idl:
* html/canvas/WebGLRenderbuffer.cpp:
* html/canvas/WebGLRenderbuffer.idl:
* html/canvas/WebGLRenderingContext.cpp:
* html/canvas/WebGLRenderingContext.idl:
* html/canvas/WebGLShader.cpp:
* html/canvas/WebGLShader.idl:
* html/canvas/WebGLTexture.cpp:
* html/canvas/WebGLTexture.idl:
* html/canvas/WebGLUniformLocation.cpp:
* html/canvas/WebGLUniformLocation.idl:
* html/canvas/WebKitLoseContext.cpp:
* html/canvas/WebKitLoseContext.idl:
* page/DOMWindow.idl:
* platform/graphics/ANGLEWebKitBridge.cpp:
* platform/graphics/GraphicsContext3D.cpp:
* platform/graphics/cg/GraphicsContext3DCG.cpp:
* platform/graphics/gpu/DrawingBuffer.cpp:
* platform/graphics/gpu/mac/DrawingBufferMac.mm:
* platform/graphics/mac/GraphicsContext3DMac.mm:
* platform/graphics/mac/WebGLLayer.mm:
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
* platform/graphics/qt/Extensions3DQt.cpp:
* platform/graphics/qt/GraphicsContext3DQt.cpp:
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
(WebCore::GraphicsLayerQtImpl::paint):
(WebCore::GraphicsLayerQtImpl::flushChanges):
* platform/graphics/qt/GraphicsLayerQt.h:
* platform/graphics/skia/GraphicsContext3DSkia.cpp:
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::isAcceleratedCanvas):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::containsPaintedContent):
(WebCore::RenderLayerBacking::contentChanged):
* webaudio/AudioBuffer.cpp:
* webaudio/AudioBuffer.idl:
* webaudio/RealtimeAnalyser.cpp:
* webaudio/RealtimeAnalyser.h:
* webaudio/RealtimeAnalyserNode.h:
* webaudio/RealtimeAnalyserNode.idl:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::setResponseType):
(WebCore::XMLHttpRequest::clearResponse):
(WebCore::XMLHttpRequest::didReceiveData):
* xml/XMLHttpRequest.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76601
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cmarrin@apple.com [Tue, 25 Jan 2011 17:27:30 +0000 (17:27 +0000)]
2011-01-24 Chris Marrin <cmarrin@apple.com>
Reviewed by Eric Seidel.
Change ENABLE_3D_CANVAS to ENABLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=53041
* configure.ac:
2011-01-24 Chris Marrin <cmarrin@apple.com>
Reviewed by Eric Seidel.
Change ENABLE_3D_CANVAS to ENABLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=53041
* Configurations/FeatureDefines.xcconfig:
2011-01-24 Chris Marrin <cmarrin@apple.com>
Reviewed by Eric Seidel.
Change ENABLE_3D_CANVAS to ENABLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=53041
* WebKit.gyp:
* features.gypi:
* src/Extensions3DChromium.cpp:
* src/GraphicsContext3DChromium.cpp:
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableWebGL):
(WebKit::WebRuntimeFeatures::isWebGLEnabled):
2011-01-24 Chris Marrin <cmarrin@apple.com>
Reviewed by Eric Seidel.
Change ENABLE_3D_CANVAS to ENABLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=53041
* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
2011-01-24 Chris Marrin <cmarrin@apple.com>
Reviewed by Eric Seidel.
Change ENABLE_3D_CANVAS to ENABLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=53041
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2011-01-24 Chris Marrin <cmarrin@apple.com>
Reviewed by Eric Seidel.
Change ENABLE_3D_CANVAS to ENABLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=53041
* Configurations/FeatureDefines.xcconfig:
2011-01-24 Chris Marrin <cmarrin@apple.com>
Reviewed by Eric Seidel.
Change ENABLE_3D_CANVAS to ENABLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=53041
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.cpp:
* GNUmakefile.am:
* WebCore.pro:
* bindings/generic/RuntimeEnabledFeatures.h:
* bindings/js/JSArrayBufferCustom.cpp:
* bindings/js/JSCanvasRenderingContextCustom.cpp:
(WebCore::toJS):
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/js/JSDataViewCustom.cpp:
* bindings/js/JSDocumentCustom.cpp:
* bindings/js/JSFloat32ArrayCustom.cpp:
* bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
* bindings/js/JSInt16ArrayCustom.cpp:
* bindings/js/JSInt32ArrayCustom.cpp:
* bindings/js/JSInt8ArrayCustom.cpp:
* bindings/js/JSUint16ArrayCustom.cpp:
* bindings/js/JSUint32ArrayCustom.cpp:
* bindings/js/JSUint8ArrayCustom.cpp:
* bindings/js/JSWebGLRenderingContextCustom.cpp:
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::markChildren):
(WebCore::JSXMLHttpRequest::send):
(WebCore::JSXMLHttpRequest::response):
* bindings/v8/custom/V8ArrayBufferCustom.cpp:
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
* bindings/v8/custom/V8DataViewCustom.cpp:
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::getCSSCanvasContextCallback):
* bindings/v8/custom/V8Float32ArrayCustom.cpp:
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
* bindings/v8/custom/V8Int16ArrayCustom.cpp:
* bindings/v8/custom/V8Int32ArrayCustom.cpp:
* bindings/v8/custom/V8Int8ArrayCustom.cpp:
* bindings/v8/custom/V8Uint16ArrayCustom.cpp:
* bindings/v8/custom/V8Uint32ArrayCustom.cpp:
* bindings/v8/custom/V8Uint8ArrayCustom.cpp:
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::responseAccessorGetter):
(WebCore::V8XMLHttpRequest::sendCallback):
* features.pri:
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
(WebCore::HTMLCanvasElement::reset):
* html/HTMLCanvasElement.h:
* html/canvas/ArrayBuffer.cpp:
* html/canvas/ArrayBuffer.idl:
* html/canvas/ArrayBufferView.cpp:
* html/canvas/ArrayBufferView.idl:
* html/canvas/DataView.cpp:
* html/canvas/DataView.idl:
* html/canvas/Float32Array.cpp:
* html/canvas/Float32Array.idl:
* html/canvas/Int16Array.cpp:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.cpp:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.cpp:
* html/canvas/Int8Array.idl:
* html/canvas/OESStandardDerivatives.cpp:
* html/canvas/OESStandardDerivatives.idl:
* html/canvas/OESTextureFloat.cpp:
* html/canvas/OESTextureFloat.idl:
* html/canvas/Uint16Array.cpp:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.cpp:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.cpp:
* html/canvas/Uint8Array.idl:
* html/canvas/WebGLActiveInfo.idl:
* html/canvas/WebGLBuffer.cpp:
* html/canvas/WebGLBuffer.idl:
* html/canvas/WebGLContextAttributes.cpp:
* html/canvas/WebGLContextAttributes.idl:
* html/canvas/WebGLContextEvent.idl:
* html/canvas/WebGLExtension.cpp:
* html/canvas/WebGLFramebuffer.cpp:
* html/canvas/WebGLFramebuffer.idl:
* html/canvas/WebGLGetInfo.cpp:
* html/canvas/WebGLObject.cpp:
* html/canvas/WebGLProgram.cpp:
* html/canvas/WebGLProgram.idl:
* html/canvas/WebGLRenderbuffer.cpp:
* html/canvas/WebGLRenderbuffer.idl:
* html/canvas/WebGLRenderingContext.cpp:
* html/canvas/WebGLRenderingContext.idl:
* html/canvas/WebGLShader.cpp:
* html/canvas/WebGLShader.idl:
* html/canvas/WebGLTexture.cpp:
* html/canvas/WebGLTexture.idl:
* html/canvas/WebGLUniformLocation.cpp:
* html/canvas/WebGLUniformLocation.idl:
* html/canvas/WebKitLoseContext.cpp:
* html/canvas/WebKitLoseContext.idl:
* page/DOMWindow.idl:
* platform/graphics/ANGLEWebKitBridge.cpp:
* platform/graphics/GraphicsContext3D.cpp:
* platform/graphics/cg/GraphicsContext3DCG.cpp:
* platform/graphics/gpu/DrawingBuffer.cpp:
* platform/graphics/gpu/mac/DrawingBufferMac.mm:
* platform/graphics/mac/GraphicsContext3DMac.mm:
* platform/graphics/mac/WebGLLayer.mm:
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
* platform/graphics/qt/Extensions3DQt.cpp:
* platform/graphics/qt/GraphicsContext3DQt.cpp:
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
(WebCore::GraphicsLayerQtImpl::paint):
(WebCore::GraphicsLayerQtImpl::flushChanges):
* platform/graphics/qt/GraphicsLayerQt.h:
* platform/graphics/skia/GraphicsContext3DSkia.cpp:
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::isAcceleratedCanvas):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::containsPaintedContent):
(WebCore::RenderLayerBacking::contentChanged):
* webaudio/AudioBuffer.cpp:
* webaudio/AudioBuffer.idl:
* webaudio/RealtimeAnalyser.cpp:
* webaudio/RealtimeAnalyser.h:
* webaudio/RealtimeAnalyserNode.h:
* webaudio/RealtimeAnalyserNode.idl:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::setResponseType):
(WebCore::XMLHttpRequest::clearResponse):
(WebCore::XMLHttpRequest::didReceiveData):
* xml/XMLHttpRequest.h:
2011-01-24 Chris Marrin <cmarrin@apple.com>
Reviewed by Eric Seidel.
Change ENABLE_3D_CANVAS to ENABLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=53041
* Configurations/FeatureDefines.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76600
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 25 Jan 2011 17:22:46 +0000 (17:22 +0000)]
2011-01-25 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
Update Leopard svg/ pixel test baselines, to make run-webkit-tests -p pass again with --tolerance 0.
Contains only marginal differences, or updates pixel test results that were forgotten to update.
* platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
* platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
* platform/mac-leopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
* platform/mac-leopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
* platform/mac-leopard/svg/W3C-SVG-1.1/struct-image-07-t-expected.checksum: Added.
* platform/mac-leopard/svg/W3C-SVG-1.1/struct-image-07-t-expected.png: Added.
* platform/mac-leopard/svg/W3C-SVG-1.1/struct-use-01-t-expected.checksum: Added.
* platform/mac-leopard/svg/W3C-SVG-1.1/struct-use-01-t-expected.png: Added.
* platform/mac-leopard/svg/css/text-gradient-shadow-expected.checksum: Added.
* platform/mac-leopard/svg/css/text-gradient-shadow-expected.png: Added.
* platform/mac-leopard/svg/custom/image-rescale-clip-expected.checksum:
* platform/mac-leopard/svg/custom/image-rescale-clip-expected.png:
* platform/mac-leopard/svg/custom/image-rescale-scroll-expected.checksum: Added.
* platform/mac-leopard/svg/custom/image-rescale-scroll-expected.png: Added.
* platform/mac-leopard/svg/custom/junk-data-expected.checksum:
* platform/mac-leopard/svg/custom/junk-data-expected.png:
* platform/mac-leopard/svg/custom/missing-xlink-expected.checksum:
* platform/mac-leopard/svg/custom/missing-xlink-expected.png:
* platform/mac-leopard/svg/filters/feComposite-expected.checksum:
* platform/mac-leopard/svg/filters/feComposite-expected.png:
* platform/mac-leopard/svg/filters/filter-rounding-issues-expected.checksum: Added.
* platform/mac-leopard/svg/filters/filter-rounding-issues-expected.png: Added.
* platform/mac-leopard/svg/repaint/filter-repaint-expected.checksum:
* platform/mac-leopard/svg/repaint/filter-repaint-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76599
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 25 Jan 2011 17:14:47 +0000 (17:14 +0000)]
Windows Production build fix
* JavaScriptCore.vcproj/JavaScriptCore.make: Added a missing "set".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76598
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Tue, 25 Jan 2011 17:11:06 +0000 (17:11 +0000)]
2011-01-25 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Prepare for landing of detailed heap snapshots.
- Introduce Preferences.detailedHeapProfiles flag for controlling
querying of detailed heap snapshots.
- Add boilerplate code for the new view.
- Factor out common code.
https://bugs.webkit.org/show_bug.cgi?id=52624
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* bindings/js/ScriptProfiler.h:
(WebCore::ScriptProfiler::HeapSnapshotControl::~HeapSnapshotControl):
(WebCore::ScriptProfiler::takeHeapSnapshot):
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::takeHeapSnapshot):
* bindings/v8/ScriptProfiler.h:
(WebCore::ScriptProfiler::HeapSnapshotControl::~HeapSnapshotControl):
* inspector/Inspector.idl:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::takeHeapSnapshot):
* inspector/InspectorProfilerAgent.h:
* inspector/front-end/DetailedHeapshotView.js: Added.
(WebInspector.DetailedHeapshotView):
(WebInspector.DetailedHeapshotView.prototype.get statusBarItems):
(WebInspector.DetailedHeapshotView.prototype.get profile):
(WebInspector.DetailedHeapshotView.prototype.set profile):
(WebInspector.DetailedHeapshotView.prototype.show):
(WebInspector.DetailedHeapshotView.prototype.hide):
(WebInspector.DetailedHeapshotProfileType):
(WebInspector.DetailedHeapshotProfileType.prototype.get buttonTooltip):
(WebInspector.DetailedHeapshotProfileType.prototype.get buttonStyle):
(WebInspector.DetailedHeapshotProfileType.prototype.buttonClicked):
(WebInspector.DetailedHeapshotProfileType.prototype.get welcomeMessage):
(WebInspector.DetailedHeapshotProfileType.prototype.createSidebarTreeElementForProfile):
(WebInspector.DetailedHeapshotProfileType.prototype.createView):
* inspector/front-end/HeapSnapshot.js: Added.
(WebInspector.HeapSnapshotEdgesIterator):
(WebInspector.HeapSnapshotEdgesIterator.prototype.get done):
(WebInspector.HeapSnapshotEdgesIterator.prototype.get isElement):
(WebInspector.HeapSnapshotEdgesIterator.prototype.get isHidden):
(WebInspector.HeapSnapshotEdgesIterator.prototype.get name):
(WebInspector.HeapSnapshotEdgesIterator.prototype.next):
(WebInspector.HeapSnapshotEdgesIterator.prototype.get node):
(WebInspector.HeapSnapshotEdgesIterator.prototype.get nodeIndex):
(WebInspector.HeapSnapshotEdgesIterator.prototype._getNameOrIndex):
(WebInspector.HeapSnapshotEdgesIterator.prototype._getType):
(WebInspector.HeapSnapshotNodeWrapper):
(WebInspector.HeapSnapshotNodeWrapper.prototype.get edges):
(WebInspector.HeapSnapshotNodeWrapper.prototype.get edgesCount):
(WebInspector.HeapSnapshotNodeWrapper.prototype.get instancesCount):
(WebInspector.HeapSnapshotNodeWrapper.prototype.get isHidden):
(WebInspector.HeapSnapshotNodeWrapper.prototype.get name):
(WebInspector.HeapSnapshotNodeWrapper.prototype.get selfSize):
(WebInspector.HeapSnapshotNodeWrapper.prototype._getName):
(WebInspector.HeapSnapshotNodeWrapper.prototype._getEdges):
(WebInspector.HeapSnapshotNodeWrapper.prototype._getType):
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype.get rootEdges):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._setRecordingProfile):
(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
(WebInspector.ProfilerDispatcher.prototype.setRecordingProfile):
(WebInspector.ProfilerDispatcher.prototype.reportHeapSnapshotProgress):
* inspector/front-end/Settings.js:
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector._createPanels):
* src/js/DevTools.js:
():
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76597
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 25 Jan 2011 17:10:08 +0000 (17:10 +0000)]
2011-01-25 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
Update Snow Leopard svg/ pixel test baselines, to make run-webkit-tests -p pass again with --tolerance 0.
Contains only marginal differences, or updates pixel test results that were forgotten to update.
* platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
* platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
* platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum:
* platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
* platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
* platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.checksum:
* platform/mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/struct-image-07-t-expected.checksum:
* platform/mac/svg/W3C-SVG-1.1/struct-image-07-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.checksum:
* platform/mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.png:
* platform/mac/svg/batik/text/textEffect-expected.checksum:
* platform/mac/svg/batik/text/textEffect-expected.png:
* platform/mac/svg/batik/text/textEffect3-expected.checksum:
* platform/mac/svg/batik/text/textEffect3-expected.png:
* platform/mac/svg/custom/baseval-animval-equality-expected.checksum:
* platform/mac/svg/custom/baseval-animval-equality-expected.png:
* platform/mac/svg/custom/foreign-object-skew-expected.checksum:
* platform/mac/svg/custom/foreign-object-skew-expected.png:
* platform/mac/svg/custom/image-rescale-expected.checksum:
* platform/mac/svg/custom/image-rescale-expected.png:
* platform/mac/svg/custom/svg-fonts-in-html-expected.checksum:
* platform/mac/svg/custom/svg-fonts-in-html-expected.png:
* platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
* platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.png:
* platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.checksum:
* platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum:
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
* platform/mac/svg/filters/feComposite-expected.checksum:
* platform/mac/svg/filters/feComposite-expected.png:
* platform/mac/svg/filters/filter-rounding-issues-expected.checksum:
* platform/mac/svg/filters/filter-rounding-issues-expected.png:
* platform/mac/svg/filters/filteredImage-expected.checksum:
* platform/mac/svg/filters/filteredImage-expected.png:
* platform/mac/svg/repaint/filter-repaint-expected.checksum:
* platform/mac/svg/repaint/filter-repaint-expected.png:
* platform/mac/svg/text/text-text-05-t-expected.checksum:
* platform/mac/svg/text/text-text-05-t-expected.png:
* platform/mac/svg/text/text-text-06-t-expected.checksum:
* platform/mac/svg/text/text-text-06-t-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76596
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Tue, 25 Jan 2011 16:48:44 +0000 (16:48 +0000)]
2011-01-25 Patrick Gansterer <paroga@webkit.org>
Reviewed by Eric Seidel.
Add missing defines for COMPILER(RVCT) && CPU(ARM_THUMB2)
https://bugs.webkit.org/show_bug.cgi?id=52949
* jit/JITStubs.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76595
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Tue, 25 Jan 2011 16:09:03 +0000 (16:09 +0000)]
2011-01-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove "attached" state related methods from InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=53086
* WebCore.exp.in:
* inspector/InspectorAgent.cpp:
* inspector/InspectorAgent.h:
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight):
(WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
* inspector/InspectorSettings.cpp:
(WebCore::InspectorSettings::InspectorSettings):
* inspector/InspectorSettings.h:
2011-01-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove "attached" state related methods from InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=53086
* WebCoreSupport/WebInspectorClientCF.cpp:
(WebInspectorClient::sendMessageToFrontend):
(WebInspectorClient::inspectorStartsAttached):
(WebInspectorClient::setInspectorStartsAttached):
(WebInspectorClient::releaseFrontendPage):
2011-01-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove "attached" state related methods from InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=53086
* WebCoreSupport/WebInspectorClient.h:
* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController showWindow:]):
(-[WebInspectorWindowController attach]):
(-[WebInspectorWindowController detach]):
2011-01-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove "attached" state related methods from InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=53086
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorFrontendClient::attachWindow):
(WebInspectorFrontendClient::detachWindow):
(WebInspectorFrontendClient::showWindowWithoutNotifications):
* WebCoreSupport/WebInspectorClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76594
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 25 Jan 2011 15:46:12 +0000 (15:46 +0000)]
2011-01-25 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed, add bug url for failing test on GTK.
[cairo] Fix LayoutTests/fast/canvas/patternfill-repeat.html
https://bugs.webkit.org/show_bug.cgi?id=53085
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76593
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 25 Jan 2011 15:24:45 +0000 (15:24 +0000)]
2011-01-25 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Symbian] RVCT fails to compile [U|I]nt[8|16|32]Array.h
https://bugs.webkit.org/show_bug.cgi?id=51873
Replace the using declaration, because it doesn't compile on RVCT, and WINSCW has the same issue.
No new functionality so no new tests.
* html/canvas/Int32Array.h:
(WebCore::Int32Array::set):
* html/canvas/Int8Array.h:
(WebCore::Int8Array::set):
* html/canvas/Uint16Array.h:
(WebCore::Uint16Array::set):
* html/canvas/Uint32Array.h:
(WebCore::Uint32Array::set):
* html/canvas/Uint8Array.h:
(WebCore::Uint8Array::set):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76592
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Tue, 25 Jan 2011 15:15:33 +0000 (15:15 +0000)]
2011-01-25 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Antonio Gomes.
fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=53073
Make the two steps in the flaky test to be executed sequentially.
* fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html:
Fix flaky test by chaining its two steps up.
* platform/gtk/Skipped: Unskip test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76591
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zherczeg@webkit.org [Tue, 25 Jan 2011 15:10:44 +0000 (15:10 +0000)]
Repaint SVG elements with filter instead of relayout where possible
https://bugs.webkit.org/show_bug.cgi?id=52200
Reviewed by Dirk Schulze.
This patch allows repainting of filters, when their
attribute changes does not require relayout.
Existing dynamic-update tests cover this feature.
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::clearResult): Clearing the currently stored image
before repainting.
* platform/graphics/filters/FilterEffect.h:
* rendering/RenderObject.h:
(WebCore::RenderObject::isSVGResourceFilter): Not only the filter primitives,
but filters should also be detected to allow safe testing and casting.
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::buildPrimitives): Passing the renderer.
(WebCore::RenderSVGResourceFilter::applyResource):
determineFilterPrimitiveSubregion does not require the filter anymore.
(WebCore::RenderSVGResourceFilter::postApplyResource): Repaint
if lastEffect->hasResult() is false.
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):
Searching for all FilterEffects, whose created by the current FilterElement,
and clearing all resulting images depending on those FilterEffects.
* rendering/svg/RenderSVGResourceFilter.h:
(WebCore::RenderSVGResourceFilter::isSVGResourceFilter):
* rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
(WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
The filter argument is unnecessary anymore. But is is still kept as a static
member, since the primitive renderer still does not know about the
FilterEffect objects.
* rendering/svg/RenderSVGResourceFilterPrimitive.h:
(WebCore::RenderSVGResourceFilterPrimitive::RenderSVGResourceFilterPrimitive):
(WebCore::RenderSVGResourceFilterPrimitive::primitiveAttributeChanged):
Calls RenderSVGResourceFilter::primitiveAttributeChanged.
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
Setting the new attribute value for each FilterEffect.
(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged):
* svg/SVGFEDiffuseLightingElement.h:
Calling primitiveAttributeChanged.
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::setFilterEffectAttribute):
This function will be removed when all FilterElement implements
their setFilterEffectAttribute
* svg/SVGFilterPrimitiveStandardAttributes.h:
(WebCore::SVGFilterPrimitiveStandardAttributes::primitiveAttributeChanged):
* svg/graphics/filters/SVGFilterBuilder.cpp:
(WebCore::SVGFilterBuilder::appendEffectToEffectReferences): The
renderers are assigned to the filter effects.
(WebCore::SVGFilterBuilder::clearEffects):
(WebCore::SVGFilterBuilder::clearResultsRecursive): Recursively
clearing the result images for those filters, whose depend on
the starting filter.
* svg/graphics/filters/SVGFilterBuilder.h:
(WebCore::SVGFilterBuilder::effectReferences): 'get' is unnecessary
(WebCore::SVGFilterBuilder::effectByRenderer): returns the
FilterEffect belongs to this RenderObject.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76590
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Tue, 25 Jan 2011 13:46:18 +0000 (13:46 +0000)]
2011-01-25 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG is missing to-animation support for Path
https://bugs.webkit.org/show_bug.cgi?id=52982
Added an animation test to check 'to' animations in combination with SVG paths.
* svg/animations/animate-path-to-animation-expected.txt: Added.
* svg/animations/animate-path-to-animation.html: Added.
* svg/animations/script-tests/animate-path-to-animation.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
2011-01-25 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG is missing to-animation support for Path
https://bugs.webkit.org/show_bug.cgi?id=52982
SVG was missing 'to' animation support for SVG paths. Even the fallback to discrete
animation did not work and an assert was thrown, because of the missing m_fromPath.
This also influences a test of the W3C test suite. Subtest 2 of animate-elem-83-t.svg passes now.
Test: svg/animations/animate-path-to-animation.html
* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::calculateAnimatedValue): Take the value of the last SVGAnimateElement for
m_fromPath, since 'to' animations are accumulative.
(WebCore::SVGAnimateElement::calculateFromAndToValues): Added support for 'to' animations.
(WebCore::SVGAnimateElement::resetToBaseValue): Set m_animatedPath on the first animation element to baseVal.
* svg/SVGPathByteStream.h:
(WebCore::SVGPathByteStream::copySVGPathByteStream): Return copy of current byte stream.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76589
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 25 Jan 2011 13:34:28 +0000 (13:34 +0000)]
2011-01-25 Nikolas Zimmermann <nzimmermann@rim.com>
Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456
Update gtk/qt baseline.
* platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
* platform/gtk/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
* platform/gtk/svg/text/text-hkern-expected.txt:
* platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt:
* platform/gtk/svg/text/text-vkern-expected.txt:
* platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
* platform/qt/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
* platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
* platform/qt/svg/text/text-hkern-expected.txt:
* platform/qt/svg/text/text-hkern-on-vertical-text-expected.txt:
* platform/qt/svg/text/text-vkern-expected.txt:
* platform/qt/svg/text/text-vkern-on-horizontal-text-expected.txt:
* platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76588
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 25 Jan 2011 13:32:33 +0000 (13:32 +0000)]
2011-01-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: bind resources to URLs upon adding them into the tree.
https://bugs.webkit.org/show_bug.cgi?id=53013
* inspector/debugger-scripts-expected.txt:
* inspector/debugger-scripts.html:
2011-01-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: bind resources to URLs upon adding them into the tree.
https://bugs.webkit.org/show_bug.cgi?id=53013
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
(WebInspector.CSSStyleModel.prototype._styleSheetChanged):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype._parsedScriptSource):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype._processCachedResources):
(WebInspector.NetworkManager.prototype.inflightResourceForURL):
(WebInspector.NetworkDispatcher):
(WebInspector.NetworkDispatcher.prototype.willSendRequest):
(WebInspector.NetworkDispatcher.prototype.markResourceAsCached):
(WebInspector.NetworkDispatcher.prototype.didReceiveResponse):
(WebInspector.NetworkDispatcher.prototype.didReceiveContentLength):
(WebInspector.NetworkDispatcher.prototype.didFinishLoading):
(WebInspector.NetworkDispatcher.prototype.didFailLoading):
(WebInspector.NetworkDispatcher.prototype.willSendWebSocketHandshakeRequest):
(WebInspector.NetworkDispatcher.prototype.didReceiveWebSocketHandshakeResponse):
(WebInspector.NetworkDispatcher.prototype.didCloseWebSocket):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
(WebInspector.NetworkDispatcher.prototype._startResource):
(WebInspector.NetworkDispatcher.prototype._finishResource):
(WebInspector.NetworkDispatcher.prototype._createResource):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype.addResourceToFrame):
(WebInspector.ResourceTreeModel.prototype._bindResourceURL):
(WebInspector.ResourceTreeModel.prototype._clearResources):
(WebInspector.ResourceTreeModel.prototype._unbindResourceURL):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.canShowSourceLine):
(WebInspector.ResourcesPanel.prototype.showSourceLine):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._parsedScriptSource):
(WebInspector.ScriptsPanel.prototype._addScript):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76587
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 25 Jan 2011 12:47:00 +0000 (12:47 +0000)]
2011-01-25 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456
Use accurate floating-point metrics for SVG Font calculations instead of casting float -> integer.
This hopefully fixes differences between 32/64 bit bots.
Needs new layout test results for several platforms, which need to be taken from the bots landing afterwards.
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::SimpleFontData):
(WebCore::SimpleFontData::initCharWidths):
2011-01-25 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456
Update mac/mac-leopard pixel baseline after removing the float -> int truncation in the SVG Fonts ascent/descent calculation code.
* platform/gtk/Skipped: Unskip several tests.
* platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
* platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
* platform/mac-leopard/svg/batik/text/textEffect-expected.checksum:
* platform/mac-leopard/svg/batik/text/textEffect-expected.png:
* platform/mac-leopard/svg/batik/text/textEffect3-expected.checksum:
* platform/mac-leopard/svg/batik/text/textEffect3-expected.png:
* platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum:
* platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.png:
* platform/mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
* platform/mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.png:
* platform/mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.checksum:
* platform/mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.png:
* platform/mac-leopard/svg/text/text-text-05-t-expected.checksum:
* platform/mac-leopard/svg/text/text-text-05-t-expected.png:
* platform/mac-leopard/svg/text/text-text-06-t-expected.checksum:
* platform/mac-leopard/svg/text/text-text-06-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
* platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
* platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
* platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
* platform/mac/svg/batik/text/textEffect-expected.txt:
* platform/mac/svg/batik/text/textEffect3-expected.txt:
* platform/mac/svg/batik/text/textPosition2-expected.png:
* platform/mac/svg/batik/text/textPosition2-expected.txt:
* platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
* platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
* platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
* platform/mac/svg/text/text-text-05-t-expected.txt:
* platform/mac/svg/text/text-text-06-t-expected.txt:
* svg/custom/glyph-transformation-with-hkern-expected.txt:
-This line, and those below, will be ignored--
M LayoutTests/platform/mac-leopard/svg/text/text-text-05-t-expected.checksum
M LayoutTests/platform/mac-leopard/svg/text/text-text-06-t-expected.checksum
M LayoutTests/platform/mac-leopard/svg/text/text-text-05-t-expected.png
M LayoutTests/platform/mac-leopard/svg/text/text-text-06-t-expected.png
M LayoutTests/platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png
M LayoutTests/platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum
M LayoutTests/platform/mac-leopard/svg/batik/text/textEffect3-expected.checksum
M LayoutTests/platform/mac-leopard/svg/batik/text/textEffect-expected.checksum
M LayoutTests/platform/mac-leopard/svg/batik/text/textEffect-expected.png
M LayoutTests/platform/mac-leopard/svg/batik/text/textEffect3-expected.png
M LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.png
M LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.checksum
M LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum
M LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.checksum
M LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.png
M LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.png
M LayoutTests/platform/mac/svg/text/text-text-06-t-expected.txt
M LayoutTests/platform/mac/svg/text/text-text-05-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png
M LayoutTests/platform/mac/svg/batik/text/textEffect3-expected.txt
M LayoutTests/platform/mac/svg/batik/text/textPosition2-expected.png
M LayoutTests/platform/mac/svg/batik/text/textEffect-expected.txt
M LayoutTests/platform/mac/svg/batik/text/textPosition2-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt
M LayoutTests/platform/mac/svg/custom/svg-fonts-in-html-expected.txt
M LayoutTests/platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt
M LayoutTests/platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt
M LayoutTests/platform/gtk/Skipped
M LayoutTests/ChangeLog
M LayoutTests/svg/custom/glyph-transformation-with-hkern-expected.txt
M Source/WebCore/ChangeLog
M Source/WebCore/platform/graphics/SimpleFontData.cpp
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76586
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Tue, 25 Jan 2011 12:43:02 +0000 (12:43 +0000)]
2011-01-25 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Add QWKPage::processCrashed() signal
https://bugs.webkit.org/show_bug.cgi?id=53076
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::processDidCrash):
* UIProcess/API/qt/qwkpage.h:
* UIProcess/API/qt/qwkpage_p.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76585
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Tue, 25 Jan 2011 11:43:11 +0000 (11:43 +0000)]
2011-01-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Andreas Kling.
[GTK] Remove 64 bits release bot from the buildbot master
https://bugs.webkit.org/show_bug.cgi?id=52899
Removes the 64 bits release slave from the buildbot configuration,
so that we can use it as an EWS.
* BuildSlaveSupport/build.webkit.org-config/config.json:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76584
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Tue, 25 Jan 2011 11:38:27 +0000 (11:38 +0000)]
2011-01-25 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipping flaky test on GTK debug bots.
editing/selection/extend-selection-bidi.html test is flaky
https://bugs.webkit.org/show_bug.cgi?id=53074
* platform/gtk/Skipped: Skipped test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76583
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Tue, 25 Jan 2011 11:09:46 +0000 (11:09 +0000)]
2011-01-25 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipping flaky test on GTK debug bots.
fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=53073
* platform/gtk/Skipped: Skipped test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76582
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Tue, 25 Jan 2011 09:44:30 +0000 (09:44 +0000)]
2011-01-24 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: debugger and browser debugger agents should manage sticky breakpoints independently.
https://bugs.webkit.org/show_bug.cgi?id=52999
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::didCommitLoad):
(WebCore::InspectorAgent::enableDebugger):
(WebCore::InspectorAgent::inspectedURLWithoutFragment):
* inspector/InspectorAgent.h:
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints):
(WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
(WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
* inspector/InspectorBrowserDebuggerAgent.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::setAllJavaScriptBreakpoints):
(WebCore::InspectorDebuggerAgent::inspectedURLChanged):
(WebCore::InspectorDebuggerAgent::restoreBreakpoints):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorState.cpp:
(WebCore::InspectorState::InspectorState):
* inspector/InspectorState.h:
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype._projectChanged):
(WebInspector.BreakpointManager.prototype._saveBreakpoints):
(WebInspector.BreakpointManager.prototype._pushBreakpointsToBackend):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76581
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Tue, 25 Jan 2011 09:19:00 +0000 (09:19 +0000)]
2011-01-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by Nikolas Zimmermann.
Skip some new tests for WebKit2 that use eventSender
https://bugs.webkit.org/show_bug.cgi?id=53068
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76580
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Tue, 25 Jan 2011 09:15:14 +0000 (09:15 +0000)]
2011-01-25 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, trivial debugger test fix.
* src/js/Tests.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76579
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 25 Jan 2011 08:43:48 +0000 (08:43 +0000)]
2011-01-25 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Crash in some pages containing flash
https://bugs.webkit.org/show_bug.cgi?id=53016
Flash plugin can produce X errors that are handled by the GDK X
error handler, which exits the process. Since we don't want to
crash due to flash bugs, we install a custom error handler to show
a warning when a X error happens without aborting.
* plugins/gtk/PluginPackageGtk.cpp:
(WebCore::webkitgtkXError):
(WebCore::PluginPackage::load):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76578
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 25 Jan 2011 08:33:59 +0000 (08:33 +0000)]
2011-01-25 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Implement spin buttons in RenderThemeGtk
https://bugs.webkit.org/show_bug.cgi?id=51454
Paint inner up/down buttons for spin button elements when building
with GTK+ 3.x.
Test results will land with the GTK+ 2.x version of this patch.
* platform/gtk/RenderThemeGtk.h:
* platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeGtk::paintInnerSpinButton):
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::spinButtonArrowSize):
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
(WebCore::paintSpinArrowButton):
(WebCore::RenderThemeGtk::paintInnerSpinButton):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76577
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Tue, 25 Jan 2011 06:44:20 +0000 (06:44 +0000)]
2011-01-24 Mihai Parparita <mihaip@chromium.org>
Unreviewed. Missed move of one m_deleted use to be outside NDEBUG block
in r76575.
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::~CachedResource):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76576
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Tue, 25 Jan 2011 06:17:25 +0000 (06:17 +0000)]
2011-01-24 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
Add runtime checks for invariants in memory cache
https://bugs.webkit.org/show_bug.cgi?id=53059
To help track down bug 53045, add some CRASH calls in addition to
ASSERTs, so that we can track down failures in reliability bots.
Just some checks, no new tests necessary.
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage):
* loader/cache/CachedResource.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::~CachedResource):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76575
268f45cc-cd09-0410-ab3c-
d52691b4dbfc