WebKit-https.git
4 years ago[CMake] Use find_package for zlib
don.olmstead@sony.com [Wed, 30 Aug 2017 04:07:50 +0000 (04:07 +0000)]
[CMake] Use find_package for zlib
https://bugs.webkit.org/show_bug.cgi?id=176075

Reviewed by Alex Christensen.

.:

* Source/cmake/OptionsAppleWin.cmake:
* Source/cmake/OptionsWinCairo.cmake:

Source/WebCore:

No new tests. No change in behavior.

* CMakeLists.txt:
* PlatformAppleWin.cmake:
* PlatformMac.cmake:
* PlatformWinCairo.cmake:

Source/WebKitLegacy:

* PlatformWin.cmake:

Tools:

* TestWebKitAPI/PlatformWin.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Xcode] Fix up file and group paths in PAL.xcodeproj
aestes@apple.com [Wed, 30 Aug 2017 04:07:39 +0000 (04:07 +0000)]
[Xcode] Fix up file and group paths in PAL.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=176073

Reviewed by Alex Christensen.

* PAL.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Critical content browser toolbar buttons are hidden at narrow widths
mattbaker@apple.com [Wed, 30 Aug 2017 04:04:02 +0000 (04:04 +0000)]
Web Inspector: Critical content browser toolbar buttons are hidden at narrow widths
https://bugs.webkit.org/show_bug.cgi?id=175999

Reviewed by Devin Rousso.

This patch adds a VisibilityPriority concept to NavigationItems. If a
NavigationBar cannot fit all of its items in the available space, items
are hidden to make room, starting with the lowest priority item. Consecutive
dividers are then collapsed, as well as leading and trailing dividers.

* UserInterface/Main.html:
New file.

* UserInterface/Views/CanvasContentView.js:
(WI.CanvasContentView):
* UserInterface/Views/ConsoleDrawer.js:
(WI.ConsoleDrawer):
* UserInterface/Views/ContentBrowser.js:
(WI.ContentBrowser):
* UserInterface/Views/ContentBrowserTabContentView.js:
(WI.ContentBrowserTabContentView):
* UserInterface/Views/DOMTreeContentView.js:
(WI.DOMTreeContentView):
Set `High` and `Low` priorities, and group the back/forward buttons.

* UserInterface/Views/GroupNavigationItem.js: Added.
(WI.GroupNavigationItem):
(WI.GroupNavigationItem.prototype.get navigationItems):
(WI.GroupNavigationItem.prototype.get minimumWidth):
(WI.GroupNavigationItem.prototype.updateLayout):
(WI.GroupNavigationItem.prototype.didAttach):
(WI.GroupNavigationItem.prototype.didDetach):
NavigationItem groups. Grouped items are shown/hidden together.

* UserInterface/Views/HierarchicalPathNavigationItem.js:
(WI.HierarchicalPathNavigationItem.prototype.updateLayout):
* UserInterface/Views/ImageResourceContentView.js:
(WI.ImageResourceContentView):
* UserInterface/Views/IndexedDatabaseObjectStoreContentView.js:
(WI.IndexedDatabaseObjectStoreContentView):
* UserInterface/Views/LogContentView.js:
(WI.LogContentView):
Set `High` and `Low` priorities.

* UserInterface/Views/NavigationBar.css:
(.navigation-bar .item.force-hidden):
New hidden class, which must be tracked separately from ".hidden".
The former is an implementation detail of NavigationBar, while the
latter is set by the client.

* UserInterface/Views/NavigationBar.js:
(WI.NavigationBar.prototype.insertNavigationItem):
(WI.NavigationBar.prototype.removeNavigationItem):
(WI.NavigationBar.prototype.findNavigationItem.matchingSelfOrChild):
(WI.NavigationBar.prototype.findNavigationItem):
(WI.NavigationBar.prototype.layout.forceItemHidden):
(WI.NavigationBar.prototype.layout.isDivider):
(WI.NavigationBar.prototype.layout.calculateVisibleItemWidth):
(WI.NavigationBar.prototype.layout):
(WI.NavigationBar.prototype._calculateMinimumWidth):
(WI.NavigationBar.prototype.get _visibleNavigationItems):
(WI.NavigationBar):

* UserInterface/Views/NavigationItem.js:
Add support for visibility priority, an integer value that determines the
order in which items are hidden when the NavigationBar becomes too narrow
to fit all of items child items. NavigationIte3m defines constants for
Low, Normal (the default), and High priority.

(WI.NavigationItem):
(WI.NavigationItem.prototype.get minimumWidth):
(WI.NavigationItem.prototype.get width):
(WI.NavigationItem.prototype.get visibilityPriority):
(WI.NavigationItem.prototype.set visibilityPriority):
(WI.NavigationItem.prototype.updateLayout):
(WI.NavigationItem.prototype.didAttach):
(WI.NavigationItem.prototype.didDetach):
Encapsulate the setting of the parent NavigationBar. Needed so that
GroupNavigationItem can forward this action to its children.

* UserInterface/Views/NetworkGridContentView.js:
(WI.NetworkGridContentView):
* UserInterface/Views/RadioButtonNavigationItem.js:
(WI.RadioButtonNavigationItem.prototype.updateLayout):
* UserInterface/Views/RecordingContentView.js:
(WI.RecordingContentView):
* UserInterface/Views/ScriptContentView.js:
(WI.ScriptContentView):
* UserInterface/Views/TextContentView.js:
(WI.TextContentView):
* UserInterface/Views/TextResourceContentView.js:
(WI.TextResourceContentView):
* UserInterface/Views/TimelineRecordingContentView.js:
(WI.TimelineRecordingContentView):
* UserInterface/Views/TimelineTabContentView.js:
(WI.TimelineTabContentView):
Set `High` and `Low` priorities, and group Timeline view mode buttons.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoResourceLoadStatistics logic does not understand custom WebsiteData stores
bfulgham@apple.com [Wed, 30 Aug 2017 02:54:31 +0000 (02:54 +0000)]
ResourceLoadStatistics logic does not understand custom WebsiteData stores
https://bugs.webkit.org/show_bug.cgi?id=176037
<rdar://problem/33338238>

Reviewed by Alex Christensen.

Source/WebKit:

The NetworkProcess::updateCookiePartitioningForTopPrivatelyOwnedDomains always notifies the default website
data store about observations it has made. This should be revised so that WebKit clients that register
custom data stores through the WKWebsiteDataStores API can be assured that observations made in one session
do not manipulate data from another session.

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::updateCookiePartitioningForTopPrivatelyOwnedDomains): Use the passed sessionID to locate
the correct NetworkStorageSession to notify about the new partitioning data.
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in: Accept new argument.
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::updateCookiePartitioningForTopPrivatelyOwnedDomains): Include the WebsiteDataStore's
session ID in the message to update cookie partition data.

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
(TEST): Update for ResourceLoadStatistics directories.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCallTracingCallback should ignore `readonly attribute`
webkit@devinrousso.com [Wed, 30 Aug 2017 02:40:03 +0000 (02:40 +0000)]
CallTracingCallback should ignore `readonly attribute`
https://bugs.webkit.org/show_bug.cgi?id=176070

Reviewed by Matt Baker.

Source/WebCore:

Update existing tests to remove calls to existing readonly attributes.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateAttributeGetterBodyDefinition):
If the attribute is marked `readonly` do not add logic for the `CallTracingCallback`.

* bindings/scripts/test/TestCallTracer.idl:
* bindings/scripts/test/JS/JSTestCallTracer.cpp:
(WebCore::JSTestCallTracerConstructor::initializeProperties):
(WebCore::jsTestCallTracerTestReadonlyAttributeGetter):
(WebCore::jsTestCallTracerTestReadonlyAttribute):

LayoutTests:

* inspector/canvas/recording-2d-expected.txt:
* inspector/canvas/recording-2d.html:
* inspector/canvas/recording-webgl-expected.txt:
* inspector/canvas/recording-webgl.html:
Remove calls to existing readonly attributes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAssertion failure when opening a file with a missing tag closing bracket
commit-queue@webkit.org [Wed, 30 Aug 2017 02:26:42 +0000 (02:26 +0000)]
Assertion failure when opening a file with a missing tag closing bracket
https://bugs.webkit.org/show_bug.cgi?id=176061

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-08-29
Reviewed by Darin Adler.

Source/WebCore:

If a tag is missing its closing bracket, the tokenizer just needs to advance()
the character position without checking m_currentCharacter != '\n'. Newline
character is a valid ending for partially closed tags.

Test: fast/tokenizer/missing-script-tag-closing-bracket.html

* html/parser/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::commitToPartialEndTag):

LayoutTests:

* fast/tokenizer/missing-script-tag-closing-bracket-expected.txt: Added.
* fast/tokenizer/missing-script-tag-closing-bracket.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRename "potentionally trustworthy" to "potentially trustworthy"
beidson@apple.com [Wed, 30 Aug 2017 02:13:19 +0000 (02:13 +0000)]
Rename "potentionally trustworthy" to "potentially trustworthy"
https://bugs.webkit.org/show_bug.cgi?id=176081

Reviewed by Daniel Bates.

Source/WebCore:

The Secure Context spec refers to this as "potentially trustworthy"

It's possible that this was done potentionally, but we should follow the spec to alleviate confusion.

* dom/Document.cpp:
(WebCore::Document::isSecureContext const):
* page/SecurityOrigin.cpp:
(WebCore::shouldTreatAsPotentiallyTrustworthy):
(WebCore::shouldTreatAsPotentionallyTrustworthy): Deleted.
* page/SecurityOrigin.h:
(WebCore::SecurityOrigin::isPotentiallyTrustworthy const):
(WebCore::SecurityOrigin::isPotentionallyTrustworthy const): Deleted.
* workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::isSecureContext const):

Tools:

* TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
(TestWebKitAPI::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAutomatically determine if a class has a modern decoder
commit-queue@webkit.org [Wed, 30 Aug 2017 01:38:32 +0000 (01:38 +0000)]
Automatically determine if a class has a modern decoder
https://bugs.webkit.org/show_bug.cgi?id=176084

Patch by Alex Christensen <achristensen@webkit.org> on 2017-08-29
Reviewed by Sam Weinig.

Instead of determining if ModernDecoder is defined in the class,
just check the signature of the decode member function.

* Platform/IPC/ArgumentCoder.h:
(): Deleted.
* Shared/WebPageCreationParameters.h:
* Shared/WebPageGroupData.h:
* Shared/WebsitePolicies.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoREGRESSION(r220235): Web Inspector: Global search should not happen incrementally
commit-queue@webkit.org [Wed, 30 Aug 2017 01:29:25 +0000 (01:29 +0000)]
REGRESSION(r220235): Web Inspector: Global search should not happen incrementally
https://bugs.webkit.org/show_bug.cgi?id=176063

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-08-29
Reviewed by Devin Rousso.

* UserInterface/Base/Main.js:
(WI.contentLoaded):
* UserInterface/Views/SearchBar.js:
(WI.SearchBar):
(WI.SearchBar.prototype._handleKeydownEvent):
Remove delegate and simplify setting incremental.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win][JSCOnly] Fix call for updating wincairo-libs in build-jsc
commit-queue@webkit.org [Wed, 30 Aug 2017 01:27:18 +0000 (01:27 +0000)]
[Win][JSCOnly] Fix call for updating wincairo-libs in build-jsc
https://bugs.webkit.org/show_bug.cgi?id=176080

Patch by Stephan Szabo <stephan.szabo@sony.com> on 2017-08-29
Reviewed by Brent Fulgham.

* Scripts/build-jsc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[JSC] Use table based approach for JSON.stringify's Quote
utatane.tea@gmail.com [Wed, 30 Aug 2017 01:22:33 +0000 (01:22 +0000)]
[JSC] Use table based approach for JSON.stringify's Quote
https://bugs.webkit.org/show_bug.cgi?id=176044

Reviewed by Darin Adler.

We change escape operation of JSON Quote from branch-based to table-based.
This patch partially adopts SpiderMonkey's change to StringBuilderJSON.cpp
to optimize this escaping operation. We separate changes from StringBuilder.cpp
to apply MPL to StringBuilderJSON.cpp file. Since WebKit already adopts MPL in
some files (like, DateMath.h), it is acceptable.

Kraken json-stringify-tinderbox shows 7.2% improvement.

                                   baseline                  patched

json-stringify-tinderbox        40.429+-0.771      ^      37.693+-0.862         ^ definitely 1.0726x faster

* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/text/StringBuilder.cpp:
(WTF::appendQuotedJSONStringInternalSlow): Deleted.
(WTF::appendQuotedJSONStringInternal): Deleted.
(WTF::StringBuilder::appendQuotedJSONString): Deleted.
* wtf/text/StringBuilderJSON.cpp: Added.
(WTF::appendQuotedJSONStringInternal):
(WTF::StringBuilder::appendQuotedJSONString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd support for FetchRequest.body
commit-queue@webkit.org [Wed, 30 Aug 2017 00:39:26 +0000 (00:39 +0000)]
Add support for FetchRequest.body
https://bugs.webkit.org/show_bug.cgi?id=176066

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-29
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

* web-platform-tests/fetch/api/request/request-disturbed-expected.txt:
* web-platform-tests/fetch/api/request/request-idl-expected.txt:

Source/WebCore:

Covered by existing tests.

Adding support for body attribute getter for FetchRequest.
To do so, FetchRequest will need to create a ReadableStream.
Adding support for DOM based creation of ReadableStream and conversion to JS values.
Small refactoring to make names more consistent.

* CMakeLists.txt:
* Modules/beacon/NavigatorBeacon.cpp:
(WebCore::NavigatorBeacon::sendBeacon):
* Modules/cache/Cache.cpp:
(WebCore::Cache::put):
* Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::extract):
* Modules/fetch/FetchBody.h:
(WebCore::FetchBody::hasReadableStream const):
(WebCore::FetchBody::readableStream):
(WebCore::FetchBody::setReadableStream):
(WebCore::FetchBody::FetchBody):
(WebCore::FetchBody::isReadableStream const): Deleted.
(WebCore::FetchBody::setAsReadableStream): Deleted.
* Modules/fetch/FetchBody.idl:
* Modules/fetch/FetchBodyOwner.cpp:
(WebCore::FetchBodyOwner::readableStream):
* Modules/fetch/FetchBodyOwner.h:
(WebCore::FetchBodyOwner::hasReadableStreamBody const):
(WebCore::FetchBodyOwner::isReadableStreamBody const): Deleted.
* Modules/fetch/FetchRequest.cpp:
(WebCore::FetchRequest::setBody):
* Modules/fetch/FetchRequest.h:
* Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::setBodyAsReadableStream):
(WebCore::FetchResponse::fetch):
* Modules/fetch/FetchResponse.h:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/ReadableStream.h:
(WebCore::JSConverter<IDLInterface<ReadableStream>>::convert):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[DFG] Add constant folding rule to convert CompareStrictEq(Untyped, Untyped [with...
utatane.tea@gmail.com [Wed, 30 Aug 2017 00:29:39 +0000 (00:29 +0000)]
[DFG] Add constant folding rule to convert CompareStrictEq(Untyped, Untyped [with non string cell constant]) to CompareEqPtr(Untyped)
https://bugs.webkit.org/show_bug.cgi?id=175895

Reviewed by Saam Barati.

We have `bucket === @sentinelMapBucket` code in builtin. Since @sentinelMapBucket and bucket
are MapBucket cell (SpecCellOther), we do not have any good fixup for CompareStrictEq.
But rather than introducing a special fixup edge (like, NonStringCellUse), converting
CompareStrictEq(Untyped, Untyped) to CompareEqPtr is simpler.
In constant folding phase, we convert CompareStrictEq(Untyped, Untyped) to CompareEqPtr(Untyed)
if one side of the children is constant non String cell.

This slightly optimizes map/set iteration.

set-for-each          4.5064+-0.3072     ^      3.2862+-0.2098        ^ definitely 1.3713x faster
large-map-iteration  56.2583+-1.6640           53.6798+-2.0097          might be 1.0480x faster
set-for-of            8.8058+-0.5953     ^      7.5832+-0.3805        ^ definitely 1.1612x faster
map-for-each          4.2633+-0.2694     ^      3.3967+-0.3013        ^ definitely 1.2551x faster
map-for-of           13.1556+-0.5707           12.4911+-0.6004          might be 1.0532x faster

* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
* dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
* dfg/DFGNode.h:
(JSC::DFG::Node::convertToCompareEqPtr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[JSC] Use reifying system for "name" property of builtin JSFunction
utatane.tea@gmail.com [Wed, 30 Aug 2017 00:06:43 +0000 (00:06 +0000)]
[JSC] Use reifying system for "name" property of builtin JSFunction
https://bugs.webkit.org/show_bug.cgi?id=175260

Reviewed by Saam Barati.

JSTests:

* stress/accessors-get-set-prefix.js:
* stress/builtin-function-name.js: Added.
(shouldBe):
(shouldThrow):
(shouldBe.JSON.stringify.Object.getOwnPropertyDescriptor):
(shouldBe.JSON.stringify.Object.getOwnPropertyNames.Array.prototype.filter.sort):

Source/JavaScriptCore:

Currently builtin JSFunction uses direct property for "name", which is different
from usual JSFunction. Usual JSFunction uses reifying system for "name". We would like
to apply this reifying mechanism to builtin JSFunction to simplify code and drop
JSFunction::createBuiltinFunction.

We would like to store the "correct" name in FunctionExecutable. For example,
we would like to store the name like "get [Symbol.species]" to FunctionExecutable
instead of specifying name when creating JSFunction. To do so, we add a new
annotations, @getter and @overriddenName. When @getter is specified, the name of
the function becomes "get xxx". And when @overriddenName="xxx" is specified,
the name of the function becomes "xxx".

* Scripts/builtins/builtins_generate_combined_header.py:
(generate_section_for_code_table_macro):
* Scripts/builtins/builtins_generate_combined_implementation.py:
(BuiltinsCombinedImplementationGenerator.generate_secondary_header_includes):
* Scripts/builtins/builtins_generate_separate_header.py:
(generate_section_for_code_table_macro):
* Scripts/builtins/builtins_generate_separate_implementation.py:
(BuiltinsSeparateImplementationGenerator.generate_secondary_header_includes):
* Scripts/builtins/builtins_model.py:
(BuiltinFunction.__init__):
(BuiltinFunction.fromString):
* Scripts/builtins/builtins_templates.py:
* Scripts/tests/builtins/JavaScriptCore-Builtin.prototype-Combined.js:
(overriddenName.string_appeared_here.match):
(intrinsic.RegExpTestIntrinsic.test):
* Scripts/tests/builtins/JavaScriptCore-Builtin.prototype-Separate.js:
(overriddenName.string_appeared_here.match):
(intrinsic.RegExpTestIntrinsic.test):
* Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Combined.js-result:
* Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Separate.js-result:
* Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Combined.js-result:
* Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Separate.js-result:
* Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Combined.js-result:
* Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Separate.js-result:
* Scripts/tests/builtins/expected/JavaScriptCore-InternalClashingNames-Combined.js-result:
* Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:
* builtins/BuiltinExecutables.cpp:
(JSC::BuiltinExecutables::BuiltinExecutables):
* builtins/BuiltinExecutables.h:
* builtins/FunctionPrototype.js:
(symbolHasInstance): Deleted.
* builtins/GlobalOperations.js:
(globalPrivate.speciesGetter): Deleted.
* builtins/IteratorPrototype.js:
(symbolIteratorGetter): Deleted.
* builtins/RegExpPrototype.js:
(match): Deleted.
(replace): Deleted.
(search): Deleted.
(split): Deleted.
* jsc.cpp:
(functionCreateBuiltin):
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::addFunctionProperties):
* runtime/IteratorPrototype.cpp:
(JSC::IteratorPrototype::finishCreation):
* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnNonIndexPropertyNames):
(JSC::JSFunction::reifyLazyBoundNameIfNeeded):
(JSC::JSFunction::createBuiltinFunction): Deleted.
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
* runtime/JSObject.cpp:
(JSC::JSObject::putDirectBuiltinFunction):
(JSC::JSObject::putDirectBuiltinFunctionWithoutTransition):
* runtime/JSTypedArrayViewPrototype.cpp:
(JSC::JSTypedArrayViewPrototype::finishCreation):
* runtime/Lookup.cpp:
(JSC::reifyStaticAccessor):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::finishCreation):

Source/WebCore:

Use @getter for JSBuiltin getters.

* Modules/fetch/FetchResponse.js:
(bodyUsed): Deleted.
(body): Deleted.
* Modules/streams/ReadableByteStreamController.js:
(byobRequest): Deleted.
(desiredSize): Deleted.
* Modules/streams/ReadableStream.js:
(locked): Deleted.
* Modules/streams/ReadableStreamBYOBReader.js:
(closed): Deleted.
* Modules/streams/ReadableStreamBYOBRequest.js:
(view): Deleted.
* Modules/streams/ReadableStreamDefaultController.js:
(desiredSize): Deleted.
* Modules/streams/ReadableStreamDefaultReader.js:
(closed): Deleted.
* Modules/streams/WritableStream.js:
(closed): Deleted.
(ready): Deleted.
(state): Deleted.
* bindings/js/JSDOMBuiltinConstructor.h:
(WebCore::JSDOMBuiltinConstructor<JSClass>::finishCreation):

LayoutTests:

* js/dom/builtin-getter-name-expected.txt: Added.
* js/dom/builtin-getter-name.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRebaseline editing/style/5084241.html after r220706.
pvollan@apple.com [Tue, 29 Aug 2017 23:50:00 +0000 (23:50 +0000)]
Rebaseline editing/style/5084241.html after r220706.

Unreviewed test gardening.

* platform/win/editing/style/5084241-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRebaselined http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl for...
jlewis3@apple.com [Tue, 29 Aug 2017 23:47:26 +0000 (23:47 +0000)]
Rebaselined http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl for ios-11.

Unreviewed test gardening.

* http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Convert all methods in Utilities.js to ECMAScript 2015 shorthand syntax
nvasilyev@apple.com [Tue, 29 Aug 2017 23:45:19 +0000 (23:45 +0000)]
Web Inspector: Convert all methods in Utilities.js to ECMAScript 2015 shorthand syntax
https://bugs.webkit.org/show_bug.cgi?id=176067

Reviewed by Joseph Pecoraro.

* UserInterface/Base/Utilities.js:
(get return):
(addStringToken):
(prettyFunctionName):
(warn):
(error):
(isEmptyObject):
(isEnterKey):
(resolveDotsInPath):
(parseMIMEType):
(simpleGlobStringToRegExp):
(defaultComparator):
(get Object):
(appendWebInspectorSourceURL):
(appendWebInspectorConsoleEvaluationSourceURL):
(isWebInspectorInternalScript):
(isWebInspectorConsoleEvaluationScript):
(isWebKitInjectedScript):
(isWebKitInternalScript):
(isFunctionStringNativeCode):
(isTextLikelyMinified):
(doubleQuotedString):
(insertionIndexForObjectInListSortedByFunction):
(insertObjectIntoSortedArray):
(decodeBase64ToBlob):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] Crash under WorkQueue::performWorkOnRegisteredWorkThread in layout tests.
pvollan@apple.com [Tue, 29 Aug 2017 23:35:33 +0000 (23:35 +0000)]
[Win] Crash under WorkQueue::performWorkOnRegisteredWorkThread in layout tests.
https://bugs.webkit.org/show_bug.cgi?id=176064

Reviewed by Saam Barati.

The crash log indicates that the function pointer is null in this case.

* wtf/win/WorkQueueWin.cpp:
(WTF::WorkQueue::dispatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRebaselined js/dom/global-constructors-attributes.html after r221258.
jlewis3@apple.com [Tue, 29 Aug 2017 23:32:43 +0000 (23:32 +0000)]
Rebaselined js/dom/global-constructors-attributes.html after r221258.

Unreviewed test gardening.

* platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoREGRESSION (r215290): "Where From" metadata is empty when dragging an image out of...
aestes@apple.com [Tue, 29 Aug 2017 23:32:36 +0000 (23:32 +0000)]
REGRESSION (r215290): "Where From" metadata is empty when dragging an image out of Safari
https://bugs.webkit.org/show_bug.cgi?id=176068

Reviewed by Wenson Hsieh.

If you drag an image out of Safari, drop it on the Desktop, and open "Get Info", there is a
"Where from:" field under "More Info" that should list the image's URL. After r215290, this
field is blank due to a mixup with the string passed to URLWithUserTypedString().

Fix this by passing metadataURLString to URLWithUserTypedString() instead of urlString.

Not possible to reliably test this since WebKit adds metadata on a global concurrent queue.

* platform/mac/FileSystemMac.mm:
(WebCore::setMetadataURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRebaseline editing/style/5065910.html after r220706.
pvollan@apple.com [Tue, 29 Aug 2017 23:10:46 +0000 (23:10 +0000)]
Rebaseline editing/style/5065910.html after r220706.

Unreviewed test gardening.

* platform/win/editing/style/5065910-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoBegin transition to modern IPC decoding
achristensen@apple.com [Tue, 29 Aug 2017 22:49:50 +0000 (22:49 +0000)]
Begin transition to modern IPC decoding
https://bugs.webkit.org/show_bug.cgi?id=176043

Reviewed by JF Bastien.

Right now, if a class is decoded from IPC we must have a default constructor.
This prevents us from having Ref or C++ references in such types, which is cluttering up our code.
This is because IPC::decode makes a default-constructed object, fills it, and returns a bool indicating success.
Making IPC::decode instead return a std::optional makes it so we do not need to call an empty constructor.
This could also enable us to add IPC::Decoder::operator>> and other fun things!
I also modernized two arbitrary classes, WebsitePolicies and WebPageGroupData with more to come.
There's no good way to update the actual generated IPC code until each class has been transitioned.

* Platform/IPC/ArgumentCoder.h:
(IPC::ArgumentCoder::decode):
* Platform/IPC/Decoder.h:
(IPC::Decoder::decode):
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* Shared/WebPageGroupData.cpp:
(WebKit::WebPageGroupData::decode):
* Shared/WebPageGroupData.h:
* Shared/WebsitePolicies.h:
(WebKit::WebsitePolicies::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCacheStorage does not need to sort its caches
commit-queue@webkit.org [Tue, 29 Aug 2017 22:34:17 +0000 (22:34 +0000)]
CacheStorage does not need to sort its caches
https://bugs.webkit.org/show_bug.cgi?id=176059

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-29
Reviewed by Chris Dumez.

Covered by existing tests.

* Modules/cache/CacheStorage.cpp:
(WebCore::CacheStorage::retrieveCaches):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoThrowing an exception in the DFG/FTL should not be a jettison-able OSR exit
sbarati@apple.com [Tue, 29 Aug 2017 21:55:12 +0000 (21:55 +0000)]
Throwing an exception in the DFG/FTL should not be a jettison-able OSR exit
https://bugs.webkit.org/show_bug.cgi?id=176060

Reviewed by Michael Saboff.

OSR exitting when we throw an exception is expected behavior. We should
not count these exits towards our jettison OSR exit threshold.

* bytecode/ExitKind.cpp:
(JSC::exitKindToString):
(JSC::exitKindMayJettison):
* bytecode/ExitKind.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileThrow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[WPE] Avoid using autogen for JHBuild modules, trying to fix the EWS
aperez@igalia.com [Tue, 29 Aug 2017 21:41:35 +0000 (21:41 +0000)]
[WPE] Avoid using autogen for JHBuild modules, trying to fix the EWS

Unreviewed build fix.

This also makes the JHBuild process faster, because there are less
modules which will trigger slow, ancient Perl and M4 based tooling.

* wpe/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSetting the cache storage engine root path according the session WebsiteDataStore
commit-queue@webkit.org [Tue, 29 Aug 2017 21:39:48 +0000 (21:39 +0000)]
Setting the cache storage engine root path according the session WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=176055

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-29
Reviewed by Alex Christensen.

Source/WebCore:

No test right now as the engine is not making any read/write operations.

* platform/network/NetworkStorageSession.h:
(WebCore::NetworkStorageSession::cacheStorageDirectory const):
(WebCore::NetworkStorageSession::setCacheStorageDirectory):

Source/WebKit:

Adding disk read/write capacities to CacheStorage engine.
This is used to store per-origin cache names in a file.
Making Engine a thread safe refcounted object so that it does read/write in a background thread.

Setting the root path of the engine to the directory set for the session in use according the WebsiteDataStore.
For each WebsiteDataStore, a path and a sandbox extension is passed to the network process if persistency of the cache storage is wanted.
Ephemeral sessions will set the path of the engine to null so that no read/write access is performed.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::ensureLegacyPrivateBrowsingSession):
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::cacheStorageDirectory const):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::from):
(WebKit::CacheStorage::Engine::defaultEngine):
(WebKit::CacheStorage::Engine::Engine):
(WebKit::CacheStorage::Engine::writeFile):
* NetworkProcess/cache/CacheStorageEngine.h:
(WebKit::CacheStorage::Engine::create):
(WebKit::CacheStorage::Engine::shouldPersist const):
* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
* NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):
* Shared/WebsiteDataStoreParameters.cpp:
(WebKit::WebsiteDataStoreParameters::encode const):
(WebKit::WebsiteDataStoreParameters::decode):
* Shared/WebsiteDataStoreParameters.h:
* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::parameters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoBuild fix. OS X "revision" can have a space.
rniwa@webkit.org [Tue, 29 Aug 2017 21:28:04 +0000 (21:28 +0000)]
Build fix. OS X "revision" can have a space.

* public/include/commit-log-fetcher.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMake it possible to specify A/B testing revision with a partial hash
rniwa@webkit.org [Tue, 29 Aug 2017 21:18:49 +0000 (21:18 +0000)]
Make it possible to specify A/B testing revision with a partial hash
https://bugs.webkit.org/show_bug.cgi?id=176047

Rubber-stamped by Chris Dumez.

Added the support for specifying a partial hash in A/B testing instead of the full hash.

* public/include/commit-log-fetcher.php:
(CommitLogFetcher::find_commit_id_by_revision): Extracted from associate-commit.php.
* public/privileged-api/associate-commit.php:
(main):
* public/privileged-api/create-test-group.php:
(main): Use find_commit_id_by_revision here to support scheduling an A/B testing with a partial hash.
* server-tests/privileged-api-create-test-group-tests.js:
(createAnalysisTask): Make it possible to customize revision string in some test cases.
* server-tests/resources/test-server.js:
(TestServer.prototype._stopApache): Fixed the bug that cleanup step always fails whenever the test file
runs more than 8s.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRebaselined http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl for...
jlewis3@apple.com [Tue, 29 Aug 2017 21:00:32 +0000 (21:00 +0000)]
Rebaselined http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl for ios-11.

Unreviewed test gardening.

* http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[CMake] Use find_package for libxml2 and libxstl
don.olmstead@sony.com [Tue, 29 Aug 2017 20:53:02 +0000 (20:53 +0000)]
[CMake] Use find_package for libxml2 and libxstl
https://bugs.webkit.org/show_bug.cgi?id=176042

Reviewed by Konstantin Tokarev.

.:

* Source/cmake/OptionsAppleWin.cmake:
* Source/cmake/OptionsWinCairo.cmake:

Source/WebCore:

No new tests. No change in behavior.

* CMakeLists.txt:
* PlatformGTK.cmake:
* PlatformWPE.cmake:
* PlatformWinCairo.cmake:

Source/WebKitLegacy:

* PlatformWin.cmake:

Tools:

* TestWebKitAPI/PlatformWin.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Optimize View.prototype.removeSubview
nvasilyev@apple.com [Tue, 29 Aug 2017 19:25:56 +0000 (19:25 +0000)]
Web Inspector: Optimize View.prototype.removeSubview
https://bugs.webkit.org/show_bug.cgi?id=176041

Reviewed by Matt Baker.

Source/WebInspectorUI:

Look up a subview in an array only once, not twice.

* UserInterface/Base/Utilities.js:
(Array.prototype.removeAll):
(Array.prototype.remove):
Split Array.propotype.remove(value, onlyFirst) into Array.propotype.removeAll(value) and
Array.propotype.remove(value).

* UserInterface/Controllers/DebuggerManager.js:
(WI.DebuggerManager.prototype._debuggerBreakpointOptions):
* UserInterface/Views/ContentViewContainer.js:
(WI.ContentViewContainer.prototype._clearTombstonesForContentView):
(WI.ContentViewContainer.prototype._disassociateFromContentView):
* UserInterface/Views/View.js:
(WI.View.prototype.removeSubview):

LayoutTests:

Split Array.prototype.remove(value, onlyFirst) into Array.prototype.removeAll(value) and Array.prototype.remove(value).

* inspector/unit-tests/array-utilities-expected.txt:
* inspector/unit-tests/array-utilities.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] A WTF test is timing out in run-api-tests.
pvollan@apple.com [Tue, 29 Aug 2017 18:34:38 +0000 (18:34 +0000)]
[Win] A WTF test is timing out in run-api-tests.
https://bugs.webkit.org/show_bug.cgi?id=176056

Reviewed by Brent Fulgham.

The test SynchronizedFixedQueue.ProduceOnly relies on that putting a thread to sleep for
1ms will wake it up before another thread which is put to sleep for 10ms. I believe this
is not neccessarily true on Windows where the thread scheduling does not have millisecond
accuracy. Fix the test timeout by adjusting the sleep time slightly.

* TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
(TestWebKitAPI::ToUpperConverter::startProducing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCacheQueryOptions::isolatedCopy() copies the cache name twice
dbates@webkit.org [Tue, 29 Aug 2017 18:08:54 +0000 (18:08 +0000)]
CacheQueryOptions::isolatedCopy() copies the cache name twice
https://bugs.webkit.org/show_bug.cgi?id=175974

Reviewed by Youenn Fablet.

Currently CacheQueryOptions has a user-defined constructor that calls String.isolatedCopy()
on the passed cache name. CacheQueryOptions::isolatedCopy() also calls String.isolatedCopy()
on the cache name before passing the result to the user-defined constructor; => we malloc
and copy the cache name twice. Ideally we would remove the user-defined constructors and
have callers use aggregate initializer syntax to instantiate a CacheQueryOptions. Unfortunately
we cannot do this until we upgrade from Visual Studio 2015 to Visual Studio 2017 as the former
does not support non-static data member initializers (NSDMI) for aggregates and CacheQueryOptions
has some. Therefore we modify the user-defined, non-default, constructor to take a String&&
and conditionally compile the the constructors when building with compilers that do not
support NSDMI for aggregates.

* Modules/cache/CacheQueryOptions.h:
(WebCore::CacheQueryOptions::CacheQueryOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCanvasCaptureMediaStreamTrack clone is not a CanvasCaptureMediaStreamTrack
commit-queue@webkit.org [Tue, 29 Aug 2017 17:43:51 +0000 (17:43 +0000)]
CanvasCaptureMediaStreamTrack clone is not a CanvasCaptureMediaStreamTrack
https://bugs.webkit.org/show_bug.cgi?id=176036

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-29
Reviewed by Eric Carlson.

Source/WebCore:

Covered by existing tests.

Instead of creating a MediaStreamTrack clone when cloning a CanvasCaptureMediaStreamTrack,
we are now creating a CanvasCaptureMediaStreamTrack.
This allows exposing the expected methods and having the expected functionality.

* Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:
(WebCore::CanvasCaptureMediaStreamTrack::clone):
* Modules/mediastream/CanvasCaptureMediaStreamTrack.h:
* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::clone):
* Modules/mediastream/MediaStreamTrack.h:

LayoutTests:

* fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track-expected.txt:
* fast/mediastream/captureStream/canvas2d.html:
* fast/mediastream/captureStream/canvas2d-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSkip editing/pasteboard/paste-empty-startcontainer.html on Windows.
pvollan@apple.com [Tue, 29 Aug 2017 17:40:14 +0000 (17:40 +0000)]
Skip editing/pasteboard/paste-empty-startcontainer.html on Windows.
It is skipped on all other platforms.

Unreviewed test gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMarked fast/events/mouse-cursor-no-mousemove.html as flaky.
jlewis3@apple.com [Tue, 29 Aug 2017 17:35:39 +0000 (17:35 +0000)]
Marked fast/events/mouse-cursor-no-mousemove.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=169238

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd initial support for dataTransferItem.webkitGetAsEntry()
cdumez@apple.com [Tue, 29 Aug 2017 17:00:09 +0000 (17:00 +0000)]
Add initial support for dataTransferItem.webkitGetAsEntry()
https://bugs.webkit.org/show_bug.cgi?id=176038
<rdar://problem/34121095>

Reviewed by Wenson Hsieh.

Source/JavaScriptCore:

Add CommonIdentifier needed by [EnabledAtRuntime].

* runtime/CommonIdentifiers.h:

Source/WebCore:

Add initial support for dataTransferItem.webkitGetAsEntry() as per:
- https://wicg.github.io/entries-api/#html-data

The method works as expected and returns a FileSystemEntry. The entry
can be either a file or a directory. All of the attributes exposed on
the FileSystemEntry return correct values.

What remains to be implemented for this new API to actually be useful:
- directory.getFile() / directory.getDirectory()
- file.file()
- entry.getParent()
- directoryReader.readEntries()

Test: editing/pasteboard/datatransfer-items-drop-getAsEntry.html

* CMakeLists.txt:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
Add new files to projects.

* Modules/entriesapi/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::DOMFileSystem):
* Modules/entriesapi/DOMFileSystem.h:
(WebCore::DOMFileSystem::create):
DOMFileSystem factory now takes a name parameter. This name is a UUID, as suggested in
the specification and implemented by Firefox.

* Modules/entriesapi/ErrorCallback.cpp: Added.
* Modules/entriesapi/ErrorCallback.h:
Add scheduleCallback() convenience method as we often need to call this callback
asynchronously.

* Modules/entriesapi/FileSystemDirectoryEntry.cpp:
(WebCore::FileSystemDirectoryEntry::FileSystemDirectoryEntry):
(WebCore::FileSystemDirectoryEntry::createReader):
(WebCore::FileSystemDirectoryEntry::getFile):
(WebCore::FileSystemDirectoryEntry::getDirectory):
* Modules/entriesapi/FileSystemDirectoryEntry.h:
- Add implementation for createReader().
- Update getFile() / getDirectory() to call the error callback for now as they are
  unimplemented.
- Have the factory take the virtual path of the entry so that it can be
  exposed via the fullPath attribute in IDL.

* Modules/entriesapi/FileSystemDirectoryEntry.idl:
Expose createReader() now that we have stubs for FileSystemDirectoryReader.

* Modules/entriesapi/FileSystemDirectoryReader.cpp: Added.
* Modules/entriesapi/FileSystemDirectoryReader.h: Added.
* Modules/entriesapi/FileSystemDirectoryReader.idl: Added.
* Modules/entriesapi/FileSystemEntriesCallback.cpp: Added.
* Modules/entriesapi/FileSystemEntriesCallback.h: Added.
* Modules/entriesapi/FileSystemEntriesCallback.idl: Added.
Land stubs for FileSystemDirectoryReader and its FileSystemEntriesCallback.

* Modules/entriesapi/FileSystemEntry.cpp:
(WebCore::FileSystemEntry::FileSystemEntry):
* Modules/entriesapi/FileSystemEntry.h:
(WebCore::FileSystemEntry::virtualPath const):
* Modules/entriesapi/FileSystemEntry.idl:
Update constructor to take a virtual path, which is exposed via fullPath
attribute in IDL.

* Modules/entriesapi/FileSystemFileEntry.cpp:
(WebCore::FileSystemFileEntry::FileSystemFileEntry):
(WebCore::FileSystemFileEntry::file):
* Modules/entriesapi/FileSystemFileEntry.h:
(isType):
* Modules/entriesapi/FileSystemFileEntry.idl:
- Update file() to call the error callback for now as they are
  unimplemented.
- Have the factory take the virtual path of the entry so that it can be
  exposed via the fullPath attribute in IDL.

* bindings/js/JSFileSystemEntryCustom.cpp: Added.
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
Add custom implementation of FileSystemEntry's toJS() function. This is
needed because FileSystemEntry has 2 subclasses and we need to type check
at runtime to construct the right wrapper.

* dom/DataTransferItem.cpp:
(WebCore::DataTransferItem::getAsEntry const):
* dom/DataTransferItem.h:
* dom/DataTransferItem.idl:
Add initial implementation for getAsEntry(), currently exposed as
webkitGetAsEntry().

* dom/DataTransferItemList.cpp:
(WebCore::DataTransferItemList::ensureItems const):
Construct a DataTransferItem if the file is a directory now that we
support getAsEntry().

* fileapi/File.cpp:
(WebCore::File::isDirectory const):
* fileapi/File.h:
Add convenience method to query if a File is a directory.

Source/WebKit:

Make dataTransfer.items an experimental feature so that it can be easily
turned on from the Develop menu, for testing convenience.

* Shared/WebPreferencesDefinitions.h:

LayoutTests:

* editing/pasteboard/datatransfer-items-drop-getAsEntry-expected.txt: Added.
* editing/pasteboard/datatransfer-items-drop-getAsEntry.html: Added.
Add layout test coverage.

* http/wpt/entries-api/interfaces-expected.txt:
Rebaseline test now that we support more of the API.

* platform/wk2/TestExpectations:
Skip new test on WK2 because it relies on beginDragWithFiles().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, update my watchlist filters.
eric.carlson@apple.com [Tue, 29 Aug 2017 17:00:04 +0000 (17:00 +0000)]
Unreviewed, update my watchlist filters.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago Marked media/video-controls-no-display-with-text-track.html and media/video-controls...
jlewis3@apple.com [Tue, 29 Aug 2017 16:52:23 +0000 (16:52 +0000)]
 Marked media/video-controls-no-display-with-text-track.html and media/video-controls-in-media-document.html as flaky.
 https://bugs.webkit.org/show_bug.cgi?id=176054

 Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRebaseline fast/doctypes/002.html after r220858.
pvollan@apple.com [Tue, 29 Aug 2017 15:21:42 +0000 (15:21 +0000)]
Rebaseline fast/doctypes/002.html after r220858.

Unreviewed test gardening.

* platform/win/fast/doctypes/002-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRebaseline fast/lists/marker-before-empty-inline.html after r220858.
pvollan@apple.com [Tue, 29 Aug 2017 14:57:36 +0000 (14:57 +0000)]
Rebaseline fast/lists/marker-before-empty-inline.html after r220858.

Unreviewed test gardening.

* platform/win/fast/lists/marker-before-empty-inline-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRebaseline css2.1/t0805-c5520-brdr-b-01-e.html after r220858.
pvollan@apple.com [Tue, 29 Aug 2017 14:33:06 +0000 (14:33 +0000)]
Rebaseline css2.1/t0805-c5520-brdr-b-01-e.html after r220858.

Unreviewed test gardening.

* platform/win/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Remove some obsolete expectations.
commit-queue@webkit.org [Tue, 29 Aug 2017 14:20:04 +0000 (14:20 +0000)]
[GTK] Remove some obsolete expectations.
https://bugs.webkit.org/show_bug.cgi?id=176051

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-29

* platform/gtk/TestExpectations:
  - fast/animation/request-animation-frame-throttling-detached-iframe.html: passing since r215259.
  - fast/animation/request-animation-frame-throttling-lowPowerMode.html: passing since r215259.
  - fast/events/drag-parent-node.html: passing since r217670-r217679.
  - fast/events/keydown-leftright-keys.html: passing since r210504.
  - fast/events/selectionchange-iframe.html: passing since r205908-r205913.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed. REGRESSION(r221219): Fix unit tests using resources from WebKit directory.
carlosgc@webkit.org [Tue, 29 Aug 2017 14:01:47 +0000 (14:01 +0000)]
Unreviewed. REGRESSION(r221219): Fix unit tests using resources from WebKit directory.

The WebKit2 directory was renamed as WebKit in r221219, but neither run-gtk-tests script nor
Test::getResourcesDir() were updated to use the new name.

* Scripts/run-gtk-tests:
(TestRunner._setup_testing_environment):
* TestWebKitAPI/glib/WebKitGLib/TestMain.h:
(Test::getResourcesDir):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[WebCrypto] Push WorkQueue dispatches for HKDF, HMAC, PBKDF2 algorithms into shared...
zandobersek@gmail.com [Tue, 29 Aug 2017 11:30:49 +0000 (11:30 +0000)]
[WebCrypto] Push WorkQueue dispatches for HKDF, HMAC, PBKDF2 algorithms into shared code
https://bugs.webkit.org/show_bug.cgi?id=175620

Reviewed by Jiewen Tan.

Push the WorkQueue dispatch code and other code duplicated between the
Mac and libgcrypt implementations of Web Crypto into the shared layer.
This patch focuses on the HKDF, HMAC and PBKDF2 algorithms.

Functions with platform-specific implementations that are invoked from
these asynchronous dispatches are made static and return an ExceptionOr
value. CryptoAlgorithmParameters objects are passed through non-const
references because data getters could lazily construct the underlying
Vector objects. CryptoKey objects are passed through const references.
Implementations can then manually retrieve and further validate any key
or parameter data, as required for that specific implementation. Input
data is passed through const references to the original Vector objects.

No new tests -- no changes in behavior that's covered by existing tests.

* crypto/algorithms/CryptoAlgorithmHKDF.cpp:
(WebCore::CryptoAlgorithmHKDF::deriveBits):
* crypto/algorithms/CryptoAlgorithmHKDF.h:
* crypto/algorithms/CryptoAlgorithmHMAC.cpp:
(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
* crypto/algorithms/CryptoAlgorithmHMAC.h:
* crypto/algorithms/CryptoAlgorithmPBKDF2.cpp:
(WebCore::CryptoAlgorithmPBKDF2::deriveBits):
* crypto/algorithms/CryptoAlgorithmPBKDF2.h:
* crypto/gcrypt/CryptoAlgorithmHKDFGCrypt.cpp:
(WebCore::CryptoAlgorithmHKDF::platformDeriveBits):
* crypto/gcrypt/CryptoAlgorithmHMACGCrypt.cpp:
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):
* crypto/gcrypt/CryptoAlgorithmPBKDF2GCrypt.cpp:
(WebCore::CryptoAlgorithmPBKDF2::platformDeriveBits):
* crypto/mac/CryptoAlgorithmHKDFMac.cpp:
(WebCore::CryptoAlgorithmHKDF::platformDeriveBits):
* crypto/mac/CryptoAlgorithmHMACMac.cpp:
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):
* crypto/mac/CryptoAlgorithmPBKDF2Mac.cpp:
(WebCore::CryptoAlgorithmPBKDF2::platformDeriveBits):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[WebCrypto] Push WorkQueue dispatches for EC algorithms into shared code
zandobersek@gmail.com [Tue, 29 Aug 2017 11:29:56 +0000 (11:29 +0000)]
[WebCrypto] Push WorkQueue dispatches for EC algorithms into shared code
https://bugs.webkit.org/show_bug.cgi?id=175619

Reviewed by Jiewen Tan.

Push the WorkQueue dispatch code duplicated between the Mac and libgcrypt
implementations of Web Crypto into the shared layer. This patch focuses on
the EC-based algorithms.

Functions with platform-specific implementations that are invoked from
these asynchronous dispatches are made static and return an ExceptionOr or
std::optional value. CryptoKey and CryptoAlgorithmParameters objects are
passed to those through const references. Input data is passed through
const references to the original Vector objects.

No new tests -- no changes in behavior that's covered by existing tests.

* crypto/algorithms/CryptoAlgorithmECDH.cpp:
(WebCore::CryptoAlgorithmECDH::deriveBits):
* crypto/algorithms/CryptoAlgorithmECDH.h:
* crypto/algorithms/CryptoAlgorithmECDSA.cpp:
(WebCore::CryptoAlgorithmECDSA::sign):
(WebCore::CryptoAlgorithmECDSA::verify):
* crypto/algorithms/CryptoAlgorithmECDSA.h:
* crypto/gcrypt/CryptoAlgorithmECDHGCrypt.cpp:
(WebCore::CryptoAlgorithmECDH::platformDeriveBits):
* crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp:
(WebCore::CryptoAlgorithmECDSA::platformSign):
(WebCore::CryptoAlgorithmECDSA::platformVerify):
* crypto/keys/CryptoKeyEC.h:
* crypto/mac/CryptoAlgorithmECDHMac.cpp:
(WebCore::CryptoAlgorithmECDH::platformDeriveBits):
* crypto/mac/CryptoAlgorithmECDSAMac.cpp:
(WebCore::CryptoAlgorithmECDSA::platformSign):
(WebCore::CryptoAlgorithmECDSA::platformVerify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[SVG] Leak in SVGAnimatedListPropertyTearOff
svillar@igalia.com [Tue, 29 Aug 2017 09:32:34 +0000 (09:32 +0000)]
[SVG] Leak in SVGAnimatedListPropertyTearOff
https://bugs.webkit.org/show_bug.cgi?id=172545

Reviewed by Darin Adler.

Source/WebCore:

SVGAnimatedListPropertyTearOff maintains a vector m_wrappers with references to
SVGPropertyTraits<PropertyType>::ListItemTearOff. Apart from that SVGPropertyTearOff has a
reference to SVGAnimatedProperty.

When SVGListProperty::getItemValuesAndWrappers() is called, it creates a
SVGPropertyTraits<PropertyType>::ListItemTearOff pointing to the same SVGAnimatedProperty (a
SVGAnimatedListPropertyTearOff) which stores the m_wrappers vector where the ListItemTearOff
is going to be added to. This effectively creates a reference cycle between the
SVGAnimatedListPropertyTearOff and all the ListItemTearOff it stores in m_wrappers.

In order to effectively break the cycle without freeing too many wrappers we should take two
measures:
1) Break the reference cycle by storing raw pointers in the m_wrappers Vector
2) Remove the ListItemTearOff which is being deleted (it notifies the animated property by
calling propertyWillBeDeleted) from the m_wrappers Vector.

This is a re-land of r219334 which caused early releases of custom data attribute objects
added to SVG elements (wkb.ug/175023).

Tests: svg/animations/animation-leak-list-property-instances.html
       svg/dom/SVGAnimatedListPropertyTearOff-crash-2.html
       svg/dom/SVGAnimatedListPropertyTearOff-crash.html
       svg/dom/SVGAnimatedListPropertyTearOff-leak.html

* svg/properties/SVGAnimatedListPropertyTearOff.h:
* svg/properties/SVGListProperty.h:
(WebCore::SVGListProperty::getItemValuesAndWrappers):
* svg/properties/SVGListPropertyTearOff.h:
(WebCore::SVGListPropertyTearOff::removeItemFromList):

LayoutTests:

The list of new added tests includes the one for the original bug, a new test for the
regression and a couple of tests imported from Blink which verify that
SVGAnimatedListPropertyTearOff does not crash after the context element goes out of scope.

* svg/animations/animation-leak-list-property-instances-expected.txt: Added.
* svg/animations/animation-leak-list-property-instances.html: Added.
* svg/dom/SVGAnimatedListPropertyTearOff-crash-2-expected.txt: Added. Imported from Blink.
* svg/dom/SVGAnimatedListPropertyTearOff-crash-2.html: Added. Imported from Blink.
* svg/dom/SVGAnimatedListPropertyTearOff-crash-expected.txt: Added. Imported from Blink.
* svg/dom/SVGAnimatedListPropertyTearOff-crash.html: Added. Imported from Blink.
* svg/dom/SVGAnimatedListPropertyTearOff-leak-expected.txt: Added.
* svg/dom/SVGAnimatedListPropertyTearOff-leak.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
aestes@apple.com [Tue, 29 Aug 2017 09:10:52 +0000 (09:10 +0000)]
[Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
https://bugs.webkit.org/show_bug.cgi?id=176046

Reviewed by Alex Christensen.

Source/WebCore:

* platform/FileSystem.cpp:
(WebCore::setMetadataURL):
* platform/FileSystem.h:
(WebCore::setMetadataURL):
* platform/mac/FileSystemMac.mm:
(WebCore::setMetadataURL):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

Source/WebCore/PAL:

* PAL.xcodeproj/project.pbxproj:
* pal/spi/mac/MetadataSPI.h: Added.

Source/WebKit:

* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::savePDFToTemporaryFolderAndOpenWithNativeApplicationRaw):
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Source/WebKitLegacy/mac:

Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.

* Misc/WebNSFileManagerExtras.mm:
(-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
(setMetaData): Deleted.
* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed WPE debug build fix.
zandobersek@gmail.com [Tue, 29 Aug 2017 07:46:13 +0000 (07:46 +0000)]
Unreviewed WPE debug build fix.

* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::dispatchPendingDecryptionStructure):
AppendState is an enum class, enum values have to be accessed
using scope resolution.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed build fix #2 after r221275.
bfulgham@apple.com [Tue, 29 Aug 2017 04:33:36 +0000 (04:33 +0000)]
Unreviewed build fix #2 after r221275.

* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
to match new API.
* WebCoreSupport/WebPlatformStrategies.h: Update signatures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoLogger should use makeString instead of String::format
eric.carlson@apple.com [Tue, 29 Aug 2017 02:59:18 +0000 (02:59 +0000)]
Logger should use makeString instead of String::format
https://bugs.webkit.org/show_bug.cgi?id=176035

Reviewed by Jer Noble.

Source/WebCore/PAL:

* pal/Logger.h:
(PAL::LogArgument::toString):
(PAL::Logger::logAlways):
(PAL::Logger::error):
(PAL::Logger::warning):
(PAL::Logger::notice):
(PAL::Logger::info):
(PAL::Logger::debug):
(PAL::Logger::MethodAndPointer::MethodAndPointer):
(PAL::Logger::log):
(PAL::LogArgument<Logger::MethodAndPointer>::toString):

Tools:

* TestWebKitAPI/Tests/WebCore/Logging.cpp:
(TestWebKitAPI::TEST_F): Update test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRebaseline accessibility/menu-list-crash2.html after r220930.
pvollan@apple.com [Tue, 29 Aug 2017 02:18:29 +0000 (02:18 +0000)]
Rebaseline accessibility/menu-list-crash2.html after r220930.

Unreviewed test gardening.

* platform/win/accessibility/menu-list-crash2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
aestes@apple.com [Tue, 29 Aug 2017 00:55:01 +0000 (00:55 +0000)]
[Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
https://bugs.webkit.org/show_bug.cgi?id=176039

Reviewed by Alex Christensen.

Source/WebCore:

* PlatformMac.cmake:
* WebCore.xcodeproj/project.pbxproj:
* platform/ios/WebCoreSystemInterfaceIOS.mm:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
* platform/text/TextEncodingRegistry.cpp:
(WebCore::defaultTextEncodingNameForSystemLanguage):
* platform/text/TextEncodingRegistry.h:
* platform/text/ios/TextEncodingRegistryIOS.mm: Added.
(WebCore::webDefaultCFStringEncoding):
* platform/text/mac/TextEncodingRegistryMac.mm: Added.
(WebCore::webDefaultCFStringEncoding):

Source/WebKit:

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Source/WebKitLegacy/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
* WebView/WebPreferences.mm:
(+[WebPreferences _systemCFStringEncoding]):

Source/WTF:

* wtf/spi/cf/CFStringSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRebaseline http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl.
ryanhaddad@apple.com [Tue, 29 Aug 2017 00:42:27 +0000 (00:42 +0000)]
Rebaseline http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl.

Unreviewed test gardening.

* http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt:
* platform/mac-highsierra/http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt: Copied from LayoutTests/http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GStreamer] The glvideoflip GStreamer element isn't available. Video mirroring and...
mcatanzaro@igalia.com [Tue, 29 Aug 2017 00:40:35 +0000 (00:40 +0000)]
[GStreamer] The glvideoflip GStreamer element isn't available. Video mirroring and rotation functionalities are thus disabled.
https://bugs.webkit.org/show_bug.cgi?id=175576

Reviewed by Carlos Alberto Lopez Perez.

Build graphene to enable the glvideoflip element.

* gstreamer/jhbuild.modules:
* gtk/jhbuild.modules:
* jhbuild/jhbuild-wrapper:
* wpe/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoREGRESSION(r220278): Web Inspector: ContextMenu items are not getting triggered
commit-queue@webkit.org [Tue, 29 Aug 2017 00:27:54 +0000 (00:27 +0000)]
REGRESSION(r220278): Web Inspector: ContextMenu items are not getting triggered
https://bugs.webkit.org/show_bug.cgi?id=176034

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-08-28
Reviewed by Devin Rousso.

* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::showContextMenu):
Responses go through InspectorFrontendAPI not InspectorFrontendHost.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix incorrect enum in atBoundaryOfGranularity call
megan_gardner@apple.com [Mon, 28 Aug 2017 23:56:25 +0000 (23:56 +0000)]
Fix incorrect enum in atBoundaryOfGranularity call
https://bugs.webkit.org/show_bug.cgi?id=176004

Reviewed by Wenson Hsieh and Enrica Casucci

Enum that was being used was incorrect, as that case in not covered in called function.
Resulted in a no-op. Should now have correct behavior around line boundaries.

Not possible to add tests for selections with velocity. Will attempt to add this behavior later.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::rangeAtWordBoundaryForPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed test gardening. <rdar://problem/34051745>
jlewis3@apple.com [Mon, 28 Aug 2017 23:29:54 +0000 (23:29 +0000)]
Unreviewed test gardening. <rdar://problem/34051745>

* platform/ios-11/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[WinCairo] Add PlatformWin cmake for Webkit
commit-queue@webkit.org [Mon, 28 Aug 2017 23:29:29 +0000 (23:29 +0000)]
[WinCairo] Add PlatformWin cmake for Webkit
https://bugs.webkit.org/show_bug.cgi?id=176027

Patch by Stephan Szabo <stephan.szabo@sony.com> on 2017-08-28
Reviewed by Brent Fulgham.

* PlatformWin.cmake: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed build fix after r221275.
bfulgham@apple.com [Mon, 28 Aug 2017 22:46:02 +0000 (22:46 +0000)]
Unreviewed build fix after r221275.

* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
to match new API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWebRTC MediaStream created without tracks does not update active state after tracks...
commit-queue@webkit.org [Mon, 28 Aug 2017 22:38:13 +0000 (22:38 +0000)]
WebRTC MediaStream created without tracks does not update active state after tracks are added
https://bugs.webkit.org/show_bug.cgi?id=175434

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-28
Reviewed by Eric Carlson.

Source/WebCore:

Covered by updated test.

Removing active/inactive events.
active attribute is still kept and is updated synchronously on every track change.

* Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::activeStatusChanged):
(WebCore::MediaStream::internalAddTrack):
(WebCore::MediaStream::updateActiveState):
(WebCore::MediaStream::hasPendingActivity const):
(WebCore::MediaStream::scheduleActiveStateChange): Deleted.
(WebCore::MediaStream::activityEventTimerFired): Deleted.
* Modules/mediastream/MediaStream.h:
* Modules/mediastream/MediaStream.idl:

LayoutTests:

* fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track-expected.txt:
* fast/mediacapturefromelement/CanvasCaptureMediaStream-creation-expected.txt:
* fast/mediastream/MediaStream-add-remove-tracks-expected.txt:
* fast/mediastream/MediaStream-add-remove-tracks.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
aestes@apple.com [Mon, 28 Aug 2017 22:23:08 +0000 (22:23 +0000)]
[Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
https://bugs.webkit.org/show_bug.cgi?id=176032

Reviewed by Alex Christensen.

Source/WebCore:

* platform/ios/WebCoreSystemInterfaceIOS.mm:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
* platform/network/NetworkStorageSession.h:
* platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::switchToNewTestingSession):
(WebCore::NetworkStorageSession::ensureSession):
* platform/network/cf/ResourceRequest.h:
* platform/network/cocoa/NetworkStorageSessionCocoa.mm:
(WebCore::createPrivateStorageSession):
* platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::setStorageSession):
(WebCore::copyRequestWithStorageSession):
(WebCore::cachedResponseForRequest):
* platform/network/mac/CookieJarMac.mm:
(WebCore::httpCookies):
(WebCore::setHTTPCookiesForURL):
(WebCore::deleteHTTPCookie):
(WebCore::deleteAllHTTPCookies):
(WebCore::setCookiesFromDOM):
(WebCore::httpCookieAcceptPolicy):
(WebCore::cookiesEnabled):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteAllCookies):
(WebCore::deleteCookiesForHostnames):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::createNSURLConnection):

Source/WebCore/PAL:

* pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::privateBrowsingSession):
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformHasLocalDataForURL):
(WebKit::cachedResponseForURL):

Source/WebKitLegacy/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
* WebView/WebView.mm:
(-[WebView _cachedResponseForURL:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDisable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header...
bfulgham@apple.com [Mon, 28 Aug 2017 22:08:34 +0000 (22:08 +0000)]
Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
https://bugs.webkit.org/show_bug.cgi?id=175992
<rdar://problem/34086613>

Reviewed by Daniel Bates.

Source/WebCore:

The original work in Bug 157053 did not properly handle the case of websockets. This patch completes
the changes to secure cookie handling to make sure websockets are also protected.

Tests: http/tests/websocket/tests/hybi/secure-cookie-insecure-connection.pl
       http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl

* Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::clientHandshakeRequest): Remove 'const' declaration so we can work with
a mutable Document object. This allows us to mark the Document as having accessed secure cookies.
(WebCore::WebSocketChannel::clientHandshakeRequest const): Deleted.
* Modules/websockets/WebSocketChannel.h:
* Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::clientHandshakeMessage): Ditto.
(WebCore::WebSocketHandshake::clientHandshakeRequest): Ditto.
(WebCore::WebSocketHandshake::clientHandshakeMessage const): Deleted.
(WebCore::WebSocketHandshake::clientHandshakeRequest const): Deleted.
* Modules/websockets/WebSocketHandshake.h:
* loader/CookieJar.cpp:
(WebCore::cookies): Small naming cleanup.
(WebCore::cookieRequestHeaderFieldValue): Pass a flag indicating whether secure cookies should be
included in the result or not. Set the document flag indicating secure cookies were accessed (if
they were), and return the resulting cookie string.
* loader/CookieJar.h:
* platform/CookiesStrategy.h:
* platform/network/CacheValidation.cpp:
(WebCore::headerValueForVary): Revise to pass a flag indicating whether secure cookies should be included
or not.
* platform/network/PlatformCookieJar.h:
* platform/network/cf/CookieJarCFNet.cpp:
(WebCore::doesContainSecureCookies): Added helper method.
(WebCore::cookiesForDOM): Revise to use new helper function.
(WebCore::cookieRequestHeaderFieldValue): Revise to accept a flag indicating if secure cookies should
be included in the result. Return a pair consisting of the cookie string, and a flag indicating whether
secure cookies were accessed or not.
* platform/network/curl/CookieJarCurl.cpp:
(WebCore::CookieJarCurlFileSystem::cookieRequestHeaderFieldValue): Ditto.
(WebCore::cookieRequestHeaderFieldValue): Ditto.
* platform/network/curl/CookieJarCurl.h:
* platform/network/mac/CookieJarMac.mm:
(WebCore::cookiesForSession): Ditto.
(WebCore::cookiesForDOM): Update for new 'cookiesForSession' signature.
(WebCore::cookieRequestHeaderFieldValue): Ditto.
* platform/network/soup/CookieJarSoup.cpp:
(WebCore::cookieRequestHeaderFieldValue): Revise to accept a flag indicating if secure cookies should
be included in the result. Return a pair consisting of the cookie string, and a flag indicating whether
secure cookies were accessed or not.

Source/WebKit:

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM): Use a better label than 'result'.
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue): Modify to accept a flag
indicating if secure cookies should be included, and return a pair containing the resulting
cookie string and a boolean indicating if secure cookies were accessed.
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in: Ditto.
* Shared/mac/CookieStorageShim.mm:
(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL): Ditto.
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue): Ditto.
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:

Source/WebKitLegacy/mac:

* WebCoreSupport/WebPlatformStrategies.h:
* WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
cookies should be included, and return a pair containing the resulting cookie string and a boolean
indicating if secure cookies were accessed.

LayoutTests:

* http/tests/websocket/tests/hybi/secure-cookie-insecure-connection-expected.txt: Added.
* http/tests/websocket/tests/hybi/secure-cookie-insecure-connection.pl: Added.
* http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt: Added.
* http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, remove duplicated TestExpectation entry.
ryanhaddad@apple.com [Mon, 28 Aug 2017 21:57:28 +0000 (21:57 +0000)]
Unreviewed, remove duplicated TestExpectation entry.

* platform/mac-highsierra-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoBefore r220970, these ssl tests were failing. Now they are timing out.
pvollan@apple.com [Mon, 28 Aug 2017 21:14:44 +0000 (21:14 +0000)]
Before r220970, these ssl tests were failing. Now they are timing out.

Unreviewed test gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMark tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-with-handler.html...
ryanhaddad@apple.com [Mon, 28 Aug 2017 21:13:00 +0000 (21:13 +0000)]
Mark tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-with-handler.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=172544

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] The test http/tests/misc/policy-delegate-called-twice.html is crashing.
pvollan@apple.com [Mon, 28 Aug 2017 20:11:45 +0000 (20:11 +0000)]
[Win] The test http/tests/misc/policy-delegate-called-twice.html is crashing.
https://bugs.webkit.org/show_bug.cgi?id=176031

Reviewed by Brent Fulgham.

When the function in the FramePolicyFunction parameter is called, it has already been moved
to an internal member by the setUpPolicyListener method, and is no longer valid. Invoke the
function by using the stored member instead.

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMarked svg/in-html/by-reference.html as flaky.
jlewis3@apple.com [Mon, 28 Aug 2017 20:10:16 +0000 (20:10 +0000)]
Marked svg/in-html/by-reference.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=175781

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Remove some unused DataGrid code
commit-queue@webkit.org [Mon, 28 Aug 2017 19:56:58 +0000 (19:56 +0000)]
Web Inspector: Remove some unused DataGrid code
https://bugs.webkit.org/show_bug.cgi?id=176029

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-08-28
Reviewed by Matt Baker.

* UserInterface/Views/DataGrid.js:
(WI.DataGrid.prototype.get copyTextDelimiter):
(WI.DataGrid.prototype.set copyTextDelimiter):
(WI.DataGrid.prototype.resizerDragging):
(WI.DataGrid.prototype.columnWidthsMap): Deleted.
(WI.DataGrid.prototype.applyColumnWidthsMap): Deleted.
(WI.DataGrid.prototype.get resizeMethod): Deleted.
(WI.DataGrid.prototype.set resizeMethod): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSkip service workers tests on Windows.
pvollan@apple.com [Mon, 28 Aug 2017 19:48:58 +0000 (19:48 +0000)]
Skip service workers tests on Windows.

Unreviewed test gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFixed expectations for http/tests/loading/basic-auth-remove-credentials.html by remov...
jlewis3@apple.com [Mon, 28 Aug 2017 19:05:10 +0000 (19:05 +0000)]
Fixed expectations for http/tests/loading/basic-auth-remove-credentials.html by removing double expectations

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRebaseline js/dom/global-constructors-attributes.html after r221209.
ryanhaddad@apple.com [Mon, 28 Aug 2017 18:40:33 +0000 (18:40 +0000)]
Rebaseline js/dom/global-constructors-attributes.html after r221209.

Unreviewed test gardening..

* platform/mac-highsierra-wk1/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-highsierra/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd WKUIDelegatePrivate equivalent of WKPageUIClient's didExceedBackgroundResourceLim...
achristensen@apple.com [Mon, 28 Aug 2017 18:20:49 +0000 (18:20 +0000)]
Add WKUIDelegatePrivate equivalent of WKPageUIClient's didExceedBackgroundResourceLimitWhileInForeground
https://bugs.webkit.org/show_bug.cgi?id=176028
<rdar://problem/29270035>

Reviewed by Andy Estes.

An API test for this did not succeed with either the memory or CPU limit calls,
possibly because the app must be in the foreground for this call to be made.

* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
* UIProcess/Cocoa/UIDelegate.h:
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::toWKResourceLimit):
(WebKit::UIDelegate::UIClient::didExceedBackgroundResourceLimitWhileInForeground):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix document-create-touch.html.
commit-queue@webkit.org [Mon, 28 Aug 2017 16:52:48 +0000 (16:52 +0000)]
Fix document-create-touch.html.
https://bugs.webkit.org/show_bug.cgi?id=172813

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-28
Reviewed by Michael Catanzaro.

The document.createTouch() call is supposed to throw an exception (as
defined by WebIDL). It has been doing this since r203941, but this
wasn't noticed because the entire fast/events/touch folder is skipped
on mac, ios and win.

* fast/events/touch/document-create-touch-expected.txt:
* fast/events/touch/document-create-touch.html:
* platform/gtk/TestExpectations:
* platform/gtk/fast/events/touch/document-create-touch-expected.txt: Removed.
* platform/wpe/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] [WPE] Rename EventHandlerGlib to EventHandlerGLib
clopez@igalia.com [Mon, 28 Aug 2017 16:37:31 +0000 (16:37 +0000)]
[GTK] [WPE] Rename EventHandlerGlib to EventHandlerGLib
https://bugs.webkit.org/show_bug.cgi?id=175864

Unreviewed cosmetic follow-up patch after r221075.

No new tests. No change in behavior.

* PlatformGTK.cmake:
* PlatformWPE.cmake:
* platform/glib/EventHandlerGLib.cpp: Renamed from Source/WebCore/platform/glib/EventHandlerGlib.cpp.
(WebCore::EventHandler::tabsToAllFormControls const):
(WebCore::EventHandler::focusDocumentView):
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::passMouseDownEventToWidget):
(WebCore::EventHandler::eventActivatedView const):
(WebCore::EventHandler::widgetDidHandleWheelEvent):
(WebCore::EventHandler::createDraggingDataTransfer const):
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
(WebCore::EventHandler::accessKeyModifiers):
(WebCore::EventHandler::shouldTurnVerticalTicksIntoHorizontal const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRebaseline js/dom/global-constructors-attributes.html after r221209.
ryanhaddad@apple.com [Mon, 28 Aug 2017 15:50:10 +0000 (15:50 +0000)]
Rebaseline js/dom/global-constructors-attributes.html after r221209.

Unreviewed test gardening.

* platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed GTK/WPE test gardening
mcatanzaro@igalia.com [Mon, 28 Aug 2017 15:29:44 +0000 (15:29 +0000)]
Unreviewed GTK/WPE test gardening

* platform/gtk/TestExpectations:
* platform/gtk/compositing/iframes/compositing-for-scrollable-iframe-expected.txt: Added.
* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
* platform/wpe/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWebDriver: implement screen capture commands
carlosgc@webkit.org [Mon, 28 Aug 2017 13:55:10 +0000 (13:55 +0000)]
WebDriver: implement screen capture commands
https://bugs.webkit.org/show_bug.cgi?id=174615

Reviewed by Brian Burg.

Source/WebDriver:

Implement takeScreenshot and takeElementScreenshot commands.

19. Screen Capture.
https://w3c.github.io/webdriver/webdriver-spec.html#screen-capture

* CommandResult.cpp:
(WebDriver::CommandResult::CommandResult): Handle ScreenshotError protocol error.
(WebDriver::CommandResult::httpStatusCode const): Add UnableToCaptureScreen.
(WebDriver::CommandResult::errorString const): Ditto.
* CommandResult.h:
* Session.cpp:
(WebDriver::Session::takeScreenshot):
* Session.h:
* WebDriverService.cpp:
(WebDriver::WebDriverService::takeScreenshot):
(WebDriver::WebDriverService::takeElementScreenshot):
* WebDriverService.h:

Source/WebKit:

Extend takeScreenshot command to optionally take a screenshot of an element. When no element is provided, the
screenshot is taken from the page visible area.

* PlatformGTK.cmake: Add WebAutomationSessionCairo.cpp to compilation.
* PlatformWPE.cmake: Ditto.
* UIProcess/Automation/Automation.json: Add ScreenshotError and several optional parameters to takeScreenshot.
* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::takeScreenshot): Receive optional frame, node and scrollIntoView that are
checked and passed to the web process.
* UIProcess/Automation/WebAutomationSession.h:
* UIProcess/Automation/cairo/WebAutomationSessionCairo.cpp: Added.
(WebKit::WebAutomationSession::platformGetBase64EncodedPNGData): Cairo implementation.
* UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:
* WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::snapshotRectForScreenshot): Helper to get the rectangle to be used for a screenshot.
(WebKit::WebAutomationSessionProxy::takeScreenshot): If a node handle is provided take the snapshot using the
element rectangle, otherwise use the page visible content rectangle.
* WebProcess/Automation/WebAutomationSessionProxy.h:
* WebProcess/Automation/WebAutomationSessionProxy.messages.in: Update TakeSnapshot message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAutomation: takeScreenshot should use the visible content rect not the document rect
carlosgc@webkit.org [Mon, 28 Aug 2017 12:32:34 +0000 (12:32 +0000)]
Automation: takeScreenshot should use the visible content rect not the document rect
https://bugs.webkit.org/show_bug.cgi?id=175665

Reviewed by Brian Burg.

According to the spec, we should get the toplevel browsing context document rectangle and take a screenshot of
it using the current viewport width and height. We are currently using the document size.

19. Screen Capture.
https://w3c.github.io/webdriver/webdriver-spec.html#dfn-draw-a-bounding-box-from-the-framebuffer

* WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::WebAutomationSessionProxy::takeScreenshot): Use FrameView::visibleContentRect().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWebDriver: implement cookies commands
carlosgc@webkit.org [Mon, 28 Aug 2017 11:52:55 +0000 (11:52 +0000)]
WebDriver: implement cookies commands
https://bugs.webkit.org/show_bug.cgi?id=174613

Reviewed by Brian Burg.

Add cookies commands.

16. Cookies.
https://w3c.github.io/webdriver/webdriver-spec.html#cookies

* CommandResult.cpp:
(WebDriver::CommandResult::httpStatusCode const): Add NoSuchCookie error.
(WebDriver::CommandResult::errorString const): Ditto.
* CommandResult.h:
* Session.cpp:
(WebDriver::parseAutomationCookie): Parse JSON cookie object returned by automation and convert it to a Cookie struct.
(WebDriver::builtAutomationCookie): Build a JSON cookie object as expected by automation from a Cookie struct.
(WebDriver::serializeCookie): Serialize a Cookie struct into a JSON cookie object according to the WebDriver spec.
(WebDriver::Session::getAllCookies):
(WebDriver::Session::getNamedCookie):
(WebDriver::Session::addCookie):
(WebDriver::Session::deleteCookie):
(WebDriver::Session::deleteAllCookies):
* Session.h:
* WebDriverService.cpp:
(WebDriver::WebDriverService::getAllCookies):
(WebDriver::WebDriverService::getNamedCookie):
(WebDriver::deserializeCookie):
(WebDriver::WebDriverService::addCookie):
(WebDriver::WebDriverService::deleteCookie):
(WebDriver::WebDriverService::deleteAllCookies):
* WebDriverService.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoEnsure that the alert function is called in TestWebExtensions.
commit-queue@webkit.org [Mon, 28 Aug 2017 11:46:14 +0000 (11:46 +0000)]
Ensure that the alert function is called in TestWebExtensions.
https://bugs.webkit.org/show_bug.cgi?id=175880

Patch by Ms2ger <Ms2ger@gmail.com> on 2017-08-28
Reviewed by Carlos Garcia Campos.

The test relied on a bug in the HTMLDocument JavaScript bindings: when calling
document.open() with three arguments, it would call any function set as the
"open" property on the window object, rather than just the real Window::open()
method. This bug was fixed by the removal of custom bindings for HTMLDocument
in r218437. As a result, the test no longer called alert(), which caused it to
fail.

Instead, call the window.open() function directly.

* TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
(testWebExtensionIsolatedWorld):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoNew baseline for insecure-audio-video-in-main-frame.html should apply to all ports
mcatanzaro@igalia.com [Mon, 28 Aug 2017 11:23:13 +0000 (11:23 +0000)]
New baseline for insecure-audio-video-in-main-frame.html should apply to all ports

The global baseline was never updated because the test has been failing on macOS.

* http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt:
* platform/gtk/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK][WPE] ASSERTION FAILED: !isOpen() in WebKit::IconDatabase::~IconDatabase()
carlosgc@webkit.org [Mon, 28 Aug 2017 11:18:25 +0000 (11:18 +0000)]
[GTK][WPE] ASSERTION FAILED: !isOpen() in WebKit::IconDatabase::~IconDatabase()
https://bugs.webkit.org/show_bug.cgi?id=175719

Reviewed by Michael Catanzaro.

This is happening always when running /webkit2/WebKitFaviconDatabase/favicon-database-test in debug builds. The
last step we do is removing all icons, then the test finishes, which destroys the WebKitFaviconDatabase object
that closes the icon database on dispose. The problem is that removing all icons schedules a main thread
notification and IconDatabase is not considered closed until all main thread callbacks have been dispatched. This
is never going to happen in the test, because the main loop is no longer running at that point. I don't think
it's worth it to consider the database open while main thread callbacks are pending, they are just notifications
and the client is no longer insterested on them afer closing the database. I think it's bettter and simpler to
simply cancel the pending callbacks on database close. That ensures that isOpen() after close() is always
false. This patch adds a helper private class to schedule notifications to the main thread that can be cancelled
on database close. It also removes the didClose() notification because it was unused and because it's pointless
now that we know the database is closed after close().

* UIProcess/API/glib/IconDatabase.cpp:
(WebKit::IconDatabase::open): Mark the main thread notifier as active.
(WebKit::IconDatabase::close): Mark the main thread notifier as not active.
(WebKit::IconDatabase::IconDatabase): Remove m_mainThreadCallbackCount initialization.
(WebKit::IconDatabase::isOpen const): Do what isOpenBesidesMainThreadCallbacks() used to do.
(WebKit::IconDatabase::removeAllIconsOnThread): Remove the notification because it's currently unused.
(WebKit::IconDatabase::dispatchDidImportIconURLForPageURLOnMainThread): Use MainThreadNotifier.
(WebKit::IconDatabase::dispatchDidImportIconDataForPageURLOnMainThread): Ditto.
(WebKit::IconDatabase::dispatchDidFinishURLImportOnMainThread): Ditto.
(WebKit::IconDatabase::isOpenBesidesMainThreadCallbacks const): Deleted.
(WebKit::IconDatabase::checkClosedAfterMainThreadCallback): Deleted.
(WebKit::IconDatabase::dispatchDidRemoveAllIconsOnMainThread): Deleted.
* UIProcess/API/glib/IconDatabase.h:
(WebKit::IconDatabaseClient::didChangeIconForPageURL):
(WebKit::IconDatabaseClient::didFinishURLImport):
(WebKit::IconDatabase::MainThreadNotifier::MainThreadNotifier):
(WebKit::IconDatabase::MainThreadNotifier::setActive):
(WebKit::IconDatabase::MainThreadNotifier::notify):
(WebKit::IconDatabase::MainThreadNotifier::stop):
(WebKit::IconDatabase::MainThreadNotifier::timerFired):
(WebKit::IconDatabaseClient::didRemoveAllIcons): Deleted.
(WebKit::IconDatabaseClient::didClose): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Rebaseline insecure-audio-video-in-main-frame.html.
commit-queue@webkit.org [Mon, 28 Aug 2017 11:02:56 +0000 (11:02 +0000)]
[GTK] Rebaseline insecure-audio-video-in-main-frame.html.
https://bugs.webkit.org/show_bug.cgi?id=142482

Unreviewed test gardening.

The test is failing due to a different console message. It seems better
to add a platform-specific baseline so we can catch actual failures.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-28

* platform/gtk/TestExpectations:
* platform/gtk/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Enable userAgentShadowDOM tests.
commit-queue@webkit.org [Mon, 28 Aug 2017 10:20:22 +0000 (10:20 +0000)]
[GTK] Enable userAgentShadowDOM tests.
https://bugs.webkit.org/show_bug.cgi?id=176015

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-28

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[WebCrypto] Push WorkQueue dispatches for AES algorithms into shared code
zandobersek@gmail.com [Mon, 28 Aug 2017 08:16:07 +0000 (08:16 +0000)]
[WebCrypto] Push WorkQueue dispatches for AES algorithms into shared code
https://bugs.webkit.org/show_bug.cgi?id=175539

Reviewed by Sam Weinig.

Push the WorkQueue dispatch code and other code duplicated between the
Mac and libgcrypt implementations of Web Crypto into the shared layer.
This patch focuses on the AES-based algorithms.

Functions with platform-specific implementations that are invoked from
these asynchronous dispatches are made static and return an ExceptionOr
value. CryptoAlgorithmParameters objects are passed through non-const
references because data getters could lazily construct the underlying
Vector objects. CryptoKey objects are passed through const references.
Implementations can then manually retrieve and further validate any key
or parameter data, as required for that specific implementation. Input
data is passed through const references to the original Vector objects.

No new tests -- no changes in behavior that's covered by existing tests.

* crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):
* crypto/algorithms/CryptoAlgorithmAES_CBC.h:
* crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:
(WebCore::CryptoAlgorithmAES_CFB::encrypt):
(WebCore::CryptoAlgorithmAES_CFB::decrypt):
* crypto/algorithms/CryptoAlgorithmAES_CFB.h:
* crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:
(WebCore::CryptoAlgorithmAES_CTR::encrypt):
(WebCore::CryptoAlgorithmAES_CTR::decrypt):
* crypto/algorithms/CryptoAlgorithmAES_CTR.h:
* crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:
(WebCore::CryptoAlgorithmAES_GCM::encrypt):
(WebCore::CryptoAlgorithmAES_GCM::decrypt):
* crypto/algorithms/CryptoAlgorithmAES_GCM.h:
* crypto/algorithms/CryptoAlgorithmAES_KW.cpp:
(WebCore::CryptoAlgorithmAES_KW::wrapKey):
(WebCore::CryptoAlgorithmAES_KW::unwrapKey):
* crypto/algorithms/CryptoAlgorithmAES_KW.h:
* crypto/gcrypt/CryptoAlgorithmAES_CBCGCrypt.cpp:
(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):
* crypto/gcrypt/CryptoAlgorithmAES_CFBGCrypt.cpp:
(WebCore::CryptoAlgorithmAES_CFB::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CFB::platformDecrypt):
* crypto/gcrypt/CryptoAlgorithmAES_CTRGCrypt.cpp:
(WebCore::CryptoAlgorithmAES_CTR::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CTR::platformDecrypt):
* crypto/gcrypt/CryptoAlgorithmAES_GCMGCrypt.cpp:
(WebCore::gcryptEncrypt):
(WebCore::gcryptDecrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformEncrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):
* crypto/gcrypt/CryptoAlgorithmAES_KWGCrypt.cpp:
(WebCore::CryptoAlgorithmAES_KW::platformWrapKey):
(WebCore::CryptoAlgorithmAES_KW::platformUnwrapKey):
* crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:
(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):
* crypto/mac/CryptoAlgorithmAES_CFBMac.cpp:
(WebCore::CryptoAlgorithmAES_CFB::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CFB::platformDecrypt):
* crypto/mac/CryptoAlgorithmAES_CTRMac.cpp:
(WebCore::CryptoAlgorithmAES_CTR::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CTR::platformDecrypt):
* crypto/mac/CryptoAlgorithmAES_GCMMac.cpp:
(WebCore::CryptoAlgorithmAES_GCM::platformEncrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):
* crypto/mac/CryptoAlgorithmAES_KWMac.cpp:
(WebCore::CryptoAlgorithmAES_KW::platformWrapKey):
(WebCore::CryptoAlgorithmAES_KW::platformUnwrapKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoPicking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput...
wenson_hsieh@apple.com [Mon, 28 Aug 2017 05:12:56 +0000 (05:12 +0000)]
Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
https://bugs.webkit.org/show_bug.cgi?id=170955
<rdar://problem/31697653>

Reviewed by Ryosuke Niwa.

Source/WebKit:

Currently, we insert text with TextEventInputAutocompletion as the text event input type if any text range to
replace was specified by the platform. Instead, limit this only to when the text replacement range is not empty.
This more closely matches the intention of the spec, which states that the "insertReplacementText" inputType
should be used when "[replacing] existing text by means of a spell checker, auto-correct or similar".

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::insertTextAsync):

Source/WebKitLegacy/mac:

Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
text is being replaced.

* WebView/WebHTMLView.mm:
(-[WebHTMLView insertText:]):

Tools:

Replace UIScriptController.insertText with UIScriptController.replaceTextAtRange, and implement
replaceTextAtRange in WebKit1. See corresponding layout tests (input-event-insert-replacement.html and
before-input-prevent-insert-replacement.html) for more detail.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/mac/AppKitTestSPI.h: Added.

Introduce an SPI header for private AppKit headers needed to support DumpRenderTree.

* DumpRenderTree/mac/UIScriptControllerMac.mm:
(WTR::UIScriptController::replaceTextAtRange):
(WTR::UIScriptController::insertText): Deleted.
* TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
* TestRunnerShared/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::replaceTextAtRange):
(WTR::UIScriptController::insertText): Deleted.
* TestRunnerShared/UIScriptContext/UIScriptController.h:
* WebKitTestRunner/mac/UIScriptControllerMac.mm:
(WTR::UIScriptController::replaceTextAtRange):
(WTR::UIScriptController::insertText): Deleted.

Replace UIScriptController.insertText with UIScriptController.replaceTextAtRange, which better describes the
behavior of this function.

LayoutTests:

Augments two existing layout tests to check for additional cases of inserting text with replacement ranges.
Also enables this test for WebKit1 on Mac. Both these tests are currently enabled only for WebKit2, and also only
check the case where we're replacing an existing non-empty range of text.

* fast/events/before-input-prevent-insert-replacement-expected.txt:
* fast/events/before-input-prevent-insert-replacement.html:
* fast/events/input-event-insert-replacement-expected.txt:
* fast/events/input-event-insert-replacement.html:

Tests for cases of replacing existing text ranges, and inserting text at a position.

* platform/mac-wk1/TestExpectations:
* resources/ui-helper.js:

Add a new UIHelper function to insert text at a given replacement range. This codepath is taken when selecting
an emoji using the emoji picker menu on Mac, and also when selecting a dead key option after holding down on a
vowel key.

(window.UIHelper.replaceTextAtRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[iOS WK2] Web process crashes after changing selection to the end of the document...
wenson_hsieh@apple.com [Mon, 28 Aug 2017 01:22:55 +0000 (01:22 +0000)]
[iOS WK2] Web process crashes after changing selection to the end of the document when speaking a selection
https://bugs.webkit.org/show_bug.cgi?id=176011
<rdar://problem/32614095>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Adds a null check to visiblePositionForPositionWithOffset. This is a crash point for accessibility codepaths,
since indexForVisiblePosition is not guaranteed to set the given `root` outparam to a non-null value, yet
visiblePositionForIndex requires root to be non-null. This causes a crash when selecting some text, hitting
'Speak', and then changing the selection to somewhere near the end of the document, since accessibility code
will attempt to speak words at an offset past the end of the document. While this is a bug in and of itself, the
web process should still handle this case gracefully and not crash. To fix this, we simply bail and return a
null VisiblePosition if a root container node was not found.

Currently, visiblePositionForPositionWithOffset is implemented twice, in WebCore (AXObjectCache.cpp) and also in
WebKit (WebPageIOS.mm), as identical static functions. This patch moves this helper into Editing.cpp and removes
it from AXObjectCache and WebPageIOS.

Tests: AccessibilityTests.RectsForSpeakingSelectionBasic
       AccessibilityTests.RectsForSpeakingSelectionWithLineWrapping
       AccessibilityTests.RectsForSpeakingSelectionDoNotCrashWhenChangingSelection

* accessibility/AXObjectCache.cpp:
(WebCore::visiblePositionForPositionWithOffset): Deleted.
* editing/Editing.cpp:
(WebCore::visiblePositionForPositionWithOffset):
* editing/Editing.h:

Source/WebKit:

Adds an SPI hook to test accessibility codepaths when speaking selected content. This patch does some minor
refactoring by introducing _accessibilityRetrieveRectsAtSelectionOffset:withText:completionHandler:, which takes
and invokes a completion handler block. The existing _accessibilityRetrieveRectsAtSelectionOffset:withText:
method simply turns around and calls the former variant with `nil` as a completion handler.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _accessibilityRetrieveRectsAtSelectionOffset:withText:completionHandler:]):
* UIProcess/API/Cocoa/WKWebViewPrivate.h:
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _accessibilityRetrieveRectsAtSelectionOffset:withText:]):
(-[WKContentView _accessibilityRetrieveRectsAtSelectionOffset:withText:completionHandler:]):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::visiblePositionForPositionWithOffset): Deleted.

Tools:

Introduces AccessibilityTests, and adds three new tests that traverse selection-rect-finding codepaths when
speaking selected content. See WebKit and WebCore ChangeLogs for more detail.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm: Added.
(-[WKWebView rectsAtSelectionOffset:withText:]):
(checkCGRectValueAtIndex):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Record actions performed on WebGLRenderingContext
webkit@devinrousso.com [Sun, 27 Aug 2017 16:12:39 +0000 (16:12 +0000)]
Web Inspector: Record actions performed on WebGLRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=174483
<rdar://problem/34040722>

Reviewed by Matt Baker.

Source/JavaScriptCore:

* inspector/protocol/Recording.json:
* inspector/scripts/codegen/generator.py:
Add type and mapping for WebGL: "canvas-webgl" => CanvasWebGL

Source/WebCore:

Tests: inspector/canvas/recording-webgl.html
       inspector/canvas/recording-webgl-snapshots.html

* bindings/js/CallTracerTypes.h:
Add types for WebGL parameters.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateAttributeSetterBodyDefinition):
(GenerateImplementationFunctionCall):
(GenerateCallTracerParameter):
Modify the generated code for `CallTracingCallback` so that optional/nullable types are only
dereferenced if they have a value.

* html/canvas/WebGLRenderingContext.idl:
Add `CallTracingCallback` to interface to record all API calls.

* inspector/InspectorCanvas.h:
* inspector/InspectorCanvas.cpp:
(WebCore::InspectorCanvas::resetRecordingData):
(WebCore::shouldSnapshotWebGLAction):
(WebCore::InspectorCanvas::recordAction):
(WebCore::InspectorCanvas::releaseInitialState):
(WebCore::InspectorCanvas::releaseFrames):
(WebCore::InspectorCanvas::appendActionSnapshotIfNeeded):
(WebCore::InspectorCanvas::getCanvasContentAsDataURL):
(WebCore::InspectorCanvas::buildInitialState):
(WebCore::InspectorCanvas::buildAction):
For all non-primitive WebGL objects, send a string corresponding to the object's name. The
value isn't needed since the preview will be generated by the `toDataURL` snapshots taken
after every visual action.

* inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::didFinishRecordingCanvasFrame):

* bindings/scripts/test/TestCallTracer.idl:
* bindings/scripts/test/JS/JSTestCallTracer.cpp:
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableVariantArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableVariantArgument):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithOptionalVariantArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithOptionalVariantArgument):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithDefaultVariantArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithDefaultVariantArgument):

Source/WebInspectorUI:

* UserInterface/Models/Recording.js:
(WI.Recording):
(WI.Recording.fromPayload):
(WI.Recording.prototype.swizzle):
Add swizzle types for WebGL parameters.

* UserInterface/Models/RecordingAction.js:
(WI.RecordingAction):
(WI.RecordingAction.fromPayload):
(WI.RecordingAction.prototype.get snapshot):
(WI.RecordingAction.prototype.swizzle):
(WI.RecordingAction.prototype.toJSON):
Include an optional fourth parameter `snapshot` that will be sent for visual actions when
recording WebGL canvas contexts.

* UserInterface/Views/RecordingContentView.js:
(WI.RecordingContentView):
(WI.RecordingContentView.prototype.get navigationItems):
(WI.RecordingContentView.prototype.updateActionIndex):
(WI.RecordingContentView.prototype.shown):
(WI.RecordingContentView.prototype._generateContentCanvasWebGL):
* UserInterface/Views/RecordingContentView.css:
(.content-view:not(.tab).recording :matches(img, canvas)):
(.content-view:not(.tab).recording canvas): Deleted.
Instead of regenerating the canvas context in the WebInspector frontend, just display the
snapshot image for the last visual action.

* UserInterface/Views/CanvasContentView.js:
(WI.CanvasContentView):

* UserInterface/Views/RecordingActionTreeElement.js:
(WI.RecordingActionTreeElement._generateDOM):

LayoutTests:

* inspector/canvas/recording-webgl-expected.txt: Added.
* inspector/canvas/recording-webgl.html: Added.

* inspector/canvas/recording-webgl-snapshots-expected.txt: Added.
* inspector/canvas/recording-webgl-snapshots.html: Added.
Created separate test for checking that snapshots differ so that each test doesn't interfere
with the results of the other tests.

* inspector/canvas/recording-2d-expected.html:
* inspector/canvas/recording-2d.html:
Drive by: change naming to match inspector/canvas/recording-webgl.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoREGRESSION (r220105): Storage service appears in macOS Activity Monitor as “localized...
mitz@apple.com [Sun, 27 Aug 2017 00:08:50 +0000 (00:08 +0000)]
REGRESSION (r220105): Storage service appears in macOS Activity Monitor as “localized string not found”
https://bugs.webkit.org/show_bug.cgi?id=176007

Reviewed by Tim Horton.

* English.lproj/Localizable.strings: Updated using update-webkit-localizable-strings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoBuild fix. Creating trying a test group no longer updates the page.
rniwa@webkit.org [Sat, 26 Aug 2017 23:26:16 +0000 (23:26 +0000)]
Build fix. Creating trying a test group no longer updates the page.

* public/v3/models/test-group.js:
(TestGroup.createWithCustomConfiguration): Added the missing ignoreCache=true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed gardening, mark a test as still failing
mcatanzaro@igalia.com [Sat, 26 Aug 2017 19:09:24 +0000 (19:09 +0000)]
Unreviewed gardening, mark a test as still failing

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove PolicyChecker::cancelCheck
commit-queue@webkit.org [Sat, 26 Aug 2017 16:58:22 +0000 (16:58 +0000)]
Remove PolicyChecker::cancelCheck
https://bugs.webkit.org/show_bug.cgi?id=176002

Patch by Alex Christensen <achristensen@webkit.org> on 2017-08-26
Reviewed by Darin Adler.

cancelCheck is conceptually equivalent to not calling a completion handler.
stopCheck is conceptually equivalent to calling a completion handler with PolicyIgnore just before cleaning up everything,
which is semantically cleaner and necessary when I replace the last use of PolicyCallback with a CompletionHandler.
Before this change, we were probably causing some loading objects to hang right before deleting them, and this cleans them up better.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::cancelPolicyCheckIfNeeded):
* loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::cancelCheck): Deleted.
* loader/PolicyChecker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, tighten up scope of variable in previous commit
mcatanzaro@igalia.com [Sat, 26 Aug 2017 16:54:35 +0000 (16:54 +0000)]
Unreviewed, tighten up scope of variable in previous commit

* platform/network/soup/CookieJarSoup.cpp:
(WebCore::cookiesForSession):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[SOUP] Update cookie jar implementation to filter out secure cookies
mcatanzaro@igalia.com [Sat, 26 Aug 2017 16:49:59 +0000 (16:49 +0000)]
[SOUP] Update cookie jar implementation to filter out secure cookies
https://bugs.webkit.org/show_bug.cgi?id=175850

Reviewed by Brent Fulgham.

Source/WebCore:

Filter out secure cookies when indicated.

* platform/network/soup/CookieJarSoup.cpp:
(WebCore::cookiesForSession):
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::getRawCookies):

LayoutTests:

Unskip newly-passing tests.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, suppress warnings in GTK port
utatane.tea@gmail.com [Sat, 26 Aug 2017 08:40:49 +0000 (08:40 +0000)]
Unreviewed, suppress warnings in GTK port

Source/JavaScriptCore:

The "block" variable hides the argument variable.

* dfg/DFGLiveCatchVariablePreservationPhase.cpp:
(JSC::DFG::LiveCatchVariablePreservationPhase::isValidFlushLocation):

Source/WTF:

Add printf format attribute.

* wtf/text/WTFString.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[EME][GStreamer] Connect CDM to GStreamer
calvaris@igalia.com [Sat, 26 Aug 2017 08:29:00 +0000 (08:29 +0000)]
[EME][GStreamer] Connect CDM to GStreamer
https://bugs.webkit.org/show_bug.cgi?id=175983

Reviewed by Žan Doberšek.

This is still a version that will need some changes for some other
use cases but it should be enough to begin with some passes in the
tests and some basic use cases.

We use the attach CDMInstance interface in the private player to
get the instance in time for the initializationDataEncountered
event, which is handled when the demuxer reports synchronously the
events even before configuring the decryptors. We wait there in
case we don't have the CDMInstance attached (which contains info
about the key system now) and when we get it we report it back to
the demuxer and continue sending the event.

We also handled the events when handled by the decryptors but for
now this will remain a FIXME. The events handled by the
AppendPipeline will end up here too for now.

The CDM instance is created with the key system because some CDMs
can handle more than one, not ClearKey yet but others in the
(near) future.

MockCDMFactory is adapted to the changes as expected.

* Modules/encryptedmedia/CDM.cpp:
(WebCore::CDM::CDM):
* platform/encryptedmedia/CDMFactory.h:
* platform/encryptedmedia/CDMInstance.h:
* platform/encryptedmedia/clearkey/CDMClearKey.cpp:
(WebCore::CDMFactoryClearKey::createCDM):
(WebCore::CDMInstanceClearKey::keySystem const):
* platform/encryptedmedia/clearkey/CDMClearKey.h:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
(WebCore::extractEventsAndSystemsFromMessage):
(WebCore::MediaPlayerPrivateGStreamerBase::handleSyncMessage):
(WebCore::MediaPlayerPrivateGStreamerBase::cdmInstanceAttached):
(WebCore::MediaPlayerPrivateGStreamerBase::cdmInstanceDetached):
(WebCore::MediaPlayerPrivateGStreamerBase::attemptToDecryptWithInstance):
(WebCore::MediaPlayerPrivateGStreamerBase::attemptToDecryptWithLocalInstance):
(WebCore::MediaPlayerPrivateGStreamerBase::dispatchDecryptionKey):
(WebCore::MediaPlayerPrivateGStreamerBase::handleProtectionEvent):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::appendPipelineElementMessageCallback):
(WebCore::AppendPipeline::AppendPipeline):
(WebCore::AppendPipeline::~AppendPipeline):
(WebCore::AppendPipeline::handleNeedContextSyncMessage):
(WebCore::AppendPipeline::handleElementMessage):
(WebCore::AppendPipeline::handleAppsrcNeedDataReceived):
(WebCore::AppendPipeline::appsinkNewSample):
* platform/graphics/gstreamer/mse/AppendPipeline.h:
* testing/MockCDMFactory.cpp:
(WebCore::MockCDMFactory::createCDM):
(WebCore::MockCDMInstance::keySystem const):
* testing/MockCDMFactory.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMerge WeakMapData into JSWeakMap and JSWeakSet
utatane.tea@gmail.com [Sat, 26 Aug 2017 08:01:24 +0000 (08:01 +0000)]
Merge WeakMapData into JSWeakMap and JSWeakSet
https://bugs.webkit.org/show_bug.cgi?id=143919

Reviewed by Darin Adler.

This patch changes WeakMapData from JSCell to JSDestructibleObject,
renaming it to WeakMapBase, and JSWeakMap and JSWeakSet simply inherit
it instead of separately allocating WeakMapData. This reduces memory
consumption and allocation times.

Also this patch a bit optimizes sizeof(DeadKeyCleaner) by dropping m_target
field. Since this class is always embedded in WeakMapBase, we can calculate
WeakMapBase address from the address of DeadKeyCleaner.

This patch does not include the optimization changing WeakMapData to Set
for JSWeakSet.

* CMakeLists.txt:
* JavaScriptCore.xcodeproj/project.pbxproj:
* inspector/JSInjectedScriptHost.cpp:
(Inspector::JSInjectedScriptHost::weakMapSize):
(Inspector::JSInjectedScriptHost::weakMapEntries):
(Inspector::JSInjectedScriptHost::weakSetSize):
(Inspector::JSInjectedScriptHost::weakSetEntries):
* runtime/JSWeakMap.cpp:
(JSC::JSWeakMap::finishCreation): Deleted.
(JSC::JSWeakMap::visitChildren): Deleted.
* runtime/JSWeakMap.h:
(JSC::JSWeakMap::createStructure): Deleted.
(JSC::JSWeakMap::create): Deleted.
(JSC::JSWeakMap::weakMapData): Deleted.
(JSC::JSWeakMap::JSWeakMap): Deleted.
* runtime/JSWeakSet.cpp:
(JSC::JSWeakSet::finishCreation): Deleted.
(JSC::JSWeakSet::visitChildren): Deleted.
* runtime/JSWeakSet.h:
(JSC::JSWeakSet::createStructure): Deleted.
(JSC::JSWeakSet::create): Deleted.
(JSC::JSWeakSet::weakMapData): Deleted.
(JSC::JSWeakSet::JSWeakSet): Deleted.
* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h:
* runtime/WeakMapBase.cpp: Renamed from Source/JavaScriptCore/runtime/WeakMapData.cpp.
(JSC::WeakMapBase::WeakMapBase):
(JSC::WeakMapBase::destroy):
(JSC::WeakMapBase::estimatedSize):
(JSC::WeakMapBase::visitChildren):
(JSC::WeakMapBase::set):
(JSC::WeakMapBase::get):
(JSC::WeakMapBase::remove):
(JSC::WeakMapBase::contains):
(JSC::WeakMapBase::clear):
(JSC::WeakMapBase::DeadKeyCleaner::target):
(JSC::WeakMapBase::DeadKeyCleaner::visitWeakReferences):
(JSC::WeakMapBase::DeadKeyCleaner::finalizeUnconditionally):
* runtime/WeakMapBase.h: Renamed from Source/JavaScriptCore/runtime/WeakMapData.h.
(JSC::WeakMapBase::size const):
* runtime/WeakMapPrototype.cpp:
(JSC::getWeakMap):
(JSC::protoFuncWeakMapDelete):
(JSC::protoFuncWeakMapGet):
(JSC::protoFuncWeakMapHas):
(JSC::protoFuncWeakMapSet):
(JSC::getWeakMapData): Deleted.
* runtime/WeakSetPrototype.cpp:
(JSC::getWeakSet):
(JSC::protoFuncWeakSetDelete):
(JSC::protoFuncWeakSetHas):
(JSC::protoFuncWeakSetAdd):
(JSC::getWeakMapData): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[WebCrypto] Push WorkQueue dispatches for RSA algorithms into shared code
zandobersek@gmail.com [Sat, 26 Aug 2017 07:48:19 +0000 (07:48 +0000)]
[WebCrypto] Push WorkQueue dispatches for RSA algorithms into shared code
https://bugs.webkit.org/show_bug.cgi?id=175621

Reviewed by Darin Adler.

Push the WorkQueue dispatch code and other code duplicated between the
Mac and libgcrypt implementations of Web Crypto into the shared layer.
This patch focuses on the RSA-based algorithms.

The WorkQueue dispatch code is condensed into two static functions on
the CryptoAlgorithm class, the first variation handling VectorCallback
as the callback type and the other handling BoolCallback. The operation
is kept in a WTF::Function<> object that returns an ExceptionOr<> value
embedding either a Vector<uint8_t> object or a boolean value, as
appropriate for the callback type.

Functions with platform-specific implementations that are invoked from
these asynchronous dispatches are made static and return an ExceptionOr
value. CryptoAlgorithmParameters objects are passed through non-const
references because data getters could lazily construct the underlying
Vector objects. CryptoKey objects are passed through const references.
Implementations can then manually retrieve and further validate any key
or parameter data, as required for that specific implementation. Input
data is passed through const references to the original Vector objects.

No new tests -- no changes in behavior that's covered by existing tests.

* crypto/CryptoAlgorithm.cpp:
(WebCore::dispatchOperationImpl):
(WebCore::CryptoAlgorithm::dispatchOperation):
* crypto/CryptoAlgorithm.h:
* crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::encrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::decrypt):
* crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
* crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
* crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
* crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:
(WebCore::CryptoAlgorithmRSA_OAEP::encrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::decrypt):
* crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
* crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:
(WebCore::CryptoAlgorithmRSA_PSS::sign):
(WebCore::CryptoAlgorithmRSA_PSS::verify):
* crypto/algorithms/CryptoAlgorithmRSA_PSS.h:
* crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:
(WebCore::gcryptEncrypt):
(WebCore::gcryptDecrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):
* crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp:
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):
* crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:
(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):
* crypto/gcrypt/CryptoAlgorithmRSA_PSSGCrypt.cpp:
(WebCore::CryptoAlgorithmRSA_PSS::platformSign):
(WebCore::CryptoAlgorithmRSA_PSS::platformVerify):
* crypto/mac/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp:
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):
* crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):
* crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp:
(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):
* crypto/mac/CryptoAlgorithmRSA_PSSMac.cpp:
(WebCore::CryptoAlgorithmRSA_PSS::platformSign):
(WebCore::CryptoAlgorithmRSA_PSS::platformVerify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd Logger::logAlways
eric.carlson@apple.com [Sat, 26 Aug 2017 03:30:41 +0000 (03:30 +0000)]
Add Logger::logAlways
https://bugs.webkit.org/show_bug.cgi?id=175996

Reviewed by Jer Noble.

Source/WebCore/PAL:

* PAL.xcodeproj/project.pbxproj:
* pal/Logger.h:
(PAL::Logger::willLog const):
(PAL::Logger::willLog const):
(PAL::Logger::logAlways): Added.
(PAL::Logger::error const): Add missing WTF_ATTRIBUTE_PRINTF.
(PAL::Logger::warning const): Ditto.
(PAL::Logger::notice const): Ditto.
(PAL::Logger::info const): Ditto.
(PAL::Logger::debug const): Use String::formatWithArguments.

Source/WTF:

* wtf/Assertions.cpp:
* wtf/Assertions.h:

Tools:

* TestWebKitAPI/Tests/WebCore/Logging.cpp:
(TestWebKitAPI::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221221 268f45cc-cd09-0410-ab3c-d52691b4dbfc