WebKit-https.git
15 years ago2007-04-09 Andrew Wellington <proton@wiretapped.net>
andrew [Mon, 9 Apr 2007 11:48:45 +0000 (11:48 +0000)]
2007-04-09  Andrew Wellington  <proton@wiretapped.net>

        Reviewed by Justin Garcia.

        Layout test for http://bugs.webkit.org/show_bug.cgi?id=12959
        "REGRESSION: Edit -> Copy not enabled on standalone images"

        * editing/pasteboard/copy-standalone-image-expected.checksum: Added.
        * editing/pasteboard/copy-standalone-image-expected.png: Added.
        * editing/pasteboard/copy-standalone-image-expected.txt: Added.
        * editing/pasteboard/copy-standalone-image.html: Added.

2007-04-09  Andrew Wellington  <proton@wiretapped.net>

        Reviewed by Justin Garcia.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=12959
        "REGRESSION: Edit -> Copy not enabled on standalone images"

        * dom/Document.h: Add support for determining if a document is an image
        (WebCore::Document::isImageDocument):
        * editing/Editor.cpp:
        (WebCore::Editor::canCopy): Image documents are copyable
        (WebCore::Editor::copy): If copying an image document, call appropriate pasteboard methods
        * loader/ImageDocument.h:
        (WebCore::ImageDocument::isImageDocument): Override to return true for image documents
        * platform/Pasteboard.h: Add new writeImage function to pasteboard
        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::writeImage): Add writeImage implementation that takes Node and URL
        * platform/qt/PasteboardQt.cpp:
        (WebCore::Pasteboard::writeImage): Stub for Qt implementation of pasteboard

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-08 Oliver Hunt <oliver@apple.com>
oliver [Mon, 9 Apr 2007 06:32:06 +0000 (06:32 +0000)]
2007-04-08  Oliver Hunt  <oliver@apple.com>

        rs=Adam.

        Add ASSERT(selectedRange) to previous change

        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::writeSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-08 Oliver Hunt <oliver@apple.com>
oliver [Mon, 9 Apr 2007 06:14:19 +0000 (06:14 +0000)]
2007-04-08  Oliver Hunt  <oliver@apple.com>

        rs=Adam.

        Fix minor error when writing selection to pasteboard.
        This shouldn't have an effect as selectedRange should be the
        selected range from source frame, however this is safer.

        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::writeSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix mouseover/out failing layout tests.
hyatt [Mon, 9 Apr 2007 06:11:48 +0000 (06:11 +0000)]
    Fix mouseover/out failing layout tests.

        Reviewed by aroben

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseMoveEvent):
        (WebCore::EventHandler::updateMouseEventTargetNode):
        (WebCore::EventHandler::dispatchMouseEvent):
        * page/EventHandler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-08 Oliver Hunt <oliver@apple.com>
oliver [Mon, 9 Apr 2007 04:30:31 +0000 (04:30 +0000)]
2007-04-08  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam.

        Fix for <rdar://problem/5113621> REGRESSION: Dragging PDF as image does not give any feedback

        If we fail when attempting to create a drag image for a dragged
        image, we fall back to the appropriate icon.

        * page/DragController.cpp:
        (WebCore::DragController::doImageDrag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
aroben [Mon, 9 Apr 2007 03:32:13 +0000 (03:32 +0000)]
    Reviewed by Oliver.

        Bestowed the gift of -webkit-dashboard-region upon all platforms, since
        there's nothing Mac-specific about it other than the name. This also
        allowed me to get rid of FrameViewMac.mm.

        Removed a lot of #if PLATFORM(MAC):

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        (WebCore::CSSPrimitiveValue::cleanup):
        (WebCore::CSSPrimitiveValue::cssText):
        * css/CSSPrimitiveValue.h:
        (WebCore::CSSPrimitiveValue::getDashboardRegionValue):
        (WebCore::CSSPrimitiveValue::):
        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseDashboardRegions):
        * css/cssparser.h:
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        * dom/Document.h:
        * page/Frame.cpp:
        (WebCore::Frame::paint):
        * page/Frame.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::layout):
        (WebCore::FrameView::updateDashboardRegions): Moved from FrameViewMac.mm.
        * page/FrameView.h:
        * page/qt/FrameQt.cpp:
        (WebCore::Frame::dashboardRegionsChanged): Stubbed out.
        * platform/gdk/FrameGdk.cpp:
        (WebCore::Frame::dashboardRegionsChanged): Ditto.
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollToOffset):
        (WebCore::RenderLayer::setHasHorizontalScrollbar):
        (WebCore::RenderLayer::setHasVerticalScrollbar):
        (WebCore::RenderLayer::updateScrollInfoAfterLayout):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::setStyle):

        * WebCore.xcodeproj/project.pbxproj: Removed FrameViewMac.mm.
        * bridge/mac/FrameViewMac.mm: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-08 Mark Rowe <mrowe@apple.com>
bdash [Sun, 8 Apr 2007 10:15:16 +0000 (10:15 +0000)]
2007-04-08  Mark Rowe  <mrowe@apple.com>

        Qt build fix.

        * platform/qt/TemporaryLinkStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
ggaren [Sat, 7 Apr 2007 19:32:09 +0000 (19:32 +0000)]
LayoutTests:

        Reviewed by Beth Dakin.

        Layout tests for one more case of <rdar://problem/5112273> REGRESSION(TOT):
        Reproducible crash loading an old version of amazon.com as a web archive

        * fast/dom/null-document-xmlhttprequest-open-expected.txt: Added.
        * fast/dom/null-document-xmlhttprequest-open.html: Added.

WebCore:

        Reviewed by Beth Dakin.

        Fixed one more case of <rdar://problem/5112273> REGRESSION(TOT):
        Reproducible crash loading an old version of amazon.com as a web archive

        * bindings/js/JSXMLHttpRequest.cpp:
        (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-06 Oliver Hunt <oliver@apple.com>
oliver [Sat, 7 Apr 2007 05:44:44 +0000 (05:44 +0000)]
2007-04-06  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam.

        Fix MouseEvent so it's possible to distinguish between
        a MouseMouseEvent with NoButton down, and a move with
        LeftButton down.  It would be nice if the DOM allowed
        for NoButton to exist, but it doesn't so this is necessary.

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchMouseEvent):
        * dom/MouseEvent.cpp:
        (WebCore::MouseEvent::MouseEvent):
        (WebCore::MouseEvent::initMouseEvent):
        * dom/MouseEvent.h:
        (WebCore::MouseEvent::noButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-07 Mark Rowe <mrowe@apple.com>
bdash [Sat, 7 Apr 2007 04:24:59 +0000 (04:24 +0000)]
2007-04-07  Mark Rowe  <mrowe@apple.com>

        Not reviewed.  Update to match some configuration changes that have been active on build.webkit.org.

        * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Not reviewed - gdk build fix.
kjk [Sat, 7 Apr 2007 03:31:48 +0000 (03:31 +0000)]
    Not reviewed - gdk build fix.

        * platform/gdk/MouseEventGdk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by darin.
kjk [Sat, 7 Apr 2007 03:08:04 +0000 (03:08 +0000)]
    Reviewed by darin.

        Coverity fix. Coverity says:
        "Event var_deref_op: Variable "info_ptr" tracked as NULL was dereferenced."

        * platform/image-decoders/png/pngrutil.c:
        (png_handle_gAMA):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoIndex: WebCore/ChangeLog
kjk [Sat, 7 Apr 2007 03:05:13 +0000 (03:05 +0000)]
Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog (revision 20709)
+++ WebCore/ChangeLog (working copy)
@@ -1,3 +1,13 @@
+2007-04-04  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
+
+        Reviewed by darin.
+
+        Coverity fix. Coverity says:
+        "Event var_deref_model: Variable "(this)->clientptr" tracked as NULL was passed to a function that dereferences it."
+
+        * platform/image-decoders/gif/GIFImageReader.cpp:
+        (GIFImageReader::read):
+
 2007-04-04  Adele Peterson  <adele@apple.com>

         Reviewed by Oliver.
Index: WebCore/platform/image-decoders/gif/GIFImageReader.cpp
===================================================================
--- WebCore/platform/image-decoders/gif/GIFImageReader.cpp (revision 20709)
+++ WebCore/platform/image-decoders/gif/GIFImageReader.cpp (working copy)
@@ -760,7 +760,8 @@ bool GIFImageReader::read(const unsigned
       if (query == GIFImageDecoder::GIFSizeQuery || haltAtFrame == images_decoded) {
         // The decoder needs to stop.  Hand back the number of bytes we consumed from
         // buffer minus 9 (the amount we consumed to read the header).
-        clientptr->decodingHalted(len + 9);
+        if (clientptr)
+            clientptr->decodingHalted(len + 9);
         GETN(9, gif_image_header);
         return true;
       }

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoIndex: JavaScriptCore/ChangeLog
kjk [Sat, 7 Apr 2007 03:02:11 +0000 (03:02 +0000)]
Index: JavaScriptCore/ChangeLog
===================================================================
--- JavaScriptCore/ChangeLog (revision 20709)
+++ JavaScriptCore/ChangeLog (working copy)
@@ -1,3 +1,14 @@
+2007-04-04  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
+
+        Reviewed by darin.
+
+        Coverity fix. Coverity says:
+        "Event var_deref_model: Variable "sourceRanges" tracked as NULL was passed to a
+        function that dereferences it"
+
+        * kjs/string_object.cpp:
+        (KJS::replace):
+
 2007-04-03  Kevin McCullough  <kmccullough@apple.com>

         Reviewed by Adam.
Index: JavaScriptCore/kjs/string_object.cpp
===================================================================
--- JavaScriptCore/kjs/string_object.cpp (revision 20709)
+++ JavaScriptCore/kjs/string_object.cpp (working copy)
@@ -387,7 +387,9 @@ static JSValue *replace(ExecState *exec,
     if (lastIndex < source.size())
       pushSourceRange(sourceRanges, sourceRangeCount, sourceRangeCapacity, UString::Range(lastIndex, source.size() - lastIndex));

-    UString result = source.spliceSubstringsWithSeparators(sourceRanges, sourceRangeCount, replacements, replacementCount);
+    UString result;
+    if (sourceRanges)
+        result = source.spliceSubstringsWithSeparators(sourceRanges, sourceRangeCount, replacements, replacementCount);

     delete [] sourceRanges;
     delete [] replacements;

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix more of the layout test failures caused by fixing the slider layout test...
hyatt [Sat, 7 Apr 2007 00:56:03 +0000 (00:56 +0000)]
    Fix more of the layout test failures caused by fixing the slider layout test failure (sigh).  clear()
        needs to null out the capturingMouseEventsNode in the case where a mousedown or move while captured
        causes a navigation to another page.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::clear):
        (WebCore::EventHandler::handleMouseReleaseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix failing slider layout test. Don't clear the subframe capture unless...
hyatt [Sat, 7 Apr 2007 00:15:41 +0000 (00:15 +0000)]
    Fix failing slider layout test.  Don't clear the subframe capture unless we really were capturing on a
        subframe.

        Reviewed by adele, darin

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseReleaseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBuild fix attempt.
thatcher [Fri, 6 Apr 2007 23:59:17 +0000 (23:59 +0000)]
Build fix attempt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff and Darin.
bdakin [Fri, 6 Apr 2007 23:56:04 +0000 (23:56 +0000)]
    Reviewed by Geoff and Darin.

        Fix for <rdar://problem/4875433> WebView underlines are too thick
        when scaled small

        When we have a small scale factor, we should follow the line-
        drawing code as if we were printing. Meaning, specifically, that we
        should not round to device pixels and we should antialias.

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::drawLineForText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
ggaren [Fri, 6 Apr 2007 23:12:57 +0000 (23:12 +0000)]
LayoutTests:

        Reviewed by Beth Dakin.

        Layout tests for <rdar://problem/5112273> REGRESSION(TOT): Reproducible
        crash loading an old version of amazon.com as a web archive

        * fast/dom/null-document-location-assign-crash-expected.txt: Added.
        * fast/dom/null-document-location-assign-crash.html: Added.
        * fast/dom/null-document-location-href-put-crash-expected.txt: Added.
        * fast/dom/null-document-location-href-put-crash.html: Added.
        * fast/dom/null-document-location-put-crash-expected.txt: Added.
        * fast/dom/null-document-location-put-crash.html: Added.
        * fast/dom/null-document-location-replace-crash-expected.txt: Added.
        * fast/dom/null-document-location-replace-crash.html: Added.
        * fast/dom/null-document-window-open-crash-expected.txt: Added.
        * fast/dom/null-document-window-open-crash.html: Added.

WebCore:

        Reviewed by Beth Dakin.

        Fixed <rdar://problem/5112273> REGRESSION(TOT): Reproducible crash loading
        an old version of amazon.com as a web archive

        The problem was JavaScript executing inside a frame with a NULL document.
        It's probably a bug that the document was NULL, but we don't want a minor
        bug to be a crasher, and we don't want the DOM to depend on the implementation
        details of the JS bindings, so I added NULL checks.

        * bindings/js/kjs_window.cpp: Call FrameLoader::completeURL instead of
        Document::completeURL, since FrameLoader::completeURL is safe against a
        NULL document.
        (KJS::Window::put):
        (KJS::WindowFunc::callAsFunction):
        (KJS::Location::put):
        (KJS::LocationFunc::callAsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele.
aroben [Fri, 6 Apr 2007 22:11:01 +0000 (22:11 +0000)]
    Reviewed by Adele.

        These two editing tests were using the wrong case for
        dumpEditingCallbacks, which meant that they were falling into DRT's
        invokeUndefinedMethodFromWebScript instead of actually turning on the
        callback dumping.

        This patch fixes the case of the call and updates the results.

        * editing/execCommand/4641880-1-expected.txt:
        * editing/execCommand/4641880-1.html:
        * editing/execCommand/4641880-2-expected.txt:
        * editing/execCommand/4641880-2.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for bug 13274. Rework mouse events so that subframe capturing works...
hyatt [Fri, 6 Apr 2007 21:37:48 +0000 (21:37 +0000)]
    Fix for bug 13274.  Rework mouse events so that subframe capturing works again.  Make sure
        everything just comes down through the top FrameView even when capturing is in effect.  Update
        scrollbar handling logic so that scrollbars receive events correctly while capturing is in
        effect.  Eliminate the notion of widget capture.  Fix mouse moves so that they only fire
        on the innermost hit frame.

        Reviewed by olliej

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseDraggedEvent):
        (WebCore::subframeForTargetNode):
        (WebCore::EventHandler::handleMousePressEvent):
        (WebCore::EventHandler::handleMouseMoveEvent):
        (WebCore::EventHandler::handleMouseReleaseEvent):
        * page/EventHandler.h:
        * platform/PopupMenu.h:
        (WebCore::PopupMenu::scrollbarCapturingMouse):
        (WebCore::PopupMenu::setScrollbarCapturingMouse):
        * platform/ScrollBar.h:
        (WebCore::Scrollbar::handleMouseReleaseEvent):
        * platform/Widget.h:
        (WebCore::Widget::geometryChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Fri, 6 Apr 2007 18:59:04 +0000 (18:59 +0000)]
LayoutTests:

        Reviewed by john

        <rdar://problem/5115601>
        REGRESSION: Crash deleting a selection that starts in an editable table cell

        * editing/deleting/5115601-expected.checksum: Added.
        * editing/deleting/5115601-expected.png: Added.
        * editing/deleting/5115601-expected.txt: Added.
        * editing/deleting/5115601.html: Added.

WebCore:

        Reviewed by john

        <rdar://problem/5115601>
        REGRESSION: Crash deleting a selection that starts in an editable table cell

        The selection starts at the start of an editable
        root that's embedded in a non-editable ToDo (table).
        Removing the selection removes all editable
        VisiblePositions from the root.  Then, the creation
        of mergeDestination fails, and using it causes a crash.

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::mergeParagraphs):
        Nil-check mergeDestination to avoid crashing and
        also insert a break in that case at m_upstreamStart,
        so that we can create a valid mergeDestination and
        perform the merge.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Adele Peterson.
ggaren [Fri, 6 Apr 2007 18:36:26 +0000 (18:36 +0000)]
    Rubber stamped by Adele Peterson.

        * kjs/ExecState.h: Removed obsolete forward/friend declaration of
        RuntimeMethodImp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by.
kmccullo [Fri, 6 Apr 2007 17:47:06 +0000 (17:47 +0000)]
    Reviewed by.

        - Fixing a test failure.

        * http/tests/misc/iframe-invalid-source-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoVersioning and ChangeLog markers.
bdash [Fri, 6 Apr 2007 16:55:12 +0000 (16:55 +0000)]
Versioning and ChangeLog markers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mark Rowe.
thatcher [Fri, 6 Apr 2007 16:29:19 +0000 (16:29 +0000)]
    Reviewed by Mark Rowe.

        Adds a build phase script that ensures WebKit's version dosen't end in a 4.
        If our version ends in 4, some sites might think we are Netscape 4 in their
        user agent checks.

        * Configurations/Version.xcconfig:
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-06 Mitz Pettel <mitz@webkit.org>
bdash [Fri, 6 Apr 2007 14:58:41 +0000 (14:58 +0000)]
2007-04-06  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Oliver.

        Eliminate PlatformMouseEvent::currentEvent.

        No test possible (no change to functionality).

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleDrag):
        * platform/PlatformMouseEvent.h:
        * platform/gdk/TemporaryLinkStubs.cpp:
        * platform/mac/PlatformMouseEventMac.mm:
        (WebCore::PlatformMouseEvent::PlatformMouseEvent):
        * platform/qt/PlatformMouseEventQt.cpp:
        * platform/win/TemporaryLinkStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix typo in ChangeLog.
bdash [Fri, 6 Apr 2007 14:56:25 +0000 (14:56 +0000)]
Fix typo in ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-05 Oliver Hunt <oliver@apple.com>
oliver [Fri, 6 Apr 2007 06:45:53 +0000 (06:45 +0000)]
2007-04-05  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej.
WebCore:
        Fix for rdar://problem/4849948 -- JSCanvasRenderingContext2D::drawImage
        crashes when given invalid arguments.

        JSCanvasRenderingContext2D frequently casts from JSValue* to JSObject*
        and then checks isObject *after* the cast.  JSObject::isObject is unsafe
        if applied to a JSImmediate value (null, undefined, etc).  This patch
        corrects the logic in a number of places by performing the isObject check
        before casting to JSObject.

        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        (WebCore::JSCanvasRenderingContext2D::drawImage):
        (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
        (WebCore::JSCanvasRenderingContext2D::createPattern):

LayoutTests:
        Layout tests for rdar://problem/4849948
        Make sure we don't crash when passing invalid args to Canvas::drawImage

        * fast/canvas/drawImage-with-invalid-args-expected.checksum: Added.
        * fast/canvas/drawImage-with-invalid-args-expected.png: Added.
        * fast/canvas/drawImage-with-invalid-args-expected.txt: Added.
        * fast/canvas/drawImage-with-invalid-args.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Fri, 6 Apr 2007 05:25:10 +0000 (05:25 +0000)]
LayoutTests:

        Reviewed by Oliver.

        Test for <rdar://problem/4965597> REGRESSION: mouseup doesn't fire for slider (causes it to always default to max)

        * fast/forms/slider-mouse-events-expected.txt: Added.
        * fast/forms/slider-mouse-events.html: Added.

WebCore:

        Reviewed by Oliver.

        Fix for <rdar://problem/4965597> REGRESSION: mouseup doesn't fire for slider (causes it to always default to max)

        Test: fast/forms/slider-mouse-events.html

        * page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent):
        Since the actual target node of the event can't be a shadow node, set the target node to the capturing node before adjusting it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
andersca [Fri, 6 Apr 2007 03:05:48 +0000 (03:05 +0000)]
LayoutTests:

        Reviewed by Adam.

        <rdar://problem/5083023>
        REGRESSION: In Real Player (10.1.0), video continues to play after closing window

        Add a test where a window containing a plugin is opened and then closed. The window is closed
        without calling -[WebView close].

        * plugins/open-and-close-window-with-plugin-expected.txt: Added.
        * plugins/open-and-close-window-with-plugin.html: Added.
        * plugins/resources/open-and-close-window-with-plugin.html: Added.

WebKit:

        Reviewed by Adam.

        <rdar://problem/5083023>
        REGRESSION: In Real Player (10.1.0), video continues to play after closing window

        This broke in revision 18422 because now the plugin isn't stopped when the window is closed. Since the window is retained
        by the plugin view for as long as it is running (so that removeTrackingRect works even though the window has been closed),
        we would end up with a reference cycle (NSWindow -> WebView -> PluginView -> NSWindow) and stopping the plug-in when the window
        was closed would break that cycle.

        Applications that call -[WebView close] when closing aren't affected, but RealPlayer doesn't do this.

        The bug that 18422 was supposed to fix was fixed by 19275, which is why it's safe to add back the check.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView addWindowObservers]):
        (-[WebBaseNetscapePluginView removeWindowObservers]):
        (-[WebBaseNetscapePluginView windowWillClose:]):

WebKitTools:

        Reviewed by Adam.

        Add support for opening new windows in DumpRenderTree.

        (+[LayoutTestController isSelectorExcludedFromWebScript:]):
        (+[LayoutTestController webScriptNameForSelector:]):
        (-[LayoutTestController setCallCloseOnWebViews:]):
        (-[LayoutTestController setCanOpenWindows]):
        Add two new methods callable from JavaScript. setCanOpenWindows controls whether a test
        can open new windows, and setCallCloseOnWebViews controls whether -[WebView close] should be called on
        web views that are about to be closed.

        (runTest):
        Make sure that only the main window is around when a test has finished running.

        (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
        (-[DumpRenderTreeWindow dealloc]):
        Manage the set of windows.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
        * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
        (NPP_Destroy):
        Add a "logDestroy" property which controls whether plugins should print when they are destroyed or not.

        * DumpRenderTree/UIDelegate.m:
        (-[UIDelegate webView:createWebViewWithRequest:]):
        Create new windows.

        (-[UIDelegate webViewClose:]):
        Close windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
andersca [Fri, 6 Apr 2007 01:46:42 +0000 (01:46 +0000)]
    Reviewed by Maciej.

        Move WebView and NSWindow creation to a separate function in preparation of supporting opening new
        windows in DRT.

        * DumpRenderTree/DumpRenderTree.m:
        (createWebView):
        (dumpRenderTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
kmccullo [Fri, 6 Apr 2007 01:05:58 +0000 (01:05 +0000)]
LayoutTests:

        Reviewed by Darin.

        - Now we add a console message when local resources are blocked.

        * http/tests/security/local-CSS-from-remote-expected.txt:
        * http/tests/security/local-JavaScript-from-remote-expected.txt:
        * http/tests/security/local-iFrame-from-remote-expected.txt:
        * http/tests/security/local-image-from-remote-expected.txt:

WebCore:

        Reviewed by Darin.

        - Added reportLocalLoadFailed to FrameLoader to send an error to the console when
        calls to canLoad fail.

        * loader/Cache.cpp:
        (WebCore::Cache::requestResource):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadSubframe):
        (WebCore::FrameLoader::loadPlugin):
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::reportLocalLoadFailed):
        * loader/FrameLoader.h:
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::create):

WebKit:

        Reviewed by Darin.

        - Moved registerURLSchemeAsLocal to the public API.

        * WebView/WebView.h:
        * WebView/WebView.mm:
        (+[WebView registerURLSchemeAsLocal:]):
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
adele [Fri, 6 Apr 2007 00:42:03 +0000 (00:42 +0000)]
    Reviewed by Maciej.

        Add text-align: -webkit-auto for form controls.  Buttons already override this property to center their text.

        * css/html4.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by darin.
kjk [Thu, 5 Apr 2007 22:52:38 +0000 (22:52 +0000)]
    Reviewed by darin.

        Coverity fix. Coverity says:
        "Event check_after_deref: Pointer "dateString" dereferenced before NULL check"

        * kjs/date_object.cpp:
        (KJS::parseDate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by darin.
kjk [Thu, 5 Apr 2007 22:50:02 +0000 (22:50 +0000)]
    Reviewed by darin.

        Coverity fix. Coverity says:
        "Event check_after_deref: Pointer "re" dereferenced before NULL check"

        * pcre/pcre_study.c:
        (pcre_study):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by darin.
kjk [Thu, 5 Apr 2007 22:45:24 +0000 (22:45 +0000)]
    Reviewed by darin.

        Coverity fixes. Coverity says:
        "Event leaked_storage: Returned without freeing storage "buffer""
        and:
        "Event leaked_storage: Returned without freeing storage "script""

        * kjs/testkjs.cpp:
        (doIt):
        (createStringWithContentsOfFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by rwlbuis.
kjk [Thu, 5 Apr 2007 22:42:37 +0000 (22:42 +0000)]
    Reviewed by rwlbuis.

        Coverity fix. Coverity says:
        "Event var_deref_model: Variable "page" tracked as NULL was passed to a function that dereferences it."

        * platform/Font.cpp:
        (WebCore::Font::glyphDataForCharacter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by darin.
kjk [Thu, 5 Apr 2007 22:38:20 +0000 (22:38 +0000)]
    Reviewed by darin.

        Coverity fix. Coverity says:
        "Event var_deref_model: Variable "unicode" tracked as NULL was passed to a
        function that dereferences it."

        * platform/DeprecatedString.cpp:
        (WebCore::DeprecatedString::DeprecatedString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by darin.
kjk [Thu, 5 Apr 2007 22:33:48 +0000 (22:33 +0000)]
    Reviewed by darin.

        Coverity fix: in single-threaded case currentThreadIsMainThread is always true
        so the code in if (!currentThreadIsMainThread) cannot possibly be reached
        and Coverity complains about dead code.

        * kjs/collector.cpp:
        (KJS::Collector::collect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
adele [Thu, 5 Apr 2007 21:26:09 +0000 (21:26 +0000)]
    Reviewed by Hyatt.

        Fix for <rdar://problem/5113593> REGRESSION: Search fields in RSS pages don't show ibeam cursor

        * css/html4.css: Set the cursor values explicitly for input, textarea (to auto), & select (to default).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for <rdar://problem/5078866> tables should only reset text-align
hyatt [Thu, 5 Apr 2007 21:21:14 +0000 (21:21 +0000)]
    Fix for <rdar://problem/5078866> tables should only reset text-align
        in quirks mode.

        Reviewed by beth

        * css/html4.css:
        * css/quirks.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fixing typo that's crashing.
adele [Thu, 5 Apr 2007 20:36:33 +0000 (20:36 +0000)]
    Fixing typo that's crashing.

        * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
          Use evt instead of null variable k.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
adele [Thu, 5 Apr 2007 20:30:52 +0000 (20:30 +0000)]
    Reviewed by Hyatt.

        Fix for <rdar://problem/5021500> Cursor should stay as pointer when slider is being dragged

        Don't set the selection ibeam cursor when there's a node that's capturing mouse events.

        * page/EventHandler.cpp:
        (WebCore::selectCursor):
        (WebCore::EventHandler::handleMouseMoveEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Beth Dakin.
ggaren [Thu, 5 Apr 2007 19:33:52 +0000 (19:33 +0000)]
    Reviewed by Beth Dakin.

        More clean-up while fixing <rdar://problem/5112273> REGRESSION(TOT):
        Reproducible crash loading an old version of amazon.com as a web archive

        Layout tests pass.

        Removed more superfluous document NULL checks. (Node::document() never
        returns NULL, and it asserts as much.)

        Merged some duplicate editing code into a static inline function.

        * page/mac/WebCoreFrameBridge.mm:
        (updateRenderingForBindings): Removed superfluous static_cast.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
adele [Thu, 5 Apr 2007 18:41:04 +0000 (18:41 +0000)]
    Reviewed by Darin.

        A little cleanup from my last checkin.  Always check if an Event is really a MouseEvent or a KeyboardEvent
        before casting it.

        * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
        (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
        * html/HTMLTextFieldInnerElement.cpp:
        (WebCore::HTMLSearchFieldResultsButtonElement::defaultEventHandler):
        (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler):
        * ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
        * page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent):
        * rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize):
        * rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Beth Dakin.
ggaren [Thu, 5 Apr 2007 17:48:23 +0000 (17:48 +0000)]
    Reviewed by Beth Dakin.

        Some clean-up while fixing <rdar://problem/5112273> REGRESSION(TOT):
        Reproducible crash loading an old version of amazon.com as a web archive

        Removed superfluous document NULL checks. (Node::document() never returns
        NULL, and it asserts as much.)

        Removed duplicate implementation of displayString.

        Layout tests pass.

        * bindings/objc/DOMInternal.h:
        * bindings/objc/DOMInternal.mm:
        * html/HTMLGenericFormElement.cpp:
        (WebCore::HTMLGenericFormElement::supportsFocus):
        * html/HTMLPlugInElement.cpp:
        (WebCore::HTMLPlugInElement::createNPObject):
        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::checkOrEnableIfNeeded):
        * rendering/HitTestResult.cpp:
        (WebCore::displayString):
        * rendering/HitTestResult.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateHoverActiveState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-05 Oliver Hunt <oliver@apple.com>
oliver [Thu, 5 Apr 2007 10:20:22 +0000 (10:20 +0000)]
2007-04-05  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam.

WebCore:
        Fix rdar://problem/5030934 -- landscape PDFs embedded as an image are cut off
        also fixes scaling of pdf images

        PDFDocumentImage was not accounting for page rotation in a number of places

        * platform/graphics/cg/PDFDocumentImage.cpp:
        (WebCore::PDFDocumentImage::size):
          we need to account for rotation of the pdf image effecting our bounds
        (WebCore::PDFDocumentImage::draw):
          When compensating for flipped coords we need to use the correct rect for the
          coordinate space.  We can't pass size() to CGContextDrawPDFDocument as it
          returns the rotated bounds now -- this is also save the old
          FloatSize -> IntSize -> FloatSize conversions.
LayoutTests:
        Testcase for landscape pdfs as image

        rdar://problem/5030934 -- landscape PDFs embedded as an image are cut off

        * fast/images/pdf-as-image-landscape-expected.txt: Added.
        * fast/images/pdf-as-image-landscape.html: Added.
        * fast/images/resources/pdf_test_landscape.pdf: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-05 Mark Malone <markmalone@mac.com>
bdash [Thu, 5 Apr 2007 05:24:58 +0000 (05:24 +0000)]
2007-04-05  Mark Malone  <markmalone@mac.com>

        Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=13273
        Bug 13273: DOM Interfaces Nav link should go somewhere more useful

        * nav.inc: Link directly to the hierarchy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Thu, 5 Apr 2007 04:40:03 +0000 (04:40 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=13278
        REGRESSION: cannot change SELECT option

        Test: fast/forms/option-change-single-selected.html

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::setSelectedIndex): If multiple selection is not allowed,
        be sure to deselect the previous option.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
adele [Thu, 5 Apr 2007 01:05:49 +0000 (01:05 +0000)]
    Reviewed by Oliver.

        Fix for <rdar://5105009> Prepare for fix to send mousedown and mouseup (but not click) events when right-clicking

        * page/EventHandler.cpp: Don't ever send click events for right-clicks.
        (WebCore::EventHandler::handleMouseDoubleClickEvent):
        (WebCore::EventHandler::handleMouseReleaseEvent):

        Check that the mousedown and mouseup are not with the right button before performing default behavior.
        * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
        * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
        (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
        * html/HTMLTextFieldInnerElement.cpp:
        (WebCore::HTMLSearchFieldResultsButtonElement::defaultEventHandler):
        (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler):
        * ksvg2/svg/SVGAElement.cpp:(WebCore::SVGAElement::defaultEventHandler):
        * rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize):
        * rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Wed, 4 Apr 2007 20:49:52 +0000 (20:49 +0000)]
LayoutTests:

        Reviewed by darin

        <rdar://problem/5026848> Can cut/delete To Do subunits

        This tests to make sure that non-editable content
        that is in both the start and end editable roots
        is removed:
        * editing/deleting/5026848-1-expected.checksum: Added.
        * editing/deleting/5026848-1-expected.png: Added.
        * editing/deleting/5026848-1-expected.txt: Added.
        * editing/deleting/5026848-1.html: Added.
        This tests to make sure that non-editable content
        that is not in both the start and end editable roots
        is not removed:
        * editing/deleting/5026848-2-expected.checksum: Added.
        * editing/deleting/5026848-2-expected.png: Added.
        * editing/deleting/5026848-2-expected.txt: Added.
        * editing/deleting/5026848-2.html: Added.
        This tests to make sure that editable regions
        that are not in both the start and end editable roots
        are cleared (not removed, unless they are in another
        editable region):
        * editing/deleting/5026848-3-expected.checksum: Added.
        * editing/deleting/5026848-3-expected.png: Added.
        * editing/deleting/5026848-3-expected.txt: Added.
        * editing/deleting/5026848-3.html: Added.

WebCore:

        Reviewed by darin

        <rdar://problem/5026848> Can cut/delete ToDo subunits

        We were removing non-editable content during a delete.

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::initializePositionData):
        Set m_startRoot and m_endRoot.
        (WebCore::DeleteSelectionCommand::removeNode): If a node
        is not inside both the start and end roots, remove it only
        if it is in editable content.
        * editing/DeleteSelectionCommand.h: Added m_startRoot and
        m_endRoot, the editable roots that contain the start and end
        of the selection, respectively.  We consult these every
        time we remove a node, and don't want to recompute them
        on every call to removeNode().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John.
andersca [Wed, 4 Apr 2007 17:30:16 +0000 (17:30 +0000)]
    Reviewed by John.

        <rdar://problem/5107536>
        http://bugs.webkit.org/show_bug.cgi?id=13264
        REGRESSION: Crash when canceling about:blank in Activity viewer

        * WebView/WebFrame.mm:
        (-[WebFrame stopLoading]):
        Add a null check for the frame loader - it can be null when the frame has been disconnected
        from the web page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoTurn's out Brady's not the only one who can rewrite history!
andersca [Wed, 4 Apr 2007 16:47:10 +0000 (16:47 +0000)]
Turn's out Brady's not the only one who can rewrite history!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
kmccullo [Wed, 4 Apr 2007 02:12:39 +0000 (02:12 +0000)]
    Reviewed by Adam.

        - Testing a post-commit hook.

        * JavaScriptCore.vcproj/testkjs/testkjs.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
andersca [Wed, 4 Apr 2007 01:32:00 +0000 (01:32 +0000)]
JavaScriptCore:

        Reviewed by Adam.

        <rdar://problem/5107534>
        http://bugs.webkit.org/show_bug.cgi?id=13265
        REGRESSION: Crash in KJS::Bindings::convertValueToNPVariant

        * bindings/NP_jsobject.cpp:
        (_NPN_InvokeDefault):
        Return false if the object isn't a function.

LayoutTests:

        Reviewed by Adam.

        <rdar://problem/5107534>
        http://bugs.webkit.org/show_bug.cgi?id=13265
        REGRESSION: Crash in KJS::Bindings::convertValueToNPVariant

        * plugins/netscape-invoke-default.html:
        Test calling NPN_InvokeDefault on an object that isn't a function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
andersca [Wed, 4 Apr 2007 00:22:06 +0000 (00:22 +0000)]
LayoutTests:

        Reviewed by Darin.

        <rdar://problem/5028178>
        Crash occurs at WebCore::FrameLoader::activeDocumentLoader() after loading Froggster widget

        * plugins/get-url-that-the-resource-load-delegate-will-disallow-expected.txt: Added.
        * plugins/get-url-that-the-resource-load-delegate-will-disallow.html: Added.

WebKit:

        Reviewed by Darin.

        <rdar://problem/5028178>
        Crash occurs at WebCore::FrameLoader::activeDocumentLoader() after loading Froggster widget

        * Plugins/WebNetscapePluginStream.mm:
        (-[WebNetscapePluginStream start]):
        If load returns no the plugin loader has already been removed by the didFail callback.

WebKitTools:

        Reviewed by Darin.

        Add the notion of a "disallowed URL", which the resource loader won't allow to be loaded.

        * DumpRenderTree/DumpRenderTree.h:
        * DumpRenderTree/DumpRenderTree.m:
        (dumpRenderTree):
        (+[LayoutTestController isSelectorExcludedFromWebScript:]):
        (+[LayoutTestController webScriptNameForSelector:]):
        (-[LayoutTestController addDisallowedURL:]):
        (runTest):
        * DumpRenderTree/ResourceLoadDelegate.m:
        (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for <rdar://problem/5108896>, make sure the assert for setEncodedSize
hyatt [Tue, 3 Apr 2007 23:31:15 +0000 (23:31 +0000)]
    Fix for <rdar://problem/5108896>, make sure the assert for setEncodedSize
        deals with the error case.

        Reviewed by andersca

        * loader/CachedResource.cpp:
        (WebCore::CachedResource::setEncodedSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Dave Hyatt.
andersca [Tue, 3 Apr 2007 23:22:45 +0000 (23:22 +0000)]
    Reviewed by Dave Hyatt.

        * loader/ImageDocument.cpp:
        Don't call error() in stopParsing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by darin
justing [Tue, 3 Apr 2007 22:50:34 +0000 (22:50 +0000)]
    Reviewed by darin

        <http://bugs.webkit.org/show_bug.cgi?id=13268>
        Make editing/selection/drag-in-iframe.html valid and deterministic

        * editing/resources/select-and-drag-iframe.html: Removed.
        * editing/selection/drag-in-iframe-expected.checksum:
        * editing/selection/drag-in-iframe-expected.png:
        * editing/selection/drag-in-iframe-expected.txt:
        * editing/selection/drag-in-iframe.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Updated results for recent change to always lighten disabled text color for...
adele [Tue, 3 Apr 2007 22:07:43 +0000 (22:07 +0000)]
    Updated results for recent change to always lighten disabled text color for black text.

        * fast/forms/input-disabled-color-expected.checksum:
        * fast/forms/input-disabled-color-expected.png:
        * fast/forms/input-disabled-color-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Tue, 3 Apr 2007 21:57:54 +0000 (21:57 +0000)]
LayoutTests:

        Reviewed by darin

        <rdar://problem/5107422>
        TOT REGRESSION: Delete key fails to delete text, and cursor disappears in Mail.app

        moveParagraphs no longer calls shouldInsert:
        * editing/deleting/delete-3857753-fix-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
        * editing/deleting/delete-block-merge-contents-001-expected.txt:
        * editing/deleting/delete-block-merge-contents-002-expected.txt:
        * editing/deleting/delete-block-merge-contents-003-expected.txt:
        * editing/deleting/delete-block-merge-contents-004-expected.txt:
        * editing/deleting/delete-block-merge-contents-005-expected.txt:
        * editing/deleting/delete-block-merge-contents-006-expected.txt:
        * editing/deleting/delete-block-merge-contents-007-expected.txt:
        * editing/deleting/delete-block-merge-contents-008-expected.txt:
        * editing/deleting/delete-block-merge-contents-009-expected.txt:
        * editing/deleting/delete-block-merge-contents-010-expected.txt:
        * editing/deleting/delete-block-merge-contents-012-expected.txt:
        * editing/deleting/delete-block-merge-contents-013-expected.txt:
        * editing/deleting/delete-block-merge-contents-014-expected.txt:
        * editing/deleting/delete-block-merge-contents-015-expected.txt:
        * editing/deleting/delete-block-merge-contents-016-expected.txt:
        * editing/deleting/delete-block-merge-contents-017-expected.txt:
        * editing/deleting/delete-block-merge-contents-018-expected.txt:
        * editing/deleting/delete-block-merge-contents-019-expected.txt:
        * editing/deleting/delete-block-merge-contents-020-expected.txt:
        * editing/deleting/delete-block-merge-contents-021-expected.txt:
        * editing/deleting/delete-block-merge-contents-022-expected.txt:
        * editing/deleting/delete-block-table-expected.txt:
        * editing/deleting/delete-br-010-expected.txt:
        * editing/deleting/delete-line-002-expected.txt:
        * editing/deleting/delete-line-004-expected.txt:
        * editing/deleting/delete-line-006-expected.txt:
        * editing/deleting/delete-line-007-expected.txt:
        * editing/deleting/delete-line-008-expected.txt:
        * editing/deleting/delete-line-011-expected.txt:
        * editing/deleting/delete-line-012-expected.txt:
        * editing/deleting/delete-listitem-001-expected.txt:
        * editing/deleting/delete-to-end-of-paragraph-expected.txt:
        * editing/deleting/merge-different-styles-expected.txt:
        * editing/deleting/merge-no-br-expected.txt:
        * editing/deleting/pruning-after-merge-1-expected.txt:
        * editing/deleting/pruning-after-merge-2-expected.txt:
        * editing/execCommand/create-list-from-range-selection-expected.txt:
        * editing/execCommand/create-list-with-hr-expected.txt:
        * editing/execCommand/format-block-expected.txt:
        * editing/execCommand/format-block-from-range-selection-expected.txt:
        * editing/execCommand/format-block-with-braces-expected.txt:
        * editing/execCommand/format-block-with-trailing-br-expected.txt:
        * editing/execCommand/indent-list-item-expected.txt:
        * editing/execCommand/indent-selection-expected.txt:
        * editing/execCommand/insert-list-and-stitch-expected.txt:
        * editing/execCommand/insert-list-with-id-expected.txt:
        * editing/execCommand/nsresponder-indent-expected.txt:
        * editing/execCommand/outdent-selection-expected.txt:
        * editing/execCommand/queryCommandState-01-expected.txt:
        * editing/execCommand/remove-list-1-expected.txt:
        * editing/execCommand/remove-list-from-range-selection-expected.txt:
        * editing/execCommand/remove-list-item-1-expected.txt:
        * editing/execCommand/remove-list-items-expected.txt:
        * editing/execCommand/switch-list-type-expected.txt:
        * editing/inserting/insert-3907422-fix-expected.txt:
        * editing/inserting/insert-div-026-expected.txt:
        * editing/inserting/multiple-lines-selected-expected.txt:
        * editing/inserting/return-key-with-selection-001-expected.txt:
        * editing/inserting/return-key-with-selection-002-expected.txt:
        * editing/pasteboard/4076267-2-expected.txt:
        * editing/pasteboard/4700297-expected.txt:
        * editing/pasteboard/8145-3-expected.txt:
        * editing/pasteboard/display-block-on-spans-expected.txt:
        * editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
        * editing/pasteboard/interchange-newline-1-expected.txt:
        * editing/pasteboard/interchange-newline-2-expected.txt:
        * editing/pasteboard/merge-after-delete-1-expected.txt:
        * editing/pasteboard/merge-after-delete-2-expected.txt:
        * editing/pasteboard/merge-after-delete-expected.txt:
        * editing/pasteboard/merge-end-1-expected.txt:
        * editing/pasteboard/merge-end-2-expected.txt:
        * editing/pasteboard/merge-end-3-expected.txt:
        * editing/pasteboard/merge-end-4-expected.txt:
        * editing/pasteboard/merge-end-5-expected.txt:
        * editing/pasteboard/merge-end-blockquote-expected.txt:
        * editing/pasteboard/merge-end-borders-expected.txt:
        * editing/pasteboard/merge-end-list-expected.txt:
        * editing/pasteboard/merge-end-table-expected.txt:
        * editing/pasteboard/paste-line-endings-007-expected.txt:
        * editing/pasteboard/paste-line-endings-008-expected.txt:
        * editing/pasteboard/paste-line-endings-009-expected.txt:
        * editing/pasteboard/paste-match-style-001-expected.txt:
        * editing/pasteboard/paste-text-002-expected.txt:
        * editing/pasteboard/paste-text-003-expected.txt:
        * editing/pasteboard/paste-text-004-expected.txt:
        * editing/pasteboard/paste-text-005-expected.txt:
        * editing/pasteboard/paste-text-006-expected.txt:
        * editing/pasteboard/paste-text-008-expected.txt:
        * editing/pasteboard/paste-text-009-expected.txt:
        * editing/pasteboard/paste-text-010-expected.txt:
        * editing/pasteboard/smart-paste-001-expected.txt:
        * editing/pasteboard/smart-paste-002-expected.txt:
        * editing/pasteboard/smart-paste-003-expected.txt:
        * editing/pasteboard/smart-paste-004-expected.txt:
        * editing/pasteboard/smart-paste-005-expected.txt:
        * editing/pasteboard/smart-paste-006-expected.txt:
        * editing/pasteboard/smart-paste-007-expected.txt:
        * editing/pasteboard/smart-paste-008-expected.txt:
        * editing/style/create-block-for-style-001-expected.txt:
        * editing/style/create-block-for-style-002-expected.txt:
        * editing/style/create-block-for-style-003-expected.txt:
        * editing/style/create-block-for-style-004-expected.txt:
        * editing/style/create-block-for-style-007-expected.txt:
        * editing/style/create-block-for-style-009-expected.txt:
        * editing/style/create-block-for-style-010-expected.txt:
        * editing/style/create-block-for-style-011-expected.txt:
        * editing/style/create-block-for-style-012-expected.txt:
        * editing/style/create-block-for-style-013-expected.txt:
        * editing/style/smoosh-styles-001-expected.txt:
        * editing/style/smoosh-styles-002-expected.txt:
        * editing/style/style-boundary-005-expected.txt:
        * editing/unsupported-content/list-delete-001-expected.txt:

WebCore:

        Reviewed by darin

        <rdar://problem/5107422>
        TOT REGRESSION: Delete key fails to delete text, and cursor disappears in Mail.app
        <rdar://problem/5107413>
        TOT REGRESSION: Crash deleting text in email (infinite recursion in shouldInsertNode)

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraphs):
        Back out the call to shouldInsert until we
        add WebViewInsertActionMoved, because Mail returns
        NO from shouldInsert for WebViewInsertActionPasted
        to override our Paste operation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
andersca [Tue, 3 Apr 2007 21:39:53 +0000 (21:39 +0000)]
LayoutTests:

        Reviewed by Mitz.

        Add tests for innerWidth/innerHeight and clientWidth/clientHeight in quirks mode.

        Modify the strict clientWidth/clientHeight test to test the behavior with scrollbars visible.

        * fast/dom/client-width-height-quirks-expected.txt: Added.
        * fast/dom/client-width-height-quirks.html: Added.
        * fast/dom/client-width-height.html:
        * fast/dom/inner-width-height-expected.txt: Added.
        * fast/dom/inner-width-height.html: Added.

WebCore:

        Reviewed by Mitz.

        Make window.innerWidth/innerHeight include the size of any present scrollbar to match Firefox.

        Make document.body.clientWidth/clientHeight return the width/height of the visible content when in
        quirks mode to match WinIE.

        * bindings/js/kjs_window.cpp:
        (KJS::Window::getValueProperty):
        Return the width and height of the scroll view, not the visible width and height.

        * dom/Element.cpp:
        (WebCore::Element::clientWidth):
        (WebCore::Element::clientHeight):
        Return the visible size if the element is the body element and we're in quirks mode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
adele [Tue, 3 Apr 2007 19:22:22 +0000 (19:22 +0000)]
    Reviewed by Darin.

        Updated fix for <rdar://problem/5107095> REGRESSION: disabled text color calculations are slowing down launchtime measurements

        * platform/graphics/Color.cpp: Moved optimization for lightening black and darkening white into the Color class.
        (WebCore::Color::light):
        (WebCore::Color::dark):
        * rendering/RenderTextControl.cpp: (WebCore::disabledTextColor): Skip the difference calculation for black text, which will always be lightened.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim.
andersca [Tue, 3 Apr 2007 18:35:35 +0000 (18:35 +0000)]
    Reviewed by Tim.

        <rdar://problem/4649516>
        Turn off slow script dialog or crank up time that makes it come up

        * bindings/js/kjs_binding.cpp:
        (KJS::ScriptInterpreter::ScriptInterpreter):
        Increase the timeout to 10 seconds to match Firefox.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-03 Mitz Pettel <mitz@webkit.org>
bdash [Tue, 3 Apr 2007 12:56:28 +0000 (12:56 +0000)]
2007-04-03  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13251
          editing/style/fontsize-1.html fails intermittently when run multiple times on Intel, generates incorrect DOM

        Covered by existing editing tests.

        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::getFloatValue): Added ASSERTs that the requested conversion
        is from a scalar type to a scalar type. The intermittent failures in the test were
        the result of trying to convert an identifier type to a scalar type.
        * editing/ApplyStyleCommand.cpp:
        (WebCore::StyleChange::checkForLegacyHTMLStyleChange): Added a check that the
        font-size property value is an absolute length. If it is not (such as in the case
        of relative units or keywords like "x-large"), then no corresponding 'size' attribute
        will be generated for legacy HTML.

2007-04-03  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - updated results for http://bugs.webkit.org/show_bug.cgi?id=13251
          editing/style/fontsize-1.html fails intermittently when run multiple times on Intel, generates incorrect DOM

        * editing/style/block-style-004-expected.txt:
        * editing/style/block-style-005-expected.txt:
        * editing/style/block-style-006-expected.txt:
        * editing/style/fontsize-1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-03 Mitz Pettel <mitz@webkit.org>
bdash [Tue, 3 Apr 2007 12:51:55 +0000 (12:51 +0000)]
2007-04-03  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13218
          <rdar://problem/5095977>
          Reproducible crash after call to window.close()

        * manual-tests/stale-currentEvent.html: Added.
        * page/EventHandler.cpp:
        (WebCore::EventHandler::hoverTimerFired): Instead of faking a mouse event,
        just hit-test the last mouse event coordinates and update for hover state
        changes. This eliminates the use of currentEvent, which can be a non-mouse
        event or even a stale event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-03 Mark Rowe <mrowe@apple.com>
bdash [Tue, 3 Apr 2007 11:24:41 +0000 (11:24 +0000)]
2007-04-03  Mark Rowe  <mrowe@apple.com>

        Reviewed by Antti.

        * BuildSlaveSupport/build-launcher-dmg: Use bzip2 compression in nightly build disk images rather than gzip.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
adele [Tue, 3 Apr 2007 05:54:33 +0000 (05:54 +0000)]
    Reviewed by Maciej.

        Fix for <rdar://problem/5107095> REGRESSION: disabled text color calculations are slowing down launchtime measurements

        Hardcode disabled text colors for the most common cases- black and white.

        * rendering/RenderTextControl.cpp: (WebCore::disabledTextColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for <rdar://problem/5105784>, assertion failure in cache. Encoded sizes...
hyatt [Tue, 3 Apr 2007 01:11:35 +0000 (01:11 +0000)]
    Fix for <rdar://problem/5105784>, assertion failure in cache.  Encoded sizes were being set to
        garbage by accident because of a mismatch between derived class and base class constructors.  This
        patch cleans all of this up and gets rid of expiration date as a concept separate from the response.

        Reviewed by anders

        * dom/Document.cpp:
        (WebCore::Document::processHttpEquiv):
        * html/HTMLImageLoader.cpp:
        (WebCore::HTMLImageLoader::updateFromElement):
        * loader/Cache.cpp:
        (WebCore::createResource):
        (WebCore::Cache::requestResource):
        * loader/Cache.h:
        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
        * loader/CachedCSSStyleSheet.h:
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::CachedImage):
        * loader/CachedImage.h:
        * loader/CachedResource.cpp:
        (WebCore::CachedResource::CachedResource):
        (WebCore::CachedResource::finish):
        * loader/CachedResource.h:
        * loader/CachedScript.cpp:
        (WebCore::CachedScript::CachedScript):
        * loader/CachedScript.h:
        * loader/CachedXBLDocument.cpp:
        (WebCore::CachedXBLDocument::CachedXBLDocument):
        * loader/CachedXBLDocument.h:
        * loader/CachedXSLStyleSheet.cpp:
        (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
        * loader/CachedXSLStyleSheet.h:
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::DocLoader):
        (WebCore::DocLoader::requestResource):
        * loader/DocLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
antti [Tue, 3 Apr 2007 01:01:09 +0000 (01:01 +0000)]
    Reviewed by Hyatt.

        Render tree memory savings, part 3

        These changes shrink all RenderBlocks by additional 28 bytes. Together with parts 1 and 2
        RenderBlock goes from 172 bytes to 128 bytes, a saving of 26%.

        - Pack bitfields together in RenderFlow
        - Move top/bottom min/max margin values to a struct that is only allocated in case these
          variables have non default values. Usually this is <5% of all blocks.
        - Move rarely used column variables to hash

        * rendering/RenderBlock.cpp:
        (WebCore::ColumnInfo::ColumnInfo):
        (WebCore::RenderBlock::RenderBlock):
        (WebCore::RenderBlock::~RenderBlock):
        (WebCore::RenderBlock::layoutBlock):
        (WebCore::RenderBlock::collapseMargins):
        (WebCore::RenderBlock::clearFloatsIfNeeded):
        (WebCore::RenderBlock::setCollapsedBottomMargin):
        (WebCore::RenderBlock::layoutBlockChildren):
        (WebCore::RenderBlock::paintColumns):
        (WebCore::RenderBlock::paintObject):
        (WebCore::RenderBlock::fillSelectionGaps):
        (WebCore::RenderBlock::lowestPosition):
        (WebCore::RenderBlock::rightmostPosition):
        (WebCore::RenderBlock::leftmostPosition):
        (WebCore::RenderBlock::nodeAtPoint):
        (WebCore::RenderBlock::hitTestColumns):
        (WebCore::RenderBlock::positionForCoordinates):
        (WebCore::RenderBlock::availableWidth):
        (WebCore::RenderBlock::calcColumnWidth):
        (WebCore::RenderBlock::setDesiredColumnCountAndWidth):
        (WebCore::RenderBlock::desiredColumnWidth):
        (WebCore::RenderBlock::desiredColumnCount):
        (WebCore::RenderBlock::columnRects):
        (WebCore::RenderBlock::layoutColumns):
        (WebCore::RenderBlock::adjustPointToColumnContents):
        (WebCore::RenderBlock::adjustRectForColumns):
        (WebCore::RenderBlock::setMaxTopMargins):
        (WebCore::RenderBlock::setMaxBottomMargins):
        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::maxTopMargin):
        (WebCore::RenderBlock::maxBottomMargin):
        (WebCore::RenderBlock::maxTopPosMargin):
        (WebCore::RenderBlock::maxTopNegMargin):
        (WebCore::RenderBlock::maxBottomPosMargin):
        (WebCore::RenderBlock::maxBottomNegMargin):
        (WebCore::RenderBlock::initMaxMarginValues):
        (WebCore::RenderBlock::MaxMargin::MaxMargin):
        (WebCore::RenderBlock::MaxMargin::topPosDefault):
        (WebCore::RenderBlock::MaxMargin::topNegDefault):
        (WebCore::RenderBlock::MaxMargin::bottomPosDefault):
        (WebCore::RenderBlock::MaxMargin::bottomNegDefault):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutBlock):
        * rendering/RenderFlow.h:
        (WebCore::RenderFlow::RenderFlow):
        (WebCore::RenderFlow::hasColumns):
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::RenderInline):
        * rendering/RenderInline.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
antti [Tue, 3 Apr 2007 00:22:30 +0000 (00:22 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        Test you don't crash when you have abs positioned elements inside rel inline.

        * fast/block/positioning/abs-inside-inline-rel-expected.checksum: Added.
        * fast/block/positioning/abs-inside-inline-rel-expected.png: Added.
        * fast/block/positioning/abs-inside-inline-rel-expected.txt: Added.
        * fast/block/positioning/abs-inside-inline-rel.html: Added.

WebCore:

        Reviewed by Hyatt.

        Fix asserts, these may also be called for rel positioned elements

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::setStaticX):
        (WebCore::RenderBox::setStaticY):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
andersca [Mon, 2 Apr 2007 23:49:03 +0000 (23:49 +0000)]
    Reviewed by Geoff.

        Fix crash when running plugins/destroy-stream-twice.html under GuardMalloc

        * Plugins/WebBaseNetscapePluginStream.h:
        * Plugins/WebBaseNetscapePluginStream.mm:
        (+[WebBaseNetscapePluginStream ownerForStream:]):
        (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]):
        (-[WebBaseNetscapePluginStream dealloc]):
        (-[WebBaseNetscapePluginStream finalize]):
        Change the streams hash map to contain an NPStream*, and change ownerForStream to take an NPStream*.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView destroyStream:reason:]):
        Check that the NPStream pointer is valid before accessing stream->ndata.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Throw in an assert to try to track down a problem where an image is being...
hyatt [Mon, 2 Apr 2007 23:41:57 +0000 (23:41 +0000)]
    Throw in an assert to try to track down a problem where an image is being set to a smaller encoded
        size.

        * loader/CachedResource.cpp:
        (WebCore::CachedResource::setEncodedSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-02 Ada Chan <adachan@apple.com>
adachan [Mon, 2 Apr 2007 22:29:45 +0000 (22:29 +0000)]
2007-04-02  Ada Chan  <adachan@apple.com>

        Reviewed by Adele.

        <rdar://5105331> Missing null check in Editor::execCommand
        Added null check.

        * editing/Editor.cpp:
        (WebCore::Editor::execCommand):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
darin [Mon, 2 Apr 2007 21:15:34 +0000 (21:15 +0000)]
    Reviewed by Geoff.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13026
          <rdar://problem/5061026> incomplete render of menu
          (assertion failing in -[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:])

        - fix http://bugs.webkit.org/show_bug.cgi?id=13120
          <rdar://problem/5080339> Plug-ins that draw through the QuickDraw interface may crash
          by hanging onto old GWorlds.

        - set clip path for CoreGraphics plug-ins in the same way we do for QuickDraw plug-ins
          this is a better fix for <rdar://problem/4939511> WebKit should set the the CG clip
          path for plug-ins that draw using Core Graphics

        Incorporates changes from a patch by Mark Ambachtsheer.

        Here are the changes:

            1) Don't try to use the offscreen code path if GGBitmapContextGetData returns 0.
            2) Handle kCGBitmapByteOrderDefault when computing the QD pixel format, even though
               we don't have any evidence that this happens in practice.
            3) Keep the GWorld around until we create a new one or the plug-in is destroyed.
            4) Use the GWorld pointer itself as a flag to indicate whether we are using an
               offscreen GWorld.
            5) Set up clipping for CoreGraphics in the same way we do for QuickDraw; remove an
               earlier attempt that handled CoreGraphics differently.

        * Plugins/WebBaseNetscapePluginView.h: Added a field named offscreenGWorld to hold
        the GWorld until it's needed.
        * Plugins/WebBaseNetscapePluginView.mm:
        (getQDPixelFormatForBitmapContext): Replaced QDPixelFormatFromCGBitmapInfo. Used the
        "get" prefix so we don't intrude on the QD namespace. Added code to handle the
        kCGBitmapByteOrderDefault case, although I'm not sure it will really come up in
        practice -- it wasn't really coming up in the buggy case.
        (getNPRect): Added helper functions. Used to make the code below clearer.
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Use getNPRect to
        streamline code. Use GetGWorld to save the port since we use SetGWorld to restore
        it later. Store the GWorld we create in the offscreenGWorld field and dispose the
        existing one. Don't treat the CGBitmapContext as an offscreen bitmap if it
        has a data pointer of 0. Set up the clip based on the result of
        -[NSView getRectsBeingDrawn:count] when setting up the port for CoreGraphics
        (after saving the port state).
        (-[WebBaseNetscapePluginView restorePortState:]): Remove now-unneeded code to
        destroy the offscreen GWorld, and simplified the code that restores the port so we
        don't need a separate case for offscreen.
        (-[WebBaseNetscapePluginView fini]): Renamed from freeAttributeKeysAndValues, since
        this method now does more than just the attributes. This is the shared method that
        does things needed in both dealloc and finalize. Added a call to DisposeGWorld here.
        (-[WebBaseNetscapePluginView dealloc]): Updated for name change.
        (-[WebBaseNetscapePluginView finalize]): Ditto.
        (-[WebBaseNetscapePluginView drawRect:]): Removed code to set clip. This is done in
        the saveAndSetNewPortStateForUpdate: method instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
andersca [Mon, 2 Apr 2007 19:33:50 +0000 (19:33 +0000)]
    * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
        Don't use #import in a header included by C files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Mon, 2 Apr 2007 18:23:42 +0000 (18:23 +0000)]
LayoutTests:

        Reviewed by darin

        <rdar://problem/5058163>
        Hitting return inserts a new line between two To Dos, but caret is position after second ToDo

        * editing/inserting/5058163-1-expected.checksum: Added.
        * editing/inserting/5058163-1-expected.png: Added.
        * editing/inserting/5058163-1-expected.txt: Added.
        * editing/inserting/5058163-1.html: Added.
        * editing/inserting/5058163-2-expected.checksum: Added.
        * editing/inserting/5058163-2-expected.png: Added.
        * editing/inserting/5058163-2-expected.txt: Added.
        * editing/inserting/5058163-2.html: Added.

WebCore:

        Reviewed by darin

        <rdar://problem/5058163>
        Hitting return inserts a new line between two To Dos, but caret is position after second ToDo

        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):
        Removed refPos, it was unused.
        Don't assume that upstream() moves to a different
        node.  This assumption caused the line break to
        be inserted *after* the caret and a bad position
        to be set (added a testcase).
        Use isStartOfParagraph instead of checking
        for the existence of a br because the line might
        be broken by a newline character in text that
        preserves newlines.  Paragraphs that are created
        in other ways, like with blocks, are handled
        above (added a testcase).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago 2007-04-02 David Harrison <harrison@apple.com>
harrison [Mon, 2 Apr 2007 17:36:20 +0000 (17:36 +0000)]
 2007-04-02  David Harrison  <harrison@apple.com>

        Reviewed by Darin.

        <rdar://problem/4906488> text attributes are not working for frame based web page

        Attribute handling now treats each WebArea as its own world, rather than sometimes
        referring back up to the top WebArea. e.g. getting/setting the selection now
        operates on the WebArea containing the WebCoreAXObject that is being messaged (self).
        The methods that sit above this and are able to go into arbitrary WebAreas
        are accessibilityFocusedUIElement and doAXTextMarkerForPosition, allowing VoiceOver
        to navigate between frames.

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject topRenderer]):
        (-[WebCoreAXObject frameView]):
        (-[WebCoreAXObject topFrameView]):
        Removed topDocument, renamed topView to topFrameView, added frameView.

        (-[WebCoreAXObject accessibilityAttributeValue:]):
        AXSelectedTextMarkerRange, AXStartTextMarker, and AXEndTextMarker now use
        self's WebArea, rather than the top WebArea.

        (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
        Use self's WebArea, rather than the top WebArea.

        (-[WebCoreAXObject doAXTextMarkerForPosition:]):
        Use renamed methods for accessing top WebArea.

        (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]):
        Use renamed methods for accessing self's WebArea.

        (AXAttributeStringSetColor):
        (AXAttributeStringSetNumber):
        (AXAttributeStringSetFont):
        (AXAttributeStringSetStyle):
        (AXAttributeStringSetElement):
        (-[WebCoreAXObject rendererForView:]):
        Clean up uses of nil and NULL.

        (-[WebCoreAXObject accessibilityFocusedUIElement]):
        Find the focused node on the whole page. If there is no focused node,
        return the WebArea for the focused document.

        (-[WebCoreAXObject doSetAXSelectedTextMarkerRange:]):
        Use self's WebArea, rather than the top WebArea.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix build. This one was not supposed to be checked in.
antti [Mon, 2 Apr 2007 10:06:12 +0000 (10:06 +0000)]
    Fix build. This one was not supposed to be checked in.

        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
antti [Mon, 2 Apr 2007 09:43:08 +0000 (09:43 +0000)]
    Reviewed by Hyatt.

        Render tree memory savings, part 2

        - Move staticX and staticY variables to RenderLayer since they are only
          applicable to positioned objects
        - Move very rarely used overrideSize variable to hash

        These changes shrink all box types by 12 bytes

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::RenderBox):
        (WebCore::RenderBox::destroy):
        (WebCore::RenderBox::overrideSize):
        (WebCore::RenderBox::setOverrideSize):
        (WebCore::RenderBox::overrideWidth):
        (WebCore::RenderBox::overrideHeight):
        (WebCore::RenderBox::position):
        (WebCore::RenderBox::calcWidth):
        (WebCore::RenderBox::calcHeight):
        (WebCore::RenderBox::staticX):
        (WebCore::RenderBox::staticY):
        (WebCore::RenderBox::setStaticX):
        (WebCore::RenderBox::setStaticY):
        (WebCore::RenderBox::calcAbsoluteHorizontal):
        (WebCore::RenderBox::calcAbsoluteVertical):
        (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
        (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
        * rendering/RenderBox.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::RenderLayer):
        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::staticX):
        (WebCore::RenderLayer::staticY):
        (WebCore::RenderLayer::setStaticX):
        (WebCore::RenderLayer::setStaticY):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::RenderObject):
        * rendering/RenderObject.h:
        (WebCore::):
        (WebCore::RenderObject::hasOverrideSize):
        (WebCore::RenderObject::setHasOverrideSize):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::destroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Not reviewed - gdk build fix.
kjk [Sun, 1 Apr 2007 23:01:35 +0000 (23:01 +0000)]
    Not reviewed - gdk build fix.

        * platform/gdk/TemporaryLinkStubs.cpp:
        (Font::selectionRectForComplexText):
        (Font::drawComplexText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Sun, 1 Apr 2007 05:41:30 +0000 (05:41 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=12778
        REGRESSION: Nightly won't load Curl plugin for full page use

        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::createDocument): Re-order cases to give more priority to plugins.
        This also fixes Adobe SVG Viewer and any plugins that register XML MIME types.
        Added a case for XHTML to avoid enumerating plugins.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@20647 268f45cc-cd09-0410...
hyatt [Sun, 1 Apr 2007 05:21:33 +0000 (05:21 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for bug 13234, layout of selected justified text is broken. Rework TextR...
hyatt [Sun, 1 Apr 2007 05:20:58 +0000 (05:20 +0000)]
    Fix for bug 13234, layout of selected justified text is broken.  Rework TextRuns to avoid having
        from/to members.  Let those be passed in only by the functions that need them (drawing and selection rect).

        Reviewed by mitz

        fast/text/justified-selection-at-edge.html

        * platform/Font.cpp:
        (WebCore::WidthIterator::WidthIterator):
        (WebCore::WidthIterator::advance):
        (WebCore::Font::canUseGlyphCache):
        (WebCore::Font::drawSimpleText):
        (WebCore::Font::drawText):
        (WebCore::Font::floatWidth):
        (WebCore::Font::floatWidthForSimpleText):
        (WebCore::Font::selectionRectForText):
        (WebCore::Font::selectionRectForSimpleText):
        (WebCore::Font::offsetForPositionForSimpleText):
        * platform/Font.h:
        (WebCore::TextRun::m_len):
        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::drawText):
        (WebCore::GraphicsContext::drawHighlightForText):
        * platform/graphics/GraphicsContext.h:
        * platform/mac/FontMac.mm:
        (WebCore::addDirectionalOverride):
        (WebCore::overrideLayoutOperation):
        (WebCore::ATSULayoutParameters::initialize):
        (WebCore::Font::selectionRectForComplexText):
        (WebCore::Font::drawComplexText):
        (WebCore::Font::floatWidthForComplexText):
        (WebCore::Font::offsetForPositionForComplexText):
        * platform/qt/FontQt.cpp:
        (WebCore::Font::drawComplexText):
        (WebCore::Font::floatWidthForComplexText):
        * platform/qt/TemporaryLinkStubs.cpp:
        (Font::selectionRectForComplexText):
        * rendering/EllipsisBox.cpp:
        (WebCore::EllipsisBox::paint):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::selectionRect):
        (WebCore::InlineTextBox::paint):
        (WebCore::InlineTextBox::paintSelection):
        (WebCore::InlineTextBox::paintMarkedTextBackground):
        (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
        (WebCore::InlineTextBox::paintTextMatchMarker):
        (WebCore::InlineTextBox::offsetForPosition):
        (WebCore::InlineTextBox::positionForOffset):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint):
        (WebCore::RenderListMarker::calcMinMaxWidth):
        (WebCore::RenderListMarker::getRelativeMarkerRect):
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::updateOptionsWidth):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::widthFromCache):
        (WebCore::RenderText::width):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-31 Mitz Pettel <mitz@webkit.org>
bdash [Sun, 1 Apr 2007 05:04:47 +0000 (05:04 +0000)]
2007-03-31  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13243
              <rdar://problem/5103226>
          REGRESSION (r20506): Repro crash/assert when using scroll wheel on a list box taller than its contents

        * platform/ScrollBar.cpp:
        (WebCore::Scrollbar::setValue): Cleaned up a little.
        (WebCore::Scrollbar::scroll): Changed to apply the minimum and maximum constraints
        in the right order, and cleaned up a little.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-31 Mitz Pettel <mitz@webkit.org>
andrew [Sun, 1 Apr 2007 04:59:52 +0000 (04:59 +0000)]
2007-03-31  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=13242
          REGRESSION: Repro crash when specifying the content property for an image

        * fast/images/text-content-crash-expected.txt: Added.
        * fast/images/text-content-crash.html: Added.

2007-03-31  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13242
          REGRESSION: Repro crash when specifying the content property for an image

        Test: fast/images/text-content-crash.html

        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::parseMappedAttribute): Added a check that the
        renderer is an image.
        (WebCore::HTMLImageElement::attach): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-31 Mark Rowe <mrowe@apple.com>
bdash [Sun, 1 Apr 2007 04:50:11 +0000 (04:50 +0000)]
2007-03-31  Mark Rowe  <mrowe@apple.com>

        Reviewed by Mitz.

        Fix http://bugs.webkit.org/show_bug.cgi?id=13239
        Bug 13239: REGRESSION (r20343): Drosera hits exception trying to call "count" cross-process

        Use -[WebScriptObject valueForKey:@"length"] to retrieve the length of a JavaScript array
        rather than -[WebScriptObject count].

        * Drosera/DebuggerDocument.m:
        (-[DebuggerDocument webScriptAttributeKeysForScriptObject:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-31 Mark Rowe <mrowe@apple.com>
bdash [Sun, 1 Apr 2007 04:48:17 +0000 (04:48 +0000)]
2007-03-31  Mark Rowe  <mrowe@apple.com>

        Reviewed by Darin.

        A more correct fix for http://bugs.webkit.org/show_bug.cgi?id=13129
        Bug 13129: Democracy Player dies in NSException from WebScriptObject on startup

        The previous attempt at a fix in r20343 attempted to conditionally expose the 'count'
        method.  It did not work which resulted in 'count' always being hidden.  This change
        disables -[WebScriptObject count] completely until it can be determined whether it is
        needed and how to support it without breaking third-party applications.

        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject count]):
        * bindings/objc/WebScriptObjectPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReplaced bogus 'text/plain' svn property with svn:mime-type property set to 'text...
ddkilzer [Sat, 31 Mar 2007 15:32:27 +0000 (15:32 +0000)]
Replaced bogus 'text/plain' svn property with svn:mime-type property set to 'text/javascript'.
Fixed one instance where 'allow-tabs' property and 'true' value were reversed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReplaced bogus 'text/plain' svn property with svn:mime-type property set to 'text...
ddkilzer [Sat, 31 Mar 2007 11:30:37 +0000 (11:30 +0000)]
Replaced bogus 'text/plain' svn property with svn:mime-type property set to 'text/javascript'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-31 Mitz Pettel <mitz@webkit.org>
ap [Sat, 31 Mar 2007 10:25:21 +0000 (10:25 +0000)]
2007-03-31  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Sam Weinig.

        - pixel test for partially selected justified text

        * fast/text/justified-selection-expected.checksum: Added.
        * fast/text/justified-selection-expected.png: Added.
        * fast/text/justified-selection-expected.txt: Added.
        * fast/text/justified-selection.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-31 Mitz Pettel <mitz@webkit.org>
ap [Sat, 31 Mar 2007 10:18:33 +0000 (10:18 +0000)]
2007-03-31  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - http://bugs.webkit.org/show_bug.cgi?id=13214

        A layout test documenting shrink-to-fit width calculation for floating elements.

        * fast/block/float/shrink-to-fit-width-expected.checksum: Added.
        * fast/block/float/shrink-to-fit-width-expected.png: Added.
        * fast/block/float/shrink-to-fit-width-expected.txt: Added.
        * fast/block/float/shrink-to-fit-width.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-31 Nicholas Shanks <webkit@nickshanks.com>
ap [Sat, 31 Mar 2007 10:07:32 +0000 (10:07 +0000)]
2007-03-31  Nicholas Shanks  <webkit@nickshanks.com>

        Reviewed by Adele.

        http://bugs.webkit.org/show_bug.cgi?id=13184
        HTMLImageElement longdesc should be complete resolved URL

        Test: fast/dom/HTMLImageElement/image-longdesc-absolute-url.html

        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::longDesc): Return absolute URL.
        Behaviour now matches Firefox and Opera.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-31 Mitz Pettel <mitz@webkit.org>
ap [Sat, 31 Mar 2007 08:26:24 +0000 (08:26 +0000)]
2007-03-31  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13209
          REGRESSION (r18756-18765): Incomplete list marker repaint when resizing list item

        Test: fast/repaint/list-marker-2.html

        A list marker can increase the horizontal overflow after layoutInlineChildren(),
        so made that function return only the vertical bounds of the repaint rect. As the
        horizontal bounds, made layoutBlock() just use the overflow bounds after layout.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock):
        * rendering/RenderBlock.h:
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-31 Mitz Pettel <mitz@webkit.org>
ap [Sat, 31 Mar 2007 07:59:22 +0000 (07:59 +0000)]
2007-03-31  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Hyatt.

        - http://bugs.webkit.org/show_bug.cgi?id=13178
          Helvetica zero-width space has non-zero width

        Test: fast/text/wide-zero-width-space.html

        * platform/FontData.cpp:
        (WebCore::FontData::FontData): Force the ZERO WIDTH SPACE glyph to have width
        0, unless the SPACE character maps to the same glyph.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-31 Mitz Pettel <mitz@webkit.org>
ap [Sat, 31 Mar 2007 07:49:19 +0000 (07:49 +0000)]
2007-03-31  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=8016
          REPRO: Safari hangs loading 18 MB page (deeply nested DOM tree)

WebCore:
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::parseTag): Made "<" terminate tag and attribute
        names. This matches Firefox.

LayoutTests:
        * fast/overflow/002-expected.checksum:
        * fast/overflow/002-expected.png:
        * fast/overflow/002-expected.txt:
        * fast/overflow/002.html: Added missing ">" to one of the BR tags.
        * fast/text/atsui-multiple-renderers-expected.checksum:
        * fast/text/atsui-multiple-renderers-expected.png:
        * fast/text/atsui-multiple-renderers-expected.txt:
        * fast/text/atsui-multiple-renderers.html: Added missing ">" to the TITLE tag.
        * fast/tokenizer/lessthan-terminates-tags-and-attrs-expected.txt: Added.
        * fast/tokenizer/lessthan-terminates-tags-and-attrs.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReplaced bogus 'text/plain' svn property with svn:mime-type property set to 'text...
ddkilzer [Sat, 31 Mar 2007 02:25:21 +0000 (02:25 +0000)]
Replaced bogus 'text/plain' svn property with svn:mime-type property set to 'text/javascript'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
andersca [Fri, 30 Mar 2007 21:41:00 +0000 (21:41 +0000)]
LayoutTests:

        Reviewed by Geoff.

        * plugins/destroy-stream-twice.html:
        Put the scripts before the embed element. Set the timeout in the onstreamload handler.

WebKitTools:

        Reviewed by Geoff.

        Add an "onstreamload" attribute to the plugin which is called when a stream starts loading.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
        * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
        (NPP_New):
        Look for the onstreamload attribute.

        (NPP_Destroy):
        Free the onstreamload attribute.

        (NPP_NewStream):
        Call the onstreamload handler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Debug build fix.
ap [Fri, 30 Mar 2007 20:57:27 +0000 (20:57 +0000)]
    Debug build fix.

        * xml/XPathValue.cpp:
        (WebCore::XPath::): Define Value::adopt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20622 268f45cc-cd09-0410-ab3c-d52691b4dbfc