WebKit-https.git
11 years agoHide the in-rietveld flag in the UI. It is only used only by tooling and shouldn...
jparent@chromium.org [Wed, 12 May 2010 21:34:13 +0000 (21:34 +0000)]
Hide the in-rietveld flag in the UI.  It is only used only by tooling and shouldn't clutter the UI.
https://bugs.webkit.org/show_bug.cgi?id=39024

Reviewed by Ojan Vafai.

* template/en/custom/attachment/list.html.tmpl:
  Removes this flag entirely from the UI, not needed on this page.
* template/en/custom/flag/list.html.tmpl: Added.
  Copied from template/en/default/flag/list.html.tmpl with only changes inside the if WEBKIT_CHANGES section.
  Hides the flag rather than removing it completely, so tools can still interact with it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdding block elements to a block and removing them changes the height of the element.
enrica@apple.com [Wed, 12 May 2010 21:24:10 +0000 (21:24 +0000)]
Adding block elements to a block and removing them changes the height of the element.
https://bugs.webkit.org/show_bug.cgi?id=38874

Reviewed by Dave Hyatt.

WebCore:

The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.

Test: editing/deleting/delete-block-contents-004.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild): m_childrenInline was set to true only when the Renderer is created
and never reset to true when all the block elements contained are removed.

LayoutTests:

* editing/deleting/delete-block-contents-004-expected.txt: Added.
* editing/deleting/delete-block-contents-004.html: Added.
The following tests have new results because of the height change and because we now have one less renderer after the DOM changes.
* editing/deleting/in-visibly-empty-root-expected.txt:
* platform/mac/editing/deleting/5408255-expected.txt:
* platform/mac/editing/deleting/delete-select-all-001-expected.txt:
* platform/mac/editing/selection/4895428-1-expected.txt:
* platform/mac/editing/selection/4895428-4-expected.txt:
* platform/mac/fast/events/mouseout-dead-node-expected.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed. Chromium: rebaseline layout tests and mark one failed layout test.
jianli@chromium.org [Wed, 12 May 2010 21:21:14 +0000 (21:21 +0000)]
Unreviewed. Chromium: rebaseline layout tests and mark one failed layout test.

* platform/chromium-linux/fast/forms/placeholder-stripped-expected.checksum: Added.
* platform/chromium-linux/fast/forms/placeholder-stripped-expected.png: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
* platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
* platform/chromium-mac/fast/forms/placeholder-stripped-expected.checksum: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
* platform/chromium-win/fast/forms/placeholder-stripped-expected.checksum: Added.
* platform/chromium-win/fast/forms/placeholder-stripped-expected.png: Added.
* platform/chromium-win/fast/forms/placeholder-stripped-expected.txt: Added.
* platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
* platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
* platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Adam Langley <agl@chromium.org>
agl@chromium.org [Wed, 12 May 2010 21:18:36 +0000 (21:18 +0000)]
2010-05-12  Adam Langley  <agl@chromium.org>

        Expectations change. Unreviewed.

        Add baselines for fast/css/font-face-woff.html.

        * platform/chromium-linux/fast/css/font-face-woff-expected.checksum: Added.
        * platform/chromium-linux/fast/css/font-face-woff-expected.png: Added.
        * platform/chromium-mac/fast/css/font-face-woff-expected.checksum: Added.
        * platform/chromium-mac/fast/css/font-face-woff-expected.png: Added.
        * platform/chromium-mac/fast/css/font-face-woff-expected.txt: Added.
        * platform/chromium-win/fast/css/font-face-woff-expected.checksum: Added.
        * platform/chromium-win/fast/css/font-face-woff-expected.png: Added.
        * platform/chromium-win/fast/css/font-face-woff-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDo not check if a database needs to be vacuumed after a read-only transaction.
dumi@chromium.org [Wed, 12 May 2010 21:08:10 +0000 (21:08 +0000)]
Do not check if a database needs to be vacuumed after a read-only transaction.
https://bugs.webkit.org/show_bug.cgi?id=38972

Reviewed by Dimitri Glazkov.

* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::postflightAndCommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Link error in debug mode without debug_and_release config
ossy@webkit.org [Wed, 12 May 2010 21:04:39 +0000 (21:04 +0000)]
[Qt] Link error in debug mode without debug_and_release config
https://bugs.webkit.org/show_bug.cgi?id=39006

Reviewed by Kenneth Rohde Christiansen.

* WebKit.pri: Unnecessary build_pass guard removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdds support for Rietveld reviews. When there is an associated
jparent@chromium.org [Wed, 12 May 2010 20:57:49 +0000 (20:57 +0000)]
Adds support for Rietveld reviews.  When there is an associated
Rietveld id for a patch, adds a link to do a Rietveld review instead.

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=38143

* attachment.cgi:
    Added support for handling action=rietveldreview.
* template/en/custom/attachment/list.html.tmpl:
    Adds a link to use rietveld review iff the in_rietveld flag is set.
* template/en/custom/attachment/reviewform.html.tmpl:
    Detects if we are in rietveld review mode due to query string paramter,
    and customizes the review form slightly:
        - Changes text describing comment field.
        - Comment field does not include quoted patch.
        - Submit button fetches from Rietveld instead of just submitting.
* template/en/custom/attachment/rietveldreview.html.tmpl: Added.
    New template for rietveldreview mode.  Hosts the rietveld frame in the
    top and the regular comments form in the bottom.
    Uses postMessage to communicate with Rietveld frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Detect debug mode consistently
ossy@webkit.org [Wed, 12 May 2010 20:56:51 +0000 (20:56 +0000)]
[Qt] Detect debug mode consistently
https://bugs.webkit.org/show_bug.cgi?id=38863

Patch by Laszlo Gombos <laszlo.1.gombos@nokia.com> on 2010-05-12
Reviewed by Kenneth Rohde Christiansen.

.:

* WebKit.pri:

JavaScriptCore:

* JavaScriptCore.pri:
* JavaScriptCore.pro:
* jsc.pro:
* qt/api/QtScript.pro:

WebCore:

No new tests as there is no new functionality.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 12 May 2010 20:51:06 +0000 (20:51 +0000)]
2010-05-12  James Robinson  <jamesr@chromium.org>

        Patch by Dan Bernstein.

        Reviewed by David Hyatt.

        Fix marking the layout root's parent as needing layout
        https://bugs.webkit.org/show_bug.cgi?id=37760

        If an element gets marked as needing layout due to the recalcStyle()
        call in FrameView::layout(), the m_layoutSchedulingEnabled flag will
        be set to false.  It's possible at this point that a parent of the
        existing FrameView::m_layoutRoot will be marked as needing layout.

        This patch updates FrameView::scheduleRelayoutOfSubtree to account
        for this case.

        Manual test only due to subtle timing issues.

        * manual-tests/layoutroot_detach.xml: Added.
        * page/FrameView.cpp:
        (WebCore::FrameView::scheduleRelayoutOfSubtree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 12 May 2010 20:50:43 +0000 (20:50 +0000)]
2010-05-12  Martin Robinson  <mrobinson@igalia.com>

        Not reviewed.

        [GTK] svg/custom/svg-fonts-with-no-element-reference.html is one pixel different on x86_64
        https://bugs.webkit.org/show_bug.cgi?id=39022

        Skipping failing tests for GTK+.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Slave losts cause build break on bots
ossy@webkit.org [Wed, 12 May 2010 20:32:27 +0000 (20:32 +0000)]
[Qt] Slave losts cause build break on bots
https://bugs.webkit.org/show_bug.cgi?id=38980

Reviewed by Kenneth Rohde Christiansen.

* Scripts/build-webkit: Remove 0 byte sized files from productDir before build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 12 May 2010 20:10:05 +0000 (20:10 +0000)]
2010-05-12  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r59245.
        http://trac.webkit.org/changeset/59245
        https://bugs.webkit.org/show_bug.cgi?id=38874

        Broke at least one test on multiple platforms

        * editing/deleting/delete-block-contents-004-expected.txt: Removed.
        * editing/deleting/delete-block-contents-004.html: Removed.
        * editing/deleting/in-visibly-empty-root-expected.txt:
        * platform/mac/editing/deleting/5408255-expected.txt:
        * platform/mac/editing/deleting/delete-select-all-001-expected.txt:
        * platform/mac/editing/selection/4895428-1-expected.txt:
        * platform/mac/editing/selection/4895428-4-expected.txt:
2010-05-12  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r59245.
        http://trac.webkit.org/changeset/59245
        https://bugs.webkit.org/show_bug.cgi?id=38874

        Broke at least one test on multiple platforms

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::removeChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed trivial fix after r59254.
ossy@webkit.org [Wed, 12 May 2010 20:08:39 +0000 (20:08 +0000)]
Unreviewed trivial fix after r59254.

* Scripts/old-run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agorun-webkit-tests --exit-after-N-failures should not count new tests as failures
ossy@webkit.org [Wed, 12 May 2010 20:01:05 +0000 (20:01 +0000)]
run-webkit-tests --exit-after-N-failures should not count new tests as failures
https://bugs.webkit.org/show_bug.cgi?id=31829

Reviewed by Eric Seidel.

* Scripts/old-run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 12 May 2010 19:48:15 +0000 (19:48 +0000)]
2010-05-12  Martin Robinson  <mrobinson@igalia.com>

        Not reviewed. Try number 3 to properly add new baselines and remove remaining
        merge marker from this file.

        * platform/gtk/fast/css/input-search-padding-expected.txt:
        * platform/gtk/svg/custom/svg-fonts-with-no-element-reference-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix LayoutTest/ChangeLog bad merge
jamesr@google.com [Wed, 12 May 2010 19:41:38 +0000 (19:41 +0000)]
Fix LayoutTest/ChangeLog bad merge

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-29 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 12 May 2010 19:36:01 +0000 (19:36 +0000)]
2010-04-29  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        Test that when a frame with fixed position elements is scrolled via the
        keyboard that the correct repaints happen.
        https://bugs.webkit.org/show_bug.cgi?id=38286

        * fast/repaint/fixed-move-after-keyboard-scroll.html: Added.
        * fast/repaint/resources/fixed-move-after-keyboard-scroll-iframe.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum: Added.
        * platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.png: Added.
        * platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@apple.com [Wed, 12 May 2010 19:19:33 +0000 (19:19 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=38752
        Strange behaviour after js insertion into a page pointing directly to an object (image, swf, etc)

        Test: fast/images/extra-image-in-image-document.html

        * loader/ImageLoader.cpp: (WebCore::ImageLoader::updateFromElement): Reset setAutoLoadImages
        after manually feeding an image - there may be more coming.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Martin Robinson <mrobinson@webkit.org>
mrobinson@webkit.org [Wed, 12 May 2010 19:12:25 +0000 (19:12 +0000)]
2010-05-12  Martin Robinson  <mrobinson@webkit.org>

        Not reviewed. Trying once more to generate baselines for GTK+.

        * platform/gtk/fast/css/input-search-padding-expected.txt:
        * platform/gtk/fast/forms/placeholder-stripped-expected.txt:
        * platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
        * platform/gtk/fast/images/svg-background-partial-redraw-expected.txt: Added.
        * platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
        * platform/gtk/svg/custom/repaint-stroke-width-changes-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/repaint-stroke-width-changes-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoHTMLLabelElement::control() should return HTMLFormControlElement, not HTMLElement
yael.aharon@nokia.com [Wed, 12 May 2010 19:09:53 +0000 (19:09 +0000)]
HTMLLabelElement::control() should return HTMLFormControlElement, not HTMLElement
https://bugs.webkit.org/show_bug.cgi?id=38991

Reviewed by Dan Bernstein.

No new tests since no new functionality was introduced.

* html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::control):
* html/HTMLLabelElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=38891
hyatt@apple.com [Wed, 12 May 2010 19:03:58 +0000 (19:03 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=38891

Reviewed by Darin Adler.

First-letter had a number of bugs that were exposed by my attempt to optimize the setting of styles when updating first-letter.
The code that drills down to find the first-letter child stopped if it hit an element that didn't need layout.  This means it could
return random incorrect results (and cause the first-letter object to not be found).

In addition when the first-letter was floated/positioned, the text child was not correctly returned, but the container itself was
returned instead.

Finally, the updating code was leaving the box that wrapped the first letter text with a stale style.  The old code happened to work because
it made new styles for the text elements instead of using the enclosing box style.  The regression was caused by my change to make the
text children simply share style with their parent (thus making the bug that the parent had the wrong style become more prominent).

No new tests, since there's a timing component to reproducing the issue.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 12 May 2010 18:30:14 +0000 (18:30 +0000)]
2010-05-12  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        Disable smooth scrolling on OS X when running tests
        https://bugs.webkit.org/show_bug.cgi?id=38964

        Some tests (like fast/repaint/fixed-move-after-keyboard-scroll.html)
        depend on smooth scrolling behavior.  Since this is off by default
        in Leopard and on by default in Snow Leopard, DRT should turn it
        off always to ensure a consistent test environment.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetDefaultsToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdding block elements to a block and removing them changes the height of the element.
enrica@apple.com [Wed, 12 May 2010 18:29:55 +0000 (18:29 +0000)]
Adding block elements to a block and removing them changes the height of the element.
https://bugs.webkit.org/show_bug.cgi?id=38874

Reviewed by Dave Hyatt.

WebCore:

The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.

Test: editing/deleting/delete-block-contents-004.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild): m_childrenInline was set to true only when the Renderer is created
and never reset to true when all the block elements contained are removed.

LayoutTests:

* editing/deleting/delete-block-contents-004-expected.txt: Added.
* editing/deleting/delete-block-contents-004.html: Added.
The following tests have new results because of the height change and because we now have one less renderer after the DOM changes.
* editing/deleting/in-visibly-empty-root-expected.txt:
* platform/mac/editing/deleting/5408255-expected.txt:
* platform/mac/editing/deleting/delete-select-all-001-expected.txt:
* platform/mac/editing/selection/4895428-1-expected.txt:
* platform/mac/editing/selection/4895428-4-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 12 May 2010 18:26:17 +0000 (18:26 +0000)]
2010-05-12  Martin Robinson  <mrobinson@igalia.com>

        Not reviewed. Added baselines to these tests which are passing interactively.

        * platform/gtk/fast/css-generated-content/after-duplicated-after-split-expected.txt: Added.
        * platform/gtk/fast/css/input-search-padding-expected.txt: Added.
        * platform/gtk/fast/forms/placeholder-stripped-expected.txt: Added.
        * platform/gtk/fast/frames/take-focus-from-iframe-expected.txt: Added.
        * platform/gtk/fast/repaint/fixed-child-move-after-scroll-expected.txt: Added.
        * platform/gtk/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt: Added.
        * platform/gtk/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt: Added.
        * platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt: Added.
        * platform/gtk/fast/repaint/fixed-move-after-scroll-expected.txt: Added.
        * platform/gtk/fast/repaint/fixed-tranformed-expected.txt: Added.
        * platform/gtk/fast/text/format-control-expected.txt: Added.
        * platform/gtk/fast/text/international/bold-bengali-expected.txt: Added.
        * platform/gtk/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt.
        * platform/gtk/svg/text/text-hkern-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-hkern-expected.txt.
        * platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt.
        * platform/gtk/svg/text/text-vkern-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-vkern-expected.txt.
        * platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-vkern-on-horizontal-text-expected.txt.
        * platform/gtk/transforms/svg-vs-css-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 12 May 2010 18:24:26 +0000 (18:24 +0000)]
2010-05-12  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: disabling style property on container breaks styles inspection for given node.

        https://bugs.webkit.org/show_bug.cgi?id=39005

        Tests: inspector/styles-disable-inherited.html
               inspector/styles-disable-then-enable.html

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype._containsInherited):
        (WebInspector.StylesSidebarPane.prototype._arrayContainsInheritedProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoHTML Entity Escape the contents of a textarea node when accessed
darin@apple.com [Wed, 12 May 2010 18:15:39 +0000 (18:15 +0000)]
HTML Entity Escape the contents of a textarea node when accessed
via the innerHTML and outerHTML node properties.
https://bugs.webkit.org/show_bug.cgi?id=38922

Patch by Abhishek Arya <inferno@chromium.org> on 2010-05-12
Reviewed by Darin Adler.

Test: fast/innerHTML/innerHTML-special-elements.html

* editing/markup.cpp:
(WebCore::appendStartMarkup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Abhishek Arya <inferno@chromium.org>
darin@apple.com [Wed, 12 May 2010 18:13:00 +0000 (18:13 +0000)]
2010-05-12  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Darin Adler.

        HTML Entity Escape the contents of a textarea node when accessed via the innerHTML and outerHTML node properties.
        https://bugs.webkit.org/show_bug.cgi?id=38922

        Test: fast/encoding/textnode-XSS.html

        * editing/markup.cpp:
        (WebCore::appendStartMarkup):
2010-05-12  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Darin Adler.

        Tests that accessing the innerHTML property of a text node encodes
        entities properly. Update existing test to fix the innerHTML result.
        https://bugs.webkit.org/show_bug.cgi?id=38922

        * fast/innerHTML/innerHTML-special-elements-expected.txt: Added.
        * fast/innerHTML/innerHTML-special-elements.html: Added.

        * fast/parser/comment-in-textarea-expected.txt: Update test expectation.
        * fast/parser/script-tests/comment-in-textarea.js: Update test by
        replacing with html entities of <, > chars in textarea innerHTML result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 12 May 2010 17:11:57 +0000 (17:11 +0000)]
2010-05-12  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] Use GOwnPtr for code that needs it
        https://bugs.webkit.org/show_bug.cgi?id=21594

        Convert many uses of raw pointers to GRefPtr and GOwnPtr in WebKitWebView.

        * WebCoreSupport/ContextMenuClientGtk.cpp:
        (WebKit::inputMethodsMenuItem):
        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::setInputMethodState):
        (WebKit::EditorClient::respondToChangedSelection):
        (WebKit::EditorClient::handleInputMethodKeydown):
        (WebKit::EditorClient::EditorClient):
        (WebKit::EditorClient::~EditorClient):
        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::postCommitFrameViewSetup):
        * webkit/webkitprivate.h:
        * webkit/webkitwebview.cpp:
        (destroy_menu_cb):
        (webkit_web_view_forward_context_menu_event):
        (webkit_web_view_key_release_event):
        (webkit_web_view_button_release_event):
        (webkit_web_view_focus_in_event):
        (webkit_web_view_focus_out_event):
        (webkit_web_view_realize):
        (webkit_web_view_set_scroll_adjustments):
        (webkit_web_view_dispose):
        (webkit_web_view_finalize):
        (webViewGetDPI):
        (webkit_web_view_screen_changed):
        (webkit_web_view_query_tooltip):
        (webkit_web_view_get_im_context):
        (webkit_web_view_update_settings):
        (webkit_web_view_init):
        (webkit_web_view_set_settings):
        (webkit_web_view_get_settings):
        (webkit_web_view_get_inspector):
        (webkit_web_view_set_window_features):
        (webkit_web_view_get_window_features):
        (webkit_web_view_get_back_forward_list):
        (webkit_web_view_zoom_in):
        (webkit_web_view_zoom_out):
        (webkit_web_view_get_encoding):
        (webkit_web_view_get_custom_encoding):
        (webkit_web_view_add_resource):
        (webkit_web_view_get_resource):
        (webkit_web_view_get_main_resource):
        (webkit_web_view_clear_resources):
        (webkit_web_view_get_subresources):
        (webkit_web_view_set_tooltip_text):
        (webkit_web_view_get_icon_uri):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=38871 REGRESSION:
bdakin@apple.com [Wed, 12 May 2010 16:52:45 +0000 (16:52 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=38871 REGRESSION:
Crash clicking background NPR tab after few minutes of sitting idle
-and corresponding-
<rdar://problem/7941504>

Reviewed by Darin Adler.

Move m_mediaCanStartListeners HashSet to Document away from Page.
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::addMediaCanStartListener):
(WebCore::Document::removeMediaCanStartListener):
(WebCore::Document::takeAnyMediaCanStartListener):
* dom/Document.h:
* page/Page.cpp:
(WebCore::Page::takeAnyMediaCanStartListener):
* page/Page.h:
(WebCore::Page::canStartMedia):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Wed, 12 May 2010 16:44:33 +0000 (16:44 +0000)]
2010-05-12  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        [Chromium] Pass the origin parameter for WebIndexedDatabase::open
        https://bugs.webkit.org/show_bug.cgi?id=38983

        * public/WebIndexedDatabase.h:
        * src/IndexedDatabaseProxy.cpp:
        (WebCore::IndexedDatabaseProxy::open):
        * src/WebIndexedDatabaseImpl.cpp:
        (WebKit::WebIndexedDatabaseImpl::open):
        * src/WebIndexedDatabaseImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-11 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 12 May 2010 16:10:44 +0000 (16:10 +0000)]
2010-05-11  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: Sometimes ResourceRequest records aren't connected to the initiator.
        https://bugs.webkit.org/show_bug.cgi?id=38925

        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
        * inspector/InspectorTimelineAgent.h:
        (WebCore::):
        * inspector/TimelineRecordFactory.cpp:
        (WebCore::TimelineRecordFactory::createScheduleResourceRequestData):
        * inspector/TimelineRecordFactory.h:
        * inspector/front-end/TimelineAgent.js:
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel):
        (WebInspector.TimelinePanel.prototype.get _recordStyles):
        (WebInspector.TimelinePanel.prototype._findParentRecord):
        (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
        (WebInspector.TimelinePanel.prototype._clearPanel):
        (WebInspector.TimelinePanel.FormattedRecord):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
        * loader/loader.cpp:
        (WebCore::Loader::load):

2010-05-11  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: Sometimes ResourceRequest records aren't connected to the initiator.
        https://bugs.webkit.org/show_bug.cgi?id=38925

        * inspector/timeline-enum-stability-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 12 May 2010 15:57:24 +0000 (15:57 +0000)]
2010-05-12  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        placeholder text should be stripped from line breaks
        https://bugs.webkit.org/show_bug.cgi?id=36291

        Add a test for placeholder values with CR and LF.

        * fast/forms/placeholder-stripped.html: Added.
        * platform/mac/fast/forms/placeholder-stripped-expected.checksum: Added.
        * platform/mac/fast/forms/placeholder-stripped-expected.png: Added.
        * platform/mac/fast/forms/placeholder-stripped-expected.txt: Added.
2010-05-12  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        placeholder text should be stripped from line breaks
        https://bugs.webkit.org/show_bug.cgi?id=36291

        According to http://dev.w3.org/html5/spec/forms.html#attr-input-placeholder ,
        we need to remove CR and LF from the placeholder attribute values.
        Introduce HTMLTextFormControlElement::strippedPlaceholder(), which
        returns stripped value, and replace getAttribute(placeholderAttr) with it.

        Test: fast/forms/placeholder-stripped.html

        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLTextFormControlElement::strippedPlaceholder):
        (WebCore::HTMLTextFormControlElement::isPlaceholderEmpty):
        (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
          Use strippedPlaceholder().
        * html/HTMLFormControlElement.h:
        * platform/text/CharacterNames.h: Add carriageReturn.
        * rendering/RenderTextControlMultiLine.cpp:
        (WebCore::RenderTextControlMultiLine::updateFromElement):
          Use strippedPlaceholder().
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::updateFromElement):
          Use strippedPlaceholder().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAllows build-webkit script to receive an install prefix as parameter https://bugs...
tonikitoo@webkit.org [Wed, 12 May 2010 15:26:04 +0000 (15:26 +0000)]
Allows build-webkit script to receive an install prefix as parameter https://bugs.webkit.org/show_bug.cgi?id=26224

Reviewed by Kenneth Christiansen , Simon Hausmann and Gustavo Noronha.
Patch by Rodrigo Belem <rodrigo.belem@openbossa.org>

WebCore:

This patch adds the ability, in the QtWebkit build system, to change
the installation path.

* WebCore.pro:

WebKitTools:

Added more parameters to build-webkit script, the --prefix for gkt
and --install-libs, --install-headers for qt. Now it is possible
to change the install prefix for gtk and install path for qt.

* Scripts/build-webkit:
* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Wed, 12 May 2010 15:05:31 +0000 (15:05 +0000)]
2010-05-12  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Kenneth Christiansen.

        [Qt] Remove the unneeded check for QWidgetPageClient @QGraphicsWebView::detachCurrentPage
        https://bugs.webkit.org/show_bug.cgi?id=38989

        Reasons:
        - There is no need to check for a QWidgetPageClient-based in QGraphicsWebView.
        - The client has always to be deleted anyways.

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::detachPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Implement a detachCurrentPage method for QGraphicsWebView and QWebView
tonikitoo@webkit.org [Wed, 12 May 2010 15:04:58 +0000 (15:04 +0000)]
[Qt] Implement a detachCurrentPage method for QGraphicsWebView and QWebView
https://bugs.webkit.org/show_bug.cgi?id=38939

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

unsetPageIfExists method was renamed to detachCurrentPage method and is now responsible
for doing all the unset logic of page and pageClient references previously done by
the Q{Graphics}WebView destructor(s).

It is a code clean up, no behaviour change.

* Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate):
(QGraphicsWebView::~QGraphicsWebView):
(QGraphicsWebViewPrivate::detachCurrentPage):
(QGraphicsWebView::setPage):
* Api/qwebview.cpp:
(QWebViewPrivate::~QWebViewPrivate):
(QWebView::~QWebView):
(QWebViewPrivate::detachCurrentPage):
(QWebView::setPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Wed, 12 May 2010 14:35:15 +0000 (14:35 +0000)]
2010-05-12  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Bug 38689: #34005 will break fullscreen video playback
        https://bugs.webkit.org/show_bug.cgi?id=38689

        Use the new definition of PlatformMedia to check the actual type
        returned by MediaPlayer.

        * FullscreenVideoController.cpp:
        (FullscreenVideoController::movie):
2010-05-12  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Bug 38689: #34005 will break fullscreen video playback
        https://bugs.webkit.org/show_bug.cgi?id=38689

        Use the new definition of PlatformMedia to check the actual type
        returned by MediaPlayer.

        * WebView/WebVideoFullscreenController.mm:
        (-[WebVideoFullscreenController windowDidLoad]):
2010-05-12  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Bug 38689: #34005 will break fullscreen video playback
        https://bugs.webkit.org/show_bug.cgi?id=38689

        The PlatformMedia struct now contains a type field indicating which type
        it contains.  The struct now contains a union of all possible return types,
        allowing the type of media returned by MediaPlayerPrivate instances to be
        determined at runtime.

        * platform/graphics/MediaPlayer.h:
        (WebCore::PlatformMedia::):
        (WebCore::):
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::platformMedia):
        * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
        (WebCore::MediaPlayerPrivateQuickTimeVisualContext::platformMedia):
        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
        (WebCore::MediaPlayerPrivate::platformMedia):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd a comment to explain the web inspector dynamic property url hook
hausmann@webkit.org [Wed, 12 May 2010 14:22:06 +0000 (14:22 +0000)]
Add a comment to explain the web inspector dynamic property url hook
and that it's there on purpose :)

Reviewed by Laszlo Gombos.

https://bugs.webkit.org/show_bug.cgi?id=35340

* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::openInspectorFrontend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Young Han Lee <joybro@company100.net>
eric@webkit.org [Wed, 12 May 2010 13:52:14 +0000 (13:52 +0000)]
2010-05-12  Young Han Lee  <joybro@company100.net>

        Reviewed by Darin Adler.

        Add missing ENABLE(SVG) guards.
        https://bugs.webkit.org/show_bug.cgi?id=38892

        * rendering/RenderSVGResourceClipper.cpp:
        * rendering/RenderSVGResourceMarker.cpp:
        * rendering/RenderSVGResourceMasker.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 12 May 2010 13:08:43 +0000 (13:08 +0000)]
2010-05-12  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: align sidebar checkboxes on windows.

        https://bugs.webkit.org/show_bug.cgi?id=38986

        * inspector/front-end/StylesSidebarPane.js:
        * inspector/front-end/inspector.css:
        (.sidebar-pane-subtitle):
        (body.platform-windows .sidebar-pane-subtitle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 12 May 2010 13:05:14 +0000 (13:05 +0000)]
2010-05-12  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, added my IRC nickname.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSupport control attribute of HTMLLabelElement
yael.aharon@nokia.com [Wed, 12 May 2010 13:02:27 +0000 (13:02 +0000)]
Support control attribute of HTMLLabelElement
https://bugs.webkit.org/show_bug.cgi?id=38688

Reviewed by Darin Adler.

WebCore:

Added support for the control attribute of HTMLLabelElement and changed the logic of determining
which control is associated with the label to conform to HTML5 spec.
Added a manual test for testing the logic of selecting the control to get focused, activated or hovered
when the label gets focused, activated or is hovered.

Test: fast/dom/HTMLLabelElement/click-label.html
Test: fast/dom/HTMLLabelElement/focus-label.html
Test: fast/dom/HTMLLabelElement/label-control.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::labelForElement):
(WebCore::AccessibilityRenderObject::correspondingControlForLabelElement):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::isLabelable):
* html/HTMLFormControlElement.h:
* html/HTMLLabelElement.cpp:
(WebCore::nodeAsLabelableFormControl):
(WebCore::HTMLLabelElement::control):
(WebCore::HTMLLabelElement::setActive):
(WebCore::HTMLLabelElement::setHovered):
(WebCore::HTMLLabelElement::defaultEventHandler):
(WebCore::HTMLLabelElement::focus):
(WebCore::HTMLLabelElement::accessKeyAction):
* html/HTMLLabelElement.h:
* html/HTMLLabelElement.idl:
* manual-tests/dom/form-control-for-label.html: Added.

WebKit/chromium:

Renamed HTMLLabelElement::correspondingControl to HTMLLabelElement::control

* src/WebLabelElement.cpp:
(WebKit::WebLabelElement::correspondingControl):

LayoutTests:

* fast/dom/HTMLLabelElement/click-label-expected.txt: Added.
* fast/dom/HTMLLabelElement/click-label.html: Added.
* fast/dom/HTMLLabelElement/focus-label-expected.txt: Added.
* fast/dom/HTMLLabelElement/focus-label.html: Added.
* fast/dom/HTMLLabelElement/label-control-expected.txt: Added.
* fast/dom/HTMLLabelElement/label-control.html: Added.
* fast/dom/HTMLLabelElement/script-tests: Added.
* fast/dom/HTMLLabelElement/script-tests/TEMPLATE.html: Added.
* fast/dom/HTMLLabelElement/script-tests/label-control.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Steve Block <steveblock@google.com>
eric@webkit.org [Wed, 12 May 2010 12:51:27 +0000 (12:51 +0000)]
2010-05-12  Steve Block  <steveblock@google.com>

        Reviewed by David Levin.

        Android's writeToFile() is buggy
        https://bugs.webkit.org/show_bug.cgi?id=38908

        No new tests, build fix only.

        * platform/android/FileSystemAndroid.cpp: Remove Android's version of writeToFile().
        * platform/posix/FileSystemPOSIX.cpp: Use POSIX version of writeToFile() on Android.
        (WebCore::writeToFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed.
ossy@webkit.org [Wed, 12 May 2010 12:21:39 +0000 (12:21 +0000)]
Unreviewed.

Other tests make http/tests/xmlhttprequest/null-auth.php fail
https://bugs.webkit.org/show_bug.cgi?id=32961

http/tests/xmlhttprequest/basic-auth-default.html introduced in r59185,
and it made http/tests/xmlhttprequest/null-auth.php fail on Qt bot, as
http/tests/xmlhttprequest/failed-auth.html did it before.

* platform/qt/Skipped: http/tests/xmlhttprequest/basic-auth-default.html skipped until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-10 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 12 May 2010 12:11:04 +0000 (12:11 +0000)]
2010-05-10  Philippe Normand  <pnormand@igalia.com>

        Reviewed by David Levin.

        [GStreamer] incoherent #ifdef in GOwnPtrGStreamer.h
        https://bugs.webkit.org/show_bug.cgi?id=38839

        Fixed #ifdef/curly braces coherence.

        * platform/graphics/gstreamer/GOwnPtrGStreamer.cpp:
        (WTF::GstElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-10 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 12 May 2010 12:07:44 +0000 (12:07 +0000)]
2010-05-10  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Dirk Schulze.

        [GStreamer] un-needed cairo.h include
        https://bugs.webkit.org/show_bug.cgi?id=38837

        Cairo not used in the sink anymore. So it's not needed to include
        the header.

        * platform/graphics/gstreamer/VideoSinkGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Peter Varga <pvarga@inf.u-szeged.hu>
zoltan@webkit.org [Wed, 12 May 2010 11:49:40 +0000 (11:49 +0000)]
2010-05-12  Peter Varga  <pvarga@inf.u-szeged.hu>

        Reviewed by Gavin Barraclough.

        Remove a direct jump in generatePatternCharacterGreedy() and
        generatePatternCharacterClassGreedy() functions if quantityCount of the term
        is unlimited.
        https://bugs.webkit.org/show_bug.cgi?id=38898

        * yarr/RegexJIT.cpp:
        (JSC::Yarr::RegexGenerator::generatePatternCharacterGreedy):
        (JSC::Yarr::RegexGenerator::generateCharacterClassGreedy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix for Windows and Chromium builds.
zherczeg@webkit.org [Wed, 12 May 2010 10:58:48 +0000 (10:58 +0000)]
Build fix for Windows and Chromium builds.

Reviewed by Nikolas Zimmermann.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* svg/graphics/filters/SVGFELighting.cpp:
(WebCore::FELighting::LightingData::upLeftPixelValue):
(WebCore::FELighting::LightingData::upPixelValue):
(WebCore::FELighting::LightingData::upRightPixelValue):
(WebCore::FELighting::LightingData::leftPixelValue):
(WebCore::FELighting::LightingData::centerPixelValue):
(WebCore::FELighting::LightingData::rightPixelValue):
(WebCore::FELighting::LightingData::downLeftPixelValue):
(WebCore::FELighting::LightingData::downPixelValue):
(WebCore::FELighting::LightingData::downRightPixelValue):
(WebCore::FELighting::setPixel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Implementing SVG filters: feDiffuseLighting and feSpecularLighting
zherczeg@webkit.org [Wed, 12 May 2010 10:18:00 +0000 (10:18 +0000)]
WebCore: Implementing SVG filters: feDiffuseLighting and feSpecularLighting
https://bugs.webkit.org/show_bug.cgi?id=32197
https://bugs.webkit.org/show_bug.cgi?id=32199

Reviewed by Nikolas Zimmermann.

The patch implements the SVG filters feDiffuseLighting and
feSpecularLighting including the impementation of their possible
light sources according to the Scalable Vector Graphics (SVG)
1.1 Specification. Only two features are missing: supporting images
with height or width set to 1, and kernelUnitLength other than (1,1).
Since the two lighting filters have a similar body, a common base
class called FELighting is introduced, and contains the code for
both filters. The implementation employs single precision floating
point arithmetic (fixed precision integer arithmetic seemed too difficult).

Indentation is removed of the modified header files in svg/graphics/filters

* GNUmakefile.am:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/FloatPoint3D.cpp:
* platform/graphics/FloatPoint3D.h:
(WebCore::FloatPoint3D::FloatPoint3D): constructors changed to inline
(WebCore::operator*): dot product
* svg/SVGFESpotLightElement.cpp:
(WebCore::SVGFESpotLightElement::lightSource):
* svg/graphics/filters/SVGDistantLightSource.h:
(WebCore::DistantLightSource::create):
(WebCore::DistantLightSource::azimuth):
(WebCore::DistantLightSource::elevation):
(WebCore::DistantLightSource::DistantLightSource):
* svg/graphics/filters/SVGFEDiffuseLighting.cpp:
(WebCore::FEDiffuseLighting::FEDiffuseLighting):
(WebCore::FEDiffuseLighting::create):
* svg/graphics/filters/SVGFEDiffuseLighting.h:
* svg/graphics/filters/SVGFELighting.cpp: Added.
(WebCore::FELighting::FELighting):
(WebCore::FELighting::LightingData::upLeftPixelValue):
(WebCore::FELighting::LightingData::upPixelValue):
(WebCore::FELighting::LightingData::upRightPixelValue):
(WebCore::FELighting::LightingData::leftPixelValue):
(WebCore::FELighting::LightingData::centerPixelValue):
(WebCore::FELighting::LightingData::rightPixelValue):
(WebCore::FELighting::LightingData::downLeftPixelValue):
(WebCore::FELighting::LightingData::downPixelValue):
(WebCore::FELighting::LightingData::downRightPixelValue):
(WebCore::FELighting::setPixel):
(WebCore::FELighting::drawLighting):
(WebCore::FELighting::apply):
* svg/graphics/filters/SVGFELighting.h: Added.
(WebCore::FELighting::uniteChildEffectSubregions):
(WebCore::FELighting::):
* svg/graphics/filters/SVGFESpecularLighting.cpp:
(WebCore::FESpecularLighting::FESpecularLighting):
(WebCore::FESpecularLighting::create):
* svg/graphics/filters/SVGFESpecularLighting.h:
* svg/graphics/filters/SVGLightSource.cpp:
(WebCore::PointLightSource::initPaintingData):
(WebCore::PointLightSource::updatePaintingData):
(WebCore::SpotLightSource::initPaintingData):
(WebCore::SpotLightSource::updatePaintingData):
(WebCore::DistantLightSource::initPaintingData):
(WebCore::DistantLightSource::updatePaintingData):
* svg/graphics/filters/SVGLightSource.h:
(WebCore::):
(WebCore::LightSource::LightSource):
(WebCore::LightSource::~LightSource):
(WebCore::LightSource::type):
* svg/graphics/filters/SVGPointLightSource.h:
(WebCore::PointLightSource::create):
(WebCore::PointLightSource::position):
(WebCore::PointLightSource::PointLightSource):
* svg/graphics/filters/SVGSpotLightSource.h:
(WebCore::SpotLightSource::create):
(WebCore::SpotLightSource::position):
(WebCore::SpotLightSource::direction):
(WebCore::SpotLightSource::specularExponent):
(WebCore::SpotLightSource::limitingConeAngle):
(WebCore::SpotLightSource::SpotLightSource):

LayoutTests: Updating the pixel tests for feDiffuseLighting and feSpecularLighting
https://bugs.webkit.org/show_bug.cgi?id=32197
https://bugs.webkit.org/show_bug.cgi?id=32199

Reviewed by Nikolas Zimmermann.

No new test were added, since SVG expected values cover
the features of the implementation

* platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
* platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
* platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
* platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 12 May 2010 09:35:20 +0000 (09:35 +0000)]
2010-05-12  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Nikolas Zimmermann.

        Add missing AM_V_GEN directives to generation rules so that they
        remain silent when requested.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Lucas De Marchi <lucas.demarchi@profusion.mobi>
eric@webkit.org [Wed, 12 May 2010 09:12:40 +0000 (09:12 +0000)]
2010-05-12  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Jeremy Orlow.

        [EFL] It does not make sense to use ScrollbarEfl::ScrollbarEfl, so
        use ScrollbarEfl (GCC 4.5 seems to be pickier about this). Revision 59030
        fixed cases for RenderThemeEfl, but missed this for ScrollbarEfl.
        http://webkit.org/b/38904

        No new tests required.

        * platform/efl/ScrollbarEfl.cpp:
        (scrollbarEflEdjeMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 MORITA Hajime <morrita@google.com>
morrita@google.com [Wed, 12 May 2010 08:51:24 +0000 (08:51 +0000)]
2010-05-12  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        [Chromium] Support HTML5 <progress> element on Windows.
        https://bugs.webkit.org/show_bug.cgi?id=37308

        Extended ChromiumBridge to handle progress bar painting,
        and added delegations to it.

        No new tests. Test cases should be shared with existing ones for
        progress element.  Expectaions will be added after PROGRESS_TAG is
        enabled on Chromium tree.

        * platform/chromium/ChromiumBridge.h:
        * rendering/RenderProgress.cpp:
        (WebCore::RenderProgress::animationProgress):
        (WebCore::RenderProgress::isDeterminate):
        * rendering/RenderProgress.h:
        (WebCore::RenderProgress::position):
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::animationRepeatIntervalForProgressBar):
        (WebCore::RenderThemeChromiumWin::animationDurationForProgressBar):
        (WebCore::RenderThemeChromiumWin::adjustProgressBarStyle):
        (WebCore::RenderThemeChromiumWin::paintProgressBar):
        * rendering/RenderThemeChromiumWin.h:
2010-05-12  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        [Chromium] Support HTML5 <progress> element on Windows.
        https://bugs.webkit.org/show_bug.cgi?id=37308

        Extended ChromiumBridge to handle progress bar painting,
        and added delegations to it.

        No new tests. Test cases should be shared with existing ones for
        progress element.  Expectaions will be added after PROGRESS_TAG is
        enabled on Chromium tree.

        * public/WebThemeEngine.h:
        (WebKit::WebThemeEngine::paintProgressBar):
        * src/ChromiumBridge.cpp:
        (WebCore::ChromiumBridge::paintProgressBar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Marcus Bulach <bulach@chromium.org>
eric@webkit.org [Wed, 12 May 2010 08:43:48 +0000 (08:43 +0000)]
2010-05-12  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Steve Block.

        Removes Geolocation::setPosition and uses positionChanged() to capture lastPosition().
        This brings CLIENT_BASED_GEOLOCATION more inline with the non-client based.
        https://bugs.webkit.org/show_bug.cgi?id=38195

        * page/Geolocation.cpp:
        (WebCore::Geolocation::lastPosition):
        (WebCore::Geolocation::requestPermission):
        (WebCore::Geolocation::positionChangedInternal):
        (WebCore::Geolocation::positionChanged):
        (WebCore::Geolocation::geolocationServicePositionChanged):
        * page/Geolocation.h:
        * page/GeolocationController.cpp:
        (WebCore::GeolocationController::positionChanged):
        (WebCore::GeolocationController::lastPosition):
        * page/GeolocationController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Marcus Bulach <bulach@chromium.org>
eric@webkit.org [Wed, 12 May 2010 08:31:30 +0000 (08:31 +0000)]
2010-05-12  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Steve Block.

        Attaches the geolocation bridge later on startUpdating().
        This prevents a page requesting permission when it has just accessed navigator.geolocation (without calling navigator.geolocation.getCurrentPosition/watchPosition).
        Note: when Geolocation::haveSuitableCachedPosition(), WebGeolocationServiceBridgeImpl::startUpdating() is not called,
        so we attach the bridge if needed at requestGeolocationPermissionForFrame().
        https://bugs.webkit.org/show_bug.cgi?id=38323
        http://crbug.com/42789

        * platform/chromium/GeolocationServiceChromium.h:
2010-05-12  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Steve Block.

        Attaches the geolocation bridge later on startUpdating().
        This prevents a page requesting permission when it has just accessed navigator.geolocation (without calling navigator.geolocation.getCurrentPosition/watchPosition).
        Note: when Geolocation::haveSuitableCachedPosition(), WebGeolocationServiceBridgeImpl::startUpdating() is not called,
        so we attach the bridge if needed at requestGeolocationPermissionForFrame().
        https://bugs.webkit.org/show_bug.cgi?id=38323
        http://crbug.com/42789

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame):
        * src/WebGeolocationServiceBridgeImpl.cpp:
        (WebKit::WebGeolocationServiceBridgeImpl::attachBridgeIfNeeded):
        (WebKit::WebGeolocationServiceBridgeImpl::setLastPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed fix.
ossy@webkit.org [Wed, 12 May 2010 08:28:07 +0000 (08:28 +0000)]
Unreviewed fix.

[Qt] Platform specific expected result updated after r59211.

* platform/qt/fast/css/pseudo-cache-stale-expected.txt: updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Robin Qiu <robin.qiu@torchmobile.com.cn>
eric@webkit.org [Wed, 12 May 2010 08:19:18 +0000 (08:19 +0000)]
2010-05-12  Robin Qiu  <robin.qiu@torchmobile.com.cn>

        Reviewed by Dirk Schulze.

        Fix a bug in SVGPathSegList::getPathSegAtLength().
        This bug is just a misktake: almost all of the code is OK, but the
        parameter is not used at all, therefore, this function always returns
        "1".
        And make a modification to return the last path segment if the distance
        exceeds the actual path length.
        https://bugs.webkit.org/show_bug.cgi?id=37515

        * svg/dom/svgpath-getPathSegAtLength-expected.txt: Added.
        * svg/dom/svgpath-getPathSegAtLength.html: Added.
2010-05-12  Robin Qiu  <robin.qiu@torchmobile.com.cn>

        Reviewed by Dirk Schulze.

        Fix a bug in SVGPathSegList::getPathSegAtLength().
        This bug is just a misktake: almost all of the code is OK, but the
        parameter is not used at all, therefore, this function always returns
        "1".
        And make a modification to return the last path segment if the distance
        exceeds the actual path length.
        https://bugs.webkit.org/show_bug.cgi?id=37515

        Test: svg/dom/svgpath-getPathSegAtLength.html

        * svg/SVGPathSegList.cpp:
        (WebCore::SVGPathSegList::getPathSegAtLength):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-12 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 12 May 2010 07:46:08 +0000 (07:46 +0000)]
2010-05-12  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] add DRT back to the chromium build
        https://bugs.webkit.org/show_bug.cgi?id=38978

        * WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=38976, fast/css/pseudo-cache-stale.html has...
hyatt@apple.com [Wed, 12 May 2010 07:01:26 +0000 (07:01 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=38976, fast/css/pseudo-cache-stale.html has incorrect results.

Reviewed by Maciej Stachowiak.

Make sure to trigger a relayout of any objects whose first-line styles change dynamically.

* dom/Element.cpp:
(WebCore::Element::pseudoStyleCacheIsInvalid):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-11 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Wed, 12 May 2010 05:50:38 +0000 (05:50 +0000)]
2010-05-11  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Shorthand Properties Getting Deleted When Editing
        https://bugs.webkit.org/show_bug.cgi?id=38958

        * inspector/front-end/DOMAgent.js:
        (WebInspector.CSSStyleDeclaration.prototype.styleTextWithShorthands): was getting regular values instead of shorthand values

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-11 Chris Jerdonek <cjerdonek@webkit.org>
cjerdonek@webkit.org [Wed, 12 May 2010 05:10:32 +0000 (05:10 +0000)]
2010-05-11  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Eric Seidel.

        Fixed two FIXME's in svn-apply: eliminated the unnecessary %copiedFiles
        variable and changed gitKnowsOfFile() to use exitStatus().

        https://bugs.webkit.org/show_bug.cgi?id=38862

        * Scripts/svn-apply:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-11 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 12 May 2010 04:56:54 +0000 (04:56 +0000)]
2010-05-11  Eric Seidel  <eric@webkit.org>

        Unreviewed, just fixing python typo.

        EWS bots should poll more often than every 5 minutes
        https://bugs.webkit.org/show_bug.cgi?id=38968

        Typo in _now(), add a unittest to prove I fixed it.

        * Scripts/webkitpy/tool/bot/queueengine.py:
        * Scripts/webkitpy/tool/bot/queueengine_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-11 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 12 May 2010 04:44:02 +0000 (04:44 +0000)]
2010-05-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Qt build failures cause SheriffBot false positives
        https://bugs.webkit.org/show_bug.cgi?id=38969

        The Qt buildbot randomly fails to compile occasionally because its
        network connection causes SVn to leave zero-byte files around.  These
        compile failures confuse SheriffBot into thinking someone's patch
        caused a build break.

        In this patch, I've temporarily removed Qt from the list of core
        builders.  Ossy is working on a script to clean up the zero byte files.
        Once that goes in, we can add Qt back to the core builders.

        * Scripts/webkitpy/common/net/buildbot.py:
        * Scripts/webkitpy/common/net/buildbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-11 Adam Barth <abarth@webkit.org>
eric@webkit.org [Wed, 12 May 2010 04:36:18 +0000 (04:36 +0000)]
2010-05-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        sheriffbot is spammy.
        https://bugs.webkit.org/show_bug.cgi?id=38936

        Reduce sheriffbot spam by not warning about new blameworthy revisions
        that can be explained by previously blamed revisions.  This might cause
        us to not warn about some real failures, but we're getting too much
        spam from slow builders that have large blamelists (and we've already
        poked the responsible folks using data from a fast builder).

        * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
            - Removed unneeded import
        * Scripts/webkitpy/tool/commands/sheriffbot.py:
            - The logic change
        * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
            - Tests of the change
        * Scripts/webkitpy/tool/mocktool.py:
            - Merged two declarations of MockBuilder

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSlight simplification to the calling convention: read RegisterFile::end()
ggaren@apple.com [Wed, 12 May 2010 04:30:35 +0000 (04:30 +0000)]
Slight simplification to the calling convention: read RegisterFile::end()
from an absolute address, instead of from a pointer to the RegisterFile
on the stack.

Reviewed by Gavin Barraclough.

SunSpider reports no change.

This should free us to remove the RegisterFile argument from the stack.

* jit/JIT.cpp:
(JSC::JIT::privateCompile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-11 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 12 May 2010 04:20:08 +0000 (04:20 +0000)]
2010-05-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        sheriffbot is spammy.
        https://bugs.webkit.org/show_bug.cgi?id=38936

        Reduce sheriffbot spam by not warning about new blameworthy revisions
        that can be explained by previously blamed revisions.  This might cause
        us to not warn about some real failures, but we're getting too much
        spam from slow builders that have large blamelists (and we've already
        poked the responsible folks using data from a fast builder).

        * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
            - Removed unneeded import
        * Scripts/webkitpy/tool/commands/sheriffbot.py:
            - The logic change
        * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
            - Tests of the change
        * Scripts/webkitpy/tool/mocktool.py:
            - Merged two declarations of MockBuilder

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-11 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 12 May 2010 03:53:35 +0000 (03:53 +0000)]
2010-05-11  Tony Chang  <tony@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Remove subframe scrollbar routing (r58937)
        https://bugs.webkit.org/show_bug.cgi?id=38894

        * platform/win/Skipped: This test should pass on windows.
2010-05-11  Tony Chang  <tony@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Remove subframe scrollbar routing (r58937)
        https://bugs.webkit.org/show_bug.cgi?id=38894

        * page/chromium/EventHandlerChromium.cpp:
        (WebCore::EventHandler::passMousePressEventToSubframe):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPossible Gtk build fix - use ALWAYS_INLINE on functions that were inlined.
bweinstein@apple.com [Wed, 12 May 2010 03:53:13 +0000 (03:53 +0000)]
Possible Gtk build fix - use ALWAYS_INLINE on functions that were inlined.

* wtf/text/AtomicString.h:
(WebCore::AtomicString::add): Use ALWAYS_INLINE.
* wtf/text/WTFString.h:
(WebCore::String::length): Ditto.
(WebCore::String::isEmpty): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-11 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 12 May 2010 03:51:18 +0000 (03:51 +0000)]
2010-05-11  Tony Chang  <tony@chromium.org>

        Reviewed by David Levin.

        [chromium] detect num processors to pass to make -j on Linux
        https://bugs.webkit.org/show_bug.cgi?id=38833

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-11 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 12 May 2010 03:41:40 +0000 (03:41 +0000)]
2010-05-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        commit-queue should commit rollouts without running tests
        https://bugs.webkit.org/show_bug.cgi?id=38940

        Most of this change is improving our test coverage for the commit-queue.
        The only functional change is removing the --test flag when the commit-queue
        is running in rollouts mode.

        I added test coverage for status updates, and updated the commit-queue status
        messages to distinguish rollout vs. normal landing mode in its empty queue
        and land patch messages.

        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
         - Got rid of a bunch of copy/paste code using _default_expected_stderr
        * Scripts/webkitpy/tool/commands/queues.py:
         - Moved rollout patch filtering out of _validate_patches_in_commit_queue
           so that we only have to check if the builders are green in one place.
         - Make the "empty queue" message note which queue it is referring to.
         - Don't pass --text to land-attachment when in rollout mode.
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
         - Update results now that we're testing status updates.
         - Test _can_build_and_test since I made a typo in that call while
           writing this change and the unit tests failed to catch it!
        * Scripts/webkitpy/tool/mocktool.py:
         - Log status updates to make them testable in our unit tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 12 May 2010 03:25:52 +0000 (03:25 +0000)]
2010-05-11  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Maciej Stachowiak.

        Body not redrawn, and filled with garbage on some composited pages
        https://bugs.webkit.org/show_bug.cgi?id=38951
        <rdar://problem/7891548>

        When the root layer becomes composited (for example, because a negative z-index
        descendant in its stacking context becomes composited), then it has to be made
        large enough to fill the viewport, because the page background draws into it.

        Test: compositing/geometry/composited-html-size.html

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::calculateCompositedBounds):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd a compile time assert that sizeof(String) == sizeof(AtomicString).
andersca@apple.com [Wed, 12 May 2010 02:33:32 +0000 (02:33 +0000)]
Add a compile time assert that sizeof(String) == sizeof(AtomicString).

Reviewed by Sam Weinig.

* wtf/text/AtomicString.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-11 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 12 May 2010 02:28:23 +0000 (02:28 +0000)]
2010-05-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=38961
        Move some member variables around to reduce class sizes.

        Make AtomicString no longer inherit from FastAllocBase.

        Since AtomicString's first (and only) member variable, a RefPtr, also inherits from FastAllocBase this
        was causing the size of AtomicString to contain sizeof(void*) bytes of padding.

        * wtf/text/AtomicString.h:
2010-05-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=38961
        Move some member variables around to reduce class sizes.

        If a class inherits (directly or indirectly) from FastAllocBase, we don't want the first member variable
        of that class to also inherit (directly or indirectly) from FastAllocBase as this will add padding to the class
        and thus increasing its size.

        * css/CSSParserValues.h:
        * css/CSSSelector.h:
        (WebCore::CSSSelector::CSSSelector):
        (WebCore::CSSSelector::RareData::RareData):
        * platform/graphics/FontCache.cpp:
        (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPatch by Gavin Barraclough.
bweinstein@apple.com [Wed, 12 May 2010 02:25:40 +0000 (02:25 +0000)]
Patch by Gavin Barraclough.

Reviewed by Maciej Stachowiak.

Rest of REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>

Inline string functions that are commonly used in WTFString, CString, and AtomicString.

* JavaScriptCore.exp: Remove exports of inline functions.
* wtf/text/AtomicString.cpp:
(WebCore::AtomicString::addSlowCase): Rename add to addSlowCase, and inline the fast path
    of add.
* wtf/text/AtomicString.h:
(WebCore::AtomicString::add): Inline the fast path of add.
* wtf/text/CString.cpp: Inline implementation of data and length in the header.
* wtf/text/CString.h:
(WTF::CString::data): Inline implementation of data.
(WTF::CString::length): Inline implementation of length.
* wtf/text/WTFString.cpp: Remove implementations of functions to be inlined.
* wtf/text/WTFString.h:
(WebCore::String::String): Inline implementation.
(WebCore::String::length): Ditto.
(WebCore::String::characters): Ditto.
(WebCore::String::operator[]): Ditto.
(WebCore::String::isEmpty): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdding a function needed by the V8 code generator to turn on/off
dumi@chromium.org [Wed, 12 May 2010 02:20:47 +0000 (02:20 +0000)]
Adding a function needed by the V8 code generator to turn on/off
the binding for WorkerContext::openDatabaseSync().
https://bugs.webkit.org/show_bug.cgi?id=38960

Reviewed by Adam Barth.

* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::openDatabaseSyncEnabled):
* bindings/generic/RuntimeEnabledFeatures.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-11 MORITA Hajime <morrita@google.com>
morrita@google.com [Wed, 12 May 2010 02:15:00 +0000 (02:15 +0000)]
2010-05-11  MORITA Hajime  <morrita@google.com>

        Reviewed by Dirk Schulze.

        CSS SVG font doesn't recognize URL without element reference
        https://bugs.webkit.org/show_bug.cgi?id=37144

        * platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
        * platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
        * platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
        * svg/custom/resources/graffiti-with-empty-first-font.svg: Added.
        * svg/custom/svg-fonts-with-no-element-reference.html: Added.
2010-05-11  MORITA Hajime  <morrita@google.com>

        Reviewed by Dirk Schulze.

        CSS SVG font doesn't recognize URL without element reference
        https://bugs.webkit.org/show_bug.cgi?id=37144

        CachedFont::getSVGFontById() did assume that element reference (ID) is given.
        So fixed to handle an empty or missing element reference. In which case,
        the first font element is returned if available.

        Test: svg/custom/svg-fonts-with-no-element-reference.html

        * loader/CachedFont.cpp:
        (WebCore::CachedFont::getSVGFontById):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-11 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 12 May 2010 01:53:30 +0000 (01:53 +0000)]
2010-05-11  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [DRT/Chromium] Apply recent changes of test_shell to DRT
        https://bugs.webkit.org/show_bug.cgi?id=38895

        * DEPS: Update Chromium revision to use the recent webkit_support change.
        * WebKit.gyp: Add JavaScriptCore/wtf to 'include' section.
        * src/WebGraphicsContext3D.cpp:
          Remove ENABLE(3D_CANVAS) to provide an empty implementation of
          WebGraphicsContext3D::createDefault().
2010-05-11  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [DRT/Chromium] Apply recent changes of test_shell to DRT
        https://bugs.webkit.org/show_bug.cgi?id=38895

        Port the changes to test_shell during (r40492, r46810] of Chromium.
        Highlights:
        - Introduce NotificationPresenter
        - Fix parameter mismatch of WebViewClient::startDragging()

        This change fixes dozens of unexpected behaviors.

        * DumpRenderTree/DumpRenderTree.gypi:
          Add NotificationPresenter.{cpp,h}
        * DumpRenderTree/chromium/EventSender.cpp:
        (applyKeyModifier):
        (EventSender::EventSender):
        (EventSender::reset):
        (EventSender::webview):
        (EventSender::doDragDrop):
        (EventSender::keyDown):
        (EventSender::addTouchPoint):
        (EventSender::clearTouchPoints):
        (EventSender::releaseTouchPoint):
        (EventSender::setTouchModifier):
        (EventSender::updateTouchPoint):
        (EventSender::cancelTouchPoint):
        (EventSender::sendCurrentTouchEvent):
        (EventSender::touchEnd):
        (EventSender::touchMove):
        (EventSender::touchStart):
        (EventSender::touchCancel):
        * DumpRenderTree/chromium/EventSender.h:
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::reset):
        (LayoutTestController::showWebInspector):
        (LayoutTestController::setAuthorAndUserStylesEnabled):
        (LayoutTestController::setScrollbarPolicy):
        (LayoutTestController::setWillSendRequestClearHeader):
        (LayoutTestController::callShouldCloseOnWebView):
        (LayoutTestController::grantDesktopNotificationPermission):
        (LayoutTestController::removeOriginAccessWhitelistEntry):
        (LayoutTestController::addUserScript):
        (LayoutTestController::addUserStyleSheet):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/chromium/NotificationPresenter.cpp: Added.
        * DumpRenderTree/chromium/NotificationPresenter.h: Added.
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell):
        (TestShell::runFileTest):
        (TestShell::resetTestController):
        * DumpRenderTree/chromium/TestShell.h:
        (TestShell::eventSender):
        (TestShell::notificationPresenter):
        (TestShell::showDevTools):
        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::createView):
        (WebViewHost::createPopupMenu):
        (WebViewHost::startDragging):
        (WebViewHost::notificationPresenter):
        (WebViewHost::createApplicationCacheHost):
        (WebViewHost::willSendRequest):
        (WebViewHost::updateAddressBar):
        (WebViewHost::updateURL):
        * DumpRenderTree/chromium/WebViewHost.h:
        (WebViewHost::addClearHeader):
        (WebViewHost::clearHeaders):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNo Review.
jer.noble@apple.com [Wed, 12 May 2010 01:35:15 +0000 (01:35 +0000)]
No Review.

Fix the Windows Debug Build: the correct VCProj variable to use when linking against
JavaScriptCore is $(WebKitDLLConfigSuffix), not $(WebKitConfigSuffix), which expands
to an empty string rather than "_debug".

* WebCore.vcproj/QTMovieWin.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNo Review.
jer.noble@apple.com [Wed, 12 May 2010 01:16:25 +0000 (01:16 +0000)]
No Review.

Fix build error: The QTMovieWin project is dependent on the JavaScriptCore project.

* WebKit.vcproj/WebKit.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-11 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Wed, 12 May 2010 00:41:48 +0000 (00:41 +0000)]
2010-05-11  Jer Noble  <jer.noble@apple.com>

        Darin Adler.

        19 media tests are crashing on Windows Release
        https://bugs.webkit.org/show_bug.cgi?id=38950
        rdar://problem/7971658

        Link against JavaScriptCore.lib instead of WTF.lib, so the free and malloc used by
        QTMovieWin is always the free and malloc in JavaScriptCore.dll.

        * WebCore.vcproj/QTMovieWin.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAnother refactoring patch in preparation for a fix to
darin@apple.com [Wed, 12 May 2010 00:35:38 +0000 (00:35 +0000)]
Another refactoring patch in preparation for a fix to
https://bugs.webkit.org/show_bug.cgi?id=38871
REGRESSION: Crash clicking background NPR tab after few minutes of sitting idle

Reviewed by Beth Dakin.

* dom/Document.cpp:
(WebCore::Document::addMediaCanStartListener): Added.
(WebCore::Document::removeMediaCanStartListener): Added.

* dom/Document.h: Added add/removeMediaCanStartListener.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement): Call removeMediaCanStartListener
on the document instead of the page.
(WebCore::HTMLMediaElement::willMoveToNewOwnerDocument): Call
removeMediaCanStartListener on the current document.
(WebCore::HTMLMediaElement::didMoveToNewOwnerDocument): Call
addMediaCanStartListener on the new document.
(WebCore::HTMLMediaElement::loadInternal): Call addMediaCanStartListener
on the document instead of the page.

* plugins/PluginView.cpp:
(WebCore::PluginView::startOrAddToUnstartedList): Call addMediaCanStartListener
on the document instead of the page.
(WebCore::PluginView::~PluginView): Call removeMediaCanStartListener
on the document instead of the page, and do it in line instead of calling
a function.

* plugins/PluginView.h: Removed unused removeFromUnstartedListIfNecessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Not reviewed.
ap@apple.com [Wed, 12 May 2010 00:26:03 +0000 (00:26 +0000)]
    Not reviewed.

        https://bugs.webkit.org/show_bug.cgi?id=38956
        [Gtk] http/tests/xmlhttprequest/basic-auth-default.html fails

        * platform/gtk/Skipped: Skipping the new failing test on Gtk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore: Patch by Gavin Barraclough.
bweinstein@apple.com [Wed, 12 May 2010 00:22:28 +0000 (00:22 +0000)]
JavaScriptCore: Patch by Gavin Barraclough.

Reviewed by Steve Falkenburg and Jon Honeycutt.

REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>

When the String classes were moved from WebCore to WTF, it meant that on Windows, all operations
on Strings in WebCore had to cross a DLL boundary (from WebKit.dll to JavaScript.dll).

We fix this by refactoring some of the WTF string code, so the code in AtomicString, StringImpl, and
WTFString can be built by both WebCore and WTF, and we don't need to talk across a DLL to do operations
on Strings.

* GNUmakefile.am: Add new file to build system.
* JavaScriptCore.gypi: Ditto.
* JavaScriptCore.pro: Ditto.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove string exports, because these are now
    handled in WebCore.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Remove the post-build step that was added
    here (the post build step is in JavaScriptCoreCommon.vsprops).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Copy the three cpp files that need to be compiled
    by WebCore into the WebKitOutputDir directory.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Add the StringStatics file.
* JavaScriptCore.vcproj/jsc/jsc.vcproj: Add the three WTF string cpp files to this project.
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Remove the need to link against WTF.lib (since jsc links against JavaScriptCore).
* JavaScriptCore.xcodeproj/project.pbxproj: Add the StringStatics file.
* wtf/text/AtomicString.cpp: Moved code to StringStatics.
* wtf/text/StringImpl.cpp: Ditto.
* wtf/text/StringStatics.cpp: Added. Move functions in WTF Strings that define static variables to here, so
    the rest of the files can be compiled in WebCore.
(WebCore::StringImpl::empty): Moved from StringImpl.cpp to here.
(WebCore::AtomicString::init): Moved from AtomicString.cpp to here.

WebCore: Patch by Gavin Barraclough.

Reviewed by Steve Falkenburg and Jon Honeycutt.

REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>

Add the WTF strings into the WebCore vcproj, from their copied location in $(WebKitOutputDir).

No new tests because no change in behavior.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSmall re-factoring patch in preparation for fixing https://
bdakin@apple.com [Wed, 12 May 2010 00:04:26 +0000 (00:04 +0000)]
Small re-factoring patch in preparation for fixing https://
bugs.webkit.org/show_bug.cgi?id=38871 REGRESSION: Crash clicking
background NPR tab after few minutes of sitting idle

Reviewed by Darin Adler.

* page/Page.cpp:
(WebCore::Page::takeAnyMediaCanStartListener):
(WebCore::Page::setCanStartMedia):
* page/Page.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Brady Eidson.
ap@apple.com [Tue, 11 May 2010 23:41:25 +0000 (23:41 +0000)]
    Reviewed by Brady Eidson.

        https://bugs.webkit.org/show_bug.cgi?id=37989
        Safari (still) doesn't always send basic credentials preemptively

        Test: http/tests/xmlhttprequest/basic-auth-default.html

        After fetching credentials from WebCore storage, put them back right away. This will add
        default credentials for the directory, since this may be the first time we learn about its
        associated protection space.

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
        (WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
        (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Tue, 11 May 2010 23:41:16 +0000 (23:41 +0000)]
Reviewed by Kevin Ollivier.

Load a blank page on creation to initialize WebCore objects properly.
https://bugs.webkit.org/show_bug.cgi?id=38932

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Tue, 11 May 2010 23:39:02 +0000 (23:39 +0000)]
Reviewed by Kevin Ollivier.

[wx] Create an NSFont on Mac builds that do not have built-in methods to do so.
https://bugs.webkit.org/show_bug.cgi?id=38931

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-10 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 11 May 2010 23:22:14 +0000 (23:22 +0000)]
2010-05-10  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        new-run-webkit-tests: fix a path-handling bug that was breaking the
        dryrun ports on windows, and add a comment about why we don't run
        the chromium dryrun tests by default on every port.

        https://bugs.webkit.org/show_bug.cgi?id=38796

        * Scripts/webkitpy/layout_tests/port/dryrun.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<http://webkit.org/b/38941> build-webkit shouldn't always override ENABLE_FOO Xcode...
mrowe@apple.com [Tue, 11 May 2010 23:12:23 +0000 (23:12 +0000)]
<webkit.org/b/38941> build-webkit shouldn't always override ENABLE_FOO Xcode configuration settings

Reviewed by Darin Adler.

* Scripts/build-webkit: Don't pass the ENABLE setting to xcodebuild if the value matches the default.
This will lead to xcodebuild picking up the settings from FeatureDefines.xcconfig, and will aid in
revealing problems that are due to inconsistent values for settings across projects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed. Remove unneeded rebaselined result for enter-clicks-buttons.html
jianli@chromium.org [Tue, 11 May 2010 23:11:02 +0000 (23:11 +0000)]
Unreviewed. Remove unneeded rebaselined result for enter-clicks-buttons.html

* platform/chromium-win/fast/forms/enter-clicks-buttons-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-11 Avi Drissman <avi@chromium.org>
eric@webkit.org [Tue, 11 May 2010 23:04:34 +0000 (23:04 +0000)]
2010-05-11  Avi Drissman  <avi@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Pipe RTL info into WebPopupMenuInfo
        https://bugs.webkit.org/show_bug.cgi?id=38749

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::menuStyle):
        * platform/chromium/PopupMenuChromium.h:
2010-05-11  Avi Drissman  <avi@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Pipe RTL info into WebPopupMenuInfo
        https://bugs.webkit.org/show_bug.cgi?id=38749

        * public/WebPopupMenuInfo.h:
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::getPopupMenuInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix build error when enabling debugging block in WebKit win painting code
alice.liu@apple.com [Tue, 11 May 2010 22:56:19 +0000 (22:56 +0000)]
Fix build error when enabling debugging block in WebKit win painting code

Rubber-stamped by Gavin Barraclough.

JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

WebKit/win:

* WebView.cpp:
(WebView::paintIntoBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix.
mrowe@apple.com [Tue, 11 May 2010 22:43:23 +0000 (22:43 +0000)]
Build fix.

* DumpRenderTree/mac/LayoutTestControllerMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-11 David Holloway <dhollowa@chromium.org>
eric@webkit.org [Tue, 11 May 2010 22:39:20 +0000 (22:39 +0000)]
2010-05-11  David Holloway  <dhollowa@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Add size method to WebInputElement class, providing same data
        as HTMLInputElement::size().  During form AutoFill Chromium needs to
        access the input element's size attribute in aid of form matching and
        filling heuristics.

        https://bugs.webkit.org/show_bug.cgi?id=38825

        * public/WebInputElement.h:
        * src/WebInputElement.cpp:
        (WebKit::WebInputElement::size):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=38937
alice.liu@apple.com [Tue, 11 May 2010 22:28:32 +0000 (22:28 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=38937
W7 window preview paints content at the wrong location

Reviewed by Steve Falkenburg.

* WebFrame.cpp:
(WebFrame::paintDocumentRectToContext): Revert r58895
(WebFrame::paintDocumentRectToContextAtPoint): Added

* Interfaces/IWebFramePrivate.idl: Added paintDocumentRectToContextAtPoint
* Interfaces/IWebViewPrivate.idl: ditto
* Interfaces/WebKit.idl: touch to rebuild
* WebFrame.h: ditto
* WebView.cpp: ditto
(WebView::paintDocumentRectToContextAtPoint): ditto
* WebView.h: ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the world.
mrowe@apple.com [Tue, 11 May 2010 22:19:52 +0000 (22:19 +0000)]
Fix the world.

In r59162 a change was made to WebCore's FeatureDefines.xcconfig that enabled FILE_READER and FILE_WRITER.
The author and reviewer of that patch ignored the carefully-worded warning at the top of that file asking
that changes to the file be kept in sync across JavaScriptCore, WebCore and WebKit, as well as being kept
in sync with build-webkit.  This led to WebCore and WebKit having different views of Document's vtable
and results in crashes in Safari shortly after launch when virtual function calls resulted in the wrong
function in WebCore being called.

We fix this by bringing the FeatureDefines.xcconfig files in to sync.  Based on the ChangeLog message and
other changes in r59162 it appears that enabling FILE_WRITER was unintentional so that particular change
has been reverted.

JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

WebCore:

* Configurations/FeatureDefines.xcconfig:

WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

WebKit2:

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-11 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 11 May 2010 22:01:27 +0000 (22:01 +0000)]
2010-05-11  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION(r58520): Implicit submission on forms with button type="submit" no longer works
        https://bugs.webkit.org/show_bug.cgi?id=38913

        Updated the test to include coverage of button elements.

        * fast/forms/enter-clicks-buttons-expected.txt: Updated expectations to account for implicit
            submission which now correctly happens from the right element (button).
        * fast/forms/implicit-submission-expected.txt: Updated expectations with new test results.
        * fast/forms/implicit-submission.html: Added tests and code to cover button elements.
2010-05-11  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION(r58520): Implicit submission on forms with button type="submit" no longer works
        https://bugs.webkit.org/show_bug.cgi?id=38913

        * Widened the check for a successful submit button to include all HTMLFormControlElements.
        * Clarified implicit submission code by:
            - introducing HTMLFormControlElement::canTriggerImplicitSubmission flag,
            - getting rid of static casting and checking for tag names.

        * html/HTMLFormControlElement.h:
        (WebCore::HTMLFormControlElement::canTriggerImplicitSubmission): Added.
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::submitImplicitly): Renamed parameters for clarity, refactored code
            to use canTriggerImplicitSubmission.
        * html/HTMLFormElement.h: Renamed parameter for clarity.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::defaultEventHandler):  Used canTriggerImplicitSubmission()
            instead of isTextField() for clarity.
        * html/HTMLInputElement.h:
        (WebCore::HTMLInputElement::canTriggerImplicitSubmission): Added.
        * html/HTMLIsIndexElement.h:
        (WebCore::HTMLIsIndexElement::canTriggerImplicitSubmission): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-11 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Tue, 11 May 2010 21:35:39 +0000 (21:35 +0000)]
2010-05-11  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r59171.
        http://trac.webkit.org/changeset/59171
        https://bugs.webkit.org/show_bug.cgi?id=38933

        "Broke the world" (Requested by bweinstein on #webkit).

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.vcproj/jsc/jsc.vcproj:
        * JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * wtf/text/AtomicString.cpp:
        (WebCore::AtomicString::init):
        * wtf/text/StringImpl.cpp:
        (WebCore::StringImpl::empty):
        * wtf/text/StringStatics.cpp: Removed.
2010-05-11  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r59171.
        http://trac.webkit.org/changeset/59171
        https://bugs.webkit.org/show_bug.cgi?id=38933

        "Broke the world" (Requested by bweinstein on #webkit).

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore: Patch by Gavin Barraclough.
bweinstein@apple.com [Tue, 11 May 2010 20:52:51 +0000 (20:52 +0000)]
JavaScriptCore: Patch by Gavin Barraclough.

Reviewed by Steve Falkenburg.

REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>

When the String classes were moved from WebCore to WTF, it meant that on Windows, all operations
on Strings in WebCore had to cross a DLL boundary (from WebKit.dll to JavaScript.dll).

We fix this by refactoring some of the WTF string code, so the code in AtomicString, StringImpl, and
WTFString can be built by both WebCore and WTF, and we don't need to talk across a DLL to do operations
on Strings.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove string exports, because these are now
    handled in WebCore.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Remove the post-build step that was added
    here (the post build step is in JavaScriptCoreCommon.vsprops).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Copy the three cpp files that need to be compiled
    by WebCore into the WebKitOutputDir directory.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Add the StringStatics file.
* JavaScriptCore.vcproj/jsc/jsc.vcproj: Add the three WTF string cpp files to this project.
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Remove the need to link against WTF.lib (since jsc links against JavaScriptCore).
* JavaScriptCore.xcodeproj/project.pbxproj: Add the StringStatics file.
* wtf/text/AtomicString.cpp: Moved code to StringStatics.
* wtf/text/StringImpl.cpp: Ditto.
* wtf/text/StringStatics.cpp: Added. Move functions in WTF Strings that define static variables to here, so
    the rest of the files can be compiled in WebCore.
(WebCore::StringImpl::empty): Moved from StringImpl.cpp to here.
(WebCore::AtomicString::init): Moved from AtomicString.cpp to here.

WebCore: Patch by Gavin Barraclough.

Reviewed by Steve Falkenburg.

REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>

Add the WTF strings into the WebCore vcproj, from their copied location in $(WebKitOutputDir).

No new tests because no change in behavior.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFixed test failures seen on SnowLeopard buildbot.
ggaren@apple.com [Tue, 11 May 2010 20:38:13 +0000 (20:38 +0000)]
Fixed test failures seen on SnowLeopard buildbot.

* runtime/JSString.cpp:
(JSC::JSString::replaceCharacter): Don't use size_t and wtf::notFound.
Instead, use the individual types and notFound values of the string APIs
we're using, since they're not necessarily the same in 64bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-11 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 11 May 2010 20:32:15 +0000 (20:32 +0000)]
2010-05-11  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Crash fix in WebPageSerializerImpl::serialize().

        https://bugs.webkit.org/show_bug.cgi?id=38543

        The relevant test is a test_shell_test in src.chromium.org, because neither
        DRT nor the Chromium webkit unit tests can currently cover the serializer
        functionality.

        * src/WebPageSerializerImpl.cpp:
        (WebKit::WebPageSerializerImpl::serialize): Check each frame's url before using it,
            since they are not guaranteed to be valid (e.g., if the frame was treated as a download).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-10 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 11 May 2010 20:11:27 +0000 (20:11 +0000)]
2010-05-10  Ojan Vafai  <ojan@chromium.org>

        Reviewed by David Levin.

        CheckStyle was eating script errors when there were local-commits and working copy changes
        https://bugs.webkit.org/show_bug.cgi?id=38880

        * Scripts/webkitpy/tool/steps/checkstyle.py:
        * Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59168 268f45cc-cd09-0410-ab3c-d52691b4dbfc