15 years ago Reviewed by Adam.
andersca@apple.com [Tue, 27 Nov 2007 22:21:24 +0000 (22:21 +0000)]
    Reviewed by Adam.

        Make PropertyNameArray and ScopeChain COMEnumVariant friendly.

        * kjs/PropertyNameArray.cpp:
        Implement PropertyNameArray::swap.

        * kjs/PropertyNameArray.h:
        Add ValueType typedef. Replace PropertyNameArrayIterator with

        * kjs/nodes.cpp:
        * kjs/scope_chain.cpp:
        Update for changes to PropertyNameArray.

        * kjs/scope_chain.h:
        Add const_iterator and ValueType typedef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
andersca@apple.com [Tue, 27 Nov 2007 21:48:33 +0000 (21:48 +0000)]
    Reviewed by Adam.

        Use the correct include paths.

        * COMEnumVariant.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
andersca@apple.com [Tue, 27 Nov 2007 21:43:18 +0000 (21:43 +0000)]
    Reviewed by Darin.

        Add COMEnumVariant, a templatized class with implements IEnumVARIANT and lets
        you enumerate over a C++ container, be it WTF or STL.

        * COMEnumVariant.h: Added.

        * WebDatabaseManager.cpp:
        Implement these using COMEnumVariant.

        * WebSecurityOrigin.cpp:
        * WebSecurityOrigin.h:
        Add a UUID for the implementation so that other parts of WebKit can access
        the WebCore::SecurityOriginData object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
andersca@apple.com [Tue, 27 Nov 2007 21:27:59 +0000 (21:27 +0000)]
    Reviewed by Darin.

        Add a ValueType typedef.

        * wtf/Vector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
timothy@apple.com [Tue, 27 Nov 2007 21:23:22 +0000 (21:23 +0000)]
    Reviewed by Adam Roben.

        * page/inspector/inspector.css: Make the text in the Network
        panel legend more readable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
timothy@apple.com [Tue, 27 Nov 2007 20:51:51 +0000 (20:51 +0000)]
    Reviewed by Adam Roben.

        Don't call setNeedsReapplyStylesInAllFrames if the
        authorAndUserStylesEnabled setting didn't change.

        * page/Settings.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-27 Alp Toker <alp@atoker.com>
alp@webkit.org [Tue, 27 Nov 2007 18:53:54 +0000 (18:53 +0000)]
2007-11-27  Alp Toker  <alp@atoker.com>

        Fix potential broken build due to a missing DEPENDPATH.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fixed 5614525, caused by a recent bug in WKGetExtensionsForMIMEType
sullivan@apple.com [Tue, 27 Nov 2007 18:48:20 +0000 (18:48 +0000)]
    Fixed 5614525, caused by a recent bug in WKGetExtensionsForMIMEType
        that affects Safari.

        reviewed by Kevin Decker

        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
timothy@apple.com [Tue, 27 Nov 2007 17:15:19 +0000 (17:15 +0000)]

        Reviewed by Dave Hyatt.

        <rdar://problem/5569233> Add the ability to disable author and user CSS styles

        * WebCore.base.exp: Add the Settings::setAuthorAndUserStylesEnabled symbol.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::CSSStyleSelector): Add a new matchAuthorAndUserStyles parameter.
        (WebCore::CSSStyleSelector::styleForElement): Check m_matchAuthorAndUserStyles before
        matching user and author rules.
        (WebCore::CSSStyleSelector::pseudoStyleForElement): Ditto.
        (WebCore::CSSStyleSelector::styleRulesForElement): Ditto.
        * css/CSSStyleSelector.h: Add m_matchAuthorAndUserStyles and new constructor parameter.
        * dom/Document.cpp:
        (WebCore::Document::Document): Pass Settings::authorAndUserStylesEnabled to the CSSStyleSelector.
        (WebCore::Document::recalcStyleSelector): Skip collecting the author stylesheets if
        Settings::authorAndUserStylesEnabled is false, and pass that to the CSSStyleSelector.
        * page/Settings.cpp:
        (WebCore::Settings::Settings): Initialize m_authorAndUserStylesEnabled to true.
        (WebCore::Settings::setAuthorAndUserStylesEnabled): Recalc style in all the frames
        when the setting changes.
        * page/Settings.h: Add m_authorAndUserStylesEnabled.
        (WebCore::Settings::authorAndUserStylesEnabled): Return m_authorAndUserStylesEnabled.


        Reviewed by Dave Hyatt.

        <rdar://problem/5569233> Add the ability to disable author and user CSS styles

        * WebView/WebPreferenceKeysPrivate.h: Define WebKitRespectStandardStyleKeyEquivalentsPreferenceKey.
        * WebView/WebPreferences.m:
        (+[WebPreferences initialize]): Default WebKitRespectStandardStyleKeyEquivalentsPreferenceKey to YES.
        (-[WebPreferences authorAndUserStylesEnabled]): Return the setting's BOOL value.
        (-[WebPreferences setAuthorAndUserStylesEnabled:]): Set the setting's BOOL value.
        * WebView/WebPreferencesPrivate.h: Add authorAndUserStylesEnabled and setAuthorAndUserStylesEnabled:.
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]): Update WebCore::Settings::authorAndUserStylesEnabled.


        Reviewed by Dave Hyatt.

        <rdar://problem/5569233> Add the ability to disable author and user CSS styles

        Add support for disabling author and user styles for testing.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/LayoutTestController.cpp:
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:


        Reviewed by Dave Hyatt.

        Test for: <rdar://problem/5569233> Add the ability to disable author and user CSS styles

        * fast/css/disabled-author-styles.html: Added.
        * platform/mac/fast/css/disabled-author-styles-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-27 Alp Toker <alp@atoker.com>
alp@webkit.org [Tue, 27 Nov 2007 08:15:36 +0000 (08:15 +0000)]
2007-11-27  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Based on changes by Mike Emmel.

        CURL HTTP backend local file fixes:

        Set a MIME type for local files based on the file extension.

        Remove any HTTP query part sent to a local file.

        * platform/network/curl/ResourceHandleManager.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
beidson@apple.com [Tue, 27 Nov 2007 03:28:31 +0000 (03:28 +0000)]

        Reviewed by Mark Rowe

        Allow setting the default storage quota per database origin

        * WebCore.base.exp:

        * page/Settings.cpp:
        * page/Settings.h:

        * storage/DatabaseTracker.cpp:
        * storage/DatabaseTracker.h:


        Reviewed by Mark Rowe

        Provide API for setting the default storage quota per database origin

        * Misc/WebNSDictionaryExtras.h:
        * Misc/WebNSDictionaryExtras.m:
        (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Helper for UINT64 preferences

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.m:
        (-[WebPreferences _unsignedLongLongValueForKey:]): Helper for UINT64 prefs
        (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto
        (-[WebPreferences defaultDatabaseQuota]):
        (-[WebPreferences setDefaultDatabaseQuota:]):
        * WebView/WebPreferencesPrivate.h:

        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]): Set the WebCore Settings version of the default storage pref

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-26 Peter Kasting <zerodpx@gmail.com>
alp@webkit.org [Tue, 27 Nov 2007 03:01:23 +0000 (03:01 +0000)]
2007-11-26  Peter Kasting  <zerodpx@gmail.com>

        Reviewed by Alp Toker.

        GIF decoding should respect frames' specified disposal methods.

        * platform/image-decoders/ImageDecoder.h:
        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        * platform/image-decoders/gif/GIFImageDecoder.h:
        * platform/image-decoders/gif/GIFImageReader.cpp:
        * platform/image-decoders/gif/GIFImageReader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Make WebKitGraphics able to handle grayscale colors
aroben@apple.com [Tue, 27 Nov 2007 02:20:03 +0000 (02:20 +0000)]
 Make WebKitGraphics able to handle grayscale colors


         Add a Color(CGColorRef) constructor

         Reviewed by Darin.

         * platform/graphics/Color.h:
         * platform/graphics/cg/ColorCG.cpp:
         (WebCore::Color::Color): Added.


         Take advantage of the new Color constructor that takes a CGColorRef

         This lets us handle grayscale colors (which only have 2 components).

         Reviewed by Darin.

         * WebKitGraphics.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
adele@apple.com [Tue, 27 Nov 2007 02:15:10 +0000 (02:15 +0000)]
    Reviewed by Darin.

        Update to last change.  Moved addPendingSheet call to within nil check for m_cachedSheet.

        * page/Frame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-26 Alp Toker <alp@atoker.com>
alp@webkit.org [Tue, 27 Nov 2007 02:08:11 +0000 (02:08 +0000)]
2007-11-26  Alp Toker  <alp@atoker.com>

        Reviewed by Adam Roben.

        Implement the window-object-cleared signal

        This implementation provides the JSGlobalContextRef and JSObjectRef
        directly rather than using an intermediate JS wrapper object, similar
        to the approach taken by the Win port.

        * Api/webkitgtk-marshal.list:
        * Api/webkitgtkframe.h:
        * Api/webkitgtkpage.cpp:
        * Api/webkitgtkpage.h:
        * WebCoreSupport/FrameLoaderClientGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
adele@apple.com [Tue, 27 Nov 2007 02:07:17 +0000 (02:07 +0000)]
    Reviewed by Darin.

        Fix for <rdar://problem/5591583> CrashTracer: [USER] 157 in Mail crashes at -[WebCoreFrameBridge reapplyStylesForDeviceType:]

        * page/Frame.cpp: Add nil checks since every other caller of requestCSSStyleSheet checks for nil.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoGCC 4.2 build fix.
mrowe@apple.com [Tue, 27 Nov 2007 02:05:03 +0000 (02:05 +0000)]
GCC 4.2 build fix.

* xml/XSLTUnicodeSort.cpp: Add another WTF_ATTRIBUTE_PRINTF.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
weinig@apple.com [Tue, 27 Nov 2007 01:52:43 +0000 (01:52 +0000)]

        Reviewed and touched up by Sam Weinig.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=16073

        Test: http/tests/security/xss-DENIED-invalid-domain-change.html

        * dom/Document.cpp:
        (WebCore::Document::setDomain): Don't set the securityOrigin policy unless
        the set succeeds.  Adds some early returns as well.


        Reviewed by Sam Weinig.

        Tests for http://bugs.webkit.org/show_bug.cgi?id=16073

        * http/tests/security/resources/iframe-invalid-domain-change.html: Added.
        * http/tests/security/xss-DENIED-invalid-domain-change-expected.txt: Added.
        * http/tests/security/xss-DENIED-invalid-domain-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele.
darin@apple.com [Tue, 27 Nov 2007 01:35:05 +0000 (01:35 +0000)]
    Reviewed by Adele.

        - some middle-mouse-button-related fixes

        These don't affect Safari since it maps the middle mouse button to the command key,
        but that might not always be the case for future versions.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView otherMouseDown:]): Pass through middle mouse down events to WebCore.
        (-[WebHTMLView otherMouseDragged:]): Ditto, for drag events.
        (-[WebHTMLView otherMouseUp:]): Ditto, for up events.

        * WebView/WebPolicyDelegate.h: Fixed inaccurate documentation of WebActionButtonKey.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix.
sfalken@apple.com [Tue, 27 Nov 2007 01:25:14 +0000 (01:25 +0000)]
    Build fix.

        * WebKit.vcproj/WebKit.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
sfalken@apple.com [Tue, 27 Nov 2007 01:08:58 +0000 (01:08 +0000)]

        Build fix.

        * WebCore.vcproj/WebCore.make:
        * WebCore.vcproj/migrate-idls.sh:


        Build fix.

        * WebKit.vcproj/build-generated-files.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
darin@apple.com [Tue, 27 Nov 2007 00:50:36 +0000 (00:50 +0000)]

        Reviewed by Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=16096
          REGRESSION (r26653-r26699): Plaxo.com addressbook does not load in webkit nightlies

        Test: fast/js/regexp-overflow.html

        * pcre/pcre_compile.cpp: (calculateCompiledPatternLengthAndFlags):
        Removed a stray "ptr++" that I added by accident when merging the
        changes between PCRE 6.4 and 6.5.


        Reviewed by Mitz.

        - test for http://bugs.webkit.org/show_bug.cgi?id=16096
          REGRESSION (r26653-r26699): Plaxo.com addressbook does not load in webkit nightlies

        * fast/js/regexp-overflow-expected.txt: Added.
        * fast/js/regexp-overflow.html: Added.
        * fast/js/resources/regexp-overflow.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix potential null-dereference.
weinig@apple.com [Tue, 27 Nov 2007 00:28:24 +0000 (00:28 +0000)]
    Fix potential null-dereference.

        Reviewed by Adam Roben.

        * page/FrameTree.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
weinig@apple.com [Tue, 27 Nov 2007 00:15:21 +0000 (00:15 +0000)]

        Reviewed by Darin.

        Fix for <rdar://problem/5592988>
        - Enforce tighter restrictions on what frames in other domains
          can be navigated.

        Tests: http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change.html

        * bindings/js/kjs_window.cpp:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::shouldAllowNavigation): Move and update logic from canTarget().
        * loader/FrameLoader.h:
        * page/FrameTree.cpp:
        (WebCore::FrameTree::isDescendantOf): Make this O(1) in the case when both frames are not
        in the same page.


        Reviewed by Darin.

        Tests for <rdar://problem/5592988>

        - Update and add tests for new tighter restrictions on what frames in other domains
          can be navigated.

        * http/tests/security/cross-frame-access-location-expected.txt:
        * http/tests/security/frameNavigation: Added.
        * http/tests/security/frameNavigation/resources: Added.
        * http/tests/security/frameNavigation/resources/iframe-that-performs-parent-navigation.html: Added.
        * http/tests/security/frameNavigation/resources/iframe-with-inner-frame-on-foreign-domain.html: Added.
        * http/tests/security/frameNavigation/resources/navigation-changed-iframe.html: Added.
        * http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change-expected.txt: Added.
        * http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change.html: Added.
        * http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change-expected.txt: Added.
        * http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
sfalken@apple.com [Mon, 26 Nov 2007 23:53:25 +0000 (23:53 +0000)]

        Build fix.

        * WebCore.vcproj/migrate-idls.sh:


        Build fix.

        * WebKit.vcproj/build-generated-files.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFixed typo
ggaren@apple.com [Mon, 26 Nov 2007 23:50:18 +0000 (23:50 +0000)]
Fixed typo

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Kevin McCullough.
ggaren@apple.com [Mon, 26 Nov 2007 23:48:14 +0000 (23:48 +0000)]
    Reviewed by Kevin McCullough.

        Fixed <rdar://problem/5597937> REGRESSION (r27126): Drosera does not
        show variables (can't enumerate ActivationImp properties)

        Implemented a custome ActivationImp::getPropertyNames, since
        ActivationImp now uses a custom property storage mechanism for local

        * kjs/function.cpp:
        * kjs/function.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
andersca@apple.com [Mon, 26 Nov 2007 23:45:46 +0000 (23:45 +0000)]
    Reviewed by Adam.

        Add an implementation of IWebSecurityOrigin and a partially stubbed out
        implementation of IWebDatabaseManager.

        * ForEachCoClass.h:
        * Interfaces/IWebDatabaseManager.idl:
        * Interfaces/WebKit.idl:
        * WebDatabaseManager.cpp:
        * WebDatabaseManager.h:
        * WebKit.vcproj/WebKit.vcproj:
        * WebKitClassFactory.cpp:
        * WebSecurityOrigin.cpp: Added.
        * WebSecurityOrigin.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - Tiger build fix.
mitz@apple.com [Mon, 26 Nov 2007 23:34:07 +0000 (23:34 +0000)]
    - Tiger build fix.

        * DumpRenderTree/mac/Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebKit/win:
kmccullough@apple.com [Mon, 26 Nov 2007 23:03:08 +0000 (23:03 +0000)]

        Reviewed by Maciej.

        - Implemented displaying variables for Drosera on Win.

        * Interfaces/IWebScriptCallFrame.idl: Added a local function to be
        able to access the WebScriptCallFrame.
        * Interfaces/IWebScriptScope.idl: Implemented.
        * Interfaces/WebKit.idl: Added WebScriptScope to the tlb.
        * WebKit.vcproj/Interfaces.vcproj:
        * WebScriptCallFrame.cpp: Implemented the helper and accessor methods.
        (EnumScopes::Next): Fixed a bug where we did not release correctly and
        would accidentally destroy scopes.
        (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString): Implemented
        * WebScriptCallFrame.h: Implemented the helper and accessor methods.
        * WebScriptScope.cpp: Implmented.
        (EnumVariables::EnumVariables): Created an IEnumVariant over the
        variables to be able to pass a DCOM acceptable structure back to
        (WebScriptScope::createInstance): Implemented.
        (WebScriptScope::variableNames): Implemented.
        * WebScriptScope.h: Implmeneted.


        Reviewed by Maciej.

        - Implemented displaying variables for Drosera on Win.

        * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
        that retrieve variables to not hold onto the return value since it's
        not returned.  Also changed to use the new signatures of the retrieval
        * Drosera/win/Drosera.cpp: Removed a needless TODO.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady.
andersca@apple.com [Mon, 26 Nov 2007 22:15:43 +0000 (22:15 +0000)]
    Reviewed by Brady.

        Add IWebDatabaseManager and IWebSecurityOrigin interfaces.

        * Interfaces/IWebDatabaseManager.idl: Added.
        * Interfaces/IWebSecurityOrigin.idl: Added.
        * WebKit.vcproj/Interfaces.vcproj:
        * WebKit.vcproj/WebKitGUID.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mitz@apple.com [Mon, 26 Nov 2007 21:19:00 +0000 (21:19 +0000)]

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5609337> Making a float shorter does not remove it from the floating object list of a nested block it intruded into

        Test: fast/dynamic/float-withdrawal-2.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlockChildren): When a float may have
        been withdrawn from a child, mark all descendants if necessary and not
        just the child.


        Reviewed by Dave Hyatt.

        - test for <rdar://problem/5609337> Making a float shorter does not remove it from the floating object list of a nested block it intruded into

        * fast/dynamic/float-withdrawal-2.html: Added.
        * platform/mac/fast/dynamic/float-withdrawal-2-expected.checksum: Added.
        * platform/mac/fast/dynamic/float-withdrawal-2-expected.png: Added.
        * platform/mac/fast/dynamic/float-withdrawal-2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Cleanup names of painting and repainting functions.
weinig@apple.com [Mon, 26 Nov 2007 21:16:04 +0000 (21:16 +0000)]
    Cleanup names of painting and repainting functions.

        Reviewed by Adam Roben.

        * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
        (drawSelectionRect): was drawSelectionRectIntoContext.
        * DumpRenderTree/cg/PixelDumpSupportCG.h:
        * DumpRenderTree/mac/PixelDumpSupportMac.mm:
        (paintWebView): was drawWebViewIntoContext.
        (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Jon Honeycutt.
alice.liu@apple.com [Mon, 26 Nov 2007 19:51:57 +0000 (19:51 +0000)]
    Reviewed by Jon Honeycutt.

        Fall back to the default Policy Delegate in these functions,
        as is already done in dispatchDecidePolicyForNavigationAction

        * WebFrame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Dan Bernstein.
mitz@apple.com [Mon, 26 Nov 2007 19:47:19 +0000 (19:47 +0000)]
    Reviewed by Dan Bernstein.

        - Leopard build fix

        * DumpRenderTree/mac/Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady.
andersca@apple.com [Mon, 26 Nov 2007 19:35:14 +0000 (19:35 +0000)]
    Reviewed by Brady.

        Get rid of the WebSecurityOriginPrivate object and store
        the WebCore::SecurityOriginData pointer in the _private field of
        the WebSecurityOrigin object instead.

        * Storage/WebDatabaseManager.mm:
        (-[WebDatabaseManager databasesWithOrigin:]):
        (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
        (-[WebDatabaseManager deleteDatabasesWithOrigin:]):
        (-[WebDatabaseManager deleteDatabase:withOrigin:]):
        * Storage/WebSecurityOrigin.mm:
        (-[WebSecurityOrigin initWithProtocol:domain:port:]):
        (-[WebSecurityOrigin protocol]):
        (-[WebSecurityOrigin domain]):
        (-[WebSecurityOrigin port]):
        (-[WebSecurityOrigin usage]):
        (-[WebSecurityOrigin quota]):
        (-[WebSecurityOrigin setQuota:]):
        (-[WebSecurityOrigin dealloc]):
        (-[WebSecurityOrigin finalize]):
        (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
        (-[WebSecurityOrigin _core]):
        * Storage/WebSecurityOriginInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix.
sfalken@apple.com [Mon, 26 Nov 2007 19:34:45 +0000 (19:34 +0000)]
    Build fix.

        * WebCore.vcproj/MigrateIDLAndScripts: Copied from WebCore.vcproj/MigrateIDLAndScripts.make.
        * WebCore.vcproj/MigrateIDLAndScripts.make: Removed.
        * WebCore.vcproj/migrate-idls.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
weinig@apple.com [Mon, 26 Nov 2007 19:19:06 +0000 (19:19 +0000)]
    Fix for bugs.webkit.org/show_bug.cgi?id=16136
        Use shared PixelDumpSupport for Mac DRT

        Reviewed by Adam Roben.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
        * DumpRenderTree/cg/ImageDiffCG.cpp:
        * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
        * DumpRenderTree/cg/PixelDumpSupportCG.h:
        * DumpRenderTree/mac/Configurations/Base.xcconfig:
        * DumpRenderTree/mac/DumpRenderTree.mm:
        * DumpRenderTree/mac/ImageDiff.m: Removed.
        * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
        * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
        * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
        * DumpRenderTree/win/PixelDumpSupport.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders (and typo lovingly found by Adam)
beidson@apple.com [Mon, 26 Nov 2007 19:17:52 +0000 (19:17 +0000)]
    Reviewed by Anders (and typo lovingly found by Adam)

        Change Databases to be stored in a per-origin directory hierarchy - this will make
        storage quotas much easier to enforce

        * platform/SecurityOriginData.cpp:
        (WebCore::SecurityOriginData::SecurityOriginData): Parse string based on '_' instead of ':'
        (WebCore::SecurityOriginData::stringIdentifier): Change to use '_' as a separator instead of ':'.
          '_' still works due to not being allowed in domain names, but also is a valid filename character '
          on all filesystems we care about

        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::fullPathForDatabase): Create a per-origin directory hierarchy to categorize
          databases by origin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-26 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 26 Nov 2007 18:40:53 +0000 (18:40 +0000)]
2007-11-26  Alp Toker  <alp@atoker.com>

        GTK+/Qt/Wx build fix for breakage introduced in r28039.

        * ForwardingHeaders/JavaScriptCore/JSRetainPtr.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
timothy@apple.com [Mon, 26 Nov 2007 17:17:50 +0000 (17:17 +0000)]

        Reviewed by Adam Roben.

        Bug 16137: Web Inspector window on Leopard should have a unified toolbar and window title

        On Leopard the toolbar background will be transparent, to allow the
        window background to show through the transparent WebView. The
        search results divs needed to move inside the "main" div, so they
        would be clipped and not show where the toolbar is.

        * page/InspectorController.cpp:
        (WebCore::platform): Return a string for which platform we are.
        Define the platform function on the JavaScript class.
        * page/inspector/Panel.js: Add panels to the panels div.
        * page/inspector/inspector.css: On the Leopard platform make
        the toolbar background transparent so the window background shows.
        * page/inspector/inspector.html: Add a panels div and move search
        result divs inside the main div.
        * page/inspector/inspector.js: Tweak the resize code to acount for
        the search results divs moving inside the main div.


        Reviewed by Adam Roben.

        Bug 16137: Web Inspector window on Leopard should have a unified toolbar and window title

        Create the Web Inspector window with the textured style. Set the content border
        thickness for the top of the window or the height of the toolbar. Also make the
        window's bottom corners square, since a normal textured window normally has
        rounded bottom corners.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController window]):


        Reviewed by Adam Roben.

        Bug 16137: Web Inspector window on Leopard should have a unified toolbar and window title

        Add a new function to make bottom window corners square for textured windows.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceTiger.a:
        * libWebKitSystemInterfaceLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix a leak pointed out by Alexey
aroben@apple.com [Mon, 26 Nov 2007 07:29:36 +0000 (07:29 +0000)]
    Fix a leak pointed out by Alexey

        * WebView.cpp:
        (getUpdateRects): Use a Vector<unsigned char>, since OwnPtr doesn't
        know to call delete[].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Bug 16052: prepare-ChangeLog doesn't report deleted files
ddkilzer@apple.com [Mon, 26 Nov 2007 07:06:30 +0000 (07:06 +0000)]
    Bug 16052: prepare-ChangeLog doesn't report deleted files

        Reviewed by Sam.

        * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix Bug 16138: Reduce code duplication in WebView.cpp
aroben@apple.com [Mon, 26 Nov 2007 07:02:46 +0000 (07:02 +0000)]
    Fix Bug 16138: Reduce code duplication in WebView.cpp


        Reviewed by Sam.

        * WebView.cpp:
        (getUpdateRects): Factored code out of updateBackingStore and paint
        into this new helper function.
        (WebView::updateBackingStore): Use getUpdateRects.
        (WebView::paint): Ditto.
        (WebView::paintIntoBackingStore): Changed to take a const IntRect&.
        (WebView::paintIntoWindow): Ditto.
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Bug 15864: Replace merge-changelog with resolve-ChangeLogs
ddkilzer@apple.com [Mon, 26 Nov 2007 06:00:00 +0000 (06:00 +0000)]
    Bug 15864: Replace merge-changelog with resolve-ChangeLogs

        Reviewed by Adam.

        Roll functionality of merge-changelog into resolve-ChangeLogs
        script.  The script now checks for ChangeLog.rej and
        ChangeLog.orig files first.  If it finds them, it uses the
        ChangeLog.rej file as a patch (in old contextual diff format) to
        apply with --fuzz=3.

        * Scripts/merge-changelog: Removed.
        * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * platform/win/Skipped: Add a known failure.
aroben@apple.com [Mon, 26 Nov 2007 05:26:47 +0000 (05:26 +0000)]
    * platform/win/Skipped: Add a known failure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * platform/win/Skipped: Remove an unnecessary entry.
aroben@apple.com [Mon, 26 Nov 2007 05:25:31 +0000 (05:25 +0000)]
    * platform/win/Skipped: Remove an unnecessary entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the...
weinig@apple.com [Mon, 26 Nov 2007 04:16:20 +0000 (04:16 +0000)]
    Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.

        Reviewed by Mark Rowe.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/mac/Configurations/Base.xcconfig:
        * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
        * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
        * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Convert DumpRenderTree to ues .xcconfig files.
weinig@apple.com [Mon, 26 Nov 2007 03:52:12 +0000 (03:52 +0000)]
    Convert DumpRenderTree to ues .xcconfig files.

        Reviewed by Mark Rowe.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/mac/Configurations: Added.
        * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
        * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
        * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add ForwardingHeaders to wtf for DumpRenderTree.
weinig@apple.com [Mon, 26 Nov 2007 02:54:45 +0000 (02:54 +0000)]
    Add ForwardingHeaders to wtf for DumpRenderTree.

        Reviewed by Mark Rowe.

        * DumpRenderTree/DumpRenderTree.h:
        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/ForwardingHeaders: Added.
        * DumpRenderTree/ForwardingHeaders/wtf: Added.
        * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
        * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
        * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
        * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
        * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
        * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
        * DumpRenderTree/LayoutTestController.cpp:
        * DumpRenderTree/WorkQueue.cpp:
        * DumpRenderTree/mac/DumpRenderTree.mm:
        * DumpRenderTree/mac/FrameLoadDelegate.mm:
        * DumpRenderTree/mac/JavaScriptThreading.cpp:
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        * DumpRenderTree/mac/ObjCController.m:
        * DumpRenderTree/mac/UIDelegate.mm:
        * DumpRenderTree/mac/WorkQueueItemMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-25 Rodney Dawes <dobey@wayofthemonkey.com>
mrowe@apple.com [Mon, 26 Nov 2007 02:37:31 +0000 (02:37 +0000)]
2007-11-25  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Maciej Stachowiak.

        Remove the unneeded CFNETWORK #ifdefs.

        * loader/NetscapePlugInStreamLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-24 Laszlo Gombos <laszlo.gombos@gmail.com>
mrowe@apple.com [Mon, 26 Nov 2007 02:12:37 +0000 (02:12 +0000)]
2007-11-24  Laszlo Gombos  <laszlo.gombos@gmail.com>

        Reviewed by Sam Weinig.

        Add printf format attribute to several functions. Use the the new WTF_ATTRIBUTE_PRINTF define.

        * dom/XMLTokenizer.cpp:
        * dom/XMLTokenizer.h:
        * platform/DeprecatedString.h:
        * platform/PlatformString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-24 Laszlo Gombos <laszlo.gombos@gmail.com>
mrowe@apple.com [Mon, 26 Nov 2007 02:12:04 +0000 (02:12 +0000)]
2007-11-24  Laszlo Gombos  <laszlo.gombos@gmail.com>

        Reviewed by Maciej Stachowiak.

        Fix minor compiler warning (GCC 4.1.3)

        * pcre/pcre_internal.h:
        * pcre/pcre_ucp_searchfuncs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix some test failures caused by r28019
aroben@apple.com [Mon, 26 Nov 2007 01:53:33 +0000 (01:53 +0000)]
     Fix some test failures caused by r28019

         Now that stdout is in binary mode, we need to always use printf
         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
         the output.

         Reviewed by Sam.

         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
mitz@apple.com [Mon, 26 Nov 2007 01:06:27 +0000 (01:06 +0000)]
    Reviewed by Adam Roben.

        - fix off-center error images

        Covered by many pixel tests with missing images

        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paint): Account for the 1 pixel outline when
        positioning the error image.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Set the font smoothing preference in DRT
aroben@apple.com [Mon, 26 Nov 2007 00:13:40 +0000 (00:13 +0000)]
     Set the font smoothing preference in DRT

         This makes the pixel results on Windows closer to the Mac results.

         Reviewed by Mitz.

         * DumpRenderTree/win/DumpRenderTree.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix Bug 16133: Implement pixel test support on Windows
aroben@apple.com [Mon, 26 Nov 2007 00:03:42 +0000 (00:03 +0000)]
 Fix Bug 16133: Implement pixel test support on Windows


         Add ImageDiff.vcproj to WebKit.sln

         Reviewed by Sam.

         * WebKit.vcproj/WebKit.sln:


         Port ImageDiff to CG and C++

         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133

         Reviewed by Sam.

         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
         * DumpRenderTree/win/ImageDiff.vcproj: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix image diff link generation on Windows
aroben@apple.com [Mon, 26 Nov 2007 00:03:18 +0000 (00:03 +0000)]
     Fix image diff link generation on Windows

         Reviewed by Sam.

         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
         to toURL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Implement pixel dumping in Windows DRT
aroben@apple.com [Mon, 26 Nov 2007 00:02:55 +0000 (00:02 +0000)]
    Implement pixel dumping in Windows DRT

        Part of http://bugs.webkit.org/show_bug.cgi?id=16133

        Reviewed by Sam.

        * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
        (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
        Content-Length header.
        * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (dump): Do a pixel dump if requested.
        (main): Parse pixel test options.
        * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
        the cg/ subdirectory to the include path.
        * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
        available in a header or import library, so we have to go through this
        LoadLibrary/GetProcAddress dance to use them.
        * DumpRenderTree/win/MD5.h: Added.
        * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
        moved up to the top level to share it with Mac eventually.
        * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
        (getBitmapContextFromWebView): Forces the WebView to paint using a
        WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Clean up Windows DRT's option parsing a little bit
aroben@apple.com [Mon, 26 Nov 2007 00:02:29 +0000 (00:02 +0000)]
     Clean up Windows DRT's option parsing a little bit

         Reviewed by Sam.

         * DumpRenderTree/win/DumpRenderTree.cpp:
         (main): Put non-option arguments into a Vector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Make Windows DRT stop changing LF into CRLF
aroben@apple.com [Mon, 26 Nov 2007 00:01:44 +0000 (00:01 +0000)]
     Make Windows DRT stop changing LF into CRLF

         Reviewed by Sam.

         * DumpRenderTree/win/DumpRenderTree.cpp:
         (main): Put stdout in binary mode.
         * Scripts/run-webkit-tests: Remove the CRLF hack.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix bug 16129: REGRESSION (r27761-r27811): malloc error while visiting http://mysit...
mrowe@apple.com [Sun, 25 Nov 2007 22:14:31 +0000 (22:14 +0000)]
Fix bug 16129: REGRESSION (r27761-r27811): malloc error while visiting mysit.es (crashes release build)

* pcre/pcre_compile.cpp: Change errorcode to be passed by reference so that any error code is propagated
to our caller like they expect.

Reviewed by Dan Bernstein.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agowx build fixes for Linux/GTK+ port.
kevino@webkit.org [Sun, 25 Nov 2007 21:16:03 +0000 (21:16 +0000)]
wx build fixes for Linux/GTK+ port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix wrong bug number in ChangeLog. Not reviewed.
zimmermann@webkit.org [Sun, 25 Nov 2007 13:06:22 +0000 (13:06 +0000)]
Fix wrong bug number in ChangeLog. Not reviewed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by Adam Roben.
zimmermann@webkit.org [Sun, 25 Nov 2007 13:04:55 +0000 (13:04 +0000)]
Reviewed by Adam Roben.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=15393
Fix problems with hidden glyphs. They were taken into account for quite
some operations (hit testing, length calulcations etc..) except painting.
Especially fixes boundaries of <textPath> (see using Web Inspector) if
text-anchor isn't equal to 'start'.

Added testcase:

Fixed testcase: (all showed text selection problems on text paths)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
ap@webkit.org [Sun, 25 Nov 2007 09:45:09 +0000 (09:45 +0000)]
    Reviewed by Maciej.

        XSLTProcessor.transformToFragment creates an extra not defined TEXT_NODE at the end

        Test: fast/xsl/extra-lf-at-end.html

        * xml/XSLTProcessor.cpp:
        (WebCore::writeToVector): Changed to use Vector to avoid slow String::apend().
        (WebCore::saveResultToString): Remove trailing line feed if present.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-24 Alp Toker <alp@atoker.com>
alp@webkit.org [Sun, 25 Nov 2007 08:48:48 +0000 (08:48 +0000)]
2007-11-24  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        [GTK] Public API does not follow GTK+ conventions

        Public API enhancements:

        Implement webkit_page_get_editable() and webkit_page_set_editable().

        Implement webkit_frame_get_name().

        Remove definitions for functions that are unusable or not implemented.
        This has caused much confusion for application developers.

        Improve documentation.

        Correct/constify some return types.

        Add parameter checks.

        Make the default fixed font "Courier New" to match the other Web
        font names.

        * Api/webkitgtkframe.cpp:
        * Api/webkitgtkframe.h:
        * Api/webkitgtkpage.cpp:
        * Api/webkitgtkpage.h:
        * Api/webkitgtkprivate.h:
        * WebCoreSupport/EditorClientGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Added tests for select.options.remove(boolean).
ddkilzer@apple.com [Sun, 25 Nov 2007 07:15:33 +0000 (07:15 +0000)]
    Added tests for select.options.remove(boolean).

        Reviewed by Maciej.

        * fast/js/resources/select-options-add.js: Added two tests.
        * fast/js/select-options-add-expected.txt: Updated results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-24 Alp Toker <alp@atoker.com>
alp@webkit.org [Sun, 25 Nov 2007 03:39:55 +0000 (03:39 +0000)]
2007-11-24  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        [GTK] Up key doesn't work properly when content is editable

        Add a missing 'break' to avoid falling through to the next case when
        handling VK_UP keystrokes. This was noticed when working on editing
        support in the GTK+ port.

        I've checked the other cases for similar typos and they seem fine.

        * WebCoreSupport/EditorClientGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-24 David Kilzer <ddkilzer@webkit.org>
ddkilzer@apple.com [Sun, 25 Nov 2007 03:13:12 +0000 (03:13 +0000)]
2007-11-24  David Kilzer  <ddkilzer@webkit.org>

        Removed empty directory.

        * Scripts/resources: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-24 Xan Lopez <xan@gnome.org>
alp@webkit.org [Sun, 25 Nov 2007 02:53:42 +0000 (02:53 +0000)]
2007-11-24  Xan Lopez  <xan@gnome.org>

        Reviewed by Alp Toker.

        [GTK] Arrow keys do not Scroll

        * Api/webkitgtkpage.cpp:

        Support Up/Down/Right/Left keys to scroll. Slight hack, see FIXME for

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-24 Christian Dywan <christian@twotoasts.de>
alp@webkit.org [Sun, 25 Nov 2007 01:23:41 +0000 (01:23 +0000)]
2007-11-24  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Alp Toker.

        [GTK] Javascript console and dialogs are not implemented

        Fix call to gtk_message_dialog_new() which expects a format string.

        * Api/webkitgtkpage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoTiger build fix.
mrowe@apple.com [Sat, 24 Nov 2007 23:56:02 +0000 (23:56 +0000)]
Tiger build fix.

Use WebCFAutorelease in place of NSMakeCollectable then autorelease as this also works on Tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix <rdar://problem/5432686> 333MB RPRVT seems to leak @ www.43folders.com (1hr plug...
mrowe@apple.com [Sat, 24 Nov 2007 23:48:52 +0000 (23:48 +0000)]
Fix <rdar://problem/5432686> 333MB RPRVT seems to leak @ 43folders.com (1hr plug-in stream).

Reviewed by Tim Hatcher.

Have NP_ASFILE and NP_ASFILEONLY streams write the data to disk as they receive it rather than
dumping the data to disk in a single go when the stream has completed loading.  On a test case
involving a 150MB Flash movie being streamed from a local web server this reduces memory consumption
on page load from around 400MB to 22MB.

The only plugin I have found that uses NP_ASFILE or NP_ASFILEONLY on the Mac is our NetscapeMoviePlugin
example code so the NP_ASFILE portion of this change has not had any testing with a real-world plugin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Get rid of WebCoreSystemInterface on Windows
aroben@apple.com [Sat, 24 Nov 2007 23:43:22 +0000 (23:43 +0000)]
 Get rid of WebCoreSystemInterface on Windows


         Get rid of WebCoreSystemInterface on Windows

         The one function defined in that file is now in WebKitSystemInterface.

         Reviewed by Tim.

         * WebCore.vcproj/WebCore.vcproj: Removed
         * platform/graphics/cg/ImageCG.cpp: Made #include of
         WebCoreSystemInterface.h Mac-only.
         * platform/win/GraphicsContextWin.cpp: Ditto.
         * platform/win/WebCoreSystemInterface.cpp: Removed.
         * platform/win/WebCoreSystemInterface.h: Removed.


         Add wkSetPatternPhaseInUserSpace to WebKitSystemInterface on Windows

         Reviewed by Tim.

         * win/include/WebKitSystemInterface/WebKitSystemInterface.h: Added
         * win/lib/WebKitSystemInterface.lib: Updated.
         * win/lib/WebKitSystemInterface_debug.lib: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Replace uses of %@ with %s in the inspector
aroben@apple.com [Sat, 24 Nov 2007 23:33:18 +0000 (23:33 +0000)]
    Replace uses of %@ with %s in the inspector

        Rubberstamped by Tim.

        * English.lproj/InspectorLocalizedStrings.js: Changed %@ to %s.
        * page/inspector/DatabasePanel.js: Ditto.
        * page/inspector/StylesSidebarPane.js: Ditto.
        * page/inspector/inspector.js: Ditto.
        * page/inspector/utilities.js:
        (String.vsprintf): Removed @ as a format specifier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Windows build fix
aroben@apple.com [Sat, 24 Nov 2007 23:32:48 +0000 (23:32 +0000)]
    Windows build fix

        Turn off the change made in r27984 on Windows for now.

        * xml/XSLTProcessor.cpp:
        * xml/XSLTUnicodeSort.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
timothy@apple.com [Sat, 24 Nov 2007 22:35:52 +0000 (22:35 +0000)]
    Reviewed by Adam Roben.

        Bug 16121: Web Inspector needs helper functions that pass a 'this' object to
        addEventListener and setTimeout

        Add Function.prototype.bind. This helper will return a wrapper function
        that will call the original function with the supplied arguments
        and using the supplied 'this' object.

        * page/inspector/Database.js: Remove a use of setTimeout by
          inheriting some common functions from Resource.
        * page/inspector/DatabasePanel.js: Use the new bind function.
        * page/inspector/ConsolePanel.js: Ditto.
        * page/inspector/DocumentPanel.js: Ditto.
        * page/inspector/NetworkPanel.js: Ditto.
        * page/inspector/PropertiesSection.js: Ditto.
        * page/inspector/Resource.js: Ditto.
        * page/inspector/SidebarPane.js: Ditto.
        * page/inspector/inspector.html: Moved Database.js after Resource.js,
          now that Database.js uses it.
        * page/inspector/inspector.js: Use the new bind function. Also
          removed a setTimeout used for the localized strings code. There is
          now a load event listener added to the localized strings script
          element that will call WebInspector.loaded.
        * page/inspector/utilities.js: Add Function.prototype.bind.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd missing strings.
timothy@apple.com [Sat, 24 Nov 2007 22:20:56 +0000 (22:20 +0000)]
Add missing strings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-24 Christian Dywan <christian@twotoasts.de>
alp@webkit.org [Sat, 24 Nov 2007 21:52:31 +0000 (21:52 +0000)]
2007-11-24  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Alp Toker.

        [GTK] Webkit doesn't show title attribute tooltip when hovering over an image

        Implement tooltip support using the new Tooltip API.

        Support for older versions of GTK+ is still lacking.

        * WebCoreSupport/ChromeClientGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
timothy@apple.com [Sat, 24 Nov 2007 19:18:45 +0000 (19:18 +0000)]
    Reviewed by Adam Roben.

        Bug 16112: Some Web Inspector UI elements use offsetWidth and offsetHeight before the stylesheet loads

        In the places where we use offsetWidth and offsetHeight before
        the stylesheet loads there is now a check. If the body's
        offsetWidth is not greater than zero, then set a timeout
        to do the updates requiring the stylesheet later.

        The three places this happened:
        - DOM tree selection highlight would show up at the wrong height
          when using Inspect Element to open the inspector.
        - DOM tree breadcrumbs would not collapse when using Inspect Element
          to open the inspector.
        - Network Timeline divider lines would not show when opening directly
          into the timeline.

        * page/inspector/DocumentPanel.js: Check if the stylesheet loaded.
        * page/inspector/NetworkPanel.js: Ditto.
        * page/inspector/inspector.html: Include the stylesheet before
          any scripts, this will help get it loaded sooner.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd wx implementation for pathGetFilename
kevino@webkit.org [Sat, 24 Nov 2007 18:18:53 +0000 (18:18 +0000)]
Add wx implementation for pathGetFilename

Reviewed by David D. Kilzer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix bisect-builds to work with recent WebKit nightly builds.
ddkilzer@apple.com [Sat, 24 Nov 2007 06:09:39 +0000 (06:09 +0000)]
    Fix bisect-builds to work with recent WebKit nightly builds.

        Reviewed by Dan.

        * Scripts/bisect-builds: Check for the
        WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
        it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
        to WebKit.app/Contents/Resources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
timothy@apple.com [Sat, 24 Nov 2007 04:48:07 +0000 (04:48 +0000)]
    Reviewed by Adam Roben.

        Bug 16110: Clicking inside the resource headers in the network timeline collapses them

        Toggle the resource headers only if the click happens on the
        resource row, not within the headers area.

        * WebCore.xcodeproj/project.pbxproj:
        * page/inspector/NetworkPanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFixed <rdar://problem/3759190> allow input methods the option of processing mouse...
oliver@apple.com [Sat, 24 Nov 2007 03:14:46 +0000 (03:14 +0000)]
Fixed <rdar://problem/3759190> allow input methods the option of processing mouse events themselves

Reviewed by Mark Rowe.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWindows build fixes for USE(CURL) and MSVC compilation for ports.
kevino@webkit.org [Sat, 24 Nov 2007 00:52:18 +0000 (00:52 +0000)]
Windows build fixes for USE(CURL) and MSVC compilation for ports.

Reviewed by Adam Roben.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoForgot to add JSCore and WebCore ChangeLog during previous commit.
kevino@webkit.org [Fri, 23 Nov 2007 23:22:24 +0000 (23:22 +0000)]
Forgot to add JSCore and WebCore ChangeLog during previous commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix the wx buildbot after removal of move-js-headers.sh..
kevino@webkit.org [Fri, 23 Nov 2007 23:17:29 +0000 (23:17 +0000)]
Fix the wx buildbot after removal of move-js-headers.sh..

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-22 Alp Toker <alp@atoker.com>
alp@webkit.org [Fri, 23 Nov 2007 22:03:38 +0000 (22:03 +0000)]
2007-11-22  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Implement and document several WebKitFrame functions, some of which
        are necessary to support DRT.

        Correct NULL handling and improve run-time checks.

        * Api/webkitgtkframe.cpp:
        * Api/webkitgtkframe.h:
        * Api/webkitgtkprivate.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Set video src from script, not from the element attribute. This
antti@apple.com [Fri, 23 Nov 2007 20:07:06 +0000 (20:07 +0000)]
    Set video src from script, not from the element attribute. This
        guarantees load events do not fire before event listeners are registered.
        This change does not affect test results.

        * media/progress-event.html:
        * media/video-autoplay.html:
        * media/video-buffered.html:
        * media/video-currentTime-set.html:
        * media/video-currentTime-set2.html:
        * media/video-currentTime.html:
        * media/video-dom-autoplay.html:
        * media/video-error-abort.html:
        * media/video-error-does-not-exist.html:
        * media/video-load-networkState.html:
        * media/video-load-readyState.html:
        * media/video-no-autoplay.html:
        * media/video-seekable.html:
        * media/video-seeking.html:
        * media/video-size.html:
        * media/video-src.html:
        * media/video-start.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAnother build fix specific to trunk (instead of the stable branch) to fix make clean...
hausmann@webkit.org [Fri, 23 Nov 2007 15:56:05 +0000 (15:56 +0000)]
Another build fix specific to trunk (instead of the stable branch) to fix make clean (which the buildbots call).

Signed-off-by: George Staikos <staikos@kde.org>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix make (dist)clean on Windows.
hausmann@webkit.org [Fri, 23 Nov 2007 15:44:14 +0000 (15:44 +0000)]
Fix make (dist)clean on Windows.

OBJECTS_DIR_WTR does not exist anymore, use GENERATED_SOURCES_DIR.

Signed-off-by: George Staikos <staikos@kde.org>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Not reviewed, trivial leak fix.
ap@webkit.org [Fri, 23 Nov 2007 12:27:06 +0000 (12:27 +0000)]
    Not reviewed, trivial leak fix.

        Fix xsltUnicodeSortFunction() memory leaks.

        * xml/XSLTUnicodeSort.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
ap@webkit.org [Fri, 23 Nov 2007 10:19:17 +0000 (10:19 +0000)]
    Reviewed by Maciej.

        <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
        not closed (affects digg.com)

        Tests: fast/loader/meta-refresh-vs-open.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::scheduleRedirection): Only check whether the load is complete for
        HTTP redirects - JavaScript-initiated ones are effective immediately.

        * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
        one after finishing with a test to avoid having its delayed onload handler fired when
        starting the next test. This is ugly and still unreliable (see LayoutTests ChangeLog),
        but it helps somewhat.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mitz@apple.com [Fri, 23 Nov 2007 09:20:16 +0000 (09:20 +0000)]

        Reviewed by Alexey Proskuryakov.

        - apply matrix transforms on the correct side of the transformation
          matrix (not on the side where the vector is multiplied).

        Test: fast/transforms/matrix-02.html

        * rendering/RenderStyle.h:


        Reviewed by Alexey Proskuryakov.

        - test the matrix transforms are applied on the correct side

        * fast/transforms/matrix-02.html: Added.
        * platform/mac/fast/transforms/matrix-02-expected.checksum: Added.
        * platform/mac/fast/transforms/matrix-02-expected.png: Added.
        * platform/mac/fast/transforms/matrix-02-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
ap@webkit.org [Fri, 23 Nov 2007 08:29:59 +0000 (08:29 +0000)]
    Reviewed by Maciej.

        <rdar://problem/5609785> XSLT processor <xsl:sort> algorithm is incompatible with other
        browser implementations

        Test: fast/xsl/sort-unicode.xml

        * xml/XSLTProcessor.cpp:
        (WebCore::XSLTProcessor::transformToString): Set a custom sort function.

        * xml/XSLTUnicodeSort.cpp: Added.
        * xml/XSLTUnicodeSort.h: Added.
        ICU-based implementation of xsl:sort, using an example from libxslt distribution.
        Only minimal coding style fixes to ease synchronization with upstream in the future.

        * icu/unicode/ucol.h: Added.
        * icu/unicode/uset.h: Added.
        Taken from ICU 3.2

        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        Added XSLTUnicodeSort.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
ap@webkit.org [Fri, 23 Nov 2007 06:43:49 +0000 (06:43 +0000)]
    Reviewed by Maciej.

        Hixie's DOM Core performance test shows insert >10x slower than append

        Each invocation of Element.childNodes[n] was creating and registering a new ChildNodeList,
        which persisted and listened to notifications until GC.

        A fix is to avoid registering child node lists for notifications - they don't need them, as
        they share a common cache in Node.

        * dom/Node.cpp:
        * dom/NodeList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mitz@apple.com [Fri, 23 Nov 2007 06:04:36 +0000 (06:04 +0000)]

        Reviewed by Antti Koivisto.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15811
          WebKit plug-ins can re-enter WebKit under attach()

        Defer plug-in loading until after attach and recalcStyle using the
        post-attach callback mechanism. Netscape plug-ins are still loaded only
        after layout.

        * dom/ContainerNode.cpp:
        Made NodeCallbackQueue elements retain the Node because callbacks might
        delete nodes that are in the callback queue.
        (WebCore::ContainerNode::suspendPostAttachCallbacks): Added. Needed to
        prevent post-attach callbacks from being dispatched under recalcStyle().
        (WebCore::ContainerNode::resumePostAttachCallbacks): Ditto.
        (WebCore::ContainerNode::dispatchPostAttachCallbacks): Factored out from
        * dom/ContainerNode.h:
        * dom/Document.cpp:
        (WebCore::Document::recalcStyle): Added calls to
        suspendPostAttachCallbacks() and resumePostAttachCallbacks().
        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::attach): Changed to queue the widget update
        for post-attach.
        (WebCore::HTMLEmbedElement::updateWidget): Added. Called by the
        post-attach callback.
        * html/HTMLEmbedElement.h: Added an m_needWidgetUpdate member needed to
        prevent a double update if another plug-in's post-attach updateWidget()
        triggers a layout which updates the widget before this plug-in's
        post-attach callback is invoked.
        (WebCore::HTMLEmbedElement::setNeedWidgetUpdate): Added a setter for
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::attach): Changed to queue the widget update
        for post-attach.
        (WebCore::HTMLObjectElement::updateWidget): Added. Called by the
        post-attach callback.
        * html/HTMLObjectElement.h:
        (WebCore::HTMLObjectElement::setNeedWidgetUpdate): Added a setter for
        * html/HTMLPlugInElement.cpp:
        (WebCore::HTMLPlugInElement::updateWidgetCallback): Added.
        * html/HTMLPlugInElement.h:
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::updateWidget): Added calls to
        setNeedWidgetUpdate(false) so that if this method is called from
        FrameView::layout() during post-attach dispatch of another plug-in,
        it will not be called again when this plug-in's post-attach callback
        is dispatched.
        * rendering/RenderPartObject.h:
        (WebCore::RenderPartObject::updateWidget) Renamed argument to match
        the method definition.


        Reviewed by Antti Koivisto.

        - http://bugs.webkit.org/show_bug.cgi?id=15811
          WebKit plug-ins can re-enter WebKit under attach()

        * Plugins/WebNullPluginView.mm:
        (-[WebNullPluginView viewDidMoveToWindow]): Removed workaround for the
        above bug that added as part of fixing

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Dan Bernstein.
timothy@apple.com [Fri, 23 Nov 2007 04:45:26 +0000 (04:45 +0000)]
    Reviewed by Dan Bernstein.

        Fix the Element.hasStyleClass and Element.removeStyleClass helpers
        to not find and replace substrings, but whole class names at the
        beginning or end of the string or surrounded by whitespace.

        * page/inspector/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix typo.
timothy@apple.com [Fri, 23 Nov 2007 04:23:57 +0000 (04:23 +0000)]
Fix typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27980 268f45cc-cd09-0410-ab3c-d52691b4dbfc