16 years ago Reviewed by Timothy.
thatcher [Wed, 12 Jul 2006 08:55:24 +0000 (08:55 +0000)]
    Reviewed by Timothy.

        Lets Drosera build universal for the nightlies. Right now it is not
        possible to build a universal binary on a PPC machine because of a
        conflict with the universal SDK.

        * BuildSlaveSupport/build-launcher-app:
        * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Tim Hatcher.
tomernic [Wed, 12 Jul 2006 08:25:29 +0000 (08:25 +0000)]
    Reviewed by Tim Hatcher.

        <rdar://problem/4624858> AGL isn't 64-bit yet; temporarily remove it from WebKit 64-bit build

        Also, fixed a LOG_ERROR() so that it uses the CGL error instead of the AGL error; Tim H missed this in his build fix
        from earlier.

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
adele [Wed, 12 Jul 2006 08:17:49 +0000 (08:17 +0000)]

        Reviewed by Maciej.

        Test for: http://bugzilla.opendarwin.org/show_bug.cgi?id=9813
        OPTION text can paint over select element's scrollbar

        * fast/forms/option-text-clip-expected.checksum: Added.
        * fast/forms/option-text-clip-expected.png: Added.
        * fast/forms/option-text-clip-expected.txt: Added.
        * fast/forms/option-text-clip.html: Added.


        Reviewed by Maciej.

        Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=9813
        OPTION text can paint over select element's scrollbar

        Test: fast/forms/option-text-clip.html

        * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::paintObject):
        When calculating the clip to apply to the button text, also consider padding.
        In the future, we may have separate renderers for the text part, and the arrow part
        of the control, and then the separation should be natural.  For now, we use padding.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
ggaren [Wed, 12 Jul 2006 08:12:08 +0000 (08:12 +0000)]
    Reviewed by Maciej.

        - Implemented a vast number of renames and comment clarifications
        suggested during API review.

        JSInternalString -> JSString
        JS*Make -> JSValueMake*, JSObjectMake*
        JSTypeCode -> JSType
        JSValueIsInstanceOf -> JSValueIsInstanceOfConstructor (reads strangely well in client code)
        JSGC*Protect -> JSValue*Protect
        JS*Callback -> JSObject*Callback
        JSGetPropertyListCallback -> JSObjectAddPropertiesToListCallback
        JSPropertyEnumeratorGetNext -> JSPropertyEnumeratorGetNextName
        JSString* ->
            JSStringCreateWithUTF8CString, JSStringGetUTF8CString,
            JSStringGetMaximumUTF8CStringSize JSStringIsEqualToUTF8CString,
            JSStringCreateWithCFString, JSStringCopyCFString, JSStringCreateWithCharacters.

        - Changed functions taking a JSValue out arg and returning a bool indicating
        whether it was set to simply return a JSValue or NULL.

        - Removed JSStringGetCharacters because it's more documentation than code,
        and it's just a glorified memcpy built on existing API functionality.

        - Moved standard library includes into the headers that actually require them.

        - Standardized use of the phrase "Create Rule."

        - Removed JSLock from make functions that don't allocate.

        - Added exception handling to JSValueToBoolean, since we now allow
        callback objects to throw exceptions upon converting to boolean.

        - Renamed JSGCCollect to JSGarbageCollect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoMore build fixes for the deprecated AGL functions.
thatcher [Wed, 12 Jul 2006 06:00:31 +0000 (06:00 +0000)]
More build fixes for the deprecated AGL functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoForgot to commit a file this morning that actually makes the Drosera console open...
thatcher [Wed, 12 Jul 2006 04:26:01 +0000 (04:26 +0000)]
Forgot to commit a file this morning that actually makes the Drosera console open. Thanks bdash!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
ddkilzer [Wed, 12 Jul 2006 03:31:30 +0000 (03:31 +0000)]

        Windows build fix.  Reviewed by NOBODY.

        * WebCore.vcproj/WebCore/WebCore.vcproj:  Added JSHTMLOptionsCollection.cpp/h
        and JSHTMLOptionsCollectionCuston.cpp.  VC++ Express realphabetized the file list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Adele.
darin [Wed, 12 Jul 2006 02:55:47 +0000 (02:55 +0000)]
    Reviewed by Adele.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9809
          focus ring fails to appear on select element after choosing item from popup

        - includes http://bugzilla.opendarwin.org/show_bug.cgi?id=9853
          improvements to select element, including some storage leak fixes

        * html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::index): Use a const
        reference for the list items, so we don't have to copy a vector.
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::selectedIndex): Ditto.
        (WebCore::HTMLSelectElement::setSelectedIndex): Ditto.
        (WebCore::HTMLSelectElement::length): Ditto.
        (WebCore::HTMLSelectElement::remove): Ditto.
        (WebCore::HTMLSelectElement::value): Ditto.
        (WebCore::HTMLSelectElement::setValue): Ditto.
        (WebCore::HTMLSelectElement::stateValue): Ditto.
        (WebCore::HTMLSelectElement::restoreState): Ditto.
        (WebCore::HTMLSelectElement::appendFormData): Ditto.
        (WebCore::HTMLSelectElement::optionToListIndex): Ditto.
        (WebCore::HTMLSelectElement::listToOptionIndex): Ditto.
        (WebCore::HTMLSelectElement::recalcListItems): Made const, with the appropriate
        fields mutable.
        (WebCore::HTMLSelectElement::reset): Use a const reference for
        the list items, so we don't have to copy the vector. Remove the call to
        setSelectionChanged for the RenderMenuList case.
        (WebCore::HTMLSelectElement::notifyOptionSelected): Ditto, on both counts.
        (WebCore::HTMLSelectElement::defaultEventHandler): Call focus() before showing
        the pop-up.
        * html/HTMLSelectElement.h: The RenderMenuList class is no longer a friend.
        Changed the listItems function to return a const reference to the vector so
        it no longer copies the vector. Removed the const_cast to the call to
        recalcListItems and changed it to a const member function. Made m_recalcListItems
        * rendering/DeprecatedRenderSelect.cpp:
        (WebCore::DeprecatedRenderSelect::updateFromElement): Removed an unnecessary call
        to recalcListItems, which is called automatically. Use a const reference for the
        list items so we don't have to copy a vector.
        (WebCore::DeprecatedRenderSelect::layout): Ditto.
        (WebCore::DeprecatedRenderSelect::selectionChanged): Ditto.
        (WebCore::DeprecatedRenderSelect::updateSelection): Ditto.
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::RenderMenuList): Updated for renamed data members.
        (WebCore::RenderMenuList::createInnerBlock): Ditto.
        (WebCore::RenderMenuList::addChild): Ditto.
        (WebCore::RenderMenuList::removeChild): Ditto.
        (WebCore::RenderMenuList::setStyle): Ditto. Also removed code to set the style
        on the pop-up menu, because it's created with the correct style and destroyed
        before it a style change could occur.
        (WebCore::RenderMenuList::updateFromElement): Rearranged code to compute the
        maximum width in a simpler fashion, and to not bother trying to maintain
        the "selected" flags on the elements, since the HTMLSelectElement class
        takes care of that. Store the width as an int. Call setText to set the text
        based on the selected element's option text.
        (WebCore::RenderMenuList::paintObject): Don't check m_inner when setting
        up the clip -- always set up the clip.
        (WebCore::RenderMenuList::calcMinMaxWidth): Use m_optionsWidth directly
        instead of calling ceilf on m_longestWidth.
        (WebCore::RenderMenuList::showPopup): Don't use m_popupMenu to store the
        menu -- instead keep the pointer in a local variable. Get the selected
        index from the HTMLSelectElement.
        (WebCore::RenderMenuList::valueChanged): Call HTMLSelectElement::setSelectedIndex
        to do most of the work.
        * rendering/RenderMenuList.h: Renamed m_inner to m_innerBlock. Removed
        m_popupMenu, m_size, m_selectionChanged, and m_selectedIndex. Renamed
        m_longestWidth to m_optionsWidth and changed it to be an int. Removed
        unneeded override of removeLeftoverAnonymousBoxes function. Removed
        unneeded selectionChanged, setSelectionChanged, updateSelection, and
        hasPopupMenu functions. Removed extra includes.
        * rendering/RenderPopupMenu.cpp: (WebCore::RenderPopupMenu::populate):
        Change to iterate the list items instead of iterating all children
        of the select node.
        * rendering/RenderPopupMenu.h: Renamed getRenderMenuList to menuList.
        * rendering/RenderPopupMenuMac.mm:
        (WebCore::RenderPopupMenuMac::populate): Moved code to clear and create
        the pop-up here from the caller. Removed an extra retain that would cause
        the NSPopUpButtonCell to leak.
        (WebCore::RenderPopupMenuMac::showPopup): Removed unnecessary code to
        create the pop-up, which is now in populate, and also the call to the
        clear function, for the same reason. Reorganized code to make it a bit
        more readable. Removed an unnecessary if to check if frame is nil.
        Used a RefPtr to make sure we don't make a call on a frame after it's
        deleted. As part of the reorganization fixed a problem where we'd retain
        the event and then return early without releasing it in one case.
        (WebCore::RenderPopupMenuMac::addSeparator): Tweaked a little.
        (WebCore::RenderPopupMenuMac::addGroupLabel): Grouped all the code to
        manage the NSMenu at the bottom of the function.
        (WebCore::RenderPopupMenuMac::addOption): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
justing [Wed, 12 Jul 2006 02:21:00 +0000 (02:21 +0000)]

        Reviewed by levi

        REGRESSION: Mispelling markers are still displayed when using the delete key to place caret into a misspelled word

        * editing/deleting/delete-after-span-ws-001-expected.checksum:
        * editing/deleting/delete-after-span-ws-001-expected.png:
        * editing/deleting/delete-after-span-ws-002-expected.checksum:
        * editing/deleting/delete-after-span-ws-002-expected.png:
        * editing/deleting/delete-after-span-ws-003-expected.checksum:
        * editing/deleting/delete-after-span-ws-003-expected.png:
        * editing/deleting/delete-block-merge-contents-010-expected.checksum:
        * editing/deleting/delete-block-merge-contents-010-expected.png:
        * editing/deleting/merge-unrendered-space-expected.checksum:
        * editing/deleting/merge-unrendered-space-expected.png:


        Reviewed by levi

        REGRESSION: Mispelling markers are still displayed when using the delete key to place caret into a misspelled word

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::respondToChangedSelection): Remove markers from newAdjacentWords
        even if oldAdjacentWords is equal to newAdjacentWords.  This happens during a deletion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agobetter build fix since other projects that include DOMPrivate.h can't included JavaSc...
thatcher [Wed, 12 Jul 2006 00:45:06 +0000 (00:45 +0000)]
better build fix since other projects that include DOMPrivate.h can't included JavaScriptCore/npruntime.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by NOBODY (build fix)
tomernic [Wed, 12 Jul 2006 00:40:44 +0000 (00:40 +0000)]
    Reviewed by NOBODY (build fix)

        * bindings/objc/DOMPrivate.h:
        Don't @class NPObject; that breaks files that actually #import <JavaScriptCore/npruntime.h>, since the NPObject
        there is of a different type.
        Also clarified a highly misleading comment from my last commit.  I meant to clarify the comment
        before landing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-07-12 Anders Carlsson <acarlsson@apple.com>
andersca [Wed, 12 Jul 2006 00:27:47 +0000 (00:27 +0000)]
2006-07-12  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        REGRESSION: Crash when adding to cart at <http://www.yemeksepeti.com/>

        * html/HTMLTokenizer.cpp:
        Don't load external scripts if the parser is stopped.

        * manual-tests/open-close-tokenizer-crash.html: Added.
        * manual-tests/resources/empty-file.js: Added.
        * manual-tests/resources/open-close-tokenizer-crash.html: Added.
        Add manual test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Kevin and Tim O
sullivan [Wed, 12 Jul 2006 00:00:58 +0000 (00:00 +0000)]
    Reviewed by Kevin and Tim O

        - added support for creating a selection image with white text

        * WebView/WebDocumentPrivate.h:
        added -selectionImageForcingWhiteText: and -selectionImageRect to the private
        <WebDocumentSelection> protocol

        * Misc/WebSearchableTextView.m:
        (-[NSString selectionImageForcingWhiteText:]):
        added stub for this new method to this obsolete class to satisfy the compiler
        (-[NSString selectionImageRect]):

        * WebView/WebHTMLView.m:
        (-[WebHTMLView _selectionDraggingImage]):
        now calls -selectionImageForcingWhiteText:NO instead of just -selectionImage
        (-[WebHTMLView _selectionDraggingRect]):
        now calls selectionImageRect, to which the implementation moved
        (-[WebHTMLView selectionImageForcingWhiteText:]):
        implemented this new method by calling through to new bridge method selectionImageForcingWhiteText:
        (-[WebHTMLView selectionImageRect]):
        implemented this new method by using existing _selectionDraggingRect implementation

        * WebView/WebPDFView.m:
        (-[WebPDFView selectionImageForcingWhiteText:]):
        implemented by using code that was formerly in Safari
        (-[WebPDFView selectionImageRect]):
        implemented by returning selectionRect

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Kevin, Timo O, Brady, Darin, and Hyatt (whee!)
sullivan [Tue, 11 Jul 2006 23:59:34 +0000 (23:59 +0000)]
    Reviewed by Kevin, Timo O, Brady, Darin, and Hyatt (whee!)

        - added support for creating a selection image with white text

        * rendering/RenderObject.h:
        add PaintRestriction enum
        add forceWhiteText boolean to PaintInfo struct

        * page/FramePrivate.h:
        replaced m_selectionOnly bool with m_paintRestriction, which also handles forcing the
        text to white

        * page/Frame.cpp:
        updated to use & pass m_paintRestriction where it used to use & pass just m_selectionOnly

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        now takes forceWhiteText parameter, stored in FramePrivate as part of PaintRestriction

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge selectionImageForcingWhiteText:]):
        renamed from selectionImage, now takes forceWhiteText parameter, which is passed
        down into Frame

        * rendering/RenderLayer.h:
        * rendering/RenderLayer.cpp:
        use a PaintRestriction value where we used to use a selectionOnly bool
        ditto; also stores forceWhiteText in PaintInfo struct

        * kcanvas/KCanvasResources.cpp:
        updated for changed signature of PaintInfo constructor

        * ksvg2/svg/SVGMaskElement.cpp:

        * ksvg2/svg/SVGPatternElement.cpp:

        * rendering/InlineTextBox.cpp:
        paint with white text color if forceWhiteText is set in PaintInfo struct

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
tomernic [Tue, 11 Jul 2006 23:58:44 +0000 (23:58 +0000)]

        Reviewed by Geoff.

        Test case for <http://bugzilla.opendarwin.org/show_bug.cgi?id=9843>:
        Give Netscape plug-ins access to their own DOM element

        * plugins/netscape-dom-access-expected.checksum: Added.
        * plugins/netscape-dom-access-expected.png: Added.
        * plugins/netscape-dom-access-expected.txt: Added.
        * plugins/netscape-dom-access.html: Added.


        Reviewed by Anders.

        Give Netscape plug-ins access to their own DOM element

        * html/HTMLPlugInElement.h:
        Just import JSC headers on Mac.  The NPObject and Bindings::Instance stuff is only used on Mac anyway.
        Changed __APPLE__ to PLATFORM(MAC).
        Added m_NPObject ivar.
        * html/HTMLPlugInElement.cpp:
        Initialize the NPObject.
        Release the NPObject when the element is destroyed.
        Creates an NPObject for the element.
        Returns the NPObject for the element, creating and caching it if necessary.

        * html/HTMLAppletElement.h:
        Changed __APPLE__ to PLATFORM(MAC).
        * html/HTMLAppletElement.cpp:
        * html/HTMLEmbedElement.h:
        * html/HTMLEmbedElement.cpp:
        * html/HTMLObjectElement.h:
        * html/HTMLObjectElement.cpp:

        * bindings/objc/DOMPrivate.h:
        Added -[DOMElement _NPObject].

        * bindings/objc/DOM.mm:
        (-[DOMElement _NPObject]):
        Returns the NPObject for the element.  Since this is only needed by the Netscape plug-in API, you can only get
        the NPObject for applet, embed, and object elements.


        Reviewed by Geoff.

        Give Netscape plug-ins access to their own DOM element

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView dealloc]):
        Release DOM element.
        (-[WebBaseNetscapePluginView getVariable:value:]):
        Return NPObject for plugin DOM element.

        * Plugins/WebNetscapePluginEmbeddedView.h:
        * Plugins/WebNetscapePluginEmbeddedView.m:
        (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
        Now takes a DOMElement, in much the same way that WebKit plug-in views take a DOMElement.

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
        Pass DOMElement to Netscape plug-ins.
        (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
adele [Tue, 11 Jul 2006 23:32:34 +0000 (23:32 +0000)]

        Reviewed by Hyatt.

        Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=9861
        REGRESSION: Can't dynamically change list box to popup

        * fast/forms/select-change-listbox-to-popup-expected.checksum: Added.
        * fast/forms/select-change-listbox-to-popup-expected.png: Added.
        * fast/forms/select-change-listbox-to-popup-expected.txt: Added.
        * fast/forms/select-change-listbox-to-popup.html: Added.
        * fast/forms/select-change-popup-to-listbox.html:


        Reviewed by Hyatt.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9861
        REGRESSION: Can't dynamically change list box to popup

        and updated fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9859
        REGRESSION: Can't dynamically change popup to list box

        The original fix for 9859 was in the renderer, and I think we can catch the change
        earlier in the element to detach and reattach.

        I also did some cleanup to remove the PopupButton code path from DeprecatedRenderSelect

        Test: fast/forms/select-change-listbox-to-popup.html

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::parseMappedAttribute): If the new attribute value is going to require us to change from listbox to popup or vice versa,
        and we're already attached, then detach and reattach to create the correct renderer.  If we're not attached, then we'll create the correct renderer
        when we attach.
        (WebCore::HTMLSelectElement::recalcStyle): Updated shouldUseMenuList since it no longer takes a RenderStyle.
        (WebCore::HTMLSelectElement::isKeyboardFocusable): ditto.
        (WebCore::HTMLSelectElement::isMouseFocusable): ditto.
        (WebCore::HTMLSelectElement::createRenderer): ditto.
        (WebCore::HTMLSelectElement::setRecalcListItems): ditto.
        (WebCore::HTMLSelectElement::reset): ditto.
        (WebCore::HTMLSelectElement::notifyOptionSelected): ditto.
        (WebCore::HTMLSelectElement::defaultEventHandler): ditto.

        * html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::shouldUseMenuList):
        This method no longer takes a RenderStyle.  That was leftover from when we used to use the appearance
        to determine whether or not to use the new menu list implementation.

        * rendering/DeprecatedRenderSelect.h: Removed PopupButton code path.
        * rendering/DeprecatedRenderSelect.cpp:

        * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement):
        Backed out previous fix since this is now done in HTMLSelectElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
justing [Tue, 11 Jul 2006 22:35:24 +0000 (22:35 +0000)]

        Reviewed by levi & thatcher

        GMail Editor: Operations that use drop down menus blow away the selection

        * editing/selection/drag-to-contenteditable-iframe-expected.txt:
        * editing/selection/subframe-with-selection-expected.checksum: Added.
        * editing/selection/subframe-with-selection-expected.png: Added.
        * editing/selection/subframe-with-selection-expected.txt: Added.
        * editing/selection/subframe-with-selection.html: Added.


        Reviewed by levi & thatcher

        GMail Editor: Operations that use drop down menus blow away the selection

        * WebView/WebHTMLView.m:
        (-[NSArray maintainsInactiveSelection]): Maintain an inactive selection
        when resigning as first responder if the selection is editable
        or if the WebView tells us to.
        * WebView/WebView.m:
        (-[WebView maintainsInactiveSelection]): Just because a WebView is
        editable doesn't mean selections inside subframes will be.  Return
        NO by default.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
adele [Tue, 11 Jul 2006 21:42:25 +0000 (21:42 +0000)]

        Reviewed by Hyatt.

        Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9859
        REGRESSION: Can't dynamically change popup to list box

        * fast/forms/select-change-popup-to-listbox-expected.checksum: Added.
        * fast/forms/select-change-popup-to-listbox-expected.png: Added.
        * fast/forms/select-change-popup-to-listbox-expected.txt: Added.
        * fast/forms/select-change-popup-to-listbox.html: Added.


        Reviewed by Hyatt.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9859
        REGRESSION: Can't dynamically change popup to list box

        Test: fast/forms/select-change-popup-to-listbox.html

        * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement):
        If the select element has the multiple property set, or has a size > 1, then it
        really should be a list box, so we detach and attach the element so it creates the
        correct type of renderer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Beth Dakin and Tim Omernick
sullivan [Tue, 11 Jul 2006 21:31:19 +0000 (21:31 +0000)]
    Reviewed by Beth Dakin and Tim Omernick

        - fixed <rdar://problem/4622794> HiDPI: dragging the selection in Safari can show pixel cracks
        at non-integral scale factors

        * bridge/mac/FrameMac.mm:
        round image rect in window coordinate space

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Tim Hatcher.
tomernic [Tue, 11 Jul 2006 20:58:37 +0000 (20:58 +0000)]
    Reviewed by Tim Hatcher.

        <rdar://problem/4622748> WebKit now uses deprecated AGL functions

        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView _createWindowedAGLContext]):
        aglSetDrawable() is deprecated in AGL 3.0.  Use aglSetWindowRef() instead.
        (-[WebBaseNetscapePluginView _createWindowlessAGLContext]):
        aglSetOffScreen() is deprecated in AGL 3.0.  Use CGLSetOffScreen(), which does the same thing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
ap [Tue, 11 Jul 2006 19:07:00 +0000 (19:07 +0000)]
    Reviewed by Darin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9572
        Add application/xhtml+xml to the Accept header

        The fix itself was landed on 2006-07-09, but I forgot about the test.

        * http/tests/misc/xhtml-expected.txt: Added.
        * http/tests/misc/xhtml.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Adele.
bdakin [Tue, 11 Jul 2006 18:54:45 +0000 (18:54 +0000)]
    Reviewed by Adele.

        Adele checked in new results for this test when you could style
        selects, but the styling of selects is turned off for now, so back
        to the original results.

        * fast/forms/001-expected.checksum:
        * fast/forms/001-expected.png:
        * fast/forms/001-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoAdding the radar to a change.
thatcher [Tue, 11 Jul 2006 18:40:01 +0000 (18:40 +0000)]
Adding the radar to a change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Tim O.
ap [Tue, 11 Jul 2006 18:21:18 +0000 (18:21 +0000)]
    Reviewed by Tim O.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=7808
        Assertion failure in -[WebBaseNetscapePluginStream dealloc] when requesting an invalid URL

        * Plugins/WebNetscapePluginStream.m:
        (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
        Remove the early return when requesting an invalid (unsupported) URL.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
        (pluginInvoke): treat getURL() with one parameter as if the second parameter were NULL -
        should open a new stream and deliver the data to the current instance.

        * plugins/get-empty-url-expected.txt: Added.
        * plugins/get-empty-url.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
thatcher [Tue, 11 Jul 2006 18:13:33 +0000 (18:13 +0000)]
    Reviewed by Darin.

        Bug 9598: [Drosera] add a JavaScript evaluator console

        * Drosera/DebuggerApplication.h:
        * Drosera/DebuggerApplication.m:
        (-[DebuggerApplication knownServers]):
        * Drosera/DebuggerDocument.h:
        * Drosera/DebuggerDocument.m:
        (-[WebScriptObject evaluateScript:inCallFrame:]):
        (-[WebScriptObject showConsole:]):
        (-[WebScriptObject toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]):
        (-[WebScriptObject toolbarDefaultItemIdentifiers:]):
        (-[WebScriptObject toolbarAllowedItemIdentifiers:]):
        (-[WebScriptObject webView:createWebViewWithRequest:]):
        (-[WebScriptObject webViewShow:]):
        (-[WebScriptObject webViewAreToolbarsVisible:]):
        (-[WebScriptObject webView:setToolbarsVisible:]):
        (-[WebScriptObject webView:setResizable:]):
        (-[WebScriptObject webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
        (-[WebScriptObject scriptConfirmSheetDidEnd:returnCode:contextInfo:]):
        (-[WebScriptObject webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
        (-[WebScriptObject webView:windowScriptObjectAvailable:]):
        (-[WebScriptObject webView:didFinishLoadForFrame:]):
        (-[WebScriptObject webView:didReceiveTitle:forFrame:]):
        * Drosera/Drosera.xcodeproj/project.pbxproj:
        * Drosera/Images/console.png: Added.
        * Drosera/console.css: Added.
        * Drosera/console.html: Added.
        * Drosera/console.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by a tired Geoff.
thatcher [Tue, 11 Jul 2006 07:51:34 +0000 (07:51 +0000)]
    Reviewed by a tired Geoff.

        Bug 9597: [Drosera] hook up the variables table to show stack variables

        * Drosera/DebuggerDocument.m:
        (-[WebScriptObject isSelectorExcludedFromWebScript:]):
        (-[WebScriptObject webScriptAttributeKeysForScriptObject:]):
        (-[WebScriptObject localScopeVariableNamesForCallFrame:]):
        (-[WebScriptObject valueForScopeVariableNamed:inCallFrame:]):
        (-[WebScriptObject webView:didReceiveTitle:forFrame:]):
        (-[WebScriptObject webView:didLoadMainResourceForDataSource:]):
        (-[WebScriptObject webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
        (-[WebScriptObject webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
        (-[WebScriptObject webView:willExecuteStatement:sourceId:line:forWebFrame:]):
        (-[WebScriptObject webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
        * Drosera/debugger.css:
        * Drosera/debugger.html:
        * Drosera/debugger.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Beth Dakin.
tomernic [Tue, 11 Jul 2006 07:30:58 +0000 (07:30 +0000)]
    Reviewed by Beth Dakin.

        Add DOM access test to DumpRenderTree's Netscape plug-in

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Geoff.
darin [Tue, 11 Jul 2006 06:04:43 +0000 (06:04 +0000)]
    Reviewed by Geoff.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9811
          OPTION text contained in OPTGROUP appears at the wrong size

        * dom/Node.h:
        * dom/Node.cpp: (WebCore::Node::renderStyle): Made a const member function.
        The derived classes were overriding with const member functions, and I could
        change either this or the derived -- decided to do this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Geoff.
darin [Tue, 11 Jul 2006 05:48:29 +0000 (05:48 +0000)]
    Reviewed by Geoff.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9810
          OPTGROUP label text is using the default font instead of Lucida Grande

        * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::setFontFromControlSize):
        Code wants the family name, but was calling fontName, which is not the same thing.
        Also removed the unneeded conversion to DeprecatedString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
ggaren [Tue, 11 Jul 2006 05:37:00 +0000 (05:37 +0000)]
    Reviewed by Darin.

        - Changed public header includes to the <JavaScriptCore/ style.
        - Changed instances of 'buffer' to 'string' since we decided on
        JSInternalString instead of JSStringBuffer.

        * API/JSContextRef.h:
        * API/JSInternalStringRef.cpp:
        * API/JSInternalStringRef.h:
        * API/JSNode.c:
        * API/JSObjectRef.cpp:
        * API/JSValueRef.h:
        * API/JavaScriptCore.h:
        * API/minidom.c:
        * API/testapi.c:
        (main): I noticed that we were prematurely releasing some string buffers,
        so I moved their release calls to the end of main(). I got rid of 'Buf' in *Buf
        (sometimes changing to 'IString', when necessary to differentiate a variable)
        to match the buffer->string change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebKitTools:
ddkilzer [Tue, 11 Jul 2006 04:36:06 +0000 (04:36 +0000)]

        Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=9839
          Bug 9839: Nightly launcher fails to detect extensions when extension causes crash on load

        Now track three states: initializing, running, and closed.  If we are launched and the previous
        state was initializing then we likely just experienced a crash on launch.

        * WebKitLauncher/WebKitNightlyEnabler.m:
        (myApplicationWillFinishLaunching): Improve wording of dialog.  Update to set new running state.
        (myApplicationWillTerminate): Update to use new states.
        (cleanUpAfterOurselves): Display alert if previous state was initializing.  Set state as
        initializing as early as practical.
        (symbol_lookup): Bring code up to speed with formatting guidelines.
        (GDSymbolLookup): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago * kjs/value.cpp: (KJS::JSValue::toInt32Inline): Added inline keyword one...
darin [Tue, 11 Jul 2006 03:37:22 +0000 (03:37 +0000)]
    * kjs/value.cpp: (KJS::JSValue::toInt32Inline): Added inline keyword one more place.
        Just in case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoMove the release tag.
thatcher [Tue, 11 Jul 2006 03:36:33 +0000 (03:36 +0000)]
Move the release tag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - fix the release build
darin [Tue, 11 Jul 2006 03:34:43 +0000 (03:34 +0000)]
    - fix the release build

        * kjs/value.h:
        * kjs/value.cpp:
        (KJS::JSValue::toInt32Inline): Move the code here to an inline.
        (KJS::JSValue::toInt32): Call the inline from both overloaded toInt32 functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoVersioning
thatcher [Tue, 11 Jul 2006 03:33:44 +0000 (03:33 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
ddkilzer [Tue, 11 Jul 2006 03:16:41 +0000 (03:16 +0000)]

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9179
          Implement select.options.add() method

        * JavaScriptCore.exp: Added overloaded KJS::JSValue::toInt32() method.
        * JavaScriptCore.xcodeproj/project.pbxproj: Altered attributes metadata for
        kjs/value.h to make it available as a forwarded header.
        * kjs/lookup.h:
        (KJS::lookupPut): Extracted a lookupPut() method from the existing lookupPut() method.
        The new method returns a boolean value if no entry is found in the lookup table.
        * kjs/value.cpp:
        (KJS::JSValue::toInt32): Overloaded toInt32() method with boolean "Ok" argument.
        * kjs/value.h: Ditto.


        Reviewed by Darin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9179
          Implement select.options.add() method

        * fast/dom/select-selectedIndex-multiple-expected.txt: Updated test results.
        * fast/dom/select-selectedIndex-multiple.html: Updated to print comments between
        tests to make failures easier to track down.
        * fast/dom/select-selectedIndex-expected.txt: Mirrored updates from select-selectedIndex-multiple.html
        * fast/dom/select-selectedIndex.html: Ditto.
        * fast/js/resources/select-options-add.js: Added.
        * fast/js/select-options-add-expected.txt: Added.
        * fast/js/select-options-add.html: Added.


        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9179
          Implement select.options.add() method

        - fast/dom/select-selectedIndex-multiple.html
        - fast/dom/select-selectedIndex.html
        - fast/js/select-options-add.html

        * DerivedSources.make: Added JSHTMLOptionsCollection.h.
        * ForwardingHeaders/kjs/operations.h: Added.
        * WebCore.xcodeproj/project.pbxproj: Added new source files.
        * bindings/js/JSHTMLOptionsCollectionCustom.cpp: Added.
        * bindings/js/kjs_html.cpp: Removed JSHTMLOptionsCollection implementation.
        Renamed classes and methods for consistency.
        * bindings/js/kjs_html.h: Ditto.
        * bindings/scripts/CodeGeneratorJS.pm: Added support for HasCustomIndexSetter class attribute.
        Added support for Optional parameter attribute, which makes generated code assume overloaded
        implementation methods are available for a JavaScript function with optional arguments.  Changed
        local 'impl' variables to 'imp' so that impl() methods could be called without class designation.
        * html/HTMLOptionElement.idl: Added GenerateNativeConverter attribute.
        * html/HTMLOptionsCollection.cpp: Added methods used by generated JSHTMLOptionsCollection class.
        * html/HTMLOptionsCollection.h: Ditto.
        * html/HTMLOptionsCollection.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Dave Hyatt.
harrison [Tue, 11 Jul 2006 02:02:11 +0000 (02:02 +0000)]
    Reviewed by Dave Hyatt.

        <rdar://problem/4602408> -webkit-highlight needs to support images and elements other than text

        * rendering/RenderBox.cpp:
        * rendering/RenderBox.h:
        Utility for subclasses.

        * rendering/RenderImage.cpp:
        Custom highlight in front of images.

        * rendering/RenderListMarker.cpp:
        Custom highlight in front of list markers.

        * rendering/RenderWidget.cpp:
        Custom highlight in front of objects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Better fix for repainting issue with positioned objects when height
hyatt [Tue, 11 Jul 2006 01:22:07 +0000 (01:22 +0000)]
    Better fix for repainting issue with positioned objects when height
        changes.  Optimize when only a positioned child changes so that we don't
        incorrectly do normal flow layout.

        Reviewed by darin

        * WebCore.xcodeproj/project.pbxproj:
        * rendering/RenderBlock.cpp:
        * rendering/RenderFlexibleBox.cpp:
        * rendering/RenderTable.cpp:
        * rendering/RenderView.cpp:
        * rendering/bidi.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago No review necessary. Removed bogus file I accidentally checked in before.
ggaren [Tue, 11 Jul 2006 00:27:28 +0000 (00:27 +0000)]
    No review necessary. Removed bogus file I accidentally checked in before.

        * API/JSInternalSringRef.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
ggaren [Tue, 11 Jul 2006 00:26:25 +0000 (00:26 +0000)]
    Reviewed by Darin.

        Added exception out parameter to API object callbacks, removed semi-bogus
        JSContext(.*)Exception functions.

        To make these calls syntactically simple, I added an exceptionSlot()
        method to the ExecState class, which provides a JSValue** slot in which to
        store a JSValue* exception.

        * API/APICast.h:
        * API/JSCallbackConstructor.cpp:
        * API/JSCallbackFunction.cpp:
        * API/JSCallbackObject.cpp:
        * API/JSContextRef.cpp:
        * API/JSContextRef.h:
        * API/JSNode.c:
        * API/JSNode.h:
        * API/JSNodeList.c:
        * API/JSObjectRef.h:
        * API/minidom.c:
        * API/testapi.c:
        * JavaScriptCore.exp:
        * kjs/ExecState.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
adele [Mon, 10 Jul 2006 23:52:44 +0000 (23:52 +0000)]

        Reviewed by Beth.

        Test for <rdar://problem/4621442> REGRESSION (NativePopup) : Popup menus aren't drawn correctly on page at orbitz.com; cheaptickets.com

        * fast/forms/select-style-expected.checksum: Added.
        * fast/forms/select-style-expected.png: Added.
        * fast/forms/select-style-expected.txt: Added.
        * fast/forms/select-style.html: Added.


        Reviewed by Beth.

        - Fix for <rdar://problem/4621442> REGRESSION (NativePopup) : Popup menus aren't drawn correctly on page at orbitz.com; cheaptickets.com

        Test: fast/forms/select-style.html

        * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):
        Don't let popups be style-able for now.  We'll allow it later, when we
        have a good way to handle border & backgrounds and still having it look like a control.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by John Sullivan.
sullivan [Mon, 10 Jul 2006 23:50:32 +0000 (23:50 +0000)]
    Reviewed by John Sullivan.

        - fix <rdar://problem/4621541>, aka <http://bugzilla.opendarwin.org/show_bug.cgi?id=9838>
          REGRESSION (r14968-r14977): View Source doesn't work for pages from the back/forward cache

        * WebView/WebDataSource.m:
        (-[WebDataSource _setPrimaryLoadComplete:]): Set our data only if the frame loader is
        has just loaded it (when coming from the back/forward cache, it hasn't).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by harrison
justing [Mon, 10 Jul 2006 22:29:02 +0000 (22:29 +0000)]
    Reviewed by harrison

        9A213 + Safari 521.15.1 Crash with To Do's alarm icon (WebCore::maxDeepOffset(WebCore::Node const*) )
        REGRESSION: Dragging selection over input field results in a crash (WebCore::maxDeepOffset(WebCore::Node const*)

        * WebCore.xcodeproj/project.pbxproj:
        * editing/Selection.cpp:
        (WebCore::Selection::adjustForEditableContent): Iterate using next/previousVisuallyDistinctCandidate
        instead of traverseNext/Previous node because we were skipping positions.  Jump out of shadow trees.
        Migrate to isEditablePosition instead of isContentEditable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Adele.
bdakin [Mon, 10 Jul 2006 22:25:41 +0000 (22:25 +0000)]
    Reviewed by Adele.

        Shuffling comments around from my last check-in to make things read
        more clearly.

        * page/DOMWindow.h:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
bdakin [Mon, 10 Jul 2006 22:05:05 +0000 (22:05 +0000)]
    Reviewed by Darin.

        Fix for <rdar://problem/4621095> The should be a way to
        access the user interface scale factor through the DOM

        window.devicePixelRatio returns the user interface scale factor.

        * page/DOMWindow.cpp:
        * page/DOMWindow.h:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
ggaren [Mon, 10 Jul 2006 21:17:26 +0000 (21:17 +0000)]
    Reviewed by Darin.

        Improved type safety by implementing opaque JSValue/JSObject typing through
        abuse of 'const', not void*. Also fixed an alarming number of bugs
        exposed by this new type safety.

        I made one design change in JavaScriptCore, which is that the JSObject
        constructor should take a JSValue* as its prototype argument, not a JSObject*,
        since we allow the prototype to be any JSValue*, including jsNull(), for

        * API/APICast.h:
        * API/JSBase.h:
        * API/JSCallbackConstructor.cpp:
        * API/JSCallbackFunction.cpp:
        * API/JSCallbackObject.cpp:
        * API/JSCallbackObject.h:
        * API/JSContextRef.cpp:
        * API/JSNode.c:
        * API/JSObjectRef.cpp:
        * API/JSObjectRef.h:
        * API/testapi.c:
        * ChangeLog:
        * kjs/object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago http://bugzilla.opendarwin.org/show_bug.cgi?id=9830
adele [Mon, 10 Jul 2006 20:53:26 +0000 (20:53 +0000)]
        More pixel test results need updating since switching to native popup

        * editing/selection/replaced-boundaries-3-expected.checksum:
        * editing/selection/replaced-boundaries-3-expected.png:
        * fast/block/margin-collapse/103-expected.checksum:
        * fast/block/margin-collapse/103-expected.png:
        * fast/forms/001-expected.checksum:
        * fast/forms/001-expected.png:
        * fast/forms/HTMLOptionElement_label01-expected.checksum:
        * fast/forms/HTMLOptionElement_label01-expected.png:
        * fast/forms/HTMLOptionElement_label02-expected.checksum:
        * fast/forms/HTMLOptionElement_label02-expected.png:
        * fast/forms/HTMLOptionElement_label03-expected.checksum:
        * fast/forms/HTMLOptionElement_label03-expected.png:
        * fast/forms/HTMLOptionElement_label04-expected.checksum:
        * fast/forms/HTMLOptionElement_label04-expected.png:
        * fast/forms/form-element-geometry-expected.checksum:
        * fast/forms/form-element-geometry-expected.png:
        * fast/forms/option-script-expected.checksum:
        * fast/forms/option-script-expected.png:
        * fast/forms/option-strip-whitespace-expected.checksum:
        * fast/forms/option-strip-whitespace-expected.png:
        * fast/invalid/014-expected.checksum:
        * fast/invalid/014-expected.png:
        * fast/parser/document-write-option-expected.checksum:
        * fast/parser/document-write-option-expected.png:
        * tables/mozilla/bugs/bug2479-3-expected.checksum:
        * tables/mozilla/bugs/bug2479-3-expected.png:
        * tables/mozilla/bugs/bug29326-expected.checksum:
        * tables/mozilla/bugs/bug29326-expected.png:
        * tables/mozilla/bugs/bug33855-expected.checksum:
        * tables/mozilla/bugs/bug33855-expected.png:
        * tables/mozilla/bugs/bug96334-expected.checksum:
        * tables/mozilla/bugs/bug96334-expected.png:
        * tables/mozilla/core/margins-expected.checksum:
        * tables/mozilla/core/margins-expected.png:
        * tables/mozilla/dom/tableDom-expected.checksum:
        * tables/mozilla/dom/tableDom-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
beidson [Mon, 10 Jul 2006 17:47:41 +0000 (17:47 +0000)]

        Reviewed by Alexey

        Resolved the console error messages people got from the new DB even if they didn't have it enabled

        * icon/IconDatabase.cpp:
        Added quick check to bail if the DB isn't open


        Reviewed by Alexey

        Resolved the console error messages people got from the new DB even if they didn't have it enabled

        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase init]):
        Disabled initializing the IconDatabaseBridge if user is living on the old DB

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Approved by Maciej, Darin.
ggaren [Mon, 10 Jul 2006 17:41:32 +0000 (17:41 +0000)]
    Approved by Maciej, Darin.

        Renamed JSStringBufferRef to JSInternalStringRef. "Internal string" means the
        JavaScript engine's internal string representation, which is the most
        low-level and efficient representation to use when interfacing with JavaScript.

        * API/APICast.h:
        * API/JSBase.h:
        * API/JSCallbackObject.cpp:
        * API/JSContextRef.cpp:
        * API/JSContextRef.h:
        * API/JSInternalStringRef.cpp: Added.
        * API/JSInternalStringRef.h: Added.
        * API/JSNode.c:
        * API/JSNodeList.c:
        * API/JSObjectRef.cpp:
        * API/JSObjectRef.h:
        * API/JSStringBufferRef.cpp: Removed.
        * API/JSStringBufferRef.h: Removed.
        * API/JSValueRef.h:
        * API/JavaScriptCore.h:
        * API/minidom.c:
        * API/testapi.c:
        * JavaScriptCore.exp:
        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@15306 268f45cc-cd09-0410...
harrison [Mon, 10 Jul 2006 16:48:37 +0000 (16:48 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
darin [Mon, 10 Jul 2006 16:18:05 +0000 (16:18 +0000)]
    Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9808
          REGRESSION: Incorrect layout (and ERROR) when forcing ATSU For All Text

        * manual-tests/ATSU-bad-layout.html: Added.
        * platform/mac/FontMac.mm:
        (WebCore::Font::floatWidthForComplexText): Return 0 immediately for empty runs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - try to fix the no-SVG build
darin [Mon, 10 Jul 2006 15:54:49 +0000 (15:54 +0000)]
    - try to fix the no-SVG build

        * ksvg2/misc/SVGImageLoader.cpp: Move namespace brace inside the #if.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Anders.
darin [Mon, 10 Jul 2006 15:53:47 +0000 (15:53 +0000)]
    Reviewed by Anders.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9833
          REGRESSION: Reproducible crash: RenderMenuList.cpp:58: failed assertion `!m_first'

        * manual-tests/empty-title-popup.html: Added.

        * rendering/RenderMenuList.h: Add createInnerBlock.
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::createInnerBlock): Factored out of addChild.
        (WebCore::RenderMenuList::addChild): Call createInnerBlock.
        (WebCore::RenderMenuList::setText): Changed parameter type.
        (WebCore::RenderMenuList::showPopup): Call createInnerBlock before calling
        the parent class's addChild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - try to fix Windows build
darin [Mon, 10 Jul 2006 15:34:04 +0000 (15:34 +0000)]
    - try to fix Windows build

        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
        Remove include paths with "khtml" in them. Add one for "html" subdir or WebCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago * tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
darin [Mon, 10 Jul 2006 15:00:20 +0000 (15:00 +0000)]
    * tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
        Updated one more result for Adele's 4463835 change last night.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
ddkilzer [Mon, 10 Jul 2006 12:57:33 +0000 (12:57 +0000)]

        Reviewed by Maciej via IRC.  Patch by Rob Buis.

        Make sure the attributes are calculated against viewport width value,
        as defined in the spec.  http://paste.lisp.org/display/22342

        * ksvg2/svg/SVGEllipseElement.cpp:
        (WebCore::SVGEllipseElement::rx):  Changed LM_HEIGHT to LM_WIDTH.
        * ksvg2/svg/SVGLineElement.cpp:
        (SVGLineElement::x2): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
bdakin [Mon, 10 Jul 2006 11:39:35 +0000 (11:39 +0000)]
    Reviewed by Maciej.

        Fix for <rdar://problem/4610314> Support the CSS3 content property
        for images

        This patch provides initial support for the CSS3 content property.
        It lacks support for any content other than images, and only allows
        content for elements that seemed safe for now.

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty): Remove restrictions for
        just :before and :after
        * html/HTMLBRElement.cpp:
        * html/HTMLFrameSetElement.cpp:
        * html/HTMLImageElement.cpp:
        * html/HTMLLegendElement.cpp:
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::setCachedImage): Don't allow the image to be
        set this way if it was already set with the content property.
        * rendering/RenderImage.h:
        (WebCore::RenderImage::setIsAnonymousImage): Anonymous images are
        those set through the content property.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::createObject): If there is content
        specified, create a RenderImage with the content and initialize the
        cached image to whatever was specified in the CSS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by NOBODY (Build Fix!)
beidson [Mon, 10 Jul 2006 10:31:06 +0000 (10:31 +0000)]
    Reviewed by NOBODY (Build Fix!)

        * icon/SiteIcon.cpp:
        Release build made an "unused variable" warning, which is, of course, an error.  fixed that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej
beidson [Mon, 10 Jul 2006 09:57:23 +0000 (09:57 +0000)]
    Reviewed by Maciej

        SQLite Icon DB now fully replicates functionality of the old DB, including pruning to keep unused
        information out to keep down disk usage.  For now, it is still off by default, as the critical
        feature of importing old icons into the new DB is still unrealized.
        If you'd like to test, add #define ICONDEBUG to your WebKitPrefix.h

        * icon/IconDatabase.cpp:
          -Sets up a timer for initial pruning
          -Switched away from "dirty blob hack" as the problem is provisionally solved
          -Same as found in WebKit
          -Adds up all retainers of icon
          -Wipes an Icon table entry out
          -Added ability to get an iconID without creating a new one if a lookup is all
           that is genuinely wanted
          -Called on a timer on DB startup to clean it out
        * icon/IconDatabase.h:
        * icon/SiteIcon.cpp:
          -Deletes the image on deletion
          -Cut down on no-longer-necessary debug info

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
andersca [Mon, 10 Jul 2006 09:02:18 +0000 (09:02 +0000)]

2006-07-10  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Adele.

        Quirksmode: Incorrect handling of disabled BUTTON elements

        * html/HTMLButtonElement.cpp:
        Don't call prepareSubmit if the element is disabled.

        * html/HTMLInputElement.cpp:
        Don't call prepareSubmit if the element is disabled.


2006-07-09  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Adele.

        Quirksmode: Incorrect handling of disabled BUTTON elements

        * fast/forms/activate-and-disabled-elements-expected.txt: Added.
        * fast/forms/activate-and-disabled-elements.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - try to fix Windows build
darin [Mon, 10 Jul 2006 08:01:59 +0000 (08:01 +0000)]
    - try to fix Windows build

        * platform/win/TemporaryLinkStubs.cpp: Put a few functions in the WebCore namespace.
        * platform/gdk/TemporaryLinkStubs.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Geoff.
darin [Mon, 10 Jul 2006 07:59:10 +0000 (07:59 +0000)]
    Reviewed by Geoff.

        - fix failures seen in layout tests

        * bindings/js/kjs_dom.cpp: (KJS::toJS): Restore one of the few WebCore:: prefixes
        that really needed to be there -- because we have two classes named JSHTMLDocument
        at the moment! (One in KJS and one in WebCore namespace.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - try to fix Windows build
darin [Mon, 10 Jul 2006 07:40:05 +0000 (07:40 +0000)]
    - try to fix Windows build

        * rendering/RenderLayer.h: Correct a forward declaration of ScrollBar.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - try to fix Windows build
darin [Mon, 10 Jul 2006 07:33:44 +0000 (07:33 +0000)]
    - try to fix Windows build

        * COM/WebFrame.h: Qualify DeprecatedString and KURL with WebCore:: prefixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
adele [Mon, 10 Jul 2006 07:19:43 +0000 (07:19 +0000)]
    Reviewed by Maciej.

        Updated results for:
        <rdar://problem/4463835> Switch to use new popup menu implementation for <select>

        * editing/selection/replaced-boundaries-3-expected.txt:
        * editing/selection/select-box-expected.txt:
        * fast/block/margin-collapse/103-expected.txt:
        * fast/dom/option-properties-expected.txt:
        * fast/forms/003-expected.txt:
        * fast/forms/004-expected.txt:
        * fast/forms/HTMLOptionElement_label01-expected.txt:
        * fast/forms/HTMLOptionElement_label02-expected.txt:
        * fast/forms/HTMLOptionElement_label03-expected.txt:
        * fast/forms/HTMLOptionElement_label04-expected.txt:
        * fast/forms/HTMLOptionElement_label06-expected.txt:
        * fast/forms/HTMLOptionElement_label07-expected.txt:
        * fast/forms/form-element-geometry-expected.txt:
        * fast/forms/option-script-expected.txt:
        * fast/forms/option-strip-whitespace-expected.txt:
        * fast/forms/select-remove-option-expected.txt:
        * fast/forms/select-replace-option-expected.txt:
        * fast/forms/select-reset-expected.txt:
        * fast/invalid/014-expected.txt:
        * fast/parser/document-write-option-expected.txt:
        * fast/replaced/width100percent-expected.txt:
        * tables/mozilla/bugs/bug1188-expected.txt:
        * tables/mozilla/bugs/bug18359-expected.txt:
        * tables/mozilla/bugs/bug2479-3-expected.txt:
        * tables/mozilla/bugs/bug2479-4-expected.txt:
        * tables/mozilla/bugs/bug29326-expected.txt:
        * tables/mozilla/bugs/bug33855-expected.txt:
        * tables/mozilla/bugs/bug4382-expected.txt:
        * tables/mozilla/bugs/bug96334-expected.txt:
        * tables/mozilla/core/margins-expected.txt:
        * tables/mozilla/dom/tableDom-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
adele [Mon, 10 Jul 2006 07:19:24 +0000 (07:19 +0000)]
    Reviewed by Maciej.

        Fix for <rdar://problem/4463835> Switch to use new popup menu implementation for <select>

        * css/html4.css: Added style for new selects, and for list boxes.
        * html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::shouldUseMenuList): Removed check for appearance so new popups can be styled.

        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::setStyle): Removed padding.  This is now set by the theme.
        (WebCore::RenderMenuList::calcMinMaxWidth): Now takes minimum text size into account.
        * rendering/RenderMenuList.h: Removed baselinePosition since we're letting the theme calculate that.

        * rendering/RenderTheme.cpp: (WebCore::RenderTheme::isControlContainer): Added menuList as a ControlContainer,
        so RenderThemeMac will compute its baseline.
        * rendering/RenderTheme.h: (WebCore::RenderTheme::minimumTextSize): Added.
        * rendering/RenderThemeMac.h: Added minimumTextSize, setPopupPaddingFromControlSize, popupButtonSizes, popupButtonMargins, popupButtonPadding.
        Removed sizeOfArrowControl.
        * rendering/RenderThemeMac.mm:
        (WebCore::): Added enum for padding.
        (WebCore::RenderThemeMac::adjustRepaintRect): Now inflates rect to account for control shadow.
        (WebCore::RenderThemeMac::baselinePosition): Now calculates baseline for menulist.
        (WebCore::RenderThemeMac::popupButtonMargins): Tweaked values.
        (WebCore::RenderThemeMac::popupButtonSizes): Added.
        (WebCore::RenderThemeMac::popupButtonPadding): Added, so different padding can be set for different control sizes.
        (WebCore::RenderThemeMac::setPopupPaddingFromControlSize): Added.
        (WebCore::RenderThemeMac::paintMenuList): Now inflates rect to account for control shadow.
        (WebCore::RenderThemeMac::adjustMenuListStyle): Resets border, sets padding, sets control size.
        (WebCore::RenderThemeMac::setPopupButtonCellState): Removed unnecessary class name.
        (WebCore::RenderThemeMac::minimumTextSize): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - add back "unused code" for plain text fields, still used by <isindex>!
darin [Mon, 10 Jul 2006 06:16:42 +0000 (06:16 +0000)]
    - add back "unused code" for plain text fields, still used by <isindex>!

        * platform/TextField.h:
        * platform/mac/TextFieldMac.mm:
        * platform/mac/WebCoreTextField.h:
        * platform/mac/WebCoreTextField.mm:
        * rendering/RenderLineEdit.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - try to fix Windows build
darin [Mon, 10 Jul 2006 06:15:44 +0000 (06:15 +0000)]
    - try to fix Windows build

        * COM/WebFrame.cpp: Rename QChar to DeprecatedChar.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - fix newlines to be consistent for all files in the COM directory
darin [Mon, 10 Jul 2006 06:05:36 +0000 (06:05 +0000)]
    - fix newlines to be consistent for all files in the COM directory
          (many had mixed style) and set the EOL style to "native" on them.

        * COM/*: Set properties and changed files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Tim Hatcher.
darin [Mon, 10 Jul 2006 05:20:17 +0000 (05:20 +0000)]
    Reviewed by Tim Hatcher.

        - put more into the WebCore namespace
        - removed unused code for plain text fields

        Put more classes, class templates, enums, functions, and constants into
        the WebCore namespace, including all the headers in the platform directory.

        Removed lots of unneeded "WebCore::" qualifiers and "using" directives.

        Added some "WebCore::" qualifiers in a few places.

        Removed "uses WebCore::" in headers that we said we'd remove "when
        everything is in the WebCore namespace".

        * bindings/js/JSDOMParser.cpp:
        * bindings/js/JSHTMLElementWrapperFactory.cpp:
        * bindings/js/JSXSLTProcessor.cpp:
        * bindings/js/kjs_binding.cpp:
        * bindings/js/kjs_css.cpp:
        * bindings/js/kjs_dom.cpp:
        * bindings/js/kjs_dom.h:
        * bindings/js/kjs_events.cpp:
        * bindings/js/kjs_proxy.h:
        * bindings/js/kjs_window.h:
        * bindings/objc/DOM.mm:
        * bridge/History.h:
        * bridge/JavaAppletWidget.h:
        * bridge/mac/FormDataMac.h:
        * bridge/mac/FormDataMac.mm:
        * bridge/mac/WebCoreAXObject.mm:
        * bridge/mac/WebCoreEncodings.mm:
        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreIconDatabaseBridge.mm:
        * bridge/mac/WebCorePageState.h:
        * bridge/mac/WebCoreScriptDebugger.mm:
        * bridge/mac/WebCoreSettings.h:
        * css/CSSGrammar.y:
        * css/CSSPageRule.cpp:
        * css/CSSPageRule.h:
        * css/MediaList.cpp:
        * css/cssstyleselector.h:
        * dom/Clipboard.h:
        * dom/Document.cpp:
        * dom/Document.h:
        * dom/EventTargetNode.h:
        * dom/Node.cpp:
        * dom/Node.h:
        * dom/Position.h:
        * dom/Range.cpp:
        * dom/XMLTokenizer.cpp:
        * editing/AppendNodeCommand.h:
        * editing/ApplyStyleCommand.cpp:
        * editing/BreakBlockquoteCommand.cpp:
        * editing/BreakBlockquoteCommand.h:
        * editing/CompositeEditCommand.cpp:
        * editing/CompositeEditCommand.h:
        * editing/CreateLinkCommand.h:
        * editing/DeleteFromTextNodeCommand.h:
        * editing/DeleteSelectionCommand.h:
        * editing/FormatBlockCommand.h:
        * editing/HTMLInterchange.cpp:
        * editing/HTMLInterchange.h:
        * editing/IndentOutdentCommand.h:
        * editing/InsertIntoTextNodeCommand.h:
        * editing/InsertLineBreakCommand.h:
        * editing/InsertListCommand.h:
        * editing/InsertNodeBeforeCommand.h:
        * editing/InsertTextCommand.cpp:
        * editing/InsertTextCommand.h:
        * editing/JSEditor.cpp:
        * editing/JSEditor.h:
        * editing/JoinTextNodesCommand.h:
        * editing/MergeIdenticalElementsCommand.cpp:
        * editing/MergeIdenticalElementsCommand.h:
        * editing/ModifySelectionListLevel.h:
        * editing/MoveSelectionCommand.h:
        * editing/RebalanceWhitespaceCommand.h:
        * editing/RemoveNodeAttributeCommand.h:
        * editing/RemoveNodeCommand.h:
        * editing/RemoveNodePreservingChildrenCommand.h:
        * editing/ReplaceSelectionCommand.h:
        * editing/SetNodeAttributeCommand.h:
        * editing/SplitElementCommand.cpp:
        * editing/SplitElementCommand.h:
        * editing/SplitTextNodeCommand.cpp:
        * editing/SplitTextNodeCommand.h:
        * editing/SplitTextNodeContainingElementCommand.h:
        * editing/TypingCommand.cpp:
        * editing/TypingCommand.h:
        * editing/UnlinkCommand.h:
        * editing/VisiblePosition.cpp:
        * editing/WrapContentsInDummySpanCommand.cpp:
        * editing/WrapContentsInDummySpanCommand.h:
        * editing/markup.cpp:
        * editing/markup.h:
        * html/HTMLAnchorElement.cpp:
        * html/HTMLBodyElement.cpp:
        * html/HTMLButtonElement.h:
        * html/HTMLCollection.h:
        * html/HTMLDocument.h:
        * html/HTMLEmbedElement.cpp:
        * html/HTMLFormElement.cpp:
        * html/HTMLFormElement.h:
        * html/HTMLFrameElement.cpp:
        * html/HTMLFrameSetElement.cpp:
        * html/HTMLKeygenElement.cpp:
        * html/HTMLLabelElement.cpp:
        * html/HTMLObjectElement.cpp:
        * html/HTMLObjectElement.h:
        * html/HTMLTableElement.cpp:
        * html/HTMLTablePartElement.cpp:
        * icon/IconDatabase.h:
        * kcanvas/KCanvasPath.h:
        * kcanvas/KCanvasResources.cpp:
        * kcanvas/KCanvasResources.h:
        * kcanvas/KCanvasTreeDebug.cpp:
        * kcanvas/KCanvasTreeDebug.h:
        * kcanvas/RenderSVGContainer.cpp:
        * kcanvas/RenderSVGText.h:
        * kcanvas/device/KRenderingPaintServer.h:
        * kcanvas/device/KRenderingPaintServerGradient.h:
        * kcanvas/device/KRenderingPaintServerSolid.cpp:
        * ksvg2/misc/SVGImageLoader.cpp:
        * ksvg2/svg/SVGElement.cpp:
        * ksvg2/svg/SVGElement.h:
        * ksvg2/svg/SVGForeignObjectElement.cpp:
        * ksvg2/svg/SVGForeignObjectElement.h:
        * ksvg2/svg/SVGImageElement.cpp:
        * ksvg2/svg/SVGPoint.h:
        * ksvg2/svg/SVGStylable.h:
        * ksvg2/svg/SVGTRefElement.cpp:
        * ksvg2/svg/SVGTRefElement.h:
        * ksvg2/svg/SVGTSpanElement.cpp:
        * ksvg2/svg/SVGTSpanElement.h:
        * ksvg2/svg/SVGTextElement.h:
        * ksvg2/svg/svgpathparser.cpp:
        * ksvg2/svg/svgpathparser.h:
        * loader/Cache.h:
        * loader/DocLoader.h:
        * loader/LoaderFunctions.h:
        * loader/mac/LoaderFunctionsMac.mm:
        * page/Frame.h:
        * page/FrameView.h:
        * page/Page.h:
        * page/Settings.h:
        * platform/AffineTransform.cpp:
        * platform/AffineTransform.h:
        * platform/Arena.cpp:
        * platform/Arena.h:
        * platform/CookieJar.h:
        * platform/DeprecatedCString.cpp:
        * platform/DeprecatedCString.h:
        * platform/DeprecatedPtrList.h:
        * platform/DeprecatedPtrListImpl.cpp:
        * platform/DeprecatedPtrListImpl.h:
        * platform/DeprecatedPtrQueue.h:
        * platform/DeprecatedString.cpp:
        * platform/DeprecatedString.h:
        * platform/DeprecatedStringList.cpp:
        * platform/DeprecatedStringList.h:
        * platform/DeprecatedValueList.h:
        * platform/DeprecatedValueListImpl.cpp:
        * platform/DeprecatedValueListImpl.h:
        * platform/FileButton.h:
        * platform/FloatPoint.h:
        * platform/FloatRect.h:
        * platform/FloatSize.h:
        * platform/FontData.h:
        * platform/FontFallbackList.h:
        * platform/GraphicsContext.h:
        * platform/IntPoint.h:
        * platform/IntRect.h:
        * platform/IntSize.h:
        * platform/KURL.cpp:
        * platform/KURL.h:
        * platform/ListBox.h:
        * platform/Logging.cpp:
        * platform/Logging.h:
        * platform/Pen.h:
        * platform/PopUpButton.h:
        * platform/RegularExpression.cpp:
        * platform/RegularExpression.h:
        * platform/SSLKeyGenerator.h:
        * platform/ScrollBar.h:
        * platform/SegmentedString.h:
        * platform/Shared.h:
        * platform/Slider.h:
        * platform/StringImpl.h:
        * platform/TextBox.h:
        * platform/TextField.h:
        * platform/TextStream.cpp:
        * platform/TextStream.h:
        * platform/TransferJob.h:
        * platform/TransferJobClient.h:
        * platform/Widget.h:
        * platform/cg/AffineTransformCG.cpp:
        * platform/mac/ClipboardMac.h:
        * platform/mac/ClipboardMac.mm:
        * platform/mac/DeprecatedStringListMac.mm:
        * platform/mac/FontCacheMac.mm:
        * platform/mac/KURLMac.mm:
        * platform/mac/ListBoxMac.mm:
        * platform/mac/PopUpButtonMac.mm:
        * platform/mac/SSLKeyGeneratorMac.mm:
        * platform/mac/TextBoxMac.mm:
        * platform/mac/TextFieldMac.mm:
        * platform/mac/WebCoreTextArea.h:
        * platform/mac/WebCoreTextArea.mm:
        * platform/mac/WebCoreTextField.h:
        * platform/mac/WebCoreTextField.mm:
        * rendering/DeprecatedRenderSelect.h:
        * rendering/RenderArena.cpp:
        * rendering/RenderArena.h:
        * rendering/RenderBlock.cpp:
        * rendering/RenderBox.cpp:
        * rendering/RenderContainer.cpp:
        * rendering/RenderFlexibleBox.cpp:
        * rendering/RenderFlow.cpp:
        * rendering/RenderLayer.cpp:
        * rendering/RenderLineEdit.cpp:
        * rendering/RenderObject.h:
        * rendering/RenderStyle.cpp:
        * rendering/RenderStyle.h:
        * rendering/RenderText.cpp:
        * rendering/RenderTextFragment.cpp:
        * rendering/RenderTheme.h:
        * rendering/RenderTreeAsText.cpp:
        * rendering/RenderTreeAsText.h:
        * rendering/RenderView.h:
        * rendering/bidi.h:
        * xml/XSLStyleSheet.cpp:
        * xml/XSLTProcessor.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
ggaren [Mon, 10 Jul 2006 05:18:50 +0000 (05:18 +0000)]

        Reviewed by Beth.

        Now that we garbage collect after reinitalizing the global object, not
        before, we have more free memory, so a custom property that used to
        get collected during the initialization phase of this test now avoids
        getting collected until the collection phase.

        * fast/dom/gc-9-expected.txt:
        * fast/dom/gc-9.html:


        Reviewed by Beth.

        * bindings/js/kjs_window.cpp:
        (KJS::Window::clear): Garbage collect after reinitalizing the global
        object, not before, since the reinitialization tends to create garbage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebKitTools:
ddkilzer [Mon, 10 Jul 2006 04:45:17 +0000 (04:45 +0000)]

        Build fix. Reviewed by NOBODY.

        - Backed out http://bugzilla.opendarwin.org/show_bug.cgi?id=7802
          devenv.com not available in VC++ Express installations

        * Scripts/webkitdirs.pm: Backed out previous change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoAdding 2006 to the copyright years for headers I changed earlier.
thatcher [Mon, 10 Jul 2006 04:25:11 +0000 (04:25 +0000)]
Adding 2006 to the copyright years for headers I changed earlier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFIx the copyright dates to include all years published.
thatcher [Mon, 10 Jul 2006 04:18:28 +0000 (04:18 +0000)]
FIx the copyright dates to include all years published.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBuild fix for DumpRenderTree and other clients that don't use AppKit. Update the...
thatcher [Mon, 10 Jul 2006 04:05:58 +0000 (04:05 +0000)]
Build fix for DumpRenderTree and other clients that don't use AppKit. Update the copyright date on headers I changed earlier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
ddkilzer [Mon, 10 Jul 2006 04:00:38 +0000 (04:00 +0000)]

        Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=9812
          LayoutTests/svg/custom/foreign-object-skew.svg seems to be fixed

        * svg/custom/foreign-object-skew-expected.checksum: Updated.
        * svg/custom/foreign-object-skew-expected.png: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebKitTools:
ddkilzer [Mon, 10 Jul 2006 03:46:07 +0000 (03:46 +0000)]

        Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=9693
          svn-apply should set ChangeLog date correctly when applying patches

        * Scripts/svn-apply: Set the ChangeLog entry date using a configurable timezone
        before applying the patch.
        * Scripts/svn-unapply: Reset the ChangeLog entry date before unapplying the patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
tomernic [Mon, 10 Jul 2006 03:26:32 +0000 (03:26 +0000)]
    Reviewed by Maciej.

        <rdar://problem/4404652> Netscape plug-in mouse events broken in HiDPI

        Multiply global mouse coordinates by the window scale factor so that plug-ins can use GlobalToLocal() in HiDPI.
        This fixes many bugs involving plug-in mouse event handling in HiDPI.  Most notably, the Flash player will now
        correctly respond to clicks.

        * Plugins/WebBaseNetscapePluginView.m:
        (+[WebBaseNetscapePluginView getCarbonEvent:]):
        (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Tim Hatcher.
darin [Mon, 10 Jul 2006 03:13:34 +0000 (03:13 +0000)]
    Reviewed by Tim Hatcher.

        - fix assertion firing in plug-in layout tests

        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView restartNullEvents]):
        Don't start null events if the plug-in is not in the
        started state. This happens when the plug-in moves within
        its view hierarchy after it has been stopped.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
thatcher [Mon, 10 Jul 2006 03:02:04 +0000 (03:02 +0000)]

        Reviewed by Darin.

        Bug 9820: Move new DOM API that has been through API review to public headers

        * bindings/objc/DOM.mm:
        (-[DOMElement focus]):
        (-[DOMElement blur]):
        (-[DOMRange text]):
        (-[DOMRange _text]):
        * bindings/objc/DOMCSS.mm:
        (-[DOMRGBColor color]):
        (-[DOMRGBColor _color]):
        * bindings/objc/DOMCore.h:
        * bindings/objc/DOMEvents.h:
        * bindings/objc/DOMExtensions.h:
        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLElement titleDisplayString]):
        (-[DOMHTMLDocument createDocumentFragmentWithMarkupString:baseURL:]):
        (-[DOMHTMLDocument createDocumentFragmentWithText:]):
        (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
        (-[DOMHTMLDocument _createDocumentFragmentWithText:]):
        * bindings/objc/DOMPrivate.h:
        * bindings/objc/DOMXPath.h:
        * bindings/objc/DOMXPath.mm:


        Reviewed by Darin.

        Bug 9820: Move new DOM API that has been through API review to public headers

        * Misc/WebElementDictionary.m: include DOMExtensions.h
        * Misc/WebNSViewExtras.m: include DOMExtensions.h
        * WebKit.xcodeproj/project.pbxproj: make DOMXPath.h public

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Kevin.
thatcher [Mon, 10 Jul 2006 02:49:53 +0000 (02:49 +0000)]
    Reviewed by Kevin.

        Bug 9818: move new UIDelegate API that has been through API review to public headers

        <rdar://problem/4387541> API: Remove webView:setContentRect: & webViewContentRect: delegate methods?
        The fix for 4310363 removed the only use of webViewContentRect: in our code. webView:setContentRect:
        was never used to begin with. There's no harm in leaving these around in the API, but they'll cruft it up.

        Also removes the never used webViewPrint: SPI that was replaced by webView:printFrameView:.

        * DefaultDelegates/WebDefaultUIDelegate.m:
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge print]):
        * WebView/WebFrameView.h:
        * WebView/WebFrameView.m:
        * WebView/WebFrameViewPrivate.h:
        * WebView/WebUIDelegate.h:
        * WebView/WebUIDelegatePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago * fast/dom/delete-contents-expected.txt: Updated results that changed
darin [Mon, 10 Jul 2006 02:43:56 +0000 (02:43 +0000)]
    * fast/dom/delete-contents-expected.txt: Updated results that changed
        because we now keep comment nodes in the DOM.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
bdakin [Mon, 10 Jul 2006 02:31:52 +0000 (02:31 +0000)]
    Reviewed by Maciej.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9749 A
        nested content editable div causes unnecessary screen redraws.

        We were repainting too much because we were deciding that we needed
        a full layout because we didn't have a first line box. Our code
        used to hold a lot of assumptions that positioned elements would
        always have line boxes, but I fixed a few bugs a while back that
        appeared because this assumption isn't true. This assumption was
        also causing the extra redraws because the check meant that we
        would decide to do a full layout for any positioned element that
        did not have any line boxes in the first place. Maciej and I talked
        about this, and we couldn't figure out why the check for line boxes
        was part of determining if we need a full layout in the first
        place. After hunting around the code, we decided to assume that
        this check is antiquated. Removing it fixes the bug and doesn't
        seem to break any layout tests. So, fingers crossed!

        Will add layout test so soon.

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren): Remove firstLineBox

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
thatcher [Mon, 10 Jul 2006 00:57:30 +0000 (00:57 +0000)]
    Reviewed by Darin.

        Bug 9814: Move new WebView API that has been through API review to public headers

        * WebView/WebView.h:
        * WebView/WebView.m:
        (-[WebView close]):
        (-[WebView setShouldCloseWithWindow:]):
        (-[WebView shouldCloseWithWindow]):
        (-[WebView selectedFrame]):
        (-[WebView setMainFrameURL:]):
        (-[WebView mainFrameURL]):
        (-[WebView isLoading]):
        (-[WebView mainFrameTitle]):
        (-[WebView mainFrameIcon]):
        (-[WebView mainFrameDocument]):
        (-[WebView setDrawsBackground:]):
        (-[WebView drawsBackground]):
        (-[WebView toggleSmartInsertDelete:]):
        (-[WebView toggleContinuousSpellChecking:]):
        (-[WebView canMakeTextStandardSize]):
        (-[WebView makeTextStandardSize:]):
        (-[WebView maintainsInactiveSelection]):
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
thatcher [Mon, 10 Jul 2006 00:11:13 +0000 (00:11 +0000)]
    Reviewed by Maciej.

        Bug 9487: The XPath section should be removed and/or moved.

        * WebInspector/webInspector/inspector.css:
        * WebInspector/webInspector/inspector.html:
        * WebInspector/webInspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
harrison [Sun, 9 Jul 2006 23:18:39 +0000 (23:18 +0000)]

        Reviewed by John Sullivan.

        <rdar://problem/4598149> Deleting the contents of a DOMRange and then inserting a node into it crashes in WebCore::Font::canUseGlyphCache

        * fast/dom/delete-contents-expected.checksum: Added.
        * fast/dom/delete-contents-expected.png: Added.
        * fast/dom/delete-contents-expected.txt: Added.
        * fast/dom/delete-contents.html: Added.


        Reviewed by John Sullivan.

        <rdar://problem/4598149> Deleting the contents of a DOMRange and then inserting a node into it crashes in WebCore::Font::canUseGlyphCache

        Test: fast/dom/delete-contents.html

        * dom/Range.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - another round of renaming; and KWQ is dead
darin [Sun, 9 Jul 2006 22:48:56 +0000 (22:48 +0000)]
    - another round of renaming; and KWQ is dead

        * WebCore.vcproj/WebCore/WebCore.vcproj: Remove paths for kwq and khtml directories.
        Move files to their new locations. Did rename.
        * WebCore.xcodeproj/project.pbxproj: Move files to their new locations. Did rename.
        * WebCoreSources.bkl: Did rename.
        * webcore-base.bkl: Removed kwq.

        * kwq/AccessibilityObjectCache.h: Removed.
        * kwq/AccessibilityObjectCache.mm: Removed.
        * kwq/FormDataMac.h: Removed.
        * kwq/FormDataMac.mm: Removed.
        * kwq/WebCoreAXObject.h: Removed.
        * kwq/WebCoreAXObject.mm: Removed.
        * kwq/WebCoreEditCommand.h: Removed.
        * kwq/WebCoreEditCommand.mm: Removed.
        * kwq/WebCorePageState.h: Removed.
        * kwq/WebCorePageState.mm: Removed.
        * kwq/WebCoreResourceLoaderImp.h: Removed.
        * kwq/WebCoreResourceLoaderImp.mm: Removed.

        * bridge/AXObjectCache.h: Added.
        * bridge/mac/AXObjectCacheMac.mm: Added.
        * bridge/mac/WebCoreAXObject.h: Added.
        * bridge/mac/WebCoreAXObject.mm: Added.

        * loader/CachedObject.cpp: Removed.
        * loader/CachedObject.h: Removed.
        * loader/CachedObjectClient.h: Removed.
        * loader/CachedObjectClientWalker.cpp: Removed.
        * loader/CachedObjectClientWalker.h: Removed.

        * loader/CachedResource.cpp: Added.
        * loader/CachedResource.h: Added.
        * loader/CachedResourceClient.h: Added.
        * loader/CachedResourceClientWalker.cpp: Added.
        * loader/CachedResourceClientWalker.h: Added.

        * bridge/mac/FrameMac.mm:
        * bridge/mac/WebCoreFrameBridge.mm:
        * css/CSSImageValue.h:
        * css/CSSImportRule.h:
        * dom/Document.cpp:
        * dom/Document.h:
        * dom/Notation.h:
        * dom/ProcessingInstruction.h:
        * dom/XMLTokenizer.cpp:
        * html/CanvasPattern.h:
        * html/HTMLDocument.h:
        * html/HTMLImageLoader.cpp:
        * html/HTMLImageLoader.h:
        * html/HTMLLinkElement.h:
        * html/HTMLScriptElement.cpp:
        * html/HTMLScriptElement.h:
        * html/HTMLTokenizer.cpp:
        * html/HTMLTokenizer.h:
        * kcanvas/KCanvasFilters.h:
        * ksvg2/svg/SVGCursorElement.cpp:
        * ksvg2/svg/SVGCursorElement.h:
        * ksvg2/svg/SVGFEImageElement.cpp:
        * ksvg2/svg/SVGFEImageElement.h:
        * loader/Cache.cpp:
        * loader/Cache.h:
        * loader/CachedCSSStyleSheet.cpp:
        * loader/CachedCSSStyleSheet.h:
        * loader/CachedImage.cpp:
        * loader/CachedImage.h:
        * loader/CachedScript.cpp:
        * loader/CachedScript.h:
        * loader/CachedXBLDocument.cpp:
        * loader/CachedXBLDocument.h:
        * loader/CachedXSLStyleSheet.cpp:
        * loader/CachedXSLStyleSheet.h:
        * loader/DocLoader.cpp:
        * loader/DocLoader.h:
        * loader/LoaderFunctions.h:
        * loader/Request.cpp:
        * loader/Request.h:
        * loader/loader.cpp:
        * loader/loader.h:
        * loader/mac/LoaderFunctionsMac.mm:
        * page/Frame.cpp:
        * page/FrameView.cpp:
        * platform/gdk/TemporaryLinkStubs.cpp:
        * platform/mac/ClipboardMac.h:
        * platform/win/TemporaryLinkStubs.cpp:
        * rendering/RenderBox.h:
        * rendering/RenderContainer.cpp:
        * rendering/RenderImage.cpp:
        * rendering/RenderImage.h:
        * rendering/RenderLayer.h:
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:
        * rendering/RenderStyle.cpp:
        * rendering/RenderStyle.h:
        * xml/XSLImportRule.h:
        Did renaming.

        * platform/mac/can-convert.mm: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago * Scripts/do-webcore-rename: Final version of this round of renaming for...
darin [Sun, 9 Jul 2006 22:39:40 +0000 (22:39 +0000)]
    * Scripts/do-webcore-rename: Final version of this round of renaming for posterity.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoRemove conflict marker.
ddkilzer [Sun, 9 Jul 2006 22:35:07 +0000 (22:35 +0000)]
Remove conflict marker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoRemove conflict marker. Thanks Mitz!
andersca [Sun, 9 Jul 2006 21:42:10 +0000 (21:42 +0000)]
Remove conflict marker. Thanks Mitz!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
andersca [Sun, 9 Jul 2006 21:39:37 +0000 (21:39 +0000)]

2006-07-09  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Tim O.

        * WebCore.exp:
        Add wkPathFromFont.

        * platform/mac/FontDataMac.mm:
        (-[NSFont WebCore]):
        Use wkPathFromFont.

        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:
        Declare wkPathFromFont.


2006-07-09  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Tim O.

        * WebCoreSupport/WebSystemInterface.m:
        Initialize wkPathFromFont.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-07-09 Anders Carlsson <acarlsson@apple.com>
andersca [Sun, 9 Jul 2006 21:31:24 +0000 (21:31 +0000)]
2006-07-09  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Darin.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterface.a:
        Add WKPathFromFont.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - fix release build
darin [Sun, 9 Jul 2006 21:11:04 +0000 (21:11 +0000)]
    - fix release build

        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView restorePortState:]): Cast inside the assertion so
        that we don't have an unused variable in versions with assertions disabled.
        The alternative would be to wrap the whole thing in an #if statement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
tomernic [Sun, 9 Jul 2006 20:37:05 +0000 (20:37 +0000)]

        Reviewed by Maciej.

        Added an OpenGL drawing model to the Netscape Plug-in API.

        * bindings/npapi.h:


        Reviewed by John Sullivan.

        * Plugins/WebBaseNetscapePluginView.h:
        - Added ivars for OpenGL support.  Someday it would be nice to refactor this class so
          that each drawing model is encapsulated in a class; this would allow
          WebBaseNetscapePluginView to make more efficient use of space, for example by not
          keeping OpenGL-related ivars for Quickdraw plug-ins.

        * Plugins/WebBaseNetscapePluginView.m:
        - Declared a bunch of internal methods for OpenGL support (see below).
        - Removed "forUpdate" from CoreGraphics port state struct; it was always set to "YES",
          so I just cleaned up the silly code that used it.
        - Declared OpenGL port state struct.
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
        - Moved a CoreGraphics-related assertion down to the big "switch" statement.
        - Don't set window.type here -- according to the Netscape Plug-in API docs, the plug-in
          should default to "windowed" mode, and may call NPN_SetValue() during its NPN_New() to
          request that the browser use a "windowless" (offscreen) context instead.
        - Moved the assertion from the top of this method here; removed a less restrictive
          assertion that is now obsolete.
        - Removed "forUpdate" flag from CoreGraphics port state struct.
        - Fill in OpenGL port state struct.  Set up the viewport appropriately for both windowed
          and windowless OpenGL plug-ins.  Windowed plug-ins need to have their GL viewport
          transformed by the amount the plug-in is clipped; windowless plug-ins are drawn off-screen
          into a surface whose geometry is never changed or clipped, so they may always draw with
          a viewport origin of (0, 0).
        (-[WebBaseNetscapePluginView restorePortState:]):
        - Removed "forUpdate" flag from CoreGraphics port state struct.
        - Restore the old OpenGL context saved by -saveAndSetNewPortStateForUpdate:.
        (-[WebBaseNetscapePluginView sendEvent:]):
        - Updated an assertion to also include OpenGL.  To ensure that attached plug-in window movements
          happen atomically with web page redisplays, we assert that the plug-in's window is set only while
          the plug-in view is redrawing.
        - Same deal as with the assertion; only save/set port state when redrawing the plug-in view.  Plug-ins
          that use the new drawing models are only allowed to draw when the web page draws.  I might consider
          changing this for windowed OpenGL plug-ins, since they always obscure the page content anyway.
        (-[WebBaseNetscapePluginView isNewWindowEqualToOldWindow]):
        - Compare new NP_GLContext structs.
        (-[WebBaseNetscapePluginView updateAndSetWindow]):
        - In OpenGL mode, can only set window when updating plug-in view.
        (-[WebBaseNetscapePluginView setWindowIfNecessary]):
        - ditto
        - Updated logging for OpenGL drawing mode.
        (-[WebBaseNetscapePluginView addWindowObservers]):
        - No need to observe frame/bounds change notifications for this and all parent views.  See -renewGState
          comments below.
        (-[WebBaseNetscapePluginView removeWindowObservers]):
        - Don't need to remove frame/bounds observers anymore.
        (-[WebBaseNetscapePluginView start]):
        - Plug-ins are "windowed" by default.  This is not a change from our previous behavior, but this is a
          better place to set the default value as it allows the plug-in to override it later.
        (-[WebBaseNetscapePluginView stop]):
        - Destroy AGL context when the plug-in stops.
        (-[WebBaseNetscapePluginView dealloc]):
        - Assert that the AGL stuff has been cleaned up.
        (-[WebBaseNetscapePluginView drawRect:]):
        - If this is a windowless OpenGL plugin, blit its contents back into this view.
        (-[WebBaseNetscapePluginView renewGState]):
        - This method is called when the view or one of its parents is moved or resized (see comments).
        (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
        - Hide the AGL window if the plug-in view is about to be removed from its window.
        (-[WebBaseNetscapePluginView viewHasMoved:]):
        - Renamed and moved to the "Internal" category.
        (-[WebBaseNetscapePluginView invalidateRegion:]):
        - Style changes.
        - Add support for OpenGL (uses the same region type as CoreGraphics).
        (-[WebBaseNetscapePluginView getVariable:value:]):
        - Style changes.
        - Implemented NPNVsupportsOpenGLBool; returns YES since we now support the OpenGL drawing model.
        (-[WebBaseNetscapePluginView setVariable:value:]):
        - Implemented NPPVpluginWindowBool, which allows plug-ins to specify whether they should be rendered in
          "windowed" or "windowless" mode.  This is an older part of the Netscape Plug-in API that was never
          implemented in WebKit.  "Windowed" Quickdraw plug-ins do not actually reside in a separate window, and
          can already do many of the same things (such as transparency) that only "windowless" plug-ins can do on
          other platforms.  However, we need the "windowed" vs. "windowless" distinction for OpenGL plug-ins so
          that they have some way of specifying whether they should be rendered on an accelerated overlay surface,
          composited into the browser window.
        - Support for setting the drawing model to OpenGL.
        (-[WebBaseNetscapePluginView _viewHasMoved]):
        - Renamed from -viewHasMoved:, and moved down in the file.
        - None of this work is necessary when the plug-in is not in a window; the plug-in's state will be properly
          restored when it is moved back into a window.
        - Reshape OpenGL surface window here.
        (-[WebBaseNetscapePluginView _createAGLContextIfNeeded]):
        - Creates the AGL context of the appropriate type (windowed/windowless).
        (-[WebBaseNetscapePluginView _createWindowedAGLContext]):
        - Creates a windowed AGL context, which is an AGL context attached to a child window.  This is the only way
          to get true hardware acceleration.
        (-[WebBaseNetscapePluginView _createWindowlessAGLContext]):
        - Creates a windowless AGL context, which is an AGL context attached to an offscreen buffer.  This buffer can
          then be blitted back into the browser window with a different alpha, or scaled, or whatever.
        (-[WebBaseNetscapePluginView _cglContext]):
        - Returns the underlying CGL context from the AGL context.  We give the plug-in access to the CGL context because
          CGL is the more primitive of the GL drawable APIs and allows for finer control over the context.
        (-[WebBaseNetscapePluginView _getAGLOffscreenBuffer:width:height:]):
        - Returns the buffer allocated for the offscreen AGL context, if there is one.
        (-[WebBaseNetscapePluginView _destroyAGLContext]):
        - Destroys the AGL context, as well as the associated offscreen buffer or child window.
        (-[WebBaseNetscapePluginView _reshapeAGLWindow]):
        - Positions the AGL window over the browser window.
        (-[WebBaseNetscapePluginView _hideAGLWindow]):
        - Hides the AGL window.
        (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
        - Returns an NSImage representation of the offscreen AGL context's framebuffer.  This is used to draw the offscreen
          bits back into the plug-in view.  This is kind of tricky because it has to convert the offscreen buffer in-place
          from BGRA to RGBA so that it can be wrapped in an NSBitmapImageRep.  See comments.

        * WebKit.xcodeproj/project.pbxproj:
        Link OpenGL and AGL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFixed a nearly unparsable ChangeLog entry
beidson [Sun, 9 Jul 2006 18:10:35 +0000 (18:10 +0000)]
Fixed a nearly unparsable ChangeLog entry

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej
beidson [Sun, 9 Jul 2006 17:52:52 +0000 (17:52 +0000)]
    Reviewed by Maciej

        Set the stage to remove the workaround for the SQLite BLOB corruption.  A few other small cleanups, and
        preparation for pruning unreferenced and unretained icons.

        * icon/IconDatabase.cpp:
        (WebCore::IconDatabase::recreateDatabase):  Added another trigger to assist in icon removal
        (WebCore::IconDatabase::deletePrivateTables):  Cleaned up logging messages
        (WebCore::IconDatabase::imageDataForIconID):  #ifdefed the blobbing hack for impending removal, use the real blob by default
        (WebCore::IconDatabase::imageDataForIconURL):  same
        (WebCore::IconDatabase::imageDataForPageURL):  same
        (WebCore::IconDatabase::pruneUnreferencedIcons):  Will delete any icons and their data that are not referenced
          by any PageURL
        * icon/IconDatabase.h:

        * icon/SQLDatabase.h:  Changed BlobAsVector to be unsigned char as thats the most reasonable type for
          a byte-buffer, and is what CFData expects
        * icon/SQLStatement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej
beidson [Sun, 9 Jul 2006 17:38:04 +0000 (17:38 +0000)]
    Reviewed by Maciej

        The ICONDEBUG flag no choose either/or the new icon database and the old one
        No longer any need to live side by side to compare results

        * Misc/WebIconDatabase.m:
        (-[NSMutableDictionary iconURLForURL:]):
        (-[NSMutableDictionary retainIconForURL:]):
        (-[NSMutableDictionary releaseIconForURL:]):
        (-[WebIconDatabase _setHaveNoIconForIconURL:]):
        (-[WebIconDatabase _setIconURL:forURL:]):
        (-[WebIconDatabase _resetCachedWebPreferences:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - move all but the last 12 files out of kwq directory
darin [Sun, 9 Jul 2006 17:03:15 +0000 (17:03 +0000)]
    - move all but the last 12 files out of kwq directory
        - removed a few unused source files I discovered

        * WebCore.vcproj/WebCore/WebCore.vcproj: Update for new file locations.
        * WebCore.xcodeproj/project.pbxproj: Ditto.

        * bridge/mac/FrameMac.mm:
        * dom/Element.h:
        * html/HTMLImageLoader.cpp:
        * loader/Cache.cpp:
        * loader/Cache.h:
        * loader/CachedCSSStyleSheet.cpp:
        * loader/CachedCSSStyleSheet.h:
        * loader/CachedImage.cpp:
        * loader/CachedImage.h:
        * loader/CachedObject.h:
        * loader/CachedScript.cpp:
        * loader/CachedScript.h:
        * loader/CachedXBLDocument.cpp:
        * loader/CachedXBLDocument.h:
        * loader/CachedXSLStyleSheet.cpp:
        * loader/CachedXSLStyleSheet.h:
        * loader/DocLoader.cpp:
        * loader/DocLoader.h:
        * page/Frame.cpp:
        * page/Frame.h:
        * page/FramePrivate.h:
        * platform/gdk/TemporaryLinkStubs.cpp:
        * platform/win/TemporaryLinkStubs.cpp:
        * rendering/DeprecatedSlider.cpp:
        * rendering/RenderObject.h:
        * xml/xmlhttprequest.cpp:
        Updated includes as needed for file location changes. Changed
        CachePolicy uses to match new filename and enum names.

        * loader/CachedResource.cpp: Removed.
        * loader/CachedResource.h: Removed.
        * loader/CachedResourceClient.h: Removed.
        * loader/CachedResourceClientWalker.cpp: Removed.
        * loader/CachedResourceClientWalker.h: Removed.
        The above files were checked in by accident a while back. The rename of
        CachedObject to CachedResource is now reflected in do-webcore-rename,
        and will be done soon.

        * kwq/AffineTransform.cpp: Removed.
        * kwq/AffineTransform.h: Removed.
        * kwq/CacheControl.h: Removed.
        * kwq/DeprecatedPtrQueue.h: Removed.
        * kwq/FileButton.h: Removed.
        * kwq/FileButton.mm: Removed.
        * kwq/ListBox.h: Removed.
        * kwq/ListBox.mm: Removed.
        * kwq/LoaderFunctions.h: Removed.
        * kwq/LoaderFunctions.mm: Removed.
        * kwq/PopUpButton.h: Removed.
        * kwq/PopUpButton.mm: Removed.
        * kwq/SSLKeyGenerator.h: Removed.
        * kwq/SSLKeyGenerator.mm: Removed.
        * kwq/Settings.h: Removed.
        * kwq/TextBox.h: Removed.
        * kwq/TextBox.mm: Removed.
        * kwq/TextField.h: Removed.
        * kwq/TextField.mm: Removed.
        * kwq/WebCoreScrollBar.h: Removed.
        * kwq/WebCoreScrollBar.mm: Removed.
        * kwq/WebCoreSlider.h: Removed.
        * kwq/WebCoreSlider.mm: Removed.

        * loader/CachePolicy.h: Added.
        * loader/LoaderFunctions.h: Added.

        * loader/mac/LoaderFunctionsMac.mm: Added.

        * page/Settings.h: Added.

        * platform/AffineTransform.cpp: Added.
        * platform/AffineTransform.h: Added.
        * platform/DeprecatedPtrQueue.h: Added.
        * platform/FileButton.h: Added.
        * platform/ListBox.h: Added.
        * platform/PopUpButton.h: Added.
        * platform/SSLKeyGenerator.h: Added.
        * platform/ScrollBar.h: Added.
        * platform/Slider.h: Added.
        * platform/TextBox.h: Added.
        * platform/TextField.h: Added.

        * platform/cg/AffineTransformCG.cpp: Added.

        * platform/mac/FileButtonMac.mm: Added.
        * platform/mac/ListBoxMac.mm: Added.
        * platform/mac/PopUpButtonMac.mm: Added.
        * platform/mac/SSLKeyGeneratorMac.mm: Added.
        * platform/mac/ScrollBarMac.mm: Added.
        * platform/mac/ScrollBarMac.mm: Added.
        * platform/mac/SliderMac.mm: Added.
        * platform/mac/SliderMac.mm: Added.
        * platform/mac/TextBoxMac.mm: Added.
        * platform/mac/TextFieldMac.mm: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago * Scripts/do-webcore-rename: Next round of renaming. (Last round was done.)
darin [Sun, 9 Jul 2006 16:36:21 +0000 (16:36 +0000)]
    * Scripts/do-webcore-rename: Next round of renaming. (Last round was done.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
ddkilzer [Sun, 9 Jul 2006 15:53:22 +0000 (15:53 +0000)]

        Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=9797
          Make description() in fast/js/resources/js-test-pre.js work with MSIE 6

        * fast/js/resources/js-test-pre.js: Change description() to work with MSIE 6.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15256 268f45cc-cd09-0410-ab3c-d52691b4dbfc