mitz@apple.com [Tue, 27 Oct 2009 16:49:09 +0000 (16:49 +0000)]
JavaScriptGlue: Updated license
Reviewed by Darin Adler.
* LICENSE:
WebCore: Updated Apple license
Reviewed by Darin Adler.
* LICENSE-APPLE:
WebKit: Updated license
Reviewed by Darin Adler.
* LICENSE:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50154
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Tue, 27 Oct 2009 16:43:39 +0000 (16:43 +0000)]
Rubberstamped by Sam Weinig.
Re-enable the check that disallows pages with unload handlers in the page cache.
<rdar://problem/
7196485> and http://webkit.org/b/29021
WebCore:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::canCachePageContainingThisFrame):
(WebCore::FrameLoader::logCanCacheFrameDecision):
LayoutTests:
* platform/mac/Skipped:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50153
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Tue, 27 Oct 2009 16:30:10 +0000 (16:30 +0000)]
Remove more empty files that didn't get removed earlier.
* inspector/DOMDispatchTimelineItem.cpp: Removed.
* inspector/DOMDispatchTimelineItem.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50152
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 27 Oct 2009 15:34:22 +0000 (15:34 +0000)]
[Qt] Fix assertion crashes introduced by changes made in r50110.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-27
Reviewed by Tor Arne Vestbø.
* dom/XMLTokenizerQt.cpp:
(WebCore::XMLTokenizer::parseEndElement): only call popCurrentNode() if there are nodes left in the stack.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50151
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Tue, 27 Oct 2009 15:27:21 +0000 (15:27 +0000)]
Remove empty files that didn't get removed earlier.
* inspector/TimelineItem.cpp: Removed.
* inspector/TimelineItem.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50150
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Tue, 27 Oct 2009 14:44:51 +0000 (14:44 +0000)]
Unreviewed Qt build fix.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-27
Update the tests as well to the new API change.
* tests/qwebelement/tst_qwebelement.cpp:
(tst_QWebElement::clear):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50149
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Tue, 27 Oct 2009 14:28:11 +0000 (14:28 +0000)]
2009-10-27 Xan Lopez <xlopez@igalia.com>
Another typo.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50148
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Tue, 27 Oct 2009 14:22:43 +0000 (14:22 +0000)]
Rubberstamped by Tor Arne Vestbø.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-27
[Qt] QWebElement::removeChildren() should be
QWebElement::removeAllChildren()
https://bugs.webkit.org/show_bug.cgi?id=30630
* Api/qwebelement.cpp:
(QWebElement::removeAllChildren):
* Api/qwebelement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50147
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Tue, 27 Oct 2009 14:18:16 +0000 (14:18 +0000)]
2009-10-27 Xan Lopez <xlopez@igalia.com>
Fix typo in test names.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50146
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Tue, 27 Oct 2009 14:02:17 +0000 (14:02 +0000)]
2009-10-27 Xan Lopez <xlopez@igalia.com>
Skip a few tests with links to their tracking bugs.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50145
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Tue, 27 Oct 2009 13:57:31 +0000 (13:57 +0000)]
This reverts commit r50141 that wrongly messed up the WebCore/ChangeLog
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50144
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 27 Oct 2009 13:51:42 +0000 (13:51 +0000)]
Rubber-stamped by Tor Arne Vestbø.
Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2009-10-27
Fix typo in RegexInterpreter.cpp and RegexJIT.cpp alterantive to
alternative.
* yarr/RegexInterpreter.cpp:
(JSC::Yarr::ByteCompiler::alternativeBodyDisjunction):
(JSC::Yarr::ByteCompiler::alternativeDisjunction):
(JSC::Yarr::ByteCompiler::emitDisjunction):
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::generateDisjunction):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50143
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Tue, 27 Oct 2009 13:38:30 +0000 (13:38 +0000)]
Make QWebPagePrivate's (QWidget) view to be a QWeakPointer.
https://bugs.webkit.org/show_bug.cgi?id=30779
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-27
Reviewed by Antti Koivisto and Holger Freyther.
The fact that it was been set from external objects of qwebpage
and not being deleted internally can lead to dangling references.
* Api/qgraphicswebview.cpp:
(QGraphicsWebView::~QGraphicsWebView):
* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::createContextMenu):
(QWebPagePrivate::handleSoftwareInputPanel):
(QWebPagePrivate::keyPressEvent):
(QWebPage::setView):
(QWebPage::view):
(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):
(QWebPage::shouldInterruptJavaScript):
(QWebPage::createWindow):
(QWebPage::extension):
(QWebPage::chooseFile):
(QWebPage::userAgentForUrl):
* Api/qwebpage_p.h:
* Api/qwebview.cpp:
(QWebView::~QWebView):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50142
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Tue, 27 Oct 2009 13:37:46 +0000 (13:37 +0000)]
2009-10-20 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: populate child nodes before sorting them.
https://bugs.webkit.org/show_bug.cgi?id=29673
* inspector/front-end/BottomUpProfileDataGridTree.js:
(WebInspector.BottomUpProfileDataGridNode): Swapped with BottomUpProfileDataGridTree to be consistent with TopDownProfileDataGridNode.
(WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode):
(WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild):
(WebInspector.BottomUpProfileDataGridNode.prototype._exclude):
(WebInspector.BottomUpProfileDataGridNode.prototype._merge):
(WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate):
(WebInspector.BottomUpProfileDataGridTree.prototype.exclude):
* inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.sort): Added missing parentheses.
(WebInspector.ProfileDataGridNode.prototype.get _parent):
(WebInspector.ProfileDataGridNode.prototype._populate):
* inspector/front-end/TopDownProfileDataGridTree.js:
(WebInspector.TopDownProfileDataGridNode.prototype._sharedPopulate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50141
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Tue, 27 Oct 2009 12:20:35 +0000 (12:20 +0000)]
2009-10-27 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25534
[GTK] Objects of ROLE_TABLE should implement the accessible table interface
First part of the implementation of AtkTable.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(getCell):
(getCellIndex):
(webkit_accessible_table_ref_at):
(webkit_accessible_table_get_index_at):
(webkit_accessible_table_get_n_columns):
(webkit_accessible_table_get_n_rows):
(webkit_accessible_table_get_column_extent_at):
(webkit_accessible_table_get_row_extent_at):
(webkit_accessible_table_get_row_header):
(atk_table_interface_init):
(AtkInterfacesInitFunctions):
(GetAtkInterfaceTypeFromWAIType):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50140
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Tue, 27 Oct 2009 11:33:44 +0000 (11:33 +0000)]
[Qt] Don't lose remainder when computing wheel event deltas
Reviewed by Lars Knoll.
* platform/qt/WheelEventQt.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50139
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 27 Oct 2009 10:17:36 +0000 (10:17 +0000)]
2009-10-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Antti Koivisto.
Fix QtWebKit build for WIN_OS if Netscape plug-in support
is turned off and refactor some related code
https://bugs.webkit.org/show_bug.cgi?id=30786
No new tests as there is no new functionality introduced.
* platform/FileSystem.h: Refactor to make sure that each different
type definition is only repeated once.
* plugins/PluginPackage.cpp:
(WebCore::PluginPackage::compareFileVersion): Move it out from the
ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH guard and combine it with the
function body from PluginPackageWin.
* plugins/win/PluginPackageWin.cpp: Remove compareFileVersion as
it is now in PluginPackage.cpp.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50138
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 27 Oct 2009 10:09:19 +0000 (10:09 +0000)]
2009-10-27 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
svn-apply can exit(0) even on patch failure
https://bugs.webkit.org/show_bug.cgi?id=29622
* Scripts/svn-apply:
- Add a bunch of "or die" statements, hopefully catching all
possible cases where failure could still exit(0).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50137
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 27 Oct 2009 10:01:58 +0000 (10:01 +0000)]
2009-10-27 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
svn-* scripts should share code through VCSUtils.pm
https://bugs.webkit.org/show_bug.cgi?id=30791
Just moving code into a shared location.
* Scripts/VCSUtils.pm:
* Scripts/prepare-ChangeLog:
* Scripts/resolve-ChangeLogs:
* Scripts/svn-apply:
* Scripts/svn-create-patch:
* Scripts/svn-unapply:
* Scripts/update-webkit:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50136
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 27 Oct 2009 09:54:39 +0000 (09:54 +0000)]
2009-10-27 Vadim Zeitlin <vadim@wxwidgets.org>
Suppress a huge number of MSVC warnings when building wxWebKit.
* wx/build/settings.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50135
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Tue, 27 Oct 2009 09:20:21 +0000 (09:20 +0000)]
2009-10-26 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=27011
[Gtk] Implement support for get_index_in_parent
Implement atk_object_get_index_in_parent.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_get_index_in_parent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50134
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 27 Oct 2009 09:07:43 +0000 (09:07 +0000)]
2009-10-27 Eric Seidel <eric@webkit.org>
No review, rolling out r50131.
http://trac.webkit.org/changeset/50131
* bridge/objc/objc_instance.h:
* bridge/objc/objc_instance.mm:
(ObjcInstance::ObjcInstance):
(ObjcInstance::virtualEnd):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50133
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Tue, 27 Oct 2009 07:12:10 +0000 (07:12 +0000)]
2009-10-26 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=30491
Fixes an issue where pressing return/enter on the keyboard
in <isindex> does not submit it if is not within a <form>.
According to the HTML 2.0 thru HTML 4.01 spec
(http://www.w3.org/MarkUp/html-spec/html-spec_7.html#SEC7.5), the
<isindex> element does not need to be within a <form> element in
order to submit it. It can submitted on its own. Also, if present,
the href property of the <base> element will dictate where to submit
the value of the <isindex> element (this is analogous to the action
property of the <form> element).
Tests: http/tests/misc/isindex-with-no-form-base-href.html
http/tests/misc/isindex-with-no-form.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler): Calls createTemporaryFormForIsIndex()
to create a <form> if none is present and we are an <isindex> element.
(WebCore::HTMLInputElement::createTemporaryFormForIsIndex): Added.
* html/HTMLInputElement.h:
2009-10-26 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=30491
Test that the <isindex> element can be submitted without being enclosed
within a <form> element. Also tests that the href property of the <base>
element can be used to direct where the submission is sent.
* http/tests/misc/isindex-with-no-form-base-href-expected.txt: Added.
* http/tests/misc/isindex-with-no-form-base-href.html: Added.
* http/tests/misc/isindex-with-no-form-expected.txt: Added.
* http/tests/misc/isindex-with-no-form.html: Added.
* http/tests/misc/resources/isindex-with-no-form-base-href-submit.html: Added.
* http/tests/misc/resources/isindex-with-no-form-base-href.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50132
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Tue, 27 Oct 2009 07:10:01 +0000 (07:10 +0000)]
Crash occurs after launching Newsfire 1.6 for the first time
https://bugs.webkit.org/show_bug.cgi?id=30807
Reviewed by Maciej Stachowiak.
Use a RetainPtr in ObjcBinding to ensure that we adequately
protect the autorelease pool from GC in GC'd applications.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50131
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 27 Oct 2009 04:48:46 +0000 (04:48 +0000)]
2009-10-26 Eric Seidel <eric@webkit.org>
No review, just adding Mike Belshe to the committers list.
* Scripts/modules/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50130
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Tue, 27 Oct 2009 04:48:18 +0000 (04:48 +0000)]
Versioning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50129
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Tue, 27 Oct 2009 03:57:19 +0000 (03:57 +0000)]
2009-10-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed.
[Qt] Build fix for QtWebKit after r50125.
* WebCore.pro: Rename TimelineItem to TimelineRecord.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50127
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 27 Oct 2009 03:38:56 +0000 (03:38 +0000)]
2009-10-26 Matt Mueller <mattm@chromium.org>
Reviewed by Darin Adler.
Refactor synchronizable property handling to store one shouldSynchronize flag per set of properties rather than one per property.
Fixes reading uninitialized memory in SynchronizableProperty hash function as well as simplifying the code.
https://bugs.webkit.org/show_bug.cgi?id=30658
Covered by running various svg tests under valgrind, ex:
LayoutTests/svg/custom/js-late-mask-and-object-creation.svg
* svg/SynchronizablePropertyController.cpp:
(WebCore::SynchronizableProperties::addProperty):
(WebCore::SynchronizableProperties::synchronize):
(WebCore::SynchronizableProperties::startAnimation):
(WebCore::SynchronizableProperties::stopAnimation):
(WebCore::SynchronizablePropertyController::registerProperty):
(WebCore::SynchronizablePropertyController::setPropertyNeedsSynchronization):
(WebCore::SynchronizablePropertyController::synchronizeProperty):
(WebCore::SynchronizablePropertyController::synchronizeAllProperties):
(WebCore::SynchronizablePropertyController::startAnimation):
(WebCore::SynchronizablePropertyController::stopAnimation):
* svg/SynchronizablePropertyController.h:
(WebCore::SynchronizableProperties::SynchronizableProperties):
(WebCore::SynchronizableProperties::setNeedsSynchronization):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50126
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 27 Oct 2009 03:24:05 +0000 (03:24 +0000)]
2009-10-26 Kelly Norton <knorton@google.com>
Reviewed by Timothy Hatcher.
Renames TimelineItem to TimelineRecord and updates all call sites.
https://bugs.webkit.org/show_bug.cgi?id=30785
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::addRecordToTimeline):
* inspector/InspectorFrontend.h:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willDispatchDOMEvent):
(WebCore::InspectorTimelineAgent::didDispatchDOMEvent):
(WebCore::InspectorTimelineAgent::willLayout):
(WebCore::InspectorTimelineAgent::didLayout):
(WebCore::InspectorTimelineAgent::willRecalculateStyle):
(WebCore::InspectorTimelineAgent::didRecalculateStyle):
(WebCore::InspectorTimelineAgent::willPaint):
(WebCore::InspectorTimelineAgent::didPaint):
(WebCore::InspectorTimelineAgent::willWriteHTML):
(WebCore::InspectorTimelineAgent::didWriteHTML):
(WebCore::InspectorTimelineAgent::didInstallTimer):
(WebCore::InspectorTimelineAgent::didRemoveTimer):
(WebCore::InspectorTimelineAgent::willFireTimer):
(WebCore::InspectorTimelineAgent::didFireTimer):
(WebCore::InspectorTimelineAgent::reset):
(WebCore::InspectorTimelineAgent::addRecordToTimeline):
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
* inspector/InspectorTimelineAgent.h:
(WebCore::):
(WebCore::InspectorTimelineAgent::RecordEntry::RecordEntry):
* inspector/TimelineItemFactory.cpp: Removed.
* inspector/TimelineItemFactory.h: Removed.
* inspector/TimelineRecordFactory.cpp: Added.
(WebCore::TimelineRecordFactory::createGenericRecord):
(WebCore::TimelineRecordFactory::createDOMDispatchRecord):
(WebCore::TimelineRecordFactory::createGenericTimerRecord):
(WebCore::TimelineRecordFactory::createTimerInstallRecord):
* inspector/TimelineRecordFactory.h: Added.
(WebCore::TimelineRecordFactory::TimelineRecordFactory):
* inspector/front-end/TimelineAgent.js:
(WebInspector.addRecordToTimeline):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.addRecordToTimeline):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype.getRecordTypeName):
(WebInspector.TimelineRecordTreeElement.prototype.onattach):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50125
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Tue, 27 Oct 2009 02:56:43 +0000 (02:56 +0000)]
Unreviewed spelling fix in the PluginViewQt.cpp
This error was pointed out in the bug report and it was agreed to
do the spelling fix when landing the patch. Fix it now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50124
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 27 Oct 2009 02:50:04 +0000 (02:50 +0000)]
2009-10-26 Girish Ramakrishnan <girish@forwardbias.in>
Reviewed by Antti Koivisto.
[Qt] Windowless Plugins : Print preview shows only part of flash when view is scrolled
When printing, QPrinter's preview mode uses a QPicture to capture the output. The
QPicture holds a reference to the X Pixmap. As a result, the print preview would
update itself when the X Pixmap changes. To prevent the print preview from updating
whenever m_drawable is updated (i.e when the view updates), we create a copy.
We require that a QPixmap::copy() result in a QPixmap backed by a XPixmap
regardless of the graphicssystem. This is taken care of by
commit
d310f7c710ecb331a9689861f0551eabd38e946e in Qt (4.6)
The beauty of this patch is that the newly created X Pixmap is managed by Qt and
it will free the Pixmap whenever the user closes the print preview dialog and
handles the case of displaying multiple preview dialogs nicely.
All credit to Samuel Rødal for suggesting usage of QPixmap::copy().
https://bugs.webkit.org/show_bug.cgi?id=30714
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50123
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 27 Oct 2009 02:42:48 +0000 (02:42 +0000)]
2009-10-26 Benjamin Otte <otte@gnome.org>
Reviewed by Gustavo Noronha.
Don't store properties in the MediaPlayerPrivate class
Access them via the MediaPlayer class instead.
https://bugs.webkit.org/show_bug.cgi?id=30462
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::setVolume):
(WebCore::MediaPlayerPrivate::setRate):
(WebCore::MediaPlayerPrivate::setVisible):
(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::createGSTPlayBin):
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50122
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Tue, 27 Oct 2009 02:27:59 +0000 (02:27 +0000)]
Fixes <http://webkit.org/b/30801>.
Web Inspector: Control + ]/[ on Windows doesn't change Panels.
Reviewed by Timothy Hatcher.
In my testing, Windows uses "U+00DB" and "U+00DD" to represent
[ and ], so we should honor those as well.
* inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50121
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Tue, 27 Oct 2009 02:10:18 +0000 (02:10 +0000)]
2009-10-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
Make .rc files compile on Windows without depending on MFC headers
https://bugs.webkit.org/show_bug.cgi?id=30750
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc: Use
winresrc.h because it exists even when MFC is not installed, and is
all that's needed here.
* WebCore.vcproj/QTMovieWin.rc: Ditto.
* WebKit.vcproj/WebKit.rc: Ditto.
* DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
windows.h instead of afxres.h because it exists even when MFC is not
installed, and is all that's needed here.
* FindSafari/FindSafari.rc: Ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50120
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Tue, 27 Oct 2009 01:56:05 +0000 (01:56 +0000)]
Unreviewed - Updating getComputedStyle results for Windows.
Updating getComputedStyle results for Windows.
* platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50119
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 27 Oct 2009 01:09:22 +0000 (01:09 +0000)]
Build corrections for ENABLE_FILTERS in Windows.
https://bugs.webkit.org/show_bug.cgi?id=30797
Reviewed by Darin Adler.
Build correction for ENABLE_FILTERS feature. No new tests needed.
* platform/graphics/filters/FEColorMatrix.cpp: Use MathExtras.h and
its piDouble constant.
* platform/graphics/filters/FEGaussianBlur.cpp: Use MathExtras.h and
its piDouble constant. Remove unnecessary call to floor used in
the division of an unsigned, converting to int.
* platform/graphics/win/SimpleFontDataCairoWin.cpp: Correct include
style for MathExtras.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50118
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 27 Oct 2009 00:53:44 +0000 (00:53 +0000)]
Updated BSD License
Reviewed by Adele Peterson.
* coding/bsd-license.html: Updated to the latest version.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50117
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Tue, 27 Oct 2009 00:19:33 +0000 (00:19 +0000)]
<rdar://problem/
7289467> and webkit.org/b/30798 - REGRESSION (r48687): myuhc.com doesn't load.
Reviewed by Darin Adler.
WebCore:
Test: fast/loader/grandparent-completion-starts-redirect.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::completed): Notify all descendants that the load completed, not just direct children.
LayoutTests:
* fast/loader/grandparent-completion-starts-redirect-expected.txt: Added.
* fast/loader/grandparent-completion-starts-redirect.html: Added.
* fast/loader/resources/meta-redirect-to-notify-done.html: Added.
* fast/loader/resources/parent-of-redirect.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50116
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 26 Oct 2009 23:56:41 +0000 (23:56 +0000)]
WebCore: Re-add CSSPropertyWebkitBackgroundSize in one more place
Reviewed by Beth Dakin.
Fixes transitions/multiple-background-size-transitions.html, transitions/background-transitions.html
* page/animation/AnimationBase.cpp:
(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
LayoutTests: Use -webkit-background-size as the transition property in this test now
that it is distinct from background-size.
Reviewed by Sam Weinig.
* transitions/multiple-background-size-transitions.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50115
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 26 Oct 2009 23:56:32 +0000 (23:56 +0000)]
Clean up the regex madness in auto-version.sh to make it obvious what the script is doing.
Reviewed by Adam Roben.
Also teaches auto-version.sh to handle RC_PROJECTSOURCEVERSION that has more than three digits
in the major component of the version number.
* win/tools/scripts/auto-version.sh:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50114
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Mon, 26 Oct 2009 23:44:49 +0000 (23:44 +0000)]
2009-10-26 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Tidy up the DOM Storage runtime flag stuff
https://bugs.webkit.org/show_bug.cgi?id=30794
Clean up the DOM Storage runtime flag stuff to match the new way of doing
things. No behavioral changes.
* bindings/v8/RuntimeEnabledFeatures.cpp:
* bindings/v8/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setDatabaseEnabled):
(WebCore::RuntimeEnabledFeatures::databaseEnabled):
(WebCore::RuntimeEnabledFeatures::setLocalStorageEnabled):
(WebCore::RuntimeEnabledFeatures::localStorageEnabled):
(WebCore::RuntimeEnabledFeatures::setSessionStorageEnabled):
(WebCore::RuntimeEnabledFeatures::sessionStorageEnabled):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::ACCESSOR_RUNTIME_ENABLER):
* storage/Storage.cpp:
* storage/Storage.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50113
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 26 Oct 2009 23:27:25 +0000 (23:27 +0000)]
Rubber-stamped by Beth Dakin.
Update expedted results after r50108.
* svg/css/getComputedStyle-basic-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50112
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Mon, 26 Oct 2009 23:20:25 +0000 (23:20 +0000)]
<rdar://problem/
7308952> and webkit.org/b/30424 - REGRESSION (r48687): Pages on ucas.com appear blank.
Reviewed by Darin Adler.
WebCore:
Test: fast/loader/history-forward-in-head.html
* loader/RedirectScheduler.cpp:
(WebCore::RedirectScheduler::scheduleHistoryNavigation): Restore the moved canGoBackOrForward() check.
This restores the side effect of an invalid history navigation canceling previous scheduled redirects
and also fixes the bug of scheduling an invalid history navigation canceling parsing of the current document.
(WebCore::RedirectScheduler::timerFired): Removed the canGoBackOrForward() check as it is now made before
the redirect is scheduled.
LayoutTests:
* fast/loader/history-forward-in-head-expected.txt: Added.
* fast/loader/history-forward-in-head.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50111
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Mon, 26 Oct 2009 23:11:30 +0000 (23:11 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=30049
<rdar://problem/
7286002> Manipulating DOM from a script while parsing XHTML can cause a crash
Tests: fast/parser/remove-current-node-parent-x-2.xhtml
fast/parser/remove-current-node-parent-x.xhtml
* dom/XMLTokenizer.h: Store the whole stack of parent nodes - element.parentNode() is
unreliable after DOM manipulation.
* dom/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::pushCurrentNode): Push the new node onto stack.
(WebCore::XMLTokenizer::popCurrentNode): This is now called instead of setCurrentNode when
exiting a node.
(WebCore::XMLTokenizer::clearCurrentNodeStack): We're aborting; or just done parsing. This
replaces setCurrentNode(0).
(WebCore::XMLTokenizer::enterText): Call pushCurrentNode().
(WebCore::XMLTokenizer::exitText): Call popCurrentNode(), removing a long-standing FIXME
(not sure if it was ever practical though - how can a parent become null while adding text?)
* dom/XMLTokenizerLibxml2.cpp:
(WebCore::XMLTokenizer::~XMLTokenizer): Call clearCurrentNodeStack().
(WebCore::XMLTokenizer::startElementNs): Call pushCurrentNode().
(WebCore::XMLTokenizer::endElementNs): Call popCurrentNode() to safely get to a parent. Also
added a check fo script element still being in document - Firefox parses those that aren't,
but doesn't execute them.
* dom/XMLTokenizerQt.cpp:
(WebCore::XMLTokenizer::~XMLTokenizer):
(WebCore::XMLTokenizer::parseStartElement):
(WebCore::XMLTokenizer::parseEndElement):
Match libxml2 version changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50110
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 26 Oct 2009 22:49:23 +0000 (22:49 +0000)]
2009-10-26 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
The thunkReturnAddress is on JITStackFrame on ARM JIT as well
https://bugs.webkit.org/show_bug.cgi?id=30782
Move the thunkReturnAddress from top of the stack into the JITStackFrame
structure. This is a requirement for JSValue32_64 support on ARM.
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::ret): Return with link register
(JSC::MacroAssemblerARM::prepareCall): Store the return address in link register
* jit/JIT.h: Remove unused ctiReturnRegister
* jit/JITInlineMethods.h: Same as ARMv7
(JSC::JIT::restoreArgumentReference): Ditto.
(JSC::JIT::restoreArgumentReferenceForTrampoline): Ditto.
* jit/JITOpcodes.cpp: Remove ctiReturnRegister related instruction
* jit/JITStubs.cpp: Store thunkReturnAddress on JITStackFrame. Use
small trampoline functions which handle return addresses for each
CTI_STUB_FUNCTION.
* jit/JITStubs.h: Store thunkReturnAddress on JITStackFrame
(JSC::JITStackFrame::returnAddressSlot): Return with the address of thunkReturnAddress
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::generateEnter): Remove the unnecessary instruction
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50109
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 26 Oct 2009 22:41:45 +0000 (22:41 +0000)]
background-size: X treated as background-size: X X, not background-size: X auto
https://bugs.webkit.org/show_bug.cgi?id=28440
Reviewed by Beth Dakin.
WebCore:
Updated fast/backgrounds/size/resources/parsing-background-size-values.js
and fast/backgrounds/size/resources/parsing-inherit.js
Reinstated -webkit-background-size and kept its behavior of filling in
the second value with the first one; and changed background-size to have
the behavior of filling in the second value with 'auto'.
* css/CSSComputedStyleDeclaration.cpp:
(computedProperties): Re-added CSSPropertyWebkitBackgroundSize.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Ditto.
(WebCore::CSSParser::parseFillSize): Adapted for the new parsing rule.
(WebCore::CSSParser::parseFillProperty): Re-added
CSSPropertyWebkitBackgroundSize.
(WebCore::cssPropertyID): Removed mapping of -webkit-background-size to
background-size.
* css/CSSParser.h:
* css/CSSPropertyNames.in: Re-added -webkit-background-size.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty): Re-added
CSSPropertyWebkitBackgroundSize.
LayoutTests:
* fast/backgrounds/size/parsing-background-size-values-expected.txt:
* fast/backgrounds/size/parsing-inherit-expected.txt:
* fast/backgrounds/size/resources/parsing-background-size-values.js:
(test):
* fast/backgrounds/size/resources/parsing-inherit.js:
* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50108
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 26 Oct 2009 22:41:10 +0000 (22:41 +0000)]
2009-10-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool post-diff should know how to mark commit-queue=?
https://bugs.webkit.org/show_bug.cgi?id=29202
* Scripts/bugzilla-tool:
- Add --commit-queue option to post-diff, post-commits and create-bug.
* Scripts/modules/bugzilla.py:
- Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
- Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50107
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 26 Oct 2009 22:37:08 +0000 (22:37 +0000)]
Move some WebView event handling code into its own file, WebViewEventHandling.mm
Reviewed by Anders Carlsson.
WebKit:
* WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
* WebView/WebView.mm:
(-[WebView _close]):
(-[WebView _selectedOrMainFrame]):
* WebView/WebViewEventHandling.mm: Added.
(-[WebView _closingEventHandling]):
(-[WebView _setMouseDownEvent:]):
(-[WebView mouseDown:]):
(-[WebView mouseUp:]):
(+[WebView _updateMouseoverWithEvent:]):
(-[WebView _updateMouseoverWithFakeEvent]):
(_updateMouseoverWithEvent:fakeEvent::if):
(-[WebView _stopAutoscrollTimer]):
(-[WebView _setToolTip:]):
* WebView/WebViewInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50106
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 26 Oct 2009 22:34:19 +0000 (22:34 +0000)]
2009-10-23 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool commit-queue does not notice modifications to committers.py
https://bugs.webkit.org/show_bug.cgi?id=30084
* Scripts/bugzilla-tool:
- Make commit-queue re-exec itself instead of using while(1).
- Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
- Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50105
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 26 Oct 2009 22:32:03 +0000 (22:32 +0000)]
2009-10-22 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue will get stuck on patches if land-patches terminates unexpectedly
https://bugs.webkit.org/show_bug.cgi?id=30634
* Scripts/bugzilla-tool:
- Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
- Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50104
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 26 Oct 2009 22:22:48 +0000 (22:22 +0000)]
2009-10-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Eric Seidel.
[Qt] Use "%lli" to format "long long" on WIN_OS to fix HTML5 WebDB crash
https://bugs.webkit.org/show_bug.cgi?id=30777
No new tests as the crash can be reproduced by existing storage
LayoutTests (by hitting an assert in debug mode Webkit on WIN_OS).
* platform/text/String.cpp:
(WebCore::String::number): Qt's QString::vsprintf does not
understand the "%I64u" format string. Always use the "%lli"
format string for Qt port.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50103
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 26 Oct 2009 22:10:26 +0000 (22:10 +0000)]
2009-10-26 Yuzo Fujishima <yuzo@google.com>
Reviewed by Eric Seidel.
Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
https://bugs.webkit.org/show_bug.cgi?id=30763
* pywebsocket/mod_pywebsocket/__init__.py:
* pywebsocket/mod_pywebsocket/dispatch.py:
* pywebsocket/mod_pywebsocket/headerparserhandler.py:
* pywebsocket/mod_pywebsocket/standalone.py:
* pywebsocket/setup.py:
* pywebsocket/test/test_dispatch.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50102
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Mon, 26 Oct 2009 22:04:00 +0000 (22:04 +0000)]
2009-10-26 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
Roll back r50073 because r50041-50043 were reverted. r50073 was
a chromium side fix for r50041.
https://bugs.webkit.org/show_bug.cgi?id=30789
* bindings/v8/V8Collection.h:
* bindings/v8/custom/V8CustomBinding.h:
* bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::getItem):
(WebCore::NAMED_PROPERTY_GETTER):
(WebCore::CALLBACK_FUNC_DECL):
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::getItem):
(WebCore::NAMED_PROPERTY_GETTER):
(WebCore::CALLBACK_FUNC_DECL):
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50101
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Mon, 26 Oct 2009 22:02:47 +0000 (22:02 +0000)]
WebCore: Fixed https://bugs.webkit.org/show_bug.cgi?id=30765
REGRESSION (r48701): Removing an event listener causes the one added just after it not to fire
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-26
Reviewed by Dimitri Glazkov.
and related bugs.
If the event listener being removed is prior to the current firing event
iterator, we need to decrement the current firing event iterator in
addition to the endpoint. (Otherwise, shrinking the event listener vector
by one implicity moves the current firing event iterator forward by one.
It's like relativity, only without the planets.)
Also took the opportunity to change some pointers to references, since
they can't be null.
* dom/EventTarget.cpp:
(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::removeAllEventListeners): Update iterator in addition
to end, if need be.
(WebCore::EventTarget::fireEventListeners): Updated for interface changes.
Added a comment to explain a behavior that was implicit enough to be
confusing.
* dom/EventTarget.h:
(WebCore::FiringEventIterator::FiringEventIterator):
(WebCore::EventTarget::isFiringEventListeners): Updated for interface changes.
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=30765
REGRESSION (r48701): Removing an event listener causes one added after it to not fire
Patch by Dimitri Glazkov <dglazkov@chromium.org> on 2009-10-26
Reviewed by Geoffrey Garen.
* fast/events/event-listener-list-mutation-expected.txt: Added.
* fast/events/event-listener-list-mutation.html: Added.
* fast/events/script-tests/event-listener-list-mutation.js: Added.
(TestMutation.listeners):
(TestMutation.mutateList):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50100
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Mon, 26 Oct 2009 21:52:59 +0000 (21:52 +0000)]
Unreviewed documentation fix from David Boddie (Qt Doc Team)
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-26
Removes the check around the RenderHints property documentation
that was clearly added to synchronize the source and header files
when the #if !defined(Q_OS_SYMBIAN) guards was added to the
property.
The documentation has also been updated to ensure that Symbian
users know that there is no actual RenderHints property on their
platform.
* Api/qwebview.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50099
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Mon, 26 Oct 2009 21:50:41 +0000 (21:50 +0000)]
Fixes <http://webkit.org/b/30792>.
Web Inspector: When changing resource scope, resource graph can get in weird state.
Reviewed by Timothy Hatcher.
If the user was scrolled down while looking at All resources, and then just
selects Fonts, or something that doesn't have many resources, then the graph
will stay scrolled down, even when there is no content there.
When the filter is updated, scroll to the top of the graph view, so this won't
happen.
* inspector/front-end/AbstractTimelinePanel.js:
(WebInspector.AbstractTimelinePanel.prototype._updateFilter):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50098
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 26 Oct 2009 21:46:02 +0000 (21:46 +0000)]
Fix mac clean build.
* html/HTMLOptionsCollection.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50097
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Mon, 26 Oct 2009 21:42:38 +0000 (21:42 +0000)]
Unreviewed documentation fix from David Boddie (Qt Doc Team)
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-26
Ensure that qdoc will always see the RenderHints property.
The property was only defined in the header file if the Q_OS_SYMBIAN
symbol was not defined, resulting in the property not showing up
in the Qt documentation just because one platform doesn't support it.
A follow up commit will improve the documentation for the property
and note that it is not supported on the Symbiam platform.
* Api/qwebview.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50096
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 26 Oct 2009 21:35:50 +0000 (21:35 +0000)]
2009-10-26 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Extract AbstractTimelinePanel that will be a base
class for ResourcesPanel and TimelinePanel.
https://bugs.webkit.org/show_bug.cgi?id=30776
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/AbstractTimelinePanel.js: Added.
(WebInspector.AbstractTimelinePanel):
(WebInspector.AbstractTimelinePanel.prototype.get categories):
(WebInspector.AbstractTimelinePanel.prototype.showCategory):
(WebInspector.AbstractTimelinePanel.prototype.hideCategory):
(WebInspector.AbstractTimelinePanel.prototype.createTimelinePanels):
(WebInspector.AbstractTimelinePanel.prototype._createFilterPanel.createFilterElement):
(WebInspector.AbstractTimelinePanel.prototype._createFilterPanel):
(WebInspector.AbstractTimelinePanel.prototype.filter):
(WebInspector.AbstractTimelinePanel.prototype._updateFilter):
(WebInspector.AbstractTimelinePanel.prototype._createGraph):
(WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
(WebInspector.AbstractTimelinePanel.prototype._updateSummaryGraph):
(WebInspector.AbstractTimelinePanel.prototype._updateDividersLabelBarPosition):
(WebInspector.AbstractTimelinePanel.prototype.get needsRefresh):
(WebInspector.AbstractTimelinePanel.prototype.set needsRefresh):
(WebInspector.AbstractTimelinePanel.prototype.refreshIfNeeded):
(WebInspector.AbstractTimelinePanel.prototype.show):
(WebInspector.AbstractTimelinePanel.prototype.resize):
(WebInspector.AbstractTimelinePanel.prototype.updateMainViewWidth):
(WebInspector.TimelineCalculator):
(WebInspector.TimelineCalculator.prototype.computeSummaryValues):
(WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
(WebInspector.TimelineCalculator.prototype.computeBarGraphLabels):
(WebInspector.TimelineCalculator.prototype.get boundarySpan):
(WebInspector.TimelineCalculator.prototype.updateBoundaries):
(WebInspector.TimelineCalculator.prototype.reset):
(WebInspector.TimelineCalculator.prototype._value):
(WebInspector.TimelineCalculator.prototype.formatValue):
* inspector/front-end/ResourceCategory.js:
(WebInspector.ResourceCategory):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.toolbarItemClass.get toolbarItemLabel):
(WebInspector.ResourcesPanel.prototype.get statusBarItems):
(WebInspector.ResourcesPanel.prototype.get categories):
(WebInspector.ResourcesPanel.prototype.showCategory):
(WebInspector.ResourcesPanel.prototype.hideCategory):
(WebInspector.ResourcesPanel.prototype.isCategoryVisible):
(WebInspector.ResourcesPanel.prototype.populateSidebar):
(WebInspector.ResourcesPanel.prototype.createPanelEnabler):
(WebInspector.ResourcesPanel.prototype.createStatusbarButtons):
(WebInspector.ResourcesPanel.prototype.set mainResourceLoadTime):
(WebInspector.ResourcesPanel.prototype.set mainResourceDOMContentTime):
(WebInspector.ResourcesPanel.prototype.show):
(WebInspector.ResourcesPanel.prototype.resize):
(WebInspector.ResourcesPanel.prototype.reset):
(WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded):
(WebInspector.ResourcesPanel.prototype.updateMainViewWidth):
(WebInspector.ResourceTimeCalculator):
(WebInspector.ResourceTransferSizeCalculator):
(WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphLabels):
* inspector/front-end/SummaryBar.js:
(WebInspector.SummaryBar.prototype.update):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.loaded):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50095
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 26 Oct 2009 21:09:55 +0000 (21:09 +0000)]
2009-10-26 Avi Drissman <avi@google.com>
Reviewed by Darin Adler.
Use Helvetica in the Inspector as intended.
https://bugs.webkit.org/show_bug.cgi?id=30787
* inspector/front-end/inspector.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50094
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Mon, 26 Oct 2009 21:05:55 +0000 (21:05 +0000)]
2009-10-26 Xan Lopez <xlopez@igalia.com>
Skip test fast/loader/opaque-base-url.html with a reference to the
bug tracking it, https://bugs.webkit.org/show_bug.cgi?id=30724
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50093
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 26 Oct 2009 21:02:10 +0000 (21:02 +0000)]
2009-10-26 Nate Chapin <japhet@chromium.org>
Reviewed by Alexey Proskuryakov.
Update no-referrer-reset for https://bugs.webkit.org/show_bug.cgi?id=30781.
* http/tests/navigation/no-referrer-reset-expected.txt: Expect window.opener to still be set.
* http/tests/navigation/no-referrer-reset.html: Update text to reflect what the test actually does.
2009-10-26 Nate Chapin <japhet@chromium.org>
Reviewed by Alexey Proskuryakov.
Don't set window.opener to 0 for the current FrameLoader if a noreferrer link was clicked, only suppress opener in a new frame.
https://bugs.webkit.org/show_bug.cgi?id=30781
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::urlSelected): Don't suppress opener in the current frame for noreferrer navigations.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50092
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 26 Oct 2009 20:53:44 +0000 (20:53 +0000)]
2009-10-26 Carol Szabo <carol.szabo@nokia.com>
Reviewed by David Levin.
REGRESSION: 2 failures in run-webkit-unittests
https://bugs.webkit.org/show_bug.cgi?id=30645
* Scripts/modules/cpp_style_unittest.py:
Fixed a few test scenarios which apparently lost some spaces from
text literals.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50091
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 26 Oct 2009 20:48:55 +0000 (20:48 +0000)]
Data loss occurs when unbolding nested bold tags.
https://bugs.webkit.org/show_bug.cgi?id=30083
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-26
Reviewed by Eric Seidel.
WebCore:
Fixes the loop in swapInNodePreservingAttributesAndChildren by saving nextSibling() of child
to a temporary valuable. It was originally calling nextSibling() after appending the child
to new parent, in which case, nextSibling is always 0.
Test: editing/style/unbolding-nested-b.html
* editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):
LayoutTests:
Adds a test to make sure WebKit can remove nested b, i, & s tags properly
without loosing the content of inner elements.
* editing/style/remove-nested-inline-styles-expected.txt: Added.
* editing/style/remove-nested-inline-styles.html: Added.
* editing/style/script-tests/remove-nested-inline-styles.js: Added.
(removeStyleAndExpect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50090
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Mon, 26 Oct 2009 20:16:59 +0000 (20:16 +0000)]
Reviewed by Jan Alonzo.
Alternative solution to regression introduced in r48672.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50089
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Mon, 26 Oct 2009 20:11:41 +0000 (20:11 +0000)]
2009-10-21 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
Storage events should use Document::url() rather than documentURI()
https://bugs.webkit.org/show_bug.cgi?id=30535
Storage events should use Document::url() rather than Document::documentURI()
per http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-October/023703.html
Test: storage/domstorage/documentURI.html
* storage/StorageEventDispatcher.cpp:
(WebCore::StorageEventDispatcher::dispatch):
2009-10-26 Sam Weinig <sam@webkit.org>
Rubber-stamped by Darin Adler.
Rollout r50041-50043. The HTML5 spec changed to make HTMLOptionsCollection
inherit from HTMLCollection.
* fast/dom/wrapper-classes-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50088
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 26 Oct 2009 20:04:22 +0000 (20:04 +0000)]
Rubber-stamped by Darin Adler.
Rollout r50041-50043. The HTML5 spec changed to make HTMLOptionsCollection
inherit from HTMLCollection.
WebCore:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::callHTMLCollection):
(WebCore::JSHTMLCollection::nameGetter):
(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):
(WebCore::toJS):
* bindings/js/JSHTMLCollectionFunctions.h: Removed.
* bindings/js/JSHTMLDocumentCustom.cpp:
* bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::JSHTMLOptionsCollection::length):
(WebCore::JSHTMLOptionsCollection::indexSetter):
* bindings/objc/DOMHTML.mm:
(kitClass):
* bindings/objc/DOMUtility.mm:
(JSC::createDOMWrapper):
* bindings/scripts/CodeGeneratorJS.pm:
* html/HTMLCollection.idl:
* html/HTMLOptionsCollection.idl:
WebKit/win:
* DOMCreateInstance.cpp:
LayoutTests:
* fast/dom/wrapper-classes-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50087
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Mon, 26 Oct 2009 19:46:34 +0000 (19:46 +0000)]
wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50086
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Mon, 26 Oct 2009 19:34:45 +0000 (19:34 +0000)]
Build fix for ENABLE_FILTERS under Windows.
https://bugs.webkit.org/show_bug.cgi?id=30762
Reviewed by Adam Roben.
Build correction for ENABLE_FILTERS feature. No new tests needed.
* WebCore.vcproj/WebCore.vcproj: Make the following changes:
(1) Create a new 'filters' sub-folder of the platform/graphics
folder to properly show the sources held in this directory.
(2) Move the files that are currently shown in svn/graphics/filters
to platform/graphics/filters (where they actually live on disk).
(3) Add the missing SVGFilter, SVGFilterBuilder, and SVGFETile to
the project so they are built.
(4) Remove SVGFEFloodElement.cpp from the build, since it is already
being compiled by SVGAllInOne.cpp. Its presence as a separate
entity is causing a linker warning for duplicate symbols.
(5) Add ImageBuffer.cpp to the build to support color space
calculations for non-CG builds.
* WebCore.vcproj/WebCoreCommon.vsprops: Add the platform/graphics/filters
path to the search paths in the project.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50085
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 26 Oct 2009 19:30:58 +0000 (19:30 +0000)]
2009-10-26 Keishi Hattori <casey.hattori@gmail.com>
Reviewed by Timothy Hatcher.
console.assert should prefix messages with "Assertion failed: "
https://bugs.webkit.org/show_bug.cgi?id=19135
* English.lproj/localizedStrings.js:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleMessage.prototype.toMessageElement): Append "Assertion failed: " for AssertMessageType.
(WebInspector.ConsoleMessage.prototype.toString):
* page/Console.cpp:
(WebCore::Console::assertCondition): Use AssertMessageType.
* page/Console.h:
(WebCore::MessageType): Added AssertMessageType.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50084
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 26 Oct 2009 19:19:58 +0000 (19:19 +0000)]
2009-10-26 Rahul Kuchhal <kuchhal@chromium.org>
Reviewed by Eric Seidel.
Prevent crash when optgroup element is empty.
https://bugs.webkit.org/show_bug.cgi?id=30365
* fast/forms/select-empty-optgroup-expected.txt: Added.
* fast/forms/select-empty-optgroup.html: Added.
2009-10-26 Rahul Kuchhal <kuchhal@chromium.org>
Reviewed by Eric Seidel.
Prevent crash when optgroup element is empty by adding a NULL check.
https://bugs.webkit.org/show_bug.cgi?id=30365
Test: fast/forms/select-empty-optgroup.html
* dom/SelectElement.cpp:
(WebCore::SelectElement::appendFormData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50083
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Mon, 26 Oct 2009 19:11:37 +0000 (19:11 +0000)]
2009-10-21 Steven Knight <sgk@chromium.org>
Reviewed by David Levin.
Refactor gyp for separate webcore_bindings{,_sources} targets.
https://bugs.webkit.org/show_bug.cgi?id=30447
Handle long link lines by building .idl-generated bindings in a
separate webcore_bindings library target. Avoid Visual Studio
dependency issues by building additional generated .cpp and .h files
in a separate webcore_bindings_sources target.
Chrome should still build and test successfully.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50082
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 26 Oct 2009 18:57:21 +0000 (18:57 +0000)]
Unification of using null device in perl scripts.
https://bugs.webkit.org/show_bug.cgi?id=30572
Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-26
Reviewed by Darin Adler.
* Scripts/VCSUtils.pm:
* Scripts/bisect-builds:
* Scripts/resolve-ChangeLogs:
* Scripts/run-iexploder-tests:
* Scripts/run-jsc:
* Scripts/run-mangleme-tests:
* Scripts/run-webkit-tests:
* Scripts/webkitdirs.pm:
Using File::Spec->devnull() instead of hard coded /dev/null.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50080
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 26 Oct 2009 18:40:45 +0000 (18:40 +0000)]
2009-10-26 Mike Belshe <mike@belshe.com>
Reviewed by Darin Fisher.
Make the number of connections for chromium controlled by
chromium rather than by ResourceRequestBase.
https://bugs.webkit.org/show_bug.cgi?id=30661
* platform/network/ResourceRequestBase.cpp:
* platform/network/chromium/ResourceRequest.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50079
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 26 Oct 2009 18:38:33 +0000 (18:38 +0000)]
2009-10-26 Eric Seidel <eric@webkit.org>
Reviewed by Holger Freyther.
Reviewers are missing from committers.py
https://bugs.webkit.org/show_bug.cgi?id=30733
* Scripts/modules/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50078
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 26 Oct 2009 18:33:50 +0000 (18:33 +0000)]
2009-10-23 Eric Seidel <eric@webkit.org>
Reviewed by Adam Roben.
PrettyPatch should show images even when they have the wrong mime type
https://bugs.webkit.org/show_bug.cgi?id=29506
* PrettyPatch/PrettyPatch.rb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50077
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 26 Oct 2009 17:54:28 +0000 (17:54 +0000)]
Unreviewed typo fix.
Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-26
* platform/qt/Skipped: shared-workers-close.html replaced with shared-worker-close.html
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50076
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Mon, 26 Oct 2009 17:45:02 +0000 (17:45 +0000)]
Unreviewed. make distcheck build fixes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50075
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Mon, 26 Oct 2009 17:44:47 +0000 (17:44 +0000)]
Unreviewed. Fix make dist regression introduced by r48672.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50074
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 26 Oct 2009 17:35:16 +0000 (17:35 +0000)]
2009-10-26 Anton Muhin <antonm@chromium.org>
Reviewed by Dimitri Glazkov.
Unbreak Chromium build: that requires adding custom implementations
for HTMLOptionsCollection's item and namedItem. Keep v8 binding
close to JSC bindings as well.
https://bugs.webkit.org/show_bug.cgi?id=30780
* bindings/v8/V8Collection.h:
(WebCore::getNamedItemsFromCollection):
(WebCore::getItemFromCollection):
* bindings/v8/custom/V8CustomBinding.h:
* bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
(WebCore::NAMED_PROPERTY_GETTER):
(WebCore::CALLBACK_FUNC_DECL):
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::NAMED_PROPERTY_GETTER):
(WebCore::CALLBACK_FUNC_DECL):
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50073
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Mon, 26 Oct 2009 17:26:26 +0000 (17:26 +0000)]
Reviewed by Adam Barth and Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=30723
<rdar://problem/
6189415> Input names added to multipart/form-data headers need to be escaped.
Test: http/tests/security/escape-form-data-field-names.html
* platform/network/FormDataBuilder.cpp:
(WebCore::appendQuotedString):
(WebCore::FormDataBuilder::beginMultiPartHeader):
(WebCore::FormDataBuilder::addFilenameToMultiPartHeader):
Percent-escape line breaks and quotation marks.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50072
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 26 Oct 2009 17:10:26 +0000 (17:10 +0000)]
[Qt] Skip two flakey tests because of sporadic timeouts.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50071
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 26 Oct 2009 17:06:01 +0000 (17:06 +0000)]
[Qt] Skipping two other tests because of missing features on our platform.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50070
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 26 Oct 2009 17:00:57 +0000 (17:00 +0000)]
[Qt] Add platform-dependent expected file for test added in r49875.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.
* platform/qt/fast/css/getComputedStyle/marginComputedStyle-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50069
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 26 Oct 2009 16:46:48 +0000 (16:46 +0000)]
2009-10-26 Kelly Norton <knorton@google.com>
Reviewed by Pavel Feldman.
Adds DOMTimer support to InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=30467
* inspector/InspectorTimelineAgent.cpp: Added timer support and fixed some method names.
(WebCore::InspectorTimelineAgent::didDispatchDOMEvent):
(WebCore::InspectorTimelineAgent::didLayout):
(WebCore::InspectorTimelineAgent::didRecalculateStyle):
(WebCore::InspectorTimelineAgent::didPaint):
(WebCore::InspectorTimelineAgent::didWriteHTML):
(WebCore::InspectorTimelineAgent::didInstallTimer): Added.
(WebCore::InspectorTimelineAgent::didRemoveTimer): Added.
(WebCore::InspectorTimelineAgent::willFireTimer): Added.
(WebCore::InspectorTimelineAgent::didFireTimer): Added.
(WebCore::InspectorTimelineAgent::addItemToTimeline): Added.
(WebCore::InspectorTimelineAgent::didCompleteCurrentTimelineItem): Renamed.
* inspector/InspectorTimelineAgent.h:
(WebCore::):
* inspector/TimelineItemFactory.cpp: Add methods for timer-related ScriptObjects.
(WebCore::TimelineItemFactory::createGenericTimerTimelineItem):
(WebCore::TimelineItemFactory::createTimerInstallTimelineItem):
* inspector/TimelineItemFactory.h:
* page/DOMTimer.cpp: Added instrumentation points.
(WebCore::DOMTimer::install):
(WebCore::DOMTimer::removeById):
(WebCore::DOMTimer::fired):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50068
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 26 Oct 2009 16:31:49 +0000 (16:31 +0000)]
2009-10-26 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/
6988966> Hardware layers do not show up in page snapshots
* WebView/WebHTMLViewPrivate.h:
* WebView/WebHTMLView.mm:
(-[WebHTMLView _compositingLayersHostingView]):
Add a private method that returns the NSView used to host compositing layers.
* platform/graphics/mac/Canvas3DLayer.h:
* platform/graphics/mac/Canvas3DLayer.mm:
(-[Canvas3DLayer copyImageSnapshotWithColorSpace:]):
Add a method that gets called when snapshotting Canvas3DLayers for page snapshots,
that allows the layer to return a CGImageRef of its contents.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50067
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 26 Oct 2009 16:22:46 +0000 (16:22 +0000)]
[Qt] Update outdated expected files which expected wrong color values.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.
* platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50066
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 26 Oct 2009 16:17:31 +0000 (16:17 +0000)]
2009-10-26 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Pass "console" as object group when evaluating selection.
https://bugs.webkit.org/show_bug.cgi?id=30738
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50065
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 26 Oct 2009 16:10:06 +0000 (16:10 +0000)]
2009-10-26 Keishi Hattori <casey.hattori@gmail.com>
Reviewed by Pavel Feldman.
Fix for Console not showing repeat count when repeatedly logging an Event
https://bugs.webkit.org/show_bug.cgi?id=30324
* inspector/console-tests-expected.txt:
2009-10-26 Keishi Hattori <casey.hattori@gmail.com>
Reviewed by Pavel Feldman.
Fix for Console not showing repeat count when repeatedly logging an Event
https://bugs.webkit.org/show_bug.cgi?id=30324
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::addToConsole):
(WebCore::ConsoleMessage::updateRepeatCountInConsole): Added.
* inspector/ConsoleMessage.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::addConsoleMessage): Calls updateRepeatCountInConsole if it is a repeating message.
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::addConsoleMessage): Renamed WebCore::InspectorFrontend::addMessageToConsole
(WebCore::InspectorFrontend::updateConsoleMessageRepeatCount): Added. Called when repeatCount is incremented.
* inspector/InspectorFrontend.h:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.addMessage): Removed calls to msg.isEqual.
(WebInspector.ConsoleView.prototype.updateMessageRepeatCount): Added.
(WebInspector.ConsoleView.prototype._incrementErrorWarningCount): Added. Updates the error/warning count.
(WebInspector.ConsoleView.prototype.clearMessages):
(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.prototype.toMessageElement): Use ConsoleMessage._updateRepeatCount
(WebInspector.ConsoleMessage.prototype._updateRepeatCount):
* inspector/front-end/inspector.js:
(WebInspector.addConsoleMessage): Renamed WebInspector.addMessageToConsole.
(WebInspector.updateConsoleMessageRepeatCount): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50064
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Mon, 26 Oct 2009 15:27:57 +0000 (15:27 +0000)]
2009-10-26 Eric Carlson <eric.carlson@apple.com>
Reviewed by Eric Seidel.
Remove HTML5 media element 'load' event
https://bugs.webkit.org/show_bug.cgi?id=30464
Part 1, change layout tests to not use the event.
* media/audio-constructor-autobuffer-expected.txt:
* media/audio-constructor-autobuffer.html:
* media/audio-constructor-expected.txt:
* media/audio-constructor-src-expected.txt:
* media/audio-constructor-src.html:
* media/audio-constructor.html:
* media/audio-controls-rendering.html:
* media/audio-data-url-expected.txt:
* media/audio-data-url.html:
* media/audio-mpeg-supported-expected.txt:
* media/audio-mpeg-supported.html:
* media/media-load-event-expected.txt:
* media/media-load-event.html:
* media/progress-event-expected.txt:
* media/progress-event-total-expected.txt:
* media/progress-event-total.html:
* media/progress-event.html:
* media/remove-from-document-expected.txt:
* media/remove-from-document-no-load-expected.txt:
* media/remove-from-document-no-load.html:
* media/remove-from-document.html:
* media/restore-from-page-cache-expected.txt:
* media/restore-from-page-cache.html:
* media/video-append-source-expected.txt:
* media/video-append-source.html:
* media/video-buffered-expected.txt:
* media/video-buffered.html:
* media/video-canvas-source-expected.txt:
* media/video-canvas-source.html:
* media/video-controls-expected.txt:
* media/video-controls-transformed-expected.txt:
* media/video-controls-transformed.html:
* media/video-controls-zoomed-expected.txt:
* media/video-controls-zoomed.html:
* media/video-controls.html:
* media/video-currentTime-expected.txt:
* media/video-currentTime-set-expected.txt:
* media/video-currentTime-set.html:
* media/video-currentTime-set2-expected.txt:
* media/video-currentTime-set2.html:
* media/video-currentTime.html:
* media/video-dom-src-expected.txt:
* media/video-dom-src.html:
* media/video-error-abort-expected.txt:
* media/video-error-abort.html:
* media/video-error-does-not-exist.html:
* media/video-muted-expected.txt:
* media/video-muted.html:
* media/video-no-autoplay-expected.txt:
* media/video-no-autoplay.html:
* media/video-seek-past-end-paused-expected.txt:
* media/video-seek-past-end-paused.html:
* media/video-seek-past-end-playing-expected.txt:
* media/video-seek-past-end-playing.html:
* media/video-seekable-expected.txt:
* media/video-seekable.html:
* media/video-seeking-expected.txt:
* media/video-seeking.html:
* media/video-src-change-expected.txt:
* media/video-src-change.html:
* media/video-volume-expected.txt:
* media/video-volume.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50063
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Mon, 26 Oct 2009 14:49:50 +0000 (14:49 +0000)]
crash with AX on when an image map contains an anchor tag
https://bugs.webkit.org/show_bug.cgi?id=30739
Reviewed by Darin Adler.
WebCore:
Tests: accessibility/crashing-a-tag-in-map.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::addChildren):
LayoutTests:
* accessibility/crashing-a-tag-in-map-expected.txt: Added.
* accessibility/crashing-a-tag-in-map.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50062
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Mon, 26 Oct 2009 13:51:29 +0000 (13:51 +0000)]
2009-10-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Update documentation control files for 1.1.16.
* docs/webkitgtk-docs.sgml:
* docs/webkitgtk-sections.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50061
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Mon, 26 Oct 2009 13:49:48 +0000 (13:49 +0000)]
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=30759
[GTK] Should use WebKitNetworkResponse, and expose it
WebKitDownload now uses our WebKitNetworkResponse instead of using
ResourceResponse directly. By exposing the response, like we do
with the request, we give our users the ability to look at the
response headers, status code, and so on, through the SoupMessage
object.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50060
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Mon, 26 Oct 2009 13:25:11 +0000 (13:25 +0000)]
2009-10-26 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Update for 1.1.16 release.
* configure.ac:
WebKit/gtk:
2009-10-26 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Update for 1.1.16 release.
* NEWS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50059
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 26 Oct 2009 13:06:03 +0000 (13:06 +0000)]
2009-10-26 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Reintroduce QWebElementCollection
Revert the patch that has replaced QWebElementCollection
with QList<QWebElement>. Update the tests accordingly.
Remove the constness of the return type of QWebElement operator[].
https://bugs.webkit.org/show_bug.cgi?id=30767
* Api/qwebelement.cpp:
(QWebElement::findAll):
(QWebElementCollectionPrivate::QWebElementCollectionPrivate):
(QWebElementCollectionPrivate::create):
(QWebElementCollection::QWebElementCollection):
(QWebElementCollection::operator=):
(QWebElementCollection::~QWebElementCollection):
(QWebElementCollection::operator+):
(QWebElementCollection::append):
(QWebElementCollection::count):
(QWebElementCollection::at):
(QWebElementCollection::toList):
* Api/qwebelement.h:
(const_iterator::begin):
(const_iterator::end):
(const_iterator::operator[]):
* Api/qwebframe.cpp:
(QWebFrame::findAllElements):
* Api/qwebframe.h:
* QtLauncher/main.cpp:
(MainWindow::selectElements):
* tests/qwebelement/tst_qwebelement.cpp:
(tst_QWebElement::simpleCollection):
(tst_QWebElement::iteration):
(tst_QWebElement::emptyCollection):
(tst_QWebElement::appendCollection):
(tst_QWebElement::nullSelect):
(tst_QWebElement::hasSetFocus):
(tst_QWebElement::render):
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::inputMethods):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50058
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benm@google.com [Mon, 26 Oct 2009 12:44:53 +0000 (12:44 +0000)]
Adds feature ENABLE guards to V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=30697
Patch by Steve Block <steveblock@google.com> on 2009-10-26
Reviewed by Eric Seidel.
This adds guards for the following features to the V8 bindings,
to allow builds with V8 to succeed when these features are not enabled.
- DATABASE
- WORKERS
- SHARED_WORKERS
- SVG
- XPATH
- XSLT
- INSPECTOR
This is a build fix only, no new tests required.
* bindings/v8/DOMObjectsInclude.h: Modified.
* bindings/v8/DerivedSourcesAllInOne.cpp: Modified.
* bindings/v8/V8Index.cpp: Modified.
* bindings/v8/V8Index.h: Modified.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50057
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 26 Oct 2009 12:32:10 +0000 (12:32 +0000)]
Rubber-stamped by Tor Arne Vestbø.
Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-26
http/tests/cookies/simple-cookies-max-age.html moved to flakey tests group.
http/tests/xmlhttprequest/workers/close.html added to flakey tests group.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50056
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 26 Oct 2009 11:58:58 +0000 (11:58 +0000)]
Unreviewed trivial fix for r49854.
Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-26
* platform/qt/Skipped: Missing html extension added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50055
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 26 Oct 2009 11:42:42 +0000 (11:42 +0000)]
2009-10-26 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25679
[Gtk] Improve accessibility of focusable lists
Fixes the issues with the Atk states exposed for ListBoxOption
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(setAtkStateSetFromCoreObject):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50054
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 26 Oct 2009 11:35:25 +0000 (11:35 +0000)]
2009-10-26 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=27085
[Gtk] Incorrect rendering of list
Adds a way for platforms to indicate that a particular object
should not be ignored.
* accessibility/AccessibilityObject.h:
* accessibility/chromium/AccessibilityObjectChromium.cpp:
* accessibility/gtk/AccessibilityObjectAtk.cpp:
* accessibility/mac/AccessibilityObjectMac.mm:
* accessibility/qt/AccessibilityObjectQt.cpp:
* accessibility/win/AccessibilityObjectWin.cpp:
* accessibility/wx/AccessibilityObjectWx.cpp:
(AccessibilityObject::accessibilityPlatformIncludesObject):
* accessibility/AccessibilityRenderObject.cpp:
(AccessibilityRenderObject::accessibilityIsIgnored):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50053
268f45cc-cd09-0410-ab3c-
d52691b4dbfc