WebKit-https.git
11 years agoWebKit: [qt] Better check for the declarative plugin inclusion.
hausmann@webkit.org [Fri, 18 Jun 2010 09:18:04 +0000 (09:18 +0000)]
WebKit: [qt] Better check for the declarative plugin inclusion.

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

* WebKit.pro:

WebKit/qt: [Qt] Change the target path to QtWebKit.

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

* declarative/declarative.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMove isAvailable()/setIsAvailable() from Database/DatabaseSync to AbstractDatabase.
dumi@chromium.org [Fri, 18 Jun 2010 09:16:22 +0000 (09:16 +0000)]
Move isAvailable()/setIsAvailable() from Database/DatabaseSync to AbstractDatabase.
https://bugs.webkit.org/show_bug.cgi?id=39041

Reviewed by Adam Barth.

WebCore:

* WebCore.base.exp
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::openDatabaseEnabled):
(WebCore::RuntimeEnabledFeatures::openDatabaseSyncEnabled):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::openDatabase):
* storage/AbstractDatabase.cpp:
(WebCore::AbstractDatabase::isAvailable):
(WebCore::AbstractDatabase::setIsAvailable):
* storage/AbstractDatabase.h:
* storage/Database.cpp:
* storage/Database.h:
* storage/DatabaseSync.cpp:
* storage/DatabaseSync.h:
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::openDatabase):
(WebCore::WorkerContext::openDatabaseSync):
* workers/WorkerContext.h:

WebKit/chromium:

* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableDatabase):
(WebKit::WebRuntimeFeatures::isDatabaseEnabled):

WebKit/gtk:

* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
(webkit_get_cache_model):

WebKit/mac:

* WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]):

WebKit/qt:

* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):

WebKit/win:

* WebView.cpp:
(WebView::notifyPreferencesChanged):

WebKit/wx:

* WebView.cpp:
(wxWebView::SetDatabasesEnabled):
(wxWebView::AreDatabasesEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 18 Jun 2010 09:01:04 +0000 (09:01 +0000)]
2010-06-18  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Try to turn Gtk 32-bit Linux Debug green again.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 18 Jun 2010 08:58:22 +0000 (08:58 +0000)]
2010-06-18  Adam Barth  <abarth@webkit.org>

        Rubber-stamped by Eric Seidel.

        Fix the namespace indent for HTML5Lexer.  This patch changes
        white-space only.

        * html/HTML5Lexer.h:
        (WebCore::HTML5Lexer::):
        (WebCore::HTML5Lexer::lineNumber):
        (WebCore::HTML5Lexer::columnNumber):
        (WebCore::HTML5Lexer::state):
        (WebCore::HTML5Lexer::setState):
        (WebCore::HTML5Lexer::skipLeadingNewLineForListing):
        (WebCore::HTML5Lexer::InputStreamPreprocessor::InputStreamPreprocessor):
        (WebCore::HTML5Lexer::InputStreamPreprocessor::nextInputCharacter):
        (WebCore::HTML5Lexer::InputStreamPreprocessor::peek):
        (WebCore::HTML5Lexer::InputStreamPreprocessor::advance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed test breakage fix.
ukai@chromium.org [Fri, 18 Jun 2010 08:28:00 +0000 (08:28 +0000)]
Unreviewed test breakage fix.

WebSocket: resume should not process buffer if already processing.
https://bugs.webkit.org/show_bug.cgi?id=39340

MessageLoop runs in main thread, so we don't need to use timer in worker thread.
Also, we should not use Timer in worker thread.

* websockets/ThreadableWebSocketChannelClientWrapper.h:
(WebCore::ThreadableWebSocketChannelClientWrapper::resume):
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Fri, 18 Jun 2010 06:58:58 +0000 (06:58 +0000)]
2010-06-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r61379.
        http://trac.webkit.org/changeset/61379
        https://bugs.webkit.org/show_bug.cgi?id=40813

        Broke multiple tests on all platforms (Requested by tkent on
        #webkit).

        * bindings/scripts/CodeGenerator.pm:
        * bindings/scripts/CodeGeneratorCPP.pm:
        * bindings/scripts/CodeGeneratorGObject.pm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/scripts/test/CPP/WebDOMTestObj.cpp:
        (WebDOMTestObj::attrWithException):
        (WebDOMTestObj::setAttrWithException):
        (WebDOMTestObj::attrWithSetterException):
        (WebDOMTestObj::attrWithGetterException):
        (WebDOMTestObj::setAttrWithGetterException):
        * bindings/scripts/test/CPP/WebDOMTestObj.h:
        * bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
        (webkit_dom_test_callback_callback_with_class1param):
        (webkit_dom_test_callback_callback_with_class2param):
        (webkit_dom_test_callback_callback_with_non_bool_return_type):
        * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
        (webkit_dom_test_obj_void_method):
        (webkit_dom_test_obj_void_method_with_args):
        (webkit_dom_test_obj_int_method):
        (webkit_dom_test_obj_int_method_with_args):
        (webkit_dom_test_obj_obj_method):
        (webkit_dom_test_obj_obj_method_with_args):
        (webkit_dom_test_obj_method_that_requires_all_args):
        (webkit_dom_test_obj_method_that_requires_all_args_and_throws):
        (webkit_dom_test_obj_serialized_value):
        (webkit_dom_test_obj_method_with_exception):
        (webkit_dom_test_obj_with_dynamic_frame):
        (webkit_dom_test_obj_with_dynamic_frame_and_arg):
        (webkit_dom_test_obj_with_dynamic_frame_and_optional_arg):
        (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture):
        (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture_asad):
        (webkit_dom_test_obj_with_script_state_void):
        (webkit_dom_test_obj_with_script_state_obj):
        (webkit_dom_test_obj_with_script_state_void_exception):
        (webkit_dom_test_obj_with_script_state_obj_exception):
        (webkit_dom_test_obj_with_script_execution_context):
        (webkit_dom_test_obj_method_with_optional_arg):
        (webkit_dom_test_obj_method_with_non_optional_arg_and_optional_arg):
        (webkit_dom_test_obj_method_with_non_optional_arg_and_two_optional_args):
        (webkit_dom_test_obj_get_read_only_int_attr):
        (webkit_dom_test_obj_get_read_only_string_attr):
        (webkit_dom_test_obj_get_read_only_test_obj_attr):
        (webkit_dom_test_obj_get_int_attr):
        (webkit_dom_test_obj_set_int_attr):
        (webkit_dom_test_obj_get_long_long_attr):
        (webkit_dom_test_obj_set_long_long_attr):
        (webkit_dom_test_obj_get_unsigned_long_long_attr):
        (webkit_dom_test_obj_set_unsigned_long_long_attr):
        (webkit_dom_test_obj_get_string_attr):
        (webkit_dom_test_obj_set_string_attr):
        (webkit_dom_test_obj_get_test_obj_attr):
        (webkit_dom_test_obj_set_test_obj_attr):
        (webkit_dom_test_obj_get_attr_with_exception):
        (webkit_dom_test_obj_set_attr_with_exception):
        (webkit_dom_test_obj_get_attr_with_setter_exception):
        (webkit_dom_test_obj_set_attr_with_setter_exception):
        (webkit_dom_test_obj_get_attr_with_getter_exception):
        (webkit_dom_test_obj_set_attr_with_getter_exception):
        (webkit_dom_test_obj_get_script_string_attr):
        (webkit_dom_test_obj_get_conditional_attr1):
        (webkit_dom_test_obj_set_conditional_attr1):
        (webkit_dom_test_obj_get_conditional_attr2):
        (webkit_dom_test_obj_set_conditional_attr2):
        (webkit_dom_test_obj_get_conditional_attr3):
        (webkit_dom_test_obj_set_conditional_attr3):
        (webkit_dom_test_obj_get_description):
        (webkit_dom_test_obj_get_id):
        (webkit_dom_test_obj_set_id):
        (webkit_dom_test_obj_get_hash):
        (webkit_dom_test_obj_set_property):
        (webkit_dom_test_obj_get_property):
        (webkit_dom_test_obj_class_init):
        * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
        * bindings/scripts/test/JS/JSTestObj.cpp:
        (WebCore::):
        (WebCore::jsTestObjAttrWithException):
        (WebCore::jsTestObjAttrWithSetterException):
        (WebCore::jsTestObjAttrWithGetterException):
        (WebCore::setJSTestObjAttrWithException):
        (WebCore::setJSTestObjAttrWithGetterException):
        (WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
        * bindings/scripts/test/JS/JSTestObj.h:
        * bindings/scripts/test/ObjC/DOMTestObj.h:
        * bindings/scripts/test/ObjC/DOMTestObj.mm:
        (-[DOMTestObj attrWithException]):
        (-[DOMTestObj setAttrWithException:]):
        (-[DOMTestObj attrWithSetterException]):
        (-[DOMTestObj attrWithGetterException]):
        (-[DOMTestObj setAttrWithGetterException:]):
        * bindings/scripts/test/TestObj.idl:
        * bindings/scripts/test/V8/V8TestObj.cpp:
        (WebCore::TestObjInternal::attrWithExceptionAttrGetter):
        (WebCore::TestObjInternal::attrWithExceptionAttrSetter):
        (WebCore::TestObjInternal::attrWithSetterExceptionAttrGetter):
        (WebCore::TestObjInternal::attrWithGetterExceptionAttrGetter):
        (WebCore::TestObjInternal::attrWithGetterExceptionAttrSetter):
        (WebCore::TestObjInternal::overloadedMethodCallback):
        (WebCore::):
        * dom/Element.cpp:
        * dom/Element.h:
        * html/HTMLAnchorElement.idl:
        * html/HTMLAppletElement.idl:
        * html/HTMLAreaElement.idl:
        * html/HTMLBRElement.idl:
        * html/HTMLBaseElement.idl:
        * html/HTMLBaseFontElement.idl:
        * html/HTMLBlockquoteElement.idl:
        * html/HTMLBodyElement.idl:
        * html/HTMLButtonElement.idl:
        * html/HTMLDListElement.idl:
        * html/HTMLDirectoryElement.idl:
        * html/HTMLDivElement.idl:
        * html/HTMLElement.idl:
        * html/HTMLEmbedElement.idl:
        * html/HTMLFontElement.idl:
        * html/HTMLFormElement.idl:
        * html/HTMLFrameElement.idl:
        * html/HTMLFrameSetElement.idl:
        * html/HTMLHRElement.idl:
        * html/HTMLHeadElement.idl:
        * html/HTMLHeadingElement.idl:
        * html/HTMLHtmlElement.idl:
        * html/HTMLIFrameElement.idl:
        * html/HTMLImageElement.idl:
        * html/HTMLInputElement.idl:
        * html/HTMLIsIndexElement.idl:
        * html/HTMLLIElement.idl:
        * html/HTMLLabelElement.idl:
        * html/HTMLLegendElement.idl:
        * html/HTMLLinkElement.idl:
        * html/HTMLMapElement.idl:
        * html/HTMLMediaElement.idl:
        * html/HTMLMenuElement.idl:
        * html/HTMLMetaElement.idl:
        * html/HTMLModElement.idl:
        * html/HTMLOListElement.idl:
        * html/HTMLObjectElement.idl:
        * html/HTMLOptGroupElement.idl:
        * html/HTMLOptionElement.idl:
        * html/HTMLParagraphElement.idl:
        * html/HTMLParamElement.idl:
        * html/HTMLPreElement.idl:
        * html/HTMLQuoteElement.idl:
        * html/HTMLScriptElement.idl:
        * html/HTMLStyleElement.idl:
        * html/HTMLTableCaptionElement.idl:
        * html/HTMLTableCellElement.idl:
        * html/HTMLTableColElement.idl:
        * html/HTMLTableElement.idl:
        * html/HTMLTableRowElement.idl:
        * html/HTMLTableSectionElement.idl:
        * html/HTMLTextAreaElement.idl:
        * html/HTMLUListElement.idl:
        * html/HTMLVideoElement.idl:
        * svg/SVGElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Rob Buis <rwlbuis@gmail.com>
rwlbuis@webkit.org [Fri, 18 Jun 2010 06:42:23 +0000 (06:42 +0000)]
2010-06-17  Rob Buis  <rwlbuis@gmail.com>

        Reviewed by Dave Hyatt.

        CSS3 "Property is declared twice in rule" test fails
        https://bugs.webkit.org/show_bug.cgi?id=36282

        Filter out duplicate properties in style declaration.

        Test: fast/css/duplicate-property-in-rule.html

        * css/CSSMutableStyleDeclaration.cpp: Filter out duplicate properties
        (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue): Discard negative padding values
        * css/CSSStyleSelector.cpp: Remove negative padding check
        (WebCore::CSSStyleSelector::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 18 Jun 2010 06:11:23 +0000 (06:11 +0000)]
2010-06-17  MORITA Hajime  <morrita@google.com>

        Unreviewed. Fixed a path of meter-element.html on Skipped list.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdding a test case to change-version.html + minor clean-ups.
dumi@chromium.org [Fri, 18 Jun 2010 06:05:50 +0000 (06:05 +0000)]
Adding a test case to change-version.html + minor clean-ups.
https://bugs.webkit.org/show_bug.cgi?id=40604

Reviewed by Adam Barth.

* storage/change-version.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 18 Jun 2010 06:00:42 +0000 (06:00 +0000)]
2010-06-17  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        * platform/chromium/test_expectations.txt:
          Update <meter> tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 18 Jun 2010 05:57:39 +0000 (05:57 +0000)]
2010-06-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Implement additional DOM attribute reflection for bindings
        https://bugs.webkit.org/show_bug.cgi?id=39936

        - Added support for [Reflect] for long, unsigned long, and boolean
          attributes.
        - Fixed code that set attributes like this: <video controls="controls">
          to instead set them like this: <video controls>.
        - Added lots more uses of [Reflect].
        - Removed now-unneeded [ConvertFromString].
        - Made [Reflect] imply [ConvertNullToNullString] so we can get rid
          of most uses of the latter.
        - Made [Reflect] automatically lowercase the name of the reflected
          content attribute to minimize the need to specify a custom content
          attribute name.

        One thing this patch does *not* do is remove the unneeded functions
        in the various DOM classes that are no longer used by the bindings.
        We should do that in a followup.

        * bindings/scripts/CodeGenerator.pm: Added new functions so code
        can be shared across bindings, GetterExpressionPrefix and
        SetterExpressionPrefix. We can do a lot more refactoring like
        this in the future.

        * bindings/scripts/CodeGeneratorCPP.pm: Removed unneeded
        ConvertFromString handling, changed to use the new
        GetterExpressionPrefix and SetterExpressionPrefix functions
        to better handle reflected DOM attributes.

        * bindings/scripts/CodeGeneratorGObject.pm: Removed unneeded
        ConvertFromString handling, changed to use the new
        GetterExpressionPrefix and SetterExpressionPrefix functions
        to better handle reflected DOM attributes. Fixed a few things
        in the output so the .cpp file will have more WebKit style.
        The .h file should be GTK style, but the .cpp file can be the
        standard WebKit style eventually.

        * bindings/scripts/CodeGeneratorJS.pm: Changed to use the new
        GetterExpressionPrefix and SetterExpressionPrefix functions
        and removed a now-unneeded IsSVGAnimatedType special case since
        the new functions take care of it. Made reflected attributes
        automatically convert null to the null string without a
        separate ConvertNullToNullString attribute.

        * bindings/scripts/CodeGeneratorObjC.pm: Changed to use the new
        GetterExpressionPrefix and SetterExpressionPrefix functions
        and removed a now-unneeded IsSVGAnimatedType special case since
        the new functions take care of it. Redid the special cases for
        ownerDocument and for operator to fit better with the new code
        paths. Removed unneeded ConvertFromString handling.

        * bindings/scripts/CodeGeneratorV8.pm: Changed to use the new
        GetterExpressionPrefix and SetterExpressionPrefix functions
        and removed a now-unneeded IsSVGAnimatedType special case since
        the new functions take care of it. Made reflected attributes
        automatically convert null to the null string without a
        separate ConvertNullToNullString attribute.

        * bindings/scripts/test/TestObj.idl: Added some test cases for
        content attribute reflection and for exceptions in string-typed
        attributes.

        * bindings/scripts/test/CPP/WebKitDOMTestObj.cpp: Updated.
        * bindings/scripts/test/CPP/WebKitDOMTestObj.h: Ditto.
        * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
        * bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
        * bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
        * bindings/scripts/test/JS/JSTestObj.h: Ditto.
        * bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
        * bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
        * bindings/scripts/test/V8/V8TestObj.cpp: Ditto.

        * dom/Element.cpp:
        (WebCore::Element::getIntegralAttribute): Added.
        (WebCore::Element::setIntegralAttribute): Added.
        (WebCore::Element::getUnsignedIntegralAttribute): Added.
        (WebCore::Element::setUnsignedIntegralAttribute): Added.
        * dom/Element.h: Added new attribute get/set functions for bindings.

        * html/HTMLAnchorElement.idl:
        * html/HTMLAppletElement.idl:
        * html/HTMLAreaElement.idl:
        * html/HTMLBRElement.idl:
        * html/HTMLBaseElement.idl:
        * html/HTMLBaseFontElement.idl:
        * html/HTMLBlockquoteElement.idl:
        * html/HTMLBodyElement.idl:
        * html/HTMLButtonElement.idl:
        * html/HTMLDListElement.idl:
        * html/HTMLDirectoryElement.idl:
        * html/HTMLDivElement.idl:
        * html/HTMLElement.idl:
        * html/HTMLEmbedElement.idl:
        * html/HTMLFontElement.idl:
        * html/HTMLFormElement.idl:
        * html/HTMLFrameElement.idl:
        * html/HTMLFrameSetElement.idl:
        * html/HTMLHRElement.idl:
        * html/HTMLHeadElement.idl:
        * html/HTMLHeadingElement.idl:
        * html/HTMLHtmlElement.idl:
        * html/HTMLIFrameElement.idl:
        * html/HTMLImageElement.idl:
        * html/HTMLInputElement.idl:
        * html/HTMLIsIndexElement.idl:
        * html/HTMLLIElement.idl:
        * html/HTMLLabelElement.idl:
        * html/HTMLLegendElement.idl:
        * html/HTMLLinkElement.idl:
        * html/HTMLMapElement.idl:
        * html/HTMLMediaElement.idl:
        * html/HTMLMenuElement.idl:
        * html/HTMLMetaElement.idl:
        * html/HTMLModElement.idl:
        * html/HTMLOListElement.idl:
        * html/HTMLObjectElement.idl:
        * html/HTMLOptGroupElement.idl:
        * html/HTMLOptionElement.idl:
        * html/HTMLParagraphElement.idl:
        * html/HTMLParamElement.idl:
        * html/HTMLPreElement.idl:
        * html/HTMLQuoteElement.idl:
        * html/HTMLScriptElement.idl:
        * html/HTMLStyleElement.idl:
        * html/HTMLTableCaptionElement.idl:
        * html/HTMLTableCellElement.idl:
        * html/HTMLTableColElement.idl:
        * html/HTMLTableElement.idl:
        * html/HTMLTableRowElement.idl:
        * html/HTMLTableSectionElement.idl:
        * html/HTMLTextAreaElement.idl:
        * html/HTMLUListElement.idl:
        * html/HTMLVideoElement.idl:
        * svg/SVGElement.idl:
        Added more uses of [Reflect]. Got rid of uses of [ConvertNullToNullString] that
        are now unneeded since [Reflect] now implies that. Changed formatting to be
        simpler and consistent without all the lining up and multiple lines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 18 Jun 2010 05:48:31 +0000 (05:48 +0000)]
2010-06-17  MORITA Hajime  <morrita@google.com>

        Unreviewed. Disabled meter-element.html temporally.
        We need to rebaseline it.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 18 Jun 2010 05:35:39 +0000 (05:35 +0000)]
2010-06-17  MORITA Hajime  <morrita@google.com>

        Unreviewd, fixed a build break.

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::pseudoId):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-15 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 18 Jun 2010 05:13:19 +0000 (05:13 +0000)]
2010-06-15  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        <meter> should allow styling for each gauge-level and component
        https://bugs.webkit.org/show_bug.cgi?id=40280

        - Updated expectations because both rendering result, render tree structure,
          html.css was changed.

        * fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html: Added.
        * fast/dom/HTMLMeterElement/meter-styles.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
        * platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.checksum:
        * platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.png:
        * platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
        * platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
        * platform/win/Skipped:
2010-06-16  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        <meter> should allow styling for each gauge-level and component
        https://bugs.webkit.org/show_bug.cgi?id=40280

        - Introduced following new pseudo classes for <meter> element.

          - -webkit-meter-horizontal-bar
          - -webkit-meter-vertical-bar
          - -webkit-meter-horizontal-optimum-value
          - -webkit-meter-vertical-optimum-value
          - -webkit-meter-horizontal-suboptimal-value
          - -webkit-meter-vertical-suboptimal-value
          - -webkit-meter-horizontal-even-less-good-value
          - -webkit-meter-vertical-even-less-good-value

        - Introduced 2 shadow nodes for RenderMeter to handle CSS styling.
          one for bar part and another for value part.
        - Removed RenderTheme::paintMeter() implementation because it can be
          handled by styled painting without RenderTheme.
        - Pulled RenderIndicator up to super class from RenderProgress,
          then make RenderMeter a subclass of it.
        - Moved shadow related methods from RenderProgress to ShadowBlockElement
          to share it with RenderMeter.
        - Added rules for html.css for new pseudo classes.

        Tests: fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html
               fast/dom/HTMLMeterElement/meter-styles.html

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::pseudoId):
        (WebCore::nameToPseudoTypeMap):
        (WebCore::CSSSelector::extractPseudoType):
        * css/CSSSelector.h:
        (WebCore::CSSSelector::):
        * css/html.css:
        (meter::-webkit-meter-horizontal-bar):
        (meter::-webkit-meter-vertical-bar):
        (meter::-webkit-meter-horizontal-optimum-value):
        (meter::-webkit-meter-horizontal-suboptimal-value):
        (meter::-webkit-meter-horizontal-even-less-good-value):
        (meter::-webkit-meter-vertical-optimum-value):
        (meter::-webkit-meter-vertical-suboptimal-value):
        (meter::-webkit-meter-vertical-even-less-good-value):
        * rendering/RenderIndicator.cpp: Added.
        (WebCore::RenderIndicator::RenderIndicator):
        (WebCore::RenderIndicator::~RenderIndicator):
        (WebCore::RenderIndicator::layout):
        (WebCore::RenderIndicator::styleDidChange):
        (WebCore::RenderIndicator::updateFromElement):
        (WebCore::RenderIndicator::hasParts):
        (WebCore::RenderIndicator::requestLayoutForParts):
        * rendering/RenderIndicator.h: Added.
        (WebCore::RenderIndicator::requiresForcedStyleRecalcPropagation):
        * rendering/RenderMeter.cpp:
        (WebCore::RenderMeter::RenderMeter):
        (WebCore::RenderMeter::~RenderMeter):
        (WebCore::RenderMeter::layoutParts): Added.
        (WebCore::RenderMeter::shouldHaveParts): Added.
        (WebCore::RenderMeter::valueRatio): Added.
        (WebCore::RenderMeter::barPartRect): Added.
        (WebCore::RenderMeter::valuePartRect): Added.
        (WebCore::RenderMeter::isHorizontal): Added.
        (WebCore::RenderMeter::valuePseudoId): Added.
        (WebCore::RenderMeter::barPseudoId): Added.
        (WebCore::RenderMeter::updatePartsState): Added.
        * rendering/RenderMeter.h:
        * rendering/RenderProgress.cpp:
        (WebCore::RenderProgress::RenderProgress):
        (WebCore::RenderProgress::updateFromElement):
        (WebCore::RenderProgress::paint):
        (WebCore::RenderProgress::layoutParts): Added.
        (WebCore::RenderProgress::shouldHaveParts): Added.
        (WebCore::RenderProgress::updatePartsState):
        (WebCore::RenderProgress::valuePartRect):
        * rendering/RenderProgress.h:
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::isControlStyled):
        (WebCore::RenderTheme::paintMeter):
        * rendering/RenderTheme.h:
        (WebCore::RenderTheme::supportsMeter): Added.
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::supportsMeter): Added.
        * rendering/ShadowElement.cpp:
        (WebCore::ShadowBlockElement::layoutAsPart): Added.
        (WebCore::ShadowBlockElement::updateStyleForPart): Added.
        (WebCore::ShadowBlockElement::createForPart): Added.
        (WebCore::ShadowBlockElement::createStyleForPart): Added.
        (WebCore::ShadowBlockElement::partShouldHaveStyle): Added.
        * rendering/ShadowElement.h:
        * rendering/style/RenderStyleConstants.h:
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Fri, 18 Jun 2010 04:30:17 +0000 (04:30 +0000)]
2010-06-17  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        WebSocket: resume should not process buffer if already processing.
        https://bugs.webkit.org/show_bug.cgi?id=39340

        Reviewed by Alexey Proskuryakov.

        * websocket/tests/alert-in-event-handler-expected.txt: Added.
        * websocket/tests/alert-in-event-handler.html: Added.
        * websocket/tests/script-tests/alert-in-event-handler.js: Added.
        * websocket/tests/send2_wsh.py: Added.
2010-06-17  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        WebSocket: resume should not process buffer if already processing.
        https://bugs.webkit.org/show_bug.cgi?id=39340

        Test: websocket/tests/alert-in-event-handler.html

        While running an event handler of WebSocket object, it may be suspended
        and resumed in various reason. e.g. alert() will suspend/resume
        ActiveDOM objects. In chromium, sending IPC message would also
        suspend/resume ActiveDOM objects.
        If resume process pending buffer in this case, another event might
        be fired while running the initial event handler.
        Thus, resume should not process pending buffer immediately.
        Pending buffer would be processed after the current task has been
        finished.

        * websockets/ThreadableWebSocketChannelClientWrapper.h:
        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::WebSocketChannel):
        (WebCore::WebSocketChannel::resume):
         Just set one shot timer for resumeTimerFired() if not yet set.
        (WebCore::WebSocketChannel::resumeTimerFired):
         Process pending event after resume was called.
        * websockets/WebSocketChannel.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 18 Jun 2010 04:14:08 +0000 (04:14 +0000)]
2010-06-17  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        REGRESSION(HTML5 parser): editing/selection/leave-requested-block.html can fail or crash
        https://bugs.webkit.org/show_bug.cgi?id=40764

        HTML5ScriptRunner was careful to only call CachedResource::addClient
        for cases where the resource was not already loaded.  This was to
        avoid getting synchronous notifyFinished callbacks from inside
        addClient.  (The old HTMLDocumentParser also has hacks to work around
        addClient's synchronous notifyFinished behavior for already-loaded
        resources as well.)

        It turns out that CachedResource will mark itself as purgeable if it
        has no clients, thus it could have its data cleared (but itself not
        deleted) in the case where we yield back to the runloop to wait for
        CSS to load before executing the loaded script.

        The fix is to act more like the old parser and always call addClient
        on every CachedScript we load.  But unlike the old parser, we're
        careful not to re-enter from addClient -> notifyFinished
        using guards in HTML5DocumentParser::watchForLoad.

        I do not know how to make a CachedResource purge itself
        from a LayoutTest, so this is not currently testable.
        If anyone knows how I'm happy to make a test.

        * html/HTML5DocumentParser.cpp:
        (WebCore::HTML5DocumentParser::watchForLoad):
         - It is now expected to call watchForLoad with a loaded script.
        (WebCore::HTML5DocumentParser::notifyFinished):
         - Now that watchForLoad is called with loaded scripts, notifyFinished
           may be be called from addClient, thus we may be in the middle of
           script execution when it's called.  It's OK.  We pass the call
           along to HTML5ScriptRunner::executeScriptsWaitingForLoad
           and it knows how to ignore the call in that case.
        * html/HTML5DocumentParser.h:
         - Document these member variables more.
        * html/HTML5ScriptRunner.cpp:
        (WebCore::HTML5ScriptRunner::~HTML5ScriptRunner):
        (WebCore::HTML5ScriptRunner::executePendingScript):
        (WebCore::HTML5ScriptRunner::hasScriptsWaitingForLoad):
        (WebCore::HTML5ScriptRunner::watchForLoad):
         - Set the pending script to RegisteringForWatch state before
           watching and WatchingForLoad after.
        (WebCore::HTML5ScriptRunner::stopWatchingForLoad):
         - Set the pending script to NotWatchingForLoad.
        (WebCore::HTML5ScriptRunner::executeScriptsWaitingForLoad):
         - Assert that callers checked hasScriptsWaitingForLoad()
        (WebCore::HTML5ScriptRunner::requestScript):
        * html/HTML5ScriptRunner.h:
        (WebCore::HTML5ScriptRunner::PendingScript::):
        (WebCore::HTML5ScriptRunner::PendingScript::PendingScript):
        (WebCore::HTML5ScriptRunner::PendingScript::watchingForLoad):
        * html/HTML5ScriptRunnerHost.h:
         - Document the new expectations of watchForLoad

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 18 Jun 2010 04:02:54 +0000 (04:02 +0000)]
2010-06-17  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        * platform/chromium/test_expectations.txt:
          Some tests in fast/repaint/ work fine on Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Tony Gentilcore <tonyg@chromium.org>
abarth@webkit.org [Fri, 18 Jun 2010 03:40:42 +0000 (03:40 +0000)]
2010-06-17  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Eric Seidel.

        Prevent HTML5PreloadScanner from loading resources in <noscript> tags.
        https://bugs.webkit.org/show_bug.cgi?id=40779

        No new tests. Will create a layout test in a subsequent patch.

        * html/HTML5PreloadScanner.cpp:
        (WebCore::HTML5PreloadScanner::processToken):
        * html/HTML5TreeBuilder.cpp:
        (WebCore::HTML5TreeBuilder::adjustedLexerState):
        (WebCore::HTML5TreeBuilder::passTokenToLegacyParser):
        (WebCore::HTML5TreeBuilder::isScriptingFlagEnabled):
        * html/HTML5TreeBuilder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Fri, 18 Jun 2010 02:53:32 +0000 (02:53 +0000)]
2010-06-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r61368.
        http://trac.webkit.org/changeset/61368
        https://bugs.webkit.org/show_bug.cgi?id=40806

        Well, actually, it still fails :( (Requested by abarth on
        #webkit).

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 18 Jun 2010 02:48:27 +0000 (02:48 +0000)]
2010-06-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        HTML5PreloadScanner parses <script> in DataState
        https://bugs.webkit.org/show_bug.cgi?id=40804

        The ScriptDataState is handled separately from the rest of the lexer
        state changes because it's more complicted in the tree builder.  The
        easiest thing is to just handle it separately in the preloader too.

        * html/HTML5PreloadScanner.cpp:
        (WebCore::HTML5PreloadScanner::processToken):
2010-06-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        HTML5PreloadScanner parses <script> in DataState
        https://bugs.webkit.org/show_bug.cgi?id=40804

        Remove the aforementioned hack that was working around this bug.  As a
        nice side effect, we get test coverage for this bug.  :)

        * fast/preloader/image.html:
        * fast/preloader/link.html:
        * fast/preloader/script.html:
        * fast/preloader/style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, test expectation fix.
tkent@chromium.org [Fri, 18 Jun 2010 02:39:55 +0000 (02:39 +0000)]
Unreviewed, test expectation fix.

* platform/chromium/test_expectations.txt: fast/preloader/*.html
fail because of no dumpResourceResponseMIMETypes(),
stripNullFromTextNodes.html have not failed recently.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 18 Jun 2010 02:31:18 +0000 (02:31 +0000)]
2010-06-17  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        I bet this test passes now.  :)

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 18 Jun 2010 02:21:25 +0000 (02:21 +0000)]
2010-06-17  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Skip fast/preloader tests on GTK and Qt because they don't implement
        dumpResourceResponseMIMETypes.

        * platform/gtk/Skipped:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 18 Jun 2010 02:01:00 +0000 (02:01 +0000)]
2010-06-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add CSS scanning to HTML5PreloadScanner
        https://bugs.webkit.org/show_bug.cgi?id=40802

        This patch just cribs the CSS preload scanning algorithm from the old
        preload scanner.  We also invented a way of testing the preload
        scanner.

        Tests: fast/preloader/image.html
               fast/preloader/link.html
               fast/preloader/script.html
               fast/preloader/style.html

        * Android.mk:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * html/CSSPreloadScanner.cpp: Added.
        (WebCore::isWhitespace):
        (WebCore::CSSPreloadScanner::CSSPreloadScanner):
        (WebCore::CSSPreloadScanner::reset):
        (WebCore::CSSPreloadScanner::scan):
        (WebCore::CSSPreloadScanner::tokenize):
        (WebCore::CSSPreloadScanner::emitRule):
        * html/CSSPreloadScanner.h: Added.
        (WebCore::CSSPreloadScanner::):
        * html/HTML5PreloadScanner.cpp:
        (WebCore::HTML5PreloadScanner::HTML5PreloadScanner):
        (WebCore::HTML5PreloadScanner::processToken):
        (WebCore::HTML5PreloadScanner::scanningBody):
        * html/HTML5PreloadScanner.h:
2010-06-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add CSS scanning to HTML5PreloadScanner
        https://bugs.webkit.org/show_bug.cgi?id=40802

        Add a testing framework for the preload scanner.  These test cover
        basic preloader behavior.  They have a small hack to work around a bug
        in the preload scanner discovered while writing the tests.  I'll fix
        the bug and remove the hack in a followup patch.

        * fast/preloader/image-expected.txt: Added.
        * fast/preloader/image.html: Added.
        * fast/preloader/link-expected.txt: Added.
        * fast/preloader/link.html: Added.
        * fast/preloader/resources/image1.png: Added.
        * fast/preloader/resources/link1.css: Added.
        * fast/preloader/resources/script1.js: Added.
        * fast/preloader/resources/style1.css: Added.
        * fast/preloader/script-expected.txt: Added.
        * fast/preloader/script.html: Added.
        * fast/preloader/style-expected.txt: Added.
        * fast/preloader/style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Abhishek Arya <inferno@chromium.org>
dpranke@chromium.org [Fri, 18 Jun 2010 01:24:21 +0000 (01:24 +0000)]
2010-06-17  Abhishek Arya  <inferno@chromium.org>

        Reviewed by David Kilzer.

        (Landed by Dirk Pranke).

        Check for a null frame before setting drag selection.
        https://bugs.webkit.org/show_bug.cgi?id=38893
        Same Layout test as https://bugs.webkit.org/show_bug.cgi?id=37168.

        Test: editing/pasteboard/drag-drop-iframe-refresh-crash.html

        Note that you need to run the test manually 20-30 times for the crash
        to reproduce.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Benjamin Poulain <benjamin.poulain@nokia.com>
eric@webkit.org [Fri, 18 Jun 2010 00:53:16 +0000 (00:53 +0000)]
2010-06-17  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Get rid of the the unused imageSize of ImageDecoderQt::internalHandleCurrentImage()
        https://bugs.webkit.org/show_bug.cgi?id=40620

        Remove an unused variable.

        * platform/graphics/qt/ImageDecoderQt.cpp:
        (WebCore::ImageDecoderQt::internalHandleCurrentImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Tony Chang <tony@chromium.org>
eric@webkit.org [Fri, 18 Jun 2010 00:39:39 +0000 (00:39 +0000)]
2010-06-17  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] cleanup redundant DEPS value and remove buildbot cleanup code
        https://bugs.webkit.org/show_bug.cgi?id=40615

        * DEPS: tools/data_pack was listed twice for linux (harmless, but unnecessary)
2010-06-17  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] cleanup redundant DEPS value and remove buildbot cleanup code
        https://bugs.webkit.org/show_bug.cgi?id=40615

        * Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix a race condition during startup where we would never send the InitializeConnectio...
andersca@apple.com [Fri, 18 Jun 2010 00:29:19 +0000 (00:29 +0000)]
Fix a race condition during startup where we would never send the InitializeConnection message to the server.

Reviewed by Sam Weinig.

* Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::open):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Jeremy Moskovich <jeremy@chromium.org>
eric@webkit.org [Fri, 18 Jun 2010 00:24:06 +0000 (00:24 +0000)]
2010-06-17  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium API] Implement WebSandboxSupport on OS X and add stubs to allow
        OOP loading of fonts.

        https://bugs.webkit.org/show_bug.cgi?id=40544

        * platform/chromium/ChromiumBridge.h: Add prototype for loadFont()
2010-06-17  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium API] Implement WebSandboxSupport on OS X and add stubs to allow
        OOP loading of fonts.

        https://bugs.webkit.org/show_bug.cgi?id=40544

        * WebKit.gyp: Add mac WebSandboxSupport.h
        * public/mac/WebSandboxSupport.h: Added.
        * src/ChromiumBridge.cpp:
        (WebCore::ChromiumBridge::loadFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Nicolas Weber <thakis@chromium.org>
eric@webkit.org [Fri, 18 Jun 2010 00:00:57 +0000 (00:00 +0000)]
2010-06-17  Nicolas Weber  <thakis@chromium.org>

        Reviewed by Eric Seidel.

        Fix various warnings that are reported when building with clang
        https://bugs.webkit.org/show_bug.cgi?id=40503

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::labelElementContainer):
        * accessibility/AccessibilityTableCell.cpp:
        (WebCore::AccessibilityTableCell::parentTable):
        * bindings/v8/NPV8Object.cpp:
        (WebCore::npObjectTypeInfo):
        * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
        (WebCore::):
        * bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
        (WebCore::):
        * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
        (WebCore::):
        * css/CSSStyleSheet.h:
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::getNamedElements):
        * inspector/InspectorValues.cpp:
        (WebCore::InspectorObject::getObject):
        (WebCore::InspectorObject::getArray):
        * page/animation/AnimationBase.h:
        * platform/graphics/BitmapImage.h:
        (WTF::):
        * platform/graphics/mac/FontPlatformData.h:
        * rendering/RenderBlock.h:
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::ellipsisBox):
        * storage/StorageNamespaceImpl.cpp:
        (WebCore::StorageNamespaceImpl::storageArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Thu, 17 Jun 2010 23:39:23 +0000 (23:39 +0000)]
2010-06-17  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Pavel Feldman.

        Add ENABLE(INSPECTOR) guard for m_sessionSettings
        https://bugs.webkit.org/show_bug.cgi?id=40611

        Build fix.

        * inspector/InspectorController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit2:
adachan@apple.com [Thu, 17 Jun 2010 23:28:41 +0000 (23:28 +0000)]
WebKit2:
        Rolling out http://trac.webkit.org/changeset/61297 due to build errors.

        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: Removed.
        * WebProcess/InjectedBundle/API/c/WKBundlePage.h: Removed.
        * WebProcess/InjectedBundle/InjectedBundlePageClient.cpp: Removed.
        * WebProcess/InjectedBundle/InjectedBundlePageClient.h: Removed.
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
        * WebProcess/WebPage/WebPage.cpp:
        * WebProcess/WebPage/WebPage.h:
        * mac/WebKit2.exp:
        * win/WebKit2.vcproj:

WebKitTools:
        Rolling out http://trac.webkit.org/changeset/61297 due to build errors.

        * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
        * MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c.
        * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 17 Jun 2010 23:25:48 +0000 (23:25 +0000)]
2010-06-17  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add FIXME to explain HTMLDocumentParser's forceSynchronous bool
        https://bugs.webkit.org/show_bug.cgi?id=40609

        No functional change, just adding comment.

        * dom/Document.cpp:
        (WebCore::Document::write):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 17 Jun 2010 23:25:08 +0000 (23:25 +0000)]
2010-06-17  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, Chromium expectations update.

        * platform/chromium-mac/fast/js/missing-title-end-tag-js-expected.checksum: Added.
        * platform/chromium-mac/fast/js/missing-title-end-tag-js-expected.png: Added.
        * platform/chromium-win-xp/fast/text/atsui-spacing-features-expected.checksum: Changed
        * platform/chromium-win-xp/fast/text/atsui-spacing-features-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Thu, 17 Jun 2010 23:04:33 +0000 (23:04 +0000)]
2010-06-17  Stephen White  <senorblanco@chromium.org>

        Unreviewed; expectations fix.

        This updates the pixel test baselines after r61341, and removes them
        from test_expectations.

        * platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
        * platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.png:
        * platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
        * platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
        * platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
        * platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
        * platform/chromium-linux/fast/backgrounds/size/backgroundSize11-expected.checksum: Added.
        * platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.checksum:
        * platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.png:
        * platform/chromium-linux/fast/backgrounds/size/backgroundSize16-expected.checksum:
        * platform/chromium-linux/fast/backgrounds/size/backgroundSize16-expected.png:
        * platform/chromium-linux/fast/backgrounds/size/backgroundSize19-expected.checksum: Added.
        * platform/chromium-linux/fast/backgrounds/size/backgroundSize22-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum: Removed.
        * platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
        * platform/chromium-linux/fast/css/value-list-out-of-bounds-crash-expected.checksum:
        * platform/chromium-linux/fast/css/value-list-out-of-bounds-crash-expected.png: Removed.
        * platform/chromium-linux/fast/events/pointer-events-2-expected.checksum:
        * platform/chromium-linux/fast/events/pointer-events-2-expected.png:
        * platform/chromium-linux/fast/forms/input-type-change-expected.checksum:
        * platform/chromium-linux/fast/forms/input-type-change-expected.png:
        * platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.checksum:
        * platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
        * platform/chromium-linux/fast/replaced/image-sizing-expected.checksum:
        * platform/chromium-linux/fast/replaced/image-sizing-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/bugs/bug101674-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug101674-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug11026-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug11026-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug14929-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug14929-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/bugs/bug2981-2-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug2981-2-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug4284-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug4284-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/bugs/bug625-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.png:
        * platform/chromium-linux/tables/mozilla/core/bloomberg-expected.checksum:
        * platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
        * platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
        * platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/core/misc-expected.checksum:
        * platform/chromium-linux/tables/mozilla/core/misc-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/other/cell_widths-expected.checksum:
        * platform/chromium-linux/tables/mozilla/other/cell_widths-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/bugs/97619-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Removed.
        * platform/chromium-mac/fast/backgrounds/size/backgroundSize16-expected.checksum: Removed.
        * platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
        * platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.png:
        * platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
        * platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
        * platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
        * platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize01-expected.checksum:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize01-expected.png:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.checksum:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.png:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.checksum:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.png:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize05-expected.checksum:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize05-expected.png:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.checksum:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.png:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize07-expected.checksum:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize07-expected.png:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize08-expected.checksum:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize08-expected.png:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize09-expected.checksum:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize09-expected.png:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize10-expected.checksum:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize10-expected.png:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize11-expected.checksum:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize11-expected.png:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize12-expected.checksum:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize12-expected.png:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.checksum:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.png:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.checksum:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.png:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.checksum:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.png:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize16-expected.checksum:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize16-expected.png:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.checksum:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.png:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.checksum:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.png:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.checksum:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.png:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize20-expected.checksum:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize20-expected.png:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize21-expected.checksum:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize21-expected.png:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.checksum:
        * platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.png:
        * platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum:
        * platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
        * platform/chromium-win/fast/css/value-list-out-of-bounds-crash-expected.checksum:
        * platform/chromium-win/fast/css/value-list-out-of-bounds-crash-expected.png:
        * platform/chromium-win/fast/events/pointer-events-2-expected.checksum:
        * platform/chromium-win/fast/events/pointer-events-2-expected.png:
        * platform/chromium-win/fast/forms/input-type-change-expected.checksum:
        * platform/chromium-win/fast/forms/input-type-change-expected.png:
        * platform/chromium-win/fast/replaced/absolute-image-sizing-expected.checksum:
        * platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
        * platform/chromium-win/fast/replaced/image-sizing-expected.checksum:
        * platform/chromium-win/fast/replaced/image-sizing-expected.png:
        * platform/chromium-win/tables/mozilla/bugs/bug101674-expected.checksum:
        * platform/chromium-win/tables/mozilla/bugs/bug101674-expected.png:
        * platform/chromium-win/tables/mozilla/bugs/bug11026-expected.checksum:
        * platform/chromium-win/tables/mozilla/bugs/bug11026-expected.png:
        * platform/chromium-win/tables/mozilla/bugs/bug1188-expected.checksum:
        * platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png:
        * platform/chromium-win/tables/mozilla/bugs/bug1296-expected.checksum:
        * platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
        * platform/chromium-win/tables/mozilla/bugs/bug1430-expected.checksum:
        * platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
        * platform/chromium-win/tables/mozilla/bugs/bug14929-expected.checksum:
        * platform/chromium-win/tables/mozilla/bugs/bug14929-expected.png:
        * platform/chromium-win/tables/mozilla/bugs/bug15544-expected.checksum:
        * platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
        * platform/chromium-win/tables/mozilla/bugs/bug2981-2-expected.checksum:
        * platform/chromium-win/tables/mozilla/bugs/bug2981-2-expected.png:
        * platform/chromium-win/tables/mozilla/bugs/bug4093-expected.checksum:
        * platform/chromium-win/tables/mozilla/bugs/bug4093-expected.png:
        * platform/chromium-win/tables/mozilla/bugs/bug4284-expected.checksum:
        * platform/chromium-win/tables/mozilla/bugs/bug4284-expected.png:
        * platform/chromium-win/tables/mozilla/bugs/bug4427-expected.checksum:
        * platform/chromium-win/tables/mozilla/bugs/bug4427-expected.png:
        * platform/chromium-win/tables/mozilla/bugs/bug56563-expected.checksum:
        * platform/chromium-win/tables/mozilla/bugs/bug56563-expected.png:
        * platform/chromium-win/tables/mozilla/bugs/bug625-expected.checksum:
        * platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
        * platform/chromium-win/tables/mozilla/bugs/bug6404-expected.checksum:
        * platform/chromium-win/tables/mozilla/bugs/bug6404-expected.png:
        * platform/chromium-win/tables/mozilla/bugs/bug97383-expected.checksum:
        * platform/chromium-win/tables/mozilla/bugs/bug97383-expected.png:
        * platform/chromium-win/tables/mozilla/core/bloomberg-expected.checksum:
        * platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
        * platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
        * platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
        * platform/chromium-win/tables/mozilla/core/misc-expected.checksum:
        * platform/chromium-win/tables/mozilla/core/misc-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
        * platform/chromium-win/tables/mozilla/other/cell_widths-expected.checksum:
        * platform/chromium-win/tables/mozilla/other/cell_widths-expected.png:
        * platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
        * platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.png:
        * platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
        * platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
        * platform/chromium/test_expectations.txt:
        * platform/mac-leopard/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum:
        * platform/mac-leopard/css2.1/t0804-c5510-padn-00-b-ag-expected.png:
        * platform/mac-leopard/tables/mozilla/bugs/bug1430-expected.checksum:
        * platform/mac-leopard/tables/mozilla/bugs/bug1430-expected.png:
        * platform/mac-leopard/tables/mozilla/bugs/bug14929-expected.checksum:
        * platform/mac-leopard/tables/mozilla/bugs/bug14929-expected.png:
        * platform/mac-leopard/tables/mozilla/bugs/bug23235-expected.checksum:
        * platform/mac-leopard/tables/mozilla/bugs/bug23235-expected.png:
        * platform/mac-leopard/tables/mozilla/bugs/bug2981-2-expected.checksum:
        * platform/mac-leopard/tables/mozilla/bugs/bug2981-2-expected.png:
        * platform/mac-leopard/tables/mozilla/bugs/bug4427-expected.checksum:
        * platform/mac-leopard/tables/mozilla/bugs/bug4427-expected.png:
        * platform/mac-leopard/tables/mozilla/bugs/bug6404-expected.checksum:
        * platform/mac-leopard/tables/mozilla/bugs/bug6404-expected.png:
        * platform/mac-leopard/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
        * platform/mac-leopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
        * platform/mac-leopard/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
        * platform/mac-leopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
        * platform/mac-leopard/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
        * platform/mac-leopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
        * platform/mac-leopard/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
        * platform/mac-leopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
        * platform/mac-leopard/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
        * platform/mac-leopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
        * platform/mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
        * platform/mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
        * platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
        * platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
        * platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
        * platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
        * platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
        * platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
        * platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
        * platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
        * platform/mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
        * platform/mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
        * platform/mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
        * platform/mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
        * platform/mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
        * platform/mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
        * platform/mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.checksum:
        * platform/mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.png:
        * platform/mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
        * platform/mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
        * platform/mac-leopard/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
        * platform/mac-leopard/tables/mozilla_expected_failures/bugs/97619-expected.png:
        * platform/mac/css2.1/t0905-c414-flt-01-d-g-expected.checksum:
        * platform/mac/css2.1/t0905-c414-flt-01-d-g-expected.png:
        * platform/mac/css2.1/t090501-c414-flt-02-d-g-expected.checksum:
        * platform/mac/css2.1/t090501-c414-flt-02-d-g-expected.png:
        * platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
        * platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.png:
        * platform/mac/css2.1/t090501-c414-flt-ln-01-d-g-expected.checksum:
        * platform/mac/css2.1/t090501-c414-flt-ln-01-d-g-expected.png:
        * platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
        * platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
        * platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
        * platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
        * platform/mac/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.checksum:
        * platform/mac/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.png:
        * platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum:
        * platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png:
        * platform/mac/css2.1/t1004-c5524-width-00-b-g-expected.checksum:
        * platform/mac/css2.1/t1004-c5524-width-00-b-g-expected.png:
        * platform/mac/css2.1/t100801-c544-valgn-02-d-agi-expected.checksum:
        * platform/mac/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
        * platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
        * platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
        * platform/mac/css2.1/t100801-c544-valgn-04-d-agi-expected.checksum:
        * platform/mac/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
        * platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.checksum:
        * platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
        * platform/mac/fast/backgrounds/size/backgroundSize01-expected.checksum:
        * platform/mac/fast/backgrounds/size/backgroundSize01-expected.png:
        * platform/mac/fast/backgrounds/size/backgroundSize05-expected.checksum:
        * platform/mac/fast/backgrounds/size/backgroundSize05-expected.png:
        * platform/mac/fast/backgrounds/size/backgroundSize06-expected.checksum:
        * platform/mac/fast/backgrounds/size/backgroundSize06-expected.png:
        * platform/mac/fast/backgrounds/size/backgroundSize07-expected.checksum:
        * platform/mac/fast/backgrounds/size/backgroundSize07-expected.png:
        * platform/mac/fast/backgrounds/size/backgroundSize08-expected.checksum:
        * platform/mac/fast/backgrounds/size/backgroundSize08-expected.png:
        * platform/mac/fast/backgrounds/size/backgroundSize09-expected.checksum:
        * platform/mac/fast/backgrounds/size/backgroundSize09-expected.png:
        * platform/mac/fast/backgrounds/size/backgroundSize10-expected.checksum:
        * platform/mac/fast/backgrounds/size/backgroundSize10-expected.png:
        * platform/mac/fast/backgrounds/size/backgroundSize11-expected.checksum:
        * platform/mac/fast/backgrounds/size/backgroundSize11-expected.png:
        * platform/mac/fast/backgrounds/size/backgroundSize12-expected.checksum:
        * platform/mac/fast/backgrounds/size/backgroundSize12-expected.png:
        * platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum:
        * platform/mac/fast/backgrounds/size/backgroundSize16-expected.png:
        * platform/mac/fast/backgrounds/size/backgroundSize17-expected.checksum:
        * platform/mac/fast/backgrounds/size/backgroundSize17-expected.png:
        * platform/mac/fast/backgrounds/size/backgroundSize18-expected.checksum:
        * platform/mac/fast/backgrounds/size/backgroundSize18-expected.png:
        * platform/mac/fast/backgrounds/size/backgroundSize19-expected.checksum:
        * platform/mac/fast/backgrounds/size/backgroundSize19-expected.png:
        * platform/mac/fast/backgrounds/size/backgroundSize20-expected.checksum:
        * platform/mac/fast/backgrounds/size/backgroundSize20-expected.png:
        * platform/mac/fast/backgrounds/size/backgroundSize21-expected.checksum:
        * platform/mac/fast/backgrounds/size/backgroundSize21-expected.png:
        * platform/mac/fast/backgrounds/size/backgroundSize22-expected.checksum:
        * platform/mac/fast/backgrounds/size/backgroundSize22-expected.png:
        * platform/mac/fast/backgrounds/size/zero-expected.checksum:
        * platform/mac/fast/backgrounds/size/zero-expected.png:
        * platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum:
        * platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
        * platform/mac/fast/canvas/canvas-as-image-expected.checksum:
        * platform/mac/fast/canvas/canvas-as-image-expected.png:
        * platform/mac/fast/css/value-list-out-of-bounds-crash-expected.checksum:
        * platform/mac/fast/css/value-list-out-of-bounds-crash-expected.png:
        * platform/mac/fast/forms/input-type-change-expected.checksum:
        * platform/mac/fast/forms/input-type-change-expected.png:
        * platform/mac/fast/replaced/001-expected.checksum:
        * platform/mac/fast/replaced/001-expected.png:
        * platform/mac/fast/replaced/002-expected.checksum:
        * platform/mac/fast/replaced/002-expected.png:
        * platform/mac/fast/replaced/003-expected.checksum:
        * platform/mac/fast/replaced/003-expected.png:
        * platform/mac/fast/replaced/absolute-image-sizing-expected.checksum:
        * platform/mac/fast/replaced/absolute-image-sizing-expected.png:
        * platform/mac/fast/replaced/image-sizing-expected.checksum:
        * platform/mac/fast/replaced/image-sizing-expected.png:
        * platform/mac/tables/mozilla/bugs/bug11026-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug11026-expected.png:
        * platform/mac/tables/mozilla/bugs/bug1188-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug1188-expected.png:
        * platform/mac/tables/mozilla/bugs/bug1296-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug1296-expected.png:
        * platform/mac/tables/mozilla/bugs/bug15544-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug15544-expected.png:
        * platform/mac/tables/mozilla/bugs/bug4093-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug4093-expected.png:
        * platform/mac/tables/mozilla/bugs/bug4284-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug4284-expected.png:
        * platform/mac/tables/mozilla/bugs/bug4523-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug4523-expected.png:
        * platform/mac/tables/mozilla/bugs/bug56563-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug56563-expected.png:
        * platform/mac/tables/mozilla/bugs/bug86708-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug86708-expected.png:
        * platform/mac/tables/mozilla/bugs/bug97383-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug97383-expected.png:
        * platform/mac/tables/mozilla/core/misc-expected.checksum:
        * platform/mac/tables/mozilla/core/misc-expected.png:
        * platform/mac/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
        * platform/mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
        * platform/mac/tables/mozilla/marvin/td_valign_middle-expected.checksum:
        * platform/mac/tables/mozilla/marvin/td_valign_middle-expected.png:
        * platform/mac/tables/mozilla/marvin/td_valign_top-expected.checksum:
        * platform/mac/tables/mozilla/marvin/td_valign_top-expected.png:
        * platform/mac/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
        * platform/mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
        * platform/mac/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
        * platform/mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
        * platform/mac/tables/mozilla/marvin/th_valign_middle-expected.checksum:
        * platform/mac/tables/mozilla/marvin/th_valign_middle-expected.png:
        * platform/mac/tables/mozilla/marvin/th_valign_top-expected.checksum:
        * platform/mac/tables/mozilla/marvin/th_valign_top-expected.png:
        * platform/mac/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
        * platform/mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
        * platform/mac/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
        * platform/mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
        * platform/mac/tables/mozilla/marvin/tr_valign_top-expected.checksum:
        * platform/mac/tables/mozilla/marvin/tr_valign_top-expected.png:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 17 Jun 2010 22:25:02 +0000 (22:25 +0000)]
2010-06-17  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, expectations update.

        Added pixel results for Chromium.

        * platform/chromium-win/fast/js/missing-title-end-tag-js-expected.checksum: Added.
        * platform/chromium-win/fast/js/missing-title-end-tag-js-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-13 Robert Hogan <robert@webkit.org>
robert@webkit.org [Thu, 17 Jun 2010 22:19:45 +0000 (22:19 +0000)]
2010-06-13  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        WebCore EventHandler needs to take account of onLoad events fired
        before layout() complete

        https://bugs.webkit.org/show_bug.cgi?id=40102

        WebCore 'cheats' by firing onLoad events before the frame's layout
        has been performed. This can result in event listeners performing
        operations that depend on the document's final layout, such as
        scrolling operations.

        When scrolling a frameview in eventhandler ensure the layout is complete.

        * platform/qt/Skipped: Unskip editing/input/page-up-down-scrolls.html
2010-06-13  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        WebCore EventHandler needs to take account of onLoad events
        fired before layout() complete

        https://bugs.webkit.org/show_bug.cgi?id=40102

        WebCore 'cheats' by firing onLoad events before the frame's layout
        has been performed. This can result in event listeners performing
        operations that depend on the document's final layout, such as
        scrolling operations.

        When scrolling a frameview in eventhandler ensure the layout is complete.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::scrollRecursively):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd the error codes defined in the async DB spec to SQLError.idl and SQLError.h.
dumi@chromium.org [Thu, 17 Jun 2010 22:06:01 +0000 (22:06 +0000)]
Add the error codes defined in the async DB spec to SQLError.idl and SQLError.h.
https://bugs.webkit.org/show_bug.cgi?id=40748

Reviewed by Dimitri Glazkov.

WebCore:

Test: storage/sql-error-codes.html

* storage/SQLError.h:
(WebCore::SQLError::):
* storage/SQLError.idl:
* storage/SQLStatement.cpp:
(WebCore::SQLStatement::execute):
(WebCore::SQLStatement::setDatabaseDeletedError):
(WebCore::SQLStatement::setVersionMismatchedError):
(WebCore::SQLStatement::setFailureDueToQuota):
(WebCore::SQLStatement::lastExecutionFailedDueToQuota):
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::deliverTransactionCallback):
(WebCore::SQLTransaction::handleCurrentStatementError):
(WebCore::SQLTransaction::deliverStatementCallback):
(WebCore::SQLTransaction::postflightAndCommit):

LayoutTests:

* platform/chromium/storage/sql-error-codes-expected.txt: Added.
* storage/sql-error-codes-expected.txt: Added.
* storage/sql-error-codes.html: Added.
* storage/sql-error-codes.js: Added.
(finishTest):
(transactionErrorCallback):
(transactionSuccessCallback):
(testTransaction):
(testTransactionThrowsException):
(testTransactionFailureBecauseOfStatementFailure):
(testInvalidStatement):
(testIncorrectNumberOfBindParameters):
(testBindParameterOfWrongType.badString.toString):
(testBindParameterOfWrongType):
(testQuotaExceeded):
(testVersionMismatch.db.transaction):
(testVersionMismatch):
(runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Robert Hogan <robert@webkit.org>
robert@webkit.org [Thu, 17 Jun 2010 21:41:50 +0000 (21:41 +0000)]
2010-06-17  Robert Hogan  <robert@webkit.org>

        [Qt] Build fix

        Unreviewed.

        Remove includes in qdeclarativewebview*.* that rely on an installation
        of QtWebKit.

        * declarative/qdeclarativewebview.cpp:
        * declarative/qdeclarativewebview_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 17 Jun 2010 21:32:33 +0000 (21:32 +0000)]
2010-06-17  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, expectations update.

        Updating Chromium expectations after http://trac.webkit.org/changeset/61128.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Thu, 17 Jun 2010 21:15:19 +0000 (21:15 +0000)]
2010-06-17  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Jian Li.

        Fix CRLF ending conversion in StringBlobItem.
        https://bugs.webkit.org/show_bug.cgi?id=40736
        Also: fix referencing uninitialized member bug and slice length bug
        in hybrid blob case.

        Tests will be added when we add BlobBuilder jsc bindings.

        * platform/BlobItem.cpp:
        (WebCore::StringBlobItem::convertToCString):
        (WebCore::DataRangeBlobItem::DataRangeBlobItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Robert Hogan <robert@webkit.org>
robert@webkit.org [Thu, 17 Jun 2010 20:59:09 +0000 (20:59 +0000)]
2010-06-17  Robert Hogan  <robert@webkit.org>

        Unreviewed, rolling out r61346.
        http://trac.webkit.org/changeset/61346
        https://bugs.webkit.org/show_bug.cgi?id=33333

        Broke inspector tests on Qt

        * platform/qt/Skipped:
2010-06-17  Robert Hogan  <robert@webkit.org>

        Unreviewed, rolling out r61346.
        http://trac.webkit.org/changeset/61346
        https://bugs.webkit.org/show_bug.cgi?id=33333

        Broke inspector tests on Qt

        * Api/qwebpage.cpp:
        (QWebPage::javaScriptConsoleMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 17 Jun 2010 20:44:28 +0000 (20:44 +0000)]
2010-06-17  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, expectations update.

        Removed obsolete Win XP expectations.

        * platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.checksum: Removed.
        * platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Robert Hogan <robert@webkit.org>
robert@webkit.org [Thu, 17 Jun 2010 20:39:04 +0000 (20:39 +0000)]
2010-06-17  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] pass plugins/open-and-close-window-with-plugin.html on Qt

        Capture logDestroy messages from the test plugin. DRT's WebPage
        is already destroyed by the time they are emitted.

        https://bugs.webkit.org/show_bug.cgi?id=33333

        Unskip:
        plugins/open-and-close-window-with-plugin.html
        plugins/geturlnotify-during-document-teardown.html

        * platform/qt/Skipped:
2010-06-17  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] pass plugins/open-and-close-window-with-plugin.html on Qt

        Capture logDestroy messages from the test plugin. DRT's WebPage
        is already destroyed by the time they are emitted.

        https://bugs.webkit.org/show_bug.cgi?id=33333

        Unskip:
        plugins/open-and-close-window-with-plugin.html
        plugins/geturlnotify-during-document-teardown.html

        * Api/qwebpage.cpp:
        (QWebPage::javaScriptConsoleMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 17 Jun 2010 20:28:01 +0000 (20:28 +0000)]
2010-06-17  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, rolling out r61340.
        http://trac.webkit.org/changeset/61340
        https://bugs.webkit.org/show_bug.cgi?id=36282

        Broke several editing tests.

        * fast/css/duplicate-property-in-rule-expected.txt: Removed.
        * fast/css/duplicate-property-in-rule.html: Removed.
2010-06-17  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, rolling out r61340.
        http://trac.webkit.org/changeset/61340
        https://bugs.webkit.org/show_bug.cgi?id=36282

        Broke several editing tests.

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 17 Jun 2010 20:25:45 +0000 (20:25 +0000)]
2010-06-17  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, expectations update.

        More clean up from the HTML5 parser spin-up.

        * platform/chromium-linux/fast/dom/stripNullFromTextNodes-expected.txt: Removed.
        * platform/chromium-mac/css1/box_properties/float_elements_in_series-expected.checksum:
        * platform/chromium-mac/css1/box_properties/float_elements_in_series-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd optional contentType parameter to Blob.slice per latest File API spec.
jianli@chromium.org [Thu, 17 Jun 2010 20:14:28 +0000 (20:14 +0000)]
Add optional contentType parameter to Blob.slice per latest File API spec.
https://bugs.webkit.org/show_bug.cgi?id=40647

Reviewed by David Levin.

WebCore:

Tested by http/tests/local/resources/send-sliced-dragged-file.html.

* html/Blob.cpp:
(WebCore::Blob::slice):
* html/Blob.h:
* html/Blob.idl:

LayoutTests:

Updated the test for the optional parameter.

* http/tests/local/resources/send-sliced-dragged-file.js:
* http/tests/local/send-sliced-dragged-file-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd viewport meta tag support to QtWebKit API layer
jesus@webkit.org [Thu, 17 Jun 2010 20:02:22 +0000 (20:02 +0000)]
Add viewport meta tag support to QtWebKit API layer

[Qt] QtWebKit does not support viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=39902

Patch by Jesus Sanchez-Palencia  <jesus@webkit.org>, Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-06-01
Reviewed by Simon Hausmann.

WebCore:

Add windowRect() to page client.

* platform/qt/QWebPageClient.h:

WebKit/qt:

This implements didReceiveViewportArguments in our ChromeClientQt
which is hooked up with QWebPage::viewportChangeRequested().
This signal does not affect the current default behavior.
The documentation of the signal explains how to make use of this new feature.

* Api/qwebframe_p.h:
(QWebFramePrivate::QWebFramePrivate):
Store information about whether the page has been laid out or not.
* Api/qwebpage.cpp:
(QWebPage::viewportChangeRequested):
* Api/qwebpage_p.h:
Added class QtViewportHintsPrivate.
* Api/qwebpage.h:
(QWebPage::setPreferredContentsSize):
Improved documentation and now only layout if the page had already
passed layout phase.
Added class QWebPage::ViewportHints.
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::windowRect):
Modified to work as intended by the DOM, for both QWebView
and QGraphicsWebView.
(WebCore::ChromeClientQt::didReceiveViewportArguments):
Emits the signal QWebPage::viewportChangeRequested.
* WebCoreSupport/ChromeClientQt.h:
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
Update information about whether the page has been laid out or not.
If the page has been laid out we ignore any further viewport meta data.
* WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQWidget::windowRect):
(WebCore::PageClientQGraphicsWidget::windowRect):
(WebCore::PageClientQGraphicsWidget::graphicsItemVisibleRect):
* WebCoreSupport/PageClientQt.h:
The PageClient is now responsible for providing the right window rect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Thu, 17 Jun 2010 19:50:36 +0000 (19:50 +0000)]
2010-06-17  Stephen White  <senorblanco@chromium.org>

        Reviewed by David Levin.

        Fix for slow multiple animated resize issue.
        https://bugs.webkit.org/show_bug.cgi?id=38233

        The timer-based resize quality approach implemented in
        http://trac.webkit.org/changeset/34210 is a good idea, but doesn't
        scale to multiple images with animated resizes.  This fix unifies all
        outstanding resize timers into a single timer, and removes the "use
        last quality" check (which doesn't work when images are overlapping).
        It also refactors the copy of this code implemented in
        RenderBoxModelObject in http://trac.webkit.org/changeset/53949.

        This improves Safari performance for the following IE9 platform demos on my C2D MacPro (10.5):
        http://ie.microsoft.com/testdrive/Performance/01FlyingImages/Default.html (4->60fps)
        http://ie.microsoft.com/testdrive/Performance/10FlickrExplorer/Default.html (3->16fps)
        http://ie.microsoft.com/testdrive/Performance/11BrowserFlip/Default.html (9->60fps)

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::ImageQualityController::ImageQualityController):
        Unify all timers into a single timer, rename RenderBoxModelScaleObserver
        to ImageQualityController, and remove the resize quality "stickness",
        since it doesn't work with multiple outstanding resizes.
        (WebCore::ImageQualityController::objectDestroyed):
        gImages global is now m_lastPaintTimeMap member.
        (WebCore::ImageQualityController::highQualityRepaintTimerFired):
        Function made non-static; repaint all pending resizes (not just one).
        (WebCore::ImageQualityController::restartTimer):
        Added function to restart timer at 1.05x threshold.
        (WebCore::imageQualityController):
        Static function to return singleton.
        (WebCore::ImageQualityController::shouldPaintAtLowQuality):
        Use m_lastPaintTimeMap, not gImages global.  Implement new timer
        algorithm.  Remove resize "stickiness".
        (WebCore::RenderBoxModelObject::shouldPaintAtLowQuality):
        Implement shouldPaintAtLowQuality, which pulls out "this" and passes
        the call to the ImageQualityController.
        (WebCore::RenderBoxModelObject::~RenderBoxModelObject):
        Call ImageQualityController singleton's objectDestroyed() instead of
        old static function.
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        Modify shouldPaintAtLowQuality() call to match new class name and
        function signature.
        * rendering/RenderBoxModelObject.h:
        Expose shouldPaintAtLowQuality as a member function.
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::~RenderImage):
        No need to call objectDestroyed() here anymore, since the
        RenderBoxModelObject destructor will do this for us.
        (WebCore::RenderImage::paintIntoRect):
        Rip out RenderImageScaleObserver, and call
        RenderBoxModelObject::shouldPaintAtLowQuality() instead.
2010-06-17  Stephen White  <senorblanco@chromium.org>

        Reviewed by David Levin.

        Temporarily modify test_expectations.txt to add tests broken by
        https://bugs.webkit.org/show_bug.cgi?id=38233

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Rob Buis <rwlbuis@gmail.com>
rwlbuis@webkit.org [Thu, 17 Jun 2010 19:32:04 +0000 (19:32 +0000)]
2010-06-17  Rob Buis  <rwlbuis@gmail.com>

        Reviewed by Dave Hyatt.

        CSS3 "Property is declared twice in rule" test fails
        https://bugs.webkit.org/show_bug.cgi?id=36282

        Filter out duplicate properties in style declaration.

        Test: fast/css/duplicate-property-in-rule.html

        * css/CSSMutableStyleDeclaration.cpp: Filter out duplicate properties
        (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue): Discard negative padding values
        * css/CSSStyleSelector.cpp: Remove negative padding check
        (WebCore::CSSStyleSelector::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 17 Jun 2010 18:14:56 +0000 (18:14 +0000)]
2010-06-17  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Clean up error conditions for Typed Arrays
        https://bugs.webkit.org/show_bug.cgi?id=40755

        * bindings/js/JSArrayBufferCustom.cpp:
        (WebCore::JSArrayBufferConstructor::constructJSArrayBuffer):
         - Fixed handling of NaN/+inf/-inf lengths. Throw RangeError for too-large or negative lengths.
        * bindings/js/JSArrayBufferViewHelper.h:
        (WebCore::constructArrayBufferView):
         - Changed all error code paths to throw exceptions. Clarified exception types.
        * bindings/js/JSFloat32ArrayCustom.cpp:
        (WebCore::JSFloat32ArrayConstructor::constructJSFloat32Array):
         - Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
        * bindings/js/JSInt16ArrayCustom.cpp:
        (WebCore::JSInt16ArrayConstructor::constructJSInt16Array):
         - Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
        * bindings/js/JSInt32ArrayCustom.cpp:
        (WebCore::JSInt32ArrayConstructor::constructJSInt32Array):
         - Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
        * bindings/js/JSInt8ArrayCustom.cpp:
        (WebCore::JSInt8ArrayConstructor::constructJSInt8Array):
         - Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
        * bindings/js/JSUint16ArrayCustom.cpp:
        (WebCore::JSUint16ArrayConstructor::constructJSUint16Array):
         - Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
        * bindings/js/JSUint32ArrayCustom.cpp:
        (WebCore::JSUint32ArrayConstructor::constructJSUint32Array):
         - Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
        * bindings/js/JSUint8ArrayCustom.cpp:
        (WebCore::JSUint8ArrayConstructor::constructJSUint8Array):
         - Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
        * bindings/v8/custom/V8ArrayBufferCustom.cpp:
        (WebCore::V8ArrayBuffer::constructorCallback):
         - Fixed handling of NaN/+inf/-inf lengths. Throw RangeError for too-large or negative lengths.
           Clarified exception types.
        * bindings/v8/custom/V8ArrayBufferViewCustom.h:
        (WebCore::constructWebGLArray):
         - Clarified exception types and throwing of exceptions along all error code paths.
        * html/canvas/TypedArrayBase.h:
        (WebCore::TypedArrayBase::create):
         - Added necessary null checks during allocation.
2010-06-17  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Clean up error conditions for Typed Arrays
        https://bugs.webkit.org/show_bug.cgi?id=40755

        * fast/canvas/webgl/array-unit-tests-expected.txt:
         - Updated test expectations.
        * fast/canvas/webgl/array-unit-tests.html:
         - Added tests for overloaded ArrayBufferView constructors taking null,
           and improperly aligned offsets. Improved precision of tests causing
           INDEX_SIZE_ERR to be thrown.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Shu Chang <chang.shu@nokia.com>
chang.shu@nokia.com [Thu, 17 Jun 2010 17:46:41 +0000 (17:46 +0000)]
2010-06-17  Shu Chang  <chang.shu@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix the link error on symbian with ENABLE_JIT=0.
        1. Add "#if ENABLE(JIT)" in the header file;
        2. Put feature enable/disable logic to a common.pri so
        that both JavaScriptCore.pri and WebCore.pri can share.

        https://bugs.webkit.org/show_bug.cgi?id=40780

        * JavaScriptCore.pri:
        * jit/ExecutableAllocator.h:

2010-06-17  Shu Chang  <chang.shu@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix the link error on symbian with ENABLE_JIT=0.
        1. Add "#if ENABLE(JIT)" in the header file;
        2. Put feature enable/disable logic to a common.pri so
        that both JavaScriptCore.pri and WebCore.pri can share.

        https://bugs.webkit.org/show_bug.cgi?id=40780

        * common.pri: Added.

2010-06-17  Shu Chang  <chang.shu@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix the link error on symbian with ENABLE_JIT=0.
        1. Add "#if ENABLE(JIT)" in the header file;
        2. Put feature enable/disable logic to a common.pri so
        that both JavaScriptCore.pri and WebCore.pri can share.

        https://bugs.webkit.org/show_bug.cgi?id=40780

        * WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 17 Jun 2010 17:39:54 +0000 (17:39 +0000)]
2010-06-17  Kenneth Russell  <kbr@google.com>

        Reviewed by Oliver Hunt.

        Differences in error reporting for overloaded methods causing fast/canvas/webgl/texImageTest.html to fail
        https://bugs.webkit.org/show_bug.cgi?id=40750

        Added V8Proxy::throwTypeError() and throwSyntaxError for parity
        with JSC::throwTypeError() and throwSyntaxError. Changed
        CodeGeneratorV8.pm to use throwTypeError for overload resolution
        failures. Revised CodeGeneratorJS.pm to use throwVMTypeError
        instead of manual call to JSValue::encode. Deleted now-unnecessary
        Chromium expectations for fast/canvas/webgl/texImageTest.html.

        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::throwTypeError):
        (WebCore::V8Proxy::throwSyntaxError):
        * bindings/v8/V8Proxy.h:
2010-06-17  Kenneth Russell  <kbr@google.com>

        Reviewed by Oliver Hunt.

        Differences in error reporting for overloaded methods causing fast/canvas/webgl/texImageTest.html to fail
        https://bugs.webkit.org/show_bug.cgi?id=40750

        Added V8Proxy::throwTypeError() and throwSyntaxError for parity
        with JSC::throwTypeError() and throwSyntaxError. Changed
        CodeGeneratorV8.pm to use throwTypeError for overload resolution
        failures. Revised CodeGeneratorJS.pm to use throwVMTypeError
        instead of manual call to JSValue::encode. Deleted now-unnecessary
        Chromium expectations for fast/canvas/webgl/texImageTest.html.

        * platform/chromium-mac/fast/canvas/webgl/texImageTest-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 17 Jun 2010 17:24:03 +0000 (17:24 +0000)]
2010-06-17  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed.

        tables/mozilla/images/adforce_imgis_com.html was removed after r61289. Remove
        it from the GTK+ skipped list.

        * platform/gtk/Skipped: Remove a defunct test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Darin Fisher <darin@chromium.org>
darin@chromium.org [Thu, 17 Jun 2010 17:23:31 +0000 (17:23 +0000)]
2010-06-17  Darin Fisher  <darin@chromium.org>

        Reviewed by Brady Eidson.

        If Page::goToItem is passed a HistoryItem that is the current item,
        then the page should be loaded again.

        https://bugs.webkit.org/show_bug.cgi?id=40660

        * loader/HistoryController.cpp:
        (WebCore::HistoryController::recursiveGoToItem): Add a check to
        recursiveGoToItem that matches the one in FrameLoader::loadItem.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Thu, 17 Jun 2010 17:06:13 +0000 (17:06 +0000)]
2010-06-17  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Kent Tamura.

        [BREWMP] Build fix for DragDataBrew
        https://bugs.webkit.org/show_bug.cgi?id=40610

        http://trac.webkit.org/changeset/60957 was not applied to DragDataBrew.cpp.
        Add FilenameConversionPolicy argument to DragData::containsURL and DragData::asURL.

        * platform/brew/DragDataBrew.cpp:
        (WebCore::DragData::containsURL):
        (WebCore::DragData::asURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Thu, 17 Jun 2010 16:53:51 +0000 (16:53 +0000)]
2010-06-17  Zhenyao Mo  <zmo@google.com>

        Reviewed by David Levin.

        Rename internalformat to internalFormat
        https://bugs.webkit.org/show_bug.cgi?id=40149

        * html/canvas/WebGLFramebuffer.cpp: Rename internalformat to internalFormat.
        (WebCore::WebGLFramebuffer::getColorBufferFormat):
        * html/canvas/WebGLRenderbuffer.cpp: Ditto.
        (WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
        * html/canvas/WebGLRenderbuffer.h: Ditto.
        (WebCore::WebGLRenderbuffer::setInternalFormat):
        (WebCore::WebGLRenderbuffer::getInternalFormat):
        * html/canvas/WebGLRenderingContext.cpp: Ditto.
        (WebCore::WebGLRenderingContext::copyTexImage2D):
        (WebCore::WebGLRenderingContext::copyTexSubImage2D):
        (WebCore::WebGLRenderingContext::framebufferRenderbuffer):
        (WebCore::WebGLRenderingContext::getRenderbufferParameter):
        (WebCore::WebGLRenderingContext::renderbufferStorage):
        (WebCore::WebGLRenderingContext::texImage2DBase):
        (WebCore::WebGLRenderingContext::isTexInternalFormatColorBufferCombinationValid):
        * html/canvas/WebGLRenderingContext.h: Ditto.
        * html/canvas/WebGLTexture.cpp: Ditto.
        (WebCore::WebGLTexture::WebGLTexture):
        * html/canvas/WebGLTexture.h: Ditto.
        (WebCore::WebGLTexture::setInternalFormat):
        (WebCore::WebGLTexture::getInternalFormat):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Thu, 17 Jun 2010 16:39:38 +0000 (16:39 +0000)]
2010-06-17  Zhenyao Mo  <zmo@google.com>

        Reviewed by David Levin.

        Remove input parameter validation for "level" upper limit in *tex* functions
        https://bugs.webkit.org/show_bug.cgi?id=40603

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::validateTexFuncParameters): Don't check for "level" upper limit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Lucas De Marchi <lucas.demarchi@profusion.mobi>
eric@webkit.org [Thu, 17 Jun 2010 16:26:13 +0000 (16:26 +0000)]
2010-06-17  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Eric Seidel.

        Clean EFL header files in order to diminish the compilation time with
        EFL from subversion. We remove the EFL includes from header files and use
        forward declarations, including the headers in correspondent source
        files when needed. This causes only the needed source files to be
        recompiled in case a new version of EFL is installed instead of
        triggering a recompilation of almost all WebCore/WebKit.
        https://bugs.webkit.org/show_bug.cgi?id=40575

        No new functionalities, so no new tests.

        * CMakeListsEfl.txt:
        * platform/PlatformKeyboardEvent.h: forward declaration.
        * platform/PlatformMouseEvent.h: forward declaration and change method
        signature to not require enum.
        * platform/PlatformWheelEvent.h: forward declaration.
        * platform/Widget.h: forward declaration.
        * platform/efl/PlatformKeyboardEventEfl.cpp: include needed header.
        * platform/efl/PlatformMouseEventEfl.cpp:
        (WebCore::PlatformMouseEvent::setClickCount): change method signature
        as mentioned above.
        * platform/efl/PlatformWheelEventEfl.cpp: include needed header.
        * platform/efl/RenderThemeEfl.cpp: include needed header
        * platform/efl/RenderThemeEfl.h: forward declaration.
        * platform/efl/ScrollbarEfl.cpp: include needed header.
        * platform/efl/ScrollbarEfl.h: forward declaration.
        * platform/efl/WidgetEfl.cpp: include needed header.
        * platform/graphics/FloatRect.h: remove unused method.
        * platform/graphics/Icon.h: forward declaration.
        * platform/graphics/IntRect.h: remove unused method.
        * platform/graphics/efl/FloatRectEfl.cpp: Removed. This file was
        implementing an unused method.
        * platform/graphics/efl/IntRectEfl.cpp: Removed. This file was
        implementing an unused method.
2010-06-17  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Eric Seidel.

        Clean EFL header files in order to diminish the compilation time with
        EFL from subversion. We remove the EFL includes from header files and use
        forward declarations, including the headers in correspondent source
        files when needed. This causes only the needed source files to be
        recompiled in case a new version of EFL is installed instead of
        triggering a recompilation of almost all WebCore/WebKit.
        https://bugs.webkit.org/show_bug.cgi?id=40575

        * efl/WebCoreSupport/ChromeClientEfl.cpp: include needed header.
        * efl/WebCoreSupport/ChromeClientEfl.h: forward declaration.
        * efl/WebCoreSupport/EditorClientEfl.h: forward declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 17 Jun 2010 16:25:37 +0000 (16:25 +0000)]
2010-06-17  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, test expectations update.

        * platform/chromium-mac/fast/dom/wrapper-classes-expected.txt:
        * platform/chromium-win/fast/dom/wrapper-classes-expected.txt: Updated results after r61322.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoOne more try at fix for Chromium build.
darin@apple.com [Thu, 17 Jun 2010 15:51:29 +0000 (15:51 +0000)]
One more try at fix for Chromium build.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell): Use set again instead of =.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Chromium build.
darin@apple.com [Thu, 17 Jun 2010 15:45:14 +0000 (15:45 +0000)]
Fix Chromium build.

       I didn't realize that neither Chromium nor Qt share the DumpRenderTree
code with all the other platforms! Wow, that should be fixed at some point.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell): Changed back to using "new".
* DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed Qt build fix.
hausmann@webkit.org [Thu, 17 Jun 2010 15:16:04 +0000 (15:16 +0000)]
Unreviewed Qt build fix.

LayoutTestController in the Qt DRT is not using refs :)

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Alex Milowski <alex@milowski.com>
darin@apple.com [Thu, 17 Jun 2010 15:11:42 +0000 (15:11 +0000)]
2010-06-17  Alex Milowski  <alex@milowski.com>

        Reviewed by Darin Adler.

        Fixed a compile error in the paint() methods by making them use the
        new visitedDependentColor() method.
        https://bugs.webkit.org/show_bug.cgi?id=40327

        * mathml/RenderMathMLRoot.cpp:
        (WebCore::RenderMathMLRoot::paint):
        (WebCore::RenderMathMLRoot::layout): Fixed a crash where every child
        was assumed to be a RenderMathMLBlock instance when that isn't the
        case.  Also, layout() needed to mark the index for layout before
        calling layout() on the index.
        * mathml/RenderMathMLSquareRoot.cpp:
        (WebCore::RenderMathMLSquareRoot::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Upstream the WebKit QML integration plugin
hausmann@webkit.org [Thu, 17 Jun 2010 15:03:46 +0000 (15:03 +0000)]
[Qt] Upstream the WebKit QML integration plugin
https://bugs.webkit.org/show_bug.cgi?id=40050

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-17
Reviewed by Kenneth Rohde Christiansen.

.:

Add to the build the QML WebKit integration plugin.

* WebKit.pro:

WebKit/qt:

Add to the Qt port the QML WebKit integration plugin.
QDeclarativeWebView is creating the item and expose
properties. The C++ API is not public, only the
properties are.

* declarative/declarative.pro: Added.
* declarative/plugin.cpp: Added.
(WebKitQmlPlugin::registerTypes):
* declarative/qdeclarativewebview.cpp: Added.
(QDeclarativeWebViewPrivate::QDeclarativeWebViewPrivate):
(QDeclarativeWebViewPrivate::):
(QDeclarativeWebViewPrivate::windowObjectsAppend):
(GraphicsWebView::GraphicsWebView):
(GraphicsWebView::mousePressEvent):
(GraphicsWebView::mouseReleaseEvent):
(GraphicsWebView::mouseDoubleClickEvent):
(GraphicsWebView::timerEvent):
(GraphicsWebView::mouseMoveEvent):
(QDeclarativeWebView::QDeclarativeWebView):
(QDeclarativeWebView::~QDeclarativeWebView):
(QDeclarativeWebView::init):
(QDeclarativeWebView::componentComplete):
(QDeclarativeWebView::status):
(QDeclarativeWebView::progress):
(QDeclarativeWebView::doLoadStarted):
(QDeclarativeWebView::doLoadProgress):
(QDeclarativeWebView::pageUrlChanged):
(QDeclarativeWebView::doLoadFinished):
(QDeclarativeWebView::url):
(QDeclarativeWebView::setUrl):
(QDeclarativeWebView::preferredWidth):
(QDeclarativeWebView::setPreferredWidth):
(QDeclarativeWebView::preferredHeight):
(QDeclarativeWebView::setPreferredHeight):
(QDeclarativeWebView::evaluateJavaScript):
(QDeclarativeWebView::updateDeclarativeWebViewSize):
(QDeclarativeWebView::initialLayout):
(QDeclarativeWebView::updateContentsSize):
(QDeclarativeWebView::geometryChanged):
(QDeclarativeWebView::javaScriptWindowObjects):
(QDeclarativeWebView::qmlAttachedProperties):
(QDeclarativeWebViewPrivate::updateWindowObjects):
(QDeclarativeWebView::renderingEnabled):
(QDeclarativeWebView::setRenderingEnabled):
(QDeclarativeWebView::heuristicZoom):
(QDeclarativeWebView::pressGrabTime):
(QDeclarativeWebView::setPressGrabTime):
(QDeclarativeWebView::backAction):
(QDeclarativeWebView::forwardAction):
(QDeclarativeWebView::reloadAction):
(QDeclarativeWebView::stopAction):
(QDeclarativeWebView::title):
(QDeclarativeWebView::icon):
(QDeclarativeWebView::setStatusText):
(QDeclarativeWebView::windowObjectCleared):
(QDeclarativeWebView::statusText):
(QDeclarativeWebView::page):
(QDeclarativeWebView::settingsObject):
(QDeclarativeWebView::setPage):
(QDeclarativeWebView::load):
(QDeclarativeWebView::html):
(QDeclarativeWebView::setHtml):
(QDeclarativeWebView::setContent):
(QDeclarativeWebView::history):
(QDeclarativeWebView::settings):
(QDeclarativeWebView::createWindow):
(QDeclarativeWebView::newWindowComponent):
(QDeclarativeWebView::setNewWindowComponent):
(QDeclarativeWebView::newWindowParent):
(QDeclarativeWebView::setNewWindowParent):
(QDeclarativeWebView::contentsSize):
(QDeclarativeWebView::contentsScale):
(QDeclarativeWebView::setContentsScale):
(QDeclarativeWebView::elementAreaAt):
(QDeclarativeWebPage::QDeclarativeWebPage):
(QDeclarativeWebPage::~QDeclarativeWebPage):
(QDeclarativeWebPage::chooseFile):
(QDeclarativeWebPage::javaScriptAlert):
(QDeclarativeWebPage::javaScriptConfirm):
(QDeclarativeWebPage::javaScriptPrompt):
(QDeclarativeWebPage::viewItem):
(QDeclarativeWebPage::createWindow):
* declarative/qdeclarativewebview_p.h: Added.
(QDeclarativeWebView::):
(QDeclarativeWebView::isComponentCompletePublic):
(QDeclarativeWebViewAttached::QDeclarativeWebViewAttached):
(QDeclarativeWebViewAttached::windowObjectName):
(QDeclarativeWebViewAttached::setWindowObjectName):
(QDeclarativeWebSettings::QDeclarativeWebSettings):
(QDeclarativeWebSettings::standardFontFamily):
(QDeclarativeWebSettings::setStandardFontFamily):
(QDeclarativeWebSettings::fixedFontFamily):
(QDeclarativeWebSettings::setFixedFontFamily):
(QDeclarativeWebSettings::serifFontFamily):
(QDeclarativeWebSettings::setSerifFontFamily):
(QDeclarativeWebSettings::sansSerifFontFamily):
(QDeclarativeWebSettings::setSansSerifFontFamily):
(QDeclarativeWebSettings::cursiveFontFamily):
(QDeclarativeWebSettings::setCursiveFontFamily):
(QDeclarativeWebSettings::fantasyFontFamily):
(QDeclarativeWebSettings::setFantasyFontFamily):
(QDeclarativeWebSettings::minimumFontSize):
(QDeclarativeWebSettings::setMinimumFontSize):
(QDeclarativeWebSettings::minimumLogicalFontSize):
(QDeclarativeWebSettings::setMinimumLogicalFontSize):
(QDeclarativeWebSettings::defaultFontSize):
(QDeclarativeWebSettings::setDefaultFontSize):
(QDeclarativeWebSettings::defaultFixedFontSize):
(QDeclarativeWebSettings::setDefaultFixedFontSize):
(QDeclarativeWebSettings::autoLoadImages):
(QDeclarativeWebSettings::setAutoLoadImages):
(QDeclarativeWebSettings::javascriptEnabled):
(QDeclarativeWebSettings::setJavascriptEnabled):
(QDeclarativeWebSettings::javaEnabled):
(QDeclarativeWebSettings::setJavaEnabled):
(QDeclarativeWebSettings::pluginsEnabled):
(QDeclarativeWebSettings::setPluginsEnabled):
(QDeclarativeWebSettings::privateBrowsingEnabled):
(QDeclarativeWebSettings::setPrivateBrowsingEnabled):
(QDeclarativeWebSettings::javascriptCanOpenWindows):
(QDeclarativeWebSettings::setJavascriptCanOpenWindows):
(QDeclarativeWebSettings::javascriptCanAccessClipboard):
(QDeclarativeWebSettings::setJavascriptCanAccessClipboard):
(QDeclarativeWebSettings::developerExtrasEnabled):
(QDeclarativeWebSettings::setDeveloperExtrasEnabled):
(QDeclarativeWebSettings::linksIncludedInFocusChain):
(QDeclarativeWebSettings::setLinksIncludedInFocusChain):
(QDeclarativeWebSettings::zoomTextOnly):
(QDeclarativeWebSettings::setZoomTextOnly):
(QDeclarativeWebSettings::printElementBackgrounds):
(QDeclarativeWebSettings::setPrintElementBackgrounds):
(QDeclarativeWebSettings::offlineStorageDatabaseEnabled):
(QDeclarativeWebSettings::setOfflineStorageDatabaseEnabled):
(QDeclarativeWebSettings::offlineWebApplicationCacheEnabled):
(QDeclarativeWebSettings::setOfflineWebApplicationCacheEnabled):
(QDeclarativeWebSettings::localStorageDatabaseEnabled):
(QDeclarativeWebSettings::setLocalStorageDatabaseEnabled):
(QDeclarativeWebSettings::localContentCanAccessRemoteUrls):
(QDeclarativeWebSettings::setLocalContentCanAccessRemoteUrls):
* declarative/qmldir: Added.
* docs/qtwebkit.qdocconf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 17 Jun 2010 14:58:48 +0000 (14:58 +0000)]
2010-06-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Use adoptRef and create functions in more code paths
        https://bugs.webkit.org/show_bug.cgi?id=40760

        * API/JSClassRef.h: Removed unneeded include of RefCounted.h.
        * API/JSWeakObjectMapRefPrivate.cpp: Ditto.

        * bytecode/CodeBlock.h:
        (JSC::FunctionCodeBlock::FunctionCodeBlock): Use the
        SharedSymbolTable::create function instead of calling new directly.

        * runtime/SymbolTable.h: Added a create function to the SharedSymbolTable
        class and made the constructor private.
2010-06-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Use adoptRef and create functions in more code paths
        https://bugs.webkit.org/show_bug.cgi?id=40760

        * Plugins/Hosted/NetscapePluginInstanceProxy.h: Made create no longer
        be an inline function.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
        Moved the call to addPluginInstance out of here.
        (WebKit::NetscapePluginInstanceProxy::create): Move it in here.
        This makes sure we call adoptRef on the new proxy before any caller
        calls ref on it.
2010-06-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Use adoptRef and create functions in more code paths
        https://bugs.webkit.org/show_bug.cgi?id=40760

        This helps prepare for an assertion that fires if you ref or destroy an
        object before calling adoptRef on it. That will help us catch mistakes
        that can lead to storage leaks.

        * WebCore.base.exp: Updated export now that Frame::create is not an
        inline function.

        * css/CSSInitialValue.h:
        (WebCore::CSSInitialValue::createExplicit): Use create.
        (WebCore::CSSInitialValue::createImplicit): Ditto.
        (WebCore::CSSInitialValue::create): Added.

        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::createUncachedIdentifier): Added.
        (WebCore::CSSPrimitiveValue::createUncachedColor): Added.
        (WebCore::CSSPrimitiveValue::createUncached): Added.
        (WebCore::CSSPrimitiveValue::createIdentifier): Use createUncachedIdentifier
        instead of using new directly.
        (WebCore::CSSPrimitiveValue::createColor): Use createUncachedColor instead
        of using new directly.
        (WebCore::CSSPrimitiveValue::create): Use createdUncached instead of using
        new directly.
        * css/CSSPrimitiveValue.h: Declare the new functions above.

        * css/CSSStyleSelector.cpp:
        (WebCore::loadFullDefaultStyle): Deref simpleDefaultStyleSheet instead of
        explicitly deleting it.

        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::SubresourceLoader): Move the call to
        addSubresourceLoader out of here.
        (WebCore::SubresourceLoader::create): Move it in here. This makes it so
        we don't ref the loader before finishing its creation and calling adoptRef.

        * page/Frame.cpp:
        (WebCore::Frame::Frame): Move the call to setMainFrame out of here.
        Also refactor the code so an assertion is easier to read.
        (WebCore::Frame::create): Move the call to setMainFrame in here.
        This makes it so we don't ref the frame before finishing its creation
        and calling adoptRef.
        * page/Frame.h: Made the create function non-inline.

        * platform/text/BidiContext.cpp:
        (WebCore::BidiContext::createUncached): Added.
        (WebCore::BidiContext::create): Call createUncached instead of callling
        new directly.
        * platform/text/BidiContext.h: Declare createUncached.

        * rendering/RenderSVGResourceFilter.cpp:
        (WebCore::RenderSVGResourceFilter::buildPrimitives): Use PassRefPtr and
        RefPtr instead of OwnPtr. And use the create function instead of new.
        * rendering/RenderSVGResourceFilter.h: Ditto.
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::writeSVGResourceContainer): Ditto.

        * storage/StorageAreaImpl.cpp:
        (WebCore::StorageAreaImpl::StorageAreaImpl): Move the code that calls
        StorageAreaSync::create out of here.
        (WebCore::StorageAreaImpl::create): Move it in here. This makes it so we
        don't ref the storage area before finishing its creation and calling adoptRef.

        * svg/SVGPaint.cpp:
        (WebCore::SVGPaint::defaultFill): Use create instead of new.
        (WebCore::SVGPaint::defaultStroke): Ditto.

        * svg/graphics/filters/SVGFilterBuilder.h: Made the constructor private
        and added a create function since this is a reference counted object and
        should not be constructed directly.
2010-06-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Use adoptRef and create functions in more code paths
        https://bugs.webkit.org/show_bug.cgi?id=40760

        * DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr.

        * DumpRenderTree/LayoutTestController.cpp:
        (LayoutTestController::create): Added.
        * DumpRenderTree/LayoutTestController.h: Declare the create function.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell): Use create instead of new.
        * DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (runTest): Use RefPtr and create instead of OwnPtr and new.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (runTest): Use RefPtr and create instead of OwnPtr and new.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef
        instead of new.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (runTest): Use RefPtr and create instead of OwnPtr and new.

        * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
        (runTest): Use RefPtr and create instead of OwnPtr and new.
        (MyApp::OnInit): Removed unneeded code to delete the layout
        test controller. This is done during each test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Update CMake build system to use new script for generating source files
abecsi@webkit.org [Thu, 17 Jun 2010 14:47:03 +0000 (14:47 +0000)]
    Update CMake build system to use new script for generating source files
        with gperf (r61091).
        https://bugs.webkit.org/show_bug.cgi?id=40628

        Patch by Lucas De Marchi <lucas.demarchi@profusion.mobi> on 2010-06-17
        Reviewed by Gustavo Noronha.

    * cmake/WebKitGenerators.cmake:

        WebCore: Update CMake build system to use new script for generating source files
        with gperf (r61091).
        This updates also the build system to cope with recent changes to
        source files list.
        https://bugs.webkit.org/show_bug.cgi?id=40628

        Patch by Lucas De Marchi <lucas.demarchi@profusion.mobi> on 2010-06-17
        Reviewed by Gustavo Noronha.

        No new tests since it's just compilation fixes.

    * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 17 Jun 2010 14:24:09 +0000 (14:24 +0000)]
2010-06-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Fix boolean reflected attributes to use empty string consistently for the content attribute value
        https://bugs.webkit.org/show_bug.cgi?id=40758

        Test: fast/dom/boolean-attribute-reflection.html

        The HTML5 specification and other browsers are all consistent:
        When setting a boolean IDL attribute to true, the attribute value
        gets set to the empty string. The guidelines for authors allow either
        the empty string or the name of the attribute, but for implementers
        of the DOM, the reflected attribute gets empty string.

        * dom/Element.cpp:
        (WebCore::Element::setBooleanAttribute): Use emptyAtom to set the
        attribute to the empty string.

        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::setAutofocus): Use the empty string,
        not "autofocus".
        (WebCore::HTMLFormControlElement::setRequired): Use the empty string,
        not "required".
2010-06-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Fix boolean reflected attributes to use empty string consistently for the content attribute value
        https://bugs.webkit.org/show_bug.cgi?id=40758

        * fast/dom/boolean-attribute-reflection-expected.txt: Added.
        * fast/dom/boolean-attribute-reflection.html: Added.
        * fast/dom/script-tests/boolean-attribute-reflection.js: Added.

        * fast/dom/wrapper-classes-expected.txt: Regenerated.
        * fast/dom/wrapper-classes.html: Added some classes.

        * media/video-controls-expected.txt: Regenerated.
        * media/video-controls.html: Changed to expect the new correct results.
        Removed unnecessary use of offsetTop to force layout. This test covers only
        the DOM and has nothing to do with layout.

        * svg/dom/svgpath-getPathSegAtLength.html: Let the
        make-script-test-wrappers script regenerate this file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 17 Jun 2010 13:19:29 +0000 (13:19 +0000)]
2010-06-17  Pavel Feldman  <pfeldman@chromium.org>

        Unreviewed: chromium tests fix. Added InspectorBackend delegates for new inspector methods.

        * inspector/front-end/InspectorBackendStub.js:
        (.WebInspector.InspectorBackendStub.prototype.clearConsoleMessages):
        (.WebInspector.InspectorBackendStub.prototype.getOuterHTML):
        (.WebInspector.InspectorBackendStub.prototype.setOuterHTML):
        (.WebInspector.InspectorBackendStub.prototype.addInspectedNode):

2010-06-17  Pavel Feldman  <pfeldman@chromium.org>

        Unreviewed: chromium tests fix. Added InspectorBackend delegates for new inspector methods.

        * src/js/InspectorControllerImpl.js:
        (devtools.InspectorBackendImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Thu, 17 Jun 2010 12:19:29 +0000 (12:19 +0000)]
2010-06-17  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        [Chromium] Prepare to making WebDevToolsAgentClient::sendMessageToFrontendOnIOThread virtual

        https://bugs.webkit.org/show_bug.cgi?id=39302

        * public/WebDevToolsAgent.h:
        * public/WebDevToolsAgentClient.h:
        (WebKit::WebDevToolsMessageTransport::~WebDevToolsMessageTransport):
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::):
        (WebKit::WebDevToolsAgent::dispatchMessageFromFrontendOnIOThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] use "win32-g++*" scope to match all MinGW makespecs
hausmann@webkit.org [Thu, 17 Jun 2010 10:23:11 +0000 (10:23 +0000)]
[Qt] use "win32-g++*" scope to match all MinGW makespecs

Patch by Mark Brand <mabrand@mabrand.nl> on 2010-06-17
Reviewed by Simon Hausmann.

The scope "win32-g++" comes from the name of the makespec. However, it
is frequently used to check for MinGW. This works fine as long as
win32-g++ is the only makespec for MinGW. Now we need the wildcard
to cover "win32-g++-cross" as well.

.:

* WebKit.pri:

JavaScriptCore:

* JavaScriptCore.pro:

WebCore:

* WebCore.pro:

WebKit/qt:

* Api/DerivedSources.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 17 Jun 2010 10:20:54 +0000 (10:20 +0000)]
2010-06-17  Pavel Feldman  <pfeldman@chromium.org>

        Unreviewed, tests fix.

        * inspector/elements-panel-search.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 17 Jun 2010 09:43:57 +0000 (09:43 +0000)]
2010-06-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Joe Pecoraro.

        Web Inspector: move get/setOuterHTML, addInspectedNode and
        clearConsole to native InspectorDOMAgent. This is done to allow
        inspected nodes array to store nodes from different domains,
        also moves outerhtml manipulation closer to the rest of the DOM
        operations. In addition to that, we are slowly getting rid of
        InjectedScriptAccess in favor of IDL-defined InspectorBackend
        interface for clearer remote debugging API.

        https://bugs.webkit.org/show_bug.cgi?id=40733

        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::inspectedNode):
        * inspector/InjectedScriptHost.h:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::changeTagName):
        (WebCore::InspectorBackend::getOuterHTML):
        (WebCore::InspectorBackend::setOuterHTML):
        (WebCore::InspectorBackend::addInspectedNode):
        (WebCore::InspectorBackend::clearConsoleMessages):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::inspectedNode):
        (WebCore::InspectorDOMAgent::changeTagName):
        (WebCore::InspectorDOMAgent::getOuterHTML):
        (WebCore::InspectorDOMAgent::setOuterHTML):
        (WebCore::InspectorDOMAgent::addInspectedNode):
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::didGetOuterHTML):
        (WebCore::InspectorFrontend::didSetOuterHTML):
        * inspector/InspectorFrontend.h:
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.requestClearMessages):
        * inspector/front-end/DOMAgent.js:
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
        (WebInspector.ElementsPanel):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.changeTagNameCallback):
        (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
        ():
        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):
        * inspector/front-end/InjectedScriptAccess.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 John Gregg <johnnyg@google.com>
eric@webkit.org [Thu, 17 Jun 2010 09:29:23 +0000 (09:29 +0000)]
2010-06-17  John Gregg  <johnnyg@google.com>

        Reviewed by David Levin.

        Move the call to the notification presenter that a Notification is being
        destroyed from the destructor (not safe) to the ActiveDOMObject::contextDestroyed
        method.

        Also fix up an incorrect reference loss in the V8 bindings code for Notifications.
        https://bugs.webkit.org/show_bug.cgi?id=40097

        No new tests; code paths are well-covered by existing tests.

        * bindings/v8/custom/V8NotificationCenterCustom.cpp:
        (WebCore::V8NotificationCenter::createHTMLNotificationCallback):
        (WebCore::V8NotificationCenter::createNotificationCallback):
        * notifications/Notification.cpp:
        (WebCore::Notification::~Notification):
        (WebCore::Notification::contextDestroyed):
        * notifications/Notification.h:
2010-06-17  John Gregg  <johnnyg@google.com>

        Reviewed by David Levin.

        Undo the build fix with the correct patch: Chromium NotificationPresenter
        is now informed of the destruction before it actually happens, so this
        use of the Notification object is correct.
        https://bugs.webkit.org/show_bug.cgi?id=40097

        * src/NotificationPresenterImpl.cpp:
        (WebKit::NotificationPresenterImpl::notificationObjectDestroyed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed rollout r61311, because it made 2 tests fail on Qt bot.
ossy@webkit.org [Thu, 17 Jun 2010 09:00:35 +0000 (09:00 +0000)]
Unreviewed rollout r61311, because it made 2 tests fail on Qt bot.

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved
https://bugs.webkit.org/show_bug.cgi?id=36702

WebCore:

* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::updatePluginWidget):

LayoutTests:

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 17 Jun 2010 08:31:30 +0000 (08:31 +0000)]
2010-06-17  Kent Tamura  <tkent@chromium.org>

        Reviewed by Shinichiro Hamaji.

        [DRT/Chromium] Fix a bug of Windows pixel tests
        https://bugs.webkit.org/show_bug.cgi?id=40763

        * DumpRenderTree/chromium/TestEventPrinter.cpp:
        (TestShellPrinter::handleImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 17 Jun 2010 08:23:44 +0000 (08:23 +0000)]
2010-06-17  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        Land new expected baselines for fill-opacity-(hsl|rgba).png
        DRT showed a mysterious error, and the baseline obviously had a problem.

        * platform/mac/svg/custom/fill-opacity-hsl-expected.checksum:
        * platform/mac/svg/custom/fill-opacity-hsl-expected.png:
        * platform/mac/svg/custom/fill-opacity-rgba-expected.checksum:
        * platform/mac/svg/custom/fill-opacity-rgba-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Make repaint throttling parameters runtime configurable.
hausmann@webkit.org [Thu, 17 Jun 2010 07:48:31 +0000 (07:48 +0000)]
WebCore: Make repaint throttling parameters runtime configurable.
https://bugs.webkit.org/show_bug.cgi?id=38401

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2010-05-28
Reviewed by Simon Hausmann, Antti Koivisto

REPAINT_THROTTLING now chooses default values for throttling parameters.
Should be removed when applications start using runtime configuration.

* page/FrameView.cpp:
(WebCore::FrameView::reset):
(WebCore::FrameView::updateDeferredRepaintDelay):
(WebCore::FrameView::setRepaintThrottlingDeferredRepaintDelay):
(WebCore::FrameView::setRepaintThrottlingnInitialDeferredRepaintDelayDuringLoading):
(WebCore::FrameView::setRepaintThrottlingMaxDeferredRepaintDelayDuringLoading):
(WebCore::FrameView::setRepaintThrottlingDeferredRepaintDelayIncrementDuringLoading):
* page/FrameView.h:

WebKit/qt: [Qt] Add internal Qt Api to configure repaint throttling parameters.
https://bugs.webkit.org/show_bug.cgi?id=38401

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2010-05-28
Reviewed by Simon Hausmann, Antti Koivisto

* Api/qwebpage.cpp:
(QWebPagePrivate::dynamicPropertyChangeEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Robert Hogan <robert@webkit.org>
eric@webkit.org [Thu, 17 Jun 2010 07:33:11 +0000 (07:33 +0000)]
2010-06-17  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

        https://bugs.webkit.org/show_bug.cgi?id=36702

        setNPWindowIfNeeded() is called on paint() in PluginViewQt, which doesn't
        work for DRT. So call it if we are in DRT mode and the window geometry
        has changed.

        Unskips plugins/reentrant-update-widget-positions.html

        * platform/qt/Skipped:
2010-06-17  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

        https://bugs.webkit.org/show_bug.cgi?id=36702

        setNPWindowIfNeeded() is called on paint() in PluginViewQt, which doesn't
        work for DRT. So call it if we are in DRT mode and the window geometry
        has changed.

        Unskips plugins/reentrant-update-widget-positions.html

        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::updatePluginWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Avoid unnecessary calls to save() and restore() when drawing images
hausmann@webkit.org [Thu, 17 Jun 2010 07:15:46 +0000 (07:15 +0000)]
[Qt] Avoid unnecessary calls to save() and restore() when drawing images

Reviewed by Kenneth Christiansen.

Avoid calling the expensive save() and restore() on the GraphicsContext just
for changing the composition mode. Instead save and restore it manually
on QPainter.

Change fac227f609e544f8f55aca8447b4328d6534407a in Qt makes sure that the
call to QPainter::setCompositionMode doesn't do anything if the mode hasn't
changed.

* platform/graphics/GraphicsContext.h:
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::toQtCompositionMode):
* platform/graphics/qt/ImageQt.cpp:
(WebCore::BitmapImage::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Hayato Ito <hayato@chromium.org>
hamaji@chromium.org [Thu, 17 Jun 2010 06:59:49 +0000 (06:59 +0000)]
2010-06-16  Hayato Ito  <hayato@chromium.org>

        Reviewed by Shinichiro Hamaji.

        Refactor layout tests for printing to use common code.

        https://bugs.webkit.org/show_bug.cgi?id=40559

        * printing/numberOfPages-expected.txt:
        * printing/numberOfPages.html:
        * printing/page-break-always-expected.txt:
        * printing/page-break-always-for-overflow-expected.txt:
        * printing/page-break-always-for-overflow.html:
        * printing/page-break-always.html:
        * printing/page-break-inside-avoid-expected.txt: Added.
        * printing/page-break-inside-avoid.html: Added.
        * printing/page-break-inside-expected.txt: Removed.
        * printing/page-break-inside.html: Removed.
        * printing/pageNumerForElementById-expected.txt:
        * printing/pageNumerForElementById.html:
        * printing/resources/paged-media-test-utils.js:
        (numberOfPagesShouldBe):
        (ratioToPageHeightToPixels):
        (createBlockWithRatioToPageHeight):
        (createBlockWithNumberOfLines):
        * printing/script-tests/TEMPLATE.html:
        * printing/script-tests/numberOfPages.js:
        (test):
        * printing/script-tests/page-break-always-for-overflow.js:
        (test):
        * printing/script-tests/page-break-always.js:
        (test):
        * printing/script-tests/page-break-inside-avoid.js: Added.
        (test):
        * printing/script-tests/page-break-inside.js: Removed.
        * printing/script-tests/pageNumerForElementById.js:
        (test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 17 Jun 2010 06:28:26 +0000 (06:28 +0000)]
2010-06-16  Kent Tamura  <tkent@chromium.org>

        Reviewed by Shinichiro Hamaji.

        [DRT/Chromium] Fix crash on Mac Release
        https://bugs.webkit.org/show_bug.cgi?id=40759

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::paintRect): We should not use m_canvas directly because
          it is created lazily in canvas().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] QtWebKit crashes while initializing flash plugin 10.1.53.64.
hausmann@webkit.org [Thu, 17 Jun 2010 05:38:10 +0000 (05:38 +0000)]
[Qt] QtWebKit crashes while initializing flash plugin 10.1.53.64.
https://bugs.webkit.org/show_bug.cgi?id=40567

Patch by Dawit Alemayehu <adawit@kde.org> on 2010-06-16
Reviewed by Simon Hausmann.

Avoid preventable crashes by ensuring gtk_init() is called in the
flash viewer plugins before calling NP_Initialize.

* plugins/qt/PluginPackageQt.cpp:
(WebCore::PluginPackage::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Tony Gentilcore <tonyg@chromium.org>
eric@webkit.org [Thu, 17 Jun 2010 05:23:00 +0000 (05:23 +0000)]
2010-06-16  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by David Levin.

        Guarantee that references are held for CachedScripts in HTMLDocumentParser.
        https://bugs.webkit.org/show_bug.cgi?id=40177

        No new tests because no new functionality.

        * html/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::reset):
        (WebCore::HTMLDocumentParser::executeExternalScriptsIfReady):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Jeremy Moskovich <jeremy@chromium.org>
eric@webkit.org [Thu, 17 Jun 2010 05:07:52 +0000 (05:07 +0000)]
2010-06-16  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Darin Adler.

        Improve assertion macro documentation.

        https://bugs.webkit.org/show_bug.cgi?id=40565

        * coding/assertion-guidelines.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Jeremy Moskovich <jeremy@chromium.org>
eric@webkit.org [Thu, 17 Jun 2010 04:29:37 +0000 (04:29 +0000)]
2010-06-16  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Geoffrey Garen.

        Add an index of technical articles to the WebKit site.  This makes the
        links to the RefPtr and Assertion documentation discoverable and
        provides an easy way to find some useful blog posts.

        https://bugs.webkit.org/show_bug.cgi?id=40561

        * coding/technical-articles.html: Added.
        * nav.inc: Add link to technical articles.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Qi Zhang <qi.2.zhang@nokia.com>
eric@webkit.org [Thu, 17 Jun 2010 04:15:05 +0000 (04:15 +0000)]
2010-06-16  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Repeat pattern should start from origin
        https://bugs.webkit.org/show_bug.cgi?id=39225

        Remove the following test case from Skipped:
        canvas/philip/tests/2d.pattern.paint.norepeat.coord3.html
        canvas/philip/tests/2d.pattern.paint.repeatx.coord1.html
        canvas/philip/tests/2d.pattern.paint.repeaty.coord1.html

        * platform/qt/Skipped:
2010-06-16  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Laszlo Gombos.

         [Qt] Repeat pattern should start from origin
         https://bugs.webkit.org/show_bug.cgi?id=39225

         Patterns must be painted so that the top left of the first image
         is anchored at the origin of the coordinate space.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::drawRepeatPattern):
        (WebCore::GraphicsContext::fillRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[wx] Build fix after new method addition.
kevino@webkit.org [Thu, 17 Jun 2010 04:04:59 +0000 (04:04 +0000)]
[wx] Build fix after new method addition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
eric@webkit.org [Thu, 17 Jun 2010 02:55:10 +0000 (02:55 +0000)]
2010-06-16  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] WebGL viewport does not show up on N900
        https://bugs.webkit.org/show_bug.cgi?id=38528

        With OGLES2 add default precision to the shader code.
        Use GLsizeiptr and GLintptr with OGLES2.
        Call paint() in beginPaint() so that drawTexture() is used
        whenever possible.

        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3D::beginPaint):
        (WebCore::GraphicsContext3D::paint):
        (WebCore::GraphicsContext3D::shaderSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 17 Jun 2010 02:18:17 +0000 (02:18 +0000)]
2010-06-16  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        This "test" no longer exists.  Turns out it was an image resource for
        another test.

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 17 Jun 2010 02:05:54 +0000 (02:05 +0000)]
2010-06-16  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [DRT/Chromium] Set current working directory for each of tests
        https://bugs.webkit.org/show_bug.cgi?id=40668

        * DEPS: Update Chromium to r49915 to have
          webkit_support::SetCurrentDirectoryForFileURL().
2010-06-16  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [DRT/Chromium] Set current working directory for each of tests
        https://bugs.webkit.org/show_bug.cgi?id=40668

        This change fixes tests with eventSender.beginDragWithFiles().

        * DumpRenderTree/chromium/DumpRenderTree.cpp:
        (runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSpatial Navigation: refactor scrollInDirection to work with scrollable content
tonikitoo@webkit.org [Thu, 17 Jun 2010 00:57:15 +0000 (00:57 +0000)]
Spatial Navigation: refactor scrollInDirection to work with scrollable content
https://bugs.webkit.org/show_bug.cgi?id=39195

Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>

WebCore:

scrollInDirection now receives as parameter the node that the Spatial Navigation
found as the more appropriated to move focus to. If it is in a scrollable container
(e.g. <div> with clipped overflow content), it scrolls recursively starting from
the container, not the current focused node.

Test: fast/events/spatial-navigation/snav-only-clipped-overflow-content.html

* page/FocusController.cpp:
(WebCore::FocusController::advanceFocusDirectionally):
* page/SpatialNavigation.cpp:
(WebCore::scrollInDirection):
* page/SpatialNavigation.h:

LayoutTests:

* fast/events/spatial-navigation/snav-only-clipped-overflow-content-expected.txt: Added.
* fast/events/spatial-navigation/snav-only-clipped-overflow-content.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=40732
weinig@apple.com [Thu, 17 Jun 2010 00:51:43 +0000 (00:51 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=40732
WebKit2: Implement didClearWindowForFrame for InjectedBundles

Reviewed by Geoffrey Garen.

WebKit2:

More InjectedBundle work.
- Add really basic page level APIs for the WebProcess side:
    - Basic client interface with just didClearWindowForFrame (more will be added later)
    - Simple main frame url getter.

These APIs are experimental and are intended to allow me to get a DRT implementation
up and running. They will be changing.

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: Added.
(WKBundlePageSetClient):
(WKBundlePageGetMainFrameURL):
* WebProcess/InjectedBundle/API/c/WKBundlePage.h: Added.
* WebProcess/InjectedBundle/InjectedBundlePageClient.cpp: Added.
(WebKit::InjectedBundlePageClient::InjectedBundlePageClient):
(WebKit::InjectedBundlePageClient::initialize):
(WebKit::InjectedBundlePageClient::didClearWindowObjectForFrame):
* WebProcess/InjectedBundle/InjectedBundlePageClient.h: Added.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::initializeInjectedBundleClient):
(WebKit::WebPage::mainFrameURL):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::injectedBundleClient):
* mac/WebKit2.exp:
* win/WebKit2.vcproj:

WebKitTools:

- Stub out use of bundlified didClearWindowForFrame with logging.

* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
* MiniBrowser/mac/WebBundle/WebBundleMain.c: Removed.
* MiniBrowser/mac/WebBundle/WebBundleMain.m: Added.
(_didClearWindow):
(_didCreatePage):
(WKBundleInitialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/7249553> and https://bugs.webkit.org/show_bug.cgi?id=40749
beidson@apple.com [Thu, 17 Jun 2010 00:27:52 +0000 (00:27 +0000)]
<rdar://problem/7249553> and https://bugs.webkit.org/show_bug.cgi?id=40749
ResourceLoader::willCacheResponse() needs to null-check Frame::Settings()

Reviewed by Eric Carlson

No new tests. (Discovered via crash reports, no reproducible cases noted)

* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willCacheResponse):  Null check m_frame->settings(),
  but also add an ASSERT so debug-build developers can learn more about why
  this might be happening.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 16 Jun 2010 23:53:32 +0000 (23:53 +0000)]
2010-06-16  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        Allow transitions and animations of clip: rect
        https://bugs.webkit.org/show_bug.cgi?id=38130

        Make the CSS clip property animatable.

        Test: transitions/clip-transition.html

        * page/animation/AnimationBase.cpp:
        (WebCore::blendFunc): New blend function for LengthBox
        (WebCore::AnimationBase::ensurePropertyMap): Create a PropertyWrapper for LengthBoxes.

        * platform/LengthBox.h:
        (WebCore::LengthBox::LengthBox): New ctor that takes 4 length values.
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::setClip): New method that takes a LengthBox.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTry to fix the MathML build.
darin@apple.com [Wed, 16 Jun 2010 23:39:14 +0000 (23:39 +0000)]
Try to fix the MathML build.

* mathml/MathMLMathElement.h: Added missing return type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 16 Jun 2010 23:07:32 +0000 (23:07 +0000)]
2010-06-16  Darin Adler  <darin@apple.com>

        Reviewed by David Levin.

        Deploy adoptRef in more places, including all HTML and MathML elements
        https://bugs.webkit.org/show_bug.cgi?id=39941

        * wtf/ThreadSafeShared.h: Made the constructor protected and removed the
        unneeded support for initial reference counts other than 1.
2010-06-16  Darin Adler  <darin@apple.com>

        Reviewed by David Levin.

        Deploy adoptRef in more places, including all HTML and MathML elements
        https://bugs.webkit.org/show_bug.cgi?id=39941

        * dom/Element.cpp:
        (WebCore::Element::dispatchAttrRemovalEvent): Use create instead of new
        in commented-out code.
        (WebCore::Element::dispatchAttrAdditionEvent): Ditto.

        * dom/Node.h: Removed now-unused CreateElementZeroRefCount and
        CreateHTMLElementZeroRefCount.

        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::insertList): Use create instead of new, fixing
        a storage leak.

        * editing/ModifySelectionListLevel.cpp:
        (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevel):
        Removed "WithType" from function name. Use create instead of new, fixing a
        storage leak.
        (WebCore::DecreaseSelectionListLevelCommand::decreaseSelectionListLevel): Use
        create instead of new, fixing a storage leak.

        * storage/IndexedDatabaseImpl.cpp:
        (WebCore::IndexedDatabaseImpl::create): Use adoptRef, fixing a storage leak.

        * editing/ModifySelectionListLevel.h: Added create functions.

        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::HTMLAnchorElement):
        * html/HTMLFrameOwnerElement.cpp:
        (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement):
        * html/HTMLMeterElement.cpp:
        (WebCore::HTMLMeterElement::HTMLMeterElement):
        * html/HTMLProgressElement.cpp:
        (WebCore::HTMLProgressElement::HTMLProgressElement):
        Removed code to explicitly pass CreateHTMLElement construction type since that's
        now the type used for all HTML elements.

        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::HTMLFormControlElement):
        * html/HTMLFormControlElement.h:
        Removed construction type argument, since CreateHTMLElement is now the type used
        for all HTML elements.

        * mathml/MathMLElement.cpp:
        (WebCore::MathMLElement::MathMLElement): Removed construction type of
        CreateStyledElementZeroRefCount so we'll use the default construction
        type, CreateStyledElement.
        (WebCore::MathMLElement::create): Use adoptRef.

        * mathml/MathMLElement.h: Made isMathMLElement function private and
        removed unneeded override of createRenderer, because it did the
        same thing as the base class's createRenderer function.

        * mathml/MathMLInlineContainerElement.cpp:
        (WebCore::MathMLInlineContainerElement::create): Use adoptRef.
        (WebCore::MathMLInlineContainerElement::createRenderer):
        Removed unnecessarily initialization of local variable and removed the
        case for mathTag, since that uses a different derived class.

        * mathml/MathMLInlineContainerElement.h: Made createRenderrer override
        private.

        * mathml/MathMLMathElement.cpp:
        (WebCore::MathMLMathElement::MathMLMathElement): Marked inline since
        it is called in only one place.
        (WebCore::MathMLMathElement::create): Use adoptRef.
        (WebCore::MathMLMathElement::createRenderer): Added. Creates a
        RenderMathMLMath object.

        * mathml/MathMLMathElement.h: Made constructor private and added a
        private override of createRenderer.

        * mathml/MathMLTextElement.cpp:
        (WebCore::MathMLTextElement::MathMLTextElement): Marked inline since
        it is called in only one place.
        (WebCore::MathMLTextElement::create): Use adoptRef.
        (WebCore::MathMLTextElement::createRenderer): Changed to call through
        to the base class instead of calling RenderObject::createObject directly.

        * mathml/MathMLTextElement.h: Made the constructor and createRenderer
        function private.

        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::RenderFileUploadControl):
        Removed an unneeded initializer.

        * rendering/RenderProgress.cpp: Tweaked includes.

        * rendering/ShadowElement.cpp: Added a "using namespace" directive.
        * rendering/ShadowElement.h: Tweaked formatting. Made more functions
        private.

        * editing/DeleteButton.cpp:
        (WebCore::DeleteButton::create):
        * html/HTMLAudioElement.cpp:
        (WebCore::HTMLAudioElement::create):
        (WebCore::HTMLAudioElement::createForJSConstructor):
        * html/HTMLBRElement.cpp:
        (WebCore::HTMLBRElement::create):
        * html/HTMLBaseElement.cpp:
        (WebCore::HTMLBaseElement::create):
        * html/HTMLBaseFontElement.cpp:
        (WebCore::HTMLBaseFontElement::create):
        * html/HTMLBlockquoteElement.cpp:
        (WebCore::HTMLBlockquoteElement::create):
        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::create):
        * html/HTMLButtonElement.cpp:
        (WebCore::HTMLButtonElement::create):
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::create):
        * html/HTMLDListElement.cpp:
        (WebCore::HTMLDListElement::create):
        * html/HTMLDataGridCellElement.cpp:
        (WebCore::HTMLDataGridCellElement::create):
        * html/HTMLDataGridColElement.cpp:
        (WebCore::HTMLDataGridColElement::create):
        * html/HTMLDataGridElement.cpp:
        (WebCore::HTMLDataGridElement::create):
        * html/HTMLDataGridRowElement.cpp:
        (WebCore::HTMLDataGridRowElement::create):
        * html/HTMLDataListElement.cpp:
        (WebCore::HTMLDataListElement::create):
        * html/HTMLDivElement.cpp:
        (WebCore::HTMLDivElement::create):
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::create):
        * html/HTMLElement.h:
        (WebCore::HTMLElement::HTMLElement):
        * html/HTMLFieldSetElement.cpp:
        (WebCore::HTMLFieldSetElement::create):
        * html/HTMLFontElement.cpp:
        (WebCore::HTMLFontElement::create):
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::create):
        * html/HTMLFrameSetElement.cpp:
        (WebCore::HTMLFrameSetElement::create):
        * html/HTMLHRElement.cpp:
        (WebCore::HTMLHRElement::create):
        * html/HTMLHeadElement.cpp:
        (WebCore::HTMLHeadElement::create):
        * html/HTMLHeadingElement.cpp:
        (WebCore::HTMLHeadingElement::create):
        * html/HTMLHtmlElement.cpp:
        (WebCore::HTMLHtmlElement::create):
        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::create):
        (WebCore::HTMLImageElement::createForJSConstructor):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::create):
        * html/HTMLIsIndexElement.cpp:
        (WebCore::HTMLIsIndexElement::create):
        * html/HTMLKeygenElement.cpp:
        (WebCore::HTMLKeygenElement::create):
        * html/HTMLLIElement.cpp:
        (WebCore::HTMLLIElement::create):
        * html/HTMLLabelElement.cpp:
        (WebCore::HTMLLabelElement::create):
        * html/HTMLLegendElement.cpp:
        (WebCore::HTMLLegendElement::create):
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::create):
        * html/HTMLMapElement.cpp:
        (WebCore::HTMLMapElement::create):
        * html/HTMLMarqueeElement.cpp:
        (WebCore::HTMLMarqueeElement::create):
        * html/HTMLMenuElement.cpp:
        (WebCore::HTMLMenuElement::create):
        * html/HTMLMetaElement.cpp:
        (WebCore::HTMLMetaElement::create):
        * html/HTMLModElement.cpp:
        (WebCore::HTMLModElement::create):
        * html/HTMLNoScriptElement.cpp:
        (WebCore::HTMLNoScriptElement::create):
        * html/HTMLOListElement.cpp:
        (WebCore::HTMLOListElement::create):
        * html/HTMLOptGroupElement.cpp:
        (WebCore::HTMLOptGroupElement::create):
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::create):
        (WebCore::HTMLOptionElement::createForJSConstructor):
        * html/HTMLParagraphElement.cpp:
        (WebCore::HTMLParagraphElement::create):
        * html/HTMLParamElement.cpp:
        (WebCore::HTMLParamElement::create):
        * html/HTMLPreElement.cpp:
        (WebCore::HTMLPreElement::create):
        * html/HTMLQuoteElement.cpp:
        (WebCore::HTMLQuoteElement::create):
        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::create):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::create):
        * html/HTMLSourceElement.cpp:
        (WebCore::HTMLSourceElement::create):
        * html/HTMLStyleElement.cpp:
        (WebCore::HTMLStyleElement::create):
        * html/HTMLTableCaptionElement.cpp:
        (WebCore::HTMLTableCaptionElement::create):
        * html/HTMLTableCellElement.cpp:
        (WebCore::HTMLTableCellElement::create):
        * html/HTMLTableColElement.cpp:
        (WebCore::HTMLTableColElement::create):
        * html/HTMLTableElement.cpp:
        (WebCore::HTMLTableElement::create):
        * html/HTMLTableRowElement.cpp:
        (WebCore::HTMLTableRowElement::create):
        * html/HTMLTableSectionElement.cpp:
        (WebCore::HTMLTableSectionElement::create):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::create):
        * html/HTMLTitleElement.cpp:
        (WebCore::HTMLTitleElement::create):
        * html/HTMLUListElement.cpp:
        (WebCore::HTMLUListElement::create):
        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::create):
        * loader/ImageDocument.cpp:
        (WebCore::ImageDocumentElement::create):
        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlShadowRootElement::create):
        (WebCore::MediaControlElement::create):
        (WebCore::MediaControlTimelineContainerElement::create):
        (WebCore::MediaControlVolumeSliderContainerElement::create):
        (WebCore::MediaControlStatusDisplayElement::create):
        (WebCore::MediaControlMuteButtonElement::create):
        (WebCore::MediaControlPlayButtonElement::create):
        (WebCore::MediaControlSeekButtonElement::create):
        (WebCore::MediaControlRewindButtonElement::create):
        (WebCore::MediaControlReturnToRealtimeButtonElement::create):
        (WebCore::MediaControlToggleClosedCaptionsButtonElement::create):
        (WebCore::MediaControlTimelineElement::create):
        (WebCore::MediaControlVolumeSliderElement::create):
        (WebCore::MediaControlFullscreenButtonElement::create):
        (WebCore::MediaControlTimeDisplayElement::create):
        * rendering/RenderSlider.cpp:
        (WebCore::SliderThumbElement::create):
        * rendering/TextControlInnerElements.cpp:
        (WebCore::TextControlInnerElement::create):
        (WebCore::TextControlInnerTextElement::create):
        (WebCore::SearchFieldResultsButtonElement::create):
        (WebCore::SearchFieldCancelButtonElement::create):
        (WebCore::SpinButtonElement::create):
        Use adoptRef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 16 Jun 2010 23:04:39 +0000 (23:04 +0000)]
2010-06-16  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, expectations tweak.

        * platform/chromium/test_expectations.txt: Transferred a failure from downstream.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 16 Jun 2010 22:58:04 +0000 (22:58 +0000)]
2010-06-16  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] r60803 broke media/controls-drag-timebar.html
        https://bugs.webkit.org/show_bug.cgi?id=40269

        * platform/gtk/Skipped: Unskip test which is now passing.
2010-06-16  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] r60803 broke media/controls-drag-timebar.html
        https://bugs.webkit.org/show_bug.cgi?id=40269

        Only queue events while the mouse button is down, if drag mode is enabled. Some
        tests may disable drag mode, to prevent the queuing of events in this situation.

        * DumpRenderTree/gtk/EventSender.cpp:
        (sendOrQueueEvent): Only queue events here if dragMode is true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove some CVS directories that snuck into Subversion
aroben@apple.com [Wed, 16 Jun 2010 22:47:47 +0000 (22:47 +0000)]
Remove some CVS directories that snuck into Subversion

These were added back when the Mozilla tables tests were imported.

Rubber-stamped by Dan Berstein.

* tables/mozilla/images/CVS: Removed.
* tables/mozilla_expected_failures/images/CVS: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61290 268f45cc-cd09-0410-ab3c-d52691b4dbfc