git://git.webkit.org / WebKit-https.git / log
? search:
summary | shortlog | log | commit | commitdiff | tree
first ⋅ prev ⋅ next
WebKit-https.git
10 years agoBash scripts should support LF endings only
commit | commitdiff | tree
dbates@webkit.org [Fri, 9 Mar 2012 19:09:11 +0000 (19:09 +0000)]
Bash scripts should support LF endings only
https://bugs.webkit.org/show_bug.cgi?id=79509

Patch by Ashod Nakashian <ashodnakashian@yahoo.com> on 2012-03-09
Reviewed by David Kilzer.

Source/JavaScriptCore:

* gyp/generate-derived-sources.sh: Added property svn:eol-style.
* gyp/run-if-exists.sh: Added property svn:eol-style.
* gyp/update-info-plist.sh: Added property svn:eol-style.

Source/ThirdParty:

* gtest/xcode/Samples/FrameworkSample/runtests.sh: Added property svn:executable.
* gtest/xcode/Scripts/runtests.sh: Added property svn:executable.

Source/ThirdParty/ANGLE:

* src/compiler/generate_parser.sh: Added property svn:eol-style.

Source/WebCore:

* WebCore.gyp/mac/adjust_visibility.sh: Added property svn:eol-style.
* WebCore.vcproj/build-generated-files.sh: Added property svn:executable.
* WebCore.vcproj/migrate-scripts.sh: Added property svn:executable.
* gyp/copy-forwarding-and-icu-headers.sh: Added property svn:eol-style.
* gyp/copy-inspector-resources.sh: Added property svn:eol-style.
* gyp/generate-derived-sources.sh: Added property svn:eol-style.
* gyp/generate-webcore-export-file-generator.sh: Added property svn:eol-style.
* gyp/run-if-exists.sh: Added property svn:eol-style.
* gyp/streamline-inspector-source.sh: Added property svn:eol-style.
* gyp/update-info-plist.sh: Added property svn:eol-style.

Source/WebKit2:

* win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.

Tools:

* EWSTools/boot.sh: Added properties svn:executable and svn:eol-style.
* EWSTools/start-queue.sh: Added property svn:eol-style.
* Scripts/webkit-tools-completion.sh: Added properties svn:executable and svn:eol-style.
* WebKitTestRunner/win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.
* iExploder/iexploder-1.7.2/tools/release_src.sh: Added property svn:eol-style.
* iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added property svn:eol-style.

WebKitLibraries:

* win/tools/scripts/feature-defines.sh: Modified property svn:eol-style.

Websites/bugs.webkit.org:

* contrib/yp_nomail.sh: Added property svn:executable.

LayoutTests:

* platform/mac/fast/loader/resources/mimeTypeExamples/example-sh.sh: Added property svn:executable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCSSParser: Use Vector for intermediate property storage.
commit | commitdiff | tree
kling@webkit.org [Fri, 9 Mar 2012 19:05:40 +0000 (19:05 +0000)]
CSSParser: Use Vector for intermediate property storage.
<http://webkit.org/b/80653>

Reviewed by Antti Koivisto.

Remove the custom memory management for intermediate CSSProperties in CSSParser
and replace it by a Vector<CSSProperty, 256>.
This avoids heap allocations and removes a bunch of unnecessary complexity.

Remove WTF_MAKE_FAST_ALLOCATED from CSSProperty since they are only created on
the stack now.

* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::~CSSParser):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::rollbackLastProperties):
(WebCore::CSSParser::clearProperties):
(WebCore::CSSParser::parse4Values):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createMarginAtRule):
(WebCore::CSSParser::startDeclarationsForMarginBox):
(WebCore::CSSParser::endDeclarationsForMarginBox):
(WebCore::CSSParser::deleteFontFaceOnlyValues):
(WebCore::CSSParser::createKeyframeRule):
* css/CSSParser.h:
(WebCore::CSSParser::hasProperties):
(CSSParser):
* css/CSSProperty.h:
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::addParsedProperties):
* css/StylePropertySet.h:
(WebCore::StylePropertySet::create):
(StylePropertySet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNote that fast/events/input-image-scrolled-x-y.html is flaky.
commit | commitdiff | tree
abarth@webkit.org [Fri, 9 Mar 2012 18:02:46 +0000 (18:02 +0000)]
Note that fast/events/input-image-scrolled-x-y.html is flaky.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r109022): Files dragged onto input controls cannot be read due to sandbox...
commit | commitdiff | tree
enrica@apple.com [Fri, 9 Mar 2012 17:59:30 +0000 (17:59 +0000)]
REGRESSION (r109022): Files dragged onto input controls cannot be read due to sandbox violation.
https://bugs.webkit.org/show_bug.cgi?id=80203
<rdar://problem/10976643>

Reviewed by Alexey Proskuryakov.

This patch reverts a small part fo r109022, leaving access to
NSPasteboard in the WebProcess when retrieving pathnames for
files being dragged. This avoid the sandbox violation until we
implement a mechanism to provide a sandbox extension to the WebProcess.

* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::getPathnamesForType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows debug build fix.
commit | commitdiff | tree
jberlin@webkit.org [Fri, 9 Mar 2012 17:56:42 +0000 (17:56 +0000)]
Windows debug build fix.

* assembler/MacroAssembler.h:
(JSC::MacroAssembler::shouldBlind):
Fix unreachable code warnings (which we treat as errors).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2012-03-09 Nate Chapin <japhet@chromium.org>
commit | commitdiff | tree
japhet@chromium.org [Fri, 9 Mar 2012 17:36:21 +0000 (17:36 +0000)]
2012-03-09  Nate Chapin  <japhet@chromium.org>

        CachedRawResource breaks when trying to load
        a resource with an empty response body from cache.

        Reviewed by Alexey Proskuryakov.

        Test: http/tests/cache/zero-length-xhr.html

        * loader/cache/CachedRawResource.cpp:
        (WebCore::CachedRawResource::didAddClient): Don't exit early
            if m_data is empty, we may still need to notifyFinished().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[BlackBerry] Upstream classes that handle layer tiling
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 9 Mar 2012 17:30:45 +0000 (17:30 +0000)]
[BlackBerry] Upstream classes that handle layer tiling
https://bugs.webkit.org/show_bug.cgi?id=79875

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-09
Reviewed by Rob Buis.

Initial upstreaming, no new tests.

* platform/graphics/blackberry/LayerTile.cpp: Added.
(WebCore):
(WebCore::LayerTile::LayerTile):
(WebCore::LayerTile::~LayerTile):
(WebCore::LayerTile::setContents):
(WebCore::LayerTile::setContentsToColor):
(WebCore::LayerTile::updateContents):
(WebCore::LayerTile::discardContents):
(WebCore::LayerTile::setVisible):
(WebCore::LayerTile::setTexture):
* platform/graphics/blackberry/LayerTile.h: Added.
(WebCore):
(LayerTileData):
(WebCore::LayerTileData::LayerTileData):
(WebCore::LayerTileData::isVisible):
(LayerTile):
(WebCore::LayerTile::texture):
(WebCore::LayerTile::isVisible):
(WebCore::LayerTile::isDirty):
(WebCore::LayerTile::hasTexture):
(WebCore::LayerTile::setContentsDirty):
* platform/graphics/blackberry/LayerTileIndex.h: Added.
(WebCore):
(TileIndex):
(WebCore::TileIndex::TileIndex):
(WebCore::TileIndex::~TileIndex):
(WebCore::TileIndex::i):
(WebCore::TileIndex::j):
(WebCore::TileIndex::setIndex):
(WebCore::operator==):
(WebCore::operator!=):
(WTF):
* platform/graphics/blackberry/LayerTiler.cpp: Added.
(WebCore):
(WebCore::transformPoint):
(WebCore::defaultTileSize):
(WebCore::LayerTiler::LayerTiler):
(WebCore::LayerTiler::~LayerTiler):
(WebCore::LayerTiler::layerWebKitThreadDestroyed):
(WebCore::LayerTiler::layerCompositingThreadDestroyed):
(WebCore::LayerTiler::setNeedsDisplay):
(WebCore::LayerTiler::updateTextureContentsIfNeeded):
(WebCore::LayerTiler::shouldPerformRenderJob):
(WebCore::LayerTiler::addTextureJob):
(WebCore::LayerTiler::clearTextureJobs):
(WebCore::LayerTiler::commitPendingTextureUploads):
(WebCore::LayerTiler::layerVisibilityChanged):
(WebCore::LayerTiler::uploadTexturesIfNeeded):
(WebCore::LayerTiler::processTextureJob):
(WebCore::LayerTiler::addTileJob):
(WebCore::LayerTiler::performTileJob):
(WebCore::LayerTiler::drawTextures):
(WebCore::LayerTiler::drawMissingTextures):
(WebCore::LayerTiler::drawTexturesInternal):
(WebCore::LayerTiler::addRenderJob):
(WebCore::LayerTiler::removeRenderJob):
(WebCore::LayerTiler::deleteTextures):
(WebCore::LayerTiler::pruneTextures):
(WebCore::LayerTiler::updateTileSize):
(WebCore::LayerTiler::disableTiling):
(WebCore::LayerTiler::shouldPrefillTile):
(WebCore::LayerTiler::indexOfTile):
(WebCore::LayerTiler::originOfTile):
(WebCore::LayerTiler::rectForTile):
(WebCore::LayerTiler::hasDirtyTiles):
(WebCore::LayerTiler::bindContentsTexture):
* platform/graphics/blackberry/LayerTiler.h: Added.
(WebCore):
(LayerTiler):
(WebCore::LayerTiler::create):
(WebCore::LayerTiler::layer):
(WebCore::LayerTiler::hasMissingTextures):
(WebCore::LayerTiler::TextureJob::TextureJob):
(TextureJob):
(WebCore::LayerTiler::TextureJob::setContents):
(WebCore::LayerTiler::TextureJob::setContentsToColor):
(WebCore::LayerTiler::TextureJob::updateContents):
(WebCore::LayerTiler::TextureJob::discardContents):
(WebCore::LayerTiler::TextureJob::resizeContents):
(WebCore::LayerTiler::TextureJob::dirtyContents):
(WebCore::LayerTiler::TextureJob::isNull):
(WebCore::LayerTiler::tileSize):
(WebCore::LayerTiler::removeUpdateContentsJobs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Ensure we use the correct time when notifying animation started
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 9 Mar 2012 16:49:02 +0000 (16:49 +0000)]
[chromium] Ensure we use the correct time when notifying animation started
https://bugs.webkit.org/show_bug.cgi?id=79537

Patch by Ian Vollick <vollick@chromium.org> on 2012-03-09
Reviewed by James Robinson

Source/WebCore:

Tested in CCLayerTreeHostTestAddAnimation

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setAnimationEvent):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
* platform/graphics/chromium/cc/CCAnimationEvents.cpp:
(WebCore::CCAnimationStartedEvent::create):
(WebCore::CCAnimationStartedEvent::CCAnimationStartedEvent):
* platform/graphics/chromium/cc/CCAnimationEvents.h:
(CCAnimationEvent):
(CCAnimationStartedEvent):
* platform/graphics/chromium/cc/CCInputHandler.h:
(CCInputHandler):
* platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.cpp:
(WebCore::CCLayerAnimationControllerImpl::animate):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForNextTick):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForStartTime):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForTargetAvailability):
(WebCore::CCLayerAnimationControllerImpl::resolveConflicts):
(WebCore::CCLayerAnimationControllerImpl::tickAnimations):
* platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.h:
(CCLayerAnimationControllerImpl):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setAnimationEvents):
(WebCore::CCLayerTreeHost::setAnimationEventsRecursive):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::animate):
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::animateLayersRecursive):
(WebCore::CCLayerTreeHostImpl::animatePageScale):
(WebCore::CCLayerTreeHostImpl::animateLayers):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImplClient):
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCPageScaleAnimation.cpp:
(WebCore::CCPageScaleAnimation::create):
(WebCore::CCPageScaleAnimation::CCPageScaleAnimation):
(WebCore::CCPageScaleAnimation::zoomTo):
(WebCore::CCPageScaleAnimation::zoomWithAnchor):
(WebCore::CCPageScaleAnimation::scrollOffsetAtTime):
(WebCore::CCPageScaleAnimation::pageScaleAtTime):
(WebCore::CCPageScaleAnimation::isAnimationCompleteAtTime):
(WebCore::CCPageScaleAnimation::progressRatioForTime):
* platform/graphics/chromium/cc/CCPageScaleAnimation.h:
(CCPageScaleAnimation):
(WebCore::CCPageScaleAnimation::startTime):
(WebCore::CCPageScaleAnimation::duration):
(WebCore::CCPageScaleAnimation::endTime):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::startPageScaleAnimation):
(WebCore::CCSingleThreadProxy::postAnimationEventsToMainThreadOnImplThread):
(WebCore::CCSingleThreadProxy::doComposite):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::startPageScaleAnimation):
(WebCore::CCThreadProxy::requestStartPageScaleAnimationOnImplThread):
(WebCore::CCThreadProxy::postAnimationEventsToMainThreadOnImplThread):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
(WebCore::CCThreadProxy::setAnimationEvents):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):

Source/WebKit/chromium:

* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::willDraw):
* src/WebCompositorInputHandlerImpl.h:
(WebCompositorInputHandlerImpl):
* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::CCLayerTreeHostImplTest::postAnimationEventsToMainThreadOnImplThread):
(WebKit::TEST_F):
* tests/CCLayerTreeHostTest.cpp:
(WTF::TestHooks::animateLayers):
(WTF::TestHooks::updateAnimations):
(WTF::MockLayerTreeHostImpl::animateLayers):
(WTF::MockLayerTreeHostClient::updateAnimations):
(WTF::CCLayerTreeHostTestAddAnimation::CCLayerTreeHostTestAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::animateLayers):
(WTF::CCLayerTreeHostTestAddAnimation::notifyAnimationStarted):
(CCLayerTreeHostTestAddAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Unreviewed gardening.
commit | commitdiff | tree
senorblanco@chromium.org [Fri, 9 Mar 2012 15:45:48 +0000 (15:45 +0000)]
[chromium] Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening.
commit | commitdiff | tree
ossy@webkit.org [Fri, 9 Mar 2012 15:25:35 +0000 (15:25 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped: Skip flaky svg tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[BUILD] use detected python to run generate-gtkdoc
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 9 Mar 2012 15:22:15 +0000 (15:22 +0000)]
[BUILD] use detected python to run generate-gtkdoc
https://bugs.webkit.org/show_bug.cgi?id=80695

Patch by Ionut Biru <ibiru@archlinux.org> on 2012-03-09
Reviewed by Gustavo Noronha Silva.

* GNUmakefile.am: Use $(PYTHON) instead of plain `python`

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening.
commit | commitdiff | tree
ossy@webkit.org [Fri, 9 Mar 2012 15:13:17 +0000 (15:13 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped:
* platform/qt/editing/selection/3690703-2-expected.png:
* platform/qt/editing/selection/3690703-2-expected.txt:
* platform/qt/editing/selection/3690703-expected.png:
* platform/qt/editing/selection/3690703-expected.txt:
* platform/qt/editing/selection/3690719-expected.png:
* platform/qt/editing/selection/3690719-expected.txt:
* platform/qt/fast/css/text-overflow-input-expected.txt: Added.
* platform/qt/fast/forms/basic-inputs-expected.png: Added.
* platform/qt/fast/forms/basic-inputs-expected.txt:
* platform/qt/fast/replaced/replaced-breaking-expected.png:
* platform/qt/fast/replaced/replaced-breaking-expected.txt:
* platform/qt/fast/text/textIteratorNilRenderer-expected.png:
* platform/qt/fast/text/textIteratorNilRenderer-expected.txt:
* platform/qt/svg/custom/inline-svg-in-xhtml-expected.png:
* platform/qt/svg/custom/inline-svg-in-xhtml-expected.txt:
* platform/qt/tables/mozilla/bugs/bug1188-expected.png:
* platform/qt/tables/mozilla/bugs/bug1188-expected.txt:
* platform/qt/tables/mozilla/bugs/bug18359-expected.png:
* platform/qt/tables/mozilla/bugs/bug18359-expected.txt:
* platform/qt/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug2479-2-expected.txt:
* platform/qt/tables/mozilla/bugs/bug2479-3-expected.png:
* platform/qt/tables/mozilla/bugs/bug2479-3-expected.txt:
* platform/qt/tables/mozilla/bugs/bug2479-4-expected.png:
* platform/qt/tables/mozilla/bugs/bug2479-4-expected.txt:
* platform/qt/tables/mozilla/bugs/bug28928-expected.png:
* platform/qt/tables/mozilla/bugs/bug28928-expected.txt:
* platform/qt/tables/mozilla/bugs/bug4382-expected.png:
* platform/qt/tables/mozilla/bugs/bug4382-expected.txt:
* platform/qt/tables/mozilla/bugs/bug44505-expected.png:
* platform/qt/tables/mozilla/bugs/bug44505-expected.txt:
* platform/qt/tables/mozilla/bugs/bug4527-expected.png:
* platform/qt/tables/mozilla/bugs/bug4527-expected.txt:
* platform/qt/tables/mozilla/bugs/bug46368-1-expected.png:
* platform/qt/tables/mozilla/bugs/bug46368-1-expected.txt:
* platform/qt/tables/mozilla/bugs/bug46368-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug46368-2-expected.txt:
* platform/qt/tables/mozilla/bugs/bug51037-expected.png:
* platform/qt/tables/mozilla/bugs/bug51037-expected.txt:
* platform/qt/tables/mozilla/bugs/bug7342-expected.png:
* platform/qt/tables/mozilla/bugs/bug7342-expected.txt:
* platform/qt/tables/mozilla/dom/tableDom-expected.png:
* platform/qt/tables/mozilla/dom/tableDom-expected.txt:
* platform/qt/tables/mozilla/other/move_row-expected.png:
* platform/qt/tables/mozilla/other/move_row-expected.txt:
* platform/qt/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLayout test for window.devicePixelRatio
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 9 Mar 2012 15:08:37 +0000 (15:08 +0000)]
Layout test for window.devicePixelRatio
https://bugs.webkit.org/show_bug.cgi?id=80292

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-03-09
Reviewed by Philippe Normand.

Update the skipped list for ports where fast/viewport/viewport-133.html is failing.

* platform/efl/Skipped:
* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Rebaseline some tests on qt platfrom
commit | commitdiff | tree
ossy@webkit.org [Fri, 9 Mar 2012 14:25:30 +0000 (14:25 +0000)]
[Qt] Rebaseline some tests on qt platfrom

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-03-09
Reviewed by Csaba Osztrogonác.

* platform/qt/ [...]: Update expected files.
* platform/qt/test_expectations.txt: Unskip now passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2012-03-09 Nikolas Zimmermann <nzimmermann@rim.com>
commit | commitdiff | tree
zimmermann@webkit.org [Fri, 9 Mar 2012 13:59:04 +0000 (13:59 +0000)]
2012-03-09  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        Rebaseline some Mac results that needed rebaselining - using Lion, and a Generic RGB Color profile.
        Had to manually switch to this, until this is done automatically, see bug 80571.

        Re-add several results that got deleted or moved to mac-future. I guess this is garden-o-matic
        misusage? Not sure, anyhow, there are clearly a dozen of missing SVG pixel tests before this patch.

        Reviewed by NOBODY (OOPS!).

        * platform/mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
        * platform/mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
        * platform/mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
        * platform/mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
        * platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
        * platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
        * platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
        * platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
        * platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
        * platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
        * platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
        * platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
        * platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
        * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
        * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
        * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
        * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
        * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
        * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
        * platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
        * platform/mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
        * platform/mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
        * platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
        * platform/mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
        * platform/mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
        * platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
        * platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
        * platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
        * platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
        * platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
        * platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
        * platform/mac/svg/batik/filters/feTile-expected.png:
        * platform/mac/svg/batik/filters/filterRegions-expected.png:
        * platform/mac/svg/batik/masking/maskRegions-expected.png: Added.
        * platform/mac/svg/batik/text/textEffect-expected.png:
        * platform/mac/svg/batik/text/textEffect3-expected.png:
        * platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Added.
        * platform/mac/svg/carto.net/scrollbar-expected.png: Added.
        * platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
        * platform/mac/svg/css/path-gradient-stroke-shadow-expected.png:
        * platform/mac/svg/css/rect-gradient-stroke-shadow-expected.png:
        * platform/mac/svg/custom/convolution-crash-expected.png:
        * platform/mac/svg/custom/empty-merge-expected.png:
        * platform/mac/svg/custom/feComponentTransfer-Discrete-expected.png:
        * platform/mac/svg/custom/feComponentTransfer-Gamma-expected.png:
        * platform/mac/svg/custom/feComponentTransfer-Linear-expected.png:
        * platform/mac/svg/custom/feComponentTransfer-Table-expected.png:
        * platform/mac/svg/custom/feDisplacementMap-01-expected.png:
        * platform/mac/svg/custom/grayscale-gradient-mask-2-expected.png:
        * platform/mac/svg/custom/image-with-transform-clip-filter-expected.png:
        * platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
        * platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
        * platform/mac/svg/custom/non-opaque-filters-expected.png:
        * platform/mac/svg/custom/recursive-filter-expected.png:
        * platform/mac/svg/custom/resource-invalidate-on-target-update-expected.png:
        * platform/mac/svg/custom/root-container-opacity-clip-viewBox-expected.png:
        * platform/mac/svg/custom/text-filter-expected.png:
        * platform/mac/svg/custom/use-disappears-after-style-update-expected.png:
        * platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.png: Added.
        * platform/mac/svg/custom/visibility-override-filter-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-dom-azimuth-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-dom-elevation-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-azimuth-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-elevation-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png:
        * platform/mac/svg/filters/big-sized-filter-2-expected.png:
        * platform/mac/svg/filters/big-sized-filter-expected.png:
        * platform/mac/svg/filters/feColorMatrix-default-type-expected.png:
        * platform/mac/svg/filters/feColorMatrix-offset-expected.png:
        * platform/mac/svg/filters/feColorMatrix-values-expected.png:
        * platform/mac/svg/filters/feComposite-expected.png:
        * platform/mac/svg/filters/feConvolveFilter-y-bounds-expected.png:
        * platform/mac/svg/filters/feDisplacementMap-expected.png:
        * platform/mac/svg/filters/feDropShadow-expected.png:
        * platform/mac/svg/filters/feGaussianBlur-expected.png:
        * platform/mac/svg/filters/feImage-animated-transform-on-target-rect-expected.png:
        * platform/mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
        * platform/mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
        * platform/mac/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
        * platform/mac/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
        * platform/mac/svg/filters/feImage-late-indirect-update-expected.png:
        * platform/mac/svg/filters/feImage-multiple-targets-id-change-expected.png:
        * platform/mac/svg/filters/feImage-position-expected.png:
        * platform/mac/svg/filters/feImage-preserveAspectratio-expected.png:
        * platform/mac/svg/filters/feImage-subregions-expected.png:
        * platform/mac/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
        * platform/mac/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
        * platform/mac/svg/filters/feImage-target-add-to-document-expected.png:
        * platform/mac/svg/filters/feImage-target-attribute-change-expected.png:
        * platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png:
        * platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png:
        * platform/mac/svg/filters/feImage-target-changes-id-expected.png:
        * platform/mac/svg/filters/feImage-target-id-change-expected.png:
        * platform/mac/svg/filters/feImage-target-inline-style-change-expected.png:
        * platform/mac/svg/filters/feImage-target-property-change-expected.png:
        * platform/mac/svg/filters/feImage-target-reappend-to-document-expected.png:
        * platform/mac/svg/filters/feImage-target-remove-from-document-expected.png:
        * platform/mac/svg/filters/feImage-target-style-change-expected.png:
        * platform/mac/svg/filters/feLighting-crash-expected.png:
        * platform/mac/svg/filters/feMerge-expected.png:
        * platform/mac/svg/filters/feOffset-expected.png:
        * platform/mac/svg/filters/feTile-expected.png:
        * platform/mac/svg/filters/filter-clip-expected.png:
        * platform/mac/svg/filters/filter-on-tspan-expected.png:
        * platform/mac/svg/filters/filter-placement-issue-expected.png:
        * platform/mac/svg/filters/filter-refresh-expected.png:
        * platform/mac/svg/filters/filter-rounding-issues-expected.png:
        * platform/mac/svg/filters/filter-source-position-expected.png:
        * platform/mac/svg/filters/filter-width-update-expected.png:
        * platform/mac/svg/filters/filterRes-expected.png:
        * platform/mac/svg/filters/filterRes1-expected.png:
        * platform/mac/svg/filters/filterRes2-expected.png:
        * platform/mac/svg/filters/filterRes3-expected.png:
        * platform/mac/svg/filters/filteredImage-expected.png:
        * platform/mac/svg/filters/parent-children-with-same-filter-expected.png:
        * platform/mac/svg/filters/shadow-on-filter-expected.png:
        * platform/mac/svg/filters/shadow-on-rect-with-filter-expected.png:
        * platform/mac/svg/filters/subRegion-in-userSpace-expected.png:
        * platform/mac/svg/filters/subRegion-one-effect-expected.png:
        * platform/mac/svg/filters/subRegion-two-effects-expected.png:
        * platform/mac/svg/hixie/mixed/003-expected.png:
        * platform/mac/svg/hixie/mixed/003-expected.txt:
        * platform/mac/svg/repaint/filter-child-repaint-expected.png:
        * platform/mac/svg/repaint/filter-repaint-expected.png:
        * platform/mac/svg/webarchive/svg-feimage-subresources-expected.png:
        * platform/mac/test_expectations.txt:
        * svg/filters/animate-fill-expected.png:
        * svg/filters/feColorMatrix-saturate-expected.png:
        * svg/filters/feImage-reference-invalidation-expected.png:
        * svg/filters/feImage-reference-svg-primitive-expected.png:
        * svg/foreignObject/filter-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix compilation without QtQuick1
commit | commitdiff | tree
ossy@webkit.org [Fri, 9 Mar 2012 13:13:44 +0000 (13:13 +0000)]
[Qt] Fix compilation without QtQuick1
https://bugs.webkit.org/show_bug.cgi?id=80503

Qt 4.8 API test fix after r110050.

Reviewed by Zoltan Herczeg.

* declarative/public.pri: Add load(features) to ensure HAVE_QQUICK1=1 is set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[BlackBerry] Web Notification not working after rebase
commit | commitdiff | tree
charles.wei@torchmobile.com.cn [Fri, 9 Mar 2012 13:11:28 +0000 (13:11 +0000)]
[BlackBerry] Web Notification not working after rebase
https://bugs.webkit.org/show_bug.cgi?id=80690

Reviewed by George Staikos.

1. NotificationPresenterImpl should be in namespace WebCore
2. Need to connect NotificationPresenterImpl to webcore the new way:
   WebCore::provideNotification(Page*, NotificationPresenter*)
3. Remove the old way of connecting the Notification:
   ChromeClientBlackBerry::notificationPresenter()

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore):
* WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
* WebCoreSupport/NotificationPresenterImpl.cpp:
* WebCoreSupport/NotificationPresenterImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPatch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2012-03-09
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 9 Mar 2012 12:45:19 +0000 (12:45 +0000)]
Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2012-03-09
Reviewed by Zoltan Herczeg.

[Qt] Fix the SH4 build after r109834
https://bugs.webkit.org/show_bug.cgi?id=80492

* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::branchAdd32):
(JSC::MacroAssemblerSH4::branchSub32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Disable WebGL performance tests temporarily.
commit | commitdiff | tree
ossy@webkit.org [Fri, 9 Mar 2012 12:16:26 +0000 (12:16 +0000)]
[Qt] Disable WebGL performance tests temporarily.
https://bugs.webkit.org/show_bug.cgi?id=80503

Rubber-stamped by Simon Hausmann.

* Source/tests.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRefactor code feature analysis in the parser
commit | commitdiff | tree
wingo@igalia.com [Fri, 9 Mar 2012 12:06:48 +0000 (12:06 +0000)]
Refactor code feature analysis in the parser
https://bugs.webkit.org/show_bug.cgi?id=79112

Reviewed by Geoffrey Garen.

This commit refactors the parser to more uniformly propagate flag
bits down and up the parse process, as the parser descends and
returns into nested blocks.  Some flags get passed town to
subscopes, some apply to specific scopes only, and some get
unioned up after parsing subscopes.

The goal is to eventually be very precise with scoping
information, once we have block scopes: one block scope might use
`eval', which would require the emission of a symbol table within
that block and containing blocks, whereas another block in the
same function might not, allowing us to not emit a symbol table.

* parser/Nodes.h:
(JSC::ScopeFlags): Rename from CodeFeatures.
(JSC::ScopeNode::addScopeFlags):
(JSC::ScopeNode::scopeFlags): New accessors for m_scopeFlags.
(JSC::ScopeNode::isStrictMode):
(JSC::ScopeNode::usesEval):
(JSC::ScopeNode::usesArguments):
(JSC::ScopeNode::setUsesArguments):
(JSC::ScopeNode::usesThis):
(JSC::ScopeNode::needsActivationForMoreThanVariables):
(JSC::ScopeNode::needsActivation): Refactor these accessors to
operate on the m_scopeFlags member.
(JSC::ScopeNode::source):
(JSC::ScopeNode::sourceURL):
(JSC::ScopeNode::sourceID): Shuffle these definitions around; no
semantic change.
(JSC::ScopeNode::ScopeNode)
(JSC::ProgramNode::ProgramNode)
(JSC::EvalNode::EvalNode)
(JSC::FunctionBodyNode::FunctionBodyNode): Have these constructors
take a ScopeFlags as an argument, instead of a bool inStrictContext.

* parser/Nodes.cpp:
(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create): Adapt constructors to change.

* parser/ASTBuilder.h:
(JSC::ASTBuilder::ASTBuilder):
(JSC::ASTBuilder::thisExpr):
(JSC::ASTBuilder::createResolve):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::addVar):
(JSC::ASTBuilder::Scope::Scope):
(Scope):
(ASTBuilder):
(JSC::ASTBuilder::makeFunctionCallNode): Don't track scope
features here.  Instead rely on the base Parser mechanism to track
features.

* parser/NodeInfo.h (NodeInfo, NodeDeclarationInfo): "ScopeFlags".

* parser/Parser.h:
(JSC::Scope::Scope): Manage scope through flags, not
bit-booleans.  This lets us uniformly propagate them up and down.
(JSC::Scope::declareWrite):
(JSC::Scope::declareParameter):
(JSC::Scope::useVariable):
(JSC::Scope::collectFreeVariables):
(JSC::Scope::getCapturedVariables):
(JSC::Scope::saveFunctionInfo):
(JSC::Scope::restoreFunctionInfo):
(JSC::Parser::pushScope): Adapt to use scope flags and their
accessors instead of bit-booleans.
* parser/Parser.cpp:
(JSC::::Parser):
(JSC::::parseInner):
(JSC::::didFinishParsing):
(JSC::::parseSourceElements):
(JSC::::parseVarDeclarationList):
(JSC::::parseConstDeclarationList):
(JSC::::parseWithStatement):
(JSC::::parseTryStatement):
(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::::parsePrimaryExpression): Hoist some of the flag handling
out of the "context" (ASTBuilder or SyntaxChecker) and to here.
Does not seem to have a performance impact.

* parser/SourceProviderCacheItem.h (SourceProviderCacheItem):
Cache the scopeflags.
* parser/SyntaxChecker.h: Remove evalCount() decl.

* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):
* runtime/Executable.h:
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::usesEval):
(JSC::ScriptExecutable::usesArguments):
(JSC::ScriptExecutable::needsActivation):
(JSC::ScriptExecutable::isStrictMode):
(JSC::ScriptExecutable::recordParse):
(ScriptExecutable): ScopeFlags, not features.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening.
commit | commitdiff | tree
ossy@webkit.org [Fri, 9 Mar 2012 12:03:57 +0000 (12:03 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped: Skip new tests without expected files, need investigation.
* platform/qt/http/tests/navigation/javascriptlink-frames-expected.png: Updated.
* platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd SVGRenderingContext and move there the context related code from SVGRenderSupport
commit | commitdiff | tree
zherczeg@webkit.org [Fri, 9 Mar 2012 12:02:50 +0000 (12:02 +0000)]
Add SVGRenderingContext and move there the context related code from SVGRenderSupport
https://bugs.webkit.org/show_bug.cgi?id=80413

Reviewed by Nikolas Zimmermann.

This is the first step of refactoring the rendering context for SVG. The
previous context was stateless before, which means the cleanup phase
needed to do a lot of checks to revert the initialization part and
was unaware of failed inititalization. Future code can also add
new local variables to the context.

This patch add a new SVGRenderingContext class, and moves there the context
initialization / cleanup code from SVGRenderSupport. All build systems were
updated.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/svg/RenderSVGAllInOne.cpp:
* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::paint):
* rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::paint):
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paintReplaced):
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::paint):
* rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::paint):
* rendering/svg/SVGRenderSupport.cpp:
* rendering/svg/SVGRenderSupport.h:
* rendering/svg/SVGRenderingContext.cpp: Added.
(WebCore):
(WebCore::isRenderingMaskImage):
(WebCore::SVGRenderingContext::~SVGRenderingContext):
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):
* rendering/svg/SVGRenderingContext.h: Added.
(WebCore):
(SVGRenderingContext):
(WebCore::SVGRenderingContext::SVGRenderingContext):
(WebCore::SVGRenderingContext::isRenderingPrepared):
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Gardening, skip 3 failing tests.
commit | commitdiff | tree
ossy@webkit.org [Fri, 9 Mar 2012 11:45:42 +0000 (11:45 +0000)]
[Qt] Gardening, skip 3 failing tests.

Patch by Nándor Huszka <huszka.nandor@stud.u-szeged.hu> on 2012-03-09
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r110191, r110202, and r110279.
commit | commitdiff | tree
ossy@webkit.org [Fri, 9 Mar 2012 11:16:35 +0000 (11:16 +0000)]
Unreviewed, rolling out r110191, r110202, and r110279.
http://trac.webkit.org/changeset/110191
http://trac.webkit.org/changeset/110202
http://trac.webkit.org/changeset/110279
https://bugs.webkit.org/show_bug.cgi?id=80694

They broke !ENABLE(INSPECTOR) builds (Requested by Ossy on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-09

.:

* Source/autotools/symbols.filter:

Source/WebCore:

* WebCore.exp.in:
* testing/Internals.cpp:
* testing/Internals.h:
(WebCore):
(Internals):
* testing/Internals.idl:

Source/WebKit/chromium:

* features.gypi:

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

* inspector/elements/highlight-node-expected.txt: Removed.
* inspector/elements/highlight-node.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake check-webkit-style complain about "no new tests" lines in changelogs
commit | commitdiff | tree
nduca@chromium.org [Fri, 9 Mar 2012 11:13:43 +0000 (11:13 +0000)]
Make check-webkit-style complain about "no new tests" lines in changelogs
https://bugs.webkit.org/show_bug.cgi?id=80582

Reviewed by David Levin.

* Scripts/webkitpy/style/checkers/changelog.py:
(ChangeLogChecker.check_entry):
* Scripts/webkitpy/style/checkers/changelog_unittest.py:
(ChangeLogCheckerTest.test_no_new_tests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSpeech JavaScript API: add SpeechGrammar and SpeechGrammarList
commit | commitdiff | tree
hans@chromium.org [Fri, 9 Mar 2012 10:56:31 +0000 (10:56 +0000)]
Speech JavaScript API: add SpeechGrammar and SpeechGrammarList
https://bugs.webkit.org/show_bug.cgi?id=80417

Reviewed by Adam Barth.

Source/WebCore:

Implement SpeechGrammar and SpeechGrammarList.
(Spec: http://speech-javascript-api-spec.googlecode.com/git/speechapi.html)

Test: fast/speech/scripted/speechgrammar-basics.html

* Modules/speech/DOMWindowSpeech.idl:
* Modules/speech/SpeechGrammar.cpp:
(WebCore):
(WebCore::SpeechGrammar::create):
(WebCore::SpeechGrammar::SpeechGrammar):
* Modules/speech/SpeechGrammar.h:
(WebCore):
(SpeechGrammar):
(WebCore::SpeechGrammar::src):
(WebCore::SpeechGrammar::setSrc):
(WebCore::SpeechGrammar::weight):
(WebCore::SpeechGrammar::setWeight):
* Modules/speech/SpeechGrammar.idl:
* Modules/speech/SpeechGrammarList.cpp:
(WebCore):
(WebCore::SpeechGrammarList::create):
(WebCore::SpeechGrammarList::item):
(WebCore::SpeechGrammarList::addFromUri):
(WebCore::SpeechGrammarList::addFromString):
(WebCore::SpeechGrammarList::SpeechGrammarList):
* Modules/speech/SpeechGrammarList.h:
(WebCore):
(SpeechGrammarList):
(WebCore::SpeechGrammarList::length):
* Modules/speech/SpeechGrammarList.idl:
* WebCore.gypi:

LayoutTests:

Add a test for SpeechGrammar and SpeechGrammarList.

* fast/speech/scripted/speechgrammar-basics-expected.txt: Added.
* fast/speech/scripted/speechgrammar-basics.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r110269.
commit | commitdiff | tree
ossy@webkit.org [Fri, 9 Mar 2012 10:39:09 +0000 (10:39 +0000)]
Unreviewed, rolling out r110269.
http://trac.webkit.org/changeset/110269
https://bugs.webkit.org/show_bug.cgi?id=80688

It made inspector/elements/highlight-node.html fail everywhere
(Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-09

* testing/Internals.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Unreviewed, build fix after r110191
commit | commitdiff | tree
apavlov@chromium.org [Fri, 9 Mar 2012 09:55:30 +0000 (09:55 +0000)]
[chromium] Unreviewed, build fix after r110191

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: [Styles] Click in the first line of rule while editing property starts...
commit | commitdiff | tree
apavlov@chromium.org [Fri, 9 Mar 2012 09:51:56 +0000 (09:51 +0000)]
Web Inspector: [Styles] Click in the first line of rule while editing property starts a new property
https://bugs.webkit.org/show_bug.cgi?id=80507

Reviewed by Vsevolod Vlasov.

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._checkWillCancelEditing):
(WebInspector.StylePropertiesSection.prototype._handleSelectorContainerClick):
(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceClick):
(WebInspector.StylePropertyTreeElement.prototype.onattach):
(WebInspector.StylePropertyTreeElement.prototype):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/11012024> Fix the build by working around <rdar://problem/10710970>.
commit | commitdiff | tree
mrowe@apple.com [Fri, 9 Mar 2012 09:33:51 +0000 (09:33 +0000)]
<rdar://problem/11012024> Fix the build by working around <rdar://problem/10710970>.

* platform/mac/RunLoopMac.mm:
(WebCore::RunLoop::stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Gardening, skip two failing tests and a timeouting one.
commit | commitdiff | tree
ossy@webkit.org [Fri, 9 Mar 2012 09:27:39 +0000 (09:27 +0000)]
[Qt] Gardening, skip two failing tests and a timeouting one.

Patch by Nándor Huszka <huszka.nandor@stud.u-szeged.hu> on 2012-03-09
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFileInputType doesn't support (save|restore)FormControlState
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 9 Mar 2012 09:01:42 +0000 (09:01 +0000)]
FileInputType doesn't support (save|restore)FormControlState
https://bugs.webkit.org/show_bug.cgi?id=80145

Patch by Marja Hölttä <marja@google.com> on 2012-03-09
Reviewed by Kent Tamura.

Source/WebCore:

This enables saving and restoring the state of file upload elements in
unsubmitted forms.

Test: fast/forms/file/recover-file-input-in-unposted-form.html

* html/BaseCheckableInputType.cpp:
(WebCore::BaseCheckableInputType::restoreFormControlState): non-const
* html/BaseCheckableInputType.h:
(BaseCheckableInputType): restoreFormControlState non-const
* html/FileInputType.cpp:
(WebCore::FileInputType::saveFormControlState): save chosen files
(WebCore):
(WebCore::FileInputType::restoreFormControlState): restore chosen files
* html/FileInputType.h:
(FileInputType): overwrite (save|restore)FormControlState
* html/HiddenInputType.cpp:
(WebCore::HiddenInputType::restoreFormControlState): non-const
* html/HiddenInputType.h:
(HiddenInputType): restoreFormControlState non-const
* html/InputType.cpp:
(WebCore::InputType::restoreFormControlState): non-const
* html/InputType.h:
(InputType): restoreFormControlState non-const
* html/PasswordInputType.cpp:
(WebCore::PasswordInputType::restoreFormControlState): non-const
* html/PasswordInputType.h:
(PasswordInputType): restoreFormControlState non-const

LayoutTests:

Tests for saving and restoring the state of file upload elements in unsubmitted forms.

* fast/forms/file/recover-file-input-in-unposted-form-expected.txt: Added.
* fast/forms/file/recover-file-input-in-unposted-form.html: Added.
* platform/wk2/Skipped: The added test needs eventSender.beginDragWithFiles.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WebSocket] Add a layout test where server force to disable all extensions
commit | commitdiff | tree
toyoshim@chromium.org [Fri, 9 Mar 2012 08:48:16 +0000 (08:48 +0000)]
[WebSocket] Add a layout test where server force to disable all extensions
https://bugs.webkit.org/show_bug.cgi?id=80650

Reviewed by Kent Tamura.

* http/tests/websocket/tests/hybi/echo-with-no-extension-expected.txt: Added.
* http/tests/websocket/tests/hybi/echo-with-no-extension.html: Check if extension property is always empty string.
* http/tests/websocket/tests/hybi/echo-with-no-extension_wsh.py: Added a handler which disable all extensions.
(web_socket_do_extra_handshake):
(web_socket_transfer_data):
* http/tests/websocket/tests/hybi/extensions-expected.txt: Updated.
* http/tests/websocket/tests/hybi/extensions.html: Added the case after connection is established.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r110250.
commit | commitdiff | tree
ossy@webkit.org [Fri, 9 Mar 2012 08:42:21 +0000 (08:42 +0000)]
Unreviewed, rolling out r110250.
http://trac.webkit.org/changeset/110250
https://bugs.webkit.org/show_bug.cgi?id=80682

It made NRWT ignore test_expectations.txt on Qt-WK2 and ignore
qt-linux at all. (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-09

* Scripts/old-run-webkit-tests:
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort):
(QtPort.determine_full_port_name):
(QtPort.baseline_search_path):
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest):
(QtPortTest._assert_search_path):
(QtPortTest.test_baseline_search_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Use Qt's module system for install rules and depending on QtWebKit
commit | commitdiff | tree
vestbo@webkit.org [Fri, 9 Mar 2012 07:39:50 +0000 (07:39 +0000)]
[Qt] Use Qt's module system for install rules and depending on QtWebKit

Instead of rolling our own install rules we now use the same approach as
every other Qt module, by loading qt_module.prf and qt_module_config.prf.

This ensures that we follow the same semantics as the rest of Qt on
what sort of config options are enabled by default (create_cmake eg.).
It also allows us to use QT += webkit instead of the workaround we had
with CONFIG += qtwebkit.

We do however force Qt to always treat our build as a non-developer build,
so the libraries will end up in the WebKit lib directory instead of the
qtbase directory (as with a normal developer-build). This allows us to
keep the webkit-build self-contained. If Qt is a developer build we still
copy the module file manually to Qt, so that you don't have to install
WebKit to make it available.

For non-developer builds of Qt, it is still possible to use the built
WebKit libraries without having to install them, by having the variable
QMAKE_EXTRA_MODULE_FORWARDS set in the project's .qmake.cache file,
pointing to $WEBKITOUTUTDIR/$CONFIGURATION/modules.

https://bugs.webkit.org/show_bug.cgi?id=80590

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBase the access to CSSStyleDeclaration on the CSSPropertyID instead of the PropertyName
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 9 Mar 2012 07:33:56 +0000 (07:33 +0000)]
Base the access to CSSStyleDeclaration on the CSSPropertyID instead of the PropertyName
https://bugs.webkit.org/show_bug.cgi?id=80461

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-08
Reviewed by Geoffrey Garen.

Previously, the acces to CSS Style properties was done through a NamedGetter. This caused
the (slow) mapping between CSSPropertyName and CSSPropertyID to be done twice for every acess:
1) canGetItemsForName() prior to the definition of the slot.
2) nameGetter() called from the slot with CSSPropertyName to get the actual value.

This patch changes the access to be based on CSSPropertyID. The slot is defined with the
CSSPropertyID as the customIndex, and the value can be accessed directly when the slot is
called.

To handle the differences create by hadPixelOrPosPrefix, two nearly identical callback are defined,
one for hadPixelOrPosPrefix, the other for !hadPixelOrPosPrefix.

The performance gain is about 19% when accessing CSS properties.

* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::getPropertyValueFallback):
(WebCore::cssPropertyGetterPixelOrPosPrefix):
(WebCore):
(WebCore::cssPropertyGetterPixelOrPosPrefixCallback):
(WebCore::cssPropertyGetter):
(WebCore::cssPropertyGetterCallback):
(WebCore::JSCSSStyleDeclaration::getOwnPropertySlotDelegate):
(WebCore::JSCSSStyleDeclaration::getOwnPropertyDescriptorDelegate):
* css/CSSStyleDeclaration.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Texmap][EFL] Implementation of AcceleratedCompositingContext for EFL port
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 9 Mar 2012 07:33:49 +0000 (07:33 +0000)]
[Texmap][EFL] Implementation of AcceleratedCompositingContext for EFL port
https://bugs.webkit.org/show_bug.cgi?id=80266

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-03-08
Reviewed by Noam Rosenthal.

This patch adds EFL's implementation of AcceleratedCompositingContext to WebCoreSupport.

* WebCoreSupport/AcceleratedCompositingContextEfl.cpp: Added.
(WebCore):
(WebCore::AcceleratedCompositingContext::create):
(WebCore::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebCore::AcceleratedCompositingContext::~AcceleratedCompositingContext):
(WebCore::AcceleratedCompositingContext::initialize):
(WebCore::AcceleratedCompositingContext::syncLayersNow):
(WebCore::AcceleratedCompositingContext::renderLayers):
(WebCore::AcceleratedCompositingContext::attachRootGraphicsLayer):
(WebCore::AcceleratedCompositingContext::context):
* WebCoreSupport/AcceleratedCompositingContextEfl.h: Added.
(WebCore):
(AcceleratedCompositingContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix Qt minimal build
commit | commitdiff | tree
vestbo@webkit.org [Fri, 9 Mar 2012 07:30:51 +0000 (07:30 +0000)]
[Qt] Fix Qt minimal build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix for MSVC after r110266
commit | commitdiff | tree
benjamin@webkit.org [Fri, 9 Mar 2012 07:21:50 +0000 (07:21 +0000)]
Build fix for MSVC after r110266

Unreviewed. A #ifdef for MSVC was left over in r110266.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-08

* runtime/RegExpObject.h:
(RegExpObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Remove dead CoreGraphics code from chromium compositor implementation
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 9 Mar 2012 07:16:05 +0000 (07:16 +0000)]
[chromium] Remove dead CoreGraphics code from chromium compositor implementation
https://bugs.webkit.org/show_bug.cgi?id=80470

Patch by James Robinson <jamesr@chromium.org> on 2012-03-08
Reviewed by Adam Barth.

We haven't supported CoreGraphics as a raster backend in chromium for a few months and do not plan to do so, so
it's time to remove the USE(CG) #ifdefs from our compositor and just rely on USE(SKIA) being set.  This also
slightly simplifies how PlatformCanvas works.

* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):
* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):
* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h:
* platform/graphics/chromium/ImageLayerChromium.h:
* platform/graphics/chromium/LayerChromium.cpp:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/PlatformCanvas.cpp:
(WebCore::PlatformCanvas::createBackingCanvas):
(WebCore::PlatformCanvas::AutoLocker::AutoLocker):
(WebCore::PlatformCanvas::AutoLocker::~AutoLocker):
(WebCore):
(WebCore::PlatformCanvas::AutoLocker::pixels):
(WebCore::PlatformCanvas::Painter::Painter):
* platform/graphics/chromium/PlatformCanvas.h:
(WebCore):
(AutoLocker):
(Painter):
(PlatformCanvas):
* platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:
* platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAllocate the RegExpObject's data with the Cell
commit | commitdiff | tree
benjamin@webkit.org [Fri, 9 Mar 2012 06:49:55 +0000 (06:49 +0000)]
Allocate the RegExpObject's data with the Cell
https://bugs.webkit.org/show_bug.cgi?id=80654

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-08
Reviewed by Gavin Barraclough.

This patch removes the creation of RegExpObject's data to avoid the overhead
create by the allocation and destruction.

We RegExp are created repeatedly, this provides some performance improvment.
The PeaceKeeper test stringDetectBrowser improves by 10%.

* runtime/RegExpObject.cpp:
(JSC::RegExpObject::RegExpObject):
(JSC::RegExpObject::visitChildren):
(JSC::RegExpObject::getOwnPropertyDescriptor):
(JSC::RegExpObject::defineOwnProperty):
(JSC::RegExpObject::match):
* runtime/RegExpObject.h:
(JSC::RegExpObject::setRegExp):
(JSC::RegExpObject::regExp):
(JSC::RegExpObject::setLastIndex):
(JSC::RegExpObject::getLastIndex):
(RegExpObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Update my email.
commit | commitdiff | tree
igor.o@sisa.samsung.com [Fri, 9 Mar 2012 06:20:39 +0000 (06:20 +0000)]
Unreviewed. Update my email.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/JavaScriptCore: Separate WTF parts of JavaScriptCoreGenerated into WTFGenerate...
commit | commitdiff | tree
sfalken@apple.com [Fri, 9 Mar 2012 06:19:43 +0000 (06:19 +0000)]
Source/JavaScriptCore: Separate WTF parts of JavaScriptCoreGenerated into WTFGenerated for Windows build
https://bugs.webkit.org/show_bug.cgi?id=80657

Preparation for WTF separation from JavaScriptCore.
The "Generated" vcproj files on Windows are necessary so Visual Studio can calculate correct
dependencies for generated files.

This also removes the PGO build targets from the WTF code, since we can't build instrumentation/optimization
versions of the WTF code independent of the JavaScriptCore code.

Reviewed by Jessie Berlin.

* JavaScriptCore.vcproj/JavaScriptCore.sln: Add WTFGenerated, update dependent projects.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Removed WTF specific parts.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Removed WTF specific parts.
* JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Removed WTF specific parts.
* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: Removed WTF specific parts.
* JavaScriptCore.vcproj/JavaScriptCore/work-around-vs-dependency-tracking-bugs.py: Removed.
* JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Add WTFGenerated, update dependent projects.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Remove PGO targets from WTF.
* JavaScriptCore.vcproj/WTF/WTFGenerated.make: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
* JavaScriptCore.vcproj/WTF/WTFGenerated.vcproj: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj.
* JavaScriptCore.vcproj/WTF/WTFGeneratedCommon.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedCommon.vsprops.
* JavaScriptCore.vcproj/WTF/WTFGeneratedDebug.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebug.vsprops.
* JavaScriptCore.vcproj/WTF/WTFGeneratedDebugAll.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebugAll.vsprops.
* JavaScriptCore.vcproj/WTF/WTFGeneratedDebugCairoCFLite.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebugCairoCFLite.vsprops.
* JavaScriptCore.vcproj/WTF/WTFGeneratedProduction.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedProduction.vsprops.
* JavaScriptCore.vcproj/WTF/WTFGeneratedRelease.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedRelease.vsprops.
* JavaScriptCore.vcproj/WTF/WTFGeneratedReleaseCairoCFLite.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedReleaseCairoCFLite.vsprops.
* JavaScriptCore.vcproj/WTF/WTFReleasePGO.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/build-generated-files.sh: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh.
* JavaScriptCore.vcproj/WTF/copy-files.cmd: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd.
* JavaScriptCore.vcproj/WTF/work-around-vs-dependency-tracking-bugs.py: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/work-around-vs-dependency-tracking-bugs.py.

Source/WebKit/win: Separate WTF parts of JavaScriptCoreGenerated into WTFGenerated for Windows build
https://bugs.webkit.org/show_bug.cgi?id=80657

Preparation for WTF separation from JavaScriptCore.
The "Generated" vcproj files on Windows are necessary so Visual Studio can calculate correct
dependencies for generated files.

Reviewed by Jessie Berlin.

* WebKit.vcproj/WebKit.sln: Add WTFGenerated, update dependent projects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGet rid of itemTypeAttributeChanged
commit | commitdiff | tree
rniwa@webkit.org [Fri, 9 Mar 2012 06:08:03 +0000 (06:08 +0000)]
Get rid of itemTypeAttributeChanged
https://bugs.webkit.org/show_bug.cgi?id=80666

Reviewed by Adam Barth.

This function is unnecessay as we can invalidate m_microDataItemListCaches
in invalidateCachesThatDependOnAttributes as done for other node lists.

* dom/Node.cpp:
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged):
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes):
* dom/Node.h:
* dom/NodeRareData.h:
(NodeListsNodeData):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r108616.
commit | commitdiff | tree
simon.fraser@apple.com [Fri, 9 Mar 2012 05:55:07 +0000 (05:55 +0000)]
Unreviewed, rolling out r108616.
http://trac.webkit.org/changeset/108616
https://bugs.webkit.org/show_bug.cgi?id=80676

breaks animation on Safari welcome page (Requested by smfr on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-08

* page/animation/AnimationController.cpp:
(WebCore::AnimationController::updateAnimations):
* page/animation/AnimationControllerPrivate.h:
(AnimationControllerPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the build of WebKit with WTFURL following the removal of ForwardingHeaders/wtf
commit | commitdiff | tree
benjamin@webkit.org [Fri, 9 Mar 2012 05:52:17 +0000 (05:52 +0000)]
Fix the build of WebKit with WTFURL following the removal of ForwardingHeaders/wtf
https://bugs.webkit.org/show_bug.cgi?id=80652

Reviewed by Eric Seidel.

Source/JavaScriptCore:

Fix the header, URLSegments.h is not part of the API.

* wtf/url/api/ParsedURL.h:

Source/WebCore:

The fowarding headers have been removed, we must now use the full path to the header.

* platform/KURLWTFURLImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChange calcRadiiFor to IntSize
commit | commitdiff | tree
eae@chromium.org [Fri, 9 Mar 2012 05:00:41 +0000 (05:00 +0000)]
Change calcRadiiFor to IntSize
https://bugs.webkit.org/show_bug.cgi?id=80655

Reviewed by Simon Fraser.

Borders and RoundedRect are both represented with pixel precision. As
such it doesn't make sense for calcRadiiFor to use subpixel units, it
just adds unnecessary type conversions.

No new tests, no new functionality.

* rendering/style/RenderStyle.cpp:
(WebCore::calcRadiiFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Encapsulate mask layer settings in LayerChromium
commit | commitdiff | tree
enne@google.com [Fri, 9 Mar 2012 04:43:57 +0000 (04:43 +0000)]
[chromium] Encapsulate mask layer settings in LayerChromium
https://bugs.webkit.org/show_bug.cgi?id=80646

Reviewed by James Robinson.

If a WebLayer sets a mask layer, the setIsMask flag will not get set
properly and the mask layer will not turn off tiling. This was only
being set through GraphicsLayerChromium. Move this flag into
LayerChromium so that it always gets set.

Test: LayoutTests/compositing/

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setMaskLayer):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setMaskLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRecent changes to chromium.py etc. broke chromium_android.py
commit | commitdiff | tree
wangxianzhu@chromium.org [Fri, 9 Mar 2012 04:28:32 +0000 (04:28 +0000)]
Recent changes to chromium.py etc. broke chromium_android.py
https://bugs.webkit.org/show_bug.cgi?id=80623

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver.__init__):
(ChromiumAndroidDriver._start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agomargins on flex-align: baseline are double counted
commit | commitdiff | tree
tony@chromium.org [Fri, 9 Mar 2012 04:27:12 +0000 (04:27 +0000)]
margins on flex-align: baseline are double counted
https://bugs.webkit.org/show_bug.cgi?id=80645

Reviewed by Ojan Vafai.

Source/WebCore:

Fix a bug where we're counting the margins on baseline aligned
children twice. Also add some test cases to make sure we handle
wrap-reverse baseline alignment properly.

Tests: css3/flexbox/multiline-reverse-wrap-baseline-expected.html
       css3/flexbox/multiline-reverse-wrap-baseline.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):

LayoutTests:

* css3/flexbox/multiline-reverse-wrap-baseline-expected.html: Added.
* css3/flexbox/multiline-reverse-wrap-baseline.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Exception running reftest with --no-pixel-tests
commit | commitdiff | tree
wangxianzhu@chromium.org [Fri, 9 Mar 2012 04:07:43 +0000 (04:07 +0000)]
[Chromium] Exception running reftest with --no-pixel-tests
https://bugs.webkit.org/show_bug.cgi?id=80642

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.__init__):
(ChromiumDriver._wrapper_options):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Pass setVisibility to CCLayerTreeHostImpl regardless of LRC initialization...
commit | commitdiff | tree
nduca@chromium.org [Fri, 9 Mar 2012 03:52:25 +0000 (03:52 +0000)]
[chromium] Pass setVisibility to CCLayerTreeHostImpl regardless of LRC initialization status
https://bugs.webkit.org/show_bug.cgi?id=80584

Reviewed by James Robinson.

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::setVisible):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Allow transparent WebViews
commit | commitdiff | tree
noam.rosenthal@nokia.com [Fri, 9 Mar 2012 03:43:49 +0000 (03:43 +0000)]
[Qt][WK2] Allow transparent WebViews
https://bugs.webkit.org/show_bug.cgi?id=80608

Reviewed by Tor Arne Vestbø.

Added support for transparentBackground in QQuickWebViewExperimental.
This uses the existing drawsTransparentBackground property in WebKit2.
Also, changed LayerTreeHostQt to set the contentsOpaque flag when the root layer changes,
otherwise the change doesn't take effect.

A new API test was added.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::setTransparentBackground):
(QQuickWebViewPrivate::transparentBackground):
(QQuickWebViewExperimental::transparentBackground):
(QQuickWebViewExperimental::setTransparentBackground):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView):
(tst_QQuickWebView::transparentWebViews):
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::setRootCompositingLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agorename flexbox tests to describe what is actually being tested
commit | commitdiff | tree
tony@chromium.org [Fri, 9 Mar 2012 03:35:43 +0000 (03:35 +0000)]
rename flexbox tests to describe what is actually being tested
https://bugs.webkit.org/show_bug.cgi?id=80636

Reviewed by Ojan Vafai.

* css3/flexbox/flex-algorithm-expected.txt: Renamed from LayoutTests/css3/flexbox/001-expected.txt.
* css3/flexbox/flex-algorithm-min-max-expected.txt: Renamed from LayoutTests/css3/flexbox/003-expected.txt.
* css3/flexbox/flex-algorithm-min-max.html: Renamed from LayoutTests/css3/flexbox/003.html.
* css3/flexbox/flex-algorithm-with-margins-expected.txt: Renamed from LayoutTests/css3/flexbox/002-expected.txt.
* css3/flexbox/flex-algorithm-with-margins.html: Renamed from LayoutTests/css3/flexbox/002.html.
* css3/flexbox/flex-algorithm.html: Renamed from LayoutTests/css3/flexbox/001.html.
* css3/flexbox/flex-pack-expected.txt: Renamed from LayoutTests/css3/flexbox/004-expected.txt.
* css3/flexbox/flex-pack.html: Renamed from LayoutTests/css3/flexbox/004.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Ensure that the cc thread animation framework continues to tick when the...
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 9 Mar 2012 03:25:37 +0000 (03:25 +0000)]
[chromium] Ensure that the cc thread animation framework continues to tick when the tab is backgrounded
https://bugs.webkit.org/show_bug.cgi?id=77668

Patch by Ian Vollick <vollick@chromium.org> on 2012-03-08
Reviewed by James Robinson.

Source/WebCore:

Tested in CCLayerTreeHostTestTickAnimationWhileBackgrounded

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(CCLayerTreeHostImplTimeSourceAdapter):
(WebCore::CCLayerTreeHostImplTimeSourceAdapter::create):
(WebCore::CCLayerTreeHostImplTimeSourceAdapter::~CCLayerTreeHostImplTimeSourceAdapter):
(WebCore::CCLayerTreeHostImplTimeSourceAdapter::onTimerTick):
(WebCore::CCLayerTreeHostImplTimeSourceAdapter::setActive):
(WebCore::CCLayerTreeHostImplTimeSourceAdapter::CCLayerTreeHostImplTimeSourceAdapter):
(WebCore):
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setVisible):
(WebCore::CCLayerTreeHostImpl::animateLayers):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore):
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCProxy.cpp:
(WebCore::CCProxy::currentThread):
(WebCore):
(WebCore::CCProxy::isMainThread):
(WebCore::CCProxy::isImplThread):
(WebCore::CCProxy::setCurrentThreadIsImplThread):
* platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):

Source/WebKit/chromium:

* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::postAddInstantAnimationToMainThread):
(CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::dispatchAddInstantAnimation):
(WTF::CCLayerTreeHostTest::dispatchAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::beginTest):
(WTF):
(CCLayerTreeHostTestTickAnimationWhileBackgrounded):
(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::CCLayerTreeHostTestTickAnimationWhileBackgrounded):
(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::beginTest):
(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::animateLayers):
(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::afterTest):
(WTF::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Only build NEON files if target_arch=="arm"
commit | commitdiff | tree
thakis@chromium.org [Fri, 9 Mar 2012 03:21:02 +0000 (03:21 +0000)]
[chromium] Only build NEON files if target_arch=="arm"
https://bugs.webkit.org/show_bug.cgi?id=80626

Currently, webcore_arm_neon will compile a bunch of files
whose contents are completely ifdef'd away on non-arm, and
then bundle all the generated empty .o files into a useless
libwebcore_arm_neon.a. Don't do this.

Reviewed by Tony Chang.

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[NRWT] Fix --platform=qt-5.0 --new-baseline combo
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 9 Mar 2012 03:07:22 +0000 (03:07 +0000)]
[NRWT] Fix --platform=qt-5.0 --new-baseline combo
https://bugs.webkit.org/show_bug.cgi?id=72489

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-03-08
Reviewed by Dirk Pranke.

NRWT: The default platform name for Qt combined with --webkit-test-runner is now
"qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
--platform will override the platform name and then we'll use it.

ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
override it in the end.

* Scripts/old-run-webkit-tests:
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort):
(QtPort.determine_full_port_name):
(QtPort.baseline_search_path):
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest):
(QtPortTest._assert_search_path):
(QtPortTest.test_baseline_search_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[BlackBerry] Fix warning in PlatformTouchEventBlackBerry.cpp
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 9 Mar 2012 03:05:31 +0000 (03:05 +0000)]
[BlackBerry] Fix warning in PlatformTouchEventBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=80621

Fixes a warning seen when control reaches the end of a
non-void function.  Return TouchCancel in the 'default' case.

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-03-08
Reviewed by Rob Buis.

* platform/blackberry/PlatformTouchEventBlackBerry.cpp:
(WebCore::touchEventType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGTK+ build fix. Only try to get the backing from the layer in when
commit | commitdiff | tree
kov@webkit.org [Fri, 9 Mar 2012 02:53:23 +0000 (02:53 +0000)]
GTK+ build fix. Only try to get the backing from the layer in when
ACCELERATED_COMPOSITING is enabled.

Rubber-stamped by Ryosuke Niwa.

* WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::screenRectOfContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Using wrong scissor rect for draw culling
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 9 Mar 2012 02:50:07 +0000 (02:50 +0000)]
[chromium] Using wrong scissor rect for draw culling
https://bugs.webkit.org/show_bug.cgi?id=80624

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-08
Reviewed by Adrienne Walker.

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::optimizeRenderPasses):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, update chromium test expectations.
commit | commitdiff | tree
ukai@chromium.org [Fri, 9 Mar 2012 02:33:03 +0000 (02:33 +0000)]
Unreviewed, update chromium test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Force the Canvas2D GPU texture cache to 0 bytes for backgrounded tabs.
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 9 Mar 2012 02:30:14 +0000 (02:30 +0000)]
[chromium] Force the Canvas2D GPU texture cache to 0 bytes for backgrounded tabs.
https://bugs.webkit.org/show_bug.cgi?id=79948

Patch by Jeff Timanus <twiz@chromium.org> on 2012-03-08
Reviewed by Stephen White.

* src/GraphicsContext3DChromium.cpp:
(WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
(WebCore::GraphicsContext3DPrivate::grContext):
(WebCore::GraphicsContext3DPrivate::setVisibilityCHROMIUM):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix some Leopard tests that broke with r110229.
commit | commitdiff | tree
ojan@chromium.org [Fri, 9 Mar 2012 02:25:51 +0000 (02:25 +0000)]
Fix some Leopard tests that broke with r110229.

* platform/chromium-mac-leopard/fast/table/cell-coalescing-expected.png: Added.
* platform/chromium-mac-leopard/fast/table/floating-th-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/complex-text-opacity-expected.txt: Added.
* platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt: Added.
* platform/chromium-mac-leopard/fast/text/international/bidi-CS-after-AN-expected.txt: Added.
* platform/chromium-mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Added.
* platform/chromium-mac-leopard/fast/text/international/thai-baht-space-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/text/wbr-pre-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/whitespace/001-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/whitespace/019-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/whitespace/023-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/whitespace/028-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/whitespace/029-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/whitespace/pre-newline-box-test-expected.png: Added.
* platform/chromium-mac-leopard/fast/writing-mode/border-vertical-lr-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/xsl/xslt-enc-cyr-expected.png: Added.
* platform/chromium-mac-leopard/fast/xsl/xslt-enc-expected.png: Added.
* platform/chromium-mac-leopard/fast/xsl/xslt-enc16-expected.png: Added.
* platform/chromium-mac-leopard/fast/xsl/xslt-enc16to16-expected.png: Added.
* platform/chromium-mac-leopard/fast/xsl/xslt-extra-content-at-end-expected.png: Added.
* platform/chromium-mac-leopard/fast/xsl/xslt_unicode-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r105396): Dragging an iWork document into icloud.com opens it in the...
commit | commitdiff | tree
aestes@apple.com [Fri, 9 Mar 2012 02:24:36 +0000 (02:24 +0000)]
REGRESSION (r105396): Dragging an iWork document into icloud.com opens it in the Mac app instead of uploading it to icloud.com
https://bugs.webkit.org/show_bug.cgi?id=79443

Reviewed by Ryosuke Niwa.

Source/WebCore:

icloud.com registers a drop event handler that sets display:none on the
file input element receiving the drop. After dispatching the drop event,
DragController hit tests the position under the mouse to see if it is a
file input element in need of receiving files. Since the file input
element has lost its renderer, it cannot be found by hit testing, so
the dropped file is never attached to the file input element, no change
event fires, and no upload commences. We want these things to happen
even if the element is no longer visible.

Since we already keep track of the file input element under the mouse
via m_fileInputElementUnderMouse, this additional hit test is
unnecessary. Use m_fileInputElementUnderMouse in concludeEditDrag()
when dropping files.

Test: fast/events/file-input-hidden-in-ondrop.html

* page/DragController.cpp:
(WebCore::DragController::concludeEditDrag): Use
m_fileInputElementUnderMouse instead of the element returned by hit
testing. Assert that m_fileInputElementUnderMouse equals the hit tested
element unless m_fileInputElementUnderMouse doesn't have a renderer.

LayoutTests:

* fast/events/file-input-hidden-in-ondrop-expected.txt: Added.
* fast/events/file-input-hidden-in-ondrop.html: Added.
* platform/wk2/Skipped: WebKitTestRunner doesn't support
EventSender.beginDragWithFiles().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Replace completelyContains with Region::contains()
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 9 Mar 2012 02:19:38 +0000 (02:19 +0000)]
[chromium] Replace completelyContains with Region::contains()
https://bugs.webkit.org/show_bug.cgi?id=80617

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-08
Reviewed by James Robinson.

* tests/CCLayerTestCommon.cpp:
(CCLayerTestCommon):
(CCLayerTestCommon::verifyQuadsExactlyCoverRect):
* tests/CCLayerTestCommon.h:
(CCLayerTestCommon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMoar Chromium Lion rebaselines.
commit | commitdiff | tree
ojan@chromium.org [Fri, 9 Mar 2012 01:53:41 +0000 (01:53 +0000)]
Moar Chromium Lion rebaselines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] more comprehensive tests for gesture scrolling
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 9 Mar 2012 01:27:31 +0000 (01:27 +0000)]
[chromium] more comprehensive tests for gesture scrolling
https://bugs.webkit.org/show_bug.cgi?id=80201

Prior to landing some changes to EventHandler::handleGestureEvent, add
some tests to ensure that the behaviour of handleGestureEvent and
handleWheelEvent don't regress.

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-08
Reviewed by Dimitri Glazkov.

* fast/events/touch/gesture/resources/gesture-helpers.js: Added: utility functions.
(recordWheel):
(recordScroll):
(exitIfNecessary):
(checkTestDependencies):
(checkScrollOffset):
* fast/events/touch/gesture/resources/scroll-inside-iframe.html: Added.
* fast/events/touch/gesture/touch-gesture-scroll-div-expected.txt: Added.
* fast/events/touch/gesture/touch-gesture-scroll-div.html: Added.
* fast/events/touch/gesture/touch-gesture-scroll-iframe-expected.txt: Added.
* fast/events/touch/gesture/touch-gesture-scroll-iframe.html: Added.
* fast/events/touch/gesture/touch-gesture-scroll-page-expected.txt: Added.
* fast/events/touch/gesture/touch-gesture-scroll-page.html: Added.
* fast/events/touch/gesture/touch-gesture-scroll-shy-target-expected.txt: Added.
* fast/events/touch/gesture/touch-gesture-scroll-shy-target.html: Added.
* platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-div-expected.txt: Added.
* platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-iframe-expected.txt: Added.
* platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-page-expected.txt: Added.
* platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-shy-target-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMac build fix for micro data API.
commit | commitdiff | tree
rniwa@webkit.org [Fri, 9 Mar 2012 01:22:49 +0000 (01:22 +0000)]
Mac build fix for micro data API.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::removeCachedMicroDataItemList):
* html/HTMLElement.idl:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Unreviewed gardening.
commit | commitdiff | tree
senorblanco@chromium.org [Fri, 9 Mar 2012 01:13:47 +0000 (01:13 +0000)]
[chromium] Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Unreviewed gardening.
commit | commitdiff | tree
senorblanco@chromium.org [Fri, 9 Mar 2012 01:11:53 +0000 (01:11 +0000)]
[chromium] Unreviewed gardening.

* platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Unreviewed gardening.
commit | commitdiff | tree
senorblanco@chromium.org [Fri, 9 Mar 2012 01:07:25 +0000 (01:07 +0000)]
[chromium] Unreviewed gardening.

Mark a bunch of tests as failing on Leopard.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoString.prototype.match and replace do not clear global regexp lastIndex per ES5.1...
commit | commitdiff | tree
barraclough@apple.com [Fri, 9 Mar 2012 00:49:31 +0000 (00:49 +0000)]
String.prototype.match and replace do not clear global regexp lastIndex per ES5.1 15.5.4.10
https://bugs.webkit.org/show_bug.cgi?id=26890

Reviewed by Oliver Hunt.

Per 15.10.6.2 step 9.a.1 called via the action of the last iteration of 15.5.4.10 8.f.i.

Source/JavaScriptCore:

* runtime/StringPrototype.cpp:
(JSC::replaceUsingRegExpSearch):
(JSC::stringProtoFuncMatch):
    - added calls to setLastIndex.

LayoutTests:

* fast/js/script-tests/string-match.js: Added.
* fast/js/string-match-expected.txt: Added.
* fast/js/string-match.html: Added.
    - Added test case for match.
* fast/js/script-tests/string-replace-2.js:
* fast/js/string-replace-2-expected.txt:
    - Added tests for update correct lastIndex handling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSupport [Custom] for static functions
commit | commitdiff | tree
jonlee@apple.com [Fri, 9 Mar 2012 00:46:38 +0000 (00:46 +0000)]
Support [Custom] for static functions
https://bugs.webkit.org/show_bug.cgi?id=80573

Reviewed by Kentaro Hara.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): If the function is static, add static qualifier to cpp function.
(GenerateImplementation): Reorganize the function to split out based on the static
attribute, instead of checking for it at every line we output.
    If the function is static and not custom, the listed code should be the code in
the rest of the function that did not have the static check. If it is custom, then
we check the number of arguments, and then call the static impl function directly.
    If the function is not static, all of the "unless ($function->isStatic)" checks
are removed since it is not necessary.

* bindings/scripts/test/TestObj.idl: Added new test case.

* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjConstructorFunctionClassMethod2):
* bindings/scripts/test/JS/JSTestObj.h:
(JSTestObj):
(WebCore):
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj classMethod2]):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCollapse ENABLE(BLOB)|ENABLE(FILE_SYSTEM) to just ENABLE(BLOB)
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 9 Mar 2012 00:41:22 +0000 (00:41 +0000)]
Collapse ENABLE(BLOB)|ENABLE(FILE_SYSTEM) to just ENABLE(BLOB)
https://bugs.webkit.org/show_bug.cgi?id=80592

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-08
Reviewed by Adam Barth.

In anticipation of moving FILE_SYSTEM-related code to Modules/, we
are collapsing combination BLOB/FILE_SYSTEM ifdefs to just
BLOB. In other words, it is assumed from now on that you can not
have FILE_SYSTEM support without BLOB support.

No new tests, all existing tests pass.

* CMakeLists.txt:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore):
(WebCore::ScriptExecutionContext::fileThread):
* dom/ScriptExecutionContext.h:
(WebCore):
(ScriptExecutionContext):
* fileapi/AsyncFileStream.cpp:
* fileapi/AsyncFileStream.h:
* fileapi/FileError.h:
* fileapi/FileException.cpp:
* fileapi/FileException.h:
* fileapi/FileThread.cpp:
* fileapi/FileThread.h:
* fileapi/OperationNotAllowedException.cpp:
* fileapi/OperationNotAllowedException.h:
* platform/FileStream.cpp:
* platform/FileStream.h:
* platform/FileStreamClient.h:
* platform/SchemeRegistry.cpp:
(WebCore::canDisplayOnlyIfCanRequestSchemes):
(WebCore::CORSEnabledSchemes):
(WebCore::SchemeRegistry::registerURLSchemeAsNotAllowingJavascriptURLs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[BlackBerry] Always use the current focused node when processing focus changes
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 9 Mar 2012 00:31:40 +0000 (00:31 +0000)]
[BlackBerry] Always use the current focused node when processing focus changes
https://bugs.webkit.org/show_bug.cgi?id=80594

Patch by Mike Fenton <mifenton@rim.com> on 2012-03-08
Reviewed by Antonio Gomes.

Guard against toRange or fromRange being null when called
as part of a clear event.

* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNULL renderer possible in WebCore::HTMLInputElement::setCanReceiveDroppedFiles()
commit | commitdiff | tree
ojan@chromium.org [Fri, 9 Mar 2012 00:19:40 +0000 (00:19 +0000)]
NULL renderer possible in WebCore::HTMLInputElement::setCanReceiveDroppedFiles()
https://bugs.webkit.org/show_bug.cgi?id=80648

Patch by Andy Estes <aestes@apple.com> on 2012-03-08
Reviewed by Simon Fraser.

* fast/events/input-element-display-none-in-dragleave-crash-expected.txt: Added.
* fast/events/input-element-display-none-in-dragleave-crash.html: Added.
* platform/wk2/Skipped: WebKitTestRunner doesn't support
EventSender.beginDragWithFiles().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed Snow Leopard build fix.
commit | commitdiff | tree
jer.noble@apple.com [Fri, 9 Mar 2012 00:13:54 +0000 (00:13 +0000)]
Unreviewed Snow Leopard build fix.

On Leopard and Snow Leopard, provide an implementation for -[NSWindow convertRectToScreen:].

Source/WebKit/mac:

* WebView/WebFullScreenController.mm:
(-[NSWindow convertRectToScreen:]):

Source/WebKit2:

* UIProcess/mac/WKFullScreenWindowController.mm:
(-[NSWindow convertRectToScreen:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse an explicit attribute to signal that a context prefers to use a discrete GPU
commit | commitdiff | tree
jamesr@google.com [Thu, 8 Mar 2012 23:52:56 +0000 (23:52 +0000)]
Use an explicit attribute to signal that a context prefers to use a discrete GPU
https://bugs.webkit.org/show_bug.cgi?id=80639

Reviewed by Stephen White.

Source/Platform:

Adds preferDiscreteGPU attribute to WebGraphicsContext3D::Attributes. Also remove the forUseOnAnotherThread
attribute, this has been dead code for a while now.

* chromium/public/WebGraphicsContext3D.h:
(WebKit::WebGraphicsContext3D::Attributes::Attributes):
(Attributes):

Source/WebCore:

On platforms that support both integrated and discrete GPUs and can dynamically switch between the two, we
sometimes have a specific preference for a given context. Specifically, contexts used for WebGL and canvas 2d
acceleration should use the discrete GPU if available, but compositor contexts can run fine on an integrated
GPU. Instead of attempting to infer the intent from examining other context attributes, this adds an explicit
attribute to control this behavior.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::create):
* platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::Attributes::Attributes):
(Attributes):
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::get):

Source/WebKit/chromium:

* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::getContextAttributes):
(WebCore::GraphicsContext3D::create):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::createCompositorGraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNULL renderer possible in WebCore::HTMLInputElement::setCanReceiveDroppedFiles()
commit | commitdiff | tree
aestes@apple.com [Thu, 8 Mar 2012 23:47:36 +0000 (23:47 +0000)]
NULL renderer possible in WebCore::HTMLInputElement::setCanReceiveDroppedFiles()
https://bugs.webkit.org/show_bug.cgi?id=80648

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/events/input-element-display-none-in-dragleave-crash.html

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setCanReceiveDroppedFiles): NULL-check renderer().

LayoutTests:

* fast/events/input-element-display-none-in-dragleave-crash-expected.txt: Added.
* fast/events/input-element-display-none-in-dragleave-crash.html: Added.
* platform/wk2/Skipped: WebKitTestRunner doesn't support
EventSender.beginDragWithFiles().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoYet another unreviewed build fix.
commit | commitdiff | tree
jer.noble@apple.com [Thu, 8 Mar 2012 23:46:30 +0000 (23:46 +0000)]
Yet another unreviewed build fix.

Remove an unneeded and Lion-defined window constant from WebCoreFullScreenWindow.

* platform/mac/WebCoreFullScreenWindow.mm:
(-[WebCoreFullScreenWindow initWithContentRect:styleMask:backing:defer:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwitch absoluteRects, culledInlineAbsoluteRects, absoluteBoundingBoxRect, and addFocu...
commit | commitdiff | tree
leviw@chromium.org [Thu, 8 Mar 2012 23:41:47 +0000 (23:41 +0000)]
Switch absoluteRects, culledInlineAbsoluteRects, absoluteBoundingBoxRect, and addFocusRingRects back to integers
https://bugs.webkit.org/show_bug.cgi?id=80545

Reviewed by Simon Fraser.

Converting the above functions, all of which return rects that represent on-screen rects, to IntRects from
LayoutRects.

addFocusRingsRects generates a vector of rects that is handed off directly to the GraphicsContext to be
drawn. Snapping the rects before adding them to the vector saves an extra pass through the vector.

absoluteRects and culledInlineAbsoluteRects are only used by addFocusRingRects, hasNonEmptyBoundingBox (only
to check if they're empty), and absoluteBoundingBoxRect, which is exposed from WebCore and thus should be an
IntRect anyways.

No new tests. No change in behavior.

* dom/Node.cpp:
(WebCore::Node::hasNonEmptyBoundingBox):
* dom/Range.cpp:
(WebCore::Range::boundingBox):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::absoluteRects):
(WebCore::RenderBlock::addFocusRingRects):
* rendering/RenderBlock.h:
(RenderBlock):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::culledInlineAbsoluteRects):
(WebCore::RenderInline::addFocusRingRects):
* rendering/RenderInline.h:
(RenderInline):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::addFocusRingRects):
* rendering/RenderListBox.h:
(RenderListBox):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::paintFocusRing):
(WebCore::RenderObject::absoluteBoundingBoxRect):
(WebCore::RenderObject::absoluteFocusRingQuads):
* rendering/RenderObject.h:
(WebCore::RenderObject::absoluteRects):
(RenderObject):
(WebCore::RenderObject::absoluteBoundingBoxRectIgnoringTransforms):
(WebCore::RenderObject::addFocusRingRects):
* rendering/RenderText.cpp:
(WebCore::RenderText::absoluteRects):
(WebCore::RenderText::absoluteRectsForRange):
* rendering/RenderText.h:
(RenderText):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::addFocusRingRects):
* rendering/RenderTextControl.h:
(RenderTextControl):
* rendering/RenderView.cpp:
(WebCore::RenderView::absoluteRects):
* rendering/RenderView.h:
(RenderView):
* rendering/svg/RenderSVGBlock.cpp:
(WebCore::RenderSVGBlock::absoluteRects):
* rendering/svg/RenderSVGBlock.h:
(RenderSVGBlock):
* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::addFocusRingRects):
* rendering/svg/RenderSVGContainer.h:
(RenderSVGContainer):
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::addFocusRingRects):
* rendering/svg/RenderSVGImage.h:
(RenderSVGImage):
* rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::absoluteRects):
* rendering/svg/RenderSVGModelObject.h:
(RenderSVGModelObject):
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::addFocusRingRects):
* rendering/svg/RenderSVGShape.h:
(RenderSVGShape):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFurther unreviewed build fix.
commit | commitdiff | tree
jer.noble@apple.com [Thu, 8 Mar 2012 23:38:11 +0000 (23:38 +0000)]
Further unreviewed build fix.

Add in the WebCore namespace, so that IntRect is pulled in.

* UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:
* UIProcess/qt/WebFullScreenManagerProxyQt.cpp:
* UIProcess/win/WebFullScreenManagerProxyWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[V8] Use EventNames instead of strings
commit | commitdiff | tree
arv@chromium.org [Thu, 8 Mar 2012 23:35:15 +0000 (23:35 +0000)]
[V8] Use EventNames instead of strings
https://bugs.webkit.org/show_bug.cgi?id=80649

Reviewed by Ojan Vafai.

No new tests. Covered by existing tests.

* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::invokeEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNo-op filter changes color output because of colorspace issues
commit | commitdiff | tree
timothy_horton@apple.com [Thu, 8 Mar 2012 23:32:01 +0000 (23:32 +0000)]
No-op filter changes color output because of colorspace issues
https://bugs.webkit.org/show_bug.cgi?id=72411
<rdar://problem/10588374>

Reviewed by Dean Jackson.

Redefine "linear RGB" color space on Mac to mean linearized sRGB, instead of linear
Generic RGB. This makes existing CG color matching equivalent to what other ports do via
ImageBuffer::transformColorSpace (which only adjusts gamma, as we will now). Previously,
we were also causing actual (non-gamma) color adjustments which were not reversible.

No new tests, covered by all existing SVG and CSS filter tests.

* Resources/linearSRGB.icc: Added.
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::linearRGBColorSpaceRef):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix.
commit | commitdiff | tree
jer.noble@apple.com [Thu, 8 Mar 2012 23:28:02 +0000 (23:28 +0000)]
Unreviewed build fix.

Add stub implementations of beganEnterFullScreen and beganExitFullScreen
to platform-specific WebFullScreenManagerProxy implementations.

* UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen):
* UIProcess/qt/WebFullScreenManagerProxyQt.cpp:
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen):
* UIProcess/win/WebFullScreenManagerProxyWin.cpp:
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=80463
commit | commitdiff | tree
bdakin@apple.com [Thu, 8 Mar 2012 23:24:14 +0000 (23:24 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=80463
RenderImage is using the wrong origin when calling addRelevantRepaintedObject
-and corresponding-
<rdar://problem/10970221>

Reviewed by Dan Bernstein.

Source/WebCore:

Use the exact same rect that we paint with instead of the
visualOverflowRect() which does not always have a correct x and y.
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::paintReplaced):

Tools:

New test!
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Added.
(TestWebKitAPI):
(NewFirstVisuallyNonEmptyLayoutForImagesTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::NewFirstVisuallyNonEmptyLayoutForImagesTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::didCreatePage):
* TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd support for ENABLE(LEGACY_NOTIFICATIONS)
commit | commitdiff | tree
jonlee@apple.com [Thu, 8 Mar 2012 23:20:00 +0000 (23:20 +0000)]
Add support for ENABLE(LEGACY_NOTIFICATIONS)
https://bugs.webkit.org/show_bug.cgi?id=80497

Reviewed by Adam Barth.

Source/JavaScriptCore:

Prep for b80472: Update API for Web Notifications
* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Prep for b80472: Update API for Web Notifications
* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:

Source/WebKit/mac:

Prep for b80472: Update API for Web Notifications
* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Prep for b80472: Update API for Web Notifications
* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFull Screen Refactor Part 4: Animate into Full Screen mode using new animation classe...
commit | commitdiff | tree
jer.noble@apple.com [Thu, 8 Mar 2012 23:15:05 +0000 (23:15 +0000)]
Full Screen Refactor Part 4: Animate into Full Screen mode using new animation classes, WebKit edition.
https://bugs.webkit.org/show_bug.cgi?id=78930

Reviewed by Anders Carlsson.

Revise WebFullScreenController to have the same general functionality and code path as WKFullScreenWindowController
in WebKit2.  As such, the following functions are copies of their equivalents in WKFullScreenWindowController:
* WebView/WebFullScreenController.mm:
(-[WebFullScreenController init]):
(-[WebFullScreenController dealloc]):
(-[WebFullScreenController windowDidLoad]):
(-[WebFullScreenController cancelOperation:]):
(-[WebFullScreenController applicationDidResignActive:]):
(-[WebFullScreenController applicationDidChangeScreenParameters:]):
(-[WebFullScreenController finishedEnterFullScreenAnimation:]):
(-[WebFullScreenController finishedExitFullScreenAnimation:]):
(-[WebFullScreenController close]):
(-[WebFullScreenController animationDidEnd:]):
(-[WebFullScreenController _updateMenuAndDockForFullScreen]):
(-[WebFullScreenController _swapView:with:]):
(createBackgroundFullscreenWindow):
(windowFrameFromApparentFrames):
(-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
(-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):

The following is a copy of the equivalent function in WebFullScreenManager:
* WebView/WebFullScreenController.mm:
(screenRectOfContents):

* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::fullScreenRendererChanged): No longer tell the WebView the renderer changed (as it doesn't care.)
* WebView/WebFullScreenController.h:
* WebView/WebFullScreenController.mm:
(-[WebFullScreenController setElement:]): No need to add event listeners to the media element.
(-[WebFullScreenController enterFullScreen:]): Same as WKFullScreenWindowController, but not asynchronous.
(-[WebFullScreenController exitFullScreen]): Ditto.
* WebView/WebView.mm:
(-[WebView _enterFullScreenForElement:WebCore::]): Fullscreen -> FullScreen.
(-[WebView _exitFullScreenForElement:WebCore::]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFull Screen Refactor Part 3: Animate into Full Screen mode using new animation classes.
commit | commitdiff | tree
jer.noble@apple.com [Thu, 8 Mar 2012 23:15:00 +0000 (23:15 +0000)]
Full Screen Refactor Part 3: Animate into Full Screen mode using new animation classes.
https://bugs.webkit.org/show_bug.cgi?id=78928

Reviewed by Anders Carlsson.

Source/WebCore:

Move WKFullScreenWindow from WebKit2 into WebCore to be shared by WebKit2 and WebKit.
* WebCore.xcodeproj/project.pbxproj:
* platform/mac/WebCoreFullScreenWindow.h:
* platform/mac/WebCoreFullScreenWindow.mm:

Add symbols for the following classes and functions to the export list:
    WebCoreFullScreenWindow
    WebWindowScaleAnimation
    WebWindowFadeAnimation
    ScrollView::contentsToScreen()
    RenderObject::localToContainerQuad()
    Document::setAnimatingFullScreen()
* WebCore.exp.in:

Source/WebKit2:

Boilerplate changes to WebKit2 IPC messages and supporting functions.
* UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::setAnimatingFullScreen): Added boilerplate.
* UIProcess/WebFullScreenManagerProxy.h:
* UIProcess/WebFullScreenManagerProxy.messages.in:
* UIProcess/mac/WebFullScreenManagerProxyMac.mm:
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen): Added boilerplate.
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen): Added boilerplate.
* WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::screenRectOfContents): Added.  Calculates the screen rect of an element's contents.
(WebKit::WebFullScreenManager::enterFullScreenForElement): Use screenRectOfContents()
(WebKit::WebFullScreenManager::willEnterFullScreen): Ditto. Do not set the background color. Call new BeganEnterFullScreen
    XPC message.
(WebKit::WebFullScreenManager::didEnterFullScreen): Do not set the background color.
(WebKit::WebFullScreenManager::willExitFullScreen): Use screenRectOfContents. Do not set the background color. Call new
    BeganExitFullScreen XPC message.
(WebKit::WebFullScreenManager::didExitFullScreen): Do not set the background color.
(WebKit::WebFullScreenManager::setAnimatingFullScreen): Added boilerplate.
* WebProcess/FullScreen/WebFullScreenManager.h:
* WebProcess/FullScreen/WebFullScreenManager.messages.in:

* UIProcess/mac/WKFullScreenWindowController.h:
* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController cancelOperation:]): Renamed from _requestExitWithAnimation:.
(-[WKFullScreenWindowController applicationDidResignActive:]): Call cancelOperation: instead
    of _requestExitWithAnimation.
(-[WKFullScreenWindowController applicationDidChangeScreenParameters:]): Set the frame of
    both the full screen window and the background window.
(-[WKFullScreenWindowController enterFullScreen:]): Save a rendered image of the current
    page to use in the placeholder.
(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:WebCore::finalFrame:WebCore::]): Renamed from
    beganEnterFullScreenAnimation.
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): No need to swap
    placeholder views here, as they were already swapped in beganEnter...:.
(-[WKFullScreenWindowController exitFullScreen]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:WebCore::finalFrame:WebCore::]): Renamed from
    beganExitFullScreenAnimation.
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]): Swap web view back into place.
(-[WKFullScreenWindowController close]):
(-[WKFullScreenWindowController animationDidEnd:]): Added.
(createBackgroundFullscreenWindow): Added.
(windowFrameFromApparentFrames): Added.
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]): Added.
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFull Screen Refactor Part 2: Remove unnecessary WebKit2 APIs for Full Screen made
commit | commitdiff | tree
jer.noble@apple.com [Thu, 8 Mar 2012 23:14:53 +0000 (23:14 +0000)]
Full Screen Refactor Part 2: Remove unnecessary WebKit2 APIs for Full Screen made
https://bugs.webkit.org/show_bug.cgi?id=78926

Reviewed by John Sullivan.

The following functions (and also their Proxy versions) were removed completely:
WebFullScreenManager::enterAcceleratedCompositingMode(const LayerTreeContext&)
WebFullScreenManager::exitAcceleratedCompositingMode()
WebFullScreenManager::beganEnterFullScreenAnimation()
WebFullScreenManager::finishedEnterFullScreenAnimation(bool)
WebFullScreenManager::beganExitFullScreenAnimation()
WebFullScreenManager::finishedExitFullScreenAnimation(bool)
WebFullScreenManager::getFullScreenRect(WebCore::IntRect&)

* UIProcess/WebFullScreenManagerProxy.cpp:
* UIProcess/WebFullScreenManagerProxy.h:
(WebKit::WebFullScreenManagerProxy::beginEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::beginExitFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::disposeOfLayerClient):
(WebFullScreenManagerProxy):
* UIProcess/WebFullScreenManagerProxy.messages.in:
* UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:
* UIProcess/mac/WebFullScreenManagerProxyMac.mm:
* UIProcess/qt/WebFullScreenManagerProxyQt.cpp:
* UIProcess/win/WebFullScreenManagerProxyWin.cpp:
(WebKit::WebFullScreenManagerProxy::finishedExitFullScreenAnimation):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::create):
(WebKit::WebFullScreenManager::~WebFullScreenManager):
* WebProcess/FullScreen/WebFullScreenManager.h:
(WebFullScreenManager):
* WebProcess/FullScreen/WebFullScreenManager.messages.in:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::exitFullScreenForElement):
* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):

Additionally, the platform-specific WebFullScreenManager subclasses were removed, as no
platform-specific implementations remained after the above functions were removed:
* GNUmakefile.am:
* Target.pri:
* win/WebKit2.vcproj:
* WebProcess/FullScreen/gtk/WebFullScreenManagerGtk.cpp: Removed.
* WebProcess/FullScreen/gtk/WebFullScreenManagerGtk.h: Removed.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Removed.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Removed.
* WebProcess/FullScreen/qt/WebFullScreenManagerQt.cpp: Removed.
* WebProcess/FullScreen/qt/WebFullScreenManagerQt.h: Removed.
* WebProcess/FullScreen/win/WebFullScreenManagerWin.cpp: Removed.
* WebProcess/FullScreen/win/WebFullScreenManagerWin.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFull Screen Refactor Part 1: Remove special-case rendering code for Full Screen anima...
commit | commitdiff | tree
jer.noble@apple.com [Thu, 8 Mar 2012 23:14:46 +0000 (23:14 +0000)]
Full Screen Refactor Part 1: Remove special-case rendering code for Full Screen animation.
https://bugs.webkit.org/show_bug.cgi?id=78925

Reviewed by John Sullivan.

No new tests; no net change in functionality so covered by existing tests.

The following functions had special case code for rendering full-screen elements removed:
* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
(WebCore::Document::setAnimatingFullScreen):
* page/FrameView.cpp:
(WebCore):
(WebCore::FrameView::updateCompositingLayers):
(WebCore::FrameView::syncCompositingStateForThisFrame):
* rendering/RenderLayerBacking.cpp:
(WebCore::layerOrAncestorIsTransformed):
(WebCore::RenderLayerBacking::updateCompositedBounds):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
* rendering/RenderLayerCompositor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't enable VIDEO_TRACK on all OS X platforms
commit | commitdiff | tree
mlilek@apple.com [Thu, 8 Mar 2012 23:08:56 +0000 (23:08 +0000)]
Don't enable VIDEO_TRACK on all OS X platforms
https://bugs.webkit.org/show_bug.cgi?id=80635

Reviewed by Eric Carlson.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMoar Chromium Lion rebaselines.
commit | commitdiff | tree
ojan@chromium.org [Thu, 8 Mar 2012 23:05:21 +0000 (23:05 +0000)]
Moar Chromium Lion rebaselines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoperf-o-matic should incrementally update JSON responses
commit | commitdiff | tree
rniwa@webkit.org [Thu, 8 Mar 2012 22:58:54 +0000 (22:58 +0000)]
perf-o-matic should incrementally update JSON responses
https://bugs.webkit.org/show_bug.cgi?id=79898

Reviewed by Eric Seidel.

Now that Runs object store test_runs and averages separately,
we can update JSON data incrementally without degrading values.

Also fixed the order of arguments passed to DashboardImage.needs_update
in schedule_runs_update. This bug had caused all chart images to be
updated on every new report.

* Websites/webkit-perf.appspot.com/controller.py:
(schedule_runs_update):
* Websites/webkit-perf.appspot.com/models.py:
(Runs.update_or_insert):
(Runs.update_incrementally):
(Runs):
(Runs.get_by_objects):
* Websites/webkit-perf.appspot.com/models_unittest.py:
(RunsTest._create_results):
(RunsTest.test_generate_runs):
(RunsTest.test_update_or_insert):
(RunsTest.test_update_incrementally):
(RunsTest.test_to_json_with_results):
* Websites/webkit-perf.appspot.com/report_process_handler.py:
(ReportProcessHandler.post):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoimplement flexbox wrap-reverse
commit | commitdiff | tree
tony@chromium.org [Thu, 8 Mar 2012 22:55:53 +0000 (22:55 +0000)]
implement flexbox wrap-reverse
https://bugs.webkit.org/show_bug.cgi?id=80552

Reviewed by Ojan Vafai.

Source/WebCore:

No new tests, but additional coverage in:
    css3/flexbox/multiline-align.html
    css3/flexbox/multiline-pack.html
    css3/flexbox/multiline.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::WrapReverseContext::WrapReverseContext): Helper struct to hold information needed for reversing
the order of lines.
(RenderFlexibleBox::WrapReverseContext):
(WebCore::RenderFlexibleBox::WrapReverseContext::addCrossAxisOffset):
(WebCore::RenderFlexibleBox::WrapReverseContext::addNumberOfChildrenOnLine):
(WebCore::RenderFlexibleBox::WrapReverseContext::lineCrossAxisDelta): Computes the number of pixels to move a line.
(WebCore):
(WebCore::RenderFlexibleBox::layoutFlexItems): Call flipForWrapReverse if needed. This happens
before flipForRightToLeftColumn because otherwise the crossAxisOffsets will be wrong.
(WebCore::flexAlignForChild):
(WebCore::RenderFlexibleBox::alignChildren): Flip alignment in wrap-reverse because the cross directions are flipped.
(WebCore::RenderFlexibleBox::flipForWrapReverse): Flip each line.
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):

LayoutTests:

* css3/flexbox/multiline-align-expected.txt:
* css3/flexbox/multiline-align.html:
* css3/flexbox/multiline-expected.txt:
* css3/flexbox/multiline-pack-expected.txt:
* css3/flexbox/multiline-pack.html:
* css3/flexbox/multiline.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix. That day is not today.
commit | commitdiff | tree
oliver@apple.com [Thu, 8 Mar 2012 22:53:01 +0000 (22:53 +0000)]
Build fix.  That day is not today.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove InDocumentFlag manipulation methods from Node interface
commit | commitdiff | tree
adamk@chromium.org [Thu, 8 Mar 2012 22:47:44 +0000 (22:47 +0000)]
Remove InDocumentFlag manipulation methods from Node interface
https://bugs.webkit.org/show_bug.cgi?id=80612

Reviewed by Ryosuke Niwa.

This is a first step towards tightening up Node::inDocument() to match
the actual in-document-tree state (see r108152 for the sort of bug
resulting from those not matching).

No new tests, refactoring only.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removedFromDocument): Remove duplicate call to clearInDocument:
the call to Node::removedFromDocument three lines above will clear the flag.
* dom/Document.cpp:
(WebCore::Document::Document): Call ContainerNode constructor with InDocumentFlag always set
instead of calling setInDocument.
* dom/Node.cpp:
(WebCore::Node::insertedIntoDocument): Inline setInDocument (now the only caller).
(WebCore::Node::removedFromDocument): Inline clearInDocument (now the only caller).
* dom/Node.h: Remove setInDocument & clearInDocument, add new CreateDocument ConstructionType.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix. One of these days I'll manage to commit something that works everywhere.
commit | commitdiff | tree
oliver@apple.com [Thu, 8 Mar 2012 22:29:09 +0000 (22:29 +0000)]
Build fix. One of these days I'll manage to commit something that works everywhere.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Try to fix the Snow Leopard build
commit | commitdiff | tree
vestbo@webkit.org [Thu, 8 Mar 2012 22:09:53 +0000 (22:09 +0000)]
[Qt] Try to fix the Snow Leopard build

If the build is running under sh, echo -n does not empty the file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate MIPS patchOffsetGetByIdSlowCaseCall
commit | commitdiff | tree
commit-queue@webkit.org [Thu, 8 Mar 2012 22:03:09 +0000 (22:03 +0000)]
Update MIPS patchOffsetGetByIdSlowCaseCall
https://bugs.webkit.org/show_bug.cgi?id=80302

Patch by Chao-ying Fu <fu@mips.com> on 2012-03-08
Reviewed by Oliver Hunt.

* jit/JIT.h:
(JIT):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

next
Mirror of the WebKit open source project from svn.webkit.org.