WebKit-https.git
9 years agoRefactoring: Editor::markAllMisspellingsAndBadGrammarInRanges should be refactored.
commit-queue@webkit.org [Wed, 7 Dec 2011 05:00:57 +0000 (05:00 +0000)]
Refactoring: Editor::markAllMisspellingsAndBadGrammarInRanges should be refactored.
https://bugs.webkit.org/show_bug.cgi?id=73628

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-06
Reviewed by Hajime Morita.

Extracted a code for adding markers and replacing misspelled words from WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges.

No new tests. covered by existing tests.

* editing/Editor.cpp:
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  Extracted a code for adding markers and replacing missplled words, and moved to markAndReplaceFor.
(WebCore::Editor::markAndReplaceFor):
* editing/Editor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAvoid calling calculateRects in RenderLayer::paintLayer when the rectangles are not...
jchaffraix@webkit.org [Wed, 7 Dec 2011 04:53:10 +0000 (04:53 +0000)]
Avoid calling calculateRects in RenderLayer::paintLayer when the rectangles are not needed
https://bugs.webkit.org/show_bug.cgi?id=73754

Reviewed by Simon Fraser.

Performance change, no change in behavior.

RenderLayer::paintLayer can easily be called a million time when scrolling on a big table with
td { overflow: hidden; }. We would spend a lot of time recomputing the rectangles that we never
unused for painting as our layer was not self-painting (clipping layer only) and we did not paint
some overlay scrollbars.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayer):
Simplified and moved the shouldPaint logic earlier in the function. Now the branches
are checking the same boolean which makes the logic more obvious. A consequence of
filling shouldPaint earlier is that we call |calculateRects| only if there is a chance
the rectangles will used. Also cached the result of isSelfPaintingLayer() in a local
variable (isSelfPaintingLayer() is fairly expensive due to several virtual calls).

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):
For coherency, applied the same optimizations here too: added an early return instead
of conditionaly call |calculateRects| as we don't have to restore any clip.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove the leapForward accidentally added in the previous commit, and add a failing...
rniwa@webkit.org [Wed, 7 Dec 2011 04:46:33 +0000 (04:46 +0000)]
Remove the leapForward accidentally added in the previous commit, and add a failing test expectation
for offsetX-offset-Y.html. The failure is tracked by the bug 73979.

* fast/events/offsetX-offsetY-expected.txt:
* fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed the test added by r100111.
rniwa@webkit.org [Wed, 7 Dec 2011 04:38:10 +0000 (04:38 +0000)]
Fixed the test added by r100111.

* fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSimplify KURL's checkEncodedString()
benjamin@webkit.org [Wed, 7 Dec 2011 04:24:41 +0000 (04:24 +0000)]
Simplify KURL's checkEncodedString()
https://bugs.webkit.org/show_bug.cgi?id=73890

Reviewed by Andreas Kling.

The Macro UNUSED_PARAM is not supposed to be used for this case,
use ASSERT_UNUSED instead.

* platform/KURL.cpp:
(WebCore::checkEncodedString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip tests added by r101883 on Mac since they have been failing.
rniwa@webkit.org [Wed, 7 Dec 2011 04:14:34 +0000 (04:14 +0000)]
Skip tests added by r101883 on Mac since they have been failing.
The failure is tracked by the bug 73977.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate <track> layout tests
eric.carlson@apple.com [Wed, 7 Dec 2011 04:04:44 +0000 (04:04 +0000)]
Update <track> layout tests
https://bugs.webkit.org/show_bug.cgi?id=73966

<track> elements won't necessarily load automatically after https://bugs.webkit.org/show_bug.cgi?id=72547
is fixed, so update tests now.

Reviewed by Sam Weinig.

* media/track/text-track-cue-is-reachable-expected.txt: Added.
* media/track/text-track-cue-is-reachable.html: Added.
* media/track/text-track-is-reachable-expected.txt: Added.
* media/track/text-track-is-reachable.html: Added.
* media/track/track-add-remove-cue.html:
* media/track/track-cues-cuechange.html:
* media/track/track-cues-enter-exit.html:
* media/track/track-cues-seeking.html:
* media/track/track-load-error-readyState.html:
* media/track/track-load-from-element-readyState.html:
* media/track/track-load-from-src-readyState.html:
* media/track/track-text-track-cue-list.html:
* media/track/track-webvtt-tc000-empty.html:
* media/track/track-webvtt-tc001-utf8.html:
* media/track/track-webvtt-tc002-bom.html:
* media/track/track-webvtt-tc003-newlines.html:
* media/track/track-webvtt-tc004-magic-header.html:
* media/track/track-webvtt-tc005-header-comment.html:
* media/track/track-webvtt-tc006-cue-identifiers.html:
* media/track/track-webvtt-tc007-cue-no-id.html:
* media/track/track-webvtt-tc008-timings-no-hours.html:
* media/track/track-webvtt-tc009-timings-hour.html:
* media/track/track-webvtt-tc010-no-timings.html:
* media/track/track-webvtt-tc011-blank-lines.html:
* media/track/track-webvtt-tc013-settings.html:
* media/track/track-webvtt-tc014-alignment.html:
* media/track/track-webvtt-tc015-positioning.html:
* media/track/track-webvtt-tc016-align-positioning.html:
* media/track/track-webvtt-tc017-line-position.html:
* media/track/track-webvtt-tc018-align-text-line-position.html:
* media/track/track-webvtt-tc019-cue-size.html:
* media/track/track-webvtt-tc020-cue-size-align.html:
* media/track/track-webvtt-tc021-valign.html:
* media/track/track-webvtt-tc022-entities.html:
* media/track/track-webvtt-tc023-markup.html:
* media/track/track-webvtt-tc024-timestamp.html:
* media/track/track-webvtt-tc025-class-markup.html:
* media/track/track-webvtt-tc026-voice.html:
* media/track/track-webvtt-tc027-empty-cue.html:
* media/track/track-webvtt-tc028-unsupported-markup.html:
* media/video-test.js:
(testTracks):
(testCues):
(allTestsEnded):
(enableAllTextTracks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a failing expectation for the test added by r101619.
rniwa@webkit.org [Wed, 7 Dec 2011 03:53:26 +0000 (03:53 +0000)]
Add a failing expectation for the test added by r101619.
The failure is tracked by the bug 73975.

* platform/mac/fast/css/hover-active-drag-expected.txt: Copied from LayoutTests/fast/css/hover-active-drag-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGTK rebaseline after r102149.
rniwa@webkit.org [Wed, 7 Dec 2011 03:41:42 +0000 (03:41 +0000)]
GTK rebaseline after r102149.

* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
* platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Copied from LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Suppress failure of fast/canvas/webgl/canvas-2d-webgl-texture.html
kbr@google.com [Wed, 7 Dec 2011 03:28:35 +0000 (03:28 +0000)]
Unreviewed. Suppress failure of fast/canvas/webgl/canvas-2d-webgl-texture.html
on Mac; tracking bug https://bugs.webkit.org/show_bug.cgi?id=73974 .

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThe code to create a NodeListsNodeData is duplicated everywhere
rniwa@webkit.org [Wed, 7 Dec 2011 03:17:05 +0000 (03:17 +0000)]
The code to create a NodeListsNodeData is duplicated everywhere
https://bugs.webkit.org/show_bug.cgi?id=73961

Reviewed by Darin Adler.

Extracted the logic to create NodeListsNodeData as NodeRareData::ensureNodeLists.

* dom/Document.cpp:
(WebCore::Document::getItems):
* dom/Node.cpp:
(WebCore::Node::childNodes):
(WebCore::Node::registerDynamicNodeList):
(WebCore::Node::getElementsByTagName):
(WebCore::Node::getElementsByTagNameNS):
(WebCore::Node::getElementsByName):
(WebCore::Node::getElementsByClassName):
* dom/NodeRareData.h:
(WebCore::NodeRareData::ensureNodeLists):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::labels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpstream about: feature in WebKit/blackberry/WebCoreSupport/
leo.yang@torchmobile.com.cn [Wed, 7 Dec 2011 02:37:25 +0000 (02:37 +0000)]
Upstream about: feature in WebKit/blackberry/WebCoreSupport/
https://bugs.webkit.org/show_bug.cgi?id=73612

Reviewed by Antonio Gomes.

Source/WebCore:

* PlatformBlackBerry.cmake: Move platform/network/blackberry/AboutData.{h, cpp}
                            to WebKit/blackberry/WebCoreSupport

Source/WebKit:

* blackberry/CMakeListsBlackBerry.txt:
* blackberry/WebCoreSupport/AboutData.cpp: Added.
(WebCore::numberToHTMLTr):
(WebCore::configPage):
(WebCore::cacheTypeStatisticToHTMLTr):
(WebCore::memoryPage):
* blackberry/WebCoreSupport/AboutData.h: Added.
* blackberry/WebCoreSupport/AboutDataEnableFeatures.in: Added.
* blackberry/WebCoreSupport/AboutDataHaveFeatures.in: Added.
* blackberry/WebCoreSupport/AboutDataUseFeatures.in: Added.
* blackberry/WebCoreSupport/generateAboutDataFeatures.pl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit Mac does not build without CONTEXT MENU
benjamin@webkit.org [Wed, 7 Dec 2011 02:11:14 +0000 (02:11 +0000)]
WebKit Mac does not build without CONTEXT MENU
https://bugs.webkit.org/show_bug.cgi?id=73962

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-06
Reviewed by Pavel Feldman.

In the patch r100903, the symbols were exported under ENABLE(CONTEXT_MENUS)
because the feature is triggered from the menus.

The implementation has no dependency on the context menu but is necessary to build
when the inspector is enabled.
This patch moves the exported symbols from ENABLE(CONTEXT_MENUS) to ENABLE(INSPECTOR).

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix typo in WebKit.gyp introduced in previous change.
dpranke@chromium.org [Wed, 7 Dec 2011 01:48:43 +0000 (01:48 +0000)]
Fix typo in WebKit.gyp introduced in previous change.

Unreviewed, build fix.

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago.: Add Tools/Tool.xcodeproj,
dpranke@chromium.org [Wed, 7 Dec 2011 01:39:36 +0000 (01:39 +0000)]
.: Add Tools/Tool.xcodeproj,
Source/WebKit/chromium/WebKitUnitTests.xcodeproj,
Source/WebKit/chromium/All.xcodeproj to .gitignore

https://bugs.webkit.org/show_bug.cgi?id=73823

Reviewed by Tony Chang.

* .gitignore:

Source/WebKit/chromium: binaries in webkit.gyp should be split into a new file to break circular dependencies on webkit_support
https://bugs.webkit.org/show_bug.cgi?id=73382

Reviewed by Tony Chang.

XCode (and hence GYP) can't handle circular dependencies between
files (and projects). Accordingly, although the binaries in
WebKit.gyp depend on webkit_support and webkit_support depends
on webkit, we don't mention the latter dependency in the file.
To fix this, this change moves the binaries like DRT into a new
GYP file, and modifies gyp_webkit to build from that file
instead of WebKit.gyp.

* WebKit.gyp:
* All.gyp:
* WebKitUnitTests.gyp:
* gyp_webkit:

Tools: binaries in webkit.gyp should be split into a new file to break circular dependencies on webkit_support
https://bugs.webkit.org/show_bug.cgi?id=73382

Reviewed by Tony Chang.

XCode (and hence GYP) can't handle circular dependencies between
files (and projects). Accordingly, although the binaries in
WebKit.gyp depend on webkit_support and webkit_support depends
on webkit, we don't mention the latter dependency in the file.
To fix this, this change moves the binaries like DRT into a new
GYP file, and modifies gyp_webkit to build from that file
instead of WebKit.gyp.

* Tools.gyp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG 32_64 call linking does not handle non-cell callees correctly
fpizlo@apple.com [Wed, 7 Dec 2011 01:29:47 +0000 (01:29 +0000)]
DFG 32_64 call linking does not handle non-cell callees correctly
https://bugs.webkit.org/show_bug.cgi?id=73965

Reviewed by Sam Weinig.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] setNeedsCommit on non-composited host layers should trigger commit
enne@google.com [Wed, 7 Dec 2011 01:17:49 +0000 (01:17 +0000)]
[chromium] setNeedsCommit on non-composited host layers should trigger commit
https://bugs.webkit.org/show_bug.cgi?id=73711

Reviewed by James Robinson.

Source/WebCore:

Pipe non-composited content host syncs to setNeedsCommit.

Since now the NonCompositedContentHost generates setNeedsCommit, don't
call it unnecessarily, e.g. calling setBackgroundColor to the same
color each frame should not retrigger more commits.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setAnchorPoint):
(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::setChildrenTransform):
(WebCore::GraphicsLayerChromium::setMasksToBounds):
(WebCore::GraphicsLayerChromium::setBackgroundColor):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setNeedsCommit):
(WebCore::LayerChromium::setAnchorPoint):
(WebCore::LayerChromium::setAnchorPointZ):
(WebCore::LayerChromium::setBackgroundColor):
(WebCore::LayerChromium::setMasksToBounds):
(WebCore::LayerChromium::setMaskLayer):
(WebCore::LayerChromium::setOpacity):
(WebCore::LayerChromium::setOpaque):
(WebCore::LayerChromium::setPosition):
(WebCore::LayerChromium::setSublayerTransform):
(WebCore::LayerChromium::setTransform):
(WebCore::LayerChromium::setScrollPosition):
(WebCore::LayerChromium::setScrollable):
(WebCore::LayerChromium::setDoubleSided):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setReplicaLayer):
* platform/graphics/chromium/NonCompositedContentHost.cpp:
(WebCore::NonCompositedContentHost::notifySyncRequired):
* platform/graphics/chromium/NonCompositedContentHost.h:

Source/WebKit/chromium:

Add some tests to make sure that modifying the noncomposited content
host triggers commits.

Properties that trigger setNeedsCommit should only do so when the
property changes. Additionally, make more property changes properly
trigger commits.

* tests/LayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unintentional type name shadowing in the Interpreter
weinig@apple.com [Wed, 7 Dec 2011 00:55:23 +0000 (00:55 +0000)]
Remove unintentional type name shadowing in the Interpreter
https://bugs.webkit.org/show_bug.cgi?id=73963

Reviewed by Oliver Hunt.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::prepareForRepeatCall): Replace the parameter name FunctionExecutable,
which shadows the FunctionExecutable type name, with functionExecutable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] unknown characters symbol on \n in complex script text (RTL and LTR)
bashi@chromium.org [Wed, 7 Dec 2011 00:38:35 +0000 (00:38 +0000)]
[Chromium] unknown characters symbol on \n in complex script text (RTL and LTR)
https://bugs.webkit.org/show_bug.cgi?id=73806

Reviewed by Tony Chang.

Source/WebCore:

Sets fMergeNeutralItems to 1 instead of merging script items based on their tags.

Tests: platform/chromium/fast/text/international/chromium-complex-text-non-printable-expected.html
       platform/chromium/fast/text/international/chromium-complex-text-non-printable.html

* platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::fillRuns): Removed a block which merges script items.

LayoutTests:

Adds a test to ensure the missing glyph doesn't appear on LF in complex text.

* fast/text/international/chromium-complex-text-non-printable-expected.html: Added.
* fast/text/international/chromium-complex-text-non-printable.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement remaining border-image and webkit-maskbox-image properties in CSSStyleApply...
macpherson@chromium.org [Wed, 7 Dec 2011 00:26:59 +0000 (00:26 +0000)]
Implement remaining border-image and webkit-maskbox-image properties in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=73391

Reviewed by Hajime Morita.

No new tests / refacoring only.

* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyBorderImageModifier::getValue):
(WebCore::ApplyPropertyBorderImageModifier::setValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::ApplyPropertyBorderImageModifier::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSStyleSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: introduce a memory agent stub.
pfeldman@chromium.org [Tue, 6 Dec 2011 23:49:19 +0000 (23:49 +0000)]
Web Inspector: introduce a memory agent stub.
https://bugs.webkit.org/show_bug.cgi?id=73930

Reviewed by Timothy Hatcher.

We'd like to experiment with the memory stats and hence need a
nice home for that. Adding this undocumented agent / domain for now.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/ScriptProfiler.h:
(WebCore::ScriptProfiler::nodeCount):
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::nodeCount):
* bindings/v8/ScriptProfiler.h:
* inspector/Inspector.json:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorMemoryAgent.cpp: Added.
(WebCore::InspectorMemoryAgent::~InspectorMemoryAgent):
(WebCore::InspectorMemoryAgent::getNodeCounter):
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
* inspector/InspectorMemoryAgent.h: Added.
(WebCore::InspectorMemoryAgent::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix after 102183.
jchaffraix@webkit.org [Tue, 6 Dec 2011 23:46:50 +0000 (23:46 +0000)]
Unreviewed build fix after 102183.

* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::initialGridTrackValue):
Use DEFINE_STATIC_LOCAL to avoid having an exit-time destructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInline RenderObject::view()
jchaffraix@webkit.org [Tue, 6 Dec 2011 23:38:37 +0000 (23:38 +0000)]
Inline RenderObject::view()
https://bugs.webkit.org/show_bug.cgi?id=73733

Reviewed by Darin Adler.

Micro-performance optimization, no change in behavior.

RenderObject::view() is super hot and is taking ~4-5% of the time in some
benchmarks as it is called several hundred thousands times. For some reason,
the compiler did not inline it even though it is very simple in release builds.

* WebCore.exp.in: Removed RenderObject::view() as it is inlined now.

* rendering/RenderObject.cpp: Moved the implementation from here ...
* rendering/RenderView.h:
(WebCore::RenderObject::view): ... to here to avoid a cyclic
dependency between RenderObject and RenderView. Also marked the
function as ALWAYS_INLINE.

* rendering/RenderObject.h:
* rendering/svg/RenderSVGResourceContainer.cpp:
Added #include "RenderView.h" as the code checks for view() during repaint.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r101838): Crash in LayerTreeHostCA::initialize() when accelerated drawing...
aestes@apple.com [Tue, 6 Dec 2011 23:29:48 +0000 (23:29 +0000)]
REGRESSION (r101838): Crash in LayerTreeHostCA::initialize() when accelerated drawing is enabled
https://bugs.webkit.org/show_bug.cgi?id=73955

Reviewed by Anders Carlsson.

* WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
(WebKit::LayerTreeHostCA::initialize): m_webPage->drawingArea() will be
null here if we are initializing the layer tree host in DrawingArea's
ctor (as is the case when accelerated drawing is enabled), before
WebPage has set its m_drawingArea pointer. Since the layer tree cannot
have been frozen at this point, it's safe to enable layer flush
scheduling if drawingArea() is null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS Grid Layout: Add support for parsing multiple grid-columns or grid-rows
jchaffraix@webkit.org [Tue, 6 Dec 2011 23:11:05 +0000 (23:11 +0000)]
CSS Grid Layout: Add support for parsing multiple grid-columns or grid-rows
https://bugs.webkit.org/show_bug.cgi?id=73272

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/css-grid-layout/grid-columns-rows-get-set-multiple.html

Updated our supported syntax to match the following:
<track-list> := [ <track-breadth> ]+ | 'none'
<track-breadth> := <length> | <percentage> | 'auto'
(the naming loosely matches the specification)

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForGridTrackBreadth): Added function to handle a breadth
(extended with 'auto' that the spec puts in <track-minmax>).

(WebCore::valueForGridTrackList): Create a space seperated list of
track breadth or none.

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Updated
to use the new functions.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTrackList): Extended the function to
match the new syntax.

* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Removed our
simple implementation. Replaced by the CSSStyleSelector functions.

* css/CSSStyleSelector.cpp:
(WebCore::createGridTrackBreadth):
(WebCore::createGridTrackList):
Added those 2 functions to convert the CSSPrimitiveValue to a Vector
as expected by RenderStyle.

(WebCore::CSSStyleSelector::applyProperty): Added our 2 properties
now that it is not handled by CSSStyleApplyProperty.

* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::gridColumns):
(WebCore::InheritedFlags::gridRows):
(WebCore::InheritedFlags::setGridColumns):
(WebCore::InheritedFlags::setGridRows):
(WebCore::InheritedFlags::initialGridColumns):
(WebCore::InheritedFlags::initialGridRows):
Updated the previous methods to take a Vector of Length.

(WebCore::InheritedFlags::initialGridTrackValue):
Needed function to return a Vector with one 'none' Length (the initial
value per the specification).

* rendering/style/StyleGridData.h: Updated to use a Vector.

LayoutTests:

* fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
* fast/css-grid-layout/resources/grid-columns-rows-get-set.js:
Added more testing for the single case.

* fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt: Added.
* fast/css-grid-layout/grid-columns-rows-get-set-multiple.html: Added.
* fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agor102146 from 73875 broke fast/js/encode-URI-test.html
msaboff@apple.com [Tue, 6 Dec 2011 22:41:56 +0000 (22:41 +0000)]
r102146 from 73875 broke fast/js/encode-URI-test.html
https://bugs.webkit.org/show_bug.cgi?id=73950

Reviewed by Gavin Barraclough.

* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncUnescape): Restructured to handle
the %uHHHH case to output the resulting character
and continue so that a failure in finding 4 hex
digits will fall through and output the '%'.
Due to style check, changed the temporary
character variable to a more descriptive name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Implement tile-sized painting using SkPicture.
commit-queue@webkit.org [Tue, 6 Dec 2011 22:37:12 +0000 (22:37 +0000)]
[Chromium] Implement tile-sized painting using SkPicture.
https://bugs.webkit.org/show_bug.cgi?id=71869

Patch by David Reveman <reveman@chromium.org> on 2011-12-06
Reviewed by James Robinson.

Source/WebCore:

Add texture uploader that paints tile-sized chunks using SkPicture
recording and playback. Expose setting which allows this texture
updater to be enabled.

No new tests. Covered by existing tests.

* WebCore.gypi:
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp: Added.
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::Texture):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::create):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::BitmapSkPictureCanvasLayerTextureUpdater):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::~BitmapSkPictureCanvasLayerTextureUpdater):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::createTexture):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::sampledTexelFormat):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::prepareToUpdate):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::paintContentsRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::updateTextureRect):
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h: Added.
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::textureUpdater):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::orientation):
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):

Source/WebKit/chromium:

Add perTilePainting setting that is used by compositor to determine
what texture uploader to use.

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setPerTilePainting):
* src/WebSettingsImpl.h:
(WebKit::WebSettingsImpl::perTilePainting):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Don't crash if tile upload happens without painting first
enne@google.com [Tue, 6 Dec 2011 22:26:27 +0000 (22:26 +0000)]
[chromium] Don't crash if tile upload happens without painting first
https://bugs.webkit.org/show_bug.cgi?id=73939

Reviewed by James Robinson.

Remove at least one place (in ImageLayerChromium) where this could
happen.

Although this shouldn't happen, we should be robust to it in the
chance that other code causes it to.

* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateCompositorResources):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGC zapping logic could benefit from some more assertions
fpizlo@apple.com [Tue, 6 Dec 2011 22:12:56 +0000 (22:12 +0000)]
GC zapping logic could benefit from some more assertions
https://bugs.webkit.org/show_bug.cgi?id=73947

Reviewed by Gavin Barraclough.

- If you're in a zapped block and you're zapped, then your mark bit should
  never be set.

- If you're being marked, then you should never be zapped.

* heap/MarkedBlock.h:
(JSC::MarkedBlock::isLive):
* runtime/Structure.h:
(JSC::MarkStack::internalAppend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable web audio by default on non-Mac POSIX platforms
commit-queue@webkit.org [Tue, 6 Dec 2011 22:07:00 +0000 (22:07 +0000)]
Enable web audio by default on non-Mac POSIX platforms
https://bugs.webkit.org/show_bug.cgi?id=73491

Patch by Ruben <chromium@hybridsource.org> on 2011-12-06
Reviewed by Tony Chang.

No new tests, just changing gyp includes.

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPut length in its own variable in KURL copyASCII
benjamin@webkit.org [Tue, 6 Dec 2011 22:02:15 +0000 (22:02 +0000)]
Put length in its own variable in KURL copyASCII
https://bugs.webkit.org/show_bug.cgi?id=73928

Reviewed by Darin Adler.

* platform/KURL.cpp:
(WebCore::copyASCII):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Set opaque flag for ImageLayerChromium
commit-queue@webkit.org [Tue, 6 Dec 2011 21:37:29 +0000 (21:37 +0000)]
[chromium] Set opaque flag for ImageLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=72964

Patch by Dana Jansens <danakj@chromium.org> on 2011-12-06
Reviewed by James Robinson.

Source/WebCore:

Unit test in tests/ImageLayerChromiumTest.cpp.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsToImage):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore::GraphicsLayerChromium::contentsLayer):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::setContents):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/DragImageTest.cpp:
(WebCore::TestImage::TestImage):
(WebCore::TestImage::nativeImageForCurrentFrame):
* tests/ImageLayerChromiumTest.cpp: Added.
(WebCore::MockGraphicsLayerClient::notifyAnimationStarted):
(WebCore::MockGraphicsLayerClient::notifySyncRequired):
(WebCore::MockGraphicsLayerClient::paintContents):
(WebCore::MockGraphicsLayerClient::showDebugBorders):
(WebCore::MockGraphicsLayerClient::showRepaintCounter):
(WebCore::TestImage::create):
(WebCore::TestImage::TestImage):
(WebCore::TestImage::isBitmapImage):
(WebCore::TestImage::currentFrameHasAlpha):
(WebCore::TestImage::size):
(WebCore::TestImage::nativeImageForCurrentFrame):
(WebCore::TestImage::destroyDecodedData):
(WebCore::TestImage::decodedSize):
(WebCore::TestImage::draw):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Guard access to WebKitPlatformSupport::currentThread with a null check
adamk@chromium.org [Tue, 6 Dec 2011 21:06:22 +0000 (21:06 +0000)]
[chromium] Guard access to WebKitPlatformSupport::currentThread with a null check
https://bugs.webkit.org/show_bug.cgi?id=73937

Reviewed by Adam Barth.

Though |currentThread| is never null in production code, it is null in
unit tests (such as Chromium's unit_tests) that call WebKit::initialize()
without first constructing a MessageLoop.

* src/WebKit.cpp:
(WebKit::initialize):
(WebKit::shutdown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Apply sent deltas on finishCommit
commit-queue@webkit.org [Tue, 6 Dec 2011 21:00:29 +0000 (21:00 +0000)]
[chromium] Apply sent deltas on finishCommit
https://bugs.webkit.org/show_bug.cgi?id=73884

Patch by Alexandre Elias <aelias@google.com> on 2011-12-06
Reviewed by James Robinson.

This moves scroll and pageScale "sent" deltas to be applied to
the layer at the end of the commit, instead of the beginning.

This has several advantages, especially for page scale:
- When pageScale changes, no longer any need to change the scroll's
coordinate space at beginning of commit, which is complex and prone to
bugs (this fixes a problem where we were forgetting to modify the
scrollPosition before).
- No need for non-commit-related code to consider the "sent" values.
m_pageScale is now always the content scale factor, and
m_pageScaleDelta is the scale to be on the impl-side matrix.
- This will make it easy to send arbitrary fake or future delta
values for example while pinch zooming out.

The scroll logic is similarly altered for consistency's sake.  Note that
I also moved the tree synchronize to the beginning of finishCommit
in order to avoid having to change the pageScale coordinate space of
sentScrollDelta in adjustScrollsForPageScaleChange().

Source/WebCore:

No new tests. (Refactoring of existing code.)

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
(WebCore::CCLayerTreeHostImpl::applyPageScaleDeltaToScrollLayer):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't allocate register in typedarray control flow
oliver@apple.com [Tue, 6 Dec 2011 20:48:27 +0000 (20:48 +0000)]
Don't allocate register in typedarray control flow
https://bugs.webkit.org/show_bug.cgi?id=73944

Reviewed by Gavin Barraclough.

Move a temporary allocation outside of control flow.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix assertion in QtViewportInteractionEngine.cpp:468
commit-queue@webkit.org [Tue, 6 Dec 2011 20:47:31 +0000 (20:47 +0000)]
[Qt] Fix assertion in QtViewportInteractionEngine.cpp:468
https://bugs.webkit.org/show_bug.cgi?id=73914

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-12-06
Reviewed by Kenneth Rohde Christiansen.

m_suspendCount should always be zero when a pinch gesture is started.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=68328
barraclough@apple.com [Tue, 6 Dec 2011 20:46:07 +0000 (20:46 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=68328
The generator and intrinsic fields in HashTableValue/HashEntry and associated structures and methods are redundant

Reviewed by Geoff Garen.

../JavaScriptCore:

Move the instrinsic enum out of the DFG, into runtime. Add entires for all host functions
that have an intrinsic in the form of a generated thunk. Remove the thunk pointer from the
hashtable, and make Intrinsic field no longer ifdef on JIT/DFG. In getHostFunction select
a thunk genertaor to use based on the Intrinsic.

* JavaScriptCore.xcodeproj/project.pbxproj:
* create_hash_table:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
* dfg/DFGCapabilities.h:
* dfg/DFGIntrinsic.h: Removed.
* jit/JITStubs.cpp:
(JSC::JITThunks::hostFunctionStub):
* jit/JITStubs.h:
* runtime/Executable.cpp:
(JSC::ExecutableBase::intrinsic):
(JSC::NativeExecutable::intrinsic):
* runtime/Executable.h:
(JSC::ExecutableBase::intrinsicFor):
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):
* runtime/Intrinsic.h: Copied from Source/JavaScriptCore/dfg/DFGIntrinsic.h.
* runtime/JSGlobalData.cpp:
(JSC::thunkGeneratorForIntrinsic):
(JSC::JSGlobalData::getHostFunction):
* runtime/JSGlobalData.h:
* runtime/Lookup.cpp:
(JSC::HashTable::createTable):
(JSC::setUpStaticFunctionSlot):
* runtime/Lookup.h:
(JSC::HashEntry::initialize):
(JSC::HashEntry::intrinsic):

../WebCore:

Intrinsic is no longer in the DFG namespace, is always in the
hash table. Removed ThunkGenerator.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHashTable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove forwarding header now that downstream has been fixed to refer to
abarth@webkit.org [Tue, 6 Dec 2011 20:39:43 +0000 (20:39 +0000)]
Remove forwarding header now that downstream has been fixed to refer to
the actual location of this header.

* public/WebRect.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r102091.
dglazkov@chromium.org [Tue, 6 Dec 2011 20:27:57 +0000 (20:27 +0000)]
Unreviewed, rolling out r102091.
http://trac.webkit.org/changeset/102091
https://bugs.webkit.org/show_bug.cgi?id=73711

Caused Clang Linux compile failure.

Source/WebCore:

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setAnchorPoint):
(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::setChildrenTransform):
(WebCore::GraphicsLayerChromium::setMasksToBounds):
(WebCore::GraphicsLayerChromium::setBackgroundColor):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setNeedsCommit):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setAnchorPoint):
(WebCore::LayerChromium::setAnchorPointZ):
(WebCore::LayerChromium::setBackgroundColor):
(WebCore::LayerChromium::setMasksToBounds):
(WebCore::LayerChromium::setMaskLayer):
(WebCore::LayerChromium::setOpacity):
(WebCore::LayerChromium::setOpaque):
(WebCore::LayerChromium::setPosition):
(WebCore::LayerChromium::setSublayerTransform):
(WebCore::LayerChromium::setTransform):
(WebCore::LayerChromium::setScrollPosition):
(WebCore::LayerChromium::setScrollable):
(WebCore::LayerChromium::setDoubleSided):
(WebCore::LayerChromium::setReplicaLayer):
* platform/graphics/chromium/NonCompositedContentHost.cpp:
(WebCore::NonCompositedContentHost::notifySyncRequired):
* platform/graphics/chromium/NonCompositedContentHost.h:

Source/WebKit/chromium:

* tests/LayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Make root layer always opaque
commit-queue@webkit.org [Tue, 6 Dec 2011 20:17:02 +0000 (20:17 +0000)]
[Chromium] Make root layer always opaque
https://bugs.webkit.org/show_bug.cgi?id=70564

Patch by Dana Jansens <danakj@chromium.org> on 2011-12-06
Reviewed by James Robinson.

* platform/graphics/chromium/NonCompositedContentHost.cpp:
(WebCore::NonCompositedContentHost::NonCompositedContentHost):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a pid parameter to CrashLogs.find_newest_log
aroben@apple.com [Tue, 6 Dec 2011 20:04:25 +0000 (20:04 +0000)]
Add a pid parameter to CrashLogs.find_newest_log

When a PID is passed, only crash logs corresponding to a crashed process with that PID are
considered.

Fixes <http://webkit.org/b/73942> webkitpy provides no way to specify the PID of the crashed
process whose crash log you want to find

Reviewed by Dirk Pranke.

* Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs.find_newest_log): Added an optional pid parameter.
(CrashLogs._find_newest_log_darwin): Added a pid parameter. When specified, we look at each
candidate log's app_description extended attribute to see if that log corresponds to a
crashed process with the specified PID.

* Scripts/webkitpy/common/system/crashlogs_unittest.py:
(CrashLogsTest.test_find_newest_log_darwin): Added a few more mock crash logs with various
contents and PIDs. Added tests that show that the pid parameter to find_newest_log is
respected. Also fixed an erroneous use of assertTrue instead of assertEqual.

* Scripts/webkitpy/common/system/filesystem.py:
(FileSystem.getxattr): Added. On Darwin, calls through to the xattr module. On other
systems, raises a KeyError, mimicking the behavior on Darwin when the given attribute isn't
present.

* Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.__init__): Added an optional xattrs parameter. Documented other parameters.
(MockFileSystem.getxattr): Added. Just pulls the given attribute out of the xattrs
dictionary.

* Scripts/webkitpy/tool/commands/queries.py:
(CrashLog): Added help text. Added an optional PID parameter.
(CrashLog.execute): Pass the PID, if any, through to find_newest_log.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWait for Crash Reporter to finish even when it lets the crashed process die quickly
aroben@apple.com [Tue, 6 Dec 2011 20:04:08 +0000 (20:04 +0000)]
Wait for Crash Reporter to finish even when it lets the crashed process die quickly

NRWT was only waiting for Crash Reporter in cases where it was keeping the crashed process
alive beyond the normal timeout limit. In cases where the crashed process was able to die
faster, NRWT would assume that Crash Reporter had finished even though it often was still
running, which would lead to an incorrect crash log being picked up.

Part of <http://webkit.org/b/71380> NRWT incorrectly associates crash logs with tests

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess._reset):
(ServerProcess.write):
(ServerProcess._check_for_crash): Changed to use new set_crashed function instead of setting
.crashed directly. Added wait_for_crash_reporter parameter, which we pass along to
set_crashed.

(ServerProcess._handle_timeout): Fixed a logic error that would cause .crashed and
.timed_out both to be set to True in cases where Crash Reporter took a long time to run. Now
we bail out of handling the failure as a timeout if we find out that the process in fact
crashed. We tell _check_for_crash not to wait for Crash Reporter because we've already done
so.
(ServerProcess.set_crashed): Added. When the process crashes, we wait for Crash Reporter to
finish running (unless directed otherwise) so we can be sure the crash log has been saved to
disk.

* Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
(TrivialMockPort.is_crash_reporter): Added.

* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver._check_for_driver_crash): Changed to use set_crashed. (This also fixed a typo
that would have partially broken crash detection on Windows, if NRWT worked on Windows.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNRWT fails on unreleased versions of Mac OS X
abarth@webkit.org [Tue, 6 Dec 2011 20:00:03 +0000 (20:00 +0000)]
NRWT fails on unreleased versions of Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=72748

Reviewed by Dirk Pranke.

Hopefully this patch will make NRWT work on future versions on Mac OS X.
Most of the infrastructure was already in place, but there were some
asserts that failed.  I've tested this patch by haxoring the version
detection logic to simulate an unknown version.  We might need to
iterate based on feedback from folks with a real future version.

* Scripts/webkitpy/layout_tests/port/apple.py:
(ApplePort.__init__):
    - mac-future is an allowed port_name that's used internally by
      webkitpy to represent future versions of Mac OS X.
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(test_versions):
    - Test that we don't throw exceptions when dealing with future
      versions of Mac OS X.
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._expectations_from_skipped_files):
    - Demote this logging message to "debug".  It's expected that
      mac-future doesn't have a Skipped file.
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.__init__):
* Scripts/webkitpy/layout_tests/port/win.py:
(WinPort.__init__):
    - Re-order some code in these constructors so that
      self._operating_system is available to the ApplePort constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUI process crashes if the Web Process crashes on launch
simon.fraser@apple.com [Tue, 6 Dec 2011 19:58:41 +0000 (19:58 +0000)]
UI process crashes if the Web Process crashes on launch
https://bugs.webkit.org/show_bug.cgi?id=73943

Reviewed by Sam Weinig.

When the Web Process crashes on launch, the WebConnectionToWebProcess
object was getting deleted inside of didClose. Add a protector to
prevent this.

* UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::didClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Do not lose message flags when converting to/from Soup Requests/Responses
kubo@profusion.mobi [Tue, 6 Dec 2011 19:29:44 +0000 (19:29 +0000)]
[EFL] Do not lose message flags when converting to/from Soup Requests/Responses
https://bugs.webkit.org/show_bug.cgi?id=73924

Reviewed by Gustavo Noronha Silva.

Apply the same change added to the GTK+ port in r55086 to prevent
soup message flags from being lost by updating the request flags when
a response is received.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebPImageDecoder computes image width and height multiple times
noel.gordon@gmail.com [Tue, 6 Dec 2011 19:29:42 +0000 (19:29 +0000)]
WebPImageDecoder computes image width and height multiple times
https://bugs.webkit.org/show_bug.cgi?id=73796

Reviewed by Adam Barth.

Once sufficient image data arrives, we can compute the decoded image height
and width from the WEBP image header data.

From then on, the decoded image size is known so there's no need to re-read
it from the WEBP image header again.

No change in behavior, so no new tests.

* platform/image-decoders/webp/WEBPImageDecoder.cpp:
(WebCore::WEBPImageDecoder::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agooptimize TransformationMatrix::scale by not calling through to generic multiply
reed@google.com [Tue, 6 Dec 2011 19:27:31 +0000 (19:27 +0000)]
optimize TransformationMatrix::scale by not calling through to generic multiply
https://bugs.webkit.org/show_bug.cgi?id=73830

Reviewed by Kenneth Russell.

No new tests. Optimization only, existing tests exercise the code

* platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::scaleNonUniform):
(WebCore::TransformationMatrix::scale3d):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix page overlay rendering with AC.
jocelyn.turcotte@nokia.com [Tue, 6 Dec 2011 19:26:33 +0000 (19:26 +0000)]
[Qt] Fix page overlay rendering with AC.
https://bugs.webkit.org/show_bug.cgi?id=73935

Reviewed by Noam Rosenthal.

The inspector node highlight would display old highlights as well
since the overlay is normally rendered right after the page on top
of the same graphics context.

* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::paintContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGenerated some new expected results for Lion.
darin@apple.com [Tue, 6 Dec 2011 19:07:36 +0000 (19:07 +0000)]
Generated some new expected results for Lion.

Discussed aspects of this with Adam Roben and Dan Bernstein.

* platform/mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
* platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
* platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
* platform/mac/fast/regions/region-overflow-break-expected.txt: Added.
* platform/mac/fast/regions/render-region-custom-style-mark-expected.txt: Added.
* platform/mac/http/tests/inspector/resource-har-conversion-expected.txt: Updated.
* platform/mac/media/controls-strict-expected.txt: Added.
* platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Updated.
* platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Updated.
* platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
* platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Updated.
* platform/mac/svg/text/text-intro-05-t-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert WebCore track Settings changes made in r101977
eric.carlson@apple.com [Tue, 6 Dec 2011 19:01:22 +0000 (19:01 +0000)]
Revert WebCore track Settings changes made in r101977
https://bugs.webkit.org/show_bug.cgi?id=73879

Reviewed by Sam Weinig.

No new tests yet, still nothing to test.

* page/Settings.cpp: Move the preference setters back into the .h file.
* page/Settings.h:
(WebCore::Settings::setShouldDisplaySubtitles):
(WebCore::Settings::setShouldDisplayCaptions):
(WebCore::Settings::setShouldDisplayTextDescriptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium expectations update.
vsevik@chromium.org [Tue, 6 Dec 2011 18:37:47 +0000 (18:37 +0000)]
Unreviewed chromium expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMediaList: Remove constructor that takes a CSSImportRule*.
kling@webkit.org [Tue, 6 Dec 2011 18:19:38 +0000 (18:19 +0000)]
MediaList: Remove constructor that takes a CSSImportRule*.
<http://webkit.org/b/73833>

Reviewed by Antti Koivisto.

* css/MediaList.h:
* css/MediaList.cpp:

    Remove MediaList(CSSImportRule*, ...) constructor.

* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::CSSImportRule):

    Have CSSImportRule construct its MediaList by passing the parent
    style sheet, which is exactly what the old constructor accomplished.
    Also assert that we're always created with a non-null parent sheet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium tests rebaseline.
vsevik@chromium.org [Tue, 6 Dec 2011 17:59:49 +0000 (17:59 +0000)]
Unreviewed chromium tests rebaseline.

* platform/chromium-cg-mac-leopard/fast/table/027-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdded myself as a committer.
tommyw@google.com [Tue, 6 Dec 2011 17:57:39 +0000 (17:57 +0000)]
Added myself as a committer.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogetComputedStyle returns wrong value for margin-*
jarred@sencha.com [Tue, 6 Dec 2011 17:43:28 +0000 (17:43 +0000)]
getComputedStyle returns wrong value for margin-*
https://bugs.webkit.org/show_bug.cgi?id=73334

Source/WebCore:

margin-* getComputedStyle values should return the "used" absolute value when there is a renderer
and the specified value is relative (percentage, auto, etc.).
When there is no renderer, the specified value should be returned.
See http://dev.w3.org/csswg/cssom/#resolved-values.

Reviewed by Darin Adler.

Test: fast/css/getComputedStyle/getComputedStyle-resolved-values.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Modified baseline tests for getComputedStyle margin values where a "used" value is returned.

Reviewed by Darin Adler.

* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* fast/css/getComputedStyle/getComputedStyle-margin-auto-expected.txt:
* fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt:
* fast/css/getComputedStyle/getComputedStyle-resolved-values-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-resolved-values.html: Added.
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago REGRESSION (WebKit2): Kill ring is not cleared when selection changes
ap@apple.com [Tue, 6 Dec 2011 17:36:48 +0000 (17:36 +0000)]
    REGRESSION (WebKit2): Kill ring is not cleared when selection changes
        https://bugs.webkit.org/show_bug.cgi?id=73888
        <rdar://problem/10532310>

        Reviewed by Mark Rowe.

        Test: editing/pasteboard/emacs-ctrl-k-with-move.html

        * editing/Editor.cpp: (WebCore::Editor::respondToChangedSelection): Moved the code to clear
        kill ring from Mac WebKit, as it's needed in all Mac ports at least.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse HashMap<OwnPtr> in CollectionCache
darin@apple.com [Tue, 6 Dec 2011 17:30:00 +0000 (17:30 +0000)]
Use HashMap<OwnPtr> in CollectionCache
https://bugs.webkit.org/show_bug.cgi?id=73784

Reviewed by Andreas Kling.

* html/CollectionCache.cpp:
(WebCore::CollectionCache::copyCacheMap): Use adoptPtr.
(WebCore::CollectionCache::reset): Removed now-unneeded calls to deleteAllValues.
(WebCore::append): Added. Helper function for appending elements to the maps from
the collection cache.

* html/CollectionCache.h: Changed mapped type in NodeCacheMap to OwnPtr.
Added append function.

* html/HTMLCollection.cpp:
(WebCore::nameShouldBeVisibleInDocumentAll): Added, to factor out common code in
two functions below.
(WebCore::HTMLCollection::checkForNameMatch): Changed to call nameShouldBeVisibleInDocumentAll.
(WebCore::HTMLCollection::updateNameCache): Ditto. Also updated cache code to use the append
function, so it will work with OwnPtr. Also eliminated an unneeded get call before
each hash table add; we do both at once in the new append function.
* html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::updateNameCache): More of the same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd 8 bit paths to global object functions
msaboff@apple.com [Tue, 6 Dec 2011 17:21:11 +0000 (17:21 +0000)]
Add 8 bit paths to global object functions
https://bugs.webkit.org/show_bug.cgi?id=73875

Added 8 bit paths for converions methods.

This is worth 1.5% on kraken audio-oscillator,
1.6% on stanford-crypto-ccm and 2.5% on
stanford-crypto-sha256-iterative.  See bug for
a full report.

Reviewed by Oliver Hunt.

* runtime/JSGlobalObjectFunctions.cpp:
(JSC::decode): Split into a templated helper.
(JSC::parseInt): Split into a templated helper.
(JSC::parseFloat): Added an 8 bit path
(JSC::globalFuncEscape): Added 8 bit path
(JSC::globalFuncUnescape): Added 8 bit path
* runtime/JSStringBuilder.h:
(JSC::JSStringBuilder::append): New append for LChar
* wtf/text/StringBuilder.h:
(WTF::StringBuilder::append): New append for LChar

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium expectations update.
vsevik@chromium.org [Tue, 6 Dec 2011 17:05:57 +0000 (17:05 +0000)]
Unreviewed chromium expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdded myself as a committer.
peter@chromium.org [Tue, 6 Dec 2011 16:36:03 +0000 (16:36 +0000)]
Added myself as a committer.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[qt][wk2] Tests of QQuickWebView assert in debug builds when destroying QQuickWebView...
commit-queue@webkit.org [Tue, 6 Dec 2011 16:35:41 +0000 (16:35 +0000)]
[qt][wk2] Tests of QQuickWebView assert in debug builds when destroying QQuickWebViewPrivate
https://bugs.webkit.org/show_bug.cgi?id=73907

Patch by Michael Brüning <michael.bruning@nokia.com> on 2011-12-06
Reviewed by Kenneth Rohde Christiansen.

* UIProcess/API/qt/qquickwebview.cpp: Disconnect signals from
QtViewportInteractionEngine in ~QQuickWebViewPrivate.
(QQuickWebViewPrivate::~QQuickWebViewPrivate):
* UIProcess/API/qt/qquickwebview_p_p.h: Remove empty inline implementation of ~QQuickWebViewPrivate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r102102.
vsevik@chromium.org [Tue, 6 Dec 2011 16:25:15 +0000 (16:25 +0000)]
Unreviewed, rolling out r102102.
http://trac.webkit.org/changeset/102102
https://bugs.webkit.org/show_bug.cgi?id=73925

Causes segmentation fault on chromium unit_tests,
content_unittests, sync_unit_tests (Requested by vsevik on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-06

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Web Inspector: getFunctionLocation should return scriptId as String not...
yurys@chromium.org [Tue, 6 Dec 2011 16:16:44 +0000 (16:16 +0000)]
[Chromium] Web Inspector: getFunctionLocation should return scriptId as String not as int
https://bugs.webkit.org/show_bug.cgi?id=73892

Reviewed by Pavel Feldman.

* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::functionLocationCallback): scriptId should be a string not a number
* inspector/Inspector.json: removed unused parameter

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium expectations update.
vsevik@chromium.org [Tue, 6 Dec 2011 15:38:57 +0000 (15:38 +0000)]
Unreviewed chromium expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium tests rebaseline.
vsevik@chromium.org [Tue, 6 Dec 2011 15:36:15 +0000 (15:36 +0000)]
Unreviewed chromium tests rebaseline.

* platform/chromium-cg-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.
* platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium expectations update.
vsevik@chromium.org [Tue, 6 Dec 2011 15:31:00 +0000 (15:31 +0000)]
Unreviewed chromium expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add initial support for focusing when entering edit mode.
kenneth@webkit.org [Tue, 6 Dec 2011 15:24:26 +0000 (15:24 +0000)]
[Qt] Add initial support for focusing when entering edit mode.

Reviewed by Simon Hausmann.

Next step would be to properly upstream our EditorState code.

* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::focusEditableArea):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/qt/QtPageClient.cpp:
(QtPageClient::focusEditableArea):
* UIProcess/qt/QtPageClient.h:
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::itemCoordFromCSS):
(WebKit::QtViewportInteractionEngine::itemRectFromCSS):
(WebKit::QtViewportInteractionEngine::focusEditableArea):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
* UIProcess/qt/QtViewportInteractionEngine.h:
* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::focusEditableArea):
* UIProcess/qt/QtWebPageEventHandler.h:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection):
(WebKit::WebEditorClient::setInputMethodState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] Unreviewed gardening. Skip a failing test because of missing layoutTestControll...
ossy@webkit.org [Tue, 6 Dec 2011 15:05:40 +0000 (15:05 +0000)]
[WK2] Unreviewed gardening. Skip a failing test because of missing layoutTestController.dumpFrameLoadCallbacks()
https://bugs.webkit.org/show_bug.cgi?id=42331

* platform/wk2/Skipped: Skip http/tests/security/mixedContent/insecure-video-in-iframe.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium expectations update.
vsevik@chromium.org [Tue, 6 Dec 2011 15:04:28 +0000 (15:04 +0000)]
Unreviewed chromium expectations update.

* platform/chromium-cg-mac-leopard/fast/table/027-vertical-expected.png: Added.
* platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug14929-expected.png:
* platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug2947-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium expectations update.
vsevik@chromium.org [Tue, 6 Dec 2011 14:38:08 +0000 (14:38 +0000)]
Unreviewed chromium expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable ParallelJobs by default
kbalazs@webkit.org [Tue, 6 Dec 2011 14:30:16 +0000 (14:30 +0000)]
Enable ParallelJobs by default
https://bugs.webkit.org/show_bug.cgi?id=70032

Reviewed by Zoltan Herczeg.

Source/JavaScriptCore:

Relanding with typo fix.

According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.

Remove the ENABLE(PARALLEL_JOBS) guard.
Fix build on Windows and Chromium.

* JavaScriptCore.gypi:  Add the files to the build. It was
missing for the gyp build system.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Export symbols.
* wtf/ParallelJobs.h:
* wtf/ParallelJobsGeneric.cpp:
(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):
Deinline these to avoid exporting a lot of symbols.
These are non-trivial and called only once on a given object
so it doesn't seems to be worthwile to inline them.
Additionally fix a signed-unsigned comparison in the constructor.
* wtf/ParallelJobsGeneric.h:
* wtf/Platform.h:

Source/WebCore:

Covered by existing tests.

According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.

Remove the ENABLE(PARALLEL_JOBS) guard. Fix the Windows build
by qualifying ParallelJobs with the WTF namespace (otherwise
MSVC believes it belongs to WebCore which is likely a compiler bug).

* platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::setInteriorPixelsWorker):
(WebCore::FEConvolveMatrix::platformApplySoftware):
* platform/graphics/filters/FEConvolveMatrix.h:
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplyWorker):
(WebCore::FEGaussianBlur::platformApply):
* platform/graphics/filters/FEGaussianBlur.h:
* platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::platformApplyGenericWorker):
(WebCore::FELighting::platformApplyGeneric):
* platform/graphics/filters/FELighting.h:
* platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::platformApplyWorker):
(WebCore::FEMorphology::platformApply):
* platform/graphics/filters/FEMorphology.h:
* platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::fillRegionWorker):
(WebCore::FETurbulence::platformApplySoftware):
* platform/graphics/filters/FETurbulence.h:
* platform/graphics/filters/arm/FELightingNEON.cpp:
(WebCore::FELighting::platformApplyNeonWorker):
* platform/graphics/filters/arm/FELightingNEON.h:
(WebCore::FELighting::platformApplyNeon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Mac] Unreviewed gardening. Paint the bot green skipping with all failing tests.
ossy@webkit.org [Tue, 6 Dec 2011 14:19:21 +0000 (14:19 +0000)]
[Qt][Mac] Unreviewed gardening. Paint the bot green skipping with all failing tests.

* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix assertion in QtWebPageEventHandler.cpp
commit-queue@webkit.org [Tue, 6 Dec 2011 14:17:16 +0000 (14:17 +0000)]
[Qt] Fix assertion in QtWebPageEventHandler.cpp
https://bugs.webkit.org/show_bug.cgi?id=73908

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-12-06
Reviewed by Kenneth Rohde Christiansen.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] fast/forms/access-key-for-all-elements.html fails
ossy@webkit.org [Tue, 6 Dec 2011 14:13:48 +0000 (14:13 +0000)]
[Qt][WK2] fast/forms/access-key-for-all-elements.html fails
https://bugs.webkit.org/show_bug.cgi?id=73917

* platform/qt-wk2/Skipped: Skip fast/forms/access-key-for-all-elements.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed assertion fix for r102123.
kling@webkit.org [Tue, 6 Dec 2011 13:59:18 +0000 (13:59 +0000)]
Unreviewed assertion fix for r102123.

* platform/KURL.cpp:
(WebCore::checkEncodedString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] Unreviewed gardening. New tests introduced in 100895 fail
ossy@webkit.org [Tue, 6 Dec 2011 13:55:23 +0000 (13:55 +0000)]
[WK2] Unreviewed gardening. New tests introduced in 100895 fail
https://bugs.webkit.org/show_bug.cgi?id=73913

* platform/wk2/Skipped: Skip failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium expectations update.
vsevik@chromium.org [Tue, 6 Dec 2011 13:49:43 +0000 (13:49 +0000)]
Unreviewed chromium expectations update.

* platform/chromium-cg-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
* platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] build-jsc script doesn't work
commit-queue@webkit.org [Tue, 6 Dec 2011 13:43:24 +0000 (13:43 +0000)]
[Qt] build-jsc script doesn't work
https://bugs.webkit.org/show_bug.cgi?id=73910

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2011-12-06
Reviewed by Tor Arne Vestbø.

.:

* WebKit.pro: Move WTF SUBDIR stuff out of here and
straight into JavaScriptCore/JavaScriptCore.pro.
Unconditionally "recurse" into JavaScriptCore now,
as we'll do the v8 scoping there to only build WTF.

Source/JavaScriptCore:

* JavaScriptCore.pro: Build WTF before JavaScriptCore and JSC
(moved from top-level WebKit.pro). Also add v8 scopes to only build
WTF during v8 builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium expectations update.
vsevik@chromium.org [Tue, 6 Dec 2011 13:43:19 +0000 (13:43 +0000)]
Unreviewed chromium expectations update.

* platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt:
* platform/chromium-cg-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt:
* platform/chromium-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt:
* platform/chromium-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSimplify KURL's checkEncodedString()
benjamin@webkit.org [Tue, 6 Dec 2011 13:04:45 +0000 (13:04 +0000)]
Simplify KURL's checkEncodedString()
https://bugs.webkit.org/show_bug.cgi?id=73890

Reviewed by Andreas Kling.

The method was reimplementing String::containsOnlyASCII().
Use the method from String and we can remove the #if NDEBUG.

* platform/KURL.cpp:
(WebCore::checkEncodedString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium expectations update.
vsevik@chromium.org [Tue, 6 Dec 2011 12:53:48 +0000 (12:53 +0000)]
Unreviewed chromium expectations update.

* tests/KURLTest.cpp:
(ComponentCase::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium expectations update.
vsevik@chromium.org [Tue, 6 Dec 2011 12:12:11 +0000 (12:12 +0000)]
Unreviewed chromium expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r102111.
vsevik@chromium.org [Tue, 6 Dec 2011 11:38:16 +0000 (11:38 +0000)]
Unreviewed, rolling out r102111.
http://trac.webkit.org/changeset/102111
https://bugs.webkit.org/show_bug.cgi?id=73902

Breaks compilation (Requested by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-06

* editing/Editor.cpp:
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
* editing/Editor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Refactoring] Accessing Node::m_document should be minimized.
commit-queue@webkit.org [Tue, 6 Dec 2011 11:30:45 +0000 (11:30 +0000)]
[Refactoring] Accessing Node::m_document should be minimized.
https://bugs.webkit.org/show_bug.cgi?id=73800

Patch by Hajime Morrita <morrita@chromium.org> on 2011-12-06
Reviewed by Kent Tamura.

No new tests. No behavioral change.

Replaced m_document reference with the document() accessor
or temporaril variables. This is a preparation for using
m_document space to point a shadow root pointer.

* dom/Document.h:
(WebCore::Node::Node):
* dom/Node.cpp:
(WebCore::Node::~Node):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=73889
commit-queue@webkit.org [Tue, 6 Dec 2011 11:24:03 +0000 (11:24 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=73889
TextCheckingParagraph::offsetTo should not have a side effect.

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-06
Reviewed by Hajime Morita.

Since TextCheckingParagraph::offsetTo had a side effect, its cache often became inconsistent.
This is likely to cause a bug when changing SpellChecker and Editor.

No new tests. Covered by existing tests.

* editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingParagraph::offsetTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] http/tests/misc/drag-over-iframe-invalid-source-crash.html and fast/events/drag...
ossy@webkit.org [Tue, 6 Dec 2011 11:20:54 +0000 (11:20 +0000)]
[Qt] http/tests/misc/drag-over-iframe-invalid-source-crash.html and fast/events/drag-selects-image.html fails with timeout
https://bugs.webkit.org/show_bug.cgi?id=73901

* platform/qt-wk1/Skipped: Skip the failint tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium tests rebaseline.
vsevik@chromium.org [Tue, 6 Dec 2011 11:12:40 +0000 (11:12 +0000)]
Unreviewed chromium tests rebaseline.

* platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug14929-expected.png: Renamed from LayoutTests/platform/chromium/tables/mozilla/bugs/bug14929-expected.png.
* platform/chromium-mac-leopard/fast/table/027-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug14929-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2947-expected.png:
* platform/chromium-mac-snowleopard/fast/table/027-vertical-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug14929-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2947-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Set texture limits as multiples of viewport size instead of hardcoded...
commit-queue@webkit.org [Tue, 6 Dec 2011 11:05:02 +0000 (11:05 +0000)]
[chromium] Set texture limits as multiples of viewport size instead of hardcoded values
https://bugs.webkit.org/show_bug.cgi?id=72202

Patch by Eric Penner <epenner@google.com> on 2011-12-06
Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayers): added viewport param
(WebCore::LayerRendererChromium::initializeSharedObjects): ditto
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::highLimitBytes): calculated based on viewport
(WebCore::TextureManager::reclaimLimitBytes): ditto
(WebCore::TextureManager::lowLimitBytes): ditto
(WebCore::TextureManager::TextureManager): added viewport param
(WebCore::TextureManager::setMaxMemoryLimitBytes): changed name
(WebCore::TextureManager::setPreferredMemoryLimitBytes): added function
(WebCore::TextureManager::requestTexture): added viewport param
* platform/graphics/chromium/TextureManager.h: ditto
(WebCore::TextureManager::create): ditto
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp: ditto
(WebCore::CCLayerTreeHost::initialize): ditto
(WebCore::CCLayerTreeHost::beginCommitOnImplThread): ditto
(WebCore::CCLayerTreeHost::setViewport): ditto
(WebCore::CCLayerTreeHost::setVisible): ditto
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread): ditto

Source/WebKit/chromium:

* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Tue, 6 Dec 2011 10:52:00 +0000 (10:52 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-5.0/Skipped:
 - Skip one more failing tests because of missing testfont handling.
 - Remove non-existent files.
* platform/qt-5.0/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
* platform/qt-5.0/svg/custom/pointer-events-text-css-transform-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[TexMap][QT] Draw the borders of media and webgl elements in TexMap.
commit-queue@webkit.org [Tue, 6 Dec 2011 10:47:13 +0000 (10:47 +0000)]
[TexMap][QT] Draw the borders of media and webgl elements in TexMap.
https://bugs.webkit.org/show_bug.cgi?id=73817

GraphicsContext3D only draws the content of the WebGL canvas, not the additional
CSS such as the borders. TextureMapper should render the content of a
media/webgl layer before drawing the actual canvas.
This makes LayoutTests/compositing/webgl/webgl-reflection.html work.

Patch by Huang Dongsung <luxtella@company100.net> on 2011-12-06
Reviewed by Noam Rosenthal.

* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::setContentsNeedsDisplay):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::paintSelf):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r102043.
vsevik@chromium.org [Tue, 6 Dec 2011 10:37:45 +0000 (10:37 +0000)]
Unreviewed, rolling out r102043.
http://trac.webkit.org/changeset/102043
https://bugs.webkit.org/show_bug.cgi?id=73898

Breaks chromium mac-cg compilation. (Requested by vsevik on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-06

Source/WebCore:

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsToImage):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore::GraphicsLayerChromium::contentsLayer):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::setContents):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/ImageLayerChromiumTest.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefactoring: Editor::markAllMisspellingsAndBadGrammarInRanges should be refactored.
commit-queue@webkit.org [Tue, 6 Dec 2011 10:31:57 +0000 (10:31 +0000)]
Refactoring: Editor::markAllMisspellingsAndBadGrammarInRanges should be refactored.
https://bugs.webkit.org/show_bug.cgi?id=73628

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-06
Reviewed by Hajime Morita.

Extracted a code for adding markers and replacing misspelled words from WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges.

No new tests. covered by existing tests.

* editing/Editor.cpp:
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  Extracted a code for adding markers and replacing missplled words, and moved to markAndReplaceFor.
(WebCore::Editor::markAndReplaceFor):
* editing/Editor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Mac] Building debug version only fails.
zeno.albisser@nokia.com [Tue, 6 Dec 2011 10:06:46 +0000 (10:06 +0000)]
[Qt][Mac] Building debug version only fails.
https://bugs.webkit.org/show_bug.cgi?id=73895

WebKit pro/pri files should not explicitly adjust
the debug_and_release settings.

Reviewed by Kenneth Rohde Christiansen.

* declarative/experimental/experimental.pri:
* declarative/public.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Audits] Implement "Stop" button and progress bar instead of spinner.
apavlov@chromium.org [Tue, 6 Dec 2011 10:05:07 +0000 (10:05 +0000)]
Web Inspector: [Audits] Implement "Stop" button and progress bar instead of spinner.
https://bugs.webkit.org/show_bug.cgi?id=73626

Reviewed by Yury Semikhatsky.

* English.lproj/localizedStrings.js:
* inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView):
(WebInspector.AuditLauncherView.prototype._setAuditRunning):
(WebInspector.AuditLauncherView.prototype._launchButtonClicked):
(WebInspector.AuditLauncherView.prototype._createLauncherUI):
(WebInspector.AuditLauncherView.prototype._updateResourceProgress):
(WebInspector.AuditLauncherView.prototype._updateButton):
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
(WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.documentLoaded):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
(WebInspector.AuditRules.CacheControlRule.prototype.doRun):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.onDocumentAvailable):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.onDocumentAvailable):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun.resultCallback):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun):
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel):
(WebInspector.AuditsPanel.prototype._executeAudit.ruleResultReadyCallback):
(WebInspector.AuditsPanel.prototype._executeAudit):
(WebInspector.AuditsPanel.prototype._auditFinishedCallback):
(WebInspector.AuditsPanel.prototype.terminateAudit):
(WebInspector.AuditCategory.prototype.run):
(WebInspector.AuditRule.prototype.run):
(WebInspector.AuditRule.prototype.doRun):
(WebInspector.AuditProgressMonitor):
(WebInspector.AuditProgressMonitor.prototype.setTotalWork):
(WebInspector.AuditProgressMonitor.prototype.worked):
(WebInspector.AuditProgressMonitor.prototype.get indeterminate):
(WebInspector.AuditProgressMonitor.prototype.done):
(WebInspector.AuditProgressMonitor.prototype.get canceled):
(WebInspector.AuditProgressMonitor.prototype.set canceled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<style scoped>: disable on Windows by default
rolandsteiner@chromium.org [Tue, 6 Dec 2011 08:38:54 +0000 (08:38 +0000)]
<style scoped>: disable on Windows by default
https://bugs.webkit.org/show_bug.cgi?id=73893

Reviewed by Andreas Kling.

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] [WK2] MiniBrowser assert on startup in debug build after r101713
commit-queue@webkit.org [Tue, 6 Dec 2011 08:38:54 +0000 (08:38 +0000)]
[Qt] [WK2] MiniBrowser assert on startup in debug build after r101713
https://bugs.webkit.org/show_bug.cgi?id=73874

This change partially reverts r101713 restoring original behaviour for
KUrl creation from empty string and fixes asserts in debug build.

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-12-06
Reviewed by Alexey Proskuryakov.

No new tests. Tests from r101713 pass.

* platform/KURL.cpp:
(WebCore::KURL::init):
(WebCore::KURL::parse):
* platform/KURL.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse HashMap<OwnPtr> for EventListenerMap's internal map.
kling@webkit.org [Tue, 6 Dec 2011 08:21:43 +0000 (08:21 +0000)]
Use HashMap<OwnPtr> for EventListenerMap's internal map.
<http://webkit.org/b/73761>

Reviewed by Benjamin Poulain.

Changed the value type of EventListenerMap::m_hashMap to OwnPtr<EventListenerVector>.
This means we no longer need to manually delete the vectors when taking them out of
the map, which makes the code a little prettier.

A few tweaks were necessary; release() instead of leakPtr() when switching modes
and adoptPtr()/get() sprinkled as needed.

* dom/EventListenerMap.h:
* dom/EventListenerMap.cpp:
(WebCore::EventListenerMap::clear):
(WebCore::EventListenerMap::add):
(WebCore::EventListenerMap::remove):
(WebCore::EventListenerMap::find):
(WebCore::EventListenerMap::removeFirstEventListenerCreatedFromMarkup):
(WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Refactoring] In webkitpy/bindings/main.py, replace subprocess.Popen() with Executive
haraken@chromium.org [Tue, 6 Dec 2011 08:05:11 +0000 (08:05 +0000)]
[Refactoring] In webkitpy/bindings/main.py, replace subprocess.Popen() with Executive
https://bugs.webkit.org/show_bug.cgi?id=73637

Reviewed by Adam Barth.

This patch replaces subprocess.Popen() with Executive, similar to other
Python scripts in webkitpy/. I manually confirmed that run-bindings-tests
works well for cases where no exception is raised, no exception is raised
but diff is found, and ScriptError is raised.

* Scripts/run-bindings-tests:
(main):
* Scripts/webkitpy/bindings/main.py: Replaces subprocess.Popen() with Executive.
(BindingsTests.__init__):
(BindingsTests.generate_from_idl):
(BindingsTests.generate_supplemental_dependency):
(BindingsTests.detect_changes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Tue, 6 Dec 2011 08:00:53 +0000 (08:00 +0000)]
[Qt] Unreviewed gardening.

Layout Test fast/forms/input-step-as-double.html fails after running touch event tests
https://bugs.webkit.org/show_bug.cgi?id=71181

* platform/qt/Skipped: Skip fast/forms/input-step-as-double.html until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Tue, 6 Dec 2011 07:51:13 +0000 (07:51 +0000)]
[Qt] Unreviewed gardening.

New test introduced in r102048 fails on Qt-WK1
https://bugs.webkit.org/show_bug.cgi?id=73366

* platform/qt-wk1/Skipped: Skip fast/events/dont-loose-last-event.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102103 268f45cc-cd09-0410-ab3c-d52691b4dbfc