15 years ago2007-12-14 Juan A. Suarez Romero <jasuarez@igalia.com>
alp@webkit.org [Mon, 17 Dec 2007 20:54:49 +0000 (20:54 +0000)]
2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>

        Reviewed by Alp Toker.

        [GTK] Eliminate webkit_init()

        Move webkit initialization to WebView class init.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-17 Luca Bruno <lethalman88@gmail.com>
alp@webkit.org [Mon, 17 Dec 2007 20:51:36 +0000 (20:51 +0000)]
2007-12-17  Luca Bruno  <lethalman88@gmail.com>

        Reviewed by Alp Toker.

        gdklauncher doesnt change URL in adress GTKEntry.

        Let DOMDocument observers do their work before emitting title-changed.
        The load-committed signal has been added for both the view and the frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-17 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Mon, 17 Dec 2007 19:48:29 +0000 (19:48 +0000)]
2007-12-17  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Darin.

        <rdar://problem/5651291> REGRESSION: Flash content doesn't display

        We were passing NPEvent** instead of NPEvent* to NPP_HandleEvent.

        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginViewWin::dispatchNPEvent): Changed to take NPEvent&, not
        (WebCore::PluginViewWin::paint): Pass NPEvent, not NPEvent*
        (WebCore::PluginViewWin::handleKeyboardEvent): same
        (WebCore::PluginViewWin::handleMouseEvent): same
        * plugins/win/PluginViewWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix argument to window.open.
andersca@apple.com [Mon, 17 Dec 2007 19:44:31 +0000 (19:44 +0000)]
    Fix argument to window.open.

        * http/tests/misc/window-open-then-write.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-17 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Mon, 17 Dec 2007 18:42:35 +0000 (18:42 +0000)]
2007-12-17  Mark Rowe  <mrowe@apple.com>

        Update test results after r28812.

        * platform/mac-tiger/fast/css/css2-system-color-expected.txt:
        * platform/mac/fast/css/css2-system-color-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap@webkit.org [Mon, 17 Dec 2007 18:34:17 +0000 (18:34 +0000)]
    Reviewed by Darin.

        Live to the promise of never making AppKit special character codes visible via DOM.

        Test: fast/events/arrow-keys-on-body.html

        * page/EventHandler.cpp:
        (WebCore::EventHandler::keyEvent): Check for empty keypress characters after disambiguation,
        to let quirks-aware code strip special charactrers.
        * platform/mac/KeyEventMac.mm:
        (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): If not in keyboard event quirks
        mode, remove the text if it's a special character.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-17 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Mon, 17 Dec 2007 18:21:43 +0000 (18:21 +0000)]
2007-12-17  Mark Rowe  <mrowe@apple.com>

        Reviewed by Darin Adler.

        Fix incorrect array size and incorrect array index in convertNSColorToColor.

        * rendering/RenderThemeMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mark Rowe.
darin@apple.com [Mon, 17 Dec 2007 17:53:23 +0000 (17:53 +0000)]
    Reviewed by Mark Rowe.

        - fix http://bugs.webkit.org/show_bug.cgi?id=16468
          REGRESSION(r28781): Crash running storage/transaction_callback_exception_crash.html

        * storage/DatabaseThread.cpp:
        (WebCore::DatabaseThread::dispatchNextTaskIdentifier): Use a RefPtr for the database
        because there's no guarantee it won't lose its last reference otherwise.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej Stachowiak.
mitz@apple.com [Mon, 17 Dec 2007 17:09:56 +0000 (17:09 +0000)]
    Reviewed by Maciej Stachowiak.

        - fix <rdar://problem/5333260> Some Chinese characters in Text Encoding menu are bold, others are not
          and <rdar://problem/5280188> Chinese text looks worse on Safari for Windows cf. Safari for Mac

        * platform/graphics/win/FontCacheWin.cpp:
        (WebCore::FontCache::getFontDataForCharacters): To ensure that font
        linking gives consistent results for characters that are exclusive to
        the simplified Chinese code page and characters that belong to that
        code page and other code pages, always ask to map to simplified Chinese
        alone first.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-17 Christian Dywan <christian@twotoasts.de>
alp@webkit.org [Mon, 17 Dec 2007 16:18:44 +0000 (16:18 +0000)]
2007-12-17  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Alp Toker.

        Implement Icon for Gtk

        Icon provides a GdkPixbuf containing a themed icon.
        The icon theme is probed for an icon name according to the
        Icon Naming Specification or conventional Gnome icon names respectively.

        See http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html

        * platform/graphics/Icon.h:
        * platform/graphics/gtk/IconGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoSunSpider:
mjs@apple.com [Mon, 17 Dec 2007 11:50:53 +0000 (11:50 +0000)]

        Reviewed by Mark.

        - fix compare feature

        * hosted/sunspider-results.html:


        Reviewed by Mark.

        - fix compare feature

        * perf/sunspider-0.9/sunspider-results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Mark.
mjs@apple.com [Mon, 17 Dec 2007 09:44:17 +0000 (09:44 +0000)]
    Rubber stamped by Mark.

        - Add a copy of SunSpider 0.9 to the site

        * perf: Added.
        * perf/sunspider-0.9: Added.
        * perf/sunspider-0.9/3d-cube.html: Added.
        * perf/sunspider-0.9/3d-morph.html: Added.
        * perf/sunspider-0.9/3d-raytrace.html: Added.
        * perf/sunspider-0.9/access-binary-trees.html: Added.
        * perf/sunspider-0.9/access-fannkuch.html: Added.
        * perf/sunspider-0.9/access-nbody.html: Added.
        * perf/sunspider-0.9/access-nsieve.html: Added.
        * perf/sunspider-0.9/bitops-3bit-bits-in-byte.html: Added.
        * perf/sunspider-0.9/bitops-bits-in-byte.html: Added.
        * perf/sunspider-0.9/bitops-bitwise-and.html: Added.
        * perf/sunspider-0.9/bitops-nsieve-bits.html: Added.
        * perf/sunspider-0.9/controlflow-recursive.html: Added.
        * perf/sunspider-0.9/crypto-aes.html: Added.
        * perf/sunspider-0.9/crypto-md5.html: Added.
        * perf/sunspider-0.9/crypto-sha1.html: Added.
        * perf/sunspider-0.9/date-format-tofte.html: Added.
        * perf/sunspider-0.9/date-format-xparb.html: Added.
        * perf/sunspider-0.9/math-cordic.html: Added.
        * perf/sunspider-0.9/math-partial-sums.html: Added.
        * perf/sunspider-0.9/math-spectral-norm.html: Added.
        * perf/sunspider-0.9/regexp-dna.html: Added.
        * perf/sunspider-0.9/string-base64.html: Added.
        * perf/sunspider-0.9/string-fasta.html: Added.
        * perf/sunspider-0.9/string-tagcloud.html: Added.
        * perf/sunspider-0.9/string-unpack-code.html: Added.
        * perf/sunspider-0.9/string-validate-input.html: Added.
        * perf/sunspider-0.9/sunspider-analyze-results.js: Added.
        * perf/sunspider-0.9/sunspider-compare-results.js: Added.
        * perf/sunspider-0.9/sunspider-driver.html: Added.
        * perf/sunspider-0.9/sunspider-record-result.js: Added.
        * perf/sunspider-0.9/sunspider-results.html: Added.
        * perf/sunspider-0.9/sunspider-test-prefix.js: Added.
        * perf/sunspider-0.9/sunspider.css: Added.
        * perf/sunspider-0.9/sunspider.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mark.
mjs@apple.com [Mon, 17 Dec 2007 09:43:01 +0000 (09:43 +0000)]
    Reviewed by Mark.

        - Change the format of the output URL to be shorter, to meet IE constraints

        * hosted/sunspider-driver.html:
        * hosted/sunspider-results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - speculative build fix for non-gcc platforms
darin@apple.com [Mon, 17 Dec 2007 08:56:54 +0000 (08:56 +0000)]
    - speculative build fix for non-gcc platforms

        * pcre/pcre_exec.cpp: (match): Remove unused cases from return switch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mitz.
weinig@apple.com [Mon, 17 Dec 2007 07:19:08 +0000 (07:19 +0000)]
    Reviewed by Mitz.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=16466
        Move the JS Location object to its own file

        - Move Location into its own file and rename it JSLocation.

        * DerivedSources.make:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSDocumentCustom.cpp:
        * bindings/js/JSLocation.cpp: Copied from WebCore/bindings/js/kjs_window.cpp.
        * bindings/js/JSLocation.h: Copied from WebCore/bindings/js/kjs_window.h.
        * bindings/js/kjs_window.cpp:
        * bindings/js/kjs_window.h:
        * history/CachedPage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Sam Weinig.
mitz@apple.com [Mon, 17 Dec 2007 06:26:50 +0000 (06:26 +0000)]
    Reviewed by Sam Weinig.

        - make 'cursor: copy' and 'cursor: none' work.

        Already covered by manual-tests/cursor.html

        * rendering/RenderStyle.h: Increase the _cursor_style field to 6 bits,
        needed for the 33rd and 34th cursor values.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoSpeculative build fix for non-Mac platforms.
mrowe@apple.com [Mon, 17 Dec 2007 06:01:22 +0000 (06:01 +0000)]
Speculative build fix for non-Mac platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRefactor Mac plugin stream code to use the shared NetscapePlugInStreamLoader implemen...
mrowe@apple.com [Mon, 17 Dec 2007 06:00:49 +0000 (06:00 +0000)]
Refactor Mac plugin stream code to use the shared NetscapePlugInStreamLoader implementation.

Reviewed by Maciej Stachowiak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
weinig@apple.com [Mon, 17 Dec 2007 04:50:53 +0000 (04:50 +0000)]
    Reviewed by Maciej.

        Yet more of http://bugs.webkit.org/show_bug.cgi?id=16385
        Cleanup kjs_window

        - Move ScheduledAction into its own file and put it in the WebCore namespace.

        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/PausedTimeouts.cpp:
        * bindings/js/PausedTimeouts.h:
        * bindings/js/ScheduledAction.cpp: Copied from bindings/js/kjs_window.cpp.
        * bindings/js/ScheduledAction.h: Copied from bindings/js/kjs_window.h.
        * bindings/js/kjs_window.cpp:
        * bindings/js/kjs_window.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin@apple.com [Mon, 17 Dec 2007 04:19:25 +0000 (04:19 +0000)]
    Reviewed by Maciej.

        - http://bugs.webkit.org/show_bug.cgi?id=16438
        - removed some more unused code
        - changed quite a few more names to WebKit-style
        - moved more things out of pcre_internal.h
        - changed some indentation to WebKit-style
        - improved design of the functions for reading and writing
          2-byte values from the opcode stream (in pcre_internal.h)

        * pcre/dftables.cpp:
        (main): Added the kjs prefix a normal way in lieu of using macros.

        * pcre/pcre_compile.cpp: Moved some definitions here from pcre_internal.h.
        (errorText): Name changes, fewer typedefs.
        (checkEscape): Ditto. Changed uppercase conversion to use toASCIIUpper.
        (isCountedRepeat): Name change.
        (readRepeatCounts): Name change.
        (firstSignificantOpcode): Got rid of the use of OP_lengths, which is
        very lightly used here. Hard-coded the length of OP_BRANUMBER.
        (firstSignificantOpcodeSkippingAssertions): Ditto. Also changed to
        use the advanceToEndOfBracket function.
        (getOthercaseRange): Name changes.
        (encodeUTF8): Ditto.
        (compileBranch): Name changes. Removed unused after_manual_callout and
        the code to handle it. Removed code to handle OP_ONCE since we never
        emit this opcode. Changed to use advanceToEndOfBracket in more places.
        (compileBracket): Name changes.
        (branchIsAnchored): Removed code to handle OP_ONCE since we never emit
        this opcode.
        (bracketIsAnchored): Name changes.
        (branchNeedsLineStart): More fo the same.
        (bracketNeedsLineStart): Ditto.
        (branchFindFirstAssertedCharacter): Removed OP_ONCE code.
        (bracketFindFirstAssertedCharacter): More of the same.
        (calculateCompiledPatternLengthAndFlags): Ditto.
        (returnError): Name changes.
        (jsRegExpCompile): Ditto.

        * pcre/pcre_exec.cpp: Moved some definitions here from pcre_internal.h.
        (matchRef): Updated names.
        Improved macros to use the do { } while(0) idiom so they expand to single
        statements rather than to blocks or multiple statements. And refeactored
        the recursive match macros.
        (MatchStack::pushNewFrame): Name changes.
        (getUTF8CharAndIncrementLength): Name changes.
        (match): Name changes. Removed the ONCE opcode.
        (jsRegExpExecute): Name changes.

        * pcre/pcre_internal.h: Removed quite a few unneeded includes. Rewrote
        quite a few comments. Removed the macros that add kjs prefixes to the
        functions with external linkage; instead renamed the functions. Removed
        the unneeded typedefs pcre_uint16, pcre_uint32, and uschar. Removed the
        dead and not-all-working code for LINK_SIZE values other than 2, although
        we aim to keep the abstraction working. Removed the OP_LENGTHS macro.
        (put2ByteValue): Replaces put2ByteOpcodeValueAtOffset.
        (get2ByteValue): Replaces get2ByteOpcodeValueAtOffset.
        (put2ByteValueAndAdvance): Replaces put2ByteOpcodeValueAtOffsetAndAdvance.
        (putLinkValueAllowZero): Replaces putOpcodeValueAtOffset; doesn't do the
        addition, since a comma is really no better than a plus sign. Added an
        assertion to catch out of range values and changed the parameter type to
        int rather than unsigned.
        (getLinkValueAllowZero): Replaces getOpcodeValueAtOffset.
        (putLinkValue): New function that most former callers of the
        putOpcodeValueAtOffset function can use; asserts the value that is
        being stored is non-zero and then calls putLinkValueAllowZero.
        (getLinkValue): Ditto.
        (putLinkValueAndAdvance): Replaces putOpcodeValueAtOffsetAndAdvance. No
        caller was using an offset, which makes sense given the advancing behavior.
        (putLinkValueAllowZeroAndAdvance): Ditto.
        (isBracketOpcode): Added. For use in an assertion.
        (advanceToEndOfBracket): Renamed from moveOpcodePtrPastAnyAlternateBranches,
        and removed comments about how it's not well designed. This function takes
        a pointer to the beginning of a bracket and advances to the end of the

        * pcre/pcre_tables.cpp: Updated names.
        * pcre/pcre_ucp_searchfuncs.cpp:
        (kjs_pcre_ucp_othercase): Ditto.
        * pcre/pcre_xclass.cpp:
        (getUTF8CharAndAdvancePointer): Ditto.
        (kjs_pcre_xclass): Ditto.
        * pcre/ucpinternal.h: Ditto.

        * wtf/ASCIICType.h:
        (WTF::isASCIIAlpha): Added an int overload, like the one we already have for
        (WTF::isASCIIAlphanumeric): Ditto.
        (WTF::isASCIIHexDigit): Ditto.
        (WTF::isASCIILower): Ditto.
        (WTF::isASCIISpace): Ditto.
        (WTF::toASCIILower): Ditto.
        (WTF::toASCIIUpper): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-16 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 17 Dec 2007 04:08:39 +0000 (04:08 +0000)]
2007-12-16  Alp Toker  <alp@atoker.com>

        Reviewed by Maciej.

        [GTK] Integrate GStreamer video with the graphics backend

        Integrate the GStreamer media backend with the Cairo graphics backend.
        There are still some issues: Data is copied more often than necessary,
        and repaint() is not called, causing transformed video not to update

        * WebCore.pro:
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
        * platform/graphics/gtk/VideoSinkGStreamer.cpp: Added.
        * platform/graphics/gtk/VideoSinkGStreamer.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-16 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Mon, 17 Dec 2007 02:09:28 +0000 (02:09 +0000)]
2007-12-16  Mark Rowe  <mrowe@apple.com>

        Mac build fix.

        * WebCore.xcodeproj/project.pbxproj: Remove NetscapePlugInStreamLoader.cpp from the WebCore target.
        Mac currently has its own implementation in NetscapePlugInStreamLoaderMac.mm which conflicts with the
        new shared implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-16 Rodney Dawes <dobey@wayofthemonkey.com>
mrowe@apple.com [Mon, 17 Dec 2007 01:50:18 +0000 (01:50 +0000)]
2007-12-16  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Maciej Stachowiak.

        Bug 16389: Common Implementation of NetscapePlugInStreamLoader

        * WebCore.vcproj/WebCore.vcproj: Remove NetscapePlugInStreamLoaderWin.cpp.
        * loader/NetscapePlugInStreamLoader.cpp: Copy method implementations from NetscapePlugInStreamLoaderWin.cpp.
        * loader/win/NetscapePlugInStreamLoaderWin.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-16 Dimitri Glazkov <dimitri@glazkov.com>
mrowe@apple.com [Mon, 17 Dec 2007 01:35:37 +0000 (01:35 +0000)]
2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>

        Reviewed by Adam Roben.

        Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.

        * FindSafari/FindSafari.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-16 Brent Fulgham <bfulgham@gmail.com>
mrowe@apple.com [Mon, 17 Dec 2007 01:33:16 +0000 (01:33 +0000)]
2007-12-16  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Adam Roben.

        FindSafari needs a path-only option.

        * FindSafari/FindSafari.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * fast/js/regexp-overflow-expected.txt: Updated. I accidentally checked in an
darin@apple.com [Mon, 17 Dec 2007 01:31:06 +0000 (01:31 +0000)]
    * fast/js/regexp-overflow-expected.txt: Updated. I accidentally checked in an
        out-of-date file last time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin Adler.
darin@apple.com [Mon, 17 Dec 2007 01:28:32 +0000 (01:28 +0000)]
    Reviewed by Darin Adler.

        Fix http://bugs.webkit.org/show_bug.cgi?id=16433.
        Bug 16433: LOW_BANDWIDTH_DISPLAY build is broken

        * dom/Document.cpp:
        * loader/FrameLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
darin@apple.com [Mon, 17 Dec 2007 01:26:54 +0000 (01:26 +0000)]

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=16459
          REGRESSION: assertion failure with regexp with \B in a case-ignoring character range

        The problem was that \B was not handled properly in character classes.

        Test: fast/js/regexp-overflow.html

        * pcre/pcre_compile.cpp:
        (check_escape): Added handling of ESC_b and ESC_B in character classes here.
        Allows us to get rid of the handling of \b in character classes from all the
        call sites that handle it separately and to handle \B properly as well.
        (compileBranch): Remove the ESC_b handling, since it's not needed any more.
        (calculateCompiledPatternLengthAndFlags): Ditto.


        Reviewed by Maciej.

        - test for http://bugs.webkit.org/show_bug.cgi?id=16459
          REGRESSION: assertion failure with regexp with \B in a case-ignoring character range

        * fast/js/regexp-overflow-expected.txt: Updated.
        * fast/js/resources/regexp-overflow.js: Added test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-16 Grace Kloba <klobag@gmail.com>
mrowe@apple.com [Mon, 17 Dec 2007 01:26:46 +0000 (01:26 +0000)]
2007-12-16  Grace Kloba  <klobag@gmail.com>

        Reviewed by Darin Adler.

        Fix http://bugs.webkit.org/show_bug.cgi?id=16433.
        Bug 16433: LOW_BANDWIDTH_DISPLAY build is broken

        * dom/Document.cpp:
        * loader/FrameLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-16 Brent Fulgham <bfulgham@gmail.com>
mrowe@apple.com [Mon, 17 Dec 2007 01:20:57 +0000 (01:20 +0000)]
2007-12-16  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Maciej Stachowiak.


        * building/debug.html:  Update to expand the win32 debugging instructions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix http://bugs.webkit.org/show_bug.cgi?id=16448 ([GTK] Celtic Kane JavaScript perfor...
mrowe@apple.com [Mon, 17 Dec 2007 01:14:36 +0000 (01:14 +0000)]
Fix bugs.webkit.org/show_bug.cgi?id=16448 ([GTK] Celtic Kane JavaScript performance on Array test is slow relative to Mac).

Reviewed by Maciej Stachowiak.

* kjs/array_instance.cpp:
(KJS::ArrayInstance::sort): Convert JSValue's to strings once up front and then sort the
results.  This avoids calling toString twice per comparison, but requires a temporary buffer
so we only use this approach in cases where the array being sorted is not too large.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
darin@apple.com [Mon, 17 Dec 2007 00:24:48 +0000 (00:24 +0000)]

        Reviewed by Darin.

        More of http://bugs.webkit.org/show_bug.cgi?id=16385
        Cleanup kjs_window

        - Move PausedTimeouts into its own file and put it in the WebCore namespace.

        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/PausedTimeouts.cpp: Copied from bindings/js/kjs_window.cpp.
        * bindings/js/PausedTimeouts.h: Copied from bindings/js/kjs_window.h.
        * bindings/js/kjs_window.cpp:
        * bindings/js/kjs_window.h:
        * history/CachedPage.cpp:
        * history/CachedPage.h:
        * page/Chrome.cpp:


        Reviewed by Maciej.

        - tests for the argument handling of the executeSql function

        * storage/execute-sql-args-expected.txt: Added.
        * storage/execute-sql-args.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - try to get the system color test passing on the buildbot
darin@apple.com [Mon, 17 Dec 2007 00:17:29 +0000 (00:17 +0000)]
    - try to get the system color test passing on the buildbot

        I fear this test may be vulnerable to slight platform differences.

        * platform/mac-tiger/fast: Added.
        * platform/mac-tiger/fast/css: Added.
        * platform/mac-tiger/fast/css/css2-system-color-expected.checksum: Copied from platform/mac/fast/css/css2-system-color-expected.checksum.
        * platform/mac-tiger/fast/css/css2-system-color-expected.png: Copied from platform/mac/fast/css/css2-system-color-expected.png.
        * platform/mac-tiger/fast/css/css2-system-color-expected.txt: Copied from platform/mac/fast/css/css2-system-color-expected.txt.
        Then updated to match what the buildbot says.

        * platform/mac/fast/css/css2-system-color-expected.txt: Updated to match
        results I'm getting locally on my Leopard machine.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
weinig@apple.com [Sun, 16 Dec 2007 23:59:02 +0000 (23:59 +0000)]
    Reviewed by Darin.

        More of http://bugs.webkit.org/show_bug.cgi?id=16385
        Cleanup kjs_window

        - Move PausedTimeouts into its own file and put it in the WebCore namespace.

        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/PausedTimeouts.cpp: Copied from bindings/js/kjs_window.cpp.
        * bindings/js/PausedTimeouts.h: Copied from bindings/js/kjs_window.h.
        * bindings/js/kjs_window.cpp:
        * bindings/js/kjs_window.h:
        * history/CachedPage.cpp:
        * history/CachedPage.h:
        * page/Chrome.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
bdakin@apple.com [Sun, 16 Dec 2007 23:08:27 +0000 (23:08 +0000)]

        Reviewed by Geoff.

        Make relative-size SVGs work in border-image.

        * rendering/RenderBox.cpp:
        * rendering/RenderObject.cpp:


        Reviewed by Geoff.

        Tests for SVG as border-image.

        * fast/borders/resources/green-fixed-size-rect.svg: Added.
        * fast/borders/resources/green-relative-size-rect.svg: Added.
        * fast/borders/svg-as-border-image-2.html: Added.
        * fast/borders/svg-as-border-image.html: Added.
        * platform/mac/fast/borders/svg-as-border-image-2-expected.checksum: Added.
        * platform/mac/fast/borders/svg-as-border-image-2-expected.png: Added.
        * platform/mac/fast/borders/svg-as-border-image-2-expected.txt: Added.
        * platform/mac/fast/borders/svg-as-border-image-expected.checksum: Added.
        * platform/mac/fast/borders/svg-as-border-image-expected.png: Added.
        * platform/mac/fast/borders/svg-as-border-image-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin Adler and Maciej Stachowiak.
ggaren@apple.com [Sun, 16 Dec 2007 22:53:51 +0000 (22:53 +0000)]
    Reviewed by Darin Adler and Maciej Stachowiak.

        More refactoring to support global variable optimization.

        Changed SymbolTable to use RefPtr<UString::Rep> as its key instead of
        UString::Rep*. With globals, the symbol table can outlast the
        declaration node for any given symbol, so the symbol table needs to ref
        its symbol names.

        In support, specialized HashMaps with RefPtr keys to allow lookup
        via raw pointer, avoiding refcount churn.

        SunSpider reports a .6% speedup (prolly just noise).

        * JavaScriptCore.vcproj/WTF/WTF.vcproj: Added new file: wtf/RefPtrHashMap.h
        * JavaScriptCore.xcodeproj/project.pbxproj: ditto

        * kjs/JSVariableObject.cpp:
        (KJS::JSVariableObject::getPropertyNames): Symbol table keys are RefPtrs now.

        * kjs/SymbolTable.h: Modified key traits to match RefPtr. Added a
        static Rep* for null, which helps compute the deletedValue() trait.

        * wtf/HashMap.h: #include the RefPtr specialization so everyone can use it.

        * wtf/RefPtrHashMap.h: Copied from wtf/HashMap.h. Added overloaded versions
        of find(), contains(), get(), set(), add(), remove(), and take() that take
        raw pointers as keys.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fix Tiger build (my fault it was broken)
darin@apple.com [Sun, 16 Dec 2007 20:14:25 +0000 (20:14 +0000)]
    - fix Tiger build (my fault it was broken)

        * rendering/RenderThemeMac.mm: Define NSUInteger if on Tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
darin@apple.com [Sun, 16 Dec 2007 19:26:02 +0000 (19:26 +0000)]

        Reviewed by Darin.

        Incomplete implementation of CSS 2.1 system colors

        Test: fast/css/css2-system-color.html

        Based on original patch by Rob Buis.

        System colors are retrieved from NSColor as appropriate. If the color is a pattern color
        (and therefore NSColor won't let us retrieve a color from it) we draw a 1x1 image of the
        color and sample that to get a solid color.

        * css/CSSStyleSelector.cpp:
        * rendering/RenderTheme.cpp:
        * rendering/RenderTheme.h:
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:


        Reviewed by Darin.

        Incomplete implementation of CSS 2.1 system colors

        Add layout test for this bug and update tests for new system-derived colors

        * fast/css/css2-system-color.html: Added.
        * platform/mac/fast/css/css2-system-color-expected.checksum: Added.
        * platform/mac/fast/css/css2-system-color-expected.png: Added.
        * platform/mac/fast/css/css2-system-color-expected.txt: Added.
        * platform/mac/fast/css/css2-system-fonts-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug103533-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mitz@apple.com [Sun, 16 Dec 2007 18:40:02 +0000 (18:40 +0000)]

        Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?id=16426
          Divs with overflow:auto: scrollbars not correctly updated when contents change

        Test: fast/overflow/scrollbar-position-update.html

        * platform/mac/PlatformScrollBarMac.mm:
        (WebCore::PlatformScrollbar::updateThumbProportion): Update the
        NSScroller's value for the new proportions.
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateScrollInfoAfterLayout): Removed unnecessary
        repaint(). Scrollbars repaint themselves as needed.


        Reviewed by Darin Adler.

        - test for http://bugs.webkit.org/show_bug.cgi?id=16426
          Divs with overflow:auto: scrollbars not correctly updated when contents change

        * fast/overflow/scrollbar-position-update.html: Added.
        * platform/mac-leopard/fast/overflow: Added.
        * platform/mac-leopard/fast/overflow/scrollbar-position-update-expected.checksum: Added.
        * platform/mac-leopard/fast/overflow/scrollbar-position-update-expected.png: Added.
        * platform/mac/fast/overflow/scrollbar-position-update-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - try to fix the build
darin@apple.com [Sun, 16 Dec 2007 18:13:32 +0000 (18:13 +0000)]
    - try to fix the build

        * WebView.cpp:
        (wxWebView::OnKeyEvents): Add a WebCore prefix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap@webkit.org [Sun, 16 Dec 2007 17:37:42 +0000 (17:37 +0000)]
    Reviewed by Darin.

        <rdar://problem/5270958> REGRESSION: Complex system KeyBindings don't work properly

        * dom/KeyboardEvent.h:
        Change stored command class to preserve complete information about commands.

        * editing/EditorCommand.cpp: (WebCore::CommandEntry::): Mark InsertText as a text insertion
        command, which it is. Previously, we couldn't do it because WebKit didn't really treat insertText:
        as a command.

        * page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Copy commands saved while interpreting
        a keydown event into keypress, to avoid losing state when running interpretKeyEvents: again.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): Made command replaying work
        when handling keypress, too.
        (-[WebHTMLView doCommandBySelector:]): Adapted for the new way to store commands in events.
        (-[WebHTMLView insertText:]): Append a command, not replace the whole existing vector. Also,
        restore the state for additional commands to be saved correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap@webkit.org [Sun, 16 Dec 2007 17:31:35 +0000 (17:31 +0000)]
    Reviewed by Darin.

        Problems with float parsing on Linux (locale-dependent parsing was used).

        * kjs/dtoa.cpp: Removed USE_LOCALE to reduce future confusion.
        * kjs/lexer.cpp: (KJS::Lexer::lex): Parse with kjs_strtod, not the system one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap@webkit.org [Sun, 16 Dec 2007 16:16:17 +0000 (16:16 +0000)]
    Reviewed by Darin.

        REGRESSION: access keys broken on Windows

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-16 Xan Lopez <xan@gnome.org>
alp@webkit.org [Sun, 16 Dec 2007 13:20:11 +0000 (13:20 +0000)]
2007-12-16  Xan Lopez  <xan@gnome.org>

        Reviewed by Alexey Proskuryakov.

        [GTK] Text input doesn't work consistently on PPC

        * platform/gtk/KeyEventGtk.cpp:

        UChar is 2 bytes (UTF-16), so transform accordingly from
        gunichar (UCS-4). Fixes keyboard input on big endian systems.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mark Rowe.
weinig@apple.com [Sun, 16 Dec 2007 06:57:04 +0000 (06:57 +0000)]
    Reviewed by Mark Rowe.

        Fix urlSuitableForTestResult to correctly identify wstring::npos as
        the case when wstring.find doesn't find anything.

        * DumpRenderTree/win/DumpRenderTree.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mark Rowe.
darin@apple.com [Sun, 16 Dec 2007 02:00:09 +0000 (02:00 +0000)]
    Reviewed by Mark Rowe.

        - better build fix for the problem affecting GTK and some other platforms
          "this time for sure"

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSEventTargetBase.cpp: Move the include of the .lut.h file here.
        * bindings/js/JSEventTargetBase.h: Instead of including the .lut.h file in the header,
        which won't work, declare the tables that are in the .lut.h file in the header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFixed the Wx port's FontPlatformData for use in HashTable.
kevino@webkit.org [Sun, 16 Dec 2007 01:54:59 +0000 (01:54 +0000)]
Fixed the Wx port's FontPlatformData for use in HashTable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin Adler.
mitz@apple.com [Sun, 16 Dec 2007 01:33:57 +0000 (01:33 +0000)]
    Reviewed by Darin Adler.

        - fix <rdar://problem/5636090> Text in Georgia, Armenian, Inuktitut, Cree, or Cherokee (KA, HY, IU, CR, CHR) draws as all missing glyphs

        * platform/graphics/win/FontCacheWin.cpp:
        (WebCore::metaFileEnumProc): Added. Called during metafile record
        enumeration and extracts the font from the create font record.
        (WebCore::FontCache::getFontDataForCharacters): If font linking fails,
        let Uniscribe draw the characters and see what font it chooses.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * WebCore.pro: Roll my last change out. Was wrong and didn't fix the build.
darin@apple.com [Sun, 16 Dec 2007 01:31:37 +0000 (01:31 +0000)]
    * WebCore.pro: Roll my last change out. Was wrong and didn't fix the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Disabled the smallFonts.svg test, which has been failing for weeks. I heard...
darin@apple.com [Sun, 16 Dec 2007 01:30:17 +0000 (01:30 +0000)]
    Disabled the smallFonts.svg test, which has been failing for weeks. I heard that Niko
        is going to fix this soon. He should rename it back at that time.

        Removed the svn:executable flag from many .svg, .png, and .css files that had it set
        for no good reason.

        * svg/batik/text/smallFonts.svg: Removed.
        * svg/batik/text/smallFonts.svg-disabled: Copied from svg/batik/text/smallFonts.svg.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Another try at a GTK build fix.
darin@apple.com [Sun, 16 Dec 2007 01:11:22 +0000 (01:11 +0000)]
    Another try at a GTK build fix.

        * WebCore.pro: Add JSEventTargetBase.cpp to LUT_TABLE_FILES instead of LUT_FILES.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Force windows to regenerate COM DOM bindings.
weinig@apple.com [Sun, 16 Dec 2007 00:07:31 +0000 (00:07 +0000)]
    Force windows to regenerate COM DOM bindings.

        * WebCore.vcproj/build-generated-files.sh: Add license.
        * bindings/scripts/CodeGeneratorCOM.pm: Use shared WK_ucfirst.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix Windows and wx builds.
weinig@apple.com [Sat, 15 Dec 2007 23:32:57 +0000 (23:32 +0000)]
    Fix Windows and wx builds.

        * WebCore.vcproj/WebCore.vcproj:
        * WebCoreSources.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoGtk build fix. Add JSEventTargetBase.cpp to SOURCES.
mrowe@apple.com [Sat, 15 Dec 2007 23:31:23 +0000 (23:31 +0000)]
Gtk build fix.  Add JSEventTargetBase.cpp to SOURCES.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix wx build.
weinig@apple.com [Sat, 15 Dec 2007 23:24:22 +0000 (23:24 +0000)]
    Fix wx build.

        * WebCoreSources.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoNot reviewed. Build fix for Qt/Gtk.
zimmermann@webkit.org [Sat, 15 Dec 2007 23:23:35 +0000 (23:23 +0000)]
Not reviewed. Build fix for Qt/Gtk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by Eric.
zimmermann@webkit.org [Sat, 15 Dec 2007 22:48:55 +0000 (22:48 +0000)]
Reviewed by Eric.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=16445 (Refactor EventTargetNode & JSEventTargetNode for an upcoming SVG patch)
Split up JSEventTargetNode in JSEventTargetNode & JSEventTargetBase - where most functionality has been moved down
in the base class. Applied the same refactorization to EventTargetNode.

This makes it possible for the upcoming patch implementing the EventTarget interface for SVGElementInstance
to share as much code as possible with the EventTargetNode classes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-15 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 15 Dec 2007 20:03:38 +0000 (20:03 +0000)]
2007-12-15  Eric Seidel  <eric@webkit.org>

        Reviewed by Oliver.

        Width of SVG elements not applied to container elements
        Added calcPrefWidths for RenderSVGRoot (copied from RenderReplaced)
        This is caused by poor factoring in the render tree.  RenderContainer probably should be a template.


        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::calcPrefWidths): Added.
        * rendering/RenderSVGRoot.h:
        * css/SVGCSSStyleSelector::applySVGProperty: fixed ASSERT in debug builds

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix comment after isSafeScript() was renamed to allowsAccessFrom().
ddkilzer@apple.com [Sat, 15 Dec 2007 14:46:15 +0000 (14:46 +0000)]
    Fix comment after isSafeScript() was renamed to allowsAccessFrom().

        * bindings/js/kjs_window.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-15 Alp Toker <alp@atoker.com>
alp@webkit.org [Sat, 15 Dec 2007 14:13:15 +0000 (14:13 +0000)]
2007-12-15  Alp Toker  <alp@atoker.com>

        GTK+ DRT build fix for GLib < 2.14.

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-15 Alp Toker <alp@atoker.com>
alp@webkit.org [Sat, 15 Dec 2007 13:40:20 +0000 (13:40 +0000)]
2007-12-15  Alp Toker  <alp@atoker.com>

        cairo_arc() functions hang or crash when passed inf as radius or start/end angle

        Fixed in r28751. Remove these tests from the skip list:

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-15 Alp Toker <alp@atoker.com>
alp@webkit.org [Sat, 15 Dec 2007 13:12:34 +0000 (13:12 +0000)]
2007-12-15  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        cairo_arc() functions hang or crash when passed inf as radius or start/end angle

        Add checks. This matches a similar workaround for a CG bug in the CG
        graphics backend: <rdar://problem/5189233>


        * platform/graphics/cairo/PathCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.
mrowe@apple.com [Sat, 15 Dec 2007 12:39:48 +0000 (12:39 +0000)]
Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.
This prevents many layout tests from hanging while waiting on user responses to dialogs.

Reviewed by Alp Toker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd a skeleton Gtk skipped list containing only tests that hang run-webkit-tests.
mrowe@apple.com [Sat, 15 Dec 2007 12:39:14 +0000 (12:39 +0000)]
Add a skeleton Gtk skipped list containing only tests that hang run-webkit-tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFlesh out DumpRenderTree for Gtk. After these changes, the majority of the tests...
mrowe@apple.com [Sat, 15 Dec 2007 11:00:11 +0000 (11:00 +0000)]
Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.

Reviewed by Alp Toker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoCorrect a mistake in ChangeLog.
ap@webkit.org [Sat, 15 Dec 2007 09:30:33 +0000 (09:30 +0000)]
Correct a mistake in ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
ap@webkit.org [Sat, 15 Dec 2007 09:07:58 +0000 (09:07 +0000)]
    Reviewed by Maciej.

        Alt+Space works incorrectly

        Test: platform/win/fast/events/alt-space-scroll.html

        * WebView.cpp:
        We do not handle WM_SYSCHAR events.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap@webkit.org [Sat, 15 Dec 2007 09:03:52 +0000 (09:03 +0000)]
    Reviewed by Darin.

        Google Maps zooming via the scroll wheel (almost) always zooms IN only.

        * dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent):
        Ensure that delta is never rounded down to zero - we are getting values less than 1 from
        many mice on OS X, and Google Maps code assumes scrolling down if event.wheelDelta is zero.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-14 Alp Toker <alp@atoker.com>
alp@webkit.org [Sat, 15 Dec 2007 06:24:09 +0000 (06:24 +0000)]
2007-12-14  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Enable the AllInOneFile.cpp optimization for the GTK+ port.

        * JavaScriptCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRemove commented out fprintf's that were for debugging purposes only.
mrowe@apple.com [Sat, 15 Dec 2007 04:35:07 +0000 (04:35 +0000)]
Remove commented out fprintf's that were for debugging purposes only.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoDon't use the MADV_DONTNEED code path for now as it has no effect on Mac OS X and...
mrowe@apple.com [Sat, 15 Dec 2007 04:31:39 +0000 (04:31 +0000)]
Don't use the MADV_DONTNEED code path for now as it has no effect on Mac OS X and is currently untested on other platforms.

Reviewed by Maciej Stachowiak.

* wtf/TCSystemAlloc.cpp:
(TCMalloc_SystemRelease): Return after releasing memory rather than potentially falling
through into another mechanism if multiple are supported.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-14 Alp Toker <alp@atoker.com>
alp@webkit.org [Sat, 15 Dec 2007 04:21:40 +0000 (04:21 +0000)]
2007-12-14  Alp Toker  <alp@atoker.com>

        Build fix for GTK+/Qt and ports that don't use AllInOneFile.cpp.

        Include UnusedParam.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix build on windows
oliver@apple.com [Sat, 15 Dec 2007 03:53:52 +0000 (03:53 +0000)]
Fix build on windows

Reviewd by Stephanie

* wtf/FastMalloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - Windows build fix
mitz@apple.com [Sat, 15 Dec 2007 03:26:35 +0000 (03:26 +0000)]
    - Windows build fix

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - yet another build fix
mitz@apple.com [Sat, 15 Dec 2007 03:02:14 +0000 (03:02 +0000)]
    - yet another build fix

        * DOMHTMLClasses.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-14 Alp Toker <alp@atoker.com>
alp@webkit.org [Sat, 15 Dec 2007 03:00:45 +0000 (03:00 +0000)]
2007-12-14  Alp Toker  <alp@atoker.com>

        Fix inconsistent indentation in the license header. Maciej was right!

        * WebCoreSupport/FrameLoaderClientGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-14 Alp Toker <alp@atoker.com>
alp@webkit.org [Sat, 15 Dec 2007 02:51:01 +0000 (02:51 +0000)]
2007-12-14  Alp Toker  <alp@atoker.com>

        GTK+/Qt build fix. Track added files in r28722.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago <rdar://problem/5647272> Remove user agent string hack for flickr.com
ddkilzer@apple.com [Sat, 15 Dec 2007 02:16:20 +0000 (02:16 +0000)]
    <rdar://problem/5647272> Remove user agent string hack for flickr.com

        Reviewed by Darin.

        * WebView/WebView.mm:
        (-[WebView _userAgentForURL:]): Removed hack.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago <rdar://problem/5647261> Remove user agent string hack for yahoo.com
ddkilzer@apple.com [Sat, 15 Dec 2007 02:15:06 +0000 (02:15 +0000)]
    <rdar://problem/5647261> Remove user agent string hack for yahoo.com

        Reviewed by Darin.

        * WebView/WebView.mm:
        (-[WebView _userAgentForURL:]): Removed hack.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - try again to fix the Windows build
mitz@apple.com [Sat, 15 Dec 2007 02:09:16 +0000 (02:09 +0000)]
    - try again to fix the Windows build

        * wtf/TCSystemAlloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - try to fix the Windows build
mitz@apple.com [Sat, 15 Dec 2007 02:00:08 +0000 (02:00 +0000)]
    - try to fix the Windows build

        * wtf/TCSystemAlloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - build fix
mitz@apple.com [Sat, 15 Dec 2007 01:35:30 +0000 (01:35 +0000)]
    - build fix

        * WebIconDatabase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix ChangeLog
weinig@apple.com [Sat, 15 Dec 2007 01:19:19 +0000 (01:19 +0000)]
Fix ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
weinig@apple.com [Sat, 15 Dec 2007 01:17:50 +0000 (01:17 +0000)]
    Reviewed by Geoff.

        Speed up getElementByClassName.
        - This makes getElementByClassName take 33% faster on the stress test
          linked to at http://bugs.webkit.org/show_bug.cgi?id=15760.

        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::foldCase): Optimize the case when all the characters are ASCII.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-14 Alp Toker <alp@atoker.com>
alp@webkit.org [Sat, 15 Dec 2007 01:03:59 +0000 (01:03 +0000)]
2007-12-14  Alp Toker  <alp@atoker.com>

        Reviewed by Maciej.

        [GTK] Update license headers

        Consent has been given by the authors of these files to change license
        to the LGPL as outlined in the bug report.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd logic for TCMalloc to release memory to the system
oliver@apple.com [Sat, 15 Dec 2007 00:25:45 +0000 (00:25 +0000)]
Add logic for TCMalloc to release memory to the system

Reviewed by Maciej and Oliver.

Add final changes to make TCMalloc release memory to the system.
This results in a 0.4% regression against ToT, but this is offset
against the gains made by the original TCMalloc r38 merge - in fact
we retain around 0.3-0.4% progression overall.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele.
darin@apple.com [Fri, 14 Dec 2007 23:42:32 +0000 (23:42 +0000)]
    Reviewed by Adele.

        - fix http://bugs.webkit.org/show_bug.cgi?id=16442
          navigation policy delegate gets called twice for each load

        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::willSendRequest): Removed call to checkNavigationPolicy.
        That's handled by FrameLoader.

        * loader/MainResourceLoader.h: Removed callContinueAfterNavigationPolicy
        and continueAfterNavigationPolicy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele.
darin@apple.com [Fri, 14 Dec 2007 23:41:16 +0000 (23:41 +0000)]
    Reviewed by Adele.

        - http://bugs.webkit.org/show_bug.cgi?id=16443
          implement some missing Windows WebKit functions

        * DOMHTMLClasses.cpp:
        (DOMHTMLDocument::URL): Implemented.

        * WebActionPropertyBag.cpp:
        (WebActionPropertyBag::Read): Fixed the WebActionElementKey case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - share the results of this test between Tiger and Leopard
mitz@apple.com [Fri, 14 Dec 2007 23:06:44 +0000 (23:06 +0000)]
    - share the results of this test between Tiger and Leopard

        * platform/mac-leopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Removed.
        * platform/mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
andersca@apple.com [Fri, 14 Dec 2007 22:06:50 +0000 (22:06 +0000)]

        Reviewed by Brady.

        Make document.open count as committing a document load, so that -[WebFrame dataSource:] won't
        return nil in that case.

        * loader/FrameLoader.cpp:


        Reviewed by Brady.

        Assert that a web frame that's loading a resource always has either a data source or
        a provisional data source.

        * DumpRenderTree/mac/ResourceLoadDelegate.mm:
        (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):


        Reviewed by Brady.

        Add test that calls window.open and then immediately writes into the document
        of the newly opened window.

        * http/tests/misc/resources/compass.jpg: Added.
        * http/tests/misc/window-open-then-write-expected.txt: Added.
        * http/tests/misc/window-open-then-write.html: Added.
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
weinig@apple.com [Fri, 14 Dec 2007 21:48:20 +0000 (21:48 +0000)]

        Reviewed by Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14955
          Implement getElementsByClassName.

        This patch also renames AtomicStringList to ClassNames to better reflect its actual use,
        and takes advantage of admitting that it's class-specific to encapsulate class attribute
        parsing so it can be shared.  It also changes the class to use a Vector, rather than a linked
        list to store the class names.

        Tests: fast/dom/getElementsByClassName/001.html

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSStyleSelector.cpp:
        * dom/AtomicStringList.h: Removed.
        * dom/ClassNames.cpp: Added.
        * dom/ClassNames.h: Copied from WebCore/dom/AtomicStringList.h.
        * dom/ClassNodeList.cpp: Added.
        * dom/ClassNodeList.h: Added.
        * dom/Document.cpp:
        * dom/Document.h:
        * dom/Document.idl:
        * dom/Element.cpp:
        * dom/Element.h:
        * dom/Element.idl:
        * dom/NameNodeList.cpp:
        * dom/NameNodeList.h:
        * dom/NamedMappedAttrMap.cpp:
        * dom/NamedMappedAttrMap.h:
        * dom/StyledElement.cpp:
        * dom/StyledElement.h:


        Reviewed by Mitz.

        - test for http://bugs.webkit.org/show_bug.cgi?id=14955
          Implement getElementsByClassName

        Tests added from http://tc.labs.opera.com/apis/getElementsByClassName/

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/getElementsByClassName: Added.
        * fast/dom/getElementsByClassName/001-expected.txt: Added.
        * fast/dom/getElementsByClassName/001.html: Added.
        * fast/dom/getElementsByClassName/002-expected.txt: Added.
        * fast/dom/getElementsByClassName/002.html: Added.
        * fast/dom/getElementsByClassName/003-expected.txt: Added.
        * fast/dom/getElementsByClassName/003.html: Added.
        * fast/dom/getElementsByClassName/004-expected.txt: Added.
        * fast/dom/getElementsByClassName/004.html: Added.
        * fast/dom/getElementsByClassName/005-expected.txt: Added.
        * fast/dom/getElementsByClassName/005.html: Added.
        * fast/dom/getElementsByClassName/006-expected.txt: Added.
        * fast/dom/getElementsByClassName/006.html: Added.
        * fast/dom/getElementsByClassName/007-expected.txt: Added.
        * fast/dom/getElementsByClassName/007.html: Added.
        * fast/dom/getElementsByClassName/008-expected.txt: Added.
        * fast/dom/getElementsByClassName/008.html: Added.
        * fast/dom/getElementsByClassName/009-expected.txt: Added.
        * fast/dom/getElementsByClassName/009.html: Added.
        * fast/dom/getElementsByClassName/010-expected.txt: Added.
        * fast/dom/getElementsByClassName/010.xml: Added.
        * fast/dom/getElementsByClassName/011-expected.txt: Added.
        * fast/dom/getElementsByClassName/011.xml: Added.
        * fast/dom/getElementsByClassName/012-expected.txt: Added.
        * fast/dom/getElementsByClassName/012.html: Added.
        * fast/dom/getElementsByClassName/013-expected.txt: Added.
        * fast/dom/getElementsByClassName/013.html: Added.
        * fast/dom/getElementsByClassName/014-expected.txt: Added.
        * fast/dom/getElementsByClassName/014.html: Added.
        * fast/dom/getElementsByClassName/array: Added.
        * fast/dom/getElementsByClassName/array/001-expected.txt: Added.
        * fast/dom/getElementsByClassName/array/001.html: Added.
        * fast/dom/getElementsByClassName/array/002-expected.txt: Added.
        * fast/dom/getElementsByClassName/array/002.html: Added.
        * fast/dom/getElementsByClassName/array/003-expected.txt: Added.
        * fast/dom/getElementsByClassName/array/003.html: Added.
        * fast/dom/getElementsByClassName/array/004-expected.txt: Added.
        * fast/dom/getElementsByClassName/array/004.html: Added.
        * fast/dom/getElementsByClassName/dumpNodeList-expected.txt: Added.
        * fast/dom/getElementsByClassName/dumpNodeList.html: Added.
        * fast/dom/getElementsByClassName/resources: Added.
        * fast/dom/getElementsByClassName/resources/common.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
darin@apple.com [Fri, 14 Dec 2007 20:50:30 +0000 (20:50 +0000)]

        Reviewed by Sam.

        - removed unnecessary includes of "Vector.h"

        * wtf/HashMap.h:
        (WTF::copyKeysToVector): Make the type of the vector be a template parameter.
        This allows copying keys into a vector of a base class or one with an inline capacity.
        (WTF::copyValuesToVector): Ditto.
        * wtf/HashSet.h:
        (WTF::copyToVector): Ditto.


        Reviewed by Sam.

        - fix http://bugs.webkit.org/show_bug.cgi?id=16351
          FontFallbackList.h doesn't include wtf/PassRefPtr.h

        * platform/graphics/FontFallbackList.h: Added include of <wtf/Forward.h>
        * platform/graphics/GlyphPageTreeNode.h: Removed an unneeded include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fix mistake causing nearly all tests to fail on Windows
darin@apple.com [Fri, 14 Dec 2007 20:42:24 +0000 (20:42 +0000)]
    - fix mistake causing nearly all tests to fail on Windows

        * DumpRenderTree/win/UIDelegate.cpp:
        (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
        npos, not 0. Also pass URL in to URL function rather than passing the entire message.

        * DumpRenderTree/mac/UIDelegate.mm:
        (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
        than passing the entire message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fix Tiger build
darin@apple.com [Fri, 14 Dec 2007 20:34:49 +0000 (20:34 +0000)]
    - fix Tiger build

        * DumpRenderTree/mac/UIDelegate.mm:
        (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
        new-to-Leopard methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebKit/mac:
darin@apple.com [Fri, 14 Dec 2007 20:25:33 +0000 (20:25 +0000)]

        Reviewed by Brady.

        - fix http://bugs.webkit.org/show_bug.cgi?id=16296
          <rdar://problem/5635641> -[WebFrameLoadDelegate didReceiveIcon:forFrame:] never called

        * WebView/WebView.mm:
        (-[WebView setFrameLoadDelegate:]): Call [WebIconDatabase sharedIconDatabase] if the
        a didReceiveIcon method is present.


        * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
        since it now triggers unwanted icon loading. We only had it because we implemented "all"
        delegate methods here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
darin@apple.com [Fri, 14 Dec 2007 20:03:16 +0000 (20:03 +0000)]

        Reviewed by Alexey.

        - http://bugs.webkit.org/show_bug.cgi?id=16420
          change regression tests to use document.execCommand instead of textInputController.doCommand

        Add a few more operations to document.execCommand.

        Finished up the transition to the new Editor::Command, including removing
        the Editor::execCommand function.

        * WebCore.base.exp: Added Editor::Command::isSupported.
        * editing/Editor.h: Removed execCommand.
        * editing/EditorCommand.cpp:
        (WebCore::expandSelectionToGranularity): Added.
        (WebCore::verticalScrollDistance): Added; replaces canScroll.
        (WebCore::executeDeleteBackward): Added. Moved code here from WebHTMLView.
        (WebCore::executeDeleteBackwardByDecomposingPreviousCharacter): Ditto.
        (WebCore::executeDeleteForward): Ditto.
        (WebCore::executeDeleteToBeginningOfLine): Ditto.
        (WebCore::executeDeleteToBeginningOfParagraph): Ditto.
        (WebCore::executeDeleteToEndOfLine): Ditto.
        (WebCore::executeDeleteToEndOfParagraph): Ditto.
        (WebCore::executeMovePageDown): Renamed this command to be consistent with all the other
        Move commands. They all modify the caret. Reimplemented to match the Mac OS X version by
        removing the explicit scrolling, and letting it be done automatically by code that makes
        the caret visible. In some cases the old code would scroll twice which was harmless but
        (WebCore::executeMovePageDownAndModifySelection): Added. Moved code here from WebHTMLView.
        (WebCore::executeMovePageUp): See MovePageDown above.
        (WebCore::executeMovePageUpAndModifySelection): Added. Moved code here from WebHTMLView.
        (WebCore::executeSelectLine): Ditto.
        (WebCore::executeSelectParagraph): Ditto.
        (WebCore::executeSelectSentence): Ditto.
        (WebCore::executeSelectWord): Ditto.
        (WebCore::executeSwapWithMark): Some small tweaks.

        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected): Changed to use Editor::command()
        instead of Editor::execCommand(). This code could be changed to use Editor::Command quite a
        bit more, but I didn't do that this time.

        - Removed some obsolete unused code.

        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::passMouseDownEventToWidget): Removed the special case code for
        NSTextView. This was left over from when we used NSTextField and NSTextView for form
        elements and is no longer used at all.

        * page/mac/WebCoreFrameBridge.h: Removed 20 unused methods that were still on one side
        of the bridge or another. We really need to find a time to tear down the rest of the
        bridge, but that's not this patch.

        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge addData:]): Changed to get at the _shouldCreateRenderers field directly
        instead of using a method.
        (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
        Took out obsolete comment about matching enums (we use a single enum now and have for some
        (-[WebCoreFrameBridge selectionGranularity]): Ditto.


        * StringsNotToBeLocalized.txt: Updated.


        Reviewed by Alexey.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::handleKeyboardEvent): Changed to use Editor::command
        instead of Editor::execCommand.
        * WebView/webkitwebview.cpp: Ditto.


        Reviewed by Alexey.

        - Changed a few more editing operations to use WebCore instead of WebKit.
        - Removed some obsolete unused code.

        * WebCoreSupport/WebFrameBridge.h: Moved declarations of methods that are both
        defined and used on the WebKit side to here. These no longer belong on the bridge
        and should be moved to the WebFrame class (or elsewhere).
        * WebCoreSupport/WebFrameBridge.mm: Removed some unused methods.

        * WebView/WebFrameView.mm:
        (+[WebFrameView _viewTypesAllowImageTypeOmission:]): Fix typo in comment.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLViewPrivate dealloc]): Removed unused firstResponderTextViewAtMouseDownTime.
        (-[WebHTMLViewPrivate clear]): Ditto.
        (-[WebHTMLView _setMouseDownEvent:]): Ditto.
        (commandNameForSelector): Added special cases for pageDown:, pageDownAndModifySelection:,
        pageUp:, and pageUpAndModifySelection:, since those names probably aren't specific enough
        to be used in WebCore (what AppKit calls scrollPageDown: vs. pageDown: needs to be
        disambiguated with the word "Move"). Added deleteBackward:,
        deleteBackwardByDecomposingPreviousCharacter:, deleteForward:, deleteToBeginningOfLine:,
        deleteToBeginningOfParagraph:, deleteToEndOfLine:, deleteToEndOfParagraph:, pageDown:,
        pageDownAndModifySelection:, pageUp:, pageUpAndModifySelection:, selectLine:,
        selectParagraph:, selectSentence:, and selectWord: to the list of commands that are
        forwarded to WebCore.
        (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Eliminated the long list of
        operations that we forward to WebCore. Instead, look up any command that WebCore can
        handle, after any that we handle specially in WebHTMLView. Also fixed a bug where
        an item that's not a menu item with changeBaseWritingDirection:NSWritingDirectionNatural
        would end up enabled instead of disabled and streamlined the logic for toggleGrammarChecking:.
        (-[WebHTMLView mouseDown:]): Removed unused firstResponderTextViewAtMouseDownTime.
        (-[WebHTMLView becomeFirstResponder]): Removed unused willBecomeFirstResponderForNodeFocus.
        (-[WebHTMLView resignFirstResponder]): Ditto.
        (-[WebHTMLView checkSpelling:]): Took unneeded extra initialization of NSSpellChecker.

        * WebView/WebHTMLViewInternal.h: Removed unused willBecomeFirstResponderForNodeFocus,
        firstResponderTextViewAtMouseDownTime, _textViewWasFirstResponderAtMouseDownTime: and


        Reviewed by Alexey.

        * Api/qwebpage.cpp:
        (QWebPage::triggerAction): Removed some use of Editor member functions we plan
        to eventually eliminate. Switch from Editor::execCommand to Editor::command.
        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleKeyboardEvent): Ditto. Also updated name from
        MoveUpByPageAndModifyCaret to MovePageUp and from MoveDownByPageAndModifyCaret
        to MovePageDown.


        Reviewed by Alexey.

        * WebView.cpp:
        (WebView::execCommand): Switched from Editor::execCommand to Editor:command.
        Updated name from MoveUpByPageAndModifyCaret to MovePageUp and from
        MoveDownByPageAndModifyCaret to MovePageDown.
        (WebView::copy): Switched from Editor::execCommand to Editor:command.
        (WebView::cut): Ditto.
        (WebView::paste): Ditto.
        (WebView::delete_): Ditto.


        Reviewed by Alexey.

        * WebKitSupport/EditorClientWx.cpp:
        (WebCore::EditorClientWx::handleKeyboardEvent): Switched from Editor::execCommand
        to Edtor::command.


        Reviewed by Alexey.

        - http://bugs.webkit.org/show_bug.cgi?id=16420
          change regression tests to use document.execCommand instead of textInputController.doCommand

        To avoid changing results at this time, I didn't correct the many tests that now have
        misleading "this test cannot be run manually" text or references to "NSResponder" or
        uneeded instructions for running the test manually. We can do that on a later pass.

        * editing/deleting/5300379.html: Use execCommand instead of doCommand.
        * editing/deleting/delete-to-end-of-paragraph.html: Ditto.
        * editing/deleting/smart-delete-003.html: Ditto.
        * editing/deleting/smart-delete-004.html: Ditto.
        * editing/execCommand/nsresponder-indent.html: Ditto.
        * editing/execCommand/nsresponder-outdent.html: Ditto.
        * editing/selection/4947387.html: Ditto.
        * editing/selection/5195166-1.html: Ditto.
        * editing/selection/5195166-2.html: Ditto.
        * editing/selection/select-line.html: Ditto.
        * editing/selection/selection-actions.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
justin.garcia@apple.com [Fri, 14 Dec 2007 19:55:37 +0000 (19:55 +0000)]

        Reviewed by Darin Adler.

        <rdar://problem/5575101> GoogleDocs: Hang in SplitElementCommand::doApply when outdenting a list item in a particular list

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::splitTreeToNode): Moved here.
        * editing/CompositeEditCommand.h:
        * editing/IndentOutdentCommand.cpp: Moved splitTreeToNode.
        * editing/IndentOutdentCommand.h: Ditto, and removed unimplemented splitTreeTo.
        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::doApply): Split ancestors of listChildNode between
        it and listNode, if they exists, so that moving listChildNode doesn't put it out
        of order.  Added a test case to cover each change.
        * editing/SplitElementCommand.cpp:
        (WebCore::SplitElementCommand::doApply): Added an ASSERT to catch code that
        tries to split a container at a bogus child, and an early return to avoid a
        hang in that case.


        Reviewed by Darin Adler.

        <rdar://problem/5575101> Hang in SplitElementCommand::doApply when outdenting a list item in a particular list

        * editing/execCommand/5575101-1-expected.txt: Added.
        * editing/execCommand/5575101-1.html: Added.
        * editing/execCommand/5575101-2-expected.txt: Added.
        * editing/execCommand/5575101-2.html: Added.
        * editing/execCommand/5575101-3-expected.txt: Added.
        * editing/execCommand/5575101-3.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
andersca@apple.com [Fri, 14 Dec 2007 19:47:16 +0000 (19:47 +0000)]

        Reviewed by Darin and Geoff.

        REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)

        Get rid of unnecessary and incorrect security checks for plug-ins accessing JavaScript objects.

        The way this used to work was that each NPObject that wrapped a JSObject would have a root object
        corresponding to the frame object (used for managing the lifecycle) and an origin root object (used for
        doing security checks).

        This would prevent a plug-in from accessing a frame's window object if it's security origin was different
        (some parts of the window, such as the location object, can be accessed from frames with different security
        origins, and those checks are being done in WebCore).

        Also, if a plug-in were to access a window object of a frame that later went away, it could lead to that
        Window JSObject being garbage collected and the NPObject pointing to freed memory.

        How this works now is that there is no origin root object anymore, and all NPObject wrappers that are created
        for a plug-in will have the root object of the containing frame of that plug-in.

        * bindings/NP_jsobject.cpp:
        Don't free the origin root object.

        Remove the origin root object parameter.

        Get rid of all security checks.

        * bindings/NP_jsobject.h:
        Remove originRootObject from the JavaScriptObject struct.

        * bindings/c/c_utility.cpp:
        Always use the root object from the ExecState.


        Reviewed by Darin and Geoff.

        REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)

        _NPN_CreateScriptObject doesn't take an origin root object anymore.

        * html/HTMLPlugInElement.cpp:
        * page/Frame.cpp:


        Reviewed by Darin and Geoff.

        REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)

        Add property getting methods to the plug-in.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:


        Reviewed by Darin and Geoff.

        REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)

        Add cross frame plug/in test where a plug/in inside an iframe tries to access properties of the
        top-level frame.

        * http/tests/plugins/cross-frame-object-access-expected.txt: Added.
        * http/tests/plugins/cross-frame-object-access.html: Added.
        * http/tests/plugins/resources/cross-frame-object-access.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin Adler.
mitz@apple.com [Fri, 14 Dec 2007 19:37:12 +0000 (19:37 +0000)]
    Reviewed by Darin Adler.

        - fix <rdar://problem/5643663> text-shadow and box-shadow offsets 1px smaller than specified
          which is the root cause of:
          box-shadow: small values don't affect shadow position
          Safari implementation of text-shadow off by 1px

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::setShadow): Slightly increase the magnitude
        of the offsets passed to CGContextSetShadow* to ensure that the end
        result after truncation is the desired integer offsets.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMove layout test to mac skipped list until mac frt bug fixed.
oliver@apple.com [Fri, 14 Dec 2007 18:34:16 +0000 (18:34 +0000)]
Move layout test to mac skipped list until mac frt bug fixed.

Reviewed by Adam.

Fix test output, and move test to mac skipped list until
<rdar://problem/5647952> fast/events/mouseout-on-window.html
is fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28713 268f45cc-cd09-0410-ab3c-d52691b4dbfc