14 years ago Reviewed by Sam.
eric@webkit.org [Thu, 7 Feb 2008 22:10:10 +0000 (22:10 +0000)]
    Reviewed by Sam.

        * sunspider: add an error message when ./tests/LIST is not found

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber stamped by Mark Rowe
dsmith@webkit.org [Thu, 7 Feb 2008 21:32:02 +0000 (21:32 +0000)]
    Rubber stamped by Mark Rowe
        Fix a duplicate selector in the test.

        * perf/slickspeed/selectors.list:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam Roben.
dsmith@webkit.org [Thu, 7 Feb 2008 21:19:42 +0000 (21:19 +0000)]
    Reviewed by Adam Roben.
        Added :nth-child and :last-child to the list of selectors to test.

        * perf/slickspeed/selectors.list:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@30070 268f45cc-cd09-0410...
hyatt@apple.com [Thu, 7 Feb 2008 20:14:58 +0000 (20:14 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for bug 6248, implement the nth-* CSS3 selectors. Patch based on origina...
hyatt@apple.com [Thu, 7 Feb 2008 20:13:24 +0000 (20:13 +0000)]
    Fix for bug 6248, implement the nth-* CSS3 selectors.  Patch based on original KHTML work from Allan Jensen
        and improved upon by Nick Shanks.

        Reviewed by Eric

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        * css/CSSSelector.cpp:
        * css/CSSSelector.h:
        * css/CSSStyleSelector.cpp:
        * css/tokenizer.flex:
        * rendering/RenderStyle.cpp:
        * rendering/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix error in bisect-builds when responding "broken" for the first build
aroben@apple.com [Thu, 7 Feb 2008 19:08:21 +0000 (19:08 +0000)]
     Fix error in bisect-builds when responding "broken" for the first build

         Reviewed by Dave Kilzer.

         * Scripts/bisect-builds: Only try to test the build if the nightly
         info for the current index has not been deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Thu, 7 Feb 2008 17:01:34 +0000 (17:01 +0000)]

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5729411> REGRESSION (r29834): Float contained in relative-positioned block is painted twice

        Test: fast/block/float/relative-painted-twice.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::addOverhangingFloats): Added another case where
        the child should not take over painting the float: when they do not have
        the same enclosing layer. In that case, the float is already being
        painted by one of its closer ancestors.


        Reviewed by Dave Hyatt.

        - test for <rdar://problem/5729411> REGRESSION (r29834): Float contained in relative-positioned block is painted twice

        * fast/block/float/relative-painted-twice.html: Added.
        * platform/mac-leopard/fast/block/float/relative-painted-twice-expected.checksum: Added.
        * platform/mac-leopard/fast/block/float/relative-painted-twice-expected.png: Added.
        * platform/mac/fast/block/float/relative-painted-twice-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Thu, 7 Feb 2008 16:59:08 +0000 (16:59 +0000)]

        Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17194
          Changing text to bold changes font family

        Test: platform/mac/fast/text/family-for-font-matched-by-name.html

        * platform/mac/WebFontCache.mm:
        (+[WebFontCache internalFontWithFamily:traits:size:]): Changed to use
        the family of the font whose name matches the desired family if there
        is no exact family match.


        Reviewed by Darin Adler.

        - test for http://bugs.webkit.org/show_bug.cgi?id=17194
          Changing text to bold changes font family

        * platform/mac/fast/text/family-for-font-matched-by-name-expected.checksum: Added.
        * platform/mac/fast/text/family-for-font-matched-by-name-expected.png: Added.
        * platform/mac/fast/text/family-for-font-matched-by-name-expected.txt: Added.
        * platform/mac/fast/text/family-for-font-matched-by-name.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
bdakin@apple.com [Thu, 7 Feb 2008 15:06:52 +0000 (15:06 +0000)]

        Reviewed by Geoff.

        Fix for <rdar://problem/5697882> Traffic or Street View button on
        Google Maps is sometimes not positioned correctly (17000)

        On the Mac, timers fire in the order that they are registered.
        Geoff and I discovered that this is not necessarily true on
        Windows, and that turned out to be the cause of this intermittent
        layout problem at Google Maps. This patch adds a new member
        variable to Timer to remember the timer's insertion point into the
        heap. Now when comparing timers, if two timers were registered at
        the same time, their insertion orders are compared to determine
        which should fire first. This code actually never runs on Debug
        builds on the Mac; the system clock on the Mac is accurate enough
        that it knows that the two timers were not registered at *exactly*
        the same time. This is not the case on Windows. In theory, if we
        sped up Javascript enough on the Mac, this code would run and would
        prevent misrenderings such as the one found on Google Maps.

        * platform/Timer.cpp:
        * platform/Timer.h:


        Test written by Geoff, reviewed by me.

        Test for <rdar://problem/5697882> Traffic or Street View button on
        Google Maps is sometimes not positioned correctly (17000)

        * fast/dom/simultaneouslyRegsiteredTimerFireOrder-expected.txt: Added.
        * fast/dom/simultaneouslyRegsiteredTimerFireOrder.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Alexey Proskuryakov.
ggaren@apple.com [Thu, 7 Feb 2008 13:59:23 +0000 (13:59 +0000)]
    Reviewed by Alexey Proskuryakov.

        Fixed two minor typos in the --root option, to get it working.

        * Scripts/run-sunspider:
            1. Actually assign the function argument to our local variable.
            2. Actually set the $root variable, so we don't try to build later.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRubber stamped by Eric.
zimmermann@webkit.org [Thu, 7 Feb 2008 10:08:52 +0000 (10:08 +0000)]
Rubber stamped by Eric.

Move existing SVG baseline from platform/mac/ to platform/mac-tiger/ (I generated all of them using Tiger).
Regenerated new SVG baseline in platform/mac-leopard. platform/mac/svg is doesn't contain any test results anymore.

In a later step it should be investigated, which layout test results can be shared between Leopard & Tiger.
Those results should be moved to platform/mac/svg then.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
justin.garcia@apple.com [Thu, 7 Feb 2008 07:17:23 +0000 (07:17 +0000)]

        Reviewed by Darin Adler.

        <rdar://problem/5195056> Huge plain text pastes are slow

        This was fixed in r27369 and then r29367 and r29667 caused performance to

        * editing/EditCommand.cpp:
        (WebCore::EditCommand::apply): Only updateLayout() for high level commands.
        (WebCore::EditCommand::unapply): Ditto.
        (WebCore::EditCommand::reapply): Ditto.
        * editing/Editor.cpp:
        (WebCore::Editor::appliedEditing): Added a note about shouldChangeSelection calls
        that shouldn't be made, a bug I filed as <rdar://problem/5729315>.
        (WebCore::Editor::unappliedEditing): Ditto.
        (WebCore::Editor::reappliedEditing): Ditto.
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::nodeWillBeRemoved): Don't try to test the selection
        base and extent with the expensive isCandidate operation if the node that will
        be removed is in a fragment, since such a removal is guaranteed to have no effect
        on a selection.  This is to speed up the paste operation, which does many removes from
        a fragment.


        Reviewed by Darin Adler.

        <rdar://problem/5195056> Huge plain text pastes are slow

        The changes made for this fix exposed several more cases of:
        <rdar://problem/5729315> Some shouldChangeSelectedDOMRange contain Ranges for selections that are no longer valid

        * platform/mac/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
        * platform/mac/editing/deleting/delete-3608462-fix-expected.txt:
        * platform/mac/editing/deleting/delete-4083333-fix-expected.txt:
        * platform/mac/editing/execCommand/find-after-replace-expected.txt:
        * platform/mac/editing/selection/move-between-blocks-no-001-expected.txt:
        * platform/mac/editing/selection/replace-selection-1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Landing updated (improved) results for this test. The results changed in...
ap@webkit.org [Thu, 7 Feb 2008 06:16:22 +0000 (06:16 +0000)]
    Landing updated (improved) results for this test. The results changed in r30013,
        but this wasn't immediately noticed because of the test being on Leopard skipped list.

        Interestingly, js-test-pre.js has a workaround for the issue fixed in this revision in
        its debug() function, but not in description(). Keeping the workaround for now to let tests
        keep running in shipping Safari/WebKit.

        * svg/css/glyph-orientation-rounding-test-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoSwitch from directly handling wx scroll wheel events to handling the PlatformWheelEve...
kevino@webkit.org [Thu, 7 Feb 2008 04:12:36 +0000 (04:12 +0000)]
Switch from directly handling wx scroll wheel events to handling the PlatformWheelEvent instead to give JS, etc. a chance to handle it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-06 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Thu, 7 Feb 2008 04:00:59 +0000 (04:00 +0000)]
2008-02-06  Mark Rowe  <mrowe@apple.com>

        Fix Windows builds.

        * WebCore.vcproj/WebCore.vcproj: Unbreak the XML of the project file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMac build fix. Track rename that happened in r30056.
mrowe@apple.com [Thu, 7 Feb 2008 02:40:06 +0000 (02:40 +0000)]
Mac build fix.  Track rename that happened in r30056.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix expected output for layout tests to match tiger expected (and so work on the...
oliver@apple.com [Thu, 7 Feb 2008 02:00:29 +0000 (02:00 +0000)]
Fix expected output for layout tests to match tiger expected (and so work on the build bots)


git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-06 Brent Fulgham <bfulgham@gmail.com>
mrowe@apple.com [Thu, 7 Feb 2008 01:52:05 +0000 (01:52 +0000)]
2008-02-06  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Adam Roben.

        Conditionalize CoreGraphics vs Cairo support in Windows port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
andersca@apple.com [Thu, 7 Feb 2008 01:36:44 +0000 (01:36 +0000)]
    Reviewed by Darin.

        Change httpBodyFromStream to take the request instead of the stream.

        * platform/network/cf/FormDataStreamCFNet.cpp:
        * platform/network/cf/FormDataStreamCFNet.h:
        * platform/network/cf/ResourceRequestCFNet.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
kmccullough@apple.com [Thu, 7 Feb 2008 01:24:23 +0000 (01:24 +0000)]
    Reviewed by Darin.

        - Added manual tests for <rdar://problem/5556374> REGRESSION: cross-domain error when
        one URL uses an explicit port number and another doesn't

        * manual-tests/Default-port-frame.html: Added.
        * manual-tests/resources/Default-port-frame-contents.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUpdate build flags to fix windows build
oliver@apple.com [Wed, 6 Feb 2008 22:23:25 +0000 (22:23 +0000)]
Update build flags to fix windows build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
kmccullough@apple.com [Wed, 6 Feb 2008 22:03:08 +0000 (22:03 +0000)]

        Rubberstamped by Darin.

        <rdar://problem/5727708> REGRESSION (r29952): Can't send message from Yahoo Mail beta
        - Reverted the change that caused the regression.

        * dom/Document.cpp:
        * dom/Document.idl:


        Rubberstamped by Darin.

        <rdar://problem/5727708> REGRESSION (r29952): Can't send message from Yahoo Mail beta
        - Reverted the change that caused the regression.

        * dom/xhtml/level3/core/documentsetstricterrorchecking02-expected.txt:
        * fast/dom/Document/createAttributeNS-namespace-err-expected.txt: Removed.
        * fast/dom/Document/createAttributeNS-namespace-err.html: Removed.
        * fast/dom/Document/createElementNS-namespace-err-expected.txt: Removed.
        * fast/dom/Document/createElementNS-namespace-err.html: Removed.
        * fast/dom/Document/resources/TEMPLATE.html: Removed.
        * fast/dom/Document/resources/createAttributeNS-namespace-err.js: Removed.
        * fast/dom/Document/resources/createElementNS-namespace-err.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver Hunt.
ggaren@apple.com [Wed, 6 Feb 2008 21:46:41 +0000 (21:46 +0000)]
    Reviewed by Oliver Hunt.

        Added an ASSERT to catch refCount underflow, since it caused a leak in
        my last check-in.

        * wtf/RefCounted.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver Hunt.
ggaren@apple.com [Wed, 6 Feb 2008 21:24:19 +0000 (21:24 +0000)]
    Reviewed by Oliver Hunt.

        Fixed <rdar://problem/5728081> REGRESSION: Many leaks on buildbot

        The problem was refCount underflow in NamedAttrMap.

        Neither our regression tests nor the stress test have yet discovered
        another instance of this problem.

        * dom/NamedAttrMap.cpp:
        (WebCore::NamedAttrMap::addAttribute): Changed to use PassRefPtr,
        for fast and correct refCount management. Also, change a rediculously
        slow malloc to a slightly less rediculously slow realloc.

        * dom/NamedAttrMap.h:
        (WebCore::NamedAttrMap::insertAttribute): Changed to use PassRefPtr,
        for fast and correct refCount management.

        * html/HTMLTokenizer.cpp:
        (WebCore::Token::addAttribute): Use a RefPtr, to guarantee that the
        object starts with a refCount of 1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix typo in comment added in r30047.
mrowe@apple.com [Wed, 6 Feb 2008 21:21:09 +0000 (21:21 +0000)]
Fix typo in comment added in r30047.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoDump of bugs.webkit.org's Bugzilla instance.
timothy@apple.com [Wed, 6 Feb 2008 20:19:16 +0000 (20:19 +0000)]
Dump of bugs.webkit.org's Bugzilla instance.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Hatcher.
darin@apple.com [Wed, 6 Feb 2008 19:29:57 +0000 (19:29 +0000)]
    Reviewed by Tim Hatcher.

        - fix <rdar://problem/5723293> NULL-deref crash in PropertyMap::put opening web inspector
          with View Source window as target

        * page/InspectorController.cpp:
        (WebCore::canPassNodeToJavaScript): Added. Returns false if the node is in a document with
        JavaScript disabled.
        (WebCore::InspectorController::inspect): Check canPassNodeToJavaScript and do nothing if
        it returns false.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemove bad layout test.:
hyatt@apple.com [Wed, 6 Feb 2008 19:27:37 +0000 (19:27 +0000)]
Remove bad layout test.:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemove bad layout test.:
hyatt@apple.com [Wed, 6 Feb 2008 19:26:57 +0000 (19:26 +0000)]
Remove bad layout test.:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for bug 16799, object elements should return absolute URLs from .data.
hyatt@apple.com [Wed, 6 Feb 2008 19:26:14 +0000 (19:26 +0000)]
    Fix for bug 16799, object elements should return absolute URLs from .data.

        Reviewed by Mark Rowe

        * dom/Document.cpp:
        * html/HTMLAnchorElement.cpp:
        * html/HTMLObjectElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
antti@apple.com [Wed, 6 Feb 2008 18:17:12 +0000 (18:17 +0000)]
    Reviewed by Darin.

        <video autoplay controls> left in unplayable state if navigated away, then back to, before video finished loading

        When moving document in and out from the page cache:
        - Cancel incomplete load by deleting the media player. This guarantees everything is in consistent state.
        - Restart the load if it was aborted in the middle.

        * html/HTMLMediaElement.cpp:
        * html/HTMLMediaElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
ggaren@apple.com [Wed, 6 Feb 2008 17:53:53 +0000 (17:53 +0000)]
    Reviewed by Darin Adler.

        PLT speedup related to <rdar://problem/5659272> REGRESSION: PLT .4%
        slower due to r28884 (global variable symbol table optimization)

        Tweaked RefCounted::deref() to be a little more efficient.

        1% - 1.5% speedup on my machine. .7% speedup on Stephanie's machine.

        * wtf/RefCounted.h:
        (WTF::RefCounted::deref): Don't modify m_refCount if we're just going
        to delete the object anyway. Also, use a simple == test, which might be
        faster than <= on some hardware.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
darin@apple.com [Wed, 6 Feb 2008 17:40:16 +0000 (17:40 +0000)]

        Reviewed by Sam.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17094
          Array.prototype functions create length properties with DontEnum/DontDelete

        Test results match Gecko with very few obscure exceptions that seem to be
        bugs in Gecko.

        Test: fast/js/array-functions-non-arrays.html

        * kjs/array_object.cpp:
        (KJS::arrayProtoFuncConcat):  Removed DontEnum and DontDelete from the call
        to set length.
        (KJS::arrayProtoFuncPop): Ditto. Also added missing call to deleteProperty,
        which is not needed for real arrays, but is needed for non-arrays.
        (KJS::arrayProtoFuncPush): Ditto.
        (KJS::arrayProtoFuncShift): Ditto.
        (KJS::arrayProtoFuncSlice): Ditto.
        (KJS::arrayProtoFuncSort): Removed incorrect call to set length when
        the array has no elements.
        (KJS::arrayProtoFuncSplice): Removed DontEnum and DontDelete from the call
        to set length.
        (KJS::arrayProtoFuncUnShift): Ditto. Also added a check for 0 arguments to
        make behavior match the specification in that case.
        * kjs/nodes.cpp:
        (KJS::ArrayNode::evaluate): Removed DontEnum and DontDelete from the call
        to set length.


        Reviewed by Sam.

        - tests for http://bugs.webkit.org/show_bug.cgi?id=17094
          Array.prototype functions create length attributes with DontEnum/DontDelete

        * fast/js/array-functions-non-arrays-expected.txt: Added.
        * fast/js/array-functions-non-arrays.html: Added.
        * fast/js/resources/array-functions-non-arrays.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
darin@apple.com [Wed, 6 Feb 2008 17:33:07 +0000 (17:33 +0000)]

        Reviewed by Sam.

        - replace calls to put to set up properties with calls to putDirect, to
          prepare for a future change where put won't take attributes any more,
          and for a slight performance boost

        * API/JSObjectRef.cpp:
        (JSObjectMakeConstructor): Use putDirect instead of put.
        * kjs/CommonIdentifiers.h: Removed lastIndex.
        * kjs/JSGlobalObject.cpp:
        (KJS::JSGlobalObject::reset): Use putDirect instead of put.
        * kjs/array_object.cpp:
        (KJS::arrayProtoFuncConcat): Took out extra call to get length (unused).
        (KJS::ArrayObjectImp::ArrayObjectImp): Use putDirect instead of put.
        * kjs/error_object.cpp:
        (KJS::ErrorPrototype::ErrorPrototype): Use putDirect instead of put.
        * kjs/function.cpp:
        (KJS::Arguments::Arguments): Use putDirect instead of put.
        (KJS::PrototypeFunction::PrototypeFunction): Use putDirect instead of put.
        * kjs/function_object.cpp:
        (KJS::FunctionObjectImp::construct): Use putDirect instead of put.
        * kjs/nodes.cpp:
        (KJS::FuncDeclNode::makeFunction): Use putDirect instead of put.
        (KJS::FuncExprNode::evaluate): Use putDirect instead of put.
        * kjs/regexp_object.cpp:
        (KJS::regExpProtoFuncCompile): Use setLastIndex instead of put(lastIndex).
        (KJS::RegExpImp::match): Get and set lastIndex by using m_lastIndex instead of
        calling get and put.
        * kjs/regexp_object.h:
        (KJS::RegExpImp::setLastIndex): Added.
        * kjs/string_object.cpp:
        (KJS::stringProtoFuncMatch): Use setLastIndex instead of put(lastIndex).


        Reviewed by Sam.

        - replace calls to put to set up properties with calls to putDirect, to
          prepare for a future change where put won't take attributes any more,
          and for a slight performance boost

        * bindings/js/JSAudioConstructor.cpp:
        (WebCore::JSAudioConstructor::JSAudioConstructor): Use putDirect instead of put.
        * bindings/js/JSEventTargetBase.h:
        (WebCore::JSEventTargetPrototype::self): Ditto.
        * bindings/js/JSHTMLOptionElementConstructor.cpp:
        (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor): Ditto.
        * bindings/js/JSSQLResultSetRowListCustom.cpp:
        (WebCore::JSSQLResultSetRowList::item): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Wed, 6 Feb 2008 16:01:09 +0000 (16:01 +0000)]

        Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?17093
        'border-color' does not animate to the value of 'color' when unspecified

        Test: fast/css/transition-color-unspecified.html

        * page/AnimationController.cpp:
        (WebCore::ImplicitAnimation::animate): Changed to use the value of the
        'color' property in the source or destination style as the source or
        destination value of properties whose inital value is defined to be the
        computed value of 'color'.


        Reviewed by Darin Adler.

        - test for http://bugs.webkit.org/show_bug.cgi?17093
        'border-color' does not animate to the value of 'color' when unspecified

        * fast/css/transition-color-unspecified.html: Added.
        * platform/mac/fast/css/transition-color-unspecified-expected.checksum: Added.
        * platform/mac/fast/css/transition-color-unspecified-expected.png: Added.
        * platform/mac/fast/css/transition-color-unspecified-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix.
mitz@apple.com [Wed, 6 Feb 2008 15:46:15 +0000 (15:46 +0000)]
    Build fix.

        * svg/svgtags.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBuild fix -- touch generate-bindings to trigger regeneration of bindings
oliver@apple.com [Wed, 6 Feb 2008 07:08:43 +0000 (07:08 +0000)]
Build fix -- touch generate-bindings to trigger regeneration of bindings

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdded the svn:mime-type property to PNGs that did not have it.
mitz@apple.com [Wed, 6 Feb 2008 06:18:39 +0000 (06:18 +0000)]
Added the svn:mime-type property to PNGs that did not have it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRS=Eric.
oliver@apple.com [Wed, 6 Feb 2008 06:01:38 +0000 (06:01 +0000)]

Re-enable foreignObject by default as it is needed for a number of
non-fO related SVG tests and none of the old known crashes occur

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
weinig@apple.com [Wed, 6 Feb 2008 04:36:31 +0000 (04:36 +0000)]

        Reviewed by Anders Carlsson.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=8080
        NodeList (and other DOM lists) items are not enumeratable using for..in

        * JavaScriptCore.exp:


        Reviewed by Anders Carlsson.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=8080
        NodeList (and other DOM lists) items are not enumeratable using for..in

        - Match Firefox when enumerating DOM interfaces with indexGetters (support for
          the array bracket, nodeList[0], notation) by including all the items in the
          list before the attributes and methods of the interface.

        Test: fast/dom/domListEnumeration.html

        * ForwardingHeaders/kjs/PropertyNameArray.h: Added.
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::customGetPropertyNames): Use the new custom method model.
        * bindings/js/JSHistoryCustom.cpp:
        (WebCore::JSHistory::customGetPropertyNames): ditto.
        * bindings/scripts/CodeGeneratorJS.pm: Instead of just adding a declaration of
        getProperyNames and implementing the method in the Custom.cpp, move to a the
        model used by generated getOwnPropertySlot() and put() where the custom code
        is written in a separate customGetPropertyNames which returns a bool indicating
        whether to call up to the base class.  This enables adding the list indexes
        to the PropertyNameArray for interfaces with indexGetters automatically.


        Reviewed by Anders Carlsson.

        Test for http://bugs.webkit.org/show_bug.cgi?id=8080
        NodeList (and other DOM lists) items are not enumeratable using for..in

        * fast/dom/domListEnumeration-expected.txt: Added.
        * fast/dom/domListEnumeration.html: Added.
        * fast/dom/resources/domListEnumeration.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Oliver.
zimmermann@webkit.org [Wed, 6 Feb 2008 02:13:41 +0000 (02:13 +0000)]
Reviewed by Oliver.
Add new dynamic update tests, for SVGClipPathElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
weinig@apple.com [Wed, 6 Feb 2008 01:29:31 +0000 (01:29 +0000)]

        Reviewed by Darin Adler.

        Fix for <rdar://problem/5726604>
        dom-checker: deleting properties of the window object cross-domain should not be allowed

        Fix flaw found while testing with dom-checker testing tool (http://code.google.com/p/dom-checker/).

        Test: http/tests/security/cross-frame-access-delete.html

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::deleteProperty): Override deleteProperty to not delete cross-domain.
        * bindings/js/JSHistoryCustom.cpp:
        (WebCore::JSHistory::deleteProperty): ditto.
        * bindings/js/JSLocation.cpp:
        (WebCore::JSLocation::deleteProperty): ditto.
        * bindings/js/JSLocation.h:

        * bindings/scripts/CodeGeneratorJS.pm: Add deleteProperty declaration when CustomDeleteProperty is used.
        * page/DOMWindow.idl: Add CustomDeleteProperty extended attribute.
        * page/History.idl: ditto.


        Reviewed by Darin Adler.

        Test for <rdar://problem/5726604>
        dom-checker: deleting properties of the window object cross-domain should not be allowed

        * http/tests/security/cross-frame-access-delete-expected.txt: Added.
        * http/tests/security/cross-frame-access-delete.html: Added.
        * http/tests/security/resources/cross-frame-iframe-for-delete-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-05 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Wed, 6 Feb 2008 01:24:10 +0000 (01:24 +0000)]
2008-02-05  Mark Rowe  <mrowe@apple.com>

        Reviewed by Alp Toker.

        Fix warnings seen on the Gtk port by declaring variables and using constants of the correct types.

        * webkit/webkitwebbackforwardlist.cpp:
        * webkit/webkitwebhistoryitem.cpp:
        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix. Don't override intermediate directory.
sfalken@apple.com [Wed, 6 Feb 2008 01:16:57 +0000 (01:16 +0000)]
    Build fix.  Don't override intermediate directory.

        * Drosera/win/Drosera.vcproj/Drosera.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-05 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 6 Feb 2008 00:57:46 +0000 (00:57 +0000)]
2008-02-05  Alp Toker  <alp@atoker.com>

        Rubber-stamped by Mark Rowe.

        Fix a "missing sentinel in function call" warning by using NULL
        instead of 0.

        * platform/gtk/RenderThemeGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Oliver.
zimmermann@webkit.org [Tue, 5 Feb 2008 23:09:47 +0000 (23:09 +0000)]
Reviewed by Oliver.
Fix dynamic updates of <circle> element's properties.

Added tests: svg/dynamic-updates/SVGCircleElement*

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWx build fix. Add WebCore/plugins to the include path.
mrowe@apple.com [Tue, 5 Feb 2008 22:31:31 +0000 (22:31 +0000)]
Wx build fix.  Add WebCore/plugins to the include path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBuild fix for Windows. willCloseFrame is a pure virtual and we are
zecke@webkit.org [Tue, 5 Feb 2008 22:28:35 +0000 (22:28 +0000)]
Build fix for Windows. willCloseFrame is a pure virtual and we are
forced to have an implementation.

This partially reverts r30014.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-05 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Tue, 5 Feb 2008 22:23:29 +0000 (22:23 +0000)]
2008-02-05  Mark Rowe  <mrowe@apple.com>

        Mac build fix.  Update the Xcode project to follow a moved file,
        and track a rename in two files that were missed earlier.

        * WebCore.xcodeproj/project.pbxproj:
        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge canProvideDocumentSource]):
        * platform/mac/PlugInInfoStoreMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoForgot to mention bug
zimmermann@webkit.org [Tue, 5 Feb 2008 21:57:27 +0000 (21:57 +0000)]
Forgot to mention bug

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Holger.
zimmermann@webkit.org [Tue, 5 Feb 2008 21:56:28 +0000 (21:56 +0000)]
Reviewed by Holger.

Fix dynamic SVG DOM updates of <a> element's href property.

This commit also introduces a new SVG Tests framework: LayoutTests/svg/dynamic-updates
Its purpose is to provide dynamic updating tests for each SVG class & property, aka.
one test per property per class. As a first pass it's sufficient to add testcases for all
SVG*Element classes, and their properties - and only common-used base-class properties.

For SVGAElement - for example - it makes most sense to test scripting its parent
SVGURIReference object ('href' property) and its own property 'target'.

Adding tests to see - for example - if SVGAElement reacts on changes on ie. its parent
SVGExternalResourcesRequired interface, should really be done in a second pass.

All tests within the new framework are supposed to be created using make-js-tests-wrappers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUnreviewed build fix. Add missing #import.
mrowe@apple.com [Tue, 5 Feb 2008 21:54:27 +0000 (21:54 +0000)]
Unreviewed build fix.  Add missing #import.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
justin.garcia@apple.com [Tue, 5 Feb 2008 21:51:29 +0000 (21:51 +0000)]

        Reviewed by Alexey Proskuryakov.

        <rdar://problem/5685601> webkit-block-placeholder class on placeholders seems unnecessary (12317)

        * editing/CompositeEditCommand.cpp:
        (WebCore::createBlockPlaceholderElement): The khtml-block-placeholder class was needed
        when the editing code actively looked for <br>s of that type in order to handle them
        specially.  That is no longer the case.
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply): Fixed a bug where an extra block
        would be inserted when hitting return inside an editable root held open by a placeholder
        <br> or '\n'.  Added test cases for the bug and for the special case code that was incorrectly
        triggered to cause the bug.


        Reviewed by Alexey Proskuryakov.

        <rdar://problem/5685601> webkit-block-placeholder class on placeholders seems unnecessary (12317)

        * editing/inserting/5685601-1-expected.txt: Added.
        * editing/inserting/5685601-1.html: Added.
        * editing/inserting/5685601-2-expected.txt: Added.
        * editing/inserting/5685601-2.html: Added.
        * editing/inserting/5685601-3-expected.txt: Added.
        * editing/inserting/5685601-3.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago 2008-02-05 Rodney Dawes <dobey@wayofthemonkey.com>
mrowe@apple.com [Tue, 5 Feb 2008 21:46:46 +0000 (21:46 +0000)]
 2008-02-05  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Anders Carlsson.

        Part one of http://bugs.webkit.org/show_bug.cgi?id=16924.
        Shared PluginDatabase, PluginInfoStore and PluginPackage implementations.

        Remove the Win suffix on several plugin-related classes that will
        soon be refactored to be more portable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools/
zecke@webkit.org [Tue, 5 Feb 2008 20:47:31 +0000 (20:47 +0000)]
2008-02-05  Holger Freyther  <zecke@selfish.org>

        Reviewed by Darin.

        In http://bugs.webkit.org/show_bug.cgi?id=16853 it was identified that the
        the output of the willCloseFrame and didClearWindowObject FrameLoadDelegate
        depends on the order the tests are executed.

        Propose to remove willCloseFrame and didlCearWindowObject output from the
        FrameLoadDelegate and update the test results. The output of didClearWindowObject
        is not interesting for any of the current tests and we have other ways to find
        out if a frame was closed or not.

        * DumpRenderTree/mac/FrameLoadDelegate.mm:
        * DumpRenderTree/win/FrameLoadDelegate.cpp:
        * DumpRenderTree/win/FrameLoadDelegate.h:

2008-02-05  Holger Freyther  <zecke@selfish.org>

        Reviewed by Darin.

        In http://bugs.webkit.org/show_bug.cgi?id=16853 it was identified that the
        the output of the willCloseFrame and didClearWindowObject FrameLoadDelegate
        depends on the order the tests are executed.

        Propose to remove willCloseFrame and didlCearWindowObject output from the
        FrameLoadDelegate and update the test results. The output of didClearWindowObject
        is not interesting for any of the current tests and we have other ways to find
        out if a frame was closed or not.

        * http/tests/loading/bad-scheme-subframe-expected.txt:
        * http/tests/loading/bad-server-subframe-expected.txt:
        * http/tests/loading/basic-expected.txt:
        * http/tests/loading/empty-subframe-expected.txt:
        * http/tests/loading/gmail-assert-on-load-expected.txt:
        * http/tests/loading/onload-vs-immediate-refresh-expected.txt:
        * http/tests/loading/slow-parsing-subframe-expected.txt:
        * platform/mac/http/tests/loading/simple-subframe-expected.txt:
        * webarchive/loading/test-loading-archive-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap@webkit.org [Tue, 5 Feb 2008 19:52:51 +0000 (19:52 +0000)]
    Reviewed by Darin.

        Setting innerHTML in a detached XHTML element doesn't use the right namespace

        Test: fast/dom/innerHTML-detached-element.xhtml

        * dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer): Take parent element namespace
        into account.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
antti@apple.com [Tue, 5 Feb 2008 19:32:19 +0000 (19:32 +0000)]

        Reviewed by Geoff.

        Fix <rdar://problem/5698200>
        eBay photo uploading hangs and causes slow script warning to pop up

        In a case like this

            var f = window.parent.parentFunction;
            document.domain = document.domain; // this makes window.parent inaccessible

        Firefox allows parentFunction to access parents properties. Match this behavior.

        In a domain security check against the dynamic global object fails for the specific reason that one of
        the frames has written to the document.domain property and another has not (but they match otherwise),
        then recheck against the lexical global object.

        Test: http/tests/security/cross-frame-access-callback-explicit-domain-ALLOW.html

        * bindings/js/kjs_window.cpp:
        * bindings/js/kjs_window.h:
        * loader/FrameLoader.cpp:
        * platform/SecurityOrigin.cpp:
        * platform/SecurityOrigin.h:


        Reviewed by Geoff.

        Test for <rdar://problem/5698200>
        eBay photo uploading hangs and causes slow script warning to pop up

        * http/tests/security/cross-frame-access-callback-explicit-domain-ALLOW-expected.txt: Added.
        * http/tests/security/cross-frame-access-callback-explicit-domain-ALLOW.html: Added.
        * http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt: Added.
        * http/tests/security/cross-frame-access-callback-explicit-domain-DENY.html: Added.
        * http/tests/security/resources/cross-frame-iframe-callback-explicit-domain-ALLOW.html: Added.
        * http/tests/security/resources/cross-frame-iframe-callback-explicit-domain-DENY.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Remove an unused member from Document
aroben@apple.com [Tue, 5 Feb 2008 19:18:13 +0000 (19:18 +0000)]
    Remove an unused member from Document

        Reviewed by Mitz.

        * dom/Document.cpp:
        (WebCore::Document::recalcStyleSelector): There's no need to take
        m_printSheet into account anymore as it's never anything but the null
        * dom/Document.h: Removed m_printSheet and methods relating to it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
darin@apple.com [Tue, 5 Feb 2008 18:36:55 +0000 (18:36 +0000)]
    Reviewed by Darin.

        <rdar://problem/5497032> Can not enter accented characters using alt-numeric keypad (take two)

        * WebView.cpp: (WebViewWndProc): KeyUp messages need to be translated, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Tue, 5 Feb 2008 17:31:30 +0000 (17:31 +0000)]

        Reviewed by Darin Adler.

        - WebCore part of <rdar://problem/5724303> Should implement writing direction shortcuts

        * WebCore.base.exp: Added Editor::setBaseWritingDirection() and
        * page/mac/WebCoreFrameBridge.h: Removed
        * page/mac/WebCoreFrameBridge.mm: Ditto.


        Reviewed by Darin Adler.

        - WebKit part of <rdar://problem/5724303> Should implement writing direction shortcuts

        The key bindings are Command-Control-left arrow and
        Command-Control-right arrow. To match AppKit, the bindings are enabled
        only when certain user defaults are set.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
        (-[WebHTMLView toggleBaseWritingDirection:]): Changed to call
        Frame::baseWritingDirectionForSelectionStart() and
        Editor::setBaseWritingDirection() directly.
        (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
        (writingDirectionKeyBindingsEnabled): Added.
        (-[WebHTMLView _changeBaseWritingDirectionTo:]): Added this helper
        (-[WebHTMLView changeBaseWritingDirectionToLTR:]): Added.
        (-[WebHTMLView changeBaseWritingDirectionToRTL:]): Added.
        * WebView/WebView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUpdate WordPress to 2.3.3 which includes security fixes.
mrowe@apple.com [Tue, 5 Feb 2008 17:01:49 +0000 (17:01 +0000)]
Update WordPress to 2.3.3 which includes security fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUpdate versioning to support the mysterious future.
mrowe@apple.com [Tue, 5 Feb 2008 15:52:37 +0000 (15:52 +0000)]
Update versioning to support the mysterious future.

Reviewed by Oliver Hunt.

* Configurations/Version.xcconfig: Add SYSTEM_VERSION_PREFIX_1060.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the wxWidget Mac build by avoiding using ICU functions that were added after...
mrowe@apple.com [Tue, 5 Feb 2008 10:42:01 +0000 (10:42 +0000)]
Fix the wxWidget Mac build by avoiding using ICU functions that were added after ICU 3.2.

* editing/SmartReplaceICU.cpp:
(WebCore::addAllCodePoints): Implement a replacement for uset_addAllCodePoints.
(WebCore::getSmartSet): Use addAllCodePoints instead of uset_addAllCodePoints.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoPretend that r29998 never happened.
ap@webkit.org [Tue, 5 Feb 2008 09:34:18 +0000 (09:34 +0000)]
Pretend that r29998 never happened.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago30,000!
mrowe@apple.com [Tue, 5 Feb 2008 08:20:46 +0000 (08:20 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWorkaround for http://bugs.webkit.org/show_bug.cgi?id=16842
mrowe@apple.com [Tue, 5 Feb 2008 08:19:42 +0000 (08:19 +0000)]
Workaround for bugs.webkit.org/show_bug.cgi?id=16842
Bug 16842: Hang in DRT in leaks mode due to signal handler doing unsafe things

Reviewed by Oliver Hunt.

Don't install the signal handler unless we are running the pixel tests.
It is currently only used to restore the color profile, but by catching
signals we can trigger a deadlock in DRT while running leak tests.
The deadlock is tracked by http://bugs.webkit.org/show_bug.cgi?id=16842,
and a more complete fix will need to be developed to address this for
pixel tests as well.

* DumpRenderTree/mac/DumpRenderTree.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-04 Matt Perry <mpComplete@gmail.com>
mrowe@apple.com [Tue, 5 Feb 2008 08:16:17 +0000 (08:16 +0000)]
2008-02-04  Matt Perry  <mpComplete@gmail.com>

        Reviewed by Darin Adler.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=14959
        No back forward entry added for pages created in javascript

        A new HistoryItem is created for calls to Document::open.  Calls to
        Document::write save the written data to a SharedBuffer that is also
        stored on the HistoryItem.  When the user navigates back to a
        HistoryItem that has a valid buffer, that data is used for the page

        Tests: http/tests/navigation/document-open-adds-history-item.html

        * bindings/js/JSHTMLDocumentCustom.cpp:
        * dom/Document.cpp:
        * dom/Document.h:
        * history/HistoryItem.cpp:
        * history/HistoryItem.h:
        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:

2008-02-04  Matt Perry  <mpComplete@gmail.com>

        Reviewed by Darin Adler.

        Test cases for fix to http://bugs.webkit.org/show_bug.cgi?id=14959
        No back forward entry added for pages created in javascript.

        * http/tests/navigation/document-open-adds-history-item-expected.txt: Added.
        * http/tests/navigation/document-open-adds-history-item.html: Added.
        * http/tests/navigation/document-open-delayed-adds-history-item-expected.txt: Added.
        * http/tests/navigation/document-open-delayed-adds-history-item.html: Added.
        * http/tests/navigation/document-open-new-window-adds-history-item-expected.txt: Added.
        * http/tests/navigation/document-open-new-window-adds-history-item.html: Added.
        * http/tests/navigation/document-open-replace-no-history-item-expected.txt: Added.
        * http/tests/navigation/document-open-replace-no-history-item.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix for Bug 16889: REGRESSION (r29425): Canvas-based graphing calculator fails to run
oliver@apple.com [Tue, 5 Feb 2008 07:58:06 +0000 (07:58 +0000)]
Fix for Bug 16889: REGRESSION (r29425): Canvas-based graphing calculator fails to run
      Bug 17015: REGRESSION (r29414-29428): www.fox.com "shows" menu fails to render
      Bug 17164: REGRESSION: JavaScript pop-up menu appears at wrong location when hovering image at http://news.chinatimes.com/

Reviewed by Oliver Hunt




The ActivationImp tear-off (r29425) introduced a problem with ReadModify
nodes that first resolve a slot, call valueForReadModifyNode(), and then
store a value in the previously resolved slot. Since valueForReadModifyNode()
may cause a tear-off, the slot needs to be resolved again, but this was
not happening with the existing code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoGtk qmake build fix. Fix perl's complaint about an odd number of elements in anonymo...
mrowe@apple.com [Tue, 5 Feb 2008 07:28:52 +0000 (07:28 +0000)]
Gtk qmake build fix.  Fix perl's complaint about an odd number of elements in anonymous hash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoGtk build fix. wchar_t is only convertible to UChar on Windows.
mrowe@apple.com [Tue, 5 Feb 2008 06:55:07 +0000 (06:55 +0000)]
Gtk build fix.  wchar_t is only convertible to UChar on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix for r29993. Should have been icon-database, not icondatabase:
alp@webkit.org [Tue, 5 Feb 2008 06:54:08 +0000 (06:54 +0000)]
Fix for r29993. Should have been icon-database, not icondatabase:

2008-02-04  Jan Michael Alonzo  <jmalonzo@unpluggable.com>

        Reviewed by Alp Toker and Mark Rowe.

        [GTK] build-webkit and run-webkit-tests autootools support

        Add support for the autotools build to the WebKit build and test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-04 Jan Michael Alonzo <jmalonzo@unpluggable.com>
mrowe@apple.com [Tue, 5 Feb 2008 06:27:44 +0000 (06:27 +0000)]
2008-02-04  Jan Michael Alonzo  <jmalonzo@unpluggable.com>

        Reviewed by Mark Rowe.

        [GTK] build-webkit and run-webkit-tests autootools support

        * configure.ac: make the option name of icon database consistent
          with the rest of webkit (from -icon-database to icondatabase)

2008-02-04  Jan Michael Alonzo  <jmalonzo@unpluggable.com>

        Reviewed by Mark Rowe.

        [GTK] build-webkit and run-webkit-tests autootools support

        * Scripts/build-webkit: added --database and --icondatabase options
        * Scripts/run-launcher:
        * Scripts/run-webkit-tests:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoPartial fix for <rdar://5621244> Drag & Drop doesn't work correctly in DRT
oliver@apple.com [Tue, 5 Feb 2008 06:18:23 +0000 (06:18 +0000)]
Partial fix for <rdar://5621244> Drag & Drop doesn't work correctly in DRT

Reviewed by Steve F.

iImplement required DRT functionality to allow majority of Drag and Drop testcases to work.
Issues include:
  * Uses Sleep() to implement leapForward reliably.
  * 3 DND tests still fail for reasons that i have not yet determined
  * Has to explicitly ignore an extraneous WM_MOUSELEAVE that i am at a loss to explain

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-04 Cameron McCormack <cam@mcc.id.au>
mrowe@apple.com [Tue, 5 Feb 2008 05:51:58 +0000 (05:51 +0000)]
2008-02-04  Cameron McCormack <cam@mcc.id.au>

        Reviewed by Geoff Garen.

        Remove some unneccesary UNUSED_PARAMs.  Clarify ownership rule of return value of JSObjectCopyPropertyNames.

        * API/JSNode.c:
        * API/JSNodeList.c:
        * API/JSObjectRef.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-04 Tony Chang <idealisms@gmail.com>
mrowe@apple.com [Tue, 5 Feb 2008 05:47:30 +0000 (05:47 +0000)]
2008-02-04  Tony Chang  <idealisms@gmail.com>

        Reviewed by Darin Adler.

        Port the CoreFoundation version of WebCore::isCharacterSmartReplaceExempt
        for other platforms by using ICU directly.

        * GNUmakefile.am: Add SmartReplaceICU.cpp.
        * WebCore.pro: Ditto.
        * WebCoreSources.bkl: Ditto.
        * editing/SmartReplace.cpp: Don't use this empty implementation when ICU is available.
        * editing/SmartReplaceICU.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-04 Robert Sesek <rsesek@bluestatic.org>
mrowe@apple.com [Tue, 5 Feb 2008 05:32:32 +0000 (05:32 +0000)]
2008-02-04  Robert Sesek  <rsesek@bluestatic.org>

        Reviewed by Darin Adler.

        Fix http://bugs.webkit.org/show_bug.cgi?id=17042
        forms without action attributes submit to the <base> href instead of the originating page

        Test: fast/forms/missing-action.html

        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::submit): Submit to origin if there is no action

2008-02-04  Robert Sesek  <rsesek@bluestatic.org>

        Reviewed by Darin Adler.

        Test for Fix http://bugs.webkit.org/show_bug.cgi?id=17042
        forms without action attributes submit to the <base> href instead of the originating page

        * fast/forms/missing-action-expected.txt: Added.
        * fast/forms/missing-action.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoGtk build fix. Use std::numeric_limits in place of ULLONG_MAX as some Linux machines...
mrowe@apple.com [Tue, 5 Feb 2008 05:18:31 +0000 (05:18 +0000)]
Gtk build fix.  Use std::numeric_limits in place of ULLONG_MAX as some Linux machines do not have ULLONG_MAX.

OriginUsageRecord::unknownDiskUsage becomes a static function to avoid the global initialiser which would otherwise be generated.

Reviewed by Tim Hatcher.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoSpeculative Gtk build fix.
mrowe@apple.com [Tue, 5 Feb 2008 03:34:58 +0000 (03:34 +0000)]
Speculative Gtk build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix http://bugs.webkit.org/show_bug.cgi?id=17175 (Bug 17175: Use of C++ compiler...
mrowe@apple.com [Tue, 5 Feb 2008 03:25:59 +0000 (03:25 +0000)]
Fix bugs.webkit.org/show_bug.cgi?id=17175 (Bug 17175: Use of C++ compiler flags in CFLAGS).

Reviewed by Alp Toker and Mark Rowe.

Add global_cxxflags definition for inclusion in CXXFLAGS variables.
Only use -fno-rtti and $(SYMBOL_VISIBILITY_INLINES) with global_cxxflags as gcc complains they aren't valid for C.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-04 Christian Dywan <christian@imendio.com>
alp@webkit.org [Tue, 5 Feb 2008 01:41:04 +0000 (01:41 +0000)]
2008-02-04  Christian Dywan  <christian@imendio.com>

        Reviewed by Alp Toker.

        [GTK] Use a consistent coding style

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Attempt to fix build of all non-Mac platforms
beidson@apple.com [Tue, 5 Feb 2008 01:33:04 +0000 (01:33 +0000)]
    Attempt to fix build of all non-Mac platforms

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCoreSources.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin
beidson@apple.com [Tue, 5 Feb 2008 00:55:47 +0000 (00:55 +0000)]
    Reviewed by Darin

        Fix for <rdar://problem/5628468> - Quotas need to be implemented per-origin, and not per-database

        To accomplish this, we need to track the sizes of all databases in an origin to constantly keep an up to date
        count of the origin's total disk usage.  I've introduced the OriginQuotaManager and OriginUsageRecord classes
        to accomplish this.

        Whenever a transaction is known to mutate the size of a database (tracked by the DatabaseAuthorizer), it marks
        that database as unknown in the OriginQuotaManager.  When a transaction later comes along to ask the
        OriginQuotaManager the usage for that origin, it stat's all of the unknown databases in the origin and returns
        the result.

        Since the OriginQuotaManager is interesting from both the main thread and a DatabaseThread, all accessors it
        provides require it to be locked first.  ASSERTs help guarantee this is always the case.

        Layout test will involve adding functionality to DRT on multiple platforms and will be coming up shortly

        * WebCore.xcodeproj/project.pbxproj:

        * platform/SecurityOrigin.h: Changed to be ThreadSafeShared instead of RefCounted

        * storage/Database.cpp:
        (WebCore::Database::databaseSize): Return the current filesize of this database on disk
        (WebCore::Database::maximumSize): Added - calculates maximum size of this database based on quota and usage
        * storage/Database.h: Add databaseSize() accessor, and get rid of unused declared methods that *were* going
          to be the solution for this bug.

        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::originQuotaManager): Accessor to the OriginQuotaManager which is lazily created
        (WebCore::DatabaseTracker::canEstablishDatabase): Fetch the usage for this database slightly earlier, which
          will ensure that the OriginQuotaManager is primed to track this origin
        (WebCore::DatabaseTracker::fullPathForDatabase): Ditto
        (WebCore::DatabaseTracker::populateOrigins): Create the OriginQuotaManager here.
        (WebCore::DatabaseTracker::usageForOrigin): Use the OriginQuotaManager instead of looping through each database
          in the origin
        (WebCore::DatabaseTracker::deleteOrigin): Remove this origin from the OriginQuotaManager as it is no longer
        (WebCore::DatabaseTracker::deleteDatabase): Remove this database from the OriginQuotaManager as it is no longer
        * storage/DatabaseTracker.h:

        * storage/OriginQuotaManager.cpp: Added.
        (WebCore::OriginQuotaManager::trackOrigin): Add an origin to be tracked.  Useful for when the very first database
          in a new origin is still in the process of being created
        (WebCore::OriginQuotaManager::removeOrigin): Removes all records in a certain origin from being tracked
        (WebCore::OriginQuotaManager::markDatabase): Mark a specific database as having an unknown size - called when the
          DatabaseAuthorizer in a SQLTransaction knows the file size might change.
        (WebCore::OriginQuotaManager::diskUsage): Returns the disk usage for the given origin
        * storage/OriginQuotaManager.h: Added.

        * storage/OriginUsageRecord.cpp: Added.
        (WebCore::OriginUsageRecord::addDatabase): Adds an entry for the database in this origin's record
        (WebCore::OriginUsageRecord::removeDatabase): Removes that entry
        (WebCore::OriginUsageRecord::markDatabase): Marks the database as of unknown size
        (WebCore::OriginUsageRecord::diskUsage): Returns the cached disk usage value, or recalculates it if any databases
          are marked
        * storage/OriginUsageRecord.h: Added.

        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::openTransactionAndPreflight): Use Database::maximumSize() instead of attributing the
          entire quota to each database.
        (WebCore::SQLTransaction::runStatements): Use Database::maximumSize() instead of attributing the entire quota
          to each database.
        (WebCore::SQLTransaction::runCurrentStatement): Mark this databases's size as unknown in the
          OriginQuotaManager if this statement will change the size of the database
        * storage/SQLTransaction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
harrison@apple.com [Tue, 5 Feb 2008 00:36:48 +0000 (00:36 +0000)]
    Reviewed by Darin Adler.

        <rdar://problem/5607381> CrashTracer: [REGRESSION] 1748 crashes in Safari at com.apple.WebCore: WebCore::Image::width const + 24

        Use an empty image when the local image file could not be loaded.

        No test case because it would require forcing tiff load failure.

        * editing/DeleteButtonController.cpp:
        Do not present the deletion UI in the (odd) event that the delete button could not be loaded.

        * platform/graphics/mac/ImageMac.mm:
        Return an empty image instead of 0 if the load fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * dom/Document.cpp:
darin@apple.com [Mon, 4 Feb 2008 23:24:35 +0000 (23:24 +0000)]
    * dom/Document.cpp:
        (WebCore::Document::completeURL): Fixed misleading comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/5722735> Merge fix for SQLITE_FULL error
timothy@apple.com [Mon, 4 Feb 2008 22:53:37 +0000 (22:53 +0000)]
    <rdar://problem/5722735> Merge fix for SQLITE_FULL error
        is given even if the max_page_count is increased (2920)

        * libWebCoreSQLite3.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-04 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Mon, 4 Feb 2008 22:15:54 +0000 (22:15 +0000)]
2008-02-04  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Darin.

        Blacklist Silverlight versions older than min required, not newer.

        * plugins/win/PluginPackageWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd layout test for selector parsing changes.
hyatt@apple.com [Mon, 4 Feb 2008 22:14:45 +0000 (22:14 +0000)]
Add layout test for selector parsing changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd layout test for selector parsing changes.
hyatt@apple.com [Mon, 4 Feb 2008 22:14:05 +0000 (22:14 +0000)]
Add layout test for selector parsing changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for bug 16751, misparsing of html*.test in CSS.
hyatt@apple.com [Mon, 4 Feb 2008 22:12:16 +0000 (22:12 +0000)]
    Fix for bug 16751, misparsing of html*.test in CSS.

        Reviewed by darin

        Added fast/css/simple-selector-chain-parsing.html

        * css/CSSGrammar.y:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Suggested by Geoff and Maciej.
darin@apple.com [Mon, 4 Feb 2008 21:38:27 +0000 (21:38 +0000)]
    Suggested by Geoff and Maciej.

        * bindings/js/JSCustomSQLTransactionCallback.cpp: Reworded a misleading
        comment to be correct.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-04 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Mon, 4 Feb 2008 21:32:12 +0000 (21:32 +0000)]
2008-02-04  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Steve, Anders.

        <rdar://problem/5211187> QuickTime and Flash plug-ins draw outside of
        content area when inside an iframe or div with overflow when playing a
        movie and scrolling the iframe/div area

        Clip the update region to the zero rect when scrolling. Don't do this
        for Java, because it results in repaint problems.

        * plugins/PluginQuirkSet.h: Added the DontClipToZeroRectWhenScrolling
        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginViewWin::updateWindow): Readded the old behavior of
        clipping to the zero rect when updating the window during a scroll.
        Added plug-in quirk to ignore this behavior for Java. Swapped order of
        the SetWindowRgn() and MoveWindow() calls to prevent Java from painting
        outside of its container during a scroll.
        (WebCore::PluginViewWin::determineQuirks): If this is Java, add the
        DontClipToZeroRectWhenScrolling quirk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mark Rowe.
timothy@apple.com [Mon, 4 Feb 2008 20:57:38 +0000 (20:57 +0000)]
    Reviewed by Mark Rowe.

        <rdar://problem/5722972> Leopard needs to statically link SQLite

        * Configurations/Base.xcconfig: Always have a header search path for WebCoreSQLite3.
        * Configurations/DebugRelease.xcconfig: Ditto.
        * Configurations/WebCore.xcconfig: Always link against WebCoreSQLite3.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * platform/win/Skipped: Added one more failure.
aroben@apple.com [Mon, 4 Feb 2008 20:29:00 +0000 (20:29 +0000)]
    * platform/win/Skipped: Added one more failure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFixed a typo
aroben@apple.com [Mon, 4 Feb 2008 20:24:44 +0000 (20:24 +0000)]
Fixed a typo

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * platform/win/Skipped: Added some new failures.
aroben@apple.com [Mon, 4 Feb 2008 20:23:01 +0000 (20:23 +0000)]
    * platform/win/Skipped: Added some new failures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Windows build fix
aroben@apple.com [Mon, 4 Feb 2008 20:17:21 +0000 (20:17 +0000)]
    Windows build fix

        * bindings/scripts/CodeGeneratorCOM.pm: Touched to force a rebuild of
        the COM bindings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
harrison@apple.com [Mon, 4 Feb 2008 19:04:18 +0000 (19:04 +0000)]

        Reviewed by Tim Hatcher.

        - fix <rdar://problem/5715481> REGRESSION (r26499): JavaScript document.lastModified is not supported

        Re-add attribute inadvertantly lost by r26499.

        Test: fast/js/lastModified.html: Added.

        * dom/Document.idl:
        Add lastModified.


        Reviewed by Tim Hatcher.

        Test for <rdar://problem/5715481> REGRESSION (r26499): JavaScript document.lastModified is not supported

        * fast/js/lastModified-expected.txt: Added.
        * fast/js/lastModified.html: Added.
        * fast/js/resources/lastModified.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix wrongly auto-merged change log.
darin@apple.com [Mon, 4 Feb 2008 18:41:27 +0000 (18:41 +0000)]
Fix wrongly auto-merged change log.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix the search field if the inpsected Document has overridden
darin@apple.com [Mon, 4 Feb 2008 18:40:55 +0000 (18:40 +0000)]
    Fix the search field if the inpsected Document has overridden
        Document.evaluate or Document.querySelectorAll

        Reviewed by Darin.

        * manual-tests/inspector-document-methods-override.html: Added.
        * page/InspectorController.cpp:
        (WebCore::InspectorController::didCommitLoad): Reworded a comment to
        force WebCore.vcproj to build.
        * page/inspector/inspector.js: Call
        Document.prototype.{evaluate,querySelectorAll}.call instead of calling
        the functions directly on the inspected Document. This ensures we are
        calling the version of these functions we intended to.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix the search field if the inpsected Document has overridden Document.evalua...
aroben@apple.com [Mon, 4 Feb 2008 18:37:49 +0000 (18:37 +0000)]
    Fix the search field if the inpsected Document has overridden Document.evaluate or Document.querySelectorAll

        Reviewed by Darin.

        * manual-tests/inspector-document-methods-override.html: Added.
        * page/InspectorController.cpp:
        (WebCore::InspectorController::didCommitLoad): Reworded a comment to
        force WebCore.vcproj to build.
        * page/inspector/inspector.js: Call
        Document.prototype.{evaluate,querySelectorAll}.call instead of calling
        the functions directly on the inspected Document. This ensures we are
        calling the version of these functions we intended to.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29965 268f45cc-cd09-0410-ab3c-d52691b4dbfc