WebKit-https.git
10 years agoDFG inlining block linking compares BlockIndex against bytecode index
fpizlo@apple.com [Wed, 11 Jan 2012 02:54:06 +0000 (02:54 +0000)]
DFG inlining block linking compares BlockIndex against bytecode index
https://bugs.webkit.org/show_bug.cgi?id=76018
<rdar://problem/10671979>

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseCodeBlock):

LayoutTests:

* fast/js/dfg-inline-many-blocks-expected.txt: Added.
* fast/js/dfg-inline-many-blocks.html: Added.
* fast/js/script-tests/dfg-inline-many-blocks.js: Added.
(stuff):
(foo):
(fuzz):
(baz):
(bar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove redundant code from DOMWindowSQLDatabase.cpp
haraken@chromium.org [Wed, 11 Jan 2012 02:04:53 +0000 (02:04 +0000)]
Remove redundant code from DOMWindowSQLDatabase.cpp
https://bugs.webkit.org/show_bug.cgi?id=76010

Reviewed by Adam Barth.

This patch removes redundant code from DOMWindowSQLDatabase.cpp.

- Remove window->frame() check, since window->frame() is always true when
  window->isCurrentlyDisplayedInFrame() is true.
- window->frame()->document() can just be window->document()

Tests: storage/open-database-creation-callback-isolated-world.html
       storage/open-database-creation-callback.html
       storage/open-database-empty-version.html
       storage/open-database-over-quota.html
       storage/open-database-set-empty-version.html
       storage/open-database-while-transaction-in-progress.html

* storage/DOMWindowSQLDatabase.cpp:
(WebCore::DOMWindowSQLDatabase::openDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRepaint video controls when buffering during pause.
commit-queue@webkit.org [Wed, 11 Jan 2012 01:51:19 +0000 (01:51 +0000)]
Repaint video controls when buffering during pause.
https://bugs.webkit.org/show_bug.cgi?id=73957

Source/WebCore:

Pipes support for a new bufferingProgressed() method on MediaControls
elements. Allows controls to be repainted as data buffers when paused.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-10
Reviewed by Hajime Morita.

Test: http/tests/media/video-buffering-repaints-controls.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setNetworkState):
(WebCore::HTMLMediaElement::progressEventTimerFired):
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::bufferingProgressed):
* html/shadow/MediaControlRootElement.h:
* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::bufferingProgressed):
* html/shadow/MediaControlRootElementChromium.h:
* html/shadow/MediaControls.h:

LayoutTests:

Adds video-buffering-repaints-controls test to verify the progress bar
repaints as new data is buffered when paused.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-10
Reviewed by Hajime Morita.

* http/tests/media/video-buffering-repaints-controls.html: Added.
* platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png: Added.
* platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/win/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r104543.
commit-queue@webkit.org [Wed, 11 Jan 2012 01:35:50 +0000 (01:35 +0000)]
Unreviewed, rolling out r104543.
http://trac.webkit.org/changeset/104543
https://bugs.webkit.org/show_bug.cgi?id=76013

Asserts on Mac 10.6 dbg bots (Requested by dimich on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-10

* css3/calc/block-mask-overlay-image-outset-expected-mismatch.html: Removed.
* css3/calc/block-mask-overlay-image-outset.html: Removed.
* css3/calc/resources/mask.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2012-01-10 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Wed, 11 Jan 2012 01:19:34 +0000 (01:19 +0000)]
2012-01-10  Chris Marrin  <cmarrin@apple.com>

        Wrapped allowedCompositingTriggers in ACCELERATED_COMPOSITING ifdef to make non-accelerated builds work

        Unreviewed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Pasteboard::documentFragment should fall back to text if there's no HTML...
dcheng@chromium.org [Wed, 11 Jan 2012 01:19:14 +0000 (01:19 +0000)]
[chromium] Pasteboard::documentFragment should fall back to text if there's no HTML text
https://bugs.webkit.org/show_bug.cgi?id=75923

Reviewed by Tony Chang.

Source/WebCore:

Test: editing/pasteboard/pasting-empty-html-falls-back-to-text.html

* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::documentFragment):

LayoutTests:

* editing/pasteboard/pasting-empty-html-falls-back-to-text-expected.txt: Added.
* editing/pasteboard/pasting-empty-html-falls-back-to-text.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse the [Supplemental] IDL in SQLDatabase
haraken@chromium.org [Wed, 11 Jan 2012 01:12:22 +0000 (01:12 +0000)]
Use the [Supplemental] IDL in SQLDatabase
https://bugs.webkit.org/show_bug.cgi?id=76004

Reviewed by Adam Barth.

We've been working on WebKit modularization. By using the [Supplemental] IDL,
we can move SQLDatabase related code from WebCore/page/DOMWindow.{h,cpp,idl}
to WebCore/storage/DOMWindowSQLDatabase.{h,cpp,idl}.

Tests: storage/open-database-creation-callback-isolated-world.html
       storage/open-database-creation-callback.html
       storage/open-database-empty-version.html
       storage/open-database-over-quota.html
       storage/open-database-set-empty-version.html
       storage/open-database-while-transaction-in-progress.html

* CMakeLists.txt: Added DOMWindowSQLDatabase.{idl,h,cpp} to the build script.
* DerivedSources.make: Ditto.
* DerivedSources.pri: Ditto.
* GNUmakefile.list.am: Ditto.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.

* page/DOMWindow.cpp: Removed SQLDatabase related code.
* page/DOMWindow.idl: Ditto.
* page/DOMWindow.h: Ditto. Moved isCurrentlyDisplayedInFrame() from private: to public:
so that DOMWindowSQLDatabase::openDatabase() can access it.

* storage/DOMWindowSQLDatabase.cpp: Added. Moved openDatabase() from DOMWindow.cpp to here.
(WebCore::DOMWindowSQLDatabase::openDatabase):
* storage/DOMWindowSQLDatabase.h: Added. Moved openDatabase() from DOMWindow.h to here.
* storage/DOMWindowSQLDatabase.idl: Added. Using the [Supplemental] IDL, moved openDatabase()
and SQLException from DOMWindow.idl to here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agopadding test for CSS3 calc
mikelawther@chromium.org [Wed, 11 Jan 2012 01:10:08 +0000 (01:10 +0000)]
padding test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=76005

Reviewed by Darin Adler.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

* css3/calc/padding-expected.txt: Added.
* css3/calc/padding.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCIFilter version of Sepia Tone filter doesn't match software
cmarrin@apple.com [Wed, 11 Jan 2012 01:07:14 +0000 (01:07 +0000)]
CIFilter version of Sepia Tone filter doesn't match software
https://bugs.webkit.org/show_bug.cgi?id=75129

Reviewed by Simon Fraser.

Source/WebCore:

Changed sepia tone filter to use a CIColorMatrix filter with
values that match sw filter.

* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(interp):
(PlatformCALayer::setFilters):

LayoutTests:

Updated sepia tone results for core image filters on CA layers to match changes. Updated sw results because
they had the wrong color space

* css3/filters/effect-sepia-expected.png:
* css3/filters/effect-sepia-hw-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2]REGRESSION(r102435): It made tst_QQuickWebView::show() crash
ostapenko.viatcheslav@nokia.com [Wed, 11 Jan 2012 00:42:11 +0000 (00:42 +0000)]
[Qt][WK2]REGRESSION(r102435): It made tst_QQuickWebView::show() crash
https://bugs.webkit.org/show_bug.cgi?id=74176

Reviewed by Noam Rosenthal.

Source/WebCore:

Replaces static global GL resource holder with holder shared between
TextureMapperGL instances created on the same GL context. Also adds
deallocation of GL resources when last TextureMapperGL instance on the
current GL context gets deleted.

Tested by multipleWebViewWindows and multipleWebViews Qt WK2 API tests.

* platform/graphics/opengl/TextureMapperGL.cpp:
(WebCore::TextureMapperGLData::SharedGLData::getCurrentGLContext):
(WebCore::TextureMapperGLData::SharedGLData::glContextDataMap):
(WebCore::TextureMapperGLData::SharedGLData::currentSharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::ProgramInfo::ProgramInfo):
(WebCore::TextureMapperGLData::SharedGLData::createShaderProgram):
(WebCore::TextureMapperGLData::SharedGLData::deleteShaderProgram):
(WebCore::TextureMapperGLData::SharedGLData::SharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::~SharedGLData):
(WebCore::TextureMapperGLData::sharedGLData):
(WebCore::TextureMapperGLData::TextureMapperGLData):
(WebCore::TextureMapperGLData::SharedGLData::initializeShaders):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::BitmapTextureGL::bind):
(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapperGL::beginClip):
(WebCore::TextureMapperGL::endClip):
* platform/graphics/opengl/TextureMapperGL.h:

Source/WebKit2:

Check texture mapper exists already in ensureRootLayer to avoid recrecation.
Check if root layer was deleted already in purgeGLResources.
Added multipleWebViewWindows and multipleWebViews API tests.

* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::multipleWebViewWindows):
(tst_QQuickWebView::multipleWebViews):
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::ensureRootLayer):
(WebKit::LayerTreeHostProxy::purgeGLResources):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Unreviewed, roll Chromium DEPS to r117121.
dcheng@chromium.org [Wed, 11 Jan 2012 00:39:01 +0000 (00:39 +0000)]
[chromium] Unreviewed, roll Chromium DEPS to r117121.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoClarify run-webkit-tests options reset-results and new-baseline
scheib@chromium.org [Wed, 11 Jan 2012 00:32:36 +0000 (00:32 +0000)]
Clarify run-webkit-tests options reset-results and new-baseline
https://bugs.webkit.org/show_bug.cgi?id=75993

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDisabled mock scrollbars should draw differently
simon.fraser@apple.com [Wed, 11 Jan 2012 00:19:50 +0000 (00:19 +0000)]
Disabled mock scrollbars should draw differently
https://bugs.webkit.org/show_bug.cgi?id=75995

Source/WebCore:

Reviewed by James Robinson.

When the scrollbar is disabled, paint the entire track of
mock scrollbars with a lighter gray, and hide the thumb.

No tests, since mock scrollbars aren't enabled by default on Mac yet.

* platform/mock/ScrollbarThemeMock.cpp:
(WebCore::ScrollbarThemeMock::paintTrackBackground):
(WebCore::ScrollbarThemeMock::paintThumb):

Tools:

Reviewed by James Robinson.

When the scrollbar is disabled, paint the entire track of
mock scrollbars with a lighter gray, and hide the thumb.

* DumpRenderTree/mac/DumpRenderTree.mm:
(-[DRTMockScroller drawKnob]):
(-[DRTMockScroller drawRect:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCodeBlock.h declares too many things
fpizlo@apple.com [Wed, 11 Jan 2012 00:18:05 +0000 (00:18 +0000)]
CodeBlock.h declares too many things
https://bugs.webkit.org/show_bug.cgi?id=76001

Rubber stamped by Gavin Barraclough.

Removed all non-CodeBlock type declarations from CodeBlock.h, and put them
into separate header files. Also removed all non-CodeBlock method implementations
from CodeBlock.cpp and put them into corresponding cpp files.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* assembler/RepatchBuffer.h:
* bytecode/CallLinkInfo.cpp: Added.
(JSC::CallLinkInfo::unlink):
* bytecode/CallLinkInfo.h: Added.
(JSC::CallLinkInfo::callTypeFor):
(JSC::CallLinkInfo::CallLinkInfo):
(JSC::CallLinkInfo::~CallLinkInfo):
(JSC::CallLinkInfo::isLinked):
(JSC::CallLinkInfo::seenOnce):
(JSC::CallLinkInfo::setSeen):
(JSC::getCallLinkInfoReturnLocation):
(JSC::getCallLinkInfoBytecodeIndex):
* bytecode/CallReturnOffsetToBytecodeOffset.h: Added.
(JSC::CallReturnOffsetToBytecodeOffset::CallReturnOffsetToBytecodeOffset):
(JSC::getCallReturnOffset):
* bytecode/CodeBlock.cpp:
* bytecode/CodeBlock.h:
* bytecode/CodeType.h: Added.
* bytecode/ExpressionRangeInfo.h: Added.
* bytecode/GlobalResolveInfo.h: Added.
(JSC::GlobalResolveInfo::GlobalResolveInfo):
* bytecode/HandlerInfo.h: Added.
* bytecode/LineInfo.h: Added.
* bytecode/MethodCallLinkInfo.cpp: Added.
(JSC::MethodCallLinkInfo::reset):
* bytecode/MethodCallLinkInfo.h: Added.
(JSC::MethodCallLinkInfo::MethodCallLinkInfo):
(JSC::MethodCallLinkInfo::seenOnce):
(JSC::MethodCallLinkInfo::setSeen):
(JSC::getMethodCallLinkInfoReturnLocation):
(JSC::getMethodCallLinkInfoBytecodeIndex):
* bytecode/StructureStubInfo.h:
(JSC::getStructureStubInfoReturnLocation):
(JSC::getStructureStubInfoBytecodeIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNeed to handle absolutely positioned elements inside flexboxes
tony@chromium.org [Tue, 10 Jan 2012 23:52:56 +0000 (23:52 +0000)]
Need to handle absolutely positioned elements inside flexboxes
https://bugs.webkit.org/show_bug.cgi?id=70793

Reviewed by David Hyatt.

Source/WebCore:

Tests: css3/flexbox/insert-text-crash.html
       css3/flexbox/position-absolute-child.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computePreferredMainAxisExtent): Skip the size of positioned elements.
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm): Add placeholders for positioned elements.
(WebCore::RenderFlexibleBox::prepareChildForPositionedLayout): Positions the layer for the positioned child.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Handle positioned elements.
(WebCore::RenderFlexibleBox::layoutColumnReverse): Adjust the main axis offset of the layer for positioned elements.
* rendering/RenderFlexibleBox.h:

LayoutTests:

* css3/flexbox/insert-text-crash-expected.txt: Added.
* css3/flexbox/insert-text-crash.html: Added.
* css3/flexbox/position-absolute-child-expected.txt: Added.
* css3/flexbox/position-absolute-child.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Reuse old timebase when activating CCDelayBasedTimeSource
nduca@chromium.org [Tue, 10 Jan 2012 23:50:35 +0000 (23:50 +0000)]
[chromium] Reuse old timebase when activating CCDelayBasedTimeSource
https://bugs.webkit.org/show_bug.cgi?id=75938

Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
(WebCore::CCDelayBasedTimeSource::CCDelayBasedTimeSource):
(WebCore::CCDelayBasedTimeSource::setActive):
(WebCore::CCDelayBasedTimeSource::onTimerFired):
(WebCore::CCDelayBasedTimeSource::postNextTickTask):
* platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:

Source/WebKit/chromium:

* tests/CCDelayBasedTimeSourceTest.cpp:
(WebKitTests::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSupport the [Supplemental] IDL on methods
haraken@chromium.org [Tue, 10 Jan 2012 23:48:39 +0000 (23:48 +0000)]
Support the [Supplemental] IDL on methods
https://bugs.webkit.org/show_bug.cgi?id=75944

Reviewed by Adam Barth.

The spec for the [Supplemental] IDL:
http://dev.w3.org/2006/webapi/WebIDL/#dfn-supplemental-interface

Currently the [Supplemental] IDL is supported on attributes but not supported
on methods. This patch makes a change to support it.

Specifically, assume the following IDL:

    interface [Supplemental=X] Y {
        void func();
    }

Then the code generator generates the following V8X.cpp.

    void funcCallback(Arguments& args) {
        X* imp = V8X::toNative(args.Holder());
        Y::func(imp);
    }

Similar code is also generated for JS, ObjC, GObject and CPP bindings.

Test: bindings/scripts/test/TestSupplemental.idl

* bindings/scripts/CodeGeneratorCPP.pm: Modified as described above.
(GenerateImplementation):
* bindings/scripts/CodeGeneratorGObject.pm: Ditto.
(GenerateFunction):
* bindings/scripts/CodeGeneratorJS.pm: Ditto.
(GenerateParametersCheck):
* bindings/scripts/CodeGeneratorObjC.pm: Ditto.
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm: Ditto.
(GenerateFunctionCallString):
* bindings/scripts/generate-bindings.pl: Ditto.

* bindings/scripts/test/TestSupplemental.idl: Added test cases for [Supplemental] methods.

* bindings/scripts/test/CPP/WebDOMTestInterface.cpp: Updated the test result.
(WebDOMTestInterface::supplementalMethod1):
(WebDOMTestInterface::supplementalMethod2):
* bindings/scripts/test/CPP/WebDOMTestInterface.h: Ditto.
* bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: Ditto.
(webkit_dom_test_interface_supplemental_method1):
(webkit_dom_test_interface_supplemental_method2):
* bindings/scripts/test/GObject/WebKitDOMTestInterface.h: Ditto.
* bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.
(WebCore::JSTestInterfacePrototype::getOwnPropertySlot):
(WebCore::JSTestInterfacePrototype::getOwnPropertyDescriptor):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod1):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):
* bindings/scripts/test/JS/JSTestInterface.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestInterface.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestInterface.mm: Ditto.
(-[DOMTestInterface supplementalMethod1]):
(-[DOMTestInterface supplementalMethod2:objArg:]):
* bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
(WebCore::TestInterfaceInternal::supplementalMethod1Callback):
(WebCore::TestInterfaceInternal::supplementalMethod2Callback):
(WebCore::ConfigureV8TestInterfaceTemplate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium rebaseline after r104625.
rniwa@webkit.org [Tue, 10 Jan 2012 23:44:05 +0000 (23:44 +0000)]
Chromium rebaseline after r104625.

* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Unreviewed, roll Chromium DEPS to r117109.
tony@chromium.org [Tue, 10 Jan 2012 23:37:55 +0000 (23:37 +0000)]
[chromium] Unreviewed, roll Chromium DEPS to r117109.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoQt rebaseline after r104625.
rniwa@webkit.org [Tue, 10 Jan 2012 23:37:01 +0000 (23:37 +0000)]
Qt rebaseline after r104625.

* platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Refactoring] Rename attributes in TestSupplemental.idl to clarify
haraken@chromium.org [Tue, 10 Jan 2012 23:35:38 +0000 (23:35 +0000)]
[Refactoring] Rename attributes in TestSupplemental.idl to clarify
that they are supplemental attributes
https://bugs.webkit.org/show_bug.cgi?id=75942

Reviewed by Adam Barth.

This patch just renames attributes in TestSupplemental.idl
to make it easy to find in {JS,V8,WebKitDOM,DOM,WebDOM}TestInterface.cpp
which attributes originate from TestSupplemental.idl.

* bindings/scripts/test/TestSupplemental.idl: Just renamed three attributes.

* bindings/scripts/test/CPP/WebDOMTestInterface.cpp: Updated the test result.
(WebDOMTestInterface::supplementalStr1):
(WebDOMTestInterface::supplementalStr2):
(WebDOMTestInterface::setSupplementalStr2):
* bindings/scripts/test/CPP/WebDOMTestInterface.h: Ditto.
* bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: Ditto.
(webkit_dom_test_interface_get_supplemental_str1):
(webkit_dom_test_interface_get_supplemental_str2):
(webkit_dom_test_interface_set_supplemental_str2):
(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):
(webkit_dom_test_interface_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestInterface.h: Ditto.
* bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.
(WebCore::jsTestInterfaceSupplementalStr1):
(WebCore::jsTestInterfaceSupplementalStr2):
(WebCore::jsTestInterface):
(WebCore::setJSTestInterfaceSupplementalStr2):
(WebCore::setJSTestInterface):
* bindings/scripts/test/JS/JSTestInterface.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestInterface.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestInterface.mm: Ditto.
(-[DOMTestInterface supplementalStr1]):
(-[DOMTestInterface supplementalStr2]):
(-[DOMTestInterface setSupplementalStr2:]):
(-[DOMTestInterface ]):
(-[DOMTestInterface set:]):
* bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
(WebCore::TestInterfaceInternal::supplementalStr1AttrGetter):
(WebCore::TestInterfaceInternal::supplementalStr2AttrGetter):
(WebCore::TestInterfaceInternal::supplementalStr2AttrSetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
commit-queue@webkit.org [Tue, 10 Jan 2012 23:35:33 +0000 (23:35 +0000)]
[chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
https://bugs.webkit.org/show_bug.cgi?id=75988

Patch by James Robinson <jamesr@chromium.org> on 2012-01-10
Reviewed by Adam Barth.

* Scripts/webkitpy/common/config/ports.py:
(WebKitPort.run_webkit_unit_tests_command):
(WebKitPort):
(ChromiumPort.run_webkit_unit_tests_command):
(ChromiumPort):
* Scripts/webkitpy/common/config/ports_mock.py:
(MockPort.run_webkit_unit_tests_command):
* Scripts/webkitpy/tool/commands/download_unittest.py:
(DownloadCommandsTest.test_build_and_test):
(test_land):
(test_land_red_builders):
* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
* Scripts/webkitpy/tool/steps/runtests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowebkitpy: add os_name, os_version to platforminfo
dpranke@chromium.org [Tue, 10 Jan 2012 23:33:59 +0000 (23:33 +0000)]
webkitpy: add os_name, os_version to platforminfo
https://bugs.webkit.org/show_bug.cgi?id=75931

Reviewed by Eric Siedel.

As a first step in cleaning up the version parsing logic in
webkitpy.layout_tests.port, this adds common routines for
getting the os_name and os_version fields to the PlatformInfo
class. Nothing uses them yet but I've added FIXME's to some of
the code that needs to be deleted in the port files.

* Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo.__init__):
(PlatformInfo):
(PlatformInfo._determine_os_name):
(PlatformInfo._determine_mac_version):
(PlatformInfo._determine_linux_version):
(PlatformInfo._determine_win_version):
(PlatformInfo.display_name):
(PlatformInfo.total_bytes_memory):
(PlatformInfo._compute_bytes_from_vm_stat_output):
(PlatformInfo.free_bytes_memory):
* Scripts/webkitpy/common/system/platforminfo_unittest.py: Added.
(TestPlatformInfo):
(TestPlatformInfo.make_info):
(TestPlatformInfo.make_info.mock_run_command):
(TestPlatformInfo.setUp):
(TestPlatformInfo.tearDown):
(TestPlatformInfo.test_basic):
(TestPlatformInfo.integration_test_basic):
(TestPlatformInfo.test_display_name_mac):
(TestPlatformInfo.test_display_name_win32):
(TestPlatformInfo.test_memory_mac):
(TestPlatformInfo.test_memory_win32):
(TestPlatformInfo.test_determine_os_name):
(TestPlatformInfo.test_determine_mac_version):
(TestPlatformInfo.test_determine_linux_version):
(TestPlatformInfo.test_determine_win_version_from_tuple):
(TestPlatformInfo.test_determine_win_version_from_cmd):
* Scripts/webkitpy/layout_tests/port/apple.py:
(ApplePort.__init__):
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort.__init__):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort):
* Scripts/webkitpy/layout_tests/port/win.py:
(WinPort):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Correctly recreate DrawingBuffer on lost device
commit-queue@webkit.org [Tue, 10 Jan 2012 23:19:03 +0000 (23:19 +0000)]
[chromium] Correctly recreate DrawingBuffer on lost device
https://bugs.webkit.org/show_bug.cgi?id=75912

Patch by John Bauman <jbauman@chromium.org> on 2012-01-10
Reviewed by Kenneth Russell.

Create new drawing buffer on new context, not old lost context. Also,
make sure to bind new drawing buffer.

No new tests.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::maybeRestoreContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSnow Leopard build fix.
rniwa@webkit.org [Tue, 10 Jan 2012 23:17:33 +0000 (23:17 +0000)]
Snow Leopard build fix.

* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAllow plugins to add rotate items to browser's context menu. Adds a new
bbudge@chromium.org [Tue, 10 Jan 2012 23:01:52 +0000 (23:01 +0000)]
Allow plugins to add rotate items to browser's context menu. Adds a new
WebPluginAction struct, with rotate types.
https://bugs.webkit.org/show_bug.cgi?id=75645

Reviewed by Darin Fisher.

* WebKit.gyp:
* public/WebContextMenuData.h:
* public/WebPlugin.h:
(WebKit::WebPlugin::canRotateView):
(WebKit::WebPlugin::rotateView):
* public/WebPluginAction.h: Added.
(WebKit::WebPluginAction::WebPluginAction):
* public/WebView.h:
* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::performMediaPlayerAction):
(WebKit::WebViewImpl::performPluginAction):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/JavaScriptCore: Hang opening movie that requires authentication
andersca@apple.com [Tue, 10 Jan 2012 22:50:51 +0000 (22:50 +0000)]
Source/JavaScriptCore: Hang opening movie that requires authentication
https://bugs.webkit.org/show_bug.cgi?id=75989
<rdar://problem/9601915>

Reviewed by Sam Weinig.

* wtf/Functional.h:
Add function wrapper for a function that takes three parameters.

Source/WebKit2: Hang opening movie that requires authentication
https://bugs.webkit.org/show_bug.cgi?id=75989

Reviewed by Sam Weinig.

Change the way the keychain calls are processed to avoid deadlocks:

1. When a keychain call is made, the web process sends an asynchronous request message to the UI process,
   avoiding the need to bounce calls to the main thread (since CoreIPC only allows sending
   synchronous messages from the main thread). Incidentally, this fixes <rdar://problem/9428041>.
2. The Web Process now waits on the calling thread, (for a condition variable to be signalled) for a reply message.
3. The UI process handles the incoming message request message on the connection work queue and uses
   dispatch_async to a global dispatch queue where the keychain call is made.
   We use a global queue to prevent the connection work queue from blocking on the call.
4. The UI process then sends an asynchronous reply message back to the web process. This message is sent from
   the global dispatch queue.
5. The Web Process handles the reply message on the connection queue, adds the reply to a map and signals
   the condition variable that the web process is waiting on and the thread that made the keychain call
   can resume execution.

* Shared/mac/SecItemRequestData.cpp:
(WebKit::SecItemRequestData::SecItemRequestData):
(WebKit::SecItemRequestData::encode):
(WebKit::SecItemRequestData::decode):
* Shared/mac/SecItemRequestData.h:
(WebKit::SecItemRequestData::type):
Add a type to SecItemRequestData and encode/decode it.

* Shared/mac/SecItemResponseData.h:
(WebKit::SecItemResponseData::resultObject):
Make this return a reference so we can call leakRef() on it.

* Shared/mac/SecKeychainItemRequestData.cpp:
(WebKit::SecKeychainItemRequestData::SecKeychainItemRequestData):
(WebKit::SecKeychainItemRequestData::~SecKeychainItemRequestData):
(WebKit::SecKeychainItemRequestData::attributeList):
(WebKit::SecKeychainItemRequestData::encode):
(WebKit::SecKeychainItemRequestData::decode):
* Shared/mac/SecKeychainItemRequestData.h:
(WebKit::SecKeychainItemRequestData::type):
Add a type, and put the OwnPtr and OwnArrayPtr in a RefCounted struct so we can
correctly copy this object.

* UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::WebConnectionToWebProcess):
Don't open the connection here, the WebProcessProxy object needs to add itself as a queue client before opening.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::disconnect):
Remove the WebProcessProxy object from the list of connection queue clients.

(WebKit::WebProcessProxy::didReceiveMessageOnConnectionWorkQueue):
Call didReceiveWebProcessProxyMessageOnConnectionWorkQueue.

(WebKit::WebProcessProxy::didFinishLaunching):
Add the WebProcessProxy as a queue client and open the connection.

* UIProcess/WebProcessProxy.h:
WebProcessProxy should inherit from CoreIPC::Connection::QueueClient. Replace all individual keychain
handler functions with two generic functions, secItemRequest and secKeychainItemRequest.

* UIProcess/WebProcessProxy.messages.in:
Replace individual keychain messages with SecItemRequest and SecKeychainItemRequest messages.

* UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::handleSecItemRequest):
Call the right SecItem function depending on the request type and send back the result.

(WebKit::WebProcessProxy::secItemRequest):
Dispatch handleSecItemRequest on a global dispatch queue.

(WebKit::handleSecKeychainItemRequest):
Call the right SecKeychainItem function depending on the request type and send back the result.

(WebKit::WebProcessProxy::secKeychainItemRequest):
Dispatch handleSecKeychainItemRequest on a global dispatch queue.

* WebKit2.xcodeproj/project.pbxproj:
Update for added/removed files.

* WebProcess/WebProcess.h:
Add secItemResponse and secKeychainItemResponse message handlers.

* WebProcess/WebProcess.messages.in:
Add SecItemResponse and SecKeychainItemResponse messages.

* WebProcess/mac/CoreIPCClientRunLoop.h:
* WebProcess/mac/CoreIPCClientRunLoop.mm:
This is no longer needed.

* WebProcess/mac/KeychainItemShimMethods.h:
* WebProcess/mac/KeychainItemShimMethods.mm:
(WebKit::managedAttributeLists):
Make this an atomically initialized static.

(WebKit::managedAttributeListsMutex):
Add an atomically initialized mutex.

(WebKit::allocateAttributeListContents):
Use the managedAttributeListsMutex to make this function callable from any thread.

(WebKit::managedKeychainItemContents):
Make this an atomically initialized static.

(WebKit::managedKeychainItemContentsMutex):
Add an atomically initialized mutex.

(WebKit::allocateKeychainItemContentData):
Use the managedAttributeListsMutex to make this function callable from any thread.

(WebKit::webFreeAttributeListContent):
Use locking so this can be called from any thread.

(WebKit::webFreeKeychainItemContent):
Ditto.

(WebKit::responseMap):
Add responseMap thread-safe singleton for holding incoming responses.

(WebKit::generateSecKeychainItemRequestID):
Return a unique item request id, using OSAtomicIncrement64Barrier for atomicity.

(WebKit::didReceiveSecKeychainItemResponse):
Pass the response over the response map.

(WebKit::sendSeqKeychainItemRequest):
Send a request message and wait for a response using ResponseMap::waitForResponse.

(WebKit::webSecKeychainItemCopyContent):
Send a request using sendSeqKeychainItemRequest.

(WebKit::webSecKeychainItemCreateFromContent):
Ditto.

(WebKit::webSecKeychainItemModifyContent):
Ditto.

* WebProcess/mac/KeychainShimResponseMap.h:
New thread-safe helper class that stores a map of responses and lets client wait for a response
with a given ID.

(KeychainShimResponseMap::waitForResponse):
Wait until the response is available in the hash map, then return it.

(KeychainShimResponseMap::didReceiveResponse):
Add the response to the hash map and signal the condition variable.

* WebProcess/mac/SecItemShimMethods.h:
* WebProcess/mac/SecItemShimMethods.mm:
(WebKit::responseMap):
Add responseMap thread-safe singleton for holding incoming responses.

(WebKit::generateSecItemRequestID):
Return a unique item request id, using OSAtomicIncrement64Barrier for atomicity.

(WebKit::didReceiveSecItemResponse):
Pass the response over the response map.

(WebKit::sendSeqItemRequest):
Send a request message and wait for a response using ResponseMap::waitForResponse.

(WebKit::webSecItemCopyMatching):
Send a request using sendSeqItemRequest.

(WebKit::webSecItemAdd):
Ditto.

(WebKit::webSecItemUpdate):
Ditto.

(WebKit::webSecItemDelete):
Ditto.

* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::secItemResponse):
Call didReceiveSecItemResponse.

(WebKit::WebProcess::secKeychainItemResponse):
Call didReceiveSecKeychainItemResponse.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: [Chromium] Partial revert of r104566, since it breaks the shared
senorblanco@chromium.org [Tue, 10 Jan 2012 22:34:23 +0000 (22:34 +0000)]
Source/WebCore: [Chromium] Partial revert of r104566, since it breaks the shared
library build on Windows.
https://bugs.webkit.org/show_bug.cgi?id=75994

Reviewed by Dmitry Titov.

Covered by SVG feColorMatrix tests (see LayoutTests/ChangeLog).

* WebCore.gypi:
* platform/graphics/filters/FEColorMatrix.h:

LayoutTests: Suppress failures caused by partial revert of r104566.
https://bugs.webkit.org/show_bug.cgi?id=75994

Reviewed by Dmitry Titov.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Unreviewed, rebaseline tests after r104575 and r104588.
dimich@chromium.org [Tue, 10 Jan 2012 22:09:02 +0000 (22:09 +0000)]
[Chromium] Unreviewed, rebaseline tests after r104575 and r104588.

* platform/chromium-mac-leopard/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
* platform/chromium-mac-leopard/fast/layers/scroll-with-transform-layer-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCodeBlock::m_numParameters should be encapsulated
fpizlo@apple.com [Tue, 10 Jan 2012 22:08:47 +0000 (22:08 +0000)]
CodeBlock::m_numParameters should be encapsulated
https://bugs.webkit.org/show_bug.cgi?id=75985
<rdar://problem/10671020>

Reviewed by Oliver Hunt.

Encapsulated CodeBlock::m_numParameters and hooked argument profile creation
into it.  This appears to be performance neutral.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::setNumParameters):
(JSC::CodeBlock::addParameter):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::numParameters):
(JSC::CodeBlock::addressOfNumParameters):
(JSC::CodeBlock::offsetOfNumParameters):
(JSC::CodeBlock::numberOfArgumentValueProfiles):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::addParameter):
(JSC::BytecodeGenerator::emitReturn):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::AbstractState):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::predictArgumentTypes):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::slideRegisterWindowForCall):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::execute):
(JSC::Interpreter::prepareForRepeatCall):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITStubs.cpp:
(JSC::arityCheckFor):
(JSC::lazyLinkFor):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Unreviewed test expectations update. This test needs a new baseline for...
dimich@chromium.org [Tue, 10 Jan 2012 22:03:13 +0000 (22:03 +0000)]
[Chromium] Unreviewed test expectations update. This test needs a new baseline for Vista.

* platform/chromium-win-vista/fast/text/unicode-variation-selector-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoClean up RenderLayerBacking code that looks for the body
simon.fraser@apple.com [Tue, 10 Jan 2012 21:38:41 +0000 (21:38 +0000)]
Clean up RenderLayerBacking code that looks for the body
https://bugs.webkit.org/show_bug.cgi?id=39502

Source/WebCore:

Reviewed by Dave Hyatt.

Consolidate code that propagates the <body> background to the
root, adding a utility method on RenderObject that is called
by RenderBox and RenderLayerBacking.

Removed an unused method in RenderLayerBacking.

The compositiong changes are not testable, since rendererBackgroundColor()
is only used by fullscreen at present.

Tests: fast/backgrounds/root-background-propagation.html
       fast/backgrounds/root-background-propagation2.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintRootBoxFillLayers):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::rendererBackgroundColor):
* rendering/RenderLayerBacking.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::rendererForRootBackground):
* rendering/RenderObject.h:

LayoutTests:

Reviewed by Dave Hyatt.

Tests for propagation of the <body> background to the root.

* fast/backgrounds/root-background-propagation-expected.png: Added.
* fast/backgrounds/root-background-propagation-expected.txt: Added.
* fast/backgrounds/root-background-propagation.html: Added.
* fast/backgrounds/root-background-propagation2-expected.png: Added.
* fast/backgrounds/root-background-propagation2-expected.txt: Added.
* fast/backgrounds/root-background-propagation2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLayout test rebaselines after r104606.
ojan@chromium.org [Tue, 10 Jan 2012 21:30:30 +0000 (21:30 +0000)]
Layout test rebaselines after r104606.

* platform/chromium-win/fast/harness/results-expected.txt: Renamed from LayoutTests/platform/chromium/fast/harness/results-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Create iterators for the RenderSurface-Layer tree
commit-queue@webkit.org [Tue, 10 Jan 2012 21:24:39 +0000 (21:24 +0000)]
[chromium] Create iterators for the RenderSurface-Layer tree
https://bugs.webkit.org/show_bug.cgi?id=74203

Patch by Dana Jansens <danakj@chromium.org> on 2012-01-10
Reviewed by James Robinson.

Source/WebCore:

New unit tests: CCLayerIteratorTest.cpp

* WebCore.gypi:
* platform/graphics/chromium/RenderSurfaceChromium.h:
* platform/graphics/chromium/cc/CCLayerIterator.cpp: Added.
(WebCore::CCLayerIteratorActions::BackToFront::begin):
(WebCore::CCLayerIteratorActions::BackToFront::end):
(WebCore::CCLayerIteratorActions::BackToFront::next):
(WebCore::CCLayerIteratorActions::FrontToBack::begin):
(WebCore::CCLayerIteratorActions::FrontToBack::end):
(WebCore::CCLayerIteratorActions::FrontToBack::next):
(WebCore::CCLayerIteratorActions::FrontToBack::goToHighestInSubtree):
* platform/graphics/chromium/cc/CCLayerIterator.h: Added.
(WebCore::CCLayerIterator::CCLayerIterator):
(WebCore::CCLayerIterator::begin):
(WebCore::CCLayerIterator::end):
(WebCore::CCLayerIterator::operator++):
(WebCore::CCLayerIterator::operator==):
(WebCore::CCLayerIterator::operator!=):
(WebCore::CCLayerIterator::operator->):
(WebCore::CCLayerIterator::operator*):
(WebCore::CCLayerIterator::representsTargetRenderSurface):
(WebCore::CCLayerIterator::representsContributingRenderSurface):
(WebCore::CCLayerIterator::representsItself):
(WebCore::CCLayerIterator::targetRenderSurfaceLayer):
* platform/graphics/chromium/cc/CCLayerIteratorPosition.h: Added.
(WebCore::CCLayerIteratorPosition::CCLayerIteratorPosition):
(WebCore::CCLayerIteratorPosition::currentLayer):
(WebCore::CCLayerIteratorPosition::currentLayerRepresentsContributingRenderSurface):
(WebCore::CCLayerIteratorPosition::currentLayerRepresentsTargetRenderSurface):
(WebCore::CCLayerIteratorPosition::targetRenderSurfaceLayer):
(WebCore::CCLayerIteratorPosition::targetRenderSurface):
(WebCore::CCLayerIteratorPosition::targetRenderSurfaceChildren):
(WebCore::CCLayerIteratorPosition::operator==):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::walkLayersAndCalculateVisibleLayerRects):
* platform/graphics/chromium/cc/CCRenderSurface.h:

Source/WebKit/chromium:

* WebKit.gypi:
* tests/CCLayerIteratorTest.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename flex-align to flex-item-align.
ojan@chromium.org [Tue, 10 Jan 2012 21:19:55 +0000 (21:19 +0000)]
Rename flex-align to flex-item-align.
https://bugs.webkit.org/show_bug.cgi?id=75929

Reviewed by Darin Adler.

Source/WebCore:

The spec has changed and now flex-align will be set on
the flexbox itself.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexAlign):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyleBitfields::flexItemAlign):
(WebCore::RenderStyleBitfields::setFlexItemAlign):
(WebCore::RenderStyleBitfields::initialFlexItemAlign):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
* rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

* css3/flexbox/css-properties-expected.txt:
* css3/flexbox/flex-align-column.html:
* css3/flexbox/flex-align-vertical-writing-mode.html:
* css3/flexbox/flex-align.html:
* css3/flexbox/line-wrapping.html:
* css3/flexbox/orthogonal-flex-directions.html:
* css3/flexbox/script-tests/css-properties.js:
* fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReplace TextTrackCue "getCueAsSource" method with "text" attribute
eric.carlson@apple.com [Tue, 10 Jan 2012 21:14:23 +0000 (21:14 +0000)]
Replace TextTrackCue "getCueAsSource" method with "text" attribute
https://bugs.webkit.org/show_bug.cgi?id=75646

Reviewed by Darin Adler.

Source/WebCore:

Test: media/track/track-cue-mutable-text.html

* html/HTMLMediaElement.h: getCueAsSource() -> text().

* html/TextTrackCue.cpp:
(WebCore::TextTrackCue::setText): New. Set cue text and clear the document fragment.
(WebCore::TextTrackCue::getCueAsHTML): Allocate the document fragment if it doesn't exist.
* html/TextTrackCue.h:
(WebCore::TextTrackCue::text):
* html/TextTrackCue.idl: getCueAsSource() -> text().

* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::updateTextTrackDisplay): getCueAsSource() -> text().
* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::updateTextTrackDisplay): getCueAsSource() -> text().

* html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::collectCueText): processCueText is dead, long live createNewCue.
(WebCore::WebVTTParser::createDocumentFragmentFromCueText): New, split out of processCueText.
    Create a document fragment from the String argument.
(WebCore::WebVTTParser::createNewCue): Split out of processCueText.
(WebCore::WebVTTParser::constructTreeFromToken): Add a comment pointing to the spec section
    with the rules for DOM construction.
* html/track/WebVTTParser.h:

LayoutTests:

* media/track/track-cue-mutable-text-expected.txt: Added.
* media/track/track-cue-mutable-text.html: Added. New test for mutable cue text.
* media/track/track-cue-nothing-to-render-expected.txt: getCueAsSource() -> text.
* media/track/track-cue-nothing-to-render.html: Ditto.
* media/track/track-cue-rendering-expected.txt: Ditto.
* media/track/track-cue-rendering.html: Ditto.
* media/track/track-webvtt-tc001-utf8-expected.txt: Ditto.
* media/track/track-webvtt-tc001-utf8.html: Ditto.
* media/track/track-webvtt-tc002-bom-expected.txt: Ditto.
* media/track/track-webvtt-tc002-bom.html: Ditto.
* media/track/track-webvtt-tc003-newlines-expected.txt: Ditto.
* media/track/track-webvtt-tc003-newlines.html: Ditto.
* media/track/track-webvtt-tc004-magic-header-expected.txt: Ditto.
* media/track/track-webvtt-tc004-magic-header.html: Ditto.
* media/track/track-webvtt-tc005-header-comment-expected.txt: Ditto.
* media/track/track-webvtt-tc005-header-comment.html: Ditto.
* media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Ditto.
* media/track/track-webvtt-tc006-cue-identifiers.html: Ditto.
* media/track/track-webvtt-tc007-cue-no-id-expected.txt: Ditto.
* media/track/track-webvtt-tc007-cue-no-id.html: Ditto.
* media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Ditto.
* media/track/track-webvtt-tc008-timings-no-hours.html: Ditto.
* media/track/track-webvtt-tc009-timings-hour-expected.txt: Ditto.
* media/track/track-webvtt-tc009-timings-hour.html: Ditto.
* media/track/track-webvtt-tc011-blank-lines-expected.txt: Ditto.
* media/track/track-webvtt-tc011-blank-lines.html: Ditto.
* media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Ditto.
* media/track/track-webvtt-tc028-unsupported-markup.html: Ditto.
* platform/mac/fast/dom/Window/window-properties-expected.txt: Remove getCueAsSource.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDispatchOnConnectionQueue messages should have a Connection parameter
andersca@apple.com [Tue, 10 Jan 2012 21:14:16 +0000 (21:14 +0000)]
DispatchOnConnectionQueue messages should have a Connection parameter
https://bugs.webkit.org/show_bug.cgi?id=75986

Reviewed by Adam Roben.

Message handlers for messages with the DispatchOnConnectionQueue should have a CoreIPC::Connection
parameter, making it easier to send messages back over that connection.

* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
(CoreIPC::handleMessageOnConnectionQueue):
* Scripts/webkit2/messages.py:
(async_case_statement):
(generate_message_handler):
* Scripts/webkit2/messages_unittest.py:
* WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::wheelEvent):
(WebKit::EventDispatcher::gestureEvent):
* WebProcess/WebPage/EventDispatcher.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::pluginProcessCrashed):
* WebProcess/WebProcess.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTurn off the FilterTrigger in WebKit and WebKit2
cmarrin@apple.com [Tue, 10 Jan 2012 21:12:45 +0000 (21:12 +0000)]
Turn off the FilterTrigger in WebKit and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=75914

Reviewed by Simon Fraser.

Source/WebKit/mac:

Implement allowedCompositingTriggers to turn on all compositing triggers except FilterTrigger.

* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::allowedCompositingTriggers):

Source/WebKit2:

Implement allowedCompositingTriggers to turn on all compositing triggers except FilterTrigger.

* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebKit::WebChromeClient::allowedCompositingTriggers):

LayoutTests:

Test to make sure compositing layers are off for filters

* css3/filters/should-not-have-compositing-layer-expected.txt: Added.
* css3/filters/should-not-have-compositing-layer.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake it possible to type data: URLs into MiniBrowser on Windows
aroben@apple.com [Tue, 10 Jan 2012 21:05:59 +0000 (21:05 +0000)]
Make it possible to type data: URLs into MiniBrowser on Windows

Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
MiniBrowser on Windows

Reviewed by Darin Adler.

* MiniBrowser/win/BrowserWindow.cpp:
(BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
whether to prepend "http://", just look for whether the typed URL contains a colon. If it
does, we assume it already has a scheme and don't modify it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix following https://bugs.webkit.org/show_bug.cgi?id=75935
barraclough@apple.com [Tue, 10 Jan 2012 21:01:01 +0000 (21:01 +0000)]
Build fix following https://bugs.webkit.org/show_bug.cgi?id=75935

Fix 32-bit builds.

* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::setLength):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r102024): Having the Bing homepage open prevents idle sleep
jer.noble@apple.com [Tue, 10 Jan 2012 20:43:20 +0000 (20:43 +0000)]
REGRESSION (r102024): Having the Bing homepage open prevents idle sleep
https://bugs.webkit.org/show_bug.cgi?id=75972

Reviewed by Oliver Hunt.

No new tests; no testing infrastructure exists to test display sleep assertions.

Only disable idle and display sleep when a video element is not paused, not looping, and
has both a video and audio track.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerRateChanged): Factor into updateDisableSleep() and
    shouldDisplaySleep().
(WebCore::HTMLMediaElement::setLoop): Ditto.
(WebCore::HTMLMediaElement::attributeChanged): Ditto.
(WebCore::HTMLMediaElement::updateDisableSleep):
(WebCore::HTMLMediaElement::shouldDisableSleep):
* html/HTMLMediaElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Rebaseline after r104585
commit-queue@webkit.org [Tue, 10 Jan 2012 20:42:41 +0000 (20:42 +0000)]
[Chromium] Rebaseline after r104585
https://bugs.webkit.org/show_bug.cgi?id=75981

Unreviewed Chromium expectations update.

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-10

* platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
* platform/chromium-linux/svg/custom/shapes-supporting-markers-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/shapes-supporting-markers-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
* platform/chromium-win/svg/custom/shapes-supporting-markers-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Move inspector tests into the inspector test group
noel.gordon@gmail.com [Tue, 10 Jan 2012 20:39:31 +0000 (20:39 +0000)]
[chromium] Move inspector tests into the inspector test group
https://bugs.webkit.org/show_bug.cgi?id=75926

Reviewed by Adam Barth.

And mark http/tests/inspector/resource-tree/resource-tree-document-url.html as flaky.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Mac] Accelerate canvas layers with the same logic as accelerating the canvas itself
mdelaney@apple.com [Tue, 10 Jan 2012 20:30:59 +0000 (20:30 +0000)]
[Mac] Accelerate canvas layers with the same logic as accelerating the canvas itself
https://bugs.webkit.org/show_bug.cgi?id=75921

Reviewed by Simon Fraser.

No new tests. Does not affect detectable behavior.

* rendering/RenderLayerCompositor.cpp: Use canvas's shouldAccelerate to avoid asking
uninitialized canvas's if they're accelerated or not.
(WebCore::RenderLayerCompositor::updateBacking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake MiniBrowser automatically escape invalid URL characters typed in its URL field
aroben@apple.com [Tue, 10 Jan 2012 20:23:48 +0000 (20:23 +0000)]
Make MiniBrowser automatically escape invalid URL characters typed in its URL field

Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
MiniBrowser on Windows

Reviewed by Darin Adler.

* MiniBrowser/win/BrowserView.cpp:
(BrowserView::goToURL): Pass the typed string through
CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdding myself (benwells) to committers.py
benwells@chromium.org [Tue, 10 Jan 2012 20:08:55 +0000 (20:08 +0000)]
Adding myself (benwells) to committers.py
https://bugs.webkit.org/show_bug.cgi?id=75971

Reviewed by Ojan Vafai.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChange -[WebHistoryItem copyWithZone:] to not use NSCopyObject()
mitz@apple.com [Tue, 10 Jan 2012 20:01:04 +0000 (20:01 +0000)]
Change -[WebHistoryItem copyWithZone:] to not use NSCopyObject()
https://bugs.webkit.org/show_bug.cgi?id=75980

Reviewed by Mark Rowe.

* History/WebHistoryItem.mm:
(-[WebHistoryItem copyWithZone:]): Replaced NSCopyObject() with
-alloc, -initWithWebCoreHistoryItem:.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix.
barraclough@apple.com [Tue, 10 Jan 2012 19:56:18 +0000 (19:56 +0000)]
Windows build fix.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Do not recreate texture updater for image layer if one exists.
commit-queue@webkit.org [Tue, 10 Jan 2012 19:52:39 +0000 (19:52 +0000)]
[Chromium] Do not recreate texture updater for image layer if one exists.
https://bugs.webkit.org/show_bug.cgi?id=75589

Patch by Daniel Sievers <sievers@chromium.org> on 2012-01-10
Reviewed by James Robinson.

Source/WebCore:

Test: platform/chromium/compositing/img-layer-grow.html

* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::createTextureUpdater):

LayoutTests:

* platform/chromium/compositing/img-layer-grow-expected.png: Added.
* platform/chromium/compositing/img-layer-grow-expected.txt: Added.
* platform/chromium/compositing/img-layer-grow.html: Added.
* platform/chromium/compositing/resources/apple.jpg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[skia] not all convex paths are convex, so recompute convexity for the problematic...
reed@google.com [Tue, 10 Jan 2012 19:50:40 +0000 (19:50 +0000)]
[skia] not all convex paths are convex, so recompute convexity for the problematic ones
https://bugs.webkit.org/show_bug.cgi?id=75960

Reviewed by Stephen White.

No new tests.
See related chrome issue
http://code.google.com/p/chromium/issues/detail?id=108605

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::setPathFromConvexPoints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Unreviewed gardening.
senorblanco@chromium.org [Tue, 10 Jan 2012 19:47:28 +0000 (19:47 +0000)]
[chromium] Unreviewed gardening.

New baselines for SVG feColorMatrix tests after r104571.

* platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-offset-expected.png:
* platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-saturate-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Removed.
* platform/chromium-mac/svg/filters/feColorMatrix-saturate-expected.png: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
* platform/chromium-win/svg/filters/feColorMatrix-offset-expected.png:
* platform/chromium-win/svg/filters/feColorMatrix-saturate-expected.png:
* platform/chromium/test_expectations.txt:
* platform/mac/svg/filters/feColorMatrix-saturate-expected.txt: Added.
* svg/filters/feColorMatrix-saturate-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Remove old WebMimeRegistry.h forwarding header
jamesr@google.com [Tue, 10 Jan 2012 19:45:15 +0000 (19:45 +0000)]
[chromium] Remove old WebMimeRegistry.h forwarding header
https://bugs.webkit.org/show_bug.cgi?id=75979

Reviewed by Ryosuke Niwa.

This isn't needed any more.

* WebKit.gyp:
* public/platform/WebMimeRegistry.h: Removed.
* src/FrameLoaderClientImpl.cpp:
* src/PlatformSupport.cpp:
* src/WebMediaPlayerClientImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImprove keyboard navigation in layout test results
simon.fraser@apple.com [Tue, 10 Jan 2012 19:43:08 +0000 (19:43 +0000)]
Improve keyboard navigation in layout test results
https://bugs.webkit.org/show_bug.cgi?id=75901

Reviewed by Ojan Vafai.

Add support for keyboard shortcuts for navigating the list of tests,
and for flagging tests.

'i', 'k', 'k', and 'l' go foward, back, to first and to last, denoting
the current test with a red expand indicator.

'e', 'c' and 't' expand, collapse and toggle the current test.

'f' toggled a test as "flagged", which adds it to a copyable list
at the bottom of the document. The user can use flagging for whatever they want.

* fast/harness/resources/results-test.js:
(runTests):
(runTests.isCollapsed):
():
* fast/harness/results-expected.txt:
* fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[BlackBerry] Fix assertion failure in BackingStore::blitContents
commit-queue@webkit.org [Tue, 10 Jan 2012 19:38:09 +0000 (19:38 +0000)]
[BlackBerry] Fix assertion failure in BackingStore::blitContents
https://bugs.webkit.org/show_bug.cgi?id=75976

Prevent an assertion failure in BackingStore::blitContents by
checking that the srcRect of the transformation matrix is non empty.

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-01-10
Reviewed by Adam Treat.

Upstream BlackBerry port is not yet building and testable.

* blackberry/Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::blitContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/JavaScriptCore: Do not allow Array length to be set if it is non-configurable
barraclough@apple.com [Tue, 10 Jan 2012 19:27:46 +0000 (19:27 +0000)]
Source/JavaScriptCore: Do not allow Array length to be set if it is non-configurable
https://bugs.webkit.org/show_bug.cgi?id=75935

Reviewed by Sam Weinig.

Do not allow Array length to be set if it is non-configurable, and if the new
length is less than the old length then intervening properties should removed
in reverse order. Removal of properties should cease if an intervening indexed
property being removed is non-configurable.

* JavaScriptCore.exp:
    - Removed export for setLength.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncConcat):
    - JSArray::setLength now takes an ExecState*
(JSC::arrayProtoFuncSlice):
    - JSArray::setLength now takes an ExecState*
* runtime/JSArray.cpp:
(JSC::JSArray::defineOwnProperty):
    - JSArray::setLength now takes an ExecState*
(JSC::JSArray::put):
    - JSArray::setLength now takes an ExecState*
(JSC::compareKeysForQSort):
    - Keys extracted from the map can be stored as unsigneds.
(JSC::JSArray::getOwnPropertyNames):
    - Keys extracted from the map can be stored as unsigneds.
(JSC::JSArray::setLength):
    - Check lengthIsReadOnly(), rather than copying the entire map to iterate
      over to determine which keys to remove, instead just copy the keys from
      the map to a Vector. When inSparseMode sort the keys in the Vector so
      that we can remove properties in reverse order.
* runtime/JSArray.h:
    - JSArray::setLength now takes an ExecState*

Source/WebCore: Do not allow Array length to be set if it is non-configurable
https://bugs.webkit.org/show_bug.cgi?id=75935

Reviewed by Sam Weinig.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::deserialize):
    - remove unnecessary call to JSArray::setLength.

LayoutTests: rebaselining some canvas images
https://bugs.webkit.org/show_bug.cgi?id=75552

Patch by Elliot Poger <epoger@google.com> on 2012-01-10
Reviewed by Ryosuke Niwa.

* platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.png:
* platform/chromium-gpu-linux/fast/canvas/quadraticCurveTo-expected.png:
* platform/chromium-gpu-mac/fast/canvas/canvas-text-baseline-expected.png: Added.
* platform/chromium-gpu-mac/fast/canvas/quadraticCurveTo-expected.png: Added.
* platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png:
* platform/chromium-gpu-win/fast/canvas/quadraticCurveTo-expected.png:
* platform/chromium-mac-leopard/fast/canvas/quadraticCurveTo-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-lineWidth-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-text-baseline-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/canvas/quadraticCurveTo-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agorebaselining some canvas images
commit-queue@webkit.org [Tue, 10 Jan 2012 19:27:02 +0000 (19:27 +0000)]
rebaselining some canvas images
https://bugs.webkit.org/show_bug.cgi?id=75552

Patch by Elliot Poger <epoger@google.com> on 2012-01-10
Reviewed by Ryosuke Niwa.

* platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.png:
* platform/chromium-gpu-linux/fast/canvas/quadraticCurveTo-expected.png:
* platform/chromium-gpu-mac/fast/canvas/canvas-text-baseline-expected.png: Added.
* platform/chromium-gpu-mac/fast/canvas/quadraticCurveTo-expected.png: Added.
* platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png:
* platform/chromium-gpu-win/fast/canvas/quadraticCurveTo-expected.png:
* platform/chromium-mac-leopard/fast/canvas/quadraticCurveTo-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-lineWidth-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-text-baseline-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/canvas/quadraticCurveTo-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse SameValue to compare property descriptor values
barraclough@apple.com [Tue, 10 Jan 2012 19:22:54 +0000 (19:22 +0000)]
Use SameValue to compare property descriptor values
https://bugs.webkit.org/show_bug.cgi?id=75975

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Rather than strictEqual.

* runtime/JSArray.cpp:
(JSC::JSArray::defineOwnNumericProperty):
    - Missing configurablePresent() check.
* runtime/JSObject.cpp:
(JSC::JSObject::defineOwnProperty):
    - call sameValue.
* runtime/PropertyDescriptor.cpp:
(JSC::sameValue):
    - Moved from JSArray.cpp, fix NaN comparison.
(JSC::PropertyDescriptor::equalTo):
    - call sameValue.
* runtime/PropertyDescriptor.h:
    - Added declaration for sameValue.

LayoutTests:

* fast/js/array-defineOwnProperty-expected.txt:
* fast/js/script-tests/array-defineOwnProperty.js:
    - Add new test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Fix expectations for worker-script-error.html on Mac/Linux
tony@chromium.org [Tue, 10 Jan 2012 19:21:14 +0000 (19:21 +0000)]
[chromium] Fix expectations for worker-script-error.html on Mac/Linux
https://bugs.webkit.org/show_bug.cgi?id=75758

Reviewed by David Levin.

The Win results appear to apply to Mac and Linux as well.

* platform/chromium-win/fast/workers/worker-script-error-expected.txt: Removed.
* platform/chromium/fast/workers/worker-script-error-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Draw debug tile borders on composited layers
enne@google.com [Tue, 10 Jan 2012 18:59:16 +0000 (18:59 +0000)]
[chromium] Draw debug tile borders on composited layers
https://bugs.webkit.org/show_bug.cgi?id=75680

Reviewed by James Robinson.

Source/WebCore:

On tiled layers, draw debug borders on the tiles themselves. By
default, these are one pixel wide and transparent, so should be
unobtrusive but informative. They are triggered when the layer itself
would have a debug border via the existing flags.

Also, fix the drawDebugBorderQuad function to handle arbitrarily
positioned quads, not just full layer quads. Also, fix alpha issue
with debug borders.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawDebugBorderQuad):
* platform/graphics/chromium/cc/CCDebugBorderDrawQuad.cpp:
(WebCore::CCDebugBorderDrawQuad::CCDebugBorderDrawQuad):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::appendDebugBorderQuad):
(WebCore::CCLayerImpl::quadTransform):
(WebCore::CCLayerImpl::hasDebugBorders):
* platform/graphics/chromium/cc/CCLayerImpl.h:
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::appendQuads):

Source/WebKit/chromium:

As debug borders are not a CCSetting and are instead grabbed directly
from each graphics layer, modify the NonCompositedContentHost to say
that its graphics layer has debug borders if the page settings demand
it.

* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setShowDebugBorders):
(WebKit::NonCompositedContentHost::showDebugBorders):
* src/NonCompositedContentHost.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttp/tests/inspector/network-preflight-options.html is flaky on linux
vsevik@chromium.org [Tue, 10 Jan 2012 18:49:36 +0000 (18:49 +0000)]
http/tests/inspector/network-preflight-options.html is flaky on linux
https://bugs.webkit.org/show_bug.cgi?id=75917

Reviewed by Yury Semikhatsky.

* http/tests/inspector/network-preflight-options-expected.txt:
* http/tests/inspector/network-preflight-options.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Missing Implementation of Public InspectorDOMAgent Function
commit-queue@webkit.org [Tue, 10 Jan 2012 18:44:41 +0000 (18:44 +0000)]
Web Inspector: Missing Implementation of Public InspectorDOMAgent Function
https://bugs.webkit.org/show_bug.cgi?id=75759

Follow-up: Remove the unused method. Keep the setter private.

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-01-10
Reviewed by Pavel Feldman.

* inspector/InspectorDOMAgent.cpp:
* inspector/InspectorDOMAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed, follow up to r104586: fix assertion within the loop.
pfeldman@chromium.org [Tue, 10 Jan 2012 18:23:13 +0000 (18:23 +0000)]
Not reviewed, follow up to r104586: fix assertion within the loop.

* inspector/DOMEditor.cpp:
(WebCore::DOMEditor::patchChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: support helpText() in DumpRenderTree
mario@webkit.org [Tue, 10 Jan 2012 18:05:45 +0000 (18:05 +0000)]
AX: support helpText() in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=40193

Unreviewed. Remove no longer needed GTK-specific expectation.

* platform/gtk/accessibility/aria-describedby-on-input-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9328684> and https://bugs.webkit.org/show_bug.cgi?id=62764
beidson@apple.com [Tue, 10 Jan 2012 17:57:42 +0000 (17:57 +0000)]
<rdar://problem/9328684> and https://bugs.webkit.org/show_bug.cgi?id=62764
Frequent crashes due to null frame below ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache

Reviewed by Maciej Stachowiak.

This is a non-reproducible high volume crash, so no test :(.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::stopLoading): Don't re-run actual "stop loading" logic if the document loader is already
  stopping loading. Also add an ASSERT that might catch cases where new loads may have been started while old loads
  were being stopped.
(WebCore::DocumentLoader::detachFromFrame): Be conservative and stop loading when we detach a document loader from a frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed: fixing the Mac build.
pfeldman@chromium.org [Tue, 10 Jan 2012 17:49:05 +0000 (17:49 +0000)]
Not reviewed: fixing the Mac build.

* inspector/DOMEditor.cpp:
(WebCore::DOMEditor::patchChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: support helpText() in DumpRenderTree
mario@webkit.org [Tue, 10 Jan 2012 17:44:21 +0000 (17:44 +0000)]
AX: support helpText() in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=40193

Reviewed by Chris Fleizach.

Source/WebKit/gtk:

Add support for retrieving WebCore's AccessibilityObject's
helpText from the GTK DumpRenderTree.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::accessibilityHelpText): Returns result
of calling to helpText() over the core accessibility object's.
* WebCoreSupport/DumpRenderTreeSupportGtk.h:

Tools:

* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::helpText): Implemented.

LayoutTests:

Unskip tests now passing.

* accessibility/aria-describedby-on-input-expected.txt: Moved from
LayoutTests/platform/mac/accessibility.
* platform/gtk/Skipped: Unskip tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] platform/gtk/accessibility/unknown-roles-not-exposed.html is flaky
mario@webkit.org [Tue, 10 Jan 2012 17:41:18 +0000 (17:41 +0000)]
[GTK] platform/gtk/accessibility/unknown-roles-not-exposed.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=74493

Unreviewed. Unskipping passing test.

* platform/gtk/test_expectations.txt: Unskip test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoElements can appear over fullscreen video
jer.noble@apple.com [Tue, 10 Jan 2012 17:38:34 +0000 (17:38 +0000)]
Elements can appear over fullscreen video
https://bugs.webkit.org/show_bug.cgi?id=75913

Reviewed by Simon Fraser.

Source/WebCore:

No new tests; updated fullscreen/full-screen-zIndex.html to trigger error condition.

RenderFullScreenPlaceholder inherits the pre-fullscreen element's style, causing a stacking
context to be created.  Instead of making the placeholder the parent of the RenderFullScreen
object, make the two renderers siblings.  Then the stacking context created by the placeholder
will not affect the z-ordering of the RenderFullScreen.

* rendering/RenderFullScreen.cpp:
(RenderFullScreen::wrapRenderer):
(RenderFullScreen::unwrapRenderer):
(RenderFullScreen::createPlaceholder):

LayoutTests:

Update the test to trigger the error condition in the linked bug.

* fullscreen/full-screen-zIndex.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling
jchaffraix@webkit.org [Tue, 10 Jan 2012 17:34:33 +0000 (17:34 +0000)]
REGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling
https://bugs.webkit.org/show_bug.cgi?id=67100

Unreviewed, chromium rebaselining after r104575.

The SL baseline for scroll-with-transform-layer.html is missing some scroll thumbs (http://webkit.org/b/75969).

* platform/chromium-linux/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
* platform/chromium-linux/fast/layers/scroll-with-transform-layer-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/layers/scroll-with-transform-layer-expected.png: Added.
* platform/chromium-win/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
* platform/chromium-win/fast/layers/scroll-with-transform-layer-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening. Remove png and txt expected files for reftests.
ossy@webkit.org [Tue, 10 Jan 2012 17:19:08 +0000 (17:19 +0000)]
[Qt] Unreviewed gardening. Remove png and txt expected files for reftests.

* platform/qt/css2.1/20110323/border-conflict-element-016-expected.png: Removed.
* platform/qt/css2.1/20110323/border-conflict-element-016-expected.txt: Removed.
* platform/qt/css2.1/20110323/border-conflict-element-017-expected.png: Removed.
* platform/qt/css2.1/20110323/border-conflict-element-017-expected.txt: Removed.
* platform/qt/css2.1/20110323/border-conflict-element-037-expected.png: Removed.
* platform/qt/css2.1/20110323/border-conflict-element-037-expected.txt: Removed.
* platform/qt/css2.1/20110323/border-conflict-element-038-expected.png: Removed.
* platform/qt/css2.1/20110323/border-conflict-element-038-expected.txt: Removed.
* platform/qt/fast/writing-mode/margins-expected.png: Removed.
* platform/qt/fast/writing-mode/margins-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: add "free flow DOM editing" experiment.
pfeldman@chromium.org [Tue, 10 Jan 2012 17:01:05 +0000 (17:01 +0000)]
Web Inspector: add "free flow DOM editing" experiment.
https://bugs.webkit.org/show_bug.cgi?id=75955

This change enables HTML editing from Resources panel experiment.

Reviewed by Yury Semikhatsky.

* CMakeLists.txt:
* English.lproj/localizedStrings.js:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/DOMEditor.cpp: Added.
(WebCore::DOMEditor::DOMEditor):
(WebCore::DOMEditor::~DOMEditor):
(WebCore::DOMEditor::patch):
(WebCore::DOMEditor::NodeDigest::NodeDigest):
(WebCore::DOMEditor::patchElement):
(WebCore::DOMEditor::patchNode):
(WebCore::DOMEditor::patchChildren):
(WebCore::addStringToSHA1):
(WebCore::DOMEditor::createNodeDigest):
* inspector/DOMEditor.h: Added.
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setOuterHTML):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent):
(WebInspector.DOMModelResourceBinding):
(WebInspector.DOMModelResourceBinding.prototype.setContent):
(WebInspector.DOMModelResourceBinding.prototype.canSetContent):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Shift PathSkia to use Skia's new RawIter
commit-queue@webkit.org [Tue, 10 Jan 2012 16:54:29 +0000 (16:54 +0000)]
[Chromium] Shift PathSkia to use Skia's new RawIter
https://bugs.webkit.org/show_bug.cgi?id=75703

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-10
Reviewed by Nikolas Zimmermann.

Source/WebCore:

No new tests required - covered by existing tests.

* platform/graphics/Path.h: Added comments ont he return values from iteration.
* platform/graphics/skia/PathSkia.cpp:
(WebCore::Path::apply): Switched to SkPath::RawIter

LayoutTests:

* platform/chromium/test_expectations.txt: Updated epxectation for
  tests that may change after this modification.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r104572.
ossy@webkit.org [Tue, 10 Jan 2012 16:47:59 +0000 (16:47 +0000)]
Unreviewed, rolling out r104572.
http://trac.webkit.org/changeset/104572
https://bugs.webkit.org/show_bug.cgi?id=75967

It broke zillion tests (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-10

Tools:

* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::EventSender):
(EventSender::sendOrQueueEvent):
(EventSender::replaySavedEvents):
(EventSender::eventFilter):
* DumpRenderTree/qt/EventSenderQt.h:

LayoutTests:

* platform/qt-wk1/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Clean up test expectations for mac.
jknotten@chromium.org [Tue, 10 Jan 2012 16:45:55 +0000 (16:45 +0000)]
[Chromium] Clean up test expectations for mac.
https://bugs.webkit.org/show_bug.cgi?id=75966

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed potential Mac WK2 build fix.
kenneth@webkit.org [Tue, 10 Jan 2012 16:44:01 +0000 (16:44 +0000)]
Unreviewed potential Mac WK2 build fix.

* UIProcess/PageClient.h: forward declare WebGestureEvent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. WebInspector: Remove unnecessary logging from the test.
loislo@chromium.org [Tue, 10 Jan 2012 16:39:10 +0000 (16:39 +0000)]
Unreviewed. WebInspector: Remove unnecessary logging from the test.

* inspector/first-open-resources.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Restore test that was removed during migration from LayoutTests folder.
loislo@chromium.org [Tue, 10 Jan 2012 16:31:28 +0000 (16:31 +0000)]
Unreviewed. Restore test that was removed during migration from LayoutTests folder.

* inspector/first-open-resources.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline fast/text/unicode-variation-selector.html following r104545.
jknotten@chromium.org [Tue, 10 Jan 2012 16:23:54 +0000 (16:23 +0000)]
Rebaseline fast/text/unicode-variation-selector.html following r104545.

* platform/chromium-win/fast/text/unicode-variation-selector-expected.png:
* platform/chromium/fast/text/unicode-variation-selector-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Use SkFontHost::GetUnitsPerEm instead of advanced type
peter@chromium.org [Tue, 10 Jan 2012 16:03:44 +0000 (16:03 +0000)]
[Chromium] Use SkFontHost::GetUnitsPerEm instead of advanced type
metrics for Android in FontPlatformData
https://bugs.webkit.org/show_bug.cgi?id=75702

Reviewed by Stephen White.

Since Skia for Android doesn't implement advanced type metric routines,
use an alternative method to calculate the number of font units for an
em size. This will be exercized by existing layout tests, as it's being
used by the ComplexTextController.

* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::emSizeInFontUnits):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, inspector style fix.
vsevik@chromium.org [Tue, 10 Jan 2012 15:59:16 +0000 (15:59 +0000)]
Unreviewed, inspector style fix.

Web Inspector: elements tree is shifted 12px to the right.
https://bugs.webkit.org/show_bug.cgi?id=75609

* inspector/front-end/elementsPanel.css:
(#elements-content):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix style errors in CSSParser.cpp
zherczeg@webkit.org [Tue, 10 Jan 2012 15:58:31 +0000 (15:58 +0000)]
Fix style errors in CSSParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=75854

Reviewed by Nikolas Zimmermann.

Minor style fixes.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseShadow):
(WebCore::isBorderImageRepeatKeyword):
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):
(WebCore::filterInfoForName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling
jchaffraix@webkit.org [Tue, 10 Jan 2012 15:48:40 +0000 (15:48 +0000)]
REGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling
https://bugs.webkit.org/show_bug.cgi?id=67100

Reviewed by Dan Bernstein.

Source/WebCore:

Tests: fast/layers/scroll-with-transform-composited-layer.html
       fast/layers/scroll-with-transform-layer.html

The regression came from a previous optimization that was wrongly kept after r93614.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
Remove the early return for transformed layer. This change worked as we used
to call updateLayerPositions from scrollTo which would call updateLayerPosition on
all our descendants. After r93614, this is no longer the case and we explicitely need
to call updateLayerPosition on our descendants from updateLayerPositionsAfterScroll.

LayoutTests:

Added 2 tests for scrolling inside a transformed layer (either composited
or not). Unfortunately due to some platform-specifics differences, they are
not ref-tests.

* fast/layers/scroll-with-transform-composited-layer-expected.txt: Added.
* fast/layers/scroll-with-transform-composited-layer.html: Added.
* fast/layers/scroll-with-transform-layer-expected.txt: Added.
* fast/layers/scroll-with-transform-layer.html: Added.
* platform/mac-snowleopard/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
* platform/mac-snowleopard/fast/layers/scroll-with-transform-layer-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Fix compilation with ENABLE_WEB_AUDIO=0
peter@chromium.org [Tue, 10 Jan 2012 15:47:26 +0000 (15:47 +0000)]
[Chromium] Fix compilation with ENABLE_WEB_AUDIO=0
https://bugs.webkit.org/show_bug.cgi?id=75957

Reviewed by Tony Gentilcore.

Revision 104502 broke Chromium compilation for platforms which disable
the Web Audio API. All references to m_audioSourceProvider should be
guarded with the ENABLE(WEB_AUDIO) conditional.

* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::load):
(WebKit::WebMediaPlayerClientImpl::loadInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out an accidental commit r104569.
ossy@webkit.org [Tue, 10 Jan 2012 15:35:59 +0000 (15:35 +0000)]
Unreviewed, rolling out an accidental commit r104569.

* Shared/EditorState.cpp:
(WebKit::EditorState::encode):
(WebKit::EditorState::decode):
* Shared/EditorState.h:
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::inputMethodQuery):
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] fast/events/dont-loose-last-event test fails on WK1
commit-queue@webkit.org [Tue, 10 Jan 2012 15:32:31 +0000 (15:32 +0000)]
[Qt] fast/events/dont-loose-last-event test fails on WK1
https://bugs.webkit.org/show_bug.cgi?id=73894

Patch by Hugo Parente Lima <hugo.lima@openbossa.org> on 2012-01-10
Reviewed by Simon Hausmann.

Tools:

Empty the entire event queue when requested besides using
sendEvent instead of postEvent to make sure all events were
delivered.
This commit also removes not working DRT code to handle drag and drop,
for more refs see: https://bugs.webkit.org/show_bug.cgi?id=31332

* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::EventSender):
(EventSender::sendOrQueueEvent):
(EventSender::replaySavedEvents):
* DumpRenderTree/qt/EventSenderQt.h:

LayoutTests:

Remove fast/events/dont-loose-last-event from qt-wk1 skip list.

* platform/qt-wk1/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Chrome/Mac build.
senorblanco@chromium.org [Tue, 10 Jan 2012 15:32:17 +0000 (15:32 +0000)]
Fix Chrome/Mac build.

Build fix; unreviewed.

* platform/graphics/filters/skia/FEColorMatrixSkia.cpp:
(WebCore::luminanceToAlphaMatrix):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed potential Mac WK2 build fix.
kenneth@webkit.org [Tue, 10 Jan 2012 15:25:20 +0000 (15:25 +0000)]
Unreviewed potential Mac WK2 build fix.

* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::doneWithGestureEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWIP
kenneth@webkit.org [Tue, 10 Jan 2012 15:20:10 +0000 (15:20 +0000)]
WIP

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Added smart pointers to Ewk_View_Paint_Context class and done minor refactoring.
commit-queue@webkit.org [Tue, 10 Jan 2012 15:17:50 +0000 (15:17 +0000)]
[EFL] Added smart pointers to Ewk_View_Paint_Context class and done minor refactoring.
https://bugs.webkit.org/show_bug.cgi?id=75837

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2012-01-10
Reviewed by Ryosuke Niwa.

Changed graphicContext raw pointer to OwnPtr smart pointer.
Renamed cr to cairo and made it a RefPtr.

* ewk/ewk_view.cpp:
(ewk_view_paint_context_new): Adjust to auto pointers use.
(ewk_view_paint_context_free): Removed explicit raw pointers delete.
Adjust to auto pointers use:
(ewk_view_paint_context_save):
(ewk_view_paint_context_restore):
(ewk_view_paint_context_clip):
(ewk_view_paint_context_paint):
(ewk_view_paint_context_paint_contents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Add font-related API tests for QWebPreferences
commit-queue@webkit.org [Tue, 10 Jan 2012 15:14:05 +0000 (15:14 +0000)]
[Qt][WK2] Add font-related API tests for QWebPreferences
https://bugs.webkit.org/show_bug.cgi?id=75739

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-10
Reviewed by Zoltan Herczeg.

* UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
* UIProcess/API/qt/tests/qmltests/common/font-preferences.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: [Skia] Switch FEColorMatrix to use a skia-based implementation when
senorblanco@chromium.org [Tue, 10 Jan 2012 15:01:07 +0000 (15:01 +0000)]
Source/WebCore: [Skia] Switch FEColorMatrix to use a skia-based implementation when
compiling with USE(SKIA).  This change will also switch the software
implementation of FEGaussianBlur to the skia implementation (ie.,
it removes the acceleration check).
https://bugs.webkit.org/show_bug.cgi?id=75582

Reviewed by Dirk Schulze.

Covered by svg/W3C-SVG-1.1/filters-color-01-b.svg and friends (will
need a rebaseline).

* WebCore.gypi:
Add FEColorMatrixSkia.cpp to the build.
* platform/graphics/filters/FEColorMatrix.h:
Add platformApplySkia().
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplySoftware):
Remove skia-specific code from FEGaussianBlur::platformApplySoftware().
* platform/graphics/filters/FEGaussianBlur.h:
Make platformApplySkia() virtual, and put it behind #if USE(SKIA).
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::apply):
Call out to platformApplySkia(), or fall back to
platformApplySoftware().
* platform/graphics/filters/FilterEffect.h:
Add platformApplySkia().
* platform/graphics/filters/skia/FEColorMatrixSkia.cpp: Added.
(WebCore::saturateMatrix):
(WebCore::hueRotateMatrix):
(WebCore::luminanceToAlphaMatrix):
(WebCore::FEColorMatrix::platformApplySkia):
Process color matrix effect, by calling out to generic matrix
version of SkColorMatrixFilter.
* platform/graphics/filters/skia/FEGaussianBlurSkia.cpp:
(WebCore::FEGaussianBlur::platformApplySkia):
Change the signature of FEGaussianBlur::platformApplySkia to be an
override of the new FilterEffect base class version.

LayoutTests: [chomium] Mark svg FEColorMatrix tests as needing new baselines.
https://bugs.webkit.org/show_bug.cgi?id=75582

Reviewed by Dirk Schulze.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix failing WK2 layout tests after r104557
hausmann@webkit.org [Tue, 10 Jan 2012 14:18:38 +0000 (14:18 +0000)]
[Qt] Fix failing WK2 layout tests after r104557

Reviewed by Kenneth Rohde Christiansen.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent): Add missing break to not
handle mouseDown as gesture event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed buildfix.
kenneth@webkit.org [Tue, 10 Jan 2012 14:13:44 +0000 (14:13 +0000)]
Unreviewed buildfix.

* UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: fix DebuggerPresentationModel::uiSourceCodes - do not iterate
pfeldman@chromium.org [Tue, 10 Jan 2012 13:49:04 +0000 (13:49 +0000)]
Web Inspector: fix DebuggerPresentationModel::uiSourceCodes - do not iterate
over same raw source code multiple times.
https://bugs.webkit.org/show_bug.cgi?id=75953

Reviewed by Yury Semikhatsky.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Add getter for Ewk_JS_Object::view.
kubo@profusion.mobi [Tue, 10 Jan 2012 13:46:54 +0000 (13:46 +0000)]
[EFL] Add getter for Ewk_JS_Object::view.
https://bugs.webkit.org/show_bug.cgi?id=75868

Reviewed by Andreas Kling.

So far the view associated with a given JS object was a private
property only accessible to ewk itself. This does not make much sense,
as one often needs to know which view a certain method was invoked
from, for example.

* ewk/ewk_js.cpp:
(ewk_js_object_view_get):
* ewk/ewk_js.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed gardening.
ossy@webkit.org [Tue, 10 Jan 2012 13:44:50 +0000 (13:44 +0000)]
Unreviewed gardening.

* platform/gtk/Skipped: Remove non-existent fast/dom/htmlcollection-zombies.html.
* platform/qt-wk2/Skipped: Skip fast/loader/submit-form-while-parsing-2.html, because it fails intermittently.
* platform/qt/Skipped: Remove non-existent fast/dom/htmlcollection-zombies.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Enable CSS_FILTERS in Qt build
ossy@webkit.org [Tue, 10 Jan 2012 13:44:02 +0000 (13:44 +0000)]
[Qt] Enable CSS_FILTERS in Qt build
https://bugs.webkit.org/show_bug.cgi?id=75777

Source/WebCore:

Enable CSS_FILTERS and unskip the tests.

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-01-10
Reviewed by Kenneth Rohde Christiansen.

Filter tests are now unskipped for Qt.

* Target.pri: add missing files to build.

Source/WebKit/qt:

For now, disallow compositing for filters. We will change that trigger when
https://bugs.webkit.org/show_bug.cgi?id=75778 is implemented.

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-01-10
Reviewed by Kenneth Rohde Christiansen.

* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::allowedCompositingTriggers):

Tools:

Add the CSS_FILTERS feature flag to Qt.

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-01-10
Reviewed by Kenneth Rohde Christiansen.

* qmake/mkspecs/features/features.prf:

LayoutTests:

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-01-10
Reviewed by Kenneth Rohde Christiansen.

Platform specific expected results tweaked by Csaba Osztrogonác.

* platform/qt/Skipped: Unskip filter tests that work.
* platform/qt/css3/filters/*: Added Qt specific results.
* platform/qt/fast/dom/Window/window-properties.html: Updated.
* platform/qt/fast/dom/Window/window-property-descriptors.html: Updated.
* platform/qt/fast/dom/prototype-inheritance-2.html: Updated.
* platform/qt/fast/js/global-constructors.html: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed -Werror build fix.
hausmann@webkit.org [Tue, 10 Jan 2012 13:36:26 +0000 (13:36 +0000)]
[Qt] Unreviewed -Werror build fix.

* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Remove dependency to uitools
hausmann@webkit.org [Tue, 10 Jan 2012 13:34:08 +0000 (13:34 +0000)]
[Qt] Remove dependency to uitools
https://bugs.webkit.org/show_bug.cgi?id=75952

Reviewed by Tor Arne Vestbø.

QUiLoader is used for creating QLabel/QProgressBar widgets for
a layout test, to verify some widget embedding feature. Unfortunately
in Qt 5, QUiLoader is part of qttools, which depends on webkit, which
depends on qttools. Since we don't really _need_ QUiLoader for our tests,
let's break the circular dependency.

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::createPlugin):
* QtTestBrowser/QtTestBrowser.pro:
* QtTestBrowser/launcherwindow.h:
* QtTestBrowser/webpage.cpp:
(WebPage::createPlugin):
* qmake/mkspecs/features/minimal_qt.prf:
* qmake/mkspecs/features/uitools.prf: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement the input panel request/close handling
kenneth@webkit.org [Tue, 10 Jan 2012 13:25:27 +0000 (13:25 +0000)]
Implement the input panel request/close handling

Reviewed by Simon Hausmann.

With the current patch we only request the input panel as a
response to a user tap. Close requests, on the other hand,
is always respected.

As multiple show/hide requests can happen while processing
the tap gesture, input panel visibility changes are postponed
until the tap gesture ends.

The input panel will become visible if the WebCore editor is
in canEdit mode and thus work for content-editable, meaning
that it won't close the input panel if you click on a link
(eg. editCommand) while in content-editable mode.

* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleGestureEvent):
(WebKit::WebPageProxy::editorStateChanged):
(WebKit::WebPageProxy::didReceiveEvent):

    Add a new doneWithGestureEvent method to the PageClient
    as well as add a updateTextInputState similar to that of mac.

* UIProcess/WebPageProxy.h:
* UIProcess/qt/QtPageClient.cpp:
(QtPageClient::updateTextInputState):
(QtPageClient::doneWithGestureEvent):

    Propagate the new events to the Qt EventHandler.

* UIProcess/qt/QtPageClient.h:
* UIProcess/qt/QtWebPageEventHandler.cpp:
* UIProcess/qt/QtWebPageEventHandler.h:
(QtWebPageEventHandler::QtWebPageEventHandler):
(QtWebPageEventHandler::handleSingleTapEvent):
(setInputPanelVisible):
(QtWebPageEventHandler::updateTextInputState):
(QtWebPageEventHandler::doneWithGestureEvent):

    Handle postponing of the input method visibility change
    and the actual showing/hiding.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104557 268f45cc-cd09-0410-ab3c-d52691b4dbfc