WebKit-https.git
10 years agoVersioning.
lforschler@apple.com [Sat, 23 Apr 2011 00:23:45 +0000 (00:23 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Sat, 23 Apr 2011 00:12:23 +0000 (00:12 +0000)]
2011-04-22  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Ryosuke Niwa.

        move caret by word in visual order returns wrong result when caret itself is at word boundary.
        https://bugs.webkit.org/show_bug.cgi?id=58504.

        Add test case to test moving left/right by word visually on every character position.
        Remove a specific test added before for testing a specific code path since the test case
        is covered now.

        * editing/selection/move-by-word-visually-expected.txt:
        * editing/selection/move-by-word-visually.html:
2011-04-22  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Ryosuke Niwa.

        move caret by word in visual order returns wrong result when caret itself is at word boundary.
        https://bugs.webkit.org/show_bug.cgi?id=58504.

        positionBeforeNextWord should take care that the current position is after current word.
        positionAfterPreviousWord should take care that the current positin is before current word.

        * editing/visible_units.cpp:
        (WebCore::positionBeforeNextWord):
        (WebCore::positionAfterPreviousWord):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Sat, 23 Apr 2011 00:08:31 +0000 (00:08 +0000)]
2011-04-22  Xiaomei Ji  <xji@chromium.org>

        Rebaseline after r84655.

        * platform/chromium-linux/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
        * platform/chromium-mac-leopard/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
        * platform/chromium-mac/fast/block/positioning/rtl-fixed-positioning-expected.checksum: Added.
        * platform/chromium-mac/fast/block/positioning/vertical-rl: Added.
        * platform/chromium-mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.checksum: Added.
        * platform/chromium-mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Fri, 22 Apr 2011 23:59:05 +0000 (23:59 +0000)]
2011-04-22  Xiaomei Ji  <xji@chromium.org>

        Rebase after r84659.

        * platform/chromium-linux/editing/deleting/table-cells-expected.png:
        * platform/chromium-linux/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
        * platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.png:
        * platform/chromium-mac-leopard/editing/deleting/table-cells-expected.png:
        * platform/chromium-mac-leopard/fast/inline-block/14498-positionForCoordinates-expected.png:
        * platform/chromium-mac/editing/deleting/table-cells-expected.png: Added.
        * platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.png: Added.
        * platform/chromium-win/editing/deleting/table-cells-expected.png:
        * platform/chromium-win/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
        * platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 22 Apr 2011 23:54:22 +0000 (23:54 +0000)]
2011-04-22  Eric Seidel  <eric@webkit.org>

        Reviewed by Eric Carlson.

        Flaky Test: media/invalid-media-url-crash.html
        https://bugs.webkit.org/show_bug.cgi?id=51138

        Add one more test to the list of known crashers from rdar://9054715.

        * platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Fri, 22 Apr 2011 23:52:44 +0000 (23:52 +0000)]
2011-04-19  Jer Noble  <jer.noble@apple.com>

        Reviewed by Daniel Bates.

        Full Screen from within an <iframe> does not cause <iframe> to resize.
        https://bugs.webkit.org/show_bug.cgi?id=58638

        * fullscreen/full-screen-frameset-expected.txt: Added.
        * fullscreen/full-screen-frameset.html: Added.
        * fullscreen/content/inner.html: Added.
        * fullscreen/full-screen-iframe-allowed-expected.txt: Updated.
        * fullscreen/full-screen-iframe-allowed.html: Add a button with which to trigger
            full screen mode in Safari.
        * fullscreen/full-screen-iframe-not-allowed-expected.txt: Updated.
        * fullscreen/full-screen-iframe-not-allowed.html: Ditto.
        * fullscreen/resources/allowed.html: Added.
        * fullscreen/resources/inner.html: Added.
2011-04-19  Jer Noble  <jer.noble@apple.com>

        Reviewed by Daniel Bates.

        Full Screen from within an <iframe> does not cause <iframe> to resize.
        https://bugs.webkit.org/show_bug.cgi?id=58638

        Tests: fullscreen/full-screen-frameset.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Add the
            -webkit-full-screen pseudo class to frame elements which contain
            full screen elements.
        * css/fullscreen.css:
        (iframe:-webkit-full-screen): Add iframe-specific styling rules.
        * dom/Document.cpp:
        (WebCore::Document::setContainsFullScreenElementRecursively): Added.  Walk up each
            successive document owner element, calling setContainsFullScreenElement() if
            owner is a frame element.
        (WebCore::Document::fullScreenIsAllowedForElement): Use the new Element::isFrameElementBase
            call instead of checking the element's tag name.
        (WebCore::Document::webkitWillEnterFullScreenForElement): Mark any containing
            iframes as containing a full screen element.
        (WebCore::Document::webkitWillExitFullScreenForElement): Ditto.
        * dom/Element.h:
        (WebCore::Element::isFrameElementBase): Added.
        * html/HTMLFrameElement.h:
        (WebCore::HTMLFrameElement::allowFullScreen): Disable full screen from within
            HTMLFrameElements.
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::setContainsFullScreenElement): Added.
        * html/HTMLFrameElementBase.h:
        (WebCore::HTMLFrameElementBase::containsFullScreenElement): Added.
        (WebCore::HTMLFrameElementBase::isFrameElementBase): Added.
2011-04-19  Jer Noble  <jer.noble@apple.com>

        Reviewed by Daniel Bates.

        Full Screen from within an <iframe> does not cause <iframe> to resize.
        https://bugs.webkit.org/show_bug.cgi?id=58638

        Tests: fullscreen/full-screen-frameset-allowed.html
               fullscreen/full-screen-frameset-not-allowed.html

        Return the _element's document instead of the WKView's document, which
        will be different in the case of elements within <iframe>s.

        * WebView/WebFullScreenController.mm:
        (-[WebFullScreenController _document]):
2011-04-19  Jer Noble  <jer.noble@apple.com>

        Reviewed by Daniel Bates.

        Full Screen from within an <iframe> does not cause <iframe> to resize.
        https://bugs.webkit.org/show_bug.cgi?id=58638

        Tests: fullscreen/full-screen-frameset-allowed.html
               fullscreen/full-screen-frameset-not-allowed.html

        * UIProcess/mac/WKFullScreenWindowController.mm:
        (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Cancel the background animation
            if the full screen animation finishes first.
        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
        (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): m_fullScreenRootLayer was uninitialized.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 59254 - DFG JIT - retain VariableRecords for args/var in all basic blocks,
barraclough@apple.com [Fri, 22 Apr 2011 23:38:53 +0000 (23:38 +0000)]
Bug 59254 - DFG JIT - retain VariableRecords for args/var in all basic blocks,
such that this information is available for DCE.  Also, since this enlarges the
size of BasicBlock, make Graph hold a vector of pointers to basic blocks, not a
vector of blocks.

Reviewed by Geoffrey Garen.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::setupPredecessors):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::VariableRecord::VariableRecord):
(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::BasicBlock::getBytecodeBegin):
(JSC::DFG::Graph::blockIndexForBytecodeOffset):
(JSC::DFG::Graph::blockForBytecodeOffset):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 22 Apr 2011 23:35:44 +0000 (23:35 +0000)]
2011-04-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CommitQueue should remember the expected failures from patch to patch
        https://bugs.webkit.org/show_bug.cgi?id=59253

        Previously, we stored the set of expected failures on the task object,
        which meant the commit-queue forgot about them after each patch.  This
        patch moves them to the CommitQueue object so they will have a longer
        lifetime.

        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
        * Scripts/webkitpy/tool/bot/patchanalysistask.py:
        * Scripts/webkitpy/tool/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 22 Apr 2011 23:29:02 +0000 (23:29 +0000)]
2011-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Brian Weinstein.

        WebKit2: Implement JavaScript unresponsiveness timer/callbacks
        https://bugs.webkit.org/show_bug.cgi?id=59248

        Stub out shouldInterruptJavaScript callbacks.

        * MiniBrowser/mac/BrowserWindowController.m:
        (-[BrowserWindowController awakeFromNib]):
        * MiniBrowser/win/BrowserView.cpp:
        (BrowserView::create):
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::createOtherPage):
        (WTR::TestController::initialize):
2011-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Brian Weinstein.

        WebKit2: Implement JavaScript unresponsiveness callback
        https://bugs.webkit.org/show_bug.cgi?id=59248

        Add support for suspending JavaScript in response to a callback.

        * UIProcess/API/C/WKPage.h:
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::QWKPage):
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::shouldInterruptJavaScript):
        * UIProcess/WebPageProxy.h:
        * UIProcess/WebPageProxy.messages.in:
        * UIProcess/WebUIClient.cpp:
        (WebKit::WebUIClient::shouldInterruptJavaScript):
        * UIProcess/WebUIClient.h:
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::shouldInterruptJavaScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Fri, 22 Apr 2011 23:11:45 +0000 (23:11 +0000)]
2011-04-22  Michael Saboff  <msaboff@apple.com>

        Reviewed by Maciej Stachowiak.

        Creating copy of ContainerNode's when inserting or removing is inefficient
        https://bugs.webkit.org/show_bug.cgi?id=58695

        Eliminated node copying in willRemove() and insertedIntoDocument().

        No new tests as this is a more efficient implementation of
        existing code that is covered by existing tests.

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::willRemove): Changed method to use
        RefPtr<> to protect against modification during removal.
        (WebCore::ContainerNode::insertedIntoDocument): Changed method to use
        RefPtr<> and two other deletion checks to protect against
        modification during insertion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoErrk, build fix.
barraclough@apple.com [Fri, 22 Apr 2011 23:09:12 +0000 (23:09 +0000)]
Errk, build fix.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 22 Apr 2011 23:04:12 +0000 (23:04 +0000)]
2011-04-22  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        We have an autogenerator, so use it
        https://bugs.webkit.org/show_bug.cgi?id=59247

        * bindings/js/JSCSSRuleCustom.cpp:
        * bindings/js/JSCSSRuleListCustom.cpp:
        * bindings/js/JSCSSStyleDeclarationCustom.cpp:
        * bindings/js/JSCSSValueCustom.cpp:
        * bindings/js/JSCanvasRenderingContextCustom.cpp:
        * bindings/js/JSDOMImplementationCustom.cpp:
        * bindings/js/JSDOMStringMapCustom.cpp:
        * bindings/js/JSHTMLCollectionCustom.cpp:
        * bindings/js/JSNamedNodeMapCustom.cpp:
        * bindings/js/JSNodeCustom.h:
        * bindings/js/JSNodeListCustom.cpp:
        * bindings/js/JSStyleSheetCustom.cpp:
        * bindings/js/JSStyleSheetListCustom.cpp: Removed repetitive hand-written code.

        * bindings/scripts/CodeGeneratorJS.pm: Augmented autogenerator to do the job.

        * css/CSSRule.idl:
        * css/CSSRuleList.idl:
        * css/CSSStyleDeclaration.idl:
        * css/CSSValue.idl:
        * css/MediaList.idl:
        * css/StyleSheet.idl:
        * css/StyleSheetList.idl:
        * dom/DOMImplementation.idl:
        * dom/DOMStringMap.idl:
        * dom/NamedNodeMap.idl:
        * dom/Node.idl:
        * dom/NodeList.idl:
        * html/DOMTokenList.idl:
        * html/HTMLCollection.idl:
        * html/canvas/CanvasRenderingContext.idl: Updated attributes to plug into
        the autogenerator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Dan Bernstein <mitz@apple.com>
jer.noble@apple.com [Fri, 22 Apr 2011 23:01:04 +0000 (23:01 +0000)]
2011-04-22  Dan Bernstein  <mitz@apple.com>

        Reviewed by Sam Weinig.

        Paint the bounding rect of the dirty region instead of individual rectangles when the region
        covers at least 3/4 of its bounds.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::shouldPaintBoundsRect): Use floating point math so that the logic that was supposed to
        achieve this actually works.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Fri, 22 Apr 2011 22:47:55 +0000 (22:47 +0000)]
2011-04-22  Daniel Bates  <dbates@webkit.org>

        Reviewed by Csaba Osztrogonác.

        webkit-patch land hangs if svn prompts for credentials
        https://bugs.webkit.org/show_bug.cgi?id=31500

        Make has_authorization_for_realm() return True only if there exists a credentials file
        that contains either the word "password" or "passtype". We assume that these words don't
        coincide with the actual credential data (e.g. a person's username is "password").

        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/common/checkout/scm_unittest.py:
          - Added test cases:
            test_has_authorization_for_realm_using_credentials_with_passtype(),
            test_has_authorization_for_realm_using_credentials_with_password(),
            test_not_have_authorization_for_realm_with_credentials_missing_password_and_passtype()
          - Renamed test_not_have_authorization_for_realm() to test_not_have_authorization_for_realm_when_missing_credentials_file()
            to better describe what it's testing.
          - Repurposed test_has_authorization_for_realm() to take realm and credential data to use
            and return the result of calling has_authorization_for_realm() so that the caller can
            assert the result; Renamed to _test_has_authorization_for_realm_using_credentials() to
            better reflect its new purpose.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Fri, 22 Apr 2011 22:45:39 +0000 (22:45 +0000)]
2011-04-22  Xiaomei Ji  <xji@chromium.org>

        Rebaseline after r84659.

        * platform/mac-wk2/fast/forms: Added.
        * platform/mac-wk2/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
        * platform/win/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Fri, 22 Apr 2011 22:44:45 +0000 (22:44 +0000)]
2011-04-22  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Kent Tamura.

        Let the RenderTheme decide if an input type should have a spinner
        https://bugs.webkit.org/show_bug.cgi?id=59246

        Whether an input should have a spinner or not should
        be a UI decision made by the RenderTheme. Remove
        WebCore's default hasSpinButton values and defer
        to the RenderTheme.

        No change in functionality, covered by existing tests.

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::isRangeControl): expose isRangeControl
        for possible RenderTheme queries.
        * html/HTMLInputElement.h:

        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
        (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
        For both of these ask the render theme if the input should
        have a spinner.

        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::shouldHaveSpinButtonForInputElement):
        Steppable inputs (number, date, and range) but not range
        should have spinners. This does not change existing behavior.
        * rendering/RenderTheme.h:

        * dom/InputElement.h:
        * html/BaseDateAndTimeInputType.cpp: remove hasSpinButton.
        * html/BaseDateAndTimeInputType.h: remove hasSpinButton.
        * html/InputType.cpp: remove hasSpinButton.
        * html/InputType.h: remove hasSpinButton.
        * html/NumberInputType.cpp: remove hasSpinButton.
        * html/NumberInputType.h: remove hasSpinButton.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=59223
bdakin@apple.com [Fri, 22 Apr 2011 22:42:50 +0000 (22:42 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=59223
REGRESSION (r82185): iframe not displayed after navigation back to cached page

Reviewed by Maciej Stachowiak.

Manual test added.
* manual-tests/frame-layout-on-back.html: Added.
* manual-tests/resources/empty-document-goes-back.html: Added.
* manual-tests/resources/simple-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Fri, 22 Apr 2011 22:36:46 +0000 (22:36 +0000)]
2011-04-22  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Sam Weinig.

        HTMLFormControlElement::labels should allow custom attributes.
        https://bugs.webkit.org/show_bug.cgi?id=59128

        * fast/forms/labels-custom-property-expected.txt: Added.
        * fast/forms/labels-custom-property.html: Added.
2011-04-22  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Sam Weinig.

        HTMLFormControlElement::labels should allow custom attributes.
        https://bugs.webkit.org/show_bug.cgi?id=59128

        Cache the labels list when it is created and keep using it for future
        labels calls.

        Test: fast/forms/labels-custom-property.html

        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::labels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 22 Apr 2011 22:34:53 +0000 (22:34 +0000)]
2011-04-22  Adam Barth  <abarth@webkit.org>

        Remove double-negative.  (Sorry this was bugging me.)

        * Scripts/webkitpy/tool/bot/commitqueuetask.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoQuick cleanup to SpeculativeJIT/NonSpeculativeJIT compile loop,
barraclough@apple.com [Fri, 22 Apr 2011 22:27:54 +0000 (22:27 +0000)]
Quick cleanup to SpeculativeJIT/NonSpeculativeJIT compile loop,
move out the call to checkConsistency().

Reviewed by Sam Weinig.

* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Adrienne Walker <enne@google.com>
enne@google.com [Fri, 22 Apr 2011 22:21:39 +0000 (22:21 +0000)]
2011-04-22  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Remove minimum texture size for compositor tiling
        https://bugs.webkit.org/show_bug.cgi?id=59236

        This was mistakenly committed in r83915 and causes bad filtering
        on very small textures.

        Tests: compositing/images/content-image-change.html

        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::setTileSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 22 Apr 2011 22:17:28 +0000 (22:17 +0000)]
2011-04-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Factor LayoutTestResultsReader out of CommitQueue
        https://bugs.webkit.org/show_bug.cgi?id=59244

        This code will be shared with the EWS when they start running tests.

        * Scripts/webkitpy/tool/bot/layouttestresultsreader.py: Added.
        * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py: Added.
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=59223
bdakin@apple.com [Fri, 22 Apr 2011 22:10:21 +0000 (22:10 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=59223
REGRESSION (r82185): iframe not displayed after navigation back to cached page
-and corresponding-
<rdar://problem/9323763>

Reviewed by Maciej Stachowiak.

Cache the scroll position in Document::setInPageCache() instead of
FrameView::resetScrollbarsAndClearContentsSize(), and only clear the contents size
for the mainFrame(). Still resetScrollbars() for other frames, which matches pre-
r82185 code.
* dom/Document.cpp:
(WebCore::Document::setInPageCache):
* page/FrameView.cpp:
(WebCore::FrameView::resetScrollbarsAndClearContentsSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Fri, 22 Apr 2011 22:01:02 +0000 (22:01 +0000)]
2011-04-21  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Adam Barth.

        Provide default constructors for HashMap iterators.
        https://bugs.webkit.org/show_bug.cgi?id=59151

        These will be used to implement an iterator over EventTarget's
        listeners.

        * wtf/HashTable.h:
        (WTF::HashTableConstIteratorAdapter::HashTableConstIteratorAdapter):
        (WTF::HashTableIteratorAdapter::HashTableIteratorAdapter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] REGRESSION(r84296): platform/qt/fast/history/back-to-unreachable-url-then-forwar...
ossy@webkit.org [Fri, 22 Apr 2011 21:56:38 +0000 (21:56 +0000)]
[Qt] REGRESSION(r84296): platform/qt/fast/history/back-to-unreachable-url-then-forward.html fails
https://bugs.webkit.org/show_bug.cgi?id=58977

r84604 fixed the bug, so we can unskip it.

* platform/qt/Skipped: Unskip platform/qt/fast/history/back-to-unreachable-url-then-forward.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Fri, 22 Apr 2011 21:37:55 +0000 (21:37 +0000)]
2011-04-22  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed: Updated Chromium expectations after WK r84606

        * platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
        * platform/chromium-mac/fast/url/host-expected.txt: Removed.
        * platform/chromium-mac/fast/url/path-expected.txt: Removed.
        * platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
        * platform/chromium-win/fast/url/host-expected.txt: Removed.
        * platform/chromium-win/fast/url/path-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 59232 - DFG JIT - Add predecessor links to BasicBlocks
barraclough@apple.com [Fri, 22 Apr 2011 21:33:36 +0000 (21:33 +0000)]
Bug 59232 - DFG JIT - Add predecessor links to BasicBlocks

Reviewed by Geoff Garen.

These will be necessary for DCE support.
Also factor allocateVirtualRegisters out into its own method.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::setupPredecessors):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::blockForBytecodeOffset):
* dfg/DFGNode.h:
(JSC::DFG::Node::isTerminal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Fri, 22 Apr 2011 21:32:40 +0000 (21:32 +0000)]
2011-04-22  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Kent Tamura.

        Don't rely on hasSpinButton to check if an input type can be stepped
        https://bugs.webkit.org/show_bug.cgi?id=59224

        Add isSteppable to know for certain if an input type can
        be stepped or not. Previously we were checking if the input
        has a spin control or is the range input type. These are UI
        details, but the step functionality does not require there
        to be a UI.

        No change in behavior, covered by existing tests.

        * html/BaseDateAndTimeInputType.cpp:
        (WebCore::BaseDateAndTimeInputType::isSteppable):
        * html/BaseDateAndTimeInputType.h:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::isSteppable):
        (WebCore::HTMLInputElement::stepUpFromRenderer): remove the
        check for a spinner and range control and instead ASSERT
        that the type is steppable.
        * html/HTMLInputElement.h:
        * html/InputType.cpp:
        (WebCore::InputType::isSteppable):
        * html/InputType.h:
        * html/NumberInputType.cpp:
        (WebCore::NumberInputType::isSteppable):
        * html/NumberInputType.h:
        * html/RangeInputType.cpp:
        (WebCore::RangeInputType::isSteppable):
        * html/RangeInputType.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPaint the bounding rect of the dirty region instead of individual rectangles when...
mitz@apple.com [Fri, 22 Apr 2011 21:24:46 +0000 (21:24 +0000)]
Paint the bounding rect of the dirty region instead of individual rectangles when the region
covers at least 3/4 of its bounds.

Reviewed by Sam Weinig.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::shouldPaintBoundsRect): Use floating point math so that the logic that was supposed to
achieve this actually works.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 22 Apr 2011 21:20:12 +0000 (21:20 +0000)]
2011-04-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CSP frame-src is missing
        https://bugs.webkit.org/show_bug.cgi?id=58643

        Update expected result to show that this test is passing now.

        * http/tests/security/contentSecurityPolicy/frame-src-blocked-expected.txt:
2011-04-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CSP frame-src is missing
        https://bugs.webkit.org/show_bug.cgi?id=58643

        In this patch, I've audited all the callers to
        SecurityOrigin::canDisplay to make sure they all the appropriate
        Content-Security-Policy method as well.  I'm not sure how to test all
        these cases, but making this changes fixed the frame-src test.

        * loader/SubframeLoader.cpp:
        (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
        (WebCore::SubframeLoader::createJavaAppletWidget):
        (WebCore::SubframeLoader::loadSubframe):
        (WebCore::SubframeLoader::loadPlugin):
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::create):
        * loader/cache/CachedResourceLoader.cpp:
        (WebCore::CachedResourceLoader::canRequest):
        (WebCore::CachedResourceLoader::requestResource):
            - While I was understanding this code, I fixed the FIXME here.
        * loader/cache/CachedResourceLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Adrienne Walker <enne@google.com>
enne@google.com [Fri, 22 Apr 2011 21:17:45 +0000 (21:17 +0000)]
2011-04-22  Adrienne Walker  <enne@google.com>

        Reviewed by Simon Fraser.

        Clear shared graphics context when destroying CanvasRenderingContext2D.
        https://bugs.webkit.org/show_bug.cgi?id=59212

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 22 Apr 2011 21:17:20 +0000 (21:17 +0000)]
2011-04-22  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Object.create creates uncachable objects
        https://bugs.webkit.org/show_bug.cgi?id=59164

        Use the prototype object's inheritorID, as we
        should always have done

        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::reset):
        (JSC::JSGlobalObject::visitChildren):
        * runtime/JSGlobalObject.h:
        (JSC::JSGlobalObject::nullPrototypeObjectStructure):
        * runtime/ObjectConstructor.cpp:
        (JSC::objectConstructorCreate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Fri, 22 Apr 2011 21:05:15 +0000 (21:05 +0000)]
2011-04-22  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Ryosuke Niwa.

        End/Home keys do not work in a contentEditable element
        https://bugs.webkit.org/show_bug.cgi?id=50564

        Fixing modifying selection by lineboundary (home/end) for editable contexts that are
        inline and share a line with non-editable content.

        * editing/selection/modify-by-lineboundary-in-inline-editable-contexts-expected.txt: Added.
        * editing/selection/modify-by-lineboundary-in-inline-editable-contexts.html: Added.
        * editing/selection/script-tests/modify-by-lineboundary-in-inline-editable-contexts.js: Added.
        (testModifyByLine):
2011-04-22  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Ryosuke Niwa.

        End/Home keys do not work in a contentEditable element
        https://bugs.webkit.org/show_bug.cgi?id=50564

        Changing logical[Start/End]OfLine to return a valid VisiblePosition for for editable contexts that are
        inline and share a line with non-editable content.

        Test: editing/selection/modify-by-lineboundary-in-inline-editable-contexts.html

        * editing/visible_units.cpp:
        (WebCore::logicalStartOfLine):
        (WebCore::logicalEndOfLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 22 Apr 2011 20:54:47 +0000 (20:54 +0000)]
2011-04-22  Dimitri Glazkov  <dglazkov@chromium.org>

        [Gtk] Update expectations after r84511.

        * platform/gtk/fast/html/details-add-summary-1-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-1-expected.txt:
        * platform/gtk/fast/html/details-add-summary-10-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-10-expected.txt:
        * platform/gtk/fast/html/details-add-summary-2-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-2-expected.txt:
        * platform/gtk/fast/html/details-add-summary-3-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-3-expected.txt:
        * platform/gtk/fast/html/details-add-summary-4-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-4-expected.txt:
        * platform/gtk/fast/html/details-add-summary-5-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-5-expected.txt:
        * platform/gtk/fast/html/details-add-summary-6-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-6-expected.txt:
        * platform/gtk/fast/html/details-add-summary-7-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-7-expected.txt:
        * platform/gtk/fast/html/details-add-summary-8-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-8-expected.txt:
        * platform/gtk/fast/html/details-add-summary-9-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-9-expected.txt:
        * platform/gtk/fast/html/details-no-summary1-expected.txt:
        * platform/gtk/fast/html/details-no-summary2-expected.txt:
        * platform/gtk/fast/html/details-no-summary3-expected.txt:
        * platform/gtk/fast/html/details-no-summary4-expected.txt:
        * platform/gtk/fast/html/details-open-javascript-expected.txt:
        * platform/gtk/fast/html/details-open1-expected.txt:
        * platform/gtk/fast/html/details-open2-expected.txt:
        * platform/gtk/fast/html/details-open3-expected.txt:
        * platform/gtk/fast/html/details-open4-expected.txt:
        * platform/gtk/fast/html/details-open5-expected.txt:
        * platform/gtk/fast/html/details-open6-expected.txt:
        * platform/gtk/fast/html/details-position-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-1-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-2-and-click-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-2-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-3-and-click-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-3-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-4-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-5-and-click-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-5-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-6-and-click-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-6-expected.txt:
        * platform/gtk/fast/html/details-writing-mode-expected.txt:
        * platform/gtk/media/video-controls-rendering-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 22 Apr 2011 20:44:46 +0000 (20:44 +0000)]
2011-04-22  Eric Seidel  <eric@webkit.org>

        Reviewed by Dimitri Glazkov.

        webkit-patch rebaseline is broken
        https://bugs.webkit.org/show_bug.cgi?id=59207

        My recent changes to how LayoutTestResults.results_from_string
        uncovered a bug in our use of urllib2.
        We now are treating the return value from _fetch_results_html()
        (which returns urllib2.openurl()) as a string.  That's incorrect,
        the return value is a file-like object (which auto-converts to a
        string in most cases).

        I've updated our urllib2-using code to correctly call .read() on the
        resulting object before treating it like a string.
        Unfortunately there is no easy way to test this mis-understanding
        of the openurl() semantics.

        * Scripts/webkitpy/common/net/buildbot/buildbot.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 59222 - DFG JIT - don't allocate virtual registers to nodes with no result
barraclough@apple.com [Fri, 22 Apr 2011 20:38:27 +0000 (20:38 +0000)]
Bug 59222 - DFG JIT - don't allocate virtual registers to nodes with no result

Reviewed by Sam Weinig.

We currently allocate virtual registers to nodes which have no result - these are
clearly unused, and may result in us allocating a larger than necessary stack frame.

Encapsulate Node::virtualRegister such that we can ASSERT this is only called on
nodes that have results, and improve the quality of output from the consistency check.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::dump):
(JSC::DFG::JITCodeGenerator::checkConsistency):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::canReuse):
(JSC::DFG::JITCodeGenerator::isFilled):
(JSC::DFG::JITCodeGenerator::isFilledDouble):
(JSC::DFG::JITCodeGenerator::use):
(JSC::DFG::JITCodeGenerator::integerResult):
(JSC::DFG::JITCodeGenerator::noResult):
(JSC::DFG::JITCodeGenerator::cellResult):
(JSC::DFG::JITCodeGenerator::jsValueResult):
(JSC::DFG::JITCodeGenerator::doubleResult):
(JSC::DFG::JITCodeGenerator::initConstantInfo):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):
(JSC::DFG::JITCompiler::fillToJS):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
* dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasResult):
(JSC::DFG::Node::virtualRegister):
(JSC::DFG::Node::setVirtualRegister):
(JSC::DFG::Node::refCount):
(JSC::DFG::Node::ref):
(JSC::DFG::Node::deref):
(JSC::DFG::Node::adjustedRefCount):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::isKnownInteger):
(JSC::DFG::NonSpeculativeJIT::isKnownNumeric):
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::use):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 22 Apr 2011 20:30:44 +0000 (20:30 +0000)]
2011-04-22  Tony Chang  <tony@chromium.org>

        Landing new baselines for plugins/embedded-attributes-style.html after
        border changes (r84273).

        https://bugs.webkit.org/show_bug.cgi?id=59068

        * platform/chromium-linux/plugins/embed-attributes-style-expected.png:
        * platform/chromium-win/plugins/embed-attributes-style-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Update expected files after r84632.
ossy@webkit.org [Fri, 22 Apr 2011 20:28:24 +0000 (20:28 +0000)]
[Qt] Update expected files after r84632.

* platform/qt/fast/html/details-add-summary-1-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-1-expected.txt:
* platform/qt/fast/html/details-add-summary-10-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-10-expected.txt:
* platform/qt/fast/html/details-add-summary-2-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-2-expected.txt:
* platform/qt/fast/html/details-add-summary-3-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-3-expected.txt:
* platform/qt/fast/html/details-add-summary-4-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-4-expected.txt:
* platform/qt/fast/html/details-add-summary-5-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-5-expected.txt:
* platform/qt/fast/html/details-add-summary-6-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-6-expected.txt:
* platform/qt/fast/html/details-add-summary-7-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-7-expected.txt:
* platform/qt/fast/html/details-add-summary-8-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-8-expected.txt:
* platform/qt/fast/html/details-add-summary-9-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-9-expected.txt:
* platform/qt/fast/html/details-no-summary1-expected.txt:
* platform/qt/fast/html/details-no-summary2-expected.txt:
* platform/qt/fast/html/details-no-summary3-expected.txt:
* platform/qt/fast/html/details-no-summary4-expected.txt:
* platform/qt/fast/html/details-open-javascript-expected.txt:
* platform/qt/fast/html/details-open1-expected.txt:
* platform/qt/fast/html/details-open2-expected.txt:
* platform/qt/fast/html/details-open3-expected.txt:
* platform/qt/fast/html/details-open4-expected.txt:
* platform/qt/fast/html/details-open5-expected.txt:
* platform/qt/fast/html/details-open6-expected.txt:
* platform/qt/fast/html/details-position-expected.txt:
* platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-1-expected.txt:
* platform/qt/fast/html/details-remove-summary-2-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-2-expected.txt:
* platform/qt/fast/html/details-remove-summary-3-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-3-expected.txt:
* platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-4-expected.txt:
* platform/qt/fast/html/details-remove-summary-5-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-5-expected.txt:
* platform/qt/fast/html/details-remove-summary-6-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-6-expected.txt:
* platform/qt/fast/html/details-writing-mode-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 22 Apr 2011 20:27:45 +0000 (20:27 +0000)]
2011-04-22  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        Make showTree/showTreeForThis aware of the shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=52965

        No new tests, because this code is only compiled in DEBUG.

        * dom/Node.cpp:
        (WebCore::traverseTreeAndMark): Moved tree traversal logic here, adding
            recursive sub-traversal of the shadow tree.
        (WebCore::Node::showTreeAndMark): Changed to use the new tree traversal function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 22 Apr 2011 20:11:08 +0000 (20:11 +0000)]
2011-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Gavin Barraclough and Oliver Hunt.

        Arrays should participate in global object forwarding fun
        https://bugs.webkit.org/show_bug.cgi?id=59215

        - Update results of prototype-inheritance-2 for new array behavior.
        - Remove checks for primitives, since they were incorrect.
        - Force function check to check a function not on a primitive (this
          wasn't happening by itself, since functions normally aren't enumerable
          in the DOM).
        - Add exception to the test to not try and test HTMLProgressElement, since
          it is not available on all platforms. This allows us to remove the windows
          specific results.

        * fast/dom/prototype-inheritance-2-expected.txt:
        * fast/dom/script-tests/prototype-inheritance-2.js:
        (constructorNamesForWindow):
        (crawl):
        * platform/win/fast/dom/prototype-inheritance-2-expected.txt: Removed.
2011-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Gavin Barraclough and Oliver Hunt.

        Arrays should participate in global object forwarding fun
        https://bugs.webkit.org/show_bug.cgi?id=59215

        * runtime/JSGlobalObject.h:
        (JSC::constructEmptyArray):
        (JSC::constructArray):
        Add variants of constructArray that take a global object.
2011-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Gavin Barraclough and Oliver Hunt.

        Arrays should participate in global object forwarding fun
        https://bugs.webkit.org/show_bug.cgi?id=59215

        Change callers of constructArray to use the new variant that takes
        a global object.

        * bindings/js/JSClipboardCustom.cpp:
        (WebCore::JSClipboard::types):
        * bindings/js/JSConsoleCustom.cpp:
        (WebCore::JSConsole::profiles):
        * bindings/js/JSJavaScriptCallFrameCustom.cpp:
        (WebCore::JSJavaScriptCallFrame::scopeChain):
        * bindings/js/JSMessageEventCustom.cpp:
        (WebCore::JSMessageEvent::ports):
        * bindings/js/JSScriptProfileNodeCustom.cpp:
        (WebCore::JSScriptProfileNode::children):
        * bindings/js/JSWebGLRenderingContextCustom.cpp:
        (WebCore::toJS):
        (WebCore::JSWebGLRenderingContext::getAttachedShaders):
        (WebCore::JSWebGLRenderingContext::getSupportedExtensions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed typo fix after r84522.
ossy@webkit.org [Fri, 22 Apr 2011 20:03:22 +0000 (20:03 +0000)]
[Qt] Unreviewed typo fix after r84522.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Fri, 22 Apr 2011 20:01:34 +0000 (20:01 +0000)]
2011-04-22  Daniel Bates  <dbates@rim.com>

        Fix misspelled word in comment; tagets => targets.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleTouchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 22 Apr 2011 19:57:23 +0000 (19:57 +0000)]
2011-04-21  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Removed a use of markDOMObjectWrapper: Element and Document
        https://bugs.webkit.org/show_bug.cgi?id=59178

        * GNUmakefile.list.am:
        * UseJSC.cmake:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp: Build!

        * bindings/js/JSDOMImplementationCustom.cpp:
        (WebCore::JSDOMImplementationOwner::isReachableFromOpaqueRoots):
        (WebCore::JSDOMImplementationOwner::finalize):
        (WebCore::wrapperOwner):
        (WebCore::wrapperContext):
        (WebCore::toJS): Use the opaque roots system for DOMImplementation. Also,
        DOMImplementation does not need to keep its document wrapper alive, since
        there's no DOM API for getting a DOMImplementation's document.

        * bindings/js/JSDOMStringMapCustom.cpp:
        (WebCore::JSDOMStringMapOwner::isReachableFromOpaqueRoots):
        (WebCore::JSDOMStringMapOwner::finalize):
        (WebCore::wrapperOwner):
        (WebCore::wrapperContext):
        (WebCore::toJS): Use the opaque roots system for DOMStringMap.

        * bindings/js/JSDOMTokenListCustom.cpp: Added.
        (WebCore::JSDOMTokenListOwner::isReachableFromOpaqueRoots):
        (WebCore::JSDOMTokenListOwner::finalize):
        (WebCore::wrapperOwner):
        (WebCore::wrapperContext):
        (WebCore::toJS): Use the opaque roots system for DOMTokenList.

        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::visitChildren):
        * bindings/js/JSElementCustom.cpp: No more need for explicit marking.

        * bindings/scripts/CodeGeneratorV8.pm: Boo on whoever made this design decision.

        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::DOMImplementation):
        (WebCore::DOMImplementation::createDocument):
        (WebCore::DOMImplementation::createHTMLDocument):
        * dom/DOMImplementation.h:
        (WebCore::DOMImplementation::create):
        (WebCore::DOMImplementation::ref):
        (WebCore::DOMImplementation::deref):
        (WebCore::DOMImplementation::document): Fixed the DOMImplementation
        ownership model to match other satellite objects in the DOM. This was
        necessary to fix some crashes due to incorrect reference counting.

        * dom/DOMImplementation.idl:
        * dom/DOMStringMap.idl:
        * dom/Document.cpp:
        (WebCore::Document::~Document):
        * dom/Document.h:
        * dom/Element.cpp:
        * dom/Element.h:
        * dom/Element.idl:
        * html/DOMTokenList.idl: Updated to match changes above.
2011-04-21  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Removed a use of markDOMObjectWrapper: Element and Document
        https://bugs.webkit.org/show_bug.cgi?id=59178

        * fast/dom/dataset-gc-expected.txt:
        * fast/dom/script-tests/dataset-gc.js: Changed this test not to be
        specific to __proto__. We have a general bug in the DOM that assignment
        to __proto__ does not persist after garbage collection. While we should
        fix that bug, we don't want existing tests to tickle it, because it makes
        them flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 22 Apr 2011 19:54:24 +0000 (19:54 +0000)]
2011-04-22  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Rounded corners don't looks smooth when background-image is a gradient
        https://bugs.webkit.org/show_bug.cgi?id=59213

        Add the "shrink background" behavior to the slow background
        drawing code path.

        Test: fast/backgrounds/gradient-background-leakage.html

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::backgroundRectAdjustedForBleedAvoidance):
        Utility function that returns a shrunk border rect based
        on the context scale.
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        Use backgroundRectAdjustedForBleedAvoidance() in both the fast
        and slow paths.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Mike Reed <reed@google.com>
commit-queue@webkit.org [Fri, 22 Apr 2011 19:49:51 +0000 (19:49 +0000)]
2011-04-22  Mike Reed  <reed@google.com>

        Reviewed by Eric Seidel.

        Update expected images with new shadow code
        [chromium, win] Multiple failures of shadow rendering layout tests
        https://bugs.webkit.org/show_bug.cgi?id=58772

        * platform/chromium-linux/fast/multicol/shadow-breaking-expected.png:
        * platform/chromium-linux/svg/css/composite-shadow-text-expected.png:
        * platform/chromium-win-xp/fast/multicol/shadow-breaking-expected.png: Added.
        * platform/chromium-win-xp/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
        * platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
        * platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
        * platform/chromium-win-xp/fast/repaint/shadow-multiple-vertical-expected.png: Added.
        * platform/chromium-win-xp/fast/text/shadow-translucent-fill-expected.png: Added.
        * platform/chromium-win-xp/fast/transforms: Added.
        * platform/chromium-win-xp/fast/transforms/shadows-expected.png: Added.
        * platform/chromium-win-xp/svg/css: Added.
        * platform/chromium-win-xp/svg/css/group-with-shadow-expected.png: Added.
        * platform/chromium-win-xp/svg/css/text-shadow-multiple-expected.png: Added.
        * platform/chromium-win-xp/transitions: Added.
        * platform/chromium-win-xp/transitions/svg-text-shadow-transition-expected.png: Added.
        * platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
        * platform/chromium-win/svg/css/composite-shadow-text-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 22 Apr 2011 19:26:04 +0000 (19:26 +0000)]
2011-04-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84650 and r84654.
        http://trac.webkit.org/changeset/84650
        http://trac.webkit.org/changeset/84654
        https://bugs.webkit.org/show_bug.cgi?id=59218

        Broke Windows build (Requested by bweinstein on #webkit).

        * API/JSCallbackObjectFunctions.h:
        (JSC::::init):
        * JavaScriptCore.exp:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * heap/Handle.h:
        (JSC::HandleBase::operator!):
        (JSC::HandleBase::operator UnspecifiedBoolType*):
        (JSC::HandleTypes::getFromSlot):
        * heap/HandleHeap.cpp:
        (JSC::HandleHeap::markStrongHandles):
        (JSC::HandleHeap::markWeakHandles):
        (JSC::HandleHeap::finalizeWeakHandles):
        (JSC::HandleHeap::writeBarrier):
        (JSC::HandleHeap::protectedGlobalObjectCount):
        (JSC::HandleHeap::isValidWeakNode):
        * heap/HandleHeap.h:
        (JSC::HandleHeap::copyWeak):
        (JSC::HandleHeap::makeWeak):
        (JSC::HandleHeap::Node::slot):
        * heap/HandleStack.cpp:
        (JSC::HandleStack::mark):
        (JSC::HandleStack::grow):
        * heap/HandleStack.h:
        (JSC::HandleStack::zapTo):
        (JSC::HandleStack::push):
        * heap/Heap.cpp:
        (JSC::HandleHeap::protectedObjectTypeCounts):
        * heap/Local.h:
        (JSC::::set):
        * heap/Strong.h:
        (JSC::Strong::set):
        * heap/Weak.h:
        (JSC::Weak::set):
        * runtime/StructureTransitionTable.h:
        (JSC::StructureTransitionTable::singleTransition):
        (JSC::StructureTransitionTable::setSingleTransition):
        * runtime/WeakGCMap.h:
        (JSC::WeakGCMap::add):
        (JSC::WeakGCMap::set):
        * runtime/WriteBarrier.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Fri, 22 Apr 2011 19:25:46 +0000 (19:25 +0000)]
2011-04-22  Xiaomei Ji  <xji@chromium.org>

        Reviewed by David Hyatt.

        Local caret rectangle calculation should be relative to its containing block.
        https://bugs.webkit.org/show_bug.cgi?id=49508.

        * fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
        * fast/forms/cursor-at-editable-content-boundary.html: Added.
        * platform/mac/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
2011-04-22  Xiaomei Ji  <xji@chromium.org>

        Reviewed by David Hyatt.

        Local caret rectangle calculation should be relative to its containing block.
        https://bugs.webkit.org/show_bug.cgi?id=49508.

        InlineBox and caret rectangle are positioned relative to its containing block.
        So its left and right edge value should be relative to its containing block as well.

        Test: fast/forms/cursor-at-editable-content-boundary.html

        * rendering/RenderText.cpp:
        (WebCore::RenderText::localCaretRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 22 Apr 2011 19:25:34 +0000 (19:25 +0000)]
2011-04-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Factor PatchAnalysis task out of CommitQueueTask
        https://bugs.webkit.org/show_bug.cgi?id=59220

        This is a first step towards teaching the EWS to run tests.

        * Scripts/webkitpy/tool/bot/commitqueuetask.py:
        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
        * Scripts/webkitpy/tool/bot/patchanalysistask.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Fri, 22 Apr 2011 19:08:19 +0000 (19:08 +0000)]
2011-04-22  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed: update Chromium baselines.

        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png: Added.
        * platform/chromium-mac-leopard/svg/filters/feDropShadow-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 22 Apr 2011 18:59:09 +0000 (18:59 +0000)]
2011-04-22  Tony Chang  <tony@chromium.org>

        Unreviewed, deleting remaining .checksum files.
        More will probably creep in over the next few days-- I'll do
        another pass in a week or so.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Fri, 22 Apr 2011 18:53:15 +0000 (18:53 +0000)]
2011-04-22  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Darin Fisher.

        REGRESSION: left property broken with position:fixed elements in RTL documents
        https://bugs.webkit.org/show_bug.cgi?id=59204
        http://code.google.com/p/chromium/issues/detail?id=80216

        Test: fast/block/positioning/rtl-fixed-positioning.html
              fast/block/positioning/vertical-rl/fixed-positioning.html

        Returning the proper scroll offsets for fixed position content in RTL documents.
        We regressed to X and Y offsets not updating while scrolling when we clamped to zero,
        but RTL documents scroll in negative space.

        * page/FrameView.cpp:
        (WebCore::FrameView::scrollXForFixedPosition): Properly handling RTL documents where
        the scroll origin and offsets are negative.
        (WebCore::FrameView::scrollYForFixedPosition): Properly handling vertical writing-
        mode RTL documents, like above.
        * platform/ScrollView.h:
        (WebCore::ScrollView::scrollOrigin): Changing this accessor to const.
2011-04-22  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Darin Fisher.

        REGRESSION: left property broken with position:fixed elements in RTL documents
        https://bugs.webkit.org/show_bug.cgi?id=59204
        http://code.google.com/p/chromium/issues/detail?id=80216

        Test to ensure position:fixed works properly in RTL documents.

        * fast/block/positioning/rtl-fixed-positioning.html: Added.
        * fast/block/positioning/vertical-rl/fixed-positioning.html: Added.
        * platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.checksum: Added.
        * platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
        * platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.txt: Added.
        * platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.checksum: Added.
        * platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
        * platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPart of Windows build fix from r84650.
bweinstein@apple.com [Fri, 22 Apr 2011 18:52:56 +0000 (18:52 +0000)]
Part of Windows build fix from r84650.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Fri, 22 Apr 2011 18:51:17 +0000 (18:51 +0000)]
2011-04-22  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Eric Seidel.

        Should assert on invalid type in FEComponentTransfer::apply
        https://bugs.webkit.org/show_bug.cgi?id=57959

        No functional change. No new tests needed.

        * platform/graphics/filters/FEComponentTransfer.cpp:
        (WebCore::FEComponentTransfer::apply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 22 Apr 2011 18:43:45 +0000 (18:43 +0000)]
2011-04-22  MORITA Hajime  <morrita@google.com>

        Unreviewed crash fix.

        * html/HTMLDetailsElement.cpp:
        (WebCore::DetailsSummaryElement::shouldInclude):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Fri, 22 Apr 2011 18:36:47 +0000 (18:36 +0000)]
2011-04-22  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed: Chromium test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 22 Apr 2011 18:26:34 +0000 (18:26 +0000)]
2011-04-22  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Make it harder to use HandleSlot incorrectly
        https://bugs.webkit.org/show_bug.cgi?id=59205

        Just add a little type fudging to make it harder to
        incorrectly assign through a HandleSlot.

        * API/JSCallbackObjectFunctions.h:
        (JSC::::init):
        * JavaScriptCore.exp:
        * heap/Handle.h:
        (JSC::HandleBase::operator!):
        (JSC::HandleBase::operator UnspecifiedBoolType*):
        (JSC::HandleTypes::getFromSlot):
        * heap/HandleHeap.cpp:
        (JSC::HandleHeap::markStrongHandles):
        (JSC::HandleHeap::markWeakHandles):
        (JSC::HandleHeap::finalizeWeakHandles):
        (JSC::HandleHeap::writeBarrier):
        (JSC::HandleHeap::protectedGlobalObjectCount):
        (JSC::HandleHeap::isValidWeakNode):
        * heap/HandleHeap.h:
        (JSC::HandleHeap::copyWeak):
        (JSC::HandleHeap::makeWeak):
        (JSC::HandleHeap::Node::slot):
        * heap/HandleStack.cpp:
        (JSC::HandleStack::mark):
        (JSC::HandleStack::grow):
        * heap/HandleStack.h:
        (JSC::HandleStack::zapTo):
        (JSC::HandleStack::push):
        * heap/Heap.cpp:
        (JSC::HandleHeap::protectedObjectTypeCounts):
        * heap/Local.h:
        (JSC::::set):
        * heap/Strong.h:
        (JSC::Strong::set):
        * heap/Weak.h:
        (JSC::Weak::set):
        * runtime/StructureTransitionTable.h:
        (JSC::StructureTransitionTable::singleTransition):
        (JSC::StructureTransitionTable::setSingleTransition):
        * runtime/WeakGCMap.h:
        (JSC::WeakGCMap::add):
        (JSC::WeakGCMap::set):
        * runtime/WriteBarrier.h:
        (JSC::OpaqueJSValue::toJSValue):
        (JSC::OpaqueJSValue::toJSValueRef):
        (JSC::OpaqueJSValue::fromJSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoExclude scrollbars from the dirty rect passed to the document
mitz@apple.com [Fri, 22 Apr 2011 18:13:24 +0000 (18:13 +0000)]
Exclude scrollbars from the dirty rect passed to the document
https://bugs.webkit.org/show_bug.cgi?id=59206

Reviewed by Sam Weinig.

No test added because functionality is unchanged.

* platform/ScrollView.cpp:
(WebCore::ScrollView::paint): Compute a clip rectangle (analogous to the frame of the clip view
in an NSScrollView) by subtracting non-overlay scrollbars, and intersect the document dirty rect
with it. If the result is empty, avoid calling paintContents().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Fri, 22 Apr 2011 18:03:04 +0000 (18:03 +0000)]
2011-04-22  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        Allow MediaPlayerPrivateAVFoundation to be disabled via a preference.
        https://bugs.webkit.org/show_bug.cgi?id=59179

        Add API to allow the WebCore Settings preference to be called from the UIProcess.

        * Shared/WebPreferencesStore.h: Added new preference definition macro.
        * UIProcess/API/C/WKPreferences.cpp:
        (WKPreferencesSetAVFoundationEnabled): Added.
        (WKPreferencesGetAVFoundationEnabled): Added.
        * UIProcess/API/C/WKPreferences.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::updatePreferences): Pass new preference along to WebCore
            Settings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 22 Apr 2011 18:00:03 +0000 (18:00 +0000)]
2011-04-22  Tony Chang  <tony@chromium.org>

        Unreviewed, deleting .checksum files in platform/mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Fri, 22 Apr 2011 17:51:00 +0000 (17:51 +0000)]
2011-04-22  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        Disable MediaPlayerPrivateAVFoundation when using old full screen mode.
        https://bugs.webkit.org/show_bug.cgi?id=59147

        Add a new isAVFoundationEnabled setting and check it before adding
        MediaPlayerPrivateAVFoundationObjC to the media engine registry.

        * WebCore.exp.in:
        * page/Settings.cpp:
        * page/Settings.h:
        (WebCore::Settings::setAVFoundationEnabled): Added.
        (WebCore::Settings::isAVFoundationEnabled): Added.
        * platform/graphics/MediaPlayer.cpp:
        (WebCore::installedMediaEngines): Check the settings added above.
2011-04-22  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        Disable MediaPlayerPrivateAVFoundation when using old full screen mode.
        https://bugs.webkit.org/show_bug.cgi?id=59147

        Add a new user default preference, and plumb that preference down to WebCore
        Settings. Allow the fullScreenEnabled preference to override the new
        isAVFoundationEnabled preference, so that clients of the legacy full screen
        mode will continue to use that mode normally.

        * WebView/WebPreferenceKeysPrivate.h: Add new preference key.
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]): Set the default value of new
            preference.
        (-[WebPreferences setAVFoundationEnabled:]): Added.
        (-[WebPreferences isAVFoundationEnabled]): Added.
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChanged:]): Update the WebCore settings with the
            new values from WebPreferences.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Ojan Vafai. Bugzilla JavaScript changes by Adam Barth.
ap@apple.com [Fri, 22 Apr 2011 17:49:52 +0000 (17:49 +0000)]
    Reviewed by Ojan Vafai. Bugzilla JavaScript changes by Adam Barth.

        Bugzilla autocomplete should support frequent contributors who are not committers
        https://bugs.webkit.org/show_bug.cgi?id=59209

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix qt build.
weinig@apple.com [Fri, 22 Apr 2011 17:49:11 +0000 (17:49 +0000)]
Fix qt build.

* Api/qwebelement.cpp:
(setupScriptContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2: Stop Responsiveness Timer when WebPageProxy closes or WebProcess crashes
bweinstein@apple.com [Fri, 22 Apr 2011 17:47:21 +0000 (17:47 +0000)]
WebKit2: Stop Responsiveness Timer when WebPageProxy closes or WebProcess crashes
https://bugs.webkit.org/show_bug.cgi?id=59210

Reviewed by Sam Weinig.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close): Stop the responsiveness timer.
(WebKit::WebPageProxy::processDidCrash): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix windows test result.
weinig@apple.com [Fri, 22 Apr 2011 17:40:37 +0000 (17:40 +0000)]
Fix windows test result.

* platform/win/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 22 Apr 2011 17:37:23 +0000 (17:37 +0000)]
2011-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Gavin Barraclough.

        Remove remaining uses of deprecated version of toJS
        https://bugs.webkit.org/show_bug.cgi?id=59170

        * fast/dom/prototype-inheritance-2-expected.txt:
        Add new passing results since we now use the correct global object. The remaining
        failures are pure JS objects (Array, Boolean, String, Number, Function).
2011-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Gavin Barraclough.

        Remove remaining uses of deprecated version of toJS
        https://bugs.webkit.org/show_bug.cgi?id=59170

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::shadowRoot):
        (DumpRenderTreeSupportGtk::ensureShadowRoot):
        Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.
2011-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Gavin Barraclough.

        Remove remaining uses of deprecated version of toJS
        https://bugs.webkit.org/show_bug.cgi?id=59170

        * DOM/WebDOMOperations.mm:
        (-[DOMElement _shadowRoot:]):
        (-[DOMElement _ensureShadowRoot:]):
        Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.
2011-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Gavin Barraclough.

        Remove remaining uses of deprecated version of toJS
        https://bugs.webkit.org/show_bug.cgi?id=59170

        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        (WebCore::toJS):
        (WebCore::JSCanvasRenderingContext2D::strokeStyle):
        (WebCore::JSCanvasRenderingContext2D::fillStyle):
        (WebCore::JSCanvasRenderingContext2D::createPattern):
        * bindings/js/JSConsoleCustom.cpp:
        (WebCore::JSConsole::profiles):
        * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
        (WebCore::JSSQLStatementErrorCallback::handleEvent):
        * bindings/js/JSDOMBinding.h:
        * bindings/js/JSDOMMimeTypeArrayCustom.cpp:
        (WebCore::JSDOMMimeTypeArray::nameGetter):
        * bindings/js/JSDOMPluginArrayCustom.cpp:
        (WebCore::JSDOMPluginArray::nameGetter):
        * bindings/js/JSDOMPluginCustom.cpp:
        (WebCore::JSDOMPlugin::nameGetter):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::namedItemGetter):
        (WebCore::JSDOMWindow::event):
        * bindings/js/JSEventTarget.cpp:
        (WebCore::toJS):
        * bindings/js/JSInjectedScriptHostCustom.cpp:
        Propagate stored global object down access chain.

        (WebCore::InjectedScriptHost::nodeAsScriptValue):
        Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.

        (WebCore::JSInjectedScriptHost::currentCallFrame):
        (WebCore::JSInjectedScriptHost::inspectedNode):
        * bindings/js/JSNamedNodeMapCustom.cpp:
        (WebCore::JSNamedNodeMap::nameGetter):
        * bindings/js/JSNodeListCustom.cpp:
        (WebCore::callNodeList):
        (WebCore::JSNodeList::nameGetter):
        * bindings/js/JSScriptProfileNodeCustom.cpp:
        (WebCore::JSScriptProfileNode::children):
        * bindings/js/JSStyleSheetListCustom.cpp:
        (WebCore::JSStyleSheetList::nameGetter):
        * bindings/js/JSXSLTProcessorCustom.cpp:
        (WebCore::JSXSLTProcessor::transformToFragment):
        (WebCore::JSXSLTProcessor::transformToDocument):
        * bindings/scripts/CodeGeneratorJS.pm:
        Propagate stored global object down access chain.

        * css/MediaQueryListListener.cpp:
        (WebCore::MediaQueryListListener::queryChanged):
        Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype,
        we will want refactor this to match other callbacks so we can remove this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Naoki Takano <takano.naoki@gmail.com>
commit-queue@webkit.org [Fri, 22 Apr 2011 17:25:50 +0000 (17:25 +0000)]
2011-04-22  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Eric Seidel.

        [Chromium]Mac UI polish to add left/right padding space for autofill popup window.
        https://bugs.webkit.org/show_bug.cgi?id=58960
        http://code.google.com/p/chromium/issues/detail?id=51077

        No new test because Chromium Autofill popup window doesn't have any test framework.
        This assumes only AutofillPopupMenuClient gives TexFieldPart appearance.
        Only if Autofill popup window has right/left padding.
        The code should be removed after Autofill popup window logic is separated from WebKit to Chromium.

        * rendering/RenderThemeChromiumMac.h: Add popupInternalPaddingRight() and popupInternalPaddingLeft().
        * rendering/RenderThemeChromiumMac.mm:
        (WebCore::RenderThemeChromiumMac::popupInternalPaddingLeft): Return padding size only if TextFieldPart is specified.
        (WebCore::RenderThemeChromiumMac::popupInternalPaddingRight): Return padding size only if TextFieldPart is specified.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 22 Apr 2011 16:51:59 +0000 (16:51 +0000)]
2011-04-22  Tony Chang  <tony@chromium.org>

        Unreviewed, deleting .checksum files in platform/gtk and platform/qt*.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGive windowless plugins' context menus an owner window in the same thread as the...
aroben@apple.com [Fri, 22 Apr 2011 16:48:35 +0000 (16:48 +0000)]
Give windowless plugins' context menus an owner window in the same thread as the plugin

In some cases, plugins pass the WKView's HWND to the ::TrackPopupMenu API. ::TrackPopupMenu
fails in this case because the WKView's HWND is owned by another process/thread. We work
around this by hooking the ::TrackPopupMenu API and providing our own window that's in the
same thread as the plugin instead.

I couldn't figure out how to write a test for this. :-(

Fixes <http://webkit.org/b/51063> <rdar://problem/8769281> REGRESSION (WebKit2): No context
menu appears when right-clicking on windowless Flash plugin

Reviewed by Brian Weinstein, and looked at suspiciously by Jeff Miller.

* Platform/Module.h: Added installIATHook on Windows.

* Platform/win/ModuleWin.cpp:
(WebKit::overwriteReadOnlyMemory): New helper function. Basically a wrapper around memcpy,
but uses ::VirtualProtect to allow writing to otherwise-read-only memory.
(WebKit::findFunctionPointerAddress): New helper function. The first overload iterates over
the imported modules and functions looking for the given one. If found, returns the address
of the function pointer that is used when calling that function. The second overload calls
the first, first passing it an enumerator for the image's imported modules, then passing it
an iterator for the image's delay-loaded modules.
(WebKit::Module::installIATHook): Added. Finds the address of the function pointer that's
used when code in this module calls the given function, then overwrites the function pointer
with the passed-in one. Future calls to the given function made by code in this module
should then end up calling to the passed-in function instead of the original one.

* Shared/Plugins/Netscape/NetscapePluginModule.h:
(WebKit::NetscapePluginModule::module): Added this simple getter.

* WebProcess/Plugins/Netscape/NetscapePlugin.h: Added some new Windows-only members.

* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::CurrentPluginSetter::CurrentPluginSetter):
(WebKit::CurrentPluginSetter::~CurrentPluginSetter):
This RAII class sets/unsets the currentPlugin global.

(WebKit::registerPluginView): Changed to use instanceHandle() instead of the mysterious
gInstance.
(WebKit::NetscapePlugin::platformPostInitialize): For windowless plugins, hook the
::TrackPopupMenu API and create a window to be used as the owner for context menus created
by this plugin. (Also changed the ::CreateWindowExW call for windowed plugins to pass an
instance handle so that the window will be associated with WebKit.dll instead of
WebKit2WebProcess.exe. This should have no visible effect, but is more correct.)
(WebKit::NetscapePlugin::platformDestroy): For windowless plugins, destroy the context menu
owner window we created above.

(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformSetFocus):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
Set ourselves as the current plugin.

(WebKit::NetscapePlugin::hookedTrackPopupMenu): Added. This is the function that actually
gets called when windowless plugins call ::TrackPopupMenu. If the passed-in owner window is
owned by the current thread, we have nothing to do; ::TrackPopupMenu should work just fine.
Otherwise, we use the current plugin's context menu owner window as the context menu's
owner. We also set focus to the new owner window because otherwise weird behavior results
(e.g., it's possible to scroll the WKView while the context menu is up).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Fri, 22 Apr 2011 16:45:50 +0000 (16:45 +0000)]
2011-04-22  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] DRT: implement eventSender.scalePageBy
        https://bugs.webkit.org/show_bug.cgi?id=59082

        * DumpRenderTree/gtk/EventSender.cpp:
        (scalePageByCallback): scalePageBy() support.

2011-04-22  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] DRT: implement eventSender.scalePageBy
        https://bugs.webkit.org/show_bug.cgi?id=59082

        Unskipped tests that should pass now that
        eventSender.scalePageBy() is supported in GTK.

        * platform/gtk/Skipped:
        * platform/gtk/fast/repaint/scale-page-shrink-expected.checksum: Added.
        * platform/gtk/fast/repaint/scale-page-shrink-expected.png: Added.
        * platform/gtk/fast/repaint/scale-page-shrink-expected.txt: Added.

2011-04-22  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] DRT: implement eventSender.scalePageBy
        https://bugs.webkit.org/show_bug.cgi?id=59082

        Added support in DRT for webview scaling.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::scale):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd code to enumerate all the functions imported by a particular Windows binary
aroben@apple.com [Fri, 22 Apr 2011 16:45:49 +0000 (16:45 +0000)]
Add code to enumerate all the functions imported by a particular Windows binary

PEImage is where all the logic starts. It represents a single Portable Executable (PE)
binary. The various enumerator classes are used in conjunction with PEImage to enumerate the
modules and functions imported by that image.

I couldn't figure out how to write a test for this. :-(

Part of <http://webkit.org/b/51063> <rdar://problem/8769281> REGRESSION (WebKit2): No
context menu appears when right-clicking on windowless Flash plugin

Reviewed by Sam Weinig, and given a good once-over by Jeff Miller.

* WebCore.vcproj/WebCore.vcproj: Added the new files.

* platform/win/PEImage.cpp: Added.
(WebCore::PEImage::PEImage): Checks that the module contains the expected magic numbers,
then initializes m_ntHeaders using the module.
(WebCore::PEImage::convertRVAToAddress): Converts a relative virtual address (RVA) to a
non-relative address, which can then be dereferenced. (The PE format uses RVAs in lots of
places.)
(WebCore::PEImage::dataDirectoryEntryAddress): Returns the address of the data associated
with the given entry in the image's DataDirectory.

* platform/win/PEImage.h: Added.
(WebCore::PEImage::isValid): We're a valid image if the validation code in our constructor
succeeded, in which case m_ntHeaders will be set.

* platform/win/ImportedFunctionsEnumerator.cpp: Added. This class enumerates all the
functions imported by the image from a single module by walking the Import Name Table (INT)
and Import Address Table (IAT).
(WebCore::ImportedFunctionsEnumerator::ImportedFunctionsEnumerator): Initialize our members.
(WebCore::ImportedFunctionsEnumerator::isAtEnd): The INT and IAT are both 0-terminated
arrays.
(WebCore::ImportedFunctionsEnumerator::next): Step to the next entries in the INT and IAT.
(WebCore::ImportedFunctionsEnumerator::currentFunctionName): Gets the address of the
function's name, if possible, using the INT.
(WebCore::ImportedFunctionsEnumerator::addressOfCurrentFunctionPointer): Returns the address
of the function pointer for the current function. This function pointer is used whenever
code in m_image calls the current function. (A future patch will take advantage of this by
overwriting this function pointer with another, thereby redirecting calls to that function.)

* platform/win/ImportedFunctionsEnumerator.h: Added.

* platform/win/ImportedModulesEnumeratorBase.h: Added. This base class is used by
ImportedModulesEnumerator and DelayLoadedModulesEnumerator, and allows code to be written
that works with either one.

* platform/win/ImportedModulesEnumerator.cpp: Added. This class enumerates all the
non-delay-loaded modules imported by the image by walking the image's import array.
(WebCore::ImportedModulesEnumerator::ImportedModulesEnumerator): Module import information
is stored in the IMAGE_DIRECTORY_ENTRY_IMPORT entry of the image's DataDirectory.
(WebCore::ImportedModulesEnumerator::isAtEnd): The import array is 0-terminated.
(WebCore::ImportedModulesEnumerator::next): Steps along the import array.
(WebCore::ImportedModulesEnumerator::currentModuleName): Gets the address of the module's
name.
(WebCore::ImportedModulesEnumerator::functionsEnumerator): Get's the addresses of the INT
and IAT for this module and wraps them in an ImportedFunctionsEnumerator.

* platform/win/ImportedModulesEnumerator.h: Added.

* platform/win/DelayLoadedModulesEnumerator.cpp: Added. This class enumerates all the
delay-loaded modules that are imported by the given PEImage by walking the image's
ImageDelayDescr array.
(WebCore::DelayLoadedModulesEnumerator::DelayLoadedModulesEnumerator): Delay-load
information is stored in the IMAGE_DIRECTORY_ENTRY_DELAY_IMPORT entry of the image's
DataDirectory.
(WebCore::DelayLoadedModulesEnumerator::isAtEnd): The delay-loaded modules array is
0-terminated.
(WebCore::DelayLoadedModulesEnumerator::next): Steps along the delay-loaded modules array.
(WebCore::DelayLoadedModulesEnumerator::currentModuleName): Gets the address of the module's
name out of the descriptor.
(WebCore::DelayLoadedModulesEnumerator::functionsEnumerator): Gets the INT and IAT for the
current module out of the descriptor and makes an ImportedFunctionsEnumerator from them.
(WebCore::DelayLoadedModulesEnumerator::convertPotentialRVAToAddress): Pre-VC7.0 images
stored non-relative addresses in the ImageDelayDescr structures, while VC7.0 and later
images store RVAs. This function abstracts away the difference.

* platform/win/DelayLoadedModulesEnumerator.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a shared do-nothing window class that anyone can use
aroben@apple.com [Fri, 22 Apr 2011 16:44:57 +0000 (16:44 +0000)]
Add a shared do-nothing window class that anyone can use

Fixes <http://webkit.org/b/59102> WebKit has too many dummy window classes

Reviewed by Anders Carlsson.

Source/WebCore:

* WebCore.vcproj/WebCore.vcproj: Added DefWndProcWindowClass.{cpp,h}. Moved Arena.cpp out of
platform/win and into platform. Let VS reorder other files.

* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::acceleratedCompositingAvailable): Changed to use the shared
dummy window class instead of creating our own.

* platform/win/DefWndProcWindowClass.cpp: Added.
(WebCore::registerClass): Register it!
(WebCore::defWndProcWindowClassName): Register it and return it!

* platform/win/DefWndProcWindowClass.h: Added.

Source/WebKit2:

Use WebCore's do-nothing window class instead of creating our own

* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
(WebKit::createDummyWindow): Less code!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Fri, 22 Apr 2011 16:39:47 +0000 (16:39 +0000)]
2011-04-22  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][WK2] Cannot play flash with NSPluginWrapper
        https://bugs.webkit.org/show_bug.cgi?id=59125

        * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
        (WebKit::NPN_GetValue): Handle the case when we have been
        called with a null plugin instance.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 22 Apr 2011 16:25:11 +0000 (16:25 +0000)]
2011-04-21  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        LayoutTestResults should know how to handle NRWT json files
        https://bugs.webkit.org/show_bug.cgi?id=59168

        LayoutTestResults was originally created to be a parallel
        to existing NRWT architecture for dealing with results files.
        But then it turns out that NRWT has no such architecture. :(
        So this patch writes the necessary code to handle reading
        full_results.json and unexpected_results.json files from
        NRWT layout-test-results directories.

        LayoutTestResults has thus morphed from being ORWT-only to
        supporting both ORWT and NRWT.  It's possible at some future
        point that other pieces of the NRWT architecture will learn
        how to read JSON files in which case this can go away.

        This is all done for making it possible for the commit-queue
        to run the tests using NWRT and be able to understand the results
        (for flaky test reporting, etc.)

        * Scripts/webkitpy/common/net/layouttestresults.py:
        * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        * Scripts/webkitpy/common/net/resultsjsonparser.py: Added.
        * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 22 Apr 2011 16:13:22 +0000 (16:13 +0000)]
2011-04-21  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        Content of <details> should be forwarded through the shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=59055

        * fast/html/details-add-child-1.html: Added.
        * fast/html/details-add-child-2.html: Added.
        * fast/html/details-remove-child-1.html: Added.
        * fast/html/details-remove-child-2.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/html/details-add-child-1-expected.checksum: Added.
        * platform/mac/fast/html/details-add-child-1-expected.png: Added.
        * platform/mac/fast/html/details-add-child-1-expected.txt: Added.
        * platform/mac/fast/html/details-add-child-2-expected.checksum: Added.
        * platform/mac/fast/html/details-add-child-2-expected.png: Added.
        * platform/mac/fast/html/details-add-child-2-expected.txt: Added.
        * platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-1-expected.txt:
        * platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-10-expected.txt:
        * platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-2-expected.txt:
        * platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-3-expected.txt:
        * platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-4-expected.txt:
        * platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-5-expected.txt:
        * platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-6-expected.txt:
        * platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-7-expected.txt:
        * platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-8-expected.txt:
        * platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-9-expected.txt:
        * platform/mac/fast/html/details-add-summary-child-1-expected.txt:
        * platform/mac/fast/html/details-add-summary-child-2-expected.txt:
        * platform/mac/fast/html/details-no-summary1-expected.txt:
        * platform/mac/fast/html/details-no-summary2-expected.txt:
        * platform/mac/fast/html/details-no-summary3-expected.txt:
        * platform/mac/fast/html/details-no-summary4-expected.txt:
        * platform/mac/fast/html/details-open-javascript-expected.txt:
        * platform/mac/fast/html/details-open1-expected.txt:
        * platform/mac/fast/html/details-open2-expected.txt:
        * platform/mac/fast/html/details-open3-expected.txt:
        * platform/mac/fast/html/details-open4-expected.txt:
        * platform/mac/fast/html/details-open5-expected.txt:
        * platform/mac/fast/html/details-open6-expected.txt:
        * platform/mac/fast/html/details-position-expected.txt:
        * platform/mac/fast/html/details-remove-child-1-expected.checksum: Added.
        * platform/mac/fast/html/details-remove-child-1-expected.png: Added.
        * platform/mac/fast/html/details-remove-child-1-expected.txt: Added.
        * platform/mac/fast/html/details-remove-child-2-expected.checksum: Added.
        * platform/mac/fast/html/details-remove-child-2-expected.png: Added.
        * platform/mac/fast/html/details-remove-child-2-expected.txt: Added.
        * platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
        * platform/mac/fast/html/details-remove-summary-1-expected.txt:
        * platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
        * platform/mac/fast/html/details-remove-summary-2-expected.txt:
        * platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
        * platform/mac/fast/html/details-remove-summary-3-expected.txt:
        * platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
        * platform/mac/fast/html/details-remove-summary-4-expected.txt:
        * platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
        * platform/mac/fast/html/details-remove-summary-5-expected.txt:
        * platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
        * platform/mac/fast/html/details-remove-summary-6-expected.txt:
        * platform/mac/fast/html/details-remove-summary-child-1-expected.txt:
        * platform/mac/fast/html/details-remove-summary-child-2-expected.txt:
        * platform/mac/fast/html/details-writing-mode-expected.txt:
2011-04-21  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        Content of <details> should be forwarded through the shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=59055

        - Made ShadowContentElement abstract and added shouldInclude() pure virtual method.
        - Added SummaryContentElement, DetailsContentElement, DetailsSummaryElement as
          subclasses of ShadowContentElement.
        - Gave two shadow children for HTMLDetailsElement. One is DetailsContentElement, that
          handles non-summary contents of <details>. Another is SummaryContentElement, that
          handles the main summary element.
        - Removed most of RenderDetails custom layout mechanism, which is replaced by
          ShadowContentElement subclasses.

        Tests: fast/html/details-add-child-1.html
               fast/html/details-add-child-2.html
               fast/html/details-remove-child-1.html
               fast/html/details-remove-child-2.html

        * dom/ShadowRoot.cpp:
        (WebCore::ShadowRoot::contentContainerFor):
        (WebCore::ShadowRoot::hostChildrenChanged):
        (WebCore::ShadowRoot::hasContentElement):
        * dom/ShadowRoot.h:
        * html/HTMLDetailsElement.cpp:
        (WebCore::DetailsContentElement::DetailsContentElement):
        (WebCore::DetailsContentElement::create):
        (WebCore::DetailsContentElement::shouldInclude):
        (WebCore::DetailsSummaryElement::DetailsSummaryElement):
        (WebCore::DetailsSummaryElement::create):
        (WebCore::DetailsSummaryElement::shouldInclude):
        (WebCore::HTMLDetailsElement::create):
        (WebCore::HTMLDetailsElement::HTMLDetailsElement):
        (WebCore::HTMLDetailsElement::ensureShadowSubtreeOf):
        (WebCore::findSummaryFor):
        (WebCore::HTMLDetailsElement::ensureMainSummary):
        (WebCore::HTMLDetailsElement::refreshMainSummary):
        (WebCore::HTMLDetailsElement::createShadowSubtree):
        * html/HTMLDetailsElement.h:
        * html/HTMLSummaryElement.cpp:
        (WebCore::SummaryContentElement::SummaryContentElement):
        (WebCore::SummaryContentElement::shouldInclude):
        (WebCore::SummaryContentElement::create):
        (WebCore::HTMLSummaryElement::createShadowSubtree):
        * html/shadow/ShadowContentElement.h:
        * rendering/RenderDetails.cpp:
        (WebCore::RenderDetails::RenderDetails):
        (WebCore::RenderDetails::addChild):
        * rendering/RenderDetails.h:
        * rendering/RenderSummary.cpp:
        * rendering/RenderSummary.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 22 Apr 2011 15:51:24 +0000 (15:51 +0000)]
2011-04-21  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Extra GraphicsContext::save() in InlineTextBox::paintDecoration()
        https://bugs.webkit.org/show_bug.cgi?id=59109

        Remove an extraneous GraphicsContext::save() in InlineTextBox::paintDecoration().

        Add an assertion that fires when a GraphicsContext() is destroyed with a non-
        empty state stack. Fix canvas to avoid this assertion, since bad content might
        trigger it.

        Also add an assertion that fires for mismatched begin/endTransparencyLayers.

        Test: fast/text/multiple-text-shadow-alpha.html

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::~HTMLCanvasElement):
        Make sure that the CanvasRenderingContext goes away before the ImageBuffer,
        so that CanvasRenderingContext2D has a chance to unwind the state stack in
        the ImageBuffer's GraphicsContext.

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
        Balance unmatched state saves in the canvas context.

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::~GraphicsContext):
        Assert that the stack is empty.

        * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
        (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
        (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
        (WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer):
        (WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer):
        Changes to allow for asserting for unmatched transparency layer begin/ends.

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paintDecoration):
        Remove an unbalanced save().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows DRT needs an implementation of shadowRoot.
jberlin@webkit.org [Fri, 22 Apr 2011 15:39:45 +0000 (15:39 +0000)]
Windows DRT needs an implementation of shadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=59081

Add media/audio-controls-do-not-fade-out.html, which uses layoutTestController.shadowRoot
to the win Skipped list to get the bots green.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Fri, 22 Apr 2011 15:34:21 +0000 (15:34 +0000)]
2011-04-22  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add Save As context menu item to the TextViewer.
        https://bugs.webkit.org/show_bug.cgi?id=59196

        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceSourceFrame.prototype.requestContent):
        (WebInspector.ResourceSourceFrame.prototype.suggestedFileName):
        (WebInspector.RevisionSourceFrame.prototype.requestContent):
        (WebInspector.RevisionSourceFrame.prototype.suggestedFileName):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._createSourceFrame):
        (WebInspector.SourceFrameDelegateForScriptsPanel):
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.formatSourceFilesToggled):
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._initializeTextViewer):
        (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
        (WebInspector.SourceFrame.prototype.suggestedFileName):
        (WebInspector.SourceFrameDelegate.prototype.formatSourceFilesToggled):
        (WebInspector.SourceFrameDelegate.prototype.suggestedFileName):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype._contextMenu):
        (WebInspector.TextViewerDelegate.prototype.cancelEditing):
        (WebInspector.TextViewerDelegate.prototype.populateLineGutterContextMenu):
        (WebInspector.TextViewerDelegate.prototype.populateTextAreaContextMenu):
        (WebInspector.TextViewerDelegate.prototype.suggestedFileName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate the Windows-specific results after r84558.
jberlin@webkit.org [Fri, 22 Apr 2011 15:21:45 +0000 (15:21 +0000)]
Update the Windows-specific results after r84558.

* platform/win/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Yi Shen <yi.4.shen@nokia.com>
yi.4.shen@nokia.com [Fri, 22 Apr 2011 14:43:07 +0000 (14:43 +0000)]
2011-04-22  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Upstream Symbian platform plugin
        https://bugs.webkit.org/show_bug.cgi?id=58435

        Upstream Symbian platform plugin.

        * Source/WebKit.pro: Add platformplugin path to the SUBDIRS.
2011-04-22  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Upstream Symbian platform plugin
        https://bugs.webkit.org/show_bug.cgi?id=58435

        Upstream Symbian platform plugin.

        * QtWebKit.pro: Add platformplugin.dll to the QtWebKit.sis.
        * symbian/platformplugin: Added.
        * symbian/platformplugin/WebPlugin.cpp: Added.
        (ItemListDelegate::ItemListDelegate):
        (ItemListDelegate::paint):
        (Popup::Popup):
        (Popup::resizeEvent):
        (Popup::populateList):
        (Popup::onItemSelected):
        (Popup::updateSelectionsBeforeDialogClosing):
        (Popup::updateAndClose):
        (WebPopup::WebPopup):
        (WebPopup::~WebPopup):
        (WebPopup::createSingleSelectionPopup):
        (WebPopup::createMultipleSelectionPopup):
        (WebPopup::createPopup):
        (WebPopup::show):
        (WebPopup::hide):
        (WebPopup::popupClosed):
        (WebPopup::itemClicked):
        (SingleSelectionPopup::SingleSelectionPopup):
        (MultipleSelectionPopup::MultipleSelectionPopup):
        (WebNotificationPresenter::showNotification):
        (WebPlugin::supportsExtension):
        (WebPlugin::createExtension):
        * symbian/platformplugin/WebPlugin.h: Added.
        (Popup::preSelectedIndices):
        (Popup::listWidget):
        (WebNotificationPresenter::WebNotificationPresenter):
        (WebNotificationPresenter::~WebNotificationPresenter):
        * symbian/platformplugin/platformplugin.pro: Added.
        * symbian/platformplugin/qwebkitplatformplugin.h: Copied from WebKit/qt/Api/qwebkitplatformplugin.h.
        (QWebSelectData::~QWebSelectData):
        (QWebSelectMethod::~QWebSelectMethod):
        (QWebNotificationData::~QWebNotificationData):
        (QWebNotificationPresenter::QWebNotificationPresenter):
        (QWebNotificationPresenter::~QWebNotificationPresenter):
        (QWebTouchModifier::~QWebTouchModifier):
        (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
        (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
        (QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
2011-04-22  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Upstream Symbian platform plugin
        https://bugs.webkit.org/show_bug.cgi?id=58435

        Exempting directory WebKit/qt/symbian/platformplugin from style guide.

        * Scripts/webkitpy/style/checker.py:
        * Scripts/webkitpy/style/checker_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Fri, 22 Apr 2011 13:52:13 +0000 (13:52 +0000)]
2011-04-22  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Move detailed heap snapshots storage and processing into workers.
        https://bugs.webkit.org/show_bug.cgi?id=59094

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * gyp/streamline-inspector-source.sh:
        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotGridNode.prototype.dispose):
        (WebInspector.HeapSnapshotObjectNode.prototype._createProvider):
        (WebInspector.HeapSnapshotInstanceNode.prototype._createProvider):
        (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
        (WebInspector.HeapSnapshotIteratorsTuple.prototype.dispose):
        (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.diffCalculated):
        (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
        (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
        (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
        (MixInSnapshotNodeFunctions):
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
        (WebInspector.HeapSnapshotSortableDataGrid.prototype.resetSortingCache):
        (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.dispose):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype._resetPaths):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.setDataSource):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.searchCancelled):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype._setRootChildrenForFinder):
        (WebInspector.DetailedHeapshotView.prototype.dispose):
        (WebInspector.DetailedHeapshotView.prototype.get profileWrapper):
        (WebInspector.DetailedHeapshotView.prototype.get baseProfileWrapper):
        * inspector/front-end/HeapSnapshot.js:
        (WebInspector.HeapSnapshotLoader):
        (WebInspector.HeapSnapshotLoader.prototype.finishLoading):
        (WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
        (WebInspector.HeapSnapshot.prototype.pushBaseIds):
        (WebInspector.HeapSnapshot.prototype.createDiff):
        (WebInspector.HeapSnapshot.prototype._parseFilter):
        (WebInspector.HeapSnapshot.prototype.createEdgesProvider):
        (WebInspector.HeapSnapshot.prototype.createNodesProvider):
        (WebInspector.HeapSnapshot.prototype.createPathFinder):
        (WebInspector.HeapSnapshot.prototype.updateStaticData):
        (WebInspector.HeapSnapshotPathFinder):
        (WebInspector.HeapSnapshotPathFinder.prototype.updateRoots):
        (WebInspector.HeapSnapshotPathFinder.prototype._reset):
        * inspector/front-end/HeapSnapshotProxy.js:
        (WebInspector.HeapSnapshotRealWorker):
        (WebInspector.HeapSnapshotRealWorker.prototype._messageReceived):
        (WebInspector.HeapSnapshotRealWorker.prototype.postMessage):
        (WebInspector.HeapSnapshotRealWorker.prototype.terminate):
        (WebInspector.HeapSnapshotFakeWorker):
        (WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
        (WebInspector.HeapSnapshotFakeWorker.prototype.terminate):
        (WebInspector.HeapSnapshotFakeWorker.prototype._postMessageFromWorker):
        (WebInspector.HeapSnapshotWorker):
        (WebInspector.HeapSnapshotWorker.prototype.createObject):
        (WebInspector.HeapSnapshotWorker.prototype.dispose):
        (WebInspector.HeapSnapshotWorker.prototype.disposeObject):
        (WebInspector.HeapSnapshotWorker.prototype.callGetter):
        (WebInspector.HeapSnapshotWorker.prototype.callFactoryMethod.wrapCallback):
        (WebInspector.HeapSnapshotWorker.prototype.callFactoryMethod):
        (WebInspector.HeapSnapshotWorker.prototype.callMethod):
        (WebInspector.HeapSnapshotWorker.prototype._findFunction):
        (WebInspector.HeapSnapshotWorker.prototype._messageReceived):
        (WebInspector.HeapSnapshotWorker.prototype._postMessage):
        (WebInspector.HeapSnapshotProxyObject):
        (WebInspector.HeapSnapshotProxyObject.prototype._callWorker):
        (WebInspector.HeapSnapshotProxyObject.prototype.dispose):
        (WebInspector.HeapSnapshotProxyObject.prototype.disposeWorker):
        (WebInspector.HeapSnapshotProxyObject.prototype.callFactoryMethod):
        (WebInspector.HeapSnapshotProxyObject.prototype.callGetter):
        (WebInspector.HeapSnapshotProxyObject.prototype.callMethod):
        (WebInspector.HeapSnapshotLoaderProxy):
        (WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading.callLoadCallbacks):
        (WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading.updateStaticData):
        (WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading):
        (WebInspector.HeapSnapshotLoaderProxy.prototype.get loaded):
        (WebInspector.HeapSnapshotLoaderProxy.prototype.startLoading):
        (WebInspector.HeapSnapshotLoaderProxy.prototype.pushJSONChunk):
        (WebInspector.HeapSnapshotProxy):
        (WebInspector.HeapSnapshotProxy.prototype.aggregates):
        (WebInspector.HeapSnapshotProxy.prototype.createDiff):
        (WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider):
        (WebInspector.HeapSnapshotProxy.prototype.createNodesProvider):
        (WebInspector.HeapSnapshotProxy.prototype.createPathFinder):
        (WebInspector.HeapSnapshotProxy.prototype.dispose):
        (WebInspector.HeapSnapshotProxy.prototype.finishLoading):
        (WebInspector.HeapSnapshotProxy.prototype.get loaded):
        (WebInspector.HeapSnapshotProxy.prototype.get nodeCount):
        (WebInspector.HeapSnapshotProxy.prototype.nodeFieldValuesByIndex):
        (WebInspector.HeapSnapshotProxy.prototype.pushBaseIds):
        (WebInspector.HeapSnapshotProxy.prototype.get rootNodeIndex):
        (WebInspector.HeapSnapshotProxy.prototype.updateStaticData):
        (WebInspector.HeapSnapshotProxy.prototype.startLoading):
        (WebInspector.HeapSnapshotProxy.prototype.get totalSize):
        (WebInspector.HeapSnapshotProxy.prototype.get uid):
        (WebInspector.HeapSnapshotProviderProxy):
        (WebInspector.HeapSnapshotProviderProxy.prototype.isEmpty):
        (WebInspector.HeapSnapshotProviderProxy.prototype.serializeNextItems):
        (WebInspector.HeapSnapshotProviderProxy.prototype.sortAndRewind):
        (WebInspector.HeapSnapshotPathFinderProxy):
        (WebInspector.HeapSnapshotPathFinderProxy.prototype.findNext):
        (WebInspector.HeapSnapshotPathFinderProxy.prototype.updateRoots):
        (WebInspector.HeapSnapshotsDiffProxy):
        (WebInspector.HeapSnapshotsDiffProxy.prototype.calculate):
        (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseIds):
        (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseSelfSizes):
        * inspector/front-end/HeapSnapshotWorker.js: Added.
        (WebInspector.UIString):
        (postMessageWrapper):
        * inspector/front-end/HeapSnapshotWorkerDispatcher.js: Added.
        (WebInspector.HeapSnapshotWorkerDispatcher):
        (WebInspector.HeapSnapshotWorkerDispatcher.prototype._findFunction):
        (WebInspector.HeapSnapshotWorkerDispatcher.prototype.dispatchMessage):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.else.parsed):
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:

2011-04-22  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Move detailed heap snapshots storage and processing into workers.
        https://bugs.webkit.org/show_bug.cgi?id=59094

        * WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 22 Apr 2011 13:49:04 +0000 (13:49 +0000)]
2011-04-22  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: fix de-obfuscation of scripts inlined in html.
        https://bugs.webkit.org/show_bug.cgi?id=58538

        * inspector/debugger/resources/obfuscated.js:
        * inspector/debugger/script-formatter-expected.txt:
        * inspector/debugger/script-formatter.html: Renamed from LayoutTests/inspector/debugger/script-formatter.html-disabled.
2011-04-22  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: fix de-obfuscation of scripts inlined in html.
        https://bugs.webkit.org/show_bug.cgi?id=58538

        Use html tokenizer to find script boundaries instead of relying on scriptParsed events.

        Test: inspector/debugger/script-formatter.html

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/JavaScriptFormatter.js: Renamed from Source/WebCore/inspector/front-end/UglifyJS/JavaScriptFormatter.js.
        * inspector/front-end/ScriptFormatter.js:
        (WebInspector.ScriptFormatter):
        (WebInspector.ScriptFormatter.prototype.formatContent):
        (WebInspector.ScriptFormatter.prototype._didFormatContent):
        * inspector/front-end/ScriptFormatterWorker.js:
        (onmessage):
        (formatScript):
        (HTMLScriptFormatter):
        (HTMLScriptFormatter.prototype.format):
        (HTMLScriptFormatter.prototype.scriptStarted):
        (HTMLScriptFormatter.prototype.scriptEnded):
        (HTMLScriptFormatter.prototype.styleSheetStarted):
        (HTMLScriptFormatter.prototype.styleSheetEnded):
        * inspector/front-end/SourceFile.js:
        (WebInspector.FormattedSourceFile.prototype._didRequestContent):
        * inspector/front-end/SourceHTMLTokenizer.js:
        (WebInspector.SourceHTMLTokenizer.prototype.scriptStarted):
        (WebInspector.SourceHTMLTokenizer.prototype.scriptEnded):
        (WebInspector.SourceHTMLTokenizer.prototype.styleSheetStarted):
        (WebInspector.SourceHTMLTokenizer.prototype.styleSheetEnded):
        (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
        * inspector/front-end/SourceHTMLTokenizer.re2js:
        * inspector/front-end/WebKit.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 22 Apr 2011 13:36:51 +0000 (13:36 +0000)]
2011-04-22  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Extensions API] misc API cleanup
        https://bugs.webkit.org/show_bug.cgi?id=59194

        * inspector/front-end/ExtensionAPISchema.json:
        * inspector/front-end/ExtensionPanel.js:
        (WebInspector.ExtensionSidebarPane.prototype._setObject):

2011-04-22  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Extensions API] misc API cleanup
        https://bugs.webkit.org/show_bug.cgi?id=59194

        * src/js/DevTools.js:
        (WebInspector.platformExtensionAPI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Fri, 22 Apr 2011 13:18:13 +0000 (13:18 +0000)]
2011-04-21  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: group content scripts in the scripts panel drop down.
        https://bugs.webkit.org/show_bug.cgi?id=59108

        * English.lproj/localizedStrings.js:
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
        (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Mike West <mkwst@google.com>
commit-queue@webkit.org [Fri, 22 Apr 2011 12:38:56 +0000 (12:38 +0000)]
2011-04-22  Mike West  <mkwst@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Tiny improvement to UI for adding an XHR breakpoint
        https://bugs.webkit.org/show_bug.cgi?id=59100

        Improve web inspector UI around adding XHR breakpoints by adding
        a textual label to the input-like `span` used to specify which
        XHR requests the breakpoint ought to target.

        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked.finishEditing):
        (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked):
        * inspector/front-end/inspector.css:
        (#breakpoint-condition-input):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 22 Apr 2011 12:35:29 +0000 (12:35 +0000)]
2011-04-22  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed. Build fix for ENABLE(INTERPRETER) after r84556.

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::visitAggregate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 22 Apr 2011 12:34:33 +0000 (12:34 +0000)]
2011-04-22  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: js formatter should never insert new tokens or remove existing tokens and comments.
        https://bugs.webkit.org/show_bug.cgi?id=59191

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/ScriptFormatter.js:
        (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks):
        (WebInspector.ScriptFormatter.prototype.formatContent):
        * inspector/front-end/ScriptFormatterWorker.js:
        (onmessage):
        * inspector/front-end/SourceFile.js:
        (WebInspector.SourceFile.prototype._loadResourceContent):
        (WebInspector.FormattedSourceFile.prototype._didRequestContent):
        (WebInspector.FormattedSourceMapping):
        (WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLine):
        (WebInspector.FormattedSourceMapping.prototype.sourceLineToScriptLocation):
        (WebInspector.FormattedSourceMapping.prototype._convertPosition):
        * inspector/front-end/UglifyJS/JavaScriptFormatter.js: Added.
        (FormattedContentBuilder): Helper class for building formatted script content.
        (FormattedContentBuilder.prototype.addToken):
        (FormattedContentBuilder.prototype.addSpace):
        (FormattedContentBuilder.prototype.addNewLine):
        (FormattedContentBuilder.prototype.increaseNestingLevel):
        (FormattedContentBuilder.prototype.decreaseNestingLevel):
        (FormattedContentBuilder.prototype.content):
        (FormattedContentBuilder.prototype.mapping):
        (Tokenizer): Wrapper class for UglifyJS tokenizer.
        (Tokenizer.prototype.content):
        (Tokenizer.prototype.next):
        (Tokenizer.prototype._convertUglifyToken):
        (JavaScriptFormatter): New formatter based on UglifyJS tokenizer.
        (JavaScriptFormatter.prototype.format):
        * inspector/front-end/UglifyJS/process.js: Removed.
        * inspector/front-end/WebKit.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Fri, 22 Apr 2011 12:32:14 +0000 (12:32 +0000)]
2011-04-22  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Refactor code prior to moving detailed heap snapshots into workers.
        https://bugs.webkit.org/show_bug.cgi?id=59189

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/BinarySearch.js: Added.
        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotGridNode.prototype._populate.sorted):
        (WebInspector.HeapSnapshotGridNode.prototype._populate):
        (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
        (WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort.afterPopulate):
        (WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort):
        (WebInspector.HeapSnapshotGridNode.prototype.sort):
        (WebInspector.HeapSnapshotObjectNode):
        (WebInspector.HeapSnapshotObjectNode.prototype._createChildNode):
        (WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode):
        (WebInspector.HeapSnapshotInstanceNode.prototype._enhanceData):
        (WebInspector.HeapSnapshotInstanceNode.prototype.get isDeletedNode):
        (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.diffCalculated):
        (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.baseIdsReceived):
        (WebInspector.HeapSnapshotDiffNode.prototype.get data):
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged.sort):
        (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
        (WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
        (WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingEnter):
        (WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave):
        (WebInspector.HeapSnapshotContainmentDataGrid):
        (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.setDataSource):
        (WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged):
        (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
        (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
        (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
        (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
        (WebInspector.HeapSnapshotDominatorsDataGrid):
        (WebInspector.HeapSnapshotDominatorsDataGrid.prototype._defaultPopulateCount.25.setDataSource):
        (WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype._performSorting):
        (WebInspector.DetailedHeapshotView.prototype._changeBase.baseProfileLoaded):
        (WebInspector.DetailedHeapshotView.prototype._changeBase):
        (WebInspector.DetailedHeapshotView.prototype._changeView):
        (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup.displayString):
        (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup):
        * inspector/front-end/HeapSnapshot.js:
        (WebInspector.HeapSnapshot.prototype.dispose):
        (WebInspector.HeapSnapshot.prototype.pushBaseNodeIds):
        (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.serializeNextItems):
        (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.sortAndRewind):
        (WebInspector.HeapSnapshotEdgesProvider.prototype._serialize):
        (WebInspector.HeapSnapshotNodesProvider.prototype._serialize):
        (WebInspector.HeapSnapshotsDiff.prototype.calculate):
        (WebInspector.HeapSnapshotsDiff.prototype.pushBaseIds):
        (WebInspector.HeapSnapshotsDiff.prototype.pushBaseSelfSizes):
        * inspector/front-end/HeapSnapshotProxy.js:
        (WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider):
        (WebInspector.HeapSnapshotProxy.prototype.createNodesProvider):
        (WebInspector.HeapSnapshotProxy.prototype.pushBaseIds):
        (WebInspector.HeapSnapshotProviderProxy):
        (WebInspector.HeapSnapshotProviderProxy.prototype.serializeNextItems):
        (WebInspector.HeapSnapshotProviderProxy.prototype.sortAndRewind):
        (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseIds):
        (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseSelfSizes):
        * inspector/front-end/PleaseWaitMessage.js:
        (WebInspector.PleaseWaitMessage.prototype.showAndWaitFor):
        (WebInspector.PleaseWaitMessage.prototype.unlistenAndHide):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:
        * inspector/front-end/utilities.js:

2011-04-22  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Refactor code prior to moving detailed heap snapshots into workers.
        https://bugs.webkit.org/show_bug.cgi?id=59189

        * inspector/profiler/detailed-heapshots-comparison-sorting.html:
        * inspector/profiler/detailed-heapshots-test.js:
        (initialize_DetailedHeapshotTest):
        (initialize_DetailedHeapshotTest.):
        * inspector/profiler/heap-snapshot-expected.txt:
        * inspector/profiler/heap-snapshot.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Fri, 22 Apr 2011 12:18:09 +0000 (12:18 +0000)]
2011-04-22  Mikhail Naganov  <mnaganov@chromium.org>

        Unreviewed fix after r84484 -- conditional statement was inverted incorrectly.

        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.handleShortcut):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Csaba Osztrogonác <ossy@webkit.org>
ossy@webkit.org [Fri, 22 Apr 2011 12:10:21 +0000 (12:10 +0000)]
2011-04-22  Csaba Osztrogonác  <ossy@webkit.org>

        [WK2] CSP reporting doesn't work
        https://bugs.webkit.org/show_bug.cgi?id=59192

        * platform/mac-wk2/Skipped: Add http/tests/security/contentSecurityPolicy/report-uri-from-child-frame.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt]fast/url/idna tests fail
ossy@webkit.org [Fri, 22 Apr 2011 11:24:29 +0000 (11:24 +0000)]
[Qt]fast/url/idna tests fail
https://bugs.webkit.org/show_bug.cgi?id=59187

* platform/qt/Skipped: Add fast/url/idna2003.html and fast/url/idna2008.html.
* platform/qt/fast/url/path-expected.txt: Update after r84606.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Fri, 22 Apr 2011 10:39:30 +0000 (10:39 +0000)]
2011-04-22  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt][WK2] Qt should use the mac-wk2 skipped list
        https://bugs.webkit.org/show_bug.cgi?id=58536

        * Scripts/old-run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Fri, 22 Apr 2011 10:04:50 +0000 (10:04 +0000)]
2011-04-22  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Timeline is too narrow
        https://bugs.webkit.org/show_bug.cgi?id=58399

        Changed Network Panel widths so that Timeline is 50%.
        Added titles to the values in the other columns, so that a tooltip will show the value if the column is too narrow.

        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel.prototype._createTable):  Changed column widths.
        (WebInspector.NetworkPanel.prototype._toggleGridMode): Changed column widths.
        (WebInspector.NetworkDataGridNode.prototype.refreshResource): Added titles to column values.
        (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell): Ditto
        (WebInspector.NetworkDataGridNode.prototype._refreshSizeCell): Ditto
        (WebInspector.NetworkDataGridNode.prototype._refreshTimeCell): Ditto
        * inspector/front-end/utilities.js:
        (Element.prototype.setTextAndTitle): Added new method to set the textContent and title of an Element at the same time, so that it can have a tooltip.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Fri, 22 Apr 2011 09:34:21 +0000 (09:34 +0000)]
2011-04-22  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Sam Weinig.

        [Qt][WK2] Implement DrawingAreaImpl for Qt.
        https://bugs.webkit.org/show_bug.cgi?id=59171

        * WebKit2.pro: Build files necessary for DrawingAreaImpl.
        * DerivedSources.pro: Build message receivers for DrawingArea and DrawingAreaProxy.

        * Shared/qt/LayerTreeContextQt.cpp:
        (WebKit::LayerTreeContext::LayerTreeContext): Stub.
        (WebKit::LayerTreeContext::~LayerTreeContext): Stub.
        (WebKit::LayerTreeContext::encode): Stub.
        (WebKit::LayerTreeContext::decode): Stub.
        (WebKit::LayerTreeContext::isEmpty): Stub.
        (WebKit::operator==): Stub.

        * Shared/qt/ShareableBitmapQt.cpp:
        (WebKit::ShareableBitmap::paint): Don't translate the painter to accomodate the
        source rect. The rect is already adjusted at the call site.

        * UIProcess/API/qt/qgraphicswkview.h: Add "Impl" to QGraphicsWKView::BackingStoreType.

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::createDrawingAreaProxy): Create DrawingAreaProxyImpl if requested.
        (QWKPagePrivate::paint): Call the correct paint() method for DrawingAreaProxyImpl,
        since this drawing area will simple ASSERT_NOT_REACHED() in the "normal" paint().

        * WebProcess/WebPage/DrawingArea.cpp:
        (WebKit::DrawingArea::create): Allow creation of DrawingAreaImpl for Qt.

        * UIProcess/BackingStore.h: Add Qt-specific types and backing store.

        * UIProcess/qt/BackingStoreQt.cpp:
        (WebKit::BackingStore::paint): Implemented.
        (WebKit::BackingStore::incorporateUpdate): Implemented.
        (WebKit::BackingStore::scroll): Implemented using QPixmap::scroll().

        * UIProcess/DrawingAreaProxy.h: Enable drawing area message receivers for Qt.
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didReceiveMessage): Ditto.
        * WebProcess/WebPage/DrawingArea.h: Ditto.
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::didReceiveMessage): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWinCairo build fix. Unreviewed.
jhoneycutt@apple.com [Fri, 22 Apr 2011 09:10:54 +0000 (09:10 +0000)]
WinCairo build fix. Unreviewed.

* WebProcess/Downloads/curl/DownloadCurl.cpp:
(WebKit::Download::useCredential):
Stubbed.
(WebKit::Download::continueWithoutCredential):
Stubbed.
(WebKit::Download::cancelAuthenticationChallenge):
Stubbed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9322486> REGRESSION (r83397): Default controls fade out when playing...
mitz@apple.com [Fri, 22 Apr 2011 08:31:42 +0000 (08:31 +0000)]
<rdar://problem/9322486> REGRESSION (r83397): Default controls fade out when playing audio-only media
https://bugs.webkit.org/show_bug.cgi?id=59180

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: media/audio-controls-do-not-fade-out.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::playbackProgressTimerFired): Only start fading out the controls if there is
a video track.

LayoutTests:

* media/audio-controls-do-not-fade-out-expected.txt: Added.
* media/audio-controls-do-not-fade-out.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNeed to support authentication for downloads in WebKit2 on Windows
jhoneycutt@apple.com [Fri, 22 Apr 2011 07:40:51 +0000 (07:40 +0000)]
Need to support authentication for downloads in WebKit2 on Windows
https://bugs.webkit.org/show_bug.cgi?id=59175
<rdar://problem/9206151>
<rdar://problem/8958280>

Reviewed by Maciej Stachowiak.

* WebProcess/Downloads/Download.cpp:
Include DownloadAuthenticationClient.h.

* WebProcess/Downloads/Download.h:
Declare a function to get or create the authentication client, a member
var to hold it, and functions that the client can call to use a
credential, continue without a credential, or cancel an auth challenge.

* WebProcess/Downloads/DownloadAuthenticationClient.cpp: Added.
(WebKit::DownloadAuthenticationClient::DownloadAuthenticationClient):
(WebKit::DownloadAuthenticationClient::receivedCredential):
Tell the Download to use the credential.
(WebKit::DownloadAuthenticationClient::receivedRequestToContinueWithoutCredential):
Tell the Download to continue with credentials.
(WebKit::DownloadAuthenticationClient::receivedCancellation):
Tell the Download to cancel the challenge.

* WebProcess/Downloads/DownloadAuthenticationClient.h: Added.
(WebKit::DownloadAuthenticationClient::create):
Return a new DownloadAuthenticationClient.
(WebKit::DownloadAuthenticationClient::detach):
Clear the Download.
(WebKit::DownloadAuthenticationClient::refAuthenticationClient):
(WebKit::DownloadAuthenticationClient::derefAuthenticationClient):

* WebProcess/Downloads/cfnet/DownloadCFNet.cpp:
(WebKit::Download::useCredential):
Create a CFURLCredentialRef from the WebCore credential, and tell
CFNetwork to use it for the auth challenge.
(WebKit::Download::continueWithoutCredential):
Call CFURLDownloadUseCredential with a null credential.
(WebKit::Download::cancelAuthenticationChallenge):
Cancel the download, and clear m_download.
(WebKit::Download::authenticationClient):
Create if needed and return a DownloadAuthenticationClient.
(WebKit::Download::platformInvalidate):
Detach the DownloadAuthenticationClient.
(WebKit::didReceiveAuthenticationChallengeCallback):
Call Download::didReceiveAuthenticationChallenge(), passing a
WebCore::AuthenticationChallenge with our DownloadAuthenticationClient.
(WebKit::Download::receivedCredential):
Get the client from the auth challenge, and call through to it.
(WebKit::Download::receivedRequestToContinueWithoutCredential):
Ditto.
(WebKit::Download::receivedCancellation):
Ditto.

* win/WebKit2.vcproj:
Add new files to project.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Luke Macpherson <macpherson@chromium.org>
commit-queue@webkit.org [Fri, 22 Apr 2011 07:40:32 +0000 (07:40 +0000)]
2011-04-22  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Eric Seidel.

        Add FontItalics and FontSmallCaps enums to be used instead of boolean values.
        https://bugs.webkit.org/show_bug.cgi?id=59080

        No new tests as no new functionality added.

        * css/CSSPrimitiveValueMappings.h:
        Add casts to/from FontItalics and FontSmallCaps
        * css/CSSStyleSelector.cpp:
        Use new casts defined in PrimitiveValueMappings.h
        * platform/graphics/Font.h:
        Use FontItalics enum.
        * platform/graphics/FontDescription.h:
        Define and use FontItalics and FontSmallCaps enums.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-22 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 22 Apr 2011 07:23:12 +0000 (07:23 +0000)]
2011-04-22  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        address maciej's styling feedback for results.html page
        https://bugs.webkit.org/show_bug.cgi?id=59165

        * fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 22 Apr 2011 07:09:30 +0000 (07:09 +0000)]
2011-04-21  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: exception in front-end when user selects resource info for resource that does not have response headers yet
        https://bugs.webkit.org/show_bug.cgi?id=59123

        * inspector/front-end/ResourceCookiesView.js:
        (WebInspector.ResourceCookiesView):
        (WebInspector.ResourceCookiesView.prototype.show):
        (WebInspector.ResourceCookiesView.prototype.get _gotCookies):
        (WebInspector.ResourceCookiesView.prototype._buildCookiesTable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Chris Weber <chris@lookout.net>
commit-queue@webkit.org [Fri, 22 Apr 2011 06:46:13 +0000 (06:46 +0000)]
2011-04-21  Chris Weber  <chris@lookout.net>

        Reviewed by Adam Barth.

        Add more test coverage to fast/url
        https://bugs.webkit.org/show_bug.cgi?id=59142

        The PASS/FAIL results for host, path, and port are set to match
        Chromium.  The PASS/FAIL results for idna2003 and idna2008 are set to
        match those specifications.

        * fast/url/host-expected.txt:
        * fast/url/idna2003-expected.txt: Added.
        * fast/url/idna2003.html: Added.
        * fast/url/idna2008-expected.txt: Added.
        * fast/url/idna2008.html: Added.
        * fast/url/path-expected.txt:
        * fast/url/port-expected.txt:
        * fast/url/script-tests/host.js:
        * fast/url/script-tests/idna2003.js: Added.
        * fast/url/script-tests/idna2008.js: Added.
        * fast/url/script-tests/path.js:
        * fast/url/script-tests/port.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84606 268f45cc-cd09-0410-ab3c-d52691b4dbfc