WebKit-https.git
16 years ago Reviewed by Darin. Landed by Maciej.
mjs [Tue, 7 Feb 2006 09:29:20 +0000 (09:29 +0000)]
    Reviewed by Darin. Landed by Maciej.

        - Several fixes to the site
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7105

        * blog/wp-content/themes/webkit/style.css:
        * index.html:
        * quality/bugwriting.html:
        * quality/reduction.html:
        * webkitdev.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
mjs [Tue, 7 Feb 2006 09:21:00 +0000 (09:21 +0000)]
LayoutTests:

        Reviewed by Eric.

        - test case that verifies that <object> containing html is treated
          like <iframe> in various respects
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7125

        * fast/dom/HTMLObjectElement/object-as-frame-expected.txt: Added.
        * fast/dom/HTMLObjectElement/object-as-frame.html: Added.

        - updated this test to reflect that the onload event now fires for iframes,
          including ones with empty src
        http://bugzilla.opendarwin.org/show_bug.cgi?id=3609

        * fast/events/event-targets-expected.checksum: Removed.
        * fast/events/event-targets-expected.png: Removed.
        * fast/events/event-targets-expected.txt:
        * fast/events/event-targets.html:

WebCore:

        Reviewed by Eric.

        - fixed "remove frame, renderer and completed flag from ChildFrame, make Frame track these"
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7125

        - fixed "onload event never called for iframe element with emtpy or about:blank src"
        http://bugzilla.opendarwin.org/show_bug.cgi?id=3609

        * bridge/mac/MacFrame.h:
        * bridge/mac/MacFrame.mm:
        (WebCore::MacFrame::MacFrame): pass along renderer
        (WebCore::MacFrame::nextKeyViewInFrameHierarchy): get owner element in newfangled way
        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge removeChild:]): don't mess with renderer
        (-[WebCoreFrameBridge init]): call new designated initializer
        (-[WebCoreFrameBridge initWithRenderer:]): new designated initializer
        (-[WebCoreFrameBridge dealloc]): don't mess with renderer
        (-[WebCoreFrameBridge finalize]): ditto
        (-[WebCoreFrameBridge installInFrame:]): ditto
        * page/Frame.cpp:
        (WebCore::FrameList::find): get name from frame not ChildFrame
        (WebCore::Frame::init): take renderer parameter
        (WebCore::Frame::clear): clear m_plugins, not m_objects
        (WebCore::Frame::childBegin): updated comment
        (WebCore::Frame::stop): add check-completed for documentless case here
        (WebCore::Frame::checkCompleted): don't track separate completed flag
        in ChildFrame, use the sub Frame object's own
        (WebCore::Frame::checkEmitLoadEvent): ditto
        (WebCore::Frame::requestFrame): don't store renderer and name in ChildFrame,
        instead pass them along
        (WebCore::Frame::requestObject): ditto above
        (WebCore::Frame::loadPlugin): expect renderer parameter
        (WebCore::Frame::loadSubframe): expect renderer and name parameters
        (WebCore::Frame::slotChildStarted): don't mess with ChildFrame
        (WebCore::Frame::slotChildCompleted): ditto
        (WebCore::Frame::childFrame): don't check m_objects
        (WebCore::Frame::frameExists): fix spacing, remove obsolete check and comment
        (WebCore::Frame::frameNames): get name from frame
        (WebCore::Frame::ownerElement): simplify a lot since the Frame knows its owner
        renderer now
        (WebCore::Frame::ownerRenderer): added
        (WebCore::Frame::canCachePage): check m_plugins not m_objects
        * page/Frame.h:
        * page/FramePrivate.h:
        (WebCore::ChildFrame): Remove constructor, most fields.
        (WebCore::FramePrivate::FramePrivate): Pass ownerRenderer
        * rendering/render_frames.cpp:
        (WebCore::RenderPartObject::updateWidget): Make sure to pass name attr
        to requestObject.

WebKit:

        Reviewed by Eric.

        - fixed "remove frame, renderer and completed flag from ChildFrame, make Frame track these"
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7125

        - fixed "onload event never called for iframe element with emtpy or about:blank src"
        http://bugzilla.opendarwin.org/show_bug.cgi?id=3609

        * WebCoreSupport/WebFrameBridge.h:
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge initWithPage:webView:renderer:frameName:view:]): Pass along renderer.
        (-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): Pass along renderer.
        * WebCoreSupport/WebPageBridge.m:
        (-[WebPageBridge initWithMainFrameName:webView:frameView:]): Pass null for renderer.
        * WebView/WebView.m:
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
adele [Tue, 7 Feb 2006 07:48:41 +0000 (07:48 +0000)]
LayoutTests:

        Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6944
          REGRESSION: crash when loading page w/ <link> that has a DOMSubtreeModified event listener

        * fast/events/event-listener-on-link.html: Added.
        * fast/events/event-listener-on-link-expected.txt: Added.
        * fast/events/event-listener-on-link-expected.png: Added.
        * fast/events/event-listener-on-link-expected.checksum: Added.

WebCore:

        Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6944
          REGRESSION: crash when loading page w/ <link> that has a DOMSubtreeModified event listener

        Test: fast/events/event-listener-on-link.html

        * khtml/xml/dom_elementimpl.h: Added createAttrImplIfNeeded, removed allocateImpl,
         changed AttrImpl contructor to remove createTextChild bool, added createTextChild method,
         changed getAttributeNode, getAttributeNodeNS, getNamedItem, getNamedItemNS, and item to return PassRefPtrs.
        (DOM::ElementImpl::getAttributeNode):
        * khtml/xml/dom_elementimpl.cpp:
        (WebCore::AttributeImpl::createAttrImplIfNeeded): New method to replace allocateImpl.
         This will use a RefPtr for the AttrImpl, check for an existing AttrImpl, create one if there isn't one,
         and will call the new createTextChild.
        (WebCore::AttrImpl::AttrImpl):  Moved creation of text child to new createTextChild method.
         If done in the constructor, the ref count is still 0, and the act of appending the text node
         could cause the AttrImpl to be destroyed.
        (WebCore::AttrImpl::createTextChild): Moved code from AttrImpl contructor.
         Also, I've added an assert to make sure that any callers of this have ref'd the AttrImpl.
        (WebCore::AttrImpl::cloneNode): Used RefPtr instead of PassRefPtr, and then called release() on it before returning.
        (WebCore::ElementImpl::cloneNode): ditto.
        (WebCore::ElementImpl::getAttributeNodeNS): Changed return type to PassRefPtr.
        (WebCore::NamedAttrMapImpl::getNamedItemNS): ditto.
        (WebCore::NamedAttrMapImpl::getNamedItem): ditto. Changed use of allocateImpl to createAttrImplIfNeeded
        (WebCore::NamedAttrMapImpl::setNamedItem): ditto.
        (WebCore::NamedAttrMapImpl::removeNamedItem): ditto.
        (WebCore::NamedAttrMapImpl::item): ditto.
        * khtml/xml/DocumentImpl.cpp:
        (WebCore::DocumentImpl::createAttributeNS): Changed return type to PassRefPtr and removed bool from AttrImpl contructor call.
        * khtml/xml/DocumentImpl.h: Now returns a PassRefPtr for createAttribute and createAttributeNS.
        (WebCore::DocumentImpl::createAttribute):
        * khtml/xml/NamedNodeMapImpl.h: Now returns a PassRefPtr for getNamedItem, getNamedItemNS, and item.
        (WebCore::NamedNodeMapImpl::getNamedItem):
        * bindings/objc/DOM.mm:
        (-[DOMNamedNodeMap getNamedItem:]): Call get() since the methods discussed above now return PassRefPtrs.
        (-[DOMNamedNodeMap item:]): ditto.
        (-[DOMNamedNodeMap getNamedItemNS::]): ditto.
        (-[DOMDocument createAttribute:]): ditto.
        (-[DOMDocument createAttributeNS::]): ditto.
        (-[DOMElement getAttributeNode:]): ditto.
        (-[DOMElement getAttributeNodeNS::]): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
mjs [Tue, 7 Feb 2006 07:37:04 +0000 (07:37 +0000)]
    Reviewed by Darin.

        - fixed 7094: onfocus/onblur on non-form-controls bubble
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7094

        * khtml/html/HTMLElementImpl.cpp:
        (WebCore::HTMLElementImpl::parseMappedAttribute): connect onfocus/onblur to
        focus/blur, not DOMFocusIn/DOMFocusOut

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
mjs [Tue, 7 Feb 2006 07:14:16 +0000 (07:14 +0000)]
    Reviewed by Darin.

        - test for 7094: onfocus/onblur on non-form-controls bubble
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7094

        * fast/events/div-focus-expected.txt: Added.
        * fast/events/div-focus.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix build bustage on Mac.
hyatt [Tue, 7 Feb 2006 07:07:37 +0000 (07:07 +0000)]
Fix build bustage on Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix build bustage on Mac.
hyatt [Tue, 7 Feb 2006 07:06:00 +0000 (07:06 +0000)]
Fix build bustage on Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-02-06 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 7 Feb 2006 06:57:35 +0000 (06:57 +0000)]
2006-02-06  Eric Seidel  <eseidel@apple.com>

        Add svn:ignore properties for visual studio internals.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-02-06 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 7 Feb 2006 06:56:03 +0000 (06:56 +0000)]
2006-02-06  Eric Seidel  <eseidel@apple.com>

        Add svn:ignore properties for visual studio internals.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-02-06 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 7 Feb 2006 06:52:55 +0000 (06:52 +0000)]
2006-02-06  Eric Seidel  <eseidel@apple.com>

        Reviewed by hyatt.

        Fix build-webkit for use on win32 (unblocks buildbot usage).
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7122

        * Scripts/build-webkit: use ifCygwin() to conditionalize builds
        * Scripts/webkitdirs.pm: add ifOSX() and ifCygwin()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoRename SystemTime.cpp to SystemTimeWin.cpp
hyatt [Tue, 7 Feb 2006 06:30:34 +0000 (06:30 +0000)]
Rename SystemTime.cpp to SystemTimeWin.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoRename SystemTime.cpp to SystemTimeWin.cpp
hyatt [Tue, 7 Feb 2006 06:29:41 +0000 (06:29 +0000)]
Rename SystemTime.cpp to SystemTimeWin.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoRemove accidentally committed file.
hyatt [Tue, 7 Feb 2006 06:28:01 +0000 (06:28 +0000)]
Remove accidentally committed file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix more build bustage.
hyatt [Tue, 7 Feb 2006 06:15:06 +0000 (06:15 +0000)]
Fix more build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLand image viewer test app.
hyatt [Tue, 7 Feb 2006 06:13:12 +0000 (06:13 +0000)]
Land image viewer test app.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
ap [Tue, 7 Feb 2006 06:11:17 +0000 (06:11 +0000)]
    Reviewed by Darin.

        - Refactor DateInstance to provide direct access to data. Several WIN32 modifications.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7107

        - No tests added - only changed functionality on WIN32, which should be covered by
        existing tests.

        * kjs/date_object.cpp:
        (gmtoffset): On WIN32, use the recommended global (_timezone rather than timezone).
        Updated comments.
        (KJS::timeZoneOffset): Removed, was basically the same as the above.
        (KJS::formatTime): Pass an UTC flag - UTC/local cannot be correctly selected on
        Windows based on struct tm itself.
        (KJS::DateInstance::getTime): Added.
        (KJS::DateInstance::getUTCTime): Added.
        (KJS::millisecondsToTM): Factored out from DateProtoFunc::callAsFunction().
        (KJS::DateObjectImp::callAsFunction): Use the new parameter to formatTime().
        (KJS::DateProtoFunc::callAsFunction): Updated for the other changes. The code for
        GetTimezoneOffset was incorrect on WIN32 - _daylight global has nothing to do
        with daylight savings time being in effect.

        * kjs/date_object.h: Added prototypes for new functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoRemove stray .cvsignore file accidentally committed.
hyatt [Tue, 7 Feb 2006 05:55:20 +0000 (05:55 +0000)]
Remove stray .cvsignore file accidentally committed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix build bustage. Missed a file.
hyatt [Tue, 7 Feb 2006 05:51:39 +0000 (05:51 +0000)]
Fix build bustage. Missed a file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLand new image code (excluding the test app, work to do there still)
hyatt [Tue, 7 Feb 2006 05:37:19 +0000 (05:37 +0000)]
Land new image code (excluding the test app, work to do there still)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoCommit remaining Cairo files.
hyatt [Tue, 7 Feb 2006 05:30:22 +0000 (05:30 +0000)]
Commit remaining Cairo files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLand Cairo itself.
hyatt [Tue, 7 Feb 2006 05:13:31 +0000 (05:13 +0000)]
Land Cairo itself.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLand pixman portion of Cairo.
hyatt [Tue, 7 Feb 2006 05:10:21 +0000 (05:10 +0000)]
Land pixman portion of Cairo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLand pixman portion of Cairo.
hyatt [Tue, 7 Feb 2006 05:04:08 +0000 (05:04 +0000)]
Land pixman portion of Cairo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoCommit cairo. Having to do this in pieces since the commit hangs otherwise.
hyatt [Tue, 7 Feb 2006 04:51:09 +0000 (04:51 +0000)]
Commit cairo. Having to do this in pieces since the commit hangs otherwise.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoCommit cairo. Having to do this in pieces since the commit hangs otherwise.
hyatt [Tue, 7 Feb 2006 04:51:01 +0000 (04:51 +0000)]
Commit cairo. Having to do this in pieces since the commit hangs otherwise.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoCommit cairo. Having to do this in pieces since the commit hangs otherwise.
hyatt [Tue, 7 Feb 2006 04:50:42 +0000 (04:50 +0000)]
Commit cairo. Having to do this in pieces since the commit hangs otherwise.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoCommit cairo. Having to do this in pieces since the commit hangs otherwise.
hyatt [Tue, 7 Feb 2006 04:50:28 +0000 (04:50 +0000)]
Commit cairo. Having to do this in pieces since the commit hangs otherwise.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoCommit cairo. Having to do this in pieces since the commit hangs otherwise.
hyatt [Tue, 7 Feb 2006 04:48:45 +0000 (04:48 +0000)]
Commit cairo. Having to do this in pieces since the commit hangs otherwise.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoCommit cairo. Having to do this in pieces since the commit hangs otherwise.
hyatt [Tue, 7 Feb 2006 04:48:03 +0000 (04:48 +0000)]
Commit cairo. Having to do this in pieces since the commit hangs otherwise.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin and Eric.
vicki [Tue, 7 Feb 2006 03:39:54 +0000 (03:39 +0000)]
    Reviewed by Darin and Eric.

        - fix <rdar://problem/4414918> REGRESSION: images dragged into contenteditable area
        end up outside of editable area (6525)

        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:]): Moved code from
        elementAtPoint to this new method.  This method takes a point and returns a NodeInfo
        for the deepest node at that point.
        (-[WebCoreFrameBridge elementAtPoint:]): Use new nodeInfoAtPoint method.
        (-[WebCoreFrameBridge _visiblePositionForPoint:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-02-06 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 7 Feb 2006 03:16:28 +0000 (03:16 +0000)]
2006-02-06  Eric Seidel  <eseidel@apple.com>

        Rubber-stamped by darin & mjs.

        Added new support directory for build slave scripts.
        Committing the first script, for use by the PLT's build slave.
        This script is used to kick of the PLT (Page Load Test) slave.

        * BuildSlaveSupport: Added.
        * BuildSlaveSupport/run-performance-tests: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by NOBODY (OOPS!).
darin [Tue, 7 Feb 2006 02:47:46 +0000 (02:47 +0000)]
    Reviewed by NOBODY (OOPS!).

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7071
          REGRESSION: Jumping to an anchor identifier makes page scroll horizontally

        * fast/overflow/scroll-vertical-not-horizontal.html: Added.
        * fast/overflow/scroll-vectical-not-horizontal-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by NOBODY (OOPS!).
darin [Tue, 7 Feb 2006 02:47:38 +0000 (02:47 +0000)]
    Reviewed by NOBODY (OOPS!).

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7071
          REGRESSION: Jumping to an anchor identifier makes page scroll horizontally

        Test: fast/overflow/scroll-vertical-not-horizontal.html

        * rendering/render_layer.cpp: (WebCore::RenderLayer::getRectToExpose):
        Fixed rectangle intersections so that the X and Y dimensions are independent,
        to fix the bug. Also restructured the function a bit so it's even easier to
        read and understand.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago * WebKitSystemInterface.h:
sullivan [Tue, 7 Feb 2006 01:16:06 +0000 (01:16 +0000)]
    * WebKitSystemInterface.h:
        * libWebKitSystemInterface.a:
        removed WKExecutableLinkedInTigerOrEarlier

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Suggested by Darin.
harrison [Tue, 7 Feb 2006 01:15:34 +0000 (01:15 +0000)]
    Suggested by Darin.

        * khtml/html/HTMLElementImpl.cpp:
        (WebCore::HTMLElementImpl::createContextualFragment):
        - make nextChild a RefPtr to survive possible DOM changes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej Stachowiak.
sullivan [Tue, 7 Feb 2006 01:10:19 +0000 (01:10 +0000)]
    Reviewed by Maciej Stachowiak.

        * WebView/WebPDFView.m:
        (-[WebPDFView menuForEvent:]):
        Removed use of WKExecutableLinkedInTigerOrEarlier() by modifying backward-compatibility
        hack involving PDF view context menus. Now we only bother to make sure that the PDFKit-
        supplied context menu items are present in Safari, for the benefit of the open source
        folks using tip of tree WebKit but older released Safari; it's possible that some other
        existing WebKit apps won't show all the PDF view context menu items.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-02-06 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 7 Feb 2006 00:57:21 +0000 (00:57 +0000)]
2006-02-06  Eric Seidel  <eseidel@apple.com>

        Rubber-stamped by darin.

        Adding setSourceDir for scripts stored in non-standard locations.

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by John and Adele
bdakin [Mon, 6 Feb 2006 23:35:09 +0000 (23:35 +0000)]
    Reviewed by John and Adele

        Fix for <rdar://problem/4323167> REGRESSION (TOT): Crash in
        RenderTable::colToEffCol entering text into text input field

        Some of the autofill code assumes that the form's label is in a
        table cell, but this is not necessarily the case. This fix checks
        that the renderer is actually a table cell before treating it as
        such.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by John.
darin [Mon, 6 Feb 2006 19:56:29 +0000 (19:56 +0000)]
    Reviewed by John.

        - fix <rdar://problem/4432562> REGRESSION (TOT):
          Safari's "stop loading" active, "view source" inactive after page load [7058]
          http://bugzilla.opendarwin.org/show_bug.cgi?id=7058

        * page/Frame.h: Make redirectionTimerFired virtual.
        * bridge/mac/MacFrame.h: Override redirectionTimerFired.
        * bridge/mac/MacFrame.mm: (WebCore::MacFrame::redirectionTimerFired):
        Send the redirectionTimerCancelled callback here, even though it has
        fired rather than being cancelled.

        * manual-tests/redirect.html: Added.
        * manual-tests/redirection-target.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by John.
harrison [Mon, 6 Feb 2006 18:29:20 +0000 (18:29 +0000)]
    Reviewed by John.

        Fix TOT regression where Mail.app replies were getting truncated.
        Was caused by 1/26/2006 checkin for http://bugzilla.opendarwin.org/show_bug.cgi?id=6754

        No layout test because this code cannot be reached via JS operations.

        * khtml/html/HTMLElementImpl.cpp:
        (WebCore::HTMLElementImpl::createContextualFragment):
        - restore code that sampled nextSibling() before node is removed
        - also, add asserts that the DOM mutation methods yield a 0 exception code, so problems
          can be caught closer to the cause.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Remove remaining .subproj references to fix release build.
mjs [Mon, 6 Feb 2006 09:35:50 +0000 (09:35 +0000)]
    Remove remaining .subproj references to fix release build.

        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Rubber stamped by Hyatt.
mjs [Mon, 6 Feb 2006 08:58:05 +0000 (08:58 +0000)]
    Rubber stamped by Hyatt.

        - renamed subproject directories to not end with .subproj

        * Carbon: renamed from Carbon.subproj
        * DOM: renamed from DOM.subproj
        * History: renamed from History.subproj
        * Misc: renamed from Misc.subproj
        * Panels: renamed from Panels.subproj
        * Plugins: renamed from Plugins.subproj
        * WebCoreSupport: renamed from WebCoreSupport.subproj
        * WebInspector: renamed from WebInspector.subproj
        * WebView: renamed from WebView.subproj

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Ooops, I made a last-minute change to my last patch that broke the build...
mjs [Mon, 6 Feb 2006 08:10:25 +0000 (08:10 +0000)]
    Ooops, I made a last-minute change to my last patch that broke the build - fixed.

        * WebView.subproj/WebFrame.m:
        (-[WebFrame _closeOldDataSources]):
        (-[WebFrame _detachFromParent]):
        (-[WebFrame _transitionToCommitted:]):
        (-[WebFrame _checkLoadCompleteForThisFrame]):
        (-[WebFrame _handledOnloadEvents]):
        (-[WebFrame _loadItem:withLoadType:]):
        (-[WebFrame _goToItem:withLoadType:]):
        (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]):
        (-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
        (-[WebFrame _clientRedirectCancelled:]):
        * WebView.subproj/WebFramePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Anders.
mjs [Mon, 6 Feb 2006 07:49:05 +0000 (07:49 +0000)]
    Reviewed by Anders.

        - fixed ~1100 KJS::Node leaked on layout tests
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7097

        * kjs/internal.cpp:
        (KJS::Parser::noteNodeCycle):
        (KJS::Parser::removeNodeCycle):
        (KJS::clearNewNodes):
        * kjs/internal.h:
        * kjs/nodes.cpp:
        (ElementNode::breakCycle):
        (PropertyListNode::breakCycle):
        (ArgumentListNode::breakCycle):
        (StatListNode::StatListNode):
        (StatListNode::breakCycle):
        (VarDeclListNode::breakCycle):
        (BlockNode::BlockNode):
        (ClauseListNode::breakCycle):
        (CaseBlockNode::CaseBlockNode):
        (ParameterNode::breakCycle):
        (SourceElementsNode::SourceElementsNode):
        (SourceElementsNode::breakCycle):
        * kjs/nodes.h:
        (KJS::Node::breakCycle):
        (KJS::ElementNode::ElementNode):
        (KJS::ArrayNode::ArrayNode):
        (KJS::PropertyListNode::PropertyListNode):
        (KJS::ObjectLiteralNode::ObjectLiteralNode):
        (KJS::ArgumentListNode::ArgumentListNode):
        (KJS::ArgumentsNode::ArgumentsNode):
        (KJS::VarDeclListNode::VarDeclListNode):
        (KJS::VarStatementNode::VarStatementNode):
        (KJS::ForNode::ForNode):
        (KJS::CaseClauseNode::CaseClauseNode):
        (KJS::ClauseListNode::ClauseListNode):
        (KJS::ParameterNode::ParameterNode):
        (KJS::FuncExprNode::FuncExprNode):
        (KJS::FuncDeclNode::FuncDeclNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
mjs [Mon, 6 Feb 2006 07:25:36 +0000 (07:25 +0000)]
    Reviewed by Darin.

        - shuffle things around so that WebFrame no longer has a WebView backpointer, the backpointer is
        at the bridge level.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7093

        * WebCoreSupport.subproj/WebFrameBridge.h:
        * WebCoreSupport.subproj/WebFrameBridge.m:
        (-[WebFrameBridge initWithPage:webView:frameName:view:]):
        (-[WebFrameBridge page]):
        (-[WebFrameBridge mainFrame]):
        (-[WebFrameBridge webView]):
        (-[WebFrameBridge createWindowWithURL:frameName:]):
        (-[WebFrameBridge showWindow]):
        (-[WebFrameBridge areToolbarsVisible]):
        (-[WebFrameBridge setToolbarsVisible:]):
        (-[WebFrameBridge isStatusbarVisible]):
        (-[WebFrameBridge setStatusbarVisible:]):
        (-[WebFrameBridge setWindowFrame:]):
        (-[WebFrameBridge windowFrame]):
        (-[WebFrameBridge setWindowContentRect:]):
        (-[WebFrameBridge windowContentRect]):
        (-[WebFrameBridge setWindowIsResizable:]):
        (-[WebFrameBridge windowIsResizable]):
        (-[WebFrameBridge firstResponder]):
        (-[WebFrameBridge makeFirstResponder:]):
        (-[WebFrameBridge closeWindowSoon]):
        (-[WebFrameBridge runJavaScriptAlertPanelWithMessage:]):
        (-[WebFrameBridge runJavaScriptConfirmPanelWithMessage:]):
        (-[WebFrameBridge canRunBeforeUnloadConfirmPanel]):
        (-[WebFrameBridge runBeforeUnloadConfirmPanelWithMessage:]):
        (-[WebFrameBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]):
        (-[WebFrameBridge addMessageToConsole:]):
        (-[WebFrameBridge runOpenPanelForFileButtonWithResultListener:]):
        (-[WebFrameBridge setStatusText:]):
        (-[WebFrameBridge startLoadingResource:withURL:customHeaders:]):
        (-[WebFrameBridge startLoadingResource:withURL:customHeaders:postData:]):
        (-[WebFrameBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
        (-[WebFrameBridge focusWindow]):
        (-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]):
        (-[WebFrameBridge userAgentForURL:]):
        (-[WebFrameBridge _nextKeyViewOutsideWebFrameViewsWithValidityCheck:]):
        (-[WebFrameBridge previousKeyViewOutsideWebFrameViews]):
        (-[WebFrameBridge defersLoading]):
        (-[WebFrameBridge setDefersLoading:]):
        (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]):
        (-[WebFrameBridge _preferences]):
        (-[WebFrameBridge selectWordBeforeMenuEvent]):
        (-[WebFrameBridge historyLength]):
        (-[WebFrameBridge canGoBackOrForward:]):
        (-[WebFrameBridge goBackOrForward:]):
        (-[WebFrameBridge print]):
        (-[WebFrameBridge pollForAppletInView:]):
        (-[WebFrameBridge respondToChangedContents]):
        (-[WebFrameBridge respondToChangedSelection]):
        (-[WebFrameBridge undoManager]):
        (-[WebFrameBridge issueCutCommand]):
        (-[WebFrameBridge issueCopyCommand]):
        (-[WebFrameBridge issuePasteCommand]):
        (-[WebFrameBridge issuePasteAndMatchStyleCommand]):
        (-[WebFrameBridge canPaste]):
        (-[WebFrameBridge overrideMediaType]):
        (-[WebFrameBridge isEditable]):
        (-[WebFrameBridge shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
        (-[WebFrameBridge shouldBeginEditing:]):
        (-[WebFrameBridge shouldEndEditing:]):
        (-[WebFrameBridge windowObjectCleared]):
        (-[WebFrameBridge spellCheckerDocumentTag]):
        (-[WebFrameBridge isContinuousSpellCheckingEnabled]):
        (-[WebFrameBridge didFirstLayout]):
        (-[WebFrameBridge dashboardRegionsChanged:]):
        (-[WebFrameBridge createModalDialogWithURL:]):
        (-[WebFrameBridge canRunModal]):
        (-[WebFrameBridge runModal]):
        * WebCoreSupport.subproj/WebPageBridge.h:
        * WebCoreSupport.subproj/WebPageBridge.m:
        (-[WebPageBridge initWithMainFrameName:webView:frameView:]):
        (-[WebPageBridge webView]):
        * WebView.subproj/WebDataSource.m:
        (-[WebDataSource _fileWrapperForURL:]):
        (-[WebDataSource _webView]):
        (-[WebDataSource _setLoading:]):
        (-[WebDataSource _startLoading:]):
        (-[WebDataSource _setTitle:]):
        (-[WebDataSource _setRequest:]):
        (-[WebDataSource _updateIconDatabaseWithURL:]):
        (-[WebDataSource _defersCallbacksChanged]):
        (-[WebDataSource _setWebFrame:]):
        * WebView.subproj/WebDataSourcePrivate.h:
        * WebView.subproj/WebFrame.m:
        (-[WebFrame _traverseNextFrameStayWithin::]):
        (-[WebFrame _detachFromParent]):
        (-[WebFrame _setDataSource:]):
        (-[WebFrame _loadDataSource:withLoadType:formState:]):
        (-[WebFrame _initWithWebFrameView:webView:bridge:]):
        (-[WebFrame dealloc]):
        (-[WebFrame finalize]):
        (-[WebFrame webView]):
        * WebView.subproj/WebFrameView.m:
        (-[WebFrameView _webView]):
        (-[WebFrameView _goBack]):
        (-[WebFrameView _goForward]):
        * WebView.subproj/WebFrameViewInternal.h:
        * WebView.subproj/WebView.m:
        (-[WebView _createFrameNamed:inParent:allowsScrolling:]):
        (-[WebView _commonInitializationWithFrameName:groupName:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-02-05 Anders Carlsson <andersca@mac.com>
andersca [Mon, 6 Feb 2006 07:06:43 +0000 (07:06 +0000)]
2006-02-05  Anders Carlsson  <andersca@mac.com>

        Reviewed by Maciej.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=7091
        Autogenerate even more.

        * JSCore.cpp:
        Add new generated files.

        * bindings/scripts/CodeGeneratorJS.pm:
        Add "IsIndex" extended attribute for parameters. Any parameter that is "unsigned long"
        and has this attribute will be checked to make sure that it's not < 0. If it is, an index size error
        exception will be thrown.

        * khtml/ecma/kjs_dom.cpp:
        (KJS::toAttr):
        Use JSAttr::info.

        (KJS::getDOMNode):
        Use new constructors.

        * khtml/ecma/kjs_dom.h:
        Remove classes that are generated now.

        * khtml/xml/Attr.idl: Added.
        * khtml/xml/CharacterData.idl: Added.
        * khtml/xml/Entity.idl: Added.
        * khtml/xml/Notation.idl: Added.
        * khtml/xml/ProcessingInstruction.idl: Added.
        * khtml/xml/Text.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-02-05 Eric Seidel <eseidel@apple.com>
eseidel [Mon, 6 Feb 2006 05:57:30 +0000 (05:57 +0000)]
2006-02-05  Eric Seidel  <eseidel@apple.com>

        Reviewed by darin.

        General update to SVG project page, also link to status page.

        * projects/svg/index.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-02-05 Eric Seidel <eseidel@apple.com>
eseidel [Mon, 6 Feb 2006 05:36:19 +0000 (05:36 +0000)]
2006-02-05  Eric Seidel  <eseidel@apple.com>

        Rubber stamped by darin.

        * projects/svg/status.xml: Added.
        * projects/svg/svg-status.css: Added.
        * projects/svg/svg-status.xsl: Added.

2006-02-05  Eric Seidel  <eseidel@apple.com>

        Adding ChangeLog :)

        * ChangeLog: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - converted three more files from UTF-16 to ASCII that had no reason to be...
darin [Mon, 6 Feb 2006 02:36:46 +0000 (02:36 +0000)]
    - converted three more files from UTF-16 to ASCII that had no reason to be UTF-16

        * fast/dom/resources/top.html: Just straight conversion to ASCII.
        * fast/events/updateLayoutForHitTest.html: Converted one character to an entity,
        and reformatted the file a bit.
        * fast/text/line-breaks.html: Just straight conversion to ASCII.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
mjs [Sun, 5 Feb 2006 23:07:54 +0000 (23:07 +0000)]
LayoutTests:

        Reviewed by Darin.

        Re-landing test case for:
        - various event cleanup, including fixing of the load event for iframes
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7079

        * fast/events/iframe-object-onload-expected.txt: Added.
        * fast/events/iframe-object-onload.html: Added.

        - changed expected results and description for this test, unload should
        not fire in this case:

        * fast/events/onunload-body-property-expected.txt:
        * fast/events/onunload-body-property.html:

        - changed from UTF-16 to ASCII, there was no reason for this to be UTF-16.

        * fast/dom/attr_dead_doc.html:

WebCore:

        Reviewed by Darin.

        Re-landed the following with more fixes so it does not break tests:

        - various event cleanup, including fixing of the load event for iframes
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7079

        Specific changes:

        - don't bother to nil-check the document, a node can never have a null document now
        - move temp event forgetting from dispatchEvent to dispatchGenericEvent
        - pass event down using RefPtr::release() to avoid ref thrashing
        - support default handlers even for non-bubbling events (only on
          target node) and skip calling default event handler explicitly in
          callers
        - dispatch a whole separate load event to a frame document's containing frame
        - don't let propagationStopped prevent this new event
        - remove bogus security check for iframe onload
        - dispatch window events on the document, not the body, and also for non-html
        - set onload, onunload, onbeforeunload from frameset tags on the window object
        - don't restrict load/unload events to HTML
        - send default handler to the dispatch object as previously

        * bridge/mac/MacFrame.mm:
        (WebCore::MacFrame::shouldClose):
        * khtml/html/html_baseimpl.cpp:
        (WebCore::HTMLFrameElementImpl::parseMappedAttribute):
        (WebCore::HTMLFrameSetElementImpl::parseMappedAttribute):
        * khtml/xml/DocumentImpl.cpp:
        (WebCore::DocumentImpl::implicitClose):
        * khtml/xml/NodeImpl.cpp:
        (WebCore::NodeImpl::dispatchEvent):
        (WebCore::NodeImpl::dispatchGenericEvent):
        (WebCore::NodeImpl::dispatchWindowEvent):
        * khtml/xml/NodeImpl.h:
        * page/Frame.cpp:
        (WebCore::Frame::stopLoading):
        (WebCore::Frame::setWindowHasFocus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Geoff.
darin [Sun, 5 Feb 2006 20:31:03 +0000 (20:31 +0000)]
    Reviewed by Geoff.

        - fix <rdar://problem/4197997> -[DOMHTMLSelectElement options] always returns an empty list

        * khtml/html/HTMLOptionsCollectionImpl.h: Changed to be a subclass of HTMLCollectionImpl.
        * khtml/html/HTMLOptionsCollectionImpl.cpp: Added.

        * WebCore.vcproj/WebCore/WebCore.vcproj: Added new source file.
        * WebCore.xcodeproj/project.pbxproj: Ditto.

        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLOptionsCollection setLength:]): Handle possible exception.
        (-[DOMHTMLSelectElement options]): Add get() since this is now a PassRefPtr.

        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLElement::selectIndexGetter): Call options() instead of optionsHTMLCollection().
        (KJS::HTMLElement::selectGetter): Ditto.
        (KJS::KJS::HTMLElement::put): Ditto.
        (KJS::HTMLElement::selectSetter): Ditto.
        (KJS::KJS::HTMLSelectCollection::put): Ditto.

        * khtml/html/HTMLSelectElementImpl.h: Tweaked formatting. Eliminated m_options.
        Changed m_minwidth and m_size to int instead of short. Removed optionsHTMLCollection().
        Changed options() to return a PassRefPtr.
        * khtml/html/HTMLSelectElementImpl.cpp:
        (WebCore::HTMLSelectElementImpl::~HTMLSelectElementImpl): Get rid of code to drop m_options.
        (WebCore::HTMLSelectElementImpl::remove): Remove unnecesssary RefPtr use, since that's
        handled fine by removeChild.
        (WebCore::HTMLSelectElementImpl::options): Change to create a new HTMLOptionsCollectionImpl
        each time, like other collection calls. Maybe we should change this eventually to use a
        HashMap so we can pass out the same collection over and over again, or could have a pointer
        stored in the select element that's managed by the collection itself.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
darin [Sun, 5 Feb 2006 19:34:01 +0000 (19:34 +0000)]
    Reviewed by Maciej.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6908
          REGRESSION: Replacing existing <option> shuffles it to the end of the list

        * fast/forms/select-replace-option.html: Added.
        * fast/forms/select-replace-option-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoForgot to put reviewer name in.
darin [Sun, 5 Feb 2006 19:33:44 +0000 (19:33 +0000)]
Forgot to put reviewer name in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by NOBODY (OOPS!).
darin [Sun, 5 Feb 2006 19:33:14 +0000 (19:33 +0000)]
    Reviewed by NOBODY (OOPS!).

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6908
          REGRESSION: Replacing existing <option> shuffles it to the end of the list

        Test: fast/forms/select-replace-option.html

        * khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLSelectCollection::put):
        Use optionsHTMLCollection, because options isn't really implemented yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
darin [Sun, 5 Feb 2006 19:18:40 +0000 (19:18 +0000)]
    Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6941
          Assertion failure in MacFrame::bridgeForWidget() on manual-tests/textfield-onblur.html

        * kwq/KWQTextField.mm: (-[KWQTextFieldController setHasFocus:]):
        Add check for nil in case the blur event causes the KWQLineEdit to be
        destroyed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
darin [Sun, 5 Feb 2006 19:17:14 +0000 (19:17 +0000)]
    Reviewed by Maciej.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6962
          REGRESSION: www.usa.phillips.com crashes due to <param> with no name

        * fast/replaced/object-param-no-name.html: Added.
        * fast/replaced/object-param-no-name-expected.txt: Added.

        - fixed test that I landed incorrectly earlier

        * fast/overflow/onscroll-layer-self-destruct.html: Removed Subversion property junk.
        * fast/overflow/onscroll-layer-self-destruct-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
darin [Sun, 5 Feb 2006 19:16:48 +0000 (19:16 +0000)]
    Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6962
          REGRESSION: www.usa.phillips.com crashes due to <param> with no name

        Test: fast/replaced/object-param-no-name.html

        * rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget):
        Check for empty name, and skip processing the name/value of that <param> element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - rolled out Maciej's event cleanup patch, which is causing problems
darin [Sun, 5 Feb 2006 19:00:52 +0000 (19:00 +0000)]
    - rolled out Maciej's event cleanup patch, which is causing problems

        I believe he has a fix, and he'll re-land the patch with the fix later.

        Original fix was <http://bugzilla.opendarwin.org/show_bug.cgi?id=7079>.
        Problems described in <http://bugzilla.opendarwin.org/show_bug.cgi?id=7084>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - rolled out Maciej's event cleanup patch, which is causing problems
darin [Sun, 5 Feb 2006 19:00:30 +0000 (19:00 +0000)]
    - rolled out Maciej's event cleanup patch, which is causing problems

        I believe he has a fix, and he'll re-land the patch with the fix later.

        Original fix was <http://bugzilla.opendarwin.org/show_bug.cgi?id=7079>.
        Problems described in <http://bugzilla.opendarwin.org/show_bug.cgi?id=7084>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago * ksvg2/css/KSVGCSSParser.cpp: Remove config.h, since this is included by...
darin [Sun, 5 Feb 2006 18:19:30 +0000 (18:19 +0000)]
    * ksvg2/css/KSVGCSSParser.cpp: Remove config.h, since this is included by another
        .cpp file -- oops!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Discussed with Anders (didn't get real review).
darin [Sun, 5 Feb 2006 18:16:59 +0000 (18:16 +0000)]
    Discussed with Anders (didn't get real review).

        - fix build

        * WebCore+SVG/SVGNamesWrapper.cpp: Touch file, not getting rebuilt even though
        it includes config.h which changed.
        * WebCore+SVG/XLinkNamesWrapper.cpp: Ditto.

        * ksvg2/css/KSVGCSSParser.cpp: Added include of config.h.
        * platform/mac/ImageDecoder.cpp: Ditto.

        * WebCore.vcproj/WebCore/WebCore.vcproj: Removed IntPoint.cpp and IntSize.cpp.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * platform/IntPoint.cpp: Removed. Was empty.
        * platform/IntSize.cpp: Removed. Was empty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
darin [Sun, 5 Feb 2006 17:21:27 +0000 (17:21 +0000)]
    Reviewed by Maciej.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7048
          Reproducible crash when onscroll handler deletes the layer or its object

        * fast/overflow/onscroll-layer-self-destruct.html: Added.
        * fast/overflow/onscroll-layer-self-destruct-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
darin [Sun, 5 Feb 2006 11:48:25 +0000 (11:48 +0000)]
    Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7048
          Reproducible crash when onscroll handler deletes the layer or its object

        Test: onscroll-layer-self-destruct.html

        * rendering/render_layer.cpp: (WebCore::RenderLayer::scrollToOffset):
        Don't send the scroll event until after we've done everything else we
        need to do.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Rubber stamped by Maciej.
darin [Sun, 5 Feb 2006 10:37:08 +0000 (10:37 +0000)]
    Rubber stamped by Maciej.

        - renamed DOMString and DOMStringImpl to String and StringImpl, and moved into platform

        * config.h: Put in transitional defines so old code can still refer to the classes
        as DOMString and DOMStringImpl.

        * platform/AtomicString.cpp: Added.
        * platform/AtomicString.h: Added.
        * platform/AtomicStringImpl.h: Added.
        * platform/PlatformString.h: Added.
        * platform/String.cpp: Added.
        * platform/StringImpl.cpp: Added.
        * platform/StringImpl.h: Added.
        Moved files here and renamed them. PlatformString.h would be named String.h except
        that conflicts with <string.h> on non-case-sensitive file systems.

        * khtml/xml/dom_atomicstring.cpp: Removed.
        * khtml/xml/dom_atomicstring.h: Removed.
        * khtml/xml/dom_stringimpl.cpp: Removed.
        * khtml/xml/dom_stringimpl.h: Removed.
        * khtml/dom/dom_string.cpp: Removed.
        * khtml/dom/dom_string.h: Removed.

        * WebCore.xcodeproj/project.pbxproj: Updated for file adds and removes.
        * WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.

        * WebCore+SVG/KDOMHeaders.h:
        * WebCore+SVG/Namespace.h:
        * WebCore+SVG/kdom.h:
        * bindings/objc/DOM.mm:
        * bindings/objc/DOMCSS.mm:
        * bindings/objc/DOMHTML.mm:
        * bindings/objc/DOMInternal.mm:
        * bridge/BrowserExtension.h:
        * css/css_base.h:
        * css/css_computedstyle.cpp:
        * css/css_grammar.y:
        * css/css_ruleimpl.h:
        * css/css_stylesheetimpl.cpp:
        * css/css_stylesheetimpl.h:
        * css/css_valueimpl.cpp:
        * css/csshelper.cpp:
        * css/csshelper.h:
        * css/cssparser.h:
        * css/cssstyleselector.h:
        * kcanvas/KCanvasTreeDebug.cpp:
        * khtml/dom/dom2_events.h:
        * khtml/ecma/JSXMLHttpRequest.cpp:
        * khtml/ecma/kjs_html.cpp:
        * khtml/ecma/kjs_window.cpp:
        * khtml/editing/SelectionController.cpp:
        * khtml/editing/apply_style_command.cpp:
        * khtml/editing/delete_from_text_node_command.h:
        * khtml/editing/insert_into_text_node_command.h:
        * khtml/editing/jsediting.h:
        * khtml/editing/rebalance_whitespace_command.h:
        * khtml/editing/remove_css_property_command.h:
        * khtml/editing/typing_command.h:
        * khtml/html/FormDataList.h:
        * khtml/html/HTMLNameCollectionImpl.h:
        * khtml/html/html_baseimpl.cpp:
        * khtml/html/html_objectimpl.cpp:
        * khtml/khtml_events.h:
        * khtml/xbl/xbl_binding.h:
        * khtml/xbl/xbl_protobinding.h:
        * khtml/xbl/xbl_protohandler.h:
        * khtml/xbl/xbl_protoimplementation.h:
        * khtml/xml/DOMImplementationImpl.cpp:
        * khtml/xml/EventNames.h:
        * khtml/xml/NameNodeListImpl.h:
        * khtml/xml/NamedNodeMapImpl.h:
        * khtml/xml/NodeImpl.cpp:
        * khtml/xml/NodeImpl.h:
        * khtml/xml/dom2_eventsimpl.h:
        * khtml/xml/dom_atomicstringlist.h:
        * khtml/xml/dom_elementimpl.h:
        * khtml/xml/dom_qname.h:
        * khtml/xml/dom_xmlimpl.cpp:
        * khtml/xml/xml_tokenizer.h:
        * khtml/xsl/xsl_stylesheetimpl.cpp:
        * khtml/xsl/xslt_processorimpl.h:
        * ksvg2/misc/KCanvasRenderingStyle.cpp:
        * ksvg2/svg/SVGAngleImpl.h:
        * ksvg2/svg/SVGAnimateColorElementImpl.cpp:
        * ksvg2/svg/SVGAnimatedStringImpl.h:
        * ksvg2/svg/SVGAnimationElementImpl.cpp:
        * ksvg2/svg/SVGColorImpl.h:
        * ksvg2/svg/SVGDOMImplementationImpl.cpp:
        * ksvg2/svg/SVGElementImpl.cpp:
        * ksvg2/svg/SVGFitToViewBoxImpl.cpp:
        * ksvg2/svg/SVGLangSpaceImpl.cpp:
        * ksvg2/svg/SVGLangSpaceImpl.h:
        * ksvg2/svg/SVGLengthImpl.h:
        * ksvg2/svg/SVGMarkerElementImpl.cpp:
        * ksvg2/svg/SVGPaintImpl.h:
        * ksvg2/svg/SVGPathSegImpl.h:
        * ksvg2/svg/SVGPreserveAspectRatioImpl.cpp:
        * ksvg2/svg/SVGSVGElementImpl.cpp:
        * ksvg2/svg/SVGScriptElementImpl.cpp:
        * ksvg2/svg/SVGStringListImpl.h:
        * ksvg2/svg/SVGStylableImpl.h:
        * ksvg2/svg/SVGStyleElementImpl.cpp:
        * ksvg2/svg/SVGStyledElementImpl.cpp:
        * ksvg2/svg/SVGSymbolElementImpl.cpp:
        * ksvg2/svg/SVGViewElementImpl.cpp:
        * kwq/KWQAccObject.mm:
        * kwq/KWQFontFamily.h:
        * kwq/KWQFontFamily.mm:
        * kwq/KWQKJobClasses.h:
        * kwq/KWQKJobClasses.mm:
        * loader/Cache.h:
        * loader/CachedObject.h:
        * loader/CachedXBLDocument.h:
        * loader/CachedXSLStyleSheet.h:
        * loader/DocLoader.h:
        * page/Frame.cpp:
        * page/FrameTreeNode.h:
        * platform/SegmentedString.h:
        * rendering/render_image.h:
        * rendering/render_style.cpp:
        * xml/xmlhttprequest.cpp:
        Updated all includes to use new filenames.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Hyatt.
mjs [Sun, 5 Feb 2006 09:53:47 +0000 (09:53 +0000)]
    Reviewed by Hyatt.

        - fix default traits for classes to make sure default constructors get called

        * kxmlcore/VectorTraits.h:
        (KXMLCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
mjs [Sun, 5 Feb 2006 09:45:53 +0000 (09:45 +0000)]
LayoutTests:

        Reviewed by Darin.

        Test case for:
        - various event cleanup, including fixing of the load event for iframes
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7079

        * fast/events/iframe-object-onload-expected.txt: Added.
        * fast/events/iframe-object-onload.html: Added.

WebCore:

        Reviewed by Darin.

        - various event cleanup, including fixing of the load event for iframes
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7079

        Specific changes:

        - don't bother to nil-check the document, a node can never have a null document now
        - move temp event forgetting from dispatchEvent to dispatchGenericEvent
        - pass event down using RefPtr::release() to avoid ref thrashing
        - support default handlers even for non-bubbling events (only on
          target node) and skip calling default event handler explicitly in
          callers
        - dispatch a whole separate load event to a frame document's containing frame
        - don't let propagationStopped prevent this new event
        - remove bogus security check for iframe onload

        * bridge/mac/MacFrame.mm:
        (WebCore::MacFrame::shouldClose):
        * khtml/xml/NodeImpl.cpp:
        (WebCore::NodeImpl::dispatchEvent):
        (WebCore::NodeImpl::dispatchGenericEvent):
        (WebCore::NodeImpl::dispatchWindowEvent):
        * khtml/xml/NodeImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-02-05 Maciej Stachowiak <mjs@apple.com>
andersca [Sun, 5 Feb 2006 08:49:12 +0000 (08:49 +0000)]
2006-02-05  Maciej Stachowiak  <mjs@apple.com>

        Reviewed and landed by Anders.

        * bindings/objc/DOM.mm:
        (-[DOMNode replaceChild::]):
        (KJS::DOMNodeProtoFunc::callAsFunction):
        Return correct child. Fixes test case failures introduced by the fix to
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7076

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Fix by David Kilzer, reviewed by Darin, landed by ap (with a tweak suggested...
ap [Sun, 5 Feb 2006 08:29:13 +0000 (08:29 +0000)]
    Fix by David Kilzer, reviewed by Darin, landed by ap (with a tweak suggested by Darin).

        - Fixed --no-svg build on http://build.webkit.org/.

        * kwq/KWQPainter.mm: Include "FloatRect.h".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
mjs [Sun, 5 Feb 2006 05:44:29 +0000 (05:44 +0000)]
    Reviewed by Darin.

        - Just return bool from DOM child mutation methods instead of the node
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7076

        * bindings/objc/DOM.mm:
        (-[DOMNode insertBefore::]):
        (-[DOMNode replaceChild::]):
        (-[DOMNode removeChild:]):
        (-[DOMNode appendChild:]):
        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMNodeProtoFunc::callAsFunction):
        * khtml/html/HTMLOptGroupElementImpl.cpp:
        (WebCore::HTMLOptGroupElementImpl::insertBefore):
        (WebCore::HTMLOptGroupElementImpl::replaceChild):
        (WebCore::HTMLOptGroupElementImpl::removeChild):
        (WebCore::HTMLOptGroupElementImpl::appendChild):
        * khtml/html/HTMLOptGroupElementImpl.h:
        * khtml/html/HTMLSelectElementImpl.cpp:
        (WebCore::HTMLSelectElementImpl::insertBefore):
        (WebCore::HTMLSelectElementImpl::replaceChild):
        (WebCore::HTMLSelectElementImpl::removeChild):
        (WebCore::HTMLSelectElementImpl::appendChild):
        * khtml/html/HTMLSelectElementImpl.h:
        * khtml/html/HTMLTextAreaElementImpl.cpp:
        (WebCore::HTMLTextAreaElementImpl::setDefaultValue):
        * khtml/html/html_tableimpl.cpp:
        (WebCore::HTMLTableElementImpl::createTFoot):
        * khtml/xml/ContainerNodeImpl.cpp:
        (WebCore::ContainerNodeImpl::insertBefore):
        (WebCore::ContainerNodeImpl::replaceChild):
        (WebCore::ContainerNodeImpl::removeChild):
        (WebCore::ContainerNodeImpl::appendChild):
        * khtml/xml/ContainerNodeImpl.h:
        * khtml/xml/NodeImpl.cpp:
        (WebCore::NodeImpl::insertBefore):
        (WebCore::NodeImpl::replaceChild):
        (WebCore::NodeImpl::removeChild):
        (WebCore::NodeImpl::appendChild):
        * khtml/xml/NodeImpl.h:
        * khtml/xml/xml_tokenizer.cpp:
        (WebCore::XMLTokenizer::insertErrorMessageBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
mjs [Sun, 5 Feb 2006 05:24:57 +0000 (05:24 +0000)]
LayoutTests:

        - reverted CSS media queries patch, as it causes random crashes on the
        layout tests with a debug build.

        * fast/media/001-expected.checksum: Removed.
        * fast/media/001-expected.png: Removed.
        * fast/media/001-expected.txt: Removed.
        * fast/media/001.html: Removed.
        * fast/media/002-expected.checksum: Removed.
        * fast/media/002-expected.png: Removed.
        * fast/media/002-expected.txt: Removed.
        * fast/media/002.html: Removed.
        * fast/media/003-expected.checksum: Removed.
        * fast/media/003-expected.png: Removed.
        * fast/media/003-expected.txt: Removed.
        * fast/media/003.html: Removed.
        * fast/media/004-expected.checksum: Removed.
        * fast/media/004-expected.png: Removed.
        * fast/media/004-expected.txt: Removed.
        * fast/media/004.html: Removed.
        * fast/media/005-expected.checksum: Removed.
        * fast/media/005-expected.png: Removed.
        * fast/media/005-expected.txt: Removed.
        * fast/media/005.html: Removed.
        * fast/media/006-expected.checksum: Removed.
        * fast/media/006-expected.png: Removed.
        * fast/media/006-expected.txt: Removed.
        * fast/media/006.html: Removed.
        * fast/media/007-expected.checksum: Removed.
        * fast/media/007-expected.png: Removed.
        * fast/media/007-expected.txt: Removed.
        * fast/media/007.html: Removed.
        * fast/media/008-expected.checksum: Removed.
        * fast/media/008-expected.png: Removed.
        * fast/media/008-expected.txt: Removed.
        * fast/media/008.html: Removed.
        * fast/media/009-expected.checksum: Removed.
        * fast/media/009-expected.png: Removed.
        * fast/media/009-expected.txt: Removed.
        * fast/media/009.html: Removed.
        * fast/media/010-expected.checksum: Removed.
        * fast/media/010-expected.png: Removed.
        * fast/media/010-expected.txt: Removed.
        * fast/media/010.html: Removed.
        * fast/media/011-expected.checksum: Removed.
        * fast/media/011-expected.png: Removed.
        * fast/media/011-expected.txt: Removed.
        * fast/media/011.html: Removed.
        * fast/media/012-expected.checksum: Removed.
        * fast/media/012-expected.png: Removed.
        * fast/media/012-expected.txt: Removed.
        * fast/media/012.html: Removed.
        * fast/media/013-expected.checksum: Removed.
        * fast/media/013-expected.png: Removed.
        * fast/media/013-expected.txt: Removed.
        * fast/media/013.html: Removed.
        * fast/media/014-expected.checksum: Removed.
        * fast/media/014-expected.png: Removed.
        * fast/media/014-expected.txt: Removed.
        * fast/media/014.html: Removed.
        * fast/media/015-expected.checksum: Removed.
        * fast/media/015-expected.png: Removed.
        * fast/media/015-expected.txt: Removed.
        * fast/media/015.html: Removed.
        * fast/media/016-expected.checksum: Removed.
        * fast/media/016-expected.png: Removed.
        * fast/media/016-expected.txt: Removed.
        * fast/media/016.html: Removed.
        * fast/media/017-expected.checksum: Removed.
        * fast/media/017-expected.png: Removed.
        * fast/media/017-expected.txt: Removed.
        * fast/media/017.html: Removed.
        * fast/media/018-expected.checksum: Removed.
        * fast/media/018-expected.png: Removed.
        * fast/media/018-expected.txt: Removed.
        * fast/media/018.html: Removed.
        * fast/media/019-expected.checksum: Removed.
        * fast/media/019-expected.png: Removed.
        * fast/media/019-expected.txt: Removed.
        * fast/media/019.html: Removed.
        * fast/media/020-expected.checksum: Removed.
        * fast/media/020-expected.png: Removed.
        * fast/media/020-expected.txt: Removed.
        * fast/media/020.html: Removed.
        * fast/media/021-expected.checksum: Removed.
        * fast/media/021-expected.png: Removed.
        * fast/media/021-expected.txt: Removed.
        * fast/media/021.html: Removed.
        * fast/media/022-expected.checksum: Removed.
        * fast/media/022-expected.png: Removed.
        * fast/media/022-expected.txt: Removed.
        * fast/media/022.html: Removed.
        * fast/media/023-expected.checksum: Removed.
        * fast/media/023-expected.png: Removed.
        * fast/media/023-expected.txt: Removed.
        * fast/media/023.html: Removed.
        * fast/media/024-expected.checksum: Removed.
        * fast/media/024-expected.png: Removed.
        * fast/media/024-expected.txt: Removed.
        * fast/media/024.html: Removed.
        * fast/media/025-expected.checksum: Removed.
        * fast/media/025-expected.png: Removed.
        * fast/media/025-expected.txt: Removed.
        * fast/media/025.html: Removed.
        * fast/media/026-expected.checksum: Removed.
        * fast/media/026-expected.png: Removed.
        * fast/media/026.html: Removed.
        * fast/media/import-p-green.css: Removed.

WebCore:

        - reverted CSS media queries patch, as it causes random crashes on the
        layout tests with a debug build.

        * WebCore.xcodeproj/project.pbxproj:
        * css/css_grammar.y:
        * css/css_mediaqueryeval.cpp: Removed.
        * css/css_mediaqueryeval.h: Removed.
        * css/css_mediaqueryimpl.cpp: Removed.
        * css/css_mediaqueryimpl.h: Removed.
        * css/css_stylesheetimpl.cpp:
        (MediaListImpl::MediaListImpl):
        (MediaListImpl::contains):
        (MediaListImpl::deleteMedium):
        (MediaListImpl::mediaText):
        (MediaListImpl::setMediaText):
        * css/css_stylesheetimpl.h:
        (DOM::MediaListImpl::length):
        (DOM::MediaListImpl::item):
        (DOM::MediaListImpl::appendMedium):
        * css/css_valueimpl.h:
        * css/csshelper.h:
        * css/cssmediafeatures.in: Removed.
        * css/cssparser.cpp:
        * css/cssparser.h:
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::CSSStyleSelector):
        (WebCore::CSSStyleSelector::init):
        (WebCore::CSSStyleSelector::~CSSStyleSelector):
        (WebCore::CSSStyleSelector::loadDefaultStyle):
        (WebCore::CSSStyleSelector::styleForElement):
        (WebCore::CSSStyleSelector::styleRulesForElement):
        (WebCore::CSSRuleSet::addRulesFromSheet):
        (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
        * css/cssstyleselector.h:
        * css/makemediafeatures: Removed.
        * css/maketokenizer:
        * css/tokenizer.flex:
        * khtml/html/html_headimpl.cpp:
        (WebCore::HTMLLinkElementImpl::process):
        (WebCore::HTMLLinkElementImpl::setStyleSheet):
        (WebCore::HTMLStyleElementImpl::childrenChanged):
        * platform/Screen.h:
        * platform/mac/Screen.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
darin [Sun, 5 Feb 2006 01:48:00 +0000 (01:48 +0000)]
    Reviewed by Maciej.

        * Misc.subproj/WebCoreStatistics.h:
        * Misc.subproj/WebCoreStatistics.m:
        (+[WebCoreStatistics javaScriptRootObjectTypeCounts]):
        javaScriptRootObjecTypeCounts -> javaScriptRootObjectTypeCounts

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5210
darin [Sun, 5 Feb 2006 01:43:42 +0000 (01:43 +0000)]
    - test for bugzilla.opendarwin.org/show_bug.cgi?id=5210
          REGRESSION: for/in loop with var changes global variable instead of making local

        * fast/js/for-in-var-scope.html: Added.
        * fast/js/resources/for-in-var-scope.js: Added.
        * fast/js/for-in-var-scope-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
darin [Sun, 5 Feb 2006 01:43:16 +0000 (01:43 +0000)]
    Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5210
          REGRESSION: for/in loop with var changes global variable instead of making local

        Test: fast/js/for-in-var-scope.html

        * kjs/nodes.cpp:
        (valueForReadModifyAssignment): Use ALWAYS_INLINE macro.
        (ForInNode::execute): Break out of the scope chain loop once we find and set the
        loop variable. We don't want to set multiple loop variables.
        (ForInNode::processVarDecls): Process the declaration of the loop variable.

        - other cleanup

        * kjs/object.cpp: (KJS::tryGetAndCallProperty): Use ALWAYS_INLINE macro.
        * kxmlcore/FastMalloc.cpp: Change to use ALWAYS_INLINE macro from AlwaysInline.h
        instead of defining it here a second time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoOops, rolled out part that wasn't supposed to be here.
darin [Sun, 5 Feb 2006 01:09:57 +0000 (01:09 +0000)]
Oops, rolled out part that wasn't supposed to be here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - updated test result due to revised fix for <ol> number
darin [Sun, 5 Feb 2006 01:07:57 +0000 (01:07 +0000)]
    - updated test result due to revised fix for <ol> number

        * fast/lists/olstart-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago * Scripts/webkitdirs.pm: Add a compatibilty hack for people with old
darin [Sun, 5 Feb 2006 01:03:46 +0000 (01:03 +0000)]
    * Scripts/webkitdirs.pm: Add a compatibilty hack for people with old
        Configuration files that say Development or Deployment in them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed and tweaked by Darin.
darin [Sun, 5 Feb 2006 00:49:09 +0000 (00:49 +0000)]
    Reviewed and tweaked by Darin.

        - fixed regressions caused by fix for bug 5776 earlier today

        * rendering/render_list.h: Remove m_value from RenderListMarker, add it to RenderListItem.
        A few other tweaks, including getting rid of "friend" relationship.
        * rendering/render_list.cpp:
        (RenderListItem::RenderListItem): Initialize m_value.
        (RenderListItem::setStyle): Restore old behavior of making no marker for LNONE case.
        (RenderListItem::calcValue): Work on m_value, not m_marker->m_value.
        (RenderListItem::resetValue): Reset m_value, even if there's no marker.
        (RenderListMarker::RenderListMarker): Remove code to set up m_value.
        (RenderListMarker::calcMinMaxWidth): Get marker value from list item.

        * rendering/RenderContainer.cpp: (updateListMarkerNumbers): Call resetValue by its new name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
mjs [Sat, 4 Feb 2006 23:29:43 +0000 (23:29 +0000)]
JavaScriptCore:

        Reviewed by Hyatt.

        - change JavaScript collector statistics calls to use HashCountedSet instead
        of CFSet; other misc cleanup
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7072

        * kjs/collector.cpp:
        (KJS::Collector::numProtectedObjects): renamed from numReferencedObjects
        (KJS::typeName):
        (KJS::Collector::rootObjectTypeCounts): renamed from rootObjectClasses,
        use HashSet
        * kjs/collector.h:
        (KJS::Collector::isOutOfMemory): Renamed from outOfMemory.
        * kjs/nodes.cpp:

WebCore:

        Reviewed by Hyatt.

        - change JavaScript collector statistics calls to use HashCountedSet instead
        of CFSet; other misc cleanup
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7072

        * kwq/WebCoreJavaScript.h:
        * kwq/WebCoreJavaScript.mm:
        (+[WebCoreJavaScript protectedObjectCount]): Renamed from referencedObjectCounts
        (+[WebCoreJavaScript rootObjectTypeCounts]): Renamed from rootObjectClasses,
        changed from NSSet to NSCountedSet.

WebKit:

        Reviewed by Hyatt.

        - change JavaScript collector statistics calls to use HashCountedSet instead
        of CFSet; other misc cleanup
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7072

        * Misc.subproj/WebCoreStatistics.h:
        * Misc.subproj/WebCoreStatistics.m:
        (+[WebCoreStatistics javaScriptProtectedObjectsCount]): new
        (+[WebCoreStatistics javaScriptRootObjecTypeCounts]): new
        (+[WebCoreStatistics javaScriptRootObjectClasses]): deprecated
        (+[WebCoreStatistics javaScriptReferencedObjectsCount]): deprecated
        (+[WebCoreStatistics javaScriptNoGCAllowedObjectsCount]): Just return 0. Deprecated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
mjs [Sat, 4 Feb 2006 22:59:54 +0000 (22:59 +0000)]
    Reviewed by Darin.

        - refactor and simplify code using ChildFrame in preparation for removing it
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7065

        * WebCore.xcodeproj/project.pbxproj: reordered slightly.
        * bridge/mac/MacFrame.h:
        * bridge/mac/MacFrame.mm:
        (WebCore::MacFrame::createFrame): Don't take isObject parameter, just check tag name
        * khtml/html/HTMLFormElementImpl.cpp:
        (WebCore::HTMLFormElementImpl::prepareSubmit): remove obsolete hasOnlyLocalReferences check
        * khtml/html/html_baseimpl.cpp:
        (WebCore::HTMLFrameElementImpl::isURLAllowed): remove obsolete hasOnlyLocalReferences check
        * loader/DocLoader.cpp:
        (khtml::DocLoader::requestImage): remove obsolete hasOnlyLocalReferences check
        (khtml::DocLoader::requestStyleSheet): remove obsolete hasOnlyLocalReferences check
        (khtml::DocLoader::requestScript): remove obsolete hasOnlyLocalReferences check
        (khtml::DocLoader::requestXSLStyleSheet): remove obsolete hasOnlyLocalReferences check
        * page/Frame.cpp:
        (WebCore::Frame::requestFrame): refactored and simplified
        (WebCore::Frame::requestObject): ditto
        (WebCore::Frame::shouldUsePlugin): ditto
        (WebCore::Frame::loadPlugin): ditto
        (WebCore::Frame::loadSubframe): ditto
        (WebCore::Frame::frameNames): remove obsolete m_bPreloaded check
        (WebCore::Frame::frames): ditto
        (WebCore::Frame::connectChild): check isFrame, not child type
        (WebCore::Frame::disconnectChild): ditto
        (WebCore::Frame::handleFallbackContent): greatly simplify using onwerElement
        (WebCore::Frame::updateBaseURLForEmptyDocument): use ownerElement, notChildFrame
        (WebCore::Frame::onlyLocalReferences): removed
        (WebCore::Frame::setOnlyLocalReferences): removed
        * page/Frame.h:
        * page/FramePrivate.h:
        (WebCore::ChildFrame::ChildFrame): remove most fields.
        * rendering/render_frames.cpp:
        (WebCore::RenderPartObject::updateWidget): Remove redundant setting of base URL for child document
        of iframe, Frame itself takes care of this already

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago * Scripts/make-js-test-wrappers: Don't create a wrapper if there's a disabled
darin [Sat, 4 Feb 2006 18:51:59 +0000 (18:51 +0000)]
    * Scripts/make-js-test-wrappers: Don't create a wrapper if there's a disabled
        wrapper already in the directory.
        * Scripts/svn-apply: Handle additions and deletions properly -- I've been noticing
        these haven't been working at all.
        * Scripts/svn-unapply: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFixed reviewer name.
darin [Sat, 4 Feb 2006 18:30:07 +0000 (18:30 +0000)]
Fixed reviewer name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed and tweaked by Darin.
darin [Sat, 4 Feb 2006 16:42:39 +0000 (16:42 +0000)]
    Reviewed and tweaked by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5776
          Generated numbers of ordered lists (OL) are not calculated right

        Uses the DOM tree to calculate previous nodes and nest correctly

        Tests:
        * fast/lists/olstart.html
        * fast/lists/ol-display-types.html

        * khtml/html/html_listimpl.cpp:
        (DOM::HTMLLIElementImpl::attach): remove calculation of start node value
        * rendering/render_list.cpp:
        (RenderListItem::setStyle): set up an m_marker even if the style is to
        not display the marker, to get the numbering right
        (enclosingList): gets the list enclosing the given node
        (previousListItemElement): gets the previous element in the list
        (RenderListItem::calcListValue): calculate the value correctly

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by NOBODY (OOPS!).
darin [Sat, 4 Feb 2006 04:57:01 +0000 (04:57 +0000)]
    Reviewed by NOBODY (OOPS!).

        Layout tests for bug 5776: Generated numbers of ordered lists (OL) are
        not calculated right

        * fast/lists/ol-display-types-expected.checksum: Added.
        * fast/lists/ol-display-types-expected.png: Added.
        * fast/lists/ol-display-types-expected.txt: Added.
        * fast/lists/ol-display-types.html: Added.
        * fast/lists/olstart-expected.checksum: Added.
        * fast/lists/olstart-expected.png: Added.
        * fast/lists/olstart-expected.txt: Added.
        * fast/lists/olstart.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed and tweaked by Darin.
darin [Sat, 4 Feb 2006 04:56:39 +0000 (04:56 +0000)]
    Reviewed and tweaked by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5776
          Generated numbers of ordered lists (OL) are not calculated right

        Uses the DOM tree to calculate previous nodes and nest correctly

        Tests:
        * fast/lists/olstart.html
        * fast/lists/ol-display-types.html

        * khtml/html/html_listimpl.cpp:
        (DOM::HTMLLIElementImpl::attach): remove calculation of start node value
        * rendering/render_list.cpp:
        (RenderListItem::setStyle): set up an m_marker even if the style is to
        not display the marker, to get the numbering right
        (enclosingList): gets the list enclosing the given node
        (previousListItemElement): gets the previous element in the list
        (RenderListItem::calcListValue): calculate the value correctly

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoCorrect the ChangeLog to credit Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
thatcher [Sat, 4 Feb 2006 02:54:19 +0000 (02:54 +0000)]
Correct the ChangeLog to credit Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agobeth felt like the changelog was judging her
ggaren [Sat, 4 Feb 2006 02:14:57 +0000 (02:14 +0000)]
beth felt like the changelog was judging her

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed beth.
ggaren [Sat, 4 Feb 2006 02:12:12 +0000 (02:12 +0000)]
    Reviewed beth.

        - Fixed <rdar://problem/4394868> window.open fails to parse
        "width=200px"

        Cause: QString::toInt() is too aggressive; it parses letters as numbers.
        The fix is to switch to DOMString. It's all the rage these days,
        and its toInt() behavior matches what we want.

        * manual-tests/window-open-features-parsing.html: Added "px" case to
        giant evil string.

        * khtml/ecma/kjs_window.cpp:
        (KJS::setWindowFeature):
        (KJS::parseWindowFeatures):
        (KJS::WindowFunc::callAsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
thatcher [Sat, 4 Feb 2006 02:01:56 +0000 (02:01 +0000)]
LayoutTests:

        Reviewed by Dave Hyatt, Tim H.

        Layout tests for:
        Bug 4127: WebCore doesn't support Media Queries (CSS3 module)
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4127

        * ChangeLog:
        * fast/media: Added.
        * fast/media/001-expected.checksum: Added.
        * fast/media/001-expected.png: Added.
        * fast/media/001-expected.txt: Added.
        * fast/media/001.html: Added.
        * fast/media/002-expected.checksum: Added.
        * fast/media/002-expected.png: Added.
        * fast/media/002-expected.txt: Added.
        * fast/media/002.html: Added.
        * fast/media/003-expected.checksum: Added.
        * fast/media/003-expected.png: Added.
        * fast/media/003-expected.txt: Added.
        * fast/media/003.html: Added.
        * fast/media/004-expected.checksum: Added.
        * fast/media/004-expected.png: Added.
        * fast/media/004-expected.txt: Added.
        * fast/media/004.html: Added.
        * fast/media/005-expected.checksum: Added.
        * fast/media/005-expected.png: Added.
        * fast/media/005-expected.txt: Added.
        * fast/media/005.html: Added.
        * fast/media/006-expected.checksum: Added.
        * fast/media/006-expected.png: Added.
        * fast/media/006-expected.txt: Added.
        * fast/media/006.html: Added.
        * fast/media/007-expected.checksum: Added.
        * fast/media/007-expected.png: Added.
        * fast/media/007-expected.txt: Added.
        * fast/media/007.html: Added.
        * fast/media/008-expected.checksum: Added.
        * fast/media/008-expected.png: Added.
        * fast/media/008-expected.txt: Added.
        * fast/media/008.html: Added.
        * fast/media/009-expected.checksum: Added.
        * fast/media/009-expected.png: Added.
        * fast/media/009-expected.txt: Added.
        * fast/media/009.html: Added.
        * fast/media/010-expected.checksum: Added.
        * fast/media/010-expected.png: Added.
        * fast/media/010-expected.txt: Added.
        * fast/media/010.html: Added.
        * fast/media/011-expected.checksum: Added.
        * fast/media/011-expected.png: Added.
        * fast/media/011-expected.txt: Added.
        * fast/media/011.html: Added.
        * fast/media/012-expected.checksum: Added.
        * fast/media/012-expected.png: Added.
        * fast/media/012-expected.txt: Added.
        * fast/media/012.html: Added.
        * fast/media/013-expected.checksum: Added.
        * fast/media/013-expected.png: Added.
        * fast/media/013-expected.txt: Added.
        * fast/media/013.html: Added.
        * fast/media/014-expected.checksum: Added.
        * fast/media/014-expected.png: Added.
        * fast/media/014-expected.txt: Added.
        * fast/media/014.html: Added.
        * fast/media/015-expected.checksum: Added.
        * fast/media/015-expected.png: Added.
        * fast/media/015-expected.txt: Added.
        * fast/media/015.html: Added.
        * fast/media/016-expected.checksum: Added.
        * fast/media/016-expected.png: Added.
        * fast/media/016-expected.txt: Added.
        * fast/media/016.html: Added.
        * fast/media/017-expected.checksum: Added.
        * fast/media/017-expected.png: Added.
        * fast/media/017-expected.txt: Added.
        * fast/media/017.html: Added.
        * fast/media/018-expected.checksum: Added.
        * fast/media/018-expected.png: Added.
        * fast/media/018-expected.txt: Added.
        * fast/media/018.html: Added.
        * fast/media/019-expected.checksum: Added.
        * fast/media/019-expected.png: Added.
        * fast/media/019-expected.txt: Added.
        * fast/media/019.html: Added.
        * fast/media/020-expected.checksum: Added.
        * fast/media/020-expected.png: Added.
        * fast/media/020-expected.txt: Added.
        * fast/media/020.html: Added.
        * fast/media/021-expected.checksum: Added.
        * fast/media/021-expected.png: Added.
        * fast/media/021-expected.txt: Added.
        * fast/media/021.html: Added.
        * fast/media/022-expected.checksum: Added.
        * fast/media/022-expected.png: Added.
        * fast/media/022-expected.txt: Added.
        * fast/media/022.html: Added.
        * fast/media/023-expected.checksum: Added.
        * fast/media/023-expected.png: Added.
        * fast/media/023-expected.txt: Added.
        * fast/media/023.html: Added.
        * fast/media/024-expected.checksum: Added.
        * fast/media/024-expected.png: Added.
        * fast/media/024-expected.txt: Added.
        * fast/media/024.html: Added.
        * fast/media/025-expected.checksum: Added.
        * fast/media/025-expected.png: Added.
        * fast/media/025-expected.txt: Added.
        * fast/media/025.html: Added.
        * fast/media/026-expected.checksum: Added.
        * fast/media/026-expected.png: Added.
        * fast/media/026.html: Added.
        * fast/media/import-p-green.css: Added.

WebCore:

        Reviewed by Dave Hyatt and Tim H.

        Bug 4127: WebCore doesn't support Media Queries (CSS3 module)
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4127

        http://www.w3.org/TR/css3-mediaqueries/

        * WebCore.xcodeproj/project.pbxproj:
        * css/css_grammar.y:
        * css/css_mediaqueryeval.cpp: Added.
        (MediaQueryEvaluator):
        (MediaQueryEvaluator::~MediaQueryEvaluator):
        (MediaQueryEvaluator::mediaTypeMatch):
        (applyRestrictor):
        (MediaQueryEvaluator::eval):
        (parseAspectRatio):
        * css/css_mediaqueryeval.h: Added.
        * css/css_mediaqueryimpl.cpp: Added.
        (MediaQueryExpImpl::MediaQueryExpImpl):
        (MediaQueryExpImpl::~MediaQueryExpImpl):
        (MediaQueryExpImpl::mediaFeature):
        (MediaQueryExpImpl::value):
        (MediaQueryImpl::MediaQueryImpl):
        (MediaQueryImpl::~MediaQueryImpl):
        (MediaQueryImpl::restrictor):
        (MediaQueryImpl::expressions):
        (MediaQueryImpl::mediaType):
        (MediaQueryImpl::operator==):
        * css/css_mediaqueryimpl.h: Added.
        (DOM::MediaQueryExpImpl::operator==):
        (DOM::MediaQueryExpListImpl::MediaQueryExpListImpl):
        (DOM::MediaQueryExpListImpl::append):
        (DOM::MediaQueryExpListImpl::list):
        (DOM::MediaQueryImpl::):
        * css/css_stylesheetimpl.cpp:
        (MediaListImpl::MediaListImpl):
        (MediaListImpl::deleteMedium):
        (mediaQueryAsDOMString):
        (MediaListImpl::mediaText):
        (MediaListImpl::setMediaText):
        (MediaListImpl::item):
        (MediaListImpl::appendMedium):
        (MediaListImpl::appendMediaQuery):
        * css/css_stylesheetimpl.h:
        (DOM::MediaListImpl::length):
        (DOM::MediaListImpl::mediaQueries):
        * css/css_valueimpl.h:
        * css/csshelper.h:
        * css/cssmediafeatures.in: Added.
        * css/cssparser.cpp:
        (CSSParser::parseMediaQuery):
        * css/cssparser.h:
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::CSSStyleSelector):
        (WebCore::CSSStyleSelector::init):
        (WebCore::CSSStyleSelector::~CSSStyleSelector):
        (WebCore::CSSStyleSelector::loadDefaultStyle):
        (WebCore::CSSStyleSelector::styleForElement):
        (WebCore::CSSStyleSelector::styleRulesForElement):
        (WebCore::CSSRuleSet::addRulesFromSheet):
        (WebCore::CSSStyleSelector::defaultStyleForRoot):
        * css/cssstyleselector.h:
        * css/makemediafeatures: Added.
        * css/maketokenizer:
        * css/tokenizer.flex:
        * khtml/html/html_headimpl.cpp:
        (WebCore::HTMLLinkElementImpl::process):
        (WebCore::HTMLLinkElementImpl::setStyleSheet):
        (WebCore::HTMLStyleElementImpl::childrenChanged):
        * platform/Screen.h:
        * platform/mac/Screen.mm:
        (WebCore::screenDepthPerComponent):
        (WebCore::screenIsMonochrome):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
mjs [Sat, 4 Feb 2006 01:48:05 +0000 (01:48 +0000)]
    Reviewed by Darin.

        - change spellchecker preflighting to happen via class methods instead of
        object methods.

        * WebView.subproj/WebView.m:
        (-[WebView setContinuousSpellCheckingEnabled:]):
        (+[WebView _preflightSpellCheckerNow:]):
        (+[WebView _preflightSpellChecker]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
thatcher [Fri, 3 Feb 2006 23:34:55 +0000 (23:34 +0000)]
JavaScriptCore:

        Reviewed by Justin.

        Renamed configuration names to Debug, Release and Production.

        * JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

        Reviewed by Justin.

        Renamed configuration names to Debug, Release and Production.

        * JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

        Reviewed by Justin.

        Renamed configuration names to Debug, Release and Production.

        * WebCore.xcodeproj/project.pbxproj:

WebKit:

        Reviewed by Justin.

        Renamed configuration names to Debug, Release and Production.

        * WebKit.xcodeproj/project.pbxproj:

WebKitTools:

        Reviewed by Justin.

        Renamed configuration names to Debug, Release and Production.

        * DrawTest/DrawTest.xcodeproj/project.pbxproj:
        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * Scripts/set-webkit-configuration:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Hyatt.
bdakin [Fri, 3 Feb 2006 22:46:46 +0000 (22:46 +0000)]
    Reviewed by Hyatt.

        No test cases added because this is an unreproducible crash.

        This is a speculative fix for <rdar://problem/4048026>
        CrashTracer: [BOUNCE BACK] 1219 crashes in Safari at
        com.apple.WebCore: KHTMLParser::popOneBlock + 36

        It seems possible that current could be nil when this function is
        called, so the speculative fix is to add a nil check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Refactoring of the image classes to make them even more
hyatt [Fri, 3 Feb 2006 11:22:36 +0000 (11:22 +0000)]
    Refactoring of the image classes to make them even more
        portable.

        Reviewed by mjs

        * WebCore.xcodeproj/project.pbxproj:
        * platform/Image.cpp:
        (WebCore::m_animationObserver):
        (WebCore::Image::Image):
        (WebCore::Image::~Image):
        (WebCore::Image::resetAnimation):
        (WebCore::Image::setData):
        (WebCore::Image::isNull):
        (WebCore::Image::size):
        (WebCore::Image::rect):
        (WebCore::Image::width):
        (WebCore::Image::height):
        (WebCore::):
        (WebCore::Image::compositeOperatorFromString):
        * platform/ImageData.cpp: Added.
        (WebCore::FrameData::clear):
        (WebCore::ImageData::ImageData):
        (WebCore::ImageData::~ImageData):
        (WebCore::ImageData::invalidateData):
        (WebCore::ImageData::cacheFrame):
        (WebCore::ImageData::isNull):
        (WebCore::ImageData::size):
        (WebCore::ImageData::setData):
        (WebCore::ImageData::setNativeData):
        (WebCore::ImageData::frameCount):
        (WebCore::ImageData::isSizeAvailable):
        (WebCore::ImageData::frameAtIndex):
        (WebCore::ImageData::frameDurationAtIndex):
        (WebCore::ImageData::shouldAnimate):
        (WebCore::ImageData::startAnimation):
        (WebCore::ImageData::stopAnimation):
        (WebCore::ImageData::resetAnimation):
        (WebCore::ImageData::advanceAnimation):
        * platform/ImageData.h: Added.
        (KXMLCore::):
        (WebCore::FrameData::m_duration):
        (WebCore::FrameData::~FrameData):
        (WebCore::ImageData::setIsPDF):
        (WebCore::ImageData::currentFrame):
        * platform/ImageDecoder.h:
        * platform/mac/Image.mm:
        (WebCore::Image::loadResource):
        (WebCore::Image::supportsType):
        (WebCore::Image::getCGImageRef):
        (WebCore::Image::getNSImage):
        (WebCore::Image::getTIFFRepresentation):
        (WebCore::graphicsContext):
        (WebCore::setCompositingOperation):
        (WebCore::fillSolidColorInRect):
        (WebCore::Image::drawInRect):
        (WebCore::drawPattern):
        (WebCore::Image::tileInRect):
        (WebCore::Image::scaleAndTileInRect):
        * platform/mac/ImageData.mm: Added.
        (WebCore::setCompositingOperation):
        (WebCore::ImageData::invalidateAppleSpecificData):
        (WebCore::ImageData::checkForSolidColor):
        (WebCore::ImageData::getTIFFRepresentation):
        (WebCore::ImageData::getNSImage):
        * platform/mac/PDFDocumentImage.h: Added.
        * platform/mac/PDFDocumentImage.mm: Added.
        (WebCore::releasePDFDocumentData):
        (WebCore::PDFDocumentImage::PDFDocumentImage):
        (WebCore::PDFDocumentImage::~PDFDocumentImage):
        (WebCore::PDFDocumentImage::documentRef):
        (WebCore::PDFDocumentImage::mediaBox):
        (WebCore::PDFDocumentImage::bounds):
        (WebCore::PDFDocumentImage::adjustCTM):
        (WebCore::PDFDocumentImage::setCurrentPage):
        (WebCore::PDFDocumentImage::currentPage):
        (WebCore::PDFDocumentImage::pageCount):
        (WebCore::PDFDocumentImage::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Make a new class called ImageDecoder that wraps a CGImageSource.
hyatt [Fri, 3 Feb 2006 09:11:10 +0000 (09:11 +0000)]
    Make a new class called ImageDecoder that wraps a CGImageSource.
        This paves the way for ImageData to become portable as well.

        Reviewed by mjs

        * WebCore.xcodeproj/project.pbxproj:
        * platform/ImageDecoder.h: Added.
        * platform/mac/Image.mm:
        (WebCore::ImageData::~ImageData):
        (WebCore::ImageData::invalidateData):
        (WebCore::ImageData::cacheFrame):
        (WebCore::ImageData::size):
        (WebCore::ImageData::setCFData):
        (WebCore::ImageData::frameCount):
        (WebCore::ImageData::isSizeAvailable):
        (WebCore::ImageData::drawInRect):
        * platform/mac/ImageDecoder.cpp: Added.
        (WebCore::ImageDecoder::ImageDecoder):
        (WebCore::ImageDecoder::~ImageDecoder):
        (WebCore::imageSourceOptions):
        (WebCore::ImageDecoder::initialized):
        (WebCore::ImageDecoder::setData):
        (WebCore::ImageDecoder::isSizeAvailable):
        (WebCore::ImageDecoder::size):
        (WebCore::ImageDecoder::repetitionCount):
        (WebCore::ImageDecoder::frameCount):
        (WebCore::ImageDecoder::createFrameAtIndex):
        (WebCore::ImageDecoder::frameDurationAtIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Move ImageAnimationObserver into its own file.
hyatt [Fri, 3 Feb 2006 07:32:20 +0000 (07:32 +0000)]
    Move ImageAnimationObserver into its own file.

        Reviewed by mjs

        * WebCore.xcodeproj/project.pbxproj:
        * loader/CachedImage.h:
        * platform/Image.h:
        * platform/ImageAnimationObserver.h: Added.
        (WebCore::ImageAnimationObserver::~ImageAnimationObserver):
        * platform/mac/Image.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Adele.
mjs [Fri, 3 Feb 2006 07:18:00 +0000 (07:18 +0000)]
    Reviewed by Adele.

        - remove all use of the ChildFrame from outside Frame.cpp, in preparation for removing it

        * bridge/mac/MacFrame.h:
        * bridge/mac/MacFrame.mm:
        (WebCore::MacFrame::frameDetached): Factor out the ChildFrame manipulations into a base
        class method.
        (WebCore::MacFrame::objectContentType): factored out from createPart, calls the bridge to
        determine contents for an Object tag.
        (WebCore::MacFrame::createPlugin): factor out code from createPart that makes a Plugin.
        (WebCore::MacFrame::createFrame): ditto for code that makes a Frame.
        (WebCore::MacFrame::createEmptyDocument): factored out part into the superclass
        * khtml/xml/DocumentImpl.cpp:
        (WebCore::DocumentImpl::ownerElement): Call new ownerElement method on Frame
        instead of mucking at Frame internals.
        * page/Frame.cpp:
        (WebCore::Frame::createPart): Moved here from MacFrame, but some of the guts were
        factored out.
        (WebCore::Frame::ownerElement): New method, logic moved from DocumentImpl.
        (WebCore::Frame::frameDetached): New virtual method, the part of this that
        pokes at ChildFrame structures.
        (WebCore::Frame::updateBaseURLForEmptyDocument): Helper that looks at the ChildFrame
        array for the benefit of createEmptyDocument.
        * page/Frame.h:
        * page/Page.h: Fix up modeline.
        * page/Plugin.h: Added.
        (WebCore::Plugin::Plugin): Moved here from MacFrame.mm, since it is now used by Frame.
        (WebCore::Plugin::view): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Avoid extra copies of all the decoded image bytes.
hyatt [Fri, 3 Feb 2006 05:47:16 +0000 (05:47 +0000)]
    Avoid extra copies of all the decoded image bytes.

        Reviewed by mjs

        * platform/mac/Image.mm:
        (WebCore::ImageData::setData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by harrison
justing [Fri, 3 Feb 2006 01:16:18 +0000 (01:16 +0000)]
    Reviewed by harrison

        Turned on continuous spell checking to test the fix for:
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=6586>
        REGRESSION: visible_text.cpp assertion failure in Mail.app

        Added:
        * editing/selection/end-of-document.html

        Pixel results for editing tests now include misspelling markers.
        A few of them are incorrect, filed 7038 to cover this.
        * editing/deleting/delete-3928305-fix-expected.checksum:
        * editing/deleting/delete-3928305-fix-expected.png:
        * editing/deleting/delete-3959464-fix-expected.checksum:
        * editing/deleting/delete-3959464-fix-expected.png:
        * editing/deleting/delete-after-span-ws-001-expected.checksum:
        * editing/deleting/delete-after-span-ws-001-expected.png:
        * editing/deleting/delete-after-span-ws-002-expected.checksum:
        * editing/deleting/delete-after-span-ws-002-expected.png:
        * editing/deleting/delete-after-span-ws-003-expected.checksum:
        * editing/deleting/delete-after-span-ws-003-expected.png:
        * editing/deleting/delete-and-undo-expected.checksum:
        * editing/deleting/delete-and-undo-expected.png:
        * editing/deleting/delete-block-contents-003-expected.checksum:
        * editing/deleting/delete-block-contents-003-expected.png:
        * editing/deleting/delete-block-merge-contents-010-expected.checksum:
        * editing/deleting/delete-block-merge-contents-010-expected.png:
        * editing/deleting/delete-contiguous-ws-001-expected.checksum:
        * editing/deleting/delete-contiguous-ws-001-expected.png:
        * editing/deleting/delete-tab-002-expected.checksum:
        * editing/deleting/delete-tab-002-expected.png:
        * editing/deleting/delete-tab-003-expected.checksum:
        * editing/deleting/delete-tab-003-expected.png:
        * editing/deleting/delete-trailing-ws-002-expected.checksum:
        * editing/deleting/delete-trailing-ws-002-expected.png:
        * editing/deleting/delete-ws-fixup-001-expected.checksum:
        * editing/deleting/delete-ws-fixup-001-expected.png:
        * editing/deleting/delete-ws-fixup-002-expected.checksum:
        * editing/deleting/delete-ws-fixup-002-expected.png:
        * editing/inserting/editing-empty-divs-expected.checksum:
        * editing/inserting/editing-empty-divs-expected.png:
        * editing/inserting/insert-3659587-fix-expected.checksum:
        * editing/inserting/insert-3659587-fix-expected.png:
        * editing/inserting/insert-br-004-expected.checksum:
        * editing/inserting/insert-br-004-expected.png:
        * editing/inserting/insert-br-005-expected.checksum:
        * editing/inserting/insert-br-005-expected.png:
        * editing/inserting/insert-br-007-expected.checksum:
        * editing/inserting/insert-br-007-expected.png:
        * editing/inserting/insert-div-007-expected.checksum:
        * editing/inserting/insert-div-007-expected.png:
        * editing/inserting/insert-div-012-expected.checksum:
        * editing/inserting/insert-div-012-expected.png:
        * editing/inserting/insert-div-013-expected.checksum:
        * editing/inserting/insert-div-013-expected.png:
        * editing/inserting/insert-div-014-expected.checksum:
        * editing/inserting/insert-div-014-expected.png:
        * editing/inserting/insert-div-015-expected.checksum:
        * editing/inserting/insert-div-015-expected.png:
        * editing/inserting/insert-div-016-expected.checksum:
        * editing/inserting/insert-div-016-expected.png:
        * editing/inserting/insert-div-017-expected.checksum:
        * editing/inserting/insert-div-017-expected.png:
        * editing/inserting/insert-div-018-expected.checksum:
        * editing/inserting/insert-div-018-expected.png:
        * editing/inserting/insert-div-019-expected.checksum:
        * editing/inserting/insert-div-019-expected.png:
        * editing/inserting/insert-div-020-expected.checksum:
        * editing/inserting/insert-div-020-expected.png:
        * editing/inserting/insert-div-021-expected.checksum:
        * editing/inserting/insert-div-021-expected.png:
        * editing/inserting/insert-div-022-expected.checksum:
        * editing/inserting/insert-div-022-expected.png:
        * editing/inserting/insert-div-025-expected.checksum:
        * editing/inserting/insert-div-025-expected.png:
        * editing/inserting/insert-div-027-expected.checksum:
        * editing/inserting/insert-div-027-expected.png:
        * editing/inserting/insert-tab-002-expected.checksum:
        * editing/inserting/insert-tab-002-expected.png:
        * editing/inserting/insert-tab-003-expected.checksum:
        * editing/inserting/insert-tab-003-expected.png:
        * editing/inserting/insert-text-with-newlines-expected.checksum:
        * editing/inserting/insert-text-with-newlines-expected.png:
        * editing/inserting/return-key-with-selection-001-expected.checksum:
        * editing/inserting/return-key-with-selection-001-expected.png:
        * editing/inserting/return-key-with-selection-002-expected.checksum:
        * editing/inserting/return-key-with-selection-002-expected.png:
        * editing/inserting/return-key-with-selection-003-expected.checksum:
        * editing/inserting/return-key-with-selection-003-expected.png:
        * editing/inserting/typing-002-expected.checksum:
        * editing/inserting/typing-002-expected.png:
        * editing/inserting/typing-around-br-001-expected.checksum:
        * editing/inserting/typing-around-br-001-expected.png:
        * editing/pasteboard/cut-text-001-expected.checksum:
        * editing/pasteboard/cut-text-001-expected.png:
        * editing/pasteboard/paste-list-001-expected.checksum:
        * editing/pasteboard/paste-text-001-expected.checksum:
        * editing/pasteboard/paste-text-001-expected.png:
        * editing/pasteboard/paste-text-012-expected.checksum:
        * editing/pasteboard/paste-text-012-expected.png:
        * editing/pasteboard/paste-text-013-expected.checksum:
        * editing/pasteboard/paste-text-013-expected.png:
        * editing/pasteboard/paste-text-014-expected.checksum:
        * editing/pasteboard/paste-text-014-expected.png:
        * editing/pasteboard/paste-text-019-expected.checksum:
        * editing/pasteboard/paste-text-019-expected.png:
        * editing/selection/3690703-2-expected.checksum:
        * editing/selection/3690703-expected.checksum:
        * editing/selection/3690719-expected.checksum:
        * editing/selection/extend-by-word-001-expected.checksum:
        * editing/selection/extend-by-word-001-expected.png:
        * editing/selection/iframe-expected.checksum:
        * editing/selection/iframe-expected.png:
        * editing/selection/move-backwords-by-word-001-expected.checksum:
        * editing/selection/move-backwords-by-word-001-expected.png:
        * editing/selection/move-by-character-001-expected.checksum:
        * editing/selection/move-by-character-001-expected.png:
        * editing/selection/move-by-line-001-expected.checksum:
        * editing/selection/move-by-line-001-expected.png:
        * editing/selection/move-by-word-001-expected.checksum:
        * editing/selection/move-by-word-001-expected.png:
        * editing/selection/replaced-boundaries-1-expected.checksum:
        * editing/selection/replaced-boundaries-1-expected.png:
        * editing/selection/unrendered-002-expected.checksum:
        * editing/selection/unrendered-002-expected.png:
        * editing/style/block-styles-007-expected.checksum:
        * editing/style/block-styles-007-expected.png:
        * editing/style/create-block-for-style-002-expected.checksum:
        * editing/style/create-block-for-style-002-expected.png:
        * editing/style/create-block-for-style-003-expected.checksum:
        * editing/style/create-block-for-style-003-expected.png:
        * editing/style/create-block-for-style-004-expected.checksum:
        * editing/style/create-block-for-style-004-expected.png:
        * editing/style/create-block-for-style-006-expected.checksum:
        * editing/style/create-block-for-style-006-expected.png:
        * editing/style/create-block-for-style-008-expected.checksum:
        * editing/style/create-block-for-style-008-expected.png:
        * editing/style/create-block-for-style-009-expected.checksum:
        * editing/style/create-block-for-style-009-expected.png:
        * editing/style/create-block-for-style-011-expected.checksum:
        * editing/style/create-block-for-style-011-expected.png:
        * editing/style/create-block-for-style-012-expected.checksum:
        * editing/style/create-block-for-style-012-expected.png:
        * editing/style/create-block-for-style-013-expected.checksum:
        * editing/style/create-block-for-style-013-expected.png:
        * editing/unsupported-content/list-type-after-expected.checksum:
        * editing/unsupported-content/list-type-before-expected.checksum:
        * editing/unsupported-content/table-type-after-expected.checksum:
        * editing/unsupported-content/table-type-before-expected.checksum:
        * fast/dom/blur-contenteditable-expected.checksum:
        * fast/dom/blur-contenteditable-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by thatcher
justing [Fri, 3 Feb 2006 01:14:39 +0000 (01:14 +0000)]
    Reviewed by thatcher

        Enabled spell checking for layout tests.

        * DumpRenderTree/DumpRenderTree.m:
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by darin, harrison
justing [Fri, 3 Feb 2006 01:14:12 +0000 (01:14 +0000)]
    Reviewed by darin, harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=6586>
        REGRESSION: visible_text.cpp assertion failure in Mail.app

        Calling range() on a WordIterator destroyed its RangeImpl, use
        RefPtr instead of PassRefPtr.
        Turned on continuous spell checking to test the fix, found
        a crasher caused by invalid positions created in
        previousBoundary.

        Added layout test:
        * editing/selection/end-of-document.html

        * khtml/editing/visible_text.h:
        * khtml/editing/visible_units.cpp:
        (khtml::previousBoundary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Vectorize Image. Optimize so that we no longer throw away
hyatt [Fri, 3 Feb 2006 00:02:59 +0000 (00:02 +0000)]
    Vectorize Image.  Optimize so that we no longer throw away
        all CGImageRefs.  Now we just throw away the last frame.

        Reviewed by mjs

        * platform/mac/Image.mm:
        (WebCore::FrameData::m_duration):
        (WebCore::FrameData::~FrameData):
        (WebCore::FrameData::clear):
        (WebCore::ImageData::invalidateData):
        (WebCore::ImageData::cacheFrame):
        (WebCore::ImageData::frameAtIndex):
        (WebCore::ImageData::frameDurationAtIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12537 268f45cc-cd09-0410-ab3c-d52691b4dbfc