mrowe@apple.com [Sat, 19 Jan 2008 18:51:36 +0000 (18:51 +0000)]
Allow the --http flag to run-webkit-tests to override
the default behaviour of disabling HTTP tests for Qt,
Gtk and Wx.
Reviewed by Alp Toker.
* Scripts/run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29674
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sat, 19 Jan 2008 18:34:01 +0000 (18:34 +0000)]
2008-01-19 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Remove any fragment part from the URL to be requested just before
passing it to curl, otherwise curl sends it as part of the HTTP/local
file request, causing page loads to fail.
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::startJob):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29673
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 19 Jan 2008 18:27:17 +0000 (18:27 +0000)]
Set svn:eol-style=native on .idl and .c files that were missed in r29663.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29672
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 19 Jan 2008 18:10:55 +0000 (18:10 +0000)]
2008-01-19 Mark Rowe <mrowe@apple.com>
Fix inconsistent line endings and set svn:eol-style=native
on IDL files that did not have it set.
* Interfaces/IGEN_DOMObject.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29671
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sat, 19 Jan 2008 15:46:23 +0000 (15:46 +0000)]
2008-01-19 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Reviewed by Alp Toker.
Add svg foreign object and svg experimental to the GTK+/autotools
build system.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29670
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sat, 19 Jan 2008 13:58:44 +0000 (13:58 +0000)]
2008-01-19 Christian Dywan <christian@imendio.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16882
[GTK] ChromeClientGtk is incompete
Implement these functions.
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::windowRect):
(WebKit::ChromeClient::pageRect):
(WebKit::ChromeClient::scaleFactor):
(WebKit::ChromeClient::focus):
(WebKit::ChromeClient::unfocus):
(WebKit::ChromeClient::canTakeFocus):
(WebKit::ChromeClient::takeFocus):
(WebKit::ChromeClient::canRunBeforeUnloadConfirmPanel):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29669
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Sat, 19 Jan 2008 10:43:32 +0000 (10:43 +0000)]
<rdar://problem/
5695344> check-for-global-initializers script never checks any object files
Reviewed by Darin.
We now touch a check-for-global-initializers.timestamp file in
the TARGET_TEMP_DIR directory to determine when new object files
have been compiled and thus need to be checked. If the timestamp
file doesn't exist, all object files will be checked.
Previously the modification time of the "executable" (the
framework binary, e.g., WebKit.framework/WebKit) was used, but
since this was the last file modified at the end of the compile
phase, no object files would ever get checked!
Also added JSCustomSQLTransactionCallback.o to the list of files
since it has static initializers in Debug builds of WebCore.
* Scripts/check-for-global-initializers:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29668
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 19 Jan 2008 10:12:48 +0000 (10:12 +0000)]
WebCore:
Reviewed by Maciej Stachowiak.
- fix <rdar://problem/
5645813> CrashTracer: [USER] 6 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::destroy + 116
Test: editing/selection/inconsistent-in-removeChildNode.html
* editing/SelectionController.cpp:
(WebCore::SelectionController::nodeWillBeRemoved): If the selection
base or extent are not visible any more, adjust the selection.
LayoutTests:
Reviewed by Maciej Stachowiak.
- test and updated results for <rdar://problem/
5645813> CrashTracer: [USER] 6 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::destroy + 116
* editing/selection/inconsistent-in-removeChildNode.html: Added.
* platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt:
* platform/mac-leopard/editing/selection: Added.
* platform/mac-leopard/editing/selection/inconsistent-in-removeChildNode-expected.checksum: Added.
* platform/mac-leopard/editing/selection/inconsistent-in-removeChildNode-expected.png: Added.
* platform/mac/editing/deleting/collapse-whitespace-
3587601-fix-expected.txt:
* platform/mac/editing/deleting/delete-
3608462-fix-expected.txt:
* platform/mac/editing/deleting/delete-
4083333-fix-expected.txt:
* platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
* platform/mac/editing/deleting/delete-line-011-expected.txt:
* platform/mac/editing/execCommand/find-after-replace-expected.txt:
* platform/mac/editing/execCommand/paste-1-expected.txt:
* platform/mac/editing/execCommand/paste-2-expected.txt:
* platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
* platform/mac/editing/selection/inconsistent-in-removeChildNode-expected.txt: Added.
* platform/mac/editing/selection/move-between-blocks-no-001-expected.txt:
* platform/mac/editing/selection/replace-selection-1-expected.txt:
* platform/mac/editing/style/remove-underline-across-paragraph-expected.txt:
* platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
* platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
* platform/mac/editing/style/remove-underline-expected.txt:
* platform/mac/editing/style/remove-underline-in-bold-expected.txt:
* platform/mac/editing/style/unbold-in-bold-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29667
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sat, 19 Jan 2008 09:43:52 +0000 (09:43 +0000)]
Build fix for --svg-foreign-object path
Reviewed by Eric Seidel
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29666
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sat, 19 Jan 2008 07:49:53 +0000 (07:49 +0000)]
2008-01-18 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16910
[GTK] REGRESSION: keyboard cursor doesn't blink
http://bugs.webkit.org/show_bug.cgi?id=16863
[GTK] REGRESSION: tab focusing doesn't work
* WebView/webkitwebview.cpp:
(webkit_web_view_focus_in_event): Added. Set the active frame.
(webkit_web_view_class_init):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29665
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Sat, 19 Jan 2008 06:01:28 +0000 (06:01 +0000)]
2008-01-18 Stephanie <slewis@apple.com>
Reviewed by Oliver.
Workaround for rdar:
5695848. Set mime_type for local files based on file extension.
* platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::doUpdateResourceResponse):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29664
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 19 Jan 2008 05:49:02 +0000 (05:49 +0000)]
set eol-style to native on tons of files to head off future mixed-line-ending problems
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29663
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Sat, 19 Jan 2008 01:44:02 +0000 (01:44 +0000)]
Reviewed by Oliver.
Fix for <rdar://
5683527> media/{audio,video|-controls-rendering.html failing
Remove platform specific results from media directory, since they should match the mac. Also, remove these tests from the skipped list.
* platform/win/Skipped:
* platform/win/media: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29662
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Sat, 19 Jan 2008 01:30:01 +0000 (01:30 +0000)]
Updating these results again. I accidently checked in the other results with some local changes.
* platform/mac/media/audio-controls-rendering-expected.checksum:
* platform/mac/media/audio-controls-rendering-expected.png:
* platform/mac/media/video-controls-rendering-expected.checksum:
* platform/mac/media/video-controls-rendering-expected.png:
* platform/mac/media/video-display-toggle-expected.checksum:
* platform/mac/media/video-display-toggle-expected.png:
* platform/mac/media/video-seek-past-end-playing-expected.checksum:
* platform/mac/media/video-seek-past-end-playing-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29661
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Sat, 19 Jan 2008 01:11:07 +0000 (01:11 +0000)]
- Build fix.
* kjs/ustring.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29660
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Sat, 19 Jan 2008 00:58:19 +0000 (00:58 +0000)]
Rubber stamped by Darin.
These are updated test results after http://bugs.webkit.org/
show_bug.cgi?id=15765 ASSERTION FAILED: m_frame->page() in
FrameLoader::tokenizerProcessedData using the new GMail interface
was checked in. This is a TEMPORARY fix until http://
bugs.webkit.org/show_bug.cgi?id=16853 really addresses this
problem.
* http/tests/loading/gmail-assert-on-load-expected.txt:
* http/tests/loading/onload-vs-immediate-refresh-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29659
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Sat, 19 Jan 2008 00:55:02 +0000 (00:55 +0000)]
Rubber stamped by Geoff.
- <rdar://
5667267> editing/selection/
5131716-1.html is failing
The problem is when the fonts are not present, but they should be
available now. This may have failed for other reasons in the past
that are now fixed.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29658
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Sat, 19 Jan 2008 00:24:41 +0000 (00:24 +0000)]
<rdar://problem/
5682340> REGRESSION (r28188): Context menu appears at wrong place when clicking in iframe whose parent is scrolled (16827)
Calling absolutePosition() in EventHandler::hitTestResultAtPoint() is extremely inefficient and passing in
true as fixed before was wrong. Use HitTestResult::localPoint() instead, and take into account border and padding widths.
Reviewed by Hyatt and Darin.
* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::operator=):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29657
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Sat, 19 Jan 2008 00:09:40 +0000 (00:09 +0000)]
Reviewed by Antti.
Adding pixel results for media tests.
* platform/mac/media/audio-constructor-expected.checksum: Added.
* platform/mac/media/audio-constructor-expected.png: Added.
* platform/mac/media/audio-constructor-src-expected.checksum: Added.
* platform/mac/media/audio-constructor-src-expected.png: Added.
* platform/mac/media/broken-video-expected.checksum: Added.
* platform/mac/media/broken-video-expected.png: Added.
* platform/mac/media/constructors-expected.checksum: Added.
* platform/mac/media/constructors-expected.png: Added.
* platform/mac/media/fallback-expected.checksum: Added.
* platform/mac/media/fallback-expected.png: Added.
* platform/mac/media/progress-event-expected.checksum: Added.
* platform/mac/media/progress-event-expected.png: Added.
* platform/mac/media/remove-from-document-expected.checksum: Added.
* platform/mac/media/remove-from-document-expected.png: Added.
* platform/mac/media/unsupported-rtsp-expected.checksum: Added.
* platform/mac/media/unsupported-rtsp-expected.png: Added.
* platform/mac/media/unsupported-tracks-expected.checksum: Added.
* platform/mac/media/unsupported-tracks-expected.png: Added.
* platform/mac/media/video-append-source-expected.checksum: Added.
* platform/mac/media/video-append-source-expected.png: Added.
* platform/mac/media/video-autoplay-expected.checksum: Added.
* platform/mac/media/video-autoplay-expected.png: Added.
* platform/mac/media/video-buffered-expected.checksum: Added.
* platform/mac/media/video-buffered-expected.png: Added.
* platform/mac/media/video-controls-expected.checksum: Added.
* platform/mac/media/video-controls-expected.png: Added.
* platform/mac/media/video-currentTime-expected.checksum: Added.
* platform/mac/media/video-currentTime-expected.png: Added.
* platform/mac/media/video-currentTime-set-expected.checksum: Added.
* platform/mac/media/video-currentTime-set-expected.png: Added.
* platform/mac/media/video-currentTime-set2-expected.checksum: Added.
* platform/mac/media/video-currentTime-set2-expected.png: Added.
* platform/mac/media/video-dom-autoplay-expected.checksum: Added.
* platform/mac/media/video-dom-autoplay-expected.png: Added.
* platform/mac/media/video-dom-end-expected.checksum: Added.
* platform/mac/media/video-dom-end-expected.png: Added.
* platform/mac/media/video-dom-loopcount-expected.checksum: Added.
* platform/mac/media/video-dom-loopcount-expected.png: Added.
* platform/mac/media/video-dom-loopend-expected.checksum: Added.
* platform/mac/media/video-dom-loopend-expected.png: Added.
* platform/mac/media/video-dom-loopstart-expected.checksum: Added.
* platform/mac/media/video-dom-loopstart-expected.png: Added.
* platform/mac/media/video-dom-src-expected.checksum: Added.
* platform/mac/media/video-dom-src-expected.png: Added.
* platform/mac/media/video-dom-start-expected.checksum: Added.
* platform/mac/media/video-dom-start-expected.png: Added.
* platform/mac/media/video-end-expected.checksum: Added.
* platform/mac/media/video-end-expected.png: Added.
* platform/mac/media/video-error-abort-expected.checksum: Added.
* platform/mac/media/video-error-abort-expected.png: Added.
* platform/mac/media/video-error-does-not-exist-expected.checksum: Added.
* platform/mac/media/video-error-does-not-exist-expected.png: Added.
* platform/mac/media/video-load-networkState-expected.checksum: Added.
* platform/mac/media/video-load-networkState-expected.png: Added.
* platform/mac/media/video-load-readyState-expected.checksum: Added.
* platform/mac/media/video-load-readyState-expected.png: Added.
* platform/mac/media/video-loopcount-expected.checksum: Added.
* platform/mac/media/video-loopcount-expected.png: Added.
* platform/mac/media/video-loopend-expected.checksum: Added.
* platform/mac/media/video-loopend-expected.png: Added.
* platform/mac/media/video-loopstart-expected.checksum: Added.
* platform/mac/media/video-loopstart-expected.png: Added.
* platform/mac/media/video-muted-expected.checksum: Added.
* platform/mac/media/video-muted-expected.png: Added.
* platform/mac/media/video-no-autoplay-expected.checksum: Added.
* platform/mac/media/video-no-autoplay-expected.png: Added.
* platform/mac/media/video-pause-empty-events-expected.checksum: Added.
* platform/mac/media/video-pause-empty-events-expected.png: Added.
* platform/mac/media/video-play-empty-events-expected.checksum: Added.
* platform/mac/media/video-play-empty-events-expected.png: Added.
* platform/mac/media/video-play-pause-events-expected.checksum: Added.
* platform/mac/media/video-play-pause-events-expected.png: Added.
* platform/mac/media/video-play-pause-exception-expected.checksum: Added.
* platform/mac/media/video-play-pause-exception-expected.png: Added.
* platform/mac/media/video-poster-expected.checksum: Added.
* platform/mac/media/video-poster-expected.png: Added.
* platform/mac/media/video-seek-past-end-paused-expected.checksum: Added.
* platform/mac/media/video-seek-past-end-paused-expected.png: Added.
* platform/mac/media/video-seek-past-end-playing-expected.checksum: Added.
* platform/mac/media/video-seek-past-end-playing-expected.png: Added.
* platform/mac/media/video-seekable-expected.checksum: Added.
* platform/mac/media/video-seekable-expected.png: Added.
* platform/mac/media/video-seeking-expected.checksum: Added.
* platform/mac/media/video-seeking-expected.png: Added.
* platform/mac/media/video-size-expected.checksum: Added.
* platform/mac/media/video-size-expected.png: Added.
* platform/mac/media/video-source-expected.checksum: Added.
* platform/mac/media/video-source-expected.png: Added.
* platform/mac/media/video-source-media-expected.checksum: Added.
* platform/mac/media/video-source-media-expected.png: Added.
* platform/mac/media/video-source-type-expected.checksum: Added.
* platform/mac/media/video-source-type-expected.png: Added.
* platform/mac/media/video-src-change-expected.checksum: Added.
* platform/mac/media/video-src-change-expected.png: Added.
* platform/mac/media/video-src-expected.checksum: Added.
* platform/mac/media/video-src-expected.png: Added.
* platform/mac/media/video-src-remove-expected.checksum: Added.
* platform/mac/media/video-src-remove-expected.png: Added.
* platform/mac/media/video-src-set-expected.checksum: Added.
* platform/mac/media/video-src-set-expected.png: Added.
* platform/mac/media/video-src-source-expected.checksum: Added.
* platform/mac/media/video-src-source-expected.png: Added.
* platform/mac/media/video-start-expected.checksum: Added.
* platform/mac/media/video-start-expected.png: Added.
* platform/mac/media/video-volume-expected.checksum: Added.
* platform/mac/media/video-volume-expected.png: Added.
* platform/mac/media/video-width-height-expected.checksum: Added.
* platform/mac/media/video-width-height-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29656
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Sat, 19 Jan 2008 00:04:08 +0000 (00:04 +0000)]
WebCore:
Reviewed by Darin, landed by Beth.
- fixed http://bugs.webkit.org/show_bug.cgi?id=15765
The call to HTMLTokenizer::write might result in a call to ::end which will invoke
HTMLParser::finished() or Document::finishedParsing(). HTMLParser::finished() will eventually
call Document::finishedParsing. The Document will delete the calling HTMLTokenizer and from the deleted
tokenizer we will call into FrameLoader::tokenizerProcessedData.
-) FrameLoader::tokenizerProcessedData calls FrameLoader::checkCompleted which gets called from the Document::finishedParsing
(FrameLoader::finishedParsing).
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::timerFired):
LayoutTests:
Reviewed by Darin, landed by Beth.
-test for http://bugs.webkit.org/show_bug.cgi?id=15765
Gmail hitting an assert in FrameLoader::tokenizerProcessedData
* http/tests/loading/gmail-assert-on-load-expected.txt: Added.
* http/tests/loading/gmail-assert-on-load.html: Added.
* http/tests/loading/resources/gmail-assert-on-load-frame.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29655
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 19 Jan 2008 00:01:01 +0000 (00:01 +0000)]
Reviewed by Beth Dakin.
Fix for <rdar://problem/
5683524> http/tests/security/cross-frame-access-get.html is failing
- Guard against possible timing related failures using polling.
* http/tests/security/:
* http/tests/security/resources/cross-frame-iframe-for-get-test.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29654
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Sat, 19 Jan 2008 00:00:25 +0000 (00:00 +0000)]
- Build fix.
* kjs/ustring.cpp:
* kjs/ustring.h:
(KJS::UString::cost):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29653
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 18 Jan 2008 23:33:07 +0000 (23:33 +0000)]
Remove incorrect addition of ChangeLog as changed in the ChangeLog.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29652
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 18 Jan 2008 23:20:30 +0000 (23:20 +0000)]
Update inline results after previous checkins. New results match Firefox more closely.
* platform/mac/fast/inline/001-expected.checksum:
* platform/mac/fast/inline/001-expected.png:
* platform/mac/fast/inline/002-expected.checksum:
* platform/mac/fast/inline/002-expected.png:
* platform/mac/fast/inline/br-text-decoration-expected.checksum:
* platform/mac/fast/inline/br-text-decoration-expected.png:
* platform/mac/fast/inline/continuation-outlines-expected.checksum:
* platform/mac/fast/inline/continuation-outlines-expected.png:
* platform/mac/fast/inline/continuation-outlines-with-layers-expected.checksum:
* platform/mac/fast/inline/continuation-outlines-with-layers-expected.png:
* platform/mac/fast/inline/dirtyLinesForInline-expected.checksum:
* platform/mac/fast/inline/dirtyLinesForInline-expected.png:
* platform/mac/fast/inline/drawStyledEmptyInlines-expected.checksum:
* platform/mac/fast/inline/drawStyledEmptyInlines-expected.png:
* platform/mac/fast/inline/drawStyledEmptyInlines-expected.txt:
* platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.checksum:
* platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
* platform/mac/fast/inline/emptyInlinesWithinLists-expected.checksum:
* platform/mac/fast/inline/emptyInlinesWithinLists-expected.png:
* platform/mac/fast/inline/emptyInlinesWithinLists-expected.txt:
* platform/mac/fast/inline/inline-borders-with-bidi-override-expected.checksum:
* platform/mac/fast/inline/inline-borders-with-bidi-override-expected.png:
* platform/mac/fast/inline/outline-continuations-expected.checksum:
* platform/mac/fast/inline/outline-continuations-expected.png:
* platform/mac/fast/inline/positionedLifetime-expected.checksum:
* platform/mac/fast/inline/positionedLifetime-expected.png:
* platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.checksum:
* platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29651
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 18 Jan 2008 23:10:51 +0000 (23:10 +0000)]
Don't apply the border/margin/padding check to root line boxes, since their renderers
are blocks.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesVertically):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29650
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 18 Jan 2008 22:59:29 +0000 (22:59 +0000)]
WebCore:
Not reviewed: rolling out a previous patch.
Fixed <rdar://problem/
5695439> Crash during GCController destructor on
quitting browser
Used svn merge to roll out r29603 because it introduced some crashes
on quit.
GC relies on static hash tables, so it's not safe to GC from a static
destructor, which might run after the static hash tables' destructors.
* bindings/js/GCController.cpp:
(WebCore::GCController::garbageCollectNow):
* bindings/js/GCController.h:
LayoutTests:
Fix for http://bugs.webkit.org/show_bug.cgi?id=15665
Reviewed by Beth
* fast/inline/inline-padding-disables-text-quirk.html: Added.
* platform/mac/fast/inline/inline-padding-disables-text-quirk-expected.checksum: Added.
* platform/mac/fast/inline/inline-padding-disables-text-quirk-expected.png: Added.
* platform/mac/fast/inline/inline-padding-disables-text-quirk-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29649
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 18 Jan 2008 22:50:13 +0000 (22:50 +0000)]
Not reviewed: rolling out a previous patch.
Fixed <rdar://problem/
5695439> Crash during GCController destructor on
quitting browser
Used svn merge to roll out r29603 because it introduced some crashes
on quit.
GC relies on static hash tables, so it's not safe to GC from a static
destructor, which might run after the static hash tables' destructors.
* bindings/js/GCController.cpp:
(WebCore::GCController::garbageCollectNow):
* bindings/js/GCController.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29648
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 18 Jan 2008 21:56:31 +0000 (21:56 +0000)]
WebCore:
Fix for http://bugs.webkit.org/show_bug.cgi?id=14975
Computed size of padding is incorrect because we default padding to auto. This is a made-up value that
was only used to implement cellpadding on tables. We needed this made-up value in order to tell that
padding wasn't set so that we could then apply cellpadding.
This patch rewrites cellpadding to be like other browsers. Instead of being a setting on the table
renderer that applies to all cells (even ones that were not <td>s), cellpadding is now mapped into the
style of <td>s. With this change it effectively becomes a content model feature and not a rendering
feature.
For example, a <td> will pick up cellpadding even when it is not a cell and/or the enclosing <table> is
not a table. Anonymous cells and CSS-display-type cells will now never pick up cellpadding. This behavior
is all consistent with other browsers.
Reviewed by Antti
Added fast/css/padding-no-renderer.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::styleForElement):
* css/CSSStyleSelector.h:
* dom/StyledElement.cpp:
* dom/StyledElement.h:
(WebCore::StyledElement::canHaveAdditionalAttributeStyleDecls):
(WebCore::StyledElement::additionalAttributeStyleDecls):
* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::additionalAttributeStyleDecls):
* html/HTMLTableCellElement.h:
(WebCore::HTMLTableCellElement::canHaveAdditionalAttributeStyleDecls):
* html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::additionalAttributeStyleDecls):
* html/HTMLTableColElement.h:
(WebCore::HTMLTableColElement::canHaveAdditionalAttributeStyleDecls):
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::parseMappedAttribute):
(WebCore::HTMLTableElement::additionalAttributeStyleDecls):
(WebCore::HTMLTableElement::addSharedCellDecls):
(WebCore::HTMLTableElement::addSharedCellBordersDecl):
(WebCore::HTMLTableElement::addSharedCellPaddingDecl):
(WebCore::HTMLTableElement::addSharedGroupDecls):
(WebCore::HTMLTableElement::attach):
* html/HTMLTableElement.h:
(WebCore::HTMLTableElement::canHaveAdditionalAttributeStyleDecls):
* html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::additionalAttributeStyleDecls):
* html/HTMLTableSectionElement.h:
(WebCore::HTMLTableSectionElement::canHaveAdditionalAttributeStyleDecls):
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::paddingTop):
(WebCore::RenderObject::paddingBottom):
(WebCore::RenderObject::paddingLeft):
(WebCore::RenderObject::paddingRight):
* rendering/RenderStyle.cpp:
(WebCore::StyleSurroundData::StyleSurroundData):
* rendering/RenderStyle.h:
(WebCore::RenderStyle::initialPadding):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::RenderTable):
* rendering/RenderTable.h:
LayoutTests:
Updated results for http://bugs.webkit.org/show_bug.cgi?id=14975
Reviewed by Antti
* fast/css/computed-style-without-renderer-expected.txt:
* fast/css/padding-no-renderer-expected.txt: Added.
* fast/css/padding-no-renderer.html: Added.
* platform/mac/fast/css/acid2-expected.checksum:
* platform/mac/fast/css/acid2-expected.png:
* platform/mac/fast/css/acid2-expected.txt:
* platform/mac/fast/css/acid2-pixel-expected.checksum:
* platform/mac/fast/css/acid2-pixel-expected.png:
* platform/mac/fast/css/acid2-pixel-expected.txt:
* platform/mac/fast/frames/viewsource-attribute-expected.checksum:
* platform/mac/fast/frames/viewsource-attribute-expected.png:
* platform/mac/fast/frames/viewsource-attribute-expected.txt:
* platform/mac/fast/lists/ordered-list-with-no-ol-tag-expected.checksum:
* platform/mac/fast/lists/ordered-list-with-no-ol-tag-expected.png:
* platform/mac/fast/lists/ordered-list-with-no-ol-tag-expected.txt:
* platform/mac/fast/table/add-before-anonymous-child-expected.checksum:
* platform/mac/fast/table/add-before-anonymous-child-expected.png:
* platform/mac/fast/table/add-before-anonymous-child-expected.txt:
* platform/mac/fast/table/cell-absolute-child-expected.checksum:
* platform/mac/fast/table/cell-absolute-child-expected.png:
* platform/mac/fast/table/cell-absolute-child-expected.txt:
* platform/mac/fast/table/frame-and-rules-expected.checksum:
* platform/mac/fast/table/frame-and-rules-expected.png:
* platform/mac/fast/table/frame-and-rules-expected.txt:
* platform/mac/http/tests/misc/acid2-expected.checksum:
* platform/mac/http/tests/misc/acid2-expected.png:
* platform/mac/http/tests/misc/acid2-expected.txt:
* platform/mac/http/tests/misc/acid2-pixel-expected.checksum:
* platform/mac/http/tests/misc/acid2-pixel-expected.png:
* platform/mac/http/tests/misc/acid2-pixel-expected.txt:
* platform/mac/tables/mozilla/bugs/bug30985-expected.checksum:
* platform/mac/tables/mozilla/bugs/bug30985-expected.png:
* platform/mac/tables/mozilla/bugs/bug30985-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29647
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 18 Jan 2008 21:52:57 +0000 (21:52 +0000)]
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/
5615307> Repro crash in WebKit!WebCore::RenderContainer::destroyLeftoverChildren
Test: fast/table/insert-row-before-form.html
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::addChild): Changed to ensure that the
object a new cell is inserted before is a child of the row, and
added an assertion that that object is either a cell or a form.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild): Changed to ensure that the
object a new row is inserted before is a child of the table section, and
added an assertion that that object is either a table row or a form.
LayoutTests:
Reviewed by Dave Hyatt.
- tests for <rdar://problem/
5615307> Repro crash in WebKit!WebCore::RenderContainer::destroyLeftoverChildren
* fast/table/insert-cell-before-form.html: Added.
* fast/table/insert-row-before-form.html: Added.
* platform/mac-leopard/fast/table: Added.
* platform/mac-leopard/fast/table/insert-cell-before-form-expected.checksum: Added.
* platform/mac-leopard/fast/table/insert-cell-before-form-expected.png: Added.
* platform/mac-leopard/fast/table/insert-row-before-form-expected.checksum: Added.
* platform/mac-leopard/fast/table/insert-row-before-form-expected.png: Added.
* platform/mac/fast/table/insert-cell-before-form-expected.txt: Added.
* platform/mac/fast/table/insert-row-before-form-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29646
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Fri, 18 Jan 2008 21:50:14 +0000 (21:50 +0000)]
Fixed date.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29645
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Fri, 18 Jan 2008 21:35:50 +0000 (21:35 +0000)]
Checked in new results for another test affected by disabling SVG
foreign object.
* platform/mac-leopard/svg/custom/stroke-width-click-expected.txt: Removed.
* platform/mac/svg/custom/stroke-width-click-expected.checksum: Removed.
* platform/mac/svg/custom/stroke-width-click-expected.png: Removed.
* svg/custom/stroke-width-click-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29644
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 18 Jan 2008 21:33:45 +0000 (21:33 +0000)]
Reviewed by Brady Eidson.
Fixed <rdar://problem/
5622424> World Leak dialog when closing a page
that has a Database
The problem was that each transaction and SQL statement would hold on
to its callback indefinitely. By design, callbacks often establish
reference cycles to temporarily protect their execution environments.
To break the cycle, we need to explicitly release each callback as soon
as it is no longer needed.
* storage/SQLStatement.cpp:
(WebCore::SQLStatement::performCallback): Release our callback objects
after performing our callback.
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::postflightAndCommit): Release our callback
objects after the transaction has terminated.
(WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback): ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29643
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Fri, 18 Jan 2008 21:20:26 +0000 (21:20 +0000)]
Fix typo in comment.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29642
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Fri, 18 Jan 2008 21:05:16 +0000 (21:05 +0000)]
JavaScriptCore:
Reviewed by Geoff.
- Correctly report cost of appended strings to trigger GC.
* kjs/ustring.cpp:
(KJS::):
(KJS::UString::Rep::create):
(KJS::UString::UString): Don't create unnecssary objects.
(KJS::UString::cost): Report cost if necessary but also keep track of
reported cost.
* kjs/ustring.h:
LayoutTests:
Reviewed by Geoff.
- Correctly report cost of appended strings to trigger GC.
* fast/js/garbage-collect-after-string-appends-expected.txt: Added.
* fast/js/garbage-collect-after-string-appends.html: Added.
* fast/js/resources/garbage-collect-after-string-appends.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29639
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Fri, 18 Jan 2008 20:58:08 +0000 (20:58 +0000)]
Reviewed by Antti.
Fix for <rdar://problem/
5679490> media controls fade in and out too jerkily and too slowly
* rendering/RenderMedia.cpp: Shorten the duration for the fade in/out animation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29638
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Jan 2008 20:54:03 +0000 (20:54 +0000)]
Build fix
* Scripts/build-webkit:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29637
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 18 Jan 2008 20:16:43 +0000 (20:16 +0000)]
Versioning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29636
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Fri, 18 Jan 2008 20:06:33 +0000 (20:06 +0000)]
WebCore:
Reviewed by Oliver.
Disables SVG foreign object for <rdar://problem/
5686989> turn off
SVG foreignobject because it does not repaint/dirty correctly
* DerivedSources.make:
* WebCore.SVG.ForeignObject.exp: Added.
* WebCore.SVG.exp:
* bindings/js/JSSVGElementWrapperFactory.cpp:
(WebCore::createJSSVGWrapper):
* rendering/RenderForeignObject.cpp:
* rendering/RenderForeignObject.h:
* svg/SVGForeignObjectElement.cpp:
* svg/SVGForeignObjectElement.h:
* svg/SVGForeignObjectElement.idl:
* svg/SVGLocatable.cpp:
(WebCore::SVGLocatable::nearestViewportElement):
(WebCore::SVGLocatable::farthestViewportElement):
* svg/SVGUseElement.cpp:
(WebCore::isDisallowedElement):
* svg/svgtags.in:
WebKitTools:
Reviewed by Oliver.
Update build-webkit to account for foreign-object being disabled by
default.
* Scripts/build-webkit:
LayoutTests:
Reviewed by Oliver.
Changed test results from disabling SVG foreign object for <rdar://
problem/
5686989> turn off SVG foreignobject because it does not
repaint/dirty correctly
* platform/mac/svg/custom/baseval-animval-equality-expected.checksum: Replaced.
* platform/mac/svg/custom/baseval-animval-equality-expected.png: Replaced.
* platform/mac/svg/custom/baseval-animval-equality-expected.txt: Replaced.
* platform/mac/svg/custom/dominant-baseline-hanging-expected.checksum: Replaced.
* platform/mac/svg/custom/dominant-baseline-hanging-expected.png: Replaced.
* platform/mac/svg/custom/dominant-baseline-hanging-expected.txt: Replaced.
* platform/mac/svg/custom/dynamic-svg-document-creation-expected.checksum: Replaced.
* platform/mac/svg/custom/dynamic-svg-document-creation-expected.png: Replaced.
* platform/mac/svg/custom/dynamic-svg-document-creation-expected.txt: Replaced.
* platform/mac/svg/custom/fill-SVGPaint-interface-expected.checksum: Replaced.
* platform/mac/svg/custom/fill-SVGPaint-interface-expected.png: Replaced.
* platform/mac/svg/custom/fill-SVGPaint-interface-expected.txt: Replaced.
* platform/mac/svg/custom/foreign-object-skew-expected.checksum: Replaced.
* platform/mac/svg/custom/foreign-object-skew-expected.png: Replaced.
* platform/mac/svg/custom/foreign-object-skew-expected.txt: Replaced.
* platform/mac/svg/custom/foreignObject-crash-on-hover-expected.checksum: Replaced.
* platform/mac/svg/custom/foreignObject-crash-on-hover-expected.png: Replaced.
* platform/mac/svg/custom/foreignObject-crash-on-hover-expected.txt: Replaced.
* platform/mac/svg/custom/getPresentationAttribute-expected.checksum: Replaced.
* platform/mac/svg/custom/getPresentationAttribute-expected.png: Replaced.
* platform/mac/svg/custom/getPresentationAttribute-expected.txt: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.checksum: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.png: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.txt: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-2-expected.checksum: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-2-expected.png: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-2-expected.txt: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.checksum: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.png: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.txt: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.checksum: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.png: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.txt: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.checksum: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.png: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.txt: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.checksum: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.png: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.txt: Replaced.
* platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.checksum: Replaced.
* platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Replaced.
* platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Replaced.
* platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.checksum: Replaced.
* platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.png: Replaced.
* platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.txt: Replaced.
* platform/mac/svg/hixie/mixed/006-expected.checksum: Replaced.
* platform/mac/svg/hixie/mixed/006-expected.png: Replaced.
* platform/mac/svg/hixie/mixed/006-expected.txt: Replaced.
* platform/mac/svg/hixie/mixed/007-expected.checksum: Replaced.
* platform/mac/svg/hixie/mixed/007-expected.png: Replaced.
* platform/mac/svg/hixie/mixed/007-expected.txt: Replaced.
* platform/mac/svg/hixie/mixed/008-expected.checksum: Replaced.
* platform/mac/svg/hixie/mixed/008-expected.png: Replaced.
* platform/mac/svg/hixie/mixed/008-expected.txt: Replaced.
* platform/mac/svg/hixie/mixed/009-expected.checksum: Replaced.
* platform/mac/svg/hixie/mixed/009-expected.png: Replaced.
* platform/mac/svg/hixie/mixed/009-expected.txt: Replaced.
* platform/mac/svg/hixie/mixed/011-expected.checksum: Replaced.
* platform/mac/svg/hixie/mixed/011-expected.png: Replaced.
* platform/mac/svg/hixie/mixed/011-expected.txt: Replaced.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29633
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 18 Jan 2008 19:58:46 +0000 (19:58 +0000)]
2008-01-18 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Adam Roben.
Fix mixed line endings in FileSystemWin.cpp and set svn:eol-style to native
to try and keep them consistent in the future.
* platform/win/FileSystemWin.cpp:
(WebCore::fileSize):
(WebCore::fileExists):
(WebCore::deleteFile):
(WebCore::pathByAppendingComponent):
(WebCore::fileSystemRepresentation):
(WebCore::makeAllDirectories):
(WebCore::homeDirectoryPath):
(WebCore::bundleName):
(WebCore::storageDirectory):
(WebCore::cachedStorageDirectory):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29631
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 18 Jan 2008 19:51:25 +0000 (19:51 +0000)]
Reviewed by Adam.
Fix unreachable code warning in RenderVideo on Windows.
Make switch cases explicit.
* rendering/RenderImage.cpp:
(WebCore::RenderImage::isWidthSpecified):
(WebCore::RenderImage::isHeightSpecified):
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::isWidthSpecified):
(WebCore::RenderVideo::isHeightSpecified):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29630
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Fri, 18 Jan 2008 19:49:37 +0000 (19:49 +0000)]
WebCore:
Reviewed by Adam Roben.
<rdar://problem/
5693558> REGRESSION (r29581): no form field focus
rings and inactive text selection after loading a page
Bug 16910: [GTK] REGRESSION: keyboard cursor doesn't blink
Bug 16917: REGRESSION (r29581/2): Google Maps search box loses focused appearance
* page/FocusController.cpp:
(WebCore::FocusController::setActive): Use focusedOrMainFrame() instead of focusedFrame()
to call selectionController()->pageActivationChanged() for cases when the focusedFrame()
has not been set yet.
WebKit/mac:
Reviewed by Adam Roben.
<rdar://problem/
5693558> REGRESSION (r29581): no form field focus rings
and inactive text selection after loading a page
Bug 16917: REGRESSION (r29581/2): Google Maps search box loses focused appearance
The problem was other frames were changing the FocusController's active
status to false after the first responder frame set it to true. The last
frame to call _updateActiveState would win.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _updateActiveState]): Only call page->focusController()->setActive()
if the first responder is the current WebHTMLView or the WebFrameView.
(-[WebHTMLView _web_firstResponderCausesFocusDisplay]): Removed, inlined code in _updateActiveState.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29629
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 18 Jan 2008 18:47:59 +0000 (18:47 +0000)]
Reviewed by Brady.
Database origin tracking is broken.
* storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::populateOrigins):
Move reading from statement back into the loop (broken in r29386).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29628
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Jan 2008 18:44:31 +0000 (18:44 +0000)]
Fix <rdar://
5693854> REGRESSION (r29581): fast/events/frame-click-focus.html failing
WebKit/mac:
Rename _updateActiveState to _updateFocusedAndActiveState
Also renamed any related methods/members similarly.
Reviewed by Adele.
* WebView/WebHTMLView.mm:
(-[WebHTMLViewPrivate dealloc]):
(-[WebHTMLView _cancelUpdateFocusedAndActiveStateTimer]):
(-[WebHTMLView close]):
(_updateFocusedAndActiveStateTimerCallback):
(-[WebHTMLView viewWillMoveToWindow:]):
(-[WebHTMLView viewDidMoveToWindow]):
(-[WebHTMLView windowDidBecomeKey:]):
(-[WebHTMLView windowDidResignKey:]):
(-[WebHTMLView becomeFirstResponder]):
(-[WebHTMLView resignFirstResponder]):
* WebView/WebHTMLViewInternal.h:
* WebView/WebHTMLViewPrivate.h:
WebKit/win:
Fix <rdar://
5693854> REGRESSION (r29581): fast/events/frame-click-focus.html failing
Restored the previous behavior of IWebViewPrivate::updateActiveState,
which DRT depends on, and renamed it to
IWebViewPrivate::updateFocusedAndActiveState to be clearer about its
side-effects.
Reviewed by Adele.
* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(WebViewWndProc): Removed some FIXMEs that we no longer want to fix
because the current design is better.
(WebView::updateActiveState): This is now just a method of WebView,
not any of its public interfaces.
(WebView::updateFocusedAndActiveState): Performs the tasks that the
old IWebViewPrivate::updateActiveState performed.
* WebView.h:
WebKitTools:
Updated for method renames
Reviewed by Adele.
* DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setMainFrameIsFirstResponder):
(LayoutTestController::setWindowIsKey):
* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webViewFocus:]):
* DumpRenderTree/win/FrameLoadDelegate.cpp:
(FrameLoadDelegate::didCommitLoadForFrame):
LayoutTests:
Reviewed by Adele.
* platform/win/Skipped: Removed a fixed test, and a test that passes
for me locally.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29627
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 18 Jan 2008 14:21:56 +0000 (14:21 +0000)]
Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
between DRT and TestNetscapePlugin.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29626
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 11:57:01 +0000 (11:57 +0000)]
Coding style fixes and added a comment about the order of includes in the PCH.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29625
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 11:30:30 +0000 (11:30 +0000)]
Marius Storm-Olsen <marius@trolltech.com>
Add use of precompiled header, when building inside Qt.
Compiling WebKit was taking forever; 17 minutes on my machine for _one_ build! Adding the PCH at least brings it down to 12 minutes for one build, for me.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29624
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 10:55:39 +0000 (10:55 +0000)]
Fix fast/forms/button-state-restore.html
Similar to the fix for fast/forms/form-post-urlencoded.html transform POST
requests to data urls into GET.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29623
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 10:55:23 +0000 (10:55 +0000)]
Fix LayoutTests/fast/cookies/local-file-can-set-cookies.html
In WebCore::cookies() don't return the full raw form but only the name=value
part. This fixes the getter part of the above test. The above test also
requires a parsing fix in Qt 4.4's QNetworkCookie to fully pass.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29622
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 10:55:06 +0000 (10:55 +0000)]
Fix fast/dom/Window/window-resize.html
In DRT connect the page's geometryChangeRequest signal to a slot that
sets the geometry of the view widget.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29621
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 10:54:52 +0000 (10:54 +0000)]
Fix return type conversions from Qt slots to JS values.
This also fixes fast/dom/open-and-close-by-DOM.html, which called
layoutTestController.windowCount().
When constructing the QVariant that holds the return type we cannot
use the QVarian(Type) constuctor as that will create a null variant.
We have to use the QVariant(Type, void *) constructor instead, just
like in QMetaObject::read() for example.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29620
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 10:54:36 +0000 (10:54 +0000)]
Fix svg/custom/path-getTotalLength.svg
Path::apply creates a PathElement and its points array on the stack,
to fill it in from the QPainterPath data and then use the platform
independent path applier functions to calculate properties such as
the length. For converting a QPainterPath::CurveToElement we need
three points in the path element. However we allocated only two
on the stack and as a result we got memory corruption and the
failing test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29619
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 10:54:20 +0000 (10:54 +0000)]
Fix LayoutTests/fast/dom/document-attribute-js-null.html
Don't crash when trying to get/set cookies without a frameloader.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29618
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 10:54:03 +0000 (10:54 +0000)]
Fix fast/dom/xmlhttprequest-get.xhtml
For local file requests remove the content length and the last-modified
headers in the response.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29617
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 10:53:45 +0000 (10:53 +0000)]
Fix fast/forms/form-post-urlencoded.html.
Post requests on files don't really make sense, but for
fast/forms/form-post-urlencoded.html we still need to retrieve the file,
which means we map it to a Get instead.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29616
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 10:37:50 +0000 (10:37 +0000)]
Simon Hausmann <hausmann@webkit.org>
Make QNetworkReplyHandler::abort() more robust against multiple invocations.
During DRT runs I see cancel() being called on the same handle multiple times. Guard
against this a bit better by setting m_reply to 0 after we called abort() on it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 10:37:33 +0000 (10:37 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
* Ask the WebCore::IconDatabase only if our URL is not empty. Otherwise
we will see a crash in a HashSet.
* It is crashing there because the StringImpl of an empty String is 0.
* We avoid this crash by checking for isEmpty() in WebKit as there is no
use to ask the iconDatabase for an empty string. We will fallback to the
defaultIcon.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29614
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 10:37:18 +0000 (10:37 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
* httpBody() can return 0 and other ports (cf/mac) check for this condition
* Looking at the cf/mac implementation we might need to call setHTTPBody somewhere
as well.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29613
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 09:46:07 +0000 (09:46 +0000)]
Prasanth Ullattil <prasanth.ullattil@trolltech.com>
Fix compilation in Win64(3): Due to the size of size_t cast the return value explicitly to double() to make sure the right Value() constructor is called.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29612
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 09:45:52 +0000 (09:45 +0000)]
Prasanth Ullattil <prasanth.ullattil@trolltech.com>
Fix compilation on Win64(2): Implemented currentThreadStackBase on X86-64 on Windows
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29611
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 09:45:09 +0000 (09:45 +0000)]
Prasanth Ullattil <prasanth.ullattil@trolltech.com>
Fix compilation on Win64(1): Define WTF_PLATFORM_X86_64 correctly on Win64.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29610
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 09:37:14 +0000 (09:37 +0000)]
* Remove our windowClipRect reimplementation and instead have our own
Widget::invalidate implementation that is invalidating
IntRect(0, 0, width(), height()) without trying to clip it (in contrast
to Widget::invalidateRect)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29609
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 09:36:57 +0000 (09:36 +0000)]
* Change the coordinate transformation in the PlatformMouseEvent handlers
* We want to convert from coordinates of the containing window to our local
position on the scrollbar.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29608
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 09:36:42 +0000 (09:36 +0000)]
* Make the qDebug more usable. Do not have an additional newline and print
the untranslated coordinates as well.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29607
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 09:36:27 +0000 (09:36 +0000)]
* Dead code, remove it
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29606
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 09:36:11 +0000 (09:36 +0000)]
* Coding-Style fixes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29605
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 09:35:50 +0000 (09:35 +0000)]
* Coding-Style fix
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29604
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 18 Jan 2008 04:05:21 +0000 (04:05 +0000)]
Reviewed by Darin Adler.
Fixed: lots of WebCore leaks reported when quitting Safari
If we're quitting with a GC still scheduled, do the GC before quitting.
That way, WebCore's leak counters won't count objects that were
scheduled for GC.
* bindings/js/GCController.cpp:
(WebCore::GCController::~GCController):
(WebCore::GCController::garbageCollectNow):
* bindings/js/GCController.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29603
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Fri, 18 Jan 2008 03:29:28 +0000 (03:29 +0000)]
2008-01-17 Alp Toker <alp@atoker.com>
Reviewed by Oliver Hunt.
gdk_screen_get_font_options() returns NULL if no default options are
set so we always have to NULL check to avoid crashes later on since
Cairo doesn't accept NULL font options.
* platform/graphics/gtk/FontPlatformDataGtk.cpp:
(WebCore::FontPlatformData::FontPlatformData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29602
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 18 Jan 2008 01:58:09 +0000 (01:58 +0000)]
Reviewed by Adele.
Windows fix for <rdar://problem/
5605682>
Disallow streaming protocols for media elements
and <rdar://problem/
5668711>
Limit the container and codec types that the <video> tag supports
- Disable unsupported QuickTime tracks types.
- Disallow streaming protocols (for now).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29601
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Fri, 18 Jan 2008 01:14:33 +0000 (01:14 +0000)]
WebKit/win:
Build fix.
* WebKit.vcproj/WebKit.make:
WebKitTools:
Build fix.
* Drosera/DroseraWin.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29600
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Fri, 18 Jan 2008 01:14:17 +0000 (01:14 +0000)]
2008-01-17 Stephanie <slewis@apple.com>
RS=Adam
Move some new failing tests to the skipped list
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29599
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Fri, 18 Jan 2008 00:34:45 +0000 (00:34 +0000)]
Added Vista crash logging information.
Reviewed by Adam.
* quality/crashlogs.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29598
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 18 Jan 2008 00:21:42 +0000 (00:21 +0000)]
Support smart copy and paste during drag and drop
Reviewed by Alice
In order for the drag and drop tests in Windows DRT to pass
we need to support smart cut and paste operations during
drag and drop on windows.
There is no layout test as drag and drop is still unsupported
on windows. Once supported smart drag/drop is tested by existing
tests
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29597
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Fri, 18 Jan 2008 00:10:52 +0000 (00:10 +0000)]
Reviewed by Darin
- fixed <rdar://problem/
5692068> -1 WebFrameView world leaks reported after closing view source window
* WebView/WebFrameView.mm:
(-[WebFrameView initWithCoder:]):
override to bump the global WebFrameView count
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29596
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 17 Jan 2008 23:58:45 +0000 (23:58 +0000)]
* Scripts/run-webkit-tests: Fixed a bug number.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29595
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 17 Jan 2008 21:33:13 +0000 (21:33 +0000)]
<rdar://problem/
5692940> Crash when attempting to get text properties in SVG with no renderer
Reviewed by Anders
We use the element renderer to calculate the text element bounds,
however there was no check against the possibility of the text dimension
properties being requested on a element with no renderer (eg. unattached,
display: none).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29594
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 17 Jan 2008 21:05:33 +0000 (21:05 +0000)]
Reviewed by Oliver.
<rdar://problem/
5636742>
CrashTracer: [USER] 1302 crashes in Safari at com.apple.WebCore: WTF::Vector<char, 0ul>::reserveCapacity + 78
When loading full-frame plug-ins, disable buffering data for the main resource loader. Otherwise, this can cause us
to crash when loading large files such as movies in the browser. We already do this for embedded plug-ins.
* WebCore.base.exp:
* loader/DocumentLoader.h:
(WebCore::DocumentLoader::mainResourceLoader):
New accessor method.
* loader/PluginDocument.cpp:
(WebCore::PluginTokenizer::writeRawData):
Disable buffering for the main resource loader.
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::setShouldBufferData):
* loader/ResourceLoader.h:
Have this free the buffer when disabling buffering.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29593
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 17 Jan 2008 20:45:08 +0000 (20:45 +0000)]
Fix Windows build.
* kjs/regexp_object.cpp:
(KJS::regExpProtoFuncToString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29592
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 17 Jan 2008 20:39:39 +0000 (20:39 +0000)]
More Qt/GTK+ build fixing.
* platform/gtk/ScrollViewGtk.cpp:
* platform/qt/ScrollViewQt.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29591
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Thu, 17 Jan 2008 20:06:06 +0000 (20:06 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16902
<rdar://problem/
5692566> fast/encoding/mailto-always-utf-8.html fails when run after
fast/dom/Window/window-property-shadowing.html
Test: fast/dom/Window/window-property-shadowing_.html
* loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Clear the frame name, too.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29590
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Thu, 17 Jan 2008 19:50:17 +0000 (19:50 +0000)]
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=16908
run-webkit-tests complains about missing FindSafari.exe
* Scripts/webkitdirs.pm: Append _debug as appropriate.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29589
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 17 Jan 2008 19:27:33 +0000 (19:27 +0000)]
Reviewed by Darin.
Fix for http://bugs.webkit.org/show_bug.cgi?id=16901
Convert remaining JS function objects to use the new PrototypeFunction class
- Moves Boolean, Function, RegExp, Number, Object and Global functions to their
own static function implementations so that they can be used with the
PrototypeFunction class. SunSpider says this is 1.003x as fast.
* kjs/JSGlobalObject.cpp:
(KJS::JSGlobalObject::reset):
* kjs/array_object.h:
* kjs/bool_object.cpp:
(KJS::BooleanInstance::BooleanInstance):
(KJS::BooleanPrototype::BooleanPrototype):
(KJS::booleanProtoFuncToString):
(KJS::booleanProtoFuncValueOf):
(KJS::BooleanObjectImp::BooleanObjectImp):
(KJS::BooleanObjectImp::implementsConstruct):
(KJS::BooleanObjectImp::construct):
(KJS::BooleanObjectImp::callAsFunction):
* kjs/bool_object.h:
(KJS::BooleanInstance::classInfo):
* kjs/error_object.cpp:
(KJS::ErrorPrototype::ErrorPrototype):
(KJS::errorProtoFuncToString):
* kjs/error_object.h:
* kjs/function.cpp:
(KJS::globalFuncEval):
(KJS::globalFuncParseInt):
(KJS::globalFuncParseFloat):
(KJS::globalFuncIsNaN):
(KJS::globalFuncIsFinite):
(KJS::globalFuncDecodeURI):
(KJS::globalFuncDecodeURIComponent):
(KJS::globalFuncEncodeURI):
(KJS::globalFuncEncodeURIComponent):
(KJS::globalFuncEscape):
(KJS::globalFuncUnEscape):
(KJS::globalFuncKJSPrint):
(KJS::PrototypeFunction::PrototypeFunction):
* kjs/function.h:
* kjs/function_object.cpp:
(KJS::FunctionPrototype::FunctionPrototype):
(KJS::functionProtoFuncToString):
(KJS::functionProtoFuncApply):
(KJS::functionProtoFuncCall):
* kjs/function_object.h:
* kjs/number_object.cpp:
(KJS::NumberPrototype::NumberPrototype):
(KJS::numberProtoFuncToString):
(KJS::numberProtoFuncToLocaleString):
(KJS::numberProtoFuncValueOf):
(KJS::numberProtoFuncToFixed):
(KJS::numberProtoFuncToExponential):
(KJS::numberProtoFuncToPrecision):
* kjs/number_object.h:
(KJS::NumberInstance::classInfo):
(KJS::NumberObjectImp::classInfo):
(KJS::NumberObjectImp::):
* kjs/object_object.cpp:
(KJS::ObjectPrototype::ObjectPrototype):
(KJS::objectProtoFuncValueOf):
(KJS::objectProtoFuncHasOwnProperty):
(KJS::objectProtoFuncIsPrototypeOf):
(KJS::objectProtoFuncDefineGetter):
(KJS::objectProtoFuncDefineSetter):
(KJS::objectProtoFuncLookupGetter):
(KJS::objectProtoFuncLookupSetter):
(KJS::objectProtoFuncPropertyIsEnumerable):
(KJS::objectProtoFuncToLocaleString):
(KJS::objectProtoFuncToString):
* kjs/object_object.h:
* kjs/regexp_object.cpp:
(KJS::RegExpPrototype::RegExpPrototype):
(KJS::regExpProtoFuncTest):
(KJS::regExpProtoFuncExec):
(KJS::regExpProtoFuncCompile):
(KJS::regExpProtoFuncToString):
* kjs/regexp_object.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29588
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 17 Jan 2008 19:23:54 +0000 (19:23 +0000)]
Name the test for a recent bug fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29587
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 17 Jan 2008 19:06:55 +0000 (19:06 +0000)]
Qt/GTK+ build fix.
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::ScrollViewPrivate::isActive):
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::ScrollViewPrivate::isActive):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29586
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 17 Jan 2008 18:55:06 +0000 (18:55 +0000)]
Reviewed by Dave Hyatt.
- make more test pass on Windows by using @font-face to force font
fallback to match Mac OS X.
* editing/deleting/
5144139-2.html:
* fast/encoding/invalid-UTF-8.html:
* fast/events/updateLayoutForHitTest.html:
* fast/forms/select-visual-hebrew.html:
* fast/forms/select-writing-direction-natural.html:
* fast/forms/visual-hebrew-text-field.html:
* fast/text/in-rendered-text-rtl.html:
* fast/text/international/bidi-L2-run-reordering.html:
* fast/text/international/bidi-LDB-2-CSS.html:
* fast/text/international/bidi-LDB-2-HTML.html:
* fast/text/international/bidi-LDB-2-formatting-characters.html:
* fast/text/international/bidi-european-terminators.html:
* fast/text/international/bidi-ignored-for-first-child-inline.html:
* fast/text/international/bidi-innertext.html:
* fast/text/international/bidi-listbox-atsui.html:
* fast/text/international/bidi-listbox.html:
* fast/text/international/bidi-menulist.html:
* fast/text/international/bidi-override.html:
* fast/text/international/resources: Added.
* fast/text/international/resources/Mac-compatible-font-fallback.css: Added.
* fast/text/international/rtl-caret.html:
* platform/mac/editing/deleting/
5144139-2-expected.txt:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29585
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 17 Jan 2008 17:46:24 +0000 (17:46 +0000)]
* platform/win/Skipped: Added another failure.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29584
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 17 Jan 2008 17:46:02 +0000 (17:46 +0000)]
Trigger activation changes at the right time by listening for WM_NCACTIVATE
This is the final part of <rdar://
5006915> Inactive look for Aqua
controls
WebView now listens to messages sent to its top-level parent window.
When the top-level parent receives a WM_NCACTIVATE message, WebView
recalculates whether it is contained within the current active window.
Reviewed by Darin.
* Interfaces/IWebViewPrivate.idl:
(IWebViewPrivate::windowAncestryDidChange): Added. WebKit clients
should call this when they change the parent window chain of a
WebView.
* WebView.cpp:
(WebView::WebView): Initialize new member.
(findTopLevelParent): Added.
(WebViewWndProc):
- Separated activation handling from focus handling, now that
activation handling is taken care of by updateActiveState
exclusively.
- Compare top-level parents in our WM_KILLFOCUS handler so that we
really know if focus is staying inside our top-level window.
- Update our active state on WM_WINDOWPOSCHANGED.
- Added a WM_TIMER handler.
(WebView::initWithFrame): Call windowAncestryDidChange after setting
up our HWND as a child of the host window.
(WebView::windowReceivedMessage): Added. Update our active state when
our top-level parent receives a WM_NCACTIVATE message.
(WebView::updateActiveStateSoon): Added.
(WebView::setHostWindow): Call windowAncestryDidChange after changing
the host window.
(WebView::updateActiveState): We are active if our top-level parent is
the same as the top-level parent of the active window.
(WebView::windowAncestryDidChange): Added. Recalculates our top-level
parent and registers as a listener for the new top-level parent's
messages.
* WebView.h: Made WebView and WindowMessageListener so that it can
utilize WindowMessageBroadcaster to listen to its top-level parent's
messages.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29583
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 17 Jan 2008 17:45:31 +0000 (17:45 +0000)]
Update scroll bars/form controls when FocusController::isActive changes
WebCore:
Update scroll bars/form controls when FocusController::isActive changes
Part of <rdar://
5006915> Inactive look for Aqua controls
Reviewed by Darin.
All tests pass.
* page/FocusController.cpp:
(WebCore::FocusController::setActive): Update control tints when the
active state changes.
* page/FrameView.cpp:
(WebCore::FrameView::updateControlTints): On Windows, we have to ask
ScrollView to paint so that the outermost scroll bars will paint. On
Mac, the outermost scroll bars are taken care of by NSScroller.
* platform/PopupMenu.h: Updated for ScrollBarClient changes.
* platform/ScrollBar.h: Added a new ScrollBarClient method.
* platform/win/PlatformScrollBarSafari.cpp:
(WebCore::PlatformScrollbar::paint): Invalidate when updating control
tints so that we can paint with the new tint later.
(WebCore::PlatformScrollbar::paintButton): Pass the active state down
to SafariTheme.
(WebCore::PlatformScrollbar::paintTrack): Ditto.
(WebCore::PlatformScrollbar::paintThumb): Ditto.
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::ScrollViewPrivate::isActive): Added.
(WebCore::ScrollView::paint): Pass paint calls on down if we're
updating control tints so the scroll bars can invalidate.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::isActive): Added.
* rendering/RenderLayer.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::isActive): Added.
* rendering/RenderListBox.h:
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isActive): Added.
* rendering/RenderTheme.h:
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::determineState): Pass the active state
down to SafariTheme.
WebKit/win:
Updated for ScrollBarClient changes
Reviewed by Darin.
* WebScrollBar.h:
(WebScrollBar::isActive): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29582
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 17 Jan 2008 17:44:35 +0000 (17:44 +0000)]
Move focused/active state from Frame to SelectionController/FocusController
WebCore:
Move focused/active state from Frame to SelectionController/FocusController
This is the first part of <rdar://
5006915> Inactive look for Aqua
controls.
The following methods were moved/renamed:
- Frame::setIsActive -> FocusController::setActive
- Frame::isActive -> SelectionController::isActiveAndFocused
- Frame::setWindowHasFocus -> SelectionController::setFocused
Active state is now correctly a Page-level concept.
The Mac parts of this patch were written by Darin.
Reviewed by Darin.
All tests pass.
* WebCore.base.exp: Updated for method renames.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::checkOneSelector): Ditto.
* editing/SelectionController.cpp:
(WebCore::SelectionController::SelectionController): Initialize new
member.
(WebCore::SelectionController::focusedOrActiveStateChanged): New
private method. Most of this code came from Frame::setIsActive.
(WebCore::SelectionController::pageActivationChanged): Added.
(WebCore::SelectionController::setFocused): Added. Replaces
Frame::setWindowHasFocus.
(WebCore::SelectionController::isFocusedAndActive): Added. Replaces
Frame::isActive.
* editing/SelectionController.h:
* page/FocusController.cpp:
(WebCore::FocusController::FocusController): Initialize new member.
(WebCore::FocusController::setFocusedFrame): Changed to just call
SelectionController::setFocused, since active state has doesn't change
when the focused frame changes.
(WebCore::FocusController::setActive): Added. Replaces
Frame::setIsActive.
* page/FocusController.h:
(WebCore::FocusController::isActive): Added.
* page/Frame.cpp:
(WebCore::Frame::setDocument): Updated for method renames.
(WebCore::Frame::setFocusedNodeIfNeeded): Ditto.
(WebCore::Frame::updateSecureKeyboardEntryIfActive): Ditto.
(WebCore::FramePrivate::FramePrivate): Removed initialization of
removed members.
* page/Frame.h:
* page/FramePrivate.h:
* page/mac/WebCoreFrameBridge.h: Removed -selectionColor.
* page/mac/WebCoreFrameBridge.mm: Ditto.
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintItemForeground): Updated for method
renames.
(WebCore::RenderListBox::paintItemBackground): Ditto.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::selectionBackgroundColor): Ditto.
(WebCore::RenderObject::selectionForegroundColor): Ditto.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::capsLockStateMayHaveChanged): Ditto.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isFocused): Ditto.
WebKit/mac:
Updated for renames/removal of WebCore methods.
Reviewed by Darin.
* Plugins/WebPluginController.mm:
(-[WebPluginController webPlugInContainerSelectionColor]): Changed to
ask isFocusedAndActive directly, instead of going through the frame
bridge.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _updateActiveState]): Updated for method renames.
WebKit/win:
Updated for changes to WebCore methods
Focus and active state are now handled (somewhat) separately. Future
patches will further separate these concepts.
Reviewed by Darin.
* WebView.cpp:
(WebViewWndProc): Updated for method renames.
(WebView::updateActiveState): Only change the active state here. Focus
is handled inside WM_SETFOCUS and WM_KILLFOCUS message handlers.
WebKit/wx:
Updated for WebCore method renames.
Reviewed by Darin.
* WebView.cpp:
(wxWebView::OnSetFocus):
(wxWebView::OnKillFocus):
(wxWebView::OnActivate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29581
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 17 Jan 2008 16:20:25 +0000 (16:20 +0000)]
Re-add DEBUG_WEBKIT_HAS_SUFFIX.
Rubber-stamped by Jon Honeycutt.
* DumpRenderTree/win/DumpRenderTree.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29580
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 17 Jan 2008 15:54:45 +0000 (15:54 +0000)]
* Make the nice 'safari' feature work on our port. When viewing a single image, clicking
on the image will zoom it.
* It seems like our platform can only determine the size of the image once it is completely
loaded. Call m_doc->imageChanged on the last chunk of data as well.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29579
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 17 Jan 2008 15:53:05 +0000 (15:53 +0000)]
Minor documentation fixes
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29578
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 17 Jan 2008 15:51:13 +0000 (15:51 +0000)]
Fix form elements not focusing correctly after the qt widget lost its focus.
When receiving a focus out event notify the focus controller. Otherwise its
m_focusedFrame variable remains unchanged and setFocusedFrame on a focusIn
event shortcuts and doesn't call setActive(true).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29577
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 17 Jan 2008 15:44:53 +0000 (15:44 +0000)]
Lots of updates to the documentation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29576
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 17 Jan 2008 14:06:12 +0000 (14:06 +0000)]
Added a urlChanged signals to QWebFrame and QWebView.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29575
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 17 Jan 2008 14:05:19 +0000 (14:05 +0000)]
Fixed docs and sanity checks in QWebSettings::setIconDatabaseEnabled
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29574
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 17 Jan 2008 14:04:35 +0000 (14:04 +0000)]
Added QWebView::createWindow() which is forwarded from QWebPage::createWindow() for convenience.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29573
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 17 Jan 2008 14:03:51 +0000 (14:03 +0000)]
Set the library version of QtWebKit to the Qt version.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29572
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 17 Jan 2008 14:03:08 +0000 (14:03 +0000)]
add a 0 pointer check.
Fixes a crash in the demo web browser.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29571
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 17 Jan 2008 13:03:37 +0000 (13:03 +0000)]
Fix QWebFrame::title().
For the titleChanged() signal we use the documentloader's title. For the property we have to use the same
instead of Document::title() as the latter is not trimmed and not suited for a window caption.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29570
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log