WebKit-https.git
10 years ago2011-02-09 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 11 Feb 2011 05:12:02 +0000 (05:12 +0000)]
2011-02-09  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        only erase draft comments after publish is successful
        https://bugs.webkit.org/show_bug.cgi?id=54163

        If there is a conflict or 500, then draft comments will survive.
        One drawback here is that the form post is now to the iframe,
        so to break out of the iframe we redirect to the bug page, which
        loses the information of who the email was sent to.

        Once WebKit supports seamless iframes we should be able to avoid
        the redirect.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 11 Feb 2011 05:07:55 +0000 (05:07 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, fix a typo.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 11 Feb 2011 04:41:56 +0000 (04:41 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 11 Feb 2011 04:24:33 +0000 (04:24 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectation update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 11 Feb 2011 04:19:54 +0000 (04:19 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 11 Feb 2011 03:55:25 +0000 (03:55 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 11 Feb 2011 03:32:01 +0000 (03:32 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, build fix.

        * DumpRenderTree/DumpRenderTree.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 11 Feb 2011 03:23:55 +0000 (03:23 +0000)]
2011-02-10  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        A little more encapsulation for MarkedBlock: Made mark bits private
        https://bugs.webkit.org/show_bug.cgi?id=54264

        SunSpider reports no change.

        * runtime/Heap.cpp:
        (JSC::Heap::markRoots):
        (JSC::Heap::reset): Renamed clearMarkBits => clearMarks, since clients
        don't need to know that marks are represented as bits. Renamed
        markedCells => markCount, since clients don't need to know that blocks
        are split into cells.

        * runtime/MarkedBlock.h:
        (JSC::MarkedBlock::isEmpty):
        (JSC::MarkedBlock::clearMarks):
        (JSC::MarkedBlock::markCount): New helper functions for encapsulating
        the information clients actually need.

        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::destroy):
        (JSC::MarkedSpace::shrink):
        (JSC::MarkedSpace::clearMarks):
        (JSC::MarkedSpace::markCount):
        (JSC::MarkedSpace::objectCount):
        * runtime/MarkedSpace.h: Use new helper functions instead of accessing
        MarkedBlock data directly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 11 Feb 2011 03:18:17 +0000 (03:18 +0000)]
2011-02-10  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        This patch adds the bulk of the remaining functionality for
        the NRWT message-passing implementation. The patch adds a new
        Worker class that will eventually replace the TestShellThread
        class in dump_render_tree_thread.py, and implements enough of
        TestRunner2 and the inline version of the manager_worker_broker
        to actually be able to send a full set of messages back and
        forth. The Worker stubs do not actually run tests, and there's
        lots of error handling and stats needed, but this is the core
        logic.

        https://bugs.webkit.org/show_bug.cgi?id=54068

        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
        * Scripts/webkitpy/layout_tests/layout_package/worker.py: Added.
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoVersioning.
mrowe@apple.com [Fri, 11 Feb 2011 03:04:20 +0000 (03:04 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 11 Feb 2011 02:57:44 +0000 (02:57 +0000)]
2011-02-10  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Repro crash with Sony Google TV ad at Gizmodo
        https://bugs.webkit.org/show_bug.cgi?id=54150
        <rdar://problem/8782346>

        Re-landing this fix, bug without the test case, since it causes hangs on the bots.
        https://bugs.webkit.org/show_bug.cgi?id=54171 tracks adding back the test.

        Since PluginView::evaluate can cause the plug-in element to go away, we need to protect it.

        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::~PluginView):
        Null out m_pluginElement here so we'll catch crashes earlier.

        (WebKit::PluginView::evaluate):
        Add a plug-in protector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 11 Feb 2011 02:24:32 +0000 (02:24 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, build fix.

        * DumpRenderTree/DumpRenderTree.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Fri, 11 Feb 2011 02:10:16 +0000 (02:10 +0000)]
2011-02-10  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        Cached JavaScript Parser Data Being Left in Memory Cache
        https://bugs.webkit.org/show_bug.cgi?id=54245

        Added clear method which removes SourceProviderCache items.
        Cleaned up extraneous whitespace.

        * JavaScriptCore.exp:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * parser/SourceProviderCache.cpp:
        (JSC::SourceProviderCache::~SourceProviderCache):
        (JSC::SourceProviderCache::clear):
        (JSC::SourceProviderCache::byteSize):
        (JSC::SourceProviderCache::add):
        * parser/SourceProviderCache.h:
2011-02-10  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        Cached JavaScript Parser Data Being Left in Memory Cache
        https://bugs.webkit.org/show_bug.cgi?id=54245

        Added logic in CachedScript to clear SourceProviderCache data in
        destroyDecodedData().  Added and changed CachedScript timeout to
        act similar to CachedImage.  Changed didAddClient to call super
        class method instead of duplicating the logic in the derived
        classes.

        * loader/cache/CachedImage.cpp:
        (WebCore::CachedImage::didAddClient):
        * loader/cache/CachedScript.cpp:
        (WebCore::CachedScript::didAddClient):
        (WebCore::CachedScript::allClientsRemoved):
        (WebCore::CachedScript::script):
        (WebCore::CachedScript::destroyDecodedData):
        * loader/cache/CachedScript.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 11 Feb 2011 02:06:21 +0000 (02:06 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, build fix.

        * DumpRenderTree/DumpRenderTree.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 11 Feb 2011 01:45:37 +0000 (01:45 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, attempt to fix crashing plugin tests.

        * DumpRenderTree/DumpRenderTree.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 11 Feb 2011 01:26:40 +0000 (01:26 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, build fix.

        * DumpRenderTree/DumpRenderTree.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix style in KURLGooglePrivate
bdakin@apple.com [Fri, 11 Feb 2011 01:23:21 +0000 (01:23 +0000)]
Fix style in KURLGooglePrivate
https://bugs.webkit.org/show_bug.cgi?id=54228

Patch by Cosmin Truta <ctruta@chromium.org> on 2011-02-10
Reviewed by David Levin.

Replace occurrences of NULL with 0, '\0' or null (as applicable),
to appease check-webkit-style.

No new tests. This is a style fix.

* platform/KURLGoogle.cpp:
* platform/KURLGooglePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Fri, 11 Feb 2011 01:16:32 +0000 (01:16 +0000)]
2011-02-10  Joseph Pecoraro  <joepeck@webkit.org>

        Follow-up fix to r78291. I should pass (int) 0, not '0' to memset.

        * runtime/GCActivityCallbackCF.cpp:
        (JSC::DefaultGCActivityCallback::commonConstructor): fix mistaken post-review change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Fri, 11 Feb 2011 01:09:34 +0000 (01:09 +0000)]
2011-02-10  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Geoffrey Garen.

        Make DefaultGCActivityCallback for PLATFORM(CF) Easier to Subclass
        https://bugs.webkit.org/show_bug.cgi?id=54257

        A subclass may want to specify the CFRunLoop that the Garbage Collection
        will happen on. It was difficult to manipulate this in a subclass because
        the current DefaultGCActivityCallback class does this in its constructor.
        This patch generalizes things a bit more so that a specific run loop can
        be passed in to the constructor. This makes it so all run loop management
        can stay in DefaultGCActivityCallback and a subclass can specify any runloop.

        * runtime/GCActivityCallback.h: expose a PLATFORM(CF) constructor that can
        specify the runloop GC can be scheduled on.
        * runtime/GCActivityCallbackCF.cpp:
        (JSC::DefaultGCActivityCallback::DefaultGCActivityCallback): two constructors,
        one that specifies the run loop and passes that on to commonConstructor and
        the old constructor defaults to the current run loop.
        (JSC::DefaultGCActivityCallback::commonConstructor): do normal construction,
        adding the timer to the given runloop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 11 Feb 2011 01:03:20 +0000 (01:03 +0000)]
2011-02-10  Martin Robinson  <mrobinson@igalia.com>

        Generate GTK+ results for many SVG tests missing them.

        * platform/gtk/Skipped: Unskip tests which now have results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Cosmin Truta <ctruta@chromium.org>
commit-queue@webkit.org [Fri, 11 Feb 2011 01:01:30 +0000 (01:01 +0000)]
2011-02-10  Cosmin Truta  <ctruta@chromium.org>

        Reviewed by David Levin.

        Fix style in KURLGooglePrivate
        https://bugs.webkit.org/show_bug.cgi?id=54228

        Replace occurrences of NULL with 0, '\0' or null (as applicable),
        to appease check-webkit-style.

        No new tests. This is a style fix.

        * platform/KURLGoogle.cpp:
        * platform/KURLGooglePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2 pages gobble up cmd-I as an editing command in some cases where it shouldn't
alice.liu@apple.com [Fri, 11 Feb 2011 00:56:24 +0000 (00:56 +0000)]
WebKit2 pages gobble up cmd-I as an editing command in some cases where it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=54254

Reviewed by Enrica Casucci and Adele Peterson.

* UIProcess/API/mac/WKView.mm:
(-[WKView _handleStyleKeyEquivalent:]):
Return early if we're not in an editable region.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry and fix some crashing tests on the chromium build bot.
weinig@apple.com [Fri, 11 Feb 2011 00:50:31 +0000 (00:50 +0000)]
Try and fix some crashing tests on the chromium build bot.

* DumpRenderTree/DumpRenderTree.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Andy Estes <aestes@apple.com>
aestes@apple.com [Fri, 11 Feb 2011 00:45:11 +0000 (00:45 +0000)]
2011-02-10  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
        https://bugs.webkit.org/show_bug.cgi?id=48719

        The HTML5 fragment parsing algorithm specifies that a new Document
        should be created to serve as the temporary parent of fragment nodes
        during parsing. Document creation is expensive and accounts for ~38% of
        the Peacekeeper DOM performance regression. Avoid the cost of creating
        a dummy document by using the already-created DocumentFragment as the
        root node during fragment parsing.

        With this patch, the regression in Peacekeeper from Safari 5.0.3 to ToT
        is ~24%.

        Test: fast/parser/fragment-parser-doctype.html

        * dom/ContainerNode.h:
        (WebCore::ContainerNode::firstElementChild): Add a method that returns
        the first element-typed child from a ContainerNode.
        * dom/Document.cpp:
        (WebCore::Document::cacheDocumentElement): Call
        ContainerNode::firstElementChild() to retrieve and cache the document
        element.
        * html/parser/HTMLConstructionSite.cpp:
        (WebCore::HTMLConstructionSite::HTMLConstructionSite): Initialize the
        root ContainerNode.
        (WebCore::HTMLConstructionSite::detach): Clear the reference to the
        root ContainerNode.
        (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
        Attach the new element to the root ContainerNode.
        (WebCore::HTMLConstructionSite::insertDoctype): Ditto.
        (WebCore::HTMLConstructionSite::insertCommentOnDocument): Ditto.
        * html/parser/HTMLConstructionSite.h: Store a pointer to a
        ContainerNode that will be used as the root node for document parsing.
        This node might or might not be the same as m_document.
        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): Initialize the
        HTMLConstructionSite with the correct root ContainerNode based on
        whether or not we're parsing a fragment.
        (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
        Remove m_dummyDocumentForFragmentParsing.
        (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished): If the
        fragment has a context element, store only the children of the root
        element (HTML5 Section 10.4, Step 7).
        * html/parser/HTMLTreeBuilder.h:
2011-02-09  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
        https://bugs.webkit.org/show_bug.cgi?id=48719

        * fast/parser/fragment-parser-doctype-expected.txt: Added.
        * fast/parser/fragment-parser-doctype.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSpeculative fix for <rdar://problem/8985232> Overlay
bdakin@apple.com [Fri, 11 Feb 2011 00:32:32 +0000 (00:32 +0000)]
Speculative fix for <rdar://problem/8985232> Overlay
scrollers can appear on the sliding page during
back/forward fluid gesture

Reviewed by Oliver Hunt.

* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPartAnimation scrollAnimatorDestroyed]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 11 Feb 2011 00:20:17 +0000 (00:20 +0000)]
2011-02-10  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        A little more encapsulation for MarkedBlock: Moved allocate() and sweep() into MarkedBlock
        https://bugs.webkit.org/show_bug.cgi?id=54253

        SunSpider reports no change.

        * runtime/CollectorHeapIterator.h: Removed DeadObjectIterator, since it
        is now unused.

        * runtime/Heap.cpp:
        (JSC::Heap::reset): Moved the call to shrink() here, since it seems a
        little more clear for MarkedSpace's client to tell it explicitly when to
        shrink.

        * runtime/JSCell.h:
        (JSC::JSCell::MarkedBlock::allocate): Split out from MarkedSpace::allocate.

        * runtime/MarkedBlock.cpp:
        (JSC::MarkedBlock::sweep): Split out from MarkedSpace::sweep, and
        converted to more directly iterate a MarkedBlock based on knowing its
        internal structure.

        * runtime/MarkedBlock.h:
        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::allocate):
        (JSC::MarkedSpace::sweep):
        * runtime/MarkedSpace.h: Split out the code mentioned above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-09 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 11 Feb 2011 00:14:37 +0000 (00:14 +0000)]
2011-02-09  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        save overall comments when saving drafts in the review tool
        https://bugs.webkit.org/show_bug.cgi?id=54165

        -save overall comments in localstorage as well
        -save all draft comments as you type
        -give a *subtle* indicator of saved state

        The latter should also make it super easy if someone wanted to do
        the work to store draft comments in appengine/s3/bugzilla/etc.

        * PrettyPatch/PrettyPatch.rb:
        * code-review-test.html:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 10 Feb 2011 23:58:13 +0000 (23:58 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 10 Feb 2011 23:51:41 +0000 (23:51 +0000)]
2011-02-10  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Log an error if a plug-in test can't be found
        https://bugs.webkit.org/show_bug.cgi?id=54252

        * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
        (PluginTest::create):
        Return null if the test wasn't found.

        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
        (NPP_New):
        Report an error if PluginTest::create returns null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-09 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 10 Feb 2011 23:49:18 +0000 (23:49 +0000)]
2011-02-09  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        IndexedDB event targets need to ensure their wrappers aren't garbage collected
        https://bugs.webkit.org/show_bug.cgi?id=54144

        hasActivityPending should return true as long as it's possible that we'll
        fire more event listeners on our event targets. It is still possible for
        user generated events to run into problems, but I'm not sure how to address
        that yet (or how big of a deal it is).

        There's really no way to test this deterministically. Testing by hand makes
        it seem like this patch works as expected though.

        * storage/IDBCursorBackendImpl.cpp:
        * storage/IDBDatabase.cpp:
        (WebCore::IDBDatabase::IDBDatabase):
        (WebCore::IDBDatabase::~IDBDatabase):
        (WebCore::IDBDatabase::hasPendingActivity):
        (WebCore::IDBDatabase::stop):
        * storage/IDBDatabase.h:
        * storage/IDBRequest.cpp:
        (WebCore::IDBRequest::IDBRequest):
        (WebCore::IDBRequest::hasPendingActivity):
        (WebCore::IDBRequest::dispatchEvent):
        (WebCore::IDBRequest::enqueueEvent):
        * storage/IDBRequest.h:
        * storage/IDBTransaction.cpp:
        (WebCore::IDBTransaction::finished):
        (WebCore::IDBTransaction::hasPendingActivity):
        (WebCore::IDBTransaction::dispatchEvent):
        (WebCore::IDBTransaction::canSuspend):
        (WebCore::IDBTransaction::contextDestroyed):
        (WebCore::IDBTransaction::enqueueEvent):
        * storage/IDBTransaction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 10 Feb 2011 23:29:10 +0000 (23:29 +0000)]
2011-02-10  Martin Robinson  <mrobinson@igalia.com>

        Add results for HTTP tests missing GTK+ results.

        * platform/gtk/Skipped: Unskip HTTP tests that now have results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 10 Feb 2011 23:26:37 +0000 (23:26 +0000)]
2011-02-10  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        Fix compilation error on OpenBSD
        https://bugs.webkit.org/show_bug.cgi?id=53766

        Add a HAVE_STRNSTR in Platform.h and define it only on Darwin and FreeBSD.

        * wtf/Platform.h:
        * wtf/StringExtras.h: Use HAVE(STRNSTR) now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 10 Feb 2011 23:23:34 +0000 (23:23 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, tiny test fix from cira.

        Excluding v8Locale from property-inheritance test
        https://bugs.webkit.org/show_bug.cgi?id=54250

        * fast/dom/script-tests/prototype-inheritance.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 10 Feb 2011 23:03:19 +0000 (23:03 +0000)]
2011-02-10  Martin Robinson  <mrobinson@igalia.com>

        Unskip some GTK+ HTTP tests that are passing locally. All the bots
        should have the same libsoup version now.

        * platform/gtk/Skipped: Unskip some passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 10 Feb 2011 22:58:10 +0000 (22:58 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Thu, 10 Feb 2011 22:57:18 +0000 (22:57 +0000)]
2011-02-10  Andreas Kling  <kling@webkit.org>

        Unreviewed Qt build fix.

        waitFor() -> deprecatedWaitFor()

        * UIProcess/TiledDrawingAreaProxy.cpp:
        (WebKit::TiledDrawingAreaProxy::waitUntilUpdatesComplete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
commit-queue@webkit.org [Thu, 10 Feb 2011 22:54:20 +0000 (22:54 +0000)]
2011-02-10  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] create pkg-config files for mingw
        https://bugs.webkit.org/show_bug.cgi?id=54238

        (mingw is mostly the same as unix)

        This change was applied in the Qt repository (qt/src/3rdparty/webkit),
        so we should do the same here in QtWebKit.

        Patch by Mark Brand <mabrand@mabrand.nl>, reviewed (there) by
        Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
        45fe2dddc3a0677b9ec9fce09f07cd4129e37afa

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Thu, 10 Feb 2011 22:52:57 +0000 (22:52 +0000)]
2011-02-10  Andreas Kling  <kling@webkit.org>

        Reviewed by Antti Koivisto.

        RenderStyle: Remove duplicate comparison of InheritedFlags::_text_transform
        https://bugs.webkit.org/show_bug.cgi?id=54246

        * rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Thu, 10 Feb 2011 22:45:04 +0000 (22:45 +0000)]
2011-02-10  Dirk Schulze  <krit@webkit.org>

        Reviewed by Andreas Kling.

        SVG animation avoid unnecessary adjust for currentColor
        https://bugs.webkit.org/show_bug.cgi?id=54243

        At the moment we try to adjust every animation value for currentColor - independent of the animation type.
        Since the value is a string and the target element may needs to get called by getElementById, this could
        be an expensive and unnecessary operation. Also after we adjust for currentColor, we save the result back
        as a string and parse it to Color afterwards again.
        With the patch we just adjust an animation value, if we use color animation. The color won't get saved and
        parsed as a string again.

        No change of functionality, no new tests.

        * svg/SVGAnimateElement.cpp:
        (WebCore::adjustForCurrentColor):
        (WebCore::SVGAnimateElement::calculateFromAndToValues):
        (WebCore::SVGAnimateElement::calculateFromAndByValues):
        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
        (WebCore::SVGAnimationElement::startedActiveInterval):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
commit-queue@webkit.org [Thu, 10 Feb 2011 22:32:06 +0000 (22:32 +0000)]
2011-02-10  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Ensure WebView press delay timer is cancelled when grab is taken
        https://bugs.webkit.org/show_bug.cgi?id=54242

        As reported in:
        http://bugreports.qt.nokia.com/browse/QTBUG-15529

        Flickable steals the grab, but the timer was not stopped and the
        keepGrab flag is set and the mouse grabbed. This means that the WebView
        now has the grab and subsequent clicks on another element are ignored.

        Original patch from Martin Jones <martin.jones@nokia.com>
        reviewed (there) by Joona Petrell
        52068f57f9c32098a90cc217730a530f85590f65

        * declarative/qdeclarativewebview.cpp:
        (GraphicsWebView::sceneEvent):
        * declarative/qdeclarativewebview_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
commit-queue@webkit.org [Thu, 10 Feb 2011 22:17:28 +0000 (22:17 +0000)]
2011-02-10  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Fix assert in QDeclarativeWebView
        https://bugs.webkit.org/show_bug.cgi?id=54240

        As reported in:
        http://bugreports.qt.nokia.com/browse/QTBUG-14278

        Instantiating a QDeclarativeWebView twice will trigger an assertion
        when in debug mode.

        Original patch from Thomas Hartmann <Thomas.Hartmann@nokia.com>,
        reviewed (there) by Aaron Kennedy
        f532679ca11914b453e22342f2ae5e9f790ce47a

        * declarative/qdeclarativewebview.cpp:
        (QDeclarativeWebView::init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
commit-queue@webkit.org [Thu, 10 Feb 2011 22:15:15 +0000 (22:15 +0000)]
2011-02-10  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Remove the use of deprecated qFindChildren()
        https://bugs.webkit.org/show_bug.cgi?id=54232

        This was applied on the Qt repository and affects QtWebKit there.
        (13833beb641289c45faed337848d37280195aadc)

        The side effect of this change is that we won't be able to build
        QtWebKit with MSVC 6, as it doesn't support member template functions
        (not sure if that's possible today anyway).

        Original patch from Olivier Goffart <olivier.goffart@nokia.com>, with
        review reported as being from the mailing list.

        The changes are result of the following commands:

            git grep -O"sed -i 's/qF\(indChildr*e*n*<[^>]*>\)(this,* */f\\1(/'" qFindChild
            git grep -O"sed -i 's/qF\(indChildr*e*n*<[^>]*>\)(&\([^\(),]*\),* */\\2.f\\1(/'" qFindChild
            git grep -O"sed -i 's/qF\(indChildr*e*n*<[^>]*>\)(\([^\(),]*()\),* */\\2->f\\1(/'" qFindChild
            git grep -O"sed -i 's/qF\(indChildr*e*n*<[^>]*>\)(\([^\(),]*\):\([^\(),]*\),* */(\\2:\\3)->f\\1(/'" qFindChild
            git grep -O"sed -i 's/qF\(indChildr*e*n*<[^>]*>\)(\([^\(),]*\),* */\\2->f\\1(/'" qFindChild

        * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
        (WebCore::MediaPlayerPrivatePhonon::MediaPlayerPrivatePhonon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
commit-queue@webkit.org [Thu, 10 Feb 2011 21:59:52 +0000 (21:59 +0000)]
2011-02-10  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Misc documentation fixes/updates
        https://bugs.webkit.org/show_bug.cgi?id=54236

        There are a few commits in the Qt repository (master and 4.7 branches)
        with QtWebKit documentation fixes:

        84d278501a19eaccf9a77cccd95ca5d17a2dcd2b
        Clarified documentation of loadFinished() signal

        eebe205b306daaa3674d9746de11a73bef4bd0de
        Doc: Fixed QML, unindented snippet

        b0d64717d2c541976dc5524e4100c62f060e206f
        doc: Changed a table into 3 tables to eliminate a \raw.

        As these are all minor doc changes, I decided to group them
        into one single patch.

        * Api/qwebpage.cpp:
        * declarative/qdeclarativewebview.cpp:
        * docs/qtwebkit.qdoc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
commit-queue@webkit.org [Thu, 10 Feb 2011 21:58:32 +0000 (21:58 +0000)]
2011-02-10  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Rename build target from "embedded" to "qpa"
        https://bugs.webkit.org/show_bug.cgi?id=54233

        This flag is used by Qt's configure script to enable a QPA build
        ("QPA is a window system agnostic implementation of Qt" --
        previously known as lighthouse).

        On the Qt repository, this was changed by two commits:

        13a0b4935900093607f2b3b7688e1452d22770fd
        (from embedded to embedded_lite)

        9716e12e0f5590ebc23ad9fb7ba75c6a3c5aadab
        (from embedded_lite to qpa)

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 10 Feb 2011 21:49:24 +0000 (21:49 +0000)]
2011-02-10  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        Incorporate algorithm for processing paths into GPU-renderable triangle meshes
        https://bugs.webkit.org/show_bug.cgi?id=45521

        Adding an implementation of Loop and Blinn's GPU accelerated path
        rendering algorithm from GPU Gems 3. This implementation pays
        particular attention to the efficiency of the curve subdivision
        phase needed for correct rendering. It utilizes the OpenGL utility
        library tessellator for triangulation of the interior of the
        shape. The regions handled by Loop and Blinn's algorithm are
        handled by the local triangulator previously incorporated.

        No tests yet; pixel tests will eventually be used to verify this
        algorithm and prevent regressions.

        * platform/graphics/gpu/LoopBlinnPathProcessor.cpp: Added.
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::Segment):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::setup):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::kind):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::getPoint):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::next):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::prev):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::setNext):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::setPrev):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::contour):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::subdivide):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::boundingBox):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::numCrossingsForXRay):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::numberOfTriangles):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::getTriangle):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::numberOfInteriorVertices):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::getInteriorVertex):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::markedForSubdivision):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::setMarkedForSubdivision):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::toString):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::computeBoundingBox):
        (WebCore::LoopBlinnPathProcessorImplementation::Contour::Contour):
        (WebCore::LoopBlinnPathProcessorImplementation::Contour::add):
        (WebCore::LoopBlinnPathProcessorImplementation::Contour::subdivide):
        (WebCore::LoopBlinnPathProcessorImplementation::Contour::begin):
        (WebCore::LoopBlinnPathProcessorImplementation::Contour::end):
        (WebCore::LoopBlinnPathProcessorImplementation::Contour::isOrientedCounterClockwise):
        (WebCore::LoopBlinnPathProcessorImplementation::Contour::setIsOrientedCounterClockwise):
        (WebCore::LoopBlinnPathProcessorImplementation::Contour::boundingBox):
        (WebCore::LoopBlinnPathProcessorImplementation::Contour::fillSide):
        (WebCore::LoopBlinnPathProcessorImplementation::Contour::setFillSide):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::triangulate):
        (WebCore::LoopBlinnPathProcessor::LoopBlinnPathProcessor):
        (WebCore::LoopBlinnPathProcessor::~LoopBlinnPathProcessor):
        (WebCore::LoopBlinnPathProcessor::process):
        (WebCore::LoopBlinnPathProcessor::buildContours):
        (WebCore::LoopBlinnPathProcessor::allSegmentsOverlappingY):
        (WebCore::LoopBlinnPathProcessor::determineSidesToFill):
        (WebCore::LoopBlinnPathProcessor::determineOrientation):
        (WebCore::SweepData::SweepEvent::SweepEvent):
        (WebCore::SweepData::SweepEvent::setup):
        (WebCore::SweepData::SweepEvent::x):
        (WebCore::SweepData::SweepEvent::entry):
        (WebCore::SweepData::SweepEvent::interval):
        (WebCore::SweepData::SweepEvent::operator<):
        (WebCore::SweepData::trianglesOverlap):
        (WebCore::LoopBlinnPathProcessor::subdivideCurves):
        (WebCore::LoopBlinnPathProcessor::conditionallySubdivide):
        (WebCore::LoopBlinnPathProcessor::subdivideCurvesSlow):
        (WebCore::TessellationState::vertexCallback):
        (WebCore::TessellationState::combineCallback):
        (WebCore::TessellationState::edgeFlagCallback):
        (WebCore::LoopBlinnPathProcessor::tessellateInterior):
        * platform/graphics/gpu/LoopBlinnPathProcessor.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
commit-queue@webkit.org [Thu, 10 Feb 2011 21:18:24 +0000 (21:18 +0000)]
2011-02-10  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Remove the use of deprecated qVariant*
        https://bugs.webkit.org/show_bug.cgi?id=54229

        This was applied on the Qt repository and affects QtWebKit there.
        (633f3f45e5420663cf4ceadea79e62fea44cd2eb)

        The side effect of this change is that we won't be able to build
        QtWebKit with MSVC 6, as it doesn't support member template functions
        (not sure if it's possible today anyway).

        Original patch from Olivier Goffart <olivier.goffart@nokia.com>, with
        review reported as being from the mailing list.

        The changes are result of the following commands:

            git grep -O"sed -i 's/qVariantValue</qvariant_cast</'" qVariantValue
            git grep -O"sed -i 's/qVariantSetValue(\([^&*\(),]*\), */\\1.setValue(/'" qVariantSetValue
            git grep -O"sed -i 's/qVariantSetValue *<\([^>]*\)> *(\([^&*\(),]*\), */\\2.setValue<\\1>(/'" qVariantSetValue
            git grep -O"sed -i 's/qVariantCanConvert *<\([^>]*\)> *(\([^&*\(),]*\))/\\2.canConvert<\\1>()/g'" qVariantCanConvert
            git grep -O"sed -i 's/qVariantCanConvert *<\([^>]*\)> *(\([^&*\(),]*([^&*\(),]*)\))/\\2.canConvert<\\1>()/g'" qVariantCanConvert
            git grep -O"sed -i 's/qVariantFromValue\( *[(<]\)/QVariant::fromValue\\1/'" qVariantFromValue

        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::convertValueToQVariant):
        * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
        (WebCore::MediaPlayerPrivateQt::commitLoad):
2011-02-10  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Remove the use of deprecated qVariant*
        https://bugs.webkit.org/show_bug.cgi?id=54229

        This was applied on the Qt repository and affects QtWebKit there.
        (633f3f45e5420663cf4ceadea79e62fea44cd2eb)

        The side effect of this change is that we won't be able to build
        QtWebKit with MSVC 6, as it doesn't support member template functions
        (not sure if it's possible today anyway).

        Original patch from Olivier Goffart <olivier.goffart@nokia.com>, with
        review reported as being from the mailing list.

        The changes are result of the following commands:

            git grep -O"sed -i 's/qVariantValue</qvariant_cast</'" qVariantValue
            git grep -O"sed -i 's/qVariantSetValue(\([^&*\(),]*\), */\\1.setValue(/'" qVariantSetValue
            git grep -O"sed -i 's/qVariantSetValue *<\([^>]*\)> *(\([^&*\(),]*\), */\\2.setValue<\\1>(/'" qVariantSetValue
            git grep -O"sed -i 's/qVariantCanConvert *<\([^>]*\)> *(\([^&*\(),]*\))/\\2.canConvert<\\1>()/g'" qVariantCanConvert
            git grep -O"sed -i 's/qVariantCanConvert *<\([^>]*\)> *(\([^&*\(),]*([^&*\(),]*)\))/\\2.canConvert<\\1>()/g'" qVariantCanConvert
            git grep -O"sed -i 's/qVariantFromValue\( *[(<]\)/QVariant::fromValue\\1/'" qVariantFromValue

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::nodesFromRect):
        * tests/qwebframe/tst_qwebframe.cpp:
        (MyQObject::myInvokableWithQObjectListArg):
        (MyQObject::myInvokableWithListOfIntArg):
        (MyQObject::myInvokableWithQObjectStarArg):
        (MyQObject::myInvokableWithQBrushArg):
        (MyQObject::myInvokableWithBrushStyleArg):
        (MyQObject::myInvokableWithVoidStarArg):
        (MyQObject::myInvokableWithAmbiguousArg):
        (MyQObject::myInvokableWithDefaultArgs):
        (MyQObject::myInvokableWithPointArg):
        (MyQObject::myOverloadedSlot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 10 Feb 2011 21:10:09 +0000 (21:10 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, rebaseline.

        * platform/chromium-mac/fast/text/international/text-combine-image-test-expected.checksum: Removed.
        * platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png: Removed.
        * platform/mac-leopard/fast/text/international/text-combine-image-test-expected.checksum: Added.
        * platform/mac-leopard/fast/text/international/text-combine-image-test-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Thu, 10 Feb 2011 21:04:40 +0000 (21:04 +0000)]
2011-02-10  Nico Weber  <thakis@chromium.org>

        Reviewed by Darin Adler.

        Fix clang warning "WebCore::HTMLAreaElement::getRect' hides overloaded virtual function [-Woverloaded-virtual]"
        https://bugs.webkit.org/show_bug.cgi?id=54221

        The method name conflicts with ContainerNode::getRect() so rename it to
        computeRect(). Rename getPath() to computePath() for consistency as
        well.

        No intended functionality change, covered by existing tests.

        * accessibility/AccessibilityImageMapLink.cpp:
        (WebCore::AccessibilityImageMapLink::elementRect):
        * html/HTMLAreaElement.cpp:
        (WebCore::HTMLAreaElement::computePath):
        (WebCore::HTMLAreaElement::computeRect):
        * html/HTMLAreaElement.h:
        * page/SpatialNavigation.cpp:
        (WebCore::virtualRectForAreaElementAndDirection):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paintFocusRing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 10 Feb 2011 21:04:34 +0000 (21:04 +0000)]
2011-02-10  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Move code to dispatch an incoming message out into a new function
        https://bugs.webkit.org/show_bug.cgi?id=54239

        This also fixes a leak where we wouldn't free ArgumentDecoder objects
        after a connection has been invalidated.

        * Platform/CoreIPC/Connection.cpp:
        (CoreIPC::Connection::dispatchMessage):
        (CoreIPC::Connection::dispatchMessages):
        * Platform/CoreIPC/Connection.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Alexis Menard <alexis.menard@nokia.com>
commit-queue@webkit.org [Thu, 10 Feb 2011 20:44:54 +0000 (20:44 +0000)]
2011-02-10  Alexis Menard  <alexis.menard@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Default focus ring is too wide
        https://bugs.webkit.org/show_bug.cgi?id=51854

        We now respect the outline property and html.css defines the outline of the focus
        ring to be 5px. This is propagated until GraphicsContext::drawFocusRing which uses
        it as the pen size. We should ignore the size and keep a default one. I also
        reverted the SolidLine to DotLine so that the selection looks nicer. Chromium Skia,
        CG Win, Haiku, WinCE ports also ignore the width.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::drawFocusRingForPath):
        (WebCore::GraphicsContext::drawFocusRing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 10 Feb 2011 20:36:12 +0000 (20:36 +0000)]
2011-02-10  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Anders Carlsson.

        Skip newly added tests that use eventSender
        https://bugs.webkit.org/show_bug.cgi?id=54235

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 10 Feb 2011 20:26:58 +0000 (20:26 +0000)]
2011-02-10  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [Soup] ResourceHandleSoup does not ever call didSendData for file uploads
        https://bugs.webkit.org/show_bug.cgi?id=52090

        * platform/gtk/Skipped: Unskip tests which should now be passing.
2011-02-10  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [Soup] ResourceHandleSoup does not ever call didSendData for file uploads
        https://bugs.webkit.org/show_bug.cgi?id=52090

        Call didSendData as body data is uploaded to the server. This is necessary
        for XHR upload events to function properly.

        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal): Add two new members.
        One to track the total amount of body data and one to track the total amount of
        body data sent so far.
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::wroteBodyDataCallback): Added.
        (WebCore::addFormElementsToSoupMessage): Split this out into a helper function.
        Will now now sum the total amount of body data.
        (WebCore::startHttp): Attach a wrote-body-data signal handler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Robert Hogan <robert@webkit.org>
robert@webkit.org [Thu, 10 Feb 2011 20:18:27 +0000 (20:18 +0000)]
2011-02-10  Robert Hogan  <robert@webkit.org>

        Reviewed by Laszlo Gombos.

        [Qt] Return menu items from eventSender.contextMenu()
        https://bugs.webkit.org/show_bug.cgi?id=53039

        * platform/qt/Skipped: unskip editing/selection/context-menu-on-text.html
2011-02-10  Robert Hogan  <robert@webkit.org>

        Reviewed by Laszlo Gombos.

        [Qt] Return menu items from eventSender.contextMenu()
        https://bugs.webkit.org/show_bug.cgi?id=53039

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (iterateContextMenu):
        (DumpRenderTreeSupportQt::contextMenu):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-02-10  Robert Hogan  <robert@webkit.org>

        Reviewed by Laszlo Gombos.

        [Qt] Return menu items from eventSender.contextMenu()
        https://bugs.webkit.org/show_bug.cgi?id=53039

        * DumpRenderTree/qt/EventSenderQt.cpp:
        (EventSender::contextClick):
        * DumpRenderTree/qt/EventSenderQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry again to fix the Qt build.
andersca@apple.com [Thu, 10 Feb 2011 20:12:54 +0000 (20:12 +0000)]
Try again to fix the Qt build.

* UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::sizeDidChange):
(WebKit::TiledDrawingAreaProxy::setPageIsVisible):
(WebKit::TiledDrawingAreaProxy::takeSnapshot):
(WebKit::TiledDrawingAreaProxy::removeTile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 10 Feb 2011 19:58:41 +0000 (19:58 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, rebaseline.

        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
        * platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.checksum:
        * platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt:
        * platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.checksum:
        * platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Bill Budge <bbudge@chromium.org>
commit-queue@webkit.org [Thu, 10 Feb 2011 19:50:37 +0000 (19:50 +0000)]
2011-02-10  Bill Budge  <bbudge@chromium.org>

        Reviewed by David Levin.

        Add fields to ResourceRequest and ResourceResponse in preparation for adding CORS support to AssociatedURLLoader.
        https://bugs.webkit.org/show_bug.cgi?id=53925

        * platform/network/chromium/ResourceRequest.cpp:
        (WebCore::ResourceRequest::doPlatformCopyData):
        (WebCore::ResourceRequest::doPlatformAdopt):
        * platform/network/chromium/ResourceRequest.h:
        (WebCore::ResourceRequest::ResourceRequest):
        (WebCore::ResourceRequest::downloadToFile):
        (WebCore::ResourceRequest::setDownloadToFile):
        * platform/network/chromium/ResourceResponse.cpp:
        (WebCore::ResourceResponse::doPlatformCopyData):
        (WebCore::ResourceResponse::doPlatformAdopt):
        * platform/network/chromium/ResourceResponse.h:
        (WebCore::ResourceResponse::downloadFilePath):
        (WebCore::ResourceResponse::setDownloadFilePath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAttempt to fix the Qt build.
andersca@apple.com [Thu, 10 Feb 2011 19:37:27 +0000 (19:37 +0000)]
Attempt to fix the Qt build.

* UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::sizeDidChange):
(WebKit::TiledDrawingAreaProxy::setPageIsVisible):
(WebKit::TiledDrawingAreaProxy::requestTileUpdate):
(WebKit::TiledDrawingAreaProxy::takeSnapshot):
(WebKit::TiledDrawingAreaProxy::removeTile):
* WebProcess/WebPage/TiledDrawingArea.cpp:
(WebKit::TiledDrawingArea::display):
(WebKit::TiledDrawingArea::setSize):
(WebKit::TiledDrawingArea::updateTile):
(WebKit::TiledDrawingArea::tileUpdateTimerFired):
(WebKit::TiledDrawingArea::didReceiveMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoHandle a null FindIndicator correctly
aroben@apple.com [Thu, 10 Feb 2011 19:26:07 +0000 (19:26 +0000)]
Handle a null FindIndicator correctly

We are passed a null FindIndicator when the find indicator becomes hidden.

Fixes <http://webkit.org/b/54213> <rdar://problem/8983261> REGRESSION (r78198): Crash in
FindIndicator::contentImage when scrolling page

Reviewed by Steve Falkenburg.

Source/WebKit2:

* Platform/win/SharedMemoryWin.cpp:
(WebKit::SharedMemory::Handle::isNull): Implemented.
(WebKit::SharedMemory::create): Bail out if the handle is null, just like Mac does.
Otherwise assert that ::MapViewOfFile succeeded. This doesn't fix the bug, but should help
catch other errors.

* UIProcess/win/WebView.cpp:
(WebKit::WebView::setFindIndicator): Null-check the FindIndicator before dereferencing it.
Also changed the function to store the FindIndicator in a RefPtr.

Tools:

Test showing and hiding the find indicator on Windows

* TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added.
(TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
(TestWebKitAPI::findIndicatorCallback): Record that the callback was called, and save the
bitmap.
(TestWebKitAPI::initialize): Hook up our callbacks.
(TestWebKitAPI::TEST): Test showing then hiding the find indicator to see if we crash.

* TestWebKitAPI/PlatformWebView.h:
* TestWebKitAPI/mac/PlatformWebViewMac.mm:
(TestWebKitAPI::PlatformWebView::page):
* TestWebKitAPI/win/PlatformWebViewWin.cpp:
(TestWebKitAPI::PlatformWebView::page):
Made page a const member function.

* TestWebKitAPI/win/TestWebKitAPI.vcproj: Added the new test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPrint locations of assertions and logs in a way that Visual Studio understands
aroben@apple.com [Thu, 10 Feb 2011 19:25:18 +0000 (19:25 +0000)]
Print locations of assertions and logs in a way that Visual Studio understands

With this change, double-clicking one of these locations in Visual Studio's Output Window
will focus that line of code in the editor.

Fixes <http://webkit.org/b/54208> Double-clicking locations of assertions/logs in Visual
Studio's Output Window does nothing

Reviewed by Alexey Proskuryakov.

* wtf/Assertions.cpp:
(printCallSite): Use OS(WINDOWS) instead of the meaningless OS(WIN). When we aren't using
the debug CRT (and thus can't call _CrtDbgReport), print the file and line number using the
same format that cl.exe uses when it prints compiler errors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Thu, 10 Feb 2011 19:16:16 +0000 (19:16 +0000)]
2011-02-10  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGAnimateElement needs information about the animated attribute type
        https://bugs.webkit.org/show_bug.cgi?id=53442

        For animations, we need to know the SVG property type for a XML attribute. A global static mapping between
        attribute name and a type is not possible, since one attribute name can be bound to different property types:
        x can be a SVGNumberList, a SVGNumber or a SVGLength. So we have to ask every target element, if it supports
        the animated attribute and of which type it is. Just for CSS properties we can share an explicit mapping between
        the name and the type. This is done in a static map in SVGStyledElement. All other mappings are stored in local static
        HashMaps for all SVG elements with animated properties. These maps get filled once with the fillAttributeToPropertyTypeMap function
        that needs to be included in every SVG element. The function is not virtual in base classes for performance reasons.

        No change of functionality, so no new test cases.

        * svg/SVGAElement.cpp:
        (WebCore::SVGAElement::attributeToPropertyTypeMap):
        (WebCore::SVGAElement::fillAttributeToPropertyTypeMap):
        * svg/SVGAElement.h:
        * svg/SVGAltGlyphElement.cpp:
        (WebCore::SVGAltGlyphElement::attributeToPropertyTypeMap):
        (WebCore::SVGAltGlyphElement::fillAttributeToPropertyTypeMap):
        * svg/SVGAltGlyphElement.h:
        * svg/SVGAnimateElement.cpp:
        (WebCore::SVGAnimateElement::determinePropertyType):
        * svg/SVGCircleElement.cpp:
        (WebCore::SVGCircleElement::attributeToPropertyTypeMap):
        (WebCore::SVGCircleElement::fillAttributeToPropertyTypeMap):
        * svg/SVGCircleElement.h:
        * svg/SVGClipPathElement.cpp:
        (WebCore::SVGClipPathElement::attributeToPropertyTypeMap):
        (WebCore::SVGClipPathElement::fillAttributeToPropertyTypeMap):
        * svg/SVGClipPathElement.h:
        * svg/SVGComponentTransferFunctionElement.cpp:
        (WebCore::SVGComponentTransferFunctionElement::attributeToPropertyTypeMap):
        (WebCore::SVGComponentTransferFunctionElement::fillAttributeToPropertyTypeMap):
        * svg/SVGComponentTransferFunctionElement.h:
        * svg/SVGCursorElement.cpp:
        (WebCore::SVGCursorElement::attributeToPropertyTypeMap):
        (WebCore::SVGCursorElement::fillAttributeToPropertyTypeMap):
        * svg/SVGCursorElement.h:
        * svg/SVGElement.cpp:
        (WebCore::SVGElement::attributeToPropertyTypeMap):
        (WebCore::SVGElement::animatedPropertyTypeForAttribute):
        * svg/SVGElement.h:
        (WebCore::SVGElement::fillAttributeToPropertyTypeMap):
        * svg/SVGEllipseElement.cpp:
        (WebCore::SVGEllipseElement::attributeToPropertyTypeMap):
        (WebCore::SVGEllipseElement::fillAttributeToPropertyTypeMap):
        * svg/SVGEllipseElement.h:
        * svg/SVGFEBlendElement.cpp:
        (WebCore::SVGFEBlendElement::attributeToPropertyTypeMap):
        (WebCore::SVGFEBlendElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEBlendElement.h:
        * svg/SVGFEColorMatrixElement.cpp:
        (WebCore::SVGFEColorMatrixElement::attributeToPropertyTypeMap):
        (WebCore::SVGFEColorMatrixElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEColorMatrixElement.h:
        * svg/SVGFEComponentTransferElement.cpp:
        (WebCore::SVGFEComponentTransferElement::attributeToPropertyTypeMap):
        (WebCore::SVGFEComponentTransferElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEComponentTransferElement.h:
        * svg/SVGFECompositeElement.cpp:
        (WebCore::SVGFECompositeElement::attributeToPropertyTypeMap):
        (WebCore::SVGFECompositeElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFECompositeElement.h:
        * svg/SVGFEConvolveMatrixElement.cpp:
        (WebCore::SVGFEConvolveMatrixElement::attributeToPropertyTypeMap):
        (WebCore::SVGFEConvolveMatrixElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEConvolveMatrixElement.h:
        * svg/SVGFEDiffuseLightingElement.cpp:
        (WebCore::SVGFEDiffuseLightingElement::attributeToPropertyTypeMap):
        (WebCore::SVGFEDiffuseLightingElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEDiffuseLightingElement.h:
        * svg/SVGFEDisplacementMapElement.cpp:
        (WebCore::SVGFEDisplacementMapElement::attributeToPropertyTypeMap):
        (WebCore::SVGFEDisplacementMapElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEDisplacementMapElement.h:
        * svg/SVGFEFloodElement.cpp:
        (WebCore::SVGFEFloodElement::attributeToPropertyTypeMap):
        (WebCore::SVGFEFloodElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEFloodElement.h:
        * svg/SVGFEGaussianBlurElement.cpp:
        (WebCore::SVGFEGaussianBlurElement::attributeToPropertyTypeMap):
        (WebCore::SVGFEGaussianBlurElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEGaussianBlurElement.h:
        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::attributeToPropertyTypeMap):
        (WebCore::SVGFEImageElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEImageElement.h:
        * svg/SVGFELightElement.cpp:
        (WebCore::SVGFELightElement::attributeToPropertyTypeMap):
        (WebCore::SVGFELightElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFELightElement.h:
        * svg/SVGFEMergeElement.cpp:
        (WebCore::SVGFEMergeElement::attributeToPropertyTypeMap):
        (WebCore::SVGFEMergeElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEMergeElement.h:
        * svg/SVGFEMergeNodeElement.cpp:
        (WebCore::SVGFEMergeNodeElement::attributeToPropertyTypeMap):
        (WebCore::SVGFEMergeNodeElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEMergeNodeElement.h:
        * svg/SVGFEMorphologyElement.cpp:
        (WebCore::SVGFEMorphologyElement::attributeToPropertyTypeMap):
        (WebCore::SVGFEMorphologyElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEMorphologyElement.h:
        * svg/SVGFEOffsetElement.cpp:
        (WebCore::SVGFEOffsetElement::attributeToPropertyTypeMap):
        (WebCore::SVGFEOffsetElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEOffsetElement.h:
        * svg/SVGFESpecularLightingElement.cpp:
        (WebCore::SVGFESpecularLightingElement::attributeToPropertyTypeMap):
        (WebCore::SVGFESpecularLightingElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFESpecularLightingElement.h:
        * svg/SVGFETileElement.cpp:
        (WebCore::SVGFETileElement::attributeToPropertyTypeMap):
        (WebCore::SVGFETileElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFETileElement.h:
        * svg/SVGFETurbulenceElement.cpp:
        (WebCore::SVGFETurbulenceElement::attributeToPropertyTypeMap):
        (WebCore::SVGFETurbulenceElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFETurbulenceElement.h:
        * svg/SVGFilterElement.cpp:
        (WebCore::SVGFilterElement::attributeToPropertyTypeMap):
        (WebCore::SVGFilterElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFilterElement.h:
        * svg/SVGFilterPrimitiveStandardAttributes.cpp:
        (WebCore::SVGFilterPrimitiveStandardAttributes::fillAttributeToPropertyTypeMap):
        * svg/SVGFilterPrimitiveStandardAttributes.h:
        * svg/SVGFontElement.cpp:
        (WebCore::SVGFontElement::attributeToPropertyTypeMap):
        (WebCore::SVGFontElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFontElement.h:
        (WebCore::SVGFontElement::rendererIsNeeded):
        * svg/SVGForeignObjectElement.cpp:
        (WebCore::SVGForeignObjectElement::attributeToPropertyTypeMap):
        (WebCore::SVGForeignObjectElement::fillAttributeToPropertyTypeMap):
        * svg/SVGForeignObjectElement.h:
        * svg/SVGGlyphElement.cpp:
        (WebCore::SVGGlyphElement::attributeToPropertyTypeMap):
        (WebCore::SVGGlyphElement::fillAttributeToPropertyTypeMap):
        * svg/SVGGlyphElement.h:
        * svg/SVGGradientElement.cpp:
        (WebCore::SVGGradientElement::fillAttributeToPropertyTypeMap):
        * svg/SVGGradientElement.h:
        * svg/SVGImageElement.cpp:
        (WebCore::SVGImageElement::attributeToPropertyTypeMap):
        (WebCore::SVGImageElement::fillAttributeToPropertyTypeMap):
        * svg/SVGImageElement.h:
        * svg/SVGLineElement.cpp:
        (WebCore::SVGLineElement::attributeToPropertyTypeMap):
        (WebCore::SVGLineElement::fillAttributeToPropertyTypeMap):
        * svg/SVGLineElement.h:
        * svg/SVGLinearGradientElement.cpp:
        (WebCore::SVGLinearGradientElement::attributeToPropertyTypeMap):
        (WebCore::SVGLinearGradientElement::fillAttributeToPropertyTypeMap):
        * svg/SVGLinearGradientElement.h:
        * svg/SVGMPathElement.cpp:
        (WebCore::SVGMPathElement::attributeToPropertyTypeMap):
        (WebCore::SVGMPathElement::fillAttributeToPropertyTypeMap):
        * svg/SVGMPathElement.h:
        * svg/SVGMarkerElement.cpp:
        (WebCore::SVGMarkerElement::attributeToPropertyTypeMap):
        (WebCore::SVGMarkerElement::fillAttributeToPropertyTypeMap):
        * svg/SVGMarkerElement.h:
        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::attributeToPropertyTypeMap):
        (WebCore::SVGMaskElement::fillAttributeToPropertyTypeMap):
        * svg/SVGMaskElement.h:
        * svg/SVGMissingGlyphElement.cpp:
        (WebCore::SVGMissingGlyphElement::attributeToPropertyTypeMap):
        (WebCore::SVGMissingGlyphElement::fillAttributeToPropertyTypeMap):
        * svg/SVGMissingGlyphElement.h:
        * svg/SVGPathElement.cpp:
        (WebCore::SVGPathElement::attributeToPropertyTypeMap):
        (WebCore::SVGPathElement::fillAttributeToPropertyTypeMap):
        * svg/SVGPathElement.h:
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::attributeToPropertyTypeMap):
        (WebCore::SVGPatternElement::fillAttributeToPropertyTypeMap):
        * svg/SVGPatternElement.h:
        * svg/SVGPolyElement.cpp:
        (WebCore::SVGPolyElement::attributeToPropertyTypeMap):
        (WebCore::SVGPolyElement::fillAttributeToPropertyTypeMap):
        * svg/SVGPolyElement.h:
        * svg/SVGRadialGradientElement.cpp:
        (WebCore::SVGRadialGradientElement::attributeToPropertyTypeMap):
        (WebCore::SVGRadialGradientElement::fillAttributeToPropertyTypeMap):
        * svg/SVGRadialGradientElement.h:
        * svg/SVGRectElement.cpp:
        (WebCore::SVGRectElement::attributeToPropertyTypeMap):
        (WebCore::SVGRectElement::fillAttributeToPropertyTypeMap):
        * svg/SVGRectElement.h:
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::attributeToPropertyTypeMap):
        (WebCore::SVGSVGElement::fillAttributeToPropertyTypeMap):
        * svg/SVGSVGElement.h:
        * svg/SVGScriptElement.cpp:
        (WebCore::SVGScriptElement::attributeToPropertyTypeMap):
        (WebCore::SVGScriptElement::fillAttributeToPropertyTypeMap):
        * svg/SVGScriptElement.h:
        * svg/SVGStopElement.cpp:
        (WebCore::SVGStopElement::attributeToPropertyTypeMap):
        (WebCore::SVGStopElement::fillAttributeToPropertyTypeMap):
        * svg/SVGStopElement.h:
        * svg/SVGStyledElement.cpp:
        (WebCore::cssPropertyToTypeMap):
        (WebCore::SVGStyledElement::animatedPropertyTypeForCSSProperty):
        (WebCore::SVGStyledElement::fillAttributeToPropertyTypeMap):
        * svg/SVGStyledElement.h:
        * svg/SVGStyledTransformableElement.cpp:
        (WebCore::SVGStyledTransformableElement::fillAttributeToPropertyTypeMap):
        * svg/SVGStyledTransformableElement.h:
        * svg/SVGSwitchElement.cpp:
        (WebCore::SVGSwitchElement::attributeToPropertyTypeMap):
        (WebCore::SVGSwitchElement::fillAttributeToPropertyTypeMap):
        * svg/SVGSwitchElement.h:
        * svg/SVGSymbolElement.cpp:
        (WebCore::SVGSymbolElement::attributeToPropertyTypeMap):
        (WebCore::SVGSymbolElement::fillAttributeToPropertyTypeMap):
        * svg/SVGSymbolElement.h:
        * svg/SVGTRefElement.cpp:
        (WebCore::SVGTRefElement::attributeToPropertyTypeMap):
        (WebCore::SVGTRefElement::fillAttributeToPropertyTypeMap):
        * svg/SVGTRefElement.h:
        * svg/SVGTSpanElement.cpp:
        (WebCore::SVGTSpanElement::attributeToPropertyTypeMap):
        (WebCore::SVGTSpanElement::fillAttributeToPropertyTypeMap):
        * svg/SVGTSpanElement.h:
        * svg/SVGTextContentElement.cpp:
        (WebCore::SVGTextContentElement::fillAttributeToPropertyTypeMap):
        * svg/SVGTextContentElement.h:
        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::attributeToPropertyTypeMap):
        (WebCore::SVGTextElement::fillAttributeToPropertyTypeMap):
        * svg/SVGTextElement.h:
        * svg/SVGTextPathElement.cpp:
        (WebCore::SVGTextPathElement::attributeToPropertyTypeMap):
        (WebCore::SVGTextPathElement::fillAttributeToPropertyTypeMap):
        * svg/SVGTextPathElement.h:
        * svg/SVGTextPositioningElement.cpp:
        (WebCore::SVGTextPositioningElement::fillAttributeToPropertyTypeMap):
        * svg/SVGTextPositioningElement.h:
        * svg/SVGTitleElement.cpp:
        (WebCore::SVGTitleElement::attributeToPropertyTypeMap):
        (WebCore::SVGTitleElement::fillAttributeToPropertyTypeMap):
        * svg/SVGTitleElement.h:
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::attributeToPropertyTypeMap):
        (WebCore::SVGUseElement::fillAttributeToPropertyTypeMap):
        * svg/SVGUseElement.h:
        * svg/SVGViewElement.cpp:
        (WebCore::SVGViewElement::attributeToPropertyTypeMap):
        (WebCore::SVGViewElement::fillAttributeToPropertyTypeMap):
        * svg/SVGViewElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Alexis Menard <alexis.menard@nokia.com>
andreas.kling@nokia.com [Thu, 10 Feb 2011 19:05:42 +0000 (19:05 +0000)]
2011-02-10  Alexis Menard  <alexis.menard@nokia.com>

        Reviewed by Andreas Kling.

        Fix a Warning after removing FileSystem support for the inspector.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 10 Feb 2011 18:55:32 +0000 (18:55 +0000)]
2011-02-10  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add 'deprecated' to the deprecated CoreIPC functions
        https://bugs.webkit.org/show_bug.cgi?id=54223

        * Platform/CoreIPC/Connection.cpp:
        (CoreIPC::Connection::sendMessage):
        * Platform/CoreIPC/Connection.h:
        (CoreIPC::Connection::send):
        (CoreIPC::Connection::deprecatedSendSync):
        (CoreIPC::Connection::deprecatedSend):
        (CoreIPC::Connection::deprecatedWaitFor):
        * Platform/CoreIPC/mac/ConnectionMac.cpp:
        (CoreIPC::Connection::open):
        * PluginProcess/PluginProcess.cpp:
        * UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
        (WebKit::ChunkedUpdateDrawingAreaProxy::paint):
        * UIProcess/Plugins/PluginProcessProxy.cpp:
        (WebKit::PluginProcessProxy::createWebProcessConnection):
        * WebProcess/InjectedBundle/InjectedBundle.cpp:
        (WebKit::InjectedBundle::postMessage):
        (WebKit::InjectedBundle::postSynchronousMessage):
        * WebProcess/Plugins/PluginProcessConnectionManager.cpp:
        (WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
        * WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
        (WebKit::ChunkedUpdateDrawingArea::display):
        (WebKit::ChunkedUpdateDrawingArea::setSize):
        * WebProcess/WebPage/LayerBackedDrawingArea.cpp:
        (WebKit::LayerBackedDrawingArea::setSize):
        * WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:
        (WebKit::LayerBackedDrawingArea::attachCompositingContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 10 Feb 2011 18:50:02 +0000 (18:50 +0000)]
2011-02-10  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Window resizer does not have a border when there are scrollbars in WebKit2 windows
        <rdar://problem/8488476>
        https://bugs.webkit.org/show_bug.cgi?id=54222

        * UIProcess/API/mac/PageClientImpl.h:
        * UIProcess/API/mac/PageClientImpl.mm:
        (WebKit::PageClientImpl::didChangeScrollbarsForMainFrame):
        * UIProcess/API/mac/WKView.mm:
        (-[WKView _updateGrowBoxForWindowFrameChange]):
        (-[WKView _didChangeScrollbarsForMainFrame]):
        * UIProcess/API/mac/WKViewInternal.h:
        * UIProcess/API/qt/qwkpage_p.h:
        (QWKPagePrivate::didChangeScrollbarsForMainFrame):
        * UIProcess/PageClient.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didChangeScrollbarsForMainFrame):
        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::didChangeScrollbarsForMainFrame):
        * UIProcess/win/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Ivan Krstić <ike@apple.com>
ike@apple.com [Thu, 10 Feb 2011 18:44:14 +0000 (18:44 +0000)]
2011-02-10  Ivan Krstić  <ike@apple.com>

        Reviewed by Adam Roben.

        Rename remaining instances of _HOME sandbox parameter.
        <rdar://problem/8983428>

        * WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Thu, 10 Feb 2011 18:42:18 +0000 (18:42 +0000)]
2011-02-10  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Log signals from AtkDocument interface also in AccessibilityController
        https://bugs.webkit.org/show_bug.cgi?id=54198

        Trace AtkDocument's signals emission through AccessibilityController.

        Also, taken the code related to adding and removing global
        listeners for ATK signals out to a separate file, for the sake of
        clarity and to ease future additions.

        * DumpRenderTree/gtk/AccessibilityCallbacks.h: Added.
        * DumpRenderTree/gtk/AccessibilityCallbacks.cpp: Added
        (printAccessibilityEvent): Print information about an event.
        (axObjectEventListener): Global listener for AtkObject's signals.
        (axDocumentEventListener): Global listener for AtkDocument's signals.
        (connectAccessibilityCallbacks): Connect all global listeners.
        (disconnectAccessibilityCallbacks): Disconnect all global listeners.

        * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
        (AccessibilityController::setLogAccessibilityEvents): Call to
        connectAccessibilityCallbacks and disconnectAccessibilityCallbacks.

        * GNUmakefile.am: Added new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 10 Feb 2011 18:40:30 +0000 (18:40 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, rebaseline.

        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
        * platform/mac-leopard/svg/batik/filters/feTile-expected.checksum:
        * platform/mac-leopard/svg/batik/filters/feTile-expected.png:
        * platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.checksum: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.checksum: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.checksum: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.checksum: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.checksum: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.checksum: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.checksum: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.checksum: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
        * platform/mac-leopard/svg/foreignObject/text-tref-02-b-expected.checksum:
        * platform/mac-leopard/svg/foreignObject/text-tref-02-b-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: AX needs to stop using WebCoreViewFactory
cfleizach@apple.com [Thu, 10 Feb 2011 18:25:16 +0000 (18:25 +0000)]
AX: AX needs to stop using WebCoreViewFactory
https://bugs.webkit.org/show_bug.cgi?id=54153

Reviewed by Anders Carlsson.

../WebCore:

WebKit2 no longer uses WebCoreViewFactory, which means that accessibility code needs
to get off of it and use WebCoreSystemInterface, like other clients.

* WebCore.exp.in:
* accessibility/AXObjectCache.h:
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
* accessibility/mac/AccessibilityObjectWrapper.h:
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper unregisterUniqueIdForUIElement]):
(CFAutoreleaseHelper):
(AXObjectIsTextMarker):
(AXObjectIsTextMarkerRange):
(AXTextMarkerRange):
(AXTextMarkerRangeStart):
(AXTextMarkerRangeEnd):
(textMarkerForVisiblePosition):
(-[AccessibilityObjectWrapper textMarkerForVisiblePosition:]):
(visiblePositionForTextMarker):
(-[AccessibilityObjectWrapper visiblePositionForTextMarker:]):
(visiblePositionForStartOfTextMarkerRange):
(visiblePositionForEndOfTextMarkerRange):
(textMarkerRangeFromMarkers):
(AXAttributeStringSetElement):
(-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
(textMarkerRangeFromVisiblePositions):
(-[AccessibilityObjectWrapper textMarkerRangeFromVisiblePositions:endPosition:]):
(-[AccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:]):
(-[AccessibilityObjectWrapper textMarkerRangeForSelection]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
* editing/mac/SelectionControllerMac.mm:
(WebCore::accessibilityConvertScreenRect):
(WebCore::SelectionController::notifyAccessibilityForSelectionChange):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

../WebKit/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

../WebKit2:

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Alexis Menard <alexis.menard@nokia.com>
commit-queue@webkit.org [Thu, 10 Feb 2011 18:15:37 +0000 (18:15 +0000)]
2011-02-10  Alexis Menard  <alexis.menard@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] In trunk with Qt Multimedia the full screen mode doesn't work.
        https://bugs.webkit.org/show_bug.cgi?id=54201

        Add files for the fullscreen video playback handling. It also fix
        a missing header.

        * WebCore.pro:
2011-02-10  Alexis Menard  <alexis.menard@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] In trunk with Qt Multimedia the full screen mode doesn't work.
        https://bugs.webkit.org/show_bug.cgi?id=54201

        Add a default fullscreen handler when there is no plaftform plugin
        installed. This handler creates a fullscreen QVideoWidget and plays
        the video. Space pause/resume the video playback and esc quit the
        fullscreen mode.

        * WebCoreSupport/FullScreenVideoQt.cpp:
        (WebCore::DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler):
        (WebCore::DefaultFullScreenVideoHandler::~DefaultFullScreenVideoHandler):
        (WebCore::DefaultFullScreenVideoHandler::requiresFullScreenForVideoPlayback):
        (WebCore::DefaultFullScreenVideoHandler::enterFullScreen):
        (WebCore::DefaultFullScreenVideoHandler::exitFullScreen):
        (WebCore::FullScreenVideoQt::FullScreenVideoQt):
        * WebCoreSupport/FullScreenVideoQt.h:
        * WebCoreSupport/FullScreenVideoWidget.cpp: Added.
        (WebCore::FullScreenVideoWidget::FullScreenVideoWidget):
        (WebCore::FullScreenVideoWidget::~FullScreenVideoWidget):
        (WebCore::FullScreenVideoWidget::show):
        (WebCore::FullScreenVideoWidget::closeEvent):
        (WebCore::FullScreenVideoWidget::event):
        (WebCore::FullScreenVideoWidget::keyPressEvent):
        (WebCore::FullScreenVideoWidget::hideCursor):
        (WebCore::FullScreenVideoWidget::showCursor):
        * WebCoreSupport/FullScreenVideoWidget.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSandbox violations trying to read crypto preferences.
weinig@apple.com [Thu, 10 Feb 2011 18:11:48 +0000 (18:11 +0000)]
Sandbox violations trying to read crypto preferences.
<rdar://problem/8981151>

Reviewed by Anders Carlsson.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 10 Feb 2011 18:07:26 +0000 (18:07 +0000)]
2011-02-10  Martin Robinson  <mrobinson@igalia.com>

        Clump the tests failing only on the GTK+ 32-bit bot together with the
        other tests that have this kind of failure.

        * platform/gtk/Skipped: Clean up the skipped list slightly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLLVM Compiler build fix.
mitz@apple.com [Thu, 10 Feb 2011 17:49:52 +0000 (17:49 +0000)]
LLVM Compiler build fix.

* runtime/MarkedBlock.cpp:
(JSC::MarkedBlock::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 10 Feb 2011 17:47:38 +0000 (17:47 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, rebaseline.

        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Removed.
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
        * platform/chromium-linux/svg/batik/filters/feTile-expected.checksum:
        * platform/chromium-linux/svg/batik/filters/feTile-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
        * platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.checksum:
        * platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Removed.
        * platform/chromium-win/svg/batik/filters/feTile-expected.checksum:
        * platform/chromium-win/svg/batik/filters/feTile-expected.png:
        * platform/chromium-win/svg/batik/filters/feTile-expected.txt:
        * platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
        * platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.checksum:
        * platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.png:
        * platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-09 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 10 Feb 2011 17:43:48 +0000 (17:43 +0000)]
2011-02-09  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Remove FileSystem support from the inspector.
        https://bugs.webkit.org/show_bug.cgi?id=50695

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/Inspector.idl:
        * inspector/InspectorApplicationCacheAgent.cpp:
        (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
        (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
        * inspector/InspectorApplicationCacheAgent.h:
        * inspector/InspectorFileSystemAgent.cpp: Removed.
        * inspector/InspectorFileSystemAgent.h: Removed.
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
        (WebCore::InspectorInstrumentation::willSendRequestImpl):
        (WebCore::InspectorInstrumentation::markResourceAsCachedImpl):
        (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
        (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
        (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
        (WebCore::InspectorInstrumentation::didFinishLoadingImpl):
        (WebCore::InspectorInstrumentation::didFailLoadingImpl):
        (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
        (WebCore::InspectorInstrumentation::scriptImportedImpl):
        (WebCore::InspectorInstrumentation::networkStateChangedImpl):
        (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
        (WebCore::InspectorInstrumentation::retrieveResourceAgent):
        * inspector/front-end/FileSystemView.js: Removed.
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Sheriff Bot <webkit.review.bot@gmail.com>
philn@webkit.org [Thu, 10 Feb 2011 17:13:32 +0000 (17:13 +0000)]
2011-02-10  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r78219.
        http://trac.webkit.org/changeset/78219
        https://bugs.webkit.org/show_bug.cgi?id=54215

        breaks editing/style/iframe-onload-crash.html on GTK 64-bit
        Debug (Requested by philn-tp on #webkit).

        * dom/Document.h:
        * dom/DocumentFragment.h:
        * dom/Element.h:
        * dom/Node.h:
        * dom/Text.h:
        * editing/htmlediting.cpp:
        (WebCore::editingIgnoresContent):
        (WebCore::canHaveChildrenForEditing):
        * editing/htmlediting.h:
        * html/HTMLBRElement.h:
        * html/HTMLButtonElement.h:
        * html/HTMLDataGridElement.h:
        * html/HTMLFormControlElement.h:
        * html/HTMLFrameElementBase.h:
        * html/HTMLHRElement.h:
        * html/HTMLImageElement.h:
        * html/HTMLMeterElement.h:
        * html/HTMLOutputElement.h:
        * html/HTMLPlugInElement.h:
        * html/HTMLProgressElement.h:
        * wml/WMLBRElement.h:
        * wml/WMLDoElement.h:
        * wml/WMLImageElement.h:
        * wml/WMLInputElement.h:
        * wml/WMLSelectElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-09 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 10 Feb 2011 16:46:23 +0000 (16:46 +0000)]
2011-02-09  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Default error page is interfering with tests which require failed loads
        https://bugs.webkit.org/show_bug.cgi?id=54157

        Unskip passing tests and remove some bogus expected results.

        * platform/gtk/Skipped: Unskip some tests which are now passing.
        * platform/gtk/fast/dom/null-document-location-put-crash-expected.txt: Removed.
2011-02-09  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Default error page is interfering with tests which require failed loads
        https://bugs.webkit.org/show_bug.cgi?id=54157

        Disable the default error page during DRT runs. This prevents unexpected loads
        from interfering with tests that have planned failed loads.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webViewLoadError): Added, disable default handler.
        (createWebView): Connect the new load-error handler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed translation file.
christian@webkit.org [Thu, 10 Feb 2011 16:21:16 +0000 (16:21 +0000)]
Unreviewed translation file.

French translation for Webkit/GTK
https://bugs.webkit.org/show_bug.cgi?id=26108

* fr.po: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Thu, 10 Feb 2011 16:16:06 +0000 (16:16 +0000)]
2011-02-10  Andras Becsi  <abecsi@webkit.org>

        Rubber-stamped by Csaba Osztrogonác.

        [Qt][V8] Fix the build.

        No new tests needed.

        * bindings/v8/WorkerContextExecutionProxy.cpp: add missing CString header.
        * loader/cache/CachedScript.h: do not use extra qualification for base class enum.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Thu, 10 Feb 2011 16:03:18 +0000 (16:03 +0000)]
2011-02-10  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [STYLES] Suggest CSS property values once Up/Down is pressed with an empty input
        https://bugs.webkit.org/show_bug.cgi?id=54205

        * inspector/front-end/CSSCompletions.js:
        (WebInspector.CSSCompletions):
        (WebInspector.CSSCompletions.prototype._firstIndexOfPrefix):
        * inspector/front-end/CSSKeywordCompletions.js:
        (WebInspector.CSSKeywordCompletions.forProperty):
        * inspector/front-end/StylesSidebarPane.js:
        ():
        * inspector/front-end/TextPrompt.js:
        (WebInspector.TextPrompt.prototype.complete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 10 Feb 2011 16:01:20 +0000 (16:01 +0000)]
2011-02-10  Philippe Normand  <pnormand@igalia.com>

        Unreviewed skip failing fast/text/international/hindi-whitespace.html test on GTK
        https://bugs.webkit.org/show_bug.cgi?id=54212

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 10 Feb 2011 15:50:10 +0000 (15:50 +0000)]
2011-02-10  Philippe Normand  <pnormand@igalia.com>

        Unreviewed skip failing fast/text/atsui* tests on GTK
        https://bugs.webkit.org/show_bug.cgi?id=54210

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Renata Hodovan <reni@webkit.org>
reni@webkit.org [Thu, 10 Feb 2011 15:47:16 +0000 (15:47 +0000)]
2011-02-10  Renata Hodovan  <reni@webkit.org>

        Reviewed by Dirk Schulze.

        SVGFESpecularLightingElement doesn't support dynamic invalidation, when attributes change.
        https://bugs.webkit.org/show_bug.cgi?id=54186

        Adding layout tests for feSpecularLighting dynamic changes.

        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
        * svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr.html: Added.
        * svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr.html: Added.
        * svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr.html: Added.
        * svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr.html: Added.
        * svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop.html: Added.
        * svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop.html: Added.
        * svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop.html: Added.
        * svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop.html: Added.
        * svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-dom-in-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-dom-specularConstant-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-dom-specularExponent-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-dom-surfaceScale-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-svgdom-in-prop.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-svgdom-specularConstant-prop.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-svgdom-specularExponent-prop.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-svgdom-surfaceScale-prop.js: Added.
        (executeTest):
2011-02-10  Renata Hodovan  <reni@webkit.org>

        Reviewed by Dirk Schulze.

        SVGFESpecularLightingElement doesn't support dynamic invalidation, when attributes change.
        https://bugs.webkit.org/show_bug.cgi?id=54186

        The dynamic changes are captured by the svgAttributeChange function, and invalidate the filter primitive if necessary.

        Tests: svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr.html
               svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr.html
               svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr.html
               svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr.html
               svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop.html
               svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop.html
               svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop.html
               svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop.html

        * svg/SVGFESpecularLightingElement.cpp:
        (WebCore::SVGFESpecularLightingElement::svgAttributeChanged):
        * svg/SVGFESpecularLightingElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 10 Feb 2011 14:59:30 +0000 (14:59 +0000)]
2011-02-10  Philippe Normand  <pnormand@igalia.com>

        Unreviewed skipping websocket tests on GTK
        https://bugs.webkit.org/show_bug.cgi?id=53683

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Andrey Adaikin <aandrey@google.com>
podivilov@chromium.org [Thu, 10 Feb 2011 14:54:51 +0000 (14:54 +0000)]
2011-02-10  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Error messages are not displayed for the last line in a script
        https://bugs.webkit.org/show_bug.cgi?id=54204

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.addMessage):
        (WebInspector.SourceFrame.prototype._addMessageToSource):
        (WebInspector.SourceFrame.prototype._createConditionElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 10 Feb 2011 14:47:26 +0000 (14:47 +0000)]
2011-02-10  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Make canHaveChildrenForEditing more efficient
        https://bugs.webkit.org/show_bug.cgi?id=53564

        Improved the performance (1-2% in release and 20% in debug) by adding virtual member function
        canContainRangeEndPoint to Node. It returns true whenever the associated node can have be a container
        node for a position.

        As of this revision, canContainRangeEndPoint returns true on Document, DocumentFragment, Text nodes
        and any elements except:

        HTML: applet, br, button, datagrid, embed, frame, frameset, hr, img, input,
              meter, object, output, progress, and select.

        WML: br, do, img, input, and select.

        No new tests are added since this change cannot be tested directly.

        * dom/Document.h:
        (WebCore::Document::canContainRangeEndPoint): Added; returns false.
        * dom/DocumentFragment.h:
        (WebCore::DocumentFragment::canContainRangeEndPoint): Added; returns true.
        * dom/Element.h:
        (WebCore::Element::canContainRangeEndPoint): Ditto.
        * dom/Node.h:
        (WebCore::Node::canContainRangeEndPoint): Added; returns false.
        * dom/Text.h:
        (WebCore::Text::canContainRangeEndPoint): Added; returns true.
        * editing/htmlediting.cpp: Removed editingIgnoresContent and canHaveChildrenForEditing.
        * editing/htmlediting.h:
        (WebCore::editingIgnoresContent): Moved from htmlediting.cpp; made it inline.
        (WebCore::canHaveChildrenForEditing): Ditto.
        * html/HTMLBRElement.h:
        (WebCore::HTMLBRElement::canContainRangeEndPoint): Added; returns false.
        * html/HTMLButtonElement.h:
        (WebCore::HTMLButtonElement::canContainRangeEndPoint): Ditto.
        * html/HTMLDataGridElement.h:
        (WebCore::HTMLDataGridElement::canContainRangeEndPoint): Ditto.
        * html/HTMLFormControlElement.h:
        (WebCore::HTMLFormControlElementWithState::canContainRangeEndPoint): Ditto.
        * html/HTMLFrameElementBase.h:
        (WebCore::HTMLFrameElementBase::canContainRangeEndPoint): Ditto.
        * html/HTMLHRElement.h:
        (WebCore::HTMLHRElement::canContainRangeEndPoint): Ditto.
        * html/HTMLImageElement.h:
        (WebCore::HTMLImageElement::canContainRangeEndPoint): Ditto.
        * html/HTMLMeterElement.h:
        (WebCore::HTMLMeterElement::canContainRangeEndPoint): Ditto.
        * html/HTMLOutputElement.h:
        (WebCore::HTMLOutputElement::canContainRangeEndPoint): Ditto.
        * html/HTMLPlugInElement.h:
        (WebCore::HTMLPlugInElement::canContainRangeEndPoint): Ditto.
        * html/HTMLProgressElement.h:
        (WebCore::HTMLProgressElement::canContainRangeEndPoint): Ditto.
        * wml/WMLBRElement.h:
        (WebCore::WMLBRElement::canContainRangeEndPoint): Ditto.
        * wml/WMLDoElement.h:
        (WebCore::WMLDoElement::canContainRangeEndPoint): Ditto.
        * wml/WMLImageElement.h:
        (WebCore::WMLImageElement::canContainRangeEndPoint): Ditto.
        * wml/WMLInputElement.h:
        (WebCore::WMLInputElement::canContainRangeEndPoint): Ditto.
        * wml/WMLSelectElement.h:
        (WebCore::WMLSelectElement::canContainRangeEndPoint): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 10 Feb 2011 14:32:48 +0000 (14:32 +0000)]
2011-02-10  Philippe Normand  <pnormand@igalia.com>

        Update GTK results after r78204

        * platform/gtk/fast/text/international/text-combine-image-test-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Add UrlLoader and command line argument handling to MiniBrowser
zoltan@webkit.org [Thu, 10 Feb 2011 14:20:03 +0000 (14:20 +0000)]
[Qt] Add UrlLoader and command line argument handling to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=54192

Reviewed by Andreas Kling.

Copy and modify files from QtTestBrowser's implementation.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::newWindow):
* MiniBrowser/qt/BrowserWindow.h:
* MiniBrowser/qt/MiniBrowser.pro:
* MiniBrowser/qt/MiniBrowserApplication.cpp: Copied from QtTestBrowser/launcherwindow.cpp
(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::handleUserOptions):
* MiniBrowser/qt/MiniBrowserApplication.h: Copied from QtTestBrowser/launcherwindow.h
(WindowOptions::WindowOptions):
(MiniBrowserApplication::urls):
(MiniBrowserApplication::isRobotized):
(MiniBrowserApplication::robotTimeout):
(MiniBrowserApplication::robotExtraTime):
* MiniBrowser/qt/UrlLoader.cpp: Copied from QtTestBrowser/urlloader.cpp
(UrlLoader::UrlLoader):
(UrlLoader::loadNext):
(UrlLoader::checkIfFinished):
(UrlLoader::frameLoadStarted):
(UrlLoader::frameLoadFinished):
(UrlLoader::loadUrlList):
(UrlLoader::getUrl):
* MiniBrowser/qt/UrlLoader.h: Copied from QtTestBrowser/urlloader.h
* MiniBrowser/qt/main.cpp:
(main):
* MiniBrowser/qt/utils.cpp: Copied from QtTestBrowser/utils.cpp
(takeOptionValue):
(formatKeys):
(enumToKeys):
(appQuit):
(urlFromUserInput):
* MiniBrowser/qt/utils.h: Copied from QtTestBrowser/utils.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 10 Feb 2011 14:18:18 +0000 (14:18 +0000)]
2011-02-10  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: chromium build fix.

        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgent::shouldInterruptForMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agocheck-webkit-style: Add -build/include exemption for Tools/MiniBrowser/qt
zoltan@webkit.org [Thu, 10 Feb 2011 14:14:45 +0000 (14:14 +0000)]
check-webkit-style: Add -build/include exemption for Tools/MiniBrowser/qt
https://bugs.webkit.org/show_bug.cgi?id=54200

Reviewed by Andreas Kling.

* Scripts/webkitpy/style/checker.py:
* Scripts/webkitpy/style/checker_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate Windows results after r78204
aroben@apple.com [Thu, 10 Feb 2011 14:05:24 +0000 (14:05 +0000)]
Update Windows results after r78204

* platform/win/fast/text/international/text-combine-image-test-expected.checksum:
* platform/win/fast/text/international/text-combine-image-test-expected.png:
* platform/win/fast/text/international/text-combine-image-test-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate Windows results after r78182
aroben@apple.com [Thu, 10 Feb 2011 14:04:38 +0000 (14:04 +0000)]
Update Windows results after r78182

Nikolas Zimmermann says he thinks we're not matching the Mac results anymore due to rounding
differences.

* platform/win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
* platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 10 Feb 2011 14:03:14 +0000 (14:03 +0000)]
2011-02-10  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: define interface per domain in Inspector.idl.
        https://bugs.webkit.org/show_bug.cgi?id=54135

        * inspector/CodeGeneratorInspector.pm:
        * inspector/Inspector.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Peter Varga <pvarga@webkit.org>
pvarga@webkit.org [Thu, 10 Feb 2011 13:39:13 +0000 (13:39 +0000)]
2011-02-10  Peter Varga  <pvarga@webkit.org>

        Reviewed by Csaba Osztrogonác.

        Remove PCRE source from trunk
        https://bugs.webkit.org/show_bug.cgi?id=54188

        * Source/cmake/WebKitFS.cmake:
2011-02-10  Peter Varga  <pvarga@webkit.org>

        Reviewed by Csaba Osztrogonác.

        Remove PCRE source from trunk
        https://bugs.webkit.org/show_bug.cgi?id=54188

        * Android.mk:
        * Android.v8.wtf.mk:
        * CMakeLists.txt:
        * DerivedSources.make:
        * DerivedSources.pro:
        * GNUmakefile.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.order:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
        * JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
        * JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * pcre/AUTHORS: Removed.
        * pcre/COPYING: Removed.
        * pcre/dftables: Removed.
        * pcre/pcre.h: Removed.
        * pcre/pcre.pri: Removed.
        * pcre/pcre_compile.cpp: Removed.
        * pcre/pcre_exec.cpp: Removed.
        * pcre/pcre_internal.h: Removed.
        * pcre/pcre_tables.cpp: Removed.
        * pcre/pcre_ucp_searchfuncs.cpp: Removed.
        * pcre/pcre_xclass.cpp: Removed.
        * pcre/ucpinternal.h: Removed.
        * pcre/ucptable.cpp: Removed.
        * wscript:
2011-02-10  Peter Varga  <pvarga@webkit.org>

        Reviewed by Csaba Osztrogonác.

        Remove PCRE source from trunk
        https://bugs.webkit.org/show_bug.cgi?id=54188

        * ForwardingHeaders/pcre/pcre.h: Removed.
2011-02-10  Peter Varga  <pvarga@webkit.org>

        Reviewed by Csaba Osztrogonác.

        Remove PCRE source from trunk
        https://bugs.webkit.org/show_bug.cgi?id=54188

        * WebKit2.pro:
2011-02-10  Peter Varga  <pvarga@webkit.org>

        Reviewed by Csaba Osztrogonác.

        Remove PCRE source from trunk
        https://bugs.webkit.org/show_bug.cgi?id=54188

        * wx/build/settings.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Andrey Adaikin <aandrey@google.com>
podivilov@chromium.org [Thu, 10 Feb 2011 13:37:26 +0000 (13:37 +0000)]
2011-02-10  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: [regression] Fix syncing heights of the gutter and main panel lines, and add 2px padding-left
        https://bugs.webkit.org/show_bug.cgi?id=54098

        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer):
        (WebInspector.TextViewer.prototype._updatePanelOffsets):
        (WebInspector.TextViewer.prototype._syncScroll):
        (WebInspector.TextViewer.prototype._syncDecorationsForLine):
        (WebInspector.TextEditorChunkedPanel.prototype._totalHeight):
        (WebInspector.TextEditorChunkedPanel.prototype.resize):
        (WebInspector.TextEditorGutterPanel):
        (WebInspector.TextEditorGutterChunk.prototype.set expanded):
        (WebInspector.TextEditorGutterChunk.prototype.get height):
        (WebInspector.TextEditorMainChunk.prototype.get height):
        * inspector/front-end/textViewer.css:
        (.webkit-line-content):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 10 Feb 2011 13:24:46 +0000 (13:24 +0000)]
2011-02-10  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip failing fast/text/midword-break-after-breakable-char.html on
        GTK

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 10 Feb 2011 13:15:24 +0000 (13:15 +0000)]
2011-02-10  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Barth.

        Add randomValuesFromOS for OS(WINDOWS)
        https://bugs.webkit.org/show_bug.cgi?id=54155

        Use CryptGenRandom for generating cryptographically secure random numbers.
        This will work on WinCE and MinGW too.

        * config.h:
        * wtf/OSRandomSource.cpp:
        (WTF::randomValuesFromOS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Jochen Eisinger <jochen@chromium.org>
jochen@chromium.org [Thu, 10 Feb 2011 13:06:05 +0000 (13:06 +0000)]
2011-02-10  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Jeremy Orlow.

        [chromium] add WebIDBObjectStore::clear method

        https://bugs.webkit.org/show_bug.cgi?id=54149

        * public/WebIDBObjectStore.h:
        (WebKit::WebIDBObjectStore::put):
        (WebKit::WebIDBObjectStore::deleteFunction):
        (WebKit::WebIDBObjectStore::clear):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 10 Feb 2011 12:59:43 +0000 (12:59 +0000)]
2011-02-10  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip failing fast/text/capitalize-boundaries.html on
        GTK

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 David Levin <levin@chromium.org>
levin@chromium.org [Thu, 10 Feb 2011 12:52:48 +0000 (12:52 +0000)]
2011-02-10  David Levin  <levin@chromium.org>

        Reviewed by Shinichiro Hamaji.

        check-webkit-style should be able to figure out function modifiers and return type.
        https://bugs.webkit.org/show_bug.cgi?id=54124

        * Scripts/webkitpy/style/checkers/cpp.py:
        (_rfind_in_lines): A way to search backwards in lines.
        (_FunctionState.modifiers_and_return_type):
        * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for the new functionality.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 takano takumi <takano@apple.com>
commit-queue@webkit.org [Thu, 10 Feb 2011 12:48:20 +0000 (12:48 +0000)]
2011-02-10  takano takumi  <takano@apple.com>

        Reviewed by Dan Bernstein.

        A full-width character rotated leftward 90 degrees in text-combine
        https://bugs.webkit.org/show_bug.cgi?id=54169

        Added a test for this bug to existing text-combine test.

        * fast/text/international/text-combine-image-test.html:
        * platform/mac/fast/text/international/text-combine-image-test-expected.checksum:
        * platform/mac/fast/text/international/text-combine-image-test-expected.png:
        * platform/mac/fast/text/international/text-combine-image-test-expected.txt:
2011-02-10  takano takumi  <takano@apple.com>

        Reviewed by Dan Bernstein.

        A full-width character rotated leftward 90 degrees in text-combine
        https://bugs.webkit.org/show_bug.cgi?id=54169

        * rendering/RenderCombineText.cpp:
        (WebCore::RenderCombineText::combineText):
        - Fixed by resetting font's orientation to horizontal when we decided to make combined text.
        Otherwise the text will be unexpectedly rotated in showGlyphsWithAdvances() in FontMac.mm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-10 Jarred Nicholls <jarred@sencha.com>
commit-queue@webkit.org [Thu, 10 Feb 2011 12:46:26 +0000 (12:46 +0000)]
2011-02-10  Jarred Nicholls  <jarred@sencha.com>

        Reviewed by Adam Barth.

        REGRESSION(r78149): Return value of read() shouldn't be ignored.
        https://bugs.webkit.org/show_bug.cgi?id=54167

        stdio read should have its return value handled. Build error in gcc 4.4.5.

        * wtf/OSRandomSource.cpp:
        (WTF::randomValuesFromOS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78203 268f45cc-cd09-0410-ab3c-d52691b4dbfc