WebKit-https.git
10 years ago2011-03-29 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Tue, 29 Mar 2011 13:33:00 +0000 (13:33 +0000)]
2011-03-29  Alexis Menard  <alexis.menard@openbossa.org>

        Unreviewed build fix for build-webkit -minimal.

        Breakage introduced by http://trac.webkit.org/changeset/82238.
        The minimal option has no support for shortcuts.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleInputMethodKeydown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Leo Yang <leo.yang@torchmobile.com.cn>
commit-queue@webkit.org [Tue, 29 Mar 2011 13:28:09 +0000 (13:28 +0000)]
2011-03-29  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Nikolas Zimmermann.

        Incorrect offset of svg <use> element which is in <symbol> element
        https://bugs.webkit.org/show_bug.cgi?id=57318

        Test case to verify offset of svg <use> element in <symbol> element
        is set correctly.

        * platform/qt/svg/custom/use-in-symbol-with-offset-expected.checksum: Added.
        * platform/qt/svg/custom/use-in-symbol-with-offset-expected.png: Added.
        * svg/custom/use-in-symbol-with-offset-expected.txt: Added.
        * svg/custom/use-in-symbol-with-offset.svg: Added.
2011-03-29  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Nikolas Zimmermann.

        Incorrect offset of svg <use> element which is in <symbol> element
        https://bugs.webkit.org/show_bug.cgi?id=57318

        When webkit expanded a svg <symbol> element in the shadow tree it
        would clone the children of the <symbol>. The children may contain
        SVGShadowTreeContainerElement which was expanded from svg <use>
        element. But the clone operation would clone a
        SVGShadowTreeContainerElement as a svg <g> element. This resulted
        that updateContainerOffset wouldn't update offset for those elements
        which were expand from <use> elements.

        This patch implements cloneElementWithoutAttributesAndChildren for
        SVGShadowTreeContainerElement to make the container clone itself
        correctly.

        Test: svg/custom/use-in-symbol-with-offset.svg

        * rendering/svg/SVGShadowTreeElements.cpp:
        (WebCore::SVGShadowTreeContainerElement::cloneElementWithoutAttributesAndChildren):
        * rendering/svg/SVGShadowTreeElements.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 29 Mar 2011 13:18:11 +0000 (13:18 +0000)]
2011-03-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Rename InlineIterator::obj to m_obj to match modern style
        https://bugs.webkit.org/show_bug.cgi?id=57319

        I started this rename after confusion in InlineBidiResolver::appendRun.
        (Which uses an "obj" local in InlineIterator.h.  It's not actually
        masking m_obj because it's a separate class, but I didn't realize
        that at the time because it's in InlineIterator.h which is itself confusing!)

        * rendering/InlineIterator.h:
        (WebCore::InlineIterator::InlineIterator):
        (WebCore::operator==):
        (WebCore::operator!=):
        (WebCore::InlineIterator::increment):
        (WebCore::InlineIterator::atEnd):
        (WebCore::InlineIterator::current):
        (WebCore::InlineIterator::direction):
        (WebCore::InlineBidiResolver::appendRun):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::checkMidpoints):
        (WebCore::RenderBlock::appendRunsForObject):
        (WebCore::RenderBlock::layoutInlineChildren):
        (WebCore::RenderBlock::matchedEndLine):
        (WebCore::skipNonBreakingSpace):
        (WebCore::RenderBlock::requiresLineBox):
        (WebCore::RenderBlock::skipTrailingWhitespace):
        (WebCore::RenderBlock::skipLeadingWhitespace):
        (WebCore::tryHyphenating):
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Remove modular references after support for the flag was removed.
ossy@webkit.org [Tue, 29 Mar 2011 13:18:05 +0000 (13:18 +0000)]
[Qt] Remove modular references after support for the flag was removed.
https://bugs.webkit.org/show_bug.cgi?id=57018

Rubber-stamped by Andreas Kling.

Symbian buildfix after r82232.

* Source/WebKit.pri: Readd uitools option.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 29 Mar 2011 13:05:07 +0000 (13:05 +0000)]
2011-03-29  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: document Timeline domain, make timeline event types of type string.
        https://bugs.webkit.org/show_bug.cgi?id=57299

        * inspector/timeline/timeline-enum-stability-expected.txt:
        * inspector/timeline/timeline-event-dispatch-expected.txt:
        * inspector/timeline/timeline-layout-expected.txt:
        * inspector/timeline/timeline-mark-timeline-expected.txt:
        * inspector/timeline/timeline-network-resource-expected.txt:
        * inspector/timeline/timeline-paint-expected.txt:
        * inspector/timeline/timeline-parse-html-expected.txt:
        * inspector/timeline/timeline-recalculate-styles-expected.txt:
        * inspector/timeline/timeline-script-tag-1-expected.txt:
        * inspector/timeline/timeline-script-tag-2-expected.txt:
        * inspector/timeline/timeline-test.js:
        (initialize_Timeline.InspectorTest.startTimeline):
        * platform/chromium/inspector/timeline/timeline-event-dispatch-expected.txt:
        * platform/chromium/inspector/timeline/timeline-mark-timeline-expected.txt:
        * platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:
        * platform/chromium/inspector/timeline/timeline-paint-expected.txt:
        * platform/chromium/inspector/timeline/timeline-parse-html-expected.txt:
2011-03-29  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: document Timeline domain, make timeline event types of type string.
        https://bugs.webkit.org/show_bug.cgi?id=57299

        * inspector/Inspector.json:
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::pushGCEventRecords):
        (WebCore::InspectorTimelineAgent::start):
        (WebCore::InspectorTimelineAgent::stop):
        (WebCore::InspectorTimelineAgent::willCallFunction):
        (WebCore::InspectorTimelineAgent::didCallFunction):
        (WebCore::InspectorTimelineAgent::willDispatchEvent):
        (WebCore::InspectorTimelineAgent::didDispatchEvent):
        (WebCore::InspectorTimelineAgent::willLayout):
        (WebCore::InspectorTimelineAgent::didLayout):
        (WebCore::InspectorTimelineAgent::willRecalculateStyle):
        (WebCore::InspectorTimelineAgent::didRecalculateStyle):
        (WebCore::InspectorTimelineAgent::willPaint):
        (WebCore::InspectorTimelineAgent::didPaint):
        (WebCore::InspectorTimelineAgent::willWriteHTML):
        (WebCore::InspectorTimelineAgent::didWriteHTML):
        (WebCore::InspectorTimelineAgent::didInstallTimer):
        (WebCore::InspectorTimelineAgent::didRemoveTimer):
        (WebCore::InspectorTimelineAgent::willFireTimer):
        (WebCore::InspectorTimelineAgent::didFireTimer):
        (WebCore::InspectorTimelineAgent::willChangeXHRReadyState):
        (WebCore::InspectorTimelineAgent::didChangeXHRReadyState):
        (WebCore::InspectorTimelineAgent::willLoadXHR):
        (WebCore::InspectorTimelineAgent::didLoadXHR):
        (WebCore::InspectorTimelineAgent::willEvaluateScript):
        (WebCore::InspectorTimelineAgent::didEvaluateScript):
        (WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
        (WebCore::InspectorTimelineAgent::willSendResourceRequest):
        (WebCore::InspectorTimelineAgent::willReceiveResourceData):
        (WebCore::InspectorTimelineAgent::didReceiveResourceData):
        (WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
        (WebCore::InspectorTimelineAgent::didReceiveResourceResponse):
        (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
        (WebCore::InspectorTimelineAgent::didMarkTimeline):
        (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
        (WebCore::InspectorTimelineAgent::didMarkLoadEvent):
        (WebCore::InspectorTimelineAgent::addRecordToTimeline):
        (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
        (WebCore::InspectorTimelineAgent::pushCurrentRecord):
        * inspector/InspectorTimelineAgent.h:
        (WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
        * inspector/front-end/TimelineAgent.js:
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype.get _recordStyles):
        (WebInspector.TimelinePanel.prototype._createEventDivider):
        (WebInspector.TimelinePanel.prototype._findParentRecord):
        (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
        (WebInspector.TimelineDispatcher.prototype.started):
        (WebInspector.TimelineDispatcher.prototype.stopped):
        (WebInspector.TimelineDispatcher.prototype.eventRecorded):
        (WebInspector.TimelinePanel.FormattedRecord):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Janne Koskinen <janne.p.koskinen@digia.com>
alexis.menard@openbossa.org [Tue, 29 Mar 2011 13:04:25 +0000 (13:04 +0000)]
2011-03-29  Janne Koskinen  <janne.p.koskinen@digia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
        https://bugs.webkit.org/show_bug.cgi?id=33179

        Fixed newline generation from Qt::Key_Enter when editting text area using InputMethods.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleInputMethodKeydown):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::inputMethods):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Andrey Adaikin <aandrey@google.com>
podivilov@chromium.org [Tue, 29 Mar 2011 12:58:15 +0000 (12:58 +0000)]
2011-03-29  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Fixing live edits tests on chromium.
        https://bugs.webkit.org/show_bug.cgi?id=57316

        * inspector/debugger/live-edit.html:
2011-03-29  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Fixing live edits tests on chromium.
        https://bugs.webkit.org/show_bug.cgi?id=57316

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.editScriptSource):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._handleSave.didEditScriptSource):
        (WebInspector.SourceFrame.prototype._handleSave):
        (WebInspector.SourceFrameDelegate.prototype.editScriptSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 29 Mar 2011 12:55:02 +0000 (12:55 +0000)]
2011-03-29  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip crashing svg test on GTK.

        * platform/gtk/Skipped: Skip svg/text/text-deco-01-b.svg

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 29 Mar 2011 12:29:56 +0000 (12:29 +0000)]
2011-03-29  Andreas Kling  <kling@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Fix documentation for QWebPage::repaintRequested()

        This signal is always emitted when the page is dirtied, so remove
        reference to old behavior where we would only emit the signal for
        headless QWebPages.

        * Api/qwebpage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 29 Mar 2011 12:28:34 +0000 (12:28 +0000)]
2011-03-29  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: fix call frames positions in formatted scripts.
        https://bugs.webkit.org/show_bug.cgi?id=57036

        * inspector/debugger/debugger-eval-while-paused.html:
2011-03-29  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: fix call frames positions in formatted scripts.
        https://bugs.webkit.org/show_bug.cgi?id=57036

        Introduce PresentationCallFrame class that encapsulates source mapping details from UI components.

        * inspector/front-end/CallStackSidebarPane.js:
        (WebInspector.CallStackSidebarPane.prototype.update.didGetSourceLocation):
        (WebInspector.CallStackSidebarPane.prototype.update):
        (WebInspector.CallStackSidebarPane.prototype.set selectedCallFrame):
        (WebInspector.CallStackSidebarPane.prototype._placardSelected):
        (WebInspector.CallStackSidebarPane.prototype._contextMenu):
        (WebInspector.CallStackSidebarPane.prototype._copyStackTrace):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype._didEditScriptSource):
        (WebInspector.DebuggerModel.prototype.get debuggerPausedDetails):
        (WebInspector.DebuggerModel.prototype._pausedScript):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel):
        (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
        (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
        (WebInspector.DebuggerPresentationModel.prototype._debuggerResumed):
        (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
        (WebInspector.DebuggerPresentationModel.prototype.get selectedCallFrame):
        (WebInspector.DebuggerPresentationModel.prototype._reset):
        (WebInspector.PresenationCallFrame): Call frame wrapper for UI.
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
        (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
        (WebInspector.ScriptsPanel.prototype._debuggerPaused):
        (WebInspector.ScriptsPanel.prototype._debuggerResumed):
        (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
        (WebInspector.ScriptsPanel.prototype._callFrameSelected.didGetSourceLocation):
        (WebInspector.ScriptsPanel.prototype._callFrameSelected):
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.evaluateInSelectedCallFrame):
        * inspector/front-end/SourceFile.js:
        (WebInspector.SourceFile.prototype.get content):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._createTextViewer):
        (WebInspector.SourceFrame.prototype.setExecutionLine):
        (WebInspector.SourceFrame.prototype.clearExecutionLine):
        (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
        (WebInspector.SourceFrame.prototype._showPopup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Tue, 29 Mar 2011 12:10:05 +0000 (12:10 +0000)]
2011-03-29  Emil A Eklund  <eae@chromium.org>

        Reviewed by Darin Adler.

        Fix for execCommand("Delete") with an empty selection.
        https://bugs.webkit.org/show_bug.cgi?id=56652

        Add test for deleting an empty selection from an empty container.

        * editing/execCommand/delete-empty-container-expected.txt: Added.
        * editing/execCommand/delete-empty-container.html: Added.
2011-03-29  Emil A Eklund  <eae@chromium.org>

        Reviewed by Darin Adler.

        Fix for execCommand("Delete") with an empty selection.
        https://bugs.webkit.org/show_bug.cgi?id=56652

        Test: editing/execCommand/delete-empty-container.html

        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::makeEditableRootEmpty): Add check for root element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Kristian Amlie <kristian.amlie@nokia.com>
commit-queue@webkit.org [Tue, 29 Mar 2011 12:01:25 +0000 (12:01 +0000)]
2011-03-29  Kristian Amlie  <kristian.amlie@nokia.com>

        Reviewed by Andreas Kling.

        Removed modular references after support for the flag was removed.

        Support was removed because the Qt Modularization project decided we
        don't need it. It's better to base decisions on the available
        information, as demonstrated in the patch by checking
        QT.phonon.includes.

        In addition, remove the reference to uitools. It has been moved to
        QtKernel now, and therefore is always available.

        [Qt] Remove modular references after support for the flag was removed.
        https://bugs.webkit.org/show_bug.cgi?id=57018

        * Source/WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Teach build-jsc how to build JavaScriptCore on Qt
ossy@webkit.org [Tue, 29 Mar 2011 12:00:43 +0000 (12:00 +0000)]
[Qt] Teach build-jsc how to build JavaScriptCore on Qt
https://bugs.webkit.org/show_bug.cgi?id=56918

Patch by Gabor Loki <loki@webkit.org> on 2011-03-29
Rubber-stamped by Csaba Osztrogon√°c.

* Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Tue, 29 Mar 2011 11:44:25 +0000 (11:44 +0000)]
2011-03-29  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Refactor HeapSnapshot-related code to
        make sure we don't return big amounts of data to forms.
        https://bugs.webkit.org/show_bug.cgi?id=57227

        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
        (WebInspector.HeapSnapshotGenericObjectNode.prototype.get _countPercent):
        (WebInspector.HeapSnapshotObjectNode):
        (WebInspector.HeapSnapshotObjectNode.prototype._createProvider):
        (WebInspector.HeapSnapshotInstanceNode):
        (WebInspector.HeapSnapshotInstanceNode.prototype._createProvider):
        (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
        (WebInspector.HeapSnapshotConstructorNode.prototype.get _countPercent):
        (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
        (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
        (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
        (WebInspector.HeapSnapshotDominatorsDataGrid.prototype.setDataSource):
        * inspector/front-end/HeapSnapshot.js:
        (WebInspector.HeapSnapshotNode.prototype.get dominatorIndex):
        (WebInspector.HeapSnapshotNode.prototype.get retainers):
        (WebInspector.HeapSnapshot):
        (WebInspector.HeapSnapshot.prototype.get _allNodes):
        (WebInspector.HeapSnapshot.prototype.get nodeCount):
        (WebInspector.HeapSnapshot.prototype.get rootNodeIndex):
        (WebInspector.HeapSnapshot.prototype.hasId):
        (WebInspector.HeapSnapshot.prototype.get nodeIds):
        (WebInspector.HeapSnapshot.prototype._retainersForNode):
        (WebInspector.HeapSnapshot.prototype._buildRetainers):
        (WebInspector.HeapSnapshot.prototype._buildAggregates):
        (WebInspector.HeapSnapshot.prototype._buildAggregatesIndexes):
        (WebInspector.HeapSnapshot.prototype._buildIdsList):
        (WebInspector.HeapSnapshot.prototype._buildNodeIndex):
        (WebInspector.HeapSnapshotFilteredOrderedIterator):
        (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.next):
        (WebInspector.HeapSnapshotEdgesProvider):
        (WebInspector.HeapSnapshotNodesProvider):

2011-03-29  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Refactor HeapSnapshot-related code to
        make sure we don't return big amounts of data to forms.
        https://bugs.webkit.org/show_bug.cgi?id=57227

        * inspector/profiler/heap-snapshot.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Tue, 29 Mar 2011 11:34:20 +0000 (11:34 +0000)]
2011-03-29  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Fix detailed heap snapshots UI.
        https://bugs.webkit.org/show_bug.cgi?id=57235

        Fix two problems:
          1. Text color of grid cells under selection needs to be white, otherwise it's unreadable for some colors;
          2. Long strings need to be truncated in grid, their contents can be shown on hover.

        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.DetailedHeapshotView.prototype._getHoverAnchor):
        (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup):
        * inspector/front-end/heapProfiler.css:
        (.detailed-heapshot-view .console-formatted-string):
        (.detailed-heapshot-view .data-grid tr.selected *):
        (.detailed-heapshot-view .data-grid:focus tr.selected *):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Teach build-jsc how to build JavaScriptCore on Qt
loki@webkit.org [Tue, 29 Mar 2011 11:24:52 +0000 (11:24 +0000)]
[Qt] Teach build-jsc how to build JavaScriptCore on Qt
https://bugs.webkit.org/show_bug.cgi?id=56918

Reviewed by Csaba Osztrogon√°c.

* Scripts/build-jsc:
* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Andrey Adaikin <aandrey@google.com>
podivilov@chromium.org [Tue, 29 Mar 2011 11:20:19 +0000 (11:20 +0000)]
2011-03-29  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Highlight visible lines first
        https://bugs.webkit.org/show_bug.cgi?id=57013

        * inspector/front-end/TextViewer.js:
        (WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleChunkNumber):
        (WebInspector.TextEditorChunkedPanel.prototype._findVisibleChunks):
        (WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleLineNumber.compareLineRowOffsetTops):
        (WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleLineNumber):
        (WebInspector.TextEditorMainPanel.prototype._paintScheduledLines):
        (WebInspector.TextEditorMainPanel.prototype._paintLines):
        (WebInspector.TextEditorMainPanel.prototype._paintLineChunks):
        (WebInspector.TextEditorMainPanel.prototype._paintLine):
        (WebInspector.TextEditorMainChunk.prototype.set expanded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Tue, 29 Mar 2011 11:13:29 +0000 (11:13 +0000)]
2011-03-29  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, updating Chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Tue, 29 Mar 2011 11:02:33 +0000 (11:02 +0000)]
2011-03-29  Emil A Eklund  <eae@chromium.org>

        Reviewed by Dimitri Glazkov.

        Relative mouse coordinates recalculated for target
        https://bugs.webkit.org/show_bug.cgi?id=57130

        Add mouse event performance test.

        * fast/events/mouse-relative-position-expected.txt: Added.
        * fast/events/mouse-relative-position.html: Added.
        * perf/mouse-event-expected.txt: Added.
        * perf/mouse-event.html: Added.
2011-03-29  Emil A Eklund  <eae@chromium.org>

        Reviewed by Dimitri Glazkov.

        Relative mouse coordinates recalculated for each target
        https://bugs.webkit.org/show_bug.cgi?id=57130

        Calculate relative coordinates lazily for mouse events instead of doing
        it for each target. Speeds up dispatching of mouse events in deep dom
        structures significantly, O(n^2) to O(n).

        Also fixes https://bugs.webkit.org/show_bug.cgi?id=34973

        Tests: fast/events/mouse-relative-position.html
               perf/mouse-event.html

        * dom/Event.cpp:
        (WebCore::Event::setTarget):
        * dom/MouseRelatedEvent.cpp:
        (WebCore::MouseRelatedEvent::MouseRelatedEvent):
        (WebCore::MouseRelatedEvent::initCoordinates):
        (WebCore::pageZoomFactor):
        (WebCore::MouseRelatedEvent::receivedTarget):
        (WebCore::MouseRelatedEvent::computeRelativePosition):
        (WebCore::MouseRelatedEvent::layerX):
        (WebCore::MouseRelatedEvent::layerY):
        (WebCore::MouseRelatedEvent::offsetX):
        (WebCore::MouseRelatedEvent::offsetY):
        * dom/MouseRelatedEvent.h:
        * dom/UIEvent.cpp:
        (WebCore::UIEvent::layerX):
        (WebCore::UIEvent::layerY):
        * dom/UIEvent.h:
2011-03-29  Emil A Eklund  <eae@chromium.org>

        Reviewed by Dimitri Glazkov.

        Relative mouse coordinates recalculated for each target
        https://bugs.webkit.org/show_bug.cgi?id=57130

        * public/WebDOMMouseEvent.h:
        * src/WebDOMMouseEvent.cpp:
        (WebKit::WebDOMMouseEvent::layerX):
        (WebKit::WebDOMMouseEvent::layerY):
        (WebKit::WebDOMMouseEvent::offsetX):
        (WebKit::WebDOMMouseEvent::offsetY):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 29 Mar 2011 10:43:00 +0000 (10:43 +0000)]
2011-03-29  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip failing http/tests/uri test on GTK.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Tue, 29 Mar 2011 10:38:11 +0000 (10:38 +0000)]
2011-03-29  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, rolling out r82195.
        http://trac.webkit.org/changeset/82195
        https://bugs.webkit.org/show_bug.cgi?id=56602

        Broke Chromium Clang builds.

        * public/WebDevToolsAgent.h:
        * public/WebURLLoaderClient.h:
        * src/AssociatedURLLoader.cpp:
        (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
        * src/ResourceHandle.cpp:
        (WebCore::ResourceHandleInternal::didReceiveData):
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::didReceiveData):
        * src/WebDevToolsAgentImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Tue, 29 Mar 2011 10:31:46 +0000 (10:31 +0000)]
2011-03-29  Emil A Eklund  <eae@chromium.org>

        Reviewed by Darin Adler.

        getComputedStyle counterIncrement crash @ WebCore::counterToCSSValue
        https://bugs.webkit.org/show_bug.cgi?id=57266

        Add test for getComputedStyle(...).counterIncrement without a counter.

        * fast/css/getComputedStyle/counterIncrement-without-counter-expected.txt: Added.
        * fast/css/getComputedStyle/counterIncrement-without-counter.html: Added.
2011-03-29  Emil A Eklund  <eae@chromium.org>

        Reviewed by Darin Adler.

        getComputedStyle counterIncrement crash @ WebCore::counterToCSSValue
        https://bugs.webkit.org/show_bug.cgi?id=57266

        Add null check to counterToCSSValue.

        Test: fast/css/getComputedStyle/counterIncrement-without-counter.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::counterToCSSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Tue, 29 Mar 2011 09:34:18 +0000 (09:34 +0000)]
2011-03-29  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed. Another build fix. The last fix was incorrect.

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::supportsFullscreenForNode):
        (WebKit::ChromeClientImpl::supportsFullScreenForElement):
        * src/ChromeClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Tue, 29 Mar 2011 09:24:17 +0000 (09:24 +0000)]
2011-03-29  Balazs Kelemen  <kbalazs@webkit.org>

        Unreviewed build fix (64 bit gcc).

        GCC does not accept uint64_t formatted as %lli.

        * UIProcess/WebIconDatabase.cpp:
        (WebKit::WebIconDatabase::getLoadDecisionForIconURL): Add explicit cast to long long.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 29 Mar 2011 09:18:50 +0000 (09:18 +0000)]
2011-03-29  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, disable an assert in testwebview due to
        https://bugs.webkit.org/show_bug.cgi?id=57315

        * tests/testwebview.c:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Tue, 29 Mar 2011 09:08:53 +0000 (09:08 +0000)]
2011-03-29  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed. Build fix for Chromium Clang bot.

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::supportsFullscreenForNode):
        * src/ChromeClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Gavin Peters <gavinp@chromium.org>
commit-queue@webkit.org [Tue, 29 Mar 2011 09:06:26 +0000 (09:06 +0000)]
2011-03-29  Gavin Peters  <gavinp@chromium.org>

        Reviewed by Tony Gentilcore.

        Implement onerror events for <link rel=prefetch>
        https://bugs.webkit.org/show_bug.cgi?id=57182

        * fast/dom/HTMLLinkElement/prefetch-onerror-expected.txt: Added.
        * fast/dom/HTMLLinkElement/prefetch-onerror.html: Added.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-03-29  Gavin Peters  <gavinp@chromium.org>

        Reviewed by Tony Gentilcore.

        Implement onerror events for <link rel=prefetch>
        https://bugs.webkit.org/show_bug.cgi?id=57182

        These events are equired on link elements, see
        http://dev.w3.org/html5/spec/Overview.html#the-link-element

        After a discussion in WebKit-dev about the direction of prefetch in the loader, and about a path
        to adding the Link header, we decided to look at making onerror, onload and onbeforeload events
        more uniformly supported.  See the thread at
        https://lists.webkit.org/pipermail/webkit-dev/2011-February/016034.html .

        It turned out that part of adding onerror for link prefetch was to make the top CachedResource less
        abstract.  It was pure virtual until prefetch became the first consumer to use an unspecialised
        implementation, and this CL continues that by adding a default checkNotify method to it.  As it
        happens there were already two subclasses using what amounted to the generic checkNotify, so I
        also removed those, buying us some code cleanup with the change.

        Test: fast/dom/HTMLLinkElement/prefetch-onerror.html

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::parseMappedAttribute):
        (WebCore::HTMLLinkElement::onloadTimerFired):
        (WebCore::HTMLLinkElement::notifyFinished):
        * loader/cache/CachedImage.cpp:
        * loader/cache/CachedImage.h:
        * loader/cache/CachedResource.cpp:
        (WebCore::CachedResource::checkNotify):
        (WebCore::CachedResource::data):
        (WebCore::CachedResource::error):
        * loader/cache/CachedResource.h:
        * loader/cache/CachedScript.cpp:
        * loader/cache/CachedScript.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttp/tests/uri/username-with-no-hostname.html fails after r82151
ossy@webkit.org [Tue, 29 Mar 2011 08:58:12 +0000 (08:58 +0000)]
http/tests/uri/username-with-no-hostname.html fails after r82151
https://bugs.webkit.org/show_bug.cgi?id=57306

* platform/qt/Skipped: Add http/tests/uri/username-with-no-hostname.html until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 29 Mar 2011 08:55:16 +0000 (08:55 +0000)]
2011-03-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Add support for parsing unicode-bidi: -webkit-isolate
        https://bugs.webkit.org/show_bug.cgi?id=57181

        * css3/unicode-bidi-insolate-parse-expected.txt: Added.
        * css3/unicode-bidi-insolate-parse.html: Added.
2011-03-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Add support for parsing unicode-bidi: -webkit-isolate
        https://bugs.webkit.org/show_bug.cgi?id=57181

        Test: css3/unicode-bidi-insolate-parse.html

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        (WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
        * css/CSSValueKeywords.in:
        * rendering/style/RenderStyleConstants.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 29 Mar 2011 08:42:43 +0000 (08:42 +0000)]
2011-03-29  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r82193.

        * platform/wince/FileSystemWinCE.cpp:
        (WebCore::openTemporaryFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 29 Mar 2011 08:40:37 +0000 (08:40 +0000)]
2011-03-29  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK rebaseline for r82144.

        * platform/gtk/fast/block/positioning/052-expected.checksum:
        * platform/gtk/fast/block/positioning/052-expected.png:
        * platform/gtk/fast/block/positioning/052-expected.txt:
        * platform/gtk/fast/forms/input-appearance-preventDefault-expected.checksum:
        * platform/gtk/fast/forms/input-appearance-preventDefault-expected.png:
        * platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Ben Taylor <bentaylor.solx86@gmail.com>
commit-queue@webkit.org [Tue, 29 Mar 2011 08:37:33 +0000 (08:37 +0000)]
2011-03-29  Ben Taylor  <bentaylor.solx86@gmail.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=57231
        Add conditional for SUNCC supporting alignment macros

        Compile fix for Solaris 10/Sun Studio 12 CC

        * wtf/Vector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 08:32:48 +0000 (08:32 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        Add GPU expectations for compositing tests (these appear to all be passes).

        * platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.checksum:
        * platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.png:
        * platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.checksum:
        * platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.png:
        * platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.checksum:
        * platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.png:
        * platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.checksum:
        * platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.png:
        * platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.checksum:
        * platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.png:
        * platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.checksum:
        * platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.png:
        * platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.checksum:
        * platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.png:
        * platform/chromium-gpu-mac/compositing/self-painting-layers-expected.checksum:
        * platform/chromium-gpu-mac/compositing/self-painting-layers-expected.png:
        * platform/chromium-gpu-mac/media/video-display-toggle-expected.checksum:
        * platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
        * platform/chromium-gpu-mac/media/video-no-audio-expected.checksum:
        * platform/chromium-gpu-mac/media/video-no-audio-expected.png:
        * platform/chromium-gpu-mac/media/video-volume-slider-expected.checksum:
        * platform/chromium-gpu-mac/media/video-volume-slider-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 08:21:34 +0000 (08:21 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        Update IMAGE results to show test progression (yay!).

        * platform/chromium-linux/fast/text/drawBidiText-expected.checksum:
        * platform/chromium-linux/fast/text/drawBidiText-expected.png:
        * platform/chromium-mac/fast/text/drawBidiText-expected.checksum: Added.
        * platform/chromium-mac/fast/text/drawBidiText-expected.png: Added.
        * platform/chromium-win-xp/fast/text/drawBidiText-expected.checksum: Added.
        * platform/chromium-win-xp/fast/text/drawBidiText-expected.png: Added.
        * platform/chromium-win/fast/text/drawBidiText-expected.checksum:
        * platform/chromium-win/fast/text/drawBidiText-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 08:14:19 +0000 (08:14 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        Add Windows baselines.

        * platform/chromium-win/fast/forms/listbox-bidi-align-expected.checksum: Added.
        * platform/chromium-win/fast/forms/listbox-bidi-align-expected.png: Added.
        * platform/chromium-win/fast/forms/listbox-bidi-align-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 08:10:01 +0000 (08:10 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        Add platform-specific baselines for listbox-bidi-align.

        * platform/chromium-linux/fast/forms/listbox-bidi-align-expected.checksum: Added.
        * platform/chromium-linux/fast/forms/listbox-bidi-align-expected.png: Added.
        * platform/chromium-linux/fast/forms/listbox-bidi-align-expected.txt: Added.
        * platform/chromium-mac/fast/forms/listbox-bidi-align-expected.checksum: Added.
        * platform/chromium-mac/fast/forms/listbox-bidi-align-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Ben Taylor <bentaylor.solx86@gmail.com>
commit-queue@webkit.org [Tue, 29 Mar 2011 07:59:16 +0000 (07:59 +0000)]
2011-03-29  Ben Taylor  <bentaylor.solx86@gmail.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=57256

        Fix crash on misaligned reads on Solaris 10/Sparc

        * wtf/text/AtomicString.cpp:
        (WTF::equal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 29 Mar 2011 07:37:30 +0000 (07:37 +0000)]
2011-03-28  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        WKPageGetSourceForFrame and WKPageGetContentsAsString should throw an error in case of a race with page loading
        https://bugs.webkit.org/show_bug.cgi?id=57305
        <rdar://problem/8738060>, <rdar://problem/8780168>

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::close): Clear m_loadDependentStringCallbackIDs
        (WebKit::WebPageProxy::getSourceForFrame): track the callback as load dependent
        (WebKit::WebPageProxy::getContentsAsString): ditto
        (WebKit::WebPageProxy::clearLoadDependentCallbacks): Invalidate all load dependent callbacks
        (WebKit::WebPageProxy::didCommitLoadForFrame): Call clearLoadDependentCallbacks
        (WebKit::WebPageProxy::didFailLoadForFrame): ditto
        (WebKit::WebPageProxy::stringCallback): Remove callback from load dependent set if appropriate
        (WebKit::WebPageProxy::processDidCrash): Clear m_loadDependentStringCallbackIDs
        * UIProcess/WebPageProxy.h: Add m_loadDependentStringCallbackIDs hash set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Tue, 29 Mar 2011 07:30:52 +0000 (07:30 +0000)]
2011-03-29  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Remove unnecessary ewk_view_viewport_attributes_set() invocation
        https://bugs.webkit.org/show_bug.cgi?id=57222

        WebCore sends viewport signal whenever viewport is changed by Page::updateViewportArguments().
        Thus, we don't need to call ewk_view_viewport_attributes_set() with dummy viewport data
        anymore.

        * WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Tue, 29 Mar 2011 07:20:19 +0000 (07:20 +0000)]
2011-03-29  Adam Klein  <adamk@chromium.org>

        Reviewed by Darin Adler.

        removeAllInDirectory() layout test helper method can call successCallback twice
        https://bugs.webkit.org/show_bug.cgi?id=57136

        Fixed to only call successCallback once, thereby avoiding
        flakiness in tests which use this function
        (see http://crbug.com/77442).

        * fast/filesystem/resources/fs-test-util.js:
        (removeAllInDirectory):
        * http/tests/filesystem/resources/fs-test-util.js:
        (removeAllInDirectory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Tue, 29 Mar 2011 07:14:10 +0000 (07:14 +0000)]
2011-03-29  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, add Chromium test expectation for http/tests/uri/username-with-no-hostname.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Tue, 29 Mar 2011 06:59:19 +0000 (06:59 +0000)]
2011-03-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82198.
        http://trac.webkit.org/changeset/82198
        https://bugs.webkit.org/show_bug.cgi?id=57304

        Broke Chromium Win build. (Requested by dave_levin on
        #webkit).

        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageDecoder::headerAvailable):
        (WebCore::PNGImageDecoder::rowAvailable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Tue, 29 Mar 2011 06:45:16 +0000 (06:45 +0000)]
2011-03-28  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, fix Chromium test results and expectations.

        * platform/chromium-mac-leopard/fast/block/positioning/047-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/block/positioning/047-expected.png: Added.
        * platform/chromium-mac/fast/text/justify-ideograph-leading-expansion-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Ofri Wolfus <ofri@google.com>
commit-queue@webkit.org [Tue, 29 Mar 2011 06:42:30 +0000 (06:42 +0000)]
2011-03-28  Ofri Wolfus  <ofri@google.com>

        Reviewed by Eric Seidel.

        RTL: Select elements with a size attribute are always left aligned.
        https://bugs.webkit.org/show_bug.cgi?id=50928

        Added support for alignment in RenderListBox.

        * fast/forms/listbox-bidi-align.html: Added.
        * platform/mac/fast/forms/listbox-bidi-align-expected.checksum: Added.
        * platform/mac/fast/forms/listbox-bidi-align-expected.png: Added.
        * platform/mac/fast/forms/listbox-bidi-align-expected.txt: Added.
        * platform/mac/fast/text/drawBidiText-expected.checksum: Updated.
        * platform/mac/fast/text/drawBidiText-expected.png: Updated.
2011-03-28  Ofri Wolfus  <ofri@google.com>

        Reviewed by Eric Seidel.

        RTL: Select elements with a size attribute are always left aligned.
        https://bugs.webkit.org/show_bug.cgi?id=50928

        Added support for alignment in RenderListBox.

        Test: fast/forms/listbox-bidi-align.html

        * rendering/RenderListBox.cpp:
        (WebCore::itemOffsetForAlignment):
        (WebCore::RenderListBox::paintItemForeground): Add support for alignment and directionality.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Tue, 29 Mar 2011 06:32:36 +0000 (06:32 +0000)]
2011-03-28  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Benjamin Poulain.

        [Qt] Change TextureMapperVideoLayer to TextureMapperMediaLayer
        https://bugs.webkit.org/show_bug.cgi?id=57142

        TextureMapperMediaLayer is a better name here because both video and plugins use this layer.
        Remove ENABLE(VIDEO) guard.

        * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
        * platform/graphics/qt/MediaPlayerPrivateQt.h:
        * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
        (WebCore::GraphicsLayerTextureMapper::setContentsToMedia):
        * platform/graphics/texmap/TextureMapperNode.h:
        * platform/graphics/texmap/TextureMapperPlatformLayer.h:
        (WebCore::TextureMapperMediaLayer::layerType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Thomas Klausner <tk@giga.or.at>
commit-queue@webkit.org [Tue, 29 Mar 2011 06:20:08 +0000 (06:20 +0000)]
2011-03-28  Thomas Klausner  <tk@giga.or.at>

        Reviewed by David Levin.

        png-1.5 fixes
        https://bugs.webkit.org/show_bug.cgi?id=54406

        Fix compilation with png-1.5: struct members were hidden, and
        a new API to terminate data processing was added (especially for
        WebKit).

        Compilation fixes, so no new tests.

        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageDecoder::headerAvailable):
        (WebCore::PNGImageDecoder::rowAvailable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Tue, 29 Mar 2011 06:18:18 +0000 (06:18 +0000)]
2011-03-28  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Adam Barth.

        Replace fprintf(stderr, ...) with LOG_ERROR
        https://bugs.webkit.org/show_bug.cgi?id=57216

        LOG_ERROR is a better choice here.

        * bridge/jni/v8/JavaClassV8.cpp:
        (JavaClass::JavaClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Andrew Foster <andrewf@chromium.org>
commit-queue@webkit.org [Tue, 29 Mar 2011 05:56:08 +0000 (05:56 +0000)]
2011-03-28  Andrew Foster  <andrewf@chromium.org>

        Reviewed by Ojan Vafai.

        webkit-patch should be more intelligent about whether a bug applies to a patch
        Create a new function, parse_bug_id_from_changelog() which determines
        that a bug is related to a patch by parsing the output generated from
        prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
        the description of a patch.
        https://bugs.webkit.org/show_bug.cgi?id=56989

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/checkout/changelog.py:
        * Scripts/webkitpy/common/net/bugzilla/__init__.py:
        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
        * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
        * Scripts/webkitpy/style/checkers/changelog.py:
        * Scripts/webkitpy/tool/commands/upload.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Tue, 29 Mar 2011 05:53:57 +0000 (05:53 +0000)]
2011-03-28  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        [Chromium] Inspector does not always shows transferred size correctly (e.g. gzipped/chunked content)
        https://bugs.webkit.org/show_bug.cgi?id=56602

        Added new methods to interface while keeping the old ones to keep
        chromium working until it is also patched.

        * public/WebDevToolsAgent.h:
        * public/WebURLLoaderClient.h:
        (WebKit::WebURLLoaderClient::didReceiveData):
        * src/AssociatedURLLoader.cpp:
        (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
        * src/ResourceHandle.cpp:
        (WebCore::ResourceHandleInternal::didReceiveData):
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::didReceiveData):
        * src/WebDevToolsAgentImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Steve Block <steveblock@google.com>
steveblock@google.com [Tue, 29 Mar 2011 05:41:07 +0000 (05:41 +0000)]
2011-03-28  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Add a new JavaValue to type to represent a Java value in the Java bridge
        https://bugs.webkit.org/show_bug.cgi?id=57022

        This change introduces a new JavaValue type and uses it in place of jvalue
        in the conversions to and from JavaNPObject used in the V8 Java bridge.

        Refactoring only, no new tests.

        * WebCore.gypi:
        * bridge/jni/JNIUtility.cpp:
        (JSC::Bindings::javaTypeFromClassName):
        (JSC::Bindings::signatureFromJavaType):
        (JSC::Bindings::getJNIField):
        (JSC::Bindings::callJNIMethod):
        * bridge/jni/JavaType.h:
        * bridge/jni/v8/JNIUtilityPrivate.cpp:
        (JSC::Bindings::convertNPVariantToJavaValue):
        (JSC::Bindings::convertJavaValueToNPVariant):
        (JSC::Bindings::jvalueToJavaValue):
        (JSC::Bindings::javaValueToJvalue):
        * bridge/jni/v8/JNIUtilityPrivate.h:
        * bridge/jni/v8/JavaNPObjectV8.cpp:
        (JSC::Bindings::JavaNPObjectInvoke):
        (JSC::Bindings::JavaNPObjectGetProperty):
        * bridge/jni/v8/JavaValueV8.h: Added.
        (JSC::Bindings::JavaValue::JavaValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 29 Mar 2011 05:29:03 +0000 (05:29 +0000)]
2011-03-28  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Darin Adler.

        Use String instead of CString as return value of openTemporaryFile
        https://bugs.webkit.org/show_bug.cgi?id=55332

        We usually store all paths as UTF-16. Do this for temporary files too.

        * WebCore.exp.in
        * platform/FileSystem.h:
        * platform/android/FileSystemAndroid.cpp:
        * platform/brew/FileSystemBrew.cpp:
        * platform/efl/FileSystemEfl.cpp:
        * platform/gtk/FileSystemGtk.cpp:
        * platform/haiku/FileSystemHaiku.cpp:
        * platform/mac/FileSystemMac.mm:
        * platform/qt/FileSystemQt.cpp:
        * platform/win/FileSystemWin.cpp:
        * platform/wince/FileSystemWinCE.cpp:
        * platform/wx/FileSystemWx.cpp:
        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::destroyStream):
        * plugins/PluginStream.h:
2011-03-28  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Darin Adler.

        Use String instead of CString as return value of openTemporaryFile
        https://bugs.webkit.org/show_bug.cgi?id=55332

        * Shared/WebMemorySampler.cpp:
        (WebKit::WebMemorySampler::initializeTempLogFile):
        * WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
        (WebKit::NetscapePluginStream::stop):
        * WebProcess/Plugins/Netscape/NetscapePluginStream.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 29 Mar 2011 05:28:10 +0000 (05:28 +0000)]
2011-03-28  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        [WIN] Remove unused DOMCreateInstance files
        https://bugs.webkit.org/show_bug.cgi?id=57193

        * DOMCreateInstance.cpp: Removed.
        * DOMCreateInstance.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Jeff Johnson <opendarwin@lapcatsoftware.com>
commit-queue@webkit.org [Tue, 29 Mar 2011 05:08:40 +0000 (05:08 +0000)]
2011-03-28  Jeff Johnson  <opendarwin@lapcatsoftware.com>

        Reviewed by Pavel Feldman.

        Web Inspector: empty, non-functional window
        https://bugs.webkit.org/show_bug.cgi?id=56354

        Check whether DOM local storage is enabled
        before attempting to access window.localStorage.

        No new tests.

        * inspector/front-end/Settings.js:
        (WebInspector.Settings.prototype.findSettingForAllProjects):
        (WebInspector.Settings.prototype._get):
        (WebInspector.Settings.prototype._set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Tue, 29 Mar 2011 04:57:49 +0000 (04:57 +0000)]
2011-03-28  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed. Clean up Chromium test expectations for plugins/embed-prefers-plugins-for-images.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix test results that were accidentally committed with a wrong
mjs@apple.com [Tue, 29 Mar 2011 04:47:44 +0000 (04:47 +0000)]
Fix test results that were accidentally committed with a wrong
result due to a temporary wrong code change.

* http/tests/uri/username-with-no-hostname-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoplugins/embed-prefers-plugins-for-images.html fails on non-Apple platforms.
aestes@apple.com [Tue, 29 Mar 2011 04:36:28 +0000 (04:36 +0000)]
plugins/embed-prefers-plugins-for-images.html fails on non-Apple platforms.
https://bugs.webkit.org/show_bug.cgi?id=57137

* platform/chromium/test_expectations.txt: Skip the test.
* platform/gtk/Skipped: Ditto.
* platform/qt/Skipped: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake embed-prefers-plugins-for-images.html pass on all Apple platforms.
aestes@apple.com [Tue, 29 Mar 2011 03:47:53 +0000 (03:47 +0000)]
Make embed-prefers-plugins-for-images.html pass on all Apple platforms.
https://bugs.webkit.org/show_bug.cgi?id=57137

* platform/mac-leopard/plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
* platform/mac-snowleopard/plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
* platform/mac-wk2/plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
* platform/win/Skipped:
* plugins/embed-prefers-plugins-for-images-expected.txt:
* plugins/embed-prefers-plugins-for-images.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert accidentally commited change.
mjs@apple.com [Tue, 29 Mar 2011 03:04:51 +0000 (03:04 +0000)]
Revert accidentally commited change.

* DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=57286 Alternative fix for:
bdakin@apple.com [Tue, 29 Mar 2011 02:39:33 +0000 (02:39 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=57286 Alternative fix for:
Horizontal scroller stops appearing after going Forward
-and corresponding-
<rdar://problem/9026946>

Reviewed by Darin Adler.

This patch rolls out revision 79053 and fixes the same bug in a  better way.

New function resetScrollbarsAndClearContentsSize() calls resetScrollbars() and then
sets the contents size to 0. This is called when a document is going into the page
cache.
* dom/Document.cpp:
(WebCore::Document::setInPageCache):
(WebCore::FrameView::resetScrollbarsAndClearContentsSize):

Roll-out of 79053.
* history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::layout):
* page/FrameView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 29 Mar 2011 02:36:16 +0000 (02:36 +0000)]
2011-03-28  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Antti Koivisto.

        fix style sharing with :any and sibling selectors
        https://bugs.webkit.org/show_bug.cgi?id=57211

        Also tests sibling selector style sharing in general since
        no existing tests seem to cover that codepath.

        * fast/css/sibling-selectors-expected.txt: Added.
        * fast/css/sibling-selectors.html: Added.
2011-03-28  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Antti Koivisto.

        fix style sharing with :any and sibling selectors
        https://bugs.webkit.org/show_bug.cgi?id=57211

        Test: fast/css/sibling-selectors.html

        * css/CSSStyleSelector.cpp:
        (WebCore::collectFeaturesFromList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 29 Mar 2011 02:30:37 +0000 (02:30 +0000)]
2011-03-27  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Antti Koivisto.

        fix :-webkit-any(:last-child)
        https://bugs.webkit.org/show_bug.cgi?id=57207

        * fast/css/pseudo-any.html:
2011-03-27  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Antti Koivisto.

        fix :-webkit-any(:last-child)
        https://bugs.webkit.org/show_bug.cgi?id=57207

        We were passing the wrong arguments to checkSelector. Also, we were not
        passing through the encounteredLink bool.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
        * css/CSSStyleSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCheck in failing results for embed-prefers-plugins-for-images-expected.txt in Mac...
aestes@apple.com [Tue, 29 Mar 2011 01:45:03 +0000 (01:45 +0000)]
Check in failing results for embed-prefers-plugins-for-images-expected.txt in Mac WK2 mode.
https://bugs.webkit.org/show_bug.cgi?id=57137

* platform/mac-wk2/plugins: Added.
* platform/mac-wk2/plugins/embed-prefers-plugins-for-images-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 29 Mar 2011 01:26:47 +0000 (01:26 +0000)]
2011-03-28  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler.

        REGRESSION(r82152): fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
        https://bugs.webkit.org/show_bug.cgi?id=57291

        * platform/KURL.cpp:
        (WebCore::KURL::parse): Instead of considering URLs with
        credentials but no host invalid, consider them to have a host
        ending in @ (which fails down the line)/
2011-03-28  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler.

        REGRESSION(r82152): fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
        https://bugs.webkit.org/show_bug.cgi?id=57291

        * http/tests/uri/username-with-no-hostname.html: Adjusted test to be more tolerant
        of exactly how the image load fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 29 Mar 2011 01:10:49 +0000 (01:10 +0000)]
2011-03-28  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Fix some problems of the appearance of form validation message bubble.
        https://bugs.webkit.org/show_bug.cgi?id=57208

        No new tests. Validation message bubble appearance is not testable
        because it depends on a timer.

        * css/html.css:
        (::-webkit-validation-bubble):
        (::-webkit-validation-bubble-message):
        (::-webkit-validation-bubble-arrow):
        (::-webkit-validation-bubble-arrow-clipper):
          - Explicitly set margin, padding, and color.
          - Make the shadow darker.
          - Make the background color darker.
          - Make opacity larger.
          - Make the border color lighter.
          - Add inset shadows
          - Change the implementation of an arrow.
            Stop making a right triangle by the border trick.
            Use -webkit-transform instead.
          - Make min-width workable by changing display property of
            -webkit-validation-bubble to "inline-block".
        * html/ValidationMessage.cpp:
        (WebCore::ValidationMessage::buildBubbleTree):
          Change the node structure. Before this change, -webkit-validation-bubble
          had three DIVs inside. After this change, it has two DIVs;
          -webkit-validation-bubble-arrow-clipper and
          -webkit-validation-bubble-message, and
          -webkit-validation-bubble-arrow-clipper contains
          -webkit-validation-bubble-arrow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Tue, 29 Mar 2011 01:06:40 +0000 (01:06 +0000)]
2011-03-28  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Adele Peterson.

        Updating small batch of gradient expected results files
        https://bugs.webkit.org/show_bug.cgi?id=57117

        * platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Added.
        * platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Added.
        * platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Added.
        * platform/mac/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Removed.
        * platform/mac/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Removed.
        * platform/mac/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION: http/tests/inspector/console-resource-errors.html failing on WebKit2.
jberlin@webkit.org [Tue, 29 Mar 2011 00:41:56 +0000 (00:41 +0000)]
REGRESSION: http/tests/inspector/console-resource-errors.html failing on WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=56539

Unreviewed, remove the platform-specific failing results to get the bots green.
The test appears to be working in WebKit after r82106 and r82017.

* platform/mac-wk2/http/tests/inspector/console-resource-errors-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Vincent Scheib <scheib@chromium.org>
scheib@chromium.org [Tue, 29 Mar 2011 00:33:29 +0000 (00:33 +0000)]
2011-03-28  Vincent Scheib  <scheib@chromium.org>

        Chromium test expectation for r82159

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION: Can't enter pasted with context or Edit menu text in search or address...
enrica@apple.com [Tue, 29 Mar 2011 00:15:05 +0000 (00:15 +0000)]
REGRESSION: Can't enter pasted with context or Edit menu text in search or address field in the browser.
https://bugs.webkit.org/show_bug.cgi?id=57275
<rdar://problem/8246691>

Reviewed by Sam Weinig.

We need to classify cut and paste actions as user typing actions even when
the action is triggered by a context menu selection to
allow the propagation of the textDidChangeInTextField event.

* editing/EditorCommand.cpp:
The following methods have been modified to properly set up
the UserTypingGestureAction when the command source is the
menu or a key binding sequence.
(WebCore::executeCut):
(WebCore::executePaste):
(WebCore::executePasteAndMatchStyle):
(WebCore::executePasteAsPlainText):
(WebCore::executeDelete):
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected): Changed to
call execute command instead of referring to the specific method in
the editor class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd another test that depends on EventSender to the mac-wk2 Skipped file.
jberlin@webkit.org [Mon, 28 Mar 2011 23:53:48 +0000 (23:53 +0000)]
Add another test that depends on EventSender to the mac-wk2 Skipped file.

* platform/mac-wk2/Skipped:
Add fast/events/onchange-text-form-field.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 28 Mar 2011 23:49:05 +0000 (23:49 +0000)]
2011-03-28  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        [chromium] have DRT write the png checksum into a png comment
        https://bugs.webkit.org/show_bug.cgi?id=57255

        * DEPS: Pull in version of chromium with comment writing
2011-03-28  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        [chromium] have DRT write the png checksum into a png comment
        https://bugs.webkit.org/show_bug.cgi?id=57255

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::dumpImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 28 Mar 2011 23:39:16 +0000 (23:39 +0000)]
2011-03-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        instanceof Array test fails when using iframes
        https://bugs.webkit.org/show_bug.cgi?id=17250

        Add test cases for correct behaviour

        * fast/js/js-constructors-use-correct-global-expected.txt: Added.
        * fast/js/js-constructors-use-correct-global.html: Added.
        * fast/js/resources/js-constructors-use-correct-global.js: Added.
2011-03-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        instanceof Array test fails when using iframes
        https://bugs.webkit.org/show_bug.cgi?id=17250

        This is a problem with all built in constructors, the use of
        lexicalGlobalObject rather than the constructors own
        global object reference means that a builtin will always use
        the prototype from the lexical global object rather than that
        of the constructors origin.

        * API/JSObjectRef.cpp:
        (JSObjectMakeFunction):
        (JSObjectMakeRegExp):
        * JavaScriptCore.exp:
        * runtime/ArrayConstructor.cpp:
        (JSC::constructArrayWithSizeQuirk):
        * runtime/BooleanConstructor.cpp:
        (JSC::constructBoolean):
        (JSC::constructBooleanFromImmediateBoolean):
        * runtime/BooleanConstructor.h:
        * runtime/DateConstructor.cpp:
        (JSC::constructDate):
        * runtime/DateInstance.cpp:
        * runtime/DateInstance.h:
        * runtime/ErrorConstructor.cpp:
        (JSC::constructWithErrorConstructor):
        (JSC::callErrorConstructor):
        * runtime/FunctionConstructor.cpp:
        (JSC::constructWithFunctionConstructor):
        (JSC::callFunctionConstructor):
        (JSC::constructFunction):
        * runtime/FunctionConstructor.h:
        * runtime/JSCell.cpp:
        (JSC::JSCell::getOwnPropertySlot):
        (JSC::JSCell::put):
        (JSC::JSCell::deleteProperty):
        (JSC::JSCell::toThisObject):
        (JSC::JSCell::toObject):
        * runtime/JSCell.h:
        (JSC::JSCell::JSValue::toObject):
        * runtime/JSNotAnObject.cpp:
        (JSC::JSNotAnObject::toObject):
        * runtime/JSNotAnObject.h:
        * runtime/JSObject.cpp:
        (JSC::JSObject::toObject):
        * runtime/JSObject.h:
        * runtime/JSString.cpp:
        (JSC::StringObject::create):
        (JSC::JSString::toObject):
        (JSC::JSString::toThisObject):
        * runtime/JSString.h:
        * runtime/JSValue.cpp:
        (JSC::JSValue::toObjectSlowCase):
        (JSC::JSValue::toThisObjectSlowCase):
        (JSC::JSValue::synthesizeObject):
        * runtime/JSValue.h:
        * runtime/NumberConstructor.cpp:
        (JSC::constructWithNumberConstructor):
        * runtime/NumberObject.cpp:
        (JSC::constructNumber):
        * runtime/NumberObject.h:
        * runtime/ObjectConstructor.cpp:
        (JSC::constructObject):
        (JSC::constructWithObjectConstructor):
        (JSC::callObjectConstructor):
        * runtime/RegExpConstructor.cpp:
        (JSC::constructRegExp):
        (JSC::constructWithRegExpConstructor):
        (JSC::callRegExpConstructor):
        * runtime/RegExpConstructor.h:
        * runtime/StringConstructor.cpp:
        (JSC::constructWithStringConstructor):
        * runtime/StringObject.h:
2011-03-25  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        instanceof Array test fails when using iframes
        https://bugs.webkit.org/show_bug.cgi?id=17250

        Up date for new toObject api

        * UserObjectImp.cpp:
        (UserObjectImp::toPrimitive):
        (UserObjectImp::toBoolean):
        (UserObjectImp::toNumber):
        (UserObjectImp::toString):
2011-03-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        instanceof Array test fails when using iframes
        https://bugs.webkit.org/show_bug.cgi?id=17250

        Update for new function and date apis

        Test: fast/js/js-constructors-use-correct-global.html

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMBinding.cpp:
        (WebCore::jsDateOrNull):
        * bindings/js/JSLazyEventListener.cpp:
        (WebCore::JSLazyEventListener::initializeJSFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemoving Qt stub, since it doesn't use the same header as the others.
adele@apple.com [Mon, 28 Mar 2011 23:24:14 +0000 (23:24 +0000)]
Removing Qt stub, since it doesn't use the same header as the others.

* DumpRenderTree/qt/LayoutTestControllerQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=57124 When the scroller style is
bdakin@apple.com [Mon, 28 Mar 2011 23:15:20 +0000 (23:15 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=57124 When the scroller style is
changed via delegate method, the page needs a full relayout and repaint
-and corresponding-
<rdar://problem/9059129>

Reviewed by Darin Adler.

Call into WebKitSystemInterface to associate the new painter with the existing
painter controller. Reset the scrollbar frame rects to the new thickness -- normally
this only happens when a scrollbar is created, so we have to reset the thickness
here to pick up the new theme thickness. Finally, force a full relayout and style
recall with setNeedsRecalcStyleInAllFrames()
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):

setNeedsRecalcStyleInAllFrames() used to be a static method in Settings.cpp. This
patch moves it to be a member function on Page so that it can be called from
FrameView when the scrollbar style changes.
* page/FrameView.cpp:
(WebCore::FrameView::setNeedsRecalcStyleInAllFrames):
* page/FrameView.h:
* page/Page.cpp:
(WebCore::Page::setNeedsRecalcStyleInAllFrames):
* page/Page.h:
* page/Settings.cpp:
(WebCore::Settings::setStandardFontFamily):
(WebCore::Settings::setFixedFontFamily):
(WebCore::Settings::setSerifFontFamily):
(WebCore::Settings::setSansSerifFontFamily):
(WebCore::Settings::setCursiveFontFamily):
(WebCore::Settings::setFantasyFontFamily):
(WebCore::Settings::setMinimumFontSize):
(WebCore::Settings::setMinimumLogicalFontSize):
(WebCore::Settings::setDefaultFontSize):
(WebCore::Settings::setDefaultFixedFontSize):
(WebCore::Settings::setTextAreasAreResizable):
(WebCore::Settings::setAuthorAndUserStylesEnabled):
(WebCore::Settings::setFontRenderingMode):
(WebCore::Settings::setAcceleratedCompositingEnabled):
(WebCore::Settings::setShowDebugBorders):
(WebCore::Settings::setShowRepaintCounter):
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::setNeedsRecalcStyleInAllFrames):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 28 Mar 2011 23:11:45 +0000 (23:11 +0000)]
2011-03-28  Dirk Pranke  <dpranke@chromium.org>

        RS=Tony Chang.

        r81977 moved FontPlatformData.h from
        WebCore/platform/graphics/cocoa to platform/graphics. This
        change updates the chromium build accordingly.

        https://bugs.webkit.org/show_bug.cgi?id=57281

        * platform/graphics/chromium/CrossProcessFontLoading.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Vincent Scheib <scheib@chromium.org>
scheib@chromium.org [Mon, 28 Mar 2011 22:56:56 +0000 (22:56 +0000)]
2011-03-28  Vincent Scheib  <scheib@chromium.org>

        Chromium rebaseline for r82144.

        * platform/chromium-linux/fast/block/positioning/058-expected.checksum:
        * platform/chromium-linux/fast/block/positioning/058-expected.png:
        * platform/chromium-win/fast/block/positioning/052-expected.txt:
        * platform/chromium-win/fast/block/positioning/058-expected.checksum:
        * platform/chromium-win/fast/block/positioning/058-expected.png:
        * platform/chromium-win/fast/block/positioning/058-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdded a few more stubs.
adele@apple.com [Mon, 28 Mar 2011 22:43:24 +0000 (22:43 +0000)]
Added a few more stubs.

* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::hasGrammarMarker):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::hasGrammarMarker):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::hasGrammarMarker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMediaPlayerPrivateAVFoundation should report that it supportsFullScreen()
jer.noble@apple.com [Mon, 28 Mar 2011 22:31:14 +0000 (22:31 +0000)]
MediaPlayerPrivateAVFoundation should report that it supportsFullScreen()
https://bugs.webkit.org/show_bug.cgi?id=57249

Reviewed by Darin Adler.

Source/WebCore:

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::supportsFullscreen):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

LayoutTests:

* platform/mac/media/controls-strict-expected.txt:
* platform/mac/media/video-controls-rendering-expected.txt:
* platform/mac/media/video-display-toggle-expected.txt:
* platform/mac/media/video-no-audio-expected.txt:
* platform/mac/media/video-zoom-controls-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix.
adele@apple.com [Mon, 28 Mar 2011 22:22:33 +0000 (22:22 +0000)]
Build fix.

Source/WebKit/gtk:

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::webkitWebFrameSelectionHasSpellingMarker):

Tools:

* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::hasGrammarMarker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 28 Mar 2011 22:07:50 +0000 (22:07 +0000)]
2011-03-28  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        http streams don't always display video with AVFoundation backend
        https://bugs.webkit.org/show_bug.cgi?id=57203

        No new tests, we don't currently have tests for http live streams. Changes verified manually.

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::MediaPlayer): Initialize m_shouldPrepareToRender.
        (WebCore::MediaPlayer::loadWithNextMediaEngine): Call prepareForRendering on new engine
            if m_shouldPrepareToRender is set.
        (WebCore::MediaPlayer::prepareForRendering): Set m_shouldPrepareToRender.
        * platform/graphics/MediaPlayer.h:

        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
        (WebCore::MediaPlayerPrivateAVFoundation::isReadyForVideoSetup): Don't return true until
            m_isAllowedToRender has been set.
        (WebCore::MediaPlayerPrivateAVFoundation::prepareForRendering): Always call setUpVideoRendering,
            it has logic to figure out when setup is required.
        (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Call setUpVideoRendering when we aren't
            using the preferred rendering mode because if we get a file's metadata between the
            time supportsAcceleratedRendering() and paint() are called, we will allocate a software
            renderer even when we prefer a layer backed renderer.
        (WebCore::MediaPlayerPrivateAVFoundation::movieLoadType): Return "unknown" until we have metadata.

        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
        (WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Use itemKVOProperties() instead of
            an explicit list of key path names.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForURL): Ditto.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): metadataKeyNames renamed
            to assetMetadataKeyNames, return an NSArray instead of a CFArrayRef since that is what the
            callers need.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Return the duration of the
            player item, not the asset, because AVAsset.duration always returns an indefinite time
            for all streaming files.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): metadataKeyNames renamed
            to assetMetadataKeyNames.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext): Do nothing until
            metadata is available.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Ditto.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Split size calculation logic off
            into sizeChanged().
        (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): New. Use AVPlayerItem.presentationSize
            until tracks is non-NULL so we have a size as early as possible.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::assetMetadataKeyNames): Renamed from metadataKeyNames.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::itemKVOProperties): New, return an array of
            KVO observable properties.
        (-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]): Respond to
            presentationSize change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago../WebKit/chromium: Build fix.
adele@apple.com [Mon, 28 Mar 2011 22:04:18 +0000 (22:04 +0000)]
../WebKit/chromium: Build fix.

* src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectionStartHasSpellingMarkerFor):
Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.

../WebKit/win: Build fix.

* WebFrame.cpp: (WebFrame::hasSpellingMarker):
Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 28 Mar 2011 22:01:58 +0000 (22:01 +0000)]
2011-03-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Search field focus ring is missing
        https://bugs.webkit.org/show_bug.cgi?id=57270
        <rdar://problem/8765555>

        Add an _automaticFocusRingDisabled method which returns YES.

        * platform/mac/ThemeMac.mm:
        (-[WebCoreFlippedView _automaticFocusRingDisabled]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 28 Mar 2011 22:00:48 +0000 (22:00 +0000)]
2011-03-28  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        REGRESSION [r78794-r79249] Allocation of memory is slow when number of active objects is large
        https://bugs.webkit.org/show_bug.cgi?id=56823

        Partial fix for most of the problem. (TOT still shows a regression, though.)

        * runtime/Heap.cpp:
        (JSC::Heap::reportExtraMemoryCostSlowCase): Use highWaterMark(), instead of
        capacity(), since capacity() is O(n) relative to the size of the heap.

        In limited circumstances, capacity() is also worse than highWaterMark()
        for measuring extra cost relative to heap size, since capacity() only
        measures the *current* capacity of the heap, but the heap will grow if
        necessary to attain highWaterMark().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCheck in failing results for embed-prefers-plugins-for-images.html on Leopard.
aestes@apple.com [Mon, 28 Mar 2011 21:53:55 +0000 (21:53 +0000)]
Check in failing results for embed-prefers-plugins-for-images.html on Leopard.
https://bugs.webkit.org/show_bug.cgi?id=57137

* platform/mac-leopard/plugins/embed-prefers-plugins-for-images-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 28 Mar 2011 21:49:53 +0000 (21:49 +0000)]
2011-03-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Move more events to EventDispatcher.
        https://bugs.webkit.org/show_bug.cgi?id=57247

        No functional changes, covered by existing tests.

        * dom/EventDispatcher.cpp:
        (WebCore::eventTargetRespectingSVGTargetRules): Made a static function,
            since it's not used anywhere outside of the EventDispatcher.
        (WebCore::EventDispatcher::dispatchScopedEvent): Moved from Node.cpp.
        (WebCore::EventDispatcher::dispatchKeyEvent): Ditto.
        (WebCore::EventDispatcher::dispatchWheelEvent): Ditto.
        (WebCore::EventDispatcher::dispatchEvent): Changed to use eventTargetRespectingSVGTargetRules
            as a static function.
        * dom/EventDispatcher.h: Updated decls.
        * dom/Node.cpp:
        (WebCore::Node::dispatchScopedEvent): Replaced with calling EventDispatcher.
        (WebCore::Node::dispatchKeyEvent): Ditto.
        (WebCore::Node::dispatchWheelEvent): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar...
adele@apple.com [Mon, 28 Mar 2011 21:48:28 +0000 (21:48 +0000)]
Source/WebCore: Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
https://bugs.webkit.org/show_bug.cgi?id=57173

Reviewed by Eric Seidel.

Test: editing/spelling/grammar.html

* WebCore.exp.in: Add symbol for new selectionStartHasMarkerFor method.
* editing/Editor.cpp:
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Every use of paragraph is specific to spelling or grammar,
 so to avoid confusion, we should explicitly use spellingParagraph or grammarParagraph.  In the case of this bug,
 when we're consider ambiguous boundary characters (characters that could indicate word boundaries, but are used
 in the middle of words too, like apostrophes), we should use the use the spellingParagraph since the spellingParagraph
 is the only one operated on when this information is used.
 (WebCore::Editor::selectionStartHasMarkerFor): Changed from selectionStartHasSpellingMarkerFor so it can check for grammar as well as spelling.
* editing/Editor.h:

Source/WebKit/mac: Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
https://bugs.webkit.org/show_bug.cgi?id=57173

Reviewed by Eric Seidel.

* WebView/WebFrame.mm:
(-[WebFrame hasSpellingMarker:length:]): Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
(-[WebFrame hasGrammarMarker:length:]): Call new selectionStartHasMarkerFor method.
* WebView/WebFramePrivate.h: Add hasGrammarMarker so grammar marking can be tested.

Tools: Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
https://bugs.webkit.org/show_bug.cgi?id=57173

Reviewed by Eric Seidel.

* DumpRenderTree/LayoutTestController.cpp:
(hasGrammarMarkerCallback): Added.
(LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
* DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.

LayoutTests: Test for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
https://bugs.webkit.org/show_bug.cgi?id=57173

Reviewed by Eric Seidel.

* editing/spelling/grammar-expected.txt: Added.
* editing/spelling/grammar.html: Added.
* platform/gtk/Skipped:
* platform/mac-wk2/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8895977> REGRESSION: multicol crashes with positioned elements
mitz@apple.com [Mon, 28 Mar 2011 21:32:42 +0000 (21:32 +0000)]
<rdar://problem/8895977> REGRESSION: multicol crashes with positioned elements
https://bugs.webkit.org/show_bug.cgi?id=48983

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/multicol/paginated-layer-crash.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintPaginatedChildLayer): Bring the logic for finding pagintating layers
into sync with updatePagination() after r68069.
(WebCore::RenderLayer::hitTestPaginatedChildLayer): Ditto.

LayoutTests:

* fast/multicol/paginated-layer-crash-expected.txt: Added.
* fast/multicol/paginated-layer-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2: Downloads started with DownloadCFNet::start never start
bweinstein@apple.com [Mon, 28 Mar 2011 21:32:25 +0000 (21:32 +0000)]
WebKit2: Downloads started with DownloadCFNet::start never start
https://bugs.webkit.org/show_bug.cgi?id=57268

Reviewed by Jon Honeycutt.

* WebProcess/Downloads/cfnet/DownloadCFNet.cpp:
(WebKit::Download::start): Call CFURLDownloadStart on the download we create.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Vincent Scheib <scheib@chromium.org>
scheib@chromium.org [Mon, 28 Mar 2011 21:28:52 +0000 (21:28 +0000)]
2011-03-28  Vincent Scheib  <scheib@chromium.org>

        Chromium rebaseline for r82123.

        * platform/chromium-mac/fast/repaint/overflow-flipped-writing-mode-block-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/overflow-flipped-writing-mode-block-expected.png: Added.
        * platform/chromium-mac/fast/repaint/overflow-flipped-writing-mode-table-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/overflow-flipped-writing-mode-table-expected.png: Added.
        * platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-block-expected.checksum: Added.
        * platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-block-expected.png: Added.
        * platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-table-expected.checksum: Added.
        * platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-table-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
ossy@webkit.org [Mon, 28 Mar 2011 21:23:09 +0000 (21:23 +0000)]
[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
https://bugs.webkit.org/show_bug.cgi?id=57087

Reviewed by Benjamin Poulain.

Trivial typo fix after r82082.

* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Windows build.
andersca@apple.com [Mon, 28 Mar 2011 21:00:06 +0000 (21:00 +0000)]
Fix Windows build.

* Shared/ShareableBitmap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 28 Mar 2011 20:58:09 +0000 (20:58 +0000)]
2011-03-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Beep when pressing a menu key equivalent when a plug-in has focus
        https://bugs.webkit.org/show_bug.cgi?id=57264
        <rdar://problem/8935597>

        We don't want the WKTextInputWindowController inputContext to be involved in interpretKeyEvents.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView inputContext]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 28 Mar 2011 20:53:20 +0000 (20:53 +0000)]
2011-03-28  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler' .

        URLSs with non-empty username but empty hostname treat first path segment as hostname, potentially enabling XSS
        https://bugs.webkit.org/show_bug.cgi?id=57220

        Test: http/tests/uri/username-with-no-hostname.html

        * platform/KURL.cpp:
        (WebCore::hostPortIsEmptyButUserPassIsNot):
        (WebCore::KURL::parse):
2011-03-28  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler' .

        URLSs with non-empty username but empty hostname are allowed to load
        https://bugs.webkit.org/show_bug.cgi?id=57220

        * http/tests/uri/username-with-no-hostname-expected.txt: Added.
        * http/tests/uri/username-with-no-hostname.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 28 Mar 2011 20:45:58 +0000 (20:45 +0000)]
2011-03-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        CGImageRefs must hold a strong reference to underlying data
        https://bugs.webkit.org/show_bug.cgi?id=57263
        <rdar://problem/9146179>

        Make paintBitmapContext use CGBitmapContextCreateImage, which creates a copy-on-write copy
        of the bitmap data. Also, add ShareableBitmap::makeCGImageCopy which does the same thing, and
        ShareableBitmap::makeCGImage in the cases where we know that the ShareableBitmap data will never change.

        * Platform/cg/CGUtilities.cpp:
        (WebKit::paintImage):
        Factor image painting code out into a separate function.

        (WebKit::paintBitmapContext):
        Call paintImage.

        * Shared/API/c/cg/WKImageCG.cpp:
        (WKImagemakeCGImage):
        Use ShareableBitmap::makeCGImageCopy.

        * Shared/ShareableBitmap.h:
        * Shared/cg/ShareableBitmapCG.cpp:
        (WebKit::ShareableBitmap::createGraphicsContext):
        (WebKit::ShareableBitmap::paint):
        (WebKit::ShareableBitmap::makeCGImageCopy):
        (WebKit::ShareableBitmap::makeCGImage):
        (WebKit::ShareableBitmap::releaseBitmapContextData):
        (WebKit::ShareableBitmap::releaseDataProviderData):
        Add makeCGImage and makeCGImageCopy.

        * Shared/cg/WebCoreArgumentCodersCG.cpp:
        (CoreIPC::createImage):
        Use ShareableBitmap::makeCGImage.

        * UIProcess/API/mac/PageClientImpl.mm:
        (WebKit::PageClientImpl::setDragImage):
        Use ShareableBitmap::makeCGImage and plug a CGImageRef leak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Build fix.
ap@apple.com [Mon, 28 Mar 2011 20:34:24 +0000 (20:34 +0000)]
    Build fix.

        * UIProcess/API/mac/WKView.mm: (-[WKView keyDown:]): It's not "event" in this function, it's
        "theEvent".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate progressing layout tests on SL.
hyatt@apple.com [Mon, 28 Mar 2011 20:32:23 +0000 (20:32 +0000)]
Update progressing layout tests on SL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Mon, 28 Mar 2011 20:19:11 +0000 (20:19 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=57260
        Clean up text input code a little

WebKit/mac:
        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::handleKeyboardEvent):
        (WebEditorClient::handleInputMethodKeydown):
        * WebView/WebHTMLViewInternal.h:
        Renamed _interceptEditingKeyEvent:shouldSaveCommand:, becasue it doesn't really intercept
        anything. It's just a version it interpretKeyEvents: that tells us whether it was handled,
        and also possibly saves resulting commands for later execution.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Changed to use early return. Changed
        return value in case platformEvent is null to be less mysterious. Moved receivedNOOP from
        WebHTMLViewPrivate to WebHTMLViewInterpretKeyEventsParameters, as this is just part of event
        handling state, like the other booleans there. Don't call interpretKeyEvents: again simply
        because the first call resulted in no saved commands, becasue it's confusing and apparently
        useless (I couldn't find any broken behavior).
        (-[WebHTMLView unmarkText]): Cleaned upo BOOL vs. bool constants.
        (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
        (-[WebHTMLView doCommandBySelector:]): Ditto.
        (-[WebHTMLView insertText:]): Ditto.

        * WebView/WebViewInternal.h: There was no _interceptEditingKeyEvent:shouldSaveCommand:
        method on WebView.

WebKit2:
        * UIProcess/API/mac/WKView.mm:
        (-[WKView doCommandBySelector:]): This NSTextInput protocol method lacked a LOG() call.
        (-[WKView keyDown:]): Added (possibly useless) event protection to match performKeyEquivalent:
        and also WebKit1.

        * WebProcess/WebPage/mac/WebPageMac.mm: Removed an obsolete comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 28 Mar 2011 20:16:06 +0000 (20:16 +0000)]
2011-03-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        script-src should block inline event handlers
        https://bugs.webkit.org/show_bug.cgi?id=57212

        I considered wrapping this into the canExecute check, but that approach
        would require passing that function a bunch of context information to
        behave correctly once we add support for the "options" directive that
        re-enables these features.

        Test: http/tests/security/contentSecurityPolicy/script-src-none-inline-event.html

        * bindings/js/JSLazyEventListener.cpp:
        (WebCore::JSLazyEventListener::initializeJSFunction):
            - This function was a mess.  I couldn't resist cleaning it up a
              bunch.  Notice that we ASSERT at the beginning of the function
              that scriptExecutionContext is a document and that both ways of
              getting the global object are the same when document->frame() is
              non-zero because the document must be active and there is a
              one-to-one relation between Frames and active Documents.
        * bindings/v8/V8LazyEventListener.cpp:
        (WebCore::V8LazyEventListener::prepareListenerObject):
        * page/ContentSecurityPolicy.cpp:
        (WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
        * page/ContentSecurityPolicy.h:
2011-03-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        script-src should block inline event handlers
        https://bugs.webkit.org/show_bug.cgi?id=57212

        * http/tests/security/contentSecurityPolicy/resources/event-handler.pl: Added.
        * http/tests/security/contentSecurityPolicy/script-src-none-inline-event-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/script-src-none-inline-event.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Mon, 28 Mar 2011 20:09:21 +0000 (20:09 +0000)]
2011-03-28  Jeff Miller  <jeffm@apple.com>

        Reviewed by Adam Roben.

        ResourceError::certificate() should return a PCCERT_CONTEXT
        https://bugs.webkit.org/show_bug.cgi?id=57262

        * platform/network/cf/ResourceError.h: certificate() now returns a PCCERT_CONTEXT.
        * platform/network/cf/ResourceErrorCF.cpp:
        (WebCore::ResourceError::certificate): Added.
2011-03-28  Jeff Miller  <jeffm@apple.com>

        Reviewed by Adam Roben.

        ResourceError::certificate() should return a PCCERT_CONTEXT
        https://bugs.webkit.org/show_bug.cgi?id=57262

        * Shared/win/PlatformCertificateInfo.cpp:
        (WebKit::PlatformCertificateInfo::PlatformCertificateInfo): Don't assert if no PCCERT_CONTEXT is specified.
        * Shared/win/WebCoreArgumentCodersWin.cpp:
        (CoreIPC::encodeResourceError): Removed unneeded code now that ResourceError::certificate() returns a PCCERT_CONTEXT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Mon, 28 Mar 2011 20:03:53 +0000 (20:03 +0000)]
2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        Add myself to the committers list.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=57221, memory corruption/crashes when positio...
hyatt@apple.com [Mon, 28 Mar 2011 19:44:19 +0000 (19:44 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=57221, memory corruption/crashes when positioned objects
occur at the end of a line.

Reviewed by Simon Fraser and Darin Adler.

The old code and new code for dealing with a trailing space object midpoint manipulated a raw
array instead of the Vector. Otherwise this corruption would have been caught prior to check-in.

I have patched the code to only go through the Vector and to make it handle the case that led to
the corruption. Trailing positioned objects can occur both prior to and following the trailing space
object's midpoint, so we have to be prepared to deal with both cases.

This is already tested by fast/block/positioning/052.html, and that test now properly progresses
like the other positioning tests did.

Source/WebCore:

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak):

LayoutTests:

* platform/mac/fast/block/positioning/052-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82144 268f45cc-cd09-0410-ab3c-d52691b4dbfc