WebKit-https.git
9 years agoAdd myself to committers.py
rtoy@google.com [Mon, 28 Jan 2013 23:15:26 +0000 (23:15 +0000)]
Add myself to committers.py
https://bugs.webkit.org/show_bug.cgi?id=107992

Reviewed by kbr@google.com.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r140869.
commit-queue@webkit.org [Mon, 28 Jan 2013 23:07:00 +0000 (23:07 +0000)]
Unreviewed, rolling out r140869.
http://trac.webkit.org/changeset/140869
https://bugs.webkit.org/show_bug.cgi?id=108120

"Crashes on http://en.wikipedia.org/wiki/Wikipedia" (Requested
by tonyg-cr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-28

Source/WebCore:

* page/FrameView.cpp:
(WebCore::FrameView::visibleContentsResized):
* platform/ScrollView.cpp:
(WebCore::ScrollView::setFixedLayoutSize):
(WebCore::ScrollView::setUseFixedLayout):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::computePageScaleFactorLimits):
* tests/WebFrameTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed gardening, removing Crash expectations from storage/indexeddb...
jsbell@chromium.org [Mon, 28 Jan 2013 23:05:09 +0000 (23:05 +0000)]
[Chromium] Unreviewed gardening, removing Crash expectations from storage/indexeddb tests.
https://bugs.webkit.org/show_bug.cgi?id=108048

Unreviewed.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r140934, r140935, and r140937.
commit-queue@webkit.org [Mon, 28 Jan 2013 22:47:38 +0000 (22:47 +0000)]
Unreviewed, rolling out r140934, r140935, and r140937.
http://trac.webkit.org/changeset/140934
http://trac.webkit.org/changeset/140935
http://trac.webkit.org/changeset/140937
https://bugs.webkit.org/show_bug.cgi?id=108117

Re-land some speculative rollouts - see wkbug.com/108048 for
context (Requested by jsbell on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-28

Source/WebCore:

* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.list.am:
* Modules/indexeddb/IDBCallbacks.h:
(IDBCallbacks):
* Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
* Modules/indexeddb/IDBCursorBackendImpl.h:
(WebCore::IDBCursorBackendImpl::create):
(IDBCursorBackendImpl):
* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::onVersionChange):
* Modules/indexeddb/IDBDatabase.h:
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::setIndexesReady):
(WebCore::OpenCursorOperation::perform):
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):
* Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):
* Modules/indexeddb/IDBFactory.h:
(WebCore):
(IDBFactory):
* Modules/indexeddb/IDBFactory.idl:
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::openCursor):
* Modules/indexeddb/IDBObjectStore.h:
(WebCore::IDBObjectStore::openCursor):
(IDBObjectStore):
* Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::create):
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::onBlocked):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
(WebCore::IDBOpenDBRequest::dispatchEvent):
* Modules/indexeddb/IDBOpenDBRequest.h:
(IDBOpenDBRequest):
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::create):
(WebCore::IDBRequest::IDBRequest):
* Modules/indexeddb/IDBRequest.h:
(IDBRequest):
(WebCore::IDBRequest::taskType):
* Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::scheduleTask):
* Modules/indexeddb/IDBTransactionBackendImpl.h:
(WebCore::IDBTransactionBackendImpl::scheduleTask):
(IDBTransactionBackendImpl):
* Modules/indexeddb/IDBTransactionBackendInterface.h:
* Modules/indexeddb/IDBUpgradeNeededEvent.cpp: Removed.
* Modules/indexeddb/IDBUpgradeNeededEvent.h: Removed.
* Modules/indexeddb/IDBUpgradeNeededEvent.idl: Removed.
* Modules/indexeddb/IDBVersionChangeEvent.cpp:
(WebCore::IDBVersionChangeEvent::create):
(WebCore::IDBVersionChangeEvent::IDBVersionChangeEvent):
* Modules/indexeddb/IDBVersionChangeEvent.h:
(IDBVersionChangeEvent):
(WebCore::IDBVersionChangeEvent::oldVersion):
(WebCore::IDBVersionChangeEvent::newVersion):
* Modules/indexeddb/IDBVersionChangeEvent.idl:
* Modules/indexeddb/IDBVersionChangeRequest.cpp: Removed.
* Modules/indexeddb/IDBVersionChangeRequest.h: Removed.
* Modules/indexeddb/IDBVersionChangeRequest.idl: Removed.
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* dom/EventNames.in:
* dom/EventTarget.h:
(WebCore):
* dom/EventTargetFactory.in:

Source/WebKit/chromium:

* public/WebIDBCallbacks.h:
(WebIDBCallbacks):
* src/AssertMatchingEnums.cpp:
* src/IDBCallbacksProxy.cpp:
* src/IDBCallbacksProxy.h:
(IDBCallbacksProxy):
* src/WebIDBCallbacksImpl.cpp:
* src/WebIDBCallbacksImpl.h:
(WebIDBCallbacksImpl):
* tests/IDBAbortOnCorruptTest.cpp:
* tests/IDBDatabaseBackendTest.cpp:

LayoutTests:

* storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt:
* storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange-expected.txt:
* storage/indexeddb/deletedatabase-blocked-expected.txt:
* storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt:
* storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-workers-expected.txt:
* storage/indexeddb/deletedatabase-delayed-by-versionchange-expected.txt:
* storage/indexeddb/deletedatabase-not-blocked-expected.txt:
* storage/indexeddb/events-expected.txt: Added.
* storage/indexeddb/events.html: Added.
* storage/indexeddb/intversion-gated-on-delete-expected.txt:
* storage/indexeddb/intversion-long-queue-expected.txt:
* storage/indexeddb/intversion-upgrades-expected.txt:
* storage/indexeddb/removed-expected.txt:
* storage/indexeddb/resources/delete-in-upgradeneeded-close-in-open-success.js:
(versionChangeCallback):
* storage/indexeddb/resources/delete-in-upgradeneeded-close-in-versionchange.js:
(versionChangeCallback):
* storage/indexeddb/resources/deletedatabase-blocked.js:
(test.request.onsuccess.openOnSuccess.h.onversionchange):
* storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js:
(prepareDatabase.h.onversionchange):
* storage/indexeddb/resources/deletedatabase-delayed-by-versionchange.js:
(h1OpenSuccess.h1.onversionchange.h1OnVersionChange.h1.onversionchange):
(h1OpenSuccess.h1.onversionchange):
(h1OpenSuccess.request.onsuccess.h2OpenSuccess.h2.onversionchange):
* storage/indexeddb/resources/deletedatabase-not-blocked.js:
(test.request.onsuccess.openOnSuccess.h.onversionchange):
* storage/indexeddb/resources/events.js: Added.
(test):
* storage/indexeddb/resources/intversion-gated-on-delete.js:
(firstSuccessCallback):
(connection1VersionChangeCallback):
* storage/indexeddb/resources/intversion-long-queue.js:
(connection1VersionChangeCallback):
(deleteDatabaseBlockedCallback):
(deleteDatabaseSuccessCallback):
(connection2VersionChangeEvent):
* storage/indexeddb/resources/removed.js:
(test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Mac build fix. Add an export for a function that may be
joepeck@webkit.org [Mon, 28 Jan 2013 22:42:20 +0000 (22:42 +0000)]
Unreviewed Mac build fix. Add an export for a function that may be
accessed outside of WebCore (RenderLayer::needsCompositedScrolling).

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Mac] Update PageVisibilityState when WebView is hidden / visible
joepeck@webkit.org [Mon, 28 Jan 2013 22:38:26 +0000 (22:38 +0000)]
[Mac] Update PageVisibilityState when WebView is hidden / visible
https://bugs.webkit.org/show_bug.cgi?id=107509

Source/WebKit/mac:

Reviewed by NOBODY (OOPS!).

* WebView/WebView.mm:
* WebView/WebViewPrivate.h:
(-[WebView _commonInitializationWithFrameName:groupName:]):
Set the initial visibility of the page.

(-[WebView addWindowObserversForWindow:]):
(-[WebView removeWindowObservers]):
(-[WebView _isViewVisible]):
(-[WebView _updateVisibilityState]):
(-[WebView viewDidMoveToWindow]):
(-[WebView _windowVisibilityChanged:]):
Update visibility state in the same ways WK2 does. This involves
listening for some new NSWindow delegates.

Tools:

Add a test that PageVisibility of WK1 WebViews and WK2 WKViews
automatically changes between hidden and visible as the view is added
and removed from window, or when it is in a window that changes
visibility, for instance by minimizing / deminimizing.

Reviewed by NOBODY (OOPS!).

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html: Added.
* TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Added.
(-[PageVisibilityStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
(runJavaScriptAlert):
(PageVisibilityStateWithWindowChanges):
(TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
(TestWebKitAPI::PageVisibilityStateWithWindowChanges::deinitializeView):
(TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
(TestWebKitAPI::TEST_F):
Test visibility state of a page in a WebView/WKView with different window states.

* TestWebKitAPI/mac/WebKitAgnosticTest.h:
* TestWebKitAPI/mac/WebKitAgnosticTest.mm:
(TestWebKitAPI::WebKitAgnosticTest::deinitializeView):
(TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
(TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
Add a WK1 and WK2 deinitializeView to balance initializeView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImprove PageVisibility API with enums
joepeck@webkit.org [Mon, 28 Jan 2013 22:38:23 +0000 (22:38 +0000)]
Improve PageVisibility API with enums
https://bugs.webkit.org/show_bug.cgi?id=107364

Reviewed by Sam Weinig.

Source/WebKit/mac:

* WebView/WebView.mm:
* WebView/WebViewPrivate.h:
(corePageVisibilityState):
(-[WebView _setVisibilityState:isInitialState:]):
Switch the private API form int to a WebPageVisibilityState enum.

Source/WebKit2:

* Shared/API/c/WKPageVisibilityTypes.h: Added.
* Shared/API/c/WKSharedAPICast.h:
(WebKit::toPageVisibilityState):
Create an enum for page visibility APIs and a conversion function
for the WK2 values to WebCore values.

* Target.pri:
* GNUmakefile.list.am:
* WebKit2.xcodeproj/project.pbxproj:
Add WKPageVisibilityTypes.h to the build as a private export.

* UIProcess/API/C/WKPage.h:
* UIProcess/API/C/WKPage.cpp:
(WKPageSetVisibilityState):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setVisibilityState):
UIProcess API to set visibility state. WebPageProxy already
had m_visibilityState, so update that when setter is used.

* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
* WebProcess/InjectedBundle/InjectedBundle.h:
Remove the old SPI for WebKitTestRunner. Tests now use the C API.

* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setVisibilityState):
* WebProcess/WebPage/WebPage.messages.in:
Update the existing WebPage API to use uint32_t, which matches
other enum message types.

Tools:

* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::resetPageVisibility):
(TestRunner::setPageVisibility):
Update the WK1 test code to use the new WK1 enums.

* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::setVisibilityState):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setPageVisibility):
(WTR::TestRunner::resetPageVisibility):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::setVisibilityState):
* WebKitTestRunner/TestController.h:
(TestController):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
Update the WK2 test code to use the new WK2 API and enums.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
(TestWebKitAPI::assertSerializedScriptValueIsStringValue):
(TestWebKitAPI::didRunStep1StateChangeVisibleToHidden):
(TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
(TestWebKitAPI::didRunStep3StateChangePrerenderToPreview):
(TestWebKitAPI::didRunStep4InStatePreview):
(TestWebKitAPI::TEST):
Test the new WK2 API with all enum types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash inside RenderBlock::layoutRunsAndFloatsInRange in the widow code
jchaffraix@webkit.org [Mon, 28 Jan 2013 22:28:21 +0000 (22:28 +0000)]
Crash inside RenderBlock::layoutRunsAndFloatsInRange in the widow code
https://bugs.webkit.org/show_bug.cgi?id=108084

Reviewed by Dean Jackson.

This is a blind fix based on the code and Chromium's stack-traces.

Unfortunately no new test as I couldn't get a local reproduction.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
Added a missing NULL-check: the previous 'while' finish if |lineBox|
is NULL and we don't want to crash in this case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Use C API inside ewk_download_job
christophe.dumez@intel.com [Mon, 28 Jan 2013 22:22:16 +0000 (22:22 +0000)]
[EFL][WK2] Use C API inside ewk_download_job
https://bugs.webkit.org/show_bug.cgi?id=107810

Reviewed by Anders Carlsson.

Use C API inside ewk_download_job instead of accessing internal C++
classes directly, to avoid violating API layering.

* UIProcess/API/C/WKDownload.cpp:
(WKDownloadGetID): Add C API to get the download ID as we need it to
support our public API and it seems like a useful addition.
* UIProcess/API/C/WKDownload.h:
* UIProcess/API/efl/ewk_download_job.cpp:
(EwkDownloadJob::EwkDownloadJob):
(EwkDownloadJob::id):
(EwkDownloadJob::request):
(EwkDownloadJob::cancel):
* UIProcess/API/efl/ewk_download_job_private.h:
(EwkDownloadJob::create):
(EwkDownloadJob):
* UIProcess/efl/DownloadManagerEfl.cpp:
(WebKit::DownloadManagerEfl::decideDestinationWithSuggestedFilename):
(WebKit::DownloadManagerEfl::didReceiveResponse):
(WebKit::DownloadManagerEfl::didCreateDestination):
(WebKit::DownloadManagerEfl::didReceiveData):
(WebKit::DownloadManagerEfl::didFail):
(WebKit::DownloadManagerEfl::didCancel):
(WebKit::DownloadManagerEfl::didFinish):
(WebKit::DownloadManagerEfl::registerDownloadJob): Rename
registerDownload() to registerDownloadJob() for consistency with
unregisterDownloadJob().
(WebKit::DownloadManagerEfl::ewkDownloadJob): Rename downloadJob() to
ewkDownloadJob() for clarity since it returns a EwkDownload object.
Also take a WKDownloadRef in argument instead of an identifier since
all the callers have a WKDownloadRef and it makes their code simpler.
Finally, make the getter non-const since it returns a non-const pointer.
(WebKit::DownloadManagerEfl::unregisterDownloadJob): Take a
WKDownloadRef in argument instead of an identifier since all the
callers have a WKDownloadRef and it makes their code simpler.
* UIProcess/efl/DownloadManagerEfl.h:
(DownloadManagerEfl):
* UIProcess/efl/PageClientBase.cpp:
(WebKit::PageClientBase::handleDownloadRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago"clang: warning: not using the clang compiler for C++ inputs" due to hard-coding...
tony@chromium.org [Mon, 28 Jan 2013 22:06:01 +0000 (22:06 +0000)]
"clang: warning: not using the clang compiler for C++ inputs" due to hard-coding of /usr/bin/clang in WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=108089

Reviewed by Ojan Vafai.

Use gcc since older versions of clang (with Xcode 3.2) warn that they are going to use gcc anyway.
These warnings are showing up on the main Chromium waterfall too:
http://build.chromium.org/p/chromium/builders/Mac/builds/19113/steps/compile/logs/stdio

No new tests, this is a build change.

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] WebConsoleMessage is missing LevelDebug (chromium bug 172416)
commit-queue@webkit.org [Mon, 28 Jan 2013 21:47:44 +0000 (21:47 +0000)]
[chromium] WebConsoleMessage is missing LevelDebug (chromium bug 172416)
https://bugs.webkit.org/show_bug.cgi?id=108004
http://code.google.com/p/chromium/issues/detail?id=172416

console.debug triggers a NOTREACHED() assertation in Chromium. This
is because WebCore::MessageLevel contains 5 levels, including debug,
where WebConsoleMessage::Level is missing a "debug" level. Add a
WebConsoleMessage::LevelDebug so that it can get passed up to the
renderer even if it doesn't make use of that now.

Requires another patch to chromium itself to fix chromium bug 172416
but this is a prerequisite.

Also add an enum compile time check to AssertMatchingEnums.cpp,

Patch by Kevin Day <kevinday@gmail.com> on 2013-01-28
Reviewed by Jochen Eisinger.

* public/WebConsoleMessage.h:
* src/AssertMatchingEnums.cpp:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::addMessageToConsole):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove hasAuthorShadowRoot to Element
esprehn@chromium.org [Mon, 28 Jan 2013 21:45:11 +0000 (21:45 +0000)]
Move hasAuthorShadowRoot to Element
https://bugs.webkit.org/show_bug.cgi?id=108071

Reviewed by Dimitri Glazkov.

Move hasAuthorShadowRoot to Element and get rid of unneccesary booleans
in HTMLProgressElement and HTMLMeterElement. Also get rid of
ShadowRoot::isAccessible since it obfuscates what's actually happening
inside of Element::shadowRoot().

No new tests, just refactoring.

* dom/Element.cpp:
(WebCore::Element::shadowRoot):
(WebCore::Element::hasAuthorShadowRoot):
* dom/Element.h:
(Element):
* dom/ShadowRoot.h:
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::HTMLMeterElement):
* html/HTMLMeterElement.h:
(HTMLMeterElement):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::HTMLProgressElement):
* html/HTMLProgressElement.h:
(HTMLProgressElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPDFPlugin: getMainResourceDataOfFrame should return PDFPlugin's data so that Save...
timothy_horton@apple.com [Mon, 28 Jan 2013 21:42:22 +0000 (21:42 +0000)]
PDFPlugin: getMainResourceDataOfFrame should return PDFPlugin's data so that Save... works
https://bugs.webkit.org/show_bug.cgi?id=108060
<rdar://problem/13075454>

Reviewed by Sam Weinig.

* WebProcess/Plugins/Netscape/NetscapePlugin.h: Implement getResourceData.
* WebProcess/Plugins/PDF/SimplePDFPlugin.h:
* WebProcess/Plugins/PDF/SimplePDFPlugin.mm: Implement getResourceData, returning the accumulated
data if it exists and has finished loading.
(WebKit::SimplePDFPlugin::getResourceData):
* WebProcess/Plugins/Plugin.h: Add getResourceData, which hands out a raw pointer/size pair
to the plugin's "main resource" data.
* WebProcess/Plugins/PluginProxy.h: Implement getResourceData.
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::getResourceData): Forward getResourceData through to the plugin.
* WebProcess/Plugins/PluginView.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getMainResourceDataOfFrame): If the requested frame is backed by a PluginDocument,
attempt to ask the PluginView for its resource data.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wk2] WKView's intrinsicContentSize should only report a flexible width if the conten...
timothy_horton@apple.com [Mon, 28 Jan 2013 21:36:49 +0000 (21:36 +0000)]
[wk2] WKView's intrinsicContentSize should only report a flexible width if the content width is less than the minimum width
https://bugs.webkit.org/show_bug.cgi?id=108056

Reviewed by Simon Fraser.

We're currently reporting a flexible width if the intrinsic
content size is less than *or equal* to the minimum layout
width. This is wrong and causes ping-ponging between flexible
and inflexible width in cases where autolayout fits our
view to exactly the intrinsic content size. It should be strictly
less than instead.

* UIProcess/API/mac/WKView.mm:
(-[WKView _setIntrinsicContentSize:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove ensureUserAgentShadowRoot to Element
esprehn@chromium.org [Mon, 28 Jan 2013 21:36:13 +0000 (21:36 +0000)]
Move ensureUserAgentShadowRoot to Element
https://bugs.webkit.org/show_bug.cgi?id=108070

Reviewed by Dimitri Glazkov.

Move ensureUserAgentShadowRoot to Element where the other
methods related to shadow roots are and get rid of the
unnecessarily specific cast to HTMLElement.

No new tests, just refactoring.

* dom/Element.cpp:
(WebCore::Element::ensureUserAgentShadowRoot): Moved from FormAssociatedElement.
* dom/Element.h:
(Element):
* html/FormAssociatedElement.cpp:
* html/FormAssociatedElement.h:
(FormAssociatedElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert 130950
cevans@google.com [Mon, 28 Jan 2013 21:20:50 +0000 (21:20 +0000)]
Revert 130950
BUG=163593

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPromote composited-scrolling layers to stacking containers.
vollick@chromium.org [Mon, 28 Jan 2013 21:18:14 +0000 (21:18 +0000)]
Promote composited-scrolling layers to stacking containers.
https://bugs.webkit.org/show_bug.cgi?id=106142

Reviewed by Simon Fraser.

With this patch, RenderLayers that use composited scrolling are
treated as stacking contexts. Since isStackingContainer now depends on
the value of m_needsCompositedScrolling, special care needed to be
taken to ensure that the value of isStackingContainer is not used when
updating m_needsCompositedScrolling. In particular, the code for
rebuilding the layer lists needed to be generalized so that we could
build the layer lists using the value of isStackingContext rather than
isStackingContainer when building the layer lists used to determine if
the descendants are contiguous in stacking order. Also, updating
m_needsCompositedScrolling can now affect stacking container status
and can therefore dirty layer lists.

Source/WebCore:

Test: compositing/overflow/composited-scrolling-creates-a-stacking-container.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateDescendantsAreContiguousInStackingOrder):
  Modified to use layer lists built based on isStackingContext rather
  than isStackingContainer.
(WebCore::RenderLayer::updateNeedsCompositedScrolling):
  This function can now affect stacking container status and layer
  lists.
(WebCore::RenderLayer::rebuildZOrderLists):
  Refactored to generalize layer list building.
(WebCore::RenderLayer::collectLayers):
  This function can now stop at either stacking containers or
  contexts.
(WebCore::RenderLayer::updateLayerListsIfNeeded):
  Layer lists may need to be built a 2nd time if we opt into
  composited scrolling.
* rendering/RenderLayer.h:
(RenderLayer):
(WebCore::RenderLayer::isStackingContainer):
  Returns true if we use composited scrolling.

LayoutTests:

* compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Added.
* compositing/overflow/composited-scrolling-creates-a-stacking-container.html: Added.
* platform/chromium/TestExpectations:
* platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert 140996
cevans@google.com [Mon, 28 Jan 2013 21:15:32 +0000 (21:15 +0000)]
Revert 140996
> Revert 130950
> BUG=163593

TBR=cevans@google.com

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSS Shaders] Parse @-webkit-filter
mvujovic@adobe.com [Mon, 28 Jan 2013 21:14:42 +0000 (21:14 +0000)]
[CSS Shaders] Parse @-webkit-filter
https://bugs.webkit.org/show_bug.cgi?id=106837

Reviewed by Dean Jackson.

Source/WebCore:

The new CSS Custom Filters syntax includes an @filter rule:
@filter IDENT { <custom-filter-description> }

IDENT is the filter name. For example:
@filter my-filter { ... }

<custom-filter-description> is a set of CSS properties, which are still under discussion in
the CSSWG.

This patch adds parsing and JS bindings for the prefixed at-rule. It does not add parsing
for any of the at-rule's internal properties.

Spec: https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#the-atfilter-rule

Tests: css3/filters/custom/custom-filter-parsing-at-rule-invalid.html
       css3/filters/custom/custom-filter-parsing-at-rule-valid.html

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
* bindings/objc/DOMCSS.mm:
(kitClass):
* bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::wrap):
* css/CSSGrammar.y.in:
* css/CSSParser.cpp:
(WebCore::CSSParser::createFilterRule):
(WebCore::CSSParser::detectAtToken):
* css/CSSParser.h:
* css/CSSPropertySourceData.h:
* css/CSSRule.h:
* css/CSSRule.idl:
    Only contains a CSSStyleDeclaration "style" property, like the other at-rules that are
    supposed to contain properties (e.g. CSSStyleRule, CSSFontFaceRule, CSSPageRule).
    Eventually, when it's specified, we should expose the filter name as well.
    Other at-rules IDL Spec: http://www.w3.org/TR/DOM-Level-2-Style/idl-definitions.html
* css/StyleRule.cpp:
(WebCore::StyleRuleBase::reportMemoryUsage):
(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRuleBase::copy):
(WebCore::StyleRuleBase::createCSSOMWrapper):
(WebCore::StyleRuleFilter::StyleRuleFilter):
(WebCore::StyleRuleFilter::~StyleRuleFilter):
(WebCore::StyleRuleFilter::mutableProperties):
(WebCore::StyleRuleFilter::setProperties):
(WebCore::StyleRuleFilter::reportDescendantMemoryUsage):
* css/StyleRule.h:
(StyleRuleBase):
(WebCore::StyleRuleBase::isFilterRule):
(StyleRuleFilter):
(WebCore::StyleRuleFilter::create):
(WebCore::StyleRuleFilter::filterName):
(WebCore::StyleRuleFilter::properties):
(WebCore::StyleRuleFilter::copy):
* css/StyleSheetContents.cpp:
(WebCore::childRulesHaveFailedOrCanceledSubresources):
* css/WebKitCSSFilterRule.cpp: Added.
    WebKitCSSFilterRule is implemented similar to CSSFontFaceRule.
(WebCore::WebKitCSSFilterRule::WebKitCSSFilterRule):
(WebCore::WebKitCSSFilterRule::~WebKitCSSFilterRule):
(WebCore::WebKitCSSFilterRule::style):
(WebCore::WebKitCSSFilterRule::cssText):
    The CSS text implementation for WebKitCSSFilterRule is almost the same as
    CSSFontFaceRule. WebKitCSSFilterRule additionally needs to output the filter name in its
    syntax (e.g. @-webkit-filter my-filter { }).
(WebCore::WebKitCSSFilterRule::reattach):
(WebCore::WebKitCSSFilterRule::reportMemoryUsage):
* css/WebKitCSSFilterRule.h: Added.
(WebKitCSSFilterRule):
(WebCore::WebKitCSSFilterRule::create):
* css/WebKitCSSFilterRule.idl: Added.

LayoutTests:

Add positive and negative tests for parsing the @-webkit-filter rule.

Factored out common helper functions between the existing CSS Custom Filters parsing tests
and the new tests into custom-filter-parsing-common.js.

* css3/filters/custom/custom-filter-parsing-at-rule-invalid-expected.txt: Added.
* css3/filters/custom/custom-filter-parsing-at-rule-invalid.html: Added.
* css3/filters/custom/custom-filter-parsing-at-rule-valid-expected.txt: Added.
* css3/filters/custom/custom-filter-parsing-at-rule-valid.html: Added.
* css3/filters/custom/custom-filter-property-parsing-invalid.html:
* css3/filters/custom/custom-filter-property-parsing.html:
* css3/filters/script-tests/custom-filter-parsing-at-rule-invalid.js: Added.
(testInvalidFilterAtRule):
* css3/filters/script-tests/custom-filter-parsing-at-rule-valid.js: Added.
(testFilterAtRule):
    Tests @-webkit-filter rule parsing and its ability to hold CSS properties.
(testNestedRules):
    Tests nesting between at-rules, involving @-webkit-filter rules.
(checkRule):
    Factor out common rule checking functionality into its own helper function, so it can be
    reused.
* css3/filters/script-tests/custom-filter-parsing-common.js: Added.
(jsWrapperClass):
    Moved.
(shouldBeType):
    Moved.
* css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
* css3/filters/script-tests/custom-filter-property-parsing.js:
* platform/chromium/css3/filters/custom/custom-filter-parsing-at-rule-valid-expected.txt:
    V8 represents WebKitCSSFilterRule a little differently.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert 130950
cevans@google.com [Mon, 28 Jan 2013 21:13:44 +0000 (21:13 +0000)]
Revert 130950
BUG=163593

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd StorageStrategy member functions to WebKit2
andersca@apple.com [Mon, 28 Jan 2013 21:10:43 +0000 (21:10 +0000)]
Add StorageStrategy member functions to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=108105

Reviewed by Tim Horton.

Source/WebCore:

StorageStrategy::sessionStorageNamespace should be virtual, not static...

* WebCore.exp.in:
* storage/StorageStrategy.h:
(StorageStrategy):

Source/WebKit2:

Add default implementations that just chain up to the base class for now.

* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::localStorageNamespace):
(WebKit::WebPlatformStrategies::sessionStorageNamespace):
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Correct auto-zoom when using compositor scaling
wangxianzhu@chromium.org [Mon, 28 Jan 2013 21:08:20 +0000 (21:08 +0000)]
[Chromium] Correct auto-zoom when using compositor scaling
https://bugs.webkit.org/show_bug.cgi?id=107592

Reviewed by Adam Barth.

1. The scale of auto-zoom should exclude deviceScaleFactor because the compositor will handle the scaling;
2. Scroll location needs to be calculated differently when pageScaleFactor is handled by the compositor.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
* tests/WebFrameTest.cpp: Updated tests DivAutoZoomParamsTest, DivAutoZoomMultipleDivsTest, DivAutoZoomScaleBoundsTest and DivAutoZoomScaleFontScaleFactorTest, to make two versions of them (WebKitScaling and CompositorScaling).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogetComputedStyle returns "left" instead of "none" for "float" on abspos elements
commit-queue@webkit.org [Mon, 28 Jan 2013 20:43:33 +0000 (20:43 +0000)]
getComputedStyle returns "left" instead of "none" for "float" on abspos elements
https://bugs.webkit.org/show_bug.cgi?id=105836

Patch by Uday Kiran <udaykiran@motorola.com> on 2013-01-28
Reviewed by Tony Chang.

If 'position' has the value absolute, page or fixed, and the value of float is
left or right, the box is absolutely positioned and the computed value of float is none.
http://www.w3.org/TR/css3-positioning/#dis-pos-flo
This matches behavior of Firefox 18, Opera 12 and IE9.

Source/WebCore:

Test: fast/css/position-absolute-float.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

* fast/css/position-absolute-float-expected.txt: Added.
* fast/css/position-absolute-float.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't use threaded HTML parser for data: URLs
tonyg@chromium.org [Mon, 28 Jan 2013 20:36:12 +0000 (20:36 +0000)]
Don't use threaded HTML parser for data: URLs
https://bugs.webkit.org/show_bug.cgi?id=108096

Reviewed by Eric Seidel.

data: URLs are currently loaded synchronously. Using the main thread parser for them preserves this behavior.
This fixes fast/dom/HTMLDocument/document-open-return-value.html and probably others.

No new tests because covered by existing tests.

* html/parser/HTMLParserOptions.cpp:
(WebCore::HTMLParserOptions::HTMLParserOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Mon, 28 Jan 2013 20:26:15 +0000 (20:26 +0000)]
Unreviewed GTK gardening.

Adding a failure expectation for a User Timing test added in r140882.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Quit debug build without -DSHARED_CORE=ON
commit-queue@webkit.org [Mon, 28 Jan 2013 20:19:14 +0000 (20:19 +0000)]
[EFL] Quit debug build without -DSHARED_CORE=ON
https://bugs.webkit.org/show_bug.cgi?id=104773

Patch by Halton Huo <halton.huo@intel.com> on 2013-01-28
Reviewed by Laszlo Gombos.

Debug build without -DSHARED_CORE=ON will fail because libwebcore_efl.a
is too big (>4G) to archive. The solution is simply to abort cmake in
this condition and notify developer.

* CMakeLists.txt:
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsCommon.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCollapse OS(UNIX)||OS(ANDROID) to OS(UNIX)
commit-queue@webkit.org [Mon, 28 Jan 2013 20:13:51 +0000 (20:13 +0000)]
Collapse OS(UNIX)||OS(ANDROID) to OS(UNIX)
https://bugs.webkit.org/show_bug.cgi?id=108091

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-01-28
Reviewed by Adam Barth.

OS(UNIX) is defined when OS(ANDROID) is defined.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleMouseDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBUILD FIX: Platform.h:1212:22: error: '__MAC_OS_X_VERSION_MIN_REQUIRED' is not define...
ddkilzer@apple.com [Mon, 28 Jan 2013 19:56:41 +0000 (19:56 +0000)]
BUILD FIX: Platform.h:1212:22: error: '__MAC_OS_X_VERSION_MIN_REQUIRED' is not defined, evaluates to 0 [-Werror,-Wundef]

This fixes the following build error introduced in r140366 for
Bug 107098:

    Platform.h:1212:22: error: '__MAC_OS_X_VERSION_MIN_REQUIRED' is not defined, evaluates to 0 [-Werror,-Wundef]
    #if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080 && !PLATFORM(IOS)
                         ^
    1 error generated.

* wtf/Platform.h: Check !PLATFORM(IOS) first so that iOS builds
do not try to evaluate __MAC_OS_X_VERSION_MIN_REQUIRED.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMac rebaselines after r140192.
rniwa@webkit.org [Mon, 28 Jan 2013 19:38:26 +0000 (19:38 +0000)]
Mac rebaselines after r140192.

* fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Added.
* fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Added.
* fast/regions/overflow-size-change-with-stacking-context-expected.txt: Added.
* platform/chromium-mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Removed.
* platform/chromium-mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Removed.
* platform/chromium-mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Removed.
* platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Removed.
* platform/mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Removed.
* platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't use the threaded HTML parser for javascript: URLs
tonyg@chromium.org [Mon, 28 Jan 2013 19:35:41 +0000 (19:35 +0000)]
Don't use the threaded HTML parser for javascript: URLs
https://bugs.webkit.org/show_bug.cgi?id=107975

Reviewed by Adam Barth.

Several layout tests depend on javascript: URL iframes loading synchronously including fast/loader/javascript-url-encoding.html.
This patch avoids using the threaded parser for those URLs so they will continue to be synchronous.

No new tests because covered by existing tests.

* html/parser/HTMLParserOptions.cpp:
(WebCore::HTMLParserOptions::HTMLParserOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSVGPathStringSource should not up-convert 8-bit strings to UTF-16
weinig@apple.com [Mon, 28 Jan 2013 19:28:01 +0000 (19:28 +0000)]
SVGPathStringSource should not up-convert 8-bit strings to UTF-16
https://bugs.webkit.org/show_bug.cgi?id=108050

Reviewed by Anders Carlsson.

Should save around ~400k on Membuster3.

* svg/SVGParserUtilities.cpp:
(WebCore::parseNumber):
(WebCore::genericParseArcFlag):
(WebCore::parseArcFlag):
* svg/SVGParserUtilities.h:
Add LChar variants of parseNumber and parseArcFlag.

* svg/SVGPathSource.h:
(WebCore):
Move forward declaration of FloatPoint here, where it belongs.

* svg/SVGPathStringSource.cpp:
(WebCore::parseFloatPoint):
(WebCore::parseFloatPoint2):
(WebCore::parseFloatPoint3):
Add helpers for parsing float points.

(WebCore::SVGPathStringSource::SVGPathStringSource):
(WebCore::SVGPathStringSource::hasMoreData):
(WebCore::SVGPathStringSource::moveToNextToken):
(WebCore::parseSVGSegmentTypeHelper):
(WebCore::SVGPathStringSource::parseSVGSegmentType):
(WebCore::nextCommandHelper):
(WebCore::SVGPathStringSource::nextCommand):
(WebCore::SVGPathStringSource::parseMoveToSegment):
(WebCore::SVGPathStringSource::parseLineToSegment):
(WebCore::SVGPathStringSource::parseLineToHorizontalSegment):
(WebCore::SVGPathStringSource::parseLineToVerticalSegment):
(WebCore::SVGPathStringSource::parseCurveToCubicSegment):
(WebCore::SVGPathStringSource::parseCurveToCubicSmoothSegment):
(WebCore::SVGPathStringSource::parseCurveToQuadraticSegment):
(WebCore::SVGPathStringSource::parseCurveToQuadraticSmoothSegment):
(WebCore::parseArcToSegmentHelper):
(WebCore::SVGPathStringSource::parseArcToSegment):
* svg/SVGPathStringSource.h:
(SVGPathStringSource):
Make 8-bit aware.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRepaint issues in background tabs after r138858
simon.fraser@apple.com [Mon, 28 Jan 2013 19:24:57 +0000 (19:24 +0000)]
Repaint issues in background tabs after r138858
https://bugs.webkit.org/show_bug.cgi?id=108092
<rdar://problem/13076430>

Reviewed by Tim Horton.

In r138858, we unparented all tiles in the tile caches of background tabs.
That broke repaints in background tabs; when bringing that tab back to the
foreground, we would call -setNeedsDisplayInRect:, and then reparent the tiles
on a zero-delay timer. Those repaints would then be flipped (possibly because
CA can't look up the layer tree to check for flipped geometry).

Fix by revalidating tiles (which reparents the tiles) at the time we're told
we're moving into the window, which happens before repaints are flushed.

* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setIsInWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove webkitNotifications.createHTMLNotification
abarth@webkit.org [Mon, 28 Jan 2013 19:23:05 +0000 (19:23 +0000)]
Remove webkitNotifications.createHTMLNotification
https://bugs.webkit.org/show_bug.cgi?id=107598

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

As discussed in http://lists.webkit.org/pipermail/webkit-dev/2012-February/019354.html,
we've been slowly deprecating HTML notificiations for about a year.
FeatureObserver says that HTML notifications are used by 0.0008% of web
pages, which means we should be able to remove them without causing too
much trouble.

* Configurations/FeatureDefines.xcconfig:
* Modules/notifications/Notification.cpp:
(WebCore):
(WebCore::Notification::Notification):
* Modules/notifications/Notification.h:
(Notification):
* Modules/notifications/NotificationCenter.h:
(NotificationCenter):
* Modules/notifications/NotificationCenter.idl:

Source/WebKit/blackberry:

* WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/chromium:

We can remove these stubs once we've removed the Chromium-side code
that depends on them.

* src/WebNotification.cpp:
(WebKit::WebNotification::isHTML):
(WebKit::WebNotification::url):
(WebKit::WebNotification::iconURL):
(WebKit::WebNotification::title):
(WebKit::WebNotification::body):

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix non-fat builds by excluding PluginService.32 as a target dependency for WebKit2.
aestes@apple.com [Mon, 28 Jan 2013 19:21:58 +0000 (19:21 +0000)]
Fix non-fat builds by excluding PluginService.32 as a target dependency for WebKit2.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r139145): A couple of fast/workers tests fail
oliver@apple.com [Mon, 28 Jan 2013 19:19:49 +0000 (19:19 +0000)]
REGRESSION(r139145): A couple of fast/workers tests fail
https://bugs.webkit.org/show_bug.cgi?id=106415

These tests are stable now.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] SpellingHandler parses and creates spellcheck requests regardless of...
commit-queue@webkit.org [Mon, 28 Jan 2013 19:15:18 +0000 (19:15 +0000)]
[BlackBerry] SpellingHandler parses and creates spellcheck requests regardless of the system spell check status
https://bugs.webkit.org/show_bug.cgi?id=108085

Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-01-28
Reviewed by Rob Buis.

Fix a merge error that duplicated a function declaration in InputHandler.h.

* WebKitSupport/InputHandler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] remove temporary define used for updating TestRunner API
jochen@chromium.org [Mon, 28 Jan 2013 19:09:38 +0000 (19:09 +0000)]
[chromium] remove temporary define used for updating TestRunner API

Unreviewed. Clean-up change.

* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSS Exclusions] Refactor ExclusionShapeInsideInfo to more general ExclusionShapeInfo
commit-queue@webkit.org [Mon, 28 Jan 2013 18:36:28 +0000 (18:36 +0000)]
[CSS Exclusions] Refactor ExclusionShapeInsideInfo to more general ExclusionShapeInfo
https://bugs.webkit.org/show_bug.cgi?id=100766

Patch by Bear Travis <betravis@adobe.com> on 2013-01-28
Reviewed by Dirk Schulze.

Refactoring, covered by existing tests.

Factoring out code common to ExclusionShapeInsideInfo and ExclusionShapeOutsideInfo
into common classes in ExclusionShapeInfo.h. Since the ExclusionShapeInsideInfo and
ExclusionShapeOutsideInfo share almost all of their code, save the RenderObject type
they work with and the specific shapeInside/Outside methods they call on RenderStyle
and ExclusionShape, the code has been templated. The code responsible for maintaining
global maps has also been factored out into a MappedInfo class.

* CMakeLists.txt: Adding ExclusionShapeInfo files.
* GNUmakefile.list.am: Ditto.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* rendering/ExclusionShapeInfo.cpp: Added.
(WebCore::::computedShape): Determine the shape based on the current logical
dimensions. Call this method rather than accessing m_shape directly.
* rendering/ExclusionShapeInfo.h: Added.
(MappedInfo): Helper class that maintains a global info map.
(WebCore::MappedInfo::ensureInfo): Look up the info for a key and add it if not present.
(WebCore::MappedInfo::removeInfo): Remove the info associated with a key.
(WebCore::MappedInfo::info): Look up the info associated with a key.
(WebCore::MappedInfo::infoMap): The map used to store key/info pairs.
(ExclusionShapeInfo): A common parent class for ExclusionShapeInside/OutsideInfos.
The methods were factored out of the code common to ExclusionShapeInside/OutsideInfo.
(WebCore::ExclusionShapeInfo::~ExclusionShapeInfo): Destructor.
(WebCore::ExclusionShapeInfo::setShapeSize): Sets the shape's logical size.
(WebCore::ExclusionShapeInfo::shapeLogicalTop/Bottom/Left/Right/Width/Height):
Returns the shape's logical dimensions.
(WebCore::ExclusionShapeInfo::dirtyShapeSize): Mark the shape for recomputation.
(WebCore::ExclusionShapeInfo::owner): The renderer to which this info belongs.
(WebCore::ExclusionShapeInfo::ExclusionShapeInfo): Constructor.
(WebCore::ExclusionShapeInfo::floatLogicalTopToLayoutUnit/floatLogicalBottomToLayoutUnit):
Helper methods that round float units from ExclusionShapes to LayoutUnits for layout.
* rendering/ExclusionShapeInsideInfo.cpp:
(WebCore::ExclusionShapeInsideInfo::computeSegmentsForLine): Modified to use
computedShape() rather than m_shape.
(WebCore::ExclusionShapeInsideInfo::adjustLogicalLineTop): Ditto.
* rendering/ExclusionShapeInsideInfo.h:
(WebCore::ExclusionShapeInsideInfo::createInfo): Renamed to match MappedInfo.
(WebCore::ExclusionShapeInsideInfo::isEnabledFor): Renamed to match shorter naming.
(WebCore::ExclusionShapeInsideInfo::lineOverlapsShapeBounds): Modified to use
computedShape().
* rendering/ExclusionShapeOutsideInfo.cpp:
(WebCore::ExclusionShapeOutsideInfo::isEnabledFor): Renamed to match shorter naming.
* rendering/ExclusionShapeOutsideInfo.h:
(WebCore::ExclusionShapeOutsideInfo::createInfo): Renamed to match MappedInfo.
(WebCore::ExclusionShapeOutsideInfo::ExclusionShapeOutsideInfo): Constructor.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::willBeDestroyed): Use shortened MappedInfo names for looking
up infos.
(WebCore::RenderBlock::exclusionShapeInsideInfo): Ditto.
(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange): Ditto.
(WebCore::RenderBlock::computeExclusionShapeSize): Ditto.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::willBeDestroyed): Ditto.
(WebCore::RenderBox::updateExclusionShapeOutsideInfoAfterStyleChange): Ditto.
* rendering/RenderBox.h:
(WebCore):
(WebCore::RenderBox::exclusionShapeOutsideInfo): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
kadam@inf.u-szeged.hu [Mon, 28 Jan 2013 18:33:03 +0000 (18:33 +0000)]
[Qt] Unreviewed gardening.

Correcting rebaseline done in r140959.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-01-28

* platform/qt-5.0-wk1/compositing/absolute-inside-out-of-view-fixed-expected.txt: Renamed from LayoutTests/platform/qt/compositing/absolute-inside-out-of-view-fixed-expected.txt.
* platform/qt-5.0-wk1/compositing/backing/no-backing-for-clip-overlap-expected.txt: Copied from LayoutTests/platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt.
* platform/qt-5.0-wk1/compositing/bounds-in-flipped-writing-mode-expected.txt: Renamed from LayoutTests/platform/qt/compositing/bounds-in-flipped-writing-mode-expected.txt.
* platform/qt-5.0-wk1/compositing/clip-child-by-non-stacking-ancestor-expected.txt: Renamed from LayoutTests/platform/qt/compositing/clip-child-by-non-stacking-ancestor-expected.txt.
* platform/qt-5.0-wk1/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt: Renamed from LayoutTests/platform/qt/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt.
* platform/qt-5.0-wk1/compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt: Renamed from LayoutTests/platform/qt/compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt.
* platform/qt-5.0-wk1/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt: Renamed from LayoutTests/platform/qt/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt.
* platform/qt-5.0-wk1/compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt: Renamed from LayoutTests/platform/qt/compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt.
* platform/qt-5.0-wk1/compositing/geometry/bounds-clipped-composited-child-expected.png: Renamed from LayoutTests/platform/qt/compositing/geometry/bounds-clipped-composited-child-expected.png.
* platform/qt-5.0-wk1/compositing/geometry/bounds-clipped-composited-child-expected.txt: Renamed from LayoutTests/platform/qt/compositing/geometry/bounds-clipped-composited-child-expected.txt.
* platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-dynamic-expected.png: Renamed from LayoutTests/platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-expected.png.
* platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt: Renamed from LayoutTests/platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt.
* platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Copied from LayoutTests/platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png.
* platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Renamed from LayoutTests/platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt.
* platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-expected.txt: Renamed from LayoutTests/platform/qt/compositing/geometry/bounds-ignores-hidden-expected.txt.
* platform/qt-5.0-wk1/compositing/geometry/clip-expected.txt: Renamed from LayoutTests/platform/qt/compositing/geometry/clip-expected.txt.
* platform/qt-5.0-wk1/compositing/geometry/clip-inside-expected.txt: Renamed from LayoutTests/platform/qt/compositing/geometry/clip-inside-expected.txt.
* platform/qt-5.0-wk1/compositing/geometry/composited-in-columns-expected.png: Renamed from LayoutTests/platform/qt/compositing/geometry/composited-in-columns-expected.png.
* platform/qt-5.0-wk1/compositing/geometry/composited-in-columns-expected.txt: Renamed from LayoutTests/platform/qt/compositing/geometry/composited-in-columns-expected.txt.
* platform/qt-5.0-wk1/compositing/geometry/flipped-writing-mode-expected.png: Renamed from LayoutTests/platform/qt/compositing/geometry/flipped-writing-mode-expected.png.
* platform/qt-5.0-wk1/compositing/geometry/flipped-writing-mode-expected.txt: Renamed from LayoutTests/platform/qt/compositing/geometry/flipped-writing-mode-expected.txt.
* platform/qt-5.0-wk1/compositing/geometry/foreground-layer-expected.png: Renamed from LayoutTests/platform/qt/compositing/geometry/foreground-layer-expected.png.
* platform/qt-5.0-wk1/compositing/geometry/foreground-layer-expected.txt: Renamed from LayoutTests/platform/qt/compositing/geometry/foreground-layer-expected.txt.
* platform/qt-5.0-wk1/compositing/geometry/preserve-3d-switching-expected.txt: Copied from LayoutTests/platform/qt/compositing/geometry/preserve-3d-switching-expected.txt.
* platform/qt-5.0-wk1/compositing/iframes/become-composited-nested-iframes-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/become-composited-nested-iframes-expected.txt.
* platform/qt-5.0-wk1/compositing/iframes/become-overlapped-iframe-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/become-overlapped-iframe-expected.txt.
* platform/qt-5.0-wk1/compositing/iframes/composited-parent-iframe-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/composited-parent-iframe-expected.txt.
* platform/qt-5.0-wk1/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/connect-compositing-iframe-delayed-expected.txt.
* platform/qt-5.0-wk1/compositing/iframes/connect-compositing-iframe-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/connect-compositing-iframe-expected.txt.
* platform/qt-5.0-wk1/compositing/iframes/connect-compositing-iframe2-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/connect-compositing-iframe2-expected.txt.
* platform/qt-5.0-wk1/compositing/iframes/connect-compositing-iframe3-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/connect-compositing-iframe3-expected.txt.
* platform/qt-5.0-wk1/compositing/iframes/enter-compositing-iframe-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/enter-compositing-iframe-expected.txt.
* platform/qt-5.0-wk1/compositing/iframes/iframe-resize-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/iframe-resize-expected.txt.
* platform/qt-5.0-wk1/compositing/iframes/overlapped-iframe-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/overlapped-iframe-expected.txt.
* platform/qt-5.0-wk1/compositing/iframes/overlapped-iframe-iframe-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/overlapped-iframe-iframe-expected.txt.
* platform/qt-5.0-wk1/compositing/iframes/overlapped-nested-iframes-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/overlapped-nested-iframes-expected.txt.
* platform/qt-5.0-wk1/compositing/iframes/scrolling-iframe-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/scrolling-iframe-expected.txt.
* platform/qt-5.0-wk1/compositing/images/clip-on-directly-composited-image-expected.txt: Renamed from LayoutTests/platform/qt/compositing/images/clip-on-directly-composited-image-expected.txt.
* platform/qt-5.0-wk1/compositing/layer-creation/animation-overlap-with-children-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/animation-overlap-with-children-expected.txt.
* platform/qt-5.0-wk1/compositing/layer-creation/fixed-position-out-of-view-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/fixed-position-out-of-view-expected.txt.
* platform/qt-5.0-wk1/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-expected.txt.
* platform/qt-5.0-wk1/compositing/layer-creation/fixed-position-under-transform-expected.png: Renamed from LayoutTests/platform/qt/compositing/layer-creation/fixed-position-under-transform-expected.png.
* platform/qt-5.0-wk1/compositing/layer-creation/fixed-position-under-transform-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/fixed-position-under-transform-expected.txt.
* platform/qt-5.0-wk1/compositing/layer-creation/no-compositing-for-fixed-position-under-transform-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/no-compositing-for-fixed-position-under-transform-expected.txt.
* platform/qt-5.0-wk1/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/overflow-scroll-overlap-expected.txt.
* platform/qt-5.0-wk1/compositing/layer-creation/overlap-animation-clipping-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/overlap-animation-clipping-expected.txt.
* platform/qt-5.0-wk1/compositing/layer-creation/overlap-animation-container-expected.txt: Copied from LayoutTests/platform/qt/compositing/layer-creation/overlap-animation-container-expected.txt.
* platform/qt-5.0-wk1/compositing/layer-creation/overlap-child-layer-expected.png: Renamed from LayoutTests/platform/qt/compositing/layer-creation/overlap-child-layer-expected.png.
* platform/qt-5.0-wk1/compositing/layer-creation/overlap-child-layer-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/overlap-child-layer-expected.txt.
* platform/qt-5.0-wk1/compositing/layer-creation/overlap-transformed-layer-expected.png: Renamed from LayoutTests/platform/qt/compositing/layer-creation/overlap-transformed-layer-expected.png.
* platform/qt-5.0-wk1/compositing/layer-creation/overlap-transformed-layer-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/overlap-transformed-layer-expected.txt.
* platform/qt-5.0-wk1/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt.
* platform/qt-5.0-wk1/compositing/layer-creation/rotate3d-overlap-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/rotate3d-overlap-expected.txt.
* platform/qt-5.0-wk1/compositing/layer-creation/stacking-context-overlap-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/stacking-context-overlap-expected.txt.
* platform/qt-5.0-wk1/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/stacking-context-overlap-nested-expected.txt.
* platform/qt-5.0-wk1/compositing/masks/mask-layer-size-expected.txt: Renamed from LayoutTests/platform/qt/compositing/masks/mask-layer-size-expected.txt.
* platform/qt-5.0-wk1/compositing/repaint/resize-repaint-expected.txt: Renamed from LayoutTests/platform/qt/compositing/repaint/resize-repaint-expected.txt.
* platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-expected.png: Renamed from LayoutTests/platform/qt/compositing/rtl/rtl-iframe-absolute-expected.png.
* platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-expected.txt: Renamed from LayoutTests/platform/qt/compositing/rtl/rtl-iframe-absolute-expected.txt.
* platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-expected.png: Renamed from LayoutTests/platform/qt/compositing/rtl/rtl-iframe-fixed-expected.png.
* platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-expected.txt: Renamed from LayoutTests/platform/qt/compositing/rtl/rtl-iframe-fixed-expected.txt.
* platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-relative-expected.png: Renamed from LayoutTests/platform/qt/compositing/rtl/rtl-iframe-relative-expected.png.
* platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-relative-expected.txt: Renamed from LayoutTests/platform/qt/compositing/rtl/rtl-iframe-relative-expected.txt.
* platform/qt-5.0-wk1/compositing/tiling/backface-preserve-3d-tiled-expected.png: Renamed from LayoutTests/platform/qt/compositing/tiling/backface-preserve-3d-tiled-expected.png.
* platform/qt-5.0-wk1/compositing/tiling/backface-preserve-3d-tiled-expected.txt: Renamed from LayoutTests/platform/qt/compositing/tiling/backface-preserve-3d-tiled-expected.txt.
* platform/qt-5.0-wk1/compositing/tiling/huge-layer-img-expected.png: Renamed from LayoutTests/platform/qt/compositing/tiling/huge-layer-img-expected.png.
* platform/qt-5.0-wk1/compositing/tiling/huge-layer-img-expected.txt: Renamed from LayoutTests/platform/qt/compositing/tiling/huge-layer-img-expected.txt.
* platform/qt-5.0-wk1/compositing/tiling/rotated-tiled-clamped-expected.png: Renamed from LayoutTests/platform/qt/compositing/tiling/rotated-tiled-clamped-expected.png.
* platform/qt-5.0-wk1/compositing/tiling/rotated-tiled-clamped-expected.txt: Renamed from LayoutTests/platform/qt/compositing/tiling/rotated-tiled-clamped-expected.txt.
* platform/qt-5.0-wk1/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.png: Renamed from LayoutTests/platform/qt/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.png.
* platform/qt-5.0-wk1/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt: Renamed from LayoutTests/platform/qt/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt.
* platform/qt-5.0-wk1/compositing/tiling/tiled-layer-resize-expected.txt: Renamed from LayoutTests/platform/qt/compositing/tiling/tiled-layer-resize-expected.txt.
* platform/qt-5.0-wk1/compositing/visibility/layer-visible-content-expected.png: Renamed from LayoutTests/platform/qt/compositing/visibility/layer-visible-content-expected.png.
* platform/qt-5.0-wk1/compositing/visibility/layer-visible-content-expected.txt: Renamed from LayoutTests/platform/qt/compositing/visibility/layer-visible-content-expected.txt.
* platform/qt-5.0-wk1/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Renamed from LayoutTests/platform/qt/compositing/visibility/visibility-image-layers-dynamic-expected.txt.
* platform/qt-5.0-wk1/css3/filters/composited-during-transition-layertree-expected.txt: Copied from LayoutTests/platform/qt/css3/filters/composited-during-transition-layertree-expected.txt.
* platform/qt-5.0-wk1/css3/filters/filtered-compositing-descendant-expected.png: Renamed from LayoutTests/platform/qt/css3/filters/filtered-compositing-descendant-expected.png.
* platform/qt-5.0-wk1/css3/filters/filtered-compositing-descendant-expected.txt: Renamed from LayoutTests/platform/qt/css3/filters/filtered-compositing-descendant-expected.txt.
* platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt:
* platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png:
* platform/qt/compositing/geometry/preserve-3d-switching-expected.txt:
* platform/qt/compositing/layer-creation/overlap-animation-container-expected.txt:
* platform/qt/css3/filters/composited-during-transition-layertree-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCleanup ARM version of debugName() in DFGFPRInfo.h
msaboff@apple.com [Mon, 28 Jan 2013 18:27:06 +0000 (18:27 +0000)]
Cleanup ARM version of debugName() in DFGFPRInfo.h
https://bugs.webkit.org/show_bug.cgi?id=108090

Reviewed by David Kilzer.

Fixed debugName() so it will compile by adding static_cast<int> and missing commas.

* dfg/DFGFPRInfo.h:
(JSC::DFG::FPRInfo::debugName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSVGViewSpec fails when corresponding element has been removed
schenney@chromium.org [Mon, 28 Jan 2013 17:45:45 +0000 (17:45 +0000)]
SVGViewSpec fails when corresponding element has been removed
https://bugs.webkit.org/show_bug.cgi?id=106957

Reviewed by Dirk Schulze.

Source/WebCore:

When JS holds an SVGViewSpec object while deleting the object that
defines the spec (an SVGSVGElement, or one of a few others) the
pointer to the target is cleared in the SVGViewSpec but the methods
that serve JS queries do not check and try to access the now null
target. This patch fixes the prooblem, returning null when the
corresponding object has been deleted.

Also removing SVGViewSpec::setPreserveAspectRatioString, which is no
longer used by any callers.

Test: svg/dom/SVGViewSpec-invalid-ref-crash.html

* svg/SVGViewSpec.cpp:
(WebCore):
(WebCore::SVGViewSpec::viewTarget): Check for null target and return null.
(WebCore::SVGViewSpec::transform): Check for null target and return null..
(WebCore::SVGViewSpec::viewBoxAnimated): Check for null target and return null.
(WebCore::SVGViewSpec::preserveAspectRatioAnimated): Check for null target and return null.
(WebCore::SVGViewSpec::lookupOrCreateViewBoxWrapper): ASSERT non-null target.
(WebCore::SVGViewSpec::lookupOrCreatePreserveAspectRatioWrapper): ASSERT non-null target.
(WebCore::SVGViewSpec::lookupOrCreateTransformWrapper): ASSERT non-null target.
* svg/SVGViewSpec.h:
(SVGViewSpec): Move some methods out of the header and into the implementation file.

* svg/SVGViewSpec.cpp:
(WebCore):
(WebCore::SVGViewSpec::transform):
(WebCore::SVGViewSpec::viewBoxAnimated):
(WebCore::SVGViewSpec::preserveAspectRatioAnimated):
(WebCore::SVGViewSpec::lookupOrCreateViewBoxWrapper):
(WebCore::SVGViewSpec::lookupOrCreatePreserveAspectRatioWrapper):
(WebCore::SVGViewSpec::lookupOrCreateTransformWrapper):
* svg/SVGViewSpec.h:
(SVGViewSpec):

LayoutTests:

Test for the situation in which the target of an SVGViewSpec is
removed while the view spec lives on in JS. The test is expected to
fail on all JSC based platforms because the element that must be
deleted to trigger the results is not deleted upon GC.

* svg/dom/SVGViewSpec-invalid-ref-crash-expected.txt: Added.
* svg/dom/SVGViewSpec-invalid-ref-crash.html: Added.

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* svg/dom/SVGViewSpec-invalid-ref-crash-expected.txt: Added.
* svg/dom/SVGViewSpec-invalid-ref-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHTML5 promotes DL from specific 'definition list' to superset 'description list'...
commit-queue@webkit.org [Mon, 28 Jan 2013 17:05:59 +0000 (17:05 +0000)]
HTML5 promotes DL from specific 'definition list' to superset 'description list'; accessibility strings and accessors should be updated to match.
https://bugs.webkit.org/show_bug.cgi?id=107650

Source/WebCore:

Patch by James Craig <james@cookiecrook.com> on 2013-01-28
Reviewed by Chris Fleizach.

Updating accessibility strings and accessors for DL/DT/DD; new one for [role="definition"] (previously it reused the role/desc for DD).

Test: platform/mac/accessibility/definition-list-term.html:
Test: accessibility/lists.html

* English.lproj/Localizable.strings:
* accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::isDescriptionList):
* accessibility/AccessibilityList.h:
(AccessibilityList):
* accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):
* platform/LocalizedStrings.cpp:
(WebCore::AXDefinitionText):
(WebCore::AXDescriptionListTermText):
(WebCore):
(WebCore::AXDescriptionListDetailText):
* platform/LocalizedStrings.h:
(WebCore):
* platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::AXDefinitionText):
(WebCore::AXDescriptionListDetailText):
(WebCore):
(WebCore::AXDescriptionListTermText):
* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::AXDefinitionText):
(WebCore):
(WebCore::AXDescriptionListTermText):
(WebCore::AXDescriptionListDetailText):
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::AXDefinitionText):
(WebCore):
(WebCore::AXDescriptionListTermText):
(WebCore::AXDescriptionListDetailText):
* platform/qt/LocalizedStringsQt.cpp:
(WebCore::AXDefinitionText):
(WebCore::AXDescriptionListTermText):
(WebCore):
(WebCore::AXDescriptionListDetailText):

Source/WebKit/chromium:

Patch by James Craig <james@cookiecrook.com> on 2013-01-28
Reviewed by Chris Fleizach.

Updating accessibility strings and accessors for DL/DT/DD; new one for [role="definition"] (previously it reused the role/desc for DD).

* public/WebAccessibilityRole.h:
* src/AssertMatchingEnums.cpp:
* src/LocalizedStrings.cpp:
(WebCore::AXDefinitionText):
(WebCore):
(WebCore::AXDescriptionListTermText):
(WebCore::AXDescriptionListDetailText):

Tools:

Patch by James Craig <james@cookiecrook.com> on 2013-01-28
Reviewed by Chris Fleizach.

Updating accessibility strings and accessors for DL/DT/DD.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js:
(createDescriptionList):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:

LayoutTests:

Patch by James Craig <james@cookiecrook.com> on 2013-01-28
Reviewed by Chris Fleizach.

Updating accessibility strings and accessors for DL/DT/DD; new one for [role="definition"] (previously it reused the role/desc for DD).
Removed gtk expectation as the expectation has changed: platform/gtk/accessibility/lists-expected.txt

* accessibility/lists.html:
* platform/gtk/accessibility/lists-expected.txt: Removed.
* platform/mac/accessibility/definition-list-term-expected.txt:
* platform/mac/accessibility/definition-list-term.html:
* platform/mac/accessibility/lists-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] SpellingHandler parses and creates spellcheck requests regardless of...
commit-queue@webkit.org [Mon, 28 Jan 2013 16:59:07 +0000 (16:59 +0000)]
[BlackBerry] SpellingHandler parses and creates spellcheck requests regardless of the system spell check status
https://bugs.webkit.org/show_bug.cgi?id=108085
PR 286165

Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-01-28
Reviewed by Rob Buis.
Internally reviewed by Nima Ghanavatian.

Adding a check for the system spell check status in InputHandler::shouldSpellCheckElement so
we won't bother sending a spellcheck request if system spell check is turned off.

However, on a fresh browser start up and on the first setElementFocus, the spellcheck value isn't defined yet.
The first spell check request is therefore necessary to connect to imf to determine whether spell check is turned on.
If spell check is turned off, we will turn spellinghandler off.

Tested the patch using a test site that contains editable text in text-areas and content-editable divs. Also tested on
an extreme test case where we try to edit a content-editable div with 30000 characters. Confirmed spell-check requests are
being canceled if system spell check is off.

In theory, this patch should also fix PR 284229 . However, because of issues with getting the system spell check values from IMF,
additional work needs to be done for that PR.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setSpellCheckingEnabled):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::shouldSpellCheckElement):
(WebKit):
(BlackBerry::WebKit::InputHandler::stopPendingSpellCheckRequests):
* WebKitSupport/InputHandler.h:
(InputHandler):
(BlackBerry::WebKit::InputHandler::setSystemSpellCheckStatus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Added platform specific expectations after r140728.
kadam@inf.u-szeged.hu [Mon, 28 Jan 2013 16:58:19 +0000 (16:58 +0000)]
[Qt] Unreviewed gardening. Added platform specific expectations after r140728.

* platform/qt/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
* platform/qt/svg/custom/glyph-setting-d-attribute-expected.png:
* platform/qt/svg/custom/glyph-setting-d-attribute-expected.txt: Added.
* platform/qt/svg/foreignObject/text-tref-02-b-expected.png:
* platform/qt/svg/foreignObject/text-tref-02-b-expected.txt: Added.
* platform/qt/svg/hixie/viewbox/002-expected.png:
* platform/qt/svg/hixie/viewbox/002-expected.txt: Added.
* platform/qt/svg/hixie/viewbox/003-expected.png:
* platform/qt/svg/hixie/viewbox/003-expected.txt: Added.
* platform/qt/svg/text/text-viewbox-rescale-expected.png:
* platform/qt/svg/text/text-viewbox-rescale-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed build fix, missing include in AssertMatchingEnums.cpp
mkwst@chromium.org [Mon, 28 Jan 2013 16:54:57 +0000 (16:54 +0000)]
[chromium] Unreviewed build fix, missing include in AssertMatchingEnums.cpp
https://bugs.webkit.org/show_bug.cgi?id=108086

Disabling SVG exposed a missing include in AssertMatchingEnums. This
patch adds it in.

* src/AssertMatchingEnums.cpp:
    Include 'ResourceLoadPriority.h'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTools: [GTK][WTR] Update layoutTestController.pathToLocalResource
commit-queue@webkit.org [Mon, 28 Jan 2013 16:44:25 +0000 (16:44 +0000)]
Tools: [GTK][WTR] Update layoutTestController.pathToLocalResource
https://bugs.webkit.org/show_bug.cgi?id=107538

Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-01-28
Reviewed by Martin Robinson.

* WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
(WTR::TestRunner::pathToLocalResource): Update implementation based on
DRT code.

LayoutTests: [GTK] [WTR] layoutTestController.pathToLocalResource needs to be updated
https://bugs.webkit.org/show_bug.cgi?id=107538

Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-01-28
Reviewed by Martin Robinson.

* platform/gtk-wk2/TestExpectations: Remove tests that pass now:
http/tests/security/local-user-CSS-from-remote.html,
fast/loader/local-CSS-from-local.html,
fast/loader/local-JavaScript-from-local.html,
fast/loader/local-image-from-local.html and
fast/dom/frame-loading-via-document-write.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK][WTR] Move getTopLevelPath() to utilities file
commit-queue@webkit.org [Mon, 28 Jan 2013 16:28:10 +0000 (16:28 +0000)]
[GTK][WTR] Move getTopLevelPath() to utilities file
https://bugs.webkit.org/show_bug.cgi?id=107541

Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-01-28
Reviewed by Martin Robinson.

* WebKitTestRunner/GNUmakefile.am: Add new files.
* WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::getOutputDir): Uses the moved method from InjectedBundleUtilities.
* WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp: Added.
(WTR):
(WTR::topLevelPath): Implementation moved from ActivateFontsGtk.
* WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h: Added.
(WTR): Add new method header and documentation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Inherit SidebarPane from View.
commit-queue@webkit.org [Mon, 28 Jan 2013 16:14:26 +0000 (16:14 +0000)]
Web Inspector: Inherit SidebarPane from View.
https://bugs.webkit.org/show_bug.cgi?id=108075

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-01-28
Reviewed by Pavel Feldman.

Inherited WebInspector.SidebarPane from WebInspector.View to streamlines the code and
simplify further enhancements to sidebar panes. Got rid of obsolete onattach calls.

No new tests.

* inspector/front-end/AuditResultView.js:
(WebInspector.AuditResultView):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.wasShown):
(WebInspector.ElementsPanel.prototype.willHide):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onCreateSidebarPane):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.wasShown):
* inspector/front-end/SidebarPane.js:
(WebInspector.SidebarPane):
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSidebarPane.prototype._refreshExpressionsIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Freetype] Synthetic bold not applied to fallback fonts properly
commit-queue@webkit.org [Mon, 28 Jan 2013 15:34:59 +0000 (15:34 +0000)]
[Freetype] Synthetic bold not applied to fallback fonts properly
https://bugs.webkit.org/show_bug.cgi?id=107733

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-01-28
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

No new tests. This is covered by existing pixel tests.

* platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::FontPlatformData): When we detect a situation in which
we are a bold font, but the Fontconfig pattern does not describe the font as
bold, we should activate synthetic bolding.

LayoutTests:

* platform/gtk/fast/css/font-face-multiple-faces-expected.png:
* platform/gtk/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
* platform/gtk/fast/dom/34176-expected.png: Added.
* platform/gtk/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
* platform/gtk/fast/text/bidi-embedding-pop-and-push-same-expected.png:
* platform/gtk/fast/text/cg-fallback-bolding-expected.png:
* platform/gtk/fast/text/fallback-traits-fixup-expected.png:
* platform/gtk/fast/text/international/bidi-LDB-2-CSS-expected.png:
* platform/gtk/fast/text/international/bidi-LDB-2-HTML-expected.png:
* platform/gtk/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
* platform/gtk/fast/text/international/bold-bengali-expected.png:
* platform/gtk/fast/text/international/khmer-selection-expected.png:
* platform/gtk/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Regression] Search all sources should not search across service projects.
vsevik@chromium.org [Mon, 28 Jan 2013 12:47:43 +0000 (12:47 +0000)]
Web Inspector: [Regression] Search all sources should not search across service projects.
https://bugs.webkit.org/show_bug.cgi?id=108068

Reviewed by Pavel Feldman.

* inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchScope):
(WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: SourceURL and SourceMappingURL together in evalled code
pfeldman@chromium.org [Mon, 28 Jan 2013 12:45:24 +0000 (12:45 +0000)]
Web Inspector: SourceURL and SourceMappingURL together in evalled code
https://bugs.webkit.org/show_bug.cgi?id=107939

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Resolve map's sources URLs wrt script URL in case sourceMap is defined as data:.

* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.loadSourceMapForScript):
* inspector/front-end/ParsedURL.js:
(WebInspector.ParsedURL.completeURL):
* inspector/front-end/SourceMap.js:
(WebInspector.SourceMap.prototype._parseMap):

LayoutTests:

* http/tests/inspector/compiler-script-mapping-expected.txt:
* http/tests/inspector/compiler-script-mapping.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Win][WK2] Build fix after r140957.
reni@webkit.org [Mon, 28 Jan 2013 12:22:14 +0000 (12:22 +0000)]
[Qt][Win][WK2] Build fix after r140957.

Rubber-stamped by Csaba Osztrogonác.

<sys/wait.h> is only needed and available on linux therefore it's moved into an ifdef block.

* WebProcess/qt/WebProcessMainQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Canvas] refactoring in CanvasAgent to reduce code dups
aandrey@chromium.org [Mon, 28 Jan 2013 12:01:24 +0000 (12:01 +0000)]
Web Inspector: [Canvas] refactoring in CanvasAgent to reduce code dups
https://bugs.webkit.org/show_bug.cgi?id=108064

Reviewed by Pavel Feldman.

Introduce private methods injectedScriptCanvasModule() in InspectorCanvasAgent to reduce much of code duplication.
Drive-by: in InspectorPageAgent.assertFrame convert "String" argument to "const String&".
* inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::dropTraceLog):
(WebCore::InspectorCanvasAgent::captureFrame):
(WebCore::InspectorCanvasAgent::startCapturing):
(WebCore::InspectorCanvasAgent::stopCapturing):
(WebCore::InspectorCanvasAgent::getTraceLog):
(WebCore::InspectorCanvasAgent::replayTraceLog):
(WebCore::InspectorCanvasAgent::getResourceInfo):
(WebCore::InspectorCanvasAgent::getResourceState):
(WebCore::InspectorCanvasAgent::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore::InspectorCanvasAgent::wrapWebGLRenderingContextForInstrumentation):
(WebCore::InspectorCanvasAgent::injectedScriptCanvasModule):
(WebCore):
(WebCore::InspectorCanvasAgent::findFramesWithUninstrumentedCanvases):
* inspector/InspectorCanvasAgent.h:
(InspectorCanvasAgent):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::assertFrame):
(WebCore::InspectorPageAgent::assertDocumentLoader):
* inspector/InspectorPageAgent.h:
(InspectorPageAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Use C API inside ewk_url_response
kenneth@webkit.org [Mon, 28 Jan 2013 10:31:53 +0000 (10:31 +0000)]
[EFL][WK2] Use C API inside ewk_url_response
https://bugs.webkit.org/show_bug.cgi?id=107826

Reviewed by Andreas Kling.

* Shared/API/c/WKURLResponse.cpp:
(WKURLResponseGetExpectedContentsLength):
* Shared/API/c/WKURLResponse.h:

    Add new WK2 C API to get the expected contents length.

* UIProcess/API/efl/ewk_url_response.cpp:
(EwkUrlResponse::EwkUrlResponse):
(EwkUrlResponse::httpStatusCode):
(EwkUrlResponse::contentLength):
* UIProcess/API/efl/ewk_url_response_private.h:
(EwkUrlResponse::create):
(EwkUrlResponse):

    Change the methods to not call WebCore methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2][EFL] Remove unneeded private methods
kenneth@webkit.org [Mon, 28 Jan 2013 10:27:46 +0000 (10:27 +0000)]
[WK2][EFL] Remove unneeded private methods
https://bugs.webkit.org/show_bug.cgi?id=107693

Reviewed by Andreas Kling.

Care has been taken to verify that the wrappers can
never be null when called.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::displayTimerFired):
(EwkViewImpl::createGLSurface):
* UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReplace the type of Proximity's supplementName for char*
kihong.kwon@samsung.com [Mon, 28 Jan 2013 10:25:32 +0000 (10:25 +0000)]
Replace the type of Proximity's supplementName for char*
https://bugs.webkit.org/show_bug.cgi?id=108049

Reviewed by Benjamin Poulain.

There are some changes for supplementName by Bug 107535.
It makes build break when PROXIMITY_EVENT feature is enabled.
Therefore ProximityController need to change the type of supplementName for char* also.

No new tests. Functionality is not changed.

* Modules/proximity/DeviceProximityController.cpp:
(WebCore::DeviceProximityController::supplementName):
* Modules/proximity/DeviceProximityController.h:
(DeviceProximityController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed rebaseline after r140821.
kadam@inf.u-szeged.hu [Mon, 28 Jan 2013 10:25:13 +0000 (10:25 +0000)]
[Qt] Unreviewed rebaseline after r140821.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-01-28

* platform/qt/compositing/absolute-inside-out-of-view-fixed-expected.txt: Added.
* platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt:
* platform/qt/compositing/bounds-in-flipped-writing-mode-expected.txt: Added.
* platform/qt/compositing/clip-child-by-non-stacking-ancestor-expected.txt: Added.
* platform/qt/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt: Added.
* platform/qt/compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt: Added.
* platform/qt/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt: Added.
* platform/qt/compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt: Added.
* platform/qt/compositing/geometry/bounds-clipped-composited-child-expected.png: Added.
* platform/qt/compositing/geometry/bounds-clipped-composited-child-expected.txt: Added.
* platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-expected.png: Copied from LayoutTests/platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png.
* platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt: Added.
* platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png:
* platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Added.
* platform/qt/compositing/geometry/bounds-ignores-hidden-expected.txt: Added.
* platform/qt/compositing/geometry/clip-expected.txt: Added.
* platform/qt/compositing/geometry/clip-inside-expected.txt: Added.
* platform/qt/compositing/geometry/composited-in-columns-expected.png: Added.
* platform/qt/compositing/geometry/composited-in-columns-expected.txt: Added.
* platform/qt/compositing/geometry/flipped-writing-mode-expected.png: Copied from LayoutTests/platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png.
* platform/qt/compositing/geometry/flipped-writing-mode-expected.txt: Added.
* platform/qt/compositing/geometry/foreground-layer-expected.png: Added.
* platform/qt/compositing/geometry/foreground-layer-expected.txt: Added.
* platform/qt/compositing/geometry/preserve-3d-switching-expected.txt:
* platform/qt/compositing/iframes/become-composited-nested-iframes-expected.txt: Added.
* platform/qt/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
* platform/qt/compositing/iframes/composited-parent-iframe-expected.txt: Added.
* platform/qt/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
* platform/qt/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
* platform/qt/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
* platform/qt/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
* platform/qt/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
* platform/qt/compositing/iframes/iframe-resize-expected.txt: Added.
* platform/qt/compositing/iframes/overlapped-iframe-expected.txt: Added.
* platform/qt/compositing/iframes/overlapped-iframe-iframe-expected.txt: Added.
* platform/qt/compositing/iframes/overlapped-nested-iframes-expected.txt: Added.
* platform/qt/compositing/iframes/scrolling-iframe-expected.txt: Added.
* platform/qt/compositing/images/clip-on-directly-composited-image-expected.txt: Added.
* platform/qt/compositing/layer-creation/animation-overlap-with-children-expected.txt: Added.
* platform/qt/compositing/layer-creation/fixed-position-out-of-view-expected.txt: Added.
* platform/qt/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-expected.txt: Added.
* platform/qt/compositing/layer-creation/fixed-position-under-transform-expected.png: Added.
* platform/qt/compositing/layer-creation/fixed-position-under-transform-expected.txt: Added.
* platform/qt/compositing/layer-creation/no-compositing-for-fixed-position-under-transform-expected.txt: Added.
* platform/qt/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Added.
* platform/qt/compositing/layer-creation/overlap-animation-clipping-expected.txt: Added.
* platform/qt/compositing/layer-creation/overlap-animation-container-expected.txt:
* platform/qt/compositing/layer-creation/overlap-child-layer-expected.png: Copied from LayoutTests/platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png.
* platform/qt/compositing/layer-creation/overlap-child-layer-expected.txt: Added.
* platform/qt/compositing/layer-creation/overlap-transformed-layer-expected.png: Copied from LayoutTests/platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png.
* platform/qt/compositing/layer-creation/overlap-transformed-layer-expected.txt: Added.
* platform/qt/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt: Added.
* platform/qt/compositing/layer-creation/rotate3d-overlap-expected.txt: Added.
* platform/qt/compositing/layer-creation/stacking-context-overlap-expected.txt: Added.
* platform/qt/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Added.
* platform/qt/compositing/masks/mask-layer-size-expected.txt: Added.
* platform/qt/compositing/repaint/resize-repaint-expected.txt: Added.
* platform/qt/compositing/rtl/rtl-iframe-absolute-expected.png: Added.
* platform/qt/compositing/rtl/rtl-iframe-absolute-expected.txt: Added.
* platform/qt/compositing/rtl/rtl-iframe-fixed-expected.png: Added.
* platform/qt/compositing/rtl/rtl-iframe-fixed-expected.txt: Added.
* platform/qt/compositing/rtl/rtl-iframe-relative-expected.png: Copied from LayoutTests/platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png.
* platform/qt/compositing/rtl/rtl-iframe-relative-expected.txt: Added.
* platform/qt/compositing/tiling/backface-preserve-3d-tiled-expected.png: Added.
* platform/qt/compositing/tiling/backface-preserve-3d-tiled-expected.txt: Added.
* platform/qt/compositing/tiling/huge-layer-img-expected.png: Added.
* platform/qt/compositing/tiling/huge-layer-img-expected.txt: Added.
* platform/qt/compositing/tiling/rotated-tiled-clamped-expected.png: Added.
* platform/qt/compositing/tiling/rotated-tiled-clamped-expected.txt: Added.
* platform/qt/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.png: Added.
* platform/qt/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt: Added.
* platform/qt/compositing/tiling/tiled-layer-resize-expected.txt: Added.
* platform/qt/compositing/visibility/layer-visible-content-expected.png: Copied from LayoutTests/platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png.
* platform/qt/compositing/visibility/layer-visible-content-expected.txt: Added.
* platform/qt/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
* platform/qt/css3/filters/composited-during-transition-layertree-expected.txt:
* platform/qt/css3/filters/filtered-compositing-descendant-expected.png: Copied from LayoutTests/platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png.
* platform/qt/css3/filters/filtered-compositing-descendant-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Include Ecore_Getopt.h in MiniBrowser.
rakuco@webkit.org [Mon, 28 Jan 2013 10:00:39 +0000 (10:00 +0000)]
[EFL] Include Ecore_Getopt.h in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=108067

Reviewed by Kenneth Rohde Christiansen.

Be explicit and include Ecore_Getopt.h since we use it for parsing
command line options. It is safer than relying on other headers
including it for us.

* MiniBrowser/efl/main.c:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] Putting QtWebProcess into a chrooted sandbox
reni@webkit.org [Mon, 28 Jan 2013 09:54:15 +0000 (09:54 +0000)]
[WK2] Putting QtWebProcess into a chrooted sandbox
https://bugs.webkit.org/show_bug.cgi?id=90005

.:

Reviewed by Anders Carlsson and Zoltan Herczeg.

Make it possible to build WebKit2 with SandboxProcess.

* Source/QtWebKit.pro:

Source/WebKit2:

Reviewed by Anders Carlsson and Zoltan Herczeg.

This new feature makes possible to run WebProcess inside a chroot. In this case UIProcess calls the
internal SandboxProcess binary what makes up an environment for WebProcess inside the sandbox and runs the WebProcess.
SandboxProcess first creates two needed device files (random and urandom), mounts filesystems (proc and shared memory),
then links run-time dependencies of WebProcess. After this, SandboxProcess moves to a new pid namespace (cloning with
CLONE_NEWPID flag). Then after an other cloning (with CLONE_FS flag) we share our filesystem with our children. This is
needed because we want to call chroot() function from here and jail our child (WebProcess) too. This will be performed
when WebProcess sends a request for it via an socketpair. If sandboxing is done, SandboxProcess exits.
Since chroot() system call needs sudoer rights SandboxProcess binary should have set its suid flag. However we can reduce
its capabilites. First we restrict the capabilities of the process and the number of its possible resources. Furthermore
we fallback to the nobody or the real user.

* Configurations/FeatureDefines.xcconfig:
* SandboxProcess.pro: Added.
* Shared/linux/SandboxProcess/SandboxEnvironmentLinux.cpp: Added.
(launchChangeRootHelper):
(setEnvironmentVariablesForChangeRootHelper):
(prepareAndStartChangeRootHelper):
(setCapabilities):
(dropPrivileges):
(fileExists):
(directoryPermissions):
(createDirectory):
(createDirectoryPath):
(createDeviceFiles):
(mountFileSystems):
(linkFile):
(linkDirectory):
(collectRunTimeDependencies):
(setupXauthorityForNobodyUser):
(initSandbox):
(restrictCapabilities):
(moveToNewPidNamespace):
(run):
(main):
* Shared/linux/SandboxProcess/SandboxEnvironmentLinux.h: Added.
* Shared/linux/SandboxProcess/StringOperations.cpp: Added.
(stringCopy):
(stringConcat):
(stringAppend):
* Shared/linux/SandboxProcess/StringOperations.h: Added.
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::ProcessLauncher::launchProcess):
* WebKit2.pri:
* WebProcess.pro:
* WebProcess/qt/WebProcessMainQt.cpp:
(WebKit):
(WebKit::chrootMe):
(WebKit::WebProcessMainQt):

Tools:

Reviewed by Anders Carlsson and  Zoltan Herczeg.

Add feature flag for suid sandbox in linux.

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Marking bug2479-5.html as crashing.
keishi@webkit.org [Mon, 28 Jan 2013 09:49:55 +0000 (09:49 +0000)]
[Chromium] Marking bug2479-5.html as crashing.

Unreviewed. Gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[REGRESSION] Calendar Picker focus ring is gone
keishi@webkit.org [Mon, 28 Jan 2013 09:39:13 +0000 (09:39 +0000)]
[REGRESSION] Calendar Picker focus ring is gone
https://bugs.webkit.org/show_bug.cgi?id=108055

Reviewed by Kent Tamura.

The focus ring wasn't visible because -webkit-focus-ring-color value
only works for outline property in strict mode. Using fixed color
instead.

No new tests. Can't reproduce in layout test because mock popup writes a
script tag in front of the doctype.

* Resources/pagepopups/chromium/calendarPickerChromium.css:
(.days-area-container:focus):
* Resources/pagepopups/chromium/pickerCommonChromium.css:
(:enabled:focus:-webkit-any(button, input[type='button'])):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChange test expectation to ensure that seamless iframes do not inherit editability.
mkwst@chromium.org [Mon, 28 Jan 2013 09:39:00 +0000 (09:39 +0000)]
Change test expectation to ensure that seamless iframes do not inherit editability.
https://bugs.webkit.org/show_bug.cgi?id=108063

Reviewed by Eric Seidel.

Seamlessly rendered documents should not inherit editability from their
parent IFrame. Currently, the test expectations don't match this
behavior. This patch trivially adjusts the expectation to ensure that
editability is _not_ inherited.

* fast/frames/seamless/seamless-inherited-document-style-expected.txt:
* fast/frames/seamless/seamless-inherited-document-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: remove unused isElement and similar methods from HeapProfiler
yurys@chromium.org [Mon, 28 Jan 2013 09:21:57 +0000 (09:21 +0000)]
Web Inspector: remove unused isElement and similar methods from HeapProfiler
https://bugs.webkit.org/show_bug.cgi?id=107940

Reviewed by Vsevolod Vlasov.

Source/WebCore:

- Removed some unused methods.
- Moved JS specific edge filters to JSHeapSnapshot.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype.createEdgesProvider):
(WebInspector.HeapSnapshot.prototype.createEdgesProviderForTest):
(WebInspector.HeapSnapshot.prototype.retainingEdgesFilter):
(WebInspector.HeapSnapshot.prototype.containmentEdgesFilter):
(WebInspector.HeapSnapshot.prototype.createRetainingEdgesProvider):
(WebInspector.HeapSnapshot.prototype.classNodesFilter):
(WebInspector.HeapSnapshot.prototype.createNodesProviderForClass):
* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider):
(WebInspector.HeapSnapshotProxy.prototype.createRetainingEdgesProvider):
* inspector/front-end/JSHeapSnapshot.js:
(WebInspector.JSHeapSnapshot.prototype.classNodesFilter):
(WebInspector.JSHeapSnapshot.prototype._markDetachedDOMTreeNodes):
* inspector/front-end/NativeHeapSnapshot.js:

LayoutTests:

* inspector/profiler/heap-snapshot.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Rely more on C API in ewk_favicon_database
christophe.dumez@intel.com [Mon, 28 Jan 2013 09:02:32 +0000 (09:02 +0000)]
[EFL][WK2] Rely more on C API in ewk_favicon_database
https://bugs.webkit.org/show_bug.cgi?id=108035

Reviewed by Benjamin Poulain.

Rely less on internal C++ API in ewk_favicon_database and use C API
instead of avoid breaking API layering.

* PlatformEfl.cmake:
* UIProcess/API/C/cairo/WKIconDatabaseCairo.cpp: Added.
(WKIconDatabaseTryGetCairoSurfaceForURL): Add C API for getting the
favicon for a given page URL as a cairo_surface_t*.
* UIProcess/API/C/cairo/WKIconDatabaseCairo.h: Added.
* UIProcess/API/efl/ewk_favicon_database.cpp:
(EwkFaviconDatabase::didChangeIconForPageURL):
(EwkFaviconDatabase::getIconSurfaceSynchronously):
(EwkFaviconDatabase::iconDataReadyForPageURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd an API for retrieving native memory information without going through the remote...
commit-queue@webkit.org [Mon, 28 Jan 2013 08:53:48 +0000 (08:53 +0000)]
Add an API for retrieving native memory information without going through the remote inspecting protocol
https://bugs.webkit.org/show_bug.cgi?id=107651

Patch by Marja Hölttä <marja@chromium.org> on 2013-01-28
Reviewed by Adam Barth.

* WebKit.gyp:
* public/WebDevToolsAgent.h:
(WebKit):
(WebDevToolsAgent):
* public/WebMemoryUsageInfo.h: Added.
(WebKit):
(WebKit::WebMemoryUsageInfo::WebMemoryUsageInfo):
(WebMemoryUsageInfo):
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::processMemoryDistribution):
(WebKit):
* src/WebDevToolsAgentImpl.h:
(WebKit):
(WebDevToolsAgentImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r140554.
commit-queue@webkit.org [Mon, 28 Jan 2013 08:24:36 +0000 (08:24 +0000)]
Unreviewed, rolling out r140554.
http://trac.webkit.org/changeset/140554
https://bugs.webkit.org/show_bug.cgi?id=108057

Caused tables/table-section-overflow-clip-crash.html and
bug2479-5.html to crash. (Requested by keishi on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-28

* rendering/RenderBox.cpp:
(WebCore::RenderBox::minPreferredLogicalWidth):
(WebCore::RenderBox::maxPreferredLogicalWidth):
* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths):
* rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::computePreferredLogicalWidths):
* rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::computePreferredLogicalWidths):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: each node in a detached DOM tree is shown in its own "detached DOM...
yurys@chromium.org [Mon, 28 Jan 2013 08:05:35 +0000 (08:05 +0000)]
Web Inspector: each node in a detached DOM tree is shown in its own "detached DOM tree" entry in heap profiler
https://bugs.webkit.org/show_bug.cgi?id=107819

Reviewed by Adam Barth.

Provide single RetainedDOMInfo for each group of DOM Node wrappers reported to GC.
Otherwise we have unequal RetainedDOMInfo groups for each wrapped node.

* bindings/v8/V8GCController.cpp:
(WebCore::ImplicitConnection::ImplicitConnection):
(WebCore::ImplicitConnection::retainedObjectInfo):
(ImplicitConnection):
(WebCore::WrapperGrouper::addObjectToGroup):
(WrapperGrouper):
(WebCore::WrapperGrouper::addNodeToGroup):
(WebCore::WrapperGrouper::apply):
(WebCore::V8GCController::opaqueRootForGC):
* bindings/v8/V8GCController.h:
(V8GCController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSSRegions] RenderFlowThread should keep a count of auto height regions
mihnea@adobe.com [Mon, 28 Jan 2013 07:24:54 +0000 (07:24 +0000)]
[CSSRegions] RenderFlowThread should keep a count of auto height regions
https://bugs.webkit.org/show_bug.cgi?id=105185

Reviewed by Julien Chaffraix.

Keep the count of auto height regions on the flow thread instead of flow thread controller.
This way, we can streamline the operations associated with the two-pass layout only to those
flow threads that have auto height regions associated.
The flow thread controller will keep a count of flow thread with auto height regions instead.
This is a performance refactoring without an expected change in behavior, therefore no new tests were added.

* rendering/FlowThreadController.cpp: Keep a count of flow threads with auto logical height regions.
(WebCore::FlowThreadController::FlowThreadController):
(WebCore::FlowThreadController::layoutRenderNamedFlowThreads): Check the count of auto height regions for all the flow threads.
(WebCore::FlowThreadController::isAutoLogicalHeightRegionsCountConsistent):
Make sure that we call these methods only when we have auto logical height regions.
(WebCore::FlowThreadController::resetRegionsOverrideLogicalContentHeight):
(WebCore::FlowThreadController::markAutoLogicalHeightRegionsForLayout):
* rendering/FlowThreadController.h:
(WebCore::FlowThreadController::hasFlowThreadsWithAutoLogicalHeightRegions):
(WebCore::FlowThreadController::incrementFlowThreadsWithAutoLogicalHeightRegions):
(WebCore::FlowThreadController::decrementFlowThreadsWithAutoLogicalHeightRegions):
* rendering/RenderFlowThread.cpp: Keep a count of auto logical height regions.
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::isAutoLogicalHeightRegionsCountConsistent):
(WebCore::RenderFlowThread::resetRegionsOverrideLogicalContentHeight): Iterate the region chain only if the region chain has auto height regions.
(WebCore::RenderFlowThread::initializeRegionsOverrideLogicalContentHeight): Ditto.
(WebCore::RenderFlowThread::markAutoLogicalHeightRegionsForLayout): Ditto.
(WebCore::RenderFlowThread::incrementAutoLogicalHeightRegions):
(WebCore::RenderFlowThread::decrementAutoLogicalHeightRegions):
* rendering/RenderFlowThread.h:
* rendering/RenderRegion.cpp: Add increment/decrementAutoLogicalHeightCount to increase/decrease
the counter inside the flow thread and use them throughout the code as needed.
(WebCore::RenderRegion::incrementAutoLogicalHeightCount):
(WebCore::RenderRegion::decrementAutoLogicalHeightCount):
(WebCore::RenderRegion::updateRegionHasAutoLogicalHeightFlag):
(WebCore::RenderRegion::attachRegion):
(WebCore::RenderRegion::detachRegion):
* rendering/RenderRegion.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::checkTwoPassLayoutForAutoHeightRegions): Use the count of flow threads with auto height regions
instead of the count of auto height regions when deciding whether we should attempt the 2 pass layout for auto height regions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSC: FunctionParameters are memory hungry.
akling@apple.com [Mon, 28 Jan 2013 06:46:36 +0000 (06:46 +0000)]
JSC: FunctionParameters are memory hungry.
<http://webkit.org/b/108033>
<rdar://problem/13094803>

Reviewed by Sam Weinig.

Instead of inheriting from Vector<Identifier>, make FunctionParameters a simple fixed-size array
with a custom-allocating create() function. Removes one step of indirection and cuts memory usage
roughly in half.

2.73 MB progression on Membuster3.

* bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::paramString):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* parser/Nodes.cpp:
(JSC::FunctionParameters::create):
(JSC::FunctionParameters::FunctionParameters):
(JSC::FunctionParameters::~FunctionParameters):
* parser/Nodes.h:
(FunctionParameters):
(JSC::FunctionParameters::size):
(JSC::FunctionParameters::at):
(JSC::FunctionParameters::identifiers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Marking two fast/forms tests as slow on debug mac.
keishi@webkit.org [Mon, 28 Jan 2013 06:38:14 +0000 (06:38 +0000)]
[Chromium] Marking two fast/forms tests as slow on debug mac.

Unreviewed. Gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSC: SourceProviderCache is memory hungry.
akling@apple.com [Mon, 28 Jan 2013 06:34:03 +0000 (06:34 +0000)]
JSC: SourceProviderCache is memory hungry.
<http://webkit.org/b/108029>
<rdar://problem/13094806>

Reviewed by Sam Weinig.

Use fixed-size arrays for SourceProviderCacheItem's lists of captured variables.
Since the lists never change after the object is created, there's no need to keep them in Vectors
and we can instead create the whole cache item in a single allocation.

13.37 MB progression on Membuster3.

* parser/Parser.cpp:
(JSC::::parseFunctionInfo):
* parser/Parser.h:
(JSC::Scope::copyCapturedVariablesToVector):
(JSC::Scope::fillParametersForSourceProviderCache):
(JSC::Scope::restoreFromSourceProviderCache):
* parser/SourceProviderCacheItem.h:
(SourceProviderCacheItemCreationParameters):
(SourceProviderCacheItem):
(JSC::SourceProviderCacheItem::approximateByteSize):
(JSC::SourceProviderCacheItem::usedVariables):
(JSC::SourceProviderCacheItem::writtenVariables):
(JSC::SourceProviderCacheItem::~SourceProviderCacheItem):
(JSC::SourceProviderCacheItem::create):
(JSC::SourceProviderCacheItem::SourceProviderCacheItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Shadow DOM] Selecting a node to another node in ShadowDOM fires 'click' event unexpe...
shinyak@chromium.org [Mon, 28 Jan 2013 06:15:45 +0000 (06:15 +0000)]
[Shadow DOM] Selecting a node to another node in ShadowDOM fires 'click' event unexpectedly
https://bugs.webkit.org/show_bug.cgi?id=107233

Reviewed by Dimitri Glazkov.

Source/WebCore:

When selecting from a node to another node in ShadowDOM, 'click' event is unexpectedly fired.

The root cause of the bug is using shadow ancestor nodes for checking the node mouse is pressed on
and the node mouse is released on is the same. This was introduced to fire a click event for a slider
in <input> or etc.

However, we don't need to check shadow ancestor if we're in Author ShadowDOM.

Test: fast/dom/shadow/selecting-anchor.html

* page/EventHandler.cpp:
(WebCore::mouseIsReleasedOnPressedElement):
(WebCore):
(WebCore::EventHandler::handleMouseReleaseEvent):

LayoutTests:

* fast/dom/shadow/select-in-shadowdom-expected.txt: Added.
* fast/dom/shadow/select-in-shadowdom.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Marking storage/indexeddb tests as crashing.
keishi@webkit.org [Mon, 28 Jan 2013 05:24:44 +0000 (05:24 +0000)]
[Chromium] Marking storage/indexeddb tests as crashing.

Unreviewed. Gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[ANDROID] Fix a typo
commit-queue@webkit.org [Mon, 28 Jan 2013 05:15:41 +0000 (05:15 +0000)]
[ANDROID] Fix a typo
https://bugs.webkit.org/show_bug.cgi?id=108046

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-01-27
Reviewed by Adam Barth.

HAVE_NMAP -> HAVE_MMAP.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Marking media/track tests as crashing.
keishi@webkit.org [Mon, 28 Jan 2013 05:10:31 +0000 (05:10 +0000)]
[Chromium] Marking media/track tests as crashing.

Unreviewed. Gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Fix location of sandbox profiles in built products
ap@apple.com [Mon, 28 Jan 2013 05:02:08 +0000 (05:02 +0000)]
    Fix location of sandbox profiles in built products
        https://bugs.webkit.org/show_bug.cgi?id=108026

        Reviewed by Sam Weinig.

        * WebKit2.xcodeproj/project.pbxproj: Sandbox profiles go into WebKit2 framework resources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r140912): Broke specifying non-trivial ARCHS value to make / build-webkit
commit-queue@webkit.org [Mon, 28 Jan 2013 04:22:30 +0000 (04:22 +0000)]
REGRESSION (r140912): Broke specifying non-trivial ARCHS value to make / build-webkit
https://bugs.webkit.org/show_bug.cgi?id=108028

Patch by David Farler <dfarler@apple.com> on 2013-01-27
Reviewed by Dan Bernstein.

.:

* Makefile: Reverted.
* Makefile.shared: Reverted.
* Source/Makefile: Reverted.

Tools:

* DumpRenderTree/Makefile: Reverted.
* Makefile: Reverted.
* Scripts/webkitdirs.pm: Reverted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAn [ActiveDOMObject] IDL attribute should be inherited
haraken@chromium.org [Mon, 28 Jan 2013 04:06:27 +0000 (04:06 +0000)]
An [ActiveDOMObject] IDL attribute should be inherited
https://bugs.webkit.org/show_bug.cgi?id=107877

Reviewed by Adam Barth.

Now we support IDL attribute inheritance. We can remove
[ActiveDOMObject] from subclasses.

No tests. No change in behavior.

* Modules/indexeddb/IDBOpenDBRequest.idl:
* Modules/webaudio/OfflineAudioContext.idl:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
* workers/SharedWorker.idl:
* workers/Worker.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r140602.
commit-queue@webkit.org [Mon, 28 Jan 2013 03:08:59 +0000 (03:08 +0000)]
Unreviewed, rolling out r140602.
http://trac.webkit.org/changeset/140602
https://bugs.webkit.org/show_bug.cgi?id=108045

Caused 8 indexed tests to crash. (Requested by keishi on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-27

Source/WebCore:

* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.list.am:
* Modules/indexeddb/IDBCallbacks.h:
(WebCore::IDBCallbacks::onBlocked):
* Modules/indexeddb/IDBDatabase.cpp:
* Modules/indexeddb/IDBDatabase.h:
(WebCore):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):
* Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):
* Modules/indexeddb/IDBFactory.h:
(WebCore):
(IDBFactory):
* Modules/indexeddb/IDBFactory.idl:
* Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::create):
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::dispatchEvent):
* Modules/indexeddb/IDBOpenDBRequest.h:
(IDBOpenDBRequest):
* Modules/indexeddb/IDBVersionChangeRequest.cpp: Copied from Source/WebKit/chromium/src/WebIDBCallbacksImpl.h.
(WebCore):
(WebCore::IDBVersionChangeRequest::create):
(WebCore::IDBVersionChangeRequest::IDBVersionChangeRequest):
(WebCore::IDBVersionChangeRequest::~IDBVersionChangeRequest):
(WebCore::IDBVersionChangeRequest::interfaceName):
(WebCore::IDBVersionChangeRequest::onBlocked):
* Modules/indexeddb/IDBVersionChangeRequest.h: Copied from Source/WebCore/Modules/indexeddb/IDBFactory.idl.
(WebCore):
(IDBVersionChangeRequest):
* Modules/indexeddb/IDBVersionChangeRequest.idl: Copied from Source/WebCore/Modules/indexeddb/IDBFactory.idl.
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* dom/EventTarget.h:
(WebCore):
* dom/EventTargetFactory.in:

Source/WebKit/chromium:

* public/WebIDBCallbacks.h:
* src/IDBCallbacksProxy.cpp:
(WebKit::IDBCallbacksProxy::onBlocked):
(WebKit):
* src/IDBCallbacksProxy.h:
(IDBCallbacksProxy):
* src/WebIDBCallbacksImpl.cpp:
(WebKit::WebIDBCallbacksImpl::onBlocked):
(WebKit):
* src/WebIDBCallbacksImpl.h:
(WebIDBCallbacksImpl):
* tests/IDBAbortOnCorruptTest.cpp:
(WebCore::MockIDBCallbacks::onBlocked):
* tests/IDBDatabaseBackendTest.cpp:

LayoutTests:

* storage/indexeddb/intversion-long-queue-expected.txt:
* storage/indexeddb/intversion-upgrades-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDisabled input/textarea doesn't trigger selection change
shinyak@chromium.org [Mon, 28 Jan 2013 02:47:17 +0000 (02:47 +0000)]
Disabled input/textarea doesn't trigger selection change
https://bugs.webkit.org/show_bug.cgi?id=85244

Reviewed by Ryosuke Niwa.

Source/WebCore:

Only rootEditableNode is there in <input> or <textarea>, 'select' event is fired.
Since readonly or disabled input/textarea element does not have editable element,
'select' event was not fired.

We don't need the check.

Test: fast/forms/input-readonly-select.html

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::notifyRendererOfSelectionChange):

LayoutTests:

* fast/forms/input-readonly-select-expected.txt: Added.
* fast/forms/input-readonly-select.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r140850.
keishi@webkit.org [Mon, 28 Jan 2013 02:32:10 +0000 (02:32 +0000)]
Unreviewed, rolling out r140850.
http://trac.webkit.org/changeset/140850
https://bugs.webkit.org/show_bug.cgi?id=107960

r14602 caused 8 indexed tests to crash.

Source/WebCore:

* Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
* Modules/indexeddb/IDBCursorBackendImpl.h:
(WebCore::IDBCursorBackendImpl::create):
(IDBCursorBackendImpl):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::setIndexesReady):
(WebCore::OpenCursorOperation::perform):
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::openCursor):
* Modules/indexeddb/IDBObjectStore.h:
(WebCore::IDBObjectStore::openCursor):
(IDBObjectStore):
* Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::create):
(WebCore::IDBRequest::IDBRequest):
* Modules/indexeddb/IDBRequest.h:
(IDBRequest):
(WebCore::IDBRequest::taskType):
* Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::scheduleTask):
* Modules/indexeddb/IDBTransactionBackendImpl.h:
(WebCore::IDBTransactionBackendImpl::scheduleTask):
(IDBTransactionBackendImpl):
* Modules/indexeddb/IDBTransactionBackendInterface.h:
(IDBTransactionBackendInterface):

Source/WebKit/chromium:

* src/AssertMatchingEnums.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r140741.
commit-queue@webkit.org [Mon, 28 Jan 2013 02:20:51 +0000 (02:20 +0000)]
Unreviewed, rolling out r140741.
http://trac.webkit.org/changeset/140741
https://bugs.webkit.org/show_bug.cgi?id=108044

Caused 8 indexed tests to fail on Mac and Win. (Requested by
keishi on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-27

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::onVersionChange):
* Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::deleteDatabase):
* Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::onBlocked):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
* Modules/indexeddb/IDBUpgradeNeededEvent.cpp: Copied from Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.cpp.
(WebCore):
(WebCore::IDBUpgradeNeededEvent::create):
(WebCore::IDBUpgradeNeededEvent::IDBUpgradeNeededEvent):
(WebCore::IDBUpgradeNeededEvent::~IDBUpgradeNeededEvent):
(WebCore::IDBUpgradeNeededEvent::oldVersion):
(WebCore::IDBUpgradeNeededEvent::newVersion):
(WebCore::IDBUpgradeNeededEvent::interfaceName):
* Modules/indexeddb/IDBUpgradeNeededEvent.h: Copied from Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.h.
(WebCore):
(IDBUpgradeNeededEvent):
* Modules/indexeddb/IDBUpgradeNeededEvent.idl: Copied from Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.idl.
* Modules/indexeddb/IDBVersionChangeEvent.cpp:
(WebCore::IDBVersionChangeEvent::create):
(WebCore::IDBVersionChangeEvent::IDBVersionChangeEvent):
(WebCore::IDBVersionChangeEvent::version):
(WebCore):
* Modules/indexeddb/IDBVersionChangeEvent.h:
(WebCore):
(IDBVersionChangeEvent):
* Modules/indexeddb/IDBVersionChangeEvent.idl:
* WebCore.gypi:
* dom/EventNames.in:

LayoutTests:

* storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt:
* storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange-expected.txt:
* storage/indexeddb/deletedatabase-blocked-expected.txt:
* storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt:
* storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-workers-expected.txt:
* storage/indexeddb/deletedatabase-delayed-by-versionchange-expected.txt:
* storage/indexeddb/deletedatabase-not-blocked-expected.txt:
* storage/indexeddb/events-expected.txt: Removed.
* storage/indexeddb/events.html: Removed.
* storage/indexeddb/intversion-gated-on-delete-expected.txt:
* storage/indexeddb/intversion-long-queue-expected.txt:
* storage/indexeddb/removed-expected.txt:
* storage/indexeddb/resources/delete-in-upgradeneeded-close-in-open-success.js:
(versionChangeCallback):
* storage/indexeddb/resources/delete-in-upgradeneeded-close-in-versionchange.js:
(versionChangeCallback):
* storage/indexeddb/resources/deletedatabase-blocked.js:
(test.request.onsuccess.openOnSuccess.h.onversionchange):
* storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js:
(prepareDatabase.h.onversionchange):
* storage/indexeddb/resources/deletedatabase-delayed-by-versionchange.js:
(h1OpenSuccess.h1.onversionchange):
(h1OpenSuccess.request.onsuccess.h2OpenSuccess.h2.onversionchange):
* storage/indexeddb/resources/deletedatabase-not-blocked.js:
(test.request.onsuccess.openOnSuccess.h.onversionchange):
* storage/indexeddb/resources/events.js: Removed.
* storage/indexeddb/resources/intversion-gated-on-delete.js:
(firstSuccessCallback):
(connection1VersionChangeCallback):
* storage/indexeddb/resources/intversion-long-queue.js:
(connection1VersionChangeCallback):
(deleteDatabaseBlockedCallback):
(deleteDatabaseSuccessCallback):
(connection2VersionChangeEvent):
* storage/indexeddb/resources/removed.js:
(test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Rebaselining overflow-size-change* tests.
keishi@webkit.org [Mon, 28 Jan 2013 02:08:38 +0000 (02:08 +0000)]
[Chromium] Rebaselining overflow-size-change* tests.

Unreviewed. Gardening.

* platform/chromium-mac-lion/fast/regions/overflow-size-change-in-variable-width-regions-expected.png:
* platform/chromium-mac-lion/fast/regions/overflow-size-change-with-stacking-context-expected.png:
* platform/chromium-mac-snowleopard/fast/regions/overflow-size-change-in-variable-width-regions-expected.png:
* platform/chromium-mac-snowleopard/fast/regions/overflow-size-change-with-stacking-context-expected.png:
* platform/chromium-mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.png:
* platform/chromium-mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Renamed from LayoutTests/platform/chromium/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt.
* platform/chromium-mac/fast/regions/overflow-size-change-with-stacking-context-expected.png:
* platform/chromium-mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Renamed from LayoutTests/platform/chromium/fast/regions/overflow-size-change-with-stacking-context-expected.txt.
* platform/chromium-win/fast/regions/overflow-size-change-in-variable-width-regions-expected.png:
* platform/chromium-win/fast/regions/overflow-size-change-with-stacking-context-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Attempt to fix expectation entry.
keishi@webkit.org [Mon, 28 Jan 2013 02:00:39 +0000 (02:00 +0000)]
[Chromium] Attempt to fix expectation entry.

Unreviewed. Gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoElements must be reattached when inserted/removed from top layer
falken@chromium.org [Mon, 28 Jan 2013 01:55:04 +0000 (01:55 +0000)]
Elements must be reattached when inserted/removed from top layer
https://bugs.webkit.org/show_bug.cgi?id=105489

Relanding r139402 as the apparent perf regression has been explained as not real (bug 106726).

Reviewed by Julien Chaffraix.

Source/WebCore:

Ensure a reattach occurs when an element is inserted/removed from top layer, so its renderer can be inserted correctly:
as a child of RenderView in top layer sibling order if it's in the top layer, and in the usual place otherwise.

We previously relied on style recalc to catch when an element is inserted/removed from the top layer, because it
only happens on dialog.show/close which toggle display: none. But that is incorrect because, for example, close()
followed immediately by show() results in no style change.

Tests: fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html
       fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html

* dom/Element.cpp:
(WebCore::Element::removedFrom): Call Document::removeFromTopLayer to let the element be removed from the top layer vector.
removeFromTopLayer calls Element::setIsInTopLayer(false) itself if needed.
(WebCore::Element::setIsInTopLayer): Ensure a reattach occurs if the element is already attached.

LayoutTests:

* fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer-expected.html: Added.
* fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html: Added.
This tests that a top layer element removed from the document does not reappear in the top layer if readded.
This test actually would pass before this patch, but just by good fortune (see bug).
* fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd-expected.html: Added.
* fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html: Added.
This tests that top layer ordering is correct after removing and readding an element to the top layer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixing atomicIncrement implementation for Windows by dropping support before XP SP2.
commit-queue@webkit.org [Mon, 28 Jan 2013 00:26:55 +0000 (00:26 +0000)]
Fixing atomicIncrement implementation for Windows by dropping support before XP SP2.
https://bugs.webkit.org/show_bug.cgi?id=106740

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-01-27
Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

* config.h:

Source/WebCore:

* WebCorePrefix.h:
* config.h:

Source/WebKit/win:

* WebKitPrefix.h:

Source/WebKit2:

* config.h:

Source/WTF:

Adding int64_t type atomicIncrement and atomicDecrement implementations for Windows
into Atomics.h required by WebKit2 after r139514. Separating WinCE implementation
that does not support WebKit2 and has no support for 64 bit interlocked methods.

Increasing WINVER and _WIN32_WINNT to XP SP2, because the 64 bit type interlocked methods
are not supported on previous versions on 32 bit target.

* config.h:
* wtf/Atomics.h:
(WTF):
(WTF::atomicIncrement):
(WTF::atomicDecrement):

Tools:

* DumpRenderTree/config.h:
* WinLauncher/stdafx.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd support for launching WebKit2 plugins using XPC
weinig@apple.com [Sun, 27 Jan 2013 21:53:24 +0000 (21:53 +0000)]
Add support for launching WebKit2 plugins using XPC
https://bugs.webkit.org/show_bug.cgi?id=108040

Reviewed by Dan Bernstein.

* Configurations/PluginService.32.xcconfig: Copied from Source/WebKit2/Configurations/WebContentService.xcconfig.
* Configurations/PluginService.64.xcconfig: Copied from Source/WebKit2/Configurations/WebContentService.xcconfig.
* Configurations/PluginService.Development.xcconfig: Copied from Source/WebKit2/Configurations/WebContentService.xcconfig.
Add configurations.

* PluginProcess/EntryPoint/mac/XPCService: Added.
* PluginProcess/EntryPoint/mac/XPCService/PluginService.32: Added.
* PluginProcess/EntryPoint/mac/XPCService/PluginService.32/Info.plist: Copied from Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info.plist.
* PluginProcess/EntryPoint/mac/XPCService/PluginService.32/PluginService.32.Main.mm: Copied from Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/NetworkServiceMain.mm.
* PluginProcess/EntryPoint/mac/XPCService/PluginService.64: Added.
* PluginProcess/EntryPoint/mac/XPCService/PluginService.64/Info.plist: Copied from Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info.plist.
* PluginProcess/EntryPoint/mac/XPCService/PluginService.64/PluginService.64.Main.mm: Copied from Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/NetworkServiceMain.mm.
* PluginProcess/EntryPoint/mac/XPCService/PluginService.Development: Added.
* PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist: Added.
* PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/PluginService.Development.Main.mm: Added.
(main):
* PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm: Copied from Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm.
(initializePluginService):
Add entry points.

* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::serviceName):
Add plugin process service names and move into correct #ifdef.

* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::shouldUseXPC):
(WebKit::PluginProcessProxy::platformInitializeLaunchOptions):
Opt into xpc using the same rules as the WebProcess.

* WebKit2.xcodeproj/project.pbxproj:
Add files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] add missing plumbing for Notification.requestPermission
jochen@chromium.org [Sun, 27 Jan 2013 21:04:20 +0000 (21:04 +0000)]
[chromium] add missing plumbing for Notification.requestPermission
https://bugs.webkit.org/show_bug.cgi?id=108012

Reviewed by Adam Barth.

Source/WebKit/chromium:

* src/NotificationPresenterImpl.cpp:
(WebKit):
(WebKit::VoidCallbackClient::VoidCallbackClient):
(NotificationPermissionCallbackClient):
(WebKit::NotificationPermissionCallbackClient::NotificationPermissionCallbackClient):
(WebKit::NotificationPermissionCallbackClient::permissionRequestComplete):
(WebKit::NotificationPermissionCallbackClient::~NotificationPermissionCallbackClient):
(WebKit::NotificationPresenterImpl::requestPermission):
* src/NotificationPresenterImpl.h:
(NotificationPresenterImpl):

LayoutTests:

* fast/notifications/notifications-constructor-request-permission-expected.txt: Added.
* fast/notifications/notifications-constructor-request-permission.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCheck notification permissions in the show() method
jochen@chromium.org [Sun, 27 Jan 2013 10:58:30 +0000 (10:58 +0000)]
Check notification permissions in the show() method
https://bugs.webkit.org/show_bug.cgi?id=108009

Reviewed by Adam Barth.

Source/WebCore:

Tests: fast/notifications/notifications-constructor-with-permission.html
       fast/notifications/notifications-constructor-without-permission.html

* Modules/notifications/Notification.cpp:
(WebCore::Notification::show):
(WebCore::Notification::taskTimerFired):

LayoutTests:

* fast/notifications/notifications-constructor-with-permission-expected.txt: Added.
* fast/notifications/notifications-constructor-with-permission.html: Added.
* fast/notifications/notifications-constructor-without-permission-expected.txt: Added.
* fast/notifications/notifications-constructor-without-permission.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Use shared ChildProcess code to enter plug-in sandbox.
ap@apple.com [Sun, 27 Jan 2013 07:02:45 +0000 (07:02 +0000)]
    Use shared ChildProcess code to enter plug-in sandbox.

        Reviewed by Sam Weinig.

        There is one known behavior change from this refactoring: getpwuid_r is used
        instead of NSHomeDirectory for home directory, mathcing other client processes.

        * PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::enterSandbox):
        * PluginProcess/PluginProcess.h:
        PluginProcess prevents ChildProcess attempt to enter the sandbox immediately on
        launch for now, because we don't have a sandbox profile directory path yet.
        It now keeps a copy of ChildProcessInitializationParameters, so that
        ChildProcess::initializeSandbox() could be called later.

        * PluginProcess/mac/PluginProcessMac.mm:
        (WebKit::PluginProcess::platformInitializeProcess): Store a copy of ChildProcessInitializationParameters
        for later.
        (WebKit::loadSandboxProfile): Build a sandbox profile from a common prefix and
        a plugin-specific part.
        (WebKit::PluginProcess::platformInitializePluginProcess): We can enter the sandbox now.
        (WebKit::PluginProcess::enterSandbox): Prepare SandboxInitializationParameters,
        and call ChildProcess::initializeSandbox().

        * Shared/mac/ChildProcessMac.mm:
        (WebKit::ChildProcess::initializeSandbox): Actually handle system directory suffix
        from parameters.

        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.h: Removed.
        * WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Don't use goma to preprocess bindings idl files
tony@chromium.org [Sun, 27 Jan 2013 06:39:38 +0000 (06:39 +0000)]
[chromium] Don't use goma to preprocess bindings idl files
https://bugs.webkit.org/show_bug.cgi?id=107984

Reviewed by Adam Barth.

On Linux and Mac, use a local gcc or clang to preprocess the bindings idl files.
On my machine, this drops the bindings generation from 137s to 24s when
using goma and -j400.

No new tests, this is a build change.

* WebCore.gyp/WebCore.gyp: Force the use of the local gcc or clang for preprocessing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd support for running the networking process as an XPCService
weinig@apple.com [Sun, 27 Jan 2013 05:32:53 +0000 (05:32 +0000)]
Add support for running the networking process as an XPCService
https://bugs.webkit.org/show_bug.cgi?id=108025

Reviewed by Dan Bernstein.

* Configurations/NetworkService.Development.xcconfig: Copied from Source/WebKit2/Configurations/WebContentService.Development.xcconfig.
* Configurations/NetworkService.xcconfig: Copied from Source/WebKit2/Configurations/WebContentService.xcconfig.
Add configurations.

* NetworkProcess/EntryPoint/mac/XPCService: Added.
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService: Added.
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development: Added.
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info.plist: Copied from Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist.
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/NetworkServiceMain.Development.mm: Copied from Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/WebContentServiceMain.Development.mm.
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info.plist: Copied from Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist.
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService/NetworkServiceMain.mm: Copied from Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/WebContentServiceMain.mm.
* NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm: Copied from Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm.
(initializeNetworkService):
Add entry points.

* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::serviceName):
(WebKit::connectToServiceForDevelopment):
(WebKit::createServiceForDevelopment):
(WebKit::createService):
(WebKit::createProcess):
(WebKit::ProcessLauncher::launchProcess):
Rework service creation to work for arbitrary services.

* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::~NetworkProcessProxy):
(WebKit::NetworkProcessProxy::getLaunchOptions):
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/Network/mac/NetworkProcessProxyMac.mm:
(WebKit::shouldUseXPC):
(WebKit::NetworkProcessProxy::platformGetLaunchOptions):
Opt into xpc using the same rules as the WebProcess.

* WebKit2.xcodeproj/project.pbxproj:
Update files.

* WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
(initializeWebContentService):
Fix the comment to refer to the shim correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r140880.
commit-queue@webkit.org [Sun, 27 Jan 2013 04:30:33 +0000 (04:30 +0000)]
Unreviewed, rolling out r140880.
http://trac.webkit.org/changeset/140880
https://bugs.webkit.org/show_bug.cgi?id=108023

Caused mathml/presentation and tests to crash and fail
(Requested by keishi on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-26

Source/WebCore:

* mathml/MathMLTextElement.cpp:
* mathml/MathMLTextElement.h:
(MathMLTextElement):
* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::RenderMathMLBlock):
(WebCore::RenderMathMLBlock::computePreferredLogicalWidths):
(WebCore):
(WebCore::RenderMathMLBlock::computeChildrenPreferredLogicalHeights):
(WebCore::RenderMathMLBlock::preferredLogicalHeightAfterSizing):
* rendering/mathml/RenderMathMLBlock.h:
(RenderMathMLBlock):
(WebCore::RenderMathMLBlock::isPreferredLogicalHeightDirty):
(WebCore::RenderMathMLBlock::preferredLogicalHeight):
(WebCore::RenderMathMLBlock::setPreferredLogicalHeight):
* rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::styleDidChange):
* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths):
(WebCore):
(WebCore::RenderMathMLOperator::glyphHeightForCharacter):
(WebCore::RenderMathMLOperator::updateFromElement):
(WebCore::RenderMathMLOperator::createGlyph):
(WebCore::RenderMathMLOperator::firstLineBoxBaseline):
* rendering/mathml/RenderMathMLOperator.h:
(RenderMathMLOperator):
* rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::index):
(WebCore::RenderMathMLRoot::computePreferredLogicalWidths):
(WebCore):
(WebCore::RenderMathMLRoot::layout):
* rendering/mathml/RenderMathMLRoot.h:
(RenderMathMLRoot):
* rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::computePreferredLogicalWidths):
(WebCore::RenderMathMLRow::layout):
* rendering/mathml/RenderMathMLRow.h:
(RenderMathMLRow):

LayoutTests:

* mathml/differentiable-manifold.html: Removed.
* platform/chromium-linux/mathml/differentiable-manifold-expected.png: Removed.
* platform/chromium-linux/mathml/differentiable-manifold-expected.txt: Removed.
* platform/chromium-linux/mathml/presentation/fenced-expected.txt:
* platform/chromium-linux/mathml/presentation/fenced-mi-expected.png:
* platform/chromium-linux/mathml/presentation/fenced-mi-expected.txt:
* platform/chromium-linux/mathml/presentation/mo-expected.txt:
* platform/chromium-linux/mathml/presentation/mo-stretch-expected.png:
* platform/chromium-linux/mathml/presentation/mo-stretch-expected.txt:
* platform/chromium-linux/mathml/presentation/over-expected.txt:
* platform/chromium-linux/mathml/presentation/row-alignment-expected.txt:
* platform/chromium-linux/mathml/presentation/row-expected.png:
* platform/chromium-linux/mathml/presentation/row-expected.txt:
* platform/chromium-linux/mathml/presentation/sub-expected.png:
* platform/chromium-linux/mathml/presentation/sub-expected.txt:
* platform/chromium-linux/mathml/presentation/subsup-expected.txt:
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSimplify environment creation in XPC service re-exec
weinig@apple.com [Sun, 27 Jan 2013 01:36:36 +0000 (01:36 +0000)]
Simplify environment creation in XPC service re-exec
https://bugs.webkit.org/show_bug.cgi?id=108017

Reviewed by Dan Bernstein.

* Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.Development.h:
(WebKit::XPCServiceEventHandler):
There is no need to copy these strings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Remove code for handling NetworkProcess authentication challenges in WebProcess
ap@apple.com [Sun, 27 Jan 2013 01:01:08 +0000 (01:01 +0000)]
    Remove code for handling NetworkProcess authentication challenges in WebProcess
        https://bugs.webkit.org/show_bug.cgi?id=108003

        Reviewed by Sam Weinig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the development build.
weinig@apple.com [Sun, 27 Jan 2013 00:53:54 +0000 (00:53 +0000)]
Fix the development build.

* Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.Development.h:
(WebKit::XPCServiceEventHandler):
Use the right stringizer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefactor XPCService initialization to make it easier to add more services
weinig@apple.com [Sun, 27 Jan 2013 00:40:16 +0000 (00:40 +0000)]
Refactor XPCService initialization to make it easier to add more services
https://bugs.webkit.org/show_bug.cgi?id=108015

Reviewed by Dan Bernstein.

* Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.Development.h: Added.
(WebKit::XPCServiceEventHandler):
* Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.h: Added.
(WebKit::XPCServiceEventHandler):
Move bootstrapping to Shared (like we have for the legacy process). For now, we use
a macro to define the actual initialization point function to use, in the future, we
could consider alternatives, such as getting the function name from the bundle.

* WebKit2.xcodeproj/project.pbxproj:
Update files.

* WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/WebContentServiceMain.Development.mm:
* WebProcess/EntryPoint/mac/XPCService/WebContentService/WebContentServiceMain.mm:
Simplify to use the new XPCServiceBootstrapper.

* WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm: Copied from Source/WebKit2/WebProcess/mac/WebProcessServiceEntryPoints.mm.
(initializeWebContentService):
* WebProcess/mac/WebProcessServiceEntryPoints.h: Removed.
* WebProcess/mac/WebProcessServiceEntryPoints.mm: Removed.
Move the entry point to where it belongs and extract the bootstrapping parts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the test for CHANNEL_MESSAGING in idl files
commit-queue@webkit.org [Sun, 27 Jan 2013 00:09:39 +0000 (00:09 +0000)]
Fix the test for CHANNEL_MESSAGING in idl files
https://bugs.webkit.org/show_bug.cgi?id=108006

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-01-26
Reviewed by Alexey Proskuryakov.

No new tests, this is a build fix.

* workers/WorkerContext.idl: Make sure ENABLE_CHANNEL_MESSAGING is
defined before using it to be consitent with other guards inside idl
files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed fix after r140451 to make GIT-SVN repositories happy.
abecsi@webkit.org [Sat, 26 Jan 2013 22:55:56 +0000 (22:55 +0000)]
Unreviewed fix after r140451 to make GIT-SVN repositories happy.

* WTF.vcproj/WTF.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt]Qt build fix
commit-queue@webkit.org [Sat, 26 Jan 2013 22:24:08 +0000 (22:24 +0000)]
[Qt]Qt build fix
https://bugs.webkit.org/show_bug.cgi?id=108013

Changes on process initialization classes broke webkit building with Qt5. This
patch fix it.

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-01-26
Reviewed by Sam Weinig.

* PluginProcess/qt/PluginProcessMainQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140916 268f45cc-cd09-0410-ab3c-d52691b4dbfc