hausmann [Thu, 26 Jul 2007 09:36:51 +0000 (09:36 +0000)]
Ensure QtLauncher and DumpRenderTree are linked against the uninstalled QtWebKit library by making sure $$OUTPUT_DIR/lib appears before $QTDIR/lib in the library search path and rpath.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24641
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 26 Jul 2007 07:11:32 +0000 (07:11 +0000)]
- grammar fix pointed out by Mitz.
* projects/goals.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24639
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 26 Jul 2007 06:44:38 +0000 (06:44 +0000)]
Rubber stamped by Adam.
Added WebKit Project Goals.
* nav.inc: added a nav link.
* projects/goals.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24638
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 26 Jul 2007 01:50:54 +0000 (01:50 +0000)]
JavaScriptCore:
Reviewed by Mark.
- follow-up to previous change
* kjs/ustring.cpp:
(KJS::UString::operator=): Make sure to reset the length when
replacing the buffer contents for a single-owned string.
WebCore:
Reviewed by Mark.
- follow-up to previous change to avoid assertion failures in debug
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::getResponseText): hold JSLock when needed
(WebCore::XMLHttpRequest::open): ditto
(WebCore::XMLHttpRequest::didFinishLoading): ditto
(WebCore::XMLHttpRequest::didReceiveData): ditto
* xml/XMLHttpRequest.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24637
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 26 Jul 2007 00:08:16 +0000 (00:08 +0000)]
LayoutTests:
Reviewed by Darin.
<rdar://problem/
5327912>
iDisk: Web iDisk & main iDisk appear blank
* http/tests/loading/cached-scripts-expected.txt: Added.
* http/tests/loading/cached-scripts.html: Added.
* http/tests/loading/resources: Added.
* http/tests/loading/resources/cached-scripts-subframe.html: Added.
WebCore:
Reviewed by Darin.
<rdar://problem/
5327912>
iDisk: Web iDisk & main iDisk appear blank
Prepend any remaining text that scripts might have written.
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::scriptExecution):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24636
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Wed, 25 Jul 2007 22:15:00 +0000 (22:15 +0000)]
LayoutTests:
Reviewed by .
* mac/leopard/Skipped:
Removing some tests that were removed earlier, but checked back
in accidentally. Not sure how they got back into my file though.
WebCore:
Reviewed by Tim, Darin, Oliver.
- <rdar://problem/
5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
- Check for file:// urls when clicking links, not block all schemes that are treated as local.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::load):
WebKitTools:
Reviewed by Tim, Darin, Oliver.
- <rdar://problem/
5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
- Change DRT to be able to intercept the requst to load so it can check if a scheme was allowed or not.
* ChangeLog:
* DumpRenderTree/DumpRenderTree.m:
(createWebView):
(dumpRenderTree):
(+[LayoutTestController isSelectorExcludedFromWebScript:]):
(+[LayoutTestController webScriptNameForSelector:]):
(-[LayoutTestController setCustomPolicyDelegate:]):
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/FrameLoadDelegate.h:
* DumpRenderTree/PolicyDelegate.h: Added.
* DumpRenderTree/PolicyDelegate.m: Added.
(-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
* DumpRenderTree/ResourceLoadDelegate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24634
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 25 Jul 2007 21:50:00 +0000 (21:50 +0000)]
JavaScriptCore:
Reviewed by Darin.
- JavaScriptCore part of fix for <rdar://problem/
5300291> Optimize GC to reclaim big, temporary objects (like XMLHttpRequest.responseXML) quickly
Also, as a side effect of optimizations included in this patch:
- 7% speedup on JavaScript iBench
- 4% speedup on "Celtic Kane" JS benchmark
The basic idea is explained in a big comment in collector.cpp. When unusually
large objecs are allocated, we push the next GC closer on the assumption that
most objects are short-lived.
I also did the following two optimizations in the course of tuning
this not to be a performance regression:
1) Change UString::Rep to hold a self-pointer as the baseString in
the unshared case, instead of a null pointer; this removes a
number of null checks in hot code because many places already
wanted to use the rep itself or the baseString as appropriate.
2) Avoid creating duplicate StringImpls when creating a
StringInstance (the object wrapper for a JS string) or calling
their methods. Since a temporary wrapper object is made every time
a string method is called, this resulted in two useless extra
StringImpls being allocated for no reason whenever a String method
was invoked on a string value. Now we bypass those.
* kjs/collector.cpp:
(KJS::):
(KJS::Collector::recordExtraCost): Basics of the extra cost mechanism.
(KJS::Collector::allocate): ditto
(KJS::Collector::collect): ditto
* kjs/collector.h:
(KJS::Collector::reportExtraMemoryCost): ditto
* kjs/array_object.cpp:
(ArrayInstance::ArrayInstance): record extra cost
* kjs/internal.cpp:
(KJS::StringImp::toObject): don't create a whole new StringImpl just
to be the internal value of a StringInstance! StringImpls are immutable
so there's no point tot his.
* kjs/internal.h:
(KJS::StringImp::StringImp): report extra cost
* kjs/string_object.cpp:
(KJS::StringInstance::StringInstance): new version that takes a StringImp
(KJS::StringProtoFunc::callAsFunction): don't create a whole new StringImpl
just to convert self to string! we already have one in the internal value
* kjs/string_object.h: report extra cost
* kjs/ustring.cpp: All changes to handle baseString being self instead of null in the
unshared case.
(KJS::):
(KJS::UString::Rep::create):
(KJS::UString::Rep::destroy):
(KJS::UString::usedCapacity):
(KJS::UString::usedPreCapacity):
(KJS::UString::expandCapacity):
(KJS::UString::expandPreCapacity):
(KJS::UString::UString):
(KJS::UString::append):
(KJS::UString::operator=):
(KJS::UString::copyForWriting):
* kjs/ustring.h:
(KJS::UString::Rep::baseIsSelf): new method, now that baseString is
self instead of null in the unshared case we can't just null check.
(KJS::UString::Rep::data): adjusted as mentioned above
(KJS::UString::cost): new method to compute the cost for a UString, for
use by StringImpl.
* kjs/value.cpp:
(KJS::jsString): style fixups.
(KJS::jsOwnedString): new method, use this for strings allocated from UStrings
held by the parse tree. Tracking their cost as part of string cost is pointless,
because garbage collecting them will not actually free the relevant string buffer.
* kjs/value.h: prototyped jsOwnedString.
* kjs/nodes.cpp:
(StringNode::evaluate): use jsOwnedString as appropriate
(RegExpNode::evaluate): ditto
(PropertyNameNode::evaluate): ditto
(ForInNode::execute): ditto
* JavaScriptCore.exp: Exported some new symbols.
WebCore:
Reviewed by Darin.
- fixed <rdar://problem/
5300291> Optimize GC to reclaim big, temporary objects (like XMLHttpRequest.responseXML) quickly
With this plus related JavaScriptCore changes, a number of XMLHttpRequest situations that
result in huge data sets are addressed, including a single huge responseXML on an XMR done
repeatedly, or accessing responseText repeatedly during loading of a single large XHR.
In addition to the GC changes in JavaScriptCore, I changed responseText to be stored as a
KJS::UString instead of a WebCore::String so that the JavaScript responseText value can
share the buffer (indeed multiple intermediate responseTexts can share its buffer).
First of all, here's some manual test cases that will each blow out the process VM without this fix,
but will settle into decent steady state with.
* manual-tests/memory: Added.
* manual-tests/memory/MessageUidsAlreadyDownloaded2: Added.
* manual-tests/memory/string-growth.html: Added.
* manual-tests/memory/xhr-multiple-requests-responseText.html: Added.
* manual-tests/memory/xhr-multiple-requests-responseXML.html: Added.
* manual-tests/memory/xhr-multiple-requests.html: Added.
* manual-tests/memory/xhr-repeated-string-access.xml: Added.
And here's the actual code changes:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDocumentCustom.cpp:
(WebCore::toJS): Record extra cost if the document is frameless (counting the nodes
doesn't make a measurable performance difference here in any case I could find)
* bindings/js/JSXMLHttpRequest.cpp:
(KJS::JSXMLHttpRequest::getValueProperty): Adjust for the fact that ressponseText
is now stored as a UString.
* bindings/js/kjs_binding.cpp:
(KJS::jsOwnedStringOrNull): New helper.
* bindings/js/kjs_binding.h:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::getResponseText): It's a UString!
(WebCore::XMLHttpRequest::getResponseXML): handle the fact that m_responseText
is a UString.
(WebCore::XMLHttpRequest::XMLHttpRequest): ditto.
(WebCore::XMLHttpRequest::abort): call dropProtection
(WebCore::XMLHttpRequest::didFinishLoading): call dropProtection
(WebCore::XMLHttpRequest::dropProtection): after removing our GC protection,
report extra cost of this XHR's responseText buffer.
* xml/XMLHttpRequest.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24633
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 25 Jul 2007 21:41:04 +0000 (21:41 +0000)]
Reviewed by Brady.
<rdar://problem/
4796657> table deletion outline does not always follow the table size as editing occurs inside
Change the outline element to position itself automaticlly using the top, left, bottom and right CSS properties.
This made the container element redundant, so it has been removed. Now the outline element and the delete button
both get appended to the target element and positioned based on that container element. This removes the need
to update the width and height when the target contents changed.
* editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::show): Change the style properties and remove the container element.
(WebCore::DeleteButtonController::hide): Remove the button and outline from the target element.
* editing/DeleteButtonController.h: Removed updateOutlineStyle, respondToChangedContents and m_containerElement.
* editing/Editor.cpp:
(WebCore::Editor::respondToChangedContents): Remove the call to DeleteButtonController respondToChangedContents.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24632
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 25 Jul 2007 21:35:57 +0000 (21:35 +0000)]
Reviewed by Darin.
<rdar://problem/
5344471>
CrashTracer: [USER] 1 crash in Mail at WebCore::PluginTokenizer::writeRawData(char const*, int)
Make sure to layout so we'll have a renderer. Also null-check the renderer for extra safety.
* loader/PluginDocument.cpp:
(WebCore::PluginTokenizer::writeRawData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24631
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan [Wed, 25 Jul 2007 20:54:03 +0000 (20:54 +0000)]
2007-07-25 Ada Chan <adachan@apple.com>
Reviewed by Adam and Steve.
Implemented some DOM methods and other fixes for <rdar://problem/
5311601>.
* DOMCoreClasses.cpp:
(DOMNode::ownerDocument): implemented
(DOMDocument::getComputedStyle): get the DOMElement via QueryInterface
(DOMElement::QueryInterface):
* DOMHTMLClasses.cpp:
(DOMHTMLDocument::body): fixed leak
(DOMHTMLFormElement::action): implemented
(DOMHTMLFormElement::method): ditto
(DOMHTMLInputElement::form): ditto
(DOMHTMLTextAreaElement::form): ditto
* Interfaces/DOMHTML.idl: IDOMHTMLInputElement should inherit from IDOMHTMLElement
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24630
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat [Wed, 25 Jul 2007 20:12:58 +0000 (20:12 +0000)]
Fix build for some reported systems.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24629
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Wed, 25 Jul 2007 19:07:23 +0000 (19:07 +0000)]
Reviewed by .
* mac/leopard/Skipped:
Removing some tests that were removed earlier, but checked back
in accidentally. Not sure how they got back into my file though.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24627
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Wed, 25 Jul 2007 19:01:20 +0000 (19:01 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24626
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Wed, 25 Jul 2007 18:48:11 +0000 (18:48 +0000)]
Reviewed by .
* mac/leopard/Skipped:
Adding to skip list to avoid false failure
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24625
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 25 Jul 2007 16:54:22 +0000 (16:54 +0000)]
Reviewed by Maciej, Darin.
- http://bugs.webkit.org/show_bug.cgi?id=14030
Add ResourceHandle::setClient to resolve some messiness with handle
releasing. Clear the client when ResourceLoader is going to release
the handle to prevent crashes in the case where somebody still holds a
reference (this doesn't seem to currently happen in practice). Add
NULL-checking for ResourceHandle implementations using the client.
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::releaseResources):
* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::fireBlockedFailure):
(WebCore::ResourceHandle::setClient):
* platform/network/ResourceHandle.h:
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willSendRequest):
(WebCore::didReceiveResponse):
(WebCore::didReceiveData):
(WebCore::didFinishLoading):
(WebCore::didFail):
(WebCore::willCacheResponse):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCancellation):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::didCancelAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCancellation):
(-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
(-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
(-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
(-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
(-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
(-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24624
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 25 Jul 2007 15:52:12 +0000 (15:52 +0000)]
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=11756
<rdar://problem/
5286420>
Fix a typo error to really compare the present domain to the domain of the parent of the targeted frame.
* loader/FrameLoader.cpp: (WebCore::FrameLoader::canTarget):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24623
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Wed, 25 Jul 2007 15:50:56 +0000 (15:50 +0000)]
Reviewed by .
- Reverted
* win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24622
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 25 Jul 2007 15:49:22 +0000 (15:49 +0000)]
LayoutTests:
Reviewed by Darin.
- test for http://bugs.webkit.org/show_bug.cgi?id=14758
REGRESSION: Repeated text after line break on facebook.com
* fast/text/reset-emptyRun-expected.checksum: Added.
* fast/text/reset-emptyRun-expected.png: Added.
* fast/text/reset-emptyRun-expected.txt: Added.
* fast/text/reset-emptyRun.html: Added.
WebCore:
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=14758
REGRESSION: Repeated text after line break on facebook.com
Test: fast/text/reset-emptyRun.html
* platform/BidiResolver.h:
(WebCore::::deleteRuns): Re-add a line that was removed for no reason at all
during refactoring in r24485.
* rendering/bidi.cpp:
(WebCore::BidiState::deleteRuns): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24621
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Wed, 25 Jul 2007 15:44:59 +0000 (15:44 +0000)]
Reviewed by .
- Forgot to checking the changes to the skipped list so the win bot doesn't fail.
* win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24620
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 25 Jul 2007 09:57:02 +0000 (09:57 +0000)]
Roll out r24618 as it broke 600+ layout tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24619
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Wed, 25 Jul 2007 09:08:51 +0000 (09:08 +0000)]
LayoutTests:
Reviewed by Oliver.
- <rdar://problem/
5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
- Tests that feed:// urls can still be followed when clicked.
* http/tests/security/feed-urls-from-remote-expected.txt: Added.
* http/tests/security/feed-urls-from-remote.html: Added.
* http/tests/security/resources/feed.html: Added.
* http/tests/security/resources/feed.xml: Added.
* win/Skipped:
WebCore:
Reviewed by Oliver.
- <rdar://problem/
5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
- Check for file:// urls when clicking links, not block all schemes that are treated as local.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::load):
WebKitTools:
Reviewed by Oliver.
- <rdar://problem/
5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
- Change DRT to be able to intercept the requst to load so it can check if a scheme was allowed or not.
* ChangeLog:
* DumpRenderTree/DumpRenderTree.m:
(createWebView):
(dumpRenderTree):
(+[LayoutTestController isSelectorExcludedFromWebScript:]):
(+[LayoutTestController webScriptNameForSelector:]):
(-[LayoutTestController setCustomPolicyDelegate:]):
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/FrameLoadDelegate.h:
* DumpRenderTree/PolicyDelegate.h: Added.
* DumpRenderTree/PolicyDelegate.m: Added.
(-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
* DumpRenderTree/ResourceLoadDelegate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24618
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 25 Jul 2007 05:38:49 +0000 (05:38 +0000)]
Reviewed by Adam Roben
<rdar://problem/
5313504> - Some Back/Forward tests fail on Leopard
* mac/leopard/Skipped: Remove from the skipped list as they work now
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24617
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Wed, 25 Jul 2007 04:37:07 +0000 (04:37 +0000)]
WebCore:
Reviewed by Adam and Justin.
<rdar://problem/
5141779> WebView editableDOMRangeForPoint: & moveDragCaretToPoint: returns last position in DOMText range
Remove bridge implementation for editableDOMRangeForPoint: and moveDragCaretToPoint:.
Now use cross-platform code Editor::rangeForPoint and DragController::placeDragCaret instead.
This required lifting local code from DragController.cpp into the shared methods
Frame::visiblePositionForPoint and Frame::documentAtPoint.
* WebCore.exp:
* editing/Editor.cpp:
(WebCore::Editor::rangeForPoint):
* editing/Editor.h:
* page/DragController.cpp:
(WebCore::DragController::dragEnded):
(WebCore::DragController::performDrag):
(WebCore::DragController::dragEnteredOrUpdated):
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::operationForLoad):
(WebCore::setSelectionToDragCaret):
(WebCore::DragController::concludeDrag):
(WebCore::DragController::placeDragCaret):
* page/DragController.h:
* page/Frame.cpp:
(WebCore::Frame::visiblePositionForPoint):
(WebCore::Frame::documentAtPoint):
* page/Frame.h:
* page/mac/WebCoreFrameBridge.h:
* page/mac/WebCoreFrameBridge.mm:
WebKit:
Reviewed by Adam and Justin.
<rdar://problem/
5141779> WebView editableDOMRangeForPoint: & moveDragCaretToPoint: returns last position in DOMText range
editableDOMRangeForPoint:, moveDragCaretToPoint:, and removeDragCaret now call directly into
WebCore without relying on bridge look up through the now removed _bridgeAtPoint:.
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebView.mm:
(-[WebView moveDragCaretToPoint:]):
(-[WebView removeDragCaret]):
(-[WebView editableDOMRangeForPoint:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24616
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 25 Jul 2007 01:22:19 +0000 (01:22 +0000)]
Rubber-stamped by Adam Roben.
Remove unused .strip files.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Wed, 25 Jul 2007 01:20:59 +0000 (01:20 +0000)]
Bump version for submit
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24613
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Wed, 25 Jul 2007 01:20:19 +0000 (01:20 +0000)]
Adding to the Leopard skip list to avoid a test that hangs due to a CFNetwork bug.
* mac/leopard/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24612
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 25 Jul 2007 01:04:03 +0000 (01:04 +0000)]
Updating skipped list
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24610
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 25 Jul 2007 00:53:02 +0000 (00:53 +0000)]
Updating test to put JS code in the onload handler helps to avoid intermittent failures.
<rdar://problem/
5313531> REGRESSION(Leopard): editing/pasteboard/copy-in-password-field.html sometimes fails
* editing/pasteboard/copy-in-password-field-expected.txt:
* editing/pasteboard/copy-in-password-field.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24609
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 25 Jul 2007 00:02:46 +0000 (00:02 +0000)]
LayoutTests:
Reviewed by Hyatt.
Test for <rdar://problem/
5308492> Computed width for elements with box-sizing: border-box is not equal to the width set in the CSS
* fast/css/getComputedStyle-border-box-expected.txt: Added.
* fast/css/getComputedStyle-border-box.html: Added.
WebCore:
Reviewed by Hyatt.
Fix for <rdar://problem/
5308492> Computed width for elements with box-sizing: border-box is not equal to the width set in the CSS
Test: fast/css/getComputedStyle-border-box.html
* css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
For the width and height properties, when you get the value from the renderer, use the renderer's box sizing value to determine the size.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24608
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 24 Jul 2007 23:36:59 +0000 (23:36 +0000)]
Reviewed by Kevin Decker.
<rdar://problem/
5355781>
REGRESSION: reproducible crash in CoreFoundation!CFRunLoopFinished on Flash pages
Null check the loader.
* plugins/win/PluginStreamWin.cpp:
(WebCore::PluginStreamWin::start):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24607
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kdecker [Tue, 24 Jul 2007 23:31:10 +0000 (23:31 +0000)]
Reviewed by Anders.
<rdar://problem/
4699455> REGRESSION (Safari 2->Safari 3): Adobe Reader 7.0.8 plug-in doesn't work
* Plugins/WebNetscapePluginEmbeddedView.h: Added a #define that renames this class to "WebNetscapePluginDocumentView"
This is necessary because the Adobe 7.x Acrobat plug-in has a hard coded check for a view named "WebNetscapePluginDocumentView"
and will not function correctly if it doesn't find a view in the hierarchy without the old class name.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24606
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Tue, 24 Jul 2007 22:23:02 +0000 (22:23 +0000)]
LayoutTests:
Reviewed by Hyatt and Adam.
Added and updated tests for <rdar://problem/
5130590> REGRESSION: style="width:1px" on <select> element no longer hides the element
The metrics have changed for the anonymous block inside popup buttons.
* fast/forms/menulist-narrow-width-expected.checksum: Added.
* fast/forms/menulist-narrow-width-expected.png: Added.
* fast/forms/menulist-narrow-width-expected.txt: Added.
* fast/forms/menulist-narrow-width.html: Added.
* editing/pasteboard/
4641033-expected.txt:
* editing/pasteboard/
4944770-1-expected.txt:
* editing/pasteboard/
4944770-2-expected.txt:
* editing/pasteboard/select-element-1-expected.txt:
* editing/selection/caret-before-select-expected.txt:
* editing/selection/replaced-boundaries-3-expected.txt:
* editing/selection/select-box-expected.txt:
* editing/selection/select-element-paragraph-boundary-expected.txt:
* fast/block/float/float-avoidance-expected.txt:
* fast/block/margin-collapse/103-expected.txt:
* fast/forms/001-expected.checksum:
* fast/forms/001-expected.png:
* fast/forms/001-expected.txt:
* fast/forms/003-expected.txt:
* fast/forms/004-expected.txt:
* fast/forms/HTMLOptionElement_label01-expected.txt:
* fast/forms/HTMLOptionElement_label02-expected.txt:
* fast/forms/HTMLOptionElement_label03-expected.txt:
* fast/forms/HTMLOptionElement_label04-expected.txt:
* fast/forms/HTMLOptionElement_label06-expected.txt:
* fast/forms/HTMLOptionElement_label07-expected.txt:
* fast/forms/control-restrict-line-height-expected.txt:
* fast/forms/disabled-select-change-index-expected.txt:
* fast/forms/form-element-geometry-expected.txt:
* fast/forms/menulist-separator-painting-expected.txt:
* fast/forms/menulist-width-change-expected.txt:
* fast/forms/option-script-expected.txt:
* fast/forms/option-strip-whitespace-expected.txt:
* fast/forms/option-text-clip-expected.txt:
* fast/forms/select-accesskey-expected.txt:
* fast/forms/select-align-expected.txt:
* fast/forms/select-baseline-expected.txt:
* fast/forms/select-change-listbox-to-popup-expected.txt:
* fast/forms/select-disabled-appearance-expected.txt:
* fast/forms/select-initial-position-expected.txt:
* fast/forms/select-selected-expected.txt:
* fast/forms/select-size-expected.txt:
* fast/forms/select-style-expected.txt:
* fast/forms/select-visual-hebrew-expected.txt:
* fast/forms/select-writing-direction-natural-expected.txt:
* fast/forms/stuff-on-my-optgroup-expected.txt:
* fast/html/keygen-expected.txt:
* fast/invalid/014-expected.txt:
* fast/invalid/residual-style-expected.txt:
* fast/parser/document-write-option-expected.txt:
* fast/replaced/replaced-breaking-expected.txt:
* fast/replaced/replaced-breaking-mixture-expected.txt:
* fast/replaced/three-selects-break-expected.txt:
* fast/replaced/width100percent-expected.txt:
* fast/text/international/bidi-menulist-expected.txt:
* http/tests/navigation/anchor-basic-expected.txt:
* http/tests/navigation/anchor-frames-expected.txt:
* http/tests/navigation/anchor-goback-expected.txt:
* http/tests/navigation/anchor-subframeload-expected.txt:
* http/tests/navigation/javascriptlink-basic-expected.txt:
* http/tests/navigation/javascriptlink-frames-expected.txt:
* http/tests/navigation/javascriptlink-goback-expected.txt:
* http/tests/navigation/javascriptlink-subframeload-expected.txt:
* http/tests/navigation/metaredirect-basic-expected.txt:
* http/tests/navigation/metaredirect-frames-expected.txt:
* http/tests/navigation/metaredirect-goback-expected.txt:
* http/tests/navigation/metaredirect-subframeload-expected.txt:
* http/tests/navigation/post-goback2-expected.txt:
* http/tests/navigation/postredirect-goback2-expected.txt:
* http/tests/navigation/redirect302-basic-expected.txt:
* http/tests/navigation/redirect302-frames-expected.txt:
* http/tests/navigation/redirect302-goback-expected.txt:
* http/tests/navigation/redirect302-subframeload-expected.txt:
* http/tests/navigation/relativeanchor-basic-expected.txt:
* http/tests/navigation/relativeanchor-frames-expected.txt:
* http/tests/navigation/relativeanchor-goback-expected.txt:
* http/tests/navigation/slowmetaredirect-basic-expected.txt:
* http/tests/navigation/slowtimerredirect-basic-expected.txt:
* http/tests/navigation/success200-basic-expected.txt:
* http/tests/navigation/success200-frames-expected.txt:
* http/tests/navigation/success200-frames-loadsame-expected.txt:
* http/tests/navigation/success200-goback-expected.txt:
* http/tests/navigation/success200-loadsame-expected.txt:
* http/tests/navigation/success200-reload-expected.txt:
* http/tests/navigation/success200-subframeload-expected.txt:
* http/tests/navigation/timerredirect-basic-expected.txt:
* http/tests/navigation/timerredirect-frames-expected.txt:
* http/tests/navigation/timerredirect-goback-expected.txt:
* http/tests/navigation/timerredirect-subframeload-expected.txt:
* tables/mozilla/bugs/bug1188-expected.txt:
* tables/mozilla/bugs/bug18359-expected.txt:
* tables/mozilla/bugs/bug2479-3-expected.txt:
* tables/mozilla/bugs/bug2479-4-expected.txt:
* tables/mozilla/bugs/bug29326-expected.txt:
* tables/mozilla/bugs/bug33855-expected.txt:
* tables/mozilla/bugs/bug4382-expected.txt:
* tables/mozilla/bugs/bug96334-expected.txt:
* tables/mozilla/core/margins-expected.txt:
* tables/mozilla/dom/tableDom-expected.txt:
* tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
WebCore:
Reviewed by Hyatt and Adam.
Fix for <rdar://problem/
5130590> REGRESSION: style="width:1px" on <select> element no longer hides the element
Removed hack that forced large padding on popup buttons. Now we put that padding in the inner block, so that
the specified width will be honored.
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::adjustInnerStyle): Set the padding on the inner block based on the metrics provided by the theme.
(WebCore::RenderMenuList::controlClipRect): Clip to the intersection of the inner content box and the outer content box.
This will leave room for the arrows which sit in the inner box padding, and if the inner box ever spills out of the outer box,
that will get clipped too.
(WebCore::RenderMenuList::calcPrefWidths): Add in the inner box's padding and border to the pref widths.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuList): Only inflate the rect for the shadow if the rect is big enough to fit the whole control.
Also, on Leopard, the NSCell will draw outside of a small rect, so add a clip for that case.
(WebCore::RenderThemeMac::paintMenuListButton): Restrict font scale to make sure the arrows will actually fit in the bounds vertically.
Don't draw the arrows if they won't fit horizontally. Reset padding. Since WinIE doesn't honor padding for popups, its not critical to
support padding at this time.
(WebCore::RenderThemeMac::adjustMenuListStyle): Don't set the padding here. Instead, we're going to set the padding on the inner block of the select.
(WebCore::RenderThemeMac::adjustMenuListButtonStyle): ditto.
(WebCore::RenderThemeMac::popupInternalPaddingLeft): Added. Provides internal padding values for RenderMenuList.
(WebCore::RenderThemeMac::popupInternalPaddingRight): ditto.
(WebCore::RenderThemeMac::popupInternalPaddingTop): ditto.
(WebCore::RenderThemeMac::popupInternalPaddingBottom): ditto.
* rendering/RenderThemeMac.h:
* rendering/RenderThemeSafari.cpp: The same changes that were made to RenderThemeMac were made here, with variations for the arrow differences.
This code should be refactored and shared, but now did not seem like the right time to do that refactoring.
(WebCore::RenderThemeSafari::paintMenuList):
(WebCore::RenderThemeSafari::paintMenuListButton):
(WebCore::RenderThemeSafari::adjustMenuListStyle):
(WebCore::RenderThemeSafari::popupInternalPaddingLeft):
(WebCore::RenderThemeSafari::popupInternalPaddingRight):
(WebCore::RenderThemeSafari::popupInternalPaddingTop):
(WebCore::RenderThemeSafari::popupInternalPaddingBottom):
(WebCore::RenderThemeSafari::adjustMenuListButtonStyle):
* rendering/RenderThemeSafari.h:
* rendering/RenderTheme.h: Added to provide internal padding values for RenderMenuList.
(WebCore::RenderTheme::popupInternalPaddingLeft):
(WebCore::RenderTheme::popupInternalPaddingRight):
(WebCore::RenderTheme::popupInternalPaddingTop):
(WebCore::RenderTheme::popupInternalPaddingBottom):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24604
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Tue, 24 Jul 2007 20:58:11 +0000 (20:58 +0000)]
replace the makeprop and makevalues shell scripts by equivalent perl versions. This is required to remove the last shell dependency when building QtWebKit on Windows.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24603
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Tue, 24 Jul 2007 20:43:50 +0000 (20:43 +0000)]
Removed touch of WebKit.rc to prevent rebuilds of the rc file.
The autoversion info can get slightly out of date now, but this isn't a huge problem relative to the rebuilds.
Rubber-stamped by Adam.
* WebKit.vcproj/WebKit.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24602
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat [Tue, 24 Jul 2007 19:49:38 +0000 (19:49 +0000)]
These are no longer necessary or used.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24600
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Tue, 24 Jul 2007 19:03:00 +0000 (19:03 +0000)]
LayoutTests:
Reviewed by Darin.
Tests for http://bugs.webkit.org/show_bug.cgi?id=14714 REGRESSION:
ASSERTION FAILED: i < size() in Vector.h:401 on negative -webkit-
column-width
- and -
http://bugs.webkit.org/show_bug.cgi?id=14718 REGRESSION: ASSERTION
FAILED: i < size() in Vector.h:401 on zero -webkit-column-count
* fast/multicol/negativeColumnWidth-expected.checksum: Added.
* fast/multicol/negativeColumnWidth-expected.png: Added.
* fast/multicol/negativeColumnWidth-expected.txt: Added.
* fast/multicol/negativeColumnWidth.html: Added.
* fast/multicol/zeroColumnCount-expected.checksum: Added.
* fast/multicol/zeroColumnCount-expected.png: Added.
* fast/multicol/zeroColumnCount-expected.txt: Added.
* fast/multicol/zeroColumnCount.html: Added.
WebCore:
Reviewed by Darin.
Fix for http://bugs.webkit.org/show_bug.cgi?id=14714 REGRESSION:
ASSERTION FAILED: i < size() in Vector.h:401 on negative -webkit-
column-width
- and -
http://bugs.webkit.org/show_bug.cgi?id=14718 REGRESSION: ASSERTION
FAILED: i < size() in Vector.h:401 on zero -webkit-column-count
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::calcColumnWidth): Make 1 the minimum value
for column-width and column-count. Since the spec does not address
what to do with negative values for these properties, we are
patching the rendering code instead of the parser.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24599
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 24 Jul 2007 18:44:27 +0000 (18:44 +0000)]
Reviewed by Steve.
<rdar://problem/
5355403>
REGRESSION: 303A2 does not display pdf files with AdobeReader 8.1
Close the file before handing off the file name to the plug-in.
* plugins/win/PluginStreamWin.cpp:
(WebCore::PluginStreamWin::destroyStream):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24596
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Tue, 24 Jul 2007 18:29:35 +0000 (18:29 +0000)]
2007-07-24 Alp Toker <alp.toker@collabora.co.uk>
Reviewed by Adam.
http://bugs.webkit.org/show_bug.cgi?id=14711
RenderThemeGdk's buttons are state-agnostic (pressed, hovered)
Remove unnecessary label from widget instances.
Render check and radio widgets correctly.
Determine the widget state and render it appropriately.
* platform/gdk/RenderThemeGdk.cpp:
(WebCore::RenderThemeGdk::determineState):
(WebCore::RenderThemeGdk::paintCheckbox):
(WebCore::RenderThemeGdk::paintRadio):
(WebCore::RenderThemeGdk::paintButton):
(WebCore::RenderThemeGdk::gtkButton):
(WebCore::RenderThemeGdk::gtkCheckbox):
(WebCore::RenderThemeGdk::gtkRadioButton):
* platform/gdk/RenderThemeGdk.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24595
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 24 Jul 2007 12:56:15 +0000 (12:56 +0000)]
Set the correct svn:mime-type on WebCore/page/inspector/Images/*.png
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24586
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 24 Jul 2007 12:21:21 +0000 (12:21 +0000)]
2007-07-24 Mark Rowe <mrowe@apple.com>
Reviewed by Antti.
<rdar://problem/
5356666> NSMenuItem's seen leaking on buildbot
* platform/mac/ContextMenuItemMac.mm:
(WebCore::ContextMenuItem::releasePlatformDescription): Transfer ownership from the RetainPtr's CF-based retain
count to the Foundation retain count so that callers of releasePlatformDescription can use -[NSObject release]
to dispose of it in a manner that won't leak under Obj-C GC.
* platform/mac/ContextMenuMac.mm:
(WebCore::ContextMenu::appendItem): Release platformItem as we were transferred its ownership by releasePlatformDescription.
(WebCore::ContextMenu::insertItem): ditto.
2007-07-24 Mark Rowe <mrowe@apple.com>
Reviewed by Antti.
<rdar://problem/
5356666> NSMenuItem's seen leaking on buildbot
* WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::contextMenuItemSelected): Release platformItem as we were transferred its ownership by releasePlatformDescription.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24585
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 24 Jul 2007 11:47:17 +0000 (11:47 +0000)]
Roll out r24583, it needs further consideration.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24584
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 24 Jul 2007 11:40:22 +0000 (11:40 +0000)]
2007-07-24 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver.
<rdar://problem/
5356666> NSMenuItem's seen leaking on buildbot
* platform/mac/ContextMenuMac.mm:
(WebCore::ContextMenu::appendItem): Release the platformItem after we take ownership of it from the ContextMenuItem.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24583
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 24 Jul 2007 09:55:33 +0000 (09:55 +0000)]
2007-07-24 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=14684
Hebrew text in Safari chrome is reversed (LTR instead of RTL)
Test: fast/text/drawBidiText.html
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* manual-tests/chrome-bidi-text.html: Added.
* manual-tests/resources/chrome-bidi-text-window.html: Added.
* platform/BidiReorderCharacters.cpp: Removed.
* platform/BidiReorderCharacters.h: Removed.
* platform/BidiResolver.h:
(WebCore::BidiCharacterRun::start): Added accessor method.
(WebCore::BidiCharacterRun::stop): Ditto.
(WebCore::BidiCharacterRun::level): Ditto.
(WebCore::BidiCharacterRun::next): Ditto.
(WebCore::::appendRun): Added default implementation.
* platform/TextStyle.h:
(WebCore::TextStyle::setDirectionalOverride): Added accessor method.
* platform/graphics/GraphicsContext.cpp:
(WebCore::TextRunIterator::TextRunIterator): Added. A BidiResolver-
compliant iterator over the characters in a TextRun.
(WebCore::TextRunIterator::offset):
(WebCore::TextRunIterator::increment):
(WebCore::TextRunIterator::atEnd):
(WebCore::TextRunIterator::current):
(WebCore::TextRunIterator::direction):
(WebCore::TextRunIterator::operator==):
(WebCore::TextRunIterator::operator!=):
(WebCore::GraphicsContext::drawBidiText): Added. Applies the Unicode
Bidi Algorithm to the text and draws the resulting unidirectional runs
in the right order and with the right directionality.
* platform/graphics/GraphicsContext.h:
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::paint): Replaced the use of a character buffer
and BidiReorderCharacters with calling to drawBidiText(). Removed special
handling of '-webkit-rtl-ordering:visual' because that CSS property is an
implementation detail of WebCore's visual Hebrew support, and the UA stylesheet
sets it to 'logical' for this form control. Authors can specify the ordering
using the 'direction' and 'unicode-bidi' properties.
* platform/win/WebCoreTextRenderer.cpp:
(WebCore::isOneLeftToRightRun): Added. Checks if the text consists of
a single left-to-right run, in which case it requires no bidi processing.
(WebCore::doDrawTextAtPoint): Changed to call drawBidiText if the text
is not entirely left-to-right.
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject): Replaced the use of a
character buffer in BidiReorderCharacters with calling to drawBidiText().
Removed special handling of '-webkit-rtl-ordering:visual' for the same reason
stated above.
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintItemForeground): Ditto. Also changed the
run-rounding modes used when drawing to match those used when measuring.
2007-07-24 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- test, updated tests and updated results for
http://bugs.webkit.org/show_bug.cgi?id=14684
Hebrew text in Safari chrome is reversed (LTR instead of RTL)
* fast/forms/HTMLOptionElement_label05-expected.checksum:
* fast/forms/HTMLOptionElement_label05-expected.png:
* fast/forms/listbox-deselect-scroll-expected.checksum:
* fast/forms/listbox-deselect-scroll-expected.png:
* fast/forms/listbox-width-change-expected.checksum:
* fast/forms/listbox-width-change-expected.png:
* fast/forms/option-strip-whitespace-expected.checksum:
* fast/forms/option-strip-whitespace-expected.png:
* fast/forms/select-change-popup-to-listbox-expected.checksum:
* fast/forms/select-change-popup-to-listbox-expected.png:
* fast/forms/select-initial-position-expected.checksum:
* fast/forms/select-initial-position-expected.png:
* fast/text/drawBidiText-expected.checksum: Added.
* fast/text/drawBidiText-expected.png: Added.
* fast/text/drawBidiText-expected.txt: Added.
* fast/text/drawBidiText.html: Added.
* fast/text/international/bidi-listbox-atsui-expected.checksum:
* fast/text/international/bidi-listbox-atsui-expected.png:
* fast/text/international/bidi-listbox-atsui-expected.txt:
* fast/text/international/bidi-listbox-atsui.html: Removed the
visual ordering cases.
* fast/text/international/bidi-listbox-expected.checksum:
* fast/text/international/bidi-listbox-expected.png:
* fast/text/international/bidi-listbox-expected.txt:
* fast/text/international/bidi-listbox.html: Removed the visual ordering
cases because the patch removed special handling of visual ordering.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24582
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Tue, 24 Jul 2007 06:54:36 +0000 (06:54 +0000)]
Reviewed by Steve.
Windows build fix, remove superfluous !
* page/EventHandler.cpp:
(WebCore::EventHandler::keyEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24564
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Tue, 24 Jul 2007 06:31:11 +0000 (06:31 +0000)]
Fixes to versioning script.
Reviewed by Ada.
* WebKit.vcproj/auto-version.sh:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24563
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Tue, 24 Jul 2007 04:11:45 +0000 (04:11 +0000)]
Implement IWebHistoryItem::[set]AlternateTitle
WebCore:
Add an assignment operator for BString that takes a BSTR
Reviewed by Geoff and Oliver.
* platform/win/BString.cpp:
(WebCore::BString::operator=):
* platform/win/BString.h:
WebKit/win:
Implement IWebHistoryItem::[set]AlternateTitle
The argument types were reversed for these two methods, so I fixed that as
well.
Reviewed by Geoff and Oliver.
* Interfaces/IWebHistoryItem.idl:
* WebHistoryItem.cpp:
(WebHistoryItem::setAlternateTitle): Implemented.
(WebHistoryItem::alternateTitle): Implemented.
* WebHistoryItem.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24562
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 24 Jul 2007 03:59:08 +0000 (03:59 +0000)]
LayoutTests:
Reviewed by Geoff.
<rdar://problem/
5354455> Word selection when right-clicking can be confusing (14728)
* editing/selection/
5354455-1-expected.checksum: Added.
* editing/selection/
5354455-1-expected.png: Added.
* editing/selection/
5354455-1-expected.txt: Added.
* editing/selection/
5354455-1.html: Added.
* editing/selection/
5354455-2-expected.checksum: Added.
* editing/selection/
5354455-2-expected.png: Added.
* editing/selection/
5354455-2-expected.txt: Added.
* editing/selection/
5354455-2.html: Added.
WebCore:
Reviewed by Geoff.
<rdar://problem/
5354455> Word selection when right-clicking can be confusing (14728)
* page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEvent): In non-editable content,
only do word selection over text. In editable content, we will continue
to select images, line breaks and other elements on right-clicks, to match
TextEdit. For now, in editable content, we'll live with the cases where
positionForPoint creates selections that aren't underneath the mouse. These
aren't regressions because we've always done word selection on right clicks
in editable content.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24561
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 24 Jul 2007 03:09:32 +0000 (03:09 +0000)]
LayoutTests:
Reviewed by Oliver.
<rdar://problem/
5335354>
REGRESSION(r21359-r21368): Can't edit inside RTEF editable region
* fast/dom/Document/open-with-pending-load-expected.txt: Added.
* fast/dom/Document/open-with-pending-load.html: Added.
WebCore:
Reviewed by Oliver.
<rdar://problem/
5335354>
REGRESSION(r21359-r21368): Can't edit inside RTEF editable region
If Document::open is called and there's a pending load that has not yet started,
that load should be cancelled.
* dom/Document.cpp:
(WebCore::Document::open):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24560
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 24 Jul 2007 03:01:26 +0000 (03:01 +0000)]
Reviewed by Geoff.
<rdar://problem/
5121461> REGRESSION: Unable to load JigZone puzzle
* bindings/jni/jni_jsobject.cpp:
(JavaJSObject::createNative):
Call RootObject::gcProtect on the global object, thereby putting it in the
"protect count" set which is used for checking if a native handle is valid.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24559
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 24 Jul 2007 01:22:46 +0000 (01:22 +0000)]
Reviewed by Mark.
Remove http/tests/multipart/invalid-image-data.html which no longer fails on Leopard.
* mac/leopard/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24558
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 24 Jul 2007 01:00:06 +0000 (01:00 +0000)]
<rdar://problem/
5228167> REGRESSION: editing/execCommand/
5119244.html failing on Leopard
Removed another use of the ⎷ entity. See below.
* editing/execCommand/
5119244-expected.checksum:
* editing/execCommand/
5119244-expected.png:
* editing/execCommand/
5119244-expected.txt:
* editing/execCommand/
5119244.html:
* mac/leopard/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24557
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 24 Jul 2007 00:46:57 +0000 (00:46 +0000)]
Reviewed by Oliver.
<rdar://problem/
5228164> REGRESSION: editing/deleting/
5144139-2.html fails on Leopard
Removed the use of the ⎷ entity, which is available on
Leopard but not Tiger. Perhaps because it is not available in Ahem
but is available in some fallback font that ships with Leopard but not Tiger.
It's OK to remove because its use wasn't necessary to test the fix for
5144139.
* editing/deleting/
5144139-2-expected.checksum:
* editing/deleting/
5144139-2-expected.png:
* editing/deleting/
5144139-2-expected.txt:
* editing/deleting/
5144139-2.html:
* mac/leopard/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24556
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan [Tue, 24 Jul 2007 00:39:26 +0000 (00:39 +0000)]
2007-07-23 Ada Chan <adachan@apple.com>
Reviewed by Steve.
Added a new text drawing method that allows caller to override the font smoothing level.
* WebKit.vcproj/WebKit.def:
* WebKit.vcproj/WebKit_debug.def:
* WebKitGraphics.cpp:
(WebDrawText):
* WebKitGraphics.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24553
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan [Tue, 24 Jul 2007 00:37:05 +0000 (00:37 +0000)]
2007-07-23 Ada Chan <adachan@apple.com>
Reviewed by Steve.
Update WebKitSystemInterface.{h,lib}.
* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:
* win/lib/WebKitSystemInterface_debug.lib:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24552
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 24 Jul 2007 00:04:32 +0000 (00:04 +0000)]
Reviewed by Hyatt.
<rdar://problem/
5242145> REGRESSION: Clicking on symbol in documentation often doesn't scroll to symbol
A renderer for the anchor wasn't always available at the time parsing finished. So we need
to bail out of gotoAnchor if stylesheets are pending and remember to call gotoAnchor later
once all of the pending stylesheets load.
* dom/Document.cpp:
(WebCore::Document::Document): Initialize m_gotoAnchorNeededAfterStylesheetsLoad to false.
(WebCore::Document::stylesheetLoaded): If we have no more pending stylesheets, call gotoAnchor if needed.
* dom/Document.h:
(WebCore::Document::gotoAnchorNeededAfterStylesheetsLoad): New method.
(WebCore::Document::setGotoAnchorNeededAfterStylesheetsLoad): Ditto.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::gotoAnchor): Bail early if the document still has pending stylesheets.
* loader/FrameLoader.h: Make gotoAnchor() public.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24550
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Mon, 23 Jul 2007 23:16:47 +0000 (23:16 +0000)]
Reviewed by Darin
- fixed <rdar://problem/
5327887> Printing Mail note (or Safari page) with misspelled word prints red underline
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
When printing, bail out without doing any work. Also moved a couple of lines down below another early
bailout since they were pointless above it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24549
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat [Mon, 23 Jul 2007 21:58:25 +0000 (21:58 +0000)]
Fix qt DRT to suppress js popup alerts and log instead.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24547
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 23 Jul 2007 21:35:44 +0000 (21:35 +0000)]
* pcre/pcre_compile.c: Roll back a tiny accidental change in the unused !JAVASCRIPT
side of an #ifdef. This has no effect when using PCRE in JAVASCRIPT mode as we do,
but seems worth rolling back.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24546
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 23 Jul 2007 21:29:06 +0000 (21:29 +0000)]
Build fix, newer Leopard builds expect GCC_ENABLE_OBJC_GC to have a value of 'supported'.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24545
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Mon, 23 Jul 2007 21:03:14 +0000 (21:03 +0000)]
LayoutTests:
Reviewed by Darin.
Added initial pseudo-hangul IM, and tests for behaviour of hangul (<rdar://problem/
5352152>)
Updated keydown-keypress-preventDefault to be correct, and to have an demonstrate that keys have been inserted.
Updated kotoeri test to perform more validation and check against updated behaviour
* editing/input/mac/hangul-enter-confirms-and-sends-keypress-expected.txt: Added.
* editing/input/mac/hangul-enter-confirms-and-sends-keypress.html: Added.
* editing/input/mac/hangul.js: Added.
* editing/input/mac/kotoeri-enter-to-confirm-and-newline.html:
* fast/events/keydown-keypress-preventDefault-expected.txt:
* fast/events/keydown-keypress-preventDefault.html:
WebCore:
Reviewed by Darin.
<rdar://problem/
5353577> WebKit key event behaviour needs to better match other browsers keyevent behaviour
<rdar://problem/
5352152> REGRESSION (24399-24479): Pressing Enter in a search field at apple.com no longer starts a search with Korean IM
<rdar://problem/
5352649> WebKit should send keyDown event on autorepeat keyDowns
http://bugs.webkit.org/show_bug.cgi?id=14690
Perform Input Method call first so that our behaviour is determined by whether or not
the input method has actually handle the event, rather than by making guesses based
on the existences of marked text. This fixes issues with IMs that have side effects
even on events they do not handle.
Refactored the code in order to improve clarity given the hoisting required by performing
the IM call earlier.
* page/EventHandler.cpp:
(WebCore::EventHandler::keyEvent):
WebKit:
Reviewed by Darin.
We have to be able to support insertText: followed by doCommandBySelector: in
order to support the 2- and 3-Set Korean and RuSwitcher IMs at least.
* WebView/WebHTMLView.mm:
(-[WebHTMLView insertText:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24542
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Mon, 23 Jul 2007 20:27:19 +0000 (20:27 +0000)]
LayoutTests:
Reviewed by Darin.
<rdar://problem/
5045711>
http://bugs.webkit.org/show_bug.cgi?id=12938
Google calendar settings page crashes
* fast/dom/destroy-selected-radio-button-crash-expected.txt: Added.
* fast/dom/destroy-selected-radio-button-crash.html: Added.
WebCore:
Reviewed by Darin.
<rdar://problem/
5045711>
http://bugs.webkit.org/show_bug.cgi?id=12938
Google calendar settings page crashes
Move handling of checked radio buttons to a new class, HTMLFormElement::CheckedRadioButtons.
Each <form> element has an instance of this class. For radio buttons without a containing
form, the document has an instance of HTMLFormElement::CheckedRadioButtons where the
state of those radio buttons will be stored.
be stored.
This also fixes another bug where removing a checked radio button that does not have a
containing form would not remove the radio button from the checked radio buttons map,
which could lead to a crash due to a dangling pointer.
* dom/Document.cpp:
(WebCore::Document::~Document):
* dom/Document.h:
(WebCore::Document::checkedRadioButtons):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::registerFormElement):
(WebCore::HTMLFormElement::removeFormElement):
(WebCore::HTMLFormElement::CheckedRadioButtons::didCheckButton):
(WebCore::HTMLFormElement::CheckedRadioButtons::checkedButtonForGroup):
(WebCore::HTMLFormElement::CheckedRadioButtons::removeButtonIfChecked):
* html/HTMLFormElement.h:
(WebCore::HTMLFormElement::checkedRadioButtons):
* html/HTMLGenericFormElement.cpp:
(WebCore::HTMLGenericFormElement::insertedIntoTree):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::~HTMLInputElement):
(WebCore::checkedRadioButtons):
(WebCore::HTMLInputElement::isKeyboardFocusable):
(WebCore::HTMLInputElement::setInputType):
(WebCore::HTMLInputElement::parseMappedAttribute):
(WebCore::HTMLInputElement::setChecked):
(WebCore::HTMLInputElement::preDispatchEventHandler):
(WebCore::HTMLInputElement::willMoveToNewOwnerDocument):
* manual-tests/remove-form-node-with-radio-buttons-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24541
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Mon, 23 Jul 2007 20:23:12 +0000 (20:23 +0000)]
Reverting change 24535 now that a solution has been found that doesn't
involve exposing an interface unnecessarily.
* WebView/WebHTMLView.mm:
* WebView/WebHTMLViewPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24540
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Mon, 23 Jul 2007 18:51:02 +0000 (18:51 +0000)]
Add layout test for continuation hang.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24539
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Mon, 23 Jul 2007 18:50:20 +0000 (18:50 +0000)]
Fix for
5350587, hang in iExploder text 8101. The code that painted outlines for continuations was buggy
in that it assumed the chain was always inline-block-inline, but this is only true for the innermost chained
continuation. To make this more robust, we always just use the inline's containing block's containing block,
which should be guaranteed to enclose all renderers in the continuation chain. In addition, there is now a
null check (to guarantee no more hangs) and an assert (to check if we hit this situation again where the block
used to paint does not properly enclose the continuation chain).
Reviewed by beth
fast/inline/outline-continuation.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintContinuationOutlines):
* rendering/InlineFlowBox.cpp:
(WebCore::RenderInline::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24538
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke [Mon, 23 Jul 2007 18:16:02 +0000 (18:16 +0000)]
2007-07-22 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Adam.
Add WebKit/gtk/Api and WebCoreSupport API to the INCLUDEPATH to allow GdkLauncher to be
build against it.
* WebKit.pri:
WebCore:
2007-07-22 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Adam.
WARNING: NO TEST CASES ADDED OR CHANGED
Add the WebKit/Gtk API to the buildsystem, ask qmake to create a
pkg-config file and install headers and libraries.
Start to emit signals from FrameLoaderClientGdk, hide the kit Frame
inside the the FrameLoaderClientGdk.
Move ChromeClientGdk to WebKit/gtk/WebCoreSupport
* WebCore.pro:
* loader/gdk/FrameLoaderClientGdk.cpp:
* loader/gdk/FrameLoaderClientGdk.h:
* platform/gdk/ChromeClientGdk.h: Removed.
* platform/gdk/FrameGdk.cpp: Remove code not belonging here
* platform/gdk/FrameGdk.h:
* platform/gdk/ScrollViewGdk.cpp: The gdkDrawable won't exist at that time and it is fine
* platform/gdk/TemporaryLinkStubs.cpp: Removed ChromeClientGdk stubs
WebKit:
2007-07-22 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Adam.
Add the first API and partial implementation of the WebKit/Gtk port as
of http://bugs.webkit.org/show_bug.cgi?id=14678.
The delegates of WebView will be modeled as signals. Delegates like the
WebPolicyDelegate will be implemented as signals with default handlers.
Start moving files to WebKit/gtk/WebCoreSupport.
* gtk: Added.
* gtk/Api: Added.
* gtk/Api/headers.pri: Added.
* gtk/Api/webkitgtk-marshal.list: Added.
* gtk/Api/webkitgtkdefines.h: Added.
* gtk/Api/webkitgtkframe.cpp: Added.
* gtk/Api/webkitgtkframe.h: Added.
* gtk/Api/webkitgtkframedata.cpp: Added.
* gtk/Api/webkitgtkframedata.h: Added.
* gtk/Api/webkitgtkglobal.cpp: Added.
* gtk/Api/webkitgtkglobal.h: Added.
* gtk/Api/webkitgtknetworkrequest.cpp: Added.
* gtk/Api/webkitgtknetworkrequest.h: Added.
* gtk/Api/webkitgtkpage.cpp: Added.
* gtk/Api/webkitgtkpage.h: Added.
* gtk/Api/webkitgtkprivate.cpp: Added.
* gtk/Api/webkitgtkprivate.h: Added.
* gtk/Api/webkitgtksettings.cpp: Added.
* gtk/Api/webkitgtksettings.h: Added.
* gtk/WebCoreSupport: Added.
* gtk/WebCoreSupport/ChromeClientGdk.cpp: Added.
(WebCore::ChromeClientGdk::ChromeClientGdk):
(WebCore::ChromeClientGdk::chromeDestroyed):
(WebCore::ChromeClientGdk::windowRect):
(WebCore::ChromeClientGdk::setWindowRect):
(WebCore::ChromeClientGdk::pageRect):
(WebCore::ChromeClientGdk::scaleFactor):
(WebCore::ChromeClientGdk::focus):
(WebCore::ChromeClientGdk::unfocus):
(WebCore::ChromeClientGdk::createWindow):
(WebCore::ChromeClientGdk::createModalDialog):
(WebCore::ChromeClientGdk::show):
(WebCore::ChromeClientGdk::canRunModal):
(WebCore::ChromeClientGdk::runModal):
(WebCore::ChromeClientGdk::setToolbarsVisible):
(WebCore::ChromeClientGdk::toolbarsVisible):
(WebCore::ChromeClientGdk::setStatusbarVisible):
(WebCore::ChromeClientGdk::statusbarVisible):
(WebCore::ChromeClientGdk::setScrollbarsVisible):
(WebCore::ChromeClientGdk::scrollbarsVisible):
(WebCore::ChromeClientGdk::setMenubarVisible):
(WebCore::ChromeClientGdk::menubarVisible):
(WebCore::ChromeClientGdk::setResizable):
(WebCore::ChromeClientGdk::closeWindowSoon):
(WebCore::ChromeClientGdk::canTakeFocus):
(WebCore::ChromeClientGdk::takeFocus):
(WebCore::ChromeClientGdk::canRunBeforeUnloadConfirmPanel):
(WebCore::ChromeClientGdk::runBeforeUnloadConfirmPanel):
(WebCore::ChromeClientGdk::addMessageToConsole):
(WebCore::ChromeClientGdk::runJavaScriptAlert):
(WebCore::ChromeClientGdk::runJavaScriptConfirm):
(WebCore::ChromeClientGdk::runJavaScriptPrompt):
(WebCore::ChromeClientGdk::setStatusbarText):
(WebCore::ChromeClientGdk::shouldInterruptJavaScript):
(WebCore::ChromeClientGdk::tabsToLinks):
(WebCore::ChromeClientGdk::windowResizerRect):
(WebCore::ChromeClientGdk::addToDirtyRegion):
(WebCore::ChromeClientGdk::scrollBackingStore):
(WebCore::ChromeClientGdk::updateBackingStore):
(WebCore::ChromeClientGdk::mouseDidMoveOverElement):
(WebCore::ChromeClientGdk::setToolTip):
(WebCore::ChromeClientGdk::print):
* gtk/WebCoreSupport/ChromeClientGdk.h: Added.
WebKitTools:
2007-07-22 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Adam.
Make the GdkLauncher use the new WebKit/Gtk API. Change webkitdirs.pm to
honor --qmakearg for the Gdk/Gtk build as well.
* GdkLauncher/main.cpp: Switch to the new API
* Scripts/webkitdirs.pm: Allow to specify --qmakearg, e.g. to control the WEBKIT_{INC,LIB}_DIR
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24537
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Mon, 23 Jul 2007 17:16:37 +0000 (17:16 +0000)]
Implement IDOMElement::setAttribute
This method was mistakenly called "setResult" in DOMCore.idl, so I
fixed that as well.
Needed for <rdar://problem/
5314906>.
Reviewed by Ada.
* DOMCoreClasses.cpp:
(DOMElement::setAttribute): Implemented/renamed.
* DOMCoreClasses.h: Renamed setResult => setAttribute.
* DOMHTMLClasses.h: Ditto.
* Interfaces/DOMCore.idl: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24536
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Mon, 23 Jul 2007 16:37:16 +0000 (16:37 +0000)]
Reviewed by Oliver Hunt.
Expose [WebHTMLView hasMarkedText] to
fix <rdar://problem/
4830074> autocomplete breaks Japanese typing
* WebView/WebHTMLView.mm:
* WebView/WebHTMLViewPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24535
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 23 Jul 2007 10:26:02 +0000 (10:26 +0000)]
Reviewed by Oliver.
- fix remaining problems with Window shadowing
* kjs/nodes.cpp:
(VarDeclNode::evaluate): Tweak the special case a little.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24534
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 23 Jul 2007 08:48:04 +0000 (08:48 +0000)]
Reviewed by Oliver.
- fix Window shadowing regressions caused by the previous commit.
* kjs/nodes.cpp:
(VarDeclNode::evaluate): Handle the case of global scope specially.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24533
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 23 Jul 2007 07:10:35 +0000 (07:10 +0000)]
Reviewed by Darin.
-fixed <rdar://problem/
5353293> REGRESSION (r24287): 1% i-Bench JS slowdown from JavaScript compatibility fix (14719)
http://bugs.webkit.org/show_bug.cgi?id=14719
My fix for this actually resulted in JS iBench being 1% faster than before the regression
and the Celtic Kane benchmark being 5% faster than before the regression.
* kjs/nodes.cpp:
(VarDeclNode::handleSlowCase): factored out the slow code path to be out of line.
(VarDeclNode::evaluate): I did a couple of things:
(1) Don't check if the variable is already declared by looking for the property in
the variable object, that code path was dead code.
(2) Special-case the common case where the top of the scope and the variable object
are the same; in that case the variable must always be in the variable object.
(3) Don't return a jsString() of the variable name, nothing uses the return value
from this node types evaluate method.
* kjs/nodes.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24532
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 23 Jul 2007 05:45:31 +0000 (05:45 +0000)]
Reviewed by Adam.
<rdar://problem/
5353174> REGRESSION: 1% JavaScript performance regression fro Window refactoring (14717)
http://bugs.webkit.org/show_bug.cgi?id=14717
* bindings/js/kjs_window.cpp:
* bindings/js/kjs_window.h:
(KJS::Window::impl): inlined
* page/DOMWindow.cpp:
* page/DOMWindow.h:
(WebCore::DOMWindow::frame): inlined
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24531
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 23 Jul 2007 05:42:46 +0000 (05:42 +0000)]
Fix typo.
* fast/dom/Window/window-function-name-getter-precedence.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24530
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 23 Jul 2007 05:30:22 +0000 (05:30 +0000)]
* platform/ContextMenu.cpp: Added missing include.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24529
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 23 Jul 2007 05:28:37 +0000 (05:28 +0000)]
LayoutTests:
Reviewed by Darin.
Test for http://bugs.webkit.org/show_bug.cgi?id=14682
REGRESSION(24285-24399): alerts do not appear at W3C RTL test page
* fast/dom/Window/window-function-name-getter-precedence-expected.txt: Added.
* fast/dom/Window/window-function-name-getter-precedence.html: Added.
WebCore:
Reviewed by Darin.
Fix for http://bugs.webkit.org/show_bug.cgi?id=14682
REGRESSION(24285-24399): alerts do not appear at W3C RTL test page
Test: fast/dom/Window/window-function-name-getter-precedence.html
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::customGetOwnPropertySlot): Make sure to return functions
before the custom name getter.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24528
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 23 Jul 2007 05:25:34 +0000 (05:25 +0000)]
Reviewed by Adam.
- fix <rdar://problem/
5353263> ContextMenuItem and ContextMenu objects leaking (seen on buildbot)
* platform/ContextMenu.cpp:
(WebCore::separatorItem): Return an auto_ptr instead of a raw pointer, since this function
creates an object that's the caller's responsibility to delete.
(WebCore::createAndAppendFontSubMenu): Create the context menu on the stack, not the heap,
since setSubMenu does not take ownership, and hence the objects were leaking.
(WebCore::createAndAppendSpellingAndGrammarSubMenu): Ditto.
(WebCore::createAndAppendSpellingSubMenu): Ditto.
(WebCore::createAndAppendSpeechSubMenu): Ditto.
(WebCore::createAndAppendWritingDirectionSubMenu): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24527
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose [Mon, 23 Jul 2007 05:00:34 +0000 (05:00 +0000)]
Reviewed by Adam Roben.
Add information on getting a useful crash log on Mac and Windows.
* nav.inc:
* quality/crashlogs.html: Added.
* quality/mac_reportbox.jpg: Added.
* quality/mac_viewtrace.jpg: Added.
* quality/win_installwatson.jpg: Added.
* quality/win_watsongui.jpg: Added.
* quality/win_watsoninstalled.jpg: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24526
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 23 Jul 2007 04:38:50 +0000 (04:38 +0000)]
* DumpRenderTree/TextInputController.m: (-[TextInputController interpretKeyEvents:withSender:]):
Fix a leak by releasing the array used here.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24525
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 22 Jul 2007 22:47:25 +0000 (22:47 +0000)]
JavaScriptCore:
Reviewed by Kevin Decker.
- fix <rdar://problem/
5126394> REGRESSION: Crash after clicking back button in test application (13250)
http://bugs.webkit.org/show_bug.cgi?id=13250
* bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue):
If the object returns 0 for _imp, convert that to "undefined", since callers
can't cope with a JSValue of 0.
WebCore:
Reviewed by Kevin Decker.
- fix <rdar://problem/
5126394> REGRESSION: Crash after clicking back button in test application (13250)
http://bugs.webkit.org/show_bug.cgi?id=13250
* bindings/objc/WebScriptObject.mm:
(_didExecute): Removed unnecessary check for isValid() since the _rootObject method already
takes care of that check.
(-[WebScriptObject _imp]): Made this return 0 if there is not a valid rootObject.
(-[WebScriptObject _isSafeScript]): Made this always return false if there is not a valid
rootObject, eliminating the need to check _rootObject for nil if the code is checking _isSafeScript.
(-[WebScriptObject callWebScriptMethod:withArguments:]): Removed check of _rootObject, since it's
immediately followed by a check of _isSafeScript. Removed awkward conversion of name from NSString *
to KJS::Identifier and did it using WebCore::String instead -- makes it clear that there's no
arbitrary JavaScript execution after _isSafeScript and before _imp, so we don't need to null-check
the _imp pointer. Added a second check of _isSafeScript after calling get to get the function
object, since arbitrary changes could occur in there, including navigation to a new frame.
This also takes care of null checking the second call to _imp.
(-[WebScriptObject evaluateWebScript:]): Removed check of _rootObject, since it's
immediately followed by a check of _isSafeScript. Removed awkward conversion of script from NSString *
to KJS::Identifier and did it using WebCore::String instead -- makes it clear that there's no
arbitrary JavaScript execution after _isSafeScript and before _imp, so we don't need to null-check
the _imp pointer.
(-[WebScriptObject setValue:forKey:]): Removed check of _rootObject, since it's
immediately followed by a check of _isSafeScript. Removed awkward conversion of key from NSString *
to KJS::Identifier and did it using WebCore::String instead -- makes it clear that there's no
arbitrary JavaScript execution after _isSafeScript and before _imp, so we don't need to null-check
the _imp pointer.
(-[WebScriptObject valueForKey:]): Ditto.
(-[WebScriptObject removeWebScriptKey:]): Ditto.
(-[WebScriptObject stringRepresentation]): Removed check of _rootObject, since it's
immediately followed by a check of _isSafeScript. Removed unnecessary local variable
and const_cast from the call to the _imp method.
(-[WebScriptObject webScriptValueAtIndex:]): Removed check of _rootObject, since it's
immediately followed by a check of _isSafeScript.
(-[WebScriptObject setWebScriptValueAtIndex:value:]): Ditto.
(-[WebScriptObject JSObject]): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24524
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sun, 22 Jul 2007 22:24:59 +0000 (22:24 +0000)]
WebKitTools:
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=14713
Script to update iExploder cssproperties.in file based on CSSPropertyNames.in
Added script to update WebKitTools/iExploder/htdocs/cssproperties.in based on the contents
of WebCore/css/CSSPropertyNames.in. Also updated cssproperties.in.
* Scripts/update-iexploder-cssproperties: Added.
* iExploder/htdocs/cssproperties.in: Updated by running update-iexploder-cssproperties script.
Added new CSS3 property section and Moved box-sizing property to it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24523
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Sun, 22 Jul 2007 21:10:57 +0000 (21:10 +0000)]
LayoutTests:
Reviewed by Sam.
Moving input method tests to editing/input/mac
* editing/input/mac: Copied from fast/events/inputmethods.
* fast/events/inputmethods: Removed.
* fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline-expected.txt: Removed.
* fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline.html: Removed.
* fast/events/inputmethods/kotoeri.js: Removed.
* fast/events/inputmethods/logger.js: Removed.
* win/Skipped:
qt:
Reviewed by Sam.
Add Mac input methods to qt skip list
* Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24522
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 22 Jul 2007 20:32:11 +0000 (20:32 +0000)]
Updated reviewers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24521
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 22 Jul 2007 20:31:40 +0000 (20:31 +0000)]
Reviewed by Anders.
- speculative fix for <rdar://problem/
5337500> CrashTracer: [USER] 4 crashes in Mail
at WebCore::HTMLImageElement::isURLAttribute(WebCore::Attribute*) const
* editing/markup.cpp: Added AttributeChange class.
(WebCore::completeURLs): Changed function so that all the URL completion is done in
a separate pass after finding all the URL attributes. This is safer, since actually
applying an attribute change could have any arbitrary effect on the document; it's
tricky to iterate a document while it's being modified and we don't have the checks
here that would be needed to make that work in pathological cases.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24520
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Sun, 22 Jul 2007 20:02:26 +0000 (20:02 +0000)]
Reviewed by Adam.
Add the input methods tests to the windows skip list
until we work to how to make them platform agnostic
* win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24519
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 22 Jul 2007 19:51:33 +0000 (19:51 +0000)]
Update Bugzilla bug number in Radar bug title based on feedback from Mitz.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24518
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Sun, 22 Jul 2007 19:46:15 +0000 (19:46 +0000)]
LayoutTests:
Reviewed by Darin.
Initial input method test case, this tests the behaviour of the
enter key in our "kotoeri" engine.
* fast/events/inputmethods: Added.
* fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline-expected.txt: Added.
* fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline.html: Added.
* fast/events/inputmethods/kotoeri.js: Added.
* fast/events/inputmethods/logger.js: Added.
WebKitTools:
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=14710
Add preliminary support for testing Input Method/WebKit behaviour and interaction
in DRT. This provides the NSTextInput API which is most of what should be necessary
to mimic the event sequences Input Methods trigger.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/TextInputController.h:
* DumpRenderTree/TextInputController.m:
(-[WebHTMLView interpretKeyEvents:]):
(+[TextInputController isSelectorExcludedFromWebScript:]):
(+[TextInputController webScriptNameForSelector:]):
(-[TextInputController initWithWebView:]):
(-[TextInputController dealloc]):
(-[TextInputController textInput]):
(-[TextInputController setInputMethodHandler:]):
(-[TextInputController interpretKeyEvents:withSender:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24517
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 22 Jul 2007 19:43:43 +0000 (19:43 +0000)]
Reviewed by Adam.
- fix <rdar://problem/
5350604> REGRESSION: Crash in inspector controller code after
clicking back button in test application (13250)
* page/InspectorController.cpp: (WebCore::InspectorController::addScriptResource):
Replace an assertion that was firing with some code that at least doesn't immediately crash.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24516
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 22 Jul 2007 19:08:44 +0000 (19:08 +0000)]
* StringsNotToBeLocalized.txt: Updated for recent changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24515
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 22 Jul 2007 18:43:49 +0000 (18:43 +0000)]
Reviewed by Anders.
- improve the fix for <rdar://problem/
5298816> Crash redirecting message,
in -[SharedBufferData initWithSharedBuffer:]; fixes a crash seen on the buildbot
* loader/DocLoader.cpp: (WebCore::DocLoader::~DocLoader): Call setDocLoader(0) on all
the resources so they don't try to use a stale DocLoader pointer later.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24514
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Sat, 21 Jul 2007 22:29:46 +0000 (22:29 +0000)]
Reviewed by Sam Weinig.
- fixed typos and markup in the following manual tests
* manual-tests/accidental-strict-mode.html:
* manual-tests/caretScrolling.html:
* manual-tests/close-on-closedWindow.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24513
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Sat, 21 Jul 2007 22:27:34 +0000 (22:27 +0000)]
LayoutTests:
Reviewed by Mitz.
Update tests for <rdar://problem/
5352013>
The computed style for background-position is wrong for the initial value
* fast/css/computed-style-expected.txt:
* fast/css/computed-style-without-renderer-expected.txt:
* fast/css/getComputedStyle-background-position-expected.txt:
WebCore:
Reviewed by Mitz.
Patch for <rdar://problem/
5352013>
The computed style for background-position is wrong for the initial value
- Set the initial value for background-position-x and background-position-y (and
therefore background-position) to 0% instead of 0px.
* rendering/RenderStyle.cpp:
(WebCore::BackgroundLayer::BackgroundLayer):
* rendering/RenderStyle.h:
(WebCore::RenderStyle::initialBackgroundXPosition):
(WebCore::RenderStyle::initialBackgroundYPosition):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24512
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan [Sat, 21 Jul 2007 22:07:28 +0000 (22:07 +0000)]
2007-07-21 Ada Chan <adachan@apple.com>
Reviewed by Adam.
Fix bug 14706: http://bugs.webkit.org/show_bug.cgi?id=14706
Need to set the last visited time before calling WebHistory::addItem().
* WebHistory.cpp:
(WebHistory::addItemForURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24511
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sat, 21 Jul 2007 21:38:09 +0000 (21:38 +0000)]
Fix REGRESSION: Right-click/control-click broken
http://bugs.webkit.org/show_bug.cgi?id=14658
<rdar://problem/
5346830>
Reviewed by Mitz.
* WebCoreSupport/WebContextMenuClient.mm:
(fixMenusToSendToOldClients): Update defaultItemsCount after removing
items from the defaultItems array.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24510
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sat, 21 Jul 2007 11:10:27 +0000 (11:10 +0000)]
Versioning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24507
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Sat, 21 Jul 2007 06:46:13 +0000 (06:46 +0000)]
Reviewed by Adele.
<rdar://problem/
5319438> REGRESSION: Cannot paste into an active inline input area (14522)
http://bugs.webkit.org/show_bug.cgi?id=14522
AppKit sends noop: to -[WebHTMLView doCommandBySelector:] when an IM does not handle event,
we now check this as it is necessary to work around some IMs that do send messages
(such as insertText: rather than unmarkText: to confirm a composition)
* WebView/WebHTMLView.mm:
(-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]):
(-[WebHTMLView doCommandBySelector:]):
* WebView/WebHTMLViewInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24505
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Sat, 21 Jul 2007 03:25:05 +0000 (03:25 +0000)]
Patch from Adam Treat to add the rest of the policy information (action type)
and a signal for initial layout
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24504
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Sat, 21 Jul 2007 02:29:07 +0000 (02:29 +0000)]
WebCore:
Reviewed by Adele and Andersca
<rdar://problem/
5336105> - WebBackForwardList created from scratch is unusable (always leads to crash)
* WebCore.exp: Export the BackForwardList c'tor so WebKit can create one explicitly
WebKit:
Reviewed by Adele and Andersca
<rdar://problem/
5336105> - WebBackForwardList created from scratch is unusable (always leads to crash)
* History/WebBackForwardList.mm:
(-[WebBackForwardList init]): Have a default initializer that uses an empty BackFowardList not associated with a page.
* WebView/WebFrame.mm:
(kit): For clarity's sake, this should return nil, not 0
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24503
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Sat, 21 Jul 2007 02:26:24 +0000 (02:26 +0000)]
LayoutTests:
Reviewed by Beth Dakin.
Tests for <rdar://problem/
5351901>
Computed value of border-position should return a CSSValueList, not a CSSPrimitiveValue
* fast/css/computed-style-expected.txt:
* fast/css/computed-style-without-renderer-expected.txt:
* fast/css/getComputedStyle-background-position-expected.txt: Added.
* fast/css/getComputedStyle-background-position.html: Added.
WebCore:
Reviewed by Beth Dakin.
Fix for <rdar://problem/
5351901>
Computed value of border-position should return a CSSValueList, not a CSSPrimitiveValue
- Return a space separated CSSValueList for background-position
instead of a CSSPrimitiveValue (string type).
- Remove the "else if (renderer)" case as it never returns a different
value than just calling length.value().
- Make background-position-x and background-position-y behave like
background-position. Fix case of initial value return 'auto' instead
of 0.
Test: fast/css/getComputedStyle-background-position.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24502
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Sat, 21 Jul 2007 01:38:16 +0000 (01:38 +0000)]
Build fix for non-Mac platforms.
* bindings/js/GCController.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24501
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sat, 21 Jul 2007 01:23:51 +0000 (01:23 +0000)]
Reviewed by Darin.
If the style sheet requested is a user style sheet, don't store it in the DocLoader's resource map;
user style sheets can outlive their doc loaders.
* loader/DocLoader.cpp:
(WebCore::DocLoader::requestCSSStyleSheet):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24500
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Sat, 21 Jul 2007 00:38:20 +0000 (00:38 +0000)]
LayoutTests:
Reviewed by Darin.
<rdar://problem/
5109817> Ctrl-click on word in non-editable text doesn't select it
* editing/selection/
5109817-expected.checksum: Added.
* editing/selection/
5109817-expected.png: Added.
* editing/selection/
5109817-expected.txt: Added.
* editing/selection/
5109817.html: Added.
WebCore:
Reviewed by Darin.
<rdar://problem/
5109817> Ctrl-click on word in non-editable text doesn't select it
* bridge/EditorClient.h: Removed a client method for enabling/disabling
word selection on right clicks.
* editing/Editor.cpp: Ditto.
* editing/Editor.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEvent): Select the
word underneath the mouse regardless of whether its editable.
WebKit:
Reviewed by Darin.
<rdar://problem/
5109817> Ctrl-click on word in non-editable text doesn't select it
* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebEditorClient.mm: Removed the method
for enabling/disabling word selection on right click.
* WebView/WebView.mm: Ditto.
* WebView/WebViewPrivate.h: Removed the getter/setter entirely,
it was in a private Category for Mail, but wasn't used by Mail
on Tiger or Leopard, they apparently implement word selection on
their own.
win:
Reviewed by Darin.
<rdar://problem/
5109817> Ctrl-click on word in non-editable text doesn't select it
* WebEditorClient.cpp: Removed the now unused selectWordBeforeMenuEvent().
* WebEditorClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24499
268f45cc-cd09-0410-ab3c-
d52691b4dbfc