WebKit-https.git
12 years agoRubber-stamped by Holger Hans Peter Freyther.
ossy@webkit.org [Mon, 11 Jan 2010 12:23:25 +0000 (12:23 +0000)]
Rubber-stamped by Holger Hans Peter Freyther.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-11
[Qt] Add expected files for the following passing new tests.
Compared to the mac expected files these only differ in svg dumping style and font metrics.

* platform/qt/fast/repaint/block-no-inflow-children-expected.txt: Added.
* platform/qt/fast/repaint/subtree-layoutstate-transform-expected.txt: Added.
* platform/qt/svg/custom/marker-referencePoint-expected.txt: Added.
* platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt: Added.
* platform/qt/svg/text/selection-background-color-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed typo fix.
ossy@webkit.org [Mon, 11 Jan 2010 12:12:02 +0000 (12:12 +0000)]
Unreviewed typo fix.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-11 Joanmarie Diggs <joanmarie.diggs@gmail.com>
eric@webkit.org [Mon, 11 Jan 2010 12:03:36 +0000 (12:03 +0000)]
2010-01-11  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=30883
        [Gtk] Implement AtkText for HTML elements which contain text

        * accessibility/gtk/AccessibilityObjectWrapperAtk.h
        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (objectAndOffsetUnignored):
        (webkit_accessible_text_get_caret_offset):
        * editing/gtk/SelectionControllerGtk.cpp:
        (SelectionController::notifyAccessibilityForSelectionChange)

        Adjust the caret offset and object with focus to reflect the
        unignored parent of the static text object which contains the
        caret. This is necessary because the static text objects are
        no longer being exposed to ATs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by Simon Hausmann.
ossy@webkit.org [Mon, 11 Jan 2010 11:48:33 +0000 (11:48 +0000)]
Rubber-stamped by Simon Hausmann.

[Qt] fast/events/touch-coords-in-zoom-and-scroll-pretty-diff.html fails on buildbot
https://bugs.webkit.org/show_bug.cgi?id=33465

* platform/qt/Skipped: fast/events/touch-coords-in-zoom-and-scroll-pretty-diff.html skipped.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-11 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 11 Jan 2010 11:35:40 +0000 (11:35 +0000)]
2010-01-11  Nikolas Zimmermann  <nzimmermann@rim.com>

        Rubber-stamped by Dirk Schulze.

        Update SVG test baseline, after the SVG text painting changes, a while ago.
        The differences are all below <0.1%, and only show up when running with --tolerance 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-11 Kim Grönholm <kim.gronholm@nomovok.com>
eric@webkit.org [Mon, 11 Jan 2010 09:44:58 +0000 (09:44 +0000)]
2010-01-11  Kim Grönholm  <kim.gronholm@nomovok.com>

        Reviewed by Antti Koivisto.

        Touchevent coordinates are incorrect after page zoom and page scroll
        https://bugs.webkit.org/show_bug.cgi?id=32899

        * fast/events/touch-coords-in-zoom-and-scroll-expected.txt: Added.
        * fast/events/touch-coords-in-zoom-and-scroll.html: Added.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/win/Skipped:
2010-01-11  Kim Grönholm  <kim.gronholm@nomovok.com>

        Reviewed by Antti Koivisto.

        Touchevent coordinates are incorrect after page zoom and page scroll
        https://bugs.webkit.org/show_bug.cgi?id=32899

        Test: fast/events/touch-coords-in-zoom-and-scroll.html

        * dom/Touch.cpp:
        (WebCore::contentsX):
        (WebCore::contentsY):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleTouchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-11 Tony Chang <tony@chromium.org>
eric@webkit.org [Mon, 11 Jan 2010 09:20:54 +0000 (09:20 +0000)]
2010-01-11  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        Have "Paste and Match Style" fire the dom paste event.
        https://bugs.webkit.org/show_bug.cgi?id=30639

        * editing/execCommand/paste-and-match-style-event.html: Added.
2010-01-11  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        Have "Paste and Match Style" fire the dom paste event.
        https://bugs.webkit.org/show_bug.cgi?id=30639

        Test: editing/execCommand/paste-and-match-style-event.html

        * editing/Editor.cpp:
        (WebCore::Editor::pasteAsPlainText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRollout renderpath culling as it once again breaks pixel tests.
oliver@apple.com [Mon, 11 Jan 2010 06:53:49 +0000 (06:53 +0000)]
Rollout renderpath culling as it once again breaks pixel tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 11 Jan 2010 06:14:37 +0000 (06:14 +0000)]
2010-01-10  Adam Barth  <abarth@webkit.org>

        Rubber stamped by David Kilzer.

        bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
        https://bugs.webkit.org/show_bug.cgi?id=33197

        Fix a typo: Commmand -> Command.

        * Scripts/webkitpy/commands/abstractsequencedcommand.py:
        * Scripts/webkitpy/commands/download.py:
        * Scripts/webkitpy/commands/queries.py:
        * Scripts/webkitpy/commands/upload.py:
        * Scripts/webkitpy/multicommandtool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-10 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 11 Jan 2010 06:09:57 +0000 (06:09 +0000)]
2010-01-10  Daniel Bates  <dbates@webkit.org>

        Unreviewed, fix typo.

        Fixed typo in test LayoutTests/fast/events/frame-programmatic-focus.html.
        The word "frame" should be "iframe" in the string "<input> in frame blurred"
        based on the context of the test. In particular, the line "<input> in iframe focused"
        and the use of an iframe in the test.

        * fast/events/frame-programmatic-focus-expected.txt:
        * fast/events/frame-programmatic-focus.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-10 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 11 Jan 2010 05:36:13 +0000 (05:36 +0000)]
2010-01-10  Daniel Bates  <dbates@webkit.org>

        Rubber-stamped by Eric Seidel.

        Adding XSSAuditor test http/tests/security/xssAuditor/malformed-HTML.html
        to the Qt Skipped file as it times out. We need to look into test further.
        See bug #33460 for more details.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-10 Adam Barth <abarth@webkit.org>
eric@webkit.org [Mon, 11 Jan 2010 05:11:21 +0000 (05:11 +0000)]
2010-01-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Let webkit-patch work with options in $EDITOR
        https://bugs.webkit.org/show_bug.cgi?id=33414

        The $EDITOR evironment variable might have command line options like
        bbedit -w.  This patch lets us run those $EDITORs.

        * Scripts/webkitpy/user.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-10 Kent Hansen <kent.hansen@nokia.com>
eric@webkit.org [Mon, 11 Jan 2010 04:55:26 +0000 (04:55 +0000)]
2010-01-10  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Darin Adler.

        RegExp.prototype.toString returns "//" for empty regular expressions
        https://bugs.webkit.org/show_bug.cgi?id=33319

        "//" starts a single-line comment, hence "/(?:)/" should be used, according to ECMA.

        * runtime/RegExpPrototype.cpp:
        (JSC::regExpProtoFuncToString):

        * tests/mozilla/ecma_2/RegExp/properties-001.js:
        (AddRegExpCases):
        * tests/mozilla/js1_2/regexp/toString.js:
        Update relevant Mozilla tests (Mozilla has had this behavior since November 2003).
2010-01-10  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Darin Adler.

        RegExp.prototype.toString returns "//" for empty regular expressions
        https://bugs.webkit.org/show_bug.cgi?id=33319

        Add new test cases and adapt existing ones.

        * fast/js/kde/RegExp-expected.txt:
        * fast/js/kde/script-tests/RegExp.js:
        * fast/js/regexp-compile-expected.txt:
        * fast/js/script-tests/regexp-compile.js:
        * fast/regex/non-pattern-characters-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* tests/mozilla/ecma/Array/15.4.1.1.js: Added property allow-tabs.
darin@apple.com [Mon, 11 Jan 2010 04:34:30 +0000 (04:34 +0000)]
* tests/mozilla/ecma/Array/15.4.1.1.js: Added property allow-tabs.
* tests/mozilla/ecma/Array/15.4.1.2.js: Added property allow-tabs.
* tests/mozilla/ecma/Array/15.4.2.1-1.js: Added property allow-tabs.
* tests/mozilla/ecma/Array/15.4.2.2-1.js: Added property allow-tabs.
* tests/mozilla/ecma/Array/15.4.2.2-2.js: Added property allow-tabs.
* tests/mozilla/ecma/Array/15.4.2.3.js: Added property allow-tabs.
* tests/mozilla/ecma/Array/15.4.3.2.js: Added property allow-tabs.
* tests/mozilla/ecma/Array/15.4.3.js: Added property allow-tabs.
* tests/mozilla/ecma/Array/15.4.4.1.js: Added property allow-tabs.
* tests/mozilla/ecma/Array/15.4.4.js: Added property allow-tabs.
* tests/mozilla/ecma/LexicalConventions/7.7.4.js: Added property allow-tabs.
* tests/mozilla/ecma/Math/15.8.2.13.js: Added property allow-tabs.
* tests/mozilla/ecma/Math/15.8.2.16.js: Added property allow-tabs.
* tests/mozilla/ecma/Math/15.8.2.18.js: Added property allow-tabs.
* tests/mozilla/ecma/Math/15.8.2.2.js: Added property allow-tabs.
* tests/mozilla/ecma/Math/15.8.2.4.js: Added property allow-tabs.
* tests/mozilla/ecma/Math/15.8.2.5.js: Added property allow-tabs.
* tests/mozilla/ecma/Math/15.8.2.7.js: Added property allow-tabs.
* tests/mozilla/ecma/String/15.5.1.js: Added property allow-tabs.
* tests/mozilla/ecma/String/15.5.2.js: Added property allow-tabs.
* tests/mozilla/ecma/String/15.5.3.1-3.js: Added property allow-tabs.
* tests/mozilla/ecma/String/15.5.3.1-4.js: Added property allow-tabs.
* tests/mozilla/ecma/String/15.5.3.js: Added property allow-tabs.
* tests/mozilla/ecma/TypeConversion/9.5-2.js: Added property allow-tabs.
* tests/mozilla/ecma/jsref.js: Modified property allow-tabs.
* tests/mozilla/ecma/shell.js: Modified property allow-tabs.
* tests/mozilla/ecma_2/LexicalConventions/keywords-001.js: Added property allow-tabs.
* tests/mozilla/ecma_2/RegExp/exec-001.js: Added property allow-tabs.
* tests/mozilla/ecma_2/String/match-004.js: Added property allow-tabs.
* tests/mozilla/ecma_2/String/replace-001.js: Added property allow-tabs.
* tests/mozilla/ecma_2/String/split-002.js: Added property allow-tabs.
* tests/mozilla/ecma_2/jsref.js: Modified property allow-tabs.
* tests/mozilla/ecma_2/shell.js: Added property allow-tabs.
* tests/mozilla/ecma_3/Date/shell.js: Modified property allow-tabs.
* tests/mozilla/ecma_3/Exceptions/regress-181654.js: Added property allow-tabs.
* tests/mozilla/ecma_3/RegExp/regress-209067.js: Added property allow-tabs.
* tests/mozilla/ecma_3/RegExp/regress-85721.js: Added property allow-tabs.
* tests/mozilla/importList.html: Added property allow-tabs.
* tests/mozilla/js1_1/shell.js: Added property allow-tabs.
* tests/mozilla/js1_2/Array/general1.js: Added property allow-tabs.
* tests/mozilla/js1_2/Array/general2.js: Added property allow-tabs.
* tests/mozilla/js1_2/Array/slice.js: Added property allow-tabs.
* tests/mozilla/js1_2/Array/splice1.js: Added property allow-tabs.
* tests/mozilla/js1_2/Array/splice2.js: Added property allow-tabs.
* tests/mozilla/js1_2/Objects/toString-001.js: Added property allow-tabs.
* tests/mozilla/js1_2/String/charCodeAt.js: Added property allow-tabs.
* tests/mozilla/js1_2/String/concat.js: Modified property allow-tabs.
* tests/mozilla/js1_2/String/match.js: Added property allow-tabs.
* tests/mozilla/js1_2/String/slice.js: Added property allow-tabs.
* tests/mozilla/js1_2/function/Function_object.js: Added property allow-tabs.
* tests/mozilla/js1_2/function/Number.js: Modified property allow-tabs.
* tests/mozilla/js1_2/function/String.js: Modified property allow-tabs.
* tests/mozilla/js1_2/function/nesting.js: Added property allow-tabs.
* tests/mozilla/js1_2/function/regexparg-1.js: Added property allow-tabs.
* tests/mozilla/js1_2/function/regexparg-2-n.js: Added property allow-tabs.
* tests/mozilla/js1_2/jsref.js: Added property allow-tabs.
* tests/mozilla/js1_2/operator/equality.js: Added property allow-tabs.
* tests/mozilla/js1_2/operator/strictEquality.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_dollar_number.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_input.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_input_as_array.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_lastIndex.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_lastMatch.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_lastMatch_as_array.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_lastParen.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_lastParen_as_array.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_leftContext.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_leftContext_as_array.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_multiline.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_multiline_as_array.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_object.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_rightContext.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_rightContext_as_array.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/alphanumeric.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/asterisk.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/backslash.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/backspace.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/beginLine.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/character_class.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/compile.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/control_characters.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/digit.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/dot.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/endLine.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/everything.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/exec.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/flags.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/global.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/hexadecimal.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/ignoreCase.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/interval.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/octal.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/parentheses.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/plus.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/question_mark.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/simple_form.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/source.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/special_characters.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/string_replace.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/string_search.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/string_split.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/test.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/toString.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/vertical_bar.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/whitespace.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/word_boundary.js: Added property allow-tabs.
* tests/mozilla/js1_2/shell.js: Added property allow-tabs.
* tests/mozilla/js1_2/statements/break.js: Added property allow-tabs.
* tests/mozilla/js1_2/statements/continue.js: Added property allow-tabs.
* tests/mozilla/js1_2/statements/do_while.js: Added property allow-tabs.
* tests/mozilla/js1_2/statements/switch.js: Added property allow-tabs.
* tests/mozilla/js1_2/statements/switch2.js: Added property allow-tabs.
* tests/mozilla/js1_3/shell.js: Added property allow-tabs.
* tests/mozilla/js1_4/shell.js: Added property allow-tabs.
* tests/mozilla/js1_5/Regress/regress-111557.js: Added property allow-tabs.
* tests/mozilla/js1_5/Regress/regress-216320.js: Added property allow-tabs.
* tests/mozilla/menuhead.html: Added property allow-tabs.
* tests/mozilla/mklistpage.pl: Added property allow-tabs.
* tests/mozilla/runtests.pl: Added property allow-tabs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-10 Robert Hogan <robert@roberthogan.net>
eric@webkit.org [Mon, 11 Jan 2010 04:09:02 +0000 (04:09 +0000)]
2010-01-10  Robert Hogan  <robert@roberthogan.net>

        Reviewed by Adam Barth.

        [Qt] Add enableXSSAuditor support to QWebSettings and DRT.

        https://bugs.webkit.org/show_bug.cgi?id=33419

        * platform/qt/Skipped:
2010-01-10  Robert Hogan  <robert@roberthogan.net>

        Reviewed by Adam Barth.

        [Qt] Add enableXSSAuditor support to QWebSettings and DRT.

        https://bugs.webkit.org/show_bug.cgi?id=33419

        * Api/qwebsettings.cpp:
        (QWebSettingsPrivate::apply):
        * Api/qwebsettings.h:
2010-01-10  Robert Hogan  <robert@roberthogan.net>

        Reviewed by Adam Barth.

        [Qt] Add enableXSSAuditor support to QWebSettings and DRT.

        https://bugs.webkit.org/show_bug.cgi?id=33419

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::WebPage::WebPage):
        (WebCore::WebPage::resetSettings):
        (WebCore::DumpRenderTree::createWindow):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setXSSAuditorEnabled):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 11 Jan 2010 03:47:24 +0000 (03:47 +0000)]
2010-01-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Allows plugins to participate in accelerated compositing
        https://bugs.webkit.org/show_bug.cgi?id=33455

        Part 1: rename setContentsToVideo() on GraphicsLayer to setContentsToMedia()
        to make it more general. Rename associated enums and methods similarly.

        * platform/graphics/GraphicsLayer.h:
        (WebCore::GraphicsLayer::setContentsToMedia):
        * platform/graphics/mac/GraphicsLayerCA.h:
        (WebCore::GraphicsLayerCA::):
        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayerCA::setContentsToMedia):
        (WebCore::GraphicsLayerCA::commitLayerChanges):
        (WebCore::GraphicsLayerCA::updateContentsMediaLayer):
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::createQTMovieLayer):
        (WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 11 Jan 2010 03:41:02 +0000 (03:41 +0000)]
2010-01-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        http/tests/messaging/cross-domain-message-event-dispatch.html failed on Gtk Linux 64-Bit Debug Bot
        https://bugs.webkit.org/show_bug.cgi?id=33458

        Fix flakey test.  If the machine is very slow, then more than 10ms
        might have elapsed between registering the timeout and calling
        postMessage.  We can't be sure which order they will be called in.
        Re-ordering the call guarantees the arrival order, even if it reduces
        our coverage slightly.

        * http/tests/messaging/cross-domain-message-event-dispatch.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBad DOM performance in large SVG files
oliver@apple.com [Mon, 11 Jan 2010 02:59:02 +0000 (02:59 +0000)]
Bad DOM performance in large SVG files
https://bugs.webkit.org/show_bug.cgi?id=30055

Reviewed by Nikolas Zimmerman

Cull RenderPaths before passing on to the underlying graphics system.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 11 Jan 2010 00:47:33 +0000 (00:47 +0000)]
2010-01-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Add defensive initialization of iframe sandbox flags
        https://bugs.webkit.org/show_bug.cgi?id=32368

        Test the mutating the allow-same-origin directive in the sandbox
        attribute does not affect the current document (but does affect the
        next document).

        * http/tests/security/resources/sandboxed-iframe-origin-add-step1.html: Added.
        * http/tests/security/resources/sandboxed-iframe-origin-add-step2.html: Added.
        * http/tests/security/resources/sandboxed-iframe-origin-remove-step1.html: Added.
        * http/tests/security/resources/sandboxed-iframe-origin-remove-step2.html: Added.
        * http/tests/security/sandboxed-iframe-origin-add-expected.txt: Added.
        * http/tests/security/sandboxed-iframe-origin-add.html: Added.
        * http/tests/security/sandboxed-iframe-origin-remove-expected.txt: Added.
        * http/tests/security/sandboxed-iframe-origin-remove.html: Added.
2010-01-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Add defensive initialization of iframe sandbox flags
        https://bugs.webkit.org/show_bug.cgi?id=32368

        We now initialize the SecurityOrigin's sandbox state directly duing
        construction.  This lets us properly set the isUnique bit.

        Tests: http/tests/security/sandboxed-iframe-origin-add.html
               http/tests/security/sandboxed-iframe-origin-remove.html

        * WebCore.base.exp:
        * dom/Document.cpp:
        (WebCore::Document::initSecurityContext):
        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::SecurityOrigin):
        (WebCore::SecurityOrigin::create):
        (WebCore::SecurityOrigin::setSandboxFlags):
        * page/SecurityOrigin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-10 Adam Barth <abarth@webkit.org>
eric@webkit.org [Mon, 11 Jan 2010 00:38:16 +0000 (00:38 +0000)]
2010-01-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Nikolas Zimmermann.

        http/tests/security/xss-DENIED-window-open-javascript-url.html timed out on Windows Debug Bot
        https://bugs.webkit.org/show_bug.cgi?id=33349

        Previously we were using JavaScript URLs to return to the main event
        loop, but that is potentially unreliable because there can be only one
        scheduled redirect in flight per frame.  Let's try using setTimeout
        instead.  Notice that there isn't a race condition here because the
        event loop will always dispatch the actions in the proper order.

        * http/tests/security/xss-DENIED-window-open-javascript-url.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 10 Jan 2010 22:53:31 +0000 (22:53 +0000)]
2010-01-10  Adam Barth  <abarth@webkit.org>

        Unreviewed cosmetic change.  Remove the status bubble for mac-ews
        because we don't have hardware for it at the moment.

        * QueueStatusServer/templates/statusbubble.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-10 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sun, 10 Jan 2010 21:30:58 +0000 (21:30 +0000)]
2010-01-10  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Inspect Element selects the wrong element.
        Drive-by fix that focuses dom tree upon settting focuesDOMNode.

        https://bugs.webkit.org/show_bug.cgi?id=33449

        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.setDocument.selectLastSelectedNode):
        (WebInspector.ElementsPanel.prototype.setDocument):
        * inspector/front-end/treeoutline.js:
        (TreeElement.prototype.select):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-10 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sun, 10 Jan 2010 19:15:04 +0000 (19:15 +0000)]
2010-01-10  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Introduce support for flexible line height in the text editor.

        https://bugs.webkit.org/show_bug.cgi?id=33431

        * inspector/front-end/TextEditor.js:
        (WebInspector.TextEditor):
        (WebInspector.TextEditor.prototype._offsetToLineNumber):
        (WebInspector.TextEditor.prototype._lineNumberToOffset):
        (WebInspector.TextEditor.prototype._lineHeight):
        (WebInspector.TextEditor.prototype.reveal):
        (WebInspector.TextEditor.prototype._textChanged):
        (WebInspector.TextEditor.prototype._selectionChanged):
        (WebInspector.TextEditor.prototype._updateSize):
        (WebInspector.TextEditor.prototype._paintLines):
        (WebInspector.TextEditor.prototype._paintLinesContinuation):
        (WebInspector.TextEditor.prototype._paintLineNumbers):
        (WebInspector.TextEditor.prototype._paintCurrentLine):
        (WebInspector.TextEditor.prototype._scroll):
        (WebInspector.TextEditor.prototype._repaintOnScroll):
        (WebInspector.TextEditor.prototype._caretForMouseEvent):
        (WebInspector.TextEditor.prototype._handleNavigationKey):
        (WebInspector.TextEditor.prototype._updateCursor):
        (WebInspector.TextEditor.prototype._invalidateHighlight):
        (WebInspector.TextEditor.prototype._paintSelection):
        (WebInspector.TextEditor.prototype._initFont):
        (WebInspector.TextCursor.prototype.setTextLineHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-10 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sun, 10 Jan 2010 19:06:59 +0000 (19:06 +0000)]
2010-01-10  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Do not repaint line numbers while editing within line.

        https://bugs.webkit.org/show_bug.cgi?id=33427

        * inspector/front-end/TextEditor.js:
        (WebInspector.TextEditor.prototype._textChanged):
        (WebInspector.TextEditor.prototype._selectionChanged):
        (WebInspector.TextEditor.prototype._repaintAll):
        (WebInspector.TextEditor.prototype._paintLines):
        (WebInspector.TextEditor.prototype._paintLinesContinuation):
        (WebInspector.TextEditor.prototype._paintLineNumbers):
        (WebInspector.TextEditor.prototype._updateCursor):
        (WebInspector.TextEditor.prototype._copy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 10 Jan 2010 08:14:05 +0000 (08:14 +0000)]
2010-01-10  Adam Barth  <abarth@webkit.org>

        Unreviewed whitespace fixes.

        * html/HTMLFrameOwnerElement.cpp:
        (WebCore::HTMLFrameOwnerElement::setSandboxFlags):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::updateSandboxFlags):
        * loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-09 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 10 Jan 2010 08:10:00 +0000 (08:10 +0000)]
2010-01-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Unify origin sandbox flag with m_noAccess in SecurityOrigin
        https://bugs.webkit.org/show_bug.cgi?id=32372

        It turns out the SandboxOrigin bit is slightly different than the
        unique origin concept because the sandbox bit is inherited by iframes.
        These concepts are separate in the spec, so I think it's ok to keep
        them separate in the implementation as well.

        No new tests because there is no behavior change.

        * dom/Document.cpp:
        (WebCore::Document::cookie):
        (WebCore::Document::setCookie):
        * loader/CrossOriginAccessControl.cpp:
        (WebCore::passesAccessControlCheck):
        * page/SecurityOrigin.cpp:
        (WebCore::schemesWithUniqueOrigins):
        (WebCore::SecurityOrigin::SecurityOrigin):
        (WebCore::SecurityOrigin::canAccess):
        (WebCore::SecurityOrigin::canRequest):
        (WebCore::SecurityOrigin::taintsCanvas):
        (WebCore::SecurityOrigin::setSandboxFlags):
        (WebCore::SecurityOrigin::toString):
        (WebCore::SecurityOrigin::registerURLSchemeAsNoAccess):
        (WebCore::SecurityOrigin::shouldTreatURLSchemeAsNoAccess):
        * page/SecurityOrigin.h:
        (WebCore::SecurityOrigin::canAccessDatabase):
        (WebCore::SecurityOrigin::canAccessStorage):
        (WebCore::SecurityOrigin::canAccessCookies):
        (WebCore::SecurityOrigin::isUnique):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-09 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sun, 10 Jan 2010 03:12:59 +0000 (03:12 +0000)]
2010-01-09  Daniel Bates  <dbates@webkit.org>

        No review, rolling out r53044.
        http://trac.webkit.org/changeset/53044
        https://bugs.webkit.org/show_bug.cgi?id=33419

        We need to look into this some more because the Qt
        bot is failing the XSSAuditor tests. See bug #33419
        for more details.

        * Api/qwebsettings.cpp:
        * Api/qwebsettings.h:

2010-01-09  Daniel Bates  <dbates@webkit.org>

        No review, rolling out r53044.
        http://trac.webkit.org/changeset/53044
        https://bugs.webkit.org/show_bug.cgi?id=33419

        We need to look into this some more because the Qt
        bot is failing the XSSAuditor tests. See bug #33419
        for more details.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::WebPage::WebPage):
        (WebCore::WebPage::resetSettings):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

2010-01-09  Daniel Bates  <dbates@webkit.org>

        No review, rolling out r53044.
        http://trac.webkit.org/changeset/53044
        https://bugs.webkit.org/show_bug.cgi?id=33419

        We need to look into this some more because the Qt
        bot is failing the XSSAuditor tests. See bug #33419
        for more details.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-09 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sun, 10 Jan 2010 02:52:14 +0000 (02:52 +0000)]
2010-01-09  Daniel Bates  <dbates@webkit.org>

        No review, rolling out r53045.
        http://trac.webkit.org/changeset/53045
        https://bugs.webkit.org/show_bug.cgi?id=33440

        This fix did not resolve the issue. That is, more XSSAuditor tests are
        failing on the Qt bot. So, we're going ultimately going to rollout the
        change committed in change set 53044 <http://trac.webkit.org/changeset/53044>,
        but we need to first rollout the attempted fix committed in change
        set 53045.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-09 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 10 Jan 2010 02:36:26 +0000 (02:36 +0000)]
2010-01-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        ScriptController::isEnabled needs to be renamed
        https://bugs.webkit.org/show_bug.cgi?id=32063

        Rename ScriptController::isEnabled to
        ScriptController::canExecuteScripts to reflect what the method actually
        means.  This is a trivial change, but it involved touching a lot of
        call sites.

        * WebCore.PluginHostProcess.exp:
        * bindings/ScriptControllerBase.cpp:
        (WebCore::ScriptController::canExecuteScripts):
        (WebCore::ScriptController::executeScript):
        * bindings/js/JSEventListener.cpp:
        (WebCore::JSEventListener::handleEvent):
        * bindings/js/JSLazyEventListener.cpp:
        (WebCore::JSLazyEventListener::parseCode):
        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::execute):
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::bindingRootObject):
        (WebCore::ScriptController::windowScriptNPObject):
        (WebCore::ScriptController::jsObjectForPluginElement):
        (WebCore::ScriptController::executeScriptInWorld):
        * bindings/js/ScriptController.h:
        * bindings/js/ScriptControllerMac.mm:
        (WebCore::ScriptController::windowScriptObject):
        * bindings/js/ScriptEventListener.cpp:
        (WebCore::createAttributeEventListener):
        * bindings/js/ScriptState.cpp:
        (WebCore::scriptStateFromNode):
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::windowScriptNPObject):
        (WebCore::ScriptController::createScriptObjectForPluginElement):
        * bindings/v8/ScriptController.h:
        * bindings/v8/ScriptEventListener.cpp:
        (WebCore::createAttributeEventListener):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::retrieve):
        * dom/ScriptElement.cpp:
        (WebCore::ScriptElementData::evaluateScript):
        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::XMLTokenizer::startElementNs):
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::controls):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::parseTag):
        (WebCore::HTMLTokenizer::processToken):
        * inspector/InspectorController.cpp:
        (WebCore::canPassNodeToJavaScript):
        * inspector/JavaScriptDebugServer.cpp:
        (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::isProcessingUserGesture):
        (WebCore::FrameLoader::open):
        (WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
        (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
2010-01-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        ScriptController::isEnabled needs to be renamed
        https://bugs.webkit.org/show_bug.cgi?id=32063

        Rename ScriptController::isEnabled to
        ScriptController::canExecuteScripts.

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::bindToWindowObject):
2010-01-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        ScriptController::isEnabled needs to be renamed
        https://bugs.webkit.org/show_bug.cgi?id=32063

        Rename ScriptController::isEnabled to
        ScriptController::canExecuteScripts.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
        (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
2010-01-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        ScriptController::isEnabled needs to be renamed
        https://bugs.webkit.org/show_bug.cgi?id=32063

        Rename ScriptController::isEnabled to
        ScriptController::canExecuteScripts.

        * WebFrame.cpp:
        (wxWebFrame::RunScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-09 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sun, 10 Jan 2010 02:00:58 +0000 (02:00 +0000)]
2010-01-09  Daniel Bates  <dbates@webkit.org>

        Rubber-stamped by Adam Barth.

        Adds failing XSSAuditor tests to the Qt Skipped file
        while we come up with a fix for them. See bug #33440
        for more details.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-09 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sun, 10 Jan 2010 00:40:21 +0000 (00:40 +0000)]
2010-01-09  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=33419

        Adds support for the XSSAuditor to the Qt DRT.

        * Api/qwebsettings.cpp: Updated comment to reflect added key XSSAuditorEnabled.
        * Api/qwebsettings.h: Adds settings key XSSAuditorEnabled.
2010-01-09  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=33419

        Removes the XSSAuditor tests from the Qt Skipped file since
        we now can run these tests.

        * platform/qt/Skipped:
2010-01-09  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=33419

        Adds support for the XSSAuditor to the Qt DRT.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::WebPage::WebPage):
        (WebCore::WebPage::resetSettings):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setXSSAuditorEnabled):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-09 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 10 Jan 2010 00:20:52 +0000 (00:20 +0000)]
2010-01-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Retry writes to QueueStatusServer when we get 500 errors
        https://bugs.webkit.org/show_bug.cgi?id=33412

        This prevents the queues from failing to mark a patch as "pass" or
        "fail" when AppEngine throws 500 errors.

        * Scripts/test-webkitpy:
        * Scripts/webkitpy/networktransaction.py: Added.
        * Scripts/webkitpy/networktransaction_unittest.py: Added.
        * Scripts/webkitpy/statusserver.py:
        * Scripts/webkitpy/steps/closebugformarkbugfixed.py: Added.
        * Scripts/webkitpy/steps/closebugregardlessofpatches.py: Added.
        * Scripts/webkitpy/steps/findbugidfromsvnrevision.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-09 Evan Martin <evan@chromium.org>
eric@webkit.org [Sun, 10 Jan 2010 00:18:05 +0000 (00:18 +0000)]
2010-01-09  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        Inspector font for errors is ugly on non-OSX platforms
        https://bugs.webkit.org/show_bug.cgi?id=33340

        * css/view-source.css: Add a fallback to sans-serif on a CSS
        selector that previously only listed Lucida Grande.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<http://webkit.org/b/33430> Fix rounded borders in queue status on older Firefox...
ddkilzer@apple.com [Sun, 10 Jan 2010 00:01:24 +0000 (00:01 +0000)]
<webkit.org/b/33430> Fix rounded borders in queue status on older Firefox and Safari browsers

Reviewed by Eric Seidel.

* QueueStatusServer/templates/statusbubble.html: Added
-moz-border-radius and -webkit-border-radius to provide rounded
borders in older Firefox and Safari browsers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-09 Chris Jerdonek <chris.jerdonek@gmail.com>
eric@webkit.org [Sat, 9 Jan 2010 22:50:53 +0000 (22:50 +0000)]
2010-01-09  Chris Jerdonek  <chris.jerdonek@gmail.com>

        Reviewed by David Kilzer.

        Modified VCSUtils::gitdiff2svndiff() to accept strings that
        end in vertical white space.

        https://bugs.webkit.org/show_bug.cgi?id=33415

        * Scripts/VCSUtils.pm:
        * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/7525778> Font fallback kills SVG kerning
mitz@apple.com [Sat, 9 Jan 2010 18:45:06 +0000 (18:45 +0000)]
<rdar://problem/7525778> Font fallback kills SVG kerning
https://bugs.webkit.org/show_bug.cgi?id=33400

Reviewed by Nikolas Zimmermann.

WebCore:

Test: platform/mac/fast/text/sticky-typesetting-features.html

Cache font attributes separately for different typesetting features.

* platform/graphics/SimpleFontData.h: Replaced single-element caches
with maps.
* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::disableLigatures): Added an ATSUStyle parameter.
(WebCore::initializeATSUStyle): Look up the ATSUStyle in the map and
initialize if necessary. Return the ATSUStyle.
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):
Use the ATSUStyle returned from initializeATSUStyle().
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformDestroy): Destroy the ATSUStyles in the
map.
(WebCore::SimpleFontData::getCFStringAttributes): Look up the attributes
dictionary in the map and initialize if necessary.

LayoutTests:

* platform/mac/fast/text/sticky-typesetting-features-expected.checksum: Added.
* platform/mac/fast/text/sticky-typesetting-features-expected.png: Added.
* platform/mac/fast/text/sticky-typesetting-features-expected.txt: Added.
* platform/mac/fast/text/sticky-typesetting-features.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 9 Jan 2010 07:49:37 +0000 (07:49 +0000)]
2010-01-08  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Fix namespace indent for SecurityOrigin.h.

        * page/SecurityOrigin.h:
        (WebCore::SecurityOrigin::domainWasSetInDOM):
        (WebCore::SecurityOrigin::protocol):
        (WebCore::SecurityOrigin::host):
        (WebCore::SecurityOrigin::domain):
        (WebCore::SecurityOrigin::port):
        (WebCore::SecurityOrigin::canLoadLocalResources):
        (WebCore::SecurityOrigin::setSandboxFlags):
        (WebCore::SecurityOrigin::isSandboxed):
        (WebCore::SecurityOrigin::canAccessDatabase):
        (WebCore::SecurityOrigin::canAccessStorage):
        (WebCore::SecurityOrigin::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Adam Barth <abarth@webkit.org>
eric@webkit.org [Sat, 9 Jan 2010 07:40:02 +0000 (07:40 +0000)]
2010-01-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Dmitry Titov.

        bindings/v8/DOMData is missing a virtual destructor
        https://bugs.webkit.org/show_bug.cgi?id=33390

        DOMData is the base class for ChildThreadDOMData and MainThreadDOMData classes
        but it does not have a virtual destructor. While this isn't currently causing
        any leaks, since there are no instances of ChildThreadDOMData or
        MainThreadDOMData that are manipulated via a DOMData pointer, the ARM GCC
        compiler generates the following compilation error:

        "/WebCore/bindings/v8/DOMData.h:45: error: 'class WebCore::DOMData' has virtual
        functions and accessible non-virtual destructor"

        We therefore need to add a virtual destructor to DOMData.

        * bindings/v8/DOMData.cpp:
        (WebCore::DOMData::~DOMData):
        * bindings/v8/DOMData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sat, 9 Jan 2010 07:09:59 +0000 (07:09 +0000)]
2010-01-08  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=33417

        Cleans up style errors exposed by the patch for bug #33198.
        Moreover, fixes all "Weird number of spaces at line-start. Are you using a 4-space indent?"
        errors reported by check-webkit-style.

        No functionality was changed. So, no new tests.

        * wtf/Platform.h:
2010-01-08  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=33417

        Cleans up style errors exposed by the patch for bug #33198.

        No functionality was changed. So, no new tests.

        * src/GraphicsContext3D.cpp:
2010-01-08  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=33417

        Cleans up style errors exposed by the patch for bug #33198.

        No functionality was changed. So, no new tests.

        * platform/graphics/SimpleFontData.h:
        * plugins/PluginPackage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 9 Jan 2010 04:48:54 +0000 (04:48 +0000)]
2010-01-08  Simon Fraser  <simon.fraser@apple.com>

        No review.

        Remove layout test that was committed by mistake.

        * compositing/webgl/webgl-blending.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 9 Jan 2010 04:07:52 +0000 (04:07 +0000)]
2010-01-08  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        WebGL canvas paints background color twice
        https://bugs.webkit.org/show_bug.cgi?id=33361

        Clean up some logic around "directly composited" content: some images, video, and WebGL.

        We previously set the GraphicsLayer background color to the CSS background color
        in some cases where the box has no other decorations. However, the content
        layer's bounds do not correspond with the background box in many cases,
        and we could end up both painting the background color, and setting it on the layer.

        Simplify this logic to never use layer background colors, and thus skip allocating
        backing store only when the element has no visible box decorations.

        Tests: compositing/images/direct-image-background-color.html
               compositing/reflections/simple-composited-reflections.html
               compositing/video/video-background-color.html
               compositing/webgl/webgl-background-color.html
               compositing/webgl/webgl-blending.html

        * rendering/RenderLayerBacking.h:
        * rendering/RenderLayerBacking.cpp:
        (WebCore::is3DCanvas): Utility to determine if a RenderObject is a canvas with WebGL
        (WebCore::RenderLayerBacking::RenderLayerBacking): Remove m_hasDirectlyCompositedContent.
        (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): canUseDirectCompositing()
        is renamed to isDirectlyCompositedImage() and only applies to images now.
        No longer set layer background color.
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Just use hasPaintedContent()
        as the argument to setDrawsContent().
        (WebCore::hasBoxDecorationsOrBackground): Renamed.
        (WebCore::RenderLayerBacking::hasNonCompositingContent):
        (WebCore::hasBoxDecorationsOrBackgroundImage): Renamed from hasBoxDecorations().
        (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): Moved test for
        hasOverflowControls() into hasNonCompositingContent() and removed the FIXME comment.
        (WebCore::RenderLayerBacking::containsPaintedContent): New method that decides
        if the layer (and its non-composited children) has any content that must be painted into backing store.
        (WebCore::RenderLayerBacking::isDirectlyCompositedImage): Renamed from canUseDirectCompositing()
        and reduced to only apply to images.
        (WebCore::RenderLayerBacking::rendererContentChanged): 3D canvas no longer falls under the
        canUseDirectCompositing() scope.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<http://webkit.org/b/33410> Fix "View Plain Diff"/"View Formatted Diff" button
ddkilzer@apple.com [Sat, 9 Jan 2010 02:16:17 +0000 (02:16 +0000)]
<webkit.org/b/33410> Fix "View Plain Diff"/"View Formatted Diff" button

Reviewed by Adam Barth.

This button was broken during a previous Bugzilla upgrade after
changes were made to the names of objects exposed on templates.

* template/en/custom/attachment/reviewform.html.tmpl: Changed
attachid to attachment.id and ispatch to attachment.ispatch.
Also tweaked the format to use 4 table columns instead of 5.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Kent Hansen <kent.hansen@nokia.com>
eric@webkit.org [Sat, 9 Jan 2010 01:57:52 +0000 (01:57 +0000)]
2010-01-08  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Eric Seidel.

        Don't store RegExp flags string representation
        https://bugs.webkit.org/show_bug.cgi?id=33321

        It's unused; the string representation is reconstructed from flags.

        * runtime/RegExp.cpp:
        (JSC::RegExp::RegExp):
        * runtime/RegExp.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Steve Block <steveblock@google.com>
eric@webkit.org [Sat, 9 Jan 2010 01:25:44 +0000 (01:25 +0000)]
2010-01-08  Steve Block  <steveblock@google.com>

        Reviewed by Darin Adler.

        Use member initialization syntax instead of assignment for member variables of Document used
        for determining minimum layout delay.
        https://bugs.webkit.org/show_bug.cgi?id=33316

        No new tests, style change only.

        * dom/Document.cpp: Modified.
        (WebCore::Document::Document): Modified. Use initializer list for m_startTime, m_overMinimumLayoutThreshold and m_extraLayoutDelay.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Kenneth Russell <kbr@google.com>
eric@webkit.org [Sat, 9 Jan 2010 01:02:53 +0000 (01:02 +0000)]
2010-01-08  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Passing array that is too large to set method of WebGLArrays does not throw an exception
        https://bugs.webkit.org/show_bug.cgi?id=33352

        Added needed range checks to JSC and V8 custom bindings. Expanded
        preexisting test suite for WebGLArrays and updated its expected
        results. Tested in WebKit and Chromium.

        * fast/canvas/webgl/array-set-out-of-bounds-expected.txt: Added.
        * fast/canvas/webgl/array-set-out-of-bounds.html: Added.
        * fast/canvas/webgl/array-unit-tests-expected.txt:
        * fast/canvas/webgl/array-unit-tests.html:
2010-01-08  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Passing array that is too large to set method of WebGLArrays does not throw an exception
        https://bugs.webkit.org/show_bug.cgi?id=33352

        Added needed range checks to JSC and V8 custom bindings. Expanded
        preexisting test suite for WebGLArrays and updated its expected
        results. Tested in WebKit and Chromium.

        Test: fast/canvas/webgl/array-set-out-of-bounds.html

        * bindings/js/JSWebGLArrayHelper.h:
        (WebCore::setWebGLArrayFromArray):
        * bindings/v8/custom/V8WebGLArrayCustom.h:
        (WebCore::setWebGLArrayFromArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sat, 9 Jan 2010 01:02:38 +0000 (01:02 +0000)]
2010-01-08  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Memory use grows grows possibly unbounded in this JavaScript Array test case
        https://bugs.webkit.org/show_bug.cgi?id=31675

        This fixes one observed bug in this test case, which is that
        arrays don't report extra cost for the sparse value maps.

        SunSpider reports a small speedup.

        * runtime/JSArray.cpp:
        (JSC::JSArray::putSlowCase): Report extra memory cost for
        the sparse value map.
        * runtime/JSArray.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 9 Jan 2010 00:46:54 +0000 (00:46 +0000)]
2010-01-08  Eric Seidel  <eric@webkit.org>

        Reviewed by Alexey Proskuryakov.

        http/tests/xmlhttprequest/logout.html failed on Tiger Bot
        https://bugs.webkit.org/show_bug.cgi?id=31412

        * platform/mac-tiger/Skipped: After talking with Alexey, we're just gonna skip the failing test on Tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dan Bernstein.
ap@apple.com [Sat, 9 Jan 2010 00:30:03 +0000 (00:30 +0000)]
    Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=32962
        HTML tags are wrongfully parsed when setting innerHTML of a SCRIPT element

        Also fixed the same for STYLE elements.

        Tests: fast/dom/css-innerHTML.html
               fast/dom/script-innerHTML-x.xhtml
               fast/dom/script-innerHTML.html

        * html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerHTML): Don't parse JS or CSS as HTML,
        matching Firefox.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix, no review.
bfulgham@webkit.org [Sat, 9 Jan 2010 00:20:30 +0000 (00:20 +0000)]
Build fix, no review.

Protect video control logic inside ENABLE(VIDEO).

* WebView.cpp:
(WebView::enterFullscreenForNode):
(WebView::exitFullscreen):
* WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReplacing all RANDOMBLOB calls with ZEROBLOB calls in preparation
dumi@chromium.org [Sat, 9 Jan 2010 00:05:52 +0000 (00:05 +0000)]
Replacing all RANDOMBLOB calls with ZEROBLOB calls in preparation
for denying RANDOMBLOB calls in HTML5 DB transactions.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=33396

* storage/open-database-while-transaction-in-progress.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoIncluded UNCONFIRMED bugs by default in advanced search query
ddkilzer@apple.com [Fri, 8 Jan 2010 23:59:28 +0000 (23:59 +0000)]
Included UNCONFIRMED bugs by default in advanced search query

Rubber-stamped by Alexey Proskuryakov.

* data/params: Prepended 'bug_status=UNCONFIRMED&' to
'defaultquery' parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Eric Seidel.
ap@apple.com [Fri, 8 Jan 2010 23:53:12 +0000 (23:53 +0000)]
    Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=33279
        fast/websockets/websocket-event-target.html causes any test after it to fail

        * fast/websockets/script-tests/websocket-event-target.js: The test uses an HTTP server
        URL to create a WebSocket, so an error may be logged to console when detected (this is
        timing dependent).

        * platform/mac/Skipped: Removed the test from Skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 8 Jan 2010 23:52:21 +0000 (23:52 +0000)]
2010-01-08  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        run-javascriptcore-tests needs a --quiet flag
        https://bugs.webkit.org/show_bug.cgi?id=33399

        Until run-javascriptcore-tests has a --quiet flag, lets just stiffle the output in webkit-patch.

        * Scripts/webkitpy/steps/runtests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=32757 Repaint bug
bdakin@apple.com [Fri, 8 Jan 2010 23:35:19 +0000 (23:35 +0000)]
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=32757 Repaint bug
with -webkit-shadow on svg shapes
-and-
<rdar://problem/7389149>

Reviewed by Oliver Hunt.

Inflate the repaintRect for the shadow using its extent.
* rendering/RenderForeignObject.cpp:
(WebCore::RenderForeignObject::computeRectForRepaint):
* rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::computeRectForRepaint):
* rendering/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::computeRectForRepaint):
* rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
(WebCore::RenderSVGRoot::computeRectForRepaint):
* rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::computeRectForRepaint):
* rendering/SVGRenderSupport.cpp:
(WebCore::getSVGShadowExtent):
(WebCore::SVGRenderBase::inflateForShadow):
* rendering/SVGRenderSupport.h:

LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=32757 Repaint bug
with -webkit-shadow on svg shapes
-and-
<rdar://problem/7389149>

Reviewed by Oliver Hunt.

* fast/repaint/moving-shadow-on-container.html: Added.
* fast/repaint/moving-shadow-on-path.html: Added.
* platform/mac/fast/repaint/moving-shadow-on-container-expected.checksum: Added.
* platform/mac/fast/repaint/moving-shadow-on-container-expected.png: Added.
* platform/mac/fast/repaint/moving-shadow-on-container-expected.txt: Added.
* platform/mac/fast/repaint/moving-shadow-on-path-expected.checksum: Added.
* platform/mac/fast/repaint/moving-shadow-on-path-expected.png: Added.
* platform/mac/fast/repaint/moving-shadow-on-path-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFIX: Make patch status appear on reviewform.html.tmpl
ddkilzer@apple.com [Fri, 8 Jan 2010 23:27:08 +0000 (23:27 +0000)]
FIX: Make patch status appear on reviewform.html.tmpl

* template/en/custom/attachment/reviewform.html.tmpl: Check
attachment.ispatch (not just ispatch) when deciding whether
to display patch status.  Also update layout a bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoOnly run http and websocket tests as last if no argument is given to be able to expli...
ossy@webkit.org [Fri, 8 Jan 2010 23:22:57 +0000 (23:22 +0000)]
Only run http and websocket tests as last if no argument is given to be able to explicitly control the test order.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-08
Reviewed by Alexey Proskuryakov.

To be able to run multiple instances of run-webkit-tests besides each other on the same machine we need to minimize
the time when Apache and WebSocketServer is locked by tests.
Because closeHTTPD() and closeWebSocketServer() is only called at the end of the testing,
we need to run http and websocket tests after all other tests.
If one however explicitly specifies the tests to run in the argument list of run-webkit-tests
we need to preserve the given order.

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate data/params parameters
ddkilzer@apple.com [Fri, 8 Jan 2010 23:22:25 +0000 (23:22 +0000)]
Update data/params parameters

* data/params: Updated 'timezone' to turn off DST.  Updated
'usebugaliases' and 'usevotes' to turn them off.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 8 Jan 2010 23:01:28 +0000 (23:01 +0000)]
2010-01-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Don't post style-queue pass messages to bugs
        https://bugs.webkit.org/show_bug.cgi?id=33404

        These messages aren't needed any more now that we have the status
        bubble reporting pass events passively.

        * Scripts/webkitpy/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
ap@apple.com [Fri, 8 Jan 2010 22:51:59 +0000 (22:51 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=32294
        http/tests/uri/escaped-entity.html affects the output of svg/W3C-SVG-1.1/filters-conv-01-f.svg

        Changed the test to not have any funky characters. Filed bug 33400 to track the underlying
        problem with kerning.

        * http/tests/uri/escaped-entity-expected.txt:
        * http/tests/uri/escaped-entity.html:
        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Adam Barth <abarth@webkit.org>
eric@webkit.org [Fri, 8 Jan 2010 22:45:52 +0000 (22:45 +0000)]
2010-01-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Optimize the number of CPUs used for building Qt and Gtk
        https://bugs.webkit.org/show_bug.cgi?id=33394

        Instead of hardcoding the number 8, we should read the number of CPUs
        from the environment.

        * Scripts/webkitpy/executive.py:
        * Scripts/webkitpy/webkitport.py:
        * Scripts/webkitpy/webkitport_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 James Robinson <jamesr@chromium.org>
dglazkov@chromium.org [Fri, 8 Jan 2010 22:31:13 +0000 (22:31 +0000)]
2010-01-08  James Robinson  <jamesr@chromium.org>

        Reviewed by Eric Seidel.

        New baselines to reflect the smaller repaint areas caused by r52839
        https://bugs.webkit.org/show_bug.cgi?id=33271

        * platform/mac/fast/repaint/background-misaligned-expected.checksum:
        * platform/mac/fast/repaint/background-misaligned-expected.png:
        * platform/mac/fast/repaint/block-selection-gap-in-composited-layer-expected.checksum:
        * platform/mac/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
        * platform/mac/fast/repaint/float-in-new-block-with-layout-delta-expected.checksum:
        * platform/mac/fast/repaint/float-in-new-block-with-layout-delta-expected.png:
        * platform/mac/fast/repaint/float-new-in-block-expected.checksum:
        * platform/mac/fast/repaint/float-new-in-block-expected.png:
        * platform/mac/fast/repaint/line-flow-with-floats-1-expected.checksum:
        * platform/mac/fast/repaint/line-flow-with-floats-1-expected.png:
        * platform/mac/fast/repaint/selected-replaced-expected.checksum:
        * platform/mac/fast/repaint/selected-replaced-expected.png:
        * platform/mac/fast/repaint/transform-replaced-shadows-expected.checksum:
        * platform/mac/fast/repaint/transform-replaced-shadows-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Kenneth Russell <kbr@google.com>
eric@webkit.org [Fri, 8 Jan 2010 22:29:55 +0000 (22:29 +0000)]
2010-01-08  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        WebGLArray subclasses do the wrong conversion in indexSetter
        https://bugs.webkit.org/show_bug.cgi?id=33350

        * fast/canvas/webgl/array-setters-expected.txt: Added.
        * fast/canvas/webgl/array-setters.html: Added.
        * fast/canvas/webgl/array-unit-tests-expected.txt:
        * fast/canvas/webgl/array-unit-tests.html:
2010-01-08  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        WebGLArray subclasses do the wrong conversion in indexSetter
        https://bugs.webkit.org/show_bug.cgi?id=33350

        Test: fast/canvas/webgl/array-setters.html

        * bindings/js/JSWebGLFloatArrayCustom.cpp:
        (WebCore::JSWebGLFloatArray::indexSetter):
        * bindings/js/JSWebGLUnsignedIntArrayCustom.cpp:
        (WebCore::JSWebGLUnsignedIntArray::indexSetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Yong Li <yoli@rim.com>
yong.li@torchmobile.com [Fri, 8 Jan 2010 22:05:18 +0000 (22:05 +0000)]
2010-01-08  Yong Li  <yoli@rim.com>

        Reviewed by Darin Adler.

        Remove unnecessary #include from FastMalloc.cpp
        https://bugs.webkit.org/show_bug.cgi?id=33393

        * wtf/FastMalloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Adam Barth <abarth@webkit.org>
eric@webkit.org [Fri, 8 Jan 2010 22:05:04 +0000 (22:05 +0000)]
2010-01-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Show patch status in bugs.webkit.org
        https://bugs.webkit.org/show_bug.cgi?id=33368

        This patch adds an iframe to the show_bug page and the edit attachment
        page that displays whether the attachment passed the various bots.

        * template/en/custom/attachment/edit.html.tmpl:
        * template/en/custom/attachment/list.html.tmpl:
        * template/en/custom/attachment/reviewform.html.tmpl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 8 Jan 2010 21:49:23 +0000 (21:49 +0000)]
2010-01-08  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Darin Adler.

        transitions/cancel-transition.html is flaky
        https://bugs.webkit.org/show_bug.cgi?id=33398

        There's a race between the check() call and the final
        setTimeout. Just remove the final setTimeout and put
        its contents in the check call itself.

        * transitions/cancel-transition.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Luiz Agostini <luiz.agostini@openbossa.org>
eric@webkit.org [Fri, 8 Jan 2010 21:48:02 +0000 (21:48 +0000)]
2010-01-08  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Delegation client
        https://bugs.webkit.org/show_bug.cgi?id=32826

        Factory related code removed from QtAbstractWebPopup. Popups are now created
        by ChromeClientQt.
        Popup content information struct added to class QtAbstractWebPopup.
        PopupMenuClient is now hidden from higher layers.
        QtAbstractWebPopup now receives content information and font as parameters
        of method populate.
        QtFallbackWebPopup moved to WebKit/qt/WebCoreSupport.

        * WebCore.pro:
        * platform/qt/PopupMenuQt.cpp:
        (WebCore::PopupMenu::PopupMenu):
        (WebCore::getItems):
        (WebCore::PopupMenu::show):
        * platform/qt/QtAbstractWebPopup.cpp:
        (WebCore::QtAbstractWebPopup::QtAbstractWebPopup):
        (WebCore::QtAbstractWebPopup::popupDidHide):
        (WebCore::QtAbstractWebPopup::valueChanged):
        * platform/qt/QtAbstractWebPopup.h:
        (WebCore::QtAbstractWebPopup::Item::):
        * platform/qt/QtFallbackWebPopup.cpp: Removed.
        * platform/qt/QtFallbackWebPopup.h: Removed.
2010-01-08  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Delegation client
        https://bugs.webkit.org/show_bug.cgi?id=32826

        Added method createPopup to ChromeClientQt used to create popups.
        QtFallbackWebPopup moved from WebCore/platform/qt to
        WebKit/qt/WebCoreSupport.

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::createPopup):
        * WebCoreSupport/ChromeClientQt.h:
        * WebCoreSupport/QtFallbackWebPopup.cpp: Added.
        (WebCore::QtFallbackWebPopup::QtFallbackWebPopup):
        (WebCore::QtFallbackWebPopup::show):
        (WebCore::QtFallbackWebPopup::populate):
        (WebCore::QtFallbackWebPopup::showPopup):
        (WebCore::QtFallbackWebPopup::hidePopup):
        (WebCore::QtFallbackWebPopup::activeChanged):
        (WebCore::QtFallbackWebPopup::setParent):
        * WebCoreSupport/QtFallbackWebPopup.h: Added.
        (WebCore::QtFallbackWebPopup::hide):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Yuzo Fujishima <yuzo@google.com>
eric@webkit.org [Fri, 8 Jan 2010 21:31:31 +0000 (21:31 +0000)]
2010-01-08  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Darin Adler.

        Skip invalid blocks in CSS property declarations.
        https://bugs.webkit.org/show_bug.cgi?id=31231
        https://bugs.webkit.org/show_bug.cgi?id=26619

        This patch makes the CSS parser skip property declarations containing invalid blocks.

        * fast/css/parsing-error-recovery-expected.txt: Added.
        * fast/css/parsing-error-recovery.html: Added.
2010-01-08  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Darin Adler.

        Skip invalid blocks in CSS property declarations.
        https://bugs.webkit.org/show_bug.cgi?id=31231
        https://bugs.webkit.org/show_bug.cgi?id=26619

        This patch makes the CSS parser skip property declarations containing invalid blocks.

        Test: fast/css/parsing-error-recovery.html

        * css/CSSGrammar.y:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fixed media test failures caused by http://trac.webkit.org/changeset/52998.
cmarrin@apple.com [Fri, 8 Jan 2010 21:11:44 +0000 (21:11 +0000)]
    Fixed media test failures caused by trac.webkit.org/changeset/52998.
        The media controller on Windows now has a full-screen button, which changes
        the layout and therefore the test results. I regenerated them for
        Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by Adam Roben.
bweinstein@apple.com [Fri, 8 Jan 2010 21:07:31 +0000 (21:07 +0000)]
Rubber-stamped by Adam Roben.

The Windows Release bots were having trouble with the xmlhttprequest tests, so
they were skipped (r50280). They all currently pass on my machine, so unskipping them now.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Darin Fisher <darin@chromium.org>
darin@chromium.org [Fri, 8 Jan 2010 20:49:26 +0000 (20:49 +0000)]
2010-01-08  Darin Fisher  <darin@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Upstream webkit unit tests from the chromium repository
        https://bugs.webkit.org/show_bug.cgi?id=33351

        This adds one such test (for KURL) and sets up the test framework.

        Switch WebKit to build a static library on all platforms.  Add a
        webkit_unit_tests executable target that runs the unit tests and also
        ensures that we don't have any missing symbols (a function that WebKit
        as a shared library used to serve).

        Changes chromium_src_dir to ../../WebKit/chromium to match how
        WebCore.gyp defines that variable.

        * WebKit.gyp:
        * public/WebKitClient.h:
        (WebKit::WebKitClient::getPluginList): Remove bogus trailing semi-colon.
        (WebKit::WebKitClient::decrementStatsCounter): Remove bogus trailing semi-colon.
        (WebKit::WebKitClient::incrementStatsCounter): Remove bogus trailing semi-colon.
        (WebKit::WebKitClient::traceEventBegin): Remove bogus trailing semi-colon.
        (WebKit::WebKitClient::traceEventEnd): Remove bogus trailing semi-colon.
        (WebKit::WebKitClient::histogramCounts): Remove bogus trailing semi-colon.
        * tests: Added.
        * tests/KURLTest.cpp: Added.
        * tests/WebKitTest.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAX: CSS content not returned correctly in AX
cfleizach@apple.com [Fri, 8 Jan 2010 20:31:19 +0000 (20:31 +0000)]
AX: CSS content not returned correctly in AX
https://bugs.webkit.org/show_bug.cgi?id=33308

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/css-content-attribute.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement):

LayoutTests:

* platform/mac/accessibility/css-content-attribute-expected.txt: Added.
* platform/mac/accessibility/css-content-attribute.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 8 Jan 2010 19:58:18 +0000 (19:58 +0000)]
2010-01-06  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        transitions/shorthand-border-transitions.html is flaky
        https://bugs.webkit.org/show_bug.cgi?id=33276

        Yet another transitions test that doesn't give consistent
        wiggle room. Make all the wiggle rooms account for >=200ms
        instead of some that were only giving 100ms wiggle room.

        * transitions/shorthand-border-transitions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Implement full-screen video for Windows
cmarrin@apple.com [Fri, 8 Jan 2010 19:23:40 +0000 (19:23 +0000)]
    Implement full-screen video for Windows
        https://bugs.webkit.org/show_bug.cgi?id=31318

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed correction.
bfulgham@webkit.org [Fri, 8 Jan 2010 18:55:07 +0000 (18:55 +0000)]
Unreviewed correction.

Accidentally left unnecessary modification to hdcFromContext
in when landing r52995.

* WebFrame.cpp:
(hdcFromContext): Back out unneeded modification.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Matt Perry <mpcomplete@chromium.org>
abarth@webkit.org [Fri, 8 Jan 2010 18:54:42 +0000 (18:54 +0000)]
2010-01-08  Matt Perry  <mpcomplete@chromium.org>

        Reviewed by Adam Barth.

        Fix a regression that removed a call to
        FrameLoaderClient::didDestroyScriptContextForFrame.
        https://bugs.webkit.org/show_bug.cgi?id=33347

        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::V8DOMWindowShell::disposeContextHandles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: WebKit plugins are not rendered during printing.
bfulgham@webkit.org [Fri, 8 Jan 2010 17:30:33 +0000 (17:30 +0000)]
WebCore: WebKit plugins are not rendered during printing.
https://bugs.webkit.org/show_bug.cgi?id=33022.

Reviewed by Adam Roben.

* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paintWindowedPluginIntoContext): Tell
  cairo printing surface to flush so that blank regions do
  not write over the plugin's paint operations.
* rendering/RenderLayer.cpp: Build fix.
(WebCore::RenderLayer::beginTransparencyLayers): Correct
  method signature missing for ColorSpace.

WebKit/win: Use correct cairo surface data type for handling print operations.
https://bugs.webkit.org/show_bug.cgi?id=33022.

Reviewed by Adam Roben.

* WebFrame.cpp:
(scaleFactor): Handle 'scale = 0' case.
(WebFrame::spoolPage): Use scaleFactor helper function.  Account for
 margin size in region passed to header/footer routines.
(WebFrame::spoolPages): Properly clean up Cairo surface.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoREGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow...
cfleizach@apple.com [Fri, 8 Jan 2010 17:24:11 +0000 (17:24 +0000)]
REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot
https://bugs.webkit.org/show_bug.cgi?id=33300

Reviewed by Eric Seidel.

WebCore:

* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilitySetPostedNotificationCallback:withContext:]):
(-[AccessibilityObjectWrapper accessibilityPostedNotification:]):

WebKitTools:

* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::~AccessibilityUIElement):
(_accessibilityNotificationCallback):
(AccessibilityUIElement::addNotificationListener):

LayoutTests:

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed trivail fix. Missing bugzilla link added to ChangeLog.(r52976)
ossy@webkit.org [Fri, 8 Jan 2010 14:27:25 +0000 (14:27 +0000)]
Unreviewed trivail fix. Missing bugzilla link added to ChangeLog.(r52976)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by Kenneth Rohde Christiansen.
ossy@webkit.org [Fri, 8 Jan 2010 14:22:27 +0000 (14:22 +0000)]
Rubber-stamped by Kenneth Rohde Christiansen.

r52976 revealed this failure by re-ordering tests.

I do not have a Snow Leopard build to test with, so skipping this
and filed bug https://bugs.webkit.org/show_bug.cgi?id=33372

* platform/mac-snowleopard/Skipped: platform/mac/editing/input/devanagari-ligature.html skipped.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed trivial fix.
ossy@webkit.org [Fri, 8 Jan 2010 13:26:57 +0000 (13:26 +0000)]
Unreviewed trivial fix.

LayoutTests/media/video-error-abort.html moved to LayoutTests/http/tests/media/video-error-abort.html
by r52923, but wasn't renamed in this skiplist by this commit.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agor52976 revealed this failure by re-ordering tests.
ossy@webkit.org [Fri, 8 Jan 2010 13:08:14 +0000 (13:08 +0000)]
r52976 revealed this failure by re-ordering tests.
r52980 corrected the expected results file, but Windows still fails,
presumably due to another test still affecting this one.

Reviewed by Eric Seidel.

I do not have a windows build to test with, so skipping this
and filed bug https://bugs.webkit.org/show_bug.cgi?id=33374

* platform/win/Skipped: svg/W3C-SVG-1.1/filters-conv-01-f.svg skipped.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 8 Jan 2010 12:59:05 +0000 (12:59 +0000)]
2010-01-08  Eric Seidel  <eric@webkit.org>

        Reviewed by Simon Hausmann.

        commit-queue should run run-javascriptcore-tests
        https://bugs.webkit.org/show_bug.cgi?id=33376

        I also made it run the python and perl unit tests.

        * Scripts/webkitpy/steps/runtests.py:
        * Scripts/webkitpy/webkitport.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Alejandro G. Castro <alex@igalia.com>
eric@webkit.org [Fri, 8 Jan 2010 12:46:48 +0000 (12:46 +0000)]
2010-01-08  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Threading problems with some of the tests
        https://bugs.webkit.org/show_bug.cgi?id=30814

        We are going to skip all the storage tests until we find the issue
        with the threading system in the gtk port.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 8 Jan 2010 12:09:42 +0000 (12:09 +0000)]
2010-01-08  Eric Seidel  <eric@webkit.org>

        No review, rolling out r52983.
        http://trac.webkit.org/changeset/52983
        https://bugs.webkit.org/show_bug.cgi?id=33321

        Broke 59 JavaScriptCore tests.  I don't think Kent knew about
        run-javascriptcore-tests.  Sadly neither does the commit-bot,
        yet.

        * runtime/RegExp.cpp:
        (JSC::RegExp::RegExp):
        * runtime/RegExp.h:
        (JSC::RegExp::flags):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Fri, 8 Jan 2010 11:54:29 +0000 (11:54 +0000)]
2010-01-08  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Xan Lopez.

        [GTK] loading test should use SoupServer instead of actual sites
        https://bugs.webkit.org/show_bug.cgi?id=33353

        Make all the loading tests use SoupServer, instead of fetching
        stuff from the Internet.

        * tests/testloading.c:
        (server_callback):
        (get_uri_for_path):
        (test_loading_status):
        (test_loading_error):
        (test_loading_cancelled):
        (load_wentback_status_changed_cb):
        (load_error_test):
        (test_loading_goback):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 8 Jan 2010 11:50:25 +0000 (11:50 +0000)]
2010-01-08  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Regex-based syntax highlighting is slow.

        https://bugs.webkit.org/show_bug.cgi?id=33330

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/JavaScriptHighlighterScheme.js: Removed.
        * inspector/front-end/JavaScriptTokenizer.js: Added.
        (WebInspector.JavaScriptTokenizer):
        (WebInspector.JavaScriptTokenizer.prototype.set line):
        (WebInspector.JavaScriptTokenizer.prototype.getCondition):
        (WebInspector.JavaScriptTokenizer.prototype.setCondition):
        (WebInspector.JavaScriptTokenizer.prototype._charAt):
        (WebInspector.JavaScriptTokenizer.prototype.nextToken):
        * inspector/front-end/JavaScriptTokenizer.re2js: Added.
        * inspector/front-end/TextEditorHighlighter.js:
        (WebInspector.TextEditorHighlighter):
        (WebInspector.TextEditorHighlighter.prototype.highlight):
        (WebInspector.TextEditorHighlighter.prototype._lex):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 8 Jan 2010 11:44:19 +0000 (11:44 +0000)]
2010-01-08  Eric Seidel  <eric@webkit.org>

        No review, rolling out r52981.
        http://trac.webkit.org/changeset/52981
        https://bugs.webkit.org/show_bug.cgi?id=33319

        Caused two JS tests to start failing:
        ecma_2/RegExp/properties-001.js and js1_2/regexp/toString.js

        * runtime/RegExpPrototype.cpp:
        (JSC::regExpProtoFuncToString):
2010-01-08  Eric Seidel  <eric@webkit.org>

        No review, rolling out r52981.
        http://trac.webkit.org/changeset/52981
        https://bugs.webkit.org/show_bug.cgi?id=33319

        Caused two JS tests to start failing:
        ecma_2/RegExp/properties-001.js and js1_2/regexp/toString.js

        * fast/js/kde/RegExp-expected.txt:
        * fast/js/kde/script-tests/RegExp.js:
        * fast/js/regexp-compile-expected.txt:
        * fast/js/script-tests/regexp-compile.js:
        * fast/regex/non-pattern-characters-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Kent Hansen <kent.hansen@nokia.com>
eric@webkit.org [Fri, 8 Jan 2010 11:32:55 +0000 (11:32 +0000)]
2010-01-08  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Darin Adler.

        Don't store RegExp flags string representation
        https://bugs.webkit.org/show_bug.cgi?id=33321

        It's unused; the string representation is reconstructed from flags.

        * runtime/RegExp.cpp:
        (JSC::RegExp::RegExp):
        * runtime/RegExp.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 8 Jan 2010 11:23:27 +0000 (11:23 +0000)]
2010-01-08  Eric Seidel  <eric@webkit.org>

        Reviewed by Tor Arne Vestbø.

        media/unsupported-tracks.html is failing on Snow Leopard Release bot
        https://bugs.webkit.org/show_bug.cgi?id=32339

        * platform/mac-snowleopard/Skipped: Add this to join a bunch of other skipped media tests which time out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Kent Hansen <kent.hansen@nokia.com>
eric@webkit.org [Fri, 8 Jan 2010 11:17:27 +0000 (11:17 +0000)]
2010-01-08  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Darin Adler.

        RegExp.prototype.toString returns "//" for empty regular expressions
        https://bugs.webkit.org/show_bug.cgi?id=33319

        "//" starts a single-line comment, hence "/(?:)/" should be used, according to ECMA.

        * runtime/RegExpPrototype.cpp:
        (JSC::regExpProtoFuncToString):
2010-01-08  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Darin Adler.

        RegExp.prototype.toString returns "//" for empty regular expressions
        https://bugs.webkit.org/show_bug.cgi?id=33319

        Add new test cases and adapt existing ones.

        * fast/js/kde/RegExp-expected.txt:
        * fast/js/kde/script-tests/RegExp.js:
        * fast/js/script-tests/regexp-compile.js:
        * fast/regex/non-pattern-characters-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-08 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 8 Jan 2010 10:22:27 +0000 (10:22 +0000)]
2010-01-08  Eric Seidel  <eric@webkit.org>

        Reviewed by Simon Hausmann.

        http/tests/uri/escaped-entity.html affects the output of svg/W3C-SVG-1.1/filters-conv-01-f.svg
        https://bugs.webkit.org/show_bug.cgi?id=32294

        * platform/mac/Skipped: Add http/tests/uri/escaped-entity.html to Skipped list since it affects later tests.
        * platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Check in correct results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 8 Jan 2010 10:12:53 +0000 (10:12 +0000)]
2010-01-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Darin Fisher.

        REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot
        https://bugs.webkit.org/show_bug.cgi?id=33300

        Skipping platform/mac/accessibility/aria-liveregions-notifications.html
        to make the bots green until Chris Fleizach can fix the AX Notification system
        to correctly unregister logging callbacks.

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRVCT compiler with "-Otime -O3" optimization tries to optimize out
hausmann@webkit.org [Fri, 8 Jan 2010 08:51:35 +0000 (08:51 +0000)]
RVCT compiler with "-Otime -O3" optimization tries to optimize out
inline new'ed pointers that are passed as arguments.
Proposed patch assigns new'ed pointer explicitly outside function call.

Patch by Norbert Leser <norbert.leser@nokia.com> on 2010-01-08
Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=33084

* API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove an unnecessary cacheFlush from ARM_TRADITIONAL JIT
loki@webkit.org [Fri, 8 Jan 2010 08:01:40 +0000 (08:01 +0000)]
Remove an unnecessary cacheFlush from ARM_TRADITIONAL JIT
https://bugs.webkit.org/show_bug.cgi?id=33203

Reviewed by Gavin Barraclough.

* assembler/ARMAssembler.cpp: Remove obsolete linkBranch function.
(JSC::ARMAssembler::executableCopy): Inline a clean linkBranch code.
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::getLdrImmAddress): Use inline function.
(JSC::ARMAssembler::getLdrImmAddressOnPool): Ditto.
(JSC::ARMAssembler::patchPointerInternal): Remove an unnecessary cacheFlush.
(JSC::ARMAssembler::linkJump): Use patchPointerInternal instead of linkBranch.
(JSC::ARMAssembler::linkCall): Ditto.
(JSC::ARMAssembler::relinkCall): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRun the http and websocket tests after all other tests.
ossy@webkit.org [Fri, 8 Jan 2010 07:56:15 +0000 (07:56 +0000)]
Run the http and websocket tests after all other tests.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07
Reviewed by Darin Adler.

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix for JSVALUE32 when ENABLE_JIT_OPTIMIZE* are disabled
loki@webkit.org [Fri, 8 Jan 2010 07:41:47 +0000 (07:41 +0000)]
Build fix for JSVALUE32 when ENABLE_JIT_OPTIMIZE* are disabled
https://bugs.webkit.org/show_bug.cgi?id=33311

Reviewed by Gavin Barraclough.

Move compileGetDirectOffset function to common part of JSVALUE32

* jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetDirectOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Mike Belshe <mbelshe@chromium.org>
eric@webkit.org [Fri, 8 Jan 2010 07:08:52 +0000 (07:08 +0000)]
2010-01-07  Mike Belshe  <mbelshe@chromium.org>

        Reviewed by Darin Adler.

        Fix Spdy casing to match style guide.

        https://bugs.webkit.org/show_bug.cgi?id=33326

        * platform/network/chromium/ResourceResponse.h:
        (WebCore::ResourceResponse::ResourceResponse):
        (WebCore::ResourceResponse::wasFetchedViaSPDY):
        (WebCore::ResourceResponse::setWasFetchedViaSPDY):
2010-01-07  Mike Belshe  <mbelshe@chromium.org>

        Reviewed by Darin Adler.

        Fix Spdy casing to match style guide.

        https://bugs.webkit.org/show_bug.cgi?id=33326

        * public/WebURLResponse.h:
        * src/WebURLResponse.cpp:
        (WebKit::WebURLResponse::wasFetchedViaSPDY):
        (WebKit::WebURLResponse::setWasFetchedViaSPDY):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Fri, 8 Jan 2010 06:54:26 +0000 (06:54 +0000)]
2010-01-07  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Maciej Stachowiak.

        Allow call sites to determine if ASSERT_* and LOG_* macros are operational
        https://bugs.webkit.org/show_bug.cgi?id=33020

        * wtf/Assertions.h: Set ASSERT_MSG_DISABLED, FATAL_DISABLED,
        ERROR_DISABLED, LOG_DISABLED to 1 if the compiler does not support
        variadic macros. Refactor for better readibility.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Fri, 8 Jan 2010 06:16:22 +0000 (06:16 +0000)]
2010-01-07  Daniel Bates  <dbates@rim.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=32987

        Added ENABLE_XHTMLMP flag. Disabled by default.

        * Configurations/FeatureDefines.xcconfig:
2010-01-07  Daniel Bates  <dbates@rim.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=32987

        Added ENABLE_XHTMLMP flag. Disabled by default.

        * features.gypi:
2010-01-07  Daniel Bates  <dbates@rim.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=32987

        Added ENABLE_XHTMLMP flag. Disabled by default.

        * Configurations/FeatureDefines.xcconfig:
2010-01-07  Daniel Bates  <dbates@rim.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=32987

        Added ENABLE_XHTMLMP flag. Disabled by default.

        * Configurations/FeatureDefines.xcconfig:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * config.h:
2010-01-07  Daniel Bates  <dbates@rim.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=32987

        Added ENABLE_XHTMLMP flag. Disabled by default.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Afonso R. Costa Jr. <afonso.costa@openbossa.org>
eric@webkit.org [Fri, 8 Jan 2010 05:54:45 +0000 (05:54 +0000)]
2010-01-07  Afonso R. Costa Jr.  <afonso.costa@openbossa.org>

        Reviewed by Darin Adler.

        As the bug https://bugs.webkit.org/show_bug.cgi?id=30034 is fixed,
        the zoomOrNot argument is unnecessary.

        * fast/dom/elementFromPoint-relative-to-viewport.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52971 268f45cc-cd09-0410-ab3c-d52691b4dbfc