WebKit-https.git
9 years agoVersioning.
lforschler@apple.com [Thu, 23 Feb 2012 21:41:17 +0000 (21:41 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd support for InterfaceName in the bindings
arv@chromium.org [Thu, 23 Feb 2012 21:23:11 +0000 (21:23 +0000)]
Add support for InterfaceName in the bindings
https://bugs.webkit.org/show_bug.cgi?id=79384

Reviewed by Adam Barth.

This makes the interface name part of the idl file instead of being hard coded into the code generators.

* bindings/scripts/CodeGenerator.pm:
(GetVisibleInterfaceName): Extracted from CodeGenerator{JS,V8}.pm and changed to look at the extended attribute.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(GenerateConstructorDefinition):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
* dom/DOMCoreException.idl: Set the InterfaceName.
* html/DOMFormData.idl: Ditto.
* plugins/DOMMimeType.idl: Ditto.
* plugins/DOMMimeTypeArray.idl: Ditto.
* plugins/DOMPlugin.idl: Ditto.
* plugins/DOMPluginArray.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r99076): WebKit pastes the trailing newline into a single-line text field
rniwa@webkit.org [Thu, 23 Feb 2012 21:17:27 +0000 (21:17 +0000)]
REGRESSION(r99076): WebKit pastes the trailing newline into a single-line text field
https://bugs.webkit.org/show_bug.cgi?id=79305

Reviewed by Tony Chang.

Source/WebCore:

The bug was caused by ReplacementFragment::m_hasInterchangeNewlineAtEnd not reset even when
text field's beforeTextInserted event handler removed interchange new lines at the end.
Because the event handler is responsible for trimming new lines, we need to recompute the values
for m_hasInterchangeNewlineAt* after the event dispatch.

Test: editing/input/paste-text-ending-with-interchange-newline.html

* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):

LayoutTests:

Add a regression test. Also make Markup.dump() dump the shadow DOM of the specififed node.

* editing/input/paste-text-ending-with-interchange-newline-expected.txt: Added.
* editing/input/paste-text-ending-with-interchange-newline.html: Added.
* resources/dump-as-markup.js:
(Markup._get):
(Markup._getShadowHostIfPossible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake use of StylePropertySet::setProperty(propertyID, CSSValue).
kling@webkit.org [Thu, 23 Feb 2012 21:15:16 +0000 (21:15 +0000)]
Make use of StylePropertySet::setProperty(propertyID, CSSValue).
<http://webkit.org/b/79374>

Reviewed by Antti Koivisto.

Use the new setProperty() overload that takes a CSSValue in more places. This allows us
to get rid of 1/3 setProperty() overloads that don't expand shorthands.

* css/StylePropertySet.h:
* css/StylePropertySet.cpp:

    Remove the setProperty() overload for specific primitive value types. StyledElement
    can take care of this without help from StylePropertySet.

* dom/StyledElement.h:
* dom/StyledElement.cpp:
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::addPropertyToAttributeStyle):

    Switch some functions over to using the setProperty() overload that takes a CSSValue.

* html/HTMLElement.cpp:
(WebCore::HTMLElement::applyBorderAttributeToStyle):
* html/HTMLHRElement.cpp:
(WebCore::HTMLHRElement::collectStyleForAttribute):
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::collectStyleForAttribute):
* html/HTMLTablePartElement.cpp:
(WebCore::HTMLTablePartElement::collectStyleForAttribute):

    Use shorthands where possible to shrink the code a bit. Pass border widths as CSS_PX
    values directly instead of making a CSSParser round-trip.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Clean up GraphicsContext3D initialization paths
jamesr@google.com [Thu, 23 Feb 2012 21:09:18 +0000 (21:09 +0000)]
[chromium] Clean up GraphicsContext3D initialization paths
https://bugs.webkit.org/show_bug.cgi?id=79321

Reviewed by Kenneth Russell.

This simplifies the GraphicsContext3D initialization paths down to two simple codepaths, one for offscreen
contexts initialized from WebCore and one for onscreen (compositor) contexts initialized by WebViewImpl or
WebLayerTreeViewImpl.

Offscreen initialization path:
1) WebCore code calls WebCore::GraphicsContext3D::create(), implemented in GraphicsContext3DChromium.cpp
2) GraphicsContext3D::create() instantiates a WebGraphicsContext3D via the static WebKitPlatformSupport interface
3) GraphicsContext3DPrivate::createGraphicsContextFromWebContext() wraps the WebGraphicsContext3D in a
GraphicsContext3D's m_private pointer.

Onscreen initialization path:
1) WebViewImpl or WebLayerTreeViewImpl request an onscreen WebGraphicsContext3D from either their WebViewClient
or WebLayerTreeViewClient, respectively
2) GraphicsContext3DPrivate::createGraphicsContextFromWebContext() wraps the WebGraphicsContext3D in a
GraphicsContext3D's m_private pointer.

There are no other initialization paths. Specifically, we do not support instantiating onscreen contexts from
within WebCore.

* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore):
(WebCore::GraphicsContext3DPrivate::platformTexture):
(WebCore::GraphicsContext3D::create):
* src/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
* src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):
* src/WebViewImpl.cpp:
(std::getCompositorContextAttributes):
(WebKit::WebViewImpl::createLayerTreeHostContext3D):
(WebKit::WebViewImpl::graphicsContext3D):
* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::CCLayerTreeHostImplTest::createContext):
(CCLayerTreeHostImplTest):
(WebKit::TEST_F):
* tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
* tests/Canvas2DLayerChromiumTest.cpp:
(WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):
* tests/CompositorFakeGraphicsContext3D.h:
(WebCore::createCompositorMockGraphicsContext3D):
* tests/FakeGraphicsContext3DTest.cpp:
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd UserGestureIndicator capability to Chromium API.
commit-queue@webkit.org [Thu, 23 Feb 2012 21:06:18 +0000 (21:06 +0000)]
Add UserGestureIndicator capability to Chromium API.
https://bugs.webkit.org/show_bug.cgi?id=77690

Patch by Greg Billock <gbillock@google.com> on 2012-02-23
Reviewed by Darin Fisher.

* WebKit.gyp:
* public/WebScopedUserGesture.h: Added.
* src/WebScopedUserGesture.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Build fixes, update the build system after recent changes.
kevino@webkit.org [Thu, 23 Feb 2012 20:54:16 +0000 (20:54 +0000)]
[wx] Build fixes, update the build system after recent changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Build fix, use the strings in LocalizedStrings.cpp.
kevino@webkit.org [Thu, 23 Feb 2012 20:52:19 +0000 (20:52 +0000)]
[wx] Build fix, use the strings in LocalizedStrings.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd missing "Reviewed by" line to change log entry for changeset r108631
dbates@webkit.org [Thu, 23 Feb 2012 20:51:33 +0000 (20:51 +0000)]
Add missing "Reviewed by" line to change log entry for changeset r108631
(https://bugs.webkit.org/show_bug.cgi?id=79252)

The patch landed in changeset r108631 was reviewed by Martin Robinson.

* ChangeLog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Build fix, disable LLINT for now and fix ENABLE defines for it.
kevino@webkit.org [Thu, 23 Feb 2012 20:48:35 +0000 (20:48 +0000)]
[wx] Build fix, disable LLINT for now and fix ENABLE defines for it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Build fix for non-Mac wx builds.
kevino@webkit.org [Thu, 23 Feb 2012 20:47:24 +0000 (20:47 +0000)]
[wx] Build fix for non-Mac wx builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMicrosoft IE fishtank demo causes assertion in RenderLayer::convertToLayerCoords
alokp@chromium.org [Thu, 23 Feb 2012 20:46:31 +0000 (20:46 +0000)]
Microsoft IE fishtank demo causes assertion in RenderLayer::convertToLayerCoords
https://bugs.webkit.org/show_bug.cgi?id=61964

Reviewed by James Robinson.

The assertion is caused with the following callstack:
WebCore::RenderLayer::convertToLayerCoords
WebCore::RenderLayerCompositor::layerWillBeRemoved
WebCore::RenderLayer::removeChild
WebCore::RenderLayer::removeOnlyThisLayer

WebCore::RenderLayer::removeOnlyThisLayer removes itself from the parent
before moving its children to its parent. When WebCore::RenderLayer::convertToLayerCoords
is called for one of the children, it tries to walk to root only to stop at the immediate
parent which was disconnected from the tree in WebCore::RenderLayer::removeOnlyThisLayer.
If removal of layer is delayed until the children has been moved, the ASSERT is avoided.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::removeOnlyThisLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMissed an if from r108657.
mdelaney@apple.com [Thu, 23 Feb 2012 20:27:31 +0000 (20:27 +0000)]
Missed an if from r108657.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for canvas breakage caused by r108597 from the following:
mdelaney@apple.com [Thu, 23 Feb 2012 20:17:21 +0000 (20:17 +0000)]
Fix for canvas breakage caused by r108597 from the following:
https://bugs.webkit.org/show_bug.cgi?id=79317

Reviewed by Oliver Hunt.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paintsIntoCanvasBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: mad Redo to Cmd+Shift+Z, not Cmd+Y on a Mac.
pfeldman@chromium.org [Thu, 23 Feb 2012 20:06:01 +0000 (20:06 +0000)]
Web Inspector: mad Redo to Cmd+Shift+Z, not Cmd+Y on a Mac.
https://bugs.webkit.org/show_bug.cgi?id=79341

Reviewed by Timothy Hatcher.

* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.handleShortcut):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Thu, 23 Feb 2012 20:02:28 +0000 (20:02 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped: Skip a failing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMac build fix after 108629.
rniwa@webkit.org [Thu, 23 Feb 2012 19:58:49 +0000 (19:58 +0000)]
Mac build fix after 108629.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] XSS Auditor bypass via javascript url and control characters
tsepez@chromium.org [Thu, 23 Feb 2012 19:46:48 +0000 (19:46 +0000)]
[chromium] XSS Auditor bypass via javascript url and control characters
https://bugs.webkit.org/show_bug.cgi?id=79154

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xssAuditor/javascript-link-control-char2.html

* html/parser/XSSAuditor.cpp:
(WebCore):
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):

LayoutTests:

* http/tests/security/xssAuditor/javascript-link-control-char2-expected.txt: Added.
* http/tests/security/xssAuditor/javascript-link-control-char2.html: Added.
* platform/chromium/http/tests/security/xssAuditor: Added.
* platform/chromium/http/tests/security/xssAuditor/javascript-link-control-char2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG's logic for emitting a Flush is too convoluted and contains an inaccurate comment
fpizlo@apple.com [Thu, 23 Feb 2012 19:45:38 +0000 (19:45 +0000)]
DFG's logic for emitting a Flush is too convoluted and contains an inaccurate comment
https://bugs.webkit.org/show_bug.cgi?id=79334

Reviewed by Oliver Hunt.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::flush):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoObject.isSealed / Object.isFrozen don't work for native objects
barraclough@apple.com [Thu, 23 Feb 2012 19:43:07 +0000 (19:43 +0000)]
Object.isSealed / Object.isFrozen don't work for native objects
https://bugs.webkit.org/show_bug.cgi?id=79331

Reviewed by Sam Weinig.

Need to inspect all properties, including static ones.
This exposes a couple of bugs in Array & Arguments:
    - getOwnPropertyDescriptor doesn't correctly report the writable attribute of array length.
    - Arguments object's defineOwnProperty does not handle callee/caller/length correctly.

Source/JavaScriptCore:

* runtime/Arguments.cpp:
(JSC::Arguments::defineOwnProperty):
    - Add handling for callee/caller/length.
* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertyDescriptor):
    - report length's writability correctly.
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
(JSC::objectConstructorIsSealed):
(JSC::objectConstructorIsFrozen):
    - Add spec-based implementation for non-final objects.

LayoutTests:

* fast/js/preventExtensions-expected.txt:
* fast/js/script-tests/preventExtensions.js:
    - Added tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agopop of array hole should get from the prototype chain
barraclough@apple.com [Thu, 23 Feb 2012 19:41:12 +0000 (19:41 +0000)]
pop of array hole should get from the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=79338

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* runtime/JSArray.cpp:
(JSC::JSArray::pop):
    - If the fast fast vector case fails, more closely follow the spec.

LayoutTests:

* sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.6_Array_prototype_pop/S15.4.4.6_A4_T1-expected.txt:
    - Checking passing test result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSString::outOfMemory() should ASSERT(isRope()) rather than !isRope()
commit-queue@webkit.org [Thu, 23 Feb 2012 19:29:14 +0000 (19:29 +0000)]
JSString::outOfMemory() should ASSERT(isRope()) rather than !isRope()
https://bugs.webkit.org/show_bug.cgi?id=79268

Patch by Yong Li <yoli@rim.com> on 2012-02-23
Reviewed by Michael Saboff.

resolveRope() is the only caller of outOfMemory(), and it calls outOfMemory()
after it fails to allocate a buffer for m_value. So outOfMemory() should assert
isRope() rather than !isRope().

* runtime/JSString.cpp:
(JSC::JSString::outOfMemory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CMake] Add WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS macro
paroga@webkit.org [Thu, 23 Feb 2012 19:23:47 +0000 (19:23 +0000)]
[CMake] Add WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS macro
https://bugs.webkit.org/show_bug.cgi?id=79371

Reviewed by Daniel Bates.

.:

Add a new macro to handle the inclusion of the platform specific *.cmake files.
In the future this macro should get expanded to also handle feature specifc
files, like the UseJSC.cmake in WebCore we already have.

* Source/cmake/WebKitMacros.cmake:

Source/JavaScriptCore:

* CMakeLists.txt:
* shell/CMakeLists.txt:
* wtf/CMakeLists.txt:

Source/WebCore:

* CMakeLists.txt:

Source/WebKit:

* CMakeLists.txt:
* PlatformBlackBerry.cmake: Renamed from Source/WebKit/blackberry/CMakeListsBlackBerry.txt.
* PlatformEfl.cmake: Renamed from Source/WebKit/efl/CMakeListsEfl.txt.
* PlatformWinCE.cmake: Renamed from Source/WebKit/wince/CMakeListsWinCE.txt.

Source/WebKit2:

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CMake] Add FindDirectX
paroga@webkit.org [Thu, 23 Feb 2012 19:15:49 +0000 (19:15 +0000)]
[CMake] Add FindDirectX
https://bugs.webkit.org/show_bug.cgi?id=79344

Reviewed by Adam Roben.

* Source/cmake/FindDirectX.cmake: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Thu, 23 Feb 2012 19:14:34 +0000 (19:14 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped:
* platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png:
* platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCleanup RenderBlock::moveChildrenTo
jchaffraix@webkit.org [Thu, 23 Feb 2012 19:12:01 +0000 (19:12 +0000)]
Cleanup RenderBlock::moveChildrenTo
https://bugs.webkit.org/show_bug.cgi?id=79319

Reviewed by Eric Seidel.

Refactoring, no change in behavior expected.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::moveChildrenTo):
Removed inline check that was redundant, switched to |while| to a |for|
to show what's going on more closely and adds a call to moveChildTo to
share more code between the 2 functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CMake] Add FindQuickTimeSDK
paroga@webkit.org [Thu, 23 Feb 2012 19:06:33 +0000 (19:06 +0000)]
[CMake] Add FindQuickTimeSDK
https://bugs.webkit.org/show_bug.cgi?id=79345

Reviewed by Adam Roben.

* Source/cmake/FindQuickTimeSDK.cmake: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add support for touch cancellation
hausmann@webkit.org [Thu, 23 Feb 2012 19:00:11 +0000 (19:00 +0000)]
[Qt] Add support for touch cancellation
https://bugs.webkit.org/show_bug.cgi?id=79348

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Map Qt touch cancel events to the WebCore equivalent.

No new tests, unskipped existing test for Qt 5.

* platform/PlatformTouchPoint.h:
(PlatformTouchPoint):
* platform/qt/PlatformTouchEventQt.cpp:
(WebCore::PlatformTouchEvent::PlatformTouchEvent):
* platform/qt/PlatformTouchPointQt.cpp:
(WebCore::PlatformTouchPoint::PlatformTouchPoint):

Source/WebKit/qt:

Forward incoming touch cancellation events to the WebCore
event handler.

* Api/qgraphicswebview.cpp:
(QGraphicsWebView::sceneEvent):
* Api/qwebpage.cpp:
(QWebPage::event):
* Api/qwebview.cpp:
(QWebView::event):

Source/WebKit2:

Convert and forward incoming touch cancellation events
to the web process.

* Shared/qt/WebEventFactoryQt.cpp:
(WebKit::webEventTypeForEvent):
(WebKit::WebEventFactory::createWebTouchEvent):
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::event):
* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::handleEvent):

Tools:

Added straight-forward touch cancellation event sending to Qt WK1 DRT
and WK2 WTR.

* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::touchCancel):
(EventSender::cancelTouchPoint):
* DumpRenderTree/qt/EventSenderQt.h:
(EventSender):
* WebKitTestRunner/EventSenderProxy.h:
(EventSenderProxy):
* WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::touchCancel):
(WTR):
(WTR::EventSendingController::cancelTouchPoint):
* WebKitTestRunner/InjectedBundle/EventSendingController.h:
(EventSendingController):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
* WebKitTestRunner/qt/EventSenderProxyQt.cpp:
(WTR::EventSenderProxy::touchCancel):
(WTR):
(WTR::EventSenderProxy::cancelTouchPoint):

LayoutTests:

Moved touch cancel event layout tests from general skip list to the
Qt 4 specific one. The Qt 5 version we depend on has QEvent::TouchCancel, which
is all we need in order to implement touch cancellation in DRT/WTR.

* platform/qt-4.8/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WinCairo] Build fix after r108428.
bfulgham@webkit.org [Thu, 23 Feb 2012 18:58:51 +0000 (18:58 +0000)]
[WinCairo] Build fix after r108428.

* win/WebKit2CFLite.def: Add missing export declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the PRI macros used in WTF::String formatters to be compatible with Qt and Visual...
hausmann@webkit.org [Thu, 23 Feb 2012 18:46:32 +0000 (18:46 +0000)]
Fix the PRI macros used in WTF::String formatters to be compatible with Qt and Visual Studio 2005 and newer.
https://bugs.webkit.org/show_bug.cgi?id=76210

Add compile time check for Visual Studio 2005 or newer.

Patch by Aron Rosenberg <arosenberg@logitech.com> on 2012-02-23
Reviewed by Simon Hausmann.

* os-win32/inttypes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed test fix after r108614: Adjust public API after changes.
hausmann@webkit.org [Thu, 23 Feb 2012 18:43:46 +0000 (18:43 +0000)]
Unreviewed test fix after r108614: Adjust public API after changes.

* UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Build fix. Qt WebKit2 can not be compiled due to QtWebPageEventHandler.
ossy@webkit.org [Thu, 23 Feb 2012 18:35:45 +0000 (18:35 +0000)]
[Qt] Build fix. Qt WebKit2 can not be compiled due to QtWebPageEventHandler.
https://bugs.webkit.org/show_bug.cgi?id=79335

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-23
Reviewed by Kenneth Rohde Christiansen.

In the upcoming Qt 5 builds the convenient setInputMethodHints method on QQuickItem
will be removed. There's no need for us to use it, we can implement passing the hints
to the input method right away in our re-implementation of inputMethodQuery, which works
with old and newer Qt 5 builds.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::inputMethodQuery):
* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::updateTextInputState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rebaseline binding test files.
arv@chromium.org [Thu, 23 Feb 2012 18:15:49 +0000 (18:15 +0000)]
Unreviewed. Rebaseline binding test files.

* bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
(webkit_dom_test_interface_supplemental_method1):
(webkit_dom_test_interface_supplemental_method2):
(webkit_dom_test_interface_get_supplemental_str1):
(webkit_dom_test_interface_get_supplemental_str2):
(webkit_dom_test_interface_set_supplemental_str2):
(webkit_dom_test_interface_get_supplemental_node):
(webkit_dom_test_interface_set_supplemental_node):
(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in ScrollElasticityController::snapRubberBandTimerFired()
andersca@apple.com [Thu, 23 Feb 2012 18:01:30 +0000 (18:01 +0000)]
Crash in ScrollElasticityController::snapRubberBandTimerFired()
https://bugs.webkit.org/show_bug.cgi?id=79372
<rdar://problem/10915193>

Reviewed by Andreas Kling.

Invalidate the rubber-band timer in the ScrollingTreeNodeMac destructor.

* page/scrolling/mac/ScrollingTreeNodeMac.h:
(ScrollingTreeNodeMac):
* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::~ScrollingTreeNodeMac):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r108626.
commit-queue@webkit.org [Thu, 23 Feb 2012 17:32:01 +0000 (17:32 +0000)]
Unreviewed, rolling out r108626.
http://trac.webkit.org/changeset/108626
https://bugs.webkit.org/show_bug.cgi?id=79370

broke qt-wk2 bot, somehow the workaround does not work on the
bot (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-23

* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::handleStatusChanged):
(WTR::PlatformWebView::resizeTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: add experiment that loads stylesheets as links
pfeldman@chromium.org [Thu, 23 Feb 2012 17:28:33 +0000 (17:28 +0000)]
Web Inspector: add experiment that loads stylesheets as links
https://bugs.webkit.org/show_bug.cgi?id=79340

Reviewed by Timothy Hatcher.

* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/View.js:
(WebInspector.View.prototype._doLoadCSS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed WinCE build fix after r108462.
paroga@webkit.org [Thu, 23 Feb 2012 16:54:17 +0000 (16:54 +0000)]
Unreviewed WinCE build fix after r108462.

* WebCoreSupport/EditorClientWinCE.h:
(EditorClientWinCE):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r108627 and r108630.
peter@chromium.org [Thu, 23 Feb 2012 16:44:50 +0000 (16:44 +0000)]
Unreviewed, rolling out r108627 and r108630.
https://bugs.webkit.org/show_bug.cgi?id=79367

ffmpeg is creating issues and was just reverted upstream as well.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2][GTK] WebProcess SIGSEVs due to incorrect clipboard handling
sergio@webkit.org [Thu, 23 Feb 2012 16:38:02 +0000 (16:38 +0000)]
[WK2][GTK] WebProcess SIGSEVs due to incorrect clipboard handling
https://bugs.webkit.org/show_bug.cgi?id=79252

Do not execute clipboard callbacks after the Frame associated with
it is destroyed.

This change is already covered by the TestWebViewEditor unit tests
(among others), they hang (because WebProcess dies) without this
patch in Debug builds.

* WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
(EditorClientFrameDestructionObserver):
(WebKit::EditorClientFrameDestructionObserver::EditorClientFrameDestructionObserver):
(WebKit::EditorClientFrameDestructionObserver::frameDestroyed):
(WebKit::EditorClientFrameDestructionObserver::destroyOnClosureFinalization):
(WebKit):
(WebKit::WebEditorClient::setSelectionPrimaryClipboardIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix. Remove the ffmpeg binary directory from the
peter@chromium.org [Thu, 23 Feb 2012 16:19:21 +0000 (16:19 +0000)]
Unreviewed build fix. Remove the ffmpeg binary directory from the
Chromium-Windows DEPS file, following the commit done in the
Chromium repository:
http://src.chromium.org/viewvc/chrome?view=rev&revision=123123

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMac build fix after r108615
aroben@apple.com [Thu, 23 Feb 2012 16:08:10 +0000 (16:08 +0000)]
Mac build fix after r108615

* WebCore.exp.in: Added a missing export.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] DRT doesn't support scheduleAsynchronousKeyDown.
commit-queue@webkit.org [Thu, 23 Feb 2012 15:57:52 +0000 (15:57 +0000)]
[GTK] DRT doesn't support scheduleAsynchronousKeyDown.
https://bugs.webkit.org/show_bug.cgi?id=78481

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-02-23
Reviewed by Gustavo Noronha Silva.

Source/WebKit/gtk:

Added a new API to deliver all mutations explicitly.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::deliverAllMutationsIfNecessary):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Tools:

Extracted shareable code from keyDownCallback and then added createKeyPressEvent
to create gdk press key event.
Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.

* DumpRenderTree/gtk/EventSender.cpp:
(scheduleAsynchronousClickCallback):
(createKeyPressEvent):
(sendKeyDown):
(keyDownCallback):
(sendAsynchronousKeyDown):
(scheduleAsynchronousKeyDownCallback):

LayoutTests:

Removed following skipped tests.
fast/mutation/end-of-task-delivery.html
fast/mutation/inline-event-listener.html

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rolled DEPS.
peter@chromium.org [Thu, 23 Feb 2012 15:30:25 +0000 (15:30 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
kbalazs@webkit.org [Thu, 23 Feb 2012 15:28:39 +0000 (15:28 +0000)]
[Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
https://bugs.webkit.org/show_bug.cgi?id=76546

Reviewed by Simon Hausmann.

Co-authored with Simon Hausmann.

Revert the workaround introduced in r107868 and reintroduce
the qml binding so we can test the code path that we are more
interested in. The reason that it did not work before is that
we don't have an active platform window which we now workaround
by propagating the resize through QWindowSystemInterface.

* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::handleStatusChanged):
(WTR::PlatformWebView::resizeTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Page doesn't get repainted while panning is in progress https://bugs.webkit...
kenneth@webkit.org [Thu, 23 Feb 2012 15:10:30 +0000 (15:10 +0000)]
[Qt] Page doesn't get repainted while panning is in progress https://bugs.webkit.org/show_bug.cgi?id=78602

Reviewed by Simon Hausmann.

The tiling code needed the current visibleContentsRect in order to be
able to create tiles, so we now make sure it gets it. We also needed
to make sure to set the trajectory vector while panning and while the
flicking engine was animating kinetic scrolling.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::_q_updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::_q_viewportTrajectoryVectorChanged):
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::setVisibleContentRectTrajectoryVector):
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::setVisibleContentRectTrajectoryVector):
* UIProcess/DrawingAreaProxyImpl.h:
(DrawingAreaProxyImpl):
* UIProcess/LayerTreeHostProxy.h:
(LayerTreeHostProxy):
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::setVisibleContentRectTrajectoryVector):
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::flickableMovingStateChanged):
(WebKit):
(WebKit::QtViewportInteractionEngine::panMoveStarted):
(WebKit::QtViewportInteractionEngine::panMoveEnded):
(WebKit::QtViewportInteractionEngine::flickableMovingPositionUpdate):
(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
* UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):
* WebProcess/WebPage/LayerTreeHost.h:
(WebKit::LayerTreeHost::setVisibleContentRectTrajectoryVector):
* WebProcess/WebPage/LayerTreeHost.messages.in:
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::setVisibleContentRectAndScale):
(WebKit::LayerTreeHostQt::setVisibleContentRectTrajectoryVector):
* WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r108577.
commit-queue@webkit.org [Thu, 23 Feb 2012 14:58:07 +0000 (14:58 +0000)]
Unreviewed, rolling out r108577.
http://trac.webkit.org/changeset/108577
https://bugs.webkit.org/show_bug.cgi?id=79359

It doesn't work as expected (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-23

Tools:

* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::postEvent):
* DumpRenderTree/qt/EventSenderQt.h:
(EventSender):

LayoutTests:

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove MediaStream related declarations from DOMWindow to DOMWindowMediaStream
abarth@webkit.org [Thu, 23 Feb 2012 12:26:05 +0000 (12:26 +0000)]
Move MediaStream related declarations from DOMWindow to DOMWindowMediaStream
https://bugs.webkit.org/show_bug.cgi?id=79343

Reviewed by Eric Seidel.

These declarations belong in the MEDIA_STREAM module.

* GNUmakefile.list.am:
* WebCore.gypi:
* mediastream/DOMWindowMediaStream.idl: Added.
* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CMAKE][WK2] Cleanup WebKit2/CMakeLists.txt.
paroga@webkit.org [Thu, 23 Feb 2012 09:32:40 +0000 (09:32 +0000)]
[CMAKE][WK2] Cleanup WebKit2/CMakeLists.txt.
https://bugs.webkit.org/show_bug.cgi?id=76122

Reviewed by Eric Seidel.

* CMakeLists.txt: Removed hardcoded WTF_USE_JSC preprocessor definition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] Trivial build fix after r108615.
hausmann@webkit.org [Thu, 23 Feb 2012 08:51:23 +0000 (08:51 +0000)]
[WK2] Trivial build fix after r108615.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] FullScreen signals
philn@webkit.org [Thu, 23 Feb 2012 08:45:56 +0000 (08:45 +0000)]
[GTK] FullScreen signals
https://bugs.webkit.org/show_bug.cgi?id=76181

Reviewed by Martin Robinson.

Source/WebKit/gtk:

Added entering-fullscreen and leaving-fullscreen signals, meant to
be used by the user agent to be notified when an element requests
full screen display and when the full screen display is to be
disabled.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::supportsFullScreenForElement):
(WebKit::onFullscreenGtkKeyPressEvent):
(WebKit::ChromeClient::cancelFullScreen):
(WebKit::ChromeClient::enterFullScreenForElement):
(WebKit::ChromeClient::exitFullScreenForElement):
* WebCoreSupport/ChromeClientGtk.h:
* tests/testwebview.c:
* webkit/webkitwebview.cpp:
(webkit_web_view_real_entering_fullscreen):
(webkit_web_view_real_leaving_fullscreen):
(webkit_web_view_class_init):
* webkit/webkitwebview.h:

Tools:

Use the two new entering/leaving fullscreen signals to hide/show
the tool bar, the status bar and ask the user's permission before
entering fullscreen.

* GtkLauncher/main.c:
(webViewFullscreenMessageWindowClose):
(webViewWindowStateEvent):
(hide_widget):
(show_widget):
(webViewEnteringFullScreen):
(webViewLeavingFullScreen):
(createBrowser):
(createWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed test expectations update for fast/css/font-face-default-font...
bashi@chromium.org [Thu, 23 Feb 2012 08:32:07 +0000 (08:32 +0000)]
[Chromium] Unreviewed test expectations update for fast/css/font-face-default-font.html

* platform/chromium-linux/fast/css/font-face-default-font-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/css/font-face-default-font-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/css/font-face-default-font-expected.png:
* platform/chromium-mac-snowleopard/fast/css/font-face-default-font-expected.txt: Removed.
* platform/chromium-win/fast/css/font-face-default-font-expected.png:
* platform/chromium-win/fast/css/font-face-default-font-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Thu, 23 Feb 2012 08:24:48 +0000 (08:24 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped:
* platform/qt/fast/multicol/span/clone-flexbox-expected.png: Added.
* platform/qt/fast/multicol/span/clone-flexbox-expected.txt: Added.
* platform/qt/fast/multicol/span/clone-summary-expected.png: Added.
* platform/qt/fast/multicol/span/clone-summary-expected.txt: Added.
* platform/qt/svg/custom/circle-move-invalidation-expected.png:
* platform/qt/svg/custom/circle-move-invalidation-expected.txt:
* platform/qt/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
* platform/qt/svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkipped a test that uses Chromium-only LayoutTestController functionality.
mitz@apple.com [Thu, 23 Feb 2012 07:36:44 +0000 (07:36 +0000)]
Skipped a test that uses Chromium-only LayoutTestController functionality.

Rubber-stamped by Joseph Pecoraro.

* platform/mac/Skipped: Added fast/dom/title-directionality-removeChild.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEvery call to RenderObject::setAnimatableStyle() iterates through all m_compositeAnim...
igor.o@sisa.samsung.com [Thu, 23 Feb 2012 07:36:38 +0000 (07:36 +0000)]
Every call to RenderObject::setAnimatableStyle() iterates through all m_compositeAnimations: potentially O(N^2)
https://bugs.webkit.org/show_bug.cgi?id=38025

This patchs implements updateAnimationTimerForRenderer, it just checks the timeToNextService for
the current RenderObject reducing the amount of iterations.

Reviewed by Simon Fraser.

* page/animation/AnimationController.cpp:
(WebCore):
(WebCore::AnimationControllerPrivate::updateAnimationTimerForRenderer):
(WebCore::AnimationController::updateAnimations):
* page/animation/AnimationControllerPrivate.h:
(AnimationControllerPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNOTIFICATIONS should be implemented as PageSupplement
commit-queue@webkit.org [Thu, 23 Feb 2012 07:29:30 +0000 (07:29 +0000)]
NOTIFICATIONS should be implemented as PageSupplement
https://bugs.webkit.org/show_bug.cgi?id=79052

Patch by Hajime Morrita <morrita@chromium.org> on 2012-02-22
Reviewed by Adam Barth.

Source/WebCore:

Turned NotificationController to a PageSupplement.

No new tests. No behavior change.

* notifications/NotificationController.cpp:
(WebCore::NotificationController::clientFrom):
(WebCore):
(WebCore::NotificationController::supplementName):
(WebCore::provideNotification):
* notifications/NotificationController.h:
(NotificationController):
(WebCore::NotificationController::from):
* notifications/NotificationPresenter.h:
(WebCore):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::webkitNotifications):
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::PageClients::PageClients):
* page/Page.h:
(WebCore):
(PageClients):
(Page):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] navigationType is missing in new API
commit-queue@webkit.org [Thu, 23 Feb 2012 07:22:03 +0000 (07:22 +0000)]
[Qt][WK2] navigationType is missing in new API
https://bugs.webkit.org/show_bug.cgi?id=78867

Patch by Michael Tyutyunik <michael.tyutyunik@nokia.com> on 2012-02-22
Reviewed by Simon Hausmann.

In QtWebPagePolicyClient::decidePolicyForNavigationAction()
navigationType argument is dropped by mistake. Adding it back
and make it available through NavigationRequest.

* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qwebnavigationrequest.cpp:
(QWebNavigationRequestPrivate::QWebNavigationRequestPrivate):
(QWebNavigationRequestPrivate):
(QWebNavigationRequest::QWebNavigationRequest):
(QWebNavigationRequest::navigationType):
* UIProcess/API/qt/qwebnavigationrequest_p.h:
* UIProcess/qt/QtWebPagePolicyClient.cpp:
(QtWebPagePolicyClient::decidePolicyForNavigationAction):
(toQuickWebViewNavigationType):
* UIProcess/qt/QtWebPagePolicyClient.h:
(QtWebPagePolicyClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium][V8] Support Uint8ClampedArray in postMessage
dslomov@google.com [Thu, 23 Feb 2012 07:04:54 +0000 (07:04 +0000)]
[Chromium][V8] Support Uint8ClampedArray in postMessage
https://bugs.webkit.org/show_bug.cgi?id=79291.

Reviewed by Kenneth Russell.

Source/WebCore:

Covered by existing tests.

* bindings/v8/SerializedScriptValue.cpp:

LayoutTests:

* platform/chromium/fast/canvas/webgl/array-message-passing-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove <input type=radio> tests to fast/forms/radio/
tkent@chromium.org [Thu, 23 Feb 2012 06:50:04 +0000 (06:50 +0000)]
Move <input type=radio> tests to fast/forms/radio/
https://bugs.webkit.org/show_bug.cgi?id=78678

Reviewed by Kentaro Hara.

* fast/forms/ValidityState-valueMissing-radio-expected.txt: Removed.
* fast/forms/ValidityState-valueMissing-radio.html: Removed.
* fast/forms/indeterminate-radio-expected.txt: Removed.
* fast/forms/indeterminate-radio.html: Removed.
* fast/forms/input-radio-checked-tab-expected.txt: Removed.
* fast/forms/input-radio-checked-tab.html: Removed.
* fast/forms/interactive-validation-required-radio-expected.txt: Removed.
* fast/forms/interactive-validation-required-radio.html: Removed.
* fast/forms/radio-attr-order-expected.txt: Removed.
* fast/forms/radio-attr-order.html: Removed.
* fast/forms/radio-button-no-change-event-expected.txt: Removed.
* fast/forms/radio-button-no-change-event.html: Removed.
* fast/forms/radio-check-click-and-drag-expected.txt: Removed.
* fast/forms/radio-check-click-and-drag.html: Removed.
* fast/forms/radio-default-value-expected.txt: Removed.
* fast/forms/radio-default-value.html: Removed.
* fast/forms/radio-group-keyboard-change-event-expected.txt: Removed.
* fast/forms/radio-group-keyboard-change-event.html: Removed.
* fast/forms/radio-nested-labels-expected.txt: Removed.
* fast/forms/radio-nested-labels.html: Removed.
* fast/forms/radio-no-theme-padding-expected.txt: Removed.
* fast/forms/radio-no-theme-padding.html: Removed.
* fast/forms/radio-remove-form-attr-expected.txt: Removed.
* fast/forms/radio-remove-form-attr.html: Removed.
* fast/forms/radio/ValidityState-valueMissing-radio-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-valueMissing-radio-expected.txt.
* fast/forms/radio/ValidityState-valueMissing-radio.html: Copied from LayoutTests/fast/forms/ValidityState-valueMissing-radio.html.
* fast/forms/radio/indeterminate-radio-expected.txt: Copied from LayoutTests/fast/forms/indeterminate-radio-expected.txt.
* fast/forms/radio/indeterminate-radio.html: Copied from LayoutTests/fast/forms/indeterminate-radio.html.
* fast/forms/radio/input-radio-checked-tab-expected.txt: Copied from LayoutTests/fast/forms/input-radio-checked-tab-expected.txt.
* fast/forms/radio/input-radio-checked-tab.html: Copied from LayoutTests/fast/forms/input-radio-checked-tab.html.
* fast/forms/radio/interactive-validation-required-radio-expected.txt: Copied from LayoutTests/fast/forms/interactive-validation-required-radio-expected.txt.
* fast/forms/radio/interactive-validation-required-radio.html: Copied from LayoutTests/fast/forms/interactive-validation-required-radio.html.
* fast/forms/radio/radio-attr-order-expected.txt: Copied from LayoutTests/fast/forms/radio-attr-order-expected.txt.
* fast/forms/radio/radio-attr-order.html: Copied from LayoutTests/fast/forms/radio-attr-order.html.
* fast/forms/radio/radio-button-no-change-event-expected.txt: Copied from LayoutTests/fast/forms/radio-button-no-change-event-expected.txt.
* fast/forms/radio/radio-button-no-change-event.html: Copied from LayoutTests/fast/forms/radio-button-no-change-event.html.
* fast/forms/radio/radio-check-click-and-drag-expected.txt: Copied from LayoutTests/fast/forms/radio-check-click-and-drag-expected.txt.
* fast/forms/radio/radio-check-click-and-drag.html: Copied from LayoutTests/fast/forms/radio-check-click-and-drag.html.
* fast/forms/radio/radio-default-value-expected.txt: Copied from LayoutTests/fast/forms/radio-default-value-expected.txt.
* fast/forms/radio/radio-default-value.html: Copied from LayoutTests/fast/forms/radio-default-value.html.
* fast/forms/radio/radio-group-keyboard-change-event-expected.txt: Copied from LayoutTests/fast/forms/radio-group-keyboard-change-event-expected.txt.
* fast/forms/radio/radio-group-keyboard-change-event.html: Copied from LayoutTests/fast/forms/radio-group-keyboard-change-event.html.
* fast/forms/radio/radio-nested-labels-expected.txt: Copied from LayoutTests/fast/forms/radio-nested-labels-expected.txt.
* fast/forms/radio/radio-nested-labels.html: Copied from LayoutTests/fast/forms/radio-nested-labels.html.
* fast/forms/radio/radio-no-theme-padding-expected.txt: Copied from LayoutTests/fast/forms/radio-no-theme-padding-expected.txt.
* fast/forms/radio/radio-no-theme-padding.html: Copied from LayoutTests/fast/forms/radio-no-theme-padding.html.
* fast/forms/radio/radio-remove-form-attr-expected.txt: Copied from LayoutTests/fast/forms/radio-remove-form-attr-expected.txt.
* fast/forms/radio/radio-remove-form-attr.html: Copied from LayoutTests/fast/forms/radio-remove-form-attr.html.
* fast/forms/radio/radio_checked-expected.txt: Copied from LayoutTests/fast/forms/radio_checked-expected.txt.
* fast/forms/radio/radio_checked.html: Copied from LayoutTests/fast/forms/radio_checked.html.
* fast/forms/radio/radio_checked_dynamic-expected.txt: Copied from LayoutTests/fast/forms/radio_checked_dynamic-expected.txt.
* fast/forms/radio/radio_checked_dynamic.html: Copied from LayoutTests/fast/forms/radio_checked_dynamic.html.
* fast/forms/radio/radio_checked_name-expected.txt: Copied from LayoutTests/fast/forms/radio_checked_name-expected.txt.
* fast/forms/radio/radio_checked_name.html: Copied from LayoutTests/fast/forms/radio_checked_name.html.
* fast/forms/radio/remove-radio-button-assert-expected.txt: Copied from LayoutTests/fast/forms/remove-radio-button-assert-expected.txt.
* fast/forms/radio/remove-radio-button-assert.html: Copied from LayoutTests/fast/forms/remove-radio-button-assert.html.
* fast/forms/radio/state-restore-radio-group-expected.txt: Copied from LayoutTests/fast/forms/state-restore-radio-group-expected.txt.
* fast/forms/radio/state-restore-radio-group.html: Copied from LayoutTests/fast/forms/state-restore-radio-group.html.
* fast/forms/radio_checked-expected.txt: Removed.
* fast/forms/radio_checked.html: Removed.
* fast/forms/radio_checked_dynamic-expected.txt: Removed.
* fast/forms/radio_checked_dynamic.html: Removed.
* fast/forms/radio_checked_name-expected.txt: Removed.
* fast/forms/radio_checked_name.html: Removed.
* fast/forms/remove-radio-button-assert-expected.txt: Removed.
* fast/forms/remove-radio-button-assert.html: Removed.
* fast/forms/state-restore-radio-group-expected.txt: Removed.
* fast/forms/state-restore-radio-group.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdated expected test results for the addition of -webkit-line-align (r108133) and the
mitz@apple.com [Thu, 23 Feb 2012 06:40:55 +0000 (06:40 +0000)]
Updated expected test results for the addition of -webkit-line-align (r108133) and the
renaming of -webkit-line-grid-snap (r107289).

Rubber-stamped by Andy Estes.

* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable Geolocation bindings for GObject
haraken@chromium.org [Thu, 23 Feb 2012 06:26:07 +0000 (06:26 +0000)]
Enable Geolocation bindings for GObject
https://bugs.webkit.org/show_bug.cgi?id=79293

Reviewed by Adam Barth.

This patch adds "WebCore::" to supplemental method calls.
This will solve the GTK build failure we have observed in the Geolocation API,
and thus this patch enables the Geolocation API.

* Modules/geolocation/NavigatorGeolocation.idl:
* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateProperty):
(GenerateFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r107516): fast/css/font-face-default-font.html is failing
bashi@chromium.org [Thu, 23 Feb 2012 06:13:01 +0000 (06:13 +0000)]
REGRESSION (r107516): fast/css/font-face-default-font.html is failing
https://bugs.webkit.org/show_bug.cgi?id=79260

Add @font-face with "font-style: italic;" so that affecting the rule
for italic text.

Reviewed by Dan Bernstein.

* fast/css/font-face-default-font.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Refactoring] Align supplementName() values.
morrita@google.com [Thu, 23 Feb 2012 05:58:31 +0000 (05:58 +0000)]
[Refactoring] Align supplementName() values.
https://bugs.webkit.org/show_bug.cgi?id=79311

Reviewed by Adam Barth.

No new tests. No behavioral change.

* dom/DeviceOrientationController.cpp:
(WebCore::DeviceOrientationController::supplementName):
* mediastream/UserMediaController.cpp:
(WebCore::UserMediaController::supplementName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r108602.
yutak@chromium.org [Thu, 23 Feb 2012 05:46:34 +0000 (05:46 +0000)]
Unreviewed, rolling out r108602.
http://trac.webkit.org/changeset/108602
https://bugs.webkit.org/show_bug.cgi?id=78878

Caused a couple of layout test failures on Chromium bots.

Source/WebCore:

* dom/Element.cpp:
(WebCore::Element::childShouldCreateRenderer):
* dom/Element.h:
(Element):
* dom/Node.h:
(WebCore::Node::childShouldCreateRenderer):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::shouldCreateRenderer):
* dom/NodeRenderingContext.h:
(NodeRenderingContext):
* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::childShouldCreateRenderer):
* html/HTMLDetailsElement.h:
(HTMLDetailsElement):
* html/HTMLMediaElement.cpp:
(WebCore):
* html/HTMLMediaElement.h:
(HTMLMediaElement):
* html/HTMLMeterElement.cpp:
* html/HTMLMeterElement.h:
(HTMLMeterElement):
* html/HTMLProgressElement.cpp:
* html/HTMLProgressElement.h:
(HTMLProgressElement):
* html/HTMLSelectElement.cpp:
* html/HTMLSelectElement.h:
(HTMLSelectElement):
* html/HTMLSummaryElement.cpp:
* html/HTMLSummaryElement.h:
(HTMLSummaryElement):
* html/HTMLTextFormControlElement.cpp:
* html/HTMLTextFormControlElement.h:
(HTMLTextFormControlElement):
* rendering/RenderButton.cpp:
(WebCore::RenderButton::canHaveChildren):
(WebCore):
* rendering/RenderButton.h:
(RenderButton):
* rendering/RenderListBox.h:
(WebCore::RenderListBox::canHaveChildren):
(RenderListBox):
* rendering/RenderMedia.h:
* rendering/RenderMenuList.h:
(WebCore::RenderMenuList::canHaveChildren):
* rendering/RenderMeter.h:
(WebCore::RenderMeter::canHaveChildren):
* rendering/RenderProgress.h:
(WebCore::RenderProgress::canHaveChildren):
* rendering/RenderTextControl.h:
(WebCore::RenderTextControl::canHaveChildren):
* rendering/svg/RenderSVGRoot.h:
(WebCore::RenderSVGRoot::canHaveChildren):
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::childShouldCreateRenderer):
* svg/SVGAElement.h:
(SVGAElement):
* svg/SVGAltGlyphElement.cpp:
(WebCore::SVGAltGlyphElement::childShouldCreateRenderer):
* svg/SVGAltGlyphElement.h:
(SVGAltGlyphElement):
* svg/SVGDocument.cpp:
(WebCore::SVGDocument::childShouldCreateRenderer):
* svg/SVGDocument.h:
(SVGDocument):
* svg/SVGElement.cpp:
(WebCore::SVGElement::childShouldCreateRenderer):
* svg/SVGElement.h:
(SVGElement):
* svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::childShouldCreateRenderer):
* svg/SVGForeignObjectElement.h:
(SVGForeignObjectElement):
* svg/SVGSwitchElement.cpp:
(WebCore::SVGSwitchElement::childShouldCreateRenderer):
* svg/SVGSwitchElement.h:
(SVGSwitchElement):
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::childShouldCreateRenderer):
* svg/SVGTRefElement.h:
(SVGTRefElement):
* svg/SVGTSpanElement.cpp:
(WebCore::SVGTSpanElement::childShouldCreateRenderer):
* svg/SVGTSpanElement.h:
(SVGTSpanElement):
* svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::childShouldCreateRenderer):
* svg/SVGTextElement.h:
(SVGTextElement):
* svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::childShouldCreateRenderer):
* svg/SVGTextPathElement.h:

LayoutTests:

* fast/dom/shadow/shadow-on-image-expected.html: Removed.
* fast/dom/shadow/shadow-on-image.html: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in RenderBlock::addChildIgnoringAnonymousColumnBlocks.
inferno@chromium.org [Thu, 23 Feb 2012 05:36:11 +0000 (05:36 +0000)]
Crash in RenderBlock::addChildIgnoringAnonymousColumnBlocks.
https://bugs.webkit.org/show_bug.cgi?id=79043

Reviewed by Julien Chaffraix.

Source/WebCore:

Tests: fast/runin/runin-div-before-child.html
       fast/runin/runin-table-before-child.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): handle
the case of run-in elements and strengthen code to handle cases where
beforeChild is incorrectly set.
* rendering/RenderObject.h: remove anonymousContainer function since
the new logic in RenderBlock does not need it.

LayoutTests:

* fast/runin/runin-div-before-child-expected.png: Added.
* fast/runin/runin-div-before-child-expected.txt: Added.
* fast/runin/runin-div-before-child.html: Added.
* fast/runin/runin-table-before-child-expected.png: Added.
* fast/runin/runin-table-before-child-expected.txt: Added.
* fast/runin/runin-table-before-child.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake ShadowRootList manage a node distribution.
hayato@chromium.org [Thu, 23 Feb 2012 05:14:17 +0000 (05:14 +0000)]
Make ShadowRootList manage a node distribution.
https://bugs.webkit.org/show_bug.cgi?id=79008

Reviewed by Dimitri Glazkov.

The result of node distributions is currently stored in
ShadowRoot. To support multiple ShadowRoots, such node distribution
information should be managed in one place per shadow host. Now
ShadowRootList takes this responsibility on behalf of owing
multiple ShadowRoots. Clients should ask ShadowRootList for such
information, not for each ShadowRoot.

No tests. No change in behavior.

* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
(WebCore::ShadowRoot::attach):
* dom/ShadowRoot.h:
(ShadowRoot):
* dom/ShadowRootList.cpp:
(WebCore::ShadowRootList::insertionPointFor):
(WebCore):
(WebCore::ShadowRootList::isSelectorActive):
(WebCore::ShadowRootList::ensureSelector):
* dom/ShadowRootList.h:
(WebCore):
(ShadowRootList):
(WebCore::ShadowRootList::hasShadowRoot):
(WebCore::ShadowRootList::youngestShadowRoot):
(WebCore::ShadowRootList::oldestShadowRoot):
(WebCore::ShadowRootList::selector):
(WebCore::ShadowRootList::host):
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):
* html/shadow/HTMLContentSelector.cpp:
(WebCore::HTMLContentSelector::willSelectOver):
* html/shadow/HTMLContentSelector.h:
(HTMLContentSelector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd multi channels support in AudioBus and AudioBufferSourceNode
commit-queue@webkit.org [Thu, 23 Feb 2012 04:51:43 +0000 (04:51 +0000)]
Add multi channels support in AudioBus and AudioBufferSourceNode
https://bugs.webkit.org/show_bug.cgi?id=79017

Patch by Wei James <james.wei@intel.com> on 2012-02-22
Reviewed by Chris Rogers.

Source/WebCore:

Tests: webaudio/up-mixing-mono-51.html
       webaudio/up-mixing-mono-stereo.html
       webaudio/up-mixing-stereo-51.html

* platform/audio/AudioBus.cpp:
(WebCore::AudioBus::copyFrom):
(WebCore::AudioBus::sumFrom):
(WebCore::AudioBus::processWithGainFromMonoStereo):
(WebCore::AudioBus::processWithGainFrom):

LayoutTests:

* webaudio/resources/audio-testing.js:
(writeAudioBuffer):
* webaudio/resources/mix-testing.js: Added.
(createToneBuffer):
* webaudio/up-mixing-mono-51-expected.wav: Added.
* webaudio/up-mixing-mono-51.html: Added.
* webaudio/up-mixing-mono-stereo-expected.wav: Added.
* webaudio/up-mixing-mono-stereo.html: Added.
* webaudio/up-mixing-stereo-51-expected.wav: Added.
* webaudio/up-mixing-stereo-51.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Supplemental] should support constants
haraken@chromium.org [Thu, 23 Feb 2012 04:24:02 +0000 (04:24 +0000)]
[Supplemental] should support constants
https://bugs.webkit.org/show_bug.cgi?id=79303

Reviewed by Adam Barth.

Given that we have

    interface [Supplemental=Y] X { constant int A = 123; }

then the code generator should generate

    X::A

to refer to the constant. However, the current code generator generates Y::A instead.
This patch fixes it.

Test: bindings/scripts/test/TestSupplemental.idl

* bindings/scripts/CodeGenerator.pm: Modified as described above.
(GenerateCompileTimeCheckForEnumsIfNeeded):

* bindings/scripts/test/JS/JSTestInterface.cpp: Updated run-bindings-tests results.
(WebCore):
* bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
(WebCore):

* page/DOMWindow.h: Moved DOMWindow::FileSystemType to DOMWindowFileSystem::FileSystemType.
(DOMWindow):
* fileapi/DOMWindowFileSystem.h: Ditto.
(DOMWindowFileSystem):
* fileapi/DOMWindowFileSystem.cpp: Ditto.
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdding a ShadowRoot to image-backed element causes a crash
morrita@google.com [Thu, 23 Feb 2012 04:01:43 +0000 (04:01 +0000)]
Adding a ShadowRoot to image-backed element causes a crash
https://bugs.webkit.org/show_bug.cgi?id=78878

Reviewed by Dimitri Glazkov.

Source/WebCore:

The crash happened because NodeRenderingContext tried to append a
child to a renderer regardless one isn't capable of holding any
children if it appears in the shadow attaching phase. RenderImage
is one of such renderer classes which aren't capable.

NodeRenderingContext decide whether the contextual node as a child
can create its renderer based on RenderObject::canHaveChildren()
and Node::childShouldCreateRenderer(). But the responsibility
between these two methods are getting confused. which results this
unfortuante crash path.

This change re-aligns the responsibility:

- Now canHaveChildren() purely declares the ability of the
  renderer. If the renderer is capable of having children, it
  return true regardless of HTML semantics.

- On the other hand, childShouldCreateRenderer() cares about the
  semantics. If the element doesn't allow children to be rendered,
  this returns false.

- Note that these decision on elements are contextual. Each element
  needs to know which role it is playing in the tree composition
  algorithm of Shadow DOM. That's why the method parameter is changed
  from Node* to NodeRenderingContext.

With this change, some decision points are moved from a renderer to an
element. Following renderers no longer stop reject having children:

- RenderButton, RenderListBox, RenderMenuList, RenderMeter,
  RenderProgress, RenderTextControl.

Corresponding element for such a render (HTMLProgressElement of
RenderProgress for exaple) now cares about that.

Tests: fast/dom/shadow/shadow-on-image-expected.html
fast/dom/shadow/shadow-on-image.html

* dom/Element.cpp:
(WebCore::Element::childShouldCreateRenderer):
* dom/Element.h:
(Element):
* dom/Node.h:
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::shouldCreateRenderer):
* dom/NodeRenderingContext.h:
(NodeRenderingContext):
(WebCore::NodeRenderingContext::isOnEncapsulationBoundary):
(WebCore):
* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::childShouldCreateRenderer):
* html/HTMLDetailsElement.h:
(HTMLDetailsElement):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::childShouldCreateRenderer):
(WebCore):
* html/HTMLMeterElement.h:
(HTMLMeterElement):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::childShouldCreateRenderer):
* html/HTMLMediaElement.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::childShouldCreateRenderer):
(WebCore):
* html/HTMLProgressElement.h:
(HTMLProgressElement):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::childShouldCreateRenderer):
(WebCore):
* html/HTMLSelectElement.h:
(HTMLSelectElement):
* html/HTMLSummaryElement.cpp:
* html/HTMLSummaryElement.h:
(HTMLSummaryElement):
* html/HTMLTextFormControlElement.cpp:
* html/HTMLTextFormControlElement.h:
(HTMLTextFormControlElement):
* rendering/RenderButton.cpp:
* rendering/RenderButton.h:
(RenderButton):
* rendering/RenderListBox.h:
(RenderListBox):
* rendering/RenderMedia.h:
(WebCore::RenderMedia::canHaveChildren):
* rendering/RenderMenuList.h:
* rendering/RenderMeter.h:
* rendering/RenderProgress.h:
* rendering/RenderTextControl.h:
* rendering/svg/RenderSVGRoot.h:
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::childShouldCreateRenderer):
* svg/SVGAElement.h:
(SVGAElement):
* svg/SVGAltGlyphElement.cpp:
(WebCore::SVGAltGlyphElement::childShouldCreateRenderer):
* svg/SVGAltGlyphElement.h:
(SVGAltGlyphElement):
* svg/SVGDocument.cpp:
(WebCore::SVGDocument::childShouldCreateRenderer):
* svg/SVGDocument.h:
(SVGDocument):
* svg/SVGElement.cpp:
(WebCore::SVGElement::childShouldCreateRenderer):
* svg/SVGElement.h:
(SVGElement):
* svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::childShouldCreateRenderer):
* svg/SVGForeignObjectElement.h:
(SVGForeignObjectElement):
* svg/SVGSwitchElement.cpp:
(WebCore::SVGSwitchElement::childShouldCreateRenderer):
* svg/SVGSwitchElement.h:
(SVGSwitchElement):
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::childShouldCreateRenderer):
* svg/SVGTRefElement.h:
(SVGTRefElement):
* svg/SVGTSpanElement.cpp:
(WebCore::SVGTSpanElement::childShouldCreateRenderer):
* svg/SVGTSpanElement.h:
(SVGTSpanElement):
* svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::childShouldCreateRenderer):
* svg/SVGTextElement.h:
(SVGTextElement):
* svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::childShouldCreateRenderer):
* svg/SVGTextPathElement.h:

LayoutTests:

* fast/dom/shadow/shadow-on-image-expected.html: Added.
* fast/dom/shadow/shadow-on-image.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] NetworkJob can access deleted objects.
commit-queue@webkit.org [Thu, 23 Feb 2012 03:57:28 +0000 (03:57 +0000)]
[BlackBerry] NetworkJob can access deleted objects.
https://bugs.webkit.org/show_bug.cgi?id=79246

Patch by Yong Li <yoli@rim.com> on 2012-02-22
Reviewed by Antonio Gomes.

When a NetworkJob is created by unload handler, we still need
to send the request to the server, but we shouldn't save and
keep using the Frame pointer because the frame is being detached.
The NetworkJob will be cancelled by PingLoader as soon as it gets
first response from host.
Also see https://bugs.webkit.org/show_bug.cgi?id=30457.

No new tests because existing test case is good enough like
LayoutTests/http/tests/navigation/image-load-in-unload-handler.html.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WebSocket] Remove zlib.h from WebSocketDeflater.h
bashi@chromium.org [Thu, 23 Feb 2012 03:44:48 +0000 (03:44 +0000)]
[WebSocket] Remove zlib.h from WebSocketDeflater.h
https://bugs.webkit.org/show_bug.cgi?id=79298

Use forward declaration and OwnPtr for z_stream to move zlib.h from
.h file to .cpp file.

Reviewed by Kent Tamura.

No new tests. No behavior change.

* websockets/WebSocketDeflater.cpp:
(WebCore::WebSocketDeflater::WebSocketDeflater):
(WebCore::WebSocketDeflater::initialize):
(WebCore::WebSocketDeflater::~WebSocketDeflater):
(WebCore::setStreamParameter):
(WebCore::WebSocketDeflater::addBytes):
(WebCore::WebSocketDeflater::finish):
(WebCore::WebSocketDeflater::reset):
(WebCore::WebSocketInflater::WebSocketInflater):
(WebCore::WebSocketInflater::initialize):
(WebCore::WebSocketInflater::~WebSocketInflater):
(WebCore::WebSocketInflater::addBytes):
(WebCore::WebSocketInflater::finish):
* websockets/WebSocketDeflater.h:
(WebSocketDeflater): Use OwnPtr for m_stream.
(WebSocketInflater): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed gardening. Two inspector tests are timing out on Mac Debug.
yutak@chromium.org [Thu, 23 Feb 2012 03:37:50 +0000 (03:37 +0000)]
[Chromium] Unreviewed gardening. Two inspector tests are timing out on Mac Debug.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add unit test for surface occlusion
commit-queue@webkit.org [Thu, 23 Feb 2012 03:37:31 +0000 (03:37 +0000)]
[chromium] Add unit test for surface occlusion
https://bugs.webkit.org/show_bug.cgi?id=79302

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-22
Reviewed by James Robinson.

* tests/CCOcclusionTrackerTest.cpp:
(WebCore::TEST):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove GraphicsContext3D::paintsIntoCanvasBuffer and unify WebGL and canvas 2d logic
jamesr@google.com [Thu, 23 Feb 2012 03:07:09 +0000 (03:07 +0000)]
Remove GraphicsContext3D::paintsIntoCanvasBuffer and unify WebGL and canvas 2d logic
https://bugs.webkit.org/show_bug.cgi?id=79317

Reviewed by Kenneth Russell.

Source/WebCore:

HTMLCanvasElement::paint needs to know whether to attempt to paint the canvas buffer for its context. In the
case of an accelerated canvas or WebGL context, unless we are printing it is typically the composited layer's
responsibility to present the contents and the element itself is only responsible for backgrounds, borders and
the like.  This removes a rather indirect path that WebGL content used to take to accomplish this and unifies
the logic with CanvasRenderingContext2D's, which has the exact same needs.

Covered by existing canvas layout tests.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paintsIntoCanvasBuffer):
(WebCore):
(WebCore::HTMLCanvasElement::paint):
* html/HTMLCanvasElement.h:
(HTMLCanvasElement):
* html/canvas/CanvasRenderingContext.h:
* html/canvas/CanvasRenderingContext2D.cpp:
* html/canvas/CanvasRenderingContext2D.h:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
* html/canvas/WebGLRenderingContext.h:
* platform/graphics/GraphicsContext3D.h:

Source/WebKit/chromium:

Remove paintsIntoCanvasBuffer() implementations.

* src/GraphicsContext3DChromium.cpp:
(WebCore):
* src/GraphicsContext3DPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPopStateEvent.state should use the same object as history.state
commit-queue@webkit.org [Thu, 23 Feb 2012 03:05:55 +0000 (03:05 +0000)]
PopStateEvent.state should use the same object as history.state
https://bugs.webkit.org/show_bug.cgi?id=77493

Patch by Pablo Flouret <pablof@motorola.com> on 2012-02-22
Reviewed by Kentaro Hara.

Source/WebCore:

Tests: fast/loader/stateobjects/state-attribute-history-getter.html
       fast/loader/stateobjects/state-attribute-popstate-event.html

* bindings/js/JSPopStateEventCustom.cpp:
(WebCore):
(WebCore::cacheState):
(WebCore::JSPopStateEvent::state):
* bindings/v8/V8HiddenPropertyName.h:
(WebCore):
* bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::stateAccessorGetter):
(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):
* bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore):
(WebCore::cacheState):
(WebCore::V8PopStateEvent::stateAccessorGetter):
* dom/Document.cpp:
(WebCore::Document::enqueuePopstateEvent):
* dom/PopStateEvent.cpp:
(WebCore::PopStateEvent::PopStateEvent):
(WebCore::PopStateEvent::create):
* dom/PopStateEvent.h:
(WebCore):
(PopStateEvent):
(WebCore::PopStateEvent::history):
* dom/PopStateEvent.idl:
* page/History.cpp:
(WebCore::History::stateChanged):
(WebCore):
(WebCore::History::isSameAsCurrentState):
* page/History.h:
(History):

LayoutTests:

* fast/loader/stateobjects/state-attribute-history-getter-expected.txt: Added.
* fast/loader/stateobjects/state-attribute-history-getter.html: Added.
* fast/loader/stateobjects/state-attribute-only-one-deserialization-expected.txt:
* fast/loader/stateobjects/state-attribute-only-one-deserialization.html:
* fast/loader/stateobjects/state-attribute-popstate-event-expected.txt: Added.
* fast/loader/stateobjects/state-attribute-popstate-event.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove obsolete FIXMEs from ContainerNode
adamk@chromium.org [Thu, 23 Feb 2012 03:01:11 +0000 (03:01 +0000)]
Remove obsolete FIXMEs from ContainerNode
https://bugs.webkit.org/show_bug.cgi?id=79295

Reviewed by Ryosuke Niwa.

Each of these three identical FIXMEs has since been fixed by adding
"RefPtr<Node> protect(this)" at the top of each method.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[JSC] Implement ArrayBuffer and typed array cloning in JSC
dslomov@google.com [Thu, 23 Feb 2012 02:51:20 +0000 (02:51 +0000)]
[JSC] Implement ArrayBuffer and typed array cloning in JSC
https://bugs.webkit.org/show_bug.cgi?id=79294

Reviewed by Oliver Hunt.

Source/WebCore:

Covered by existing tests.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::typedArrayElementSize):
(WebCore):
(WebCore::CloneSerializer::dumpArrayBufferView):
(CloneSerializer):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::readArrayBufferViewSubtag):
(CloneDeserializer):
(WebCore::CloneDeserializer::readArrayBuffer):
(WebCore::CloneDeserializer::readArrayBufferView):
(WebCore::CloneDeserializer::getJSValue):
(WebCore::CloneDeserializer::readTerminal):

LayoutTests:

* fast/canvas/webgl/array-message-passing-expected.txt: Updated expectation after cloning implemented.
* fast/canvas/webgl/script-tests/array-message-passing.js: Added Uint8ClampedArray
* platform/chromium/fast/canvas/webgl/array-message-passing-expected.txt: Updated expectations. Fixing covered by https://bugs.webkit.org/show_bug.cgi?id=79291

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed speculative chromium-mac build fix.
enne@google.com [Thu, 23 Feb 2012 02:24:01 +0000 (02:24 +0000)]
[chromium] Unreviewed speculative chromium-mac build fix.
https://bugs.webkit.org/show_bug.cgi?id=75874

This broke in r108581.

* platform/graphics/chromium/cc/CCLayerAnimationController.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoexponentialRampToValue doesn't use starting value
commit-queue@webkit.org [Thu, 23 Feb 2012 02:19:25 +0000 (02:19 +0000)]
exponentialRampToValue doesn't use starting value
https://bugs.webkit.org/show_bug.cgi?id=78035

Patch by Raymond Toy <rtoy@google.com> on 2012-02-22
Reviewed by Chris Rogers.

Source/WebCore:

Test: webaudio/audioparam-exponentialRampToValueAtTime.html

* webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl): Set
starting value for exponential ramp.

LayoutTests:

* webaudio/audioparam-exponentialRampToValueAtTime-expected.txt: Added.
* webaudio/audioparam-exponentialRampToValueAtTime.html: Added.
* webaudio/resources/audioparam-testing.js: Added.
(createConstantBuffer):
(createExponentialRampArray):
(comparePartialSignals):
(verifyDiscontinuities):
(compareSignals):
(doAutomation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r108590.
yutak@chromium.org [Thu, 23 Feb 2012 02:16:01 +0000 (02:16 +0000)]
Unreviewed, rolling out r108590.
http://trac.webkit.org/changeset/108590

I mistakenly disabled tests even though the fix was already
in.

* tests/CCOcclusionTrackerTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed. Disable two tests from CCOcclusionTrackerTest
yutak@chromium.org [Thu, 23 Feb 2012 02:09:22 +0000 (02:09 +0000)]
[Chromium] Unreviewed. Disable two tests from CCOcclusionTrackerTest
which cause assertion failures.

* tests/CCOcclusionTrackerTest.cpp:
(WebCore):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed gardening. Rebaseline more svg tests.
enne@google.com [Thu, 23 Feb 2012 01:51:51 +0000 (01:51 +0000)]
[chromium] Unreviewed gardening. Rebaseline more svg tests.

This test was also broken after r108559. It times out on all platforms
but windows, so only rebaselining windows.

* platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png:
* platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fix CCOcclusionTracker unit test assertion
commit-queue@webkit.org [Thu, 23 Feb 2012 01:42:08 +0000 (01:42 +0000)]
[chromium] Fix CCOcclusionTracker unit test assertion
https://bugs.webkit.org/show_bug.cgi?id=79275

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-22
Reviewed by James Robinson.

* tests/CCOcclusionTrackerTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake parsing color presentation attributes do less pointless work.
kling@webkit.org [Thu, 23 Feb 2012 01:40:12 +0000 (01:40 +0000)]
Make parsing color presentation attributes do less pointless work.
<http://webkit.org/b/79304>

Reviewed by Antti Koivisto.

Let HTMLElement::addHTMLColorToStyle() construct the color CSSValue directly
rather than passing a string that has to go through CSSParser.

* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::setProperty):
* css/StylePropertySet.h:

    Added a setProperty(propertyID, CSSValue) overload that expands shorthand
    properties if necessary. Also added a little comment about the behavior
    differences between setProperty() overloads.

* html/HTMLElement.cpp:
(WebCore::parseColorStringWithCrazyLegacyRules):

    Changed this to return an RGBA32.

(WebCore::HTMLElement::addHTMLColorToStyle):

    Figure out the RGB value and construct a (pooled) CSSValue directly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed gardening. Rebaseline zoom-replaced-intrinsic-ratio
enne@google.com [Thu, 23 Feb 2012 01:35:46 +0000 (01:35 +0000)]
[chromium] Unreviewed gardening. Rebaseline zoom-replaced-intrinsic-ratio

This was broken after r108559 and the result looks reasonable given
the description of the change, so rebaselining.

* platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-mac-leopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt.
* platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofast/files/create-blob-url-crash.html is no longer flaky.
dpranke@chromium.org [Thu, 23 Feb 2012 01:34:05 +0000 (01:34 +0000)]
fast/files/create-blob-url-crash.html is no longer flaky.
https://bugs.webkit.org/show_bug.cgi?id=60125

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Fix to launch the EWebLauncher using the script, run-launcher.
commit-queue@webkit.org [Thu, 23 Feb 2012 01:32:59 +0000 (01:32 +0000)]
[EFL] Fix to launch the EWebLauncher using the script, run-launcher.
https://bugs.webkit.org/show_bug.cgi?id=79076

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-02-22
Reviewed by Andreas Kling.

* Scripts/webkitdirs.pm: Fix the path of libewebkit.so.
(builtDylibPathForName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement [[DefineOwnProperty]] for the arguments object
barraclough@apple.com [Thu, 23 Feb 2012 01:25:37 +0000 (01:25 +0000)]
Implement [[DefineOwnProperty]] for the arguments object
https://bugs.webkit.org/show_bug.cgi?id=79309

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* runtime/Arguments.cpp:
(JSC::Arguments::deletePropertyByIndex):
(JSC::Arguments::deleteProperty):
    - Deleting an argument should also delete the copy on the object, if any.
(JSC::Arguments::defineOwnProperty):
    - Defining a property may override the live mapping.
* runtime/Arguments.h:
(Arguments):

LayoutTests:

* fast/js/arguments-expected.txt:
* fast/js/script-tests/arguments.js:
    - Added test cases

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Plumb from GraphicsLayer to the cc thread animation code
commit-queue@webkit.org [Thu, 23 Feb 2012 01:22:22 +0000 (01:22 +0000)]
[chromium] Plumb from GraphicsLayer to the cc thread animation code
https://bugs.webkit.org/show_bug.cgi?id=75874

Patch by Ian Vollick <vollick@chromium.org> on 2012-02-22
Reviewed by James Robinson.

Source/WebCore:

* WebCore.gypi:
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setThreadedAnimationEnabled):
(WebCore::Settings::threadedAnimationEnabled):
(Settings):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(std):
(WebCore::GraphicsLayerChromium::addChild):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::mapAnimationNameToId):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(GraphicsLayerChromium):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::addAnimation):
(WebCore):
(WebCore::LayerChromium::pauseAnimation):
(WebCore::LayerChromium::removeAnimation):
(WebCore::LayerChromium::suspendAnimations):
(WebCore::LayerChromium::resumeAnimations):
(WebCore::LayerChromium::setLayerAnimationController):
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerChromium.h:
(WebCore):
(LayerChromium):
(WebCore::LayerChromium::layerAnimationController):
(WebCore::LayerChromium::numChildren):
* platform/graphics/chromium/cc/CCActiveAnimation.cpp:
(WebCore::CCActiveAnimation::create):
(WebCore):
(WebCore::CCActiveAnimation::CCActiveAnimation):
(WebCore::CCActiveAnimation::~CCActiveAnimation):
(WebCore::CCActiveAnimation::isWaiting):
(WebCore::CCActiveAnimation::isRunningOrHasRun):
(WebCore::CCActiveAnimation::cloneForImplThread):
(WebCore::CCActiveAnimation::synchronizeProperties):
* platform/graphics/chromium/cc/CCActiveAnimation.h:
(CCActiveAnimation):
(WebCore::CCActiveAnimation::AnimationSignature::AnimationSignature):
(AnimationSignature):
(WebCore::CCActiveAnimation::id):
(WebCore::CCActiveAnimation::group):
(WebCore::CCActiveAnimation::signature):
* platform/graphics/chromium/cc/CCAnimationCurve.h:
(CCAnimationCurve):
(CCTransformAnimationCurve):
* platform/graphics/chromium/cc/CCAnimationEvents.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCAnimationCurve.h.
(WebCore):
(WebCore::CCAnimationStartedEvent::CCAnimationStartedEvent):
(CCAnimationStartedEvent):
* platform/graphics/chromium/cc/CCLayerAnimationController.cpp: Added.
(WebCore):
(WebCore::CCLayerAnimationController::CCLayerAnimationController):
(WebCore::CCLayerAnimationController::~CCLayerAnimationController):
(WebCore::CCLayerAnimationController::create):
(WebCore::CCLayerAnimationController::addAnimation):
(WebCore::CCLayerAnimationController::pauseAnimation):
(WebCore::CCLayerAnimationController::removeAnimation):
(WebCore::CCLayerAnimationController::suspendAnimations):
(WebCore::CCLayerAnimationController::resumeAnimations):
(WebCore::CCLayerAnimationController::synchronizeAnimations):
(WebCore::CCLayerAnimationController::removeCompletedAnimations):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::removeAnimationsCompletedOnMainThread):
(WebCore::CCLayerAnimationController::pushAnimationProperties):
(WebCore::CCLayerAnimationController::getActiveAnimation):
(WebCore::CCLayerAnimationController::remove):
* platform/graphics/chromium/cc/CCLayerAnimationController.h: Added.
(WebCore):
(CCLayerAnimationController):
(WebCore::CCLayerAnimationController::activeAnimations):
* platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.cpp:
(WebCore::CCLayerAnimationControllerImpl::~CCLayerAnimationControllerImpl):
(WebCore):
(WebCore::CCLayerAnimationControllerImpl::animate):
(WebCore::CCLayerAnimationControllerImpl::add):
(WebCore::CCLayerAnimationControllerImpl::getActiveAnimation):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForNextTick):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForStartTime):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForTargetAvailability):
(WebCore::CCLayerAnimationControllerImpl::purgeFinishedAnimations):
(WebCore::CCLayerAnimationControllerImpl::tickAnimations):
* platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.h:
(CCLayerAnimationControllerImplClient):
(CCLayerAnimationControllerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
(WebCore::CCLayerImpl::id):
(WebCore::CCLayerImpl::opacity):
(WebCore::CCLayerImpl::transform):
(WebCore::CCLayerImpl::bounds):
(WebCore::CCLayerImpl::layerAnimationController):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setAnimationEvents):
(WebCore):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
(CCSettings):
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::animate):
(WebCore::CCLayerTreeHostImpl::animateLayersRecursive):
(WebCore):
(WebCore::CCLayerTreeHostImpl::animatePageScale):
(WebCore::CCLayerTreeHostImpl::animateLayers):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImplClient):
(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::needsAnimateLayers):
(WebCore::CCLayerTreeHostImpl::setNeedsAnimateLayers):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::postAnimationEventsToMainThreadOnImplThread):
(WebCore):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
(WebCore):
(DebugScopedSetMainThread):
(WebCore::DebugScopedSetMainThread::DebugScopedSetMainThread):
(WebCore::DebugScopedSetMainThread::~DebugScopedSetMainThread):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::postAnimationEventsToMainThreadOnImplThread):
(WebCore):
(WebCore::CCThreadProxy::setAnimationEvents):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):

Source/WebKit/chromium:

* WebKit.gypi:
* public/WebSettings.h:
* public/platform/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setThreadedAnimationEnabled):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* tests/CCActiveAnimationTest.cpp:
(WebCore::createActiveAnimation):
* tests/CCAnimationTestCommon.cpp: Added.
(WebKitTests):
(WebKitTests::FakeFloatAnimationCurve::FakeFloatAnimationCurve):
(WebKitTests::FakeFloatAnimationCurve::~FakeFloatAnimationCurve):
(WebKitTests::FakeFloatAnimationCurve::clone):
(WebKitTests::FakeTransformTransition::FakeTransformTransition):
(WebKitTests::FakeTransformTransition::~FakeTransformTransition):
(WebKitTests::FakeTransformTransition::getValue):
(WebKitTests::FakeTransformTransition::clone):
(WebKitTests::FakeFloatTransition::FakeFloatTransition):
(WebKitTests::FakeFloatTransition::~FakeFloatTransition):
(WebKitTests::FakeFloatTransition::getValue):
(WebKitTests::FakeLayerAnimationControllerImplClient::FakeLayerAnimationControllerImplClient):
(WebKitTests::FakeLayerAnimationControllerImplClient::~FakeLayerAnimationControllerImplClient):
(WebKitTests::FakeFloatTransition::clone):
(WebKitTests::addOpacityTransition):
* tests/CCAnimationTestCommon.h: Added.
(WebCore):
(WebKitTests):
(FakeFloatAnimationCurve):
(WebKitTests::FakeFloatAnimationCurve::duration):
(WebKitTests::FakeFloatAnimationCurve::getValue):
(FakeTransformTransition):
(WebKitTests::FakeTransformTransition::duration):
(FakeFloatTransition):
(WebKitTests::FakeFloatTransition::duration):
(FakeLayerAnimationControllerImplClient):
(WebKitTests::FakeLayerAnimationControllerImplClient::id):
(WebKitTests::FakeLayerAnimationControllerImplClient::opacity):
(WebKitTests::FakeLayerAnimationControllerImplClient::setOpacity):
(WebKitTests::FakeLayerAnimationControllerImplClient::transform):
(WebKitTests::FakeLayerAnimationControllerImplClient::setTransform):
(WebKitTests::FakeLayerAnimationControllerImplClient::bounds):
* tests/CCLayerAnimationControllerImplTest.cpp:
(WebKitTests::createActiveAnimation):
(WebKitTests::TEST):
* tests/CCLayerAnimationControllerTest.cpp: Added.
(WebKitTests):
(WebKitTests::createActiveAnimation):
(WebKitTests::TEST):
* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::CCLayerTreeHostImplTest::postAnimationEventsToMainThreadOnImplThread):
* tests/CCLayerTreeHostTest.cpp:
(WTF::TestHooks::animateLayers):
(MockLayerTreeHostImpl):
(WTF::MockLayerTreeHostImpl::animateLayers):
(WTF::MockLayerTreeHost::create):
(WTF::MockLayerTreeHost::createLayerTreeHostImpl):
(WTF):
(MockLayerAnimationController):
(WTF::MockLayerAnimationController::create):
(WTF::MockLayerAnimationController::addAnimation):
(WTF::MockLayerTreeHostClient::scheduleComposite):
(WTF::CCLayerTreeHostTest::postAddAnimationToMainThread):
(CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::dispatchAddAnimation):
(WTF::CCLayerTreeHostTest::doBeginTest):
(CCLayerTreeHostTestAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::CCLayerTreeHostTestAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::beginTest):
(WTF::CCLayerTreeHostTestAddAnimation::animateLayers):
(WTF::CCLayerTreeHostTestAddAnimation::afterTest):
(WTF::TEST_F):
* tests/TreeSynchronizerTest.cpp:
(FakeLayerAnimationController):
(WebKitTests::FakeLayerAnimationController::create):
(WebKitTests::FakeLayerAnimationController::synchronizedAnimations):
(WebKitTests::FakeLayerAnimationController::FakeLayerAnimationController):
(WebKitTests::FakeLayerAnimationController::synchronizeAnimations):
(WebKitTests):
(WebKitTests::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSubframes with scrollable areas must be added to the non-fast scrollable region
andersca@apple.com [Thu, 23 Feb 2012 01:13:08 +0000 (01:13 +0000)]
Subframes with scrollable areas must be added to the non-fast scrollable region
https://bugs.webkit.org/show_bug.cgi?id=79306
<rdar://problem/10915564>

Reviewed by Andreas Kling.

When computing the non-fast scrollable region, add subframes with scrollable regions to the region.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed gardening. Update expectations after skia roll.
enne@google.com [Thu, 23 Feb 2012 01:04:16 +0000 (01:04 +0000)]
[chromium] Unreviewed gardening. Update expectations after skia roll.

It is most likely that the Skia roll from 3216 to 3226 slightly
changed image expectations for the following tests. None of these are
perceptually any different, so just rebaselining.

* platform/chromium-linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/chromium-linux/fast/borders/border-image-rotate-transform-expected.png:
* platform/chromium-linux/svg/custom/focus-ring-expected.png:
* platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.png:
* platform/chromium-mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/chromium-mac-leopard/svg/custom/focus-ring-expected.png:
* platform/chromium-mac-leopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
* platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/chromium-mac-snowleopard/fast/borders/border-image-rotate-transform-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png:
* platform/chromium-mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
* platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/chromium-win/fast/borders/border-image-rotate-transform-expected.png:
* platform/chromium-win/svg/custom/focus-ring-expected.png:
* platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add eventSender.gestureTap
commit-queue@webkit.org [Thu, 23 Feb 2012 00:56:06 +0000 (00:56 +0000)]
[Qt] Add eventSender.gestureTap
https://bugs.webkit.org/show_bug.cgi?id=66173

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-22
Reviewed by Kenneth Rohde Christiansen.

Tools:

* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::gestureTap):
* DumpRenderTree/qt/EventSenderQt.h:

LayoutTests:

Unskip gestureTap test.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: CachedResourceLoader ignores the Range header
japhet@chromium.org [Thu, 23 Feb 2012 00:47:02 +0000 (00:47 +0000)]
Source/WebCore: CachedResourceLoader ignores the Range header
in determineRavlidationPolicy(), resulting in incorrect
cache hits.

Reviewed by Adam Barth.

Test: http/tests/xmlhttprequest/range-test.html
Test written by Aaron Colwell (acolwell@chromium.org).

* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::determineRevalidationPolicy):

LayoutTests: Test Range header compliance for CachedResources.
https://bugs.webkit.org/show_bug.cgi?id=76564

Reviewed by Adam Barth.

* http/tests/xmlhttprequest/range-test-expected.txt: Added.
* http/tests/xmlhttprequest/range-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed gardening. Generalize svg failures from r108494.
enne@google.com [Thu, 23 Feb 2012 00:44:12 +0000 (00:44 +0000)]
[chromium] Unreviewed gardening. Generalize svg failures from r108494.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r104060): Web font is not loaded if specified by link element dynamically...
antti@apple.com [Thu, 23 Feb 2012 00:42:47 +0000 (00:42 +0000)]
REGRESSION (r104060): Web font is not loaded if specified by link element dynamically inserted
https://bugs.webkit.org/show_bug.cgi?id=79186

Reviewed by Andreas Kling.

Source/WebCore:

Test: fast/css/font-face-insert-link.html

If a dynamically inserted stylesheet contains @font-face rules, we may fail to update the rendering.

Before r104060 the style selector was destroyed on every style change, and the font selector along with it.
This is no longer the case and we can't rely on comparing font selector pointers when comparing Fonts
for equality. This patch adds version number to the font selector and checks it in Font::operator==.
The version number is incremented when new font-face rules are added to the font selector.

FontFallbackList is an object shared between Fonts so the extra field shouldn't matter much in terms
of memory.

* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::CSSFontSelector):
(WebCore::CSSFontSelector::addFontFaceRule):
* css/CSSFontSelector.h:
(CSSFontSelector):
* platform/graphics/Font.cpp:
(WebCore::Font::operator==):
* platform/graphics/FontFallbackList.cpp:
(WebCore::FontFallbackList::FontFallbackList):
(WebCore::FontFallbackList::invalidate):
* platform/graphics/FontFallbackList.h:
(FontFallbackList):
(WebCore::FontFallbackList::fontSelectorVersion):
* platform/graphics/FontSelector.h:
(FontSelector):

LayoutTests:

* fast/css/font-face-insert-link-expected.txt: Added.
* fast/css/font-face-insert-link.html: Added.
* fast/css/resources/ahem.css: Added.
(@font-face):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Prevent CachedRawResource from sending the same data
japhet@chromium.org [Thu, 23 Feb 2012 00:38:17 +0000 (00:38 +0000)]
Source/WebCore: Prevent CachedRawResource from sending the same data
chunk multiple times.
https://bugs.webkit.org/show_bug.cgi?id=78810

Reviewed by Adam Barth.

If a CachedRawResource receives data while a CachedRawResourceCallback
timer is active, the incremental data will be sent to the client, followed
but all data received so far, resulting in invalid data. Resolving this adds
complexity to CachedRawResource and requires making a few more CachedResource
functions virtual, so push the callback logic into CachedResource where it can
be implemented more cleanly.

Test: inspector/debugger/script-formatter-console.html
    should no longer be flaky.

* loader/cache/CachedRawResource.cpp: CachedRawResourceCallback renamed and moved to CachedResource.
(WebCore::CachedRawResource::didAddClient): More or less the same as sendCallbacks() was.
* loader/cache/CachedRawResource.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::addClient): Check the return value of addClientToSet() to determine whether
    or not to call didAddClient.
(WebCore::CachedResource::didAddClient): May be called during addClient(), or may be called on a timer.
    If called on a timer, move the client between sets.
(WebCore::CachedResource::addClientToSet): Determine whether didAddClient() can be called synchronously and
    return true if it can.
(WebCore::CachedResource::removeClient): Ensure we cancel pending callbacks if necessary.
(WebCore::CachedResource::CachedResourceCallback::CachedResourceCallback): Renamed and moved from CachedRawResource.
* loader/cache/CachedResource.h:
(WebCore::CachedResource::hasClients): Check m_clientsAwaitingCallback as well as m_clients.
(WebCore::CachedResource::CachedResourceCallback::schedule):
(WebCore::CachedResource::hasClient): Helper for calling contains() on both m_clientsAwaitingCallback and m_clients.

LayoutTests: inspector/debugger/script-formatter-console.html should
no longer be flaky.
https://bugs.webkit.org/show_bug.cgi?id=78810

Reviewed by Adam Barth.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CMake] Remove FindGDK.cmake and FindGDK-PixBuf.cmake
kubo@profusion.mobi [Thu, 23 Feb 2012 00:26:55 +0000 (00:26 +0000)]
[CMake] Remove FindGDK.cmake and FindGDK-PixBuf.cmake
https://bugs.webkit.org/show_bug.cgi?id=79292

Reviewed by Daniel Bates.

These files were committed when the EFL port's buildsystem code
was upstreamed, but are currently not being used anywhere, as the EFL
port has not depended on GDK for a long time.

* Source/cmake/FindGDK-PixBuf.cmake: Removed.
* Source/cmake/FindGDK.cmake: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement TiledCoreAnimationDrawingAreaProxy::deviceScaleFactorDidChange
andersca@apple.com [Thu, 23 Feb 2012 00:24:11 +0000 (00:24 +0000)]
Implement TiledCoreAnimationDrawingAreaProxy::deviceScaleFactorDidChange
https://bugs.webkit.org/show_bug.cgi?id=79297
<rdar://problem/10748510>

Reviewed by Beth Dakin.

* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::deviceScaleFactorDidChange):
Send a message to the web process.

* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setDeviceScaleFactor):
Add empty stub.

* WebProcess/WebPage/DrawingArea.messages.in:
Add SetDeviceScaleFactor message.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setDeviceScaleFactor):
Call WebPage::setDeviceScaleFactor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/10406044> and https://bugs.webkit.org/show_bug.cgi?id=79279
beidson@apple.com [Thu, 23 Feb 2012 00:16:53 +0000 (00:16 +0000)]
<rdar://problem/10406044> and https://bugs.webkit.org/show_bug.cgi?id=79279
Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs

Reviewed by NOBODY (OOPS!).

Source/WebKit2:

Anytime the WebProcess sends a sync message up to the UI Process a hang can ensue.

In the case of shouldGoToBackForwardListItem it seems many clients want a back/forward
notification but don't actually want to make a policy decision.

Making it an asynchronous notification instead of a synchronous policy call will remove the
possibility of a hang here.

If clients later decide it is important to have a policy here we should implement a form of
shouldGoToBackForwardListItem in the bundle loader client.

Add a notification "willGoToBackForwardListItem" to the WKPageLoaderClient:
* UIProcess/API/C/WKPage.h:

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeLoaderClient): Tell the WebProcess whether it should be
  sending the shouldGoToBackForwardListItem or willGoToBackForwardListItem form of this message.
(WebKit::WebPageProxy::shouldGoToBackForwardListItem):
(WebKit::WebPageProxy::willGoToBackForwardListItem):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in: Add an asynchronous WillGoToBackForwardListItem message

Store a flag in the WebProcess - Sent from the UIProcess - to tell the FrameLoaderClient which form
of the callback should be used:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::willGoToBackForwardItemCallbackEnabled):
(WebKit::WebPage::setWillGoToBackForwardItemCallbackEnabled):
* WebProcess/WebPage/WebPage.messages.in:

* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::shouldGoToBackForwardListItem): Only consider calling this for
  version 0 clients.
(WebKit::WebLoaderClient::willGoToBackForwardListItem): Later clients get this callback.
* UIProcess/WebLoaderClient.h:
(WebLoaderClient):

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::shouldGoToHistoryItem): Send either the synchronous "should" message
  or the asynchronous "will" message depending on which the WebProcess was last told that the
  UIProcess expects. There is an edge case where the wrong one might be sent because the WebProcess
  hasn't received the message about a change in the WKPageLoaderClient yet but that's probably okay;
  It seems unlikely that a UIProcess client would ever rapidly change between v0 and other versions
  of the loader client and the UIProcess of WebKit2 is equipped to handle that case if it comes up.

Tools:

Update our tools to the new form of the PageLoadClient.

* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Object.freeze for non-final objects.
barraclough@apple.com [Wed, 22 Feb 2012 23:46:48 +0000 (23:46 +0000)]
Fix Object.freeze for non-final objects.
https://bugs.webkit.org/show_bug.cgi?id=79286

Reviewed by Oliver Hunt.

For vanilla objects we implement this with a single transition, for objects
with special properties we should just follow the spec defined algorithm.

Source/JavaScriptCore:

* runtime/JSArray.cpp:
(JSC::SparseArrayValueMap::put):
    - this does need to handle inextensible objects.
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
    - Implement spec defined algorithm for non-final objects.
* runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::freezeTransition):
    - freeze should set m_hasReadOnlyOrGetterSetterPropertiesExcludingProto.
* runtime/Structure.h:
(JSC::Structure::hasReadOnlyOrGetterSetterPropertiesExcludingProto):
(JSC::Structure::setHasGetterSetterProperties):
(JSC::Structure::setContainsReadOnlyProperties):
(Structure):
    - renamed m_hasReadOnlyOrGetterSetterPropertiesExcludingProto.

LayoutTests:

* fast/js/preventExtensions-expected.txt:
* fast/js/script-tests/preventExtensions.js:
    - added new tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate change log entry for r108561 to reflect removal of "if (m_dispatchSoonList...
dbates@webkit.org [Wed, 22 Feb 2012 23:46:45 +0000 (23:46 +0000)]
Update change log entry for r108561 to reflect removal of "if (m_dispatchSoonList.isEmpty())".
https://bugs.webkit.org/show_bug.cgi?id=78840

Mention removal of unnecessary check for empty list m_dispatchSoonList in EventSender::cancelEvent().

Also, fix the date in the change log entry for changeset r108562 since it landed today (02/22/2012).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108567 268f45cc-cd09-0410-ab3c-d52691b4dbfc