WebKit-https.git
11 years agoIncorrect UA style when printing a simple document
mitz@apple.com [Thu, 2 Jun 2011 07:21:12 +0000 (07:21 +0000)]
Incorrect UA style when printing a simple document
https://bugs.webkit.org/show_bug.cgi?id=61900

Reviewed by Anders Carlsson.

This is not testable in run-webkit-tests because unless the test is the first to run in an instance
of DumpRenderTree, it is not guaranteed that the full default style sheet has not been initialized.

* css/CSSStyleSelector.cpp:
(WebCore::loadFullDefaultStyle): Replace the simple default print style, which is now equal to the
simple default style, with a new RuleSet before adding the style rules from the full default sheet.
(WebCore::loadSimpleDefaultStyle): Set defaultPrintStyle to point to the default style. They are
equal in the simple case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 2 Jun 2011 07:04:05 +0000 (07:04 +0000)]
2011-06-01  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Remove outer-spin-button
        https://bugs.webkit.org/show_bug.cgi?id=61845

        Update Mac expectations because the position of steppers are moved.

        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png:
        * platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
        * platform/mac/fast/forms/input-appearance-spinbutton-expected.png:
        * platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
        * platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.png:
        * platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt:
        * platform/mac/fast/forms/input-appearance-spinbutton-up-expected.png:
        * platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
        * platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.png:
        * platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
2011-06-01  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Remove outer-spin-button
        https://bugs.webkit.org/show_bug.cgi?id=61845

        Remove outer-spin-button, and render steppers as inner-spin-button.
        Outer-spin-button have never worked well with padding and border of
        <input>, and the layout code is very tricky and very hard to maintain it.

        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        * css/CSSValueKeywords.in:
        * css/html.css:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::innerSpinButtonElement):
        * html/HTMLInputElement.h:
        * html/InputType.h:
        * html/TextFieldInputType.cpp:
        (WebCore::TextFieldInputType::TextFieldInputType):
        (WebCore::TextFieldInputType::createShadowSubtree):
        (WebCore::TextFieldInputType::destroyShadowSubtree):
        * html/TextFieldInputType.h:
        * html/shadow/TextControlInnerElements.cpp:
        (WebCore::SpinButtonElement::SpinButtonElement):
        (WebCore::SpinButtonElement::create):
        (WebCore::SpinButtonElement::shadowPseudoId):
        * html/shadow/TextControlInnerElements.h:
        * platform/ThemeTypes.h:
        * platform/chromium/ThemeChromiumMac.mm:
        (WebCore::paintStepper):
         Center the stepper drawing area because the specified area can be
         larger than the NSStepper sizes.
        (WebCore::ThemeChromiumMac::controlSize):
        (WebCore::ThemeChromiumMac::minimumControlSize):
        (WebCore::ThemeChromiumMac::inflateControlPaintRect):
        (WebCore::ThemeChromiumMac::paint):
        * platform/mac/ThemeMac.mm:
        (WebCore::paintStepper):
         Center the stepper drawing area because the specified area can be
         larger than the NSStepper sizes.
        (WebCore::ThemeMac::controlSize):
        (WebCore::ThemeMac::minimumControlSize):
        (WebCore::ThemeMac::inflateControlPaintRect):
        (WebCore::ThemeMac::paint):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintBoxDecorations):
        * rendering/RenderBox.h:
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::layout):
        (WebCore::RenderTextControlSingleLine::nodeAtPoint):
        (WebCore::RenderTextControlSingleLine::textBlockWidth):
        * rendering/RenderTextControlSingleLine.h:
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::adjustStyle):
        (WebCore::RenderTheme::paint):
        (WebCore::RenderTheme::adjustInnerSpinButtonStyle):
        * rendering/RenderTheme.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::adjustRepaintRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Thu, 2 Jun 2011 06:41:17 +0000 (06:41 +0000)]
2011-06-01  Emil A Eklund  <eae@chromium.org>

        Reviewed by Eric Seidel.

        Switch RenderLayer::convertToLayerCoords to use IntPoint
        https://bugs.webkit.org/show_bug.cgi?id=61818

        Covered by existing tests.

        * platform/graphics/FloatPoint.h:
        (WebCore::flooredIntSize):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPositions):
        (WebCore::expandClipRectForDescendantsAndReflection):
        (WebCore::transparencyClipBox):
        (WebCore::RenderLayer::convertToLayerCoords):
        (WebCore::RenderLayer::paintLayer):
        (WebCore::RenderLayer::paintChildLayerIntoColumns):
        (WebCore::RenderLayer::createLocalTransformState):
        (WebCore::RenderLayer::hitTestChildLayerColumns):
        (WebCore::RenderLayer::calculateClipRects):
        (WebCore::RenderLayer::calculateRects):
        (WebCore::RenderLayer::boundingBox):
        (WebCore::RenderLayer::setBackingNeedsRepaintInRect):
        * rendering/RenderLayer.h:
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateCompositedBounds):
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::calculateCompositedBounds):
        (WebCore::RenderLayerCompositor::layerWillBeRemoved):
        (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Thu, 2 Jun 2011 06:30:25 +0000 (06:30 +0000)]
2011-06-01  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Kent Tamura.

        Remove superfluous renderer() test
        https://bugs.webkit.org/show_bug.cgi?id=61907

        No new tests. (trivial)

        * dom/Document.cpp:
        (WebCore::Document::recalcStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Thu, 2 Jun 2011 04:51:08 +0000 (04:51 +0000)]
2011-06-01  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Hajime Morita.

        Add IntPoint + IntPoint operator
        https://bugs.webkit.org/show_bug.cgi?id=61876

        Adding an operator+ convenience method to IntPoint that sums two points
        and returns the result as an IntPoint. Changing doImageDrag to use it
        as a proof of concept.

        No new tests since there is no change in behavior.

        * page/DragController.cpp:
        (WebCore::DragController::doImageDrag):
        * platform/graphics/IntPoint.h:
        (WebCore::operator+):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Jaehun Lim <ljaehun.lim@samsung.com>
commit-queue@webkit.org [Thu, 2 Jun 2011 04:21:26 +0000 (04:21 +0000)]
2011-06-01  Jaehun Lim  <ljaehun.lim@samsung.com>

        Reviewed by Eric Seidel.

        [EFL] Add adjustMenuListButtonStyle and paintMenuListButton functions
        https://bugs.webkit.org/show_bug.cgi?id=61836

        Add functions for rendering drop-down list when style attributes are applied.

        * platform/efl/RenderThemeEfl.cpp:
        (WebCore::RenderThemeEfl::adjustMenuListButtonStyle):
        (WebCore::RenderThemeEfl::paintMenuListButton):
        * platform/efl/RenderThemeEfl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Thu, 2 Jun 2011 02:53:13 +0000 (02:53 +0000)]
2011-06-01  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket: WebSocketChannel::fail() should close the connection immediately
        https://bugs.webkit.org/show_bug.cgi?id=61851

        The effect of this change is almost unobservable. The difference between m_handle->close() and
        m_handle->disconnect() is that the former does not close the connection if the handle has
        unsent data while the latter immediately closes the connection regardless of unsent data.
        Usually a socket stream handle does not have unsent data, and even if it has any, it is hard
        for user scripts to observe the difference between close() and disconnect() (it should take some time
        for onclose() to be called if there are any unsent data, but there ought to be no other difference
        in user scripts' perspective).

        No new tests are added, because writing a test for this issue is not feasible due to the above reason.

        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::fail): Use m_handle->disconnect() instead of m_handle->close().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Thu, 2 Jun 2011 02:49:37 +0000 (02:49 +0000)]
2011-06-01  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        Coding style nit. Move ec=0 initialization, change
        recommended by Alexey in bug.
        https://bugs.webkit.org/show_bug.cgi?id=60831

        * dom/Document.cpp:
        (WebCore::Document::setBody):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Thu, 2 Jun 2011 02:23:45 +0000 (02:23 +0000)]
2011-06-01  Hayato Ito  <hayato@chromium.org>

        Reviewed by Kent Tamura.

        Move {Next,Previous}FocusableNode functions from Document to FocusController.
        https://bugs.webkit.org/show_bug.cgi?id=61839

        There are some member functions in Document which use 'this'
        pointer, but we should use TreeScope instead of Document in some
        places to handle focus issues nicely. We have to move these
        functions out of Document class so that we can give the TreeScope
        as a parameter.

        No new tests since no functionality was changed.

        * dom/Document.cpp:
        * dom/Document.h:
        * page/FocusController.cpp:
        (WebCore::FocusController::deepFocusableNode):
        (WebCore::FocusController::advanceFocusInDocumentOrder):
        (WebCore::nextNodeWithExactTabIndex):
        (WebCore::previousNodeWithExactTabIndex):
        (WebCore::nextNodeWithGreaterTabIndex):
        (WebCore::previousNodeWithLowerTabIndex):
        (WebCore::FocusController::nextFocusableNode):
        (WebCore::FocusController::previousFocusableNode):
        * page/FocusController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 2 Jun 2011 02:09:39 +0000 (02:09 +0000)]
2011-06-01  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        old-run-webkit-tests: add support for audio files
        https://bugs.webkit.org/show_bug.cgi?id=57992

        * Scripts/old-run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 2 Jun 2011 01:36:35 +0000 (01:36 +0000)]
2011-06-01  Adam Barth  <abarth@webkit.org>

        There seems to be something odd about registerProtocolHandler on Mac.
        The "no-crash" seems to "pass" because the test does not crash, where
        as the "register-protocol-handler" test fails, apparently due to the
        API being disabled.

        * platform/chromium/test_expectations.txt:
        * platform/mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
        * platform/mac/fast/dom/navigator-detached-no-crash-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt.
            - This expectation file is misplaced.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 2 Jun 2011 01:11:43 +0000 (01:11 +0000)]
2011-06-01  Adam Barth  <abarth@webkit.org>

        Now that this test doesn't time out, we can see that it fails.  That's
        progress, of a sort.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 2 Jun 2011 01:05:15 +0000 (01:05 +0000)]
2011-06-01  Adam Barth  <abarth@webkit.org>

        Move expected result to the correct location.  The script put it in the
        wrong location.

        * platform/chromium-mac/fast/js/property-getters-and-setters-expected.txt: Removed.
        * platform/chromium-win/fast/js/property-getters-and-setters-expected.txt: Removed.
        * platform/chromium/fast/js/property-getters-and-setters-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/js/property-getters-and-setters-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 2 Jun 2011 01:00:11 +0000 (01:00 +0000)]
2011-06-01  Adam Barth  <abarth@webkit.org>

        These test time out on debug, probably because drop shadows are slow in debug skia.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Adrienne Walker <enne@google.com>
enne@google.com [Thu, 2 Jun 2011 00:53:47 +0000 (00:53 +0000)]
2011-06-01  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Fix syncing of removed mask and replica layers
        https://bugs.webkit.org/show_bug.cgi?id=61895

        * platform/graphics/chromium/TreeSynchronizer.cpp:
        (WebCore::TreeSynchronizer::synchronizeTreeRecursive):
2011-06-01  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Fix syncing of removed mask and replica layers
        https://bugs.webkit.org/show_bug.cgi?id=61895

        * tests/TreeSynchronizerTest.cpp:
        (WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Julien Chaffraix <jchaffraix@codeaurora.org>
jchaffraix@webkit.org [Thu, 2 Jun 2011 00:53:01 +0000 (00:53 +0000)]
2011-06-01  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Simon Fraser.

        CSSStyleSheet#insertRule doesn't work well with imported stylesheets
        https://bugs.webkit.org/show_bug.cgi?id=56981

        Test that a combination of insertRule and @import works properly.

        * fast/css/import-and-insert-rule-no-update-expected.txt: Added.
        * fast/css/import-and-insert-rule-no-update.html: Added.
        * fast/css/resources/red.css: Added.
        (div):
        * fast/css/resources/redimport.css: Added.
2011-06-01  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Simon Fraser.

        CSSStyleSheet#insertRule doesn't work well with imported stylesheets
        https://bugs.webkit.org/show_bug.cgi?id=56981

        Test: fast/css/import-and-insert-rule-no-update.html

        The bug arises from the fact that <link> element did not know about a programmatically
        loading sheet (using insertRule and @import) and would thus never call removePendingSheet.
        This is needed to make sure our style selector contains an up-to-date list of stylesheets.

        The gist of the patch adds a way for style sheet owner element to know if we are
        programmatically loading a style sheet. This is needed as <link> keeps the information
        about that last loaded stylesheet.

        * css/CSSImportRule.cpp:
        (WebCore::CSSImportRule::insertedIntoParent): Call startLoadingDynamicSheet
        on our parent style sheet instead of directly adding a pending style sheet.

        * css/CSSStyleSheet.cpp:
        (WebCore::CSSStyleSheet::startLoadingDynamicSheet): Call startLoadingDynamicSheet
        on our owner element if we have one.

        * css/CSSStyleSheet.h:
        * dom/Node.h:
        (WebCore::Node::startLoadingDynamicSheet): Added common implementation of
        startLoadingDynamicSheet, which should never be called.

        * dom/StyleElement.cpp:
        (WebCore::StyleElement::startLoadingDynamicSheet):
        * dom/StyleElement.h:
        Common implementation of startLoadingDynamicSheet for style elements.

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::startLoadingDynamicSheet):
        * html/HTMLLinkElement.h:
        Use the HTMLLinkElement plumbing to make sure we call addRemovePendingSheet.

        * html/HTMLStyleElement.h:
        (WebCore::HTMLStyleElement::startLoadingDynamicSheet):
        * svg/SVGStyleElement.h:
        (WebCore::SVGStyleElement::startLoadingDynamicSheet):
        Forward the call to StyleElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Thu, 2 Jun 2011 00:46:41 +0000 (00:46 +0000)]
2011-06-01  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch paintCustomHighlight to use IntPoint
        https://bugs.webkit.org/show_bug.cgi?id=61562

        Switching paintCustomHighlight to use an IntPoint for
        its paint offset instead of a pair of ints.

        No new tests since this is refactoring.

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint):
        (WebCore::InlineTextBox::paintCustomHighlight):
        * rendering/InlineTextBox.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintCustomHighlight):
        * rendering/RenderBox.h:
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paintReplaced):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::paintCustomHighlight):
        (WebCore::RootInlineBox::paint):
        * rendering/RootInlineBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Wed, 1 Jun 2011 23:19:02 +0000 (23:19 +0000)]
2011-06-01  Emil A Eklund  <eae@chromium.org>

        Reviewed by Eric Seidel.

        Switch MouseRelatedEvent to use IntPoint
        https://bugs.webkit.org/show_bug.cgi?id=61574

        Covered by existing tests.

        * dom/MouseEvent.cpp:
        (WebCore::MouseEvent::MouseEvent):
        (WebCore::MouseEvent::initMouseEvent):
        (WebCore::SimulatedMouseEvent::SimulatedMouseEvent):
        * dom/MouseRelatedEvent.cpp:
        (WebCore::MouseRelatedEvent::MouseRelatedEvent):
        (WebCore::contentsScrollOffset):
        (WebCore::MouseRelatedEvent::initCoordinates):
        (WebCore::MouseRelatedEvent::computeRelativePosition):
        (WebCore::MouseRelatedEvent::layerX):
        (WebCore::MouseRelatedEvent::layerY):
        (WebCore::MouseRelatedEvent::offsetX):
        (WebCore::MouseRelatedEvent::offsetY):
        (WebCore::MouseRelatedEvent::pageX):
        (WebCore::MouseRelatedEvent::pageY):
        (WebCore::MouseRelatedEvent::pageLocation):
        (WebCore::MouseRelatedEvent::x):
        (WebCore::MouseRelatedEvent::y):
        * dom/MouseRelatedEvent.h:
        (WebCore::MouseRelatedEvent::screenX):
        (WebCore::MouseRelatedEvent::screenY):
        (WebCore::MouseRelatedEvent::screenLocation):
        (WebCore::MouseRelatedEvent::clientX):
        (WebCore::MouseRelatedEvent::clientY):
        (WebCore::MouseRelatedEvent::clientLocation):
        (WebCore::MouseRelatedEvent::absoluteLocation):
        * dom/TouchEvent.cpp:
        (WebCore::TouchEvent::TouchEvent):
        (WebCore::TouchEvent::initTouchEvent):
        * dom/WheelEvent.cpp:
        (WebCore::WheelEvent::WheelEvent):
        (WebCore::WheelEvent::initWheelEvent):
        (WebCore::WheelEventDispatchMediator::WheelEventDispatchMediator):
        * dom/WheelEvent.h:
        (WebCore::WheelEvent::create):
        (WebCore::WheelEvent::wheelDelta):
        (WebCore::WheelEvent::wheelDeltaX):
        (WebCore::WheelEvent::wheelDeltaY):
        (WebCore::WheelEvent::rawDeltaX):
        (WebCore::WheelEvent::rawDeltaY):
        (WebCore::WheelEvent::isHorizontal):
        * platform/graphics/IntPoint.h:
        (WebCore::IntPoint::scale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Wed, 1 Jun 2011 23:15:58 +0000 (23:15 +0000)]
2011-06-01  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch paintOverflowControls to use IntPoint
        https://bugs.webkit.org/show_bug.cgi?id=61884

        Switching paintOverflowControls to use an IntPoint instead of a pair of ints.

        No new tests since this is simple refactoring.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paint):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintOverflowControls):
        (WebCore::RenderLayer::paintLayer):
        * rendering/RenderLayer.h:
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::paintIntoLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Wed, 1 Jun 2011 23:13:53 +0000 (23:13 +0000)]
2011-06-01  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Fix setting of document.body
        https://bugs.webkit.org/show_bug.cgi?id=60831

        1. Only allowing setting to an element if it has a body tag.
        2. If element is from another document, import it.

        Test: fast/dom/document-set-body.html

        * dom/Document.cpp:
        (WebCore::Document::setBody):
2011-06-01  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Tests setting document.body to non body elements, elements in other
        documents.
        https://bugs.webkit.org/show_bug.cgi?id=60831

        * fast/dom/document-set-body-expected.txt: Added.
        * fast/dom/document-set-body.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 1 Jun 2011 23:03:40 +0000 (23:03 +0000)]
2011-06-01  Adam Barth  <abarth@webkit.org>

        Add Windows baseline for this new test.

        * platform/chromium-win-vista/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
        * platform/chromium-win-vista/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 1 Jun 2011 22:59:54 +0000 (22:59 +0000)]
2011-06-01  Adam Barth  <abarth@webkit.org>

        Update image baselines for these drop shadows.  They differ from each
        other only by minor rendering differences in the shadow.

        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
        * platform/chromium-linux-x86/svg/filters/feDropShadow-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
        * platform/chromium-linux/svg/filters/feDropShadow-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
        * platform/chromium-mac-leopard/svg/filters/feDropShadow-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
        * platform/chromium-mac/svg/filters/feDropShadow-expected.png:
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
        * platform/chromium-win/svg/filters/feDropShadow-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Jochen Eisinger <jochen@chromium.org>
jochen@chromium.org [Wed, 1 Jun 2011 22:57:33 +0000 (22:57 +0000)]
2011-06-01  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Adam Barth.

        Add a test for FrameLoaderClient::allowImages
        https://bugs.webkit.org/show_bug.cgi?id=34314

        * platform/chromium/permissionclient/image-permissions-expected.txt: Added.
        * platform/chromium/permissionclient/image-permissions.html: Added.
        * platform/chromium/permissionclient/resources/boston.gif: Added.
        * platform/chromium/permissionclient/resources/image.html: Added.
2011-06-01  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Adam Barth.

        Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
        https://bugs.webkit.org/show_bug.cgi?id=34314

        * DumpRenderTree/DumpRenderTree.gypi:
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::setImagesAllowed):
        (LayoutTestController::setStorageAllowed):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h.
        (WebPermissions::WebPermissions):
        (WebPermissions::~WebPermissions):
        (WebPermissions::allowImages):
        (WebPermissions::allowStorage):
        (WebPermissions::setImagesAllowed):
        (WebPermissions::setStorageAllowed):
        (WebPermissions::reset):
        * DumpRenderTree/chromium/WebPermissions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 1 Jun 2011 22:54:23 +0000 (22:54 +0000)]
2011-06-01  Adam Barth  <abarth@webkit.org>

        These tests no longer time out.  Yay!

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 1 Jun 2011 22:51:37 +0000 (22:51 +0000)]
2011-06-01  Adam Barth  <abarth@webkit.org>

        Update expected results to match V8 rather than JSC.

        * platform/chromium-mac/fast/js/property-getters-and-setters-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNon-users need access to the mds caches for SSL support.
weinig@apple.com [Wed, 1 Jun 2011 22:48:28 +0000 (22:48 +0000)]
Non-users need access to the mds caches for SSL support.
<rdar://problem/9471799>

Reviewed by Anders Carlsson.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSafari always crashes on http://bbc.co.uk when VoiceOver enabled
cfleizach@apple.com [Wed, 1 Jun 2011 22:37:07 +0000 (22:37 +0000)]
Safari always crashes on bbc.co.uk when VoiceOver enabled
https://bugs.webkit.org/show_bug.cgi?id=61886

Reviewed by Darin Adler.

This crash can happen on webpages that remove an element from the DOM when the element receives focus.
When AppKit goes to post a notification to inform VoiceOver the focus has changed, it asks for the AXFocusedUIElement.
However by posting that notification, a render tree update is performed. This causes the element to disappear, but
AppKit still has a handle to it and continues to try to reference it. When the autorelease pool pops, the reference goes bad.

To fix, the root element, the AccessibilityScrollView, needs to implement updateBackingStore(), otherwise this method
will not be called in time.

No test could be created because to cause it depends on an internal AppKit mechanism
that is only triggered remotely through the accessibility runtime.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::updateBackingStore):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
* accessibility/AccessibilityRenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Noel Gordon <noel.gordon@gmail.com>
commit-queue@webkit.org [Wed, 1 Jun 2011 21:57:05 +0000 (21:57 +0000)]
2011-06-01  Noel Gordon  <noel.gordon@gmail.com>

        Reviewed by Tony Chang.

        Test plugin should support event logging on the windows port.
        https://bugs.webkit.org/show_bug.cgi?id=61721

        * platform/chromium-win/plugins/keyboard-events-expected.txt:  New windows result.
        * platform/chromium/test_expectations.txt:  New expectations.
        * plugins/keyboard-events.html:  Add attribute windowPlugin="false" to force the
        Chromium windows port to load the test plugin in windowless mode. The plugin will
        then receive events and can log them to the console as required by this test.
        * plugins/mouse-events.html:  Ditto.
2011-06-01  Noel Gordon  <noel.gordon@gmail.com>

        Reviewed by Tony Chang.

        Test plugin should support event logging on the windows port.
        https://bugs.webkit.org/show_bug.cgi?id=61721

        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
        (handleEventWin): Well, handle them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 1 Jun 2011 21:55:43 +0000 (21:55 +0000)]
2011-06-01  Adam Barth  <abarth@webkit.org>

        ... and finally Windows.

        * platform/chromium-win-vista/fullscreen/full-screen-zIndex-after-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 David Carson <dacarson@apple.com>
commit-queue@webkit.org [Wed, 1 Jun 2011 21:42:43 +0000 (21:42 +0000)]
2011-06-01  David Carson  <dacarson@apple.com>

        Reviewed by Antti Koivisto.

        Don't flatten frames that have a zero size.
        https://bugs.webkit.org/show_bug.cgi?id=61831

        This tests creates an iframe that has a width and height of zero
        and ensures that the iframe is not flattened to the size of the
        containing content.

        * fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html: Added.
        * fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size-expected.txt: Added.
2011-06-01  David Carson  <dacarson@apple.com>

        Reviewed by Antti Koivisto.

        https://bugs.webkit.org/show_bug.cgi?id=61831
        If width and height of an iframe is fixed and should not be visible, then
        it shouldn't be flattened.

        Test: fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html

        * rendering/RenderIFrame.cpp:
        (WebCore::RenderIFrame::flattenFrame): add a check for a zero width or height

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 1 Jun 2011 21:32:31 +0000 (21:32 +0000)]
2011-06-01  Adam Barth  <abarth@webkit.org>

        Linux image baselines for this new test.  Leviw confirms that this results are correct.

        * platform/chromium-linux-x86/svg/text: Added.
        * platform/chromium-linux-x86/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
        * platform/chromium-linux-x86/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
        * platform/chromium-linux/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
        * platform/chromium-linux/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 1 Jun 2011 21:28:37 +0000 (21:28 +0000)]
2011-06-01  Adam Barth  <abarth@webkit.org>

        Image baselines for this new test.

        * platform/chromium-linux-x86/fullscreen/full-screen-zIndex-after-expected.png: Added.
        * platform/chromium-linux/fullscreen/full-screen-zIndex-after-expected.png: Added.
        * platform/chromium-mac/fullscreen/full-screen-zIndex-after-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 1 Jun 2011 21:25:16 +0000 (21:25 +0000)]
2011-06-01  Adam Barth  <abarth@webkit.org>

        ... and now Windows results.

        * platform/chromium-win-vista/svg/custom/embedding-external-svgs-expected.png: Added.
        * platform/chromium-win-vista/svg/custom/embedding-external-svgs-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Daniel Cheng <dcheng@chromium.org>
dcheng@chromium.org [Wed, 1 Jun 2011 21:13:06 +0000 (21:13 +0000)]
2011-06-01  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Tony Chang.

        [chromium] Use correct file name for dragging out images.
        https://bugs.webkit.org/show_bug.cgi?id=24887

        * fast/events/drag-image-filename-expected.txt: Added.
        * fast/events/drag-image-filename.html: Added.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-06-01  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Tony Chang.

        [chromium] Use correct file name for dragging out images.
        https://bugs.webkit.org/show_bug.cgi?id=24887

        We try to guess an appropriate filename when dragging out images. In order, we try to use:
        - The filename suggested in the HTTP header.
        - The last path component of the source URL.
        - The alt text.
        This matches the behavior of the other WebKit ports.

        Test: fast/events/drag-image-filename.html

        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::writeImageToDataObject):
        * platform/chromium/ClipboardChromiumMac.cpp:
        (WebCore::isInvalidFileCharacter):
        (WebCore::ClipboardChromium::validateFileName):
2011-06-01  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Tony Chang.

        [chromium] Use correct file name for dragging out images.
        https://bugs.webkit.org/show_bug.cgi?id=24887

        * DumpRenderTree/chromium/EventSender.cpp:
        (EventSender::EventSender):
        (EventSender::dumpFilenameBeingDragged):
        * DumpRenderTree/chromium/EventSender.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 1 Jun 2011 21:09:05 +0000 (21:09 +0000)]
2011-06-01  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        nrwt: make webaudio work w/o content-length header
        https://bugs.webkit.org/show_bug.cgi?id=61819

        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
        * Scripts/webkitpy/layout_tests/port/mock_drt.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Wed, 1 Jun 2011 21:00:56 +0000 (21:00 +0000)]
2011-06-01  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Text is scaled in a stair-step pattern
        https://bugs.webkit.org/show_bug.cgi?id=60317

        Stop scaling the specified font to the actual on-screen value when font-rendering:
        geometricPrecision is specified, but instead scale the graphics context. This allows
        us to scale text up and down smoothly.

        Test: svg/text/scaling-font-with-geometric-precision.html

        * rendering/svg/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):
2011-06-01  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Text is scaled in a stair-step pattern
        https://bugs.webkit.org/show_bug.cgi?id=60317

        Stop scaling the specified font to the actual on-screen value when font-rendering:
        geometricPrecision is specified, but instead scale the graphics context. This allows
        us to scale text up and down smoothly.

        * platform/mac/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
        * platform/mac/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
        * svg/text/scaling-font-with-geometric-precision.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Wed, 1 Jun 2011 20:58:34 +0000 (20:58 +0000)]
2011-06-01  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch paintResizer to use IntPoint
        https://bugs.webkit.org/show_bug.cgi?id=61883

        Switch paintResizer to take an IntPoint instead of a pair of ints.

        No new tests as this is simple refactoring.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintOverflowControls):
        (WebCore::RenderLayer::paintResizer):
        * rendering/RenderLayer.h:
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::paintContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Wed, 1 Jun 2011 20:57:15 +0000 (20:57 +0000)]
2011-06-01  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Page layout messed up after exiting full screen at Apple trailers page
        https://bugs.webkit.org/show_bug.cgi?id=61755

        * fullscreen/full-screen-zIndex-after-expected.txt: Added.
        * fullscreen/full-screen-zIndex-after.html: Added.
        * platform/mac/fullscreen/full-screen-zIndex-after-expected.png: Added.
2011-06-01  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Page layout messed up after exiting full screen at Apple trailers page
        https://bugs.webkit.org/show_bug.cgi?id=61755
        <rdar://problem/9525277>

        Test: fullscreen/full-screen-zIndex-after.html

        Fix the incomplete implementation of r87660. Make parameters to
        setContainsFullScreenElementRecursively() in webkitWillExitFullScreenForElement() match those
        in webkitWillEnterFullScreenForElement(), so the ancestors' flags do not become
        inconsistent..

        * dom/Document.cpp:
        (WebCore::Document::webkitWillExitFullScreenForElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 1 Jun 2011 20:52:44 +0000 (20:52 +0000)]
2011-06-01  Adam Barth  <abarth@webkit.org>

        Image baselines for this test.  More to follow once the bots catch up.

        * platform/chromium-linux-x86/svg/custom/embedding-external-svgs-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/embedding-external-svgs-expected.txt: Added.
        * platform/chromium-linux/svg/custom/embedding-external-svgs-expected.png: Added.
        * platform/chromium-linux/svg/custom/embedding-external-svgs-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 1 Jun 2011 20:42:30 +0000 (20:42 +0000)]
2011-06-01  Adam Barth  <abarth@webkit.org>

        Image baselines for these platforms.

        * platform/chromium-linux-x86/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
        * platform/chromium-linux-x86/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.
        * platform/chromium-linux/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
        * platform/chromium-linux/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.
        * platform/chromium-win-vista/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
        * platform/chromium-win-vista/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Wed, 1 Jun 2011 20:38:14 +0000 (20:38 +0000)]
2011-06-01  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch paintScrollCorner to use IntPoint
        https://bugs.webkit.org/show_bug.cgi?id=61874

        Changing paintScrollCorner to take an IntPoint representing the paint
        offset instead of a pair of ints.

        No new tests as this is simple refactoring.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintOverflowControls):
        (WebCore::RenderLayer::paintScrollCorner):
        * rendering/RenderLayer.h:
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::paintContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 1 Jun 2011 20:24:28 +0000 (20:24 +0000)]
2011-06-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Rob Buis.

        SVG graphics do not actually work in IMG tags or as background-image properties
        https://bugs.webkit.org/show_bug.cgi?id=18228

        Adding the nice testcase from the bug 18228, all issues are fully resolved now.

        * platform/mac/svg/custom/embedding-external-svgs-expected.png: Added.
        * platform/mac/svg/custom/embedding-external-svgs-expected.txt: Added.
        * svg/custom/embedding-external-svgs.xhtml: Added.
        * svg/custom/resources/spinner.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Wed, 1 Jun 2011 20:14:36 +0000 (20:14 +0000)]
2011-06-01  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        Flash of old video frame at the end of full screen transition
        https://bugs.webkit.org/show_bug.cgi?id=61752

        Add a new method and message, DisposeOfLayerClient, which will invalidate and release
        the WKRemoteLayerClient used during the full-screen animation.  This ensures that
        the root layer used for the full-screen animation will be in a clean state at the start
        of the next transition.

        * UIProcess/WebFullScreenManagerProxy.cpp:
        (WebKit::WebFullScreenManagerProxy::disposeOfLayerClient): Added.
        * UIProcess/WebFullScreenManagerProxy.h:
        * UIProcess/mac/WKFullScreenWindowController.mm:
        (-[WKFullScreenWindowController exitCompositedModeRepaintCompleted]): Call disposeOfLayerClient.
        * WebProcess/FullScreen/WebFullScreenManager.h:
        (WebKit::WebFullScreenManager::disposeOfLayerClient): Added.
        * WebProcess/FullScreen/WebFullScreenManager.messages.in: Added DisposeOfLayerClient.
        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:
        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
        (WebKit::WebFullScreenManagerMac::disposeOfLayerClient): Added, invalidates and clears m_rootLayerClient.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 1 Jun 2011 20:09:04 +0000 (20:09 +0000)]
2011-06-01  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Add single character lookup cache to IdentifierArena
        https://bugs.webkit.org/show_bug.cgi?id=61879

        Add a simple lookup cache for single ascii character
        identifiers.  Produces around a 2% improvement in parse
        time for my adhoc parser test.

        * parser/ParserArena.h:
        (JSC::IdentifierArena::IdentifierArena):
        (JSC::IdentifierArena::clear):
        (JSC::IdentifierArena::makeIdentifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Kenneth Russell <kbr@google.com>
kbr@google.com [Wed, 1 Jun 2011 19:52:13 +0000 (19:52 +0000)]
2011-06-01  Kenneth Russell  <kbr@google.com>

        Reviewed by Nate Chapin.

        [V8] Optimize fetches of indexed properties in custom bindings
        https://bugs.webkit.org/show_bug.cgi?id=61821

        Avoid allocating garbage in affected custom bindings. This speeds
        up one test case by at least a factor of two. No new tests;
        covered by existing layout tests (typed array and otherwise).

        * bindings/v8/custom/V8ArrayBufferViewCustom.h:
        (WebCore::constructWebGLArray):
        (WebCore::setWebGLArrayHelper):
        * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
        (WebCore::V8InspectorFrontendHost::showContextMenuCallback):
        * bindings/v8/custom/V8MessagePortCustom.cpp:
        (WebCore::getMessagePortArray):
        * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
        (WebCore::jsArrayToFloatArray):
        (WebCore::jsArrayToIntArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 1 Jun 2011 19:20:04 +0000 (19:20 +0000)]
2011-06-01  Adam Barth  <abarth@webkit.org>

        Add new results for this new test.  Our results are different by one
        pixel.  Mac results likely to follow once those bots catch up.

        * platform/chromium-linux-x86/svg/as-image: Added.
        * platform/chromium-linux-x86/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
        * platform/chromium-linux/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
        * platform/chromium-win-vista/svg/as-image: Added.
        * platform/chromium-win-vista/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 1 Jun 2011 18:58:26 +0000 (18:58 +0000)]
2011-06-01  Ryosuke Niwa  <rniwa@webkit.org>

        Skip editing/pasteboard/drag-drop-list.html on GTK after r87778
        since smart paste isn't supported by GTK (tracked by the bug 61661).

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix after r87831
aroben@apple.com [Wed, 1 Jun 2011 18:54:48 +0000 (18:54 +0000)]
Build fix after r87831

* UIProcess/win/WebView.cpp:
(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):
Added some HAVE(WKQCA) guards.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Annie Sullivan <sullivan@chromium.org>
rniwa@webkit.org [Wed, 1 Jun 2011 18:44:12 +0000 (18:44 +0000)]
2011-06-01  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Ryosuke Niwa.

        LayoutTests/editing/pasteboard/drag-drop-list fails on webkit2
        https://bugs.webkit.org/show_bug.cgi?id=61871

        Renames editing/pasteboard/4861080.html to drag-drop-list.html, since it was renamed in r87778.

        * platform/mac-wk2/Skipped:
        * platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDelete a bunch of dead code in DrawingAreaImpl
aroben@apple.com [Wed, 1 Jun 2011 18:41:23 +0000 (18:41 +0000)]
Delete a bunch of dead code in DrawingAreaImpl

LayerTreeHost::participatesInDisplay always returns false now, which means a bunch of code
in DrawingAreaImpl no longer runs.

Cleanup after fixing <http://webkit.org/b/58054>
<rdar://problem/9249839> REGRESSION (WebKit2): Accelerated CSS animations have a lower
framerate than in WebKit1

Reviewed by Anders Carlsson.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::forceRepaint):
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers):
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
(WebKit::DrawingAreaImpl::didUpdate):
(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::scheduleDisplay):
(WebKit::DrawingAreaImpl::displayTimerFired):
(WebKit::DrawingAreaImpl::display):
* WebProcess/WebPage/DrawingAreaImpl.h:
* WebProcess/WebPage/LayerTreeHost.h:
Reverted r82959.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRender accelerated content into a web process-owned child HWND
aroben@apple.com [Wed, 1 Jun 2011 18:39:19 +0000 (18:39 +0000)]
Render accelerated content into a web process-owned child HWND

This allows us to use WKCACFView's far more efficient kWKCACFViewDrawingDestinationWindow
mode, which gives us asynchronous rendering on a background thread and doesn't require us to
read bits off the GPU back into system memory.

A new class, WKCACFViewWindow, represents the child HWND. The child HWND is placed at the
bottom of the z-order so it won't obscure any other child HWNDs (i.e., windowed plugins).
The child HWND is made transparent to mouse events so that WKView will continue to receive
mouse events even though it is obscured by the child HWND.

There is now a bunch of dead code in DrawingAreaImpl to handle our old rendering model. I'll
remove that in a future patch.

Fixes <http://webkit.org/b/58054> <rdar://problem/9249839> REGRESSION (WebKit2): Accelerated
CSS animations have a lower framerate than in WebKit1

Reviewed by Anders Carlsson.

* Shared/LayerTreeContext.h: Added HWND member on Windows.

* Shared/win/CoalescedWindowGeometriesUpdater.cpp:
(WebKit::CoalescedWindowGeometriesUpdater::updateGeometries):
* Shared/win/CoalescedWindowGeometriesUpdater.h:
Added new BringToTopOrNot argument. Allows the caller to specify that all windows being
updated should also be brought to the top of the z-order.

* Shared/win/LayerTreeContextWin.cpp:
(WebKit::LayerTreeContext::LayerTreeContext):
(WebKit::LayerTreeContext::~LayerTreeContext):
(WebKit::LayerTreeContext::encode):
(WebKit::LayerTreeContext::decode):
(WebKit::LayerTreeContext::isEmpty):
(WebKit::operator==):
Implemented based on new window member.

* UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView): Initialize new member.
(WebKit::WebView::onSizeEvent): Resize the layer host window to cover our entire view, if we
have one.
(WebKit::WebView::enterAcceleratedCompositingMode): Store, position, and show the layer host
window.
(WebKit::WebView::exitAcceleratedCompositingMode): Destroy the layer host window.
(WebKit::WebView::updateChildWindowGeometries): Updated for change to
CoalescedWindowGeometriesUpdater.

* UIProcess/win/WebView.h: Added m_layerHostWindow member.

* WebProcess/WebPage/LayerTreeHost.h: Added scheduleChildWindowGeometryUpdate.

* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
(WebKit::LayerTreeHostCAWin::supportsAcceleratedCompositing): Simplified by using
WKCACFViewWindow.

(WebKit::LayerTreeHostCAWin::LayerTreeHostCAWin): Removed initialization of a removed
member.
(WebKit::LayerTreeHostCAWin::platformInitialize): Changed to use WKCACFViewWindow,
kWKCACFViewDrawingDestinationWindow, and to initialize the LayerTreeContext.
(WebKit::LayerTreeHostCAWin::invalidate): Leak our window and tell it to clean up after
itself. The UI process will take care of destroying the window when it finishes switching
out of accelerated compositing mode. Removed a WKCACFViewUpdate call that is now handled by
WKCACFViewWindow.
(WebKit::LayerTreeHostCAWin::scheduleChildWindowGeometryUpdate): Added. Calls through to
m_geometriesUpdater.
(WebKit::LayerTreeHostCAWin::sizeDidChange): Updated to use WKCACFViewWindow.
(WebKit::LayerTreeHostCAWin::contextDidChange): Update child window geometries now to keep
them (almost) in sync with the accelerated content. <http://webkit.org/b/61867> covers the
slight asynchrony that still exists.
(WebKit::LayerTreeHostCAWin::setRootCompositingLayer): Don't flush any changes when we don't
have a root layer. This prevents a flash of white when switching out of compositing mode.

* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h: Added m_window and m_geometriesUpdater.
Removed code related to the old, synchronous display model.

* WebProcess/WebPage/ca/win/WKCACFViewWindow.cpp: Added.
(WebKit::WKCACFViewWindow::WKCACFViewWindow): Initialize members and create our window.
(WebKit::WKCACFViewWindow::~WKCACFViewWindow): Destroy our window if needed.
(WebKit::WKCACFViewWindow::onCustomDestroy): Just call ::DestroyWindow.
(WebKit::WKCACFViewWindow::onDestroy): Tell our view not to render into our window anymore.
(WebKit::WKCACFViewWindow::onEraseBackground): Tell Windows not to erase us.
(WebKit::WKCACFViewWindow::onNCDestroy): Clear out m_window since it's now pointing to a
destroy window, and destroy ourselves if requested.
(WebKit::WKCACFViewWindow::onPaint): Tell the view to draw, then clear our invalid region.
(WebKit::WKCACFViewWindow::onPrintClient): Tell our view to draw into the given HDC.
(WebKit::WKCACFViewWindow::registerClass): Register our class (duh).
(WebKit::WKCACFViewWindow::staticWndProc): Get the WKCACFViewWindow pointer, or store the
pointer if needed, then call through to wndProc.
(WebKit::WKCACFViewWindow::wndProc): Call out to the appropriate handler function.

* WebProcess/WebPage/ca/win/WKCACFViewWindow.h: Added.
(WebKit::WKCACFViewWindow::setDeletesSelfWhenWindowDestroyed): Simple setter.
(WebKit::WKCACFViewWindow::window): Simple getter.

* WebProcess/WebPage/win/DrawingAreaImplWin.cpp:
(WebKit::DrawingAreaImpl::scheduleChildWindowGeometryUpdate): Let the LayerTreeHost handle
the geometry update, if we have one.

* win/WebKit2.vcproj: Added WKCACFViewWindow files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 1 Jun 2011 18:38:35 +0000 (18:38 +0000)]
2011-06-01  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        Explictly request the size of a pointer in malloc. Otherwise this
        explodes in 64bit architectures, at least.

        * webkit/webkitwebplugin.cpp:
        (webkit_web_plugin_get_mimetypes): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 1 Jun 2011 18:36:13 +0000 (18:36 +0000)]
2011-06-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Eric Seidel.

        Permanent red background when SVG is used as a background image (DEBUG ONLY)
        https://bugs.webkit.org/show_bug.cgi?id=16518

        The problem seems gone, I can't reproduce it anymore, add Beths test to svg/as-image.

        * platform/mac/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
        * platform/mac/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.
        * svg/as-image/resources/svg-as-background-with-relative-size.svg: Added.
        * svg/as-image/svg-as-background-with-relative-size.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Wed, 1 Jun 2011 18:16:14 +0000 (18:16 +0000)]
2011-06-01  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Fix the Phonon build when logging is disabled
        https://bugs.webkit.org/show_bug.cgi?id=61869

        No new tests needed.

        * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: Add missing guards.
        (WebCore::MediaPlayerPrivatePhonon::networkState):
        (WebCore::MediaPlayerPrivatePhonon::readyState):
        (WebCore::MediaPlayerPrivatePhonon::updateStates):
        (WebCore::MediaPlayerPrivatePhonon::stateChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Wed, 1 Jun 2011 18:12:53 +0000 (18:12 +0000)]
2011-06-01  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Antti Koivisto.

        Do not use the pushed style selector if it is not equal to the
        parent document's style selector. It usually means that it is
        in a bad state, e.g. already cleared.
        https://bugs.webkit.org/show_bug.cgi?id=61737

        * dom/Element.cpp:
        (WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-31 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 1 Jun 2011 18:08:07 +0000 (18:08 +0000)]
2011-05-31  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Freezing a function and its prototype causes browser to crash.
        https://bugs.webkit.org/show_bug.cgi?id=61758

        Add test to ensure correct behaviour

        * fast/js/preventExtensions-expected.txt:
        * fast/js/script-tests/preventExtensions.js:
        (f):
2011-05-31  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Freezing a function and its prototype causes browser to crash.
        https://bugs.webkit.org/show_bug.cgi?id=61758

        Make JSObject::preventExtensions virtual so that we can override it
        and instantiate all lazy

        * JavaScriptCore.exp:
        * runtime/JSFunction.cpp:
        (JSC::createPrototypeProperty):
        (JSC::JSFunction::preventExtensions):
        (JSC::JSFunction::getOwnPropertySlot):
        * runtime/JSFunction.h:
        * runtime/JSObject.h:
        * runtime/JSObject.cpp:
        (JSC::JSObject::seal):
        (JSC::JSObject::seal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Wed, 1 Jun 2011 17:59:02 +0000 (17:59 +0000)]
2011-06-01  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch RenderLineBoxList intersection functions to use IntPoint
        https://bugs.webkit.org/show_bug.cgi?id=61794

        Switching rangeIntersectsRect, anyLineIntersectsRect, and lineIntersectsDirtyRect
        to take IntPoint instead of a tx/ty to represent the offset to be applied match
        the rect and lines' coordinates.

        No new tests since this is merely refactoring.

        * rendering/RenderLineBoxList.cpp:
        (WebCore::RenderLineBoxList::rangeIntersectsRect):
        (WebCore::RenderLineBoxList::anyLineIntersectsRect):
        (WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
        (WebCore::RenderLineBoxList::paint):
        (WebCore::RenderLineBoxList::hitTest):
        * rendering/RenderLineBoxList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
commit-queue@webkit.org [Wed, 1 Jun 2011 17:55:07 +0000 (17:55 +0000)]
2011-06-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>

        Reviewed by Andreas Kling.

        [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
        https://bugs.webkit.org/show_bug.cgi?id=61802

        Add command line parameter and menu item to MiniBrowser application
        enabling use of QGLWidget for browser viewport.

        * MiniBrowser/qt/BrowserWindow.cpp:
        (BrowserWindow::BrowserWindow):
        (BrowserWindow::toggleGLViewport):
        * MiniBrowser/qt/BrowserWindow.h:
        * MiniBrowser/qt/MiniBrowserApplication.cpp:
        (MiniBrowserApplication::handleUserOptions):
        * MiniBrowser/qt/MiniBrowserApplication.h:
        (WindowOptions::WindowOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 1 Jun 2011 17:41:25 +0000 (17:41 +0000)]
2011-06-01  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Utility methods for UA spellchecking
        https://bugs.webkit.org/show_bug.cgi?id=61788

        Adds a couple of utility methods needed to implement some aspects
        of spell checking support in a browser.

        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_replace_selection): method to replace the current
        selection with a string of text.
        (webkit_web_frame_get_range_for_word_around_caret): returns the DOM
        range for the word where the caret/selection currently is.
        * webkit/webkitwebframe.h: declare new methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Adrienne Walker <enne@google.com>
enne@google.com [Wed, 1 Jun 2011 17:36:56 +0000 (17:36 +0000)]
2011-05-19  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Don't split long, narrow layers into multiple tiles.
        https://bugs.webkit.org/show_bug.cgi?id=60821

        These tests have imperceptible pixel changes on horizontal scrollbars
        as a result of this patch.  Marking them as failing temporarily so
        that they can be rebaselined.

        * platform/chromium/test_expectations.txt:
2011-05-19  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Don't split long, narrow layers into multiple tiles.
        https://bugs.webkit.org/show_bug.cgi?id=60821

        This changes the heuristic for when we tile layers to be less bad
        about wasting texture space.  Long, narrow layers that are tiled with
        a large tile size waste texture space.  Now layers are only tiled if
        they are above 512px in one dimension and extend into a second tile in
        the other.  If they are not tiled, their layer texture will exactly
        fit their layer bounds.  In particular, this will help scrollbars.

        * platform/graphics/chromium/ContentLayerChromium.cpp:
        (WebCore::ContentLayerChromium::updateLayerSize):
        * platform/graphics/chromium/LayerRendererChromium.h:
        (WebCore::LayerRendererChromium::maxTextureSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Cary Clark <caryclark@google.com>
commit-queue@webkit.org [Wed, 1 Jun 2011 17:19:42 +0000 (17:19 +0000)]
2011-06-01  Cary Clark  <caryclark@google.com>

        Reviewed by Eric Seidel.

        Ready Chromium port for Skia on Mac
        https://bugs.webkit.org/show_bug.cgi?id=61800

        Skia on Mac is not enabled. The executing
        code is unchanged, so there are no new tests.

        * platform/chromium/DragImageRef.h:
        Use Skia for DragImageRef instead of CG.

        * platform/chromium/ScrollbarThemeChromiumMac.mm:
        (WebCore::ScrollbarThemeChromiumMac::paint):
        Get the total matrix from Skia for the scrollbar.
        Convert the SkCanvas into a CGContext to draw.

        * platform/chromium/ThemeChromiumMac.mm:
        (WebCore::paintStepper):
        Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 1 Jun 2011 17:03:55 +0000 (17:03 +0000)]
2011-06-01  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        Print out autogen arguments when they differ from the last set, to help
        with debugging build issues.

        * Scripts/webkitdirs.pm: Print out previous and current build arguments
        when they differ.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
caio.oliveira@openbossa.org [Wed, 1 Jun 2011 16:58:35 +0000 (16:58 +0000)]
2011-06-01  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt]Fix tst_QWebFrame::setUrlToInvalid() autotest after r84762
        https://bugs.webkit.org/show_bug.cgi?id=59345

        KURL and QUrl disagree whether certain URLs are valid or not. The regression here
        was caused by the fact that now KURL accepts "http:/example.com" (note only one
        slash) and our test case used a strange edge case that's transformed into a
        "one-slash" URL that now KURL can handle.

        QtWebKit approach in this case is to do a best effort and accept the QUrl if KURL
        can understand it. So I've updated the test to use a more meaningful example and
        show that an invalid URL gets converted to a valid URL if possible.

        * tests/qwebframe/tst_qwebframe.cpp:
        (tst_QWebFrame::setUrlToInvalid):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Steve Lacey <sjl@chromium.org>
sjl@chromium.org [Wed, 1 Jun 2011 16:27:21 +0000 (16:27 +0000)]
2011-06-01  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        Remove layout test http/tests/media/video-seekable-stall

        http/tests/media/video-seekable-stall.html fails on the Leopard Commit Queue Machine
        https://bugs.webkit.org/show_bug.cgi?id=35271

        * http/tests/media/video-seekable-stall-expected.txt: Removed.
        * http/tests/media/video-seekable-stall.html: Removed.
        * platform/chromium-linux/http/tests/media/video-seekable-stall-expected.png: Removed.
        * platform/chromium-win/http/tests/media/video-seekable-stall-expected.png: Removed.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac-snowleopard/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Wed, 1 Jun 2011 16:22:22 +0000 (16:22 +0000)]
2011-06-01  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, added new baselines for GTK after r87779.

        * platform/gtk/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
        * platform/gtk/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
        * platform/gtk/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
        * platform/gtk/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
        * platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
        * platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
        * platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
        * platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
        * platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
        * platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
        * platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
        * platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
        * platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
        * platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
        * platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
        * platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
        * platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
        * platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
        * platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
        * platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
        * platform/gtk/svg/hixie/intrinsic/001-expected.png: Added.
        * platform/gtk/svg/hixie/intrinsic/001-expected.txt: Added.
        * platform/gtk/svg/hixie/intrinsic/003-expected.png: Added.
        * platform/gtk/svg/hixie/intrinsic/003-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 1 Jun 2011 16:15:31 +0000 (16:15 +0000)]
2011-06-01  Adam Barth  <abarth@webkit.org>

        Add baselines for these tests.

        * platform/chromium-linux-x86/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
        * platform/chromium-linux/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
        * platform/chromium-linux/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Wed, 1 Jun 2011 16:14:33 +0000 (16:14 +0000)]
2011-06-01  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, added new baseline for GTK after r87726.

        * platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.txt: Added.
        * platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Wed, 1 Jun 2011 16:14:06 +0000 (16:14 +0000)]
2011-06-01  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, added new baselines for GTK after r87721.

        * platform/gtk/svg/custom/invalid-stroke-hex-expected.txt: Added.
        * platform/gtk/svg/custom/invalid-stroke-hex-expected.png: Added.
        * platform/gtk/svg/custom/invalid-uri-stroke-expected.txt: Added.
        * platform/gtk/svg/custom/invalid-uri-stroke-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Wed, 1 Jun 2011 16:13:16 +0000 (16:13 +0000)]
2011-06-01  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, added new baseline for GTK after r87680.

        * platform/gtk/svg/filters/feConvolveFilter-y-bounds-expected.txt: Added.
        * platform/gtk/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Wed, 1 Jun 2011 16:12:23 +0000 (16:12 +0000)]
2011-06-01  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, added new baseline for GTK after r87605.

        * platform/gtk/svg/wicd/test-scalable-background-image2-expected.txt: Added.
        * platform/gtk/svg/wicd/test-scalable-background-image2-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Wed, 1 Jun 2011 16:11:40 +0000 (16:11 +0000)]
2011-06-01  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, added new baselines for GTK after r87526.

        * platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
        * platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
        * platform/gtk/svg/custom/object-no-size-attributes-expected.png: Added.
        * platform/gtk/svg/custom/object-no-size-attributes-expected.txt: Added.
        * platform/gtk/svg/custom/object-sizing-expected.png: Added.
        * platform/gtk/svg/custom/object-sizing-expected.txt: Added.
        * platform/gtk/svg/custom/object-sizing-explicit-height-expected.png: Added.
        * platform/gtk/svg/custom/object-sizing-explicit-height-expected.txt: Added.
        * platform/gtk/svg/custom/object-sizing-explicit-width-expected.png: Added.
        * platform/gtk/svg/custom/object-sizing-explicit-width-expected.txt: Added.
        * platform/gtk/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
        * platform/gtk/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
        * platform/gtk/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
        * platform/gtk/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt: Added.
        * platform/gtk/svg/custom/object-sizing-no-width-height-expected.png: Added.
        * platform/gtk/svg/custom/object-sizing-no-width-height-expected.txt: Added.
        * platform/gtk/svg/wicd/rightsizing-grid-expected.png: Added.
        * platform/gtk/svg/wicd/rightsizing-grid-expected.txt: Added.
        * platform/gtk/svg/wicd/test-rightsizing-a-expected.png: Added.
        * platform/gtk/svg/wicd/test-rightsizing-a-expected.txt: Added.
        * platform/gtk/svg/wicd/test-rightsizing-b-expected.png: Added.
        * platform/gtk/svg/wicd/test-rightsizing-b-expected.txt: Added.
        * platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
        * platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
        * platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
        * platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
        * platform/gtk/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
        * platform/gtk/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
        * platform/gtk/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
        * platform/gtk/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
        * platform/gtk/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
        * platform/gtk/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
        * platform/gtk/svg/zoom/page/zoom-svg-through-object-with-text-expected.png: Added.
        * platform/gtk/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Wed, 1 Jun 2011 16:10:16 +0000 (16:10 +0000)]
2011-06-01  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, added new baseline for GTK after r87387.

        * platform/gtk/fast/borders/border-antialiasing-expected.txt: Added.
        * platform/gtk/fast/borders/border-antialiasing-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Wed, 1 Jun 2011 16:08:24 +0000 (16:08 +0000)]
2011-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] run-launcher should run MiniBrowser in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=61858

        * Scripts/run-launcher: Check whether -2 command line option has
        been passed and run MiniBrowser instead of GtkLauncher.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 1 Jun 2011 16:01:12 +0000 (16:01 +0000)]
2011-06-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Rob Buis.

        SVGs with a viewbox specified do not seem to work as SVGImages
        https://bugs.webkit.org/show_bug.cgi?id=16517

        SVGs with a viewBox work as background image nowadays, add a testcase covering it, originally from Beth Dakin.

        * platform/mac/svg/as-image/svg-as-background-with-viewBox-expected.png: Added.
        * platform/mac/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
        * svg/as-image/resources/green-relative-size-rect-with-viewBox.svg: Added.
        * svg/as-image/svg-as-background-with-viewBox.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRoute plugin window geometry updates through the DrawingArea
aroben@apple.com [Wed, 1 Jun 2011 15:28:13 +0000 (15:28 +0000)]
Route plugin window geometry updates through the DrawingArea

This will allow the geometry updates to be handled by the LayerTreeHost in compositing mode
in the future.

More rep work for <http://webkit.org/b/58054> <rdar://problem/9249839> REGRESSION (WebKit2):
Accelerated CSS animations have a lower framerate than in WebKit1

Reviewed by Anders Carlsson.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::scheduleWindowedPluginGeometryUpdate): Tell the DrawingArea, not the
WebPage, about the geometry update.

* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/DrawingAreaImpl.h:
* WebProcess/WebPage/win/DrawingAreaImplWin.cpp: Added.
(WebKit::DrawingAreaImpl::scheduleChildWindowGeometryUpdate):
Moved code here...

* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/win/WebPageWin.cpp:
...from here.

* win/WebKit2.vcproj: Added DrawingAreaImplWin.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMove WebView's window geometry updating code to a new class
aroben@apple.com [Wed, 1 Jun 2011 15:12:16 +0000 (15:12 +0000)]
Move WebView's window geometry updating code to a new class

This will allow us to share this code with LayerTreeHostCAWin.

Prep work for <http://webkit.org/b/58054> <rdar://problem/9249839> REGRESSION (WebKit2):
Accelerated CSS animations have a lower framerate than in WebKit1

Reviewed by Anders Carlsson.

* Shared/win/CoalescedWindowGeometriesUpdater.cpp: Added.
(WebKit::CoalescedWindowGeometriesUpdater::CoalescedWindowGeometriesUpdater):
(WebKit::CoalescedWindowGeometriesUpdater::~CoalescedWindowGeometriesUpdater):
Simple constructor/destructor.

(WebKit::CoalescedWindowGeometriesUpdater::addPendingUpdate):
(WebKit::setWindowRegion):
(WebKit::CoalescedWindowGeometriesUpdater::updateGeometries):
* Shared/win/CoalescedWindowGeometriesUpdater.h: Added.
Moved code here...

* UIProcess/win/WebView.cpp:
(WebKit::WebView::scheduleChildWindowGeometryUpdate):
(WebKit::WebView::updateChildWindowGeometries):
* UIProcess/win/WebView.h:
...from here.

* win/WebKit2.vcproj: Added new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix after r87755
aroben@apple.com [Wed, 1 Jun 2011 14:51:08 +0000 (14:51 +0000)]
Windows build fix after r87755

* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
(WebKit::LayerTreeHostCAWin::setLayerFlushSchedulingEnabled): Fixed
typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 1 Jun 2011 14:34:11 +0000 (14:34 +0000)]
2011-06-01  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: allow opening inspector for existing workers
        https://bugs.webkit.org/show_bug.cgi?id=61853

        Added sidebar pane with a list of all workers. Each worker has a check box
        that allows opening inspector for the worker.

        * inspector/Inspector.json:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::didStartWorkerContext):
        * inspector/InspectorWorkerAgent.cpp:
        (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel):
        (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel):
        (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::connectToWorkerContext):
        (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::disconnectFromWorkerContext):
        (WebCore::InspectorWorkerAgent::clearFrontend):
        (WebCore::InspectorWorkerAgent::connectToWorker):
        (WebCore::InspectorWorkerAgent::disconnectFromWorker):
        (WebCore::InspectorWorkerAgent::didStartWorkerContext):
        * inspector/InspectorWorkerAgent.h:
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        * inspector/front-end/Settings.js:
        * inspector/front-end/WorkerManager.js:
        (WebInspector.WorkerManager):
        (WebInspector.WorkerManager.prototype._workerCreated):
        (WebInspector.WorkerManager.prototype._sendMessageToWorkerInspector):
        (WebInspector.WorkerManager.prototype.openWorkerInspector):
        (WebInspector.WorkerManager.prototype.closeWorkerInspector):
        (WebInspector.WorkerManager.prototype._workerInspectorClosing):
        (WebInspector.WorkerMessageForwarder):
        (WebInspector.WorkerMessageForwarder.prototype.workerCreated):
        (WebInspector.WorkerMessageForwarder.prototype.dispatchMessageFromWorker):
        * inspector/front-end/WorkersSidebarPane.js:
        (WebInspector.WorkersSidebarPane):
        (WebInspector.WorkersSidebarPane.prototype.addWorker):
        (WebInspector.WorkerListSidebarPane):
        (WebInspector.WorkerListSidebarPane.prototype._workerAdded):
        (WebInspector.WorkerListSidebarPane.prototype._workerRemoved):
        (WebInspector.WorkerListSidebarPane.prototype._workerInspectorClosed):
        (WebInspector.WorkerListSidebarPane.prototype._addWorker):
        (WebInspector.WorkerListSidebarPane.prototype._createCheckbox):
        (WebInspector.WorkerListSidebarPane.prototype._workerItemClicked):
        * workers/Worker.cpp:
        (WebCore::Worker::notifyFinished):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Shishir Agrawal <shishir@chromium.org>
commit-queue@webkit.org [Wed, 1 Jun 2011 14:11:23 +0000 (14:11 +0000)]
2011-06-01  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by Tony Gentilcore.

        Renaming the Page Visibility attributes as per the modified spec draft.
        https://bugs.webkit.org/show_bug.cgi?id=61825

        Spec draft:
        http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PageVisibility/Overview.html

        - Event needs to be webkitVisibilityChange from webkitVisibilityStateChange
        - The attribute webkitIsVisible needs to change to webkitHidden

        * fast/events/page-visibility-iframe-delete-test.html:
        * fast/events/page-visibility-iframe-move-test-expected.txt:
        * fast/events/page-visibility-iframe-move-test.html:
        * fast/events/page-visibility-iframe-propagation-test-expected.txt:
        * fast/events/page-visibility-iframe-propagation-test.html:
        * fast/events/page-visibility-transition-test-expected.txt:
        * fast/events/page-visibility-transition-test.html:
2011-06-01  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by Tony Gentilcore.

        Renaming the Page Visibility attributes as per the modified spec draft.
        https://bugs.webkit.org/show_bug.cgi?id=61825

        Spec draft:
        http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PageVisibility/Overview.html

        - Event needs to be webkitVisibilityChange from webkitVisibilityStateChange
        - The attribute webkitIsVisible needs to change to webkitHidden

        * dom/Document.cpp:
        (WebCore::Document::webkitHidden):
        (WebCore::Document::dispatchVisibilityStateChangeEvent):
        * dom/Document.h:
        * dom/Document.idl:
        * dom/EventNames.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 1 Jun 2011 14:10:15 +0000 (14:10 +0000)]
2011-06-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Rob Buis.

        Remove duplicated code in various computeReplacedLogical*() functions
        https://bugs.webkit.org/show_bug.cgi?id=61860

        Centralize this calculation in RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth:
        int minLogicalWidth = computeReplacedLogicalWidthUsing(style()->logicalMinWidth());
        int maxLogicalWidth = !includeMaxWidth || style()->logicalMaxWidth().isUndefined() ? logicalWidth : computeReplacedLogicalWidthUsing(style()->logicalMaxWidth());
        return max(minLogicalWidth, min(logicalWidth, maxLogicalWidth));

        Centralize this calculation in RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight:
        int minLogicalHeight = computeReplacedLogicalHeightUsing(style()->logicalMinHeight());
        int maxLogicalHeight = style()->logicalMaxHeight().isUndefined() ? logicalHeight : computeReplacedLogicalHeightUsing(style()->logicalMaxHeight());
        return max(minLogicalHeight, min(logicalHeight, maxLogicalHeight));

        Use the new helper methods where possible, deduplicating lots of code.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::computeReplacedLogicalWidth):
        (WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth):
        (WebCore::RenderBox::computeReplacedLogicalHeight):
        (WebCore::RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight):
        * rendering/RenderBox.h:
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::computeReplacedLogicalWidth):
        (WebCore::RenderImage::computeReplacedLogicalHeight):
        * rendering/RenderPart.cpp:
        (WebCore::RenderPart::computeEmbeddedDocumentReplacedWidth):
        (WebCore::RenderPart::computeEmbeddedDocumentReplacedHeight):
        (WebCore::RenderPart::computeReplacedLogicalWidth):
        (WebCore::RenderPart::computeReplacedLogicalHeight):
        * rendering/RenderPart.h:
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::computeReplacedLogicalWidth):
        (WebCore::RenderReplaced::computeReplacedLogicalHeight):
        * rendering/svg/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
        (WebCore::RenderSVGRoot::computeReplacedLogicalHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Gabor Loki <loki@webkit.org>
loki@webkit.org [Wed, 1 Jun 2011 13:48:43 +0000 (13:48 +0000)]
2011-06-01  Gabor Loki  <loki@webkit.org>

        Rubber-stamped by Csaba Osztrogonác.

        Skip a flakey test on ARM.

        * platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 1 Jun 2011 13:04:43 +0000 (13:04 +0000)]
2011-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87788.
        http://trac.webkit.org/changeset/87788
        https://bugs.webkit.org/show_bug.cgi?id=61856

        breaks windows chromium canary (Requested by jknotten on
        #webkit).

        * wtf/DateMath.cpp:
        (WTF::timeClip):
        * wtf/DateMath.h:
2011-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87788.
        http://trac.webkit.org/changeset/87788
        https://bugs.webkit.org/show_bug.cgi?id=61856

        breaks windows chromium canary (Requested by jknotten on
        #webkit).

        * loader/archive/mhtml/MHTMLArchive.cpp:
        * loader/archive/mhtml/MHTMLArchive.h:
        * page/PageSerializer.cpp:
        (WebCore::PageSerializer::serializeFrame):
        (WebCore::PageSerializer::serializeCSSStyleSheet):
        * platform/SharedBuffer.cpp:
        * platform/SharedBuffer.h:
2011-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87788.
        http://trac.webkit.org/changeset/87788
        https://bugs.webkit.org/show_bug.cgi?id=61856

        breaks windows chromium canary (Requested by jknotten on
        #webkit).

        * public/WebPageSerializer.h:
        * src/WebPageSerializer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[WK2] Skip new failing test because of missing SVG animation pause API.
ossy@webkit.org [Wed, 1 Jun 2011 12:44:40 +0000 (12:44 +0000)]
[WK2] Skip new failing test because of missing SVG animation pause API.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Wed, 1 Jun 2011 12:39:46 +0000 (12:39 +0000)]
2011-06-01  Andreas Kling  <kling@webkit.org>

        Reviewed by Benjamin Poulain.

        REGRESSION: [Qt] QNetworkReply delivered by the unsupportedContent() signal does not contain downloaded data
        https://bugs.webkit.org/show_bug.cgi?id=49650

        Defer emission of QWebPage::unsupportedContent() until we're back in the event loop.
        This lets the QNAM backend finish with the reply without handing over ownership to the user code.

        No new tests since this doesn't fail for qrc:// or file:// URLs and our tests can't depend on http:// URLs.

        To correctly solve this issue, we need changes to Qt, tracked here:
        http://bugreports.qt.nokia.com/browse/QTBUG-18718

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::setFrame):
        (WebCore::FrameLoaderClientQt::download):
        * WebCoreSupport/FrameLoaderClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
caio.oliveira@openbossa.org [Wed, 1 Jun 2011 12:16:09 +0000 (12:16 +0000)]
2011-06-01  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Tor Arne Vestbø.

        [Qt] Rewrite tst_QDeclarativeWebView::multipleWindows() to not depend on Grid internals
        https://bugs.webkit.org/show_bug.cgi?id=61739

        The skipped test was imported from Qt source repository, and used private headers
        to peek in the QML Grid element. This patch changes the QML used to expose the
        information we want to test: number of pages opened and the first page opened.

        * tests/qdeclarativewebview/resources/newwindows.html:
        Added <body> tags. We have no reason to not use them in the test.

        * tests/qdeclarativewebview/resources/newwindows.qml:
        Moved the timer out of the page component, used anchors for setting webview size,
        changed the way we count pages opened. Also changed coding style a bit.

        * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
        (tst_QDeclarativeWebView::multipleWindows):
        We now look for properties with the information we want in the rootItem: pagesOpened and
        firstPageOpened.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Wed, 1 Jun 2011 12:01:20 +0000 (12:01 +0000)]
2011-06-01  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, skipping flaky test on GTK 64-bit bot.

        * platform/gtk/Skipped: Skipped test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Wed, 1 Jun 2011 11:40:56 +0000 (11:40 +0000)]
2011-06-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Kent Tamura.

        [EFL] Add null checking condition to EditorClientEfl.cpp
        https://bugs.webkit.org/show_bug.cgi?id=61846

        Add null checking condition for using settings() of frame.

        * WebCoreSupport/EditorClientEfl.cpp:
        (WebCore::EditorClientEfl::handleEditingKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Wed, 1 Jun 2011 11:17:59 +0000 (11:17 +0000)]
2011-06-01  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [JSC] JSLock ASSERTs Seen Under eventListenerHandlerBody
        https://bugs.webkit.org/show_bug.cgi?id=61835

        Add a JSLock call before possible allocations in jsFunction and toString.

        * bindings/js/ScriptEventListener.cpp:
        (WebCore::eventListenerHandlerBody):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Unreviewed trivial fix after r87778.
ossy@webkit.org [Wed, 1 Jun 2011 11:03:05 +0000 (11:03 +0000)]
[Qt] Unreviewed trivial fix after r87778.

* platform/qt/Skipped: Rename editing/pasteboard/4861080.html to editing/pasteboard/drag-drop-list.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Gabor Loki <loki@webkit.org>
loki@webkit.org [Wed, 1 Jun 2011 09:53:58 +0000 (09:53 +0000)]
2011-06-01 Gabor Loki <loki@webkit.org>

        Rubber-stamped by Csaba Osztrogonác.

        [Qt] Skip flakey tests on ARM

        * platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Wed, 1 Jun 2011 09:40:21 +0000 (09:40 +0000)]
2011-06-01  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Add in baselines for new SVG tests following https://bugs.webkit.org/show_bug.cgi?id=15473
        https://bugs.webkit.org/show_bug.cgi?id=61849

        * platform/chromium-linux-x86/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
        * platform/chromium-linux-x86/svg/hixie/intrinsic/001-expected.png: Added.
        * platform/chromium-linux-x86/svg/hixie/intrinsic/001-expected.txt: Added.
        * platform/chromium-linux-x86/svg/hixie/intrinsic/002-expected.png: Added.
        * platform/chromium-linux-x86/svg/hixie/intrinsic/002-expected.txt: Added.
        * platform/chromium-linux-x86/svg/hixie/intrinsic/003-expected.png: Added.
        * platform/chromium-linux-x86/svg/hixie/intrinsic/003-expected.txt: Added.
        * platform/chromium-linux/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
        * platform/chromium-linux/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
        * platform/chromium-linux/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
        * platform/chromium-linux/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
        * platform/chromium-linux/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
        * platform/chromium-linux/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
        * platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
        * platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
        * platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
        * platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
        * platform/chromium-linux/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
        * platform/chromium-linux/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
        * platform/chromium-linux/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
        * platform/chromium-linux/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
        * platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
        * platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
        * platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
        * platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
        * platform/chromium-linux/svg/hixie/intrinsic/001-expected.png: Added.
        * platform/chromium-linux/svg/hixie/intrinsic/001-expected.txt: Added.
        * platform/chromium-linux/svg/hixie/intrinsic/002-expected.png: Added.
        * platform/chromium-linux/svg/hixie/intrinsic/002-expected.txt: Added.
        * platform/chromium-linux/svg/hixie/intrinsic/003-expected.png: Added.
        * platform/chromium-linux/svg/hixie/intrinsic/003-expected.txt: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
        * platform/chromium-win-vista/svg/hixie/intrinsic/001-expected.png: Added.
        * platform/chromium-win-vista/svg/hixie/intrinsic/001-expected.txt: Added.
        * platform/chromium-win-vista/svg/hixie/intrinsic/002-expected.png: Added.
        * platform/chromium-win-vista/svg/hixie/intrinsic/002-expected.txt: Added.
        * platform/chromium-win-vista/svg/hixie/intrinsic/003-expected.png: Added.
        * platform/chromium-win-vista/svg/hixie/intrinsic/003-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Wed, 1 Jun 2011 09:23:51 +0000 (09:23 +0000)]
2011-06-01  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed. Test rebaselines for GTK after revision 87526.

        * platform/gtk/svg/hixie/text/003-expected.png:
        * platform/gtk/svg/hixie/text/003-expected.txt:
        * platform/gtk/svg/in-html/by-reference-expected.txt:
        * platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Jay Civelli <jcivelli@chromium.org>
jcivelli@chromium.org [Wed, 1 Jun 2011 09:17:53 +0000 (09:17 +0000)]
2011-06-01  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Adam Barth.

        Added a method to generate RFC 2822 compliant date strings.
        https://bugs.webkit.org/show_bug.cgi?id=7169

        * wtf/DateMath.cpp:
        (WTF::twoDigitStringFromNumber):
        (WTF::makeRFC2822DateString):
        * wtf/DateMath.h:
2011-06-01  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Adam Barth.

        Adding MHTML generation support to MHTMLArchive.
        https://bugs.webkit.org/show_bug.cgi?id=7169

        * loader/archive/mhtml/MHTMLArchive.cpp:
        (WebCore::generateRandomBoundary):
        (WebCore::replaceNonPrintableCharacters):
        (WebCore::MHTMLArchive::generateMHTMLData):
        * loader/archive/mhtml/MHTMLArchive.h:
        * page/PageSerializer.cpp:
        (WebCore::PageSerializer::serializeFrame):
        (WebCore::PageSerializer::serializeCSSStyleSheet):
        * platform/SharedBuffer.cpp:
        (WebCore::SharedBuffer::append):
        * platform/SharedBuffer.h:
2011-06-01  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Adam Barth.

        Adding MHTML generation support to MHTMLArchive.
        https://bugs.webkit.org/show_bug.cgi?id=7169

        * public/WebPageSerializer.h:
        * src/WebPageSerializer.cpp:
        (WebKit::WebPageSerializer::serializeToMHTML):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 1 Jun 2011 09:10:08 +0000 (09:10 +0000)]
2011-06-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Andreas Kling.

        REGRESSION: fast/images/svg-background-crash-on-refresh.html hangs
        https://bugs.webkit.org/show_bug.cgi?id=15483

        The regression seems gone, I can't reproduce it anymore, reenable svg-background-crash-on-refresh.html.
        Convert the test to use dumpAsText() and actually execute the refreshing twice, including forced gc
        to see whether we crash on referesh or not, before it didn't actually reload. If a crash happened,
        it happened somewhen after executing this test, which is probably why it was flakey.

        * platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.png: Removed.
        * platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.txt: Removed.
        * svg/as-image/svg-background-crash-on-refresh-expected.txt: Copied from platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.txt.
        * svg/as-image/svg-background-crash-on-refresh.html: Copied from svg/as-image/svg-background-crash-on-refresh.html-disabled.
        * svg/as-image/svg-background-crash-on-refresh.html-disabled: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-31 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Wed, 1 Jun 2011 08:47:03 +0000 (08:47 +0000)]
2011-05-31  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector [Chromium]: Put worker scripts into devtools_frontend.zip.
        https://bugs.webkit.org/show_bug.cgi?id=61803

        * WebKit.gyp:
        * scripts/generate_devtools_zip.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Wed, 1 Jun 2011 08:29:22 +0000 (08:29 +0000)]
2011-06-01  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed. Test rebaselines for GTK after revision 87721.

        * platform/gtk/svg/custom/invalid-fill-expected.png:
        * platform/gtk/svg/custom/invalid-fill-expected.txt:
        * platform/gtk/svg/custom/invalid-fill-hex-expected.png:
        * platform/gtk/svg/custom/invalid-fill-hex-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 1 Jun 2011 08:07:14 +0000 (08:07 +0000)]
2011-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87781.
        http://trac.webkit.org/changeset/87781
        https://bugs.webkit.org/show_bug.cgi?id=61842

        breaks chromium linux release (Requested by mnaganov on
        #webkit).

        * WebKit.gyp:
        * scripts/generate_devtools_zip.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Oleg Romashin <romaxa@gmail.com>
commit-queue@webkit.org [Wed, 1 Jun 2011 08:04:58 +0000 (08:04 +0000)]
2011-06-01  Oleg Romashin  <romaxa@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        platformGeometryDidChange function definition was changed everywhere except Qt.
        This is fix for Qt WK2 plugins compilation
        https://bugs.webkit.org/show_bug.cgi?id=61832

        * PluginProcess/qt/PluginControllerProxyQt.cpp:
        (WebKit::PluginControllerProxy::platformGeometryDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 1 Jun 2011 08:02:19 +0000 (08:02 +0000)]
2011-06-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Adam Barth.

        Move fast/images/*svg* to svg/as-image/
        https://bugs.webkit.org/show_bug.cgi?id=61840

        The SVG crowd regulary runs pixel tests, and we'd like to also include the SVG-as-image tests in our daily runs.
        Also it makes more sense to have these tests in a single place, just like eg. svg/in-html (html5+svg).

        * fast/images/animated-svg-as-image.html: Removed.
        * fast/images/drag-svg-as-image-expected.txt: Removed.
        * fast/images/drag-svg-as-image.html: Removed.
        * fast/images/resources/animated-rect-fixed-size.svg: Removed.
        * fast/images/resources/animated-rect-relative-size.svg: Removed.
        * fast/images/resources/butterfly.svg: Removed.
        * fast/images/resources/circle.svg: Removed.
        * fast/images/resources/green-fixed-size-rect.svg: Removed.
        * fast/images/resources/green-relative-size-rect.svg: Removed.
        * fast/images/resources/load-script.html: Removed.
        * fast/images/resources/width-100-percent.svg: Removed.
        * fast/images/svg-as-background.html: Removed.
        * fast/images/svg-as-image.html: Removed.
        * fast/images/svg-as-relative-image.html: Removed.
        * fast/images/svg-as-tiled-background.html: Removed.
        * fast/images/svg-background-crash-on-refresh.html-disabled: Removed.
        * fast/images/svg-background-partial-redraw.html: Removed.
        * fast/images/svg-image-leak-loader-expected.txt: Removed.
        * fast/images/svg-image-leak-loader.html: Removed.
        * fast/images/svg-nested-expected.txt: Removed.
        * fast/images/svg-nested.html: Removed.
        * fast/images/svg-width-100p-as-background.html: Removed.
        * platform/chromium-linux/fast/images/animated-svg-as-image-expected.png: Removed.
        * platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.png: Removed.
        * platform/chromium-linux/svg/as-image: Added.
        * platform/chromium-linux/svg/as-image/animated-svg-as-image-expected.png: Copied from platform/chromium-linux/fast/images/animated-svg-as-image-expected.png.
        * platform/chromium-linux/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.png.
        * platform/chromium-mac-leopard/fast/images/svg-background-partial-redraw-expected.png: Removed.
        * platform/chromium-mac-leopard/svg/as-image: Added.
        * platform/chromium-mac-leopard/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-mac-leopard/fast/images/svg-background-partial-redraw-expected.png.
        * platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.png: Removed.
        * platform/chromium-mac/svg/as-image: Added.
        * platform/chromium-mac/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.png.
        * platform/chromium-win/fast/images/animated-svg-as-image-expected.png: Removed.
        * platform/chromium-win/fast/images/animated-svg-as-image-expected.txt: Removed.
        * platform/chromium-win/fast/images/svg-as-background-expected.txt: Removed.
        * platform/chromium-win/fast/images/svg-as-tiled-background-expected.txt: Removed.
        * platform/chromium-win/fast/images/svg-background-partial-redraw-expected.png: Removed.
        * platform/chromium-win/fast/images/svg-background-partial-redraw-expected.txt: Removed.
        * platform/chromium-win/fast/images/svg-width-100p-as-background-expected.txt: Removed.
        * platform/chromium-win/svg/as-image: Added.
        * platform/chromium-win/svg/as-image/animated-svg-as-image-expected.png: Copied from platform/chromium-win/fast/images/animated-svg-as-image-expected.png.
        * platform/chromium-win/svg/as-image/animated-svg-as-image-expected.txt: Copied from platform/chromium-win/fast/images/animated-svg-as-image-expected.txt.
        * platform/chromium-win/svg/as-image/svg-as-background-expected.txt: Copied from platform/chromium-win/fast/images/svg-as-background-expected.txt.
        * platform/chromium-win/svg/as-image/svg-as-tiled-background-expected.txt: Copied from platform/chromium-win/fast/images/svg-as-tiled-background-expected.txt.
        * platform/chromium-win/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-win/fast/images/svg-background-partial-redraw-expected.png.
        * platform/chromium-win/svg/as-image/svg-background-partial-redraw-expected.txt: Copied from platform/chromium-win/fast/images/svg-background-partial-redraw-expected.txt.
        * platform/chromium-win/svg/as-image/svg-width-100p-as-background-expected.txt: Copied from platform/chromium-win/fast/images/svg-width-100p-as-background-expected.txt.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/fast/images/animated-svg-as-image-expected.png: Removed.
        * platform/gtk/fast/images/animated-svg-as-image-expected.txt: Removed.
        * platform/gtk/fast/images/svg-as-background-expected.png: Removed.
        * platform/gtk/fast/images/svg-as-background-expected.txt: Removed.
        * platform/gtk/fast/images/svg-as-image-expected.png: Removed.
        * platform/gtk/fast/images/svg-as-image-expected.txt: Removed.
        * platform/gtk/fast/images/svg-as-relative-image-expected.png: Removed.
        * platform/gtk/fast/images/svg-as-relative-image-expected.txt: Removed.
        * platform/gtk/fast/images/svg-as-tiled-background-expected.png: Removed.
        * platform/gtk/fast/images/svg-as-tiled-background-expected.txt: Removed.
        * platform/gtk/fast/images/svg-background-partial-redraw-expected.txt: Removed.
        * platform/gtk/fast/images/svg-width-100p-as-background-expected.png: Removed.
        * platform/gtk/fast/images/svg-width-100p-as-background-expected.txt: Removed.
        * platform/gtk/svg/as-image: Added.
        * platform/gtk/svg/as-image/animated-svg-as-image-expected.png: Copied from platform/gtk/fast/images/animated-svg-as-image-expected.png.
        * platform/gtk/svg/as-image/animated-svg-as-image-expected.txt: Copied from platform/gtk/fast/images/animated-svg-as-image-expected.txt.
        * platform/gtk/svg/as-image/svg-as-background-expected.png: Copied from platform/gtk/fast/images/svg-as-background-expected.png.
        * platform/gtk/svg/as-image/svg-as-background-expected.txt: Copied from platform/gtk/fast/images/svg-as-background-expected.txt.
        * platform/gtk/svg/as-image/svg-as-image-expected.png: Copied from platform/gtk/fast/images/svg-as-image-expected.png.
        * platform/gtk/svg/as-image/svg-as-image-expected.txt: Copied from platform/gtk/fast/images/svg-as-image-expected.txt.
        * platform/gtk/svg/as-image/svg-as-relative-image-expected.png: Copied from platform/gtk/fast/images/svg-as-relative-image-expected.png.
        * platform/gtk/svg/as-image/svg-as-relative-image-expected.txt: Copied from platform/gtk/fast/images/svg-as-relative-image-expected.txt.
        * platform/gtk/svg/as-image/svg-as-tiled-background-expected.png: Copied from platform/gtk/fast/images/svg-as-tiled-background-expected.png.
        * platform/gtk/svg/as-image/svg-as-tiled-background-expected.txt: Copied from platform/gtk/fast/images/svg-as-tiled-background-expected.txt.
        * platform/gtk/svg/as-image/svg-background-partial-redraw-expected.txt: Copied from platform/gtk/fast/images/svg-background-partial-redraw-expected.txt.
        * platform/gtk/svg/as-image/svg-width-100p-as-background-expected.png: Copied from platform/gtk/fast/images/svg-width-100p-as-background-expected.png.
        * platform/gtk/svg/as-image/svg-width-100p-as-background-expected.txt: Copied from platform/gtk/fast/images/svg-width-100p-as-background-expected.txt.
        * platform/mac-leopard/fast/images/animated-svg-as-image-expected.png: Removed.
        * platform/mac-leopard/fast/images/svg-background-partial-redraw-expected.png: Removed.
        * platform/mac-leopard/svg/as-image: Added.
        * platform/mac-leopard/svg/as-image/animated-svg-as-image-expected.png: Copied from platform/mac-leopard/fast/images/animated-svg-as-image-expected.png.
        * platform/mac-leopard/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/mac-leopard/fast/images/svg-background-partial-redraw-expected.png.
        * platform/mac/fast/images/animated-svg-as-image-expected.png: Removed.
        * platform/mac/fast/images/animated-svg-as-image-expected.txt: Removed.
        * platform/mac/fast/images/svg-as-background-expected.png: Removed.
        * platform/mac/fast/images/svg-as-background-expected.txt: Removed.
        * platform/mac/fast/images/svg-as-image-expected.png: Removed.
        * platform/mac/fast/images/svg-as-image-expected.txt: Removed.
        * platform/mac/fast/images/svg-as-relative-image-expected.png: Removed.
        * platform/mac/fast/images/svg-as-relative-image-expected.txt: Removed.
        * platform/mac/fast/images/svg-as-tiled-background-expected.png: Removed.
        * platform/mac/fast/images/svg-as-tiled-background-expected.txt: Removed.
        * platform/mac/fast/images/svg-background-crash-on-refresh-expected.png: Removed.
        * platform/mac/fast/images/svg-background-crash-on-refresh-expected.txt: Removed.
        * platform/mac/fast/images/svg-background-partial-redraw-expected.png: Removed.
        * platform/mac/fast/images/svg-background-partial-redraw-expected.txt: Removed.
        * platform/mac/fast/images/svg-width-100p-as-background-expected.png: Removed.
        * platform/mac/fast/images/svg-width-100p-as-background-expected.txt: Removed.
        * platform/mac/svg/as-image: Added.
        * platform/mac/svg/as-image/animated-svg-as-image-expected.png: Copied from platform/mac/fast/images/animated-svg-as-image-expected.png.
        * platform/mac/svg/as-image/animated-svg-as-image-expected.txt: Copied from platform/mac/fast/images/animated-svg-as-image-expected.txt.
        * platform/mac/svg/as-image/svg-as-background-expected.png: Copied from platform/mac/fast/images/svg-as-background-expected.png.
        * platform/mac/svg/as-image/svg-as-background-expected.txt: Copied from platform/mac/fast/images/svg-as-background-expected.txt.
        * platform/mac/svg/as-image/svg-as-image-expected.png: Copied from platform/mac/fast/images/svg-as-image-expected.png.
        * platform/mac/svg/as-image/svg-as-image-expected.txt: Copied from platform/mac/fast/images/svg-as-image-expected.txt.
        * platform/mac/svg/as-image/svg-as-relative-image-expected.png: Copied from platform/mac/fast/images/svg-as-relative-image-expected.png.
        * platform/mac/svg/as-image/svg-as-relative-image-expected.txt: Copied from platform/mac/fast/images/svg-as-relative-image-expected.txt.
        * platform/mac/svg/as-image/svg-as-tiled-background-expected.png: Copied from platform/mac/fast/images/svg-as-tiled-background-expected.png.
        * platform/mac/svg/as-image/svg-as-tiled-background-expected.txt: Copied from platform/mac/fast/images/svg-as-tiled-background-expected.txt.
        * platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.png: Copied from platform/mac/fast/images/svg-background-crash-on-refresh-expected.png.
        * platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.txt: Copied from platform/mac/fast/images/svg-background-crash-on-refresh-expected.txt.
        * platform/mac/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/mac/fast/images/svg-background-partial-redraw-expected.png.
        * platform/mac/svg/as-image/svg-background-partial-redraw-expected.txt: Copied from platform/mac/fast/images/svg-background-partial-redraw-expected.txt.
        * platform/mac/svg/as-image/svg-width-100p-as-background-expected.png: Copied from platform/mac/fast/images/svg-width-100p-as-background-expected.png.
        * platform/mac/svg/as-image/svg-width-100p-as-background-expected.txt: Copied from platform/mac/fast/images/svg-width-100p-as-background-expected.txt.
        * platform/qt-mac/Skipped:
        * platform/qt-wk2/Skipped:
        * platform/qt/Skipped:
        * platform/qt/fast/images/animated-svg-as-image-expected.txt: Removed.
        * platform/qt/fast/images/svg-as-background-expected.txt: Removed.
        * platform/qt/fast/images/svg-as-image-expected.txt: Removed.
        * platform/qt/fast/images/svg-as-relative-image-expected.txt: Removed.
        * platform/qt/fast/images/svg-as-tiled-background-expected.txt: Removed.
        * platform/qt/fast/images/svg-background-partial-redraw-expected.png: Removed.
        * platform/qt/fast/images/svg-background-partial-redraw-expected.txt: Removed.
        * platform/qt/fast/images/svg-width-100p-as-background-expected.txt: Removed.
        * platform/qt/svg/as-image: Added.
        * platform/qt/svg/as-image/animated-svg-as-image-expected.txt: Copied from platform/qt/fast/images/animated-svg-as-image-expected.txt.
        * platform/qt/svg/as-image/svg-as-background-expected.txt: Copied from platform/qt/fast/images/svg-as-background-expected.txt.
        * platform/qt/svg/as-image/svg-as-image-expected.txt: Copied from platform/qt/fast/images/svg-as-image-expected.txt.
        * platform/qt/svg/as-image/svg-as-relative-image-expected.txt: Copied from platform/qt/fast/images/svg-as-relative-image-expected.txt.
        * platform/qt/svg/as-image/svg-as-tiled-background-expected.txt: Copied from platform/qt/fast/images/svg-as-tiled-background-expected.txt.
        * platform/qt/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/qt/fast/images/svg-background-partial-redraw-expected.png.
        * platform/qt/svg/as-image/svg-background-partial-redraw-expected.txt: Copied from platform/qt/fast/images/svg-background-partial-redraw-expected.txt.
        * platform/qt/svg/as-image/svg-width-100p-as-background-expected.txt: Copied from platform/qt/fast/images/svg-width-100p-as-background-expected.txt.
        * svg/as-image: Added.
        * svg/as-image/animated-svg-as-image.html: Copied from fast/images/animated-svg-as-image.html.
        * svg/as-image/drag-svg-as-image-expected.txt: Copied from fast/images/drag-svg-as-image-expected.txt.
        * svg/as-image/drag-svg-as-image.html: Copied from fast/images/drag-svg-as-image.html.
        * svg/as-image/resources: Added.
        * svg/as-image/resources/animated-rect-fixed-size.svg: Copied from fast/images/resources/animated-rect-fixed-size.svg.
        * svg/as-image/resources/animated-rect-relative-size.svg: Copied from fast/images/resources/animated-rect-relative-size.svg.
        * svg/as-image/resources/butterfly.svg: Copied from fast/images/resources/butterfly.svg.
        * svg/as-image/resources/circle.svg: Copied from fast/images/resources/circle.svg.
        * svg/as-image/resources/green-fixed-size-rect.svg: Copied from fast/images/resources/green-fixed-size-rect.svg.
        * svg/as-image/resources/green-relative-size-rect.svg: Copied from fast/images/resources/green-relative-size-rect.svg.
        * svg/as-image/resources/load-script.html: Copied from fast/images/resources/load-script.html.
        * svg/as-image/resources/width-100-percent.svg: Copied from fast/images/resources/width-100-percent.svg.
        * svg/as-image/svg-as-background.html: Copied from fast/images/svg-as-background.html.
        * svg/as-image/svg-as-image.html: Copied from fast/images/svg-as-image.html.
        * svg/as-image/svg-as-relative-image.html: Copied from fast/images/svg-as-relative-image.html.
        * svg/as-image/svg-as-tiled-background.html: Copied from fast/images/svg-as-tiled-background.html.
        * svg/as-image/svg-background-crash-on-refresh.html-disabled: Copied from fast/images/svg-background-crash-on-refresh.html-disabled.
        * svg/as-image/svg-background-partial-redraw.html: Copied from fast/images/svg-background-partial-redraw.html.
        * svg/as-image/svg-image-leak-loader-expected.txt: Copied from fast/images/svg-image-leak-loader-expected.txt.
        * svg/as-image/svg-image-leak-loader.html: Copied from fast/images/svg-image-leak-loader.html.
        * svg/as-image/svg-nested-expected.txt: Copied from fast/images/svg-nested-expected.txt.
        * svg/as-image/svg-nested.html: Copied from fast/images/svg-nested.html.
        * svg/as-image/svg-width-100p-as-background.html: Copied from fast/images/svg-width-100p-as-background.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-31 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Wed, 1 Jun 2011 07:46:13 +0000 (07:46 +0000)]
2011-05-31  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector [Chromium]: Put worker scripts into devtools_frontend.zip.
        https://bugs.webkit.org/show_bug.cgi?id=61803

        * WebKit.gyp:
        * scripts/generate_devtools_zip.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87781 268f45cc-cd09-0410-ab3c-d52691b4dbfc