WebKit-https.git
10 years agoTowards making PopupMenuClient more testable
fsamuel@chromium.org [Wed, 12 Oct 2011 00:19:29 +0000 (00:19 +0000)]
Towards making PopupMenuClient more testable
https://bugs.webkit.org/show_bug.cgi?id=69631

Reviewed by Simon Fraser.

Source/WebCore:

Added some functions to window.internals to allow testing of parts of PopupMenuClient.

Test: fast/dom/popup-menu-client-test.html

* platform/PopupMenuClient.h:
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::showPopup):
(WebCore::RenderMenuList::boundingBoxRect):
* rendering/RenderMenuList.h:
(WebCore::RenderMenuList::RenderMenuList::isPopupMenuClient):
* rendering/RenderObject.h:
(WebCore::RenderObject::isPopupMenuClient):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::showPopup):
(WebCore::RenderTextControlSingleLine::boundingBoxRect):
* rendering/RenderTextControlSingleLine.h:
(WebCore::RenderTextControlSingleLine::isPopupMenuClient):
* testing/Internals.cpp:
(WebCore::Internals::toPopupMenuClient):
(WebCore::Internals::popupClientPaddingLeft):
(WebCore::Internals::popupClientPaddingRight):
(WebCore::Internals::popupClientBoundingBoxRect):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit/chromium:

* src/AutofillPopupMenuClient.cpp:
(WebKit::AutofillPopupMenuClient::boundingBoxRect):
* src/AutofillPopupMenuClient.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::applyAutofillSuggestions):

LayoutTests:

* fast/dom/popup-menu-client-test-expected.txt: Added.
* fast/dom/popup-menu-client-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago [Mac] Crash when opening an embedded PDF in a background tab
ap@apple.com [Wed, 12 Oct 2011 00:17:37 +0000 (00:17 +0000)]
    [Mac] Crash when opening an embedded PDF in a background tab
        https://bugs.webkit.org/show_bug.cgi?id=69880

        Reviewed by Darin Adler.

        * WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
        (WebKit::BuiltInPDFView::BuiltInPDFView):
        (WebKit::BuiltInPDFView::~BuiltInPDFView):
        (WebKit::BuiltInPDFView::initialize):
        (WebKit::BuiltInPDFView::destroy):
        Moved initialization and destruction code from C++ constructor and destructor to designated
        functions. Not part of the fix, but seems related enough to fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago [Mac] Crash when opening an embedded PDF in a background tab
ap@apple.com [Wed, 12 Oct 2011 00:16:22 +0000 (00:16 +0000)]
    [Mac] Crash when opening an embedded PDF in a background tab
        https://bugs.webkit.org/show_bug.cgi?id=69880

        Reviewed by Darin Adler.

        * WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::paint): Don't call plug-in that
        doesn't even have a controller yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake CachedResourceClientWalker templates, and
japhet@chromium.org [Wed, 12 Oct 2011 00:12:29 +0000 (00:12 +0000)]
Make CachedResourceClientWalker templates, and
have it check and filter out bad casts when iterating
(currently we rely on CachedResourceClients being careful
to inherit from the right subclass for the type of resource
they want to load).
https://bugs.webkit.org/show_bug.cgi?id=69877

Reviewed by Adam Barth.

No new tests, no functionality change.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* loader/cache/CachedCSSStyleSheet.cpp:
* loader/cache/CachedFont.cpp:
* loader/cache/CachedFont.h:
* loader/cache/CachedImage.cpp:
* loader/cache/CachedImage.h:
* loader/cache/CachedResource.cpp:
* loader/cache/CachedResourceClient.h:
* loader/cache/CachedResourceClientWalker.cpp: Removed.
* loader/cache/CachedResourceClientWalker.h:
* loader/cache/CachedStyleSheetClient.h:
* loader/cache/CachedXSLStyleSheet.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agosheriffbot takes too long to acknowledge rollout commands
abarth@webkit.org [Tue, 11 Oct 2011 23:50:33 +0000 (23:50 +0000)]
sheriffbot takes too long to acknowledge rollout commands
https://bugs.webkit.org/show_bug.cgi?id=69871

Reviewed by Eric Seidel.

We used to update the working copy before acknowledging the command
because we wanted to ping all the relevant IRC nicks.  That's caused a
bunch of frustration because folks don't know whether the bot has heard
their commands.

This patch makes the bot reply immediately before updating the working
copy.  All the relevenat folks are still pinged when the bot finishes
preparing the rollout.

* Scripts/webkitpy/tool/bot/irc_command.py:
* Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG virtual register allocator should be more aggressive in
fpizlo@apple.com [Tue, 11 Oct 2011 23:50:26 +0000 (23:50 +0000)]
DFG virtual register allocator should be more aggressive in
reusing temporary slots
https://bugs.webkit.org/show_bug.cgi?id=69868

Reviewed by Oliver Hunt.

1.2% win on V8, neutral elsewhere. The win is probably because it
increases precision of GC conservative scans.

This required making the DFG::ScoreBoard operate over a bitvector
of preserved variables, rather than just a preserved variable
threshold. To do this, I improved the WTF::BitVector class to make
it more user-friendly. It still retains all previous functionality.
Also made changes to PackedIntVector to accomodate those changes.
Finally, this adds more debugging to the virtual register allocator
and to the OSR exit code, as this was necessary to track down bugs
in an earlier version of this patch.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::getLocal):
* dfg/DFGGraph.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::allocateVirtualRegisters):
* dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::ScoreBoard):
(JSC::DFG::ScoreBoard::~ScoreBoard):
(JSC::DFG::ScoreBoard::allocate):
(JSC::DFG::ScoreBoard::use):
(JSC::DFG::ScoreBoard::highWatermark):
(JSC::DFG::ScoreBoard::dump):
(JSC::DFG::ScoreBoard::max):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueRecovery::dump):
* wtf/BitVector.cpp:
(WTF::BitVector::setSlow):
(WTF::BitVector::resizeOutOfLine):
(WTF::BitVector::dump):
* wtf/BitVector.h:
(WTF::BitVector::BitVector):
(WTF::BitVector::operator=):
(WTF::BitVector::quickGet):
(WTF::BitVector::quickSet):
(WTF::BitVector::quickClear):
(WTF::BitVector::get):
(WTF::BitVector::set):
(WTF::BitVector::clear):
* wtf/PackedIntVector.h:
(WTF::PackedIntVector::get):
(WTF::PackedIntVector::set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agotest-webkitpy fails on Lion
abarth@webkit.org [Tue, 11 Oct 2011 23:48:51 +0000 (23:48 +0000)]
test-webkitpy fails on Lion
https://bugs.webkit.org/show_bug.cgi?id=69873

Reviewed by Eric Seidel.

This patch fixes one of the two failures.  I'll need to track down the
other failure another time.

* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Fix compilation guards in ScrollAnimatorNone (GESTURE_EVENTS).
wjmaclean@chromium.org [Tue, 11 Oct 2011 23:43:40 +0000 (23:43 +0000)]
[chromium] Fix compilation guards in ScrollAnimatorNone (GESTURE_EVENTS).
https://bugs.webkit.org/show_bug.cgi?id=69853

Reviewed by Kenneth Russell.

Adding missing guards ENABLE(GESTURE_EVENTS) in ScrollAnimatorNone. So
far this hasn't been a problem since GESTURE_EVENTS are usually turned on
whenever SMOOTH_SCROLLING is, but it could be a problem if this changes.

No new tests (compilation without errors is the test).

* platform/ScrollAnimatorNone.cpp:
* platform/ScrollAnimatorNone.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Check for lost context at beginning of compositor's execution
kbr@google.com [Tue, 11 Oct 2011 23:34:37 +0000 (23:34 +0000)]
[chromium] Check for lost context at beginning of compositor's execution
https://bugs.webkit.org/show_bug.cgi?id=69776

Reviewed by James Robinson.

Source/WebCore:

Test: platform/chromium/compositing/webgl-loses-compositor-context.html

* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):

LayoutTests:

Added test case which asserts when run in Chrome with dynamic GPU
switching enabled and without the fix in this patch.

* platform/chromium/compositing/webgl-loses-compositor-context-expected.png: Added.
* platform/chromium/compositing/webgl-loses-compositor-context-expected.txt: Added.
* platform/chromium/compositing/webgl-loses-compositor-context.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebAccessibilityObject needs titleUIElement
dmazzoni@google.com [Tue, 11 Oct 2011 23:23:54 +0000 (23:23 +0000)]
WebAccessibilityObject needs titleUIElement
https://bugs.webkit.org/show_bug.cgi?id=69869

Reviewed by Dimitri Glazkov.

* public/WebAccessibilityObject.h:
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::titleUIElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogarden-o-matic should warn me when run-webkit-tests errors out (e.g., due to python...
abarth@webkit.org [Tue, 11 Oct 2011 23:15:46 +0000 (23:15 +0000)]
garden-o-matic should warn me when run-webkit-tests errors out (e.g., due to python screw-ups)
https://bugs.webkit.org/show_bug.cgi?id=65230

Reviewed by Dimitri Glazkov.

This patch causes us to treat crashed or hung run-webkit-tests runs
similarly to how we treat compile failures.  In some sense, they're
similar because they prevent us from getting test coverage.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=69874
bdakin@apple.com [Tue, 11 Oct 2011 23:05:33 +0000 (23:05 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=69874
WebKit2 snapshot APIs should take the device scale factor into account
-and corresponding-
<rdar://problem/10269112>

Reviewed by Darin Adler.

Add the deviceScaleFactor as a scale on the snapshot's context to create a
snapshot of the appropriate resolution. This matches the manner in which we scale
the context in DrawingAreaImpl::display().
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::snapshotInViewCoordinates):
(WebKit::WebPage::scaledSnapshotInDocumentCoordinates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFailing builder display in garden-o-matic should have the same visual style as the...
abarth@webkit.org [Tue, 11 Oct 2011 23:04:15 +0000 (23:04 +0000)]
Failing builder display in garden-o-matic should have the same visual style as the failure grid
https://bugs.webkit.org/show_bug.cgi?id=69876

Reviewed by Dimitri Glazkov.

This patch generalizes the view we use for failing builders in the
FailureGrid so that we can use it for the list of builders that aren't
compiling.

One downside of this patch is that it makes it harder to tell when
debug builders are failing (as opposed to release builders) because
that information isn't presented in this view.  A future patch will
improve this aspect.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG JIT 32_64 - Switch to cdecl calling convention.
barraclough@apple.com [Tue, 11 Oct 2011 22:51:46 +0000 (22:51 +0000)]
DFG JIT 32_64 - Switch to cdecl calling convention.
https://bugs.webkit.org/show_bug.cgi?id=69863

Reviewed by Oliver Hunt.

This makes it easier to keep the stack correctly aligned, which is required on OS X.

* assembler/MacroAssemblerCodeRef.h:
(JSC::FunctionPtr::FunctionPtr):
    - Provide default FunctionPtr constructors for CDECL functions on STDCALL platforms.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
    - Switch calls to poke arguments rather than pushing them.
(JSC::DFG::resetCallArguments):
(JSC::DFG::addCallArgument):
(JSC::DFG::addCallArgumentBoxed):
    - Helper functions to stack up call arguments on X86.
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
    - Don't push, poke!
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::compileBody):
    - Don't push, poke!
* dfg/DFGOperations.cpp:
    - Switch ReturnAddress wrappers to push return address last, update asm trampolines.
* dfg/DFGOperations.h:
    - switch DFG_OPERATION to assert CDECL on STDCALL platforms.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::fmodWithCDecl):
(JSC::DFG::SpeculativeJIT::compile):
    - On STDCALL platforms wrap fmod, since DFG_OPERATION wrappers are CDECL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLoss of precision when converting from double to int and double to float in FrameView...
wjmaclean@chromium.org [Tue, 11 Oct 2011 22:43:53 +0000 (22:43 +0000)]
Loss of precision when converting from double to int and double to float in FrameView::zoomAnimatorTransformChanged()
https://bugs.webkit.org/show_bug.cgi?id=69739

Source/WebCore:

Reviewed by Simon Fraser.

Change 'double' parameters in FrameView:: & ScrollableArea::zoomAnimatorTransformChanged()
to 'float' to avoid loss of precision warnings when invoking setPageScalefactor.

Test coverage provided by existing zoom-animator tests.

* page/FrameView.cpp:
(WebCore::FrameView::zoomAnimatorTransformChanged):
* page/FrameView.h:
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::zoomAnimatorTransformChanged):
* platform/ScrollableArea.h:

Source/WebKit2:

Change 'double' parameters to 'float' to match changes in FrameView.

Reviewed by Simon Fraser.

* WebProcess/Plugins/PDF/BuiltInPDFView.h:
(WebKit::BuiltInPDFView::zoomAnimatorTransformChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSome API tests are timing out in Release
fpizlo@apple.com [Tue, 11 Oct 2011 21:56:09 +0000 (21:56 +0000)]
Some API tests are timing out in Release
https://bugs.webkit.org/show_bug.cgi?id=69787

Reviewed by Mark Rowe.

NDEBUG must be set in release builds. Otherwise the world breaks. Also added some
magic to ensure that GTest builds in release mode in clang with NDEBUG set.

* TestWebKitAPI/Configurations/Base.xcconfig:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix, unbreaking the Qt minimal bot.
noam.rosenthal@nokia.com [Tue, 11 Oct 2011 21:42:54 +0000 (21:42 +0000)]
Unreviewed build fix, unbreaking the Qt minimal bot.
Some #ifdef ENABLED(TILED_BACKING_STORE) clauses were missing.

* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::computeTiles):
(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::paintSelf):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMac rebaseline after r96610.
rniwa@webkit.org [Tue, 11 Oct 2011 21:24:20 +0000 (21:24 +0000)]
Mac rebaseline after r96610.

* platform/chromium/http/tests/security/redirect-BLOCKED-to-localURL-expected.txt: Copied from
LayoutTests/http/tests/security/redirect-BLOCKED-to-localURL-expected.txt.
* platform/mac/http/tests/security/redirect-BLOCKED-to-localURL-expected.txt: Copied from
LayoutTests/http/tests/security/redirect-BLOCKED-to-localURL-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago [Mac] Small embedded PDFs are not fully repainted when scrolling
ap@apple.com [Tue, 11 Oct 2011 21:14:12 +0000 (21:14 +0000)]
    [Mac] Small embedded PDFs are not fully repainted when scrolling
        https://bugs.webkit.org/show_bug.cgi?id=69861

        Reviewed by Anders Carlsson.

        * WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::paintContent):
        Account for vertical centering when deciding which pages to paint.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMac rebaseline after r96675.
rniwa@webkit.org [Tue, 11 Oct 2011 21:10:39 +0000 (21:10 +0000)]
Mac rebaseline after r96675.

* platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGeneralize r95461 change to include table-cell and
inferno@chromium.org [Tue, 11 Oct 2011 21:09:24 +0000 (21:09 +0000)]
Generalize r95461 change to include table-cell and
allow splitting between :before, :after content.
https://bugs.webkit.org/show_bug.cgi?id=69854

Reviewed by Eric Seidel.

* fast/table/table-row-before-after-content-around-table-cell-expected.png: Added.
* fast/table/table-row-before-after-content-around-table-cell-expected.txt: Added.
* fast/table/table-row-before-after-content-around-table-cell.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Generalize r95461 change to include table-cell and
inferno@chromium.org [Tue, 11 Oct 2011 21:05:20 +0000 (21:05 +0000)]
Source/WebCore: Generalize r95461 change to include table-cell and
allow splitting between :before, :after content.
https://bugs.webkit.org/show_bug.cgi?id=69854

Reviewed by Eric Seidel.

Test: fast/table/table-row-before-after-content-around-table-cell.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::addChild):

LayoutTests: Style for updated due to inability to locate
:before content in presence of listmarkers and runins.
https://bugs.webkit.org/show_bug.cgi?id=68624

Reviewed by Eric Seidel.

* fast/lists/inline-before-content-after-list-marker-expected.png: Added.
* fast/lists/inline-before-content-after-list-marker-expected.txt: Added.
* fast/lists/inline-before-content-after-list-marker.html: Added.
* fast/runin/runin-between-list-marker-and-before-content-expected.png: Added.
* fast/runin/runin-between-list-marker-and-before-content-expected.txt: Added.
* fast/runin/runin-between-list-marker-and-before-content.html: Added.
* fast/runin/runin-into-div-with-float-child-expected.png: Added.
* fast/runin/runin-into-div-with-float-child-expected.txt: Added.
* fast/runin/runin-into-div-with-float-child.html: Added.
* fast/runin/runin-not-go-into-float-expected.png: Added.
* fast/runin/runin-not-go-into-float-expected.txt: Added.
* fast/runin/runin-not-go-into-float.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMac rebaseline after r96958.
rniwa@webkit.org [Tue, 11 Oct 2011 21:02:38 +0000 (21:02 +0000)]
Mac rebaseline after r96958.

* platform/mac/fast/forms/input-disabled-color-expected.png:
* platform/mac/fast/forms/input-disabled-color-expected.txt:
* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove test expectations added by r96987 to Chromium Linux directory,
rniwa@webkit.org [Tue, 11 Oct 2011 20:58:28 +0000 (20:58 +0000)]
Move test expectations added by r96987 to Chromium Linux directory,
and add the baseline for Mac port.

* fast/css/text-transform-select-expected.txt: Removed.
* platform/chromium-linux/fast/css/text-transform-select-expected.txt: Copied from
LayoutTests/fast/css/text-transform-select-expected.txt.
* platform/mac/fast/css/text-transform-select-expected.png: Added.
* platform/mac/fast/css/text-transform-select-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAccessibilityMenuList should fire change notification when popup is not open.
dmazzoni@google.com [Tue, 11 Oct 2011 20:46:25 +0000 (20:46 +0000)]
AccessibilityMenuList should fire change notification when popup is not open.
https://bugs.webkit.org/show_bug.cgi?id=69440

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/menu-list-sends-change-notification.html

* accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::didUpdateActiveOption):

LayoutTests:

* accessibility/menu-list-sends-change-notification.html: Added.
* platform/chromium/accessibility/menu-list-sends-change-notification-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogarden-o-matic links to flakiness dashboard should open in a new tab
abarth@webkit.org [Tue, 11 Oct 2011 20:44:37 +0000 (20:44 +0000)]
garden-o-matic links to flakiness dashboard should open in a new tab
https://bugs.webkit.org/show_bug.cgi?id=69864

Reviewed by Dimitri Glazkov.

This bug was obvious in the first five minutes of using this new
feature.  :)

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Suddenly, things are crashing sporadically.
dglazkov@chromium.org [Tue, 11 Oct 2011 20:44:22 +0000 (20:44 +0000)]
[Chromium] Suddenly, things are crashing sporadically.

* platform/chromium/test_expectations.txt: Document the crashes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTweak the Content-Security-Policy for garden-o-matic. It turns out
abarth@webkit.org [Tue, 11 Oct 2011 20:37:10 +0000 (20:37 +0000)]
Tweak the Content-Security-Policy for garden-o-matic.  It turns out
that * doesn't really mean "all".  I've emailed the W3C working group
about changing the spec.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] fast/js/regexp-overflow.html is slow everywhere.
dglazkov@chromium.org [Tue, 11 Oct 2011 20:36:51 +0000 (20:36 +0000)]
[Chromium] fast/js/regexp-overflow.html is slow everywhere.

* platform/chromium/test_expectations.txt: Widened platform specifiers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogarden-o-matic should link to the flakiness dashboard
abarth@webkit.org [Tue, 11 Oct 2011 20:34:12 +0000 (20:34 +0000)]
garden-o-matic should link to the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=69862

Reviewed by Dimitri Glazkov.

The flakiness dashboard has lots of great information about the failure
history of each test.  This patch adds a link from garden-o-matic to
the flakiness dashboard so the gardener can look at this information.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowatchlist: assertRaisesRegexp implementation should be compatible with python 2.7.
levin@chromium.org [Tue, 11 Oct 2011 20:21:23 +0000 (20:21 +0000)]
watchlist: assertRaisesRegexp implementation should be compatible with python 2.7.
https://bugs.webkit.org/show_bug.cgi?id=69789

Reviewed by Eric Seidel.

Made the signature of _assertRaisesRegexp match that of Python 2.7.

* Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adjusted to be compatible with Python 2.7.
* Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Ditto.
* Scripts/webkitpy/common/webkitunittest.py: Ditto.
* Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Mark more flakes as flakes.
dglazkov@chromium.org [Tue, 11 Oct 2011 19:56:28 +0000 (19:56 +0000)]
[Chromium] Mark more flakes as flakes.

* platform/chromium/test_expectations.txt: Marked flakes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] DRT: Do not abort() when an unknown key is pressed.
commit-queue@webkit.org [Tue, 11 Oct 2011 19:37:18 +0000 (19:37 +0000)]
[EFL] DRT: Do not abort() when an unknown key is pressed.
https://bugs.webkit.org/show_bug.cgi?id=69856

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-11
Reviewed by Antonio Gomes.

A lot of tests crash due to the previous behaviour. Just using the
received name of the pressed key works most of the time, and when it
does not the failing tests should tell us.

* DumpRenderTree/efl/EventSender.cpp:
(keyPadNameFromJSValue):
(keyNameFromJSValue):
(keyDownCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIndexedDB: implement IDBFactory.cmp method
commit-queue@webkit.org [Tue, 11 Oct 2011 19:22:14 +0000 (19:22 +0000)]
IndexedDB: implement IDBFactory.cmp method
https://bugs.webkit.org/show_bug.cgi?id=62293

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-11
Reviewed by Tony Chang.

Source/WebCore:

* storage/IDBFactory.cpp:
(WebCore::IDBFactory::cmp):
* storage/IDBFactory.h:
* storage/IDBFactory.idl:
* storage/IDBKey.cpp:
(WebCore::IDBKey::compare):
(WebCore::IDBKey::isLessThan):
(WebCore::IDBKey::isEqual):
* storage/IDBKey.h:

LayoutTests:

Check for IDBFactory.deleteDatabase (NYI) marked as FAIL. crbug.com/72002
Tests for array keys (NYI) marked as FAIL. crbug.com/99876
Tests for invalid key exception types marked as FAIL. crbug.com/98930

* storage/indexeddb/factory-basics-expected.txt:
* storage/indexeddb/factory-basics.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Embedding of PDF's with <object> or <embed> fails when there is no MIME type...
ap@apple.com [Tue, 11 Oct 2011 19:01:14 +0000 (19:01 +0000)]
    Embedding of PDF's with <object> or <embed> fails when there is no MIME type specified
        https://bugs.webkit.org/show_bug.cgi?id=64934

        Reviewed by Dan Bernstein.

        * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): Check URL extension, too,
        like GetPluginPath does in UI process. One difference is that UI process additionally tries
        platform specific extension to MIME type mapping, but that doesn't matter for PDF, which
        does not have other standard extensions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Unbarf Win testers after ambiguous expectations were added in r97149.
dglazkov@chromium.org [Tue, 11 Oct 2011 18:39:42 +0000 (18:39 +0000)]
[Chromium] Unbarf Win testers after ambiguous expectations were added in r97149.

* platform/chromium/test_expectations.txt: Made expectation more specific.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Texmap] TextureMapperGL leaves GL in a modified state.
noam.rosenthal@nokia.com [Tue, 11 Oct 2011 18:35:37 +0000 (18:35 +0000)]
[Texmap] TextureMapperGL leaves GL in a modified state.
https://bugs.webkit.org/show_bug.cgi?id=68983

Reviewed by Andreas Kling.

Disable the vertexAttribArray after clipping.

No new functionality so no new tests.

* platform/graphics/opengl/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::beginClip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Fix expectations for two accessibility tests.
dmazzoni@google.com [Tue, 11 Oct 2011 18:07:56 +0000 (18:07 +0000)]
[Chromium] Fix expectations for two accessibility tests.
https://bugs.webkit.org/show_bug.cgi?id=69827

These tests were never run on Chromium before, so they're not new
failures. aria-roles had different expectations on different Mac
platforms, but on Chromium the results will always be the same, so
added Chromium-specific expectations. image-map-update-parent is
timing out, the cause here is unclear but it was never running before
so there's no new bug.

Unreviewed.

* platform/chromium/accessibility/aria-roles-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Synchronize tiling with accelerated compositing
noam.rosenthal@nokia.com [Tue, 11 Oct 2011 17:43:00 +0000 (17:43 +0000)]
[Qt][WK2] Synchronize tiling with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=69151

Reviewed by Kenneth Rohde Christiansen.

Enable "externally managed" tiles in TextureMapperNodes.
Currently, TextureMapperNodes manage tiles themselves, the tiles being there only to
overcome the 2k texture size limitation. For WebKit2, we want those tiles to be managed
externally, namely through the web process via the remote tile backend for
TiledBackingStore.

This patch adds a store for those externally managed tiles, and adds the necessary code to
paint them instead of the owned tiles when appropriate.

In addition, in order to support externally managed remote tiles, we have to calculate per-
layer visible rects and pass them to the web process. The new collectVisibleContentRects
does this - and is directly tied to the externally-managed tile approach.

Code is disabled for now, but covered by existing compositing tests.

* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::computeTiles):
(WebCore::clampRect):
(WebCore::TextureMapperNode::collectVisibleContentRects):
(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::targetRectForTileRect):
(WebCore::TextureMapperNode::paintSelf):
(WebCore::TextureMapperNode::createContentsTile):
(WebCore::TextureMapperNode::removeContentsTile):
(WebCore::TextureMapperNode::setTileBackBufferTextureForDirectlyCompositedImage):
(WebCore::TextureMapperNode::clearAllDirectlyCompositedImageTiles):
(WebCore::TextureMapperNode::setContentsTileBackBuffer):
(WebCore::TextureMapperNode::swapContentsBuffers):
(WebCore::TextureMapperNode::syncCompositingStateSelf):
(WebCore::TextureMapperNode::syncCompositingState):
* platform/graphics/texmap/TextureMapperNode.h:
(WebCore::TextureMapperNode::size):
(WebCore::TextureMapperNode::setTileOwnership):
(WebCore::TextureMapperNode::setID):
(WebCore::TextureMapperNode::id):
(WebCore::TextureMapperNode::texture):
(WebCore::TextureMapperNode::ExternallyManagedTile::ExternallyManagedTile):
(WebCore::TextureMapperNode::State::State):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Gardening flakey test expectations.
dglazkov@chromium.org [Tue, 11 Oct 2011 17:41:02 +0000 (17:41 +0000)]
[Chromium] Gardening flakey test expectations.

* platform/chromium/test_expectations.txt: Updated for recent flakes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] GtkAuthenticationDialog: use GtkGrid instead of GtkTable
commit-queue@webkit.org [Tue, 11 Oct 2011 17:16:57 +0000 (17:16 +0000)]
[GTK] GtkAuthenticationDialog: use GtkGrid instead of GtkTable
https://bugs.webkit.org/show_bug.cgi?id=69749

Patch by Claudio Saavedra <csaavedra@igalia.com> on 2011-10-11
Reviewed by Martin Robinson.

* platform/gtk/GtkAuthenticationDialog.cpp:
(WebCore::addEntryToGrid): Migrate to GtkGrid when using GTK+ 3
(WebCore::GtkAuthenticationDialog::GtkAuthenticationDialog):
Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Build fix.
ap@apple.com [Tue, 11 Oct 2011 17:03:32 +0000 (17:03 +0000)]
    Build fix.

        * WebCore.exp.in: Export GraphicsContext::clearShadow().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[MutationObservers] Add stub implementation of WebKitMutationObserver
adamk@chromium.org [Tue, 11 Oct 2011 16:57:07 +0000 (16:57 +0000)]
[MutationObservers] Add stub implementation of WebKitMutationObserver
https://bugs.webkit.org/show_bug.cgi?id=68949

Reviewed by Ryosuke Niwa, Oliver Hunt, and Dimitri Glazkov.

Source/WebCore:

See https://bugs.webkit.org/show_bug.cgi?id=68729 for the metabug.

This patch adds a stub WebKitMutationObserver and its supporting classes
MutationCallback and MutationObserverOptions.
No implementation is provided for the all-important observe() and
disconnect() methods.

Note that WebKitMutationObserver is vendor-prefixed since it has a
constructor exposed on DOMWindow.  None of the rest of the API needs
prefixing, as it's only available via a call through a MutationObserver
callback (created by instantiating WebKitMutationObserver).

Given the number of files required to get just the stub up and running,
it seems reasonable to leave the actual implementation for the next
patch (or more likely several patches).  I've left FIXMEs in all the places
that'll need augmentation.

Tests: fast/mutation/mutation-observer-constructor.html
       fast/mutation/observe-exceptions.html

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.list.am:
* UseJSC.cmake:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDictionary.h:
(WebCore::JSDictionary::tryGetProperty):
* bindings/js/JSMutationCallbackCustom.cpp: Added.
(WebCore::JSMutationCallback::handleEvent):
* bindings/js/JSWebKitMutationObserverCustom.cpp: Added.
(WebCore::JSWebKitMutationObserverConstructor::constructJSWebKitMutationObserver):
(WebCore::JSWebKitMutationObserver::observe):
* bindings/v8/custom/V8MutationCallbackCustom.cpp: Added.
(WebCore::V8MutationCallback::handleEvent):
* bindings/v8/custom/V8WebKitMutationObserverCustom.cpp: Added.
(WebCore::V8WebKitMutationObserver::constructorCallback):
(WebCore::V8WebKitMutationObserver::observeCallback):
* dom/MutationCallback.h: Added.
(WebCore::MutationCallback::~MutationCallback):
* dom/MutationCallback.idl: Added.
* dom/MutationObserverOptions.h: Added.
(WebCore::MutationObserverOptions::create):
(WebCore::MutationObserverOptions::childList):
(WebCore::MutationObserverOptions::setChildList):
(WebCore::MutationObserverOptions::attributes):
(WebCore::MutationObserverOptions::setAttributes):
(WebCore::MutationObserverOptions::characterData):
(WebCore::MutationObserverOptions::setCharacterData):
(WebCore::MutationObserverOptions::subtree):
(WebCore::MutationObserverOptions::setSubtree):
(WebCore::MutationObserverOptions::attributeOldValue):
(WebCore::MutationObserverOptions::setAttributeOldValue):
(WebCore::MutationObserverOptions::characterDataOldValue):
(WebCore::MutationObserverOptions::setCharacterDataOldValue):
(WebCore::MutationObserverOptions::MutationObserverOptions):
* dom/WebKitMutationObserver.cpp: Added.
(WebCore::WebKitMutationObserver::create):
(WebCore::WebKitMutationObserver::WebKitMutationObserver):
(WebCore::WebKitMutationObserver::~WebKitMutationObserver):
(WebCore::WebKitMutationObserver::observe):
(WebCore::WebKitMutationObserver::disconnect):
* dom/WebKitMutationObserver.h: Added.
* dom/WebKitMutationObserver.idl: Added.
* page/DOMWindow.idl:

Source/WebKit/chromium:

* features.gypi: Added 'enable_mutation_observers' variable.

LayoutTests:

Add basic tests and skip them in all ports for now.

* fast/mutation/mutation-observer-constructor-expected.txt: Added.
* fast/mutation/mutation-observer-constructor.html: Added.
* fast/mutation/observe-exceptions-expected.txt: Added.
* fast/mutation/observe-exceptions.html: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] [WK2] NRWT failed to launch MiniBrowser after test run
commit-queue@webkit.org [Tue, 11 Oct 2011 16:53:41 +0000 (16:53 +0000)]
[Qt] [WK2] NRWT failed to launch MiniBrowser after test run
https://bugs.webkit.org/show_bug.cgi?id=68016

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-10-11
Reviewed by Chang Shu.

* Scripts/webkitpy/layout_tests/port/qt.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNeed more efficient ways to set inline CSS styles
commit-queue@webkit.org [Tue, 11 Oct 2011 16:48:52 +0000 (16:48 +0000)]
Need more efficient ways to set inline CSS styles
https://bugs.webkit.org/show_bug.cgi?id=58157

Patch by Arun Patole <BMF834@motorola.com> on 2011-10-11
Reviewed by Dimitri Glazkov.

No new tests added as this is just a code optimization.

Code optimization:
  -Used CSSPropertyNames, CSSValues and CSSPrimitiveValues instead of Strings.
  -Removed displayString(), webkitTransitionString(), opacityString() functions as they will no longer be needed after this change.
  -Moved makeOpaque and makeTransparent functionality to MediaControlPanelElement from MediaControlRootElement.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerRateChanged):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlElement::show):
(WebCore::MediaControlElement::hide):
(WebCore::MediaControlPanelElement::MediaControlPanelElement):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):
(WebCore::MediaControlInputElement::show):
(WebCore::MediaControlInputElement::hide):
* html/shadow/MediaControlElements.h:
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::MediaControlRootElement):
(WebCore::MediaControlRootElement::makeOpaque):
(WebCore::MediaControlRootElement::makeTransparent):
* html/shadow/MediaControlRootElement.h:
* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::makeOpaque):
(WebCore::MediaControlRootElementChromium::makeTransparent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago [Mac] Should be able to display multi-page PDFs in subframes
ap@apple.com [Tue, 11 Oct 2011 16:41:11 +0000 (16:41 +0000)]
    [Mac] Should be able to display multi-page PDFs in subframes
        https://bugs.webkit.org/show_bug.cgi?id=69804

        Reviewed by Anders Carlsson.

        * WebProcess/Plugins/PDF/BuiltInPDFView.h:
        * WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
        (WebKit::BuiltInPDFView::updateScrollbars): Page step should be exactly one page, so that
        one could step over the document page by page. It certainly shouldn't be a portion of the
        whole document.
        (WebKit::BuiltInPDFView::pdfDocumentDidLoad): Moved duplicated code from load callbacks here.
        (WebKit::BuiltInPDFView::calculateSizes): Calculate document size including gutters, and
        remember page boxes.
        (WebKit::BuiltInPDFView::paint): Split into separate functions.
        (WebKit::BuiltInPDFView::paintBackground): Just paint gray background for the whole dirty rect.
        (WebKit::BuiltInPDFView::paintContent): Paint pages and shadow under them. This code is still
        fairly naive, as it doesn't understand annotations or page rotation.
        Constants for shadows roughly match PDFView, but not quite, since it draws entirely custom
        shadows.
        (WebKit::BuiltInPDFView::paintControls): Moved scrollbar and scroll corner painting here.
        (WebKit::BuiltInPDFView::streamDidFinishLoading): Moved common code into pdfDocumentDidLoad().
        (WebKit::BuiltInPDFView::manualStreamDidFinishLoading): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] WebProcess using proxy settings for localhost as well
commit-queue@webkit.org [Tue, 11 Oct 2011 16:13:11 +0000 (16:13 +0000)]
[Qt] WebProcess using proxy settings for localhost as well
https://bugs.webkit.org/show_bug.cgi?id=69611

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-10-11
Reviewed by Chang Shu.

Implemented checks in queryProxy to return QNetworkProxy::NoProxy for localhost and 127.0.0.1

* WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::EnvHttpProxyFactory::queryProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwitch RegisterSizedBoolean/dfgConvertJSValueToInt32 return type to size_t
commit-queue@webkit.org [Tue, 11 Oct 2011 16:02:52 +0000 (16:02 +0000)]
Switch RegisterSizedBoolean/dfgConvertJSValueToInt32 return type to size_t
https://bugs.webkit.org/show_bug.cgi?id=69821

Patch by Gavin Barraclough <baraclough@apple.com> on 2011-10-11
Reviewed by Filip Pizlo.

Operations returning types Z (int32_t) and B (RegisterSizedBoolean - implemented as an
intptr_t) are indistinguishable on 32-bit Linux, preventing the DFG JIT from building.

dfgConvertJSValueToInt32 would be better returning a value known to be register sized, for
JSVALUE64 (we currently zero-extend in JIT code, potentially introducing an unnecessary
move), so by switching all associated operations to return a size_t we can fix the type
problem on Linux & make it a small tweak that removes an unnecessary instruction.

* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):
    - comparisons now return a size_t.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
    - Removed Z_DFGOperation_EJ form.
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
    - comparisons now return a size_t.
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
    - comparisons now return a size_t.
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
    - Change return types for comparison operations & dfgConvertJSValueToInt32 to size_t,
      Both need to return values zero extended to fill a register.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
    - comparisons now return a size_t.
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compare):
    - comparisons now return a size_t.
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compare):
    - comparisons now return a size_t.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: make Extensions component compile.
pfeldman@chromium.org [Tue, 11 Oct 2011 14:43:45 +0000 (14:43 +0000)]
Web Inspector: make Extensions component compile.
https://bugs.webkit.org/show_bug.cgi?id=69833

Reviewed by Yury Semikhatsky.

* inspector/compile-front-end.sh:
* inspector/front-end/BinarySearch.js:
* inspector/front-end/ConsoleModel.js:
* inspector/front-end/ExtensionAPI.js:
(injectedExtensionAPI.Network.prototype.addRequestHeaders):
(injectedExtensionAPI.AuditResultImpl.prototype.addResult):
(injectedExtensionAPI.AuditResultNode.prototype.addChild):
* inspector/front-end/ExtensionAuditCategory.js:
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionSidebarPane.prototype.setExpression):
* inspector/front-end/ExtensionRegistryStub.js:
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._postNotification):
(WebInspector.ExtensionServer.prototype._onAddRequestHeaders):
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
(WebInspector.ExtensionServer.prototype._registerExtension):
(WebInspector.ExtensionStatus):
* inspector/front-end/NetworkLog.js:
(WebInspector.NetworkLog.prototype._onResourceStarted):
* inspector/front-end/Object.js:
(WebInspector.Object.prototype.dispatchEventToListeners):
* inspector/front-end/externs.js:
(console.warn):
(console.assert):
(console.error):
():
(AuditResult):
(EventSink):
(ExtensionSidebarPane):
(Panel):
(PanelWithSidebar):
(Request):
(Resource):
(Timeline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: implement CompilerSourceMappingProvider.
podivilov@chromium.org [Tue, 11 Oct 2011 14:04:55 +0000 (14:04 +0000)]
Web Inspector: implement CompilerSourceMappingProvider.
https://bugs.webkit.org/show_bug.cgi?id=69423

Reviewed by Pavel Feldman.

Source/WebCore:

CompilerSourceMappingProvider implements a cross-domain communication channel for loading source mappings and source files.
Front-end page can't send XHRs to source mapping server directly due to SOP restrictions. Instead, we inject an invisible
iframe that is loaded from source mapping server and use window.postMessage to communicate with it. iframe has a different
origin and thus doesn't have access to front-end window.

Test: http/tests/inspector/compiler-source-mapping-provider.html

* inspector/front-end/CompilerSourceMappingProvider.js:
(WebInspector.CompilerSourceMappingProvider):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping.frameLoaded.didLoadData):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping.frameLoaded):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceCode):
(WebInspector.CompilerSourceMappingProvider.prototype._sendRequest):
(WebInspector.CompilerSourceMappingProvider.prototype._onMessage):
(WebInspector.CompilerSourceMappingProvider.prototype._cancelRequest):
* inspector/front-end/inspector.js:
(WebInspector.installSourceMappingForTest):

LayoutTests:

* http/tests/inspector/compiler-source-mapping-provider-expected.txt: Added.
* http/tests/inspector/compiler-source-mapping-provider.html: Added.
* http/tests/inspector/resources/compiler-source-mapping-provider/app-map: Added.
* http/tests/inspector/resources/compiler-source-mapping-provider/app-map.html: Added.
* http/tests/inspector/resources/compiler-source-mapping-provider/app.js: Added.
(window.onload):
(handleClick):
* http/tests/inspector/resources/compiler-source-mapping-provider/foo.js: Added.
(ClickHandler):
(ClickHandler.prototype.handle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] DRT: Return the right window count in LayoutTestController.
commit-queue@webkit.org [Tue, 11 Oct 2011 13:30:56 +0000 (13:30 +0000)]
[EFL] DRT: Return the right window count in LayoutTestController.
https://bugs.webkit.org/show_bug.cgi?id=69764

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-11
Reviewed by Antonio Gomes.

Follow-up to r96943: now that we have DumpRenderTreeChrome and
DumpRenderTreeView in the tree, we can correctly count the number of
open windows in DRT.

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::windowCount):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agore-add support for GDI text behind a compile flag
reed@google.com [Tue, 11 Oct 2011 13:11:33 +0000 (13:11 +0000)]
re-add support for GDI text behind a compile flag
https://bugs.webkit.org/show_bug.cgi?id=69530

Reviewed by James Robinson.

Source/WebCore:

Reverts back to using GDI for text (when possible)
but keeps skia-text version behind a compile-flag. If/when we can
resolve the outstanding soft-clip and intl-performance bugs with the
skia version, we may change the compile-flag to reenable skia.

Previous change http://trac.webkit.org/changeset/94589 removed the GDI code.

* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::estimateTextBounds):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::estimateTextBounds):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):
* platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::draw):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
* platform/graphics/skia/PlatformContextSkia.h:
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::windowsCanHandleDrawTextShadow):
(WebCore::windowsCanHandleTextDrawing):
(WebCore::windowsCanHandleTextDrawingWithoutShadow):
* platform/graphics/skia/SkiaFontWin.h:

Source/WebKit/chromium:

* features.gypi:

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r96770-r96777): fast/dom/Window/window-properties.html, fast/dom/prototyp...
ossy@webkit.org [Tue, 11 Oct 2011 12:54:19 +0000 (12:54 +0000)]
REGRESSION (r96770-r96777): fast/dom/Window/window-properties.html, fast/dom/prototype-inheritance-2.html, fast/js/global-constructors.html failing on SnowLeopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=69800

Patch by Jer Noble <jer.noble@apple.com> on 2011-10-11
Reviewed by Csaba Osztrogonác.

Tools:

Enable WEB_AUDIO at runtime.

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):

LayoutTests:

Rebaseline after r96774.

* platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
* platform/mac/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] DRT: Make sure IconDatabase is closed before trying to open it again.
commit-queue@webkit.org [Tue, 11 Oct 2011 12:47:54 +0000 (12:47 +0000)]
[EFL] DRT: Make sure IconDatabase is closed before trying to open it again.
https://bugs.webkit.org/show_bug.cgi?id=69769

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-11
Reviewed by Antonio Gomes.

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setIconDatabaseEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Gtk] Update test expectation after r96712.
mario@webkit.org [Tue, 11 Oct 2011 12:20:05 +0000 (12:20 +0000)]
[Gtk] Update test expectation after r96712.

Unreviewed gardening.

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2011-10-11

* platform/gtk/svg/clip-path/clip-path-transform-1-expected.png: Added.
* platform/gtk/svg/clip-path/clip-path-transform-1-expected.txt: Added.
* platform/gtk/svg/clip-path/clip-path-transform-2-expected.png: Added.
* platform/gtk/svg/clip-path/clip-path-transform-2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-10-11 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 11 Oct 2011 11:51:23 +0000 (11:51 +0000)]
2011-10-11  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, roll chromium revision to pick HTML speech input images update.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Gtk] Skip test crashing due to bug 60931.
mario@webkit.org [Tue, 11 Oct 2011 11:34:57 +0000 (11:34 +0000)]
[Gtk] Skip test crashing due to bug 60931.
https://bugs.webkit.org/show_bug.cgi?id=60931

Unreviewed gardening.

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2011-10-11

* platform/gtk/Skipped: Skipped
http/tests/security/cookies/cookie-theft-with-javascript-doc.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Support multipart responses is not implemented.
ossy@webkit.org [Tue, 11 Oct 2011 11:12:46 +0000 (11:12 +0000)]
[Qt] Support multipart responses is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=47060

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2011-10-11
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:
 - Skip multipart tests.
 - Unskip http/tests/misc/timer-vs-loading.htm, because it isn't multipart test and it passes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Gtk] Update test expectation after r96970.
mario@webkit.org [Tue, 11 Oct 2011 11:07:29 +0000 (11:07 +0000)]
[Gtk] Update test expectation after r96970.

Unreviewed gardening.

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2011-10-11

* platform/gtk/fast/images/color-jpeg-with-color-profile-expected.png: Added.
* platform/gtk/fast/images/color-jpeg-with-color-profile-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Gtk] Update test expectation after r97103.
mario@webkit.org [Tue, 11 Oct 2011 10:40:48 +0000 (10:40 +0000)]
[Gtk] Update test expectation after r97103.

Unreviewed gardening.

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2011-10-11

* platform/gtk/plugins/iframe-plugin-bgcolor-expected.png: Added.
* platform/gtk/plugins/iframe-plugin-bgcolor-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-10-11 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 11 Oct 2011 10:35:32 +0000 (10:35 +0000)]
2011-10-11  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, mark two accessibility tests as failing on chromium.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Remove all references to QTDIR_build and standalone_package
vestbo@webkit.org [Tue, 11 Oct 2011 10:30:54 +0000 (10:30 +0000)]
[Qt] Remove all references to QTDIR_build and standalone_package

Qt is now modularized, which means we no longer import WebKit into
the Qt source tree. Instead we use git submodules, and building
QtWebKit as "part of Qt" is really building QtWebKit as from trunk.

To decrease the number of buildsystem configurations we also remove
the standalone_package code-path used when we were providing tarballs
with the derived sources pre-generated.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-10-11 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 11 Oct 2011 10:15:17 +0000 (10:15 +0000)]
2011-10-11  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, rebaseline test expectations after r104864 (chromium).

        * platform/chromium-cg-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
        * platform/chromium-cg-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.png:
        * platform/chromium-cg-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
        * platform/chromium-cg-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
        * platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png: Added.
        * platform/chromium-cg-mac/fast/speech/input-appearance-numberandspeech-expected.png: Removed.
        * platform/chromium-cg-mac/fast/speech/input-appearance-searchandspeech-expected.png: Removed.
        * platform/chromium-cg-mac/fast/speech/input-appearance-speechbutton-expected.png: Removed.
        * platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
        * platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
        * platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
        * platform/chromium-linux/fast/speech/speech-bidi-rendering-expected.png:
        * platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png: Added.
        * platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.png: Added.
        * platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png: Added.
        * platform/chromium-mac-leopard/fast/speech/speech-bidi-rendering-expected.png: Added.
        * platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png: Added.
        * platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png: Added.
        * platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png: Added.
        * platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png: Added.
        * platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png: Removed.
        * platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt: Removed.
        * platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png: Removed.
        * platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt: Removed.
        * platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png: Removed.
        * platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt: Removed.
        * platform/chromium-mac/fast/speech/speech-bidi-rendering-expected.png: Removed.
        * platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
        * platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png:
        * platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.png:
        * platform/chromium-win/fast/speech/speech-bidi-rendering-expected.png:
        * platform/chromium/fast/speech/input-appearance-numberandspeech-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/speech/input-appearance-numberandspeech-expected.txt.
        * platform/chromium/fast/speech/input-appearance-searchandspeech-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/speech/input-appearance-searchandspeech-expected.txt.
        * platform/chromium/fast/speech/input-appearance-speechbutton-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/speech/input-appearance-speechbutton-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoShrink WebCore::Node on 64-bit.
andreas.kling@nokia.com [Tue, 11 Oct 2011 09:31:38 +0000 (09:31 +0000)]
Shrink WebCore::Node on 64-bit.
https://bugs.webkit.org/show_bug.cgi?id=69768

Reviewed by Antti Koivisto.

Rearrange TreeShared and Node members so that the node flags fall
into the padding at the end of TreeShared on 64-bit, reducing the
size of Node (and all subclasses) by 8 bytes.

* dom/Document.h:
(WebCore::Node::Node):
* dom/Node.h:
* platform/TreeShared.h:
(WebCore::TreeShared::TreeShared):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Gtk] Update test expectations after r96987, r97088 and r97114.
mario@webkit.org [Tue, 11 Oct 2011 09:30:55 +0000 (09:30 +0000)]
[Gtk] Update test expectations after r96987, r97088 and r97114.

Unreviewed gardening.

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2011-10-11

* platform/gtk/fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
* platform/gtk/fast/css-generated-content/table-parts-before-and-after-expected.txt: Added.
* platform/gtk/fast/css/text-transform-select-expected.png: Added.
* platform/gtk/fast/css/text-transform-select-expected.txt: Added.
* platform/gtk/fullscreen/full-screen-render-inline-expected.png: Added.
* platform/gtk/fullscreen/full-screen-render-inline-expected.txt: Added.
* platform/gtk/fullscreen/parent-flow-inline-with-block-child-expected.png: Added.
* platform/gtk/fullscreen/parent-flow-inline-with-block-child-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove m_listItems and m_recalcListItems from SelectElementData to HTMLSelectElement
tkent@chromium.org [Tue, 11 Oct 2011 08:45:38 +0000 (08:45 +0000)]
Move m_listItems and m_recalcListItems from SelectElementData to HTMLSelectElement
https://bugs.webkit.org/show_bug.cgi?id=69812

Reviewed by Ryosuke Niwa.

Move SelectElementData::m_recalcListItems,
SelectElementData::m_listItems, and related functions of
SelectElementData class to HTMLSelectElement.

Non-const listItems() was removed because it is used only in
recalcListItemsInternal() and it can access m_listItems diretly.

Static recalcListItems() is changed to non-static, and renamed to
recalcListItemsInternal() in order to avoid confusion with the
existing recalcListItems().

No new tests, just a refactoring.

* dom/SelectElement.cpp:
Move checkListItems() and listItems() to HTMLSelectElement.
(WebCore::SelectElementData::SelectElementData):
Remove Initialization of m_recalcListItems.
* dom/SelectElement.h:
Move m_recalcListItems, m_listItems, and related functions to HTMLSelectElement.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::HTMLSelectElement):
Initializes m_recalcListItems.
(WebCore::HTMLSelectElement::recalcListItems):
Rename the static recalcListItems() to recalcListItemsInternal().
(WebCore::HTMLSelectElement::recalcListItemsIfNeeded):
Use m_recalcListItems directly.
(WebCore::HTMLSelectElement::nextSelectableListIndex):
Update a listItems() callsite.
(WebCore::HTMLSelectElement::previousSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::firstSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::lastSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::nextSelectableListIndexPageAway): ditto.
(WebCore::HTMLSelectElement::saveLastSelection): ditto.
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): ditto.
(WebCore::HTMLSelectElement::updateListBoxSelection): ditto.
(WebCore::HTMLSelectElement::listBoxOnChange): ditto.
(WebCore::HTMLSelectElement::checkListItems):
Moved from SelectElementData.
(WebCore::HTMLSelectElement::listItems): ditto.
(WebCore::HTMLSelectElement::setRecalcListItems):
Use m_recalcListItems directly.
(WebCore::HTMLSelectElement::recalcListItemsInternal):
- Make this non-static.
- Renamed from recalcListItems() to avoid confilct with another recalcListItems().
- Use m_recalcListItems and m_listItems directly.
(WebCore::HTMLSelectElement::selectedIndex):
Update a listItems() callsite.
(WebCore::HTMLSelectElement::setSelectedIndexInternal): ditto.
(WebCore::HTMLSelectElement::optionToListIndex): ditto.
(WebCore::HTMLSelectElement::listToOptionIndex): ditto.
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation): ditto.
(WebCore::HTMLSelectElement::saveFormControlState):
Update callsites of listItems() and recalcListItems().
(WebCore::HTMLSelectElement::restoreFormControlState):
Update a listItems() callsite.
(WebCore::HTMLSelectElement::appendFormData): ditto.
(WebCore::HTMLSelectElement::reset): ditto.
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto.
(WebCore::HTMLSelectElement::updateSelectedState): ditto.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
(WebCore::HTMLSelectElement::lastSelectedListIndex): ditto.
(WebCore::HTMLSelectElement::typeAheadFind): ditto.
(WebCore::HTMLSelectElement::insertedIntoTree):
Update a recalcListItems() callsite.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
Update a listItems() callsite.
(WebCore::HTMLSelectElement::length): ditto.
* html/HTMLSelectElement.h:
Move m_recalcListItems, m_listItems, and related functions from SelectElementData.
* html/HTMLSelectElementWin.cpp:
(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
Update a listItems() callsite.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate Chromium text_expectations to skip mac- and win-specific accessibility
dmazzoni@google.com [Tue, 11 Oct 2011 08:44:53 +0000 (08:44 +0000)]
Update Chromium text_expectations to skip mac- and win-specific accessibility
tests. Unreviewed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Complex script code path breaks on Windows XP when a CFF font is used
bashi@chromium.org [Tue, 11 Oct 2011 08:38:43 +0000 (08:38 +0000)]
[Chromium] Complex script code path breaks on Windows XP when a CFF font is used
https://bugs.webkit.org/show_bug.cgi?id=69497

Reviewed by Kent Tamura.

Don't use CFF webfonts when ScriptShape() can't handle it.
ScriptShape() indicates us the case by setting fNoGlyphIndex to TRUE.
If it's TRUE, we don't use the font. This could happen with early
version of Uniscribe on WinXP.

No new tests because the version of Uniscribe depends on environment.
One can install newer version of Uniscribe on WinXP.

* platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::canUseGlyphIndex): Added.
(WebCore::UniscribeHelper::shape): Don't use the shape result when canUseGlyphIndex() returns false.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix crash with toDataURL to JPEG
commit-queue@webkit.org [Tue, 11 Oct 2011 08:28:00 +0000 (08:28 +0000)]
Fix crash with toDataURL to JPEG
https://bugs.webkit.org/show_bug.cgi?id=69681

Patch by John Bauman <jbauman@chromium.org> on 2011-10-11
Reviewed by Kenneth Russell.

Move RefPtr declaration outside if to make sure image data still
exists through CGImageToDataURL.

* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::toDataURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoExpose WebLayer::isNull
commit-queue@webkit.org [Tue, 11 Oct 2011 07:54:33 +0000 (07:54 +0000)]
Expose WebLayer::isNull
https://bugs.webkit.org/show_bug.cgi?id=69813

Patch by Antoine Labour <piman@chromium.org> on 2011-10-11
Reviewed by Darin Fisher.

* public/WebLayer.h:
(WebKit::WebLayer::isNull):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Update test expectation after r97109.
reni@webkit.org [Tue, 11 Oct 2011 07:50:14 +0000 (07:50 +0000)]
[Qt] Update test expectation after r97109.

Unreviewed gardening.

Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-10-11

* platform/qt/fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
* platform/qt/fast/css-generated-content/table-parts-before-and-after-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd missing copyright notice in DFG JIT files
commit-queue@webkit.org [Tue, 11 Oct 2011 07:40:22 +0000 (07:40 +0000)]
Add missing copyright notice in DFG JIT files
https://bugs.webkit.org/show_bug.cgi?id=69809

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-11
Reviewed by Gavin Barraclough.

* dfg/DFGJITCodeGenerator32_64.cpp:
* dfg/DFGJITCompiler32_64.cpp:
* dfg/DFGJITCompilerInlineMethods.h:
* dfg/DFGSpeculativeJIT32_64.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTools: Update Chromium accessibility support in DRT.
dmazzoni@google.com [Tue, 11 Oct 2011 07:28:56 +0000 (07:28 +0000)]
Tools: Update Chromium accessibility support in DRT.
https://bugs.webkit.org/show_bug.cgi?id=69676

Reviewed by Chris Fleizach.

Adds several missing properties and methods to enable more
tests to pass, and in particular adds support for notification
callbacks.

* DumpRenderTree/chromium/AccessibilityController.cpp:
(AccessibilityController::AccessibilityController):
(AccessibilityController::reset):
(AccessibilityController::getFocusedElement):
(AccessibilityController::shouldLogAccessibilityEvents):
(AccessibilityController::notificationReceived):
(AccessibilityController::logAccessibilityEventsCallback):
* DumpRenderTree/chromium/AccessibilityController.h:
* DumpRenderTree/chromium/AccessibilityUIElement.cpp:
(getHelpText):
(getStringValue):
(getOrientation):
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::getChildAtIndex):
(AccessibilityUIElement::isEqual):
(AccessibilityUIElement::notificationReceived):
(AccessibilityUIElement::roleGetterCallback):
(AccessibilityUIElement::titleGetterCallback):
(AccessibilityUIElement::descriptionGetterCallback):
(AccessibilityUIElement::helpTextGetterCallback):
(AccessibilityUIElement::stringValueGetterCallback):
(AccessibilityUIElement::xGetterCallback):
(AccessibilityUIElement::yGetterCallback):
(AccessibilityUIElement::widthGetterCallback):
(AccessibilityUIElement::heightGetterCallback):
(AccessibilityUIElement::intValueGetterCallback):
(AccessibilityUIElement::minValueGetterCallback):
(AccessibilityUIElement::maxValueGetterCallback):
(AccessibilityUIElement::childrenCountGetterCallback):
(AccessibilityUIElement::insertionPointLineNumberGetterCallback):
(AccessibilityUIElement::selectedTextRangeGetterCallback):
(AccessibilityUIElement::isEnabledGetterCallback):
(AccessibilityUIElement::isRequiredGetterCallback):
(AccessibilityUIElement::isFocusedGetterCallback):
(AccessibilityUIElement::isFocusableGetterCallback):
(AccessibilityUIElement::isSelectedGetterCallback):
(AccessibilityUIElement::isSelectableGetterCallback):
(AccessibilityUIElement::isMultiSelectableGetterCallback):
(AccessibilityUIElement::isExpandedGetterCallback):
(AccessibilityUIElement::isCheckedGetterCallback):
(AccessibilityUIElement::isVisibleGetterCallback):
(AccessibilityUIElement::isOffScreenGetterCallback):
(AccessibilityUIElement::isCollapsedGetterCallback):
(AccessibilityUIElement::hasPopupGetterCallback):
(AccessibilityUIElement::isValidGetterCallback):
(AccessibilityUIElement::orientationGetterCallback):
(AccessibilityUIElement::showMenuCallback):
(AccessibilityUIElement::pressCallback):
(AccessibilityUIElement::isEqualCallback):
(AccessibilityUIElement::addNotificationListenerCallback):
(AccessibilityUIElement::removeNotificationListenerCallback):
(AccessibilityUIElement::takeFocusCallback):
(AccessibilityUIElement::fallbackCallback):
(RootAccessibilityUIElement::getChildAtIndex):
(AccessibilityUIElementList::getOrCreate):
* DumpRenderTree/chromium/AccessibilityUIElement.h:
* DumpRenderTree/chromium/CppVariant.cpp:
(CppVariant::invokeDefault):
* DumpRenderTree/chromium/CppVariant.h:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::reset):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::postAccessibilityNotification):

LayoutTests: Enable accessibility tests on chromium and update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=69676

Reviewed by Chris Fleizach.

* platform/chromium/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Added.
* platform/chromium/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added.
* platform/chromium/accessibility/div-within-anchors-causes-crash-expected.txt: Added.
* platform/chromium/accessibility/platform-name-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate test results.
abarth@webkit.org [Tue, 11 Oct 2011 07:00:13 +0000 (07:00 +0000)]
Update test results.

* bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::V8TestInterface::existingWrapper):
(WebCore::V8TestInterface::wrap):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::V8TestMediaQueryListListener::existingWrapper):
(WebCore::V8TestMediaQueryListListener::wrap):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter):
(WebCore::TestObjInternal::cachedAttribute1AttrGetter):
(WebCore::TestObjInternal::cachedAttribute2AttrGetter):
* bindings/scripts/test/V8/V8TestObj.h:
(WebCore::V8TestObj::existingWrapper):
(WebCore::V8TestObj::wrap):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::V8TestSerializedScriptValueInterface::existingWrapper):
(WebCore::V8TestSerializedScriptValueInterface::wrap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Fix expectations from r97120. (again)
simonjam@chromium.org [Tue, 11 Oct 2011 05:33:44 +0000 (05:33 +0000)]
[Chromium] Fix expectations from r97120. (again)

Unreviewed.

* platform/chromium-linux/editing/pasteboard/smart-paste-008-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoStyle not updated on text fragment in :first-letter
inferno@chromium.org [Tue, 11 Oct 2011 05:08:13 +0000 (05:08 +0000)]
Style not updated on text fragment in :first-letter
nested in :before table.
https://bugs.webkit.org/show_bug.cgi?id=69540

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/css-generated-content/first-letter-in-nested-before-table.html

* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::updateBeforeAfterContent):

LayoutTests:

* fast/css-generated-content/first-letter-in-nested-before-table-expected.png: Added.
* fast/css-generated-content/first-letter-in-nested-before-table-expected.txt: Added.
* fast/css-generated-content/first-letter-in-nested-before-table.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r97121.
tkent@chromium.org [Tue, 11 Oct 2011 04:57:27 +0000 (04:57 +0000)]
Unreviewed, rolling out r97121.
http://trac.webkit.org/changeset/97121
https://bugs.webkit.org/show_bug.cgi?id=69815

Many layout tests failed (Requested by tkent on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-10

* dom/SelectElement.cpp:
(WebCore::SelectElementData::SelectElementData):
(WebCore::SelectElementData::checkListItems):
(WebCore::SelectElementData::listItems):
* dom/SelectElement.h:
(WebCore::SelectElementData::shouldRecalcListItems):
(WebCore::SelectElementData::setShouldRecalcListItems):
(WebCore::SelectElementData::rawListItems):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::HTMLSelectElement):
(WebCore::HTMLSelectElement::recalcListItems):
(WebCore::HTMLSelectElement::recalcListItemsIfNeeded):
(WebCore::HTMLSelectElement::nextSelectableListIndex):
(WebCore::HTMLSelectElement::previousSelectableListIndex):
(WebCore::HTMLSelectElement::firstSelectableListIndex):
(WebCore::HTMLSelectElement::lastSelectableListIndex):
(WebCore::HTMLSelectElement::nextSelectableListIndexPageAway):
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::setRecalcListItems):
(WebCore::HTMLSelectElement::selectedIndex):
(WebCore::HTMLSelectElement::setSelectedIndexInternal):
(WebCore::HTMLSelectElement::optionToListIndex):
(WebCore::HTMLSelectElement::listToOptionIndex):
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
(WebCore::HTMLSelectElement::saveFormControlState):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
(WebCore::HTMLSelectElement::lastSelectedListIndex):
(WebCore::HTMLSelectElement::typeAheadFind):
(WebCore::HTMLSelectElement::insertedIntoTree):
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
(WebCore::HTMLSelectElement::length):
* html/HTMLSelectElement.h:
(WebCore::HTMLSelectElement::listItems):
* html/HTMLSelectElementWin.cpp:
(WebCore::HTMLSelectElement::platformHandleKeydownEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Fix expectations from r97120.
simonjam@chromium.org [Tue, 11 Oct 2011 04:55:43 +0000 (04:55 +0000)]
[Chromium] Fix expectations from r97120.

Unreviewed.

* platform/chromium-cg-mac-leopard/editing/pasteboard/smart-paste-008-expected.png:
* platform/chromium-cg-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png:
* platform/chromium-cg-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.txt: Removed.
* platform/chromium-linux/editing/pasteboard/smart-paste-008-expected.png:
* platform/chromium-mac-leopard/editing/pasteboard/smart-paste-008-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png:
* platform/chromium-win/editing/pasteboard/smart-paste-008-expected.png:
* platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt: Copied from LayoutTests/platform/chromium/editing/pasteboard/smart-paste-008-expected.txt.
* platform/chromium/editing/pasteboard/smart-paste-008-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove m_listItems and m_recalcListItems from SelectElementData to HTMLSelectElement
tkent@chromium.org [Tue, 11 Oct 2011 04:16:59 +0000 (04:16 +0000)]
Move m_listItems and m_recalcListItems from SelectElementData to HTMLSelectElement
https://bugs.webkit.org/show_bug.cgi?id=69812

Reviewed by Ryosuke Niwa.

Move SelectElementData::m_recalcListItems,
SelectElementData::m_listItems, and related functions of
SelectElementData class to HTMLSelectElement.

Non-const listItems() was removed because it is used only in
recalcListItemsInternal() and it can access m_listItems diretly.

Static recalcListItems() is changed to non-static, and renamed to
recalcListItemsInternal() in order to avoid confusion with the
existing recalcListItems().

No new tests, just a refactoring.

* dom/SelectElement.cpp:
Move checkListItems() and listItems() to HTMLSelectElement.
(WebCore::SelectElementData::SelectElementData):
Remove Initialization of m_recalcListItems.
* dom/SelectElement.h:
Move m_recalcListItems, m_listItems, and related functions to HTMLSelectElement.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::HTMLSelectElement):
Initializes m_recalcListItems.
(WebCore::HTMLSelectElement::recalcListItems):
Rename the static recalcListItems() to recalcListItemsInternal().
(WebCore::HTMLSelectElement::recalcListItemsIfNeeded):
Use m_recalcListItems directly.
(WebCore::HTMLSelectElement::nextSelectableListIndex):
Update a listItems() callsite.
(WebCore::HTMLSelectElement::previousSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::firstSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::lastSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::nextSelectableListIndexPageAway): ditto.
(WebCore::HTMLSelectElement::saveLastSelection): ditto.
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): ditto.
(WebCore::HTMLSelectElement::updateListBoxSelection): ditto.
(WebCore::HTMLSelectElement::listBoxOnChange): ditto.
(WebCore::HTMLSelectElement::checkListItems):
Moved from SelectElementData.
(WebCore::HTMLSelectElement::listItems): ditto.
(WebCore::HTMLSelectElement::setRecalcListItems):
Use m_recalcListItems directly.
(WebCore::HTMLSelectElement::recalcListItemsInternal):
- Make this non-static.
- Renamed from recalcListItems() to avoid confilct with another recalcListItems().
- Use m_recalcListItems and m_listItems directly.
(WebCore::HTMLSelectElement::selectedIndex):
Update a listItems() callsite.
(WebCore::HTMLSelectElement::setSelectedIndexInternal): ditto.
(WebCore::HTMLSelectElement::optionToListIndex): ditto.
(WebCore::HTMLSelectElement::listToOptionIndex): ditto.
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation): ditto.
(WebCore::HTMLSelectElement::saveFormControlState):
Update callsites of listItems() and recalcListItems().
(WebCore::HTMLSelectElement::restoreFormControlState):
Update a listItems() callsite.
(WebCore::HTMLSelectElement::appendFormData): ditto.
(WebCore::HTMLSelectElement::reset): ditto.
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto.
(WebCore::HTMLSelectElement::updateSelectedState): ditto.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
(WebCore::HTMLSelectElement::lastSelectedListIndex): ditto.
(WebCore::HTMLSelectElement::typeAheadFind): ditto.
(WebCore::HTMLSelectElement::insertedIntoTree):
Update a recalcListItems() callsite.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
Update a listItems() callsite.
(WebCore::HTMLSelectElement::length): ditto.
* html/HTMLSelectElement.h:
Move m_recalcListItems, m_listItems, and related functions from SelectElementData.
* html/HTMLSelectElementWin.cpp:
(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
Update a listItems() callsite.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Rebaselines for r97102 and r97114. Pass 2 more tests.
simonjam@chromium.org [Tue, 11 Oct 2011 03:01:51 +0000 (03:01 +0000)]
[Chromium] Rebaselines for r97102 and r97114. Pass 2 more tests.

Unreviewed.

* platform/chromium-cg-mac-leopard/editing/pasteboard/smart-paste-008-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
* platform/chromium-linux/fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/pasteboard/smart-paste-008-expected.png.
* platform/chromium-win/editing/pasteboard/smart-paste-008-expected.png:
* platform/chromium-win/fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix r97115. smart-paste-008.html is in editing/paste, not in fast/events.
rniwa@webkit.org [Tue, 11 Oct 2011 01:15:09 +0000 (01:15 +0000)]
Fix r97115. smart-paste-008.html is in editing/paste, not in fast/events.

* platform/chromium/editing/pasteboard/smart-paste-008-expected.txt: Copied from
LayoutTests/platform/chromium/fast/events/smart-paste-008-expected.txt.
* platform/chromium/fast/events/smart-paste-008-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG JSVALUE64 spill/fill code should not box integers and doubles
fpizlo@apple.com [Tue, 11 Oct 2011 01:14:13 +0000 (01:14 +0000)]
DFG JSVALUE64 spill/fill code should not box integers and doubles
https://bugs.webkit.org/show_bug.cgi?id=69782

Reviewed by Oliver Hunt.

Added the notion of DataFormatInteger and DataFormatDouble to the spillFormat.
This required changing all of the places that spill registers (both silently
and not) and filling registers (both silently and on demand). It also required
changing OSR exit to recognize that a spilled value (DisplacedInRegisterFile)
may have the wrong format for the old JIT (unboxed int or double).

This is a slight win on Kraken (0.25%) and neutral elsewhere.

* dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::spill):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::spill):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueRecovery::displacedInRegisterFile):
(JSC::DFG::ValueRecovery::virtualRegister):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG JIT switch dfgConvert methods to use callOperation
barraclough@apple.com [Tue, 11 Oct 2011 01:01:30 +0000 (01:01 +0000)]
DFG JIT switch dfgConvert methods to use callOperation
https://bugs.webkit.org/show_bug.cgi?id=69806

Reviewed by Filip Pizlo.

* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
* dfg/DFGOperations.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAnother Chromium rebaseline after r97102.
rniwa@webkit.org [Tue, 11 Oct 2011 00:49:43 +0000 (00:49 +0000)]
Another Chromium rebaseline after r97102.

* platform/chromium-cg-mac-snowleopard/fast/events/ondragenter-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/events/ondragenter-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt: Removed.
* platform/chromium-win/fast/events/ondragenter-expected.txt: Removed.
* platform/chromium/fast/events/ondragenter-expected.txt: Copied from
LayoutTests/platform/chromium-win/fast/events/ondragenter-expected.txt.
* platform/chromium/fast/events/smart-paste-008-expected.txt: Copied from
LayoutTests/platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/10246137> Duplicate ::after content when both ::before and ::after...
mitz@apple.com [Tue, 11 Oct 2011 00:46:53 +0000 (00:46 +0000)]
<rdar://problem/10246137> Duplicate ::after content when both ::before and ::after are styled as table parts

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/css-generated-content/table-parts-before-and-after.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::addChild): Prevented table part childern after a ::before table from being merged
into it.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild): Prevented children after a ::before table section from being merged
into it.

LayoutTests:

* fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
* fast/css-generated-content/table-parts-before-and-after-expected.txt: Added.
* fast/css-generated-content/table-parts-before-and-after.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Most of the functions in CachedResourceClient are specific
japhet@chromium.org [Tue, 11 Oct 2011 00:41:18 +0000 (00:41 +0000)]
Source/WebCore: Most of the functions in CachedResourceClient are specific
to a single type of CachedResource. Move these callbacks into
separate subclasses of CachedResourceClient, and leave only
the common callback (notifyFinished) in the base class.
https://bugs.webkit.org/show_bug.cgi?id=69790

Reviewed by Adam Barth.

No new tests, no functionality changed intended.

* css/CSSFontFaceSource.h:
* css/CSSImageValue.h:
* css/CSSImportRule.h:
* dom/ProcessingInstruction.cpp:
* dom/ProcessingInstruction.h:
* html/HTMLLinkElement.h:
* html/ImageDocument.h:
* loader/ImageLoader.h:
* loader/cache/CachedCSSStyleSheet.cpp:
* loader/cache/CachedCSSStyleSheet.h:
* loader/cache/CachedFont.cpp:
* loader/cache/CachedFont.h:
* loader/cache/CachedImage.cpp:
* loader/cache/CachedImage.h:
* loader/cache/CachedResourceClient.h:
* loader/cache/CachedXSLStyleSheet.cpp:
* loader/cache/CachedXSLStyleSheet.h:
* platform/chromium/ClipboardChromium.h:
* platform/gtk/ClipboardGtk.h:
* platform/mac/ClipboardMac.h:
* platform/qt/ClipboardQt.h:
* platform/win/ClipboardWin.h:
* rendering/RenderObject.cpp:
* rendering/RenderObject.h:
* svg/SVGFEImageElement.h:
* svg/SVGFontFaceUriElement.h:
* xml/XSLImportRule.h:

Source/WebKit/mac: Use a CachedImageClient instead of CachedResourceClient
in WebHTMLView.
https://bugs.webkit.org/show_bug.cgi?id=69790

Reviewed by Adam Barth.

* WebView/WebHTMLView.mm:
(promisedDataClient):

Source/WebKit2: Use a CachedImageClient instead of CachedResourceClient
in WebDragClientMac.
https://bugs.webkit.org/show_bug.cgi?id=69790

Reviewed by Adam Barth.

* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(promisedDataClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium rebaseline after r97102.
rniwa@webkit.org [Tue, 11 Oct 2011 00:35:52 +0000 (00:35 +0000)]
Chromium rebaseline after r97102.

* platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt:
* platform/chromium-win/fast/events/ondragenter-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a typo pointed by Sam (Weinig).
rniwa@webkit.org [Tue, 11 Oct 2011 00:29:34 +0000 (00:29 +0000)]
Fix a typo pointed by Sam (Weinig).

* coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r97087.
commit-queue@webkit.org [Tue, 11 Oct 2011 00:18:47 +0000 (00:18 +0000)]
Unreviewed, rolling out r97087.
http://trac.webkit.org/changeset/97087
https://bugs.webkit.org/show_bug.cgi?id=69805

failing assert on debug builds (Requested by simonjam on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-10

Source/WebCore:

* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::replaceDocument):
(WebCore::DocumentWriter::begin):
* loader/DocumentWriter.h:

Source/WebKit/chromium:

* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::loadJavaScriptURL):

LayoutTests:

* http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url-expected.txt: Removed.
* http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[V8] CodeGeneratorV8 shouldn't hardcode the list of ActiveDOMObjects
abarth@webkit.org [Tue, 11 Oct 2011 00:11:14 +0000 (00:11 +0000)]
[V8] CodeGeneratorV8 shouldn't hardcode the list of ActiveDOMObjects
https://bugs.webkit.org/show_bug.cgi?id=69792

Reviewed by Nate Chapin.

We used to hard code the list of active DOM objects in the code
generator, but now we have an IDL attribute.  This patch switches the
code generator over to using the IDL attribute.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateImplementation):
(GetDomMapFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Pull tools/clang from upstream.
thakis@chromium.org [Tue, 11 Oct 2011 00:10:55 +0000 (00:10 +0000)]
[chromium] Pull tools/clang from upstream.
https://bugs.webkit.org/show_bug.cgi?id=69797

Reviewed by Adam Barth.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove some unused methods from the DFG JIT.
barraclough@apple.com [Tue, 11 Oct 2011 00:08:54 +0000 (00:08 +0000)]
Remove some unused methods from the DFG JIT.

Rubber stamped by Oliver Hunt

Thee methods were only used by the non-speculative JIT, and can be removed.

* dfg/DFGJITCodeGenerator.h:
* dfg/DFGJITCodeGenerator32_64.cpp:
* dfg/DFGJITCodeGenerator64.cpp:
    - removed:
        nonSpeculativeAdd
        nonSpeculativeArithSub
        nonSpeculativeArithMod
        nonSpeculativeCheckHasInstance
        nonSpeculativeInstanceOf
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
    - removed:
        operationArithMod
        operationInstanceOf
        operationThrowHasInstanceError

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSupport Distributed-CompileC as an action name in filter-build-webkit
adamk@chromium.org [Mon, 10 Oct 2011 23:59:37 +0000 (23:59 +0000)]
Support Distributed-CompileC as an action name in filter-build-webkit
https://bugs.webkit.org/show_bug.cgi?id=69783

Reviewed by Ojan Vafai.

* Scripts/filter-build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwitch most calls in DFGJITCodeGenerator to use callOperation.
barraclough@apple.com [Mon, 10 Oct 2011 23:56:58 +0000 (23:56 +0000)]
Switch most calls in DFGJITCodeGenerator to use callOperation.
https://bugs.webkit.org/show_bug.cgi?id=69802

Reviewed by Oliver Hunt.

Compares, add, mod are the easy cases.

* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeArithMod):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago3D transforms are flattened in WebKit2 snapshots
simon.fraser@apple.com [Mon, 10 Oct 2011 23:34:14 +0000 (23:34 +0000)]
3D transforms are flattened in WebKit2 snapshots
https://bugs.webkit.org/show_bug.cgi?id=68276

Reviewed by Anders Carlsson.

Use a snapshot of the window, rather than an image from the web process
for pixel testing in WebKitTestRunner. This correctly captures compositing
layers, so works for 3D transform tests.

* WebKitTestRunner/PlatformWebView.h: Add a windowSnapshotImage() method.
* WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::createCGContextFromImage): Add a param to optionally flip the image when drawing.
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Call windowSnapshotImage(), and if it returns an image,
use that instead of the image we get from the web process.
* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::windowSnapshotImage): Stub out the new method.
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::windowSnapshotImage): Ditto.
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::windowSnapshotImage): Ditto.
* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::windowSnapshotImage): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPluginDocumentParser uses incorrect syntax for background color
thakis@chromium.org [Mon, 10 Oct 2011 23:32:15 +0000 (23:32 +0000)]
PluginDocumentParser uses incorrect syntax for background color
https://bugs.webkit.org/show_bug.cgi?id=69694

Reviewed by Adam Barth.

Source/WebCore:

* html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):

LayoutTests:

* platform/mac/plugins/iframe-plugin-bgcolor-expected.txt: Added
* plugins/iframe-plugin-bgcolor.html: Added.
* plugins/iframe-plugin-bgcolor-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r96870): editing/pasteboard/smart-paste-008.html fails on non-Mac
rniwa@webkit.org [Mon, 10 Oct 2011 23:09:12 +0000 (23:09 +0000)]
REGRESSION(r96870): editing/pasteboard/smart-paste-008.html fails on non-Mac
https://bugs.webkit.org/show_bug.cgi?id=69587

Reviewed by Enrica Casucci.

Source/WebCore:

Insert a space at the correct offset when startNode is a text node.

* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace):

LayoutTests:

Unskip the test. Also rebaseline a test for a nbsp/sp change.

* platform/win/Skipped:
* platform/win/fast/events/ondragenter-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG: Switch GetById / PutById to use callOperation
barraclough@apple.com [Mon, 10 Oct 2011 22:54:05 +0000 (22:54 +0000)]
DFG: Switch GetById / PutById to use callOperation
https://bugs.webkit.org/show_bug.cgi?id=69795

Reviewed by Oliver Hunt.

Also make the take base as a cell, so 32_64 doesn't have to set up the cell tag.

* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGRepatch.cpp:
(JSC::DFG::appropriatePutByIdFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMediaControlSeekButtonElement should support seeking by changing the playback rate.
jer.noble@apple.com [Mon, 10 Oct 2011 22:42:28 +0000 (22:42 +0000)]
MediaControlSeekButtonElement should support seeking by changing the playback rate.
https://bugs.webkit.org/show_bug.cgi?id=63595

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/video-controls-scanning.html

Add a new property to HTMLMediaElement, supportsScanning(), which returns whether the
element is capable of playing its media at a rate greater than 1x. HTMLMediaElement passes
this call through to MediaPlayer and MediaPlayerPrivate. If this property returns true, the
built-in scanning controls can prefer to scan by changing the playbackRate, rather than by
repeatedly seeking small amounts of time. Unless overridden by specific media engines, this
property defaults to "false".

* html/HTMLMediaElement.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::supportsScanning): Added.  Calls through to MediaPlayer.
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::supportsScanning): Added. Calls through to MediaPlayerPrivate.
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::supportsScanning): Added. Defaults to "false".
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(WebCore::MediaPlayerPrivateAVFoundation::supportsScanning): Added.
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
(WebCore::MediaPlayerPrivateQTKit::supportsScanning): Added.

MediaControlSeekButtonElement now queries HTMLMediaElement::supportsScanning() to see if the
media element can implement its seeking behavior by scanning the media at greater than 1x
rate. Note whether the media was playing or paused when the seek begins, so that the playing
state can be restored when seeking ends.  Instead of capturing the mouse after mouseDown,
the seek button now responds to setActive() and begins seeking when the button is active
and stops when it becomes inactive.

Some behaviors have changed: clicking on the seek button no longer causes the media element
to pause; the media will end in the same state it began after the click.  cStepTime has been
eliminated; Clicking the seek button will always skip by at least cSeekTime, or 0.2s.

* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): Initialize new
    ivars.
(WebCore::MediaControlSeekButtonElement::defaultEventHandler): Mark mouseDown and mouseUp
    as defaultHandled, so as not to trigger drag start and drag end actions.
(WebCore::MediaControlSeekButtonElement::setActive): Call startTimer or stopTimer based
    on whether the button is active or not.
(WebCore::MediaControlSeekButtonElement::startTimer): Determine whether to scan or skip
    and start the seekTimer.
(WebCore::MediaControlSeekButtonElement::stopTimer): Restore the playing state and
    stop the timer.
(WebCore::MediaControlSeekButtonElement::seekTimerFired): Depending on whether we're
    scanning or skipping, jump ahead or change the playback rate.
* html/shadow/MediaControlElements.h:

LayoutTests:

* media/video-controls-scanning-expected.txt: Added.
* media/video-controls-scanning.html: Added.
* platform/mac/media/video-controls-scanning-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSIoN (r95399): Web process hangs when opening documents on Google Docs
fpizlo@apple.com [Mon, 10 Oct 2011 22:41:01 +0000 (22:41 +0000)]
REGRESSIoN (r95399): Web process hangs when opening documents on Google Docs
https://bugs.webkit.org/show_bug.cgi?id=69412

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JIT.h:

LayoutTests:

* fast/js/dfg-min-max-expected.txt: Added.
* fast/js/dfg-min-max.html: Added.
* fast/js/script-tests/dfg-min-max.js: Added.
(doMin):
(doMax):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97099 268f45cc-cd09-0410-ab3c-d52691b4dbfc